Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 )

Change subject: First implementation of the LLSK gtp SAPI
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c 
File src/osmo-hnodeb/gtp.c:

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c@126 
PS2, Line 126: }
             : 
             : 	osmo_fd_setup(&hnb->gtp.fd0, gsn->fd0, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0);
             : 	if ((rc = osmo_fd_register(&hnb->gtp.fd0)) < 0)
             : 		goto free_ret;
             : 
             : 	osmo_fd_setup(&hnb->gtp.fd1c, gsn->fd1c, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 1);
             : 	if ((rc = osmo_fd_register(&hnb->gtp.fd1c)) < 0)
             : 		goto free_ret;
             : 
             : 	osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 2);
             : 	if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0)
> After having a quick look at libgtp and TS 29 060 I decided to go for libgtp to avoid having to reim […]
* there are no sequence numbers in GTP-U
* there are no retransmits in GTP-U
* there is no GTPv0 in GTP-U on Iu or Iuh, or in fact anything that is 3G,4G or 5G.

So I don't really see what libgtp possibly can give you that you'd need.  It really is pushing one fixed-length header on the uplink side, and stripping it on the downlink side (after looking up the UE based on the TEID).

Please correct me if I'm wrong. It happens :)


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c@180 
PS2, Line 180: 		LOG
> Yes, pdp_t below uses "struct in_addr" in several fields, it seems only IPv4 is supported in the tra […]
one [small] more reason to not use libgtp.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366
Gerrit-Change-Number: 26503
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 13 Dec 2021 18:12:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211213/4c50a032/attachment.htm>