Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Dec 13 18:11:47 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 )

Change subject: Initial implementation of LowerLayer UD Socket
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c 
File src/osmo-hnodeb/llsk.c:

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c@108 
PS11, Line 108: HNB_PRIM_SAPI_IUH
> my point was that this should be reflected in the name of the constant. […]
I just picked something which was short to have something similar to GTP, AUDIO, etc.
TBH I'm fine with this naming (I agree though that it's a bit generic), since it's basically "all Iuh which is not specific to Audio or user plana PS data for GTP."
If you are not happy with current one, please provide the naming you'd like and I'll proceed to bulk change it in all places I find. Not sure if it's really worth it though.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d
Gerrit-Change-Number: 26357
Gerrit-PatchSet: 12
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 13 Dec 2021 18:11:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211213/0ecd5113/attachment.htm>


More information about the gerrit-log mailing list