Change in osmo-bts[master]: osmo-bts-trx: fix a memleak in trx_sched_set_lchan()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Dec 13 12:12:10 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26532 )

Change subject: osmo-bts-trx: fix a memleak in trx_sched_set_lchan()
......................................................................

osmo-bts-trx: fix a memleak in trx_sched_set_lchan()

An additional burst buffer is allocated in rx_data_fn() for Uplink
SACCH repetition, but unlike the main buffer it never gets free()d.

Change-Id: I93310e7aed91a49c0511e2ed30e000440617f95a
Fixes: I7e4cc33cc010866e41e3b594351a7f7bf93e08ac
Related: OS#4795, SYS#5114
---
M src/common/scheduler.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index bd33ce1..e854ce1 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -1109,6 +1109,10 @@
 			talloc_free(chan_state->ul_bursts);
 			chan_state->ul_bursts = NULL;
 		}
+		if (chan_state->ul_bursts_prev) {
+			talloc_free(chan_state->ul_bursts_prev);
+			chan_state->ul_bursts_prev = NULL;
+		}
 
 		if (active) {
 			/* Clean up everything */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26532
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I93310e7aed91a49c0511e2ed30e000440617f95a
Gerrit-Change-Number: 26532
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211213/da116ae6/attachment.htm>


More information about the gerrit-log mailing list