This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26527 ) Change subject: oml: fix copy-pasted comments in oml_rx_set_*_attr() ...................................................................... oml: fix copy-pasted comments in oml_rx_set_*_attr() Change-Id: Iaa0e630b28b2a86312c069e7e55dd8bc5743759a --- M src/common/oml.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/oml.c b/src/common/oml.c index 4e09008..c8819c9 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -735,7 +735,7 @@ return oml_fom_ack_nack(msg, NM_NACK_INCORR_STRUCT); } - /* merge existing BTS attributes with new attributes */ + /* merge existing TRX attributes with new attributes */ tp_merged = osmo_tlvp_copy(trx->mo.nm_attr, trx); osmo_tlvp_merge(tp_merged, &tp); @@ -746,7 +746,7 @@ return oml_fom_ack_nack(msg, -rc); } - /* Success: replace old BTS attributes with new */ + /* Success: replace old TRX attributes with new */ talloc_free(trx->mo.nm_attr); trx->mo.nm_attr = tp_merged; @@ -949,7 +949,7 @@ return oml_fom_ack_nack(msg, NM_NACK_SPEC_IMPL_NOTSUPP); } - /* merge existing BTS attributes with new attributes */ + /* merge existing CHAN attributes with new attributes */ tp_merged = osmo_tlvp_copy(ts->mo.nm_attr, ts->trx); osmo_tlvp_merge(tp_merged, &tp); @@ -962,7 +962,7 @@ return oml_fom_ack_nack(msg, -rc); } - /* Success: replace old BTS attributes with new */ + /* Success: replace old CHAN attributes with new */ talloc_free(ts->mo.nm_attr); ts->mo.nm_attr = tp_merged; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaa0e630b28b2a86312c069e7e55dd8bc5743759a Gerrit-Change-Number: 26527 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211213/5e19c139/attachment.htm>