Change in osmo-pcap[master]: Revert "configure.ac: don't depend on libosmogb."

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Dec 13 12:03:15 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26534 )

Change subject: Revert "configure.ac: don't depend on libosmogb."
......................................................................

Revert "configure.ac: don't depend on libosmogb."

gprs header files from libosmogb are needed for osmo-pcap. This was the
reason why it was added as dependency to configure.ac in
I9a8fa03cef1efc9fdaea65ee63ca9b3379993989.

  $ git grep "osmocom/gprs"
  src/osmo_client_core.c:#include <osmocom/gprs/gprs_bssgp.h>
  src/osmo_client_core.c:#include <osmocom/gprs/protocol/gsm_08_16.h>
  src/osmo_client_core.c:#include <osmocom/gprs/protocol/gsm_08_18.h>

The package is only still building for debian, because in debian
libosmocore is not split up, and for centos, because the rpm spec file
still lists the dependency.

This reverts commit 2c2eadcadf59ac42a02339f554c5daa48ee4f9fd.

Change-Id: Ic358956521230a2f6525533779c27417b2e86833
---
M configure.ac
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/configure.ac b/configure.ac
index 06c9dc2..fa9a3c8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -158,6 +158,8 @@
 
 dnl checks for libraries
 PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0)
+# libosmogb: needed for osmocom/gprs includes
+PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0)
 PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0)
 PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0)
 PKG_CHECK_MODULES(LIBZMQ, libzmq >= 3.2.2)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26534
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: Ic358956521230a2f6525533779c27417b2e86833
Gerrit-Change-Number: 26534
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211213/c8175b70/attachment.htm>


More information about the gerrit-log mailing list