Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Dec 13 11:42:06 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 )

Change subject: osmo-pcap-master: doesn't need libosmo-netif
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> > Patch Set 3:
> > 
> > > Patch Set 1:
> > > 
> > > your commitlog states remove libosmonetif, but the patch also adds libosmogb (which should not be required)?
> > 
> > according to configure.ac it is required, updated the commit message
> 
> then configure.ac is wrong, see:  https://gerrit.osmocom.org/c/osmo-pcap/+/26510
> 
> It doesn't make any sense... there is nothing NS/BSSGP inside a generic pcap capture+store system.

The dependency was added because of osmocom/gprs includes:
https://gerrit.osmocom.org/c/osmo-pcap/+/26266

Here's a patch to add it back to configure.ac:
https://gerrit.osmocom.org/c/osmo-pcap/+/26534


-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31
Gerrit-Change-Number: 26498
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Dec 2021 11:42:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211213/af9e9b67/attachment.htm>


More information about the gerrit-log mailing list