Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 )

Change subject: abis_nm: actively block BTSs with invalid configuration
......................................................................


Patch Set 7: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/abis_nm.c 
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/abis_nm.c@938 
PS7, Line 938: 	if (gsm_bts_check_cfg(bts) != 0) {
why is this still here?!


https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/bts_ipaccess_nanobts.c 
File src/osmo-bsc/bts_ipaccess_nanobts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/bts_ipaccess_nanobts.c@704 
PS7, Line 704: 		ipaccess_drop_oml(bts, "bad config");
You may need to use ipaccess_drop_oml_deferred() here. Check the description of that function on whether this is one of the cases.


https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/bts_ipaccess_nanobts.c@706 
PS7, Line 706: 			ipaccess_drop_rsl(trx, "bad config");
This is not needed, it's already done by ipaccess_drop_oml().



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e
Gerrit-Change-Number: 26197
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Dec 2021 12:22:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211209/57e41665/attachment.htm>