Change in osmo-ccid-firmware[master]: slot fsm: rearrange fsm cb events to make debugging easier

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 )

Change subject: slot fsm: rearrange fsm cb events to make debugging easier
......................................................................

slot fsm: rearrange fsm cb events to make debugging easier

..and so I can break on the nop.

Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b
---
M ccid_common/ccid_slot_fsm.c
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c
index 8dccfa5..5ef30a2 100644
--- a/ccid_common/ccid_slot_fsm.c
+++ b/ccid_common/ccid_slot_fsm.c
@@ -148,6 +148,10 @@
 	/* continues in iso_fsm_clot_user_cb once ATR is received */
 }
 
+#ifndef __NOP
+#define __NOP()
+#endif
+
 static void iso_fsm_clot_user_cb(struct osmo_fsm_inst *fi, int event, int cause, void *data)
 {
 	struct iso_fsm_slot *ss = iso7816_fsm_get_user_priv(fi);
@@ -159,14 +163,16 @@
 	case ISO7816_E_HW_ERR_IND:
 		card_uart_ctrl(ss->cuart, CUART_CTL_NO_RXTX, true);
 		break;
-	case ISO7816_E_ATR_DONE_IND:
 	case ISO7816_E_ATR_ERR_IND:
-	case ISO7816_E_TPDU_DONE_IND:
 	case ISO7816_E_TPDU_FAILED_IND:
-	case ISO7816_E_PPS_DONE_IND:
 	case ISO7816_E_PPS_FAILED_IND:
 	case ISO7816_E_PPS_UNSUPPORTED_IND:
 	case ISO7816_E_WTIME_EXP:
+		__NOP();
+		/* no break */
+	case ISO7816_E_ATR_DONE_IND:
+	case ISO7816_E_TPDU_DONE_IND:
+	case ISO7816_E_PPS_DONE_IND:
 		cs->event_data = data;
 #ifdef OCTSIMFWBUILD
 		asm volatile("dmb st": : :"memory");

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b
Gerrit-Change-Number: 26399
Gerrit-PatchSet: 7
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211208/a20d8395/attachment.htm>