Change in osmo-remsim[master]: rspro_client_fsm: Differentiate different log levels

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Dec 8 20:30:03 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26469 )

Change subject: rspro_client_fsm: Differentiate different log levels
......................................................................

rspro_client_fsm: Differentiate different log levels

Raw Rx/Tx of messages should be LOGL_DEBUG, while connection
establishment/loss should be something like LOGL_NOTICE.

Change-Id: I1bc6d491a8a748cbd729cbdeede60d32bd760a15
---
M src/rspro_client_fsm.c
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c
index 36a3016..5718015 100644
--- a/src/rspro_client_fsm.c
+++ b/src/rspro_client_fsm.c
@@ -79,7 +79,7 @@
 
 static int _server_conn_send_rspro(struct rspro_server_conn *srvc, RsproPDU_t *rspro)
 {
-	LOGPFSM(srvc->fi, "Tx RSPRO %s\n", rspro_msgt_name(rspro));
+	LOGPFSML(srvc->fi, LOGL_DEBUG, "Tx RSPRO %s\n", rspro_msgt_name(rspro));
 	return ipa_client_conn_send_rspro(srvc->conn, rspro);
 }
 
@@ -124,7 +124,8 @@
 {
 	struct rspro_server_conn *srvc = conn->data;
 
-	LOGPFSM(srvc->fi, "RSPRO link to %s:%d %s\n", conn->addr, conn->port, up ? "UP" : "DOWN");
+	LOGPFSML(srvc->fi, LOGL_NOTICE, "RSPRO link to %s:%d %s\n",
+		 conn->addr, conn->port, up ? "UP" : "DOWN");
 
 	osmo_fsm_inst_dispatch(srvc->fi, up ? SRVC_E_TCP_UP: SRVC_E_TCP_DOWN, 0);
 }
@@ -162,7 +163,7 @@
 		msg->l2h = &he->data[0];
 		switch (he->proto) {
 		case IPAC_PROTO_EXT_RSPRO:
-			LOGPFSM(srvc->fi, "Received RSPRO %s\n", msgb_hexdump(msg));
+			LOGPFSML(srvc->fi, LOGL_DEBUG, "Received RSPRO %s\n", msgb_hexdump(msg));
 			pdu = rspro_dec_msg(msg);
 			if (!pdu) {
 				rc = -EIO;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26469
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I1bc6d491a8a748cbd729cbdeede60d32bd760a15
Gerrit-Change-Number: 26469
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211208/f17213d3/attachment.htm>


More information about the gerrit-log mailing list