Change in osmo-remsim[master]: Add separate log category for RSPRO protocol

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Dec 8 20:17:25 UTC 2021


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26473 )


Change subject: Add separate log category for RSPRO protocol
......................................................................

Add separate log category for RSPRO protocol

Change-Id: I2e158f5181a24ae2256aae12d26865c4907eabad
---
M src/debug.c
M src/debug.h
M src/rspro_client_fsm.c
3 files changed, 10 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/73/26473/1

diff --git a/src/debug.c b/src/debug.c
index b98ca08..a538697 100644
--- a/src/debug.c
+++ b/src/debug.c
@@ -36,6 +36,11 @@
 		.loglevel = LOGL_INFO,
 		.enabled = 1,
 	},
+	[DRSPRO] = {
+		.name = "DRSPRO",
+		.loglevel = LOGL_INFO,
+		.enabled = 1,
+	},
 };
 
 const struct log_info log_info = {
diff --git a/src/debug.h b/src/debug.h
index 2a3e5a3..51331f4 100644
--- a/src/debug.h
+++ b/src/debug.h
@@ -4,6 +4,7 @@
 enum {
 	DMAIN,
 	DST2,
+	DRSPRO,
 };
 
 extern const struct log_info log_info;
diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c
index 5718015..bfd7ebd 100644
--- a/src/rspro_client_fsm.c
+++ b/src/rspro_client_fsm.c
@@ -68,8 +68,8 @@
 {
 	struct msgb *msg = rspro_enc_msg(rspro);
 	if (!msg) {
-		LOGP(DMAIN, LOGL_ERROR, "Error encoding RSPRO: %s\n", rspro_msgt_name(rspro));
-		osmo_log_backtrace(DMAIN, LOGL_ERROR);
+		LOGP(DRSPRO, LOGL_ERROR, "Error encoding RSPRO: %s\n", rspro_msgt_name(rspro));
+		osmo_log_backtrace(DRSPRO, LOGL_ERROR);
 		ASN_STRUCT_FREE(asn_DEF_RsproPDU, rspro);
 		return -1;
 	}
@@ -87,7 +87,7 @@
 {
 	if (!rspro) {
 		LOGPFSML(srvc->fi, LOGL_ERROR, "Attempt to transmit NULL\n");
-		osmo_log_backtrace(DMAIN, LOGL_ERROR);
+		osmo_log_backtrace(DRSPRO, LOGL_ERROR);
 		return -EINVAL;
 	}
 	if (osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_RSPRO_TX, rspro) < 0) {
@@ -432,7 +432,7 @@
 	.allstate_event_mask = S(SRVC_E_ESTABLISH) | S(SRVC_E_DISCONNECT),
 	.allstate_action = srvc_allstate_action,
 	.timer_cb = server_conn_fsm_timer_cb,
-	.log_subsys = DMAIN,
+	.log_subsys = DRSPRO,
 	.event_names = server_conn_fsm_event_names,
 };
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26473
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I2e158f5181a24ae2256aae12d26865c4907eabad
Gerrit-Change-Number: 26473
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211208/c487738f/attachment.htm>


More information about the gerrit-log mailing list