This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26466 ) Change subject: bankd_pcsc: Improve logging in non-error case ...................................................................... bankd_pcsc: Improve logging in non-error case Before this commit, the PCSC operation (e.g. SCardStatus) is only printed in the error case, but not in the debug case. Let's fix that. [000 CONN_CLIENT_MAPPED_CARD] bankd_pcsc.c:196 : OK will become [000 CONN_CLIENT_MAPPED_CARD] bankd_pcsc.c:196 SCardTransmit: OK Change-Id: I3c77655c5d1f76be778cb8873d8acf1343c87b05 --- M src/bankd/bankd_pcsc.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index e0b349c..5bc7bb8 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -178,7 +178,7 @@ LOGW_PCSC_ERROR(w, rv, text); \ goto end; \ } else { \ - LOGW((w), ": OK\n"); \ + LOGW((w), text ": OK\n"); \ } static int pcsc_get_atr(struct bankd_worker *worker) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3c77655c5d1f76be778cb8873d8acf1343c87b05 Gerrit-Change-Number: 26466 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211208/b7bb665d/attachment.htm>