Change in osmo-ci[master]: lint: checkpatch_osmo: ignore VOLATILE

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Wed Dec 8 10:41:00 UTC 2021


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26464 )


Change subject: lint: checkpatch_osmo: ignore VOLATILE
......................................................................

lint: checkpatch_osmo: ignore VOLATILE

The warning about potentially using volatile wrong is not useful for us,
it makes sense to use it in embedded projects.

Related: OS#5087
Related: https://www.kernel.org/doc/html/latest/process/volatile-considered-harmful.html
Related: https://gerrit.osmocom.org/c/simtrace2/+/26463
Change-Id: Ie81db479c66749531ed1c81cf076ce248aa22f69
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/64/26464/1

diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh
index 126a8b4..ae66e71 100755
--- a/lint/checkpatch/checkpatch_osmo.sh
+++ b/lint/checkpatch/checkpatch_osmo.sh
@@ -73,6 +73,7 @@
 # * UNNECESSARY_BREAK: not followed (see https://gerrit.osmocom.org/c/libosmo-netif/+/26429)
 # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345)
 # * UNSPECIFIED_INT: not followed (doesn't seem useful for us)
+# * VOLATILE: using volatile makes sense in embedded projects so this warning is not useful for us
 
 cd "$PROJECT_DIR"
 
@@ -109,6 +110,7 @@
 	--ignore UNNECESSARY_BREAK \
 	--ignore UNNECESSARY_INT \
 	--ignore UNSPECIFIED_INT \
+	--ignore VOLATILE \
 	--max-line-length 120 \
 	--no-signoff \
 	--no-tree \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26464
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ie81db479c66749531ed1c81cf076ce248aa22f69
Gerrit-Change-Number: 26464
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211208/655c86d1/attachment.htm>


More information about the gerrit-log mailing list