This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Hoernchen gerrit-no-reply at lists.osmocom.orgHoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile File firmware/Makefile: https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile@245 PS2, Line 245: ap > I'm not quite sure the usb_strings_generated. […] Done https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile@288 PS2, Line 288: m > patching the file in-line IMHO doesn't work very well with how make manages dependencies. […] At least as far as I am aware every simtrace firmware make always rebuilds everything from scratch anyway... https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/apps/blupdate/main.c File firmware/apps/blupdate/main.c: https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/apps/blupdate/main.c@98 PS2, Line 98: SCB->AIRCR = ((0x5FA << SCB_AIRCR_VECTKEY_Pos) | (SCB->AIRCR & SCB_AIRCR_PRIGROUP_Msk) | > can we just tunr NVIC_SystemReset into a #define? or use __attribute__((always_inline)) ? I didn't want to mess with the asf code used everywhere else, and gcc warns if you use always_inline because "always_inline function might not be inlinable" (?!), so I didn't bother and left it like this, because it only affects two special occurences anyway... -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 08 Dec 2021 09:43:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211208/1f66d57c/attachment.htm>