Change in libosmocore[master]: select: gather statistics for TCP connections

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 )

Change subject: select: gather statistics for TCP connections
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/select.c 
File src/select.c:

https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/select.c@173 
PS1, Line 173: 	/* Ensure that priv_stats is set to NULL. */
I find this comment useless.


https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.h 
File src/stats_tcp.h:

https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.h@5 
PS1, Line 5: void stats_tcp_poll(struct llist_head *osmo_fds);
A header file just for one function? Are you planning to add more stuff here? If not, let's rather declare it in select.c.


https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.c 
File src/stats_tcp.c:

https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.c@64 
PS1, Line 64: const struct osmo_stat_item_desc stats_tcp_item_desc[] = {
static?


https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.c@74 
PS1, Line 74: const struct osmo_stat_item_group_desc stats_tcp_desc = {
static?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d
Gerrit-Change-Number: 26454
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Dec 2021 16:39:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211206/03d33e0d/attachment.htm>