This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 ) Change subject: bsc: fix TC_cm_serv_rej ...................................................................... Patch Set 1: Code-Review-2 I agree with Harald here, it would be good to find the actual problem. To me it looks like the race condition is happening in RSL_Emulation.f_chan_est(), which is called by MSC_ConnectionHandler.f_create_chan_and_exp(). In this function we basically send a ChanRqd, wait for an Immediate Assignment, and then send the ESTablish INDication. The last message is important because it triggers the SCCP connection establishment towards the virtual MSC. Most likely, the Service Reject message gets enqueued *before* the actual SCCP connection is established. I compared the following test suite logs line-by-line: [PASS] https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bsc-test/1580/artifact/logs/bsc-tester/BSC_Tests.TC_cm_serv_rej.merged [FAIL] https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bsc-test/1581/artifact/logs/bsc-tester/BSC_Tests.TC_cm_serv_rej.merged and indeed, during the successful run we first get a 'SCCPasp_Types.ASP_SCCP_N_CONNECT_ind', and then enqueue a 'BSSAP_Types.PDU_BSSAP' with the reject. The logs of the failed run indicate that we get a 'BSSAP_Types.PDU_BSSAP' before the 'SCCPasp_Types.ASP_SCCP_N_CONNECT_ind'. My proposal is to modify f_create_chan_and_exp() in a way that it would block until the SCCP connection is established. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iad30319a7e9e726d006c9934ed2eb48f886811a9 Gerrit-Change-Number: 26433 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sat, 04 Dec 2021 16:31:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211204/29958411/attachment.htm>