This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26394 ) Change subject: logging: make LIBOSMOCORE_NO_LOGGING work as expected ...................................................................... Patch Set 1: > Patch Set 1: > > No, this was always about getting rid of logging related calls and especially the infinite log level checks, I just got the first patch wrong. The fsm will try to log every single event in _osmo_fsm_inst_dispatch using LOGPFSMSRC for example, which adds up if we have a lot of events... like for every single byte.. then the naming/condition is wrong. "DEBUG" should only control whether debug logging is compiled in. If logging shall be globlaly disalbe then there should be a macro that implies this in its name, such as "#define DISABLE_LOGGING" or LOGGING_DISABLED or NO_LOGGING or whatever that makes its purpose clear. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4c78abe5f198139f96ffa289998855be2477585 Gerrit-Change-Number: 26394 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sat, 04 Dec 2021 10:33:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211204/1d4c8ee1/attachment.htm>