Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Dec 4 10:14:33 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26426 )

Change subject: Introduce osmo_prim_srv APIs
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmo-netif/+/26426/5/src/prim.c 
File src/prim.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/26426/5/src/prim.c@107 
PS5, Line 107: 1600
I think we should probably make that somehow user-configurable.  I could very well imagine primitives of a larger size at some point.  Maybe just make it a struct member of the prim_srv_link?

Also, it may make sense to use msgb_alloc_c using the stream_srv as context, this way it is easier to track from which particular server a memory leak originates.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044
Gerrit-Change-Number: 26426
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 04 Dec 2021 10:14:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211204/f213e536/attachment.htm>


More information about the gerrit-log mailing list