Change in osmo-msc[master]: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Dec 2 12:45:48 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 )

Change subject: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2()
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-msc/+/26391/3//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-msc/+/26391/3//COMMIT_MSG@7 
PS3, Line 7: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2()
I think the commit message can be improved.
I don't really understand the first line. Not even sure whether passwd is a noun or verb, the sentence makes no sense to me.

"not pass it to it." <-- same here.


https://gerrit.osmocom.org/c/osmo-msc/+/26391/3//COMMIT_MSG@10 
PS3, Line 10: The reason behind is that UEA0 can't passed in the TLV of a SecurityCommand and is implicit
This sentence is also written in a really strange way.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e
Gerrit-Change-Number: 26391
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Dec 2021 12:45:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211202/b191811d/attachment.htm>


More information about the gerrit-log mailing list