Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Dec 2 01:54:35 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 )

Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

So we have 1+1 here (by Harald and Neels). Given that Pau revoked his vote and changed to neutral, I am adding CR+2 and going to merge this patch soon. If I missed something, let me know.

https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c 
File src/libmsc/ran_msg_iu.c:

https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c@380 
PS2, Line 380: 			       | (1 << OSMO_UTRAN_UIA2);
> (would prefer the comment on its own line, and replace "it" with something explanatory like "make th […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a
Gerrit-Change-Number: 26410
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Dec 2021 01:54:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211202/73ff0a9e/attachment.htm>


More information about the gerrit-log mailing list