This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26430 ) Change subject: lint: checkpatch_osmo: ignore UNNECESSARY_BREAK ...................................................................... lint: checkpatch_osmo: ignore UNNECESSARY_BREAK Not necessarily followed in Osmocom code, as Daniel wrote: > The lint complains about this break, I don't agree with it though. > Without we're one (or two) refactors away from an unintended > fall-through Related: OS#5087 Change-Id: I3f106510953b0b1bf70c28ceb55a431c5c03854e --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index ec9384c..126a8b4 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -70,6 +70,7 @@ # * SPLIT_STRING: we do split long messages over multiple lines # * STRING_FRAGMENTS: sometimes used intentionally to improve readability # * TRAILING_STATEMENTS: not followed, e.g. 'while (osmo_select_main_ctx(1) > 0);' is put in one line +# * UNNECESSARY_BREAK: not followed (see https://gerrit.osmocom.org/c/libosmo-netif/+/26429) # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) # * UNSPECIFIED_INT: not followed (doesn't seem useful for us) @@ -105,6 +106,7 @@ --ignore SPLIT_STRING \ --ignore STRING_FRAGMENTS \ --ignore TRAILING_STATEMENTS \ + --ignore UNNECESSARY_BREAK \ --ignore UNNECESSARY_INT \ --ignore UNSPECIFIED_INT \ --max-line-length 120 \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3f106510953b0b1bf70c28ceb55a431c5c03854e Gerrit-Change-Number: 26430 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211201/2b3799d1/attachment.htm>