From gerrit-no-reply at lists.osmocom.org Wed Dec 1 08:54:56 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 1 Dec 2021 08:54:56 +0000 Subject: Change in docker-playground[master]: ttcn3-{bts, bsc, msc, hlr}-test: set OSMO_SUT_{HOST, PORT} In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26408 ) Change subject: ttcn3-{bts,bsc,msc,hlr}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Besides $SUBNET, LGTM! https://gerrit.osmocom.org/c/docker-playground/+/26408/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/docker-playground/+/26408/2//COMMIT_MSG at 15 PS2, Line 15: Related: [1] I1b03b17426d8760c55976e3b78ca2f3af248c055 (mention osmo-ttcn3-hacks here, since it's a different repo?) https://gerrit.osmocom.org/c/docker-playground/+/26408/2/ttcn3-bsc-test/jenkins.sh File ttcn3-bsc-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/26408/2/ttcn3-bsc-test/jenkins.sh at 65 PS2, Line 65: 2 $SUBNET, same below in the other scripts -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Gerrit-Change-Number: 26408 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 01 Dec 2021 08:54:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 08:55:12 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 1 Dec 2021 08:55:12 +0000 Subject: Change in docker-playground[master]: debian-stretch-titan/Dockerfile: install osmo-python-tests In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26427 ) Change subject: debian-stretch-titan/Dockerfile: install osmo-python-tests ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ida8e08e7fe4f171f934a2d4eef4568da7c398f5c Gerrit-Change-Number: 26427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 01 Dec 2021 08:55:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 08:55:17 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 1 Dec 2021 08:55:17 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 ) Change subject: ttcn3-tcpdump-stop.sh: order the SUT to print talloc report ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26407 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b03b17426d8760c55976e3b78ca2f3af248c055 Gerrit-Change-Number: 26407 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 01 Dec 2021 08:55:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 09:05:43 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 1 Dec 2021 09:05:43 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore UNNECESSARY_BREAK References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26430 ) Change subject: lint: checkpatch_osmo: ignore UNNECESSARY_BREAK ...................................................................... lint: checkpatch_osmo: ignore UNNECESSARY_BREAK Not necessarily followed in Osmocom code, as Daniel wrote: > The lint complains about this break, I don't agree with it though. > Without we're one (or two) refactors away from an unintended > fall-through Related: OS#5087 Change-Id: I3f106510953b0b1bf70c28ceb55a431c5c03854e --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/30/26430/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index ec9384c..126a8b4 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -70,6 +70,7 @@ # * SPLIT_STRING: we do split long messages over multiple lines # * STRING_FRAGMENTS: sometimes used intentionally to improve readability # * TRAILING_STATEMENTS: not followed, e.g. 'while (osmo_select_main_ctx(1) > 0);' is put in one line +# * UNNECESSARY_BREAK: not followed (see https://gerrit.osmocom.org/c/libosmo-netif/+/26429) # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) # * UNSPECIFIED_INT: not followed (doesn't seem useful for us) @@ -105,6 +106,7 @@ --ignore SPLIT_STRING \ --ignore STRING_FRAGMENTS \ --ignore TRAILING_STATEMENTS \ + --ignore UNNECESSARY_BREAK \ --ignore UNNECESSARY_INT \ --ignore UNSPECIFIED_INT \ --max-line-length 120 \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3f106510953b0b1bf70c28ceb55a431c5c03854e Gerrit-Change-Number: 26430 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 09:08:50 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 1 Dec 2021 09:08:50 +0000 Subject: Change in libosmo-netif[master]: stream: Factor out sctp_recvmg long code chunk In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26429 ) Change subject: stream: Factor out sctp_recvmg long code chunk ...................................................................... Patch Set 1: (1 comment) agreed with recvmg -> recvmsg, otherwise looks good https://gerrit.osmocom.org/c/libosmo-netif/+/26429/1/src/stream.c File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26429/1/src/stream.c at 1333 PS1, Line 1333: break; > The lint complains about this break, I don't agree with it though. [?] https://gerrit.osmocom.org/c/osmo-ci/+/26430 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3e0f4407e00a2dac9ee885fe1cc1cb4b463898a Gerrit-Change-Number: 26429 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-CC: osmith Gerrit-Comment-Date: Wed, 01 Dec 2021 09:08:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 10:38:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 1 Dec 2021 10:38:13 +0000 Subject: Change in docker-playground[master]: redmine: process changelogs every 10 minutes In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26428 ) Change subject: redmine: process changelogs every 10 minutes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2a65fd6be22ae541a93c08c71cf286e4b5ad370f Gerrit-Change-Number: 26428 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 01 Dec 2021 10:38:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 10:38:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 1 Dec 2021 10:38:15 +0000 Subject: Change in docker-playground[master]: redmine: process changelogs every 10 minutes In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26428 ) Change subject: redmine: process changelogs every 10 minutes ...................................................................... redmine: process changelogs every 10 minutes Wrap the original entrypoint script with a custom one that also runs a loop in the background, which periodically lets redmine fetch git repositories. When repositories are fetched, redmine interpretes "closes" etc. in commit messages to mark issues as resolved. Closes: OS#5331 Change-Id: I2a65fd6be22ae541a93c08c71cf286e4b5ad370f --- M redmine/Dockerfile A redmine/docker-entrypoint-osmo.sh 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: osmith: Verified laforge: Looks good to me, approved diff --git a/redmine/Dockerfile b/redmine/Dockerfile index 2d8eb11..fc1ba89 100644 --- a/redmine/Dockerfile +++ b/redmine/Dockerfile @@ -17,3 +17,7 @@ ADD commitlog-references-oshash.diff /tmp/commitlog-references-oshash.diff RUN cd /usr/src/redmine && patch -p1 < /tmp/commitlog-references-oshash.diff + +ADD docker-entrypoint-osmo.sh / +ENTRYPOINT ["/docker-entrypoint-osmo.sh"] +CMD ["passenger", "start"] diff --git a/redmine/docker-entrypoint-osmo.sh b/redmine/docker-entrypoint-osmo.sh new file mode 100755 index 0000000..aff8183 --- /dev/null +++ b/redmine/docker-entrypoint-osmo.sh @@ -0,0 +1,17 @@ +#!/bin/sh + +# Periodically fetch git repositories +# https://www.redmine.org/projects/redmine/wiki/RedmineRepositories +# Double fork, so it still runs after the exec below +(while :; do + sleep 10m + echo + echo "=== Fetching git repositories (OS#5331) ===" + su redmine -c 'rails runner "Repository.fetch_changesets" -e production' + echo +done &) & + +# Run the original docker-entrypoint.sh script. Exec is important, so "tini" +# inside the original script becomes pid 1 to clean up zombies from redmine. +# https://github.com/docker-library/redmine/ +exec /docker-entrypoint.sh "$@" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I2a65fd6be22ae541a93c08c71cf286e4b5ad370f Gerrit-Change-Number: 26428 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 10:42:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 1 Dec 2021 10:42:26 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore UNNECESSARY_BREAK In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26430 ) Change subject: lint: checkpatch_osmo: ignore UNNECESSARY_BREAK ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3f106510953b0b1bf70c28ceb55a431c5c03854e Gerrit-Change-Number: 26430 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 01 Dec 2021 10:42:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 10:42:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 1 Dec 2021 10:42:29 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore UNNECESSARY_BREAK In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26430 ) Change subject: lint: checkpatch_osmo: ignore UNNECESSARY_BREAK ...................................................................... lint: checkpatch_osmo: ignore UNNECESSARY_BREAK Not necessarily followed in Osmocom code, as Daniel wrote: > The lint complains about this break, I don't agree with it though. > Without we're one (or two) refactors away from an unintended > fall-through Related: OS#5087 Change-Id: I3f106510953b0b1bf70c28ceb55a431c5c03854e --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index ec9384c..126a8b4 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -70,6 +70,7 @@ # * SPLIT_STRING: we do split long messages over multiple lines # * STRING_FRAGMENTS: sometimes used intentionally to improve readability # * TRAILING_STATEMENTS: not followed, e.g. 'while (osmo_select_main_ctx(1) > 0);' is put in one line +# * UNNECESSARY_BREAK: not followed (see https://gerrit.osmocom.org/c/libosmo-netif/+/26429) # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) # * UNSPECIFIED_INT: not followed (doesn't seem useful for us) @@ -105,6 +106,7 @@ --ignore SPLIT_STRING \ --ignore STRING_FRAGMENTS \ --ignore TRAILING_STATEMENTS \ + --ignore UNNECESSARY_BREAK \ --ignore UNNECESSARY_INT \ --ignore UNSPECIFIED_INT \ --max-line-length 120 \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3f106510953b0b1bf70c28ceb55a431c5c03854e Gerrit-Change-Number: 26430 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 10:44:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 1 Dec 2021 10:44:07 +0000 Subject: Change in libosmo-netif[master]: stream: Factor out sctp_recvmg long code chunk In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26429 ) Change subject: stream: Factor out sctp_recvmg long code chunk ...................................................................... Patch Set 1: Code-Review+1 sme here, recvmsg. beyond that, we mgiht want to revisit having all of those log lines only in LOGL_DEBUG, but that's a separate topic. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3e0f4407e00a2dac9ee885fe1cc1cb4b463898a Gerrit-Change-Number: 26429 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-CC: osmith Gerrit-Comment-Date: Wed, 01 Dec 2021 10:44:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 11:32:52 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 1 Dec 2021 11:32:52 +0000 Subject: Change in pysim[master]: filesystem: actively probe applications References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26431 ) Change subject: filesystem: actively probe applications ...................................................................... filesystem: actively probe applications A profile can cover lots of different applications. Those applications may not exist on all card models. To exclude applications that are not installed on the particular card EF.DIR is evaluated. However, there may be applications that are not registered in EF.DIR but supported by the profile. To cover those as well, lets try to select the applications we do not see in EF.DIR. If selecting works we know that the application exists on the card and we can include them in the RuntimeState. Change-Id: I3fa77a68664fe50d690a18adfb1ae1a88a189827 --- M pySim/filesystem.py 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/31/26431/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 4c3308c..c706131 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1101,14 +1101,23 @@ for a in aids_card: for f in apps_profile: if f.aid in a: - print(" %s: %s" % (f.name, a)) + print(" %s: %s (EF.DIR)" % (f.name, a)) aids_taken.append(a) apps_taken.append(f) aids_unknown = set(aids_card) - set(aids_taken) for a in aids_unknown: - print(" unknown: %s" % a) + print(" unknown: %s (EF.DIR)" % a) else: - print("error: could not determine card applications") + print("warning: EF.DIR seems to be empty!") + + # Some card applications may not be registered in EF.DIR, we will actively + # probe for those applications + for f in set(apps_profile) - set(apps_taken): + data, sw = self.card.select_adf_by_aid(f.aid) + if sw == "9000": + print(" %s: %s" % (f.name, a)) + apps_taken.append(f) + return apps_taken def reset(self, cmd_app=None) -> Hexstr: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3fa77a68664fe50d690a18adfb1ae1a88a189827 Gerrit-Change-Number: 26431 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 11:40:08 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 1 Dec 2021 11:40:08 +0000 Subject: Change in docker-playground[master]: ttcn3-{bts, bsc, msc, hlr}-test: set OSMO_SUT_{HOST, PORT} In-Reply-To: References: Message-ID: Hello osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/26408 to look at the new patch set (#3). Change subject: ttcn3-{bts,bsc,msc,hlr}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... ttcn3-{bts,bsc,msc,hlr}-test: set OSMO_SUT_{HOST,PORT} This enables the test suite to obtain talloc reports between the test case executions, which get stored together with the PCAP files. Let's see how it works with the mentioned projects first; others can be configured later. See [1] for more details. Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Related: [1] I1b03b17426d8760c55976e3b78ca2f3af248c055 Related: OS#5328 --- M ttcn3-bsc-test/jenkins.sh M ttcn3-bts-test/jenkins.sh M ttcn3-hlr-test/jenkins.sh M ttcn3-msc-test/jenkins.sh 4 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/08/26408/3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Gerrit-Change-Number: 26408 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 11:40:19 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 1 Dec 2021 11:40:19 +0000 Subject: Change in docker-playground[master]: debian-stretch-titan/Dockerfile: install osmo-python-tests In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26427 ) Change subject: debian-stretch-titan/Dockerfile: install osmo-python-tests ...................................................................... debian-stretch-titan/Dockerfile: install osmo-python-tests We need osmo_interact_vty.py in order to obtain talloc reports for each test case automatically. See [1] for more details. Change-Id: Ida8e08e7fe4f171f934a2d4eef4568da7c398f5c Related: [1] I1b03b17426d8760c55976e3b78ca2f3af248c055 --- M debian-stretch-titan/Dockerfile 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved fixeria: Verified diff --git a/debian-stretch-titan/Dockerfile b/debian-stretch-titan/Dockerfile index 5b6b134..d348914 100644 --- a/debian-stretch-titan/Dockerfile +++ b/debian-stretch-titan/Dockerfile @@ -32,9 +32,14 @@ wireshark-common \ vim \ netcat-openbsd \ + python3-setuptools \ + python3-pip \ && \ apt-get clean +# This is required for obtaining talloc reports from the SUT +RUN pip3 install git+git://git.osmocom.org/python/osmo-python-tests + # somehow Debian folks updated the gcc version but not titan :/ RUN sed -i 's/^#error/\/\/#error/' /usr/include/titan/cversion.h -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ida8e08e7fe4f171f934a2d4eef4568da7c398f5c Gerrit-Change-Number: 26427 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 12:10:17 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 1 Dec 2021 12:10:17 +0000 Subject: Change in docker-playground[master]: ttcn3-{bts, bsc, msc, hlr}-test: set OSMO_SUT_{HOST, PORT} In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26408 ) Change subject: ttcn3-{bts,bsc,msc,hlr}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Gerrit-Change-Number: 26408 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 01 Dec 2021 12:10:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 12:14:34 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 1 Dec 2021 12:14:34 +0000 Subject: Change in docker-playground[master]: ttcn3-sccp-test/jenkins.sh: fix typo References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26432 ) Change subject: ttcn3-sccp-test/jenkins.sh: fix typo ...................................................................... ttcn3-sccp-test/jenkins.sh: fix typo Fixes: 305ce55 ("ttcn3: write Osmocom repository to configs") Change-Id: I79734da2744502a2b8c4db9d38f992b77fe6a42a --- M ttcn3-sccp-test/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/32/26432/1 diff --git a/ttcn3-sccp-test/jenkins.sh b/ttcn3-sccp-test/jenkins.sh index 687e746..d1a9a11 100755 --- a/ttcn3-sccp-test/jenkins.sh +++ b/ttcn3-sccp-test/jenkins.sh @@ -12,7 +12,7 @@ mkdir $VOL_BASE_DIR/sccp-tester cp SCCP_Tests.cfg $VOL_BASE_DIR/sccp-tester/ -write_mp_osmo_repo "$VOL_BASE_DIR/scpp-tester/SCCP_Tests.cfg" +write_mp_osmo_repo "$VOL_BASE_DIR/sccp-tester/SCCP_Tests.cfg" mkdir $VOL_BASE_DIR/sccp cp sccp_demo_user.cfg $VOL_BASE_DIR/sccp/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I79734da2744502a2b8c4db9d38f992b77fe6a42a Gerrit-Change-Number: 26432 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 12:40:33 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Wed, 1 Dec 2021 12:40:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: fix TC_cm_serv_rej References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 ) Change subject: bsc: fix TC_cm_serv_rej ...................................................................... bsc: fix TC_cm_serv_rej Calling BSSAP.send() directly after f_create_chan_and_exp() seems to be racy for an unknown reason. Adding a sleep after f_create_chan_and_exp() makes the test pass reliably. Related: SYS#4878 Change-Id: Iad30319a7e9e726d006c9934ed2eb48f886811a9 --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/26433/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 22df0cb..be7dac8 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -10534,6 +10534,7 @@ private function f_TC_cm_serv_rej(charstring id) runs on MSC_ConnHdlr { f_create_chan_and_exp(); + f_sleep(1.0); BSSAP.send(ts_PDU_DTAP_MT(ts_CM_SERV_REJ('02'O), '00'O)); f_sleep(1.0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iad30319a7e9e726d006c9934ed2eb48f886811a9 Gerrit-Change-Number: 26433 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 13:47:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 1 Dec 2021 13:47:20 +0000 Subject: Change in docker-playground[master]: ttcn3-{bts, bsc, msc, hlr}-test: set OSMO_SUT_{HOST, PORT} In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26408 ) Change subject: ttcn3-{bts,bsc,msc,hlr}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Gerrit-Change-Number: 26408 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 01 Dec 2021 13:47:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 13:48:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 1 Dec 2021 13:48:47 +0000 Subject: Change in docker-playground[master]: ttcn3-{bts, bsc, msc, hlr}-test: set OSMO_SUT_{HOST, PORT} In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26408 ) Change subject: ttcn3-{bts,bsc,msc,hlr}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... Patch Set 3: Verified+1 Code-Review+2 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Gerrit-Change-Number: 26408 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 01 Dec 2021 13:48:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 13:48:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 1 Dec 2021 13:48:50 +0000 Subject: Change in docker-playground[master]: ttcn3-{bts, bsc, msc, hlr}-test: set OSMO_SUT_{HOST, PORT} In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26408 ) Change subject: ttcn3-{bts,bsc,msc,hlr}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... ttcn3-{bts,bsc,msc,hlr}-test: set OSMO_SUT_{HOST,PORT} This enables the test suite to obtain talloc reports between the test case executions, which get stored together with the PCAP files. Let's see how it works with the mentioned projects first; others can be configured later. See [1] for more details. Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Related: [1] I1b03b17426d8760c55976e3b78ca2f3af248c055 Related: OS#5328 --- M ttcn3-bsc-test/jenkins.sh M ttcn3-bts-test/jenkins.sh M ttcn3-hlr-test/jenkins.sh M ttcn3-msc-test/jenkins.sh 4 files changed, 8 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve diff --git a/ttcn3-bsc-test/jenkins.sh b/ttcn3-bsc-test/jenkins.sh index 3898491..7f05c5e 100755 --- a/ttcn3-bsc-test/jenkins.sh +++ b/ttcn3-bsc-test/jenkins.sh @@ -62,6 +62,8 @@ $(docker_network_params $SUBNET 203) \ --ulimit core=-1 \ -e "TTCN3_PCAP_PATH=/data" \ + -e "OSMO_SUT_HOST=172.18.$SUBNET.20" \ + -e "OSMO_SUT_PORT=4242" \ -v $VOL_BASE_DIR/bsc-tester:/data \ --name ${BUILD_TAG}-ttcn3-bsc-test \ $DOCKER_ARGS \ diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 4ce333e..395407b 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -107,6 +107,8 @@ $(docker_network_params $SUBNET 10) \ --ulimit core=-1 \ -e "TTCN3_PCAP_PATH=/data" \ + -e "OSMO_SUT_HOST=172.18.$SUBNET.20" \ + -e "OSMO_SUT_PORT=4241" \ -v $VOL_BASE_DIR/bts-tester-${variant}:/data \ -v $VOL_BASE_DIR/unix:/data/unix \ --name ${BUILD_TAG}-ttcn3-bts-test \ diff --git a/ttcn3-hlr-test/jenkins.sh b/ttcn3-hlr-test/jenkins.sh index 6702e40..317f141 100755 --- a/ttcn3-hlr-test/jenkins.sh +++ b/ttcn3-hlr-test/jenkins.sh @@ -34,6 +34,8 @@ $(docker_network_params $SUBNET 103) \ --ulimit core=-1 \ -e "TTCN3_PCAP_PATH=/data" \ + -e "OSMO_SUT_HOST=172.18.$SUBNET.20" \ + -e "OSMO_SUT_PORT=4258" \ -v $VOL_BASE_DIR/hlr-tester:/data \ --name ${BUILD_TAG}-ttcn3-hlr-test \ $DOCKER_ARGS \ diff --git a/ttcn3-msc-test/jenkins.sh b/ttcn3-msc-test/jenkins.sh index 937b91f..a8e6229 100755 --- a/ttcn3-msc-test/jenkins.sh +++ b/ttcn3-msc-test/jenkins.sh @@ -51,6 +51,8 @@ $(docker_network_params $SUBNET 103) \ --ulimit core=-1 \ -e "TTCN3_PCAP_PATH=/data" \ + -e "OSMO_SUT_HOST=172.18.$SUBNET.10" \ + -e "OSMO_SUT_PORT=4254" \ -v $VOL_BASE_DIR/msc-tester:/data \ -v $VOL_BASE_DIR/unix:/data/unix \ --name ${BUILD_TAG}-ttcn3-msc-test \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26408 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icd4c2d80db934535d499598282ed9416d8088163 Gerrit-Change-Number: 26408 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 13:52:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 1 Dec 2021 13:52:51 +0000 Subject: Change in libosmo-netif[master]: stream: Factor out sctp_recvmg long code chunk In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26429 to look at the new patch set (#2). Change subject: stream: Factor out sctp_recvmg long code chunk ...................................................................... stream: Factor out sctp_recvmg long code chunk This makes it easier to follow the general path selection based on protocol type. It will also make it easier when we add new paths based on socket domain. Change-Id: Ia3e0f4407e00a2dac9ee885fe1cc1cb4b463898a --- M src/stream.c 1 file changed, 51 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/29/26429/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3e0f4407e00a2dac9ee885fe1cc1cb4b463898a Gerrit-Change-Number: 26429 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-CC: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 13:53:30 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 1 Dec 2021 13:53:30 +0000 Subject: Change in libosmo-netif[master]: stream: Factor out sctp_recvmg long code chunk In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26429 ) Change subject: stream: Factor out sctp_recvmg long code chunk ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3e0f4407e00a2dac9ee885fe1cc1cb4b463898a Gerrit-Change-Number: 26429 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 01 Dec 2021 13:53:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 13:54:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 1 Dec 2021 13:54:26 +0000 Subject: Change in docker-playground[master]: ttcn3-sccp-test/jenkins.sh: fix typo In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26432 ) Change subject: ttcn3-sccp-test/jenkins.sh: fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I79734da2744502a2b8c4db9d38f992b77fe6a42a Gerrit-Change-Number: 26432 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 01 Dec 2021 13:54:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 13:54:40 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 1 Dec 2021 13:54:40 +0000 Subject: Change in docker-playground[master]: ttcn3-sccp-test/jenkins.sh: fix typo In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26432 ) Change subject: ttcn3-sccp-test/jenkins.sh: fix typo ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I79734da2744502a2b8c4db9d38f992b77fe6a42a Gerrit-Change-Number: 26432 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 01 Dec 2021 13:54:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 13:54:43 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 1 Dec 2021 13:54:43 +0000 Subject: Change in docker-playground[master]: ttcn3-sccp-test/jenkins.sh: fix typo In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26432 ) Change subject: ttcn3-sccp-test/jenkins.sh: fix typo ...................................................................... ttcn3-sccp-test/jenkins.sh: fix typo Fixes: 305ce55 ("ttcn3: write Osmocom repository to configs") Change-Id: I79734da2744502a2b8c4db9d38f992b77fe6a42a --- M ttcn3-sccp-test/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved osmith: Verified diff --git a/ttcn3-sccp-test/jenkins.sh b/ttcn3-sccp-test/jenkins.sh index 687e746..d1a9a11 100755 --- a/ttcn3-sccp-test/jenkins.sh +++ b/ttcn3-sccp-test/jenkins.sh @@ -12,7 +12,7 @@ mkdir $VOL_BASE_DIR/sccp-tester cp SCCP_Tests.cfg $VOL_BASE_DIR/sccp-tester/ -write_mp_osmo_repo "$VOL_BASE_DIR/scpp-tester/SCCP_Tests.cfg" +write_mp_osmo_repo "$VOL_BASE_DIR/sccp-tester/SCCP_Tests.cfg" mkdir $VOL_BASE_DIR/sccp cp sccp_demo_user.cfg $VOL_BASE_DIR/sccp/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I79734da2744502a2b8c4db9d38f992b77fe6a42a Gerrit-Change-Number: 26432 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 13:55:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 1 Dec 2021 13:55:40 +0000 Subject: Change in libosmo-netif[master]: stream: Factor out sctp_recvmg long code chunk In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26429 ) Change subject: stream: Factor out sctp_recvmg long code chunk ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3e0f4407e00a2dac9ee885fe1cc1cb4b463898a Gerrit-Change-Number: 26429 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 01 Dec 2021 13:55:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 13:55:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 1 Dec 2021 13:55:42 +0000 Subject: Change in libosmo-netif[master]: stream: Factor out sctp_recvmg long code chunk In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26429 ) Change subject: stream: Factor out sctp_recvmg long code chunk ...................................................................... stream: Factor out sctp_recvmg long code chunk This makes it easier to follow the general path selection based on protocol type. It will also make it easier when we add new paths based on socket domain. Change-Id: Ia3e0f4407e00a2dac9ee885fe1cc1cb4b463898a --- M src/stream.c 1 file changed, 51 insertions(+), 43 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/stream.c b/src/stream.c index e4fb668..309aafe 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1290,6 +1290,56 @@ osmo_fd_write_enable(&conn->ofd); } +#ifdef HAVE_LIBSCTP +static int _sctp_recvmsg_wrapper(int fd, struct msgb *msg) +{ + struct sctp_sndrcvinfo sinfo; + int flags = 0; + int ret; + + ret = sctp_recvmsg(fd, msgb_data(msg), msgb_tailroom(msg), + NULL, NULL, &sinfo, &flags); + if (flags & MSG_NOTIFICATION) { + union sctp_notification *notif = (union sctp_notification *)msgb_data(msg); + LOGP(DLINP, LOGL_DEBUG, "NOTIFICATION %u flags=0x%x\n", notif->sn_header.sn_type, notif->sn_header.sn_flags); + switch (notif->sn_header.sn_type) { + case SCTP_ASSOC_CHANGE: + LOGP(DLINP, LOGL_DEBUG, "===> ASSOC CHANGE:"); + switch (notif->sn_assoc_change.sac_state) { + case SCTP_COMM_UP: + LOGPC(DLINP, LOGL_DEBUG, " UP\n"); + break; + case SCTP_COMM_LOST: + LOGPC(DLINP, LOGL_DEBUG, " LOST\n"); + break; + case SCTP_RESTART: + LOGPC(DLINP, LOGL_DEBUG, " RESTART\n"); + break; + case SCTP_SHUTDOWN_COMP: + LOGPC(DLINP, LOGL_DEBUG, " SHUTDOWN COMP\n"); + break; + case SCTP_CANT_STR_ASSOC: + LOGPC(DLINP, LOGL_DEBUG, " CANT STR ASSOC\n"); + break; + } + break; + case SCTP_PEER_ADDR_CHANGE: + LOGP(DLINP, LOGL_DEBUG, "===> PEER ADDR CHANGE\n"); + break; + case SCTP_SHUTDOWN_EVENT: + LOGP(DLINP, LOGL_DEBUG, "===> SHUTDOWN EVT\n"); + /* Handle this like a regular disconnect */ + return 0; + break; + } + return -EAGAIN; + } + msgb_sctp_ppid(msg) = ntohl(sinfo.sinfo_ppid); + msgb_sctp_stream(msg) = sinfo.sinfo_stream; + return ret; +} +#endif + /*! \brief Receive data via Osmocom stream server * \param[in] conn Stream Server from which to receive * \param msg pre-allocate message buffer to which received data is appended @@ -1297,10 +1347,6 @@ */ int osmo_stream_srv_recv(struct osmo_stream_srv *conn, struct msgb *msg) { -#ifdef HAVE_LIBSCTP - struct sctp_sndrcvinfo sinfo; - int flags = 0; -#endif int ret; if (!msg) @@ -1309,45 +1355,7 @@ switch (conn->srv->proto) { #ifdef HAVE_LIBSCTP case IPPROTO_SCTP: - ret = sctp_recvmsg(conn->ofd.fd, msgb_data(msg), msgb_tailroom(msg), - NULL, NULL, &sinfo, &flags); - if (flags & MSG_NOTIFICATION) { - union sctp_notification *notif = (union sctp_notification *) msgb_data(msg); - LOGP(DLINP, LOGL_DEBUG, "NOTIFICATION %u flags=0x%x\n", notif->sn_header.sn_type, notif->sn_header.sn_flags); - switch (notif->sn_header.sn_type) { - case SCTP_ASSOC_CHANGE: - LOGP(DLINP, LOGL_DEBUG, "===> ASSOC CHANGE:"); - switch (notif->sn_assoc_change.sac_state) { - case SCTP_COMM_UP: - LOGPC(DLINP, LOGL_DEBUG, " UP\n"); - break; - case SCTP_COMM_LOST: - LOGPC(DLINP, LOGL_DEBUG, " LOST\n"); - break; - case SCTP_RESTART: - LOGPC(DLINP, LOGL_DEBUG, " RESTART\n"); - break; - case SCTP_SHUTDOWN_COMP: - LOGPC(DLINP, LOGL_DEBUG, " SHUTDOWN COMP\n"); - break; - case SCTP_CANT_STR_ASSOC: - LOGPC(DLINP, LOGL_DEBUG, " CANT STR ASSOC\n"); - break; - } - break; - case SCTP_PEER_ADDR_CHANGE: - LOGP(DLINP, LOGL_DEBUG, "===> PEER ADDR CHANGE\n"); - break; - case SCTP_SHUTDOWN_EVENT: - LOGP(DLINP, LOGL_DEBUG, "===> SHUTDOWN EVT\n"); - /* Handle this like a regular disconnect */ - return 0; - break; - } - return -EAGAIN; - } - msgb_sctp_ppid(msg) = ntohl(sinfo.sinfo_ppid); - msgb_sctp_stream(msg) = sinfo.sinfo_stream; + ret = _sctp_recvmsg_wrapper(conn->ofd.fd, msg); break; #endif case IPPROTO_TCP: -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3e0f4407e00a2dac9ee885fe1cc1cb4b463898a Gerrit-Change-Number: 26429 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 17:18:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 1 Dec 2021 17:18:35 +0000 Subject: Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 to look at the new patch set (#2). Change subject: Introduce osmo_prim_srv APIs ...................................................................... Introduce osmo_prim_srv APIs This new module allows easy exchange of osmo_prim based data types over IPC communication (UD socket supported only so far), by replacing the osmo_prim_hdr struct with a serialized header when submitting/receiving it from the IPC socket. This patch introduces the server side of the UD socket, but the client side can easily be introduced in the same file whenever needed. Related: SYS#5516 Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 --- M TODO-RELEASE M include/osmocom/netif/Makefile.am A include/osmocom/netif/prim.h M src/Makefile.am A src/prim.c 5 files changed, 400 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/26/26426/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 Gerrit-Change-Number: 26426 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 17:18:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 1 Dec 2021 17:18:36 +0000 Subject: Change in libosmo-netif[master]: stream: Add support for AF_UNIX sockets References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26434 ) Change subject: stream: Add support for AF_UNIX sockets ...................................................................... stream: Add support for AF_UNIX sockets Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 --- M include/osmocom/netif/stream.h M src/stream.c 2 files changed, 223 insertions(+), 72 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/34/26434/1 diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index 331dec1..b82dff1 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -25,6 +25,8 @@ int osmo_stream_srv_link_set_addrs(struct osmo_stream_srv_link *link, const char **addr, size_t addrcnt); void osmo_stream_srv_link_set_port(struct osmo_stream_srv_link *link, uint16_t port); void osmo_stream_srv_link_set_proto(struct osmo_stream_srv_link *link, uint16_t proto); +int osmo_stream_srv_link_set_type(struct osmo_stream_srv_link *link, int type); +int osmo_stream_srv_link_set_domain(struct osmo_stream_srv_link *link, int domain); void osmo_stream_srv_link_set_accept_cb(struct osmo_stream_srv_link *link, int (*accept_cb)(struct osmo_stream_srv_link *link, int fd)); void osmo_stream_srv_link_set_data(struct osmo_stream_srv_link *link, void *data); void *osmo_stream_srv_link_get_data(struct osmo_stream_srv_link *link); @@ -57,6 +59,8 @@ void osmo_stream_cli_set_addr(struct osmo_stream_cli *cli, const char *addr); int osmo_stream_cli_set_addrs(struct osmo_stream_cli *cli, const char **addr, size_t addrcnt); void osmo_stream_cli_set_port(struct osmo_stream_cli *cli, uint16_t port); +int osmo_stream_cli_set_type(struct osmo_stream_cli *cli, int type); +int osmo_stream_cli_set_domain(struct osmo_stream_cli *cli, int domain); void osmo_stream_cli_set_proto(struct osmo_stream_cli *cli, uint16_t proto); void osmo_stream_cli_set_local_addr(struct osmo_stream_cli *cli, const char *addr); int osmo_stream_cli_set_local_addrs(struct osmo_stream_cli *cli, const char **addr, size_t addrcnt); diff --git a/src/stream.c b/src/stream.c index 309aafe..1b3d0fb 100644 --- a/src/stream.c +++ b/src/stream.c @@ -256,6 +256,8 @@ char *local_addr[OSMO_STREAM_MAX_ADDRS]; uint8_t local_addrcnt; uint16_t local_port; + int sk_domain; + int sk_type; uint16_t proto; int (*connect_cb)(struct osmo_stream_cli *srv); int (*disconnect_cb)(struct osmo_stream_cli *srv); @@ -349,20 +351,26 @@ LOGSCLI(cli, LOGL_DEBUG, "sending %u bytes of data\n", msgb_length(msg)); - switch (cli->proto) { -#ifdef HAVE_LIBSCTP - case IPPROTO_SCTP: - memset(&sinfo, 0, sizeof(sinfo)); - sinfo.sinfo_ppid = htonl(msgb_sctp_ppid(msg)); - sinfo.sinfo_stream = msgb_sctp_stream(msg); - ret = sctp_send(cli->ofd.fd, msg->data, msgb_length(msg), - &sinfo, MSG_NOSIGNAL); + switch (cli->sk_domain) { + case AF_UNIX: + ret = send(cli->ofd.fd, msg->data, msg->len, 0); break; -#endif - case IPPROTO_TCP: default: - ret = send(cli->ofd.fd, msg->data, msgb_length(msg), 0); - break; + switch (cli->proto) { +#ifdef HAVE_LIBSCTP + case IPPROTO_SCTP: + memset(&sinfo, 0, sizeof(sinfo)); + sinfo.sinfo_ppid = htonl(msgb_sctp_ppid(msg)); + sinfo.sinfo_stream = msgb_sctp_stream(msg); + ret = sctp_send(cli->ofd.fd, msg->data, msgb_length(msg), + &sinfo, MSG_NOSIGNAL); + break; +#endif + case IPPROTO_TCP: + default: + ret = send(cli->ofd.fd, msg->data, msgb_length(msg), 0); + break; + } } if (ret < 0) { if (errno == EPIPE || errno == ENOTCONN) { @@ -395,15 +403,20 @@ LOGSCLI(cli, LOGL_DEBUG, "connection done.\n"); cli->state = STREAM_CLI_STATE_CONNECTED; - if (cli->proto == IPPROTO_SCTP) { + switch (cli->sk_domain) { + case AF_UNIX: + break; + default: + if (cli->proto == IPPROTO_SCTP) { #ifdef SO_NOSIGPIPE - int val = 1; + int val = 1; - ret = setsockopt(ofd->fd, SOL_SOCKET, SO_NOSIGPIPE, (void*)&val, sizeof(val)); - if (ret < 0) - LOGSCLI(cli, LOGL_DEBUG, "Failed setting SO_NOSIGPIPE: %s\n", strerror(errno)); + ret = setsockopt(ofd->fd, SOL_SOCKET, SO_NOSIGPIPE, (void*)&val, sizeof(val)); + if (ret < 0) + LOGSCLI(cli, LOGL_DEBUG, "Failed setting SO_NOSIGPIPE: %s\n", strerror(errno)); #endif - sctp_sock_activate_events(ofd->fd); + sctp_sock_activate_events(ofd->fd); + } } if (cli->connect_cb) cli->connect_cb(cli); @@ -441,6 +454,8 @@ if (!cli) return NULL; + cli->sk_domain = AF_UNSPEC; + cli->sk_type = SOCK_STREAM; cli->proto = IPPROTO_TCP; cli->ofd.fd = -1; cli->ofd.priv_nr = 0; /* XXX */ @@ -557,6 +572,46 @@ cli->flags |= OSMO_STREAM_CLI_F_RECONF; } +/*! \brief Set the socket type for the stream server link + * \param[in] cli Stream Client to modify + * \param[in] type Socket Type (like SOCK_STREAM (default), SOCK_SEQPACKET, ...) + * \returns zero on success, negative on error. + */ +int osmo_stream_cli_set_type(struct osmo_stream_cli *cli, int type) +{ + switch (type) { + case SOCK_STREAM: + case SOCK_SEQPACKET: + break; + default: + return -ENOTSUP; + } + cli->sk_type = type; + cli->flags |= OSMO_STREAM_CLI_F_RECONF; + return 0; +} + +/*! \brief Set the socket type for the stream server link + * \param[in] cli Stream Client to modify + * \param[in] type Socket Domain (like AF_UNSPEC (default for IP), AF_UNIX, AF_INET, ...) + * \returns zero on success, negative on error. + */ +int osmo_stream_cli_set_domain(struct osmo_stream_cli *cli, int domain) +{ + switch (domain) { + case AF_UNSPEC: + case AF_INET: + case AF_INET6: + case AF_UNIX: + break; + default: + return -ENOTSUP; + } + cli->sk_domain = domain; + cli->flags |= OSMO_STREAM_CLI_F_RECONF; + return 0; +} + /*! \brief Set the reconnect time of the stream client socket * \param[in] cli Stream Client to modify * \param[in] timeout Re-connect timeout in seconds or negative value to disable auto-reconnection */ @@ -731,21 +786,29 @@ cli->flags &= ~OSMO_STREAM_CLI_F_RECONF; - - switch (cli->proto) { -#ifdef HAVE_LIBSCTP - case IPPROTO_SCTP: - ret = osmo_sock_init2_multiaddr(AF_UNSPEC, SOCK_STREAM, cli->proto, - (const char **)cli->local_addr, cli->local_addrcnt, cli->local_port, - (const char **)cli->addr, cli->addrcnt, cli->port, - OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_BIND|OSMO_SOCK_F_NONBLOCK); + switch (cli->sk_domain) { + case AF_UNIX: + ret = osmo_sock_unix_init(cli->sk_type, 0, cli->addr[0], OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_BIND|OSMO_SOCK_F_NONBLOCK); break; -#endif + case AF_INET: + case AF_INET6: + case AF_UNSPEC: default: - ret = osmo_sock_init2(AF_UNSPEC, SOCK_STREAM, cli->proto, - cli->local_addr[0], cli->local_port, - cli->addr[0], cli->port, - OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_BIND|OSMO_SOCK_F_NONBLOCK); + switch (cli->proto) { +#ifdef HAVE_LIBSCTP + case IPPROTO_SCTP: + ret = osmo_sock_init2_multiaddr(cli->sk_domain, cli->sk_type, cli->proto, + (const char **)cli->local_addr, cli->local_addrcnt, cli->local_port, + (const char **)cli->addr, cli->addrcnt, cli->port, + OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_BIND|OSMO_SOCK_F_NONBLOCK); + break; +#endif + default: + ret = osmo_sock_init2(cli->sk_domain, cli->sk_type, cli->proto, + cli->local_addr[0], cli->local_port, + cli->addr[0], cli->port, + OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_BIND|OSMO_SOCK_F_NONBLOCK); + } } if (ret < 0) { @@ -827,6 +890,8 @@ char *addr[OSMO_STREAM_MAX_ADDRS]; uint8_t addrcnt; uint16_t port; + int sk_domain; + int sk_type; uint16_t proto; int (*accept_cb)(struct osmo_stream_srv_link *srv, int fd); void *data; @@ -838,7 +903,7 @@ int ret; int sock_fd; char addrstr[128]; - bool is_ipv6; + bool is_ipv6 = false; struct sockaddr_storage sa; socklen_t sa_len = sizeof(sa); struct osmo_stream_srv_link *link = ofd->data; @@ -849,19 +914,35 @@ "peer, reason=`%s'\n", strerror(errno)); return ret; } - is_ipv6 = ((struct sockaddr *)&sa)->sa_family == AF_INET6; - LOGP(DLINP, LOGL_DEBUG, "accept()ed new link from %s to port %u\n", - inet_ntop(is_ipv6 ? AF_INET6 : AF_INET, - is_ipv6 ? (void*)&(((struct sockaddr_in6 *)&sa)->sin6_addr) : - (void*)&(((struct sockaddr_in *)&sa)->sin_addr), - addrstr, sizeof(addrstr)), - link->port); sock_fd = ret; - if (link->proto == IPPROTO_SCTP) { - ret = sctp_sock_activate_events(sock_fd); - if (ret < 0) - goto error_close_socket; + is_ipv6 = false; + switch (((struct sockaddr *)&sa)->sa_family) { + case AF_UNIX: + LOGP(DLINP, LOGL_DEBUG, "accept()ed new link on fd %d\n", + sock_fd); + break; + case AF_INET6: + is_ipv6 = true; + /* fall through */ + case AF_INET: + LOGP(DLINP, LOGL_DEBUG, "accept()ed new link from %s to port %u\n", + inet_ntop(is_ipv6 ? AF_INET6 : AF_INET, + is_ipv6 ? (void*)&(((struct sockaddr_in6 *)&sa)->sin6_addr) : + (void*)&(((struct sockaddr_in *)&sa)->sin_addr), + addrstr, sizeof(addrstr)), + link->port); + + if (link->proto == IPPROTO_SCTP) { + ret = sctp_sock_activate_events(sock_fd); + if (ret < 0) + goto error_close_socket; + } + break; + default: + LOGP(DLINP, LOGL_DEBUG, "accept()ed unexpected address family %d\n", + ((struct sockaddr *)&sa)->sa_family); + goto error_close_socket; } if (link->flags & OSMO_STREAM_SRV_F_NODELAY) { @@ -899,6 +980,8 @@ if (!link) return NULL; + link->sk_domain = AF_UNSPEC; + link->sk_type = SOCK_STREAM; link->proto = IPPROTO_TCP; osmo_fd_setup(&link->ofd, -1, OSMO_FD_READ | OSMO_FD_WRITE, osmo_stream_srv_fd_cb, link, 0); @@ -978,6 +1061,47 @@ link->flags |= OSMO_STREAM_SRV_F_RECONF; } + +/*! \brief Set the socket type for the stream server link + * \param[in] link Stream Server Link to modify + * \param[in] type Socket Type (like SOCK_STREAM (default), SOCK_SEQPACKET, ...) + * \returns zero on success, negative on error. + */ +int osmo_stream_srv_link_set_type(struct osmo_stream_srv_link *link, int type) +{ + switch (type) { + case SOCK_STREAM: + case SOCK_SEQPACKET: + break; + default: + return -ENOTSUP; + } + link->sk_type = type; + link->flags |= OSMO_STREAM_SRV_F_RECONF; + return 0; +} + +/*! \brief Set the socket type for the stream server link + * \param[in] link Stream Server Link to modify + * \param[in] type Socket Domain (like AF_UNSPEC (default for IP), AF_UNIX, AF_INET, ...) + * \returns zero on success, negative on error. + */ +int osmo_stream_srv_link_set_domain(struct osmo_stream_srv_link *link, int domain) +{ + switch (domain) { + case AF_UNSPEC: + case AF_INET: + case AF_INET6: + case AF_UNIX: + break; + default: + return -ENOTSUP; + } + link->sk_domain = domain; + link->flags |= OSMO_STREAM_SRV_F_RECONF; + return 0; +} + /*! \brief Set application private data of the stream server link * \param[in] link Stream Server Link to modify * \param[in] data User-specific data (available in call-back functions) */ @@ -1060,17 +1184,28 @@ link->flags &= ~OSMO_STREAM_SRV_F_RECONF; - switch (link->proto) { + switch (link->sk_domain) { + case AF_UNIX: + ret = osmo_sock_unix_init(link->sk_type, 0, link->addr[0], OSMO_SOCK_F_BIND); + break; + case AF_UNSPEC: + case AF_INET: + case AF_INET6: + switch (link->proto) { #ifdef HAVE_LIBSCTP - case IPPROTO_SCTP: - ret = osmo_sock_init2_multiaddr(AF_UNSPEC, SOCK_STREAM, link->proto, - (const char **)link->addr, link->addrcnt, link->port, - NULL, 0, 0, OSMO_SOCK_F_BIND); - break; + case IPPROTO_SCTP: + ret = osmo_sock_init2_multiaddr(link->sk_domain, link->sk_type, link->proto, + (const char **)link->addr, link->addrcnt, link->port, + NULL, 0, 0, OSMO_SOCK_F_BIND); + break; #endif - default: - ret = osmo_sock_init(AF_UNSPEC, SOCK_STREAM, link->proto, - link->addr[0], link->port, OSMO_SOCK_F_BIND); + default: + ret = osmo_sock_init(link->sk_domain, link->sk_type, link->proto, + link->addr[0], link->port, OSMO_SOCK_F_BIND); + } + break; + default: + ret = -ENOTSUP; } if (ret < 0) return ret; @@ -1144,20 +1279,26 @@ llist_del(lh); msg = llist_entry(lh, struct msgb, list); - switch (conn->srv->proto) { -#ifdef HAVE_LIBSCTP - case IPPROTO_SCTP: - memset(&sinfo, 0, sizeof(sinfo)); - sinfo.sinfo_ppid = htonl(msgb_sctp_ppid(msg)); - sinfo.sinfo_stream = msgb_sctp_stream(msg); - ret = sctp_send(conn->ofd.fd, msg->data, msgb_length(msg), - &sinfo, MSG_NOSIGNAL); - break; -#endif - case IPPROTO_TCP: - default: + switch (conn->srv->sk_domain) { + case AF_UNIX: ret = send(conn->ofd.fd, msg->data, msg->len, 0); break; + default: + switch (conn->srv->proto) { +#ifdef HAVE_LIBSCTP + case IPPROTO_SCTP: + memset(&sinfo, 0, sizeof(sinfo)); + sinfo.sinfo_ppid = htonl(msgb_sctp_ppid(msg)); + sinfo.sinfo_stream = msgb_sctp_stream(msg); + ret = sctp_send(conn->ofd.fd, msg->data, msgb_length(msg), + &sinfo, MSG_NOSIGNAL); + break; +#endif + case IPPROTO_TCP: + default: + ret = send(conn->ofd.fd, msg->data, msg->len, 0); + break; + } } if (ret < 0) { LOGP(DLINP, LOGL_ERROR, "error to send\n"); @@ -1352,16 +1493,22 @@ if (!msg) return -EINVAL; - switch (conn->srv->proto) { -#ifdef HAVE_LIBSCTP - case IPPROTO_SCTP: - ret = _sctp_recvmsg_wrapper(conn->ofd.fd, msg); - break; -#endif - case IPPROTO_TCP: - default: + switch (conn->srv->sk_domain) { + case AF_UNIX: ret = recv(conn->ofd.fd, msgb_data(msg), msgb_tailroom(msg), 0); break; + default: + switch (conn->srv->proto) { +#ifdef HAVE_LIBSCTP + case IPPROTO_SCTP: + ret = _sctp_recvmsg_wrapper(conn->ofd.fd, msg); + break; +#endif + case IPPROTO_TCP: + default: + ret = recv(conn->ofd.fd, msgb_data(msg), msgb_tailroom(msg), 0); + break; + } } if (ret < 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 Gerrit-Change-Number: 26434 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Arran Cudbard-bell Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 17:21:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 1 Dec 2021 17:21:03 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 to look at the new patch set (#8). Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Initial implementation of LowerLayer UD Socket The LLSK socket is an interface allowing thid-parties to implement and hook their RLC/MAC/RRC stack to osmo-hnodbe, which takes care of interconnection with the rest of the RAN and core network (Iuh, RTP, GTP-U, etc.). Related: SYS#5516 Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d --- A doc/hnodeb.msc M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_ctl.c A src/osmo-hnodeb/llsk_iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 20 files changed, 1,255 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/57/26357/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 8 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 17:24:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 1 Dec 2021 17:24:36 +0000 Subject: Change in libosmo-netif[master]: stream: Add support for AF_UNIX sockets In-Reply-To: References: Message-ID: Hello Jenkins Builder, Arran Cudbard-bell, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 to look at the new patch set (#2). Change subject: stream: Add support for AF_UNIX sockets ...................................................................... stream: Add support for AF_UNIX sockets Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 --- M include/osmocom/netif/stream.h M src/stream.c 2 files changed, 222 insertions(+), 71 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/34/26434/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 Gerrit-Change-Number: 26434 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Arran Cudbard-bell Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 18:52:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 1 Dec 2021 18:52:40 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26435 ) Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... prim: Add internal CTL SAPI to negotiate SAP versions This commits adds a generic mechansim for applications to validate support for SAPs and specific versions of them. A new special SAPI is introduced to manage inbound control messages for the protocol. In that SAPI a new primitive HELLO.ind/.cnf is added to negotiate support for versions of any given SAP. The idea is that the client upon connecting submits a HELLO.ind(SAP, VER) for each SAP it plans to use, including the version of the special CTL SAPI itself (preferrably to be checked first). Upon receiving such a message, osmo_prim_srv handles it using a special path, which ends up calling the user provided rx_sapi_version_cb(SAP, VER). In there, the user can either: * Accept the version (return same VER value) * Reject the requested version but propose another candidate version (return some positive VER value other than received VER). In this case, the client can decide whether to request another VER or close the connection. * Reject the proposed version and close the connection. Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 --- M include/osmocom/netif/prim.h M src/prim.c 2 files changed, 122 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/35/26435/1 diff --git a/include/osmocom/netif/prim.h b/include/osmocom/netif/prim.h index 4c99cd7..facc555 100644 --- a/include/osmocom/netif/prim.h +++ b/include/osmocom/netif/prim.h @@ -31,6 +31,15 @@ /*! oph and related msgb is owned by srv and wll be freed after the callback returns. */ typedef int (*osmo_prim_srv_rx_cb)(struct osmo_prim_srv *prim_srv, struct osmo_prim_hdr *oph); +/*! Return value: + * RET=rem_version: Accept the version + * RET!=rem_version && RET > 0: Reject the requested version but propose another candidate version + * In this case, the client can decide whether to request another VER + * or close the connection. + * RET<0: Reject the proposed version and close the connection. + */ +typedef int (*osmo_prim_srv_rx_sapi_version)(struct osmo_prim_srv *prim_srv, uint32_t sapi, uint16_t rem_version); + struct osmo_prim_hdr *osmo_prim_msgb_alloc(unsigned int sap, unsigned int primitive, enum osmo_prim_operation operation, size_t alloc_len); @@ -42,6 +51,7 @@ void *osmo_prim_srv_link_get_priv(const struct osmo_prim_srv_link *prim_link); void osmo_prim_srv_link_set_log_category(struct osmo_prim_srv_link *prim_link, int log_cat); void osmo_prim_srv_link_set_rx_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_rx_cb rx_cb); +void osmo_prim_srv_link_set_rx_sapi_version_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_rx_sapi_version rx_sapi_version_cb); void osmo_prim_srv_link_set_opened_conn_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_conn_cb opened_conn_cb); void osmo_prim_srv_link_set_closed_conn_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_conn_cb closed_conn_cb); int osmo_prim_srv_link_open(struct osmo_prim_srv_link *prim_link); diff --git a/src/prim.c b/src/prim.c index fc271a4..463463b 100644 --- a/src/prim.c +++ b/src/prim.c @@ -83,6 +83,7 @@ osmo_prim_srv_conn_cb opened_conn_cb; osmo_prim_srv_conn_cb closed_conn_cb; osmo_prim_srv_rx_cb rx_cb; + osmo_prim_srv_rx_sapi_version rx_sapi_version_cb; }; struct osmo_prim_srv { @@ -92,10 +93,106 @@ }; /****************************** + * CONTROL SAP + ******************************/ +#define OSMO_PRIM_CTL_SAPI 0xffffffff +#define OSMO_PRIM_CTL_API_VERSION 0 + +enum sap_ctl_prim_type { + SAP_CTL_PRIM_HELLO, + _SAP_CTL_PRIM_MAX +}; + +const struct value_string sap_ctl_prim_type_names[] = { + OSMO_VALUE_STRING(SAP_CTL_PRIM_HELLO), + { 0, NULL } +}; + +/* HNB_CTL_PRIM_HELLO.ind, UL */ +struct sap_ctl_hello_param { + uint16_t sapi; /* SAPI for which we negotiate version */ + uint16_t api_version; /* The intended version */ +} __attribute__ ((packed)); + +struct sap_ctl_prim { + struct osmo_prim_hdr hdr; + union { + struct sap_ctl_hello_param hello_ind; + struct sap_ctl_hello_param hello_cnf; + } u; +} __attribute__ ((packed)); + +static struct sap_ctl_prim *_sap_ctl_makeprim_hello_cnf(uint32_t sapi, uint16_t api_version) +{ + struct sap_ctl_prim *ctl_prim; + + ctl_prim = (struct sap_ctl_prim *)osmo_prim_msgb_alloc( + OSMO_PRIM_CTL_SAPI, SAP_CTL_PRIM_HELLO, PRIM_OP_CONFIRM, + sizeof(struct osmo_prim_hdr) + sizeof(struct sap_ctl_hello_param)); + ctl_prim->u.hello_cnf.sapi = sapi; + ctl_prim->u.hello_cnf.api_version = api_version; + + return ctl_prim; +} + +/****************************** * osmo_prim_srv ******************************/ #define LOGSRV(srv, lvl, fmt, args...) LOGP((srv)->link->log_cat, lvl, fmt, ## args) +static int _srv_sap_ctl_rx_hello_ind(struct osmo_prim_srv *prim_srv, struct sap_ctl_hello_param *hello_ind) +{ + struct sap_ctl_prim *prim_resp; + int rc; + + LOGSRV(prim_srv, LOGL_INFO, "Rx CTL::HELLO.ind SAPI=%u API_VERSION=%u\n", hello_ind->sapi, hello_ind->api_version); + + if (hello_ind->sapi == OSMO_PRIM_CTL_SAPI) + rc = hello_ind->api_version == OSMO_PRIM_CTL_API_VERSION ? OSMO_PRIM_CTL_API_VERSION : -1; + else if (prim_srv->link->rx_sapi_version_cb) + rc = prim_srv->link->rx_sapi_version_cb(prim_srv, hello_ind->sapi, hello_ind->api_version); + else /* Accept whatever version by default: */ + rc = hello_ind->api_version; + + if (rc < 0) { + LOGSRV(prim_srv, LOGL_ERROR, + "SAPI=%u API_VERSION=%u not supported! destroying connection\n", + hello_ind->sapi, hello_ind->api_version); + osmo_stream_srv_set_flush_and_destroy(prim_srv->stream); + return rc; + } + prim_resp = _sap_ctl_makeprim_hello_cnf(hello_ind->sapi, (uint16_t)rc); + LOGSRV(prim_srv, LOGL_INFO, "Tx CTL::HELLO.cnf SAPI=%u API_VERSION=%u\n", + hello_ind->sapi, prim_resp->u.hello_cnf.api_version); + osmo_prim_srv_send(prim_srv, prim_resp->hdr.msg); + return rc; +} + +static int _srv_sap_ctl_rx(struct osmo_prim_srv *prim_srv, struct osmo_prim_hdr *oph) +{ + switch (oph->operation) { + case PRIM_OP_INDICATION: + switch (oph->primitive) { + case SAP_CTL_PRIM_HELLO: + return _srv_sap_ctl_rx_hello_ind(prim_srv, (struct sap_ctl_hello_param *)msgb_data(oph->msg)); + default: + LOGSRV(prim_srv, LOGL_ERROR, "Rx unknown CTL SAP primitive %u (len=%u)\n", + oph->primitive, msgb_length(oph->msg)); + return -EINVAL; + } + break; + case PRIM_OP_RESPONSE: + case PRIM_OP_REQUEST: + case PRIM_OP_CONFIRM: + default: + LOGSRV(prim_srv, LOGL_ERROR, "Rx CTL SAP unexpected primitive operation %s::%s (len=%u)\n", + get_value_string(sap_ctl_prim_type_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation), + msgb_length(oph->msg)); + return -EINVAL; + } +} + static int _osmo_prim_srv_read_cb(struct osmo_stream_srv *srv) { struct osmo_prim_srv *prim_srv = osmo_stream_srv_get_data(srv); @@ -131,9 +228,15 @@ osmo_prim_init(&oph, pkth->sap, pkth->primitive, pkth->operation, msg); msgb_pull(msg, sizeof(*pkth)); - if (prim_srv->link->rx_cb) - rc = prim_srv->link->rx_cb(prim_srv, &oph); - + switch (oph.sap) { + case OSMO_PRIM_CTL_SAPI: + rc = _srv_sap_ctl_rx(prim_srv, &oph); + break; + default: + if (prim_srv->link->rx_cb) + rc = prim_srv->link->rx_cb(prim_srv, &oph); + break; + } /* as we always synchronously process the message in _osmo_prim_srv_link_rx() and * its callbacks, we can free the message here. */ msgb_free(msg); @@ -327,6 +430,12 @@ prim_link->rx_cb = rx_cb; } +void osmo_prim_srv_link_set_rx_sapi_version_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_rx_sapi_version rx_sapi_version_cb) +{ + prim_link->rx_sapi_version_cb = rx_sapi_version_cb; + +} + int osmo_prim_srv_link_open(struct osmo_prim_srv_link *prim_link) { int rc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 18:53:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 1 Dec 2021 18:53:43 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26435 ) Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... Patch Set 1: Take this as an RFC, I didn't implement & test this with TTCN3 or osmo-hnodeb yet, but I prefer getting opinions before having to rewrite all that several times. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 01 Dec 2021 18:53:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 1 19:00:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 1 Dec 2021 19:00:17 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 to look at the new patch set (#2). Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... prim: Add internal CTL SAPI to negotiate SAP versions This commits adds a generic mechansim for applications to validate support for SAPs and specific versions of them. A new special SAPI is introduced to manage inbound control messages for the protocol. In that SAPI a new primitive HELLO.ind/.cnf is added to negotiate support for versions of any given SAP. The idea is that the client upon connecting submits a HELLO.ind(SAP, VER) for each SAP it plans to use, including the version of the special CTL SAPI itself (preferrably to be checked first). Upon receiving such a message, osmo_prim_srv handles it using a special path, which ends up calling the user provided rx_sapi_version_cb(SAP, VER). In there, the user can either: * Accept the version (return same VER value) * Reject the requested version but propose another candidate version (return some positive VER value other than received VER). In this case, the client can decide whether to request another VER or close the connection. * Reject the proposed version and close the connection. Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 --- M include/osmocom/netif/prim.h M src/prim.c 2 files changed, 122 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/35/26435/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Wed Dec 1 20:18:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:18:42 +0000 Subject: Build failure of network:osmocom:latest/osmocom-latest in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61a7d8afd1523_317e2ab7faf366004061e0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmocom-latest/openSUSE_Factory_ARM/armv7l Package network:osmocom:latest/osmocom-latest failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmocom-latest Last lines of build log: [ 59s] warning: %post(make-4.3-2.19.armv7hl) scriptlet failed, exit status 127 [ 59s] patch-2.7.6-4.1 ######################################## [ 59s] rpm-build-4.17.0-2.1 ######################################## [ 59s] gcc-PIE-11-4.1 ######################################## [ 59s] zlib-devel-1.2.11-18.10 ######################################## [ 59s] post-build-checks-84.87+git20210304.df######################################## [ 59s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 59s] build-compare-20210921T214418.86d06d9-######################################## [ 59s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 59s] compat-usrmerge-build-84.87-5.1 ######################################## [ 59s] attr-2.5.1-1.8 ######################################## [ 59s] hostname-3.23-2.4 ######################################## [ 59s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 59s] warning: %post(hostname-3.23-2.4.armv7hl) scriptlet failed, exit status 127 [ 59s] build-mkbaselibs-20210120-1.2 ######################################## [ 59s] cputype-armv7-20190430-3.1 ######################################## [ 59s] kernel-obs-build-5.15.5-1.5 ######################################## [ 59s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 59s] warning: %posttrans(coreutils-9.0-1.1.armv7hl) scriptlet failed, exit status 127 [ 59s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 59s] warning: %posttrans(rpm-4.17.0-2.1.armv7hl) scriptlet failed, exit status 127 [ 60s] exit ... [ 60s] ### VM INTERACTION START ### [ 63s] [ 12.713502][ T384] sysrq: Power Off [ 63s] [ 12.714375][ T15] reboot: Power down [ 63s] ### VM INTERACTION END ### [ 63s] [ 63s] obs-arm-10 failed "build osmocom-latest.spec" at Wed Dec 1 20:18:37 UTC 2021. [ 63s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:19:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:19:33 +0000 Subject: Build failure of network:osmocom:latest/osmocom-latest in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61a7d8e689db7_317e2ab7faf3660040907a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmocom-latest/openSUSE_Factory_ARM/aarch64 Package network:osmocom:latest/osmocom-latest failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmocom-latest Last lines of build log: [ 45s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 45s] warning: %post(make-4.3-2.19.aarch64) scriptlet failed, exit status 127 [ 45s] patch-2.7.6-4.1 ######################################## [ 45s] rpm-build-4.17.0-2.1 ######################################## [ 45s] gcc-PIE-11-4.1 ######################################## [ 45s] zlib-devel-1.2.11-18.10 ######################################## [ 45s] post-build-checks-84.87+git20210304.df######################################## [ 45s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 45s] build-compare-20210921T214418.86d06d9-######################################## [ 45s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 45s] compat-usrmerge-build-84.87-5.1 ######################################## [ 45s] attr-2.5.1-1.8 ######################################## [ 45s] hostname-3.23-2.4 ######################################## [ 45s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 45s] warning: %post(hostname-3.23-2.4.aarch64) scriptlet failed, exit status 127 [ 45s] build-mkbaselibs-20211025-1.1 ######################################## [ 45s] kernel-obs-build-5.15.5-1.5 ######################################## [ 45s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 45s] warning: %posttrans(coreutils-9.0-2.1.aarch64) scriptlet failed, exit status 127 [ 45s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 45s] warning: %posttrans(rpm-4.17.0-2.1.aarch64) scriptlet failed, exit status 127 [ 46s] exit ... [ 46s] ### VM INTERACTION START ### [ 49s] [ 19.097414][ T383] sysrq: Power Off [ 49s] [ 19.098649][ T15] reboot: Power down [ 50s] ### VM INTERACTION END ### [ 50s] [ 50s] obs-arm-9 failed "build osmocom-latest.spec" at Wed Dec 1 20:19:30 UTC 2021. [ 50s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:19:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:19:33 +0000 Subject: Build failure of network:osmocom:nightly/osmocom-nightly in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61a7d8e7135e3_317e2ab7faf36600409280@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/osmocom-nightly failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: [ 67s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 67s] warning: %post(make-4.3-2.19.aarch64) scriptlet failed, exit status 127 [ 67s] patch-2.7.6-4.1 ######################################## [ 67s] rpm-build-4.17.0-2.1 ######################################## [ 67s] gcc-PIE-11-4.1 ######################################## [ 67s] zlib-devel-1.2.11-18.10 ######################################## [ 67s] post-build-checks-84.87+git20210304.df######################################## [ 68s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 68s] build-compare-20210921T214418.86d06d9-######################################## [ 68s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 68s] compat-usrmerge-build-84.87-5.1 ######################################## [ 68s] attr-2.5.1-1.8 ######################################## [ 68s] hostname-3.23-2.4 ######################################## [ 68s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 68s] warning: %post(hostname-3.23-2.4.aarch64) scriptlet failed, exit status 127 [ 68s] build-mkbaselibs-20211025-1.1 ######################################## [ 69s] kernel-obs-build-5.15.5-1.5 ######################################## [ 70s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 70s] warning: %posttrans(coreutils-9.0-2.1.aarch64) scriptlet failed, exit status 127 [ 70s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 70s] warning: %posttrans(rpm-4.17.0-2.1.aarch64) scriptlet failed, exit status 127 [ 74s] exit ... [ 74s] ### VM INTERACTION START ### [ 77s] [ 51.577077][ T384] sysrq: Power Off [ 77s] [ 51.625073][ T15] reboot: Power down [ 77s] ### VM INTERACTION END ### [ 77s] [ 77s] obs-arm-3 failed "build osmocom-nightly.spec" at Wed Dec 1 20:19:21 UTC 2021. [ 77s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:24:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:24:24 +0000 Subject: Build failure of network:osmocom:latest/orcania in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61a7da112124f_317e2ab7faf366004236aa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/orcania/openSUSE_Factory_ARM/aarch64 Package network:osmocom:latest/orcania failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest orcania Last lines of build log: [ 75s] patch-2.7.6-4.1 ######################################## [ 75s] rpm-build-4.17.0-2.1 ######################################## [ 75s] cmake-3.21.4-1.1 ######################################## [ 75s] gcc-c++-11-4.1 ######################################## [ 75s] gcc-PIE-11-4.1 ######################################## [ 75s] zlib-devel-1.2.11-18.10 ######################################## [ 75s] post-build-checks-84.87+git20210304.df######################################## [ 76s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 76s] build-compare-20210921T214418.86d06d9-######################################## [ 76s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 76s] compat-usrmerge-build-84.87-5.1 ######################################## [ 76s] attr-2.5.1-1.8 ######################################## [ 76s] hostname-3.23-2.4 ######################################## [ 76s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 76s] warning: %post(hostname-3.23-2.4.aarch64) scriptlet failed, exit status 127 [ 76s] build-mkbaselibs-20211025-1.1 ######################################## [ 77s] kernel-obs-build-5.15.5-1.5 ######################################## [ 77s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 77s] warning: %posttrans(coreutils-9.0-2.1.aarch64) scriptlet failed, exit status 127 [ 77s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 77s] warning: %posttrans(rpm-4.17.0-2.1.aarch64) scriptlet failed, exit status 127 [ 83s] exit ... [ 83s] ### VM INTERACTION START ### [ 86s] [ 59.735142][ T385] sysrq: Power Off [ 86s] [ 59.754115][ T15] reboot: Power down [ 86s] ### VM INTERACTION END ### [ 86s] [ 86s] obs-arm-3 failed "build orcania.spec" at Wed Dec 1 20:24:19 UTC 2021. [ 86s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:25:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:25:50 +0000 Subject: Build failure of network:osmocom:nightly/orcania in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61a7da63e062d_317e2ab7faf36600428411@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/orcania/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/orcania failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly orcania Last lines of build log: [ 68s] patch-2.7.6-4.1 ######################################## [ 68s] rpm-build-4.17.0-2.1 ######################################## [ 68s] cmake-3.21.4-1.1 ######################################## [ 68s] gcc-c++-11-4.1 ######################################## [ 68s] gcc-PIE-11-4.1 ######################################## [ 68s] zlib-devel-1.2.11-18.10 ######################################## [ 68s] post-build-checks-84.87+git20210304.df######################################## [ 68s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 69s] build-compare-20210921T214418.86d06d9-######################################## [ 69s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 69s] compat-usrmerge-build-84.87-5.1 ######################################## [ 69s] attr-2.5.1-1.8 ######################################## [ 69s] hostname-3.23-2.4 ######################################## [ 69s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 69s] warning: %post(hostname-3.23-2.4.aarch64) scriptlet failed, exit status 127 [ 69s] build-mkbaselibs-20211025-1.1 ######################################## [ 69s] kernel-obs-build-5.15.5-1.5 ######################################## [ 69s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 69s] warning: %posttrans(coreutils-9.0-2.1.aarch64) scriptlet failed, exit status 127 [ 69s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 69s] warning: %posttrans(rpm-4.17.0-2.1.aarch64) scriptlet failed, exit status 127 [ 70s] exit ... [ 70s] ### VM INTERACTION START ### [ 73s] [ 22.253431][ T384] sysrq: Power Off [ 73s] [ 22.254757][ T15] reboot: Power down [ 74s] ### VM INTERACTION END ### [ 74s] [ 74s] obs-arm-9 failed "build orcania.spec" at Wed Dec 1 20:25:35 UTC 2021. [ 74s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:27:49 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:27:49 +0000 Subject: Build failure of network:osmocom:latest/libgtpnl in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61a7dadf848a9_317e2ab7faf3660043657e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libgtpnl/openSUSE_Factory_ARM/aarch64 Package network:osmocom:latest/libgtpnl failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libgtpnl Last lines of build log: [ 65s] gcc-PIE-11-4.1 ######################################## [ 66s] zlib-devel-1.2.11-18.10 ######################################## [ 66s] libmnl-devel-1.0.4-2.6 ######################################## [ 66s] post-build-checks-84.87+git20210304.df######################################## [ 66s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 67s] libtool-2.4.6-8.18 ######################################## [ 67s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 67s] warning: %post(libtool-2.4.6-8.18.aarch64) scriptlet failed, exit status 127 [ 67s] build-compare-20210921T214418.86d06d9-######################################## [ 67s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 67s] compat-usrmerge-build-84.87-5.1 ######################################## [ 67s] attr-2.5.1-1.8 ######################################## [ 67s] hostname-3.23-2.4 ######################################## [ 67s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 67s] warning: %post(hostname-3.23-2.4.aarch64) scriptlet failed, exit status 127 [ 67s] build-mkbaselibs-20211025-1.1 ######################################## [ 68s] kernel-obs-build-5.15.5-1.5 ######################################## [ 68s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 68s] warning: %posttrans(coreutils-9.0-2.1.aarch64) scriptlet failed, exit status 127 [ 68s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 68s] warning: %posttrans(rpm-4.17.0-2.1.aarch64) scriptlet failed, exit status 127 [ 72s] exit ... [ 73s] ### VM INTERACTION START ### [ 76s] [ 50.630008][ T385] sysrq: Power Off [ 76s] [ 50.655522][ T15] reboot: Power down [ 76s] ### VM INTERACTION END ### [ 76s] [ 76s] obs-arm-3 failed "build libgtpnl.spec" at Wed Dec 1 20:27:37 UTC 2021. [ 76s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:30:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:30:39 +0000 Subject: Build failure of network:osmocom:nightly/yder in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61a7db779e72f_317e2ab7faf366004464a7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/yder/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/yder failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly yder Last lines of build log: [ 79s] cmake-3.21.4-1.1 ######################################## [ 79s] gcc-c++-11-4.1 ######################################## [ 79s] gcc-PIE-11-4.1 ######################################## [ 79s] zlib-devel-1.2.11-18.10 ######################################## [ 79s] orcania-devel-2.2.1-3.20 ######################################## [ 79s] systemd-mini-devel-249.7-1.1 ######################################## [ 79s] post-build-checks-84.87+git20210304.df######################################## [ 80s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 80s] build-compare-20210921T214418.86d06d9-######################################## [ 80s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 80s] compat-usrmerge-build-84.87-5.1 ######################################## [ 80s] attr-2.5.1-1.8 ######################################## [ 80s] hostname-3.23-2.4 ######################################## [ 80s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 80s] warning: %post(hostname-3.23-2.4.aarch64) scriptlet failed, exit status 127 [ 80s] build-mkbaselibs-20211025-1.1 ######################################## [ 80s] kernel-obs-build-5.15.5-1.5 ######################################## [ 80s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 80s] warning: %posttrans(coreutils-9.0-2.1.aarch64) scriptlet failed, exit status 127 [ 80s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 80s] warning: %posttrans(rpm-4.17.0-2.1.aarch64) scriptlet failed, exit status 127 [ 81s] exit ... [ 81s] ### VM INTERACTION START ### [ 84s] [ 20.721875][ T384] sysrq: Power Off [ 84s] [ 20.723709][ T15] reboot: Power down [ 84s] ### VM INTERACTION END ### [ 84s] [ 84s] obs-arm-9 failed "build yder.spec" at Wed Dec 1 20:30:31 UTC 2021. [ 84s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:32:38 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:32:38 +0000 Subject: Build failure of network:osmocom:latest/libsmpp34 in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61a7dbf2af994_317e2ab7faf3660044884e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libsmpp34/openSUSE_Factory_ARM/aarch64 Package network:osmocom:latest/libsmpp34 failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libsmpp34 Last lines of build log: [ 69s] rpm-build-4.17.0-2.1 ######################################## [ 69s] libxml2-devel-2.9.12-2.1 ######################################## [ 69s] gcc-PIE-11-4.1 ######################################## [ 69s] post-build-checks-84.87+git20210304.df######################################## [ 70s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 70s] libtool-2.4.6-8.18 ######################################## [ 70s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 70s] warning: %post(libtool-2.4.6-8.18.aarch64) scriptlet failed, exit status 127 [ 70s] build-compare-20210921T214418.86d06d9-######################################## [ 70s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 70s] compat-usrmerge-build-84.87-5.1 ######################################## [ 70s] attr-2.5.1-1.8 ######################################## [ 70s] hostname-3.23-2.4 ######################################## [ 70s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 70s] warning: %post(hostname-3.23-2.4.aarch64) scriptlet failed, exit status 127 [ 70s] build-mkbaselibs-20211025-1.1 ######################################## [ 71s] kernel-obs-build-5.15.5-1.5 ######################################## [ 72s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 72s] warning: %posttrans(coreutils-9.0-2.1.aarch64) scriptlet failed, exit status 127 [ 72s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 72s] warning: %posttrans(rpm-4.17.0-2.1.aarch64) scriptlet failed, exit status 127 [ 76s] exit ... [ 76s] ### VM INTERACTION START ### [ 79s] [ 51.986785][ T385] sysrq: Power Off [ 79s] [ 51.996653][ T15] reboot: Power down [ 79s] ### VM INTERACTION END ### [ 79s] [ 79s] obs-arm-3 failed "build libsmpp34.spec" at Wed Dec 1 20:32:34 UTC 2021. [ 79s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:36:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:36:03 +0000 Subject: Build failure of network:osmocom:nightly/sofia-sip in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61a7dcc66798_317e2ab7faf36600455512@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/sofia-sip/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/sofia-sip failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly sofia-sip Last lines of build log: [ 85s] glib2-devel-2.70.1-1.1 ######################################## [ 85s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 85s] warning: %filetriggerin(glib2-tools-2.70.1-1.1.aarch64) scriptlet failed, exit status 127 [ 85s] gcc-c++-11-4.1 ######################################## [ 85s] gcc-PIE-11-4.1 ######################################## [ 85s] post-build-checks-84.87+git20210304.df######################################## [ 85s] build-compare-20210921T214418.86d06d9-######################################## [ 85s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 85s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 85s] compat-usrmerge-build-84.87-5.1 ######################################## [ 85s] attr-2.5.1-1.8 ######################################## [ 85s] hostname-3.23-2.4 ######################################## [ 85s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 85s] warning: %post(hostname-3.23-2.4.aarch64) scriptlet failed, exit status 127 [ 85s] build-mkbaselibs-20211125-1.1 ######################################## [ 85s] fdupes-2.1.2-1.11 ######################################## [ 85s] kernel-obs-build-5.15.5-1.5 ######################################## [ 85s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 85s] warning: %posttrans(coreutils-9.0-2.1.aarch64) scriptlet failed, exit status 127 [ 85s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 85s] warning: %posttrans(rpm-4.17.0-2.1.aarch64) scriptlet failed, exit status 127 [ 86s] exit ... [ 86s] ### VM INTERACTION START ### [ 89s] [ 21.751442][ T383] sysrq: Power Off [ 89s] [ 21.753126][ T194] reboot: Power down [ 90s] ### VM INTERACTION END ### [ 90s] [ 90s] obs-arm-9 failed "build sofia-sip.spec" at Wed Dec 1 20:35:54 UTC 2021. [ 90s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:36:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:36:20 +0000 Subject: Build failure of network:osmocom:latest/yder in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61a7dce0a0dd1_317e2ab7faf366004563b7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/yder/openSUSE_Factory_ARM/aarch64 Package network:osmocom:latest/yder failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest yder Last lines of build log: [ 78s] cmake-3.21.4-1.1 ######################################## [ 78s] gcc-c++-11-4.1 ######################################## [ 78s] gcc-PIE-11-4.1 ######################################## [ 78s] zlib-devel-1.2.11-18.10 ######################################## [ 78s] orcania-devel-2.2.1-5.19 ######################################## [ 78s] systemd-mini-devel-249.7-1.1 ######################################## [ 78s] post-build-checks-84.87+git20210304.df######################################## [ 78s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 79s] build-compare-20210921T214418.86d06d9-######################################## [ 79s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 79s] compat-usrmerge-build-84.87-5.1 ######################################## [ 79s] attr-2.5.1-1.8 ######################################## [ 79s] hostname-3.23-2.4 ######################################## [ 79s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 79s] warning: %post(hostname-3.23-2.4.aarch64) scriptlet failed, exit status 127 [ 79s] build-mkbaselibs-20211125-1.1 ######################################## [ 80s] kernel-obs-build-5.15.5-1.5 ######################################## [ 83s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 83s] warning: %posttrans(coreutils-9.0-2.1.aarch64) scriptlet failed, exit status 127 [ 83s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 83s] warning: %posttrans(rpm-4.17.0-2.1.aarch64) scriptlet failed, exit status 127 [ 86s] exit ... [ 86s] ### VM INTERACTION START ### [ 89s] [ 60.890467][ T402] sysrq: Power Off [ 89s] [ 60.895639][ T15] reboot: Power down [ 89s] ### VM INTERACTION END ### [ 89s] [ 89s] obs-arm-1 failed "build yder.spec" at Wed Dec 1 20:36:17 UTC 2021. [ 89s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:37:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:37:28 +0000 Subject: Build failure of network:osmocom:nightly/osmocom-nightly in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61a7dd1b5de6c_317e2ab7faf36600459199@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/osmocom-nightly failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: [ 30s] warning: %post(make-4.3-2.19.armv7hl) scriptlet failed, exit status 127 [ 30s] patch-2.7.6-4.1 ######################################## [ 30s] rpm-build-4.17.0-2.1 ######################################## [ 30s] gcc-PIE-11-4.1 ######################################## [ 30s] zlib-devel-1.2.11-18.10 ######################################## [ 30s] post-build-checks-84.87+git20210304.df######################################## [ 30s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 30s] build-compare-20210921T214418.86d06d9-######################################## [ 30s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 30s] compat-usrmerge-build-84.87-5.1 ######################################## [ 30s] attr-2.5.1-1.8 ######################################## [ 30s] hostname-3.23-2.4 ######################################## [ 30s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 30s] warning: %post(hostname-3.23-2.4.armv7hl) scriptlet failed, exit status 127 [ 30s] build-mkbaselibs-20210120-1.2 ######################################## [ 30s] cputype-armv7-20190430-3.1 ######################################## [ 31s] kernel-obs-build-5.15.5-1.5 ######################################## [ 31s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 31s] warning: %posttrans(coreutils-9.0-1.1.armv7hl) scriptlet failed, exit status 127 [ 31s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 31s] warning: %posttrans(rpm-4.17.0-2.1.armv7hl) scriptlet failed, exit status 127 [ 37s] exit ... [ 37s] ### VM INTERACTION START ### [ 40s] [ 21.343548][ T384] sysrq: Power Off [ 40s] [ 21.344277][ T15] reboot: Power down [ 40s] ### VM INTERACTION END ### [ 40s] [ 40s] obs-arm-11 failed "build osmocom-nightly.spec" at Wed Dec 1 20:37:16 UTC 2021. [ 40s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:38:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:38:36 +0000 Subject: Build failure of network:osmocom:nightly/libgtpnl in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61a7dd5cc8ac7_317e2ab7faf36600462265@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/libgtpnl failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [ 27s] gcc-PIE-11-4.1 ######################################## [ 27s] zlib-devel-1.2.11-18.10 ######################################## [ 27s] libmnl-devel-1.0.4-2.6 ######################################## [ 27s] post-build-checks-84.87+git20210304.df######################################## [ 28s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 28s] libtool-2.4.6-8.18 ######################################## [ 28s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 28s] warning: %post(libtool-2.4.6-8.18.aarch64) scriptlet failed, exit status 127 [ 28s] build-compare-20210921T214418.86d06d9-######################################## [ 28s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 28s] compat-usrmerge-build-84.87-5.1 ######################################## [ 28s] attr-2.5.1-1.8 ######################################## [ 28s] hostname-3.23-2.4 ######################################## [ 28s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 28s] warning: %post(hostname-3.23-2.4.aarch64) scriptlet failed, exit status 127 [ 28s] build-mkbaselibs-20211125-1.1 ######################################## [ 28s] kernel-obs-build-5.15.5-1.5 ######################################## [ 28s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 28s] warning: %posttrans(coreutils-9.0-2.1.aarch64) scriptlet failed, exit status 127 [ 28s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 28s] warning: %posttrans(rpm-4.17.0-2.1.aarch64) scriptlet failed, exit status 127 [ 29s] exit ... [ 29s] ### VM INTERACTION START ### [ 32s] [ 21.863023][ T418] sysrq: Power Off [ 32s] [ 21.865055][ T15] reboot: Power down [ 33s] ### VM INTERACTION END ### [ 33s] [ 33s] obs-arm-7 failed "build libgtpnl.spec" at Wed Dec 1 20:38:23 UTC 2021. [ 33s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:41:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:41:43 +0000 Subject: Build failure of network:osmocom:nightly/libsmpp34 in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61a7de2a67662_317e2ab7faf366004719a2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/libsmpp34 failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: [ 75s] rpm-build-4.17.0-2.1 ######################################## [ 75s] libxml2-devel-2.9.12-2.1 ######################################## [ 75s] gcc-PIE-11-4.1 ######################################## [ 75s] post-build-checks-84.87+git20210304.df######################################## [ 76s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 76s] libtool-2.4.6-8.18 ######################################## [ 76s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 76s] warning: %post(libtool-2.4.6-8.18.aarch64) scriptlet failed, exit status 127 [ 76s] build-compare-20210921T214418.86d06d9-######################################## [ 76s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 77s] compat-usrmerge-build-84.87-5.1 ######################################## [ 77s] attr-2.5.1-1.8 ######################################## [ 77s] hostname-3.23-2.4 ######################################## [ 77s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 77s] warning: %post(hostname-3.23-2.4.aarch64) scriptlet failed, exit status 127 [ 77s] build-mkbaselibs-20211125-1.1 ######################################## [ 78s] kernel-obs-build-5.15.5-1.5 ######################################## [ 78s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 78s] warning: %posttrans(coreutils-9.0-2.1.aarch64) scriptlet failed, exit status 127 [ 78s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 79s] warning: %posttrans(rpm-4.17.0-2.1.aarch64) scriptlet failed, exit status 127 [ 84s] exit ... [ 84s] ### VM INTERACTION START ### [ 87s] [ 59.025374][ T385] sysrq: Power Off [ 87s] [ 59.038355][ T15] reboot: Power down [ 87s] ### VM INTERACTION END ### [ 87s] [ 87s] obs-arm-2 failed "build libsmpp34.spec" at Wed Dec 1 20:41:30 UTC 2021. [ 87s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:42:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:42:34 +0000 Subject: Build failure of network:osmocom:nightly/orcania in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61a7de4ab9a74_317e2ab7faf36600474156@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/orcania/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/orcania failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly orcania Last lines of build log: [ 53s] rpm-build-4.17.0-2.1 ######################################## [ 53s] cmake-3.21.4-1.1 ######################################## [ 53s] gcc-c++-11-4.1 ######################################## [ 53s] gcc-PIE-11-4.1 ######################################## [ 53s] zlib-devel-1.2.11-18.10 ######################################## [ 53s] post-build-checks-84.87+git20210304.df######################################## [ 53s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 53s] build-compare-20210921T214418.86d06d9-######################################## [ 53s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 53s] compat-usrmerge-build-84.87-5.1 ######################################## [ 53s] attr-2.5.1-1.8 ######################################## [ 53s] hostname-3.23-2.4 ######################################## [ 53s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 53s] warning: %post(hostname-3.23-2.4.armv7hl) scriptlet failed, exit status 127 [ 53s] build-mkbaselibs-20210120-1.2 ######################################## [ 53s] cputype-armv7-20190430-3.1 ######################################## [ 53s] kernel-obs-build-5.15.5-1.5 ######################################## [ 53s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 53s] warning: %posttrans(coreutils-9.0-1.1.armv7hl) scriptlet failed, exit status 127 [ 53s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 53s] warning: %posttrans(rpm-4.17.0-2.1.armv7hl) scriptlet failed, exit status 127 [ 54s] exit ... [ 54s] ### VM INTERACTION START ### [ 57s] [ 15.397880][ T383] sysrq: Power Off [ 57s] [ 15.398542][ T15] reboot: Power down [ 57s] ### VM INTERACTION END ### [ 57s] [ 57s] obs-arm-10 failed "build orcania.spec" at Wed Dec 1 20:42:31 UTC 2021. [ 57s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:51:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:51:21 +0000 Subject: Build failure of network:osmocom:nightly/sofia-sip in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61a7e063d61c6_317e2ab7faf366004969f7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/sofia-sip/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/sofia-sip failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly sofia-sip Last lines of build log: [ 68s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 68s] warning: %filetriggerin(glib2-tools-2.70.1-1.1.armv7hl) scriptlet failed, exit status 127 [ 68s] gcc-c++-11-4.1 ######################################## [ 68s] gcc-PIE-11-4.1 ######################################## [ 68s] post-build-checks-84.87+git20210304.df######################################## [ 68s] build-compare-20210921T214418.86d06d9-######################################## [ 68s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 68s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 68s] compat-usrmerge-build-84.87-5.1 ######################################## [ 68s] attr-2.5.1-1.8 ######################################## [ 68s] hostname-3.23-2.4 ######################################## [ 68s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 68s] warning: %post(hostname-3.23-2.4.armv7hl) scriptlet failed, exit status 127 [ 68s] build-mkbaselibs-20210120-1.2 ######################################## [ 68s] cputype-armv7-20190430-3.1 ######################################## [ 68s] fdupes-2.1.2-1.11 ######################################## [ 68s] kernel-obs-build-5.15.5-1.5 ######################################## [ 68s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 68s] warning: %posttrans(coreutils-9.0-1.1.armv7hl) scriptlet failed, exit status 127 [ 68s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 68s] warning: %posttrans(rpm-4.17.0-2.1.armv7hl) scriptlet failed, exit status 127 [ 69s] exit ... [ 69s] ### VM INTERACTION START ### [ 72s] [ 16.202190][ T384] sysrq: Power Off [ 72s] [ 16.216209][ T15] reboot: Power down [ 72s] ### VM INTERACTION END ### [ 72s] [ 72s] obs-arm-11 failed "build sofia-sip.spec" at Wed Dec 1 20:51:18 UTC 2021. [ 72s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:55:20 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:55:20 +0000 Subject: Build failure of network:osmocom:nightly/libgtpnl in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61a7e1518991e_317e2ab7faf36600507244@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/libgtpnl failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [ 58s] zlib-devel-1.2.11-18.10 ######################################## [ 58s] libmnl-devel-1.0.4-2.6 ######################################## [ 58s] post-build-checks-84.87+git20210304.df######################################## [ 58s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 58s] libtool-2.4.6-8.18 ######################################## [ 58s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 58s] warning: %post(libtool-2.4.6-8.18.armv7hl) scriptlet failed, exit status 127 [ 58s] build-compare-20210921T214418.86d06d9-######################################## [ 58s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 58s] compat-usrmerge-build-84.87-5.1 ######################################## [ 58s] attr-2.5.1-1.8 ######################################## [ 58s] hostname-3.23-2.4 ######################################## [ 58s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 58s] warning: %post(hostname-3.23-2.4.armv7hl) scriptlet failed, exit status 127 [ 58s] build-mkbaselibs-20210120-1.2 ######################################## [ 58s] cputype-armv7-20190430-3.1 ######################################## [ 58s] kernel-obs-build-5.15.5-1.5 ######################################## [ 58s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 58s] warning: %posttrans(coreutils-9.0-1.1.armv7hl) scriptlet failed, exit status 127 [ 58s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 58s] warning: %posttrans(rpm-4.17.0-2.1.armv7hl) scriptlet failed, exit status 127 [ 59s] exit ... [ 59s] ### VM INTERACTION START ### [ 62s] [ 14.384434][ T383] sysrq: Power Off [ 62s] [ 14.385160][ T15] reboot: Power down [ 62s] ### VM INTERACTION END ### [ 62s] [ 62s] obs-arm-11 failed "build libgtpnl.spec" at Wed Dec 1 20:55:11 UTC 2021. [ 62s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:58:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:58:27 +0000 Subject: Build failure of network:osmocom:latest/orcania in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61a7e2072237f_317e2ab7faf366005153a0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/orcania/openSUSE_Factory_ARM/armv7l Package network:osmocom:latest/orcania failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest orcania Last lines of build log: [ 49s] rpm-build-4.17.0-2.1 ######################################## [ 49s] cmake-3.21.4-1.1 ######################################## [ 49s] gcc-c++-11-4.1 ######################################## [ 49s] gcc-PIE-11-4.1 ######################################## [ 49s] zlib-devel-1.2.11-18.10 ######################################## [ 49s] post-build-checks-84.87+git20210304.df######################################## [ 50s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 50s] build-compare-20210921T214418.86d06d9-######################################## [ 50s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 50s] compat-usrmerge-build-84.87-5.1 ######################################## [ 50s] attr-2.5.1-1.8 ######################################## [ 50s] hostname-3.23-2.4 ######################################## [ 50s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 50s] warning: %post(hostname-3.23-2.4.armv7hl) scriptlet failed, exit status 127 [ 50s] build-mkbaselibs-20210120-1.2 ######################################## [ 50s] cputype-armv7-20190430-3.1 ######################################## [ 50s] kernel-obs-build-5.15.5-1.5 ######################################## [ 51s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 51s] warning: %posttrans(coreutils-9.0-1.1.armv7hl) scriptlet failed, exit status 127 [ 51s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 51s] warning: %posttrans(rpm-4.17.0-2.1.armv7hl) scriptlet failed, exit status 127 [ 52s] exit ... [ 52s] ### VM INTERACTION START ### [ 56s] [ 31.129822][ T384] sysrq: Power Off [ 56s] [ 31.171507][ T15] reboot: Power down [ 56s] ### VM INTERACTION END ### [ 56s] [ 56s] obs-arm-6 failed "build orcania.spec" at Wed Dec 1 20:58:22 UTC 2021. [ 56s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 20:59:01 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 20:59:01 +0000 Subject: Build failure of network:osmocom:nightly/libsmpp34 in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61a7e2214e46f_317e2ab7faf366005168cd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/libsmpp34 failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: [ 42s] libxml2-devel-2.9.12-2.1 ######################################## [ 42s] gcc-PIE-11-4.1 ######################################## [ 42s] post-build-checks-84.87+git20210304.df######################################## [ 42s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 42s] libtool-2.4.6-8.18 ######################################## [ 42s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 42s] warning: %post(libtool-2.4.6-8.18.armv7hl) scriptlet failed, exit status 127 [ 42s] build-compare-20210921T214418.86d06d9-######################################## [ 42s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 42s] compat-usrmerge-build-84.87-5.1 ######################################## [ 42s] attr-2.5.1-1.8 ######################################## [ 42s] hostname-3.23-2.4 ######################################## [ 42s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 42s] warning: %post(hostname-3.23-2.4.armv7hl) scriptlet failed, exit status 127 [ 42s] build-mkbaselibs-20210120-1.2 ######################################## [ 42s] cputype-armv7-20190430-3.1 ######################################## [ 43s] kernel-obs-build-5.15.5-1.5 ######################################## [ 43s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 43s] warning: %posttrans(coreutils-9.0-1.1.armv7hl) scriptlet failed, exit status 127 [ 43s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 43s] warning: %posttrans(rpm-4.17.0-2.1.armv7hl) scriptlet failed, exit status 127 [ 43s] exit ... [ 43s] ### VM INTERACTION START ### [ 46s] [ 13.059339][ T383] sysrq: Power Off [ 46s] [ 13.059967][ T15] reboot: Power down [ 46s] ### VM INTERACTION END ### [ 46s] [ 46s] obs-arm-11 failed "build libsmpp34.spec" at Wed Dec 1 20:58:55 UTC 2021. [ 46s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 21:02:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 21:02:08 +0000 Subject: Build failure of network:osmocom:latest/libgtpnl in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61a7e2df9319f_317e2ab7faf3660052643@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libgtpnl/openSUSE_Factory_ARM/armv7l Package network:osmocom:latest/libgtpnl failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest libgtpnl Last lines of build log: [ 42s] zlib-devel-1.2.11-18.10 ######################################## [ 42s] libmnl-devel-1.0.4-2.6 ######################################## [ 42s] post-build-checks-84.87+git20210304.df######################################## [ 42s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 42s] libtool-2.4.6-8.18 ######################################## [ 42s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 42s] warning: %post(libtool-2.4.6-8.18.armv7hl) scriptlet failed, exit status 127 [ 42s] build-compare-20210921T214418.86d06d9-######################################## [ 42s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 42s] compat-usrmerge-build-84.87-5.1 ######################################## [ 42s] attr-2.5.1-1.8 ######################################## [ 42s] hostname-3.23-2.4 ######################################## [ 42s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 42s] warning: %post(hostname-3.23-2.4.armv7hl) scriptlet failed, exit status 127 [ 42s] build-mkbaselibs-20210120-1.2 ######################################## [ 42s] cputype-armv7-20190430-3.1 ######################################## [ 43s] kernel-obs-build-5.15.5-1.5 ######################################## [ 43s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 43s] warning: %posttrans(coreutils-9.0-1.1.armv7hl) scriptlet failed, exit status 127 [ 43s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 43s] warning: %posttrans(rpm-4.17.0-2.1.armv7hl) scriptlet failed, exit status 127 [ 44s] exit ... [ 44s] ### VM INTERACTION START ### [ 48s] [ 30.268096][ T384] sysrq: Power Off [ 48s] [ 30.272949][ T15] reboot: Power down [ 48s] ### VM INTERACTION END ### [ 48s] [ 48s] obs-arm-6 failed "build libgtpnl.spec" at Wed Dec 1 21:01:57 UTC 2021. [ 48s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 1 21:05:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 01 Dec 2021 21:05:50 +0000 Subject: Build failure of network:osmocom:latest/libsmpp34 in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61a7e3c6eef55_317e2ab7faf3660053687b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libsmpp34/openSUSE_Factory_ARM/armv7l Package network:osmocom:latest/libsmpp34 failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest libsmpp34 Last lines of build log: [ 44s] libxml2-devel-2.9.12-2.1 ######################################## [ 44s] gcc-PIE-11-4.1 ######################################## [ 44s] post-build-checks-84.87+git20210304.df######################################## [ 44s] rpmlint-mini-2.1+git20211126.ebc84d5-2######################################## [ 44s] libtool-2.4.6-8.18 ######################################## [ 44s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 44s] warning: %post(libtool-2.4.6-8.18.armv7hl) scriptlet failed, exit status 127 [ 44s] build-compare-20210921T214418.86d06d9-######################################## [ 44s] brp-check-suse-84.87+git20211116.6c5fe######################################## [ 44s] compat-usrmerge-build-84.87-5.1 ######################################## [ 44s] attr-2.5.1-1.8 ######################################## [ 44s] hostname-3.23-2.4 ######################################## [ 44s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 44s] warning: %post(hostname-3.23-2.4.armv7hl) scriptlet failed, exit status 127 [ 44s] build-mkbaselibs-20210120-1.2 ######################################## [ 44s] cputype-armv7-20190430-3.1 ######################################## [ 45s] kernel-obs-build-5.15.5-1.5 ######################################## [ 45s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 45s] warning: %posttrans(coreutils-9.0-1.1.armv7hl) scriptlet failed, exit status 127 [ 45s] error: failed to exec scriptlet interpreter /bin/sh: No such file or directory [ 45s] warning: %posttrans(rpm-4.17.0-2.1.armv7hl) scriptlet failed, exit status 127 [ 46s] exit ... [ 47s] ### VM INTERACTION START ### [ 50s] [ 27.032761][ T383] sysrq: Power Off [ 50s] [ 27.063766][ T15] reboot: Power down [ 51s] ### VM INTERACTION END ### [ 51s] [ 51s] obs-arm-6 failed "build libsmpp34.spec" at Wed Dec 1 21:05:36 UTC 2021. [ 51s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Dec 2 01:51:11 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 2 Dec 2021 01:51:11 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask In-Reply-To: References: Message-ID: Hello Jenkins Builder, neels, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 to look at the new patch set (#3). Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask ...................................................................... libmsc: ran_iu_make_security_mode_command(): clarify UIA mask Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a --- M src/libmsc/ran_msg_iu.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/10/26410/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a Gerrit-Change-Number: 26410 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 01:51:11 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 2 Dec 2021 01:51:11 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: fixeria has uploaded a new patch set (#3) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() ...................................................................... ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() Since ranap_new_msg_sec_mod_cmd2() doesn't support UEA0 we must not pass it to it. The reason behind is that UEA0 can't passed in the TLV of a SecurityCommand and is implicit UEA0 if the TLV is not present. Fixes: 505a94a610fc ("Make UTRAN encryption algorithms configurable") Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e --- M src/libmsc/ran_msg_iu.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/91/26391/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 01:54:35 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 2 Dec 2021 01:54:35 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 ) Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask ...................................................................... Patch Set 3: Code-Review+2 (1 comment) So we have 1+1 here (by Harald and Neels). Given that Pau revoked his vote and changed to neutral, I am adding CR+2 and going to merge this patch soon. If I missed something, let me know. https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/26410/2/src/libmsc/ran_msg_iu.c at 380 PS2, Line 380: | (1 << OSMO_UTRAN_UIA2); > (would prefer the comment on its own line, and replace "it" with something explanatory like "make th [?] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a Gerrit-Change-Number: 26410 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 02 Dec 2021 01:54:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 01:56:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 2 Dec 2021 01:56:39 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() ...................................................................... Patch Set 3: > Patch Set 2: Code-Review+1 > > Can we rebase it on top of https://gerrit.osmocom.org/c/osmo-msc/+/26409? I rebased this one on top of my patch and changed the code a bit for the sake of consistency. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 02 Dec 2021 01:56:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 01:58:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 2 Dec 2021 01:58:50 +0000 Subject: Change in pysim[master]: filesystem: actively probe applications In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26431 ) Change subject: filesystem: actively probe applications ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3fa77a68664fe50d690a18adfb1ae1a88a189827 Gerrit-Change-Number: 26431 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 02 Dec 2021 01:58:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 09:48:25 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 2 Dec 2021 09:48:25 +0000 Subject: Change in libosmo-netif[master]: stream: Add support for AF_UNIX sockets In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26434 ) Change subject: stream: Add support for AF_UNIX sockets ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmo-netif/+/26434/2/src/stream.c File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26434/2/src/stream.c at 796 PS2, Line 796: default: Since the setter functions prevent sk_* to become just any value I'd prefer the default case here and elsewhere in the code to error as well. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 Gerrit-Change-Number: 26434 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Arran Cudbard-bell Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 02 Dec 2021 09:48:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 12:45:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 2 Dec 2021 12:45:48 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/26391/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/26391/3//COMMIT_MSG at 7 PS3, Line 7: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() I think the commit message can be improved. I don't really understand the first line. Not even sure whether passwd is a noun or verb, the sentence makes no sense to me. "not pass it to it." <-- same here. https://gerrit.osmocom.org/c/osmo-msc/+/26391/3//COMMIT_MSG at 10 PS3, Line 10: The reason behind is that UEA0 can't passed in the TLV of a SecurityCommand and is implicit This sentence is also written in a really strange way. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 02 Dec 2021 12:45:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 12:48:52 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 2 Dec 2021 12:48:52 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26391/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/26391/3//COMMIT_MSG at 7 PS3, Line 7: passwd Also, no /etc/passwd here :P -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 02 Dec 2021 12:48:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 12:56:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 2 Dec 2021 12:56:51 +0000 Subject: Change in libosmo-netif[master]: stream: Add support for AF_UNIX sockets In-Reply-To: References: Message-ID: Hello Jenkins Builder, Arran Cudbard-bell, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 to look at the new patch set (#3). Change subject: stream: Add support for AF_UNIX sockets ...................................................................... stream: Add support for AF_UNIX sockets Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 --- M include/osmocom/netif/stream.h M src/stream.c 2 files changed, 233 insertions(+), 70 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/34/26434/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 Gerrit-Change-Number: 26434 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Arran Cudbard-bell Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 13:37:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 2 Dec 2021 13:37:45 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 to look at the new patch set (#9). Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Initial implementation of LowerLayer UD Socket The LLSK socket is an interface allowing thid-parties to implement and hook their RLC/MAC/RRC stack to osmo-hnodbe, which takes care of interconnection with the rest of the RAN and core network (Iuh, RTP, GTP-U, etc.). Related: SYS#5516 Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d --- A doc/hnodeb.msc M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_ctl.c A src/osmo-hnodeb/llsk_iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 20 files changed, 1,255 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/57/26357/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 20:36:54 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 2 Dec 2021 20:36:54 +0000 Subject: Change in docker-playground[master]: open5gs-latest: fix Dockerfile: remove custom mirror list References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26436 ) Change subject: open5gs-latest: fix Dockerfile: remove custom mirror list ...................................................................... open5gs-latest: fix Dockerfile: remove custom mirror list I was experiencing problems with Debian's mirrors while working on this image, so I had to use a custom mirror list. This is a left- over that should have been removed before merging. Change-Id: I313bb604b09293bff8753edeefa7f78cafc9cc22 Related: SYS#5602 --- M open5gs-latest/Dockerfile 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/36/26436/1 diff --git a/open5gs-latest/Dockerfile b/open5gs-latest/Dockerfile index ba8c866..325062f 100644 --- a/open5gs-latest/Dockerfile +++ b/open5gs-latest/Dockerfile @@ -3,9 +3,6 @@ MAINTAINER Vadim Yanitskiy -# TODO: remove me! -ADD sources.list /etc/apt/sources.list - RUN apt-get update && \ apt-get install -y --no-install-recommends \ ca-certificates \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I313bb604b09293bff8753edeefa7f78cafc9cc22 Gerrit-Change-Number: 26436 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 20:36:54 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 2 Dec 2021 20:36:54 +0000 Subject: Change in docker-playground[master]: Revert "osmo-msc-latest: centos8: add libdbi-dbd-sqlite" References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26437 ) Change subject: Revert "osmo-msc-latest: centos8: add libdbi-dbd-sqlite" ...................................................................... Revert "osmo-msc-latest: centos8: add libdbi-dbd-sqlite" This reverts commit 9a526e876f6a939f8bf6531b40876d1642a1e997. There is no need to install this dependency explicitly anymore. Change-Id: I093f17981f5a09346cf46fe33b94c4b7833757c5 --- M osmo-msc-latest/Dockerfile 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/37/26437/1 diff --git a/osmo-msc-latest/Dockerfile b/osmo-msc-latest/Dockerfile index cc18602..8b24cb5 100644 --- a/osmo-msc-latest/Dockerfile +++ b/osmo-msc-latest/Dockerfile @@ -5,7 +5,6 @@ # Arguments used after FROM must be specified again ARG DISTRO -# libdbi-dbd-sqlite can be removed after osmo-msc > 1.7.0 release RUN case "$DISTRO" in \ debian*) \ apt-get update && \ @@ -15,7 +14,6 @@ ;; \ centos*) \ dnf install -y \ - libdbi-dbd-sqlite \ osmo-msc \ ;; \ esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I093f17981f5a09346cf46fe33b94c4b7833757c5 Gerrit-Change-Number: 26437 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 20:42:11 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 2 Dec 2021 20:42:11 +0000 Subject: Change in docker-playground[master]: Revert "osmocom-bb-host-master: install python-enum as fake_trx depen... References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26438 ) Change subject: Revert "osmocom-bb-host-master: install python-enum as fake_trx dependency" ...................................................................... Revert "osmocom-bb-host-master: install python-enum as fake_trx dependency" This reverts commit c034da05476429f1470c1245ad949fe45f08dc97. Python 2 is EOL, we are using Python 3 now with built-in enums. Change-Id: I6aa653f2165bb9a81aa8253fabc0fb436bcba009 --- M osmocom-bb-host-master/Dockerfile 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/38/26438/1 diff --git a/osmocom-bb-host-master/Dockerfile b/osmocom-bb-host-master/Dockerfile index 2e86767..3f9c108 100644 --- a/osmocom-bb-host-master/Dockerfile +++ b/osmocom-bb-host-master/Dockerfile @@ -18,11 +18,10 @@ rm /tmp/Release.key && \ echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list -# python-enum34 is a dependecy of fake_trx as long we're using python2 ADD $OSMOCOM_REPO/Release /tmp/Release RUN apt-get update && \ apt-get install -y --no-install-recommends \ - libosmocore-dev python-enum34 && \ + libosmocore-dev && \ apt-get clean WORKDIR /tmp -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6aa653f2165bb9a81aa8253fabc0fb436bcba009 Gerrit-Change-Number: 26438 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 20:56:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 2 Dec 2021 20:56:39 +0000 Subject: Change in docker-playground[master]: ttcn3-msc-test/osmo-msc.cfg: remove deprecated 'periodic location upd... References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26439 ) Change subject: ttcn3-msc-test/osmo-msc.cfg: remove deprecated 'periodic location update' ...................................................................... ttcn3-msc-test/osmo-msc.cfg: remove deprecated 'periodic location update' Let's keep osmo-msc.cfg up to date with the one in osmo-ttcn3-hacks. Change-Id: I0576f21230dff2c96060430ef9ffb6001d19542d Related: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26415 --- M ttcn3-msc-test/osmo-msc.cfg 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/39/26439/1 diff --git a/ttcn3-msc-test/osmo-msc.cfg b/ttcn3-msc-test/osmo-msc.cfg index 946ba14..be7acbd 100644 --- a/ttcn3-msc-test/osmo-msc.cfg +++ b/ttcn3-msc-test/osmo-msc.cfg @@ -73,7 +73,6 @@ authentication optional rrlp mode none mm info 0 - periodic location update 30 msc assign-tmsi cs7-instance-a 0 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0576f21230dff2c96060430ef9ffb6001d19542d Gerrit-Change-Number: 26439 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 20:56:40 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 2 Dec 2021 20:56:40 +0000 Subject: Change in docker-playground[master]: ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26440 ) Change subject: ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN ...................................................................... ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN The Iu/UMTS specific test cases in ttcn3-msc-test expect no encryption in Security Mode Command by default (only integrity), while osmo-msc would permit both UEA1 and UEA2 unless configured explicitly. This causes the related test cases to fail. A similar change was merged to osmo-ttcn3-hacks, updating the osmo-msc.cfg in there, however the actual configuration file that is used to execute test cases on Jenkins was not updated. Change-Id: I43f80e3fbd73be21fb89006e16de0e1df9ba03f5 Related: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26389 Fixes: OS#5333 --- M ttcn3-msc-test/osmo-msc.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/40/26440/1 diff --git a/ttcn3-msc-test/osmo-msc.cfg b/ttcn3-msc-test/osmo-msc.cfg index be7acbd..903b5bd 100644 --- a/ttcn3-msc-test/osmo-msc.cfg +++ b/ttcn3-msc-test/osmo-msc.cfg @@ -70,6 +70,7 @@ short name OsmoMSC long name OsmoMSC encryption a5 0 + encryption uea 0 authentication optional rrlp mode none mm info 0 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I43f80e3fbd73be21fb89006e16de0e1df9ba03f5 Gerrit-Change-Number: 26440 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 2 21:17:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 2 Dec 2021 21:17:32 +0000 Subject: Change in docker-playground[master]: ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN In-Reply-To: References: Message-ID: fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/docker-playground/+/26440 ) Change subject: ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN ...................................................................... ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN The Iu/UMTS specific test cases in ttcn3-msc-test expect no encryption in Security Mode Command by default (only integrity), while osmo-msc would permit both UEA1 and UEA2 unless configured explicitly. This causes the related test cases to fail. A similar change was merged to osmo-ttcn3-hacks, updating the osmo-msc.cfg in there, however the actual configuration file that is used to execute test cases on Jenkins was not updated. Change-Id: I43f80e3fbd73be21fb89006e16de0e1df9ba03f5 Related: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26389 Fixes: OS#5333 --- M ttcn3-msc-test/osmo-msc.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/40/26440/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I43f80e3fbd73be21fb89006e16de0e1df9ba03f5 Gerrit-Change-Number: 26440 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 06:37:08 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 3 Dec 2021 06:37:08 +0000 Subject: Change in libosmo-netif[master]: stream: Add support for AF_UNIX sockets In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26434 ) Change subject: stream: Add support for AF_UNIX sockets ...................................................................... Patch Set 3: (3 comments) https://gerrit.osmocom.org/c/libosmo-netif/+/26434/2/src/stream.c File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26434/2/src/stream.c at 796 PS2, Line 796: default: > Since the setter functions prevent sk_* to become just any value I'd prefer the default case here an [?] Done https://gerrit.osmocom.org/c/libosmo-netif/+/26434/3/src/stream.c File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26434/3/src/stream.c at 358 PS3, Line 358: default: What about here? https://gerrit.osmocom.org/c/libosmo-netif/+/26434/3/src/stream.c at 409 PS3, Line 409: default: And here? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 Gerrit-Change-Number: 26434 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Arran Cudbard-bell Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 03 Dec 2021 06:37:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 07:15:33 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 3 Dec 2021 07:15:33 +0000 Subject: Change in docker-playground[master]: open5gs-latest: fix Dockerfile: remove custom mirror list In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26436 ) Change subject: open5gs-latest: fix Dockerfile: remove custom mirror list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I313bb604b09293bff8753edeefa7f78cafc9cc22 Gerrit-Change-Number: 26436 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 03 Dec 2021 07:15:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 07:15:50 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 3 Dec 2021 07:15:50 +0000 Subject: Change in docker-playground[master]: Revert "osmo-msc-latest: centos8: add libdbi-dbd-sqlite" In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26437 ) Change subject: Revert "osmo-msc-latest: centos8: add libdbi-dbd-sqlite" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I093f17981f5a09346cf46fe33b94c4b7833757c5 Gerrit-Change-Number: 26437 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 03 Dec 2021 07:15:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 07:16:38 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 3 Dec 2021 07:16:38 +0000 Subject: Change in docker-playground[master]: Revert "osmocom-bb-host-master: install python-enum as fake_trx depen... In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26438 ) Change subject: Revert "osmocom-bb-host-master: install python-enum as fake_trx dependency" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6aa653f2165bb9a81aa8253fabc0fb436bcba009 Gerrit-Change-Number: 26438 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 03 Dec 2021 07:16:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 07:16:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 3 Dec 2021 07:16:59 +0000 Subject: Change in docker-playground[master]: ttcn3-msc-test/osmo-msc.cfg: remove deprecated 'periodic location upd... In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26439 ) Change subject: ttcn3-msc-test/osmo-msc.cfg: remove deprecated 'periodic location update' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0576f21230dff2c96060430ef9ffb6001d19542d Gerrit-Change-Number: 26439 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 03 Dec 2021 07:16:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 07:17:46 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 3 Dec 2021 07:17:46 +0000 Subject: Change in docker-playground[master]: ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26440 ) Change subject: ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I43f80e3fbd73be21fb89006e16de0e1df9ba03f5 Gerrit-Change-Number: 26440 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 03 Dec 2021 07:17:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 11:24:20 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 3 Dec 2021 11:24:20 +0000 Subject: Change in docker-playground[master]: open5gs-latest: fix Dockerfile: remove custom mirror list In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26436 ) Change subject: open5gs-latest: fix Dockerfile: remove custom mirror list ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I313bb604b09293bff8753edeefa7f78cafc9cc22 Gerrit-Change-Number: 26436 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 03 Dec 2021 11:24:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 11:24:23 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 3 Dec 2021 11:24:23 +0000 Subject: Change in docker-playground[master]: Revert "osmo-msc-latest: centos8: add libdbi-dbd-sqlite" In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26437 ) Change subject: Revert "osmo-msc-latest: centos8: add libdbi-dbd-sqlite" ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I093f17981f5a09346cf46fe33b94c4b7833757c5 Gerrit-Change-Number: 26437 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 03 Dec 2021 11:24:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 11:25:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 3 Dec 2021 11:25:47 +0000 Subject: Change in docker-playground[master]: open5gs-latest: fix Dockerfile: remove custom mirror list In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26436 ) Change subject: open5gs-latest: fix Dockerfile: remove custom mirror list ...................................................................... open5gs-latest: fix Dockerfile: remove custom mirror list I was experiencing problems with Debian's mirrors while working on this image, so I had to use a custom mirror list. This is a left- over that should have been removed before merging. Change-Id: I313bb604b09293bff8753edeefa7f78cafc9cc22 Related: SYS#5602 --- M open5gs-latest/Dockerfile 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: osmith: Looks good to me, approved fixeria: Verified diff --git a/open5gs-latest/Dockerfile b/open5gs-latest/Dockerfile index ba8c866..325062f 100644 --- a/open5gs-latest/Dockerfile +++ b/open5gs-latest/Dockerfile @@ -3,9 +3,6 @@ MAINTAINER Vadim Yanitskiy -# TODO: remove me! -ADD sources.list /etc/apt/sources.list - RUN apt-get update && \ apt-get install -y --no-install-recommends \ ca-certificates \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26436 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I313bb604b09293bff8753edeefa7f78cafc9cc22 Gerrit-Change-Number: 26436 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 11:25:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 3 Dec 2021 11:25:47 +0000 Subject: Change in docker-playground[master]: Revert "osmo-msc-latest: centos8: add libdbi-dbd-sqlite" In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26437 ) Change subject: Revert "osmo-msc-latest: centos8: add libdbi-dbd-sqlite" ...................................................................... Revert "osmo-msc-latest: centos8: add libdbi-dbd-sqlite" This reverts commit 9a526e876f6a939f8bf6531b40876d1642a1e997. There is no need to install this dependency explicitly anymore. Change-Id: I093f17981f5a09346cf46fe33b94c4b7833757c5 --- M osmo-msc-latest/Dockerfile 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved fixeria: Verified diff --git a/osmo-msc-latest/Dockerfile b/osmo-msc-latest/Dockerfile index cc18602..8b24cb5 100644 --- a/osmo-msc-latest/Dockerfile +++ b/osmo-msc-latest/Dockerfile @@ -5,7 +5,6 @@ # Arguments used after FROM must be specified again ARG DISTRO -# libdbi-dbd-sqlite can be removed after osmo-msc > 1.7.0 release RUN case "$DISTRO" in \ debian*) \ apt-get update && \ @@ -15,7 +14,6 @@ ;; \ centos*) \ dnf install -y \ - libdbi-dbd-sqlite \ osmo-msc \ ;; \ esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26437 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I093f17981f5a09346cf46fe33b94c4b7833757c5 Gerrit-Change-Number: 26437 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 12:16:44 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 3 Dec 2021 12:16:44 +0000 Subject: Change in libosmo-netif[master]: stream: Add support for AF_UNIX sockets In-Reply-To: References: Message-ID: Hello Jenkins Builder, Arran Cudbard-bell, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 to look at the new patch set (#4). Change subject: stream: Add support for AF_UNIX sockets ...................................................................... stream: Add support for AF_UNIX sockets Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 --- M include/osmocom/netif/stream.h M src/stream.c 2 files changed, 242 insertions(+), 69 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/34/26434/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 Gerrit-Change-Number: 26434 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Arran Cudbard-bell Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 12:19:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 3 Dec 2021 12:19:04 +0000 Subject: Change in docker-playground[master]: Revert "osmocom-bb-host-master: install python-enum as fake_trx depen... In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26438 ) Change subject: Revert "osmocom-bb-host-master: install python-enum as fake_trx dependency" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6aa653f2165bb9a81aa8253fabc0fb436bcba009 Gerrit-Change-Number: 26438 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 03 Dec 2021 12:19:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 12:19:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 3 Dec 2021 12:19:18 +0000 Subject: Change in docker-playground[master]: ttcn3-msc-test/osmo-msc.cfg: remove deprecated 'periodic location upd... In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26439 ) Change subject: ttcn3-msc-test/osmo-msc.cfg: remove deprecated 'periodic location update' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0576f21230dff2c96060430ef9ffb6001d19542d Gerrit-Change-Number: 26439 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 03 Dec 2021 12:19:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 12:19:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 3 Dec 2021 12:19:50 +0000 Subject: Change in docker-playground[master]: ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26440 ) Change subject: ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I43f80e3fbd73be21fb89006e16de0e1df9ba03f5 Gerrit-Change-Number: 26440 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 03 Dec 2021 12:19:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 12:20:57 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 3 Dec 2021 12:20:57 +0000 Subject: Change in libosmo-netif[master]: stream: Add support for AF_UNIX sockets In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26434 ) Change subject: stream: Add support for AF_UNIX sockets ...................................................................... Patch Set 4: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/libosmo-netif/+/26434/3/src/stream.c File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26434/3/src/stream.c at 358 PS3, Line 358: default: > What about here? Done https://gerrit.osmocom.org/c/libosmo-netif/+/26434/3/src/stream.c at 409 PS3, Line 409: default: > And here? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 Gerrit-Change-Number: 26434 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Arran Cudbard-bell Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 03 Dec 2021 12:20:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 12:38:58 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 3 Dec 2021 12:38:58 +0000 Subject: Change in docker-playground[master]: Revert "osmocom-bb-host-master: install python-enum as fake_trx depen... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26438 ) Change subject: Revert "osmocom-bb-host-master: install python-enum as fake_trx dependency" ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6aa653f2165bb9a81aa8253fabc0fb436bcba009 Gerrit-Change-Number: 26438 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 03 Dec 2021 12:38:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 12:39:06 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 3 Dec 2021 12:39:06 +0000 Subject: Change in docker-playground[master]: ttcn3-msc-test/osmo-msc.cfg: remove deprecated 'periodic location upd... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26439 ) Change subject: ttcn3-msc-test/osmo-msc.cfg: remove deprecated 'periodic location update' ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0576f21230dff2c96060430ef9ffb6001d19542d Gerrit-Change-Number: 26439 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 03 Dec 2021 12:39:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 12:40:24 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 3 Dec 2021 12:40:24 +0000 Subject: Change in docker-playground[master]: ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26440 ) Change subject: ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN ...................................................................... Patch Set 2: Verified+1 Code-Review+2 FYI: I verified this patch by running ttcn3-msc-test in a local Docker environment. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I43f80e3fbd73be21fb89006e16de0e1df9ba03f5 Gerrit-Change-Number: 26440 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 03 Dec 2021 12:40:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 12:40:31 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 3 Dec 2021 12:40:31 +0000 Subject: Change in docker-playground[master]: Revert "osmocom-bb-host-master: install python-enum as fake_trx depen... In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26438 ) Change subject: Revert "osmocom-bb-host-master: install python-enum as fake_trx dependency" ...................................................................... Revert "osmocom-bb-host-master: install python-enum as fake_trx dependency" This reverts commit c034da05476429f1470c1245ad949fe45f08dc97. Python 2 is EOL, we are using Python 3 now with built-in enums. Change-Id: I6aa653f2165bb9a81aa8253fabc0fb436bcba009 --- M osmocom-bb-host-master/Dockerfile 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved fixeria: Verified diff --git a/osmocom-bb-host-master/Dockerfile b/osmocom-bb-host-master/Dockerfile index 2e86767..3f9c108 100644 --- a/osmocom-bb-host-master/Dockerfile +++ b/osmocom-bb-host-master/Dockerfile @@ -18,11 +18,10 @@ rm /tmp/Release.key && \ echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list -# python-enum34 is a dependecy of fake_trx as long we're using python2 ADD $OSMOCOM_REPO/Release /tmp/Release RUN apt-get update && \ apt-get install -y --no-install-recommends \ - libosmocore-dev python-enum34 && \ + libosmocore-dev && \ apt-get clean WORKDIR /tmp -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6aa653f2165bb9a81aa8253fabc0fb436bcba009 Gerrit-Change-Number: 26438 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 12:40:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 3 Dec 2021 12:40:32 +0000 Subject: Change in docker-playground[master]: ttcn3-msc-test/osmo-msc.cfg: remove deprecated 'periodic location upd... In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26439 ) Change subject: ttcn3-msc-test/osmo-msc.cfg: remove deprecated 'periodic location update' ...................................................................... ttcn3-msc-test/osmo-msc.cfg: remove deprecated 'periodic location update' Let's keep osmo-msc.cfg up to date with the one in osmo-ttcn3-hacks. Change-Id: I0576f21230dff2c96060430ef9ffb6001d19542d Related: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26415 --- M ttcn3-msc-test/osmo-msc.cfg 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved fixeria: Verified diff --git a/ttcn3-msc-test/osmo-msc.cfg b/ttcn3-msc-test/osmo-msc.cfg index 946ba14..be7acbd 100644 --- a/ttcn3-msc-test/osmo-msc.cfg +++ b/ttcn3-msc-test/osmo-msc.cfg @@ -73,7 +73,6 @@ authentication optional rrlp mode none mm info 0 - periodic location update 30 msc assign-tmsi cs7-instance-a 0 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0576f21230dff2c96060430ef9ffb6001d19542d Gerrit-Change-Number: 26439 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 12:40:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 3 Dec 2021 12:40:32 +0000 Subject: Change in docker-playground[master]: ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26440 ) Change subject: ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN ...................................................................... ttcn3-msc-test/osmo-msc.cfg: disable encryption for UTRAN The Iu/UMTS specific test cases in ttcn3-msc-test expect no encryption in Security Mode Command by default (only integrity), while osmo-msc would permit both UEA1 and UEA2 unless configured explicitly. This causes the related test cases to fail. A similar change was merged to osmo-ttcn3-hacks, updating the osmo-msc.cfg in there, however the actual configuration file that is used to execute test cases on Jenkins was not updated. Change-Id: I43f80e3fbd73be21fb89006e16de0e1df9ba03f5 Related: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26389 Fixes: OS#5333 --- M ttcn3-msc-test/osmo-msc.cfg 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/ttcn3-msc-test/osmo-msc.cfg b/ttcn3-msc-test/osmo-msc.cfg index be7acbd..903b5bd 100644 --- a/ttcn3-msc-test/osmo-msc.cfg +++ b/ttcn3-msc-test/osmo-msc.cfg @@ -70,6 +70,7 @@ short name OsmoMSC long name OsmoMSC encryption a5 0 + encryption uea 0 authentication optional rrlp mode none mm info 0 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I43f80e3fbd73be21fb89006e16de0e1df9ba03f5 Gerrit-Change-Number: 26440 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 14:14:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 3 Dec 2021 14:14:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 to look at the new patch set (#6). Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... hnodeb: Add initial infra to emulate HNB LL socket iface Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.default M hnodeb/HNB_Tests.ttcn M hnodeb/gen_links.sh M hnodeb/regen_makefile.sh A library/HNBLLIF_CodecPort.ttcn A library/HNBLLIF_Templates.ttcn A library/HNBLLIF_Types.ttcn M library/Iuh_CodecPort.ttcn M library/rua/RUA_Templates.ttcn 10 files changed, 964 insertions(+), 38 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/26373/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 14:14:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 3 Dec 2021 14:14:02 +0000 Subject: Change in osmo-ttcn3-hacks[master]: break GTP_Templates dependency on Osmo_Gb_Types, BSSGP_Types, NS_Types References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26441 ) Change subject: break GTP_Templates dependency on Osmo_Gb_Types, BSSGP_Types, NS_Types ...................................................................... break GTP_Templates dependency on Osmo_Gb_Types, BSSGP_Types, NS_Types The resulting set of dependencies needed just to have one simple CellId struct is huge. That was fine for sgsn testsuite since anyway those were being used, but it's not acceptable for other testsuites (hnodeb) which only really require the GTP side. After this change, GTP_Templates only requires GSM_Types, which ends up in a much smaller subset of dependencies being pulled in. Change-Id: Icd8234908af445b798517fe110cd0648969179a4 --- M library/GTP_Templates.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 36 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/26441/1 diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index 1bd56e1..9c8d1b6 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -17,7 +17,17 @@ import from GTPU_Types all; import from GTP_CodecPort all; import from IPCP_Types all; - import from Osmocom_Gb_Types all; // BssgpCellId + import from GSM_Types all; // RoutingAreaIdentification, CellIdentity + + type record GTP_CellId { + RoutingAreaIdentification ra_id, + CellIdentity cell_id + } with { encode "RAW" }; + + template (value) GTP_CellId ts_GTP_CellId(template (value) RoutingAreaIdentification rai, CellIdentity cell_id) := { + ra_id := rai, + cell_id := cell_id + }; /* Table 38 of 3GPP TS 29.060 */ type enumerated GTP_Cause { @@ -673,7 +683,7 @@ }, rIMProtocolVersionNumber := int2oct(ver, 1) } - function tr_GTPC_Cell_Identifier_V(template BssgpCellId cid) return template Cell_Identifier_V_GTPC { + function tr_GTPC_Cell_Identifier_V(template GTP_CellId cid) return template Cell_Identifier_V_GTPC { var template Cell_Identifier_V_GTPC ret := { mccDigit1 := ?, mccDigit2 := ?, @@ -713,7 +723,7 @@ } return ret; } - template (value) Cell_Identifier_V_GTPC ts_GTPC_Cell_Identifier_V(BssgpCellId cid) := { + template (value) Cell_Identifier_V_GTPC ts_GTPC_Cell_Identifier_V(GTP_CellId cid) := { mccDigit1 := cid.ra_id.lai.mcc_mnc[0], mccDigit2 := cid.ra_id.lai.mcc_mnc[1], mccDigit3 := cid.ra_id.lai.mcc_mnc[2], @@ -724,10 +734,10 @@ rac := int2oct(cid.ra_id.rac, 1), cI_value := int2oct(cid.cell_id, 2) } - template RIM_Routing_Address_GTPC t_GTPC_RIM_Routing_Address_cid(BssgpCellId cid) := { + template RIM_Routing_Address_GTPC t_GTPC_RIM_Routing_Address_cid(GTP_CellId cid) := { cell_Identifier := ts_GTPC_Cell_Identifier_V(cid) } - function tr_GTPC_ENB_Identifier(template BssgpCellId cid, template integer tac, template octetstring gnbid) return template ENB_Identifier { + function tr_GTPC_ENB_Identifier(template GTP_CellId cid, template integer tac, template octetstring gnbid) return template ENB_Identifier { var template ENB_Identifier ret := { mccDigit1 := ?, mccDigit2 := ?, @@ -764,7 +774,7 @@ return ret; } - template (value) ENB_Identifier ts_GTPC_ENB_Identifier(BssgpCellId cid, integer tac, octetstring gnbid) := { + template (value) ENB_Identifier ts_GTPC_ENB_Identifier(GTP_CellId cid, integer tac, octetstring gnbid) := { mccDigit1 := cid.ra_id.lai.mcc_mnc[0], mccDigit2 := cid.ra_id.lai.mcc_mnc[1], mccDigit3 := cid.ra_id.lai.mcc_mnc[2], @@ -774,7 +784,7 @@ tAC := int2oct(tac, 2), globalENB_ID := gnbid } - template RIM_Routing_Address_GTPC t_GTPC_RIM_Routing_Address_enbid(BssgpCellId cid, integer tac, octetstring gnbid) := { + template RIM_Routing_Address_GTPC t_GTPC_RIM_Routing_Address_enbid(GTP_CellId cid, integer tac, octetstring gnbid) := { eNB_Identifier := ts_GTPC_ENB_Identifier(cid, tac, gnbid) } template RIM_Routing_Information_GTPC @@ -801,7 +811,7 @@ } /* 3GPP TS 48.018 11.3.63.1.1 */ template RAN_Information_Request_Application_Container_NACC_GTPC - tr_GTPC_RAN_Information_Request_Application_Container_NACC(template BssgpCellId cid) := { + tr_GTPC_RAN_Information_Request_Application_Container_NACC(template GTP_CellId cid) := { iEI := '4D'O, ext := '1'B, lengthIndicator := { @@ -810,7 +820,7 @@ reporting_Cell_Identifier := tr_GTPC_Cell_Identifier_V(cid) } template (value) RAN_Information_Request_Application_Container_NACC_GTPC - ts_GTPC_RAN_Information_Request_Application_Container_NACC(BssgpCellId cid) := { + ts_GTPC_RAN_Information_Request_Application_Container_NACC(GTP_CellId cid) := { iEI := '4D'O, ext := '1'B, lengthIndicator := { @@ -820,16 +830,16 @@ } /* 3GPP TS 48.018 11.3.63.1 */ template RAN_Information_Request_Application_Container_GTPC - tru_GTPC_RAN_Information_Request_Application_Container_NACC(template BssgpCellId cid) := { + tru_GTPC_RAN_Information_Request_Application_Container_NACC(template GTP_CellId cid) := { nacc := tr_GTPC_RAN_Information_Request_Application_Container_NACC(cid) } template (value) RAN_Information_Request_Application_Container_GTPC - tsu_GTPC_RAN_Information_Request_Application_Container_NACC(BssgpCellId cid) := { + tsu_GTPC_RAN_Information_Request_Application_Container_NACC(GTP_CellId cid) := { nacc := ts_GTPC_RAN_Information_Request_Application_Container_NACC(cid) } /* 3GPP TS 48.018 11.3.63.2.1 */ template RAN_Information_Application_Container_NACC_GTPC - tr_GTPC_RAN_Information_Application_Container_NACC(template BssgpCellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { + tr_GTPC_RAN_Information_Application_Container_NACC(template GTP_CellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { iEI := '4E'O, ext := '1'B, lengthIndicator := { @@ -841,7 +851,7 @@ sI_PSI := si_psi } template (value) RAN_Information_Application_Container_NACC_GTPC - ts_GTPC_RAN_Information_Application_Container_NACC(BssgpCellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { + ts_GTPC_RAN_Information_Application_Container_NACC(GTP_CellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { iEI := '4E'O, ext := '1'B, lengthIndicator := { @@ -892,11 +902,11 @@ /* RAN_Information */ template ApplContainer_or_ApplErrContainer_NACC_GTPC - tru_GTPC_ApplContainer_NACC(BssgpCellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { + tru_GTPC_ApplContainer_NACC(GTP_CellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { application_Container := tr_GTPC_RAN_Information_Application_Container_NACC(cid, psi_type, si_psi_num, si_psi) } template (value) ApplContainer_or_ApplErrContainer_NACC_GTPC - tsu_GTPC_ApplContainer_NACC(BssgpCellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { + tsu_GTPC_ApplContainer_NACC(GTP_CellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { application_Container := ts_GTPC_RAN_Information_Application_Container_NACC(cid, psi_type, si_psi_num, si_psi) } template ApplContainer_or_ApplErrContainer_GTPC diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 2461962..3386f71 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -250,6 +250,12 @@ return ret; }; +private function f_BssgpCellId_to_GTP_CellId(in BssgpCellId cell_id) return GTP_CellId +{ + template (value) GTP_CellId ret := ts_GTP_CellId(cell_id.ra_id, cell_id.cell_id); + return valueof(ret); +} + private function f_init_gb(inout GbInstance gb, charstring id, integer offset) runs on test_CT { gb.vc_NS := NS_CT.create(id & "-NS" & int2str(offset)); gb.vc_BSSGP := BSSGP_CT.create(id & "-BSSGP" & int2str(offset)); @@ -3373,20 +3379,21 @@ remName := mp_sgsn_gtp_ip, remPort := GTP1C_PORT } + var GTP_CellId gtp_ci := f_BssgpCellId_to_GTP_CellId(g_gb[1].cfg.bvc[0].cell_id); var template (value) RIM_Routing_Address_GTPC gtpc_dst_addr, gtpc_src_addr; var template (value) RAN_Information_Request_RIM_Container_GTPC gtpc_rim_req_cont; var template (value) PDU_BSSGP_RAN_INFORMATION_REQUEST_GTPC gtpc_bssgp_cont; var template (value) Gtp1cUnitdata gtpc_pdu; - gtpc_dst_addr := t_GTPC_RIM_Routing_Address_cid(g_gb[1].cfg.bvc[0].cell_id); - gtpc_src_addr := t_GTPC_RIM_Routing_Address_enbid(g_gb[1].cfg.bvc[0].cell_id, tac := 3, gnbid := '12345678123456'O); + gtpc_dst_addr := t_GTPC_RIM_Routing_Address_cid(gtp_ci); + gtpc_src_addr := t_GTPC_RIM_Routing_Address_enbid(gtp_ci, tac := 3, gnbid := '12345678123456'O); gtpc_rim_req_cont := ts_GTPC_RAN_Information_Request_RIM_Container(ts_GTPC_RIM_Application_Identity(RIM_APP_ID_NACC), ts_GTPC_RIM_Sequence_Number(1), ts_GTPC_RIM_PDU_Indications(false, RIM_PDU_TYPE_SING_REP), ts_GTPC_RIM_Protocol_Version_Number(1), - tsu_GTPC_RAN_Information_Request_Application_Container_NACC(g_gb[1].cfg.bvc[0].cell_id), + tsu_GTPC_RAN_Information_Request_Application_Container_NACC(gtp_ci), omit); gtpc_bssgp_cont := ts_GTPC_RAN_Information_Request(ts_GTPC_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID, gtpc_dst_addr), ts_GTPC_RIM_Routing_Information(RIM_ADDR_EUTRAN_NODEB_ID, gtpc_src_addr), @@ -3439,7 +3446,7 @@ ts_GTPC_RIM_Sequence_Number(2), ts_GTPC_RIM_PDU_Indications(false, RIM_PDU_TYPE_SING_REP), ts_GTPC_RIM_Protocol_Version_Number(1), - tru_GTPC_ApplContainer_or_ApplErrContainer_NACC(tru_GTPC_ApplContainer_NACC(g_gb[1].cfg.bvc[0].cell_id, false, 3, si_default)), + tru_GTPC_ApplContainer_or_ApplErrContainer_NACC(tru_GTPC_ApplContainer_NACC(gtp_ci, false, 3, si_default)), omit); gtpc_bssgp_cont_ack := tr_GTPC_RAN_Information(tr_GTPC_RIM_Routing_Information(RIM_ADDR_EUTRAN_NODEB_ID, gtpc_src_addr), tr_GTPC_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID, gtpc_dst_addr), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26441 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icd8234908af445b798517fe110cd0648969179a4 Gerrit-Change-Number: 26441 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 16:30:15 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 3 Dec 2021 16:30:15 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: fix redundant titan image build References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26442 ) Change subject: jenkins-common.sh: fix redundant titan image build ...................................................................... jenkins-common.sh: fix redundant titan image build Do not build debian-stretch-titan, when registry.osmocom.org is enabled. The image that would be built at this point is not useful, since other images like ttcn3-msc-test will use the debian-stretch-titan image from the registry instead of the one that was just built locally. Related: OS#5336 Change-Id: I7127e3ebac3a6a985c3ba50ba8c7cb8c5de978d9 --- M jenkins-common.sh 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/42/26442/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index d4258d2..88d053c 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -120,6 +120,16 @@ local dir for i in $@; do + # Don't build images that are available on the private + # registry, if using it. + if [ "$REGISTRY_HOST" = "registry.osmocom.org" ]; then + case "$i" in + debian-stretch-titan) + continue + ;; + esac + fi + # Build dependencies first depends="$(docker_depends "$i")" if [ -n "$depends" ]; then -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7127e3ebac3a6a985c3ba50ba8c7cb8c5de978d9 Gerrit-Change-Number: 26442 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 16:30:16 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 3 Dec 2021 16:30:16 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: pull registry.osmocom.org imgs References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26443 ) Change subject: jenkins-common.sh: pull registry.osmocom.org imgs ...................................................................... jenkins-common.sh: pull registry.osmocom.org imgs Pull debian-stretch-titan from registry.osmocom.org if the repository is enabled. Otherwise the image gets only pulled the first time, and does not get updated once it becomes outdated. Related: OS#5336 Change-Id: I1cf998c21e4ee1f723c3b783703e339328377f3e --- M jenkins-common.sh 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/43/26443/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index 88d053c..3511c02 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -121,10 +121,12 @@ for i in $@; do # Don't build images that are available on the private - # registry, if using it. + # registry, if using it. Instead, pull the images to make sure + # they are up-to-date. if [ "$REGISTRY_HOST" = "registry.osmocom.org" ]; then case "$i" in debian-stretch-titan) + docker pull "$REGISTRY_HOST/$USER/$i" continue ;; esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26443 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1cf998c21e4ee1f723c3b783703e339328377f3e Gerrit-Change-Number: 26443 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 16:30:37 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 3 Dec 2021 16:30:37 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: pull registry.osmocom.org imgs In-Reply-To: References: Message-ID: osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/docker-playground/+/26443 ) Change subject: jenkins-common.sh: pull registry.osmocom.org imgs ...................................................................... jenkins-common.sh: pull registry.osmocom.org imgs Pull debian-stretch-titan from registry.osmocom.org if the repository is enabled. Otherwise the image gets only pulled the first time, and does not get updated once it becomes outdated. Fixes: OS#5336 Change-Id: I1cf998c21e4ee1f723c3b783703e339328377f3e --- M jenkins-common.sh 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/43/26443/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26443 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1cf998c21e4ee1f723c3b783703e339328377f3e Gerrit-Change-Number: 26443 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 16:34:49 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 3 Dec 2021 16:34:49 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: fix redundant titan image build In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26442 ) Change subject: jenkins-common.sh: fix redundant titan image build ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7127e3ebac3a6a985c3ba50ba8c7cb8c5de978d9 Gerrit-Change-Number: 26442 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 03 Dec 2021 16:34:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 16:34:54 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 3 Dec 2021 16:34:54 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: pull registry.osmocom.org imgs In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26443 ) Change subject: jenkins-common.sh: pull registry.osmocom.org imgs ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26443 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1cf998c21e4ee1f723c3b783703e339328377f3e Gerrit-Change-Number: 26443 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 03 Dec 2021 16:34:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 17:47:42 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 3 Dec 2021 17:47:42 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add audio SAPI References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 ) Change subject: hnodeb: Add audio SAPI ...................................................................... hnodeb: Add audio SAPI Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 --- M hnodeb/HNB_Tests.ttcn M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 3 files changed, 255 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/26444/1 diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index 6b95730..07da8c8 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -63,6 +63,7 @@ const hexstring ranap_auth_req := '00144032000002001040262505120217dc146aeac56cb5ff6d5fb51f47f19220108ca5a6d0c8110000b9e9272498872764003b400100'H; const hexstring ranap_auth_resp := '001440140000010010400d0c0554ccbdd0302104002f3ae4'H; const hexstring ranap_paging := '000e401e0000030003400100001740095000010100000000f10040400500b6cf4773'H; +const hexstring ranap_rab_ass_req := '0000005900000100364052000001003500487824cd80102fa7201a2c0000f44c080a028000514000272028140067400000222814003c40000000503d02000227c03500010a0901a200000000000000000000000000401f4a0000400100'H; const hexstring iu_release_compl := '20010003000000'H; type component test_CT extends CTRL_Adapter_CT { @@ -277,11 +278,55 @@ f_shutdown_helper(); } +private function f_tc_cs_mo_call(charstring id) runs on HNBGW_ConnHdlr { + const integer context_id := 30; + const bitstring context_id_bstr := '000000000000000000011110'B; /* encoded context_id */ + const Establishment_Cause est_cause := normal_call; + f_handle_hnbap_hnb_register_req(); + + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONFIGURE_REQ(g_pars.mcc, g_pars.mnc, g_pars.cell_identity, + g_pars.lac, g_pars.rac, g_pars.sac, g_pars.rnc_id))); + + /* Now an UE attempts CM Service Request: */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_ESTABLISH_IND(context_id, 0, enum2int(est_cause), hex2oct(ranap_cm_service_req)))); + /* The related RUA Connect + RANAP message is received on Iuh: */ + RUA.receive(tr_RUA_Connect(cs_domain, context_id_bstr, est_cause, hex2oct(ranap_cm_service_req))); + + /* Now HNBGW answers with RUA-DirectTransfer(RANAP-RabASsReq) */ + RUA.send(ts_RUA_DirectTransfer(cs_domain, context_id_bstr, hex2oct(ranap_rab_ass_req))); + + /* Now on LLSK first the Conn establishment is confirmed and then we receive data */ + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONN_ESTABLISH_CNF(context_id, 0, 0))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONN_DATA_REQ(context_id, 0, hex2oct(ranap_rab_ass_req)))); + + /* Now LLSK provides the remote TransportLayerAddress from RabAssReq and asks SUT to provide a local address: */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_ESTABLISH_IND(context_id, 8888, HNBLL_IF_ADDR_TYPE_IPV4, + f_HNBLLIF_Addr(HNBLL_IF_ADDR_TYPE_IPV4, g_pars.hnbgw_addr)))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_ESTABLISH_CNF(context_id, 0, ?, HNBLL_IF_ADDR_TYPE_IPV4, ?))); + + /* TODO: forward audio data in both directions */ + + LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_RELEASE_IND(context_id))); + + /* UE sends Iu Release Complete to release the conn */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_RELEASE_IND(context_id, 0, 0, 0, hex2oct(iu_release_compl)))); + RUA.receive(tr_RUA_Disconnect(cs_domain, context_id_bstr, ts_RUA_Cause(normal), hex2oct(iu_release_compl))); +} +testcase TC_cs_mo_call() runs on test_CT { + var HNBGW_ConnHdlr vc_conn; + + f_init(); + vc_conn := f_start_handler(refers(f_tc_cs_mo_call)); + vc_conn.done; + f_shutdown_helper(); +} + control { execute( TC_hnb_register_request_accept() ); execute( TC_hnb_register_request_reject() ); execute( TC_mo_conn() ); execute( TC_paging() ); + execute( TC_cs_mo_call() ); } } diff --git a/library/HNBLLIF_Templates.ttcn b/library/HNBLLIF_Templates.ttcn index f2cb961..a2673c0 100644 --- a/library/HNBLLIF_Templates.ttcn +++ b/library/HNBLLIF_Templates.ttcn @@ -244,4 +244,80 @@ } } +/********************** + * AUDIO SAPI + **********************/ + +template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_ESTABLISH_IND(template (value) uint32_t context_id, + template (value) uint16_t remote_rtp_port, + template (value) HNBLLIF_AddrType remote_rtp_address_type, + template (value) HNBLLIF_Addr remote_addr) := { + sapi := HNBLL_IF_SAPI_AUDIO, + u := { + audio := { + prim := HNBLL_IF_AUDIO_MSG_CONN_ESTABLISH, + u := { + conn_establish := { + op := HNBLL_IF_OP_INDICATION, + u := { + ind := { + context_id := context_id, + remote_rtp_port := remote_rtp_port, + reserved := 0, + remote_rtp_address_type := remote_rtp_address_type, + remote_addr := remote_addr + } + } + } + } + } + } +} + +template (present) HNBLLIF_Message tr_HNBLLIF_AUDIO_CONN_ESTABLISH_CNF(template (present) uint32_t context_id := ?, + template (present) uint8_t error_code := ?, + template (present) uint16_t local_rtp_port:= ?, + template (present) HNBLLIF_AddrType local_rtp_address_type := ?, + template (present) HNBLLIF_Addr local_addr := ?) := { + sapi := HNBLL_IF_SAPI_AUDIO, + u := { + audio := { + prim := HNBLL_IF_AUDIO_MSG_CONN_ESTABLISH, + u := { + conn_establish := { + op := HNBLL_IF_OP_CONFIRM, + u := { + cnf := { + context_id := context_id, + local_rtp_port := local_rtp_port, + error_code := error_code, + local_rtp_address_type := local_rtp_address_type, + local_addr := local_addr + } + } + } + } + } + } +} + +template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_RELEASE_IND(template (value) uint32_t context_id) := { + sapi := HNBLL_IF_SAPI_AUDIO, + u := { + audio := { + prim := HNBLL_IF_AUDIO_MSG_CONN_RELEASE, + u := { + conn_release := { + op := HNBLL_IF_OP_INDICATION, + u := { + ind := { + context_id := context_id + } + } + } + } + } + } +} + } with { encode "RAW" variant "BYTEORDER(first)" }; diff --git a/library/HNBLLIF_Types.ttcn b/library/HNBLLIF_Types.ttcn index 8bc87d0..8b0c08f 100644 --- a/library/HNBLLIF_Types.ttcn +++ b/library/HNBLLIF_Types.ttcn @@ -230,15 +230,121 @@ other, OTHERWISE)" }; +/********************** + * AUDIO SAPI + **********************/ +type enumerated HNBLLIF_AUDIO_MsgType { + HNBLL_IF_AUDIO_MSG_CONN_ESTABLISH ('0000'O), + HNBLL_IF_AUDIO_MSG_CONN_RELEASE ('0001'O), + HNBLL_IF_AUDIO_MSG_CONN_DATA ('0002'O) +} with { variant "FIELDLENGTH(16)" }; + +/* CONN_ESTABLISH */ +type record HNBLLIF_AUDIO_conn_establish_ind { + uint32_t context_id, + uint16_t remote_rtp_port, + uint8_t reserved, + HNBLLIF_AddrType remote_rtp_address_type, + HNBLLIF_Addr remote_addr +} with { variant "" }; + +type record HNBLLIF_AUDIO_conn_establish_cnf { + uint32_t context_id, + uint16_t local_rtp_port, + uint8_t error_code, + HNBLLIF_AddrType local_rtp_address_type, + HNBLLIF_Addr local_addr +} with { variant "" }; + +type union HNBLLIF_AUDIO_PrimOpUnion_conn_establish { + HNBLLIF_AUDIO_conn_establish_ind ind, + HNBLLIF_AUDIO_conn_establish_cnf cnf, + octetstring other +} with { variant "" }; +type record HNBLLIF_AUDIO_PrimOp_conn_establish { + HNBLLIF_Operation op, + HNBLLIF_AUDIO_PrimOpUnion_conn_establish u +} with { variant (u) "CROSSTAG( ind, op = HNBLL_IF_OP_INDICATION; + cnf, op = HNBLL_IF_OP_CONFIRM; + other, OTHERWISE)" +}; + +/* CONN_RELEASE */ +type record HNBLLIF_AUDIO_conn_release_ind { + uint32_t context_id +} with { variant "" }; + + +type union HNBLLIF_AUDIO_PrimOpUnion_conn_release { + HNBLLIF_AUDIO_conn_release_ind ind, + octetstring other +} with { variant "" }; +type record HNBLLIF_AUDIO_PrimOp_conn_release { + HNBLLIF_Operation op, + HNBLLIF_AUDIO_PrimOpUnion_conn_release u +} with { variant (u) "CROSSTAG( ind, op = HNBLL_IF_OP_INDICATION; + other, OTHERWISE)" +}; + +/* CONN_DATA */ +type record HNBLLIF_AUDIO_conn_data_ind { + uint32_t context_id, + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type record HNBLLIF_AUDIO_conn_data_req { + uint32_t context_id, + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type union HNBLLIF_AUDIO_PrimOpUnion_conn_data { + HNBLLIF_AUDIO_conn_data_req req, + HNBLLIF_AUDIO_conn_data_ind ind, + octetstring other +} with { variant "" }; +type record HNBLLIF_AUDIO_PrimOp_conn_data { + HNBLLIF_Operation op, + HNBLLIF_AUDIO_PrimOpUnion_conn_data u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + ind, op = HNBLL_IF_OP_INDICATION; + other, OTHERWISE)" +}; + +type union HNBLLIF_AUDIO_PrimUnion { + HNBLLIF_AUDIO_PrimOp_conn_establish conn_establish, + HNBLLIF_AUDIO_PrimOp_conn_release conn_release, + HNBLLIF_AUDIO_PrimOp_conn_data conn_data, + octetstring other +} with { variant "" }; + +type record HNBLLIF_AUDIO_PrimHdr { + HNBLLIF_AUDIO_MsgType prim, + HNBLLIF_AUDIO_PrimUnion u +} with { variant (u) "CROSSTAG( conn_establish, prim = HNBLL_IF_AUDIO_MSG_CONN_ESTABLISH; + conn_release, prim = HNBLL_IF_AUDIO_MSG_CONN_RELEASE; + conn_data, prim = HNBLL_IF_AUDIO_MSG_CONN_DATA; + other, OTHERWISE)" +}; + /********************** * General **********************/ + +type enumerated HNBLLIF_AddrType { + HNBLL_IF_ADDR_TYPE_UNSPEC ('00'O), + HNBLL_IF_ADDR_TYPE_IPV4 ('01'O), + HNBLL_IF_ADDR_TYPE_IPV6 ('02'O) +} with { variant "FIELDLENGTH(8)" }; +type octetstring HNBLLIF_Addr length(16); + type enumerated HNBLLIF_Sapi { HNBLL_IF_SAPI_CTL ('00000000'O), - HNBLL_IF_SAPI_IUH ('00000001'O)//, + HNBLL_IF_SAPI_IUH ('00000001'O), //HNBLL_IF_SAPI_GTP ('00000002'O), - //HNBLL_IF_SAPI_AUDIO ('00000003'O), + HNBLL_IF_SAPI_AUDIO ('00000003'O) } with { variant "FIELDLENGTH(32)" }; type enumerated HNBLLIF_Operation { @@ -251,6 +357,7 @@ type union HNBLLIF_SapiUnion { HNBLLIF_CTL_PrimHdr ctl, HNBLLIF_IUH_PrimHdr iuh, + HNBLLIF_AUDIO_PrimHdr audio, octetstring other } with { variant "" }; @@ -259,6 +366,7 @@ HNBLLIF_SapiUnion u } with { variant (u) "CROSSTAG( ctl, sapi = HNBLL_IF_SAPI_CTL; iuh, sapi = HNBLL_IF_SAPI_IUH; + audio, sapi = HNBLL_IF_SAPI_AUDIO; other, OTHERWISE)" }; @@ -267,5 +375,29 @@ external function dec_HNBLLIF_Message(in octetstring stream) return HNBLLIF_Message with { extension "prototype(convert) decode(RAW)" }; +function f_HNBLLIF_AF2addr_type(AddressFamily address_family) +return HNBLLIF_AddrType { + if (address_family == AF_INET) { + return HNBLL_IF_ADDR_TYPE_IPV4; + } else if (address_family == AF_INET6) { + return HNBLL_IF_ADDR_TYPE_IPV6; + } else { + return HNBLL_IF_ADDR_TYPE_UNSPEC; + } +} + +function f_HNBLLIF_Addr(HNBLLIF_AddrType addr_type, charstring addr_str) +return HNBLLIF_Addr { + var HNBLLIF_Addr addr; + + if (addr_type == HNBLL_IF_ADDR_TYPE_IPV4) { + addr := f_inet_addr(addr_str); + } else { + addr := f_inet6_addr(addr_str); + } + + return addr; +} + } with { encode "RAW" variant "BYTEORDER(first)" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 Gerrit-Change-Number: 26444 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 3 17:47:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 3 Dec 2021 17:47:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add gtp SAPI References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 ) Change subject: hnodeb: Add gtp SAPI ...................................................................... hnodeb: Add gtp SAPI Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn M hnodeb/gen_links.sh M hnodeb/regen_makefile.sh M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 6 files changed, 342 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/26445/1 diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn index 3ee79f0..7dec5d0 100644 --- a/hnodeb/HNBGW_ConnectionHandler.ttcn +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -31,8 +31,14 @@ import from HNBLLIF_Types all; import from HNBLLIF_Templates all; +import from GTP_Emulation all; +import from GTP_Templates all; +import from GTP_CodecPort all; +import from GTPC_Types all; +import from GTPU_Types all; + /* this component represents a single Iuh connection at the HNBGW. */ -type component HNBGW_ConnHdlr extends StatsD_ConnHdlr { +type component HNBGW_ConnHdlr extends StatsD_ConnHdlr, GTP_ConnHdlr { port TELNETasp_PT HNBVTY; port HNBAP_PT HNBAP; port RUA_PT RUA; @@ -40,6 +46,8 @@ port HNBLLIF_CODEC_PT LLSK; var integer g_llsk_conn_id; + var GTP_Emulation_CT vc_GTP; + var TestHdlrParams g_pars; var boolean g_vty_initialized := false; @@ -54,11 +62,8 @@ } } -/* initialize all parameters */ -function f_HNBGW_ConnHdlr_init(charstring id, TestHdlrParams pars) runs on HNBGW_ConnHdlr { +private function f_HNBGW_ConnHdlr_init_iuh(charstring id) runs on HNBGW_ConnHdlr { var Iuh_Emulation_CT vc_Iuh; - - g_pars := valueof(pars); vc_Iuh := Iuh_Emulation_CT.create(id & "-HNBGW"); connect(self:HNBAP, vc_Iuh:HNBAP); connect(self:RUA, vc_Iuh:RUA); @@ -69,7 +74,30 @@ iuh_pars.local_ip := g_pars.hnbgw_addr; iuh_pars.local_sctp_port := g_pars.hnbgw_port; vc_Iuh.start(Iuh_Emulation.main(iuh_pars, id & "-Iuh")); +} +private function f_HNBGW_ConnHdlr_init_gtp(charstring id) runs on HNBGW_ConnHdlr { + id := id & "-GTP"; + + var GtpEmulationCfg gtp_cfg := { + gtpc_bind_ip := g_pars.hnbgw_addr, + gtpc_bind_port := GTP1C_PORT, + gtpu_bind_ip := g_pars.hnbgw_addr, + gtpu_bind_port := GTP1U_PORT, + sgsn_role := false + }; + + vc_GTP := GTP_Emulation_CT.create(id); + connect(self:GTP, vc_GTP:CLIENT); + connect(self:GTP_PROC, vc_GTP:CLIENT_PROC); + vc_GTP.start(GTP_Emulation.main(gtp_cfg)); +} + +/* initialize all parameters */ +function f_HNBGW_ConnHdlr_init(charstring id, TestHdlrParams pars) runs on HNBGW_ConnHdlr { + g_pars := valueof(pars); + f_HNBGW_ConnHdlr_init_iuh(id); + f_HNBGW_ConnHdlr_init_gtp(id); f_HNBGW_ConnHdlr_init_vty(); /* Connect to HNB on LLSK and do HELLO ping-pong */ @@ -129,6 +157,17 @@ sac := 4 } +template (value) GtpPeer ts_GtpPeerU(charstring ip) := { + connId := 1, + remName := ip, + remPort := GTP1U_PORT +} + +function f_gtpu_send(uint32_t tei, octetstring payload) runs on HNBGW_ConnHdlr { + var GtpPeer peer := valueof(ts_GtpPeerU(g_pars.hnodeb_addr)); + GTP.send(ts_GTP1U_GPDU(peer, 0 /*seq*/, int2oct(tei, 4), payload)); +} + /* HNBLLIF socket may at any time receive a new INFO.ind */ altstep as_hnbllif_hello_cnf(HNBLLIF_CODEC_PT pt, integer hnbllif_conn_id, out HNBLLIF_Message last_hello_cnf, template (present) HNBLLIF_Version exp_version := ?) { diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index 07da8c8..9883a4b 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -48,6 +48,10 @@ import from HNBLLIF_Types all; import from HNBLLIF_Templates all; +import from GTPU_Types all; +import from GTP_Templates all; +import from GTP_Emulation all; + modulepar { /* IP address at which the HNodeB can be reached */ charstring mp_hnodeb_ip := "127.0.0.1"; @@ -321,12 +325,70 @@ f_shutdown_helper(); } +private function f_tc_ps_mo_gtp_ping_pong(charstring id) runs on HNBGW_ConnHdlr { + const integer context_id := 30; + const bitstring context_id_bstr := '000000000000000000011110'B; /* encoded context_id */ + const Establishment_Cause est_cause := normal_call; + var uint32_t remote_tei := 8888; + var uint32_t local_tei; + var octetstring gtp_payload := f_rnd_octstring(40); + var HNBLLIF_send_data sd; + + f_gtp_register_teid(int2oct(remote_tei, 4)); + + f_handle_hnbap_hnb_register_req(); + + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONFIGURE_REQ(g_pars.mcc, g_pars.mnc, g_pars.cell_identity, + g_pars.lac, g_pars.rac, g_pars.sac, g_pars.rnc_id))); + + /* Now an UE attempts CM Service Request: */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_ESTABLISH_IND(context_id, 1, enum2int(est_cause), hex2oct(ranap_cm_service_req)))); + /* The related RUA Connect + RANAP message is received on Iuh: */ + RUA.receive(tr_RUA_Connect(ps_domain, context_id_bstr, est_cause, hex2oct(ranap_cm_service_req))); + + /* Now HNBGW answers with RUA-DirectTransfer(RANAP-RabASsReq) */ + RUA.send(ts_RUA_DirectTransfer(ps_domain, context_id_bstr, hex2oct(ranap_rab_ass_req))); + + /* Now on LLSK first the Conn establishment is confirmed and then we receive data */ + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONN_ESTABLISH_CNF(context_id, 1, 0))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONN_DATA_REQ(context_id, 1, hex2oct(ranap_rab_ass_req)))); + + /* Now LLSK provides the remote TransportLayerAddress from RabAssReq and asks SUT to provide a local address: */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_ESTABLISH_IND(context_id, remote_tei, HNBLL_IF_ADDR_TYPE_IPV4, + f_HNBLLIF_Addr(HNBLL_IF_ADDR_TYPE_IPV4, g_pars.hnbgw_addr)))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_GTP_CONN_ESTABLISH_CNF(context_id, ?, 0, + HNBLL_IF_ADDR_TYPE_IPV4, ?))) -> value sd; + local_tei := sd.data.u.gtp.u.conn_establish.u.cnf.local_tei; + + /* Forward GTP data in both directions */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_DATA_IND(context_id, remote_tei, gtp_payload))); + GTP.receive(tr_GTPU_GPDU(ts_GtpPeerU(g_pars.hnodeb_addr), int2oct(remote_tei, 4), gtp_payload)); + f_gtpu_send(local_tei, gtp_payload); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_GTP_CONN_DATA_REQ(context_id, local_tei, gtp_payload))); + + /* Done, release GTP conn */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_RELEASE_IND(context_id, remote_tei))); + + /* UE sends Iu Release Complete to release the conn */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_RELEASE_IND(context_id, 1, 0, 0, hex2oct(iu_release_compl)))); + RUA.receive(tr_RUA_Disconnect(ps_domain, context_id_bstr, ts_RUA_Cause(normal), hex2oct(iu_release_compl))); +} +testcase TC_ps_mo_gtp_ping_pong() runs on test_CT { + var HNBGW_ConnHdlr vc_conn; + + f_init(); + vc_conn := f_start_handler(refers(f_tc_ps_mo_gtp_ping_pong)); + vc_conn.done; + f_shutdown_helper(); +} + control { execute( TC_hnb_register_request_accept() ); execute( TC_hnb_register_request_reject() ); execute( TC_mo_conn() ); execute( TC_paging() ); execute( TC_cs_mo_call() ); + execute( TC_ps_mo_gtp_ping_pong() ); } } diff --git a/hnodeb/gen_links.sh b/hnodeb/gen_links.sh index 6ddb4c0..84495e9 100755 --- a/hnodeb/gen_links.sh +++ b/hnodeb/gen_links.sh @@ -44,6 +44,10 @@ FILES="TELNETasp_PT.cc TELNETasp_PT.hh TELNETasp_PortType.ttcn" gen_links $DIR $FILES +DIR=$BASEDIR/titan.ProtocolModules.GTP_v13.5.0/src +FILES="GTPC_EncDec.cc GTPC_Types.ttcn GTPU_EncDec.cc GTPU_Types.ttcn" +gen_links $DIR $FILES + DIR=../library/hnbap FILES="HNBAP_CommonDataTypes.asn HNBAP_Constants.asn HNBAP_Containers.asn HNBAP_IEs.asn HNBAP_PDU_Contents.asn HNBAP_PDU_Descriptions.asn " FILES+="HNBAP_EncDec.cc HNBAP_Types.ttcn HNBAP_Templates.ttcn " @@ -59,7 +63,7 @@ FILES+="Iuh_Types.ttcn Iuh_CodecPort.ttcn Iuh_CodecPort_CtrlFunctDef.cc Iuh_CodecPort_CtrlFunct.ttcn Iuh_Emulation.ttcn DNS_Helpers.ttcn " FILES+="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn RTP_CodecPort.ttcn RTP_CodecPort_CtrlFunct.ttcn RTP_CodecPort_CtrlFunctDef.cc RTP_Emulation.ttcn IuUP_Types.ttcn IuUP_EncDec.cc IuUP_Emulation.ttcn " FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcn " - +FILES+="GTP_CodecPort.ttcn GTP_CodecPort_CtrlFunct.ttcn GTP_CodecPort_CtrlFunctDef.cc GTP_Emulation.ttcn GTP_Templates.ttcn IPCP_Types.ttcn GSM_Types.ttcn " gen_links $DIR $FILES ignore_pp_results diff --git a/hnodeb/regen_makefile.sh b/hnodeb/regen_makefile.sh index 2d13504..10f5c21 100755 --- a/hnodeb/regen_makefile.sh +++ b/hnodeb/regen_makefile.sh @@ -25,6 +25,9 @@ HNBAP_EncDec.cc RUA_EncDec.cc UD_PT.cc + GTPC_EncDec.cc + GTPU_EncDec.cc + GTP_CodecPort_CtrlFunctDef.cc " export CPPFLAGS_TTCN3=" diff --git a/library/HNBLLIF_Templates.ttcn b/library/HNBLLIF_Templates.ttcn index a2673c0..025f65f 100644 --- a/library/HNBLLIF_Templates.ttcn +++ b/library/HNBLLIF_Templates.ttcn @@ -320,4 +320,129 @@ } } +/********************** + * GTP SAPI + **********************/ +template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_ESTABLISH_IND(template (value) uint32_t context_id, + template (value) uint32_t remote_tei, + template (value) HNBLLIF_AddrType remote_gtpu_address_type, + template (value) HNBLLIF_Addr remote_gtpu_addr) := { + sapi := HNBLL_IF_SAPI_GTP, + u := { + gtp := { + prim := HNBLL_IF_GTP_MSG_CONN_ESTABLISH, + u := { + conn_establish := { + op := HNBLL_IF_OP_INDICATION, + u := { + ind := { + context_id := context_id, + remote_tei := remote_tei, + reserved := 0, + remote_gtpu_address_type := remote_gtpu_address_type, + remote_gtpu_addr := remote_gtpu_addr + } + } + } + } + } + } +} + +template (present) HNBLLIF_Message tr_HNBLLIF_GTP_CONN_ESTABLISH_CNF(template (present) uint32_t context_id := ?, + template (present) uint32_t local_tei := ?, + template (present) uint8_t error_code := ?, + template (present) HNBLLIF_AddrType local_gtpu_address_type := ?, + template (present) HNBLLIF_Addr local_gtpu_addr := ?) := { + sapi := HNBLL_IF_SAPI_GTP, + u := { + gtp := { + prim := HNBLL_IF_GTP_MSG_CONN_ESTABLISH, + u := { + conn_establish := { + op := HNBLL_IF_OP_CONFIRM, + u := { + cnf := { + context_id := context_id, + local_tei := local_tei, + error_code := error_code, + local_gtpu_address_type := local_gtpu_address_type, + local_gtpu_addr := local_gtpu_addr + } + } + } + } + } + } +} + +template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_RELEASE_IND(template (value) uint32_t context_id, + template (value) uint32_t remote_tei) := { + sapi := HNBLL_IF_SAPI_GTP, + u := { + gtp := { + prim := HNBLL_IF_GTP_MSG_CONN_RELEASE, + u := { + conn_release := { + op := HNBLL_IF_OP_INDICATION, + u := { + ind := { + context_id := context_id, + remote_tei := remote_tei + } + } + } + } + } + } +} + +template (present) HNBLLIF_Message tr_HNBLLIF_GTP_CONN_DATA_REQ(template (present) uint32_t context_id := ?, + template (present) uint32_t local_tei := ?, + template (present) octetstring data := ?) := { + sapi := HNBLL_IF_SAPI_GTP, + u := { + gtp := { + prim := HNBLL_IF_GTP_MSG_CONN_DATA, + u := { + conn_data := { + op := HNBLL_IF_OP_REQUEST, + u := { + req := { + context_id := context_id, + local_tei := local_tei, + data_len := ?, + data := data + } + } + } + } + } + } +} + +template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_DATA_IND(template (value) uint32_t context_id, + template (value) uint32_t remote_tei, + template (value) octetstring data) := { + sapi := HNBLL_IF_SAPI_GTP, + u := { + gtp := { + prim := HNBLL_IF_GTP_MSG_CONN_DATA, + u := { + conn_data := { + op := HNBLL_IF_OP_INDICATION, + u := { + ind := { + context_id := context_id, + remote_tei := remote_tei, + data_len := lengthof(data), + data := data + } + } + } + } + } + } +} + } with { encode "RAW" variant "BYTEORDER(first)" }; diff --git a/library/HNBLLIF_Types.ttcn b/library/HNBLLIF_Types.ttcn index 8b0c08f..664d34c 100644 --- a/library/HNBLLIF_Types.ttcn +++ b/library/HNBLLIF_Types.ttcn @@ -328,6 +328,106 @@ other, OTHERWISE)" }; +/********************** + * GTP SAPI + **********************/ +type enumerated HNBLLIF_GTP_MsgType { + HNBLL_IF_GTP_MSG_CONN_ESTABLISH ('0000'O), + HNBLL_IF_GTP_MSG_CONN_RELEASE ('0001'O), + HNBLL_IF_GTP_MSG_CONN_DATA ('0002'O) +} with { variant "FIELDLENGTH(16)" }; + +/* CONN_ESTABLISH */ +type record HNBLLIF_GTP_conn_establish_ind { + uint32_t context_id, + uint32_t remote_tei, + uint8_t reserved, + HNBLLIF_AddrType remote_gtpu_address_type, + HNBLLIF_Addr remote_gtpu_addr +} with { variant "" }; + +type record HNBLLIF_GTP_conn_establish_cnf { + uint32_t context_id, + uint32_t local_tei, + uint8_t error_code, + HNBLLIF_AddrType local_gtpu_address_type, + HNBLLIF_Addr local_gtpu_addr +} with { variant "" }; + +type union HNBLLIF_GTP_PrimOpUnion_conn_establish { + HNBLLIF_GTP_conn_establish_ind ind, + HNBLLIF_GTP_conn_establish_cnf cnf, + octetstring other +} with { variant "" }; +type record HNBLLIF_GTP_PrimOp_conn_establish { + HNBLLIF_Operation op, + HNBLLIF_GTP_PrimOpUnion_conn_establish u +} with { variant (u) "CROSSTAG( ind, op = HNBLL_IF_OP_INDICATION; + cnf, op = HNBLL_IF_OP_CONFIRM; + other, OTHERWISE)" +}; + +/* CONN_RELEASE */ +type record HNBLLIF_GTP_conn_release_ind { + uint32_t context_id, + uint32_t remote_tei +} with { variant "" }; + +type union HNBLLIF_GTP_PrimOpUnion_conn_release { + HNBLLIF_GTP_conn_release_ind ind, + octetstring other +} with { variant "" }; +type record HNBLLIF_GTP_PrimOp_conn_release { + HNBLLIF_Operation op, + HNBLLIF_GTP_PrimOpUnion_conn_release u +} with { variant (u) "CROSSTAG( ind, op = HNBLL_IF_OP_INDICATION; + other, OTHERWISE)" +}; + +/* CONN_DATA */ +type record HNBLLIF_GTP_conn_data_ind { + uint32_t context_id, + uint32_t remote_tei, + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type record HNBLLIF_GTP_conn_data_req { + uint32_t context_id, + uint32_t local_tei, + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type union HNBLLIF_GTP_PrimOpUnion_conn_data { + HNBLLIF_GTP_conn_data_req req, + HNBLLIF_GTP_conn_data_ind ind, + octetstring other +} with { variant "" }; +type record HNBLLIF_GTP_PrimOp_conn_data { + HNBLLIF_Operation op, + HNBLLIF_GTP_PrimOpUnion_conn_data u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + ind, op = HNBLL_IF_OP_INDICATION; + other, OTHERWISE)" +}; + +type union HNBLLIF_GTP_PrimUnion { + HNBLLIF_GTP_PrimOp_conn_establish conn_establish, + HNBLLIF_GTP_PrimOp_conn_release conn_release, + HNBLLIF_GTP_PrimOp_conn_data conn_data, + octetstring other +} with { variant "" }; + +type record HNBLLIF_GTP_PrimHdr { + HNBLLIF_GTP_MsgType prim, + HNBLLIF_GTP_PrimUnion u +} with { variant (u) "CROSSTAG( conn_establish, prim = HNBLL_IF_GTP_MSG_CONN_ESTABLISH; + conn_release, prim = HNBLL_IF_GTP_MSG_CONN_RELEASE; + conn_data, prim = HNBLL_IF_GTP_MSG_CONN_DATA; + other, OTHERWISE)" +}; + /********************** * General @@ -343,7 +443,7 @@ type enumerated HNBLLIF_Sapi { HNBLL_IF_SAPI_CTL ('00000000'O), HNBLL_IF_SAPI_IUH ('00000001'O), - //HNBLL_IF_SAPI_GTP ('00000002'O), + HNBLL_IF_SAPI_GTP ('00000002'O), HNBLL_IF_SAPI_AUDIO ('00000003'O) } with { variant "FIELDLENGTH(32)" }; @@ -357,6 +457,7 @@ type union HNBLLIF_SapiUnion { HNBLLIF_CTL_PrimHdr ctl, HNBLLIF_IUH_PrimHdr iuh, + HNBLLIF_GTP_PrimHdr gtp, HNBLLIF_AUDIO_PrimHdr audio, octetstring other } with { variant "" }; @@ -366,6 +467,7 @@ HNBLLIF_SapiUnion u } with { variant (u) "CROSSTAG( ctl, sapi = HNBLL_IF_SAPI_CTL; iuh, sapi = HNBLL_IF_SAPI_IUH; + gtp, sapi = HNBLL_IF_SAPI_GTP; audio, sapi = HNBLL_IF_SAPI_AUDIO; other, OTHERWISE)" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 Gerrit-Change-Number: 26445 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 00:41:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 4 Dec 2021 00:41:05 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: pull registry.osmocom.org imgs In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26443 ) Change subject: jenkins-common.sh: pull registry.osmocom.org imgs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26443 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1cf998c21e4ee1f723c3b783703e339328377f3e Gerrit-Change-Number: 26443 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Sat, 04 Dec 2021 00:41:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 00:41:11 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 4 Dec 2021 00:41:11 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: fix redundant titan image build In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26442 ) Change subject: jenkins-common.sh: fix redundant titan image build ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7127e3ebac3a6a985c3ba50ba8c7cb8c5de978d9 Gerrit-Change-Number: 26442 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Sat, 04 Dec 2021 00:41:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:03:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:03:51 +0000 Subject: Change in libosmo-netif[master]: stream: Add support for AF_UNIX sockets In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26434 ) Change subject: stream: Add support for AF_UNIX sockets ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmo-netif/+/26434/4/src/stream.c File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26434/4/src/stream.c at 412 PS4, Line 412: case AF_UNIX: I think SO_NOSIGPIPE may also make sense for unix domain sockets? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 Gerrit-Change-Number: 26434 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Arran Cudbard-bell Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Dec 2021 10:03:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:14:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:14:33 +0000 Subject: Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26426 ) Change subject: Introduce osmo_prim_srv APIs ...................................................................... Patch Set 5: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmo-netif/+/26426/5/src/prim.c File src/prim.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26426/5/src/prim.c at 107 PS5, Line 107: 1600 I think we should probably make that somehow user-configurable. I could very well imagine primitives of a larger size at some point. Maybe just make it a struct member of the prim_srv_link? Also, it may make sense to use msgb_alloc_c using the stream_srv as context, this way it is easier to track from which particular server a memory leak originates. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 Gerrit-Change-Number: 26426 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Dec 2021 10:14:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:16:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:16:00 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26435 ) Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmo-netif/+/26435/4/src/prim.c File src/prim.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26435/4/src/prim.c at 98 PS4, Line 98: OSMO_PRIM_CTL_SAPI this could be a public #define that is visible to the applications? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Dec 2021 10:16:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:16:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:16:42 +0000 Subject: Change in osmo-ttcn3-hacks[master]: break GTP_Templates dependency on Osmo_Gb_Types, BSSGP_Types, NS_Types In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26441 ) Change subject: break GTP_Templates dependency on Osmo_Gb_Types, BSSGP_Types, NS_Types ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26441 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icd8234908af445b798517fe110cd0648969179a4 Gerrit-Change-Number: 26441 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Dec 2021 10:16:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:17:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:17:57 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 ) Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Dec 2021 10:17:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:19:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:19:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add audio SAPI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 ) Change subject: hnodeb: Add audio SAPI ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 Gerrit-Change-Number: 26444 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Dec 2021 10:19:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:20:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:20:41 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add gtp SAPI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 ) Change subject: hnodeb: Add gtp SAPI ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 Gerrit-Change-Number: 26445 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Dec 2021 10:20:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:22:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:22:41 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: fix redundant titan image build In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26442 ) Change subject: jenkins-common.sh: fix redundant titan image build ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7127e3ebac3a6a985c3ba50ba8c7cb8c5de978d9 Gerrit-Change-Number: 26442 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Sat, 04 Dec 2021 10:22:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:22:55 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:22:55 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: pull registry.osmocom.org imgs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26443 ) Change subject: jenkins-common.sh: pull registry.osmocom.org imgs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26443 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1cf998c21e4ee1f723c3b783703e339328377f3e Gerrit-Change-Number: 26443 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Sat, 04 Dec 2021 10:22:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:33:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:33:58 +0000 Subject: Change in libosmocore[master]: logging: make LIBOSMOCORE_NO_LOGGING work as expected In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26394 ) Change subject: logging: make LIBOSMOCORE_NO_LOGGING work as expected ...................................................................... Patch Set 1: > Patch Set 1: > > No, this was always about getting rid of logging related calls and especially the infinite log level checks, I just got the first patch wrong. The fsm will try to log every single event in _osmo_fsm_inst_dispatch using LOGPFSMSRC for example, which adds up if we have a lot of events... like for every single byte.. then the naming/condition is wrong. "DEBUG" should only control whether debug logging is compiled in. If logging shall be globlaly disalbe then there should be a macro that implies this in its name, such as "#define DISABLE_LOGGING" or LOGGING_DISABLED or NO_LOGGING or whatever that makes its purpose clear. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4c78abe5f198139f96ffa289998855be2477585 Gerrit-Change-Number: 26394 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 04 Dec 2021 10:33:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:35:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:35:18 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/BSC_ConnectionHandler: refactor and split f_mm_common() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26404 ) Change subject: msc/BSC_ConnectionHandler: refactor and split f_mm_common() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib7ebe8fd675295beb02cadebb19d8465dffeb732 Gerrit-Change-Number: 26404 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 04 Dec 2021 10:35:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:36:34 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:36:34 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: fix TC_cm_serv_rej In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 ) Change subject: bsc: fix TC_cm_serv_rej ...................................................................... Patch Set 1: Code-Review-1 I really dislike this kind if hand-waving. It basically implies "we are giving up to understand the cause and are just fighting the symptoms". Let's please understand the root cause of the problem and try to fix that. Or if at some point we determine it's un-fixable, we can fall-back to work-arounds. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iad30319a7e9e726d006c9934ed2eb48f886811a9 Gerrit-Change-Number: 26433 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Dec 2021 10:36:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:37:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:37:52 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: ensure UEA0 is not passwd to ranap_new_msg_sec_mod_cmd2() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 04 Dec 2021 10:37:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:38:22 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:38:22 +0000 Subject: Change in pysim[master]: filesystem: actively probe applications In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26431 ) Change subject: filesystem: actively probe applications ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3fa77a68664fe50d690a18adfb1ae1a88a189827 Gerrit-Change-Number: 26431 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Dec 2021 10:38:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 10:38:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 4 Dec 2021 10:38:24 +0000 Subject: Change in pysim[master]: filesystem: actively probe applications In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26431 ) Change subject: filesystem: actively probe applications ...................................................................... filesystem: actively probe applications A profile can cover lots of different applications. Those applications may not exist on all card models. To exclude applications that are not installed on the particular card EF.DIR is evaluated. However, there may be applications that are not registered in EF.DIR but supported by the profile. To cover those as well, lets try to select the applications we do not see in EF.DIR. If selecting works we know that the application exists on the card and we can include them in the RuntimeState. Change-Id: I3fa77a68664fe50d690a18adfb1ae1a88a189827 --- M pySim/filesystem.py 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 4c3308c..c706131 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1101,14 +1101,23 @@ for a in aids_card: for f in apps_profile: if f.aid in a: - print(" %s: %s" % (f.name, a)) + print(" %s: %s (EF.DIR)" % (f.name, a)) aids_taken.append(a) apps_taken.append(f) aids_unknown = set(aids_card) - set(aids_taken) for a in aids_unknown: - print(" unknown: %s" % a) + print(" unknown: %s (EF.DIR)" % a) else: - print("error: could not determine card applications") + print("warning: EF.DIR seems to be empty!") + + # Some card applications may not be registered in EF.DIR, we will actively + # probe for those applications + for f in set(apps_profile) - set(apps_taken): + data, sw = self.card.select_adf_by_aid(f.aid) + if sw == "9000": + print(" %s: %s" % (f.name, a)) + apps_taken.append(f) + return apps_taken def reset(self, cmd_app=None) -> Hexstr: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3fa77a68664fe50d690a18adfb1ae1a88a189827 Gerrit-Change-Number: 26431 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 11:01:57 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 4 Dec 2021 11:01:57 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/BSC_ConnectionHandler: refactor and split f_mm_common() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26404 ) Change subject: msc/BSC_ConnectionHandler: refactor and split f_mm_common() ...................................................................... msc/BSC_ConnectionHandler: refactor and split f_mm_common() Reduce nesting and improve readability by splitting GERAN/UTRAN specific CMC/SMC message handling into separate functions. Change-Id: Ib7ebe8fd675295beb02cadebb19d8465dffeb732 Related: OS#5333 --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 69 insertions(+), 57 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 2f270ca..873ec5b 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -611,68 +611,80 @@ } +private function f_mm_ciph_geran() runs on BSC_ConnHdlr +{ + var template BSSMAP_IE_EncryptionInformation encryptionInformation; + var template BSSMAP_IE_ChosenEncryptionAlgorithm chosenEncryptionAlgorithm; + var template BSSMAP_IE_KC128 kC128; + var OCT1 a5_perm_alg; + var PDU_BSSAP pdu; + + if (g_pars.net.expect_ciph) { + /* There is nothing to do */ + return; + } + + f_get_expected_encryption(encryptionInformation, chosenEncryptionAlgorithm, kC128, a5_perm_alg); + alt { + [] BSSAP.receive(tr_BSSMAP_CipherModeCmd2(encryptionInformation, kC128)) -> value pdu { + var OCT1 a5_chosen := f_best_alg_from_mask(a5_perm_alg); + var integer a5_nr := f_alg_from_mask(a5_chosen); + BSSAP.send(ts_BSSMAP_CipherModeCompl(int2oct(a5_nr+1, 1))); + } + [] BSSAP.receive(tr_BSSMAP_CipherModeCmd2) -> value pdu { + log("Error: Ciphering Mode Command with unexpected content. Expected: ", + tr_BSSMAP_CipherModeCmd2(encryptionInformation, kC128), " got: ", pdu); + setverdict(fail, "Ciphering Mode Command with unexpected content."); + mtc.stop; + } + [] BSSAP.receive(tr_BSSMAP_ClassmarkRequest) { + BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)) + repeat; + } + } + /* FIXME: Send the best available algorithm */ +} + +private function f_mm_ciph_utran() runs on BSC_ConnHdlr +{ + alt { + [g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmdEnc(uia_algs := ?, + uia_key := oct2bit(g_pars.vec.ik), + key_sts := ?, + uea_algs := ?, + uea_key := oct2bit(g_pars.vec.ck))) { + var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1*/ + var EncryptionAlgorithm uea_chosen := 1; /*standard_UMTS_encryption_algorith_UEA1*/ + BSSAP.send(ts_RANAP_SecurityModeCompleteEnc(uia_chosen, uea_chosen)); + } + [g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmdEnc(?,?,?,?,?)) { + setverdict(fail, "Invalid SecurityModeCommand (ciphering case)"); + mtc.stop; + } + [not g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmd(uia_algs := ?, + uia_key := oct2bit(g_pars.vec.ik), + key_sts := ?)) { + var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1;*/ + BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen)); + } + [not g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmd(?,?,?)) { + setverdict(fail, "Invalid SecurityModeCommand (non-ciphering case)"); + mtc.stop; + } + } +} + function f_mm_common() runs on BSC_ConnHdlr { f_mm_auth(); - if (g_pars.ran_is_geran) { - if (g_pars.net.expect_ciph) { - var template BSSMAP_IE_EncryptionInformation encryptionInformation; - var template BSSMAP_IE_ChosenEncryptionAlgorithm chosenEncryptionAlgorithm; - var template BSSMAP_IE_KC128 kC128; - var OCT1 a5_perm_alg; - f_get_expected_encryption(encryptionInformation, chosenEncryptionAlgorithm, kC128, a5_perm_alg); - var PDU_BSSAP pdu; - var template PDU_BSSAP expect_ciph_mode_cmd := tr_BSSMAP_CipherModeCmd2(encryptionInformation, kC128); - alt { - [] BSSAP.receive(expect_ciph_mode_cmd) -> value pdu { - var OCT1 a5_chosen := f_best_alg_from_mask(a5_perm_alg); - var integer a5_nr := f_alg_from_mask(a5_chosen); - BSSAP.send(ts_BSSMAP_CipherModeCompl(int2oct(a5_nr+1, 1))); - } - [] BSSAP.receive(tr_BSSMAP_CipherModeCmd2) -> value pdu { - log("Error: Ciphering Mode Command with unexpected content. Expected: ", - expect_ciph_mode_cmd, " got: ", pdu); - setverdict(fail, "Ciphering Mode Command with unexpected content."); - mtc.stop; - } - [] BSSAP.receive(tr_BSSMAP_ClassmarkRequest) { - BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)) - repeat; - } - } - /* FIXME: Send the best available algorithm */ - } - f_expect_common_id(); - } else { /* UTRAN */ - alt { - [g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmdEnc(uia_algs := ?, - uia_key := oct2bit(g_pars.vec.ik), - key_sts := ?, - uea_algs := ?, - uea_key := oct2bit(g_pars.vec.ck))) { - var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1*/ - var EncryptionAlgorithm uea_chosen := 1; /*standard_UMTS_encryption_algorith_UEA1*/ - BSSAP.send(ts_RANAP_SecurityModeCompleteEnc(uia_chosen, uea_chosen)); - f_expect_common_id(); - } - [g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmdEnc(?,?,?,?,?)) { - setverdict(fail, "Invalid SecurityModeCommand (ciphering case)"); - mtc.stop; - } - [not g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmd(uia_algs := ?, - uia_key := oct2bit(g_pars.vec.ik), - key_sts := ?)) { - var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1;*/ - BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen)); - f_expect_common_id(); - } - [not g_pars.net.expect_ciph] BSSAP.receive(tr_RANAP_SecurityModeCmd(?,?,?)) { - setverdict(fail, "Invalid SecurityModeCommand (non-ciphering case)"); - mtc.stop; - } - } + if (g_pars.ran_is_geran) { + f_mm_ciph_geran(); + } else { + f_mm_ciph_utran(); } + + f_expect_common_id(); } function f_expect_mm_info() runs on BSC_ConnHdlr { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib7ebe8fd675295beb02cadebb19d8465dffeb732 Gerrit-Change-Number: 26404 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 13:53:42 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 4 Dec 2021 13:53:42 +0000 Subject: Change in osmo-msc[master]: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26410 ) Change subject: libmsc: ran_iu_make_security_mode_command(): clarify UIA mask ...................................................................... libmsc: ran_iu_make_security_mode_command(): clarify UIA mask Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a --- M src/libmsc/ran_msg_iu.c 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index 6705ab8..cf57d35 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -375,6 +375,8 @@ static struct msgb *ran_iu_make_security_mode_command(struct osmo_fsm_inst *caller_fi, const struct ran_cipher_mode_command *cm) { + /* TODO: make the choice of available UIA algorithms configurable */ + const uint8_t uia_mask = (1 << OSMO_UTRAN_UIA1) | (1 << OSMO_UTRAN_UIA2); bool use_encryption = cm->utran.uea_encryption_mask > (1 << OSMO_UTRAN_UEA0); LOG_RAN_IU_ENC(caller_fi, LOGL_DEBUG, "Tx RANAP SECURITY MODE COMMAND to RNC, IK=%s, CK=%s\n", @@ -384,7 +386,9 @@ * in the case of A5? */ return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, use_encryption ? cm->vec->ck : NULL, - RANAP_KeyStatus_new, 0x06, cm->utran.uea_encryption_mask); + RANAP_KeyStatus_new, + (uia_mask << 1), /* API treats LSB as UIA0 */ + cm->utran.uea_encryption_mask); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7535d5ede5b22c61575a16d15927598e6137392a Gerrit-Change-Number: 26410 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 15:30:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 4 Dec 2021 15:30:17 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Makefile: add target for generating tags References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26446 ) Change subject: Makefile: add target for generating tags ...................................................................... Makefile: add target for generating tags Change-Id: Ic2c68c12471d872f449e29082a98df14b47bbda4 --- M Makefile 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/26446/1 diff --git a/Makefile b/Makefile index f05ab48..87ce759 100644 --- a/Makefile +++ b/Makefile @@ -108,3 +108,10 @@ $(eval $(call DIR_clean_template,$(dir))) \ $(eval $(call DIR_all_template,$(dir))) \ ) + +.PHONY: tags +tags: + find $(shell pwd) \ + -type f -name "*.ttcn" -o \ + -type f -name "*.ttcnpp" | \ + xargs ctags -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26446 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2c68c12471d872f449e29082a98df14b47bbda4 Gerrit-Change-Number: 26446 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 16:31:58 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 4 Dec 2021 16:31:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: fix TC_cm_serv_rej In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 ) Change subject: bsc: fix TC_cm_serv_rej ...................................................................... Patch Set 1: Code-Review-2 I agree with Harald here, it would be good to find the actual problem. To me it looks like the race condition is happening in RSL_Emulation.f_chan_est(), which is called by MSC_ConnectionHandler.f_create_chan_and_exp(). In this function we basically send a ChanRqd, wait for an Immediate Assignment, and then send the ESTablish INDication. The last message is important because it triggers the SCCP connection establishment towards the virtual MSC. Most likely, the Service Reject message gets enqueued *before* the actual SCCP connection is established. I compared the following test suite logs line-by-line: [PASS] https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bsc-test/1580/artifact/logs/bsc-tester/BSC_Tests.TC_cm_serv_rej.merged [FAIL] https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bsc-test/1581/artifact/logs/bsc-tester/BSC_Tests.TC_cm_serv_rej.merged and indeed, during the successful run we first get a 'SCCPasp_Types.ASP_SCCP_N_CONNECT_ind', and then enqueue a 'BSSAP_Types.PDU_BSSAP' with the reject. The logs of the failed run indicate that we get a 'BSSAP_Types.PDU_BSSAP' before the 'SCCPasp_Types.ASP_SCCP_N_CONNECT_ind'. My proposal is to modify f_create_chan_and_exp() in a way that it would block until the SCCP connection is established. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iad30319a7e9e726d006c9934ed2eb48f886811a9 Gerrit-Change-Number: 26433 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Dec 2021 16:31:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 17:31:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 4 Dec 2021 17:31:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/BSSMAP_Templates: parametrize codec list for tr_BSSMAP_ComplL3 References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26447 ) Change subject: library/BSSMAP_Templates: parametrize codec list for tr_BSSMAP_ComplL3 ...................................................................... library/BSSMAP_Templates: parametrize codec list for tr_BSSMAP_ComplL3 Change-Id: I4abd77ebe47791adf2708e1c31614383d18e54b8 --- M library/BSSMAP_Templates.ttcn 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/26447/1 diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn index 67537fb..d497d25 100644 --- a/library/BSSMAP_Templates.ttcn +++ b/library/BSSMAP_Templates.ttcn @@ -388,7 +388,8 @@ } template PDU_BSSAP tr_BSSMAP_ComplL3(template octetstring l3_info := ?, - template BSSMAP_IE_CellIdentifier cell_id := ?) + template BSSMAP_IE_CellIdentifier cell_id := ?, + template BSSMAP_IE_SpeechCodecList codec_list := *) modifies tr_BSSAP_BSSMAP := { pdu := { bssmap := { @@ -399,7 +400,7 @@ chosenChannel := *, lSAIdentifier := *, aPDU := *, - codecList := *, + codecList := codec_list, redirectAttemptFlag := *, sendSequenceNumber := *, iMSI := * -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4abd77ebe47791adf2708e1c31614383d18e54b8 Gerrit-Change-Number: 26447 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 17:31:28 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 4 Dec 2021 17:31:28 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: f_create_chan_and_exp(): ensure that SCCP connection is up References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26448 ) Change subject: bsc: f_create_chan_and_exp(): ensure that SCCP connection is up ...................................................................... bsc: f_create_chan_and_exp(): ensure that SCCP connection is up This change fixes sporadic failures of TC_cm_serv_rej: RAN Connection table not found by component TC_cm_serv_rej(2648) BSC_Tests.ttcn:11106 BSC_Tests control part BSC_Tests.ttcn:10550 TC_cm_serv_rej testcase The reason is that sometimes a BSSAP/DTAP PDU (with CM Service Reject) gets enqueued before the SUT has established an SCCP connection to the virtual MSC. This causes a lookup error in the RAN connection table. A simple solution would be to add a receive statement after calling f_create_chan_and_exp(), like it's done everywhere else: f_create_chan_and_exp(); BSSAP.receive(tr_BSSMAP_ComplL3); // <--- But a more general solution is to expect and receive this message in f_create_chan_and_exp(), so we can reduce code duplication and make the API more convinient. This is exactly what this change does. Change-Id: Ic675168e29919e1234cb49440c4a630238ff5d70 Related: SYS#4878 --- M bsc/BSC_Tests.ttcn M bsc/MSC_ConnectionHandler.ttcn 2 files changed, 25 insertions(+), 61 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/48/26448/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 22df0cb..3aaab85 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3880,7 +3880,6 @@ /* this is like the beginning of f_establish_fully(), but only up to ciphering reject */ var BSSMAP_FIELD_CodecType codecType; - timer T := 10.0; codecType := exp_ass_req.pdu.bssmap.assignmentRequest.codecList.codecElements[0].codecType; f_MscConnHdlr_init(g_pars.media_nr, host_bts, host_mgw_mgcp, codecType); @@ -3888,24 +3887,6 @@ f_create_chan_and_exp(); /* we should now have a COMPL_L3 at the MSC */ - var template PDU_BSSAP exp_l3_compl; - exp_l3_compl := tr_BSSMAP_ComplL3() - if (g_pars.aoip == false) { - exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := omit; - } else { - exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := ?; - } - T.start; - alt { - [] BSSAP.receive(exp_l3_compl); - [] BSSAP.receive(tr_BSSMAP_ComplL3) { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Received non-matching COMPLETE LAYER 3 INFORMATION"); - } - [] T.timeout { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for COMPLETE LAYER 3 INFORMATION"); - } - } - /* Start ciphering, expect Cipher Mode Reject */ f_cipher_mode(g_pars.encr, exp_fail := true); } @@ -5055,7 +5036,6 @@ f_create_chan_and_exp(); /* we should now have a COMPL_L3 at the MSC */ - BSSAP.receive(tr_BSSMAP_ComplL3); BSSAP.send(ts_BSSMAP_ClassmarkRequest); RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, decmatch tr_RRM_CM_ENQUIRY)); @@ -5081,7 +5061,6 @@ f_create_chan_and_exp(); /* we should now have a COMPL_L3 at the MSC */ - BSSAP.receive(tr_BSSMAP_ComplL3); /* Send CommonID */ BSSAP.send(ts_BSSMAP_CommonId(g_pars.imsi)); @@ -5105,7 +5084,6 @@ g_pars := f_gen_test_hdlr_pars(); f_create_chan_and_exp(); /* we should now have a COMPL_L3 at the MSC */ - BSSAP.receive(tr_BSSMAP_ComplL3); /* send the single message we want to send */ f_rsl_send_l3(l3); @@ -5176,7 +5154,6 @@ g_pars := f_gen_test_hdlr_pars(); f_create_chan_and_exp(); /* we should now have a COMPL_L3 at the MSC */ - BSSAP.receive(tr_BSSMAP_ComplL3); /* send short message */ RSL.send(ts_RSL_DATA_IND(g_chan_nr, valueof(ts_RslLinkID_DCCH(0)), ''O)); @@ -10534,6 +10511,7 @@ private function f_TC_cm_serv_rej(charstring id) runs on MSC_ConnHdlr { f_create_chan_and_exp(); + /* we should now have a COMPL_L3 at the MSC */ BSSAP.send(ts_PDU_DTAP_MT(ts_CM_SERV_REJ('02'O), '00'O)); f_sleep(1.0); } @@ -10575,24 +10553,6 @@ f_rslem_dchan_queue_enable(); /* we should now have a COMPL_L3 at the MSC */ - var template PDU_BSSAP exp_l3_compl; - exp_l3_compl := tr_BSSMAP_ComplL3() - if (g_pars.aoip == false) { - exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := omit; - } else { - exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := ?; - } - timer T := 10.0; - T.start; - alt { - [] BSSAP.receive(exp_l3_compl); - [] BSSAP.receive(tr_BSSMAP_ComplL3) { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Received non-matching COMPLETE LAYER 3 INFORMATION"); - } - [] T.timeout { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for COMPLETE LAYER 3 INFORMATION"); - } - } f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); activate(as_Media_mgw()); diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index 481abc0..4aeb539 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -644,19 +644,42 @@ expect_tsc := omit } -function f_create_chan_and_exp() runs on MSC_ConnHdlr { +function f_create_chan_and_exp(template (present) PDU_BSSAP exp_l3_compl := ?) +runs on MSC_ConnHdlr { var MobileIdentityLV mi := valueof(ts_MI_IMSI_LV(g_pars.imsi)); var PDU_ML3_MS_NW l3_info := valueof(ts_CM_SERV_REQ(CM_TYPE_MO_CALL, mi)); var octetstring l3_enc := enc_PDU_ML3_MS_NW(l3_info); var template uint3_t tsc := ?; + timer T; if (not istemplatekind(g_pars.expect_tsc, "omit")) { tsc := g_pars.expect_tsc; } + if (istemplatekind(exp_l3_compl, "?")) { + if (g_pars.aoip == false) { + exp_l3_compl := tr_BSSMAP_ComplL3(l3_enc, codec_list := omit); + } else { + exp_l3_compl := tr_BSSMAP_ComplL3(l3_enc, codec_list := ?); + } + } + f_create_bssmap_exp(l3_enc); /* call helper function for CHAN_RQD -> IMM ASS ->EST_IND */ RSL_Emulation.f_chan_est(g_pars.ra, l3_enc, g_pars.link_id, g_pars.fn, tsc); + /* wait for a COMPL_L3 from the BSC to ensure that the SCCP connection is up */ + T.start(2.0); + alt { + [] BSSAP.receive(exp_l3_compl); + [] BSSAP.receive(tr_BSSMAP_ComplL3) { + setverdict(fail, "Received non-matching COMPLETE LAYER 3 INFORMATION"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + [] T.timeout { + setverdict(fail, "Timeout waiting for COMPLETE LAYER 3 INFORMATION"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } } function f_rsl_send_l3(template PDU_ML3_MS_NW l3, template (omit) RslLinkId link_id := omit, @@ -1214,25 +1237,6 @@ f_ass_patch_lcls(ass_tpl, exp_ass_cpl); f_create_chan_and_exp(); - /* we should now have a COMPL_L3 at the MSC */ - - var template PDU_BSSAP exp_l3_compl; - exp_l3_compl := tr_BSSMAP_ComplL3() - if (g_pars.aoip == false) { - exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := omit; - } else { - exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := ?; - } - T.start; - alt { - [] BSSAP.receive(exp_l3_compl); - [] BSSAP.receive(tr_BSSMAP_ComplL3) { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Received non-matching COMPLETE LAYER 3 INFORMATION"); - } - [] T.timeout { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for COMPLETE LAYER 3 INFORMATION"); - } - } /* start ciphering, if requested */ if (ispresent(g_pars.encr)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic675168e29919e1234cb49440c4a630238ff5d70 Gerrit-Change-Number: 26448 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: dexter Gerrit-Reviewer: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 17:32:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 4 Dec 2021 17:32:32 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: fix TC_cm_serv_rej In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 ) Change subject: bsc: fix TC_cm_serv_rej ...................................................................... Patch Set 1: Here is my solution: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26448. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iad30319a7e9e726d006c9934ed2eb48f886811a9 Gerrit-Change-Number: 26433 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 04 Dec 2021 17:32:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 18:12:06 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 4 Dec 2021 18:12:06 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: tune logging configuration References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26449 ) Change subject: bsc/osmo-{bsc,stp}.cfg: tune logging configuration ...................................................................... bsc/osmo-{bsc,stp}.cfg: tune logging configuration Change-Id: I955c0b8dbf74761d525c6bfb195eed418af24ab6 --- M bsc/osmo-bsc.cfg M bsc/osmo-stp.cfg 2 files changed, 12 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/49/26449/1 diff --git a/bsc/osmo-bsc.cfg b/bsc/osmo-bsc.cfg index b64a63d..b318e7c 100644 --- a/bsc/osmo-bsc.cfg +++ b/bsc/osmo-bsc.cfg @@ -5,10 +5,14 @@ ! log stderr logging filter all 1 - logging color 1 + logging print file basename last + logging print category-hex 0 logging print category 1 + logging print level 1 logging timestamp 1 - logging print extended-timestamp 1 + logging color 1 +! + logging level set-all notice logging level rll notice logging level mm notice logging level rr notice @@ -22,24 +26,6 @@ logging level ctrl notice logging level filter debug logging level pcu debug - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl notice - logging level lgtp notice - logging level lstats notice - logging level lgsup notice - logging level loap notice - logging level lss7 notice - logging level lsccp notice - logging level lsua notice - logging level lm3ua notice - logging level lmgcp notice - logging level reset notice ! stats interval 0 stats reporter statsd diff --git a/bsc/osmo-stp.cfg b/bsc/osmo-stp.cfg index 7ea46a4..b0b4f05 100644 --- a/bsc/osmo-stp.cfg +++ b/bsc/osmo-stp.cfg @@ -4,27 +4,18 @@ ! log stderr logging filter all 1 - logging color 1 + logging print file basename last + logging print category-hex 0 logging print category 1 + logging print level 1 logging timestamp 1 - logging print extended-timestamp 1 - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl notice - logging level lgtp notice - logging level lstats notice - logging level lgsup notice - logging level loap notice + logging color 1 +! + logging level set-all notice logging level lss7 debug logging level lsccp debug logging level lsua debug logging level lm3ua debug - logging level lmgcp notice ! line vty no login -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26449 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I955c0b8dbf74761d525c6bfb195eed418af24ab6 Gerrit-Change-Number: 26449 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 4 18:12:08 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 4 Dec 2021 18:12:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26450 ) Change subject: bsc/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' ...................................................................... bsc/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' Change-Id: If53c49157ec861163f3d993972414674ab18119f --- M bsc/osmo-bsc.cfg 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/26450/1 diff --git a/bsc/osmo-bsc.cfg b/bsc/osmo-bsc.cfg index b318e7c..0ed4916 100644 --- a/bsc/osmo-bsc.cfg +++ b/bsc/osmo-bsc.cfg @@ -68,7 +68,7 @@ timer t3113 10 timer t3212 30 bts 0 - type sysmobts + type osmo-bts band DCS1800 cell_identity 0 location_area_code 1 @@ -158,7 +158,7 @@ phys_chan_config PDCH hopping enabled 0 bts 1 - type sysmobts + type osmo-bts band DCS1800 cell_identity 1 location_area_code 1 @@ -248,7 +248,7 @@ phys_chan_config PDCH hopping enabled 0 bts 2 - type sysmobts + type osmo-bts band DCS1800 cell_identity 1 location_area_code 2 @@ -338,7 +338,7 @@ phys_chan_config PDCH hopping enabled 0 bts 3 - type sysmobts + type osmo-bts band DCS1800 cell_identity 3 location_area_code 3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If53c49157ec861163f3d993972414674ab18119f Gerrit-Change-Number: 26450 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 5 09:32:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 5 Dec 2021 09:32:57 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: fix TC_cm_serv_rej In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 ) Change subject: bsc: fix TC_cm_serv_rej ...................................................................... Patch Set 1: > Patch Set 1: Code-Review-2 > > My proposal is to modify f_create_chan_and_exp() in a way that it would block until the SCCP connection is established. ACK -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iad30319a7e9e726d006c9934ed2eb48f886811a9 Gerrit-Change-Number: 26433 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 05 Dec 2021 09:32:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 5 09:34:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 5 Dec 2021 09:34:06 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: f_create_chan_and_exp(): ensure that SCCP connection is up In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26448 ) Change subject: bsc: f_create_chan_and_exp(): ensure that SCCP connection is up ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic675168e29919e1234cb49440c4a630238ff5d70 Gerrit-Change-Number: 26448 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Sun, 05 Dec 2021 09:34:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 5 09:34:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 5 Dec 2021 09:34:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: tune logging configuration In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26449 ) Change subject: bsc/osmo-{bsc,stp}.cfg: tune logging configuration ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26449 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I955c0b8dbf74761d525c6bfb195eed418af24ab6 Gerrit-Change-Number: 26449 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 05 Dec 2021 09:34:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 5 09:34:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 5 Dec 2021 09:34:57 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26450 ) Change subject: bsc/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If53c49157ec861163f3d993972414674ab18119f Gerrit-Change-Number: 26450 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 05 Dec 2021 09:34:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 5 09:35:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 5 Dec 2021 09:35:51 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/BSSMAP_Templates: parametrize codec list for tr_BSSMAP_ComplL3 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26447 ) Change subject: library/BSSMAP_Templates: parametrize codec list for tr_BSSMAP_ComplL3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4abd77ebe47791adf2708e1c31614383d18e54b8 Gerrit-Change-Number: 26447 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 05 Dec 2021 09:35:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 5 09:36:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 5 Dec 2021 09:36:04 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Makefile: add target for generating tags In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26446 ) Change subject: Makefile: add target for generating tags ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26446 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2c68c12471d872f449e29082a98df14b47bbda4 Gerrit-Change-Number: 26446 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 05 Dec 2021 09:36:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 5 09:36:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 5 Dec 2021 09:36:06 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Makefile: add target for generating tags In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26446 ) Change subject: Makefile: add target for generating tags ...................................................................... Makefile: add target for generating tags Change-Id: Ic2c68c12471d872f449e29082a98df14b47bbda4 --- M Makefile 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/Makefile b/Makefile index f05ab48..87ce759 100644 --- a/Makefile +++ b/Makefile @@ -108,3 +108,10 @@ $(eval $(call DIR_clean_template,$(dir))) \ $(eval $(call DIR_all_template,$(dir))) \ ) + +.PHONY: tags +tags: + find $(shell pwd) \ + -type f -name "*.ttcn" -o \ + -type f -name "*.ttcnpp" | \ + xargs ctags -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26446 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2c68c12471d872f449e29082a98df14b47bbda4 Gerrit-Change-Number: 26446 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 00:06:21 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Mon, 6 Dec 2021 00:06:21 +0000 Subject: Change in osmo-remsim[master]: client: request card-remove and sim-local when no bankd/slot is set In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/25410 ) Change subject: client: request card-remove and sim-local when no bankd/slot is set ...................................................................... Patch Set 2: Code-Review+2 ``` Tue Nov 30 20:03:27 2021 daemon.info remsim: Cause: event-server-connect - Modem: 1 Tue Nov 30 20:03:27 2021 daemon.info remsim: Cause: event-config-bankd - Modem: 1 Tue Nov 30 20:03:28 2021 daemon.info remsim: Cause: request-sim-remote - Modem: 1 Tue Nov 30 20:03:28 2021 daemon.info remsim: Cause: request-card-insert - Modem: 1 Tue Nov 30 20:03:28 2021 daemon.info remsim: Cause: event-bankd-connect - Modem: 1 Tue Nov 30 20:03:28 2021 daemon.info remsim: Cause: request-modem-reset - Modem: 1 Tue Nov 30 20:03:28 2021 daemon.info remsim: Cause: event-modem-status - Modem: 1 Tue Nov 30 20:03:38 2021 daemon.info remsim: Cause: event-modem-status - Modem: 1 Tue Nov 30 20:04:35 2021 daemon.info remsim: Cause: request-card-remove - Modem: 1 Tue Nov 30 20:04:35 2021 daemon.info remsim: Cause: request-sim-local - Modem: 1 Tue Nov 30 20:04:35 2021 daemon.info remsim: Cause: request-modem-reset - Modem: 1 Tue Nov 30 20:06:58 2021 daemon.info remsim: Cause: request-card-insert - Modem: 1 Tue Nov 30 20:06:58 2021 daemon.info remsim: Cause: request-sim-remote - Modem: 1 Tue Nov 30 20:06:58 2021 daemon.info remsim: Cause: event-bankd-connect - Modem: 1 Tue Nov 30 20:06:58 2021 daemon.info remsim: Cause: request-modem-reset - Modem: 1 Tue Nov 30 20:07:09 2021 daemon.info remsim: Cause: event-modem-status - Modem: 1 ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/25410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ifaa4b60474bf8585bfbe0288062f581821bd3faa Gerrit-Change-Number: 25410 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Assignee: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: daniel Gerrit-Comment-Date: Mon, 06 Dec 2021 00:06:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 09:20:45 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 6 Dec 2021 09:20:45 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: fix redundant titan image build In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26442 ) Change subject: jenkins-common.sh: fix redundant titan image build ...................................................................... jenkins-common.sh: fix redundant titan image build Do not build debian-stretch-titan, when registry.osmocom.org is enabled. The image that would be built at this point is not useful, since other images like ttcn3-msc-test will use the debian-stretch-titan image from the registry instead of the one that was just built locally. Related: OS#5336 Change-Id: I7127e3ebac3a6a985c3ba50ba8c7cb8c5de978d9 --- M jenkins-common.sh 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: osmith: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jenkins-common.sh b/jenkins-common.sh index d4258d2..88d053c 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -120,6 +120,16 @@ local dir for i in $@; do + # Don't build images that are available on the private + # registry, if using it. + if [ "$REGISTRY_HOST" = "registry.osmocom.org" ]; then + case "$i" in + debian-stretch-titan) + continue + ;; + esac + fi + # Build dependencies first depends="$(docker_depends "$i")" if [ -n "$depends" ]; then -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7127e3ebac3a6a985c3ba50ba8c7cb8c5de978d9 Gerrit-Change-Number: 26442 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 09:20:46 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 6 Dec 2021 09:20:46 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: pull registry.osmocom.org imgs In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26443 ) Change subject: jenkins-common.sh: pull registry.osmocom.org imgs ...................................................................... jenkins-common.sh: pull registry.osmocom.org imgs Pull debian-stretch-titan from registry.osmocom.org if the repository is enabled. Otherwise the image gets only pulled the first time, and does not get updated once it becomes outdated. Fixes: OS#5336 Change-Id: I1cf998c21e4ee1f723c3b783703e339328377f3e --- M jenkins-common.sh 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: osmith: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jenkins-common.sh b/jenkins-common.sh index 88d053c..3511c02 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -121,10 +121,12 @@ for i in $@; do # Don't build images that are available on the private - # registry, if using it. + # registry, if using it. Instead, pull the images to make sure + # they are up-to-date. if [ "$REGISTRY_HOST" = "registry.osmocom.org" ]; then case "$i" in debian-stretch-titan) + docker pull "$REGISTRY_HOST/$USER/$i" continue ;; esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26443 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1cf998c21e4ee1f723c3b783703e339328377f3e Gerrit-Change-Number: 26443 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 12:51:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 6 Dec 2021 12:51:52 +0000 Subject: Change in osmo-remsim[master]: client: request card-remove and sim-local when no bankd/slot is set In-Reply-To: References: Message-ID: laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/25410 ) Change subject: client: request card-remove and sim-local when no bankd/slot is set ...................................................................... Removed Code-Review-1 by laforge -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/25410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ifaa4b60474bf8585bfbe0288062f581821bd3faa Gerrit-Change-Number: 25410 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Assignee: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: daniel Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 12:52:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 6 Dec 2021 12:52:14 +0000 Subject: Change in osmo-remsim[master]: client: request card-remove and sim-local when no bankd/slot is set In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/25410 ) Change subject: client: request card-remove and sim-local when no bankd/slot is set ...................................................................... client: request card-remove and sim-local when no bankd/slot is set When the client leaves the OPERATIONAL state, do the inverse of what happens when entering that state: * request "card insert" no longer to be generated towards modem * request switch back to local SIM * reset the modem to notice the change This way entering remote-sim operation due to adding a slotmap and leaving remote-sim due to removing the slotmap should be symmetrical. Change-Id: Ifaa4b60474bf8585bfbe0288062f581821bd3faa Closes: OS#5216 --- M src/client/client.h M src/client/main_fsm.c M src/client/user_ifdhandler.c M src/client/user_shell.c M src/client/user_simtrace2.c 5 files changed, 52 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/src/client/client.h b/src/client/client.h index 0024f52..9cfdc5d 100644 --- a/src/client/client.h +++ b/src/client/client.h @@ -43,7 +43,9 @@ /* API from generic core to frontend (modem/cardem) */ int frontend_request_card_insert(struct bankd_client *bc); +int frontend_request_card_remove(struct bankd_client *bc); int frontend_request_sim_remote(struct bankd_client *bc); +int frontend_request_sim_local(struct bankd_client *bc); int frontend_request_modem_reset(struct bankd_client *bc); int frontend_handle_card2modem(struct bankd_client *bc, const uint8_t *data, size_t len); int frontend_handle_set_atr(struct bankd_client *bc, const uint8_t *data, size_t len); diff --git a/src/client/main_fsm.c b/src/client/main_fsm.c index 673b19e..96b4b90 100644 --- a/src/client/main_fsm.c +++ b/src/client/main_fsm.c @@ -208,6 +208,23 @@ call_script(bc, "request-modem-reset"); } +static void main_st_operational_onleave(struct osmo_fsm_inst *fi, uint32_t next_state) +{ + struct bankd_client *bc = (struct bankd_client *) fi->priv; + + /* Simulate a card-remval to modem */ + frontend_request_card_remove(bc); + call_script(bc, "request-card-remove"); + + /* Select local SIM */ + frontend_request_sim_local(bc); + call_script(bc, "request-sim-local"); + + /* Reset the modem */ + frontend_request_modem_reset(bc); + call_script(bc, "request-modem-reset"); +} + static void main_st_operational(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct bankd_client *bc = (struct bankd_client *) fi->priv; @@ -353,6 +370,7 @@ .out_state_mask = S(MF_ST_INIT) | S(MF_ST_UNCONFIGURED) | S(MF_ST_WAIT_BANKD), .action = main_st_operational, .onenter = main_st_operational_onenter, + .onleave = main_st_operational_onleave, }, }; diff --git a/src/client/user_ifdhandler.c b/src/client/user_ifdhandler.c index a690503..a416e6e 100644 --- a/src/client/user_ifdhandler.c +++ b/src/client/user_ifdhandler.c @@ -156,11 +156,21 @@ return 0; } +int frontend_request_card_remove(struct bankd_client *bc) +{ + return 0; +} + int frontend_request_sim_remote(struct bankd_client *bc) { return 0; } +int frontend_request_sim_local(struct bankd_client *bc) +{ + return 0; +} + int frontend_request_modem_reset(struct bankd_client *bc) { return 0; diff --git a/src/client/user_shell.c b/src/client/user_shell.c index b22ee9a..5d37e97 100644 --- a/src/client/user_shell.c +++ b/src/client/user_shell.c @@ -20,11 +20,21 @@ return 0; } +int frontend_request_card_remove(struct bankd_client *bc) +{ + return 0; +} + int frontend_request_sim_remote(struct bankd_client *bc) { return 0; } +int frontend_request_sim_local(struct bankd_client *bc) +{ + return 0; +} + int frontend_request_modem_reset(struct bankd_client *bc) { return 0; diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c index fa6c319..8d8a6c9 100644 --- a/src/client/user_simtrace2.c +++ b/src/client/user_simtrace2.c @@ -322,12 +322,24 @@ return osmo_st2_cardem_request_card_insert(ci, true); } +int frontend_request_card_remove(struct bankd_client *bc) +{ + struct osmo_st2_cardem_inst *ci = bc->cardem; + return osmo_st2_cardem_request_card_insert(ci, false); +} + int frontend_request_sim_remote(struct bankd_client *bc) { struct osmo_st2_cardem_inst *ci = bc->cardem; return osmo_st2_modem_sim_select_remote(ci->slot); } +int frontend_request_sim_local(struct bankd_client *bc) +{ + struct osmo_st2_cardem_inst *ci = bc->cardem; + return osmo_st2_modem_sim_select_local(ci->slot); +} + int frontend_request_modem_reset(struct bankd_client *bc) { struct osmo_st2_cardem_inst *ci = bc->cardem; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/25410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ifaa4b60474bf8585bfbe0288062f581821bd3faa Gerrit-Change-Number: 25410 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Assignee: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: daniel Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 15:00:53 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 6 Dec 2021 15:00:53 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/BSC_ConnectionHandler: fix early return in f_mm_ciph_geran() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26451 ) Change subject: msc/BSC_ConnectionHandler: fix early return in f_mm_ciph_geran() ...................................................................... msc/BSC_ConnectionHandler: fix early return in f_mm_ciph_geran() In [1] I forgot to invert an if statement. This regression caused most of GERAN specific test cases to fail due to "Tguard timeout". Change-Id: I8cbaff00abfd9eb252dc3011df848e2e24fe5a1e Fixes: [1] Ib7ebe8fd675295beb02cadebb19d8465dffeb732 Related: OS#5333 --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/51/26451/1 diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 873ec5b..7b3188a 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -619,7 +619,7 @@ var OCT1 a5_perm_alg; var PDU_BSSAP pdu; - if (g_pars.net.expect_ciph) { + if (not g_pars.net.expect_ciph) { /* There is nothing to do */ return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26451 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8cbaff00abfd9eb252dc3011df848e2e24fe5a1e Gerrit-Change-Number: 26451 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 15:34:40 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 6 Dec 2021 15:34:40 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Test BVC bringup with conflicting BVCs References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26452 ) Change subject: gbproxy: Test BVC bringup with conflicting BVCs ...................................................................... gbproxy: Test BVC bringup with conflicting BVCs Different pcus try to establish the same BVC. Ensure that all the other BVCs still remain functional. Change-Id: I46eb0205b4c86b5f1bdc241ef0b2e12135c028e4 --- M gbproxy/GBProxy_Tests.ttcn 1 file changed, 115 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/26452/1 diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn index 5f5d835..ddf98a9 100644 --- a/gbproxy/GBProxy_Tests.ttcn +++ b/gbproxy/GBProxy_Tests.ttcn @@ -1069,6 +1069,117 @@ f_cleanup(); } +testcase TC_BVC_bringup_conflicting() runs on test_CT { + var float t_guard := 15.0; + var BssgpStatusIndication bsi; + var integer i; + + + g_Tguard.start(t_guard); + activate(as_gTguard(g_Tguard)); + + f_ipa_ctrl_start_client(mp_gbproxy_ip, mp_gbproxy_ctrl_port); + + var BssgpBvcConfigs bvcs := { }; + for (i := 0; i < lengthof(mp_gbconfigs); i := i+1) { + g_pcu[i].cfg := mp_gbconfigs[i]; + g_pcu[i].cfg.bvc[0].bvci := 23; + /* make sure all have a proper create_cb, which cannot be specified in config file */ + f_fix_create_cb(g_pcu[i].cfg); + /* concatenate all the PCU-side BVCs for the SGSN side */ + bvcs := bvcs & g_pcu[i].cfg.bvc; + } + + for (i := 0; i < lengthof(mp_nsconfig_sgsn); i := i+1) { + g_sgsn[i].cfg := { + nsei := mp_nsconfig_sgsn[i].nsei, + sgsn_role := true, + bvc := bvcs + } + } + + f_init_vty(); + for (i := 0; i < lengthof(mp_nsconfig_sgsn); i := i+1) { + f_vty_transceive(GBPVTY, "nsvc nsei " & int2str(g_sgsn[i].cfg.nsei) & " force-unconfigured"); + } + for (i := 0; i < lengthof(mp_nsconfig_pcu); i := i+1) { + f_vty_transceive(GBPVTY, "nsvc nsei " & int2str(g_pcu[i].cfg.nsei) & " force-unconfigured"); + f_vty_transceive(GBPVTY, "delete-gbproxy-peer " & int2str(g_pcu[i].cfg.nsei) & " only-bvc"); + } + + for (i := 0; i < lengthof(mp_nsconfig_sgsn); i := i+1) { + f_init_gb_sgsn(g_sgsn[i], "GbProxy_Test", i); + } + f_sleep(4.0); + for (i := 0; i < lengthof(mp_nsconfig_pcu); i := i+1) { + f_init_gb_pcu(g_pcu[i], "GbProxy_Test", i); + } + + /* wait until all BVC are unblocked on both sides */ + timer T := 10.0; + T.start; + alt { + [] SGSN_MGMT.receive(BssgpStatusIndication:{*, ?, ?}) { + repeat; + } + [] SGSN_MGMT.receive(BssgpResetIndication:?) { + repeat; + } + [] SGSN_MGMT.receive { + f_shutdown(__FILE__, __LINE__, fail, "Received unexpected message on SGSN_MGMT"); + } + [] PCU_MGMT.receive(BssgpStatusIndication:{*, ?, BVC_S_UNBLOCKED}) -> value bsi { + repeat; + } + [] PCU_MGMT.receive(BssgpStatusIndication:{*, ?, ?}) { + repeat; + } + [] PCU_MGMT.receive(BssgpResetIndication:{0}) { + repeat; + } + [] PCU_MGMT.receive { + f_shutdown(__FILE__, __LINE__, fail, "Received unexpected message on PCU_MGMT"); + } + [] T.timeout { + } + } + + /* Wait to ensure the gbproxy processed the RESET_ACK messages from the SGSN. + * Otherwise the state might still be WAIT_RESET_ACK */ + f_sleep(0.2); + + /* Verify BVCs, but ignore conflicting BVCI 23 */ + /* verify SGSN-side BVC FSM in IUT are UNBLOCKED */ + for (i := 0; i < lengthof(mp_nsconfig_sgsn); i := i+1) { + f_bvc_fsm_ensure_state(mp_nsconfig_sgsn[i].nsei, 0, "UNBLOCKED"); + /* iterate over list and check all BVCI */ + for (var integer j := 0; j < lengthof(g_sgsn[i].cfg.bvc); j := j+1) { + var BssgpBvci bvci := g_sgsn[i].cfg.bvc[j].bvci; + if (bvci == 23) { + continue; + } + f_bvc_fsm_ensure_state(mp_nsconfig_sgsn[i].nsei, bvci, "UNBLOCKED"); + } + } + /* verify PCU-side BVC FSM in IUT are UNBLOCKED */ + for (i := 0; i < lengthof(mp_nsconfig_pcu); i := i+1) { + f_bvc_fsm_ensure_state(mp_nsconfig_pcu[i].nsei, 0, "UNBLOCKED"); + /* iterate over list and check all BVCI */ + for (var integer j := 0; j < lengthof(g_pcu[i].cfg.bvc); j := j+1) { + var BssgpBvci bvci := g_pcu[i].cfg.bvc[j].bvci; + if (bvci == 23) { + continue; + } + f_bvc_fsm_ensure_state(mp_nsconfig_pcu[i].nsei, bvci, "UNBLOCKED"); + } + } + + /* re-start guard timer after all BVCs are up, so it only counts the actual test case */ + g_Tguard.start(t_guard); + f_start_handlers(refers(f_TC_BVC_bringup), testcasename(), 51); + f_cleanup(); +} + friend function f_bssgp_suspend(integer ran_idx := 0) runs on BSSGP_ConnHdlr return OCT1 { var BssgpBvcConfig bvcc := g_pars.pcu[ran_idx].cfg.bvc[0]; timer T := 5.0; @@ -3592,6 +3703,10 @@ control { execute( TC_BVC_bringup() ); + /* Depends on osmo-gbproxy > 0.2.0 */ + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + execute( TC_BVC_bringup_conflicting() ); + } execute( TC_ul_unitdata() ); execute( TC_ul_unitdata_pool_failure() ); execute( TC_dl_unitdata() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I46eb0205b4c86b5f1bdc241ef0b2e12135c028e4 Gerrit-Change-Number: 26452 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 15:49:18 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 6 Dec 2021 15:49:18 +0000 Subject: Change in libosmocore[master]: select: add member for human readable name to osmo_fd References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26453 ) Change subject: select: add member for human readable name to osmo_fd ...................................................................... select: add member for human readable name to osmo_fd osmo_fd structs are quite ubiquitous in osmocom applications. It might be helpful to give them names to distinguish network connections and unix domain sockets on a lower level. Change-Id: I64b288174ae3dd22d50a701ce7cbf9e623246479 Related: SYS#5701 --- M include/osmocom/core/select.h 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/53/26453/1 diff --git a/include/osmocom/core/select.h b/include/osmocom/core/select.h index e9f19a5..980bc97 100644 --- a/include/osmocom/core/select.h +++ b/include/osmocom/core/select.h @@ -43,6 +43,8 @@ void *data; /*! private number, extending \a data */ unsigned int priv_nr; + /*! human-readable name of this fd (optional) */ + const char *name; }; void osmo_fd_setup(struct osmo_fd *ofd, int fd, unsigned int when, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I64b288174ae3dd22d50a701ce7cbf9e623246479 Gerrit-Change-Number: 26453 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 15:49:19 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 6 Dec 2021 15:49:19 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... select: gather statistics for TCP connections osmocom applications are deployed in a variety of different situations. Dependung on the medium that interconnects the network components unexpected behaviour may occur. To debug problems with the interconnection between network components it might help to monitor the health of the related TCP connections. This can be done on a lower level so that any TCP connection that is handled by an osmocom process can be monitored through stats items. Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Related: SYS#5701 --- M include/osmocom/core/select.h M src/Makefile.am M src/select.c A src/stats_tcp.c A src/stats_tcp.h 5 files changed, 192 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/26454/1 diff --git a/include/osmocom/core/select.h b/include/osmocom/core/select.h index 980bc97..57aee39 100644 --- a/include/osmocom/core/select.h +++ b/include/osmocom/core/select.h @@ -45,6 +45,9 @@ unsigned int priv_nr; /*! human-readable name of this fd (optional) */ const char *name; + /*! statistics associated with this fd + * (automatically managed by libosmocore) */ + struct osmo_stat_item_group *priv_stats; }; void osmo_fd_setup(struct osmo_fd *ofd, int fd, unsigned int when, diff --git a/src/Makefile.am b/src/Makefile.am index 4bda456..519029d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -22,6 +22,7 @@ conv.c application.c rbtree.c strrb.c \ loggingrb.c crc8gen.c crc16gen.c crc32gen.c crc64gen.c \ macaddr.c stat_item.c stats.c stats_statsd.c prim.c \ + stats_tcp.c \ conv_acc.c conv_acc_generic.c sercomm.c prbs.c \ isdnhdlc.c \ tdef.c \ @@ -65,6 +66,7 @@ conv_acc_neon_impl.h \ crcXXgen.c.tpl \ stat_item_internal.h \ + stats_tcp.h \ $(NULL) libosmocore_la_LDFLAGS = -version-info $(LIBVERSION) -no-undefined diff --git a/src/select.c b/src/select.c index f7eb5ea..6627c0b 100644 --- a/src/select.c +++ b/src/select.c @@ -38,6 +38,8 @@ #include #include #include +#include +#include "stats_tcp.h" #include "../config.h" @@ -168,6 +170,9 @@ g_poll.num_registered++; #endif /* FORCE_IO_SELECT */ + /* Ensure that priv_stats is set to NULL. */ + fd->priv_stats = NULL; + llist_add_tail(&fd->list, &osmo_fds); return 0; @@ -186,6 +191,12 @@ #ifndef FORCE_IO_SELECT g_poll.num_registered--; #endif /* FORCE_IO_SELECT */ + + /* If existant, free any statistical data */ + if (fd->priv_stats) { + osmo_stat_item_group_free(fd->priv_stats); + fd->priv_stats = NULL; + } } /*! Close a file descriptor, mark it as closed + unregister from select loop abstraction @@ -373,6 +384,10 @@ unsigned int n_poll; int rc; +#if !defined(EMBEDDED) + stats_tcp_poll(&osmo_fds); +#endif /* !EMBEDDED */ + /* prepare read and write fdsets */ n_poll = poll_fill_fds(); diff --git a/src/stats_tcp.c b/src/stats_tcp.c new file mode 100644 index 0000000..d35dcb2 --- /dev/null +++ b/src/stats_tcp.c @@ -0,0 +1,167 @@ +/* + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Philipp Maier + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + * + */ + +/*! \addtogroup stats + * @{ + * \file stats_tcp.c */ + +#include "config.h" +#if !defined(EMBEDDED) + +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include + +#include +#include +#include "stats_tcp.h" +#include + +enum { + STATS_TCP_UNACKED, + STATS_TCP_RETRANS, + STATS_TCP_RTT, + STATS_TCP_RCV_RTT, + STATS_TCP_NOTSENT_BYTES, + STATS_TCP_RWND_LIMITED, + STATS_TCP_REORD_SEEN, +}; + +struct stats_tcp_entry { + struct llist_head entry; + struct osmo_stat_item_group *stats_tcp; + int fd; +}; + +const struct osmo_stat_item_desc stats_tcp_item_desc[] = { + [STATS_TCP_UNACKED] = { "tcp:unacked", "unacknowledged packets", "", 60, 0 }, + [STATS_TCP_RETRANS] = { "tcp:retrans", "retransmitted packets", "", 60, 0 }, + [STATS_TCP_RTT] = { "tcp:rtt", "roundtrip-time", "", 60, 0 }, + [STATS_TCP_RCV_RTT] = { "tcp:rcv_rtt", "roundtrip-time (receive)", "", 60, 0 }, + [STATS_TCP_NOTSENT_BYTES] = { "tcp:notsent_bytes", "bytes not yet sent", "", 60, 0 }, + [STATS_TCP_RWND_LIMITED] = { "tcp:rwnd_limited", "time (usec) limited by receive window", "", 60, 0 }, + [STATS_TCP_REORD_SEEN] = { "tcp:sndbuf_limited", "reordering events seen", "", 60, 0 }, +}; + +const struct osmo_stat_item_group_desc stats_tcp_desc = { + .group_name_prefix = "tcp", + .group_description = "stats tcp", + .class_id = OSMO_STATS_CLASS_GLOBAL, + .num_items = ARRAY_SIZE(stats_tcp_item_desc), + .item_desc = stats_tcp_item_desc, +}; + +static void fill_stats(struct osmo_fd *ufd) +{ + int rc; + struct tcp_info tcp_info; + socklen_t tcp_info_len = sizeof(tcp_info); + + rc = getsockopt(ufd->fd, IPPROTO_TCP, TCP_INFO, &tcp_info, &tcp_info_len); + if (rc < 0) + return; + + osmo_stat_item_set(osmo_stat_item_group_get_item(ufd->priv_stats, STATS_TCP_UNACKED), tcp_info.tcpi_unacked); + osmo_stat_item_set(osmo_stat_item_group_get_item(ufd->priv_stats, STATS_TCP_RETRANS), tcp_info.tcpi_retrans); + osmo_stat_item_set(osmo_stat_item_group_get_item(ufd->priv_stats, STATS_TCP_RTT), tcp_info.tcpi_rtt); + osmo_stat_item_set(osmo_stat_item_group_get_item(ufd->priv_stats, STATS_TCP_RCV_RTT), + tcp_info.tcpi_notsent_bytes); + osmo_stat_item_set(osmo_stat_item_group_get_item(ufd->priv_stats, STATS_TCP_NOTSENT_BYTES), + tcp_info.tcpi_rwnd_limited); + osmo_stat_item_set(osmo_stat_item_group_get_item(ufd->priv_stats, STATS_TCP_RWND_LIMITED), + tcp_info.tcpi_sndbuf_limited); + osmo_stat_item_set(osmo_stat_item_group_get_item(ufd->priv_stats, STATS_TCP_REORD_SEEN), + tcp_info.tcpi_reord_seen); +} + +/* Check if the socket we dealing with is associated with a stream (TCP) */ +static bool is_stream(struct osmo_fd *ufd) +{ + int rc; + struct stat fd_stat; + int so_type = 0; + socklen_t so_type_len = sizeof(so_type); + + rc = fstat(ufd->fd, &fd_stat); + if (rc < 0) + return false; + + if (S_ISSOCK(fd_stat.st_mode)) { + rc = getsockopt(ufd->fd, SOL_SOCKET, SO_TYPE, &so_type, &so_type_len); + if (rc < 0) + return false; + + if (so_type == SOCK_STREAM) + return true; + } + + return false; +} + +/* Check if the socket is connected to a remote end. */ +static bool is_connected(struct osmo_fd *ufd) +{ + if (osmo_sock_get_ip_and_port(ufd->fd, NULL, 0, NULL, 0, false) != 0) + return false; + return true; +} + +void add_stats(struct osmo_fd *ufd) +{ + char stat_name[256]; + + ufd->priv_stats = osmo_stat_item_group_alloc(NULL, &stats_tcp_desc, ufd->fd); + OSMO_ASSERT(ufd->priv_stats); + + if (ufd->name) + snprintf(stat_name, sizeof(stat_name), "%s,%s", ufd->name, osmo_sock_get_name2(ufd->fd)); + else + snprintf(stat_name, sizeof(stat_name), "%s", osmo_sock_get_name2(ufd->fd)); + + osmo_stat_item_group_set_name(ufd->priv_stats, stat_name); + +} + +void stats_tcp_poll(struct llist_head *osmo_fds) +{ + struct osmo_fd *ufd; + + llist_for_each_entry(ufd, osmo_fds, list) { + if (ufd->priv_stats == NULL && is_stream(ufd) && is_connected(ufd)) + add_stats(ufd); + if (ufd->priv_stats) + fill_stats(ufd); + } +} + +#endif /* !EMBEDDED */ + +/* @} */ diff --git a/src/stats_tcp.h b/src/stats_tcp.h new file mode 100644 index 0000000..1c0b475 --- /dev/null +++ b/src/stats_tcp.h @@ -0,0 +1,5 @@ +#pragma once + +struct llist_head; + +void stats_tcp_poll(struct llist_head *osmo_fds); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 15:50:24 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 6 Dec 2021 15:50:24 +0000 Subject: Change in libosmo-abis[master]: ipaccess.c: assign names to the related osmo_fds References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26455 ) Change subject: ipaccess.c: assign names to the related osmo_fds ...................................................................... ipaccess.c: assign names to the related osmo_fds The osmo_fds used form ipaccess based E1 traffic should have names Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e depends: libosmocore I64b288174ae3dd22d50a701ce7cbf9e623246479 Related: SYS#5701 --- M src/input/ipaccess.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/55/26455/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 04b4474..4eacb6e 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -341,6 +341,7 @@ "could not register FD\n"); goto err; } + newbfd->name = "ipa-rsl"; e1i_ts = ipaccess_line_ts(newbfd, new_line); ipaccess_bsc_keepalive_fsm_alloc(e1i_ts, newbfd, "rsl_bsc_to_bts"); @@ -671,6 +672,7 @@ LOGP(DLINP, LOGL_ERROR, "could not register FD\n"); goto err_line; } + bfd->name = "ipa-oml"; update_fd_settings(line, bfd->fd); @@ -724,6 +726,8 @@ LOGP(DLINP, LOGL_ERROR, "could not register FD\n"); goto err_line; } + bfd->name = "ipa-rsl"; + /* Request ID. FIXME: request LOCATION, HW/SW VErsion, Unit Name, Serno */ ret = ipa_ccm_send_id_req(bfd->fd); if (ret < 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 15:58:05 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 6 Dec 2021 15:58:05 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy_peer: Free all related BVCs if the cell is freed References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26456 ) Change subject: gbproxy_peer: Free all related BVCs if the cell is freed ...................................................................... gbproxy_peer: Free all related BVCs if the cell is freed Previously the SGSN BVCs would still be present after the related Cell was freed. This caused some inconsistencies if a BVC with the same BVCI was established again. The symptoms of this were cells that were attached to no SGSN or the same one multiple times and crashes. This patch ensures that the SGSN-side BVCs are also freed when the cell is freed and that this fact is reflected when handling reset notifications. Change-Id: Iedeede8917e2870e0b62a2050ccb331109167017 --- M src/gb_proxy.c M src/gb_proxy_peer.c 2 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/56/26456/1 diff --git a/src/gb_proxy.c b/src/gb_proxy.c index d6d760f..69a58d4 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -682,8 +682,10 @@ LOGPBVC(bvc->cell->bss_bvc, LOGL_NOTICE, "Destroying due to conflicting " "BVCI configuration (new NSEI=%05u)!\n", bvc->nse->nsei); gbproxy_bvc_free(bvc->cell->bss_bvc); + bvc->cell = NULL; + } else { + LOGPBVC(bvc, LOGL_ERROR, "Found cell without BSS BVC, this should not happen!"); } - bvc->cell->bss_bvc = bvc; } } diff --git a/src/gb_proxy_peer.c b/src/gb_proxy_peer.c index f59cf9e..0070155 100644 --- a/src/gb_proxy_peer.c +++ b/src/gb_proxy_peer.c @@ -217,8 +217,16 @@ { int i; - if (cell->bss_bvc == bvc) + if (cell->bss_bvc == bvc) { + /* Remove the whole cell including all BVCs */ + for (i = 0; i < ARRAY_SIZE(cell->sgsn_bvc); i++) { + if (cell->sgsn_bvc[i]) { + gbproxy_bvc_free(cell->sgsn_bvc[i]); + cell->sgsn_bvc[i] = NULL; + } + } return gbproxy_cell_free(cell); + } /* we could also be a SGSN-side BVC */ for (i = 0; i < ARRAY_SIZE(cell->sgsn_bvc); i++) { -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Iedeede8917e2870e0b62a2050ccb331109167017 Gerrit-Change-Number: 26456 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 16:39:54 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 6 Dec 2021 16:39:54 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/select.c at 173 PS1, Line 173: /* Ensure that priv_stats is set to NULL. */ I find this comment useless. https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.h File src/stats_tcp.h: https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.h at 5 PS1, Line 5: void stats_tcp_poll(struct llist_head *osmo_fds); A header file just for one function? Are you planning to add more stuff here? If not, let's rather declare it in select.c. https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.c File src/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.c at 64 PS1, Line 64: const struct osmo_stat_item_desc stats_tcp_item_desc[] = { static? https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.c at 74 PS1, Line 74: const struct osmo_stat_item_group_desc stats_tcp_desc = { static? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 06 Dec 2021 16:39:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 16:56:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 6 Dec 2021 16:56:07 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457 ) Change subject: BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc ...................................................................... BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc Change-Id: I9d7042ab4f3f7dea88811bd1b90d829065063f33 Related: SYS#5047, OS#4728 --- M bsc/BSC_Tests.ttcn 1 file changed, 38 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/26457/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 22df0cb..7036d94 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -2435,6 +2435,7 @@ private function f_exp_sapi_n_reject(template (present) GsmSapi sapi := ?, template myBSSMAP_Cause cause := ?, + template (present) BIT2 cc := ?, float T_val := 2.0) runs on test_CT { var BSSAP_N_DATA_ind rx_di; @@ -2451,6 +2452,15 @@ setverdict(fail, "Rx unexpected Cause IE: ", rx_cause, " vs expected ", tr_cause); } + + /* Who ever on the earth decided to define this field as two separate bits?!? */ + var BIT2 rx_cc := rx_di.userData.pdu.bssmap.sAPInReject.dLCI.c2 + & rx_di.userData.pdu.bssmap.sAPInReject.dLCI.c1; + if (not match(rx_cc, cc)) { + setverdict(fail, "Rx unexpected Control Channel type: ", + rx_cc, " vs expected ", cc); + } + setverdict(pass); } [] BSSAP.receive(BSSAP_N_DATA_ind:?) -> value rx_di { @@ -2544,6 +2554,33 @@ f_shutdown_helper(); } +/* Check DLCI CC (Control Channel type) bits in SAPI N Reject */ +testcase TC_rll_sapi_n_reject_dlci_cc() runs on test_CT { + var octetstring rnd_data := f_rnd_octstring(16); + var RSL_Message rx_rsl; + var DchanTuple dt; + + f_init(1); + + /* MS establishes a SAPI=0 link on DCCH */ + dt := f_est_dchan(f_rnd_ra_cs(), 23, rnd_data); + + /* MSC sends some data on (not yet established) SAPI=3 link */ + BSSAP.send(ts_BSSAP_DATA_req(dt.sccp_conn_id, ts_BSSAP_DTAP(rnd_data, '03'O))); + /* BSC attempts to establish a SAPI=3 link on DCCH */ + rx_rsl := f_exp_ipa_rx(0, tr_RSL_EST_REQ(dt.rsl_chan_nr, tr_RslLinkID_DCCH(3))); + + /* MS sends unexpected ERROR INDication on DCCH/ACCH SAPI=3 */ + f_ipa_tx(0, ts_RSL_ERROR_IND(dt.rsl_chan_nr, ts_RslLinkID_DCCH(3), ''O)); + f_exp_sapi_n_reject(3, GSM0808_CAUSE_MS_NOT_EQUIPPED, '10'B); + + /* Clean up the connection */ + BSSAP.send(ts_BSSAP_DISC_req(dt.sccp_conn_id, 0)); + f_expect_chan_rel(0, dt.rsl_chan_nr, expect_rll_rel_req := false); + + f_shutdown_helper(); +} + testcase TC_si_default() runs on test_CT { f_init(0); f_init_bts_and_check_sysinfo(0, expect_si := SystemInformationConfig_default); @@ -10938,6 +10975,7 @@ execute( TC_rll_rel_ind_sapi_n_reject() ); execute( TC_rll_err_ind_sapi_n_reject() ); execute( TC_rll_timeout_sapi_n_reject() ); + execute( TC_rll_sapi_n_reject_dlci_cc() ); /* Paging related tests */ execute( TC_paging_imsi_nochan() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9d7042ab4f3f7dea88811bd1b90d829065063f33 Gerrit-Change-Number: 26457 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 16:57:12 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 6 Dec 2021 16:57:12 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457 ) Change subject: BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9d7042ab4f3f7dea88811bd1b90d829065063f33 Gerrit-Change-Number: 26457 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 06 Dec 2021 16:57:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 17:03:10 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 6 Dec 2021 17:03:10 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/BSC_ConnectionHandler: fix early return in f_mm_ciph_geran() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26451 ) Change subject: msc/BSC_ConnectionHandler: fix early return in f_mm_ciph_geran() ...................................................................... Patch Set 1: Verified+1 Code-Review+2 Urgent fix, merging myself. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26451 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8cbaff00abfd9eb252dc3011df848e2e24fe5a1e Gerrit-Change-Number: 26451 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 06 Dec 2021 17:03:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 17:03:20 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 6 Dec 2021 17:03:20 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/BSC_ConnectionHandler: fix early return in f_mm_ciph_geran() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26451 ) Change subject: msc/BSC_ConnectionHandler: fix early return in f_mm_ciph_geran() ...................................................................... msc/BSC_ConnectionHandler: fix early return in f_mm_ciph_geran() In [1] I forgot to invert an if statement. This regression caused most of GERAN specific test cases to fail due to "Tguard timeout". Change-Id: I8cbaff00abfd9eb252dc3011df848e2e24fe5a1e Fixes: [1] Ib7ebe8fd675295beb02cadebb19d8465dffeb732 Related: OS#5333 --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved; Verified diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 873ec5b..7b3188a 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -619,7 +619,7 @@ var OCT1 a5_perm_alg; var PDU_BSSAP pdu; - if (g_pars.net.expect_ciph) { + if (not g_pars.net.expect_ciph) { /* There is nothing to do */ return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26451 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8cbaff00abfd9eb252dc3011df848e2e24fe5a1e Gerrit-Change-Number: 26451 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 17:06:29 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 6 Dec 2021 17:06:29 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/IPA_Types: WIP codec for IPA UnitID (site/bts/trx) References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26458 ) Change subject: library/IPA_Types: WIP codec for IPA UnitID (site/bts/trx) ...................................................................... library/IPA_Types: WIP codec for IPA UnitID (site/bts/trx) Change-Id: I68eb0d9e28bbf5d2d8ffe916aae5a66a0fdb9bd0 --- M library/IPA_Types.ttcn 1 file changed, 40 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/26458/1 diff --git a/library/IPA_Types.ttcn b/library/IPA_Types.ttcn index 95623ef..6bb7d07 100644 --- a/library/IPA_Types.ttcn +++ b/library/IPA_Types.ttcn @@ -132,6 +132,46 @@ extension "decode(RAW)" } +/* Example: 1234/0/1 (site 1234, BTS#0, TRX#0) */ +type record IpaUnitId { + integer site_id, + integer bts_id, + integer trx_id +} with { + encode "TEXT" + variant "SEPARATOR('/', '/')" +}; + +external function enc_IpaUnitId(in IpaUnitId unit_id) return charstring + with { extension "prototype(convert) encode(TEXT)" } +external function dec_IpaUnitId(in charstring stream) return IpaUnitId + with { extension "prototype(convert) decode(TEXT)" } + +template (value) IpaUnitId ts_IpaUnitId(integer site_id := 1234, + integer bts_id := 0, + integer trx_id := 0) := { + site_id := site_id, + bts_id := bts_id, + trx_id := trx_id +}; +template IpaUnitId tr_IpaUnitId(template (present) integer site_id := ?, + template (present) integer bts_id := ?, + template (present) integer trx_id := ?) := { + site_id := site_id, + bts_id := bts_id, + trx_id := trx_id +}; + +private type component Dummy_CT { }; + +testcase TC_selftest_IpaUnitId() runs on Dummy_CT { + var IpaUnitId unit_id := valueof(ts_IpaUnitId(1234, 0, 3)); + var charstring unit_id_enc := enc_IpaUnitId(unit_id); + + log("Enc: ", unit_id_enc); + log("Dec: ", dec_IpaUnitId(unit_id_enc & "\00")); +} + /* Finds an IE with the given tag in IPA IDENTITY RESPONSE. * Returns index of an IE if found, -1 otherwise. */ function f_ipa_id_resp_find_ie(in IpaCcmIdResp resp, IpaCcmIdTag tag) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26458 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68eb0d9e28bbf5d2d8ffe916aae5a66a0fdb9bd0 Gerrit-Change-Number: 26458 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 17:45:42 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 6 Dec 2021 17:45:42 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: tune logging configuration In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26449 ) Change subject: bsc/osmo-{bsc,stp}.cfg: tune logging configuration ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26449 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I955c0b8dbf74761d525c6bfb195eed418af24ab6 Gerrit-Change-Number: 26449 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 06 Dec 2021 17:45:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 17:46:07 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 6 Dec 2021 17:46:07 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26450 ) Change subject: bsc/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If53c49157ec861163f3d993972414674ab18119f Gerrit-Change-Number: 26450 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 06 Dec 2021 17:46:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 17:48:58 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 6 Dec 2021 17:48:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457 ) Change subject: BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9d7042ab4f3f7dea88811bd1b90d829065063f33 Gerrit-Change-Number: 26457 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 06 Dec 2021 17:48:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 17:55:12 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 6 Dec 2021 17:55:12 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26450 ) Change subject: bsc/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If53c49157ec861163f3d993972414674ab18119f Gerrit-Change-Number: 26450 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 06 Dec 2021 17:55:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 17:55:16 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 6 Dec 2021 17:55:16 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: tune logging configuration In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26449 ) Change subject: bsc/osmo-{bsc,stp}.cfg: tune logging configuration ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26449 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I955c0b8dbf74761d525c6bfb195eed418af24ab6 Gerrit-Change-Number: 26449 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 06 Dec 2021 17:55:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 17:55:25 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 6 Dec 2021 17:55:25 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: tune logging configuration In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26449 ) Change subject: bsc/osmo-{bsc,stp}.cfg: tune logging configuration ...................................................................... bsc/osmo-{bsc,stp}.cfg: tune logging configuration Change-Id: I955c0b8dbf74761d525c6bfb195eed418af24ab6 --- M bsc/osmo-bsc.cfg M bsc/osmo-stp.cfg 2 files changed, 12 insertions(+), 35 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/osmo-bsc.cfg b/bsc/osmo-bsc.cfg index b64a63d..b318e7c 100644 --- a/bsc/osmo-bsc.cfg +++ b/bsc/osmo-bsc.cfg @@ -5,10 +5,14 @@ ! log stderr logging filter all 1 - logging color 1 + logging print file basename last + logging print category-hex 0 logging print category 1 + logging print level 1 logging timestamp 1 - logging print extended-timestamp 1 + logging color 1 +! + logging level set-all notice logging level rll notice logging level mm notice logging level rr notice @@ -22,24 +26,6 @@ logging level ctrl notice logging level filter debug logging level pcu debug - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl notice - logging level lgtp notice - logging level lstats notice - logging level lgsup notice - logging level loap notice - logging level lss7 notice - logging level lsccp notice - logging level lsua notice - logging level lm3ua notice - logging level lmgcp notice - logging level reset notice ! stats interval 0 stats reporter statsd diff --git a/bsc/osmo-stp.cfg b/bsc/osmo-stp.cfg index 7ea46a4..b0b4f05 100644 --- a/bsc/osmo-stp.cfg +++ b/bsc/osmo-stp.cfg @@ -4,27 +4,18 @@ ! log stderr logging filter all 1 - logging color 1 + logging print file basename last + logging print category-hex 0 logging print category 1 + logging print level 1 logging timestamp 1 - logging print extended-timestamp 1 - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl notice - logging level lgtp notice - logging level lstats notice - logging level lgsup notice - logging level loap notice + logging color 1 +! + logging level set-all notice logging level lss7 debug logging level lsccp debug logging level lsua debug logging level lm3ua debug - logging level lmgcp notice ! line vty no login -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26449 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I955c0b8dbf74761d525c6bfb195eed418af24ab6 Gerrit-Change-Number: 26449 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 17:55:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 6 Dec 2021 17:55:26 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26450 ) Change subject: bsc/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' ...................................................................... bsc/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' Change-Id: If53c49157ec861163f3d993972414674ab18119f --- M bsc/osmo-bsc.cfg 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/osmo-bsc.cfg b/bsc/osmo-bsc.cfg index b318e7c..0ed4916 100644 --- a/bsc/osmo-bsc.cfg +++ b/bsc/osmo-bsc.cfg @@ -68,7 +68,7 @@ timer t3113 10 timer t3212 30 bts 0 - type sysmobts + type osmo-bts band DCS1800 cell_identity 0 location_area_code 1 @@ -158,7 +158,7 @@ phys_chan_config PDCH hopping enabled 0 bts 1 - type sysmobts + type osmo-bts band DCS1800 cell_identity 1 location_area_code 1 @@ -248,7 +248,7 @@ phys_chan_config PDCH hopping enabled 0 bts 2 - type sysmobts + type osmo-bts band DCS1800 cell_identity 1 location_area_code 2 @@ -338,7 +338,7 @@ phys_chan_config PDCH hopping enabled 0 bts 3 - type sysmobts + type osmo-bts band DCS1800 cell_identity 3 location_area_code 3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If53c49157ec861163f3d993972414674ab18119f Gerrit-Change-Number: 26450 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 18:03:46 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 6 Dec 2021 18:03:46 +0000 Subject: Change in osmo-bsc[master]: bts-examples: add example for E1 connected BTS In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26367 to look at the new patch set (#3). Change subject: bts-examples: add example for E1 connected BTS ...................................................................... bts-examples: add example for E1 connected BTS The manual lacks an example on how to set up an E1 connected BTS. Especially the relation between trunk number and E1 line number is not obvious. Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Related: OS#5308 --- M doc/manuals/chapters/bts-examples.adoc 1 file changed, 117 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/67/26367/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Gerrit-Change-Number: 26367 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 18:06:29 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 6 Dec 2021 18:06:29 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 to look at the new patch set (#7). Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... abis_nm: actively block BTSs with invalid configuration At the moment the BTS configuration is checked, but the check does not have much consequence other than that some initialization that is not executed. The BTS will go into the OML bootstrap phase anyway and most likely fail at some later point due to the invalid configuration. To reduce noise and unexpected behaviour of the BTS lets make sure that the OML boostrap phase can only proceed when the BSC conciders the configuration as valid. Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Related: SYS#5369 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts.c M src/osmo-bsc/osmo_bsc_main.c 5 files changed, 84 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/26197/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 18:23:33 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 6 Dec 2021 18:23:33 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 7: I have changed the code so that it does the check when ipaccess_sign_link_up() is called in bts_ipaccess_nanobts.c This works find now. So for ipaccess based BTSs everything looks good now. Unfortunately E1 BTSs still have a problem. There is no way to "drop" an E1 connection. We might consider to remove the related check code from abis_nm.c since E1 is more or less a corner case. Also we still have a check that runs on BSC startup. And last but not least the BTS shouldn't accept an invalid config anyway and respond with an OML error. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 06 Dec 2021 18:23:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 6 18:26:36 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 6 Dec 2021 18:26:36 +0000 Subject: Change in osmo-bsc[master]: bts-examples: add example for E1 connected BTS In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26367 ) Change subject: bts-examples: add example for E1 connected BTS ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26367/1/doc/manuals/chapters/bts-examples.adoc File doc/manuals/chapters/bts-examples.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/26367/1/doc/manuals/chapters/bts-examples.adoc at 192 PS1, Line 192: handover window rxlev averaging 10 > I don't think we want tons of non-related config here. [?] I have shortened the config a bit. Also I have added some explanation on what the E1 related settings mean. It should now be more helpful to the user. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Gerrit-Change-Number: 26367 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 06 Dec 2021 18:26:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:36:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:36:35 +0000 Subject: Change in osmo-bsc[master]: bts-examples: add example for E1 connected BTS In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26367 ) Change subject: bts-examples: add example for E1 connected BTS ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Gerrit-Change-Number: 26367 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 07 Dec 2021 07:36:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:38:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:38:15 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 7: Code-Review+1 > Unfortunately E1 BTSs still have a problem. There is no way to "drop" an E1 connection. I'm nor sure why not? In IPA/TCP, there is a TCP socket that can be closed for each of RSL and OML. In E1, this corresponds to the LAPD data-links for OML and RSL, respectively. So closing the LAPD data link should resemble exactly what closing the TCP socket is in IPA? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 07 Dec 2021 07:38:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:38:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:38:28 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: f_create_chan_and_exp(): ensure that SCCP connection is up In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26448 ) Change subject: bsc: f_create_chan_and_exp(): ensure that SCCP connection is up ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic675168e29919e1234cb49440c4a630238ff5d70 Gerrit-Change-Number: 26448 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 07 Dec 2021 07:38:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:38:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:38:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/BSSMAP_Templates: parametrize codec list for tr_BSSMAP_ComplL3 In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26447 ) Change subject: library/BSSMAP_Templates: parametrize codec list for tr_BSSMAP_ComplL3 ...................................................................... library/BSSMAP_Templates: parametrize codec list for tr_BSSMAP_ComplL3 Change-Id: I4abd77ebe47791adf2708e1c31614383d18e54b8 --- M library/BSSMAP_Templates.ttcn 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn index 67537fb..d497d25 100644 --- a/library/BSSMAP_Templates.ttcn +++ b/library/BSSMAP_Templates.ttcn @@ -388,7 +388,8 @@ } template PDU_BSSAP tr_BSSMAP_ComplL3(template octetstring l3_info := ?, - template BSSMAP_IE_CellIdentifier cell_id := ?) + template BSSMAP_IE_CellIdentifier cell_id := ?, + template BSSMAP_IE_SpeechCodecList codec_list := *) modifies tr_BSSAP_BSSMAP := { pdu := { bssmap := { @@ -399,7 +400,7 @@ chosenChannel := *, lSAIdentifier := *, aPDU := *, - codecList := *, + codecList := codec_list, redirectAttemptFlag := *, sendSequenceNumber := *, iMSI := * -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4abd77ebe47791adf2708e1c31614383d18e54b8 Gerrit-Change-Number: 26447 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:38:34 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:38:34 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: f_create_chan_and_exp(): ensure that SCCP connection is up In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26448 ) Change subject: bsc: f_create_chan_and_exp(): ensure that SCCP connection is up ...................................................................... bsc: f_create_chan_and_exp(): ensure that SCCP connection is up This change fixes sporadic failures of TC_cm_serv_rej: RAN Connection table not found by component TC_cm_serv_rej(2648) BSC_Tests.ttcn:11106 BSC_Tests control part BSC_Tests.ttcn:10550 TC_cm_serv_rej testcase The reason is that sometimes a BSSAP/DTAP PDU (with CM Service Reject) gets enqueued before the SUT has established an SCCP connection to the virtual MSC. This causes a lookup error in the RAN connection table. A simple solution would be to add a receive statement after calling f_create_chan_and_exp(), like it's done everywhere else: f_create_chan_and_exp(); BSSAP.receive(tr_BSSMAP_ComplL3); // <--- But a more general solution is to expect and receive this message in f_create_chan_and_exp(), so we can reduce code duplication and make the API more convinient. This is exactly what this change does. Change-Id: Ic675168e29919e1234cb49440c4a630238ff5d70 Related: SYS#4878 --- M bsc/BSC_Tests.ttcn M bsc/MSC_ConnectionHandler.ttcn 2 files changed, 25 insertions(+), 61 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 22df0cb..3aaab85 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3880,7 +3880,6 @@ /* this is like the beginning of f_establish_fully(), but only up to ciphering reject */ var BSSMAP_FIELD_CodecType codecType; - timer T := 10.0; codecType := exp_ass_req.pdu.bssmap.assignmentRequest.codecList.codecElements[0].codecType; f_MscConnHdlr_init(g_pars.media_nr, host_bts, host_mgw_mgcp, codecType); @@ -3888,24 +3887,6 @@ f_create_chan_and_exp(); /* we should now have a COMPL_L3 at the MSC */ - var template PDU_BSSAP exp_l3_compl; - exp_l3_compl := tr_BSSMAP_ComplL3() - if (g_pars.aoip == false) { - exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := omit; - } else { - exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := ?; - } - T.start; - alt { - [] BSSAP.receive(exp_l3_compl); - [] BSSAP.receive(tr_BSSMAP_ComplL3) { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Received non-matching COMPLETE LAYER 3 INFORMATION"); - } - [] T.timeout { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for COMPLETE LAYER 3 INFORMATION"); - } - } - /* Start ciphering, expect Cipher Mode Reject */ f_cipher_mode(g_pars.encr, exp_fail := true); } @@ -5055,7 +5036,6 @@ f_create_chan_and_exp(); /* we should now have a COMPL_L3 at the MSC */ - BSSAP.receive(tr_BSSMAP_ComplL3); BSSAP.send(ts_BSSMAP_ClassmarkRequest); RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, decmatch tr_RRM_CM_ENQUIRY)); @@ -5081,7 +5061,6 @@ f_create_chan_and_exp(); /* we should now have a COMPL_L3 at the MSC */ - BSSAP.receive(tr_BSSMAP_ComplL3); /* Send CommonID */ BSSAP.send(ts_BSSMAP_CommonId(g_pars.imsi)); @@ -5105,7 +5084,6 @@ g_pars := f_gen_test_hdlr_pars(); f_create_chan_and_exp(); /* we should now have a COMPL_L3 at the MSC */ - BSSAP.receive(tr_BSSMAP_ComplL3); /* send the single message we want to send */ f_rsl_send_l3(l3); @@ -5176,7 +5154,6 @@ g_pars := f_gen_test_hdlr_pars(); f_create_chan_and_exp(); /* we should now have a COMPL_L3 at the MSC */ - BSSAP.receive(tr_BSSMAP_ComplL3); /* send short message */ RSL.send(ts_RSL_DATA_IND(g_chan_nr, valueof(ts_RslLinkID_DCCH(0)), ''O)); @@ -10534,6 +10511,7 @@ private function f_TC_cm_serv_rej(charstring id) runs on MSC_ConnHdlr { f_create_chan_and_exp(); + /* we should now have a COMPL_L3 at the MSC */ BSSAP.send(ts_PDU_DTAP_MT(ts_CM_SERV_REJ('02'O), '00'O)); f_sleep(1.0); } @@ -10575,24 +10553,6 @@ f_rslem_dchan_queue_enable(); /* we should now have a COMPL_L3 at the MSC */ - var template PDU_BSSAP exp_l3_compl; - exp_l3_compl := tr_BSSMAP_ComplL3() - if (g_pars.aoip == false) { - exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := omit; - } else { - exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := ?; - } - timer T := 10.0; - T.start; - alt { - [] BSSAP.receive(exp_l3_compl); - [] BSSAP.receive(tr_BSSMAP_ComplL3) { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Received non-matching COMPLETE LAYER 3 INFORMATION"); - } - [] T.timeout { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for COMPLETE LAYER 3 INFORMATION"); - } - } f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); activate(as_Media_mgw()); diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index 481abc0..4aeb539 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -644,19 +644,42 @@ expect_tsc := omit } -function f_create_chan_and_exp() runs on MSC_ConnHdlr { +function f_create_chan_and_exp(template (present) PDU_BSSAP exp_l3_compl := ?) +runs on MSC_ConnHdlr { var MobileIdentityLV mi := valueof(ts_MI_IMSI_LV(g_pars.imsi)); var PDU_ML3_MS_NW l3_info := valueof(ts_CM_SERV_REQ(CM_TYPE_MO_CALL, mi)); var octetstring l3_enc := enc_PDU_ML3_MS_NW(l3_info); var template uint3_t tsc := ?; + timer T; if (not istemplatekind(g_pars.expect_tsc, "omit")) { tsc := g_pars.expect_tsc; } + if (istemplatekind(exp_l3_compl, "?")) { + if (g_pars.aoip == false) { + exp_l3_compl := tr_BSSMAP_ComplL3(l3_enc, codec_list := omit); + } else { + exp_l3_compl := tr_BSSMAP_ComplL3(l3_enc, codec_list := ?); + } + } + f_create_bssmap_exp(l3_enc); /* call helper function for CHAN_RQD -> IMM ASS ->EST_IND */ RSL_Emulation.f_chan_est(g_pars.ra, l3_enc, g_pars.link_id, g_pars.fn, tsc); + /* wait for a COMPL_L3 from the BSC to ensure that the SCCP connection is up */ + T.start(2.0); + alt { + [] BSSAP.receive(exp_l3_compl); + [] BSSAP.receive(tr_BSSMAP_ComplL3) { + setverdict(fail, "Received non-matching COMPLETE LAYER 3 INFORMATION"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + [] T.timeout { + setverdict(fail, "Timeout waiting for COMPLETE LAYER 3 INFORMATION"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } } function f_rsl_send_l3(template PDU_ML3_MS_NW l3, template (omit) RslLinkId link_id := omit, @@ -1214,25 +1237,6 @@ f_ass_patch_lcls(ass_tpl, exp_ass_cpl); f_create_chan_and_exp(); - /* we should now have a COMPL_L3 at the MSC */ - - var template PDU_BSSAP exp_l3_compl; - exp_l3_compl := tr_BSSMAP_ComplL3() - if (g_pars.aoip == false) { - exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := omit; - } else { - exp_l3_compl.pdu.bssmap.completeLayer3Information.codecList := ?; - } - T.start; - alt { - [] BSSAP.receive(exp_l3_compl); - [] BSSAP.receive(tr_BSSMAP_ComplL3) { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Received non-matching COMPLETE LAYER 3 INFORMATION"); - } - [] T.timeout { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for COMPLETE LAYER 3 INFORMATION"); - } - } /* start ciphering, if requested */ if (ispresent(g_pars.encr)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic675168e29919e1234cb49440c4a630238ff5d70 Gerrit-Change-Number: 26448 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:39:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:39:06 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457 ) Change subject: BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9d7042ab4f3f7dea88811bd1b90d829065063f33 Gerrit-Change-Number: 26457 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 07 Dec 2021 07:39:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:39:08 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:39:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457 ) Change subject: BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc ...................................................................... BSC_Tests: add TC_rll_sapi_n_reject_dlci_cc Change-Id: I9d7042ab4f3f7dea88811bd1b90d829065063f33 Related: SYS#5047, OS#4728 --- M bsc/BSC_Tests.ttcn 1 file changed, 38 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 3aaab85..e7c4599 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -2435,6 +2435,7 @@ private function f_exp_sapi_n_reject(template (present) GsmSapi sapi := ?, template myBSSMAP_Cause cause := ?, + template (present) BIT2 cc := ?, float T_val := 2.0) runs on test_CT { var BSSAP_N_DATA_ind rx_di; @@ -2451,6 +2452,15 @@ setverdict(fail, "Rx unexpected Cause IE: ", rx_cause, " vs expected ", tr_cause); } + + /* Who ever on the earth decided to define this field as two separate bits?!? */ + var BIT2 rx_cc := rx_di.userData.pdu.bssmap.sAPInReject.dLCI.c2 + & rx_di.userData.pdu.bssmap.sAPInReject.dLCI.c1; + if (not match(rx_cc, cc)) { + setverdict(fail, "Rx unexpected Control Channel type: ", + rx_cc, " vs expected ", cc); + } + setverdict(pass); } [] BSSAP.receive(BSSAP_N_DATA_ind:?) -> value rx_di { @@ -2544,6 +2554,33 @@ f_shutdown_helper(); } +/* Check DLCI CC (Control Channel type) bits in SAPI N Reject */ +testcase TC_rll_sapi_n_reject_dlci_cc() runs on test_CT { + var octetstring rnd_data := f_rnd_octstring(16); + var RSL_Message rx_rsl; + var DchanTuple dt; + + f_init(1); + + /* MS establishes a SAPI=0 link on DCCH */ + dt := f_est_dchan(f_rnd_ra_cs(), 23, rnd_data); + + /* MSC sends some data on (not yet established) SAPI=3 link */ + BSSAP.send(ts_BSSAP_DATA_req(dt.sccp_conn_id, ts_BSSAP_DTAP(rnd_data, '03'O))); + /* BSC attempts to establish a SAPI=3 link on DCCH */ + rx_rsl := f_exp_ipa_rx(0, tr_RSL_EST_REQ(dt.rsl_chan_nr, tr_RslLinkID_DCCH(3))); + + /* MS sends unexpected ERROR INDication on DCCH/ACCH SAPI=3 */ + f_ipa_tx(0, ts_RSL_ERROR_IND(dt.rsl_chan_nr, ts_RslLinkID_DCCH(3), ''O)); + f_exp_sapi_n_reject(3, GSM0808_CAUSE_MS_NOT_EQUIPPED, '10'B); + + /* Clean up the connection */ + BSSAP.send(ts_BSSAP_DISC_req(dt.sccp_conn_id, 0)); + f_expect_chan_rel(0, dt.rsl_chan_nr, expect_rll_rel_req := false); + + f_shutdown_helper(); +} + testcase TC_si_default() runs on test_CT { f_init(0); f_init_bts_and_check_sysinfo(0, expect_si := SystemInformationConfig_default); @@ -10898,6 +10935,7 @@ execute( TC_rll_rel_ind_sapi_n_reject() ); execute( TC_rll_err_ind_sapi_n_reject() ); execute( TC_rll_timeout_sapi_n_reject() ); + execute( TC_rll_sapi_n_reject_dlci_cc() ); /* Paging related tests */ execute( TC_paging_imsi_nochan() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9d7042ab4f3f7dea88811bd1b90d829065063f33 Gerrit-Change-Number: 26457 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:41:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:41:03 +0000 Subject: Change in libosmocore[master]: select: add member for human readable name to osmo_fd In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26453 ) Change subject: select: add member for human readable name to osmo_fd ...................................................................... Patch Set 1: Code-Review+2 it might make sense to add a osmo_fd_set_name() function, or possibly even an extended osmo_fd_setup2 that adds the name argument? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I64b288174ae3dd22d50a701ce7cbf9e623246479 Gerrit-Change-Number: 26453 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 07 Dec 2021 07:41:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:54:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:54:42 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 1: Code-Review-1 (1 comment) I think this is completely inacceptable. osmo_select_main() is about the 'hottest' code path we have in the entire osmocom universe. It's the single most called function. You are adding potentially many hundreds of system calls (multiple for each fd, to find out if it's a stream socket, then the getsockopt) to _each interation_ of osmo_select_main. I would expect this to completely kill performance of software like osmo-mgw. I think the proper way to address this is to a) keep the status of what is a TCP stream socket in osmo_fd so we can just read it from there as opposed to invoking a system call (super expensive) b) gather those TCP_INFO statistics rarely. That could be a timer firing every 1/5/10 seconds (could e vty-configurable even down to 0, in case a user doesn't want this feature and the related overhead). Even then, iterating over all fd's in one timer and potentially issuing many consecutive TCP_INFO syscalls before returning to osmo_select_main() might introduce more delay than we want in some more performance critical code. One could also consider obtaining the statistics "every [Nth] read on the specific TCP stream socket". This would mean it is triggered whenever the fd is marked readable-or-writable, and before we call the fd_cb, we would issue the getsockopt. The nice part about this approach is that we avoid potentially long chains of getsockopt calls before returning back to osmo_select_main, i.e. avoid introducing high amounts of latency. If one decides to work in the 'one timer to issue TCP_INFO for all fds' approach: One idea would be to keep a separate list of only the TCP stream sockets, so that we don't have to iterate the whole list every time. This would add one more llist_add / llist_del in osmo_fd_{register,unregister}, which is a relatively "cold" path, i.e. not executed thousands of times per second. keping a separate flag in osmo_fd (or having the separate linked-list of 'stats enabled sockets') also adds the capability to selectively enable this feature for those TCP sockets where it really matters. In your current approach we would enable it for VTY and CTRL, for example, which I think is of very limited [if at all] benefit and can hence be avoided. https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/select.c at 388 PS1, Line 388: stats_tcp_poll(&osmo_fds); I really don't think you want to poll those statistics every time you enter any osmo_select_main. This could be thousands (or more!) times per second. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 07 Dec 2021 07:54:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:54:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:54:42 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: laforge has removed Jenkins Builder from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Removed reviewer Jenkins Builder with the following votes: * Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-MessageType: deleteReviewer -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:55:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:55:32 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy_peer: Free all related BVCs if the cell is freed In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26456 ) Change subject: gbproxy_peer: Free all related BVCs if the cell is freed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Iedeede8917e2870e0b62a2050ccb331109167017 Gerrit-Change-Number: 26456 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Tue, 07 Dec 2021 07:55:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:55:55 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:55:55 +0000 Subject: Change in libosmocore[master]: select: add member for human readable name to osmo_fd In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26453 ) Change subject: select: add member for human readable name to osmo_fd ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I64b288174ae3dd22d50a701ce7cbf9e623246479 Gerrit-Change-Number: 26453 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 07 Dec 2021 07:55:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:57:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:57:09 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Test BVC bringup with conflicting BVCs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26452 ) Change subject: gbproxy: Test BVC bringup with conflicting BVCs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I46eb0205b4c86b5f1bdc241ef0b2e12135c028e4 Gerrit-Change-Number: 26452 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 07 Dec 2021 07:57:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 07:58:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 07:58:06 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: fix TC_cm_serv_rej In-Reply-To: References: Message-ID: laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 ) Change subject: bsc: fix TC_cm_serv_rej ...................................................................... Abandoned see https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26448 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iad30319a7e9e726d006c9934ed2eb48f886811a9 Gerrit-Change-Number: 26433 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 12:51:03 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 7 Dec 2021 12:51:03 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy_peer: Free all related BVCs if the cell is freed In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26456 ) Change subject: gbproxy_peer: Free all related BVCs if the cell is freed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Iedeede8917e2870e0b62a2050ccb331109167017 Gerrit-Change-Number: 26456 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Tue, 07 Dec 2021 12:51:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 12:51:05 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 7 Dec 2021 12:51:05 +0000 Subject: Change in osmo-gbproxy[master]: gbproxy_peer: Free all related BVCs if the cell is freed In-Reply-To: References: Message-ID: daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26456 ) Change subject: gbproxy_peer: Free all related BVCs if the cell is freed ...................................................................... gbproxy_peer: Free all related BVCs if the cell is freed Previously the SGSN BVCs would still be present after the related Cell was freed. This caused some inconsistencies if a BVC with the same BVCI was established again. The symptoms of this were cells that were attached to no SGSN or the same one multiple times and crashes. This patch ensures that the SGSN-side BVCs are also freed when the cell is freed and that this fact is reflected when handling reset notifications. Change-Id: Iedeede8917e2870e0b62a2050ccb331109167017 --- M src/gb_proxy.c M src/gb_proxy_peer.c 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/gb_proxy.c b/src/gb_proxy.c index d6d760f..69a58d4 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -682,8 +682,10 @@ LOGPBVC(bvc->cell->bss_bvc, LOGL_NOTICE, "Destroying due to conflicting " "BVCI configuration (new NSEI=%05u)!\n", bvc->nse->nsei); gbproxy_bvc_free(bvc->cell->bss_bvc); + bvc->cell = NULL; + } else { + LOGPBVC(bvc, LOGL_ERROR, "Found cell without BSS BVC, this should not happen!"); } - bvc->cell->bss_bvc = bvc; } } diff --git a/src/gb_proxy_peer.c b/src/gb_proxy_peer.c index f59cf9e..0070155 100644 --- a/src/gb_proxy_peer.c +++ b/src/gb_proxy_peer.c @@ -217,8 +217,16 @@ { int i; - if (cell->bss_bvc == bvc) + if (cell->bss_bvc == bvc) { + /* Remove the whole cell including all BVCs */ + for (i = 0; i < ARRAY_SIZE(cell->sgsn_bvc); i++) { + if (cell->sgsn_bvc[i]) { + gbproxy_bvc_free(cell->sgsn_bvc[i]); + cell->sgsn_bvc[i] = NULL; + } + } return gbproxy_cell_free(cell); + } /* we could also be a SGSN-side BVC */ for (i = 0; i < ARRAY_SIZE(cell->sgsn_bvc); i++) { -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Iedeede8917e2870e0b62a2050ccb331109167017 Gerrit-Change-Number: 26456 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 15:26:04 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 7 Dec 2021 15:26:04 +0000 Subject: Change in libosmocore[master]: move tlv.h, tlv_parser.c from libosmogsm to libosmocore References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26459 ) Change subject: move tlv.h, tlv_parser.c from libosmogsm to libosmocore ...................................................................... move tlv.h, tlv_parser.c from libosmogsm to libosmocore TLV decoding and encoding has turned out useful outside of GSM, so move it to libosmocore. The current specific reason to move it is the implementation of osmo-upf, which depends on libosmocore, but does not need libosmogsm, besides the TLV parser/encoder for PFCP message coding. Related: SYS#5599 Change-Id: I3cda0143af9eaf90dc73f9deccd651117fdf8845 --- M TODO-RELEASE M include/Makefile.am A include/osmocom/core/tlv.h M include/osmocom/gsm/tlv.h M src/Makefile.am M src/gsm/Makefile.am R src/tlv_parser.c M tests/Makefile.am M tests/tlv/tlv_test.c 9 files changed, 728 insertions(+), 709 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/59/26459/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 8ccfa49..f8ba440 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmogsm osmocom/gsm/tlv.h gsm/tlv.h and gsm/tlv_parser.c moved to libosmocore diff --git a/include/Makefile.am b/include/Makefile.am index e3246cf..948cc70 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -62,6 +62,7 @@ osmocom/core/sockaddr_str.h \ osmocom/core/time_cc.h \ osmocom/core/use_count.h \ + osmocom/core/tlv.h \ osmocom/crypt/auth.h \ osmocom/crypt/gprs_cipher.h \ osmocom/crypt/kdf.h \ diff --git a/include/osmocom/core/tlv.h b/include/osmocom/core/tlv.h new file mode 100644 index 0000000..7e6dfb5 --- /dev/null +++ b/include/osmocom/core/tlv.h @@ -0,0 +1,708 @@ +#pragma once + +#include +#include + +#include +#include +#include +#include + +/*! \defgroup tlv TLV parser + * @{ + * \file tlv.h */ + +/* Terminology / wording + tag length value (in bits) + + V - - 8 + LV - 8 N * 8 + TLV 8 8 N * 8 + TL16V 8 16 N * 8 + TLV16 8 8 N * 16 + TvLV 8 8/16 N * 8 + vTvLV 8/16 8/16 N * 8 + T16LV 16 8 N * 8 +*/ + +/*! gross length of a LV type field */ +#define LV_GROSS_LEN(x) (x+1) +/*! gross length of a TLV type field */ +#define TLV_GROSS_LEN(x) (x+2) +/*! gross length of a TLV16 type field */ +#define TLV16_GROSS_LEN(x) ((2*x)+2) +/*! gross length of a TL16V type field */ +#define TL16V_GROSS_LEN(x) (x+3) +/*! gross length of a L16TV type field */ +#define L16TV_GROSS_LEN(x) (x+3) +/*! gross length of a T16LV type field */ +#define T16LV_GROSS_LEN(x) (x+3) + +/*! maximum length of TLV of one byte length */ +#define TVLV_MAX_ONEBYTE 0x7f + +/*! error return codes of various TLV parser functions */ +enum osmo_tlv_parser_error { + OSMO_TLVP_ERR_OFS_BEYOND_BUFFER = -1, + OSMO_TLVP_ERR_OFS_LEN_BEYOND_BUFFER = -2, + OSMO_TLVP_ERR_UNKNOWN_TLV_TYPE = -3, + + OSMO_TLVP_ERR_MAND_IE_MISSING = -50, + OSMO_TLVP_ERR_IE_TOO_SHORT = -51, +}; + +/*! gross length of a TVLV type field */ +static inline uint16_t TVLV_GROSS_LEN(uint16_t len) +{ + if (len <= TVLV_MAX_ONEBYTE) + return TLV_GROSS_LEN(len); + else + return TL16V_GROSS_LEN(len); +} + +/*! gross length of vTvL header (tag+len) */ +static inline uint16_t VTVL_GAN_GROSS_LEN(uint16_t tag, uint16_t len) +{ + uint16_t ret = 2; + + if (tag > TVLV_MAX_ONEBYTE) + ret++; + + if (len > TVLV_MAX_ONEBYTE) + ret++; + + return ret; +} + +/*! gross length of vTvLV (tag+len+val) */ +static inline uint16_t VTVLV_GAN_GROSS_LEN(uint16_t tag, uint16_t len) +{ + uint16_t ret; + + if (len <= TVLV_MAX_ONEBYTE) + ret = TLV_GROSS_LEN(len); + else + ret = TL16V_GROSS_LEN(len); + + if (tag > TVLV_MAX_ONEBYTE) + ret += 1; + + return ret; +} + +/* TLV generation */ + +/*! put (append) a LV field */ +static inline uint8_t *lv_put(uint8_t *buf, uint8_t len, + const uint8_t *val) +{ + *buf++ = len; + memcpy(buf, val, len); + return buf + len; +} + +/*! Append a TLV field, a Tag-Length-Value field. + * \param[out] buf Location in a buffer to append TLV at. + * \param[in] tag Tag id to write. + * \param[in] len Length field to write and amount of bytes to append. + * \param[in] val Pointer to data to append, or NULL to append zero data. + * Always append tag and length. Append \a len bytes read from \a val. If val is NULL, append \a len zero + * bytes instead. If \a len is zero, do not append any data apart from tag and length. */ +static inline uint8_t *tlv_put(uint8_t *buf, uint8_t tag, uint8_t len, + const uint8_t *val) +{ + *buf++ = tag; + *buf++ = len; + if (len) { + if (val) + memcpy(buf, val, len); + else + memset(buf, 0, len); + } + return buf + len; +} + +/*! put (append) a TL field (a TLV field but omitting the value part). */ +static inline uint8_t *tl_put(uint8_t *buf, uint8_t tag, uint8_t len) +{ + *buf++ = tag; + *buf++ = len; + return buf; +} + +/*! put (append) a TLV16 field */ +static inline uint8_t *tlv16_put(uint8_t *buf, uint8_t tag, uint8_t len, + const uint16_t *val) +{ + *buf++ = tag; + *buf++ = len; + memcpy(buf, val, len*2); + return buf + len*2; +} + +/*! put (append) a TL16V field */ +static inline uint8_t *tl16v_put(uint8_t *buf, uint8_t tag, uint16_t len, + const uint8_t *val) +{ + *buf++ = tag; + *buf++ = len >> 8; + *buf++ = len & 0xff; + memcpy(buf, val, len); + return buf + len; +} + +/*! put (append) a TL16 field. */ +static inline uint8_t *tl16_put(uint8_t *buf, uint8_t tag, uint16_t len) +{ + *buf++ = tag; + *buf++ = len >> 8; + *buf++ = len & 0xff; + return buf; +} + +/*! put (append) a TL16V field */ +static inline uint8_t *t16lv_put(uint8_t *buf, uint16_t tag, uint8_t len, + const uint8_t *val) +{ + *buf++ = tag >> 8; + *buf++ = tag & 0xff; + *buf++ = len; + memcpy(buf, val, len); + return buf + len; +} + +/*! put (append) a TvLV field */ +static inline uint8_t *tvlv_put(uint8_t *buf, uint8_t tag, uint16_t len, + const uint8_t *val) +{ + uint8_t *ret; + + if (len <= TVLV_MAX_ONEBYTE) { + ret = tlv_put(buf, tag, len, val); + buf[1] |= 0x80; + } else + ret = tl16v_put(buf, tag, len, val); + + return ret; +} + +/*! put (append) a TvL field (a TvLV with variable-size length, where the value part's length is already known, but will + * be put() later). + * \returns pointer to the value's start position. + */ +static inline uint8_t *tvl_put(uint8_t *buf, uint8_t tag, uint16_t len) +{ + uint8_t *ret; + + if (len <= TVLV_MAX_ONEBYTE) { + ret = tl_put(buf, tag, len); + buf[1] |= 0x80; + } else + ret = tl16_put(buf, tag, len); + + return ret; +} + +/*! put (append) a variable-length tag or variable-length length * */ +static inline uint8_t *vt_gan_put(uint8_t *buf, uint16_t tag) +{ + if (tag > TVLV_MAX_ONEBYTE) { + /* two-byte TAG */ + *buf++ = 0x80 | (tag >> 8); + *buf++ = (tag & 0xff); + } else + *buf++ = tag; + + return buf; +} + +/* put (append) vTvL (GAN) field (tag + length)*/ +static inline uint8_t *vtvl_gan_put(uint8_t *buf, uint16_t tag, uint16_t len) +{ + uint8_t *ret; + + ret = vt_gan_put(buf, tag); + return vt_gan_put(ret, len); +} + +/* put (append) vTvLV (GAN) field (tag + length + val) */ +static inline uint8_t *vtvlv_gan_put(uint8_t *buf, uint16_t tag, uint16_t len, + const uint8_t *val) +{ + uint8_t *ret; + + ret = vtvl_gan_put(buf, tag, len ); + + memcpy(ret, val, len); + ret = buf + len; + + return ret; +} + +/*! put (append) a TLV16 field to \ref msgb */ +static inline uint8_t *msgb_tlv16_put(struct msgb *msg, uint8_t tag, uint8_t len, const uint16_t *val) +{ + uint8_t *buf = msgb_put(msg, TLV16_GROSS_LEN(len)); + return tlv16_put(buf, tag, len, val); +} + +/*! put (append) a TL16V field to \ref msgb */ +static inline uint8_t *msgb_tl16v_put(struct msgb *msg, uint8_t tag, uint16_t len, + const uint8_t *val) +{ + uint8_t *buf = msgb_put(msg, TL16V_GROSS_LEN(len)); + return tl16v_put(buf, tag, len, val); +} + +static inline uint8_t *msgb_t16lv_put(struct msgb *msg, uint16_t tag, uint8_t len, const uint8_t *val) +{ + uint8_t *buf = msgb_put(msg, T16LV_GROSS_LEN(len)); + return t16lv_put(buf, tag, len, val); +} + +/*! put (append) a TvL field to \ref msgb, i.e. a TvLV with variable-size length, where the value's length is already + * known, but will be put() later. The value section is not yet reserved, only tag and variable-length are put in the + * msgb. + * \returns pointer to the value's start position and end of the msgb. + */ +static inline uint8_t *msgb_tvl_put(struct msgb *msg, uint8_t tag, uint16_t len) +{ + uint8_t *buf = msgb_put(msg, TVLV_GROSS_LEN(len)); + return tvl_put(buf, tag, len); +} + +/*! put (append) a TvLV field to \ref msgb */ +static inline uint8_t *msgb_tvlv_put(struct msgb *msg, uint8_t tag, uint16_t len, + const uint8_t *val) +{ + uint8_t *buf = msgb_put(msg, TVLV_GROSS_LEN(len)); + return tvlv_put(buf, tag, len, val); +} + +/*! put (append) a TvLV field containing a big-endian 16bit value to msgb. */ +static inline uint8_t *msgb_tvlv_put_16be(struct msgb *msg, uint8_t tag, uint16_t val) +{ + uint16_t val_be = osmo_htons(val); + return msgb_tvlv_put(msg, tag, 2, (const uint8_t *)&val_be); +} + +/*! put (append) a TvLV field containing a big-endian 16bit value to msgb. */ +static inline uint8_t *msgb_tvlv_put_32be(struct msgb *msg, uint8_t tag, uint32_t val) +{ + uint32_t val_be = osmo_htonl(val); + return msgb_tvlv_put(msg, tag, 4, (const uint8_t *)&val_be); +} + +/*! put (append) a vTvLV field to \ref msgb */ +static inline uint8_t *msgb_vtvlv_gan_put(struct msgb *msg, uint16_t tag, + uint16_t len, const uint8_t *val) +{ + uint8_t *buf = msgb_put(msg, VTVLV_GAN_GROSS_LEN(tag, len)); + return vtvlv_gan_put(buf, tag, len, val); +} + +/*! put (append) a L16TV field to \ref msgb */ +static inline uint8_t *msgb_l16tv_put(struct msgb *msg, uint16_t len, uint8_t tag, + const uint8_t *val) +{ + uint8_t *buf = msgb_put(msg, L16TV_GROSS_LEN(len)); + + *buf++ = len >> 8; + *buf++ = len & 0xff; + *buf++ = tag; + memcpy(buf, val, len); + return buf + len; +} + +/*! put (append) a V field */ +static inline uint8_t *v_put(uint8_t *buf, uint8_t val) +{ + *buf++ = val; + return buf; +} + +/*! put (append) a TV field */ +static inline uint8_t *tv_put(uint8_t *buf, uint8_t tag, + uint8_t val) +{ + *buf++ = tag; + *buf++ = val; + return buf; +} + +/*! put (append) a TVfixed field */ +static inline uint8_t *tv_fixed_put(uint8_t *buf, uint8_t tag, + unsigned int len, const uint8_t *val) +{ + *buf++ = tag; + memcpy(buf, val, len); + return buf + len; +} + +/*! put (append) a TV16 field + * \param[in,out] buf data buffer + * \param[in] tag Tag value + * \param[in] val Value (in host byte order!) + */ +static inline uint8_t *tv16_put(uint8_t *buf, uint8_t tag, + uint16_t val) +{ + *buf++ = tag; + *buf++ = val >> 8; + *buf++ = val & 0xff; + return buf; +} + +/*! put (append) a LV field to a \ref msgb + * \returns pointer to first byte after newly-put information */ +static inline uint8_t *msgb_lv_put(struct msgb *msg, uint8_t len, const uint8_t *val) +{ + uint8_t *buf = msgb_put(msg, LV_GROSS_LEN(len)); + return lv_put(buf, len, val); +} + +/*! put (append) a TLV field to a \ref msgb + * \returns pointer to first byte after newly-put information */ +static inline uint8_t *msgb_tlv_put(struct msgb *msg, uint8_t tag, uint8_t len, const uint8_t *val) +{ + uint8_t *buf = msgb_put(msg, TLV_GROSS_LEN(len)); + return tlv_put(buf, tag, len, val); +} + +/*! put (append) a TV field to a \ref msgb + * \returns pointer to first byte after newly-put information */ +static inline uint8_t *msgb_tv_put(struct msgb *msg, uint8_t tag, uint8_t val) +{ + uint8_t *buf = msgb_put(msg, 2); + return tv_put(buf, tag, val); +} + +/*! put (append) a TVfixed field to a \ref msgb + * \returns pointer to first byte after newly-put information */ +static inline uint8_t *msgb_tv_fixed_put(struct msgb *msg, uint8_t tag, + unsigned int len, const uint8_t *val) +{ + uint8_t *buf = msgb_put(msg, 1+len); + return tv_fixed_put(buf, tag, len, val); +} + +/*! put (append) a V field to a \ref msgb + * \returns pointer to first byte after newly-put information */ +static inline uint8_t *msgb_v_put(struct msgb *msg, uint8_t val) +{ + uint8_t *buf = msgb_put(msg, 1); + return v_put(buf, val); +} + +/*! put (append) a TL fields to a \ref msgb + * \returns pointer to the length field so it can be updated after adding new information under specified tag */ +static inline uint8_t *msgb_tl_put(struct msgb *msg, uint8_t tag) +{ + uint8_t *len = msgb_v_put(msg, tag); + + /* reserve space for length, len points to this reserved space already */ + msgb_v_put(msg, 0); + + return len; +} + +/*! put (append) a TV16 field (network order) to the given msgb + * \returns pointer to first byte after newly-put information */ +static inline uint8_t *msgb_tv16_put(struct msgb *msg, uint8_t tag, uint16_t val) +{ + uint8_t *buf = msgb_put(msg, 3); + return tv16_put(buf, tag, val); +} + +/*! put (append) a TV32 field (network order) to the given msgb + * \returns pointer to first byte after newly-put information */ +static inline uint8_t *msgb_tv32_put(struct msgb *msg, uint8_t tag, uint32_t val) +{ + uint8_t *buf = msgb_put(msg, 1 + 4); + *buf++ = tag; + osmo_store32be(val, buf); + return msg->tail; +} + +/*! push (prepend) a TLV field to a \ref msgb + * \returns pointer to first byte of newly-pushed information */ +static inline uint8_t *msgb_tlv_push(struct msgb *msg, uint8_t tag, uint8_t len, const uint8_t *val) +{ + uint8_t *buf = msgb_push(msg, TLV_GROSS_LEN(len)); + tlv_put(buf, tag, len, val); + return buf; +} + +/*! push 1-byte tagged value */ +static inline uint8_t *msgb_tlv1_push(struct msgb *msg, uint8_t tag, uint8_t val) +{ + return msgb_tlv_push(msg, tag, 1, &val); +} + +/*! push (prepend) a TV field to a \ref msgb + * \returns pointer to first byte of newly-pushed information */ +static inline uint8_t *msgb_tv_push(struct msgb *msg, uint8_t tag, uint8_t val) +{ + uint8_t *buf = msgb_push(msg, 2); + tv_put(buf, tag, val); + return buf; +} + +/*! push (prepend) a TV16 field to a \ref msgb + * \returns pointer to first byte of newly-pushed information */ +static inline uint8_t *msgb_tv16_push(struct msgb *msg, uint8_t tag, uint16_t val) +{ + uint8_t *buf = msgb_push(msg, 3); + tv16_put(buf, tag, val); + return buf; +} + +/*! push (prepend) a TvLV field to a \ref msgb + * \returns pointer to first byte of newly-pushed information */ +static inline uint8_t *msgb_tvlv_push(struct msgb *msg, uint8_t tag, uint16_t len, + const uint8_t *val) +{ + uint8_t *buf = msgb_push(msg, TVLV_GROSS_LEN(len)); + tvlv_put(buf, tag, len, val); + return buf; +} + +/* push (prepend) a vTvL header to a \ref msgb + */ +static inline uint8_t *msgb_vtvl_gan_push(struct msgb *msg, uint16_t tag, + uint16_t len) +{ + uint8_t *buf = msgb_push(msg, VTVL_GAN_GROSS_LEN(tag, len)); + vtvl_gan_put(buf, tag, len); + return buf; +} + + +static inline uint8_t *msgb_vtvlv_gan_push(struct msgb *msg, uint16_t tag, + uint16_t len, const uint8_t *val) +{ + uint8_t *buf = msgb_push(msg, VTVLV_GAN_GROSS_LEN(tag, len)); + vtvlv_gan_put(buf, tag, len, val); + return buf; +} + +/* TLV parsing */ + +/*! Entry in a TLV parser array */ +struct tlv_p_entry { + uint16_t len; /*!< length */ + const uint8_t *val; /*!< pointer to value */ +}; + +/*! TLV type */ +enum tlv_type { + TLV_TYPE_NONE, /*!< no type */ + TLV_TYPE_FIXED, /*!< fixed-length value-only */ + TLV_TYPE_T, /*!< tag-only */ + TLV_TYPE_TV, /*!< tag-value (8bit) */ + TLV_TYPE_TLV, /*!< tag-length-value */ + TLV_TYPE_TL16V, /*!< tag, 16 bit length, value */ + TLV_TYPE_TvLV, /*!< tag, variable length, value */ + TLV_TYPE_SINGLE_TV, /*!< tag and value (both 4 bit) in 1 byte */ + TLV_TYPE_vTvLV_GAN, /*!< variable-length tag, variable-length length */ +}; + +/*! Definition of a single IE (Information Element) */ +struct tlv_def { + enum tlv_type type; /*!< TLV type */ + uint8_t fixed_len; /*!< length in case of \ref TLV_TYPE_FIXED */ +}; + +/*! Definition of All 256 IE / TLV */ +struct tlv_definition { + struct tlv_def def[256]; +}; + +/*! result of the TLV parser */ +struct tlv_parsed { + struct tlv_p_entry lv[256]; +}; + +extern struct tlv_definition tvlv_att_def; +extern struct tlv_definition vtvlv_gan_att_def; + +int tlv_parse_one(uint8_t *o_tag, uint16_t *o_len, const uint8_t **o_val, + const struct tlv_definition *def, + const uint8_t *buf, int buf_len); +int tlv_parse(struct tlv_parsed *dec, const struct tlv_definition *def, + const uint8_t *buf, int buf_len, uint8_t lv_tag, uint8_t lv_tag2); +int tlv_parse2(struct tlv_parsed *dec, int dec_multiples, + const struct tlv_definition *def, const uint8_t *buf, int buf_len, + uint8_t lv_tag, uint8_t lv_tag2); +/* take a master (src) tlv def and fill up all empty slots in 'dst' */ +void tlv_def_patch(struct tlv_definition *dst, const struct tlv_definition *src); + +int tlv_encode_one(struct msgb *msg, enum tlv_type type, uint8_t tag, + unsigned int len, const uint8_t *val); +int tlv_encode(struct msgb *msg, const struct tlv_definition *def, const struct tlv_parsed *tp); +int tlv_encode_ordered(struct msgb *msg, const struct tlv_definition *def, const struct tlv_parsed *tp, + const uint8_t *tag_order, unsigned int tag_order_len); + +#define TLVP_PRESENT(x, y) ((x)->lv[y].val) +#define TLVP_LEN(x, y) (x)->lv[y].len +#define TLVP_VAL(x, y) (x)->lv[y].val + +#define TLVP_PRES_LEN(tp, tag, min_len) \ + (TLVP_PRESENT(tp, tag) && TLVP_LEN(tp, tag) >= min_len) + +/*! Return pointer to a TLV element if it is present. + * Usage: + * struct tlv_p_entry *e = TVLP_GET(&tp, TAG); + * if (!e) + * return -ENOENT; + * hexdump(e->val, e->len); + * \param[in] _tp pointer to \ref tlv_parsed. + * \param[in] tag IE tag to return. + * \returns struct tlv_p_entry pointer, or NULL if not present. + */ +#define TLVP_GET(_tp, tag) (TLVP_PRESENT(_tp, tag)? &(_tp)->lv[tag] : NULL) + +/*! Like TLVP_GET(), but enforcing a minimum val length. + * \param[in] _tp pointer to \ref tlv_parsed. + * \param[in] tag IE tag to return. + * \param[in] min_len Minimum value length in bytes. + * \returns struct tlv_p_entry pointer, or NULL if not present or too short. + */ +#define TLVP_GET_MINLEN(_tp, tag, min_len) \ + (TLVP_PRES_LEN(_tp, tag, min_len)? &(_tp)->lv[tag] : NULL) + +/*! Like TLVP_VAL(), but enforcing a minimum val length. + * \param[in] _tp pointer to \ref tlv_parsed. + * \param[in] tag IE tag to return. + * \param[in] min_len Minimum value length in bytes. + * \returns const uint8_t pointer to value, or NULL if not present or too short. + */ +#define TLVP_VAL_MINLEN(_tp, tag, min_len) \ + (TLVP_PRES_LEN(_tp, tag, min_len)? (_tp)->lv[tag].val : NULL) + + +/*! Obtain 1-byte TLV element. + * \param[in] tp pointer to \ref tlv_parsed + * \param[in] tag the Tag to look for + * \param[in] default_val default value to use if tag not available + * \returns the 1st byte of value with a given tag or default_val if tag was not found + */ +static inline uint8_t tlvp_val8(const struct tlv_parsed *tp, uint8_t tag, uint8_t default_val) +{ + const uint8_t *res = TLVP_VAL_MINLEN(tp, tag, 1); + + if (res) + return res[0]; + + return default_val; +} + +/*! Align given TLV element with 16 bit value to an even address + * \param[in] tp pointer to \ref tlv_parsed + * \param[in] pos element to return + * \returns aligned 16 bit value + */ +static inline uint16_t tlvp_val16_unal(const struct tlv_parsed *tp, int pos) +{ + uint16_t res; + memcpy(&res, TLVP_VAL(tp, pos), sizeof(res)); + return res; +} + +/*! Align given TLV element with 32 bit value to an address that is a multiple of 4 + * \param[in] tp pointer to \ref tlv_parsed + * \param[in] pos element to return + * \returns aligned 32 bit value + */ +static inline uint32_t tlvp_val32_unal(const struct tlv_parsed *tp, int pos) +{ + uint32_t res; + memcpy(&res, TLVP_VAL(tp, pos), sizeof(res)); + return res; +} + +/*! Retrieve (possibly unaligned) TLV element and convert to host byte order + * \param[in] tp pointer to \ref tlv_parsed + * \param[in] pos element to return + * \returns aligned 16 bit value in host byte order + */ +static inline uint16_t tlvp_val16be(const struct tlv_parsed *tp, int pos) +{ + return osmo_load16be(TLVP_VAL(tp, pos)); +} + +/*! Retrieve (possibly unaligned) TLV element and convert to host byte order + * \param[in] tp pointer to \ref tlv_parsed + * \param[in] pos element to return + * \returns aligned 32 bit value in host byte order + */ +static inline uint32_t tlvp_val32be(const struct tlv_parsed *tp, int pos) +{ + return osmo_load32be(TLVP_VAL(tp, pos)); +} + + +struct tlv_parsed *osmo_tlvp_copy(const struct tlv_parsed *tp_orig, void *ctx); +int osmo_tlvp_merge(struct tlv_parsed *dst, const struct tlv_parsed *src); +int osmo_shift_v_fixed(uint8_t **data, size_t *data_len, + size_t len, uint8_t **value); +int osmo_match_shift_tv_fixed(uint8_t **data, size_t *data_len, + uint8_t tag, size_t len, uint8_t **value); +int osmo_shift_tlv(uint8_t **data, size_t *data_len, + uint8_t *tag, uint8_t **value, size_t *value_len); +int osmo_match_shift_tlv(uint8_t **data, size_t *data_len, + uint8_t tag, uint8_t **value, size_t *value_len); +int osmo_shift_lv(uint8_t **data, size_t *data_len, + uint8_t **value, size_t *value_len); + +#define MSG_DEF(name, mand_ies, flags) { name, mand_ies, ARRAY_SIZE(mand_ies), flags } + +struct osmo_tlv_prot_msg_def { + /*! human-readable name of message type (optional) */ + const char *name; + /*! array of mandatory IEs */ + const uint8_t *mand_ies; + /*! number of entries in 'mand_ies' above */ + uint8_t mand_count; + /*! user-defined flags (like uplink/downlink/...) */ + uint32_t flags; +}; +struct osmo_tlv_prot_ie_def { + /*! minimum length of IE value part, in octets */ + uint16_t min_len; + /*! huamn-readable name (optional) */ + const char *name; +}; + +/*! Osmocom TLV protocol definition */ +struct osmo_tlv_prot_def { + /*! human-readable name of protocol */ + const char *name; + /*! TLV parser definition (optional) */ + const struct tlv_definition *tlv_def; + /*! definition of each message (8-bit message type) */ + struct osmo_tlv_prot_msg_def msg_def[256]; + /*! definition of IE for each 8-bit tag */ + struct osmo_tlv_prot_ie_def ie_def[256]; + /*! value_string array of message type names (legacy, if not populated in msg_def) */ + const struct value_string *msgt_names; +}; + +const char *osmo_tlv_prot_msg_name(const struct osmo_tlv_prot_def *pdef, uint8_t msg_type); +const char *osmo_tlv_prot_ie_name(const struct osmo_tlv_prot_def *pdef, uint8_t iei); + +int osmo_tlv_prot_validate_tp(const struct osmo_tlv_prot_def *pdef, uint8_t msg_type, + const struct tlv_parsed *tp, int log_subsys, const char *log_pfx); + +int osmo_tlv_prot_parse(const struct osmo_tlv_prot_def *pdef, + struct tlv_parsed *dec, unsigned int dec_multiples, uint8_t msg_type, + const uint8_t *buf, unsigned int buf_len, uint8_t lv_tag, uint8_t lv_tag2, + int log_subsys, const char *log_pfx); + +static inline uint32_t osmo_tlv_prot_msgt_flags(const struct osmo_tlv_prot_def *pdef, uint8_t msg_type) +{ + return pdef->msg_def[msg_type].flags; +} + + +/*! @} */ diff --git a/include/osmocom/gsm/tlv.h b/include/osmocom/gsm/tlv.h index 7e6dfb5..05a7261 100644 --- a/include/osmocom/gsm/tlv.h +++ b/include/osmocom/gsm/tlv.h @@ -1,708 +1,8 @@ #pragma once -#include -#include - -#include -#include -#include -#include - -/*! \defgroup tlv TLV parser - * @{ - * \file tlv.h */ - -/* Terminology / wording - tag length value (in bits) - - V - - 8 - LV - 8 N * 8 - TLV 8 8 N * 8 - TL16V 8 16 N * 8 - TLV16 8 8 N * 16 - TvLV 8 8/16 N * 8 - vTvLV 8/16 8/16 N * 8 - T16LV 16 8 N * 8 -*/ - -/*! gross length of a LV type field */ -#define LV_GROSS_LEN(x) (x+1) -/*! gross length of a TLV type field */ -#define TLV_GROSS_LEN(x) (x+2) -/*! gross length of a TLV16 type field */ -#define TLV16_GROSS_LEN(x) ((2*x)+2) -/*! gross length of a TL16V type field */ -#define TL16V_GROSS_LEN(x) (x+3) -/*! gross length of a L16TV type field */ -#define L16TV_GROSS_LEN(x) (x+3) -/*! gross length of a T16LV type field */ -#define T16LV_GROSS_LEN(x) (x+3) - -/*! maximum length of TLV of one byte length */ -#define TVLV_MAX_ONEBYTE 0x7f - -/*! error return codes of various TLV parser functions */ -enum osmo_tlv_parser_error { - OSMO_TLVP_ERR_OFS_BEYOND_BUFFER = -1, - OSMO_TLVP_ERR_OFS_LEN_BEYOND_BUFFER = -2, - OSMO_TLVP_ERR_UNKNOWN_TLV_TYPE = -3, - - OSMO_TLVP_ERR_MAND_IE_MISSING = -50, - OSMO_TLVP_ERR_IE_TOO_SHORT = -51, -}; - -/*! gross length of a TVLV type field */ -static inline uint16_t TVLV_GROSS_LEN(uint16_t len) -{ - if (len <= TVLV_MAX_ONEBYTE) - return TLV_GROSS_LEN(len); - else - return TL16V_GROSS_LEN(len); -} - -/*! gross length of vTvL header (tag+len) */ -static inline uint16_t VTVL_GAN_GROSS_LEN(uint16_t tag, uint16_t len) -{ - uint16_t ret = 2; - - if (tag > TVLV_MAX_ONEBYTE) - ret++; - - if (len > TVLV_MAX_ONEBYTE) - ret++; - - return ret; -} - -/*! gross length of vTvLV (tag+len+val) */ -static inline uint16_t VTVLV_GAN_GROSS_LEN(uint16_t tag, uint16_t len) -{ - uint16_t ret; - - if (len <= TVLV_MAX_ONEBYTE) - ret = TLV_GROSS_LEN(len); - else - ret = TL16V_GROSS_LEN(len); - - if (tag > TVLV_MAX_ONEBYTE) - ret += 1; - - return ret; -} - -/* TLV generation */ - -/*! put (append) a LV field */ -static inline uint8_t *lv_put(uint8_t *buf, uint8_t len, - const uint8_t *val) -{ - *buf++ = len; - memcpy(buf, val, len); - return buf + len; -} - -/*! Append a TLV field, a Tag-Length-Value field. - * \param[out] buf Location in a buffer to append TLV at. - * \param[in] tag Tag id to write. - * \param[in] len Length field to write and amount of bytes to append. - * \param[in] val Pointer to data to append, or NULL to append zero data. - * Always append tag and length. Append \a len bytes read from \a val. If val is NULL, append \a len zero - * bytes instead. If \a len is zero, do not append any data apart from tag and length. */ -static inline uint8_t *tlv_put(uint8_t *buf, uint8_t tag, uint8_t len, - const uint8_t *val) -{ - *buf++ = tag; - *buf++ = len; - if (len) { - if (val) - memcpy(buf, val, len); - else - memset(buf, 0, len); - } - return buf + len; -} - -/*! put (append) a TL field (a TLV field but omitting the value part). */ -static inline uint8_t *tl_put(uint8_t *buf, uint8_t tag, uint8_t len) -{ - *buf++ = tag; - *buf++ = len; - return buf; -} - -/*! put (append) a TLV16 field */ -static inline uint8_t *tlv16_put(uint8_t *buf, uint8_t tag, uint8_t len, - const uint16_t *val) -{ - *buf++ = tag; - *buf++ = len; - memcpy(buf, val, len*2); - return buf + len*2; -} - -/*! put (append) a TL16V field */ -static inline uint8_t *tl16v_put(uint8_t *buf, uint8_t tag, uint16_t len, - const uint8_t *val) -{ - *buf++ = tag; - *buf++ = len >> 8; - *buf++ = len & 0xff; - memcpy(buf, val, len); - return buf + len; -} - -/*! put (append) a TL16 field. */ -static inline uint8_t *tl16_put(uint8_t *buf, uint8_t tag, uint16_t len) -{ - *buf++ = tag; - *buf++ = len >> 8; - *buf++ = len & 0xff; - return buf; -} - -/*! put (append) a TL16V field */ -static inline uint8_t *t16lv_put(uint8_t *buf, uint16_t tag, uint8_t len, - const uint8_t *val) -{ - *buf++ = tag >> 8; - *buf++ = tag & 0xff; - *buf++ = len; - memcpy(buf, val, len); - return buf + len; -} - -/*! put (append) a TvLV field */ -static inline uint8_t *tvlv_put(uint8_t *buf, uint8_t tag, uint16_t len, - const uint8_t *val) -{ - uint8_t *ret; - - if (len <= TVLV_MAX_ONEBYTE) { - ret = tlv_put(buf, tag, len, val); - buf[1] |= 0x80; - } else - ret = tl16v_put(buf, tag, len, val); - - return ret; -} - -/*! put (append) a TvL field (a TvLV with variable-size length, where the value part's length is already known, but will - * be put() later). - * \returns pointer to the value's start position. +/* Up to libosmocore v1.6.0, tlv.h lived in osmocom/gsm/tlv.h. + * The file was moved to osmocom/core/tlv.h, because TLV turned out to be useful outside of GSM. + * For easy compatibility, this file remains as redirection to core/tlv.h. */ -static inline uint8_t *tvl_put(uint8_t *buf, uint8_t tag, uint16_t len) -{ - uint8_t *ret; - if (len <= TVLV_MAX_ONEBYTE) { - ret = tl_put(buf, tag, len); - buf[1] |= 0x80; - } else - ret = tl16_put(buf, tag, len); - - return ret; -} - -/*! put (append) a variable-length tag or variable-length length * */ -static inline uint8_t *vt_gan_put(uint8_t *buf, uint16_t tag) -{ - if (tag > TVLV_MAX_ONEBYTE) { - /* two-byte TAG */ - *buf++ = 0x80 | (tag >> 8); - *buf++ = (tag & 0xff); - } else - *buf++ = tag; - - return buf; -} - -/* put (append) vTvL (GAN) field (tag + length)*/ -static inline uint8_t *vtvl_gan_put(uint8_t *buf, uint16_t tag, uint16_t len) -{ - uint8_t *ret; - - ret = vt_gan_put(buf, tag); - return vt_gan_put(ret, len); -} - -/* put (append) vTvLV (GAN) field (tag + length + val) */ -static inline uint8_t *vtvlv_gan_put(uint8_t *buf, uint16_t tag, uint16_t len, - const uint8_t *val) -{ - uint8_t *ret; - - ret = vtvl_gan_put(buf, tag, len ); - - memcpy(ret, val, len); - ret = buf + len; - - return ret; -} - -/*! put (append) a TLV16 field to \ref msgb */ -static inline uint8_t *msgb_tlv16_put(struct msgb *msg, uint8_t tag, uint8_t len, const uint16_t *val) -{ - uint8_t *buf = msgb_put(msg, TLV16_GROSS_LEN(len)); - return tlv16_put(buf, tag, len, val); -} - -/*! put (append) a TL16V field to \ref msgb */ -static inline uint8_t *msgb_tl16v_put(struct msgb *msg, uint8_t tag, uint16_t len, - const uint8_t *val) -{ - uint8_t *buf = msgb_put(msg, TL16V_GROSS_LEN(len)); - return tl16v_put(buf, tag, len, val); -} - -static inline uint8_t *msgb_t16lv_put(struct msgb *msg, uint16_t tag, uint8_t len, const uint8_t *val) -{ - uint8_t *buf = msgb_put(msg, T16LV_GROSS_LEN(len)); - return t16lv_put(buf, tag, len, val); -} - -/*! put (append) a TvL field to \ref msgb, i.e. a TvLV with variable-size length, where the value's length is already - * known, but will be put() later. The value section is not yet reserved, only tag and variable-length are put in the - * msgb. - * \returns pointer to the value's start position and end of the msgb. - */ -static inline uint8_t *msgb_tvl_put(struct msgb *msg, uint8_t tag, uint16_t len) -{ - uint8_t *buf = msgb_put(msg, TVLV_GROSS_LEN(len)); - return tvl_put(buf, tag, len); -} - -/*! put (append) a TvLV field to \ref msgb */ -static inline uint8_t *msgb_tvlv_put(struct msgb *msg, uint8_t tag, uint16_t len, - const uint8_t *val) -{ - uint8_t *buf = msgb_put(msg, TVLV_GROSS_LEN(len)); - return tvlv_put(buf, tag, len, val); -} - -/*! put (append) a TvLV field containing a big-endian 16bit value to msgb. */ -static inline uint8_t *msgb_tvlv_put_16be(struct msgb *msg, uint8_t tag, uint16_t val) -{ - uint16_t val_be = osmo_htons(val); - return msgb_tvlv_put(msg, tag, 2, (const uint8_t *)&val_be); -} - -/*! put (append) a TvLV field containing a big-endian 16bit value to msgb. */ -static inline uint8_t *msgb_tvlv_put_32be(struct msgb *msg, uint8_t tag, uint32_t val) -{ - uint32_t val_be = osmo_htonl(val); - return msgb_tvlv_put(msg, tag, 4, (const uint8_t *)&val_be); -} - -/*! put (append) a vTvLV field to \ref msgb */ -static inline uint8_t *msgb_vtvlv_gan_put(struct msgb *msg, uint16_t tag, - uint16_t len, const uint8_t *val) -{ - uint8_t *buf = msgb_put(msg, VTVLV_GAN_GROSS_LEN(tag, len)); - return vtvlv_gan_put(buf, tag, len, val); -} - -/*! put (append) a L16TV field to \ref msgb */ -static inline uint8_t *msgb_l16tv_put(struct msgb *msg, uint16_t len, uint8_t tag, - const uint8_t *val) -{ - uint8_t *buf = msgb_put(msg, L16TV_GROSS_LEN(len)); - - *buf++ = len >> 8; - *buf++ = len & 0xff; - *buf++ = tag; - memcpy(buf, val, len); - return buf + len; -} - -/*! put (append) a V field */ -static inline uint8_t *v_put(uint8_t *buf, uint8_t val) -{ - *buf++ = val; - return buf; -} - -/*! put (append) a TV field */ -static inline uint8_t *tv_put(uint8_t *buf, uint8_t tag, - uint8_t val) -{ - *buf++ = tag; - *buf++ = val; - return buf; -} - -/*! put (append) a TVfixed field */ -static inline uint8_t *tv_fixed_put(uint8_t *buf, uint8_t tag, - unsigned int len, const uint8_t *val) -{ - *buf++ = tag; - memcpy(buf, val, len); - return buf + len; -} - -/*! put (append) a TV16 field - * \param[in,out] buf data buffer - * \param[in] tag Tag value - * \param[in] val Value (in host byte order!) - */ -static inline uint8_t *tv16_put(uint8_t *buf, uint8_t tag, - uint16_t val) -{ - *buf++ = tag; - *buf++ = val >> 8; - *buf++ = val & 0xff; - return buf; -} - -/*! put (append) a LV field to a \ref msgb - * \returns pointer to first byte after newly-put information */ -static inline uint8_t *msgb_lv_put(struct msgb *msg, uint8_t len, const uint8_t *val) -{ - uint8_t *buf = msgb_put(msg, LV_GROSS_LEN(len)); - return lv_put(buf, len, val); -} - -/*! put (append) a TLV field to a \ref msgb - * \returns pointer to first byte after newly-put information */ -static inline uint8_t *msgb_tlv_put(struct msgb *msg, uint8_t tag, uint8_t len, const uint8_t *val) -{ - uint8_t *buf = msgb_put(msg, TLV_GROSS_LEN(len)); - return tlv_put(buf, tag, len, val); -} - -/*! put (append) a TV field to a \ref msgb - * \returns pointer to first byte after newly-put information */ -static inline uint8_t *msgb_tv_put(struct msgb *msg, uint8_t tag, uint8_t val) -{ - uint8_t *buf = msgb_put(msg, 2); - return tv_put(buf, tag, val); -} - -/*! put (append) a TVfixed field to a \ref msgb - * \returns pointer to first byte after newly-put information */ -static inline uint8_t *msgb_tv_fixed_put(struct msgb *msg, uint8_t tag, - unsigned int len, const uint8_t *val) -{ - uint8_t *buf = msgb_put(msg, 1+len); - return tv_fixed_put(buf, tag, len, val); -} - -/*! put (append) a V field to a \ref msgb - * \returns pointer to first byte after newly-put information */ -static inline uint8_t *msgb_v_put(struct msgb *msg, uint8_t val) -{ - uint8_t *buf = msgb_put(msg, 1); - return v_put(buf, val); -} - -/*! put (append) a TL fields to a \ref msgb - * \returns pointer to the length field so it can be updated after adding new information under specified tag */ -static inline uint8_t *msgb_tl_put(struct msgb *msg, uint8_t tag) -{ - uint8_t *len = msgb_v_put(msg, tag); - - /* reserve space for length, len points to this reserved space already */ - msgb_v_put(msg, 0); - - return len; -} - -/*! put (append) a TV16 field (network order) to the given msgb - * \returns pointer to first byte after newly-put information */ -static inline uint8_t *msgb_tv16_put(struct msgb *msg, uint8_t tag, uint16_t val) -{ - uint8_t *buf = msgb_put(msg, 3); - return tv16_put(buf, tag, val); -} - -/*! put (append) a TV32 field (network order) to the given msgb - * \returns pointer to first byte after newly-put information */ -static inline uint8_t *msgb_tv32_put(struct msgb *msg, uint8_t tag, uint32_t val) -{ - uint8_t *buf = msgb_put(msg, 1 + 4); - *buf++ = tag; - osmo_store32be(val, buf); - return msg->tail; -} - -/*! push (prepend) a TLV field to a \ref msgb - * \returns pointer to first byte of newly-pushed information */ -static inline uint8_t *msgb_tlv_push(struct msgb *msg, uint8_t tag, uint8_t len, const uint8_t *val) -{ - uint8_t *buf = msgb_push(msg, TLV_GROSS_LEN(len)); - tlv_put(buf, tag, len, val); - return buf; -} - -/*! push 1-byte tagged value */ -static inline uint8_t *msgb_tlv1_push(struct msgb *msg, uint8_t tag, uint8_t val) -{ - return msgb_tlv_push(msg, tag, 1, &val); -} - -/*! push (prepend) a TV field to a \ref msgb - * \returns pointer to first byte of newly-pushed information */ -static inline uint8_t *msgb_tv_push(struct msgb *msg, uint8_t tag, uint8_t val) -{ - uint8_t *buf = msgb_push(msg, 2); - tv_put(buf, tag, val); - return buf; -} - -/*! push (prepend) a TV16 field to a \ref msgb - * \returns pointer to first byte of newly-pushed information */ -static inline uint8_t *msgb_tv16_push(struct msgb *msg, uint8_t tag, uint16_t val) -{ - uint8_t *buf = msgb_push(msg, 3); - tv16_put(buf, tag, val); - return buf; -} - -/*! push (prepend) a TvLV field to a \ref msgb - * \returns pointer to first byte of newly-pushed information */ -static inline uint8_t *msgb_tvlv_push(struct msgb *msg, uint8_t tag, uint16_t len, - const uint8_t *val) -{ - uint8_t *buf = msgb_push(msg, TVLV_GROSS_LEN(len)); - tvlv_put(buf, tag, len, val); - return buf; -} - -/* push (prepend) a vTvL header to a \ref msgb - */ -static inline uint8_t *msgb_vtvl_gan_push(struct msgb *msg, uint16_t tag, - uint16_t len) -{ - uint8_t *buf = msgb_push(msg, VTVL_GAN_GROSS_LEN(tag, len)); - vtvl_gan_put(buf, tag, len); - return buf; -} - - -static inline uint8_t *msgb_vtvlv_gan_push(struct msgb *msg, uint16_t tag, - uint16_t len, const uint8_t *val) -{ - uint8_t *buf = msgb_push(msg, VTVLV_GAN_GROSS_LEN(tag, len)); - vtvlv_gan_put(buf, tag, len, val); - return buf; -} - -/* TLV parsing */ - -/*! Entry in a TLV parser array */ -struct tlv_p_entry { - uint16_t len; /*!< length */ - const uint8_t *val; /*!< pointer to value */ -}; - -/*! TLV type */ -enum tlv_type { - TLV_TYPE_NONE, /*!< no type */ - TLV_TYPE_FIXED, /*!< fixed-length value-only */ - TLV_TYPE_T, /*!< tag-only */ - TLV_TYPE_TV, /*!< tag-value (8bit) */ - TLV_TYPE_TLV, /*!< tag-length-value */ - TLV_TYPE_TL16V, /*!< tag, 16 bit length, value */ - TLV_TYPE_TvLV, /*!< tag, variable length, value */ - TLV_TYPE_SINGLE_TV, /*!< tag and value (both 4 bit) in 1 byte */ - TLV_TYPE_vTvLV_GAN, /*!< variable-length tag, variable-length length */ -}; - -/*! Definition of a single IE (Information Element) */ -struct tlv_def { - enum tlv_type type; /*!< TLV type */ - uint8_t fixed_len; /*!< length in case of \ref TLV_TYPE_FIXED */ -}; - -/*! Definition of All 256 IE / TLV */ -struct tlv_definition { - struct tlv_def def[256]; -}; - -/*! result of the TLV parser */ -struct tlv_parsed { - struct tlv_p_entry lv[256]; -}; - -extern struct tlv_definition tvlv_att_def; -extern struct tlv_definition vtvlv_gan_att_def; - -int tlv_parse_one(uint8_t *o_tag, uint16_t *o_len, const uint8_t **o_val, - const struct tlv_definition *def, - const uint8_t *buf, int buf_len); -int tlv_parse(struct tlv_parsed *dec, const struct tlv_definition *def, - const uint8_t *buf, int buf_len, uint8_t lv_tag, uint8_t lv_tag2); -int tlv_parse2(struct tlv_parsed *dec, int dec_multiples, - const struct tlv_definition *def, const uint8_t *buf, int buf_len, - uint8_t lv_tag, uint8_t lv_tag2); -/* take a master (src) tlv def and fill up all empty slots in 'dst' */ -void tlv_def_patch(struct tlv_definition *dst, const struct tlv_definition *src); - -int tlv_encode_one(struct msgb *msg, enum tlv_type type, uint8_t tag, - unsigned int len, const uint8_t *val); -int tlv_encode(struct msgb *msg, const struct tlv_definition *def, const struct tlv_parsed *tp); -int tlv_encode_ordered(struct msgb *msg, const struct tlv_definition *def, const struct tlv_parsed *tp, - const uint8_t *tag_order, unsigned int tag_order_len); - -#define TLVP_PRESENT(x, y) ((x)->lv[y].val) -#define TLVP_LEN(x, y) (x)->lv[y].len -#define TLVP_VAL(x, y) (x)->lv[y].val - -#define TLVP_PRES_LEN(tp, tag, min_len) \ - (TLVP_PRESENT(tp, tag) && TLVP_LEN(tp, tag) >= min_len) - -/*! Return pointer to a TLV element if it is present. - * Usage: - * struct tlv_p_entry *e = TVLP_GET(&tp, TAG); - * if (!e) - * return -ENOENT; - * hexdump(e->val, e->len); - * \param[in] _tp pointer to \ref tlv_parsed. - * \param[in] tag IE tag to return. - * \returns struct tlv_p_entry pointer, or NULL if not present. - */ -#define TLVP_GET(_tp, tag) (TLVP_PRESENT(_tp, tag)? &(_tp)->lv[tag] : NULL) - -/*! Like TLVP_GET(), but enforcing a minimum val length. - * \param[in] _tp pointer to \ref tlv_parsed. - * \param[in] tag IE tag to return. - * \param[in] min_len Minimum value length in bytes. - * \returns struct tlv_p_entry pointer, or NULL if not present or too short. - */ -#define TLVP_GET_MINLEN(_tp, tag, min_len) \ - (TLVP_PRES_LEN(_tp, tag, min_len)? &(_tp)->lv[tag] : NULL) - -/*! Like TLVP_VAL(), but enforcing a minimum val length. - * \param[in] _tp pointer to \ref tlv_parsed. - * \param[in] tag IE tag to return. - * \param[in] min_len Minimum value length in bytes. - * \returns const uint8_t pointer to value, or NULL if not present or too short. - */ -#define TLVP_VAL_MINLEN(_tp, tag, min_len) \ - (TLVP_PRES_LEN(_tp, tag, min_len)? (_tp)->lv[tag].val : NULL) - - -/*! Obtain 1-byte TLV element. - * \param[in] tp pointer to \ref tlv_parsed - * \param[in] tag the Tag to look for - * \param[in] default_val default value to use if tag not available - * \returns the 1st byte of value with a given tag or default_val if tag was not found - */ -static inline uint8_t tlvp_val8(const struct tlv_parsed *tp, uint8_t tag, uint8_t default_val) -{ - const uint8_t *res = TLVP_VAL_MINLEN(tp, tag, 1); - - if (res) - return res[0]; - - return default_val; -} - -/*! Align given TLV element with 16 bit value to an even address - * \param[in] tp pointer to \ref tlv_parsed - * \param[in] pos element to return - * \returns aligned 16 bit value - */ -static inline uint16_t tlvp_val16_unal(const struct tlv_parsed *tp, int pos) -{ - uint16_t res; - memcpy(&res, TLVP_VAL(tp, pos), sizeof(res)); - return res; -} - -/*! Align given TLV element with 32 bit value to an address that is a multiple of 4 - * \param[in] tp pointer to \ref tlv_parsed - * \param[in] pos element to return - * \returns aligned 32 bit value - */ -static inline uint32_t tlvp_val32_unal(const struct tlv_parsed *tp, int pos) -{ - uint32_t res; - memcpy(&res, TLVP_VAL(tp, pos), sizeof(res)); - return res; -} - -/*! Retrieve (possibly unaligned) TLV element and convert to host byte order - * \param[in] tp pointer to \ref tlv_parsed - * \param[in] pos element to return - * \returns aligned 16 bit value in host byte order - */ -static inline uint16_t tlvp_val16be(const struct tlv_parsed *tp, int pos) -{ - return osmo_load16be(TLVP_VAL(tp, pos)); -} - -/*! Retrieve (possibly unaligned) TLV element and convert to host byte order - * \param[in] tp pointer to \ref tlv_parsed - * \param[in] pos element to return - * \returns aligned 32 bit value in host byte order - */ -static inline uint32_t tlvp_val32be(const struct tlv_parsed *tp, int pos) -{ - return osmo_load32be(TLVP_VAL(tp, pos)); -} - - -struct tlv_parsed *osmo_tlvp_copy(const struct tlv_parsed *tp_orig, void *ctx); -int osmo_tlvp_merge(struct tlv_parsed *dst, const struct tlv_parsed *src); -int osmo_shift_v_fixed(uint8_t **data, size_t *data_len, - size_t len, uint8_t **value); -int osmo_match_shift_tv_fixed(uint8_t **data, size_t *data_len, - uint8_t tag, size_t len, uint8_t **value); -int osmo_shift_tlv(uint8_t **data, size_t *data_len, - uint8_t *tag, uint8_t **value, size_t *value_len); -int osmo_match_shift_tlv(uint8_t **data, size_t *data_len, - uint8_t tag, uint8_t **value, size_t *value_len); -int osmo_shift_lv(uint8_t **data, size_t *data_len, - uint8_t **value, size_t *value_len); - -#define MSG_DEF(name, mand_ies, flags) { name, mand_ies, ARRAY_SIZE(mand_ies), flags } - -struct osmo_tlv_prot_msg_def { - /*! human-readable name of message type (optional) */ - const char *name; - /*! array of mandatory IEs */ - const uint8_t *mand_ies; - /*! number of entries in 'mand_ies' above */ - uint8_t mand_count; - /*! user-defined flags (like uplink/downlink/...) */ - uint32_t flags; -}; -struct osmo_tlv_prot_ie_def { - /*! minimum length of IE value part, in octets */ - uint16_t min_len; - /*! huamn-readable name (optional) */ - const char *name; -}; - -/*! Osmocom TLV protocol definition */ -struct osmo_tlv_prot_def { - /*! human-readable name of protocol */ - const char *name; - /*! TLV parser definition (optional) */ - const struct tlv_definition *tlv_def; - /*! definition of each message (8-bit message type) */ - struct osmo_tlv_prot_msg_def msg_def[256]; - /*! definition of IE for each 8-bit tag */ - struct osmo_tlv_prot_ie_def ie_def[256]; - /*! value_string array of message type names (legacy, if not populated in msg_def) */ - const struct value_string *msgt_names; -}; - -const char *osmo_tlv_prot_msg_name(const struct osmo_tlv_prot_def *pdef, uint8_t msg_type); -const char *osmo_tlv_prot_ie_name(const struct osmo_tlv_prot_def *pdef, uint8_t iei); - -int osmo_tlv_prot_validate_tp(const struct osmo_tlv_prot_def *pdef, uint8_t msg_type, - const struct tlv_parsed *tp, int log_subsys, const char *log_pfx); - -int osmo_tlv_prot_parse(const struct osmo_tlv_prot_def *pdef, - struct tlv_parsed *dec, unsigned int dec_multiples, uint8_t msg_type, - const uint8_t *buf, unsigned int buf_len, uint8_t lv_tag, uint8_t lv_tag2, - int log_subsys, const char *log_pfx); - -static inline uint32_t osmo_tlv_prot_msgt_flags(const struct osmo_tlv_prot_def *pdef, uint8_t msg_type) -{ - return pdef->msg_def[msg_type].flags; -} - - -/*! @} */ +#include diff --git a/src/Makefile.am b/src/Makefile.am index 4bda456..953b53b 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -33,6 +33,7 @@ it_q.c \ probes.d \ base64.c \ + tlv_parser.c \ $(NULL) if HAVE_SSSE3 diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am index 580e397..8b19a5e 100644 --- a/src/gsm/Makefile.am +++ b/src/gsm/Makefile.am @@ -20,7 +20,7 @@ BUILT_SOURCES = gsm0503_conv.c -libgsmint_la_SOURCES = a5.c rxlev_stat.c tlv_parser.c comp128.c comp128v23.c \ +libgsmint_la_SOURCES = a5.c rxlev_stat.c comp128.c comp128v23.c \ gsm_utils.c rsl.c gsm48.c gsm48_arfcn_range_encode.c \ gsm48_ie.c gsm0808.c sysinfo.c \ gprs_cipher_core.c gprs_rlc.c gsm0480.c abis_nm.c gsm0502.c \ diff --git a/src/gsm/tlv_parser.c b/src/tlv_parser.c similarity index 100% rename from src/gsm/tlv_parser.c rename to src/tlv_parser.c diff --git a/tests/Makefile.am b/tests/Makefile.am index a6f6017..176532e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -240,7 +240,7 @@ $(top_builddir)/src/gsm/libosmogsm.la tlv_tlv_test_SOURCES = tlv/tlv_test.c -tlv_tlv_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la +tlv_tlv_test_LDADD = $(LDADD) gsup_gsup_test_SOURCES = gsup/gsup_test.c gsup_gsup_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la diff --git a/tests/tlv/tlv_test.c b/tests/tlv/tlv_test.c index fdd15ab..f30f635 100644 --- a/tests/tlv/tlv_test.c +++ b/tests/tlv/tlv_test.c @@ -288,6 +288,14 @@ OSMO_ASSERT(dec3[2].lv[tag].val == &test_data[2 + 3 + 3]); } +static const struct tlv_definition test_tlvdef = { + .def = { + [0x17] = { TLV_TYPE_TLV }, + [0x2c] = { TLV_TYPE_TV }, + [0x40] = { TLV_TYPE_TV }, + }, +}; + static void test_tlv_encoder() { const uint8_t enc_ies[] = { @@ -312,11 +320,11 @@ OSMO_ASSERT(msg); /* decode BSSAP IEs specified above */ - rc = osmo_bssap_tlv_parse(&tp, enc_ies, ARRAY_SIZE(enc_ies)); + rc = tlv_parse(&tp, &test_tlvdef, enc_ies, ARRAY_SIZE(enc_ies), 0, 0); OSMO_ASSERT(rc == 3); /* re-encode it */ - rc = tlv_encode(msg, gsm0808_att_tlvdef(), &tp); + rc = tlv_encode(msg, &test_tlvdef, &tp); OSMO_ASSERT(rc == ARRAY_SIZE(enc_ies)); OSMO_ASSERT(!memcmp(msgb_data(msg), enc_ies, ARRAY_SIZE(enc_ies))); @@ -325,7 +333,7 @@ printf("Testing TLV encoder with IE ordering\n"); /* re-encodei in different order */ - rc = tlv_encode_ordered(msg, gsm0808_att_tlvdef(), &tp, ie_order, ARRAY_SIZE(ie_order)); + rc = tlv_encode_ordered(msg, &test_tlvdef, &tp, ie_order, ARRAY_SIZE(ie_order)); OSMO_ASSERT(rc == ARRAY_SIZE(enc_ies)); OSMO_ASSERT(!memcmp(msgb_data(msg), enc_ies_reordered, ARRAY_SIZE(enc_ies_reordered))); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cda0143af9eaf90dc73f9deccd651117fdf8845 Gerrit-Change-Number: 26459 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 15:43:30 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 7 Dec 2021 15:43:30 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26460 ) Change subject: libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() ...................................................................... libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() Function msc_i_ran_enc() calls msc_role_ran_encode(), but unlike the other callers of this function it does not free() the encoded message. A simple solution would be to call msgb_free(), like it's done in the other places. But a more elegant solution is to modify function msc_role_ran_encode(), so that it attaches the msgb to OTC_SELECT. This way there is no need to call msgb_free() here and there. This change fixes a memleak observed while running ttcn3-msc-test. Change-Id: I741e082badc32ba9a97c1495c894e1d22e122e3a Related: OS#5340 --- M src/libmsc/msc_a.c M src/libmsc/msc_a_remote.c M src/libmsc/msc_t.c M src/libmsc/msub.c 4 files changed, 7 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/60/26460/1 diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index 74721d2..c9b0572 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -1659,12 +1659,9 @@ .an_proto = msc_a->c.ran->an_proto, .msg = msc_role_ran_encode(msc_a->c.fi, ran_msg), }; - int rc; if (!an_apdu.msg) return -EIO; - rc = _msub_role_dispatch(msc_a->c.msub, to_role, to_role_event, &an_apdu, file, line); - msgb_free(an_apdu.msg); - return rc; + return _msub_role_dispatch(msc_a->c.msub, to_role, to_role_event, &an_apdu, file, line); } int msc_a_tx_dtap_to_i(struct msc_a *msc_a, struct msgb *dtap) diff --git a/src/libmsc/msc_a_remote.c b/src/libmsc/msc_a_remote.c index 84eff07..e4474f4 100644 --- a/src/libmsc/msc_a_remote.c +++ b/src/libmsc/msc_a_remote.c @@ -179,8 +179,6 @@ return; msc_a_remote_msg_up_to_remote_msc(msc_a, MSC_ROLE_T, OSMO_GSUP_MSGT_E_PREPARE_HANDOVER_ERROR, &an_apdu); - msgb_free(an_apdu.msg); - return; } /* [MSC-A---------------------] [MSC-B---------------------] diff --git a/src/libmsc/msc_t.c b/src/libmsc/msc_t.c index af0ddaa..43bc74e 100644 --- a/src/libmsc/msc_t.c +++ b/src/libmsc/msc_t.c @@ -145,7 +145,6 @@ return; msub_role_dispatch(msc_t->c.msub, MSC_ROLE_A, MSC_A_EV_FROM_T_PREPARE_HANDOVER_FAILURE, &an_apdu); - msgb_free(an_apdu.msg); } static int msc_t_ho_request_decode_and_store_cb(struct osmo_fsm_inst *msc_t_fi, void *data, @@ -238,7 +237,6 @@ static int msc_t_send_stored_ho_request__decode_cb(struct osmo_fsm_inst *msc_t_fi, void *data, const struct ran_msg *ran_dec) { - int rc; struct an_apdu an_apdu; struct msc_t *msc_t = msc_t_priv(msc_t_fi); struct osmo_sockaddr_str *rtp_ran_local = data; @@ -263,9 +261,7 @@ }; if (!an_apdu.msg) return -EIO; - rc = msc_t_down_l2_co(msc_t, &an_apdu, true); - msgb_free(an_apdu.msg); - return rc; + return msc_t_down_l2_co(msc_t, &an_apdu, true); } /* The MGW endpoint is created, we know our AoIP Transport Layer Address and can send the Handover Request to the RAN @@ -472,9 +468,7 @@ if (!an_apdu.msg) return -EIO; /* Send to remote MSC via msc_a_remote role */ - rc = msub_role_dispatch(msc_t->c.msub, MSC_ROLE_A, MSC_A_EV_FROM_T_PREPARE_HANDOVER_RESPONSE, &an_apdu); - msgb_free(an_apdu.msg); - return rc; + return msub_role_dispatch(msc_t->c.msub, MSC_ROLE_A, MSC_A_EV_FROM_T_PREPARE_HANDOVER_RESPONSE, &an_apdu); } static int msc_t_wait_ho_request_ack_decode_cb(struct osmo_fsm_inst *msc_t_fi, void *data, diff --git a/src/libmsc/msub.c b/src/libmsc/msub.c index 112703a..e4dd332 100644 --- a/src/libmsc/msub.c +++ b/src/libmsc/msub.c @@ -544,6 +544,8 @@ *conn_p = NULL; } +/* NOTE: the resulting message buffer will be attached to OTC_SELECT, so its lifetime + * is limited by the current select() loop iteration. Use talloc_steal() to avoid this. */ struct msgb *msc_role_ran_encode(struct osmo_fsm_inst *fi, const struct ran_msg *ran_msg) { struct msc_role_common *c = fi->priv; @@ -556,6 +558,8 @@ msg = c->ran->ran_encode(fi, ran_msg); if (!msg) LOGPFSML(fi, LOGL_ERROR, "Failed to encode %s\n", ran_msg_type_name(ran_msg->msg_type)); + else + talloc_steal(OTC_SELECT, msg); return msg; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I741e082badc32ba9a97c1495c894e1d22e122e3a Gerrit-Change-Number: 26460 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 15:47:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 7 Dec 2021 15:47:39 +0000 Subject: Change in libosmocore[master]: move tlv.h, tlv_parser.c from libosmogsm to libosmocore In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26459 ) Change subject: move tlv.h, tlv_parser.c from libosmogsm to libosmocore ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cda0143af9eaf90dc73f9deccd651117fdf8845 Gerrit-Change-Number: 26459 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Tue, 07 Dec 2021 15:47:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 16:33:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 7 Dec 2021 16:33:32 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: do not pass UEA0 to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: fixeria has uploaded a new patch set (#4) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: do not pass UEA0 to ranap_new_msg_sec_mod_cmd2() ...................................................................... ran_msg_iu: do not pass UEA0 to ranap_new_msg_sec_mod_cmd2() On the protocol level, it's impossible to indicate UEA0 together with the other algorithms. The encryption is either a) disabled, so the Encryption Information IE is not present, or b) enabled, so the Encryption Information IE indicates UEA1 and/or UEA2. Because of that, the ranap_new_msg_sec_mod_cmd2() would fail to generate the RANAP PDU if the given bitmask has the UEA0 bit set. Fixes: 505a94a610fc ("Make UTRAN encryption algorithms configurable") Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e --- M src/libmsc/ran_msg_iu.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/91/26391/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 16:36:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 7 Dec 2021 16:36:26 +0000 Subject: Change in libosmocore[master]: VTY: enable talloc introspection for OTC_GLOBAL References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26461 ) Change subject: VTY: enable talloc introspection for OTC_GLOBAL ...................................................................... VTY: enable talloc introspection for OTC_GLOBAL Change-Id: I831722174ecbac7f2d53f2427ba7e2615fa28c8a --- M src/vty/talloc_ctx_vty.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/26461/1 diff --git a/src/vty/talloc_ctx_vty.c b/src/vty/talloc_ctx_vty.c index 3966478..2900409 100644 --- a/src/vty/talloc_ctx_vty.c +++ b/src/vty/talloc_ctx_vty.c @@ -151,6 +151,8 @@ /* Determine a context for report */ if (!strncmp(ctx, "app", 3)) talloc_ctx = host.app_info->tall_ctx; + else if (!strcmp(ctx, "global")) + talloc_ctx = OTC_GLOBAL; else if (!strncmp(ctx, "all", 3)) talloc_ctx = NULL; @@ -167,11 +169,12 @@ } #define BASE_CMD_STR \ - "show talloc-context (application|all) (full|brief|DEPTH)" + "show talloc-context (application|global|all) (full|brief|DEPTH)" #define BASE_CMD_DESCR \ SHOW_STR "Show talloc memory hierarchy\n" \ "Application's context\n" \ + "Global context (OTC_GLOBAL)" \ "All contexts, if NULL-context tracking is enabled\n" \ "Display a full talloc memory hierarchy\n" \ "Display a brief talloc memory hierarchy\n" \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26461 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I831722174ecbac7f2d53f2427ba7e2615fa28c8a Gerrit-Change-Number: 26461 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 16:39:25 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 7 Dec 2021 16:39:25 +0000 Subject: Change in osmo-sgsn[master]: llme_free: clean up related sndcp References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26462 ) Change subject: llme_free: clean up related sndcp ...................................................................... llme_free: clean up related sndcp Fix crash in vty_dump_sne when sndcp->lle has already been deallocated. Context: * sndcp->lle is set only once in gprs_sndcp_entity_alloc() * sndcp->lle is a struct gprs_llc_lle, which gets allocated and deallocated together with struct gprs_llc_llme. From gprs_llc.h: struct gprs_llc_llme { ... struct gprs_llc_lle lle[NUM_SAPIS]; Fixes: OS#4824 Change-Id: I707029f78222bc6335837241e5a08c54c5ae6eb3 --- M include/osmocom/sgsn/gprs_sndcp.h M src/sgsn/gprs_llc.c M src/sgsn/gprs_sndcp.c 3 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/62/26462/1 diff --git a/include/osmocom/sgsn/gprs_sndcp.h b/include/osmocom/sgsn/gprs_sndcp.h index d970240..5334d92 100644 --- a/include/osmocom/sgsn/gprs_sndcp.h +++ b/include/osmocom/sgsn/gprs_sndcp.h @@ -76,4 +76,7 @@ struct gprs_llc_xid_field *xid_field_request, struct gprs_llc_lle *lle); +/* Clean up all gprs_sndcp_entities related to llme (OS#4824) */ +void gprs_sndcp_sm_deactivate_ind_by_llme(struct gprs_llc_llme *llme); + #endif /* INT_SNDCP_H */ diff --git a/src/sgsn/gprs_llc.c b/src/sgsn/gprs_llc.c index eea1cec..453ded5 100644 --- a/src/sgsn/gprs_llc.c +++ b/src/sgsn/gprs_llc.c @@ -590,6 +590,7 @@ static void llme_free(struct gprs_llc_llme *llme) { + gprs_sndcp_sm_deactivate_ind_by_llme(llme); gprs_sndcp_comp_free(llme->comp.proto); gprs_sndcp_comp_free(llme->comp.data); llist_del(&llme->list); diff --git a/src/sgsn/gprs_sndcp.c b/src/sgsn/gprs_sndcp.c index 6692f1a..d8982ac 100644 --- a/src/sgsn/gprs_sndcp.c +++ b/src/sgsn/gprs_sndcp.c @@ -544,6 +544,20 @@ return 0; } +/* Clean up all gprs_sndcp_entities related to llme (OS#4824) */ +void gprs_sndcp_sm_deactivate_ind_by_llme(struct gprs_llc_llme *llme) +{ + struct gprs_sndcp_entity *sne, *sne2; + + llist_for_each_entry_safe(sne, sne2, &gprs_sndcp_entities, list) { + if (sne->lle->llme == llme) { + LOGP(DSNDCP, LOGL_INFO, "SNSM-DEACTIVATE.ind for SNDCP attached to llme=%p\n", llme); + /* Free and remove from list */ + sndcp_sm_deactivate_ind(sne->lle, sne->nsapi); + } + } +} + /* Fragmenter state */ struct sndcp_frag_state { uint8_t frag_nr; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26462 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I707029f78222bc6335837241e5a08c54c5ae6eb3 Gerrit-Change-Number: 26462 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 16:46:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 7 Dec 2021 16:46:17 +0000 Subject: Change in libosmocore[master]: VTY: enable talloc introspection for OTC_GLOBAL In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26461 to look at the new patch set (#2). Change subject: VTY: enable talloc introspection for OTC_GLOBAL ...................................................................... VTY: enable talloc introspection for OTC_GLOBAL Change-Id: I831722174ecbac7f2d53f2427ba7e2615fa28c8a --- M src/vty/talloc_ctx_vty.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/26461/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26461 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I831722174ecbac7f2d53f2427ba7e2615fa28c8a Gerrit-Change-Number: 26461 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 17:40:56 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 7 Dec 2021 17:40:56 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26460 ) Change subject: libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26460/1/src/libmsc/msub.c File src/libmsc/msub.c: https://gerrit.osmocom.org/c/osmo-msc/+/26460/1/src/libmsc/msub.c at 548 PS1, Line 548: ws -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I741e082badc32ba9a97c1495c894e1d22e122e3a Gerrit-Change-Number: 26460 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Comment-Date: Tue, 07 Dec 2021 17:40:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 17:42:36 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 7 Dec 2021 17:42:36 +0000 Subject: Change in libosmocore[master]: move tlv.h, tlv_parser.c from libosmogsm to libosmocore In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26459 ) Change subject: move tlv.h, tlv_parser.c from libosmogsm to libosmocore ...................................................................... Patch Set 1: linter doesn't like our old tlv.h But another thing: turns out that PFCP has 16 bit tags, so tlv.h as it is won't be useful for PFCP at all. We can still move this to libosmocore, but it won't help much for PFCP in osmo-ufp. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cda0143af9eaf90dc73f9deccd651117fdf8845 Gerrit-Change-Number: 26459 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Tue, 07 Dec 2021 17:42:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 17:51:44 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 7 Dec 2021 17:51:44 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... firmware: add crc stub to all dfu apps to ensure reliable loading DFU flashing of apps sometimes aborts, and although rare this leads to broken devices if no boot button or serial/jtag access exists, because the bootloader will keep trying to start a half-flashed app that then crashes at some point. The easiest fix that works with existing bootloaders is to prepend a small 512 byte stub that calculcates the crc and compares it with the crc calculated at build time, and then either starts the actual app, or sets the dfu flag and resets. This ensures we either have a working, running app, or end up in the bootloader, ready to flash again. For obvious reasons this only applies to dfu apps, and not to flash targets like the actual bootloader itself. Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f --- M firmware/Makefile M firmware/apps/blupdate/main.c M firmware/libboard/common/resources/sam3s4/dfu.ld M firmware/libboard/common/resources/sam3s4/flash.ld A firmware/libcommon/source/crcstub.c A firmware/misc/crctool A firmware/misc/crctool.c 7 files changed, 215 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/63/26463/1 diff --git a/firmware/Makefile b/firmware/Makefile index c30dc9a..8464a3b 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -117,7 +117,7 @@ C_LIBUSB_RT = dfu.c dfu_runtime.c C_LIBUSB_DFU = dfu.c dfu_desc.c dfu_driver.c C_LIBCOMMON = string.c stdio.c fputs.c usb_buf.c ringbuffer.c pseudo_talloc.c host_communication.c \ - main_common.c stack_check.c + main_common.c stack_check.c crcstub.c C_BOARD = $(notdir $(wildcard libboard/common/source/*.c)) C_BOARD += $(notdir $(wildcard libboard/$(BOARD)/source/*.c)) @@ -235,11 +235,14 @@ usbstring/usbstring: usbstring/usbstring.c gcc $^ -o $@ +misc/crctool: misc/crctool.c + gcc $^ -o $@ + .PHONY: apps/$(APP)/usb_strings.txt.patched apps/$(APP)/usb_strings.txt.patched: apps/$(APP)/usb_strings.txt sed "s/PRODUCT_STRING/$(shell cat libboard/$(BOARD)/product_string.txt)/" $< > $@ -apps/$(APP)/usb_strings_generated.h: apps/$(APP)/usb_strings.txt.patched usbstring/usbstring +apps/$(APP)/usb_strings_generated.h: apps/$(APP)/usb_strings.txt.patched usbstring/usbstring misc/crctool cat $< | usbstring/usbstring > $@ define RULES @@ -281,6 +284,8 @@ $(SILENT)$(OBJCOPY) --update-section .blupdate=bin/$(BOARD)-dfu-flash-padded.bin bin/$(BOARD)-blupdate-dfu.elf $(SILENT)$(OBJCOPY) -O binary bin/$(BOARD)-blupdate-dfu.elf bin/$(BOARD)-blupdate-dfu.bin endif + $(info updating app with crc..) + misc/crctool 512 bin/$(BOARD)-$(APP)-dfu.bin flash: build_flash #alternate way of embedding: obj file #ifeq ($(APP), dfu) diff --git a/firmware/apps/blupdate/main.c b/firmware/apps/blupdate/main.c index 330d040..3c8e67d 100644 --- a/firmware/apps/blupdate/main.c +++ b/firmware/apps/blupdate/main.c @@ -93,8 +93,14 @@ flash_cmd(EFC_FCMD_EA, 0); #endif flash_wait_ready(); - for (;;) - NVIC_SystemReset(); + for (;;) { + /* no functon call, since NVIC_SystemReset() might not be inlined! */ + SCB->AIRCR = ((0x5FA << SCB_AIRCR_VECTKEY_Pos) | (SCB->AIRCR & SCB_AIRCR_PRIGROUP_Msk) | + SCB_AIRCR_SYSRESETREQ_Msk); + __DSB(); + while (1) + ; + } } #define MAX_USB_ITER BOARD_MCK / 72 // This should be around a second diff --git a/firmware/libboard/common/resources/sam3s4/dfu.ld b/firmware/libboard/common/resources/sam3s4/dfu.ld index 7d896c6..86e6622 100644 --- a/firmware/libboard/common/resources/sam3s4/dfu.ld +++ b/firmware/libboard/common/resources/sam3s4/dfu.ld @@ -39,7 +39,8 @@ MEMORY { /* reserve the first 16k (= 0x4000) for the DFU bootloader */ - rom (rx) : ORIGIN = 0x00400000 + 16K, LENGTH = 256K - 16K /* flash, 256K */ + crcstub (rx) : ORIGIN = 0x00400000 + 16K, LENGTH = 512 /* crcstub part */ + rom (rx) : ORIGIN = 0x00400000 + 16K + 512, LENGTH = 256K - 16K - 512 /* flash, 256K */ /* note: dfudata will be at the start */ ram (rwx) : ORIGIN = 0x20000000, LENGTH = 48K /* SRAM, 48K */ } @@ -47,9 +48,17 @@ /* Section Definitions */ SECTIONS { - .text : - { + .crcstub : + { . = ALIGN(4); + KEEP(*(.crcstub_table)) + KEEP(*(.crcstub_code)) + } > crcstub = 0xff + + .text : + { + + . = ALIGN(512); _sfixed = .; KEEP(*(.vectors .vectors.*)) *(.text .text.* .gnu.linkonce.t.*) @@ -94,7 +103,7 @@ . = ALIGN(4); _efixed = .; /* End of text section */ - } > rom + } > rom = 0xff /DISCARD/ : { diff --git a/firmware/libboard/common/resources/sam3s4/flash.ld b/firmware/libboard/common/resources/sam3s4/flash.ld index 50631c6..b1de154 100644 --- a/firmware/libboard/common/resources/sam3s4/flash.ld +++ b/firmware/libboard/common/resources/sam3s4/flash.ld @@ -97,6 +97,8 @@ /DISCARD/ : { *(.ARM.exidx) + *(.crcstub_table) + *(.crcstub_code) } . = ALIGN(4); diff --git a/firmware/libcommon/source/crcstub.c b/firmware/libcommon/source/crcstub.c new file mode 100644 index 0000000..b13661b --- /dev/null +++ b/firmware/libcommon/source/crcstub.c @@ -0,0 +1,90 @@ +/* SIMtrace 2 firmware crc stub + * + * (C) 2021 by sysmocom -s.f.m.c. GmbH, Author: Eric Wild + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ + +#include +#include "board.h" +#include "core_cm3.h" +#include "usb/device/dfu/dfu.h" + +/* +* This file is a bit special, everything has to go to specific sections, and no globals are available. +* No external functions may be called, unless inlining is enforced! +*/ + +static void crc_check_stub(); +__attribute__((section(".crcstub_table"))) volatile uint32_t crcstub_dummy_table[] = { + (uint32_t)0xdeadc0de, /* deliberately choose invalid value so unpatched image will not be started */ + (uint32_t)crc_check_stub, /* must be valid flash addr */ + (uint32_t)0xf1, /* crc value calculated by the host */ + (uint32_t)0xf2, /* crc calc start address */ + (uint32_t)0xf3 /* crc calc length (byte) */ +}; + +__attribute__((section(".crcstub_code"))) static void do_crc32(int8_t c, uint32_t *crc_reg) +{ + int32_t i, mask; + *crc_reg ^= c; + + for (unsigned int j = 0; j < 8; j++) + if (*crc_reg & 1) + *crc_reg = (*crc_reg >> 1) ^ 0xEDB88320; + else + *crc_reg = *crc_reg >> 1; +} + +__attribute__((section(".crcstub_code"), noinline)) static void crc_check_stub() +{ + uint32_t crc_reg = 0xffffffff; + uint32_t expected_crc_val = crcstub_dummy_table[2]; + uint8_t *crc_calc_startaddr = (uint8_t *)crcstub_dummy_table[3]; + volatile uint32_t *actual_exc_tbl = (volatile uint32_t *)crc_calc_startaddr; + uint32_t crc_len = crcstub_dummy_table[4]; + + /* 4000ms wdt tickling */ + WDT->WDT_MR = WDT_MR_WDRSTEN | WDT_MR_WDDBGHLT | WDT_MR_WDIDLEHLT | (((4000UL << 8) / 1000) << 16) | + ((4000UL << 8) / 1000); + + for (uint8_t *i = crc_calc_startaddr; i < crc_calc_startaddr + crc_len; i++) + do_crc32(*i, &crc_reg); + + crc_reg = ~crc_reg; + + if (crc_reg == expected_crc_val) { + /* this looks a bit awkward because we have to ensure the bx does not require a sp-relative load */ + __asm__ volatile("\ + mov r0, %0;\n\ + mov r1, %1;\n\ + MSR msp,r0;\n\ + bx r1;" + : + : "r"(actual_exc_tbl[0]), "r"(actual_exc_tbl[1])); + } else { + /* no globals ! */ + ((struct dfudata *)0x20000000)->magic = USB_DFU_MAGIC; + __DSB(); + for (;;) { + /* no functon call, since NVIC_SystemReset() might not be inlined! */ + SCB->AIRCR = ((0x5FA << SCB_AIRCR_VECTKEY_Pos) | (SCB->AIRCR & SCB_AIRCR_PRIGROUP_Msk) | + SCB_AIRCR_SYSRESETREQ_Msk); + __DSB(); + while (1) + ; + } + } +} diff --git a/firmware/misc/crctool b/firmware/misc/crctool new file mode 100755 index 0000000..07f9592 --- /dev/null +++ b/firmware/misc/crctool Binary files differ diff --git a/firmware/misc/crctool.c b/firmware/misc/crctool.c new file mode 100644 index 0000000..41ad3cf --- /dev/null +++ b/firmware/misc/crctool.c @@ -0,0 +1,95 @@ +/* SIMtrace 2 firmware crc tool + * + * (C) 2021 by sysmocom -s.f.m.c. GmbH, Author: Eric Wild + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ + +#include +#include +#include + +static void do_crc32(int8_t c, uint32_t *crc_reg) +{ + int32_t i, mask; + *crc_reg ^= c; + + for (unsigned int j = 0; j < 8; j++) + if (*crc_reg & 1) + *crc_reg = (*crc_reg >> 1) ^ 0xEDB88320; + else + *crc_reg = *crc_reg >> 1; +} + +int main(int argc, char *argv[]) +{ + uint32_t crc_reg = 0xffffffff; + long fsize; + uint8_t *buffer; + uint32_t crc_start_offset; + + if (argc < 3) { + perror("usage: crctool startoffset blupdate.bin"); + return -1; + } + + crc_start_offset = strtoull(argv[1], 0, 10); + + FILE *blfile = fopen(argv[2], "rb+"); + if (blfile == NULL) { + perror("error opening file!"); + return -1; + } + + fseek(blfile, 0, SEEK_END); + fsize = ftell(blfile); + + if (fsize <= crc_start_offset) { + perror("file size?!"); + return -1; + } + + fseek(blfile, 0, SEEK_SET); + + buffer = malloc(fsize); + fread(buffer, 1, fsize, blfile); + + if (*(uint32_t *)buffer != 0xdeadc0de) { + perror("weird magic, not a valid blupdate file?"); + free(buffer); + return -1; + } + + uint8_t *startaddr = buffer + crc_start_offset; + uint8_t *endaddr = buffer + fsize; + for (uint8_t *i = startaddr; i < endaddr; i++) { + do_crc32(*i, &crc_reg); + } + crc_reg = ~crc_reg; + + fprintf(stderr, "len: %ld crc: %.8x\n", fsize - crc_start_offset, crc_reg); + + ((uint32_t *)buffer)[0] = 0x2000baa0; /* fix magic to valid stack address, checked by BL */ + ((uint32_t *)buffer)[2] = crc_reg; + ((uint32_t *)buffer)[3] = 0x00400000 + 0x4000 + crc_start_offset; + ((uint32_t *)buffer)[4] = fsize - crc_start_offset; + + fseek(blfile, 0, SEEK_SET); + fwrite(buffer, 4, 5, blfile); + + fclose(blfile); + free(buffer); + return 0; +} -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 17:58:13 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 7 Dec 2021 17:58:13 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hoernchen has removed tsaitgaist from this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Removed reviewer tsaitgaist. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: deleteReviewer -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 17:59:20 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 7 Dec 2021 17:59:20 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/26463 to look at the new patch set (#2). Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... firmware: add crc stub to all dfu apps to ensure reliable loading DFU flashing of apps sometimes aborts, and although rare this leads to broken devices if no boot button or serial/jtag access exists, because the bootloader will keep trying to start a half-flashed app that then crashes at some point. The easiest fix that works with existing bootloaders is to prepend a small 512 byte stub that calculcates the crc and compares it with the crc calculated at build time, and then either starts the actual app, or sets the dfu flag and resets. This ensures we either have a working, running app, or end up in the bootloader, ready to flash again. For obvious reasons this only applies to dfu apps, and not to flash targets like the actual bootloader itself. Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f --- M firmware/Makefile M firmware/apps/blupdate/main.c M firmware/libboard/common/resources/sam3s4/dfu.ld M firmware/libboard/common/resources/sam3s4/flash.ld A firmware/libcommon/source/crcstub.c A firmware/misc/crctool.c 6 files changed, 215 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/63/26463/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 17:59:36 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 7 Dec 2021 17:59:36 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hoernchen has removed tsaitgaist from this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Removed reviewer tsaitgaist. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: deleteReviewer -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 18:13:46 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 7 Dec 2021 18:13:46 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Test BVC bringup with conflicting BVCs In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26452 ) Change subject: gbproxy: Test BVC bringup with conflicting BVCs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I46eb0205b4c86b5f1bdc241ef0b2e12135c028e4 Gerrit-Change-Number: 26452 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 07 Dec 2021 18:13:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 18:40:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 7 Dec 2021 18:40:07 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26460 ) Change subject: libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26460/1/src/libmsc/msub.c File src/libmsc/msub.c: https://gerrit.osmocom.org/c/osmo-msc/+/26460/1/src/libmsc/msub.c at 548 PS1, Line 548: > ws I got a habit to use two spaces between sentences, like in man-pages... -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I741e082badc32ba9a97c1495c894e1d22e122e3a Gerrit-Change-Number: 26460 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Comment-Date: Tue, 07 Dec 2021 18:40:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 19:32:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 19:32:50 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26460 ) Change subject: libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/26460/1/src/libmsc/msub.c File src/libmsc/msub.c: https://gerrit.osmocom.org/c/osmo-msc/+/26460/1/src/libmsc/msub.c at 548 PS1, Line 548: > I got a habit to use two spaces between sentences, like in man-pages... I also typically do this everywhere. Picked that up in usenet ages ago. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I741e082badc32ba9a97c1495c894e1d22e122e3a Gerrit-Change-Number: 26460 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Tue, 07 Dec 2021 19:32:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 19:36:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 7 Dec 2021 19:36:00 +0000 Subject: Change in libosmocore[master]: move tlv.h, tlv_parser.c from libosmogsm to libosmocore In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26459 ) Change subject: move tlv.h, tlv_parser.c from libosmogsm to libosmocore ...................................................................... Patch Set 1: > Patch Set 1: > > linter doesn't like our old tlv.h > > But another thing: turns out that PFCP has 16 bit tags, so tlv.h as it is won't be useful for PFCP at all. you might be able to generalize the xua_msg code from libosmo-sigtran. The M3UA/SUA/... messages have 16bit tags, and the parser builds dynamically-allocated linked-list representations of the messages, which also supports repeated tags, ... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cda0143af9eaf90dc73f9deccd651117fdf8845 Gerrit-Change-Number: 26459 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Tue, 07 Dec 2021 19:36:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 20:43:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 7 Dec 2021 20:43:26 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26460 ) Change subject: libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I741e082badc32ba9a97c1495c894e1d22e122e3a Gerrit-Change-Number: 26460 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Tue, 07 Dec 2021 20:43:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 20:43:31 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 7 Dec 2021 20:43:31 +0000 Subject: Change in osmo-msc[master]: libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26460 ) Change subject: libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() ...................................................................... libmsc: fix memory leak (struct msgb) in msc_i_ran_enc() Function msc_i_ran_enc() calls msc_role_ran_encode(), but unlike the other callers of this function it does not free() the encoded message. A simple solution would be to call msgb_free(), like it's done in the other places. But a more elegant solution is to modify function msc_role_ran_encode(), so that it attaches the msgb to OTC_SELECT. This way there is no need to call msgb_free() here and there. This change fixes a memleak observed while running ttcn3-msc-test. Change-Id: I741e082badc32ba9a97c1495c894e1d22e122e3a Related: OS#5340 --- M src/libmsc/msc_a.c M src/libmsc/msc_a_remote.c M src/libmsc/msc_t.c M src/libmsc/msub.c 4 files changed, 7 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index 74721d2..c9b0572 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -1659,12 +1659,9 @@ .an_proto = msc_a->c.ran->an_proto, .msg = msc_role_ran_encode(msc_a->c.fi, ran_msg), }; - int rc; if (!an_apdu.msg) return -EIO; - rc = _msub_role_dispatch(msc_a->c.msub, to_role, to_role_event, &an_apdu, file, line); - msgb_free(an_apdu.msg); - return rc; + return _msub_role_dispatch(msc_a->c.msub, to_role, to_role_event, &an_apdu, file, line); } int msc_a_tx_dtap_to_i(struct msc_a *msc_a, struct msgb *dtap) diff --git a/src/libmsc/msc_a_remote.c b/src/libmsc/msc_a_remote.c index 84eff07..e4474f4 100644 --- a/src/libmsc/msc_a_remote.c +++ b/src/libmsc/msc_a_remote.c @@ -179,8 +179,6 @@ return; msc_a_remote_msg_up_to_remote_msc(msc_a, MSC_ROLE_T, OSMO_GSUP_MSGT_E_PREPARE_HANDOVER_ERROR, &an_apdu); - msgb_free(an_apdu.msg); - return; } /* [MSC-A---------------------] [MSC-B---------------------] diff --git a/src/libmsc/msc_t.c b/src/libmsc/msc_t.c index af0ddaa..43bc74e 100644 --- a/src/libmsc/msc_t.c +++ b/src/libmsc/msc_t.c @@ -145,7 +145,6 @@ return; msub_role_dispatch(msc_t->c.msub, MSC_ROLE_A, MSC_A_EV_FROM_T_PREPARE_HANDOVER_FAILURE, &an_apdu); - msgb_free(an_apdu.msg); } static int msc_t_ho_request_decode_and_store_cb(struct osmo_fsm_inst *msc_t_fi, void *data, @@ -238,7 +237,6 @@ static int msc_t_send_stored_ho_request__decode_cb(struct osmo_fsm_inst *msc_t_fi, void *data, const struct ran_msg *ran_dec) { - int rc; struct an_apdu an_apdu; struct msc_t *msc_t = msc_t_priv(msc_t_fi); struct osmo_sockaddr_str *rtp_ran_local = data; @@ -263,9 +261,7 @@ }; if (!an_apdu.msg) return -EIO; - rc = msc_t_down_l2_co(msc_t, &an_apdu, true); - msgb_free(an_apdu.msg); - return rc; + return msc_t_down_l2_co(msc_t, &an_apdu, true); } /* The MGW endpoint is created, we know our AoIP Transport Layer Address and can send the Handover Request to the RAN @@ -472,9 +468,7 @@ if (!an_apdu.msg) return -EIO; /* Send to remote MSC via msc_a_remote role */ - rc = msub_role_dispatch(msc_t->c.msub, MSC_ROLE_A, MSC_A_EV_FROM_T_PREPARE_HANDOVER_RESPONSE, &an_apdu); - msgb_free(an_apdu.msg); - return rc; + return msub_role_dispatch(msc_t->c.msub, MSC_ROLE_A, MSC_A_EV_FROM_T_PREPARE_HANDOVER_RESPONSE, &an_apdu); } static int msc_t_wait_ho_request_ack_decode_cb(struct osmo_fsm_inst *msc_t_fi, void *data, diff --git a/src/libmsc/msub.c b/src/libmsc/msub.c index 112703a..e4dd332 100644 --- a/src/libmsc/msub.c +++ b/src/libmsc/msub.c @@ -544,6 +544,8 @@ *conn_p = NULL; } +/* NOTE: the resulting message buffer will be attached to OTC_SELECT, so its lifetime + * is limited by the current select() loop iteration. Use talloc_steal() to avoid this. */ struct msgb *msc_role_ran_encode(struct osmo_fsm_inst *fi, const struct ran_msg *ran_msg) { struct msc_role_common *c = fi->priv; @@ -556,6 +558,8 @@ msg = c->ran->ran_encode(fi, ran_msg); if (!msg) LOGPFSML(fi, LOGL_ERROR, "Failed to encode %s\n", ran_msg_type_name(ran_msg->msg_type)); + else + talloc_steal(OTC_SELECT, msg); return msg; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I741e082badc32ba9a97c1495c894e1d22e122e3a Gerrit-Change-Number: 26460 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 7 23:11:04 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 7 Dec 2021 23:11:04 +0000 Subject: Change in osmo-sgsn[master]: llme_free: clean up related sndcp In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26462 ) Change subject: llme_free: clean up related sndcp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26462 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I707029f78222bc6335837241e5a08c54c5ae6eb3 Gerrit-Change-Number: 26462 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 07 Dec 2021 23:11:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 07:47:27 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 8 Dec 2021 07:47:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Test BVC bringup with conflicting BVCs In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26452 ) Change subject: gbproxy: Test BVC bringup with conflicting BVCs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I46eb0205b4c86b5f1bdc241ef0b2e12135c028e4 Gerrit-Change-Number: 26452 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 08 Dec 2021 07:47:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 07:47:29 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 8 Dec 2021 07:47:29 +0000 Subject: Change in osmo-ttcn3-hacks[master]: gbproxy: Test BVC bringup with conflicting BVCs In-Reply-To: References: Message-ID: daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26452 ) Change subject: gbproxy: Test BVC bringup with conflicting BVCs ...................................................................... gbproxy: Test BVC bringup with conflicting BVCs Different pcus try to establish the same BVC. Ensure that all the other BVCs still remain functional. Change-Id: I46eb0205b4c86b5f1bdc241ef0b2e12135c028e4 --- M gbproxy/GBProxy_Tests.ttcn 1 file changed, 115 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve daniel: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn index 5f5d835..ddf98a9 100644 --- a/gbproxy/GBProxy_Tests.ttcn +++ b/gbproxy/GBProxy_Tests.ttcn @@ -1069,6 +1069,117 @@ f_cleanup(); } +testcase TC_BVC_bringup_conflicting() runs on test_CT { + var float t_guard := 15.0; + var BssgpStatusIndication bsi; + var integer i; + + + g_Tguard.start(t_guard); + activate(as_gTguard(g_Tguard)); + + f_ipa_ctrl_start_client(mp_gbproxy_ip, mp_gbproxy_ctrl_port); + + var BssgpBvcConfigs bvcs := { }; + for (i := 0; i < lengthof(mp_gbconfigs); i := i+1) { + g_pcu[i].cfg := mp_gbconfigs[i]; + g_pcu[i].cfg.bvc[0].bvci := 23; + /* make sure all have a proper create_cb, which cannot be specified in config file */ + f_fix_create_cb(g_pcu[i].cfg); + /* concatenate all the PCU-side BVCs for the SGSN side */ + bvcs := bvcs & g_pcu[i].cfg.bvc; + } + + for (i := 0; i < lengthof(mp_nsconfig_sgsn); i := i+1) { + g_sgsn[i].cfg := { + nsei := mp_nsconfig_sgsn[i].nsei, + sgsn_role := true, + bvc := bvcs + } + } + + f_init_vty(); + for (i := 0; i < lengthof(mp_nsconfig_sgsn); i := i+1) { + f_vty_transceive(GBPVTY, "nsvc nsei " & int2str(g_sgsn[i].cfg.nsei) & " force-unconfigured"); + } + for (i := 0; i < lengthof(mp_nsconfig_pcu); i := i+1) { + f_vty_transceive(GBPVTY, "nsvc nsei " & int2str(g_pcu[i].cfg.nsei) & " force-unconfigured"); + f_vty_transceive(GBPVTY, "delete-gbproxy-peer " & int2str(g_pcu[i].cfg.nsei) & " only-bvc"); + } + + for (i := 0; i < lengthof(mp_nsconfig_sgsn); i := i+1) { + f_init_gb_sgsn(g_sgsn[i], "GbProxy_Test", i); + } + f_sleep(4.0); + for (i := 0; i < lengthof(mp_nsconfig_pcu); i := i+1) { + f_init_gb_pcu(g_pcu[i], "GbProxy_Test", i); + } + + /* wait until all BVC are unblocked on both sides */ + timer T := 10.0; + T.start; + alt { + [] SGSN_MGMT.receive(BssgpStatusIndication:{*, ?, ?}) { + repeat; + } + [] SGSN_MGMT.receive(BssgpResetIndication:?) { + repeat; + } + [] SGSN_MGMT.receive { + f_shutdown(__FILE__, __LINE__, fail, "Received unexpected message on SGSN_MGMT"); + } + [] PCU_MGMT.receive(BssgpStatusIndication:{*, ?, BVC_S_UNBLOCKED}) -> value bsi { + repeat; + } + [] PCU_MGMT.receive(BssgpStatusIndication:{*, ?, ?}) { + repeat; + } + [] PCU_MGMT.receive(BssgpResetIndication:{0}) { + repeat; + } + [] PCU_MGMT.receive { + f_shutdown(__FILE__, __LINE__, fail, "Received unexpected message on PCU_MGMT"); + } + [] T.timeout { + } + } + + /* Wait to ensure the gbproxy processed the RESET_ACK messages from the SGSN. + * Otherwise the state might still be WAIT_RESET_ACK */ + f_sleep(0.2); + + /* Verify BVCs, but ignore conflicting BVCI 23 */ + /* verify SGSN-side BVC FSM in IUT are UNBLOCKED */ + for (i := 0; i < lengthof(mp_nsconfig_sgsn); i := i+1) { + f_bvc_fsm_ensure_state(mp_nsconfig_sgsn[i].nsei, 0, "UNBLOCKED"); + /* iterate over list and check all BVCI */ + for (var integer j := 0; j < lengthof(g_sgsn[i].cfg.bvc); j := j+1) { + var BssgpBvci bvci := g_sgsn[i].cfg.bvc[j].bvci; + if (bvci == 23) { + continue; + } + f_bvc_fsm_ensure_state(mp_nsconfig_sgsn[i].nsei, bvci, "UNBLOCKED"); + } + } + /* verify PCU-side BVC FSM in IUT are UNBLOCKED */ + for (i := 0; i < lengthof(mp_nsconfig_pcu); i := i+1) { + f_bvc_fsm_ensure_state(mp_nsconfig_pcu[i].nsei, 0, "UNBLOCKED"); + /* iterate over list and check all BVCI */ + for (var integer j := 0; j < lengthof(g_pcu[i].cfg.bvc); j := j+1) { + var BssgpBvci bvci := g_pcu[i].cfg.bvc[j].bvci; + if (bvci == 23) { + continue; + } + f_bvc_fsm_ensure_state(mp_nsconfig_pcu[i].nsei, bvci, "UNBLOCKED"); + } + } + + /* re-start guard timer after all BVCs are up, so it only counts the actual test case */ + g_Tguard.start(t_guard); + f_start_handlers(refers(f_TC_BVC_bringup), testcasename(), 51); + f_cleanup(); +} + friend function f_bssgp_suspend(integer ran_idx := 0) runs on BSSGP_ConnHdlr return OCT1 { var BssgpBvcConfig bvcc := g_pars.pcu[ran_idx].cfg.bvc[0]; timer T := 5.0; @@ -3592,6 +3703,10 @@ control { execute( TC_BVC_bringup() ); + /* Depends on osmo-gbproxy > 0.2.0 */ + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + execute( TC_BVC_bringup_conflicting() ); + } execute( TC_ul_unitdata() ); execute( TC_ul_unitdata_pool_failure() ); execute( TC_dl_unitdata() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I46eb0205b4c86b5f1bdc241ef0b2e12135c028e4 Gerrit-Change-Number: 26452 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 08:04:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 08:04:04 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 2: (3 comments) excellent idea, I like the approach in general. Just some minor details. https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile File firmware/Makefile: https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile at 245 PS2, Line 245: ap I'm not quite sure the usb_strings_generated.h depends on misc/crctool? Wouldn't it make more sense to add it to the $(BIN) target above, next to usb_strings_generated.h? https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile at 288 PS2, Line 288: m patching the file in-line IMHO doesn't work very well with how make manages dependencies. Should the last step fail, there will still be a .bin file and a subsequent repeated 'make' command will no longer try executing crctool, as the .bin already exists? If the files without and with CRC would have different names, the built-in make logic should be able to help re-running crctool if it failed, and also the user would not have a .bin file in their filesystem that looks like everything is done. https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/apps/blupdate/main.c File firmware/apps/blupdate/main.c: https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/apps/blupdate/main.c at 98 PS2, Line 98: SCB->AIRCR = ((0x5FA << SCB_AIRCR_VECTKEY_Pos) | (SCB->AIRCR & SCB_AIRCR_PRIGROUP_Msk) | can we just tunr NVIC_SystemReset into a #define? or use __attribute__((always_inline)) ? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 08 Dec 2021 08:04:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 08:05:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 08:05:36 +0000 Subject: Change in osmo-sgsn[master]: llme_free: clean up related sndcp In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26462 ) Change subject: llme_free: clean up related sndcp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26462 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I707029f78222bc6335837241e5a08c54c5ae6eb3 Gerrit-Change-Number: 26462 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 08 Dec 2021 08:05:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 08:05:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 08:05:40 +0000 Subject: Change in osmo-sgsn[master]: llme_free: clean up related sndcp In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26462 ) Change subject: llme_free: clean up related sndcp ...................................................................... llme_free: clean up related sndcp Fix crash in vty_dump_sne when sndcp->lle has already been deallocated. Context: * sndcp->lle is set only once in gprs_sndcp_entity_alloc() * sndcp->lle is a struct gprs_llc_lle, which gets allocated and deallocated together with struct gprs_llc_llme. From gprs_llc.h: struct gprs_llc_llme { ... struct gprs_llc_lle lle[NUM_SAPIS]; Fixes: OS#4824 Change-Id: I707029f78222bc6335837241e5a08c54c5ae6eb3 --- M include/osmocom/sgsn/gprs_sndcp.h M src/sgsn/gprs_llc.c M src/sgsn/gprs_sndcp.c 3 files changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/sgsn/gprs_sndcp.h b/include/osmocom/sgsn/gprs_sndcp.h index d970240..5334d92 100644 --- a/include/osmocom/sgsn/gprs_sndcp.h +++ b/include/osmocom/sgsn/gprs_sndcp.h @@ -76,4 +76,7 @@ struct gprs_llc_xid_field *xid_field_request, struct gprs_llc_lle *lle); +/* Clean up all gprs_sndcp_entities related to llme (OS#4824) */ +void gprs_sndcp_sm_deactivate_ind_by_llme(struct gprs_llc_llme *llme); + #endif /* INT_SNDCP_H */ diff --git a/src/sgsn/gprs_llc.c b/src/sgsn/gprs_llc.c index eea1cec..453ded5 100644 --- a/src/sgsn/gprs_llc.c +++ b/src/sgsn/gprs_llc.c @@ -590,6 +590,7 @@ static void llme_free(struct gprs_llc_llme *llme) { + gprs_sndcp_sm_deactivate_ind_by_llme(llme); gprs_sndcp_comp_free(llme->comp.proto); gprs_sndcp_comp_free(llme->comp.data); llist_del(&llme->list); diff --git a/src/sgsn/gprs_sndcp.c b/src/sgsn/gprs_sndcp.c index 6692f1a..d8982ac 100644 --- a/src/sgsn/gprs_sndcp.c +++ b/src/sgsn/gprs_sndcp.c @@ -544,6 +544,20 @@ return 0; } +/* Clean up all gprs_sndcp_entities related to llme (OS#4824) */ +void gprs_sndcp_sm_deactivate_ind_by_llme(struct gprs_llc_llme *llme) +{ + struct gprs_sndcp_entity *sne, *sne2; + + llist_for_each_entry_safe(sne, sne2, &gprs_sndcp_entities, list) { + if (sne->lle->llme == llme) { + LOGP(DSNDCP, LOGL_INFO, "SNSM-DEACTIVATE.ind for SNDCP attached to llme=%p\n", llme); + /* Free and remove from list */ + sndcp_sm_deactivate_ind(sne->lle, sne->nsapi); + } + } +} + /* Fragmenter state */ struct sndcp_frag_state { uint8_t frag_nr; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26462 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I707029f78222bc6335837241e5a08c54c5ae6eb3 Gerrit-Change-Number: 26462 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 08:06:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 08:06:05 +0000 Subject: Change in libosmocore[master]: VTY: enable talloc introspection for OTC_GLOBAL In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26461 ) Change subject: VTY: enable talloc introspection for OTC_GLOBAL ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26461 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I831722174ecbac7f2d53f2427ba7e2615fa28c8a Gerrit-Change-Number: 26461 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 08 Dec 2021 08:06:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 08:06:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 08:06:07 +0000 Subject: Change in libosmocore[master]: VTY: enable talloc introspection for OTC_GLOBAL In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26461 ) Change subject: VTY: enable talloc introspection for OTC_GLOBAL ...................................................................... VTY: enable talloc introspection for OTC_GLOBAL Change-Id: I831722174ecbac7f2d53f2427ba7e2615fa28c8a --- M src/vty/talloc_ctx_vty.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/vty/talloc_ctx_vty.c b/src/vty/talloc_ctx_vty.c index 3966478..206d049 100644 --- a/src/vty/talloc_ctx_vty.c +++ b/src/vty/talloc_ctx_vty.c @@ -151,6 +151,8 @@ /* Determine a context for report */ if (!strncmp(ctx, "app", 3)) talloc_ctx = host.app_info->tall_ctx; + else if (!strcmp(ctx, "global")) + talloc_ctx = OTC_GLOBAL; else if (!strncmp(ctx, "all", 3)) talloc_ctx = NULL; @@ -167,11 +169,12 @@ } #define BASE_CMD_STR \ - "show talloc-context (application|all) (full|brief|DEPTH)" + "show talloc-context (application|global|all) (full|brief|DEPTH)" #define BASE_CMD_DESCR \ SHOW_STR "Show talloc memory hierarchy\n" \ "Application's context\n" \ + "Global context (OTC_GLOBAL)\n" \ "All contexts, if NULL-context tracking is enabled\n" \ "Display a full talloc memory hierarchy\n" \ "Display a brief talloc memory hierarchy\n" \ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26461 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I831722174ecbac7f2d53f2427ba7e2615fa28c8a Gerrit-Change-Number: 26461 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 08:07:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 08:07:00 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: do not pass UEA0 to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: do not pass UEA0 to ranap_new_msg_sec_mod_cmd2() ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 08 Dec 2021 08:07:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 08:07:55 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 08:07:55 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: fake ccid setparameter response In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 ) Change subject: slot fsm: fake ccid setparameter response ...................................................................... Patch Set 5: ping! no patch follow-up in 8 days? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 Gerrit-Change-Number: 26400 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 08 Dec 2021 08:07:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 09:43:36 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 8 Dec 2021 09:43:36 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile File firmware/Makefile: https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile at 245 PS2, Line 245: ap > I'm not quite sure the usb_strings_generated. [?] Done https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile at 288 PS2, Line 288: m > patching the file in-line IMHO doesn't work very well with how make manages dependencies. [?] At least as far as I am aware every simtrace firmware make always rebuilds everything from scratch anyway... https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/apps/blupdate/main.c File firmware/apps/blupdate/main.c: https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/apps/blupdate/main.c at 98 PS2, Line 98: SCB->AIRCR = ((0x5FA << SCB_AIRCR_VECTKEY_Pos) | (SCB->AIRCR & SCB_AIRCR_PRIGROUP_Msk) | > can we just tunr NVIC_SystemReset into a #define? or use __attribute__((always_inline)) ? I didn't want to mess with the asf code used everywhere else, and gcc warns if you use always_inline because "always_inline function might not be inlinable" (?!), so I didn't bother and left it like this, because it only affects two special occurences anyway... -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 08 Dec 2021 09:43:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 09:44:18 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 8 Dec 2021 09:44:18 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/26463 to look at the new patch set (#3). Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... firmware: add crc stub to all dfu apps to ensure reliable loading DFU flashing of apps sometimes aborts, and although rare this leads to broken devices if no boot button or serial/jtag access exists, because the bootloader will keep trying to start a half-flashed app that then crashes at some point. The easiest fix that works with existing bootloaders is to prepend a small 512 byte stub that calculcates the crc and compares it with the crc calculated at build time, and then either starts the actual app, or sets the dfu flag and resets. This ensures we either have a working, running app, or end up in the bootloader, ready to flash again. For obvious reasons this only applies to dfu apps, and not to flash targets like the actual bootloader itself. Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f --- M firmware/Makefile M firmware/apps/blupdate/main.c M firmware/libboard/common/resources/sam3s4/dfu.ld M firmware/libboard/common/resources/sam3s4/flash.ld A firmware/libcommon/source/crcstub.c A firmware/misc/crctool.c 6 files changed, 215 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/63/26463/3 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 10:41:00 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 8 Dec 2021 10:41:00 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore VOLATILE References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26464 ) Change subject: lint: checkpatch_osmo: ignore VOLATILE ...................................................................... lint: checkpatch_osmo: ignore VOLATILE The warning about potentially using volatile wrong is not useful for us, it makes sense to use it in embedded projects. Related: OS#5087 Related: https://www.kernel.org/doc/html/latest/process/volatile-considered-harmful.html Related: https://gerrit.osmocom.org/c/simtrace2/+/26463 Change-Id: Ie81db479c66749531ed1c81cf076ce248aa22f69 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/64/26464/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 126a8b4..ae66e71 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -73,6 +73,7 @@ # * UNNECESSARY_BREAK: not followed (see https://gerrit.osmocom.org/c/libosmo-netif/+/26429) # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) # * UNSPECIFIED_INT: not followed (doesn't seem useful for us) +# * VOLATILE: using volatile makes sense in embedded projects so this warning is not useful for us cd "$PROJECT_DIR" @@ -109,6 +110,7 @@ --ignore UNNECESSARY_BREAK \ --ignore UNNECESSARY_INT \ --ignore UNSPECIFIED_INT \ + --ignore VOLATILE \ --max-line-length 120 \ --no-signoff \ --no-tree \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie81db479c66749531ed1c81cf076ce248aa22f69 Gerrit-Change-Number: 26464 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 10:41:00 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 8 Dec 2021 10:41:00 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore BRACES_NOT_NECESSARY References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26465 ) Change subject: lint: checkpatch_osmo: ignore BRACES_NOT_NECESSARY ...................................................................... lint: checkpatch_osmo: ignore BRACES_NOT_NECESSARY Don't complain about using braces when they could be omitted, for example: if (condition) { single_statement(); } Another example: if (condition) { single_statement(); } else { another_single_statement(); } This is not something we would care about in code review either from what I've seen and so it's probably just annoying for patch authors to fix up. Related: OS#5087 Change-Id: Ice08d5b88c683a59bacff999a1d6c07754663d39 --- M lint/checkpatch/checkpatch.pl M lint/checkpatch/checkpatch_osmo.sh 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/65/26465/1 diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl index e31a61f..a4d229c 100755 --- a/lint/checkpatch/checkpatch.pl +++ b/lint/checkpatch/checkpatch.pl @@ -6008,7 +6008,7 @@ $sum_allowed += $_; } if ($sum_allowed == 0) { - WARN("BRACES", + WARN("BRACES_NOT_NECESSARY", # Osmocom specific: renamed from BRACES "braces {} are not necessary for any arm of this statement\n" . $herectx); } elsif ($sum_allowed != $allow && $seen != $allow) { @@ -6064,7 +6064,7 @@ my $cnt = statement_rawlines($block); my $herectx = get_stat_here($linenr, $cnt, $here); - WARN("BRACES", + WARN("BRACES_NOT_NECESSARY", # Osmocom specific: renamed from BRACES "braces {} are not necessary for single statement blocks\n" . $herectx); } } diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index ae66e71..d1ce63a 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -49,6 +49,7 @@ # * ASSIGN_IN_IF: not followed (e.g. 'if ((u8 = gsup_msg->cause))') # * AVOID_EXTERNS: we do use externs # * BLOCK_COMMENT_STYLE: we don't use a trailing */ on a separate line +# * BRACES_NOT_NECESSARY: not followed # * COMPLEX_MACRO: we don't use parentheses when building macros of strings across multiple lines # * CONSTANT_COMPARISON: not followed: "Comparisons should place the constant on the right side" # * DEEP_INDENTATION: warns about many leading tabs, not useful if changing existing code without refactoring @@ -84,6 +85,7 @@ --ignore ASSIGN_IN_IF \ --ignore AVOID_EXTERNS \ --ignore BLOCK_COMMENT_STYLE \ + --ignore BRACES_NOT_NECESSARY \ --ignore COMPLEX_MACRO \ --ignore CONSTANT_COMPARISON \ --ignore DEEP_INDENTATION \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ice08d5b88c683a59bacff999a1d6c07754663d39 Gerrit-Change-Number: 26465 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 10:45:58 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 8 Dec 2021 10:45:58 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: rearrange fsm cb events to make debugging easier In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 to look at the new patch set (#5). Change subject: slot fsm: rearrange fsm cb events to make debugging easier ...................................................................... slot fsm: rearrange fsm cb events to make debugging easier Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b --- M ccid_common/ccid_slot_fsm.c 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/99/26399/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b Gerrit-Change-Number: 26399 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 10:49:44 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 8 Dec 2021 10:49:44 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: fake ccid setparameter response In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 ) Change subject: slot fsm: fake ccid setparameter response ...................................................................... Patch Set 6: > Patch Set 5: > > (1 comment) > > If I read this correctly, you are preventing a PPS from happening by spoofing the response at CCID level. Why is it then that the actual code performing PPS still needs to be modified? Because this is mostly a logical grouping of related changes, you can also make it work by doing the pps and then only changing the fi/di values as long as maxslots is set to ~4. I'm carrtying a boatload of changes related to debugging that I didn't want in master so far but this is something that just has to be in there for now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 Gerrit-Change-Number: 26400 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 08 Dec 2021 10:49:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 10:55:52 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 8 Dec 2021 10:55:52 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: rearrange fsm cb events to make debugging easier In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 to look at the new patch set (#6). Change subject: slot fsm: rearrange fsm cb events to make debugging easier ...................................................................... slot fsm: rearrange fsm cb events to make debugging easier ..and so I can break on the nop. Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b --- M ccid_common/ccid_slot_fsm.c 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/99/26399/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b Gerrit-Change-Number: 26399 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 11:16:11 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 8 Dec 2021 11:16:11 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Code looks good to me. Regarding linter errors from https://jenkins.osmocom.org/jenkins/job/gerrit-simtrace2-lint/49/console: 1. firmware/libcommon/source/crcstub.c:31: WARNING:VOLATILE: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst Doesn't make sense here IMHO, submitted a patch to ignore it: https://gerrit.osmocom.org/c/osmo-ci/+/26464 2. firmware/misc/crctool.c:77: WARNING:BRACES: braces {} are not necessary for single statement blocks Doesn't seem useful either: https://gerrit.osmocom.org/c/osmo-ci/+/26465 3. firmware/libcommon/source/crcstub.c:16: ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Personally I like if there is not so much boilerplate at the start of every file, and having the mailing address from the FSF in there in 2021 is probably not useful. So I'd argue it makes sense to remove the address. https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile File firmware/Makefile: https://gerrit.osmocom.org/c/simtrace2/+/26463/2/firmware/Makefile at 288 PS2, Line 288: m > a subsequent repeated 'make' command will no longer try executing crctool, as the .bin already exists? No, because "dfu" is a PHONY target. In case one would run the "dfu" target twice (although Eric says above that this usually is not done/possible?), it will attempt to run the crctool again and fail because the magic does not match anymore. I agree that it would be cleaner to have it use a separate file, but it looks like this is not a problem. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Wed, 08 Dec 2021 11:16:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hoernchen Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 11:57:23 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 8 Dec 2021 11:57:23 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 3: > 3. firmware/libcommon/source/crcstub.c:16: ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. > > Personally I like if there is not so much boilerplate at the start of every file, and having the mailing address from the FSF in there in 2021 is probably not useful. So I'd argue it makes sense to remove the address. I'd argue that the comment block at the top is collapsed by any reasonable editor anyway because no one wants to look at it - unless you create a new file, by just copying the block from another open file. Then having to check and modify that block because the linter looks at comments does not sound like a improvement to me.. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Wed, 08 Dec 2021 11:57:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 12:17:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 8 Dec 2021 12:17:18 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore VOLATILE In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26464 ) Change subject: lint: checkpatch_osmo: ignore VOLATILE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie81db479c66749531ed1c81cf076ce248aa22f69 Gerrit-Change-Number: 26464 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 08 Dec 2021 12:17:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 12:17:35 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 8 Dec 2021 12:17:35 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore BRACES_NOT_NECESSARY In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26465 ) Change subject: lint: checkpatch_osmo: ignore BRACES_NOT_NECESSARY ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ice08d5b88c683a59bacff999a1d6c07754663d39 Gerrit-Change-Number: 26465 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 08 Dec 2021 12:17:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 14:35:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 14:35:18 +0000 Subject: Change in osmo-remsim[master]: bankd_pcsc: Improve logging in non-error case References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26466 ) Change subject: bankd_pcsc: Improve logging in non-error case ...................................................................... bankd_pcsc: Improve logging in non-error case Before this commit, the PCSC operation (e.g. SCardStatus) is only printed in the error case, but not in the debug case. Let's fix that. [000 CONN_CLIENT_MAPPED_CARD] bankd_pcsc.c:196 : OK will become [000 CONN_CLIENT_MAPPED_CARD] bankd_pcsc.c:196 SCardTransmit: OK Change-Id: I3c77655c5d1f76be778cb8873d8acf1343c87b05 --- M src/bankd/bankd_pcsc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/66/26466/1 diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index e0b349c..ea8e557 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -178,7 +178,7 @@ LOGW_PCSC_ERROR(w, rv, text); \ goto end; \ } else { \ - LOGW((w), ": OK\n"); \ + LOGW((w), text ": OK\n"); \ } static int pcsc_get_atr(struct bankd_worker *worker) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3c77655c5d1f76be778cb8873d8acf1343c87b05 Gerrit-Change-Number: 26466 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 14:35:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 14:35:18 +0000 Subject: Change in osmo-remsim[master]: bankd_main: Improve log usefulness References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26467 ) Change subject: bankd_main: Improve log usefulness ...................................................................... bankd_main: Improve log usefulness Right now we get duplicate log lines like [000 CONN_CLIENT_MAPPED_CARD] bankd_main.c:662 Rx RSPRO tpduModemToCard [000 CONN_CLIENT_MAPPED_CARD] bankd_main.c:623 tpduModemToCard(0070000001) Where the first line is printed by the generic receive handler for RSPRO messages, while the second line is from the specific handler function handling the specific message type. Let's only print from the generic message handler if no specific handler function exists. Change-Id: I992c847e0081bd1cd8a0b70212618c4980d9db81 --- M src/bankd/bankd_main.c 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/67/26467/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index ce34ac2..ecfa22d 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -645,7 +645,7 @@ OSMO_ASSERT(pdu->msg.present == RsproPDUchoice_PR_connectClientReq); - LOGW(worker, "connectClientReq(T=%lu, N='%s', SW='%s', VER='%s')\n", + LOGW(worker, "Rx RSPRO connectClientReq(T=%lu, N='%s', SW='%s', VER='%s')\n", cid->type, cid->name.buf, cid->software.buf, cid->swVersion.buf); /* FIXME: store somewhere? */ @@ -698,7 +698,8 @@ struct bank_slot bslot; int rc; - LOGW(worker, "tpduModemToCard(%s)\n", osmo_hexdump_nospc(mdm2sim->data.buf, mdm2sim->data.size)); + LOGW(worker, "Rx RSPRO tpduModemToCard(%s)\n", + osmo_hexdump_nospc(mdm2sim->data.buf, mdm2sim->data.size)); if (worker->state != BW_ST_CONN_CLIENT_MAPPED_CARD) { LOGW(worker, "Unexpected tpduModemToCaard\n"); @@ -738,7 +739,7 @@ const struct SlotPhysStatus *sps = &cssi->slotPhysStatus; int rc = 0; - LOGW(worker, "clientSlotStatusInd(RST=%s, VCC=%s, CLK=%s)\n", + LOGW(worker, "Rx RSPRO clientSlotStatusInd(RST=%s, VCC=%s, CLK=%s)\n", sps->resetActive ? "ACTIVE" : "INACTIVE", sps->vccPresent ? *sps->vccPresent ? "PRESENT" : "ABSENT" : "NULL", sps->clkActive ? *sps->clkActive ? "ACTIVE" : "INACTIVE" : "NULL"); @@ -757,8 +758,6 @@ { int rc = -100; - LOGW(worker, "Rx RSPRO %s\n", rspro_msgt_name(pdu)); - switch (pdu->msg.present) { case RsproPDUchoice_PR_connectClientReq: rc = worker_handle_connectClientReq(worker, pdu); @@ -771,9 +770,11 @@ rc = 0; break; case RsproPDUchoice_PR_setAtrRes: + LOGW(worker, "Rx RSPRO %s\n", rspro_msgt_name(pdu)); rc = 0; break; default: + LOGW(worker, "Rx RSPRO %s (unhandled)\n", rspro_msgt_name(pdu)); rc = -101; break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26467 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I992c847e0081bd1cd8a0b70212618c4980d9db81 Gerrit-Change-Number: 26467 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 14:35:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 14:35:19 +0000 Subject: Change in osmo-remsim[master]: bankd_pcsc: Don't log every successful SCardTransmit References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26468 ) Change subject: bankd_pcsc: Don't log every successful SCardTransmit ...................................................................... bankd_pcsc: Don't log every successful SCardTransmit Contrary to other operations, SCardTransmit has a much higher frequency and the logs should not be clobbered with "OK" lines all over the place. Change-Id: Icf87b61d71722b2998ae78f9aee7c4ad94c46da7 --- M src/bankd/bankd_pcsc.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/68/26468/1 diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index ea8e557..5934ac0 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -297,9 +297,10 @@ long rc; rc = SCardTransmit(worker->reader.pcsc.hCard, pioSendPci, out, out_len, &pioRecvPci, in, in_len); - PCSC_ERROR(worker, rc, "SCardTransmit"); + /* don't use PCSC_ERROR here as we don't want to log every successful SCardTransmit */ + if (rc != SCARD_S_SUCCESS) + LOGW_PCSC_ERROR(worker, rc, "SCrdTransmit"); -end: return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icf87b61d71722b2998ae78f9aee7c4ad94c46da7 Gerrit-Change-Number: 26468 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 14:56:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 14:56:49 +0000 Subject: Change in osmo-remsim[master]: rspro_client_fsm: Differentiate different log levels References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26469 ) Change subject: rspro_client_fsm: Differentiate different log levels ...................................................................... rspro_client_fsm: Differentiate different log levels Raw Rx/Tx of messages should be LOGL_DEBUG, while connection establishment/loss should be something like LOGL_NOTICE. Change-Id: I1bc6d491a8a748cbd729cbdeede60d32bd760a15 --- M src/rspro_client_fsm.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/69/26469/1 diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 36a3016..5718015 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -79,7 +79,7 @@ static int _server_conn_send_rspro(struct rspro_server_conn *srvc, RsproPDU_t *rspro) { - LOGPFSM(srvc->fi, "Tx RSPRO %s\n", rspro_msgt_name(rspro)); + LOGPFSML(srvc->fi, LOGL_DEBUG, "Tx RSPRO %s\n", rspro_msgt_name(rspro)); return ipa_client_conn_send_rspro(srvc->conn, rspro); } @@ -124,7 +124,8 @@ { struct rspro_server_conn *srvc = conn->data; - LOGPFSM(srvc->fi, "RSPRO link to %s:%d %s\n", conn->addr, conn->port, up ? "UP" : "DOWN"); + LOGPFSML(srvc->fi, LOGL_NOTICE, "RSPRO link to %s:%d %s\n", + conn->addr, conn->port, up ? "UP" : "DOWN"); osmo_fsm_inst_dispatch(srvc->fi, up ? SRVC_E_TCP_UP: SRVC_E_TCP_DOWN, 0); } @@ -162,7 +163,7 @@ msg->l2h = &he->data[0]; switch (he->proto) { case IPAC_PROTO_EXT_RSPRO: - LOGPFSM(srvc->fi, "Received RSPRO %s\n", msgb_hexdump(msg)); + LOGPFSML(srvc->fi, LOGL_DEBUG, "Received RSPRO %s\n", msgb_hexdump(msg)); pdu = rspro_dec_msg(msg); if (!pdu) { rc = -EIO; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26469 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I1bc6d491a8a748cbd729cbdeede60d32bd760a15 Gerrit-Change-Number: 26469 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 14:56:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 14:56:49 +0000 Subject: Change in osmo-remsim[master]: rspro_client_fsm: Change FSM log level to INFO References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26470 ) Change subject: rspro_client_fsm: Change FSM log level to INFO ...................................................................... rspro_client_fsm: Change FSM log level to INFO this will drop printing DEBUG level messages by default. Change-Id: I8ecb17674d480988847d7fa23b586b66fa52010a --- M src/rspro_client_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/70/26470/1 diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 5718015..14a4901 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -440,7 +440,7 @@ { struct osmo_fsm_inst *fi; - fi = osmo_fsm_inst_alloc(&rspro_client_server_fsm, ctx, srvc, LOGL_DEBUG, "server"); + fi = osmo_fsm_inst_alloc(&rspro_client_server_fsm, ctx, srvc, LOGL_INFO, "server"); if (!fi) return -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8ecb17674d480988847d7fa23b586b66fa52010a Gerrit-Change-Number: 26470 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 14:58:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 14:58:18 +0000 Subject: Change in osmo-remsim[master]: bankd_pcsc: Improve logging in non-error case In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/26466 to look at the new patch set (#2). Change subject: bankd_pcsc: Improve logging in non-error case ...................................................................... bankd_pcsc: Improve logging in non-error case Before this commit, the PCSC operation (e.g. SCardStatus) is only printed in the error case, but not in the debug case. Let's fix that. [000 CONN_CLIENT_MAPPED_CARD] bankd_pcsc.c:196 : OK will become [000 CONN_CLIENT_MAPPED_CARD] bankd_pcsc.c:196 SCardTransmit: OK Change-Id: I3c77655c5d1f76be778cb8873d8acf1343c87b05 --- M src/bankd/bankd_pcsc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/66/26466/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3c77655c5d1f76be778cb8873d8acf1343c87b05 Gerrit-Change-Number: 26466 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 15:55:35 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 8 Dec 2021 15:55:35 +0000 Subject: Change in osmo-remsim[master]: rspro_client_fsm: Change FSM log level to INFO In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26470 ) Change subject: rspro_client_fsm: Change FSM log level to INFO ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8ecb17674d480988847d7fa23b586b66fa52010a Gerrit-Change-Number: 26470 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 08 Dec 2021 15:55:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 15:58:21 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 8 Dec 2021 15:58:21 +0000 Subject: Change in osmo-remsim[master]: bankd_main: Improve log usefulness In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26467 ) Change subject: bankd_main: Improve log usefulness ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26467 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I992c847e0081bd1cd8a0b70212618c4980d9db81 Gerrit-Change-Number: 26467 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 08 Dec 2021 15:58:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Wed Dec 8 16:36:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 08 Dec 2021 16:36:00 +0000 Subject: Build failure of network:osmocom:latest/ulfius in Debian_9.0/i586 In-Reply-To: References: Message-ID: <61b0def61ae23_69582abcb47346005303b3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_9.0/i586 Package network:osmocom:latest/ulfius failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 53s] dh_install -O--buildsystem=cmake -O--builddirectory=build [ 53s] dh_installdocs -O--buildsystem=cmake -O--builddirectory=build [ 53s] dh_installchangelogs -O--buildsystem=cmake -O--builddirectory=build [ 54s] dh_installexamples -O--buildsystem=cmake -O--builddirectory=build [ 54s] dh_perl -O--buildsystem=cmake -O--builddirectory=build [ 54s] dh_link -O--buildsystem=cmake -O--builddirectory=build [ 54s] dh_strip_nondeterminism -O--buildsystem=cmake -O--builddirectory=build [ 54s] dh_compress -O--buildsystem=cmake -O--builddirectory=build [ 54s] dh_fixperms -O--buildsystem=cmake -O--builddirectory=build [ 54s] dh_strip -O--buildsystem=cmake -O--builddirectory=build [ 54s] dh_makeshlibs -O--buildsystem=cmake -O--builddirectory=build [ 54s] dh_shlibdeps -O--buildsystem=cmake -O--builddirectory=build [ 55s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/i386-linux-gnu/libulfius.so.2.5.2 was not linked against libgnutls.so.30 (it uses none of the library's symbols) [ 55s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/i386-linux-gnu/libulfius.so.2.5.2 was not linked against libpthread.so.0 (it uses none of the library's symbols) [ 55s] dh_installdeb -O--buildsystem=cmake -O--builddirectory=build [ 55s] dh_gencontrol -O--buildsystem=cmake -O--builddirectory=build [ 55s] dpkg-gencontrol: warning: can't parse dependency libyder2.0 = 1.4.4 [ 55s] dpkg-gencontrol: error: error occurred while parsing Depends field: libc6 (>= 2.3.6-6~), libc6 (>= 2.4), libcurl3-gnutls (>= 7.16.2), libgnutls30 (>= 3.5.0), libjansson4 (>= 2.1), libmicrohttpd12 (>= 0.9.50), liborcania1.2 (>= 1.2.2), libyder2.0 (>= 1.3.3), , libyder2.0 = 1.4.4 [ 55s] dh_gencontrol: dpkg-gencontrol -plibulfius2.5 -ldebian/changelog -Tdebian/libulfius2.5.substvars -Pdebian/.debhelper/libulfius2.5/dbgsym-root -UPre-Depends -URecommends -USuggests -UEnhances -UProvides -UEssential -UConflicts -DPriority=extra -DAuto-Built-Package=debug-symbols -DPackage=libulfius2.5-dbgsym -DDepends=libulfius2.5 (= ${binary:Version}) -DDescription=Debug symbols for libulfius2.5 -DBuild-Ids=5825acc7c7ee7fa0bfb6f22c8ff3b01303445f69 -DSection=debug -UReplaces -UBreaks returned exit code 255 [ 55s] debian/rules:9: recipe for target 'binary' failed [ 55s] make: *** [binary] Error 2 [ 55s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 [ 55s] ### VM INTERACTION START ### [ 58s] [ 49.967021] sysrq: Power Off [ 58s] [ 49.969759] reboot: Power down [ 58s] ### VM INTERACTION END ### [ 58s] [ 58s] goat07 failed "build ulfius_2.5.2-4.2.dsc" at Wed Dec 8 16:35:55 UTC 2021. [ 58s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 8 16:36:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 08 Dec 2021 16:36:17 +0000 Subject: Build failure of network:osmocom:latest/ulfius in Debian_9.0/x86_64 In-Reply-To: References: Message-ID: <61b0df1034820_69582abcb47346005304a4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_9.0/x86_64 Package network:osmocom:latest/ulfius failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 75s] dh_install -O--buildsystem=cmake -O--builddirectory=build [ 75s] dh_installdocs -O--buildsystem=cmake -O--builddirectory=build [ 75s] dh_installchangelogs -O--buildsystem=cmake -O--builddirectory=build [ 75s] dh_installexamples -O--buildsystem=cmake -O--builddirectory=build [ 75s] dh_perl -O--buildsystem=cmake -O--builddirectory=build [ 75s] dh_link -O--buildsystem=cmake -O--builddirectory=build [ 76s] dh_strip_nondeterminism -O--buildsystem=cmake -O--builddirectory=build [ 76s] dh_compress -O--buildsystem=cmake -O--builddirectory=build [ 76s] dh_fixperms -O--buildsystem=cmake -O--builddirectory=build [ 76s] dh_strip -O--buildsystem=cmake -O--builddirectory=build [ 76s] dh_makeshlibs -O--buildsystem=cmake -O--builddirectory=build [ 76s] dh_shlibdeps -O--buildsystem=cmake -O--builddirectory=build [ 77s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/x86_64-linux-gnu/libulfius.so.2.5.2 was not linked against libpthread.so.0 (it uses none of the library's symbols) [ 77s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/x86_64-linux-gnu/libulfius.so.2.5.2 was not linked against libgnutls.so.30 (it uses none of the library's symbols) [ 77s] dh_installdeb -O--buildsystem=cmake -O--builddirectory=build [ 77s] dh_gencontrol -O--buildsystem=cmake -O--builddirectory=build [ 77s] dpkg-gencontrol: warning: can't parse dependency libyder2.0 = 1.4.4 [ 77s] dpkg-gencontrol: error: error occurred while parsing Depends field: libc6 (>= 2.14), libcurl3-gnutls (>= 7.16.2), libgnutls30 (>= 3.5.0), libjansson4 (>= 2.1), libmicrohttpd12 (>= 0.9.50), liborcania1.2 (>= 1.2.2), libyder2.0 (>= 1.3.3), , libyder2.0 = 1.4.4 [ 77s] dh_gencontrol: dpkg-gencontrol -plibulfius2.5 -ldebian/changelog -Tdebian/libulfius2.5.substvars -Pdebian/.debhelper/libulfius2.5/dbgsym-root -UPre-Depends -URecommends -USuggests -UEnhances -UProvides -UEssential -UConflicts -DPriority=extra -DAuto-Built-Package=debug-symbols -DPackage=libulfius2.5-dbgsym -DDepends=libulfius2.5 (= ${binary:Version}) -DDescription=Debug symbols for libulfius2.5 -DBuild-Ids=47da31e34ad1876c56f8df83f773cd1a9810dc3c -DSection=debug -UReplaces -UBreaks returned exit code 255 [ 77s] debian/rules:9: recipe for target 'binary' failed [ 77s] make: *** [binary] Error 2 [ 77s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 [ 77s] ### VM INTERACTION START ### [ 80s] [ 64.122969] sysrq: Power Off [ 80s] [ 64.138888] reboot: Power down [ 80s] ### VM INTERACTION END ### [ 80s] [ 80s] goat03 failed "build ulfius_2.5.2-4.2.dsc" at Wed Dec 8 16:36:10 UTC 2021. [ 80s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 8 16:36:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 08 Dec 2021 16:36:51 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_9.0/aarch64 In-Reply-To: References: Message-ID: <61b0df2fb96a1_69582abcb47346005306da@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_9.0/aarch64 Package network:osmocom:nightly/ulfius failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 86s] dh_install -O--buildsystem=cmake -O--builddirectory=build [ 86s] dh_installdocs -O--buildsystem=cmake -O--builddirectory=build [ 86s] dh_installchangelogs -O--buildsystem=cmake -O--builddirectory=build [ 86s] dh_installexamples -O--buildsystem=cmake -O--builddirectory=build [ 87s] dh_perl -O--buildsystem=cmake -O--builddirectory=build [ 87s] dh_link -O--buildsystem=cmake -O--builddirectory=build [ 87s] dh_strip_nondeterminism -O--buildsystem=cmake -O--builddirectory=build [ 87s] dh_compress -O--buildsystem=cmake -O--builddirectory=build [ 87s] dh_fixperms -O--buildsystem=cmake -O--builddirectory=build [ 87s] dh_strip -O--buildsystem=cmake -O--builddirectory=build [ 87s] dh_makeshlibs -O--buildsystem=cmake -O--builddirectory=build [ 87s] dh_shlibdeps -O--buildsystem=cmake -O--builddirectory=build [ 87s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/aarch64-linux-gnu/libulfius.so.2.5.2 was not linked against libpthread.so.0 (it uses none of the library's symbols) [ 87s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/aarch64-linux-gnu/libulfius.so.2.5.2 was not linked against libgnutls.so.30 (it uses none of the library's symbols) [ 88s] dh_installdeb -O--buildsystem=cmake -O--builddirectory=build [ 88s] dh_gencontrol -O--buildsystem=cmake -O--builddirectory=build [ 88s] dpkg-gencontrol: warning: can't parse dependency libyder2.0 = 1.4.4 [ 88s] dpkg-gencontrol: error: error occurred while parsing Depends field: libc6 (>= 2.17), libcurl3-gnutls (>= 7.16.2), libgnutls30 (>= 3.5.0), libjansson4 (>= 2.1), libmicrohttpd12 (>= 0.9.50), liborcania1.2 (>= 1.2.2), libyder2.0 (>= 1.3.3), , libyder2.0 = 1.4.4 [ 88s] dh_gencontrol: dpkg-gencontrol -plibulfius2.5 -ldebian/changelog -Tdebian/libulfius2.5.substvars -Pdebian/.debhelper/libulfius2.5/dbgsym-root -UPre-Depends -URecommends -USuggests -UEnhances -UProvides -UEssential -UConflicts -DPriority=extra -DAuto-Built-Package=debug-symbols -DPackage=libulfius2.5-dbgsym -DDepends=libulfius2.5 (= ${binary:Version}) -DDescription=Debug symbols for libulfius2.5 -DBuild-Ids=f830c17a992c3adb1ea302656b3532426f0198c4 -DSection=debug -UReplaces -UBreaks returned exit code 255 [ 88s] debian/rules:9: recipe for target 'binary' failed [ 88s] make: *** [binary] Error 2 [ 88s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 [ 88s] ### VM INTERACTION START ### [ 93s] [ 64.621005] sysrq: Power Off [ 93s] [ 64.621820] reboot: Power down [ 93s] ### VM INTERACTION END ### [ 93s] [ 93s] obs-arm-10 failed "build ulfius_2.5.2-4.2.dsc" at Wed Dec 8 16:36:34 UTC 2021. [ 93s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 8 16:36:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 08 Dec 2021 16:36:51 +0000 Subject: Build failure of network:osmocom:latest/ulfius in Debian_9.0/aarch64 In-Reply-To: References: Message-ID: <61b0df30673ee_69582abcb47346005308e5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_9.0/aarch64 Package network:osmocom:latest/ulfius failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 118s] dh_install -O--buildsystem=cmake -O--builddirectory=build [ 118s] dh_installdocs -O--buildsystem=cmake -O--builddirectory=build [ 118s] dh_installchangelogs -O--buildsystem=cmake -O--builddirectory=build [ 118s] dh_installexamples -O--buildsystem=cmake -O--builddirectory=build [ 119s] dh_perl -O--buildsystem=cmake -O--builddirectory=build [ 119s] dh_link -O--buildsystem=cmake -O--builddirectory=build [ 119s] dh_strip_nondeterminism -O--buildsystem=cmake -O--builddirectory=build [ 119s] dh_compress -O--buildsystem=cmake -O--builddirectory=build [ 119s] dh_fixperms -O--buildsystem=cmake -O--builddirectory=build [ 120s] dh_strip -O--buildsystem=cmake -O--builddirectory=build [ 120s] dh_makeshlibs -O--buildsystem=cmake -O--builddirectory=build [ 120s] dh_shlibdeps -O--buildsystem=cmake -O--builddirectory=build [ 122s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/aarch64-linux-gnu/libulfius.so.2.5.2 was not linked against libgnutls.so.30 (it uses none of the library's symbols) [ 122s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/aarch64-linux-gnu/libulfius.so.2.5.2 was not linked against libpthread.so.0 (it uses none of the library's symbols) [ 122s] dh_installdeb -O--buildsystem=cmake -O--builddirectory=build [ 122s] dh_gencontrol -O--buildsystem=cmake -O--builddirectory=build [ 123s] dpkg-gencontrol: warning: can't parse dependency libyder2.0 = 1.4.4 [ 123s] dpkg-gencontrol: error: error occurred while parsing Depends field: libc6 (>= 2.17), libcurl3-gnutls (>= 7.16.2), libgnutls30 (>= 3.5.0), libjansson4 (>= 2.1), libmicrohttpd12 (>= 0.9.50), liborcania1.2 (>= 1.2.2), libyder2.0 (>= 1.3.3), , libyder2.0 = 1.4.4 [ 123s] dh_gencontrol: dpkg-gencontrol -plibulfius2.5 -ldebian/changelog -Tdebian/libulfius2.5.substvars -Pdebian/.debhelper/libulfius2.5/dbgsym-root -UPre-Depends -URecommends -USuggests -UEnhances -UProvides -UEssential -UConflicts -DPriority=extra -DAuto-Built-Package=debug-symbols -DPackage=libulfius2.5-dbgsym -DDepends=libulfius2.5 (= ${binary:Version}) -DDescription=Debug symbols for libulfius2.5 -DBuild-Ids=f830c17a992c3adb1ea302656b3532426f0198c4 -DSection=debug -UReplaces -UBreaks returned exit code 255 [ 123s] debian/rules:9: recipe for target 'binary' failed [ 123s] make: *** [binary] Error 2 [ 123s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 [ 123s] ### VM INTERACTION START ### [ 126s] [ 110.825955] sysrq: Power Off [ 126s] [ 110.885308] reboot: Power down [ 126s] ### VM INTERACTION END ### [ 126s] [ 126s] obs-arm-9 failed "build ulfius_2.5.2-4.2.dsc" at Wed Dec 8 16:36:49 UTC 2021. [ 126s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 8 16:36:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 08 Dec 2021 16:36:34 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_9.0/i586 In-Reply-To: References: Message-ID: <61b0df2eef730_69582abcb473460053059@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_9.0/i586 Package network:osmocom:nightly/ulfius failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 110s] dh_install -O--buildsystem=cmake -O--builddirectory=build [ 110s] dh_installdocs -O--buildsystem=cmake -O--builddirectory=build [ 110s] dh_installchangelogs -O--buildsystem=cmake -O--builddirectory=build [ 111s] dh_installexamples -O--buildsystem=cmake -O--builddirectory=build [ 111s] dh_perl -O--buildsystem=cmake -O--builddirectory=build [ 111s] dh_link -O--buildsystem=cmake -O--builddirectory=build [ 111s] dh_strip_nondeterminism -O--buildsystem=cmake -O--builddirectory=build [ 111s] dh_compress -O--buildsystem=cmake -O--builddirectory=build [ 112s] dh_fixperms -O--buildsystem=cmake -O--builddirectory=build [ 112s] dh_strip -O--buildsystem=cmake -O--builddirectory=build [ 113s] dh_makeshlibs -O--buildsystem=cmake -O--builddirectory=build [ 113s] dh_shlibdeps -O--buildsystem=cmake -O--builddirectory=build [ 115s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/i386-linux-gnu/libulfius.so.2.5.2 was not linked against libpthread.so.0 (it uses none of the library's symbols) [ 115s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/i386-linux-gnu/libulfius.so.2.5.2 was not linked against libgnutls.so.30 (it uses none of the library's symbols) [ 115s] dh_installdeb -O--buildsystem=cmake -O--builddirectory=build [ 115s] dh_gencontrol -O--buildsystem=cmake -O--builddirectory=build [ 115s] dpkg-gencontrol: warning: can't parse dependency libyder2.0 = 1.4.4 [ 115s] dpkg-gencontrol: error: error occurred while parsing Depends field: libc6 (>= 2.3.6-6~), libc6 (>= 2.4), libcurl3-gnutls (>= 7.16.2), libgnutls30 (>= 3.5.0), libjansson4 (>= 2.1), libmicrohttpd12 (>= 0.9.50), liborcania1.2 (>= 1.2.2), libyder2.0 (>= 1.3.3), , libyder2.0 = 1.4.4 [ 115s] dh_gencontrol: dpkg-gencontrol -plibulfius2.5 -ldebian/changelog -Tdebian/libulfius2.5.substvars -Pdebian/.debhelper/libulfius2.5/dbgsym-root -UPre-Depends -URecommends -USuggests -UEnhances -UProvides -UEssential -UConflicts -DPriority=extra -DAuto-Built-Package=debug-symbols -DPackage=libulfius2.5-dbgsym -DDepends=libulfius2.5 (= ${binary:Version}) -DDescription=Debug symbols for libulfius2.5 -DBuild-Ids=5825acc7c7ee7fa0bfb6f22c8ff3b01303445f69 -DSection=debug -UReplaces -UBreaks returned exit code 255 [ 115s] debian/rules:9: recipe for target 'binary' failed [ 115s] make: *** [binary] Error 2 [ 115s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 [ 115s] ### VM INTERACTION START ### [ 118s] [ 105.519000] sysrq: Power Off [ 119s] [ 105.568763] reboot: Power down [ 119s] ### VM INTERACTION END ### [ 119s] [ 119s] lamb08 failed "build ulfius_2.5.2-4.2.dsc" at Wed Dec 8 16:36:26 UTC 2021. [ 119s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 8 16:36:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 08 Dec 2021 16:36:51 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_9.0/x86_64 In-Reply-To: References: Message-ID: <61b0df2ff3f9a_69582abcb47346005307a9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_9.0/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 97s] dh_install -O--buildsystem=cmake -O--builddirectory=build [ 97s] dh_installdocs -O--buildsystem=cmake -O--builddirectory=build [ 97s] dh_installchangelogs -O--buildsystem=cmake -O--builddirectory=build [ 97s] dh_installexamples -O--buildsystem=cmake -O--builddirectory=build [ 97s] dh_perl -O--buildsystem=cmake -O--builddirectory=build [ 97s] dh_link -O--buildsystem=cmake -O--builddirectory=build [ 97s] dh_strip_nondeterminism -O--buildsystem=cmake -O--builddirectory=build [ 98s] dh_compress -O--buildsystem=cmake -O--builddirectory=build [ 98s] dh_fixperms -O--buildsystem=cmake -O--builddirectory=build [ 98s] dh_strip -O--buildsystem=cmake -O--builddirectory=build [ 98s] dh_makeshlibs -O--buildsystem=cmake -O--builddirectory=build [ 98s] dh_shlibdeps -O--buildsystem=cmake -O--builddirectory=build [ 99s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/x86_64-linux-gnu/libulfius.so.2.5.2 was not linked against libgnutls.so.30 (it uses none of the library's symbols) [ 99s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/x86_64-linux-gnu/libulfius.so.2.5.2 was not linked against libpthread.so.0 (it uses none of the library's symbols) [ 99s] dh_installdeb -O--buildsystem=cmake -O--builddirectory=build [ 100s] dh_gencontrol -O--buildsystem=cmake -O--builddirectory=build [ 100s] dpkg-gencontrol: warning: can't parse dependency libyder2.0 = 1.4.4 [ 100s] dpkg-gencontrol: error: error occurred while parsing Depends field: libc6 (>= 2.14), libcurl3-gnutls (>= 7.16.2), libgnutls30 (>= 3.5.0), libjansson4 (>= 2.1), libmicrohttpd12 (>= 0.9.50), liborcania1.2 (>= 1.2.2), libyder2.0 (>= 1.3.3), , libyder2.0 = 1.4.4 [ 100s] dh_gencontrol: dpkg-gencontrol -plibulfius2.5 -ldebian/changelog -Tdebian/libulfius2.5.substvars -Pdebian/.debhelper/libulfius2.5/dbgsym-root -UPre-Depends -URecommends -USuggests -UEnhances -UProvides -UEssential -UConflicts -DPriority=extra -DAuto-Built-Package=debug-symbols -DPackage=libulfius2.5-dbgsym -DDepends=libulfius2.5 (= ${binary:Version}) -DDescription=Debug symbols for libulfius2.5 -DBuild-Ids=47da31e34ad1876c56f8df83f773cd1a9810dc3c -DSection=debug -UReplaces -UBreaks returned exit code 255 [ 100s] debian/rules:9: recipe for target 'binary' failed [ 100s] make: *** [binary] Error 2 [ 100s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 [ 100s] ### VM INTERACTION START ### [ 103s] [ 84.711017] sysrq: Power Off [ 103s] [ 84.729305] reboot: Power down [ 103s] ### VM INTERACTION END ### [ 103s] [ 103s] cloud121 failed "build ulfius_2.5.2-4.2.dsc" at Wed Dec 8 16:36:35 UTC 2021. [ 103s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 8 16:37:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 08 Dec 2021 16:37:08 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_9.0/armv7l In-Reply-To: References: Message-ID: <61b0df4a7d3df_69582abcb47346005310c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_9.0/armv7l Package network:osmocom:nightly/ulfius failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 141s] dh_install -O--buildsystem=cmake -O--builddirectory=build [ 141s] dh_installdocs -O--buildsystem=cmake -O--builddirectory=build [ 142s] dh_installchangelogs -O--buildsystem=cmake -O--builddirectory=build [ 142s] dh_installexamples -O--buildsystem=cmake -O--builddirectory=build [ 142s] dh_perl -O--buildsystem=cmake -O--builddirectory=build [ 142s] dh_link -O--buildsystem=cmake -O--builddirectory=build [ 143s] dh_strip_nondeterminism -O--buildsystem=cmake -O--builddirectory=build [ 143s] dh_compress -O--buildsystem=cmake -O--builddirectory=build [ 143s] dh_fixperms -O--buildsystem=cmake -O--builddirectory=build [ 144s] dh_strip -O--buildsystem=cmake -O--builddirectory=build [ 144s] dh_makeshlibs -O--buildsystem=cmake -O--builddirectory=build [ 144s] dh_shlibdeps -O--buildsystem=cmake -O--builddirectory=build [ 146s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/arm-linux-gnueabihf/libulfius.so.2.5.2 was not linked against libpthread.so.0 (it uses none of the library's symbols) [ 146s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/arm-linux-gnueabihf/libulfius.so.2.5.2 was not linked against libgnutls.so.30 (it uses none of the library's symbols) [ 146s] dh_installdeb -O--buildsystem=cmake -O--builddirectory=build [ 146s] dh_gencontrol -O--buildsystem=cmake -O--builddirectory=build [ 147s] dpkg-gencontrol: warning: can't parse dependency libyder2.0 = 1.4.4 [ 147s] dpkg-gencontrol: error: error occurred while parsing Depends field: libc6 (>= 2.4), libcurl3-gnutls (>= 7.16.2), libgnutls30 (>= 3.5.0), libjansson4 (>= 2.1), libmicrohttpd12 (>= 0.9.50), liborcania1.2 (>= 1.2.2), libyder2.0 (>= 1.3.3), , libyder2.0 = 1.4.4 [ 147s] dh_gencontrol: dpkg-gencontrol -plibulfius2.5 -ldebian/changelog -Tdebian/libulfius2.5.substvars -Pdebian/.debhelper/libulfius2.5/dbgsym-root -UPre-Depends -URecommends -USuggests -UEnhances -UProvides -UEssential -UConflicts -DPriority=extra -DAuto-Built-Package=debug-symbols -DPackage=libulfius2.5-dbgsym -DDepends=libulfius2.5 (= ${binary:Version}) -DDescription=Debug symbols for libulfius2.5 -DBuild-Ids=2b4ec40fbd103832f2baf5889921bef5c91fa71b -DSection=debug -UReplaces -UBreaks returned exit code 255 [ 147s] debian/rules:9: recipe for target 'binary' failed [ 147s] make: *** [binary] Error 2 [ 147s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 [ 147s] ### VM INTERACTION START ### [ 150s] [ 131.314223] sysrq: SysRq : Power Off [ 150s] [ 131.365848] reboot: Power down [ 150s] ### VM INTERACTION END ### [ 150s] [ 150s] armbuild24 failed "build ulfius_2.5.2-4.2.dsc" at Wed Dec 8 16:37:01 UTC 2021. [ 150s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 8 16:37:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 08 Dec 2021 16:37:08 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_11/aarch64 In-Reply-To: References: Message-ID: <61b0df4b2ac4f_69582abcb473460053128a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_11/aarch64 Package network:osmocom:nightly/ulfius failed to build in Debian_11/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 102s] + ulfius_websocket_client_connection_close at Base 2.5.2-4.2 [ 102s] + ulfius_websocket_client_connection_send_close_signal at Base 2.5.2-4.2 [ 102s] + ulfius_websocket_client_connection_status at Base 2.5.2-4.2 [ 102s] + ulfius_websocket_client_connection_wait_close at Base 2.5.2-4.2 [ 102s] + ulfius_websocket_pop_first_message at Base 2.5.2-4.2 [ 102s] + ulfius_websocket_send_close_signal at Base 2.5.2-4.2 [ 102s] + ulfius_websocket_send_fragmented_message at Base 2.5.2-4.2 [ 102s] + ulfius_websocket_send_message at Base 2.5.2-4.2 [ 102s] + ulfius_websocket_status at Base 2.5.2-4.2 [ 102s] + ulfius_websocket_wait_close at Base 2.5.2-4.2 [ 102s] utf8_check at Base 2.5.0 [ 102s] yuarel_parse at Base 2.5.0 [ 102s] yuarel_parse_query at Base 2.5.0 [ 102s] dh_shlibdeps -O--buildsystem=cmake -O--builddirectory=build [ 103s] dh_installdeb -O--buildsystem=cmake -O--builddirectory=build [ 103s] dh_gencontrol -O--buildsystem=cmake -O--builddirectory=build [ 103s] dpkg-gencontrol: warning: can't parse dependency libyder2.0 = 1.4.4 [ 103s] dpkg-gencontrol: error: parsing package 'libulfius2.5' Depends field: libc6 (>= 2.17), libcurl3-gnutls (>= 7.16.2), libgnutls30 (>= 3.7.0), libjansson4 (>= 2.1), libmicrohttpd12 (>= 0.9.52), liborcania1.2 (>= 1.2.2), libyder2.0 (>= 1.3.3), , libyder2.0 = 1.4.4 [ 103s] dh_gencontrol: error: dpkg-gencontrol -plibulfius2.5 -ldebian/changelog -Tdebian/libulfius2.5.substvars -Pdebian/.debhelper/libulfius2.5/dbgsym-root -UPre-Depends -URecommends -USuggests -UEnhances -UProvides -UEssential -UConflicts -DPriority=optional -UHomepage -UImportant -UBuilt-Using -DAuto-Built-Package=debug-symbols -UProtected -DPackage=libulfius2.5-dbgsym "-DDepends=libulfius2.5 (= \${binary:Version})" "-DDescription=debug symbols for libulfius2.5" -DBuild-Ids=01272f57dc78b84e95503fe87031c5a962130d24 -DSection=debug -UReplaces -UBreaks returned exit code 25 [ 103s] dh_gencontrol: error: Aborting due to earlier error [ 103s] make: *** [debian/rules:9: binary] Error 25 [ 103s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 103s] ### VM INTERACTION START ### [ 107s] [ 76.610585] sysrq: Power Off [ 107s] [ 76.611315] reboot: Power down [ 107s] ### VM INTERACTION END ### [ 107s] [ 107s] obs-arm-10 failed "build ulfius_2.5.2-4.2.dsc" at Wed Dec 8 16:36:55 UTC 2021. [ 107s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 8 16:37:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 08 Dec 2021 16:37:42 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_11/x86_64 In-Reply-To: References: Message-ID: <61b0df6a3f266_69582abcb473460053133a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_11/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_11/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 88s] + ulfius_websocket_client_connection_close at Base 2.5.2-4.2 [ 88s] + ulfius_websocket_client_connection_send_close_signal at Base 2.5.2-4.2 [ 88s] + ulfius_websocket_client_connection_status at Base 2.5.2-4.2 [ 88s] + ulfius_websocket_client_connection_wait_close at Base 2.5.2-4.2 [ 88s] + ulfius_websocket_pop_first_message at Base 2.5.2-4.2 [ 88s] + ulfius_websocket_send_close_signal at Base 2.5.2-4.2 [ 88s] + ulfius_websocket_send_fragmented_message at Base 2.5.2-4.2 [ 88s] + ulfius_websocket_send_message at Base 2.5.2-4.2 [ 88s] + ulfius_websocket_status at Base 2.5.2-4.2 [ 88s] + ulfius_websocket_wait_close at Base 2.5.2-4.2 [ 88s] utf8_check at Base 2.5.0 [ 88s] yuarel_parse at Base 2.5.0 [ 88s] yuarel_parse_query at Base 2.5.0 [ 88s] dh_shlibdeps -O--buildsystem=cmake -O--builddirectory=build [ 89s] dh_installdeb -O--buildsystem=cmake -O--builddirectory=build [ 89s] dh_gencontrol -O--buildsystem=cmake -O--builddirectory=build [ 89s] dpkg-gencontrol: warning: can't parse dependency libyder2.0 = 1.4.4 [ 89s] dpkg-gencontrol: error: parsing package 'libulfius2.5' Depends field: libc6 (>= 2.17), libcurl3-gnutls (>= 7.16.2), libgnutls30 (>= 3.7.0), libjansson4 (>= 2.1), libmicrohttpd12 (>= 0.9.52), liborcania1.2 (>= 1.2.2), libyder2.0 (>= 1.3.3), , libyder2.0 = 1.4.4 [ 89s] dh_gencontrol: error: dpkg-gencontrol -plibulfius2.5 -ldebian/changelog -Tdebian/libulfius2.5.substvars -Pdebian/.debhelper/libulfius2.5/dbgsym-root -UPre-Depends -URecommends -USuggests -UEnhances -UProvides -UEssential -UConflicts -DPriority=optional -UHomepage -UImportant -UBuilt-Using -DAuto-Built-Package=debug-symbols -UProtected -DPackage=libulfius2.5-dbgsym "-DDepends=libulfius2.5 (= \${binary:Version})" "-DDescription=debug symbols for libulfius2.5" -DBuild-Ids=60ef7344675afd2cdf845595d0125683fb1a17e2 -DSection=debug -UReplaces -UBreaks returned exit code 25 [ 89s] dh_gencontrol: error: Aborting due to earlier error [ 89s] make: *** [debian/rules:9: binary] Error 25 [ 89s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 89s] ### VM INTERACTION START ### [ 92s] [ 83.213727] sysrq: Power Off [ 92s] [ 83.216616] reboot: Power down [ 92s] ### VM INTERACTION END ### [ 92s] [ 92s] goat13 failed "build ulfius_2.5.2-4.2.dsc" at Wed Dec 8 16:37:38 UTC 2021. [ 92s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 8 16:39:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 08 Dec 2021 16:39:08 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_11/i586 In-Reply-To: References: Message-ID: <61b0dfc38fc5a_69582abcb47346005316ec@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_11/i586 Package network:osmocom:nightly/ulfius failed to build in Debian_11/i586 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 267s] + ulfius_websocket_client_connection_close at Base 2.5.2-4.2 [ 267s] + ulfius_websocket_client_connection_send_close_signal at Base 2.5.2-4.2 [ 267s] + ulfius_websocket_client_connection_status at Base 2.5.2-4.2 [ 267s] + ulfius_websocket_client_connection_wait_close at Base 2.5.2-4.2 [ 267s] + ulfius_websocket_pop_first_message at Base 2.5.2-4.2 [ 267s] + ulfius_websocket_send_close_signal at Base 2.5.2-4.2 [ 267s] + ulfius_websocket_send_fragmented_message at Base 2.5.2-4.2 [ 267s] + ulfius_websocket_send_message at Base 2.5.2-4.2 [ 267s] + ulfius_websocket_status at Base 2.5.2-4.2 [ 267s] + ulfius_websocket_wait_close at Base 2.5.2-4.2 [ 267s] utf8_check at Base 2.5.0 [ 267s] yuarel_parse at Base 2.5.0 [ 267s] yuarel_parse_query at Base 2.5.0 [ 267s] dh_shlibdeps -O--buildsystem=cmake -O--builddirectory=build [ 269s] dh_installdeb -O--buildsystem=cmake -O--builddirectory=build [ 269s] dh_gencontrol -O--buildsystem=cmake -O--builddirectory=build [ 269s] dpkg-gencontrol: warning: can't parse dependency libyder2.0 = 1.4.4 [ 269s] dpkg-gencontrol: error: parsing package 'libulfius2.5' Depends field: libc6 (>= 2.3.6-6~), libc6 (>= 2.17), libcurl3-gnutls (>= 7.16.2), libgnutls30 (>= 3.7.0), libjansson4 (>= 2.1), libmicrohttpd12 (>= 0.9.52), liborcania1.2 (>= 1.2.2), libyder2.0 (>= 1.3.3), , libyder2.0 = 1.4.4 [ 269s] dh_gencontrol: error: dpkg-gencontrol -plibulfius2.5 -ldebian/changelog -Tdebian/libulfius2.5.substvars -Pdebian/.debhelper/libulfius2.5/dbgsym-root -UPre-Depends -URecommends -USuggests -UEnhances -UProvides -UEssential -UConflicts -DPriority=optional -UHomepage -UImportant -UBuilt-Using -DAuto-Built-Package=debug-symbols -UProtected -DPackage=libulfius2.5-dbgsym "-DDepends=libulfius2.5 (= \${binary:Version})" "-DDescription=debug symbols for libulfius2.5" -DBuild-Ids=0349f69abd9602cc07a8db7f05774ab1f312b685 -DSection=debug -UReplaces -UBreaks returned exit code 25 [ 269s] dh_gencontrol: error: Aborting due to earlier error [ 269s] make: *** [debian/rules:9: binary] Error 25 [ 269s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 269s] ### VM INTERACTION START ### [ 272s] [ 242.808445] sysrq: Power Off [ 272s] [ 242.820028] reboot: Power down [ 272s] ### VM INTERACTION END ### [ 272s] [ 273s] lamb07 failed "build ulfius_2.5.2-4.2.dsc" at Wed Dec 8 16:39:01 UTC 2021. [ 273s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 8 16:40:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 08 Dec 2021 16:40:17 +0000 Subject: Build failure of network:osmocom:latest/ulfius in Debian_9.0/armv7l In-Reply-To: References: Message-ID: <61b0dfff6fdf_69582abcb473460053192@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_9.0/armv7l Package network:osmocom:latest/ulfius failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 132s] dh_install -O--buildsystem=cmake -O--builddirectory=build [ 132s] dh_installdocs -O--buildsystem=cmake -O--builddirectory=build [ 132s] dh_installchangelogs -O--buildsystem=cmake -O--builddirectory=build [ 133s] dh_installexamples -O--buildsystem=cmake -O--builddirectory=build [ 133s] dh_perl -O--buildsystem=cmake -O--builddirectory=build [ 133s] dh_link -O--buildsystem=cmake -O--builddirectory=build [ 133s] dh_strip_nondeterminism -O--buildsystem=cmake -O--builddirectory=build [ 134s] dh_compress -O--buildsystem=cmake -O--builddirectory=build [ 134s] dh_fixperms -O--buildsystem=cmake -O--builddirectory=build [ 134s] dh_strip -O--buildsystem=cmake -O--builddirectory=build [ 135s] dh_makeshlibs -O--buildsystem=cmake -O--builddirectory=build [ 135s] dh_shlibdeps -O--buildsystem=cmake -O--builddirectory=build [ 137s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/arm-linux-gnueabihf/libulfius.so.2.5.2 was not linked against libpthread.so.0 (it uses none of the library's symbols) [ 137s] dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/libulfius2.5/usr/lib/arm-linux-gnueabihf/libulfius.so.2.5.2 was not linked against libgnutls.so.30 (it uses none of the library's symbols) [ 137s] dh_installdeb -O--buildsystem=cmake -O--builddirectory=build [ 137s] dh_gencontrol -O--buildsystem=cmake -O--builddirectory=build [ 137s] dpkg-gencontrol: warning: can't parse dependency libyder2.0 = 1.4.4 [ 137s] dpkg-gencontrol: error: error occurred while parsing Depends field: libc6 (>= 2.4), libcurl3-gnutls (>= 7.16.2), libgnutls30 (>= 3.5.0), libjansson4 (>= 2.1), libmicrohttpd12 (>= 0.9.50), liborcania1.2 (>= 1.2.2), libyder2.0 (>= 1.3.3), , libyder2.0 = 1.4.4 [ 137s] dh_gencontrol: dpkg-gencontrol -plibulfius2.5 -ldebian/changelog -Tdebian/libulfius2.5.substvars -Pdebian/.debhelper/libulfius2.5/dbgsym-root -UPre-Depends -URecommends -USuggests -UEnhances -UProvides -UEssential -UConflicts -DPriority=extra -DAuto-Built-Package=debug-symbols -DPackage=libulfius2.5-dbgsym -DDepends=libulfius2.5 (= ${binary:Version}) -DDescription=Debug symbols for libulfius2.5 -DBuild-Ids=2b4ec40fbd103832f2baf5889921bef5c91fa71b -DSection=debug -UReplaces -UBreaks returned exit code 255 [ 137s] debian/rules:9: recipe for target 'binary' failed [ 137s] make: *** [binary] Error 2 [ 137s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 [ 137s] ### VM INTERACTION START ### [ 140s] [ 125.147417] sysrq: SysRq : Power Off [ 141s] [ 125.168673] reboot: Power down [ 141s] ### VM INTERACTION END ### [ 141s] [ 141s] armbuild24 failed "build ulfius_2.5.2-4.2.dsc" at Wed Dec 8 16:40:14 UTC 2021. [ 141s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:20:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:20:32 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore BRACES_NOT_NECESSARY In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26465 ) Change subject: lint: checkpatch_osmo: ignore BRACES_NOT_NECESSARY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ice08d5b88c683a59bacff999a1d6c07754663d39 Gerrit-Change-Number: 26465 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 08 Dec 2021 19:20:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:20:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:20:37 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore VOLATILE In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26464 ) Change subject: lint: checkpatch_osmo: ignore VOLATILE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie81db479c66749531ed1c81cf076ce248aa22f69 Gerrit-Change-Number: 26464 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 08 Dec 2021 19:20:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:20:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:20:40 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore VOLATILE In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26464 ) Change subject: lint: checkpatch_osmo: ignore VOLATILE ...................................................................... lint: checkpatch_osmo: ignore VOLATILE The warning about potentially using volatile wrong is not useful for us, it makes sense to use it in embedded projects. Related: OS#5087 Related: https://www.kernel.org/doc/html/latest/process/volatile-considered-harmful.html Related: https://gerrit.osmocom.org/c/simtrace2/+/26463 Change-Id: Ie81db479c66749531ed1c81cf076ce248aa22f69 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 126a8b4..ae66e71 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -73,6 +73,7 @@ # * UNNECESSARY_BREAK: not followed (see https://gerrit.osmocom.org/c/libosmo-netif/+/26429) # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) # * UNSPECIFIED_INT: not followed (doesn't seem useful for us) +# * VOLATILE: using volatile makes sense in embedded projects so this warning is not useful for us cd "$PROJECT_DIR" @@ -109,6 +110,7 @@ --ignore UNNECESSARY_BREAK \ --ignore UNNECESSARY_INT \ --ignore UNSPECIFIED_INT \ + --ignore VOLATILE \ --max-line-length 120 \ --no-signoff \ --no-tree \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie81db479c66749531ed1c81cf076ce248aa22f69 Gerrit-Change-Number: 26464 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:20:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:20:41 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore BRACES_NOT_NECESSARY In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26465 ) Change subject: lint: checkpatch_osmo: ignore BRACES_NOT_NECESSARY ...................................................................... lint: checkpatch_osmo: ignore BRACES_NOT_NECESSARY Don't complain about using braces when they could be omitted, for example: if (condition) { single_statement(); } Another example: if (condition) { single_statement(); } else { another_single_statement(); } This is not something we would care about in code review either from what I've seen and so it's probably just annoying for patch authors to fix up. Related: OS#5087 Change-Id: Ice08d5b88c683a59bacff999a1d6c07754663d39 --- M lint/checkpatch/checkpatch.pl M lint/checkpatch/checkpatch_osmo.sh 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl index e31a61f..a4d229c 100755 --- a/lint/checkpatch/checkpatch.pl +++ b/lint/checkpatch/checkpatch.pl @@ -6008,7 +6008,7 @@ $sum_allowed += $_; } if ($sum_allowed == 0) { - WARN("BRACES", + WARN("BRACES_NOT_NECESSARY", # Osmocom specific: renamed from BRACES "braces {} are not necessary for any arm of this statement\n" . $herectx); } elsif ($sum_allowed != $allow && $seen != $allow) { @@ -6064,7 +6064,7 @@ my $cnt = statement_rawlines($block); my $herectx = get_stat_here($linenr, $cnt, $here); - WARN("BRACES", + WARN("BRACES_NOT_NECESSARY", # Osmocom specific: renamed from BRACES "braces {} are not necessary for single statement blocks\n" . $herectx); } } diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index ae66e71..d1ce63a 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -49,6 +49,7 @@ # * ASSIGN_IN_IF: not followed (e.g. 'if ((u8 = gsup_msg->cause))') # * AVOID_EXTERNS: we do use externs # * BLOCK_COMMENT_STYLE: we don't use a trailing */ on a separate line +# * BRACES_NOT_NECESSARY: not followed # * COMPLEX_MACRO: we don't use parentheses when building macros of strings across multiple lines # * CONSTANT_COMPARISON: not followed: "Comparisons should place the constant on the right side" # * DEEP_INDENTATION: warns about many leading tabs, not useful if changing existing code without refactoring @@ -84,6 +85,7 @@ --ignore ASSIGN_IN_IF \ --ignore AVOID_EXTERNS \ --ignore BLOCK_COMMENT_STYLE \ + --ignore BRACES_NOT_NECESSARY \ --ignore COMPLEX_MACRO \ --ignore CONSTANT_COMPARISON \ --ignore DEEP_INDENTATION \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ice08d5b88c683a59bacff999a1d6c07754663d39 Gerrit-Change-Number: 26465 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:42:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:42:36 +0000 Subject: Change in osmo-remsim[master]: Change default FSM log level to INFO In-Reply-To: References: Message-ID: Hello Jenkins Builder, lynxis lazus, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/26470 to look at the new patch set (#3). Change subject: Change default FSM log level to INFO ...................................................................... Change default FSM log level to INFO this will drop printing DEBUG level messages by default. Change-Id: I8ecb17674d480988847d7fa23b586b66fa52010a --- M src/debug.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/70/26470/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8ecb17674d480988847d7fa23b586b66fa52010a Gerrit-Change-Number: 26470 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:42:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:42:36 +0000 Subject: Change in osmo-remsim[master]: [cosmetic] bankd: mark handle_options() as static References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26471 ) Change subject: [cosmetic] bankd: mark handle_options() as static ...................................................................... [cosmetic] bankd: mark handle_options() as static Change-Id: I991542d8fb52cc86e850bf5d20352c802f77c392 --- M src/bankd/bankd_main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/71/26471/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index ecfa22d..a9c7b71 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -286,7 +286,7 @@ static int g_bind_port = 9999; static char *g_bind_ip = NULL; -void handle_options(int argc, char **argv) +static void handle_options(int argc, char **argv) { while (1) { int option_index = 0, c; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I991542d8fb52cc86e850bf5d20352c802f77c392 Gerrit-Change-Number: 26471 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:42:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:42:37 +0000 Subject: Change in osmo-remsim[master]: logging: Print category + level, disable category-hex References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26472 ) Change subject: logging: Print category + level, disable category-hex ...................................................................... logging: Print category + level, disable category-hex Change-Id: I9ae27b78b965d173146583b030fd93e2d70b845e --- M src/bankd/bankd_main.c M src/client/remsim_client_main.c M src/server/remsim_server.c 3 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/72/26472/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index a9c7b71..ff1c439 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -75,6 +75,9 @@ { g_tall_ctx = talloc_named_const(NULL, 0, "global"); osmo_init_logging2(g_tall_ctx, &log_info); + log_set_print_level(osmo_stderr_target, 1); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_category_hex(osmo_stderr_target, false); asn_debug = 0; diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c index bbc2990..19a77e3 100644 --- a/src/client/remsim_client_main.c +++ b/src/client/remsim_client_main.c @@ -169,6 +169,9 @@ msgb_talloc_ctx_init(g_tall_ctx, 0); osmo_init_logging2(g_tall_ctx, &log_info); + log_set_print_level(osmo_stderr_target, 1); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_category_hex(osmo_stderr_target, false); cfg = client_config_init(g_tall_ctx); OSMO_ASSERT(cfg); diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index 7fc2926..676bb9a 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -87,6 +87,9 @@ msgb_talloc_ctx_init(g_tall_ctx, 0); osmo_init_logging2(g_tall_ctx, &log_info); + log_set_print_level(osmo_stderr_target, 1); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_category_hex(osmo_stderr_target, false); handle_options(argc, argv); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26472 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9ae27b78b965d173146583b030fd93e2d70b845e Gerrit-Change-Number: 26472 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:43:12 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:43:12 +0000 Subject: Change in osmo-remsim[master]: bankd_pcsc: Improve logging in non-error case In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26466 ) Change subject: bankd_pcsc: Improve logging in non-error case ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3c77655c5d1f76be778cb8873d8acf1343c87b05 Gerrit-Change-Number: 26466 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 08 Dec 2021 19:43:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:43:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:43:30 +0000 Subject: Change in osmo-remsim[master]: bankd_main: Improve log usefulness In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26467 ) Change subject: bankd_main: Improve log usefulness ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26467 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I992c847e0081bd1cd8a0b70212618c4980d9db81 Gerrit-Change-Number: 26467 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 08 Dec 2021 19:43:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:44:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:44:30 +0000 Subject: Change in osmo-remsim[master]: bankd_pcsc: Don't log every successful SCardTransmit In-Reply-To: References: Message-ID: Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/26468 to look at the new patch set (#3). Change subject: bankd_pcsc: Don't log every successful SCardTransmit ...................................................................... bankd_pcsc: Don't log every successful SCardTransmit Contrary to other operations, SCardTransmit has a much higher frequency and the logs should not be clobbered with "OK" lines all over the place. Change-Id: Icf87b61d71722b2998ae78f9aee7c4ad94c46da7 --- M src/bankd/bankd_pcsc.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/68/26468/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icf87b61d71722b2998ae78f9aee7c4ad94c46da7 Gerrit-Change-Number: 26468 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:44:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:44:44 +0000 Subject: Change in osmo-remsim[master]: bankd_pcsc: Don't log every successful SCardTransmit In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26468 ) Change subject: bankd_pcsc: Don't log every successful SCardTransmit ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icf87b61d71722b2998ae78f9aee7c4ad94c46da7 Gerrit-Change-Number: 26468 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 08 Dec 2021 19:44:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:44:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:44:56 +0000 Subject: Change in osmo-remsim[master]: rspro_client_fsm: Differentiate different log levels In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26469 ) Change subject: rspro_client_fsm: Differentiate different log levels ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26469 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I1bc6d491a8a748cbd729cbdeede60d32bd760a15 Gerrit-Change-Number: 26469 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 08 Dec 2021 19:44:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:45:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:45:16 +0000 Subject: Change in osmo-remsim[master]: bankd_pcsc: Improve logging in non-error case In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26466 ) Change subject: bankd_pcsc: Improve logging in non-error case ...................................................................... bankd_pcsc: Improve logging in non-error case Before this commit, the PCSC operation (e.g. SCardStatus) is only printed in the error case, but not in the debug case. Let's fix that. [000 CONN_CLIENT_MAPPED_CARD] bankd_pcsc.c:196 : OK will become [000 CONN_CLIENT_MAPPED_CARD] bankd_pcsc.c:196 SCardTransmit: OK Change-Id: I3c77655c5d1f76be778cb8873d8acf1343c87b05 --- M src/bankd/bankd_pcsc.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index e0b349c..5bc7bb8 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -178,7 +178,7 @@ LOGW_PCSC_ERROR(w, rv, text); \ goto end; \ } else { \ - LOGW((w), ": OK\n"); \ + LOGW((w), text ": OK\n"); \ } static int pcsc_get_atr(struct bankd_worker *worker) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26466 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3c77655c5d1f76be778cb8873d8acf1343c87b05 Gerrit-Change-Number: 26466 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:45:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:45:16 +0000 Subject: Change in osmo-remsim[master]: bankd_main: Improve log usefulness In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26467 ) Change subject: bankd_main: Improve log usefulness ...................................................................... bankd_main: Improve log usefulness Right now we get duplicate log lines like [000 CONN_CLIENT_MAPPED_CARD] bankd_main.c:662 Rx RSPRO tpduModemToCard [000 CONN_CLIENT_MAPPED_CARD] bankd_main.c:623 tpduModemToCard(0070000001) Where the first line is printed by the generic receive handler for RSPRO messages, while the second line is from the specific handler function handling the specific message type. Let's only print from the generic message handler if no specific handler function exists. Change-Id: I992c847e0081bd1cd8a0b70212618c4980d9db81 --- M src/bankd/bankd_main.c 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index ce34ac2..ecfa22d 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -645,7 +645,7 @@ OSMO_ASSERT(pdu->msg.present == RsproPDUchoice_PR_connectClientReq); - LOGW(worker, "connectClientReq(T=%lu, N='%s', SW='%s', VER='%s')\n", + LOGW(worker, "Rx RSPRO connectClientReq(T=%lu, N='%s', SW='%s', VER='%s')\n", cid->type, cid->name.buf, cid->software.buf, cid->swVersion.buf); /* FIXME: store somewhere? */ @@ -698,7 +698,8 @@ struct bank_slot bslot; int rc; - LOGW(worker, "tpduModemToCard(%s)\n", osmo_hexdump_nospc(mdm2sim->data.buf, mdm2sim->data.size)); + LOGW(worker, "Rx RSPRO tpduModemToCard(%s)\n", + osmo_hexdump_nospc(mdm2sim->data.buf, mdm2sim->data.size)); if (worker->state != BW_ST_CONN_CLIENT_MAPPED_CARD) { LOGW(worker, "Unexpected tpduModemToCaard\n"); @@ -738,7 +739,7 @@ const struct SlotPhysStatus *sps = &cssi->slotPhysStatus; int rc = 0; - LOGW(worker, "clientSlotStatusInd(RST=%s, VCC=%s, CLK=%s)\n", + LOGW(worker, "Rx RSPRO clientSlotStatusInd(RST=%s, VCC=%s, CLK=%s)\n", sps->resetActive ? "ACTIVE" : "INACTIVE", sps->vccPresent ? *sps->vccPresent ? "PRESENT" : "ABSENT" : "NULL", sps->clkActive ? *sps->clkActive ? "ACTIVE" : "INACTIVE" : "NULL"); @@ -757,8 +758,6 @@ { int rc = -100; - LOGW(worker, "Rx RSPRO %s\n", rspro_msgt_name(pdu)); - switch (pdu->msg.present) { case RsproPDUchoice_PR_connectClientReq: rc = worker_handle_connectClientReq(worker, pdu); @@ -771,9 +770,11 @@ rc = 0; break; case RsproPDUchoice_PR_setAtrRes: + LOGW(worker, "Rx RSPRO %s\n", rspro_msgt_name(pdu)); rc = 0; break; default: + LOGW(worker, "Rx RSPRO %s (unhandled)\n", rspro_msgt_name(pdu)); rc = -101; break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26467 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I992c847e0081bd1cd8a0b70212618c4980d9db81 Gerrit-Change-Number: 26467 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:45:34 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:45:34 +0000 Subject: Change in osmo-remsim[master]: Change default log level to INFO In-Reply-To: References: Message-ID: Hello Jenkins Builder, lynxis lazus, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/26470 to look at the new patch set (#5). Change subject: Change default log level to INFO ...................................................................... Change default log level to INFO this will drop printing DEBUG level messages by default. Change-Id: I8ecb17674d480988847d7fa23b586b66fa52010a --- M src/debug.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/70/26470/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8ecb17674d480988847d7fa23b586b66fa52010a Gerrit-Change-Number: 26470 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:45:34 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:45:34 +0000 Subject: Change in osmo-remsim[master]: [cosmetic] bankd: mark handle_options() as static In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/26471 to look at the new patch set (#3). Change subject: [cosmetic] bankd: mark handle_options() as static ...................................................................... [cosmetic] bankd: mark handle_options() as static Change-Id: I991542d8fb52cc86e850bf5d20352c802f77c392 --- M src/bankd/bankd_main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/71/26471/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I991542d8fb52cc86e850bf5d20352c802f77c392 Gerrit-Change-Number: 26471 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:45:34 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:45:34 +0000 Subject: Change in osmo-remsim[master]: logging: Print category + level, disable category-hex In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/26472 to look at the new patch set (#3). Change subject: logging: Print category + level, disable category-hex ...................................................................... logging: Print category + level, disable category-hex Change-Id: I9ae27b78b965d173146583b030fd93e2d70b845e --- M src/bankd/bankd_main.c M src/client/remsim_client_main.c M src/server/remsim_server.c 3 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/72/26472/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26472 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9ae27b78b965d173146583b030fd93e2d70b845e Gerrit-Change-Number: 26472 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:45:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:45:42 +0000 Subject: Change in osmo-remsim[master]: Change default log level to INFO In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26470 ) Change subject: Change default log level to INFO ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8ecb17674d480988847d7fa23b586b66fa52010a Gerrit-Change-Number: 26470 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Wed, 08 Dec 2021 19:45:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 19:45:48 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 19:45:48 +0000 Subject: Change in osmo-remsim[master]: [cosmetic] bankd: mark handle_options() as static In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26471 ) Change subject: [cosmetic] bankd: mark handle_options() as static ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I991542d8fb52cc86e850bf5d20352c802f77c392 Gerrit-Change-Number: 26471 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 08 Dec 2021 19:45:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:17:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:17:24 +0000 Subject: Change in osmo-remsim[master]: logging: Print category + level, disable category-hex In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/26472 to look at the new patch set (#4). Change subject: logging: Print category + level, disable category-hex ...................................................................... logging: Print category + level, disable category-hex Change-Id: I9ae27b78b965d173146583b030fd93e2d70b845e --- M src/bankd/bankd_main.c M src/client/remsim_client_main.c M src/server/remsim_server.c 3 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/72/26472/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26472 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9ae27b78b965d173146583b030fd93e2d70b845e Gerrit-Change-Number: 26472 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:17:25 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:17:25 +0000 Subject: Change in osmo-remsim[master]: Add separate log category for RSPRO protocol References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26473 ) Change subject: Add separate log category for RSPRO protocol ...................................................................... Add separate log category for RSPRO protocol Change-Id: I2e158f5181a24ae2256aae12d26865c4907eabad --- M src/debug.c M src/debug.h M src/rspro_client_fsm.c 3 files changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/73/26473/1 diff --git a/src/debug.c b/src/debug.c index b98ca08..a538697 100644 --- a/src/debug.c +++ b/src/debug.c @@ -36,6 +36,11 @@ .loglevel = LOGL_INFO, .enabled = 1, }, + [DRSPRO] = { + .name = "DRSPRO", + .loglevel = LOGL_INFO, + .enabled = 1, + }, }; const struct log_info log_info = { diff --git a/src/debug.h b/src/debug.h index 2a3e5a3..51331f4 100644 --- a/src/debug.h +++ b/src/debug.h @@ -4,6 +4,7 @@ enum { DMAIN, DST2, + DRSPRO, }; extern const struct log_info log_info; diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 5718015..bfd7ebd 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -68,8 +68,8 @@ { struct msgb *msg = rspro_enc_msg(rspro); if (!msg) { - LOGP(DMAIN, LOGL_ERROR, "Error encoding RSPRO: %s\n", rspro_msgt_name(rspro)); - osmo_log_backtrace(DMAIN, LOGL_ERROR); + LOGP(DRSPRO, LOGL_ERROR, "Error encoding RSPRO: %s\n", rspro_msgt_name(rspro)); + osmo_log_backtrace(DRSPRO, LOGL_ERROR); ASN_STRUCT_FREE(asn_DEF_RsproPDU, rspro); return -1; } @@ -87,7 +87,7 @@ { if (!rspro) { LOGPFSML(srvc->fi, LOGL_ERROR, "Attempt to transmit NULL\n"); - osmo_log_backtrace(DMAIN, LOGL_ERROR); + osmo_log_backtrace(DRSPRO, LOGL_ERROR); return -EINVAL; } if (osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_RSPRO_TX, rspro) < 0) { @@ -432,7 +432,7 @@ .allstate_event_mask = S(SRVC_E_ESTABLISH) | S(SRVC_E_DISCONNECT), .allstate_action = srvc_allstate_action, .timer_cb = server_conn_fsm_timer_cb, - .log_subsys = DMAIN, + .log_subsys = DRSPRO, .event_names = server_conn_fsm_event_names, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26473 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2e158f5181a24ae2256aae12d26865c4907eabad Gerrit-Change-Number: 26473 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:17:25 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:17:25 +0000 Subject: Change in osmo-remsim[master]: switch to libosmocore multihread-logging References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26474 ) Change subject: switch to libosmocore multihread-logging ...................................................................... switch to libosmocore multihread-logging When osmo-remsim was originally developed, libosmocore logging was not yet thread-safe. This meant that the worker threads of remsim-bankd and remsim-server could not log via the libosmocore logging framework but directly used stderr/stdout, which produced rather inconsistent log output. However, since 1.3.0, libosmocore has received support for multi-threaded applications. Let's make use of this and consistently use it in remsim-server and remsim-bankd. This obviously also means adding some more log categories. Change-Id: I7bd5264c559b756927046563a2d00c54826bee9b --- M src/bankd/bankd.h M src/bankd/bankd_main.c M src/debug.c M src/debug.h M src/server/remsim_server.c M src/server/rest_api.c M src/server/rspro_server.c M src/slotmap.c 8 files changed, 34 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/74/26474/1 diff --git a/src/bankd/bankd.h b/src/bankd/bankd.h index 6de3213..c007802 100644 --- a/src/bankd/bankd.h +++ b/src/bankd/bankd.h @@ -20,8 +20,8 @@ extern struct value_string worker_state_names[]; #define LOGW(w, fmt, args...) \ - printf("[%03u %s] %s:%u " fmt, (w)->num, get_value_string(worker_state_names, (w)->state), \ - __FILE__, __LINE__, ## args) + LOGP(DBANKDW, LOGL_INFO, "[%03u %s] " fmt, (w)->num, get_value_string(worker_state_names, (w)->state), \ + ## args) struct bankd; diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 3842b0c..5b70b88 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -80,6 +80,8 @@ log_set_print_category(osmo_stderr_target, 1); log_set_print_category_hex(osmo_stderr_target, 0); osmo_fsm_log_addr(0); + log_set_print_tid(osmo_stderr_target, 1); + log_enable_multithread(); asn_debug = 0; diff --git a/src/debug.c b/src/debug.c index a538697..2dfc16e 100644 --- a/src/debug.c +++ b/src/debug.c @@ -41,6 +41,21 @@ .loglevel = LOGL_INFO, .enabled = 1, }, + [DREST] = { + .name = "DREST", + .loglevel = LOGL_INFO, + .enabled = 1, + }, + [DSLOTMAP] = { + .name = "DSLOTMAP", + .loglevel = LOGL_INFO, + .enabled = 1, + }, + [DBANKDW] = { + .name = "DBANKDW", + .loglevel = LOGL_INFO, + .enabled = 1, + }, }; const struct log_info log_info = { diff --git a/src/debug.h b/src/debug.h index 51331f4..88288ca 100644 --- a/src/debug.h +++ b/src/debug.h @@ -5,6 +5,9 @@ DMAIN, DST2, DRSPRO, + DREST, + DSLOTMAP, + DBANKDW, }; extern const struct log_info log_info; diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index 49107b9..c2d54e5 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -93,6 +93,8 @@ log_set_print_category(osmo_stderr_target, 1); log_set_print_category_hex(osmo_stderr_target, 0); osmo_fsm_log_addr(0); + log_set_print_tid(osmo_stderr_target, 1); + log_enable_multithread(); handle_options(argc, argv); diff --git a/src/server/rest_api.c b/src/server/rest_api.c index ff1b588..540fbd4 100644 --- a/src/server/rest_api.c +++ b/src/server/rest_api.c @@ -304,7 +304,7 @@ rc = write(g_event_ofd.fd, &one, sizeof(one)); if (rc < 8) - fprintf(stderr, "Error writing to eventfd(): %d\n", rc); + LOGP(DREST, LOGL_ERROR, "Error writing to eventfd(): %d\n", rc); } static int api_cb_slotmaps_post(const struct _u_request *req, struct _u_response *resp, void *user_data) @@ -318,7 +318,7 @@ json_req = ulfius_get_json_body_request(req, &json_err); if (!json_req) { - fprintf(stderr, "REST: No JSON Body\n"); + LOGP(DREST, LOGL_NOTICE, "REST: No JSON Body\n"); goto err; } @@ -327,7 +327,7 @@ goto err; map = slotmap_add(g_rps->slotmaps, &slotmap.bank, &slotmap.client); if (!map) { - fprintf(stderr, "REST: Cannot add slotmap\n"); + LOGP(DREST, LOGL_NOTICE, "REST: Cannot add slotmap\n"); goto err; } slotmap_state_change(map, SLMAP_S_NEW, NULL); @@ -511,7 +511,7 @@ ulfius_add_endpoint(&g_instance, &api_endpoints[i]); if (ulfius_start_framework(&g_instance) != U_OK) { - fprintf(stderr, "Cannot start REST API on port %u\n", port); + LOGP(DREST, LOGL_FATAL, "Cannot start REST API on port %u\n", port); return -1; } return 0; diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index b35800f..6514f80 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -709,11 +709,11 @@ /* read from the socket to "confirm" the event and make it non-readable again */ rc = read(ofd->fd, &value, 8); if (rc < 8) { - fprintf(stderr, "Error reading eventfd: %d\n", rc); + LOGP(DMAIN, LOGL_ERROR, "Error reading eventfd: %d\n", rc); return rc; } - printf("rspro_server: Event FD arrived, checking for any pending work\n"); + LOGP(DMAIN, LOGL_INFO, "Event FD arrived, checking for any pending work\n"); pthread_rwlock_rdlock(&srv->rwlock); llist_for_each_entry(conn, &srv->banks, list) { diff --git a/src/slotmap.c b/src/slotmap.c index b837f01..fe0c6b7 100644 --- a/src/slotmap.c +++ b/src/slotmap.c @@ -103,14 +103,14 @@ map = slotmap_by_bank(maps, bank); if (map) { - fprintf(stderr, "BANKD %u:%u already in use, cannot add new map\n", + LOGP(DSLOTMAP, LOGL_ERROR, "BANKD %u:%u already in use, cannot add new map\n", bank->bank_id, bank->slot_nr); return NULL; } map = slotmap_by_client(maps, client); if (map) { - fprintf(stderr, "CLIENT %u:%u already in use, cannot add new map\n", + LOGP(DSLOTMAP, LOGL_ERROR, "CLIENT %u:%u already in use, cannot add new map\n", client->client_id, client->slot_nr); return NULL; } @@ -132,7 +132,7 @@ #endif slotmaps_unlock(maps); - printf("Slot Map %s added\n", slotmap_name(mapname, sizeof(mapname), map)); + LOGP(DSLOTMAP, LOGL_INFO, "Slot Map %s added\n", slotmap_name(mapname, sizeof(mapname), map)); return map; } @@ -142,7 +142,7 @@ { char mapname[64]; - printf("Slot Map %s deleted\n", slotmap_name(mapname, sizeof(mapname), map)); + LOGP(DSLOTMAP, LOGL_INFO, "Slot Map %s deleted\n", slotmap_name(mapname, sizeof(mapname), map)); llist_del(&map->list); #ifdef REMSIM_SERVER -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26474 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I7bd5264c559b756927046563a2d00c54826bee9b Gerrit-Change-Number: 26474 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:29:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:29:44 +0000 Subject: Change in osmo-remsim[master]: logging: Replace maining fprintf() calls with libosmocore logging References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26475 ) Change subject: logging: Replace maining fprintf() calls with libosmocore logging ...................................................................... logging: Replace maining fprintf() calls with libosmocore logging Change-Id: I2a772b3180131923d4e2ee7311670b938cb50fe0 --- M src/bankd/bankd_pcsc.c M src/bankd/driver_core.c M src/bankd/driver_pcsc.c M src/client/remsim_client.c M src/client/remsim_client_main.c M src/client/user_simtrace2.c M src/rspro_util.c 7 files changed, 25 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/75/26475/1 diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index 91eeadd..8202504 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -102,14 +102,16 @@ regex_t compiled_name; int rc; - printf("PC/SC slot name: %u/%u -> regex '%s'\n", sn->slot.bank_id, sn->slot.slot_nr, sn->name_regex); + LOGP(DMAIN, LOGL_INFO, "PC/SC slot name: %u/%u -> regex '%s'\n", + sn->slot.bank_id, sn->slot.slot_nr, sn->name_regex); memset(&compiled_name, 0, sizeof(compiled_name)); rc = regcomp(&compiled_name, sn->name_regex, REG_EXTENDED); if (rc != 0) { char *errmsg = get_regerror(sn, rc, &compiled_name); - fprintf(stderr, "Error compiling regex '%s': %s - Ignoring\n", sn->name_regex, errmsg); + LOGP(DMAIN, LOGL_ERROR, "Error compiling regex '%s': %s - Ignoring\n", + sn->name_regex, errmsg); talloc_free(errmsg); talloc_free(sn); } else { @@ -141,7 +143,8 @@ while ((bytes_read = fread(buf, 1, sizeof(buf), fp)) > 0) { if (csv_parse(&p, buf, bytes_read, cb1, cb2, &ps) != bytes_read) { - fprintf(stderr, "Error parsing CSV: %s\n", csv_strerror(csv_error(&p))); + LOGP(DMAIN, LOGL_FATAL, "Error parsing bankd PC/SC CSV: %s\n", + csv_strerror(csv_error(&p))); fclose(fp); return -1; } diff --git a/src/bankd/driver_core.c b/src/bankd/driver_core.c index dbdf23f..57ae3cd 100644 --- a/src/bankd/driver_core.c +++ b/src/bankd/driver_core.c @@ -28,6 +28,7 @@ #include #include "internal.h" +#include "debug.h" static LLIST_HEAD(g_card_reader_drivers); static LLIST_HEAD(g_card_readers); @@ -46,7 +47,7 @@ llist_add(&cr->list, &g_card_readers); - printf("allocated reader '%s'\n", cr->name); + LOGP(DMAIN, LOGL_INFO, "allocated reader '%s'\n", cr->name); return cr; } @@ -78,7 +79,7 @@ struct card_reader_driver *drv; llist_for_each_entry(drv, &g_card_reader_drivers, list) { - printf("probing driver '%s' for drivers\n", drv->name); + LOGP(DMAIN, LOGL_INFO, "probing driver '%s' for drivers\n", drv->name); drv->ops->probe(ctx); } } diff --git a/src/bankd/driver_pcsc.c b/src/bankd/driver_pcsc.c index 03a7f32..2ba7eb5 100644 --- a/src/bankd/driver_pcsc.c +++ b/src/bankd/driver_pcsc.c @@ -36,13 +36,14 @@ #include #include "internal.h" +#include "debug.h" #define PCSC_ERROR(rv, text) \ if (rv != SCARD_S_SUCCESS) { \ - fprintf(stderr, text ": %s (0x%lX)\n", pcsc_stringify_error(rv), rv); \ + LOGP(DMAIN, LOGL_ERROR, text ": %s (0x%lX)\n", pcsc_stringify_error(rv), rv); \ goto end; \ } else { \ - printf(text ": OK\n\n"); \ + LOGP(DMAIN, LOGL_DEBUG, ": OK\n\n"); \ } static void pcsc_readers_probe(void *ctx) @@ -73,7 +74,7 @@ num_readers++; } - printf("num_readers=%d\n", num_readers); + LOGP(DMAIN, LOGL_DEBUG, "num_readers=%d\n", num_readers); end: if (mszReaders) diff --git a/src/client/remsim_client.c b/src/client/remsim_client.c index 182894f..388aa26 100644 --- a/src/client/remsim_client.c +++ b/src/client/remsim_client.c @@ -140,7 +140,7 @@ bc->main_fi = main_fsm_alloc(bc, bc); if (!bc->main_fi) { - fprintf(stderr, "Unable to create main client FSM: %s\n", strerror(errno)); + LOGP(DMAIN, LOGL_FATAL, "Unable to create main client FSM: %s\n", strerror(errno)); exit(1); } @@ -158,7 +158,7 @@ rc = server_conn_fsm_alloc(bc, srvc); if (rc < 0) { - fprintf(stderr, "Unable to create Server conn FSM: %s\n", strerror(errno)); + LOGP(DMAIN, LOGL_FATAL, "Unable to create Server conn FSM: %s\n", strerror(errno)); exit(1); } osmo_fsm_inst_change_parent(srvc->fi, bc->main_fi, MF_E_SRVC_LOST); @@ -171,7 +171,7 @@ memcpy(&bankdc->own_comp_id, &srvc->own_comp_id, sizeof(bankdc->own_comp_id)); rc = server_conn_fsm_alloc(bc, bankdc); if (rc < 0) { - fprintf(stderr, "Unable to connect bankd conn FSM: %s\n", strerror(errno)); + LOGP(DMAIN, LOGL_FATAL, "Unable to connect bankd conn FSM: %s\n", strerror(errno)); exit(1); } osmo_fsm_inst_update_id(bankdc->fi, "bankd"); diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c index f064960..47ec8ac 100644 --- a/src/client/remsim_client_main.c +++ b/src/client/remsim_client_main.c @@ -188,7 +188,7 @@ /* Silently (and portably) reap children. */ if (avoid_zombies() < 0) { - fprintf(stderr, "Unable to silently reap children: %s\n", strerror(errno)); + LOGP(DMAIN, LOGL_FATAL, "Unable to silently reap children: %s\n", strerror(errno)); exit(1); } diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c index 8d8a6c9..100d55b 100644 --- a/src/client/user_simtrace2.c +++ b/src/client/user_simtrace2.c @@ -404,7 +404,7 @@ rc = osmo_libusb_init(NULL); if (rc < 0) { - fprintf(stderr, "libusb initialization failed\n"); + LOGP(DMAIN, LOGL_ERROR, "libusb initialization failed\n"); return rc; } @@ -427,7 +427,7 @@ transp->usb_async = true; transp->usb_devh = osmo_libusb_open_claim_interface(NULL, NULL, ifm); if (!transp->usb_devh) { - fprintf(stderr, "can't open USB device\n"); + LOGP(DMAIN, LOGL_ERROR, "can't open USB device\n"); return -1; } @@ -437,14 +437,14 @@ rc = libusb_claim_interface(transp->usb_devh, cfg->usb.if_num); if (rc < 0) { - fprintf(stderr, "can't claim interface %d; rc=%d\n", cfg->usb.if_num, rc); + LOGP(DMAIN, LOGL_ERROR, "can't claim interface %d; rc=%d\n", cfg->usb.if_num, rc); goto close_exit; } rc = osmo_libusb_get_ep_addrs(transp->usb_devh, cfg->usb.if_num, &transp->usb_ep.out, &transp->usb_ep.in, &transp->usb_ep.irq_in); if (rc < 0) { - fprintf(stderr, "can't obtain EP addrs; rc=%d\n", rc); + LOGP(DMAIN, LOGL_ERROR, "can't obtain EP addrs; rc=%d\n", rc); goto close_exit; } diff --git a/src/rspro_util.c b/src/rspro_util.c index ab748f6..a7476dc 100644 --- a/src/rspro_util.c +++ b/src/rspro_util.c @@ -33,6 +33,7 @@ #include #include "rspro_util.h" +#include "debug.h" #define ASN_ALLOC_COPY(out, in) \ do { \ @@ -69,7 +70,7 @@ msg->l2h = msg->data; rval = der_encode_to_buffer(&asn_DEF_RsproPDU, pdu, msgb_data(msg), msgb_tailroom(msg)); if (rval.encoded < 0) { - fprintf(stderr, "Failed to encode %s\n", rval.failed_type->name); + LOGP(DRSPRO, LOGL_ERROR, "Failed to encode %s\n", rval.failed_type->name); msgb_free(msg); return NULL; } @@ -86,10 +87,10 @@ RsproPDU_t *pdu = NULL; asn_dec_rval_t rval; - //printf("decoding %s\n", msgb_hexdump(msg)); + LOGP(DRSPRO, LOGL_DEBUG, "decoding %s\n", msgb_hexdump(msg)); rval = ber_decode(NULL, &asn_DEF_RsproPDU, (void **) &pdu, msgb_l2(msg), msgb_l2len(msg)); if (rval.code != RC_OK) { - fprintf(stderr, "Failed to decode: %d. Consumed %zu of %u bytes\n", + LOGP(DRSPRO, LOGL_ERROR, "Failed to decode: %d. Consumed %zu of %u bytes\n", rval.code, rval.consumed, msgb_length(msg)); return NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2a772b3180131923d4e2ee7311670b938cb50fe0 Gerrit-Change-Number: 26475 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:30:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:30:03 +0000 Subject: Change in osmo-remsim[master]: bankd_pcsc: Don't log every successful SCardTransmit In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26468 ) Change subject: bankd_pcsc: Don't log every successful SCardTransmit ...................................................................... bankd_pcsc: Don't log every successful SCardTransmit Contrary to other operations, SCardTransmit has a much higher frequency and the logs should not be clobbered with "OK" lines all over the place. Change-Id: Icf87b61d71722b2998ae78f9aee7c4ad94c46da7 --- M src/bankd/bankd_pcsc.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index 5bc7bb8..91eeadd 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -297,9 +297,10 @@ long rc; rc = SCardTransmit(worker->reader.pcsc.hCard, pioSendPci, out, out_len, &pioRecvPci, in, in_len); - PCSC_ERROR(worker, rc, "SCardTransmit"); + /* don't use PCSC_ERROR here as we don't want to log every successful SCardTransmit */ + if (rc != SCARD_S_SUCCESS) + LOGW_PCSC_ERROR(worker, rc, "SCardTransmit"); -end: return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icf87b61d71722b2998ae78f9aee7c4ad94c46da7 Gerrit-Change-Number: 26468 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:30:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:30:03 +0000 Subject: Change in osmo-remsim[master]: rspro_client_fsm: Differentiate different log levels In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26469 ) Change subject: rspro_client_fsm: Differentiate different log levels ...................................................................... rspro_client_fsm: Differentiate different log levels Raw Rx/Tx of messages should be LOGL_DEBUG, while connection establishment/loss should be something like LOGL_NOTICE. Change-Id: I1bc6d491a8a748cbd729cbdeede60d32bd760a15 --- M src/rspro_client_fsm.c 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 36a3016..5718015 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -79,7 +79,7 @@ static int _server_conn_send_rspro(struct rspro_server_conn *srvc, RsproPDU_t *rspro) { - LOGPFSM(srvc->fi, "Tx RSPRO %s\n", rspro_msgt_name(rspro)); + LOGPFSML(srvc->fi, LOGL_DEBUG, "Tx RSPRO %s\n", rspro_msgt_name(rspro)); return ipa_client_conn_send_rspro(srvc->conn, rspro); } @@ -124,7 +124,8 @@ { struct rspro_server_conn *srvc = conn->data; - LOGPFSM(srvc->fi, "RSPRO link to %s:%d %s\n", conn->addr, conn->port, up ? "UP" : "DOWN"); + LOGPFSML(srvc->fi, LOGL_NOTICE, "RSPRO link to %s:%d %s\n", + conn->addr, conn->port, up ? "UP" : "DOWN"); osmo_fsm_inst_dispatch(srvc->fi, up ? SRVC_E_TCP_UP: SRVC_E_TCP_DOWN, 0); } @@ -162,7 +163,7 @@ msg->l2h = &he->data[0]; switch (he->proto) { case IPAC_PROTO_EXT_RSPRO: - LOGPFSM(srvc->fi, "Received RSPRO %s\n", msgb_hexdump(msg)); + LOGPFSML(srvc->fi, LOGL_DEBUG, "Received RSPRO %s\n", msgb_hexdump(msg)); pdu = rspro_dec_msg(msg); if (!pdu) { rc = -EIO; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26469 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I1bc6d491a8a748cbd729cbdeede60d32bd760a15 Gerrit-Change-Number: 26469 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:30:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:30:03 +0000 Subject: Change in osmo-remsim[master]: Change default log level to INFO In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26470 ) Change subject: Change default log level to INFO ...................................................................... Change default log level to INFO this will drop printing DEBUG level messages by default. Change-Id: I8ecb17674d480988847d7fa23b586b66fa52010a --- M src/debug.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/debug.c b/src/debug.c index 91c2f71..b98ca08 100644 --- a/src/debug.c +++ b/src/debug.c @@ -28,7 +28,7 @@ static const struct log_info_cat default_categories[] = { [DMAIN] = { .name = "DMAIN", - .loglevel = LOGL_DEBUG, + .loglevel = LOGL_INFO, .enabled = 1, }, [DST2] = { -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8ecb17674d480988847d7fa23b586b66fa52010a Gerrit-Change-Number: 26470 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:30:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:30:03 +0000 Subject: Change in osmo-remsim[master]: [cosmetic] bankd: mark handle_options() as static In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26471 ) Change subject: [cosmetic] bankd: mark handle_options() as static ...................................................................... [cosmetic] bankd: mark handle_options() as static Change-Id: I991542d8fb52cc86e850bf5d20352c802f77c392 --- M src/bankd/bankd_main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index ecfa22d..a9c7b71 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -286,7 +286,7 @@ static int g_bind_port = 9999; static char *g_bind_ip = NULL; -void handle_options(int argc, char **argv) +static void handle_options(int argc, char **argv) { while (1) { int option_index = 0, c; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I991542d8fb52cc86e850bf5d20352c802f77c392 Gerrit-Change-Number: 26471 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:30:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:30:42 +0000 Subject: Change in osmo-remsim[master]: logging: Print category + level, disable category-hex In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26472 ) Change subject: logging: Print category + level, disable category-hex ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26472 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9ae27b78b965d173146583b030fd93e2d70b845e Gerrit-Change-Number: 26472 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 08 Dec 2021 20:30:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:30:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:30:51 +0000 Subject: Change in osmo-remsim[master]: Add separate log category for RSPRO protocol In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26473 ) Change subject: Add separate log category for RSPRO protocol ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26473 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2e158f5181a24ae2256aae12d26865c4907eabad Gerrit-Change-Number: 26473 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 08 Dec 2021 20:30:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:31:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:31:11 +0000 Subject: Change in osmo-remsim[master]: logging: Print category + level, disable category-hex In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26472 ) Change subject: logging: Print category + level, disable category-hex ...................................................................... logging: Print category + level, disable category-hex Change-Id: I9ae27b78b965d173146583b030fd93e2d70b845e --- M src/bankd/bankd_main.c M src/client/remsim_client_main.c M src/server/remsim_server.c 3 files changed, 17 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index a9c7b71..3842b0c 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -39,6 +39,7 @@ #include #include #include +#include #include #include @@ -75,6 +76,10 @@ { g_tall_ctx = talloc_named_const(NULL, 0, "global"); osmo_init_logging2(g_tall_ctx, &log_info); + log_set_print_level(osmo_stderr_target, 1); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_category_hex(osmo_stderr_target, 0); + osmo_fsm_log_addr(0); asn_debug = 0; diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c index bbc2990..f064960 100644 --- a/src/client/remsim_client_main.c +++ b/src/client/remsim_client_main.c @@ -6,6 +6,8 @@ #include #include +#include +#include #include #include "client.h" @@ -169,6 +171,10 @@ msgb_talloc_ctx_init(g_tall_ctx, 0); osmo_init_logging2(g_tall_ctx, &log_info); + log_set_print_level(osmo_stderr_target, 1); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_category_hex(osmo_stderr_target, 0); + osmo_fsm_log_addr(0); cfg = client_config_init(g_tall_ctx); OSMO_ASSERT(cfg); diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index 7fc2926..49107b9 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -8,6 +8,8 @@ #include #include +#include +#include #include #include @@ -87,6 +89,10 @@ msgb_talloc_ctx_init(g_tall_ctx, 0); osmo_init_logging2(g_tall_ctx, &log_info); + log_set_print_level(osmo_stderr_target, 1); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_category_hex(osmo_stderr_target, 0); + osmo_fsm_log_addr(0); handle_options(argc, argv); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26472 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9ae27b78b965d173146583b030fd93e2d70b845e Gerrit-Change-Number: 26472 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:31:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:31:11 +0000 Subject: Change in osmo-remsim[master]: Add separate log category for RSPRO protocol In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26473 ) Change subject: Add separate log category for RSPRO protocol ...................................................................... Add separate log category for RSPRO protocol Change-Id: I2e158f5181a24ae2256aae12d26865c4907eabad --- M src/debug.c M src/debug.h M src/rspro_client_fsm.c 3 files changed, 10 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/debug.c b/src/debug.c index b98ca08..a538697 100644 --- a/src/debug.c +++ b/src/debug.c @@ -36,6 +36,11 @@ .loglevel = LOGL_INFO, .enabled = 1, }, + [DRSPRO] = { + .name = "DRSPRO", + .loglevel = LOGL_INFO, + .enabled = 1, + }, }; const struct log_info log_info = { diff --git a/src/debug.h b/src/debug.h index 2a3e5a3..51331f4 100644 --- a/src/debug.h +++ b/src/debug.h @@ -4,6 +4,7 @@ enum { DMAIN, DST2, + DRSPRO, }; extern const struct log_info log_info; diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 5718015..bfd7ebd 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -68,8 +68,8 @@ { struct msgb *msg = rspro_enc_msg(rspro); if (!msg) { - LOGP(DMAIN, LOGL_ERROR, "Error encoding RSPRO: %s\n", rspro_msgt_name(rspro)); - osmo_log_backtrace(DMAIN, LOGL_ERROR); + LOGP(DRSPRO, LOGL_ERROR, "Error encoding RSPRO: %s\n", rspro_msgt_name(rspro)); + osmo_log_backtrace(DRSPRO, LOGL_ERROR); ASN_STRUCT_FREE(asn_DEF_RsproPDU, rspro); return -1; } @@ -87,7 +87,7 @@ { if (!rspro) { LOGPFSML(srvc->fi, LOGL_ERROR, "Attempt to transmit NULL\n"); - osmo_log_backtrace(DMAIN, LOGL_ERROR); + osmo_log_backtrace(DRSPRO, LOGL_ERROR); return -EINVAL; } if (osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_RSPRO_TX, rspro) < 0) { @@ -432,7 +432,7 @@ .allstate_event_mask = S(SRVC_E_ESTABLISH) | S(SRVC_E_DISCONNECT), .allstate_action = srvc_allstate_action, .timer_cb = server_conn_fsm_timer_cb, - .log_subsys = DMAIN, + .log_subsys = DRSPRO, .event_names = server_conn_fsm_event_names, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26473 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2e158f5181a24ae2256aae12d26865c4907eabad Gerrit-Change-Number: 26473 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:32:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:32:26 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: rearrange fsm cb events to make debugging easier In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 ) Change subject: slot fsm: rearrange fsm cb events to make debugging easier ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b Gerrit-Change-Number: 26399 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 08 Dec 2021 20:32:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:32:55 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:32:55 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: fake ccid setparameter response In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 ) Change subject: slot fsm: fake ccid setparameter response ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 Gerrit-Change-Number: 26400 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 08 Dec 2021 20:32:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:32:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:32:59 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: rearrange fsm cb events to make debugging easier In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 ) Change subject: slot fsm: rearrange fsm cb events to make debugging easier ...................................................................... slot fsm: rearrange fsm cb events to make debugging easier ..and so I can break on the nop. Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b --- M ccid_common/ccid_slot_fsm.c 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c index 8dccfa5..5ef30a2 100644 --- a/ccid_common/ccid_slot_fsm.c +++ b/ccid_common/ccid_slot_fsm.c @@ -148,6 +148,10 @@ /* continues in iso_fsm_clot_user_cb once ATR is received */ } +#ifndef __NOP +#define __NOP() +#endif + static void iso_fsm_clot_user_cb(struct osmo_fsm_inst *fi, int event, int cause, void *data) { struct iso_fsm_slot *ss = iso7816_fsm_get_user_priv(fi); @@ -159,14 +163,16 @@ case ISO7816_E_HW_ERR_IND: card_uart_ctrl(ss->cuart, CUART_CTL_NO_RXTX, true); break; - case ISO7816_E_ATR_DONE_IND: case ISO7816_E_ATR_ERR_IND: - case ISO7816_E_TPDU_DONE_IND: case ISO7816_E_TPDU_FAILED_IND: - case ISO7816_E_PPS_DONE_IND: case ISO7816_E_PPS_FAILED_IND: case ISO7816_E_PPS_UNSUPPORTED_IND: case ISO7816_E_WTIME_EXP: + __NOP(); + /* no break */ + case ISO7816_E_ATR_DONE_IND: + case ISO7816_E_TPDU_DONE_IND: + case ISO7816_E_PPS_DONE_IND: cs->event_data = data; #ifdef OCTSIMFWBUILD asm volatile("dmb st": : :"memory"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26399 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Idcf076ffbc3fd7698b49b611ac8057939105415b Gerrit-Change-Number: 26399 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 8 20:32:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 8 Dec 2021 20:32:59 +0000 Subject: Change in osmo-ccid-firmware[master]: slot fsm: fake ccid setparameter response In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 ) Change subject: slot fsm: fake ccid setparameter response ...................................................................... slot fsm: fake ccid setparameter response This secretly disables the PPS exchange to set a different baud rate and ensures proper multislot operation at the default rate @ 2.5Mhz. Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 --- M ccid_common/ccid_slot_fsm.c 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c index 5ef30a2..788e3ae 100644 --- a/ccid_common/ccid_slot_fsm.c +++ b/ccid_common/ccid_slot_fsm.c @@ -32,6 +32,8 @@ #include "iso7816_fsm.h" #include "iso7816_3.h" +#define FAKE_CCID_SETPARAMETERS + struct iso_fsm_slot { /* CCID slot above us */ struct ccid_slot *cs; @@ -280,11 +282,20 @@ * - after ATR while card is idle * - after PPS while card is idle */ +#ifndef FAKE_CCID_SETPARAMETERS card_uart_ctrl(ss->cuart, CUART_CTL_SET_CLOCK_FREQ, fmax); card_uart_ctrl(ss->cuart, CUART_CTL_SET_FD, F/D); card_uart_ctrl(ss->cuart, CUART_CTL_WTIME, cs->proposed_pars.t0.waiting_integer * 960 * D_or_one); cs->pars = cs->proposed_pars; +#else + //card_uart_ctrl(ss->cuart, CUART_CTL_SET_CLOCK_FREQ, fmax); + card_uart_ctrl(ss->cuart, CUART_CTL_SET_FD, F/D); + //card_uart_ctrl(ss->cuart, CUART_CTL_WTIME, cs->proposed_pars.t0.waiting_integer); + + cs->pars.fi = cs->proposed_pars.fi; + cs->pars.di = cs->proposed_pars.di; +#endif resp = ccid_gen_parameters_t0(cs, ss->seq, CCID_CMD_STATUS_OK, 0); ccid_slot_send_unbusy(cs, resp); @@ -408,8 +419,13 @@ LOGPCS(cs, LOGL_DEBUG, "scheduling PPS transfer, PPS1: %2x\n", PPS1); +#ifdef FAKE_CCID_SETPARAMETERS + ccid_slot_send_unbusy(cs, ccid_gen_parameters_t0(cs, ss->seq, CCID_CMD_STATUS_OK, 0)); +#else /* pass PPS1 instead of msgb */ osmo_fsm_inst_dispatch(ss->fi, ISO7816_E_XCEIVE_PPS_CMD, (void*)PPS1); +#endif + /* continues in iso_fsm_clot_user_cb once response/error/timeout is received */ return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I72bd2bbabe55c00e771626d2e473f6f8e88793d2 Gerrit-Change-Number: 26400 Gerrit-PatchSet: 8 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 06:58:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 06:58:31 +0000 Subject: Change in osmo-remsim[master]: logging: Replace remaining fprintf() calls with libosmocore logging In-Reply-To: References: Message-ID: Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/26475 to look at the new patch set (#2). Change subject: logging: Replace remaining fprintf() calls with libosmocore logging ...................................................................... logging: Replace remaining fprintf() calls with libosmocore logging Change-Id: I2a772b3180131923d4e2ee7311670b938cb50fe0 --- M src/bankd/bankd_pcsc.c M src/bankd/driver_core.c M src/bankd/driver_pcsc.c M src/client/remsim_client.c M src/client/remsim_client_main.c M src/client/user_simtrace2.c M src/rspro_util.c 7 files changed, 25 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/75/26475/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2a772b3180131923d4e2ee7311670b938cb50fe0 Gerrit-Change-Number: 26475 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 07:01:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 07:01:50 +0000 Subject: Change in osmo-remsim[master]: increase required libosmocore version References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26476 ) Change subject: increase required libosmocore version ...................................................................... increase required libosmocore version osmo-remsim depends on a variety of modern libosmocore features, and now that libosmocore 1.6.0 has been tagged, we can finally depend on a more recent minimum version. Change-Id: Ic3cb86b5be524f15d118bcb7ec1947608fbbb034 --- M configure.ac M contrib/osmo-remsim.spec.in M debian/control 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/76/26476/1 diff --git a/configure.ac b/configure.ac index 400578b..45fbdee 100644 --- a/configure.ac +++ b/configure.ac @@ -33,7 +33,7 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -PKG_CHECK_MODULES(OSMOCORE, libosmocore >= 1.3.0) +PKG_CHECK_MODULES(OSMOCORE, libosmocore >= 1.6.0) PKG_CHECK_MODULES(OSMOGSM, libosmogsm >= 0.11.0) PKG_CHECK_MODULES(OSMOABIS, libosmoabis >= 0.8.0) diff --git a/contrib/osmo-remsim.spec.in b/contrib/osmo-remsim.spec.in index 90ef773..bfc5f36 100644 --- a/contrib/osmo-remsim.spec.in +++ b/contrib/osmo-remsim.spec.in @@ -31,7 +31,7 @@ %endif BuildRequires: pkgconfig(libasn1c) >= 0.9.30 BuildRequires: pkgconfig(libosmoabis) -BuildRequires: pkgconfig(libosmocore) >= 0.11.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 BuildRequires: pkgconfig(libosmogsm) >= 0.11.0 BuildRequires: pkgconfig(libosmosim) BuildRequires: pkgconfig(libpcsclite) diff --git a/debian/control b/debian/control index bdae589..faef9ee 100644 --- a/debian/control +++ b/debian/control @@ -9,7 +9,7 @@ pkg-config, osmo-gsm-manuals-dev, libcsv-dev, - libosmocore-dev (>= 1.3.0), + libosmocore-dev (>= 1.6.0), libosmo-abis-dev, libosmo-simtrace2-dev, libpcsclite-dev, -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26476 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic3cb86b5be524f15d118bcb7ec1947608fbbb034 Gerrit-Change-Number: 26476 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 07:14:08 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 07:14:08 +0000 Subject: Change in simtrace2[master]: host: Upgrade libosmocore dependency to 1.4.0 References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26477 ) Change subject: host: Upgrade libosmocore dependency to 1.4.0 ...................................................................... host: Upgrade libosmocore dependency to 1.4.0 1.4.0 contains the most recent changes to libosmousb, so let's use that as a minimum basis. Change-Id: Ia44377cd6a8d7998c6995a3f89adb22cdc675601 --- M debian/control M host/configure.ac 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/77/26477/1 diff --git a/debian/control b/debian/control index cbe9f75..16e6af5 100644 --- a/debian/control +++ b/debian/control @@ -10,7 +10,7 @@ pkg-config, git, dh-autoreconf, - libosmocore-dev, + libosmocore-dev (>= 1.4.0), libpcsclite-dev, libnewlib-arm-none-eabi, libusb-1.0-0-dev, diff --git a/host/configure.ac b/host/configure.ac index 2e4dcf7..8ba9930 100644 --- a/host/configure.ac +++ b/host/configure.ac @@ -56,9 +56,9 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.0.0) -PKG_CHECK_MODULES(LIBOSMOSIM, libosmosim >= 1.0.0) -PKG_CHECK_MODULES(LIBOSMOUSB, libosmousb >= 0.0.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.4.0) +PKG_CHECK_MODULES(LIBOSMOSIM, libosmosim >= 1.4.0) +PKG_CHECK_MODULES(LIBOSMOUSB, libosmousb >= 1.4.0) PKG_CHECK_MODULES(LIBUSB, libusb-1.0) AC_ARG_ENABLE(sanitize, -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26477 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ia44377cd6a8d7998c6995a3f89adb22cdc675601 Gerrit-Change-Number: 26477 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 07:14:08 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 07:14:08 +0000 Subject: =?UTF-8?Q?Change_in_simtrace2=5Bmaster=5D=3A_Bump_version=3A_0=2E7=2E0=2E166-61b4-dirty_=E2=86=92_0=2E8=2E0?= References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26478 ) Change subject: Bump version: 0.7.0.166-61b4-dirty ? 0.8.0 ...................................................................... Bump version: 0.7.0.166-61b4-dirty ? 0.8.0 Change-Id: I1650f7181cf514ba00e6f70e8133ee88780ebf41 --- M debian/changelog M debian/control R debian/libosmo-simtrace2-1.install M host/lib/Makefile.am 4 files changed, 203 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/78/26478/1 diff --git a/debian/changelog b/debian/changelog index ccebd49..38fdd6b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,8 +1,205 @@ -simtrace2 (0.5.2) UNRELEASED; urgency=medium +simtrace2 (0.8.0) unstable; urgency=medium + [ Harald Welte ] * adapt to host tools in autotools + * simtrace2_api: Remove dead code + * fix baudrate of 'make log' + * qmod DFU: Don't overwrite memory beyond end of usb_strings[] + * usb_strings.txt: s/SIMtrace Phone/SIMtrace Card Emulation/ + * Patch actual board name into the USB iProduct string descriptor + * Build only 'reasonable' combinations of APP/MEMORY + * stdio: Add support for %p format string (pointer address) + * Fix format string related warnings (int vs. long) + * Add missing CR to achieve CRLF at end of log lines + * more comments in host_communication.c. + * usb_buf: count number of elements in queue + * usb_buf: Limit the maximum queue length to 3 elements + * qmod: Don't print EEPROM operations in help when not supported + * cosmetic: board_qmod: Annotate #endif with comments + * qmod: Document '!' and '@' commands on UART + * implement minimalistic talloc_report(); add 't' command on UART + * update copyright statement + * cardem: Fix memory leak on unsupported SIMTRACE_MSGT_DT_CEMU_CARDINSERT + * usb_buf: Actually limit queue to 3 elements, not 4 + * USBD_HAL: Don't disable UDP peripheral clock on suspend + * usb_buf: Properly initialize buffered_endpoint->ep number + * pseudo_talloc: Increment number of buffers from 10 to 20 + * card_emu: Factor out card_handle_reset() from card_emu_init() + * cardem: Move card_emu_io_statechg() calls out of interrupt context + * cardem: RST resets all state (including release of buffers) + * host_communication: Send zero-length-packet on wMaxPacketSize + * card_emu: Initialize PTSS state every time we start PTS + * card_emu: Avoid recursive calls to card_set_state() + * card_emu: Always print state names in string representation + * card_emu: Remove extraneous code + * card_emu: Remove extraneous initialization of ch->pts.state + * cardem: Make card_emu_report_status() optionally use IRQ endpoint + * cardem: Add SIMTRACE_MSGT_BD_CEMU_CONFIG + * cardem: Implement support for CEMU_FEAT_F_STATUS_IRQ + * simtrace2-sniff: Reformat value_string to pass our validation scripts + * firmware: Reformat value_string to pass our validation scripts + * jenkins.sh: Add verify_value_string_arrays_are_terminated.py + * [lib] apdu_dispatch: Use DLGLOBAL and don't printf() directly + * [lib] apdu_dispatch: Don't print APDU state to stdout + * OSMO_ASSERT() on double-free or invalid pointer + * Update .gitignore file for host + * migrate to libosmousb + * library: Add osmo_st2_compatible_dev_idsp[] + * firmware: move printing of welcome banner to common function print_banner() + * firmware: apps/cardem/main.c: Synchronize with apps/trace/main.c + * host: Add COPYING file for host software (GPLv2) + * host/lib/gsmtap.c: Add GPLv2 disclaimer + * increase ringbuffer size from 512 to 1024 bytes + * simtrace2_api: Add osmo_st2_cardem_request_config() + * Disable interrupts during EEFC_ReadUniqueID() + * cardem: Fix infinite loop + watchdog reset on long OUT message + * extend osmo_st2_cardem_inst with fields required by osmo-remsim + * cosmetic: Add missing CR to LF in dispatch_received_usb_msg() + * USBD.c: Don't reset EP0 on SetConfiguration(0) + * pio_it.c: Permit repeated calls to PIO_ConfigureIt() + * simtrace2_siff: getopt_long() returns int, not char + * Introduce support for asynchronous USB transmission + * firmware: fix builds with gcc stack smashing protection enabled + * dfu: Shrink code by 144 bytes (by not calling PIO_InitializeInterrupts) + * dfu: Save another 60 bytes by changing the way we print horizontal lines + * migrate from BSC_FD_* to OSMO_FD_* + * remove usb2udp + * rename simtrace2-remsim to simtrace2-cardem-pcsc + * Update README + * remove old pre-autoconf makefile + * simtrace2-cardem-pcsc: Make it work again + * Revert "add ISO 7816-3 library to remsim project" + * Revert "add library providing ISO 7816-3 utilities" + * card_emu: waiting_time is stored in etu, not clocks. + * card_emu: Rename fi to Fi and di to Di + * card_emu: Clarify and differentiate F/Fi/F_index/Fi_index + * iso7816_fidi: Add iso7816_3_ prefix to symbols; fix terminology + * card_emu: improve reset detection conditions + * card_emu: explicitly initialize PTS and TPDU states + * card_emu: Use USART timeout for waiting time + * card_emu: Fix USART timer, particularly in re-start situations + * card_emu: Fix computation of waiting time + * contrib/jenkins.sh: Switch from rita -> ftp.osmocom.org + * st2-cardem-pcsc: Fix goto-in-while mess + * st2-cardem-pcsc: Use ATR of real card by default + * simtrace board.h: Enable HAVE_CARDEM if we build the cardem firmware + * jenkins.sh: build 'cardem' firmware also for simtrace board + * Revert "cardem: disable upload for simtrace2" + * simtrace2-cardem-pcsc: Decode STATUS flags to strings + * simtrace2-cardem-pcsc: Reset the real card if reader resets cardem + * assert: Use printf_sync() to ensure printing of assert / panic + * Add usb product ID of sysmoOCTSIMTEST + * octsimtest: remove lots of unused #defines + * octsimtest: most code for support of this new board + * octsimtest: Switch direction of I/O level shifter depending on uart tx / rx + * cardem-pcsc: initialize libosmocore logging + * octsimtest: Adjust VCC voltage thresholds (resistive VCC divider) + * contrib/jenkins.sh: Build 'cardem' app for 'octsimtest' board + * firmware: octsimtest: Fix IO_DIR pin definition + * firmware: octsimtest: Make slot mux configurable via USB + * firmware: octsimtest: mcp23017 initializaiton + * firmware: cardem: re-factor CARDINSERT command processing + * firmware: octsimtest: Support SIMTRACE_MSGT_DT_CEMU_CARDINSERT + * firmware: octsimtest: use TRACE_* macros instead of direct printf + * firmware: octsimtest: Fix disabling the card_insert signal + * firmware: octsimtest: Add i/I command for setting card-insert via I2C GPIO + * firmware: octsimtest: ensure all card_insert GPIO are 0 after reset + * don't printf() directly from library code, go via libosmocore logging + * simtrace2-list: Use osmo_st2_compatible_dev_ids[] + * board_gpio.gnumeric: Add ngff-cardem pin-out + * 99-simtrace2.rules: Add OCTSIMTEST + * contrib/flash.py: Add OCTSIMTEST support + * Introduce simtrace2-tool + * introduce support for new ngff_cardem board + * simtrace2.spec: Add simtrace2-tool binary to package + * contrib/jenkins.sh: Build APP=cardem for BOARD=ngff_cardem + * jenkins.sh: Build 'trace' firmware for ngff_cardem + * Use osmo_libusb_{init,exit}() instead of libusb_{init,exit}() + * simtrace2-cardem-pcsc: Remove double libusb initialization + * simtrace2-tool: Initialize logging to avoid error on first log output + * cardem-pcsc: Fix return of uninitialized variable + * host: Upgrade libosmocore dependency to 1.4.0 - -- Harald Welte Thu, 28 Nov 2019 00:44:57 +0100 + [ K?vin Redon ] + * minor: fix spacing + * minor: updated copyright years + * dfu: minor: make debug output only verbose in info level + * minor: move USB debug output from info to debug level + * minor: improve debug output + * minor : fix typo in comment + * better detect VCC and nRST changes on simtrace2 board + * minor: ignore usbstring binary + * simtrace2-remsim: Use simplest ATR + * cardem: use simplest ATR as default ATR + * minor: fix typo + * DFU: increase USB reset duration to 50 ms + * DFU: restart bootloader when USB conf failed + * Makefile: add linker option showing memory usage + * improve shared bootloader/application memory + * minor: improve trace output + * DFU: add DFU application + * add script to flash latest firmware + * minor: use same LED pattern for cardem as other applications + * cardem: currently simtrace does not support cardem + * add library providing ISO 7816-3 utilities + * add ISO 7816-3 library to remsim project + * rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO} + * minor add comments + * make sim switch board specific + + [ Eric Wild ] + * remsim: allow selecting pcsc reader number + * cardem: disable upload for simtrace2 + * firmware: do not allow undefined symbols + * firmware: allow verbose builds + * cardem: choose a more reasonable default ATR + * contrib: add a basic simtrace lua dissector for wireshark + * cardem: free the buf + * cardemu: support 1v8 for the tester + * firmware: data sections + * firmware: proper makefile deps + * firmware: make the ngff beakout blink + * simtrace2-cardem: use local sim on exit + * contrib: more cardem dissection + * firmware: trace for ngff + * cardem: fix spurious NULL bytes during transfers + * contrib/jenkins.sh: build ngff_Cardem dfu bootloader + * contrib: allow manually forcing bulk simtrace dissection + * contrib/jenkins.sh: lower trace to make bl fit + * Revert "firmware: data sections" + * add the ngff cardem to default build targets + * drop unused exidx sections when linking + * clang build support + * fix bootloader led config crash + * firmware: add bootloader update "app" + * firmware: remove usb pullup that dates back to simtrace1 + * firmware: increase reset delay before usb reattach + * firmware: drop cref printing + * add our default clang-format file + * firmware: add missing usb strings to blupdate that prevented building it + * jenkins: build bootloader updater + * firmware: remove dfu-dfu default target + + [ Oliver Smith ] + * contrib: import RPM spec + * contrib: integrate RPM spec + * d/source/format: new file + * firmware/Makefile: fix UNKNOWN in OBS packages + * host: use git-version-gen/tarball-v. from topdir + * gitignore: add firmware/apps/*/usb_strings.txt.patched + * firmware: create duplicate files for upload only + * contrib/prepare_upload.sh: fix cd problems + * firmware: qmod-dfu: disable stack protector + * firmware: disable stack protector by default + * gitreview: new file + + [ Leonard H?bner ] + * remsim: adding cli argument to set the atr + + [ Eric ] + * dfu: let the device reset itself + + -- Harald Welte Thu, 09 Dec 2021 08:12:56 +0100 simtrace2 (0.5.1) unstable; urgency=medium diff --git a/debian/control b/debian/control index 16e6af5..612e2ca 100644 --- a/debian/control +++ b/debian/control @@ -33,11 +33,11 @@ Section: devel Architecture: any Multi-Arch: same -Depends: ${shlibs:Depends}, ${misc:Depends}, libosmo-simtrace2-0 +Depends: ${shlibs:Depends}, ${misc:Depends}, libosmo-simtrace2-1 Recommends: simtrace2-firmware Description: Host utilities to communicate with SIMtrace2 USB Devices. -Package: libosmo-simtrace2-0 +Package: libosmo-simtrace2-1 Section: libs Architecture: any Multi-Arch: same @@ -52,7 +52,7 @@ Section: libdevel Architecture: any Multi-Arch: same -Depends: libosmo-simtrace2-0, ${misc:Depends} +Depends: libosmo-simtrace2-1, ${misc:Depends} Description: Development headers for Osmocom SIMtrace2 library This library contains core "driver" functionality to interface with the Osmocom SIMtrace2 (and compatible) USB device firmware. It enables diff --git a/debian/libosmo-simtrace2-0.install b/debian/libosmo-simtrace2-1.install similarity index 100% rename from debian/libosmo-simtrace2-0.install rename to debian/libosmo-simtrace2-1.install diff --git a/host/lib/Makefile.am b/host/lib/Makefile.am index 3f7ec8e..e134c75 100644 --- a/host/lib/Makefile.am +++ b/host/lib/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -ST2_LIBVERSION=0:0:0 +ST2_LIBVERSION=1:0:0 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOSIM_CFLAGS) $(LIBUSB_CFLAGS) $(COVERAGE_CFLAGS) -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1650f7181cf514ba00e6f70e8133ee88780ebf41 Gerrit-Change-Number: 26478 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 07:14:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 07:14:36 +0000 Subject: Change in simtrace2[master]: host: Upgrade libosmocore dependency to 1.4.0 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26477 ) Change subject: host: Upgrade libosmocore dependency to 1.4.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26477 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ia44377cd6a8d7998c6995a3f89adb22cdc675601 Gerrit-Change-Number: 26477 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 09 Dec 2021 07:14:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 07:16:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 07:16:44 +0000 Subject: Change in simtrace2[master]: host: Upgrade libosmocore dependency to 1.4.0 In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26477 ) Change subject: host: Upgrade libosmocore dependency to 1.4.0 ...................................................................... host: Upgrade libosmocore dependency to 1.4.0 1.4.0 contains the most recent changes to libosmousb, so let's use that as a minimum basis. Change-Id: Ia44377cd6a8d7998c6995a3f89adb22cdc675601 --- M debian/control M host/configure.ac 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/control b/debian/control index cbe9f75..16e6af5 100644 --- a/debian/control +++ b/debian/control @@ -10,7 +10,7 @@ pkg-config, git, dh-autoreconf, - libosmocore-dev, + libosmocore-dev (>= 1.4.0), libpcsclite-dev, libnewlib-arm-none-eabi, libusb-1.0-0-dev, diff --git a/host/configure.ac b/host/configure.ac index 2e4dcf7..8ba9930 100644 --- a/host/configure.ac +++ b/host/configure.ac @@ -56,9 +56,9 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.0.0) -PKG_CHECK_MODULES(LIBOSMOSIM, libosmosim >= 1.0.0) -PKG_CHECK_MODULES(LIBOSMOUSB, libosmousb >= 0.0.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.4.0) +PKG_CHECK_MODULES(LIBOSMOSIM, libosmosim >= 1.4.0) +PKG_CHECK_MODULES(LIBOSMOUSB, libosmousb >= 1.4.0) PKG_CHECK_MODULES(LIBUSB, libusb-1.0) AC_ARG_ENABLE(sanitize, -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26477 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ia44377cd6a8d7998c6995a3f89adb22cdc675601 Gerrit-Change-Number: 26477 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 07:16:47 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 07:16:47 +0000 Subject: =?UTF-8?Q?Change_in_simtrace2=5Bmaster=5D=3A_Bump_version=3A_0=2E7=2E0=2E166-61b4-dirty_=E2=86=92_0=2E8=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26478 ) Change subject: Bump version: 0.7.0.166-61b4-dirty ? 0.8.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1650f7181cf514ba00e6f70e8133ee88780ebf41 Gerrit-Change-Number: 26478 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 09 Dec 2021 07:16:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 07:16:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 07:16:50 +0000 Subject: =?UTF-8?Q?Change_in_simtrace2=5Bmaster=5D=3A_Bump_version=3A_0=2E7=2E0=2E166-61b4-dirty_=E2=86=92_0=2E8=2E0?= In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26478 ) Change subject: Bump version: 0.7.0.166-61b4-dirty ? 0.8.0 ...................................................................... Bump version: 0.7.0.166-61b4-dirty ? 0.8.0 Change-Id: I1650f7181cf514ba00e6f70e8133ee88780ebf41 --- M debian/changelog M debian/control R debian/libosmo-simtrace2-1.install M host/lib/Makefile.am 4 files changed, 203 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index ccebd49..38fdd6b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,8 +1,205 @@ -simtrace2 (0.5.2) UNRELEASED; urgency=medium +simtrace2 (0.8.0) unstable; urgency=medium + [ Harald Welte ] * adapt to host tools in autotools + * simtrace2_api: Remove dead code + * fix baudrate of 'make log' + * qmod DFU: Don't overwrite memory beyond end of usb_strings[] + * usb_strings.txt: s/SIMtrace Phone/SIMtrace Card Emulation/ + * Patch actual board name into the USB iProduct string descriptor + * Build only 'reasonable' combinations of APP/MEMORY + * stdio: Add support for %p format string (pointer address) + * Fix format string related warnings (int vs. long) + * Add missing CR to achieve CRLF at end of log lines + * more comments in host_communication.c. + * usb_buf: count number of elements in queue + * usb_buf: Limit the maximum queue length to 3 elements + * qmod: Don't print EEPROM operations in help when not supported + * cosmetic: board_qmod: Annotate #endif with comments + * qmod: Document '!' and '@' commands on UART + * implement minimalistic talloc_report(); add 't' command on UART + * update copyright statement + * cardem: Fix memory leak on unsupported SIMTRACE_MSGT_DT_CEMU_CARDINSERT + * usb_buf: Actually limit queue to 3 elements, not 4 + * USBD_HAL: Don't disable UDP peripheral clock on suspend + * usb_buf: Properly initialize buffered_endpoint->ep number + * pseudo_talloc: Increment number of buffers from 10 to 20 + * card_emu: Factor out card_handle_reset() from card_emu_init() + * cardem: Move card_emu_io_statechg() calls out of interrupt context + * cardem: RST resets all state (including release of buffers) + * host_communication: Send zero-length-packet on wMaxPacketSize + * card_emu: Initialize PTSS state every time we start PTS + * card_emu: Avoid recursive calls to card_set_state() + * card_emu: Always print state names in string representation + * card_emu: Remove extraneous code + * card_emu: Remove extraneous initialization of ch->pts.state + * cardem: Make card_emu_report_status() optionally use IRQ endpoint + * cardem: Add SIMTRACE_MSGT_BD_CEMU_CONFIG + * cardem: Implement support for CEMU_FEAT_F_STATUS_IRQ + * simtrace2-sniff: Reformat value_string to pass our validation scripts + * firmware: Reformat value_string to pass our validation scripts + * jenkins.sh: Add verify_value_string_arrays_are_terminated.py + * [lib] apdu_dispatch: Use DLGLOBAL and don't printf() directly + * [lib] apdu_dispatch: Don't print APDU state to stdout + * OSMO_ASSERT() on double-free or invalid pointer + * Update .gitignore file for host + * migrate to libosmousb + * library: Add osmo_st2_compatible_dev_idsp[] + * firmware: move printing of welcome banner to common function print_banner() + * firmware: apps/cardem/main.c: Synchronize with apps/trace/main.c + * host: Add COPYING file for host software (GPLv2) + * host/lib/gsmtap.c: Add GPLv2 disclaimer + * increase ringbuffer size from 512 to 1024 bytes + * simtrace2_api: Add osmo_st2_cardem_request_config() + * Disable interrupts during EEFC_ReadUniqueID() + * cardem: Fix infinite loop + watchdog reset on long OUT message + * extend osmo_st2_cardem_inst with fields required by osmo-remsim + * cosmetic: Add missing CR to LF in dispatch_received_usb_msg() + * USBD.c: Don't reset EP0 on SetConfiguration(0) + * pio_it.c: Permit repeated calls to PIO_ConfigureIt() + * simtrace2_siff: getopt_long() returns int, not char + * Introduce support for asynchronous USB transmission + * firmware: fix builds with gcc stack smashing protection enabled + * dfu: Shrink code by 144 bytes (by not calling PIO_InitializeInterrupts) + * dfu: Save another 60 bytes by changing the way we print horizontal lines + * migrate from BSC_FD_* to OSMO_FD_* + * remove usb2udp + * rename simtrace2-remsim to simtrace2-cardem-pcsc + * Update README + * remove old pre-autoconf makefile + * simtrace2-cardem-pcsc: Make it work again + * Revert "add ISO 7816-3 library to remsim project" + * Revert "add library providing ISO 7816-3 utilities" + * card_emu: waiting_time is stored in etu, not clocks. + * card_emu: Rename fi to Fi and di to Di + * card_emu: Clarify and differentiate F/Fi/F_index/Fi_index + * iso7816_fidi: Add iso7816_3_ prefix to symbols; fix terminology + * card_emu: improve reset detection conditions + * card_emu: explicitly initialize PTS and TPDU states + * card_emu: Use USART timeout for waiting time + * card_emu: Fix USART timer, particularly in re-start situations + * card_emu: Fix computation of waiting time + * contrib/jenkins.sh: Switch from rita -> ftp.osmocom.org + * st2-cardem-pcsc: Fix goto-in-while mess + * st2-cardem-pcsc: Use ATR of real card by default + * simtrace board.h: Enable HAVE_CARDEM if we build the cardem firmware + * jenkins.sh: build 'cardem' firmware also for simtrace board + * Revert "cardem: disable upload for simtrace2" + * simtrace2-cardem-pcsc: Decode STATUS flags to strings + * simtrace2-cardem-pcsc: Reset the real card if reader resets cardem + * assert: Use printf_sync() to ensure printing of assert / panic + * Add usb product ID of sysmoOCTSIMTEST + * octsimtest: remove lots of unused #defines + * octsimtest: most code for support of this new board + * octsimtest: Switch direction of I/O level shifter depending on uart tx / rx + * cardem-pcsc: initialize libosmocore logging + * octsimtest: Adjust VCC voltage thresholds (resistive VCC divider) + * contrib/jenkins.sh: Build 'cardem' app for 'octsimtest' board + * firmware: octsimtest: Fix IO_DIR pin definition + * firmware: octsimtest: Make slot mux configurable via USB + * firmware: octsimtest: mcp23017 initializaiton + * firmware: cardem: re-factor CARDINSERT command processing + * firmware: octsimtest: Support SIMTRACE_MSGT_DT_CEMU_CARDINSERT + * firmware: octsimtest: use TRACE_* macros instead of direct printf + * firmware: octsimtest: Fix disabling the card_insert signal + * firmware: octsimtest: Add i/I command for setting card-insert via I2C GPIO + * firmware: octsimtest: ensure all card_insert GPIO are 0 after reset + * don't printf() directly from library code, go via libosmocore logging + * simtrace2-list: Use osmo_st2_compatible_dev_ids[] + * board_gpio.gnumeric: Add ngff-cardem pin-out + * 99-simtrace2.rules: Add OCTSIMTEST + * contrib/flash.py: Add OCTSIMTEST support + * Introduce simtrace2-tool + * introduce support for new ngff_cardem board + * simtrace2.spec: Add simtrace2-tool binary to package + * contrib/jenkins.sh: Build APP=cardem for BOARD=ngff_cardem + * jenkins.sh: Build 'trace' firmware for ngff_cardem + * Use osmo_libusb_{init,exit}() instead of libusb_{init,exit}() + * simtrace2-cardem-pcsc: Remove double libusb initialization + * simtrace2-tool: Initialize logging to avoid error on first log output + * cardem-pcsc: Fix return of uninitialized variable + * host: Upgrade libosmocore dependency to 1.4.0 - -- Harald Welte Thu, 28 Nov 2019 00:44:57 +0100 + [ K?vin Redon ] + * minor: fix spacing + * minor: updated copyright years + * dfu: minor: make debug output only verbose in info level + * minor: move USB debug output from info to debug level + * minor: improve debug output + * minor : fix typo in comment + * better detect VCC and nRST changes on simtrace2 board + * minor: ignore usbstring binary + * simtrace2-remsim: Use simplest ATR + * cardem: use simplest ATR as default ATR + * minor: fix typo + * DFU: increase USB reset duration to 50 ms + * DFU: restart bootloader when USB conf failed + * Makefile: add linker option showing memory usage + * improve shared bootloader/application memory + * minor: improve trace output + * DFU: add DFU application + * add script to flash latest firmware + * minor: use same LED pattern for cardem as other applications + * cardem: currently simtrace does not support cardem + * add library providing ISO 7816-3 utilities + * add ISO 7816-3 library to remsim project + * rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO} + * minor add comments + * make sim switch board specific + + [ Eric Wild ] + * remsim: allow selecting pcsc reader number + * cardem: disable upload for simtrace2 + * firmware: do not allow undefined symbols + * firmware: allow verbose builds + * cardem: choose a more reasonable default ATR + * contrib: add a basic simtrace lua dissector for wireshark + * cardem: free the buf + * cardemu: support 1v8 for the tester + * firmware: data sections + * firmware: proper makefile deps + * firmware: make the ngff beakout blink + * simtrace2-cardem: use local sim on exit + * contrib: more cardem dissection + * firmware: trace for ngff + * cardem: fix spurious NULL bytes during transfers + * contrib/jenkins.sh: build ngff_Cardem dfu bootloader + * contrib: allow manually forcing bulk simtrace dissection + * contrib/jenkins.sh: lower trace to make bl fit + * Revert "firmware: data sections" + * add the ngff cardem to default build targets + * drop unused exidx sections when linking + * clang build support + * fix bootloader led config crash + * firmware: add bootloader update "app" + * firmware: remove usb pullup that dates back to simtrace1 + * firmware: increase reset delay before usb reattach + * firmware: drop cref printing + * add our default clang-format file + * firmware: add missing usb strings to blupdate that prevented building it + * jenkins: build bootloader updater + * firmware: remove dfu-dfu default target + + [ Oliver Smith ] + * contrib: import RPM spec + * contrib: integrate RPM spec + * d/source/format: new file + * firmware/Makefile: fix UNKNOWN in OBS packages + * host: use git-version-gen/tarball-v. from topdir + * gitignore: add firmware/apps/*/usb_strings.txt.patched + * firmware: create duplicate files for upload only + * contrib/prepare_upload.sh: fix cd problems + * firmware: qmod-dfu: disable stack protector + * firmware: disable stack protector by default + * gitreview: new file + + [ Leonard H?bner ] + * remsim: adding cli argument to set the atr + + [ Eric ] + * dfu: let the device reset itself + + -- Harald Welte Thu, 09 Dec 2021 08:12:56 +0100 simtrace2 (0.5.1) unstable; urgency=medium diff --git a/debian/control b/debian/control index 16e6af5..612e2ca 100644 --- a/debian/control +++ b/debian/control @@ -33,11 +33,11 @@ Section: devel Architecture: any Multi-Arch: same -Depends: ${shlibs:Depends}, ${misc:Depends}, libosmo-simtrace2-0 +Depends: ${shlibs:Depends}, ${misc:Depends}, libosmo-simtrace2-1 Recommends: simtrace2-firmware Description: Host utilities to communicate with SIMtrace2 USB Devices. -Package: libosmo-simtrace2-0 +Package: libosmo-simtrace2-1 Section: libs Architecture: any Multi-Arch: same @@ -52,7 +52,7 @@ Section: libdevel Architecture: any Multi-Arch: same -Depends: libosmo-simtrace2-0, ${misc:Depends} +Depends: libosmo-simtrace2-1, ${misc:Depends} Description: Development headers for Osmocom SIMtrace2 library This library contains core "driver" functionality to interface with the Osmocom SIMtrace2 (and compatible) USB device firmware. It enables diff --git a/debian/libosmo-simtrace2-0.install b/debian/libosmo-simtrace2-1.install similarity index 100% rename from debian/libosmo-simtrace2-0.install rename to debian/libosmo-simtrace2-1.install diff --git a/host/lib/Makefile.am b/host/lib/Makefile.am index 3f7ec8e..e134c75 100644 --- a/host/lib/Makefile.am +++ b/host/lib/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -ST2_LIBVERSION=0:0:0 +ST2_LIBVERSION=1:0:0 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOSIM_CFLAGS) $(LIBUSB_CFLAGS) $(COVERAGE_CFLAGS) -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1650f7181cf514ba00e6f70e8133ee88780ebf41 Gerrit-Change-Number: 26478 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 07:20:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 07:20:52 +0000 Subject: Change in osmo-remsim[master]: Depend on libosmo-simtrace >= 0.8.0 References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26479 ) Change subject: Depend on libosmo-simtrace >= 0.8.0 ...................................................................... Depend on libosmo-simtrace >= 0.8.0 Change-Id: I60ae1e097c4182d948ed807ee4ca37f91d32cfae --- M configure.ac M contrib/osmo-remsim.spec.in M debian/control 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/79/26479/1 diff --git a/configure.ac b/configure.ac index 45fbdee..5db0216 100644 --- a/configure.ac +++ b/configure.ac @@ -64,8 +64,8 @@ [osmo_ac_build_client_st2="$enableval"],[osmo_ac_build_client_st2="yes"]) if test "$osmo_ac_build_client_st2" = "yes"; then AC_DEFINE(BUILD_CLIENT_ST2, 1, [Define if we want to build osmo-remsim-client-st2]) - PKG_CHECK_MODULES(OSMOUSB, libosmousb) - PKG_CHECK_MODULES(OSMOSIMTRACE2, libosmo-simtrace2) + PKG_CHECK_MODULES(OSMOUSB, libosmousb >= 1.4.0) + PKG_CHECK_MODULES(OSMOSIMTRACE2, libosmo-simtrace2 >= 0.8.0) PKG_CHECK_MODULES(USB, libusb-1.0) fi AM_CONDITIONAL(BUILD_CLIENT_ST2, test "x$osmo_ac_build_client_st2" = "xyes") diff --git a/contrib/osmo-remsim.spec.in b/contrib/osmo-remsim.spec.in index bfc5f36..2cf0fd3 100644 --- a/contrib/osmo-remsim.spec.in +++ b/contrib/osmo-remsim.spec.in @@ -38,7 +38,7 @@ BuildRequires: pkgconfig(libulfius) BuildRequires: pkgconfig(libusb-1.0) BuildRequires: pkgconfig(libosmousb) -BuildRequires: pkgconfig(libosmo-simtrace2) +BuildRequires: pkgconfig(libosmo-simtrace2) >= 0.8.0 %{?systemd_requires} %description diff --git a/debian/control b/debian/control index faef9ee..7517856 100644 --- a/debian/control +++ b/debian/control @@ -11,7 +11,7 @@ libcsv-dev, libosmocore-dev (>= 1.6.0), libosmo-abis-dev, - libosmo-simtrace2-dev, + libosmo-simtrace2-dev (>= 0.8.0), libpcsclite-dev, libusb-1.0-0-dev, libulfius-dev, -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I60ae1e097c4182d948ed807ee4ca37f91d32cfae Gerrit-Change-Number: 26479 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 07:23:53 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 07:23:53 +0000 Subject: Change in osmo-remsim[master]: Depend on libosmo-simtrace >= 0.8.0 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26479 ) Change subject: Depend on libosmo-simtrace >= 0.8.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I60ae1e097c4182d948ed807ee4ca37f91d32cfae Gerrit-Change-Number: 26479 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 09 Dec 2021 07:23:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 07:23:55 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 07:23:55 +0000 Subject: Change in osmo-remsim[master]: increase required libosmocore version In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26476 ) Change subject: increase required libosmocore version ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26476 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic3cb86b5be524f15d118bcb7ec1947608fbbb034 Gerrit-Change-Number: 26476 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 09 Dec 2021 07:23:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 08:25:20 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 9 Dec 2021 08:25:20 +0000 Subject: =?UTF-8?Q?Change_in_simtrace2=5Bmaster=5D=3A_Bump_version=3A_0=2E7=2E0=2E166-61b4-dirty_=E2=86=92_0=2E8=2E0?= In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26478 ) Change subject: Bump version: 0.7.0.166-61b4-dirty ? 0.8.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I1650f7181cf514ba00e6f70e8133ee88780ebf41 Gerrit-Change-Number: 26478 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 09 Dec 2021 08:25:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 08:33:22 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 9 Dec 2021 08:33:22 +0000 Subject: Change in osmo-remsim[master]: increase required libosmocore version In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26476 ) Change subject: increase required libosmocore version ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26476 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic3cb86b5be524f15d118bcb7ec1947608fbbb034 Gerrit-Change-Number: 26476 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 09 Dec 2021 08:33:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 08:34:55 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 9 Dec 2021 08:34:55 +0000 Subject: Change in osmo-remsim[master]: Depend on libosmo-simtrace >= 0.8.0 In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26479 ) Change subject: Depend on libosmo-simtrace >= 0.8.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I60ae1e097c4182d948ed807ee4ca37f91d32cfae Gerrit-Change-Number: 26479 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 09 Dec 2021 08:34:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 08:51:01 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 9 Dec 2021 08:51:01 +0000 Subject: Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: new job References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26480 ) Change subject: jobs/octsim_osmo-ccid-firmware: new job ...................................................................... jobs/octsim_osmo-ccid-firmware: new job Import the existing (non jenkins-job-builder) job with jenkins-job-wrecker. Change it to fetch the git repository, add missing mkdir so it works with a fresh workspace too. Related: OS#5738 Change-Id: I19d18b24a6ae5948aeaf7c46083748c70cdb3b7b --- A jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 55 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/80/26480/1 diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml new file mode 100644 index 0000000..311be33 --- /dev/null +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -0,0 +1,55 @@ +- job: + axes: + - axis: + name: label + type: slave + values: + - octsimtest + block-downstream: false + block-upstream: false + builders: + - shell: | + cd ./tests + mkdir -p sysmo-octsim/dl + ./run-tests + concurrent: false + description: octsim osmo-ccid-firmware CI - flash every build to octsim and see + if it still works + disabled: false + execution-strategy: + sequential: false + name: octsim_osmo-ccid-firmware + project-type: matrix + scm: + - git: + url: git://git.osmocom.org/osmo-ccid-firmware + git-config-name: 'Jenkins Builder' + git-config-email: 'jenkins at osmocom.org' + skip-tag: true + branches: + - 'origin/master' + properties: + - build-blocker: + block-level: GLOBAL + blocking-jobs: [] + queue-scanning: DISABLED + use-build-blocker: false + - build-discarder: + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 + days-to-keep: 30 + num-to-keep: 120 + - rebuild: + auto-rebuild: false + rebuild-disabled: false + publishers: + - email: + notify-every-unstable-build: true + recipients: jsteiger at sysmocom.de + send-to-individuals: true + retry-count: '3' + triggers: + - reverse: + jobs: master-osmo-ccid-firmware, + - timed: H H * * * + wrappers: [] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I19d18b24a6ae5948aeaf7c46083748c70cdb3b7b Gerrit-Change-Number: 26480 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 09:02:36 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 9 Dec 2021 09:02:36 +0000 Subject: Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: new job In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/26480 to look at the new patch set (#2). Change subject: jobs/octsim_osmo-ccid-firmware: new job ...................................................................... jobs/octsim_osmo-ccid-firmware: new job Import the existing (non jenkins-job-builder) job with jenkins-job-wrecker. Change it to fetch the git repository, add missing mkdir so it works with a fresh workspace too. Fixes: SYS#5738 Change-Id: I19d18b24a6ae5948aeaf7c46083748c70cdb3b7b --- A jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 55 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/80/26480/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I19d18b24a6ae5948aeaf7c46083748c70cdb3b7b Gerrit-Change-Number: 26480 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 10:15:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 10:15:23 +0000 Subject: Change in osmo-remsim[master]: switch to libosmocore multihread-logging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26474 ) Change subject: switch to libosmocore multihread-logging ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26474 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I7bd5264c559b756927046563a2d00c54826bee9b Gerrit-Change-Number: 26474 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Dec 2021 10:15:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 10:15:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 10:15:27 +0000 Subject: Change in osmo-remsim[master]: logging: Replace remaining fprintf() calls with libosmocore logging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26475 ) Change subject: logging: Replace remaining fprintf() calls with libosmocore logging ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2a772b3180131923d4e2ee7311670b938cb50fe0 Gerrit-Change-Number: 26475 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Thu, 09 Dec 2021 10:15:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 10:15:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 10:15:30 +0000 Subject: Change in osmo-remsim[master]: switch to libosmocore multihread-logging In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26474 ) Change subject: switch to libosmocore multihread-logging ...................................................................... switch to libosmocore multihread-logging When osmo-remsim was originally developed, libosmocore logging was not yet thread-safe. This meant that the worker threads of remsim-bankd and remsim-server could not log via the libosmocore logging framework but directly used stderr/stdout, which produced rather inconsistent log output. However, since 1.3.0, libosmocore has received support for multi-threaded applications. Let's make use of this and consistently use it in remsim-server and remsim-bankd. This obviously also means adding some more log categories. Change-Id: I7bd5264c559b756927046563a2d00c54826bee9b --- M src/bankd/bankd.h M src/bankd/bankd_main.c M src/debug.c M src/debug.h M src/server/remsim_server.c M src/server/rest_api.c M src/server/rspro_server.c M src/slotmap.c 8 files changed, 34 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/bankd/bankd.h b/src/bankd/bankd.h index 6de3213..c007802 100644 --- a/src/bankd/bankd.h +++ b/src/bankd/bankd.h @@ -20,8 +20,8 @@ extern struct value_string worker_state_names[]; #define LOGW(w, fmt, args...) \ - printf("[%03u %s] %s:%u " fmt, (w)->num, get_value_string(worker_state_names, (w)->state), \ - __FILE__, __LINE__, ## args) + LOGP(DBANKDW, LOGL_INFO, "[%03u %s] " fmt, (w)->num, get_value_string(worker_state_names, (w)->state), \ + ## args) struct bankd; diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 3842b0c..5b70b88 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -80,6 +80,8 @@ log_set_print_category(osmo_stderr_target, 1); log_set_print_category_hex(osmo_stderr_target, 0); osmo_fsm_log_addr(0); + log_set_print_tid(osmo_stderr_target, 1); + log_enable_multithread(); asn_debug = 0; diff --git a/src/debug.c b/src/debug.c index a538697..2dfc16e 100644 --- a/src/debug.c +++ b/src/debug.c @@ -41,6 +41,21 @@ .loglevel = LOGL_INFO, .enabled = 1, }, + [DREST] = { + .name = "DREST", + .loglevel = LOGL_INFO, + .enabled = 1, + }, + [DSLOTMAP] = { + .name = "DSLOTMAP", + .loglevel = LOGL_INFO, + .enabled = 1, + }, + [DBANKDW] = { + .name = "DBANKDW", + .loglevel = LOGL_INFO, + .enabled = 1, + }, }; const struct log_info log_info = { diff --git a/src/debug.h b/src/debug.h index 51331f4..88288ca 100644 --- a/src/debug.h +++ b/src/debug.h @@ -5,6 +5,9 @@ DMAIN, DST2, DRSPRO, + DREST, + DSLOTMAP, + DBANKDW, }; extern const struct log_info log_info; diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index 49107b9..c2d54e5 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -93,6 +93,8 @@ log_set_print_category(osmo_stderr_target, 1); log_set_print_category_hex(osmo_stderr_target, 0); osmo_fsm_log_addr(0); + log_set_print_tid(osmo_stderr_target, 1); + log_enable_multithread(); handle_options(argc, argv); diff --git a/src/server/rest_api.c b/src/server/rest_api.c index ff1b588..540fbd4 100644 --- a/src/server/rest_api.c +++ b/src/server/rest_api.c @@ -304,7 +304,7 @@ rc = write(g_event_ofd.fd, &one, sizeof(one)); if (rc < 8) - fprintf(stderr, "Error writing to eventfd(): %d\n", rc); + LOGP(DREST, LOGL_ERROR, "Error writing to eventfd(): %d\n", rc); } static int api_cb_slotmaps_post(const struct _u_request *req, struct _u_response *resp, void *user_data) @@ -318,7 +318,7 @@ json_req = ulfius_get_json_body_request(req, &json_err); if (!json_req) { - fprintf(stderr, "REST: No JSON Body\n"); + LOGP(DREST, LOGL_NOTICE, "REST: No JSON Body\n"); goto err; } @@ -327,7 +327,7 @@ goto err; map = slotmap_add(g_rps->slotmaps, &slotmap.bank, &slotmap.client); if (!map) { - fprintf(stderr, "REST: Cannot add slotmap\n"); + LOGP(DREST, LOGL_NOTICE, "REST: Cannot add slotmap\n"); goto err; } slotmap_state_change(map, SLMAP_S_NEW, NULL); @@ -511,7 +511,7 @@ ulfius_add_endpoint(&g_instance, &api_endpoints[i]); if (ulfius_start_framework(&g_instance) != U_OK) { - fprintf(stderr, "Cannot start REST API on port %u\n", port); + LOGP(DREST, LOGL_FATAL, "Cannot start REST API on port %u\n", port); return -1; } return 0; diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index b35800f..6514f80 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -709,11 +709,11 @@ /* read from the socket to "confirm" the event and make it non-readable again */ rc = read(ofd->fd, &value, 8); if (rc < 8) { - fprintf(stderr, "Error reading eventfd: %d\n", rc); + LOGP(DMAIN, LOGL_ERROR, "Error reading eventfd: %d\n", rc); return rc; } - printf("rspro_server: Event FD arrived, checking for any pending work\n"); + LOGP(DMAIN, LOGL_INFO, "Event FD arrived, checking for any pending work\n"); pthread_rwlock_rdlock(&srv->rwlock); llist_for_each_entry(conn, &srv->banks, list) { diff --git a/src/slotmap.c b/src/slotmap.c index b837f01..fe0c6b7 100644 --- a/src/slotmap.c +++ b/src/slotmap.c @@ -103,14 +103,14 @@ map = slotmap_by_bank(maps, bank); if (map) { - fprintf(stderr, "BANKD %u:%u already in use, cannot add new map\n", + LOGP(DSLOTMAP, LOGL_ERROR, "BANKD %u:%u already in use, cannot add new map\n", bank->bank_id, bank->slot_nr); return NULL; } map = slotmap_by_client(maps, client); if (map) { - fprintf(stderr, "CLIENT %u:%u already in use, cannot add new map\n", + LOGP(DSLOTMAP, LOGL_ERROR, "CLIENT %u:%u already in use, cannot add new map\n", client->client_id, client->slot_nr); return NULL; } @@ -132,7 +132,7 @@ #endif slotmaps_unlock(maps); - printf("Slot Map %s added\n", slotmap_name(mapname, sizeof(mapname), map)); + LOGP(DSLOTMAP, LOGL_INFO, "Slot Map %s added\n", slotmap_name(mapname, sizeof(mapname), map)); return map; } @@ -142,7 +142,7 @@ { char mapname[64]; - printf("Slot Map %s deleted\n", slotmap_name(mapname, sizeof(mapname), map)); + LOGP(DSLOTMAP, LOGL_INFO, "Slot Map %s deleted\n", slotmap_name(mapname, sizeof(mapname), map)); llist_del(&map->list); #ifdef REMSIM_SERVER -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26474 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I7bd5264c559b756927046563a2d00c54826bee9b Gerrit-Change-Number: 26474 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 10:15:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 10:15:30 +0000 Subject: Change in osmo-remsim[master]: logging: Replace remaining fprintf() calls with libosmocore logging In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26475 ) Change subject: logging: Replace remaining fprintf() calls with libosmocore logging ...................................................................... logging: Replace remaining fprintf() calls with libosmocore logging Change-Id: I2a772b3180131923d4e2ee7311670b938cb50fe0 --- M src/bankd/bankd_pcsc.c M src/bankd/driver_core.c M src/bankd/driver_pcsc.c M src/client/remsim_client.c M src/client/remsim_client_main.c M src/client/user_simtrace2.c M src/rspro_util.c 7 files changed, 25 insertions(+), 19 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index 91eeadd..8202504 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -102,14 +102,16 @@ regex_t compiled_name; int rc; - printf("PC/SC slot name: %u/%u -> regex '%s'\n", sn->slot.bank_id, sn->slot.slot_nr, sn->name_regex); + LOGP(DMAIN, LOGL_INFO, "PC/SC slot name: %u/%u -> regex '%s'\n", + sn->slot.bank_id, sn->slot.slot_nr, sn->name_regex); memset(&compiled_name, 0, sizeof(compiled_name)); rc = regcomp(&compiled_name, sn->name_regex, REG_EXTENDED); if (rc != 0) { char *errmsg = get_regerror(sn, rc, &compiled_name); - fprintf(stderr, "Error compiling regex '%s': %s - Ignoring\n", sn->name_regex, errmsg); + LOGP(DMAIN, LOGL_ERROR, "Error compiling regex '%s': %s - Ignoring\n", + sn->name_regex, errmsg); talloc_free(errmsg); talloc_free(sn); } else { @@ -141,7 +143,8 @@ while ((bytes_read = fread(buf, 1, sizeof(buf), fp)) > 0) { if (csv_parse(&p, buf, bytes_read, cb1, cb2, &ps) != bytes_read) { - fprintf(stderr, "Error parsing CSV: %s\n", csv_strerror(csv_error(&p))); + LOGP(DMAIN, LOGL_FATAL, "Error parsing bankd PC/SC CSV: %s\n", + csv_strerror(csv_error(&p))); fclose(fp); return -1; } diff --git a/src/bankd/driver_core.c b/src/bankd/driver_core.c index dbdf23f..57ae3cd 100644 --- a/src/bankd/driver_core.c +++ b/src/bankd/driver_core.c @@ -28,6 +28,7 @@ #include #include "internal.h" +#include "debug.h" static LLIST_HEAD(g_card_reader_drivers); static LLIST_HEAD(g_card_readers); @@ -46,7 +47,7 @@ llist_add(&cr->list, &g_card_readers); - printf("allocated reader '%s'\n", cr->name); + LOGP(DMAIN, LOGL_INFO, "allocated reader '%s'\n", cr->name); return cr; } @@ -78,7 +79,7 @@ struct card_reader_driver *drv; llist_for_each_entry(drv, &g_card_reader_drivers, list) { - printf("probing driver '%s' for drivers\n", drv->name); + LOGP(DMAIN, LOGL_INFO, "probing driver '%s' for drivers\n", drv->name); drv->ops->probe(ctx); } } diff --git a/src/bankd/driver_pcsc.c b/src/bankd/driver_pcsc.c index 03a7f32..4279c2f 100644 --- a/src/bankd/driver_pcsc.c +++ b/src/bankd/driver_pcsc.c @@ -36,13 +36,14 @@ #include #include "internal.h" +#include "debug.h" #define PCSC_ERROR(rv, text) \ if (rv != SCARD_S_SUCCESS) { \ - fprintf(stderr, text ": %s (0x%lX)\n", pcsc_stringify_error(rv), rv); \ + LOGP(DMAIN, LOGL_ERROR, text ": %s (0x%lX)\n", pcsc_stringify_error(rv), rv); \ goto end; \ } else { \ - printf(text ": OK\n\n"); \ + LOGP(DMAIN, LOGL_DEBUG, ": OK\n\n"); \ } static void pcsc_readers_probe(void *ctx) @@ -73,7 +74,7 @@ num_readers++; } - printf("num_readers=%d\n", num_readers); + LOGP(DMAIN, LOGL_DEBUG, "num_readers=%d\n", num_readers); end: if (mszReaders) diff --git a/src/client/remsim_client.c b/src/client/remsim_client.c index 182894f..388aa26 100644 --- a/src/client/remsim_client.c +++ b/src/client/remsim_client.c @@ -140,7 +140,7 @@ bc->main_fi = main_fsm_alloc(bc, bc); if (!bc->main_fi) { - fprintf(stderr, "Unable to create main client FSM: %s\n", strerror(errno)); + LOGP(DMAIN, LOGL_FATAL, "Unable to create main client FSM: %s\n", strerror(errno)); exit(1); } @@ -158,7 +158,7 @@ rc = server_conn_fsm_alloc(bc, srvc); if (rc < 0) { - fprintf(stderr, "Unable to create Server conn FSM: %s\n", strerror(errno)); + LOGP(DMAIN, LOGL_FATAL, "Unable to create Server conn FSM: %s\n", strerror(errno)); exit(1); } osmo_fsm_inst_change_parent(srvc->fi, bc->main_fi, MF_E_SRVC_LOST); @@ -171,7 +171,7 @@ memcpy(&bankdc->own_comp_id, &srvc->own_comp_id, sizeof(bankdc->own_comp_id)); rc = server_conn_fsm_alloc(bc, bankdc); if (rc < 0) { - fprintf(stderr, "Unable to connect bankd conn FSM: %s\n", strerror(errno)); + LOGP(DMAIN, LOGL_FATAL, "Unable to connect bankd conn FSM: %s\n", strerror(errno)); exit(1); } osmo_fsm_inst_update_id(bankdc->fi, "bankd"); diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c index f064960..47ec8ac 100644 --- a/src/client/remsim_client_main.c +++ b/src/client/remsim_client_main.c @@ -188,7 +188,7 @@ /* Silently (and portably) reap children. */ if (avoid_zombies() < 0) { - fprintf(stderr, "Unable to silently reap children: %s\n", strerror(errno)); + LOGP(DMAIN, LOGL_FATAL, "Unable to silently reap children: %s\n", strerror(errno)); exit(1); } diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c index 8d8a6c9..100d55b 100644 --- a/src/client/user_simtrace2.c +++ b/src/client/user_simtrace2.c @@ -404,7 +404,7 @@ rc = osmo_libusb_init(NULL); if (rc < 0) { - fprintf(stderr, "libusb initialization failed\n"); + LOGP(DMAIN, LOGL_ERROR, "libusb initialization failed\n"); return rc; } @@ -427,7 +427,7 @@ transp->usb_async = true; transp->usb_devh = osmo_libusb_open_claim_interface(NULL, NULL, ifm); if (!transp->usb_devh) { - fprintf(stderr, "can't open USB device\n"); + LOGP(DMAIN, LOGL_ERROR, "can't open USB device\n"); return -1; } @@ -437,14 +437,14 @@ rc = libusb_claim_interface(transp->usb_devh, cfg->usb.if_num); if (rc < 0) { - fprintf(stderr, "can't claim interface %d; rc=%d\n", cfg->usb.if_num, rc); + LOGP(DMAIN, LOGL_ERROR, "can't claim interface %d; rc=%d\n", cfg->usb.if_num, rc); goto close_exit; } rc = osmo_libusb_get_ep_addrs(transp->usb_devh, cfg->usb.if_num, &transp->usb_ep.out, &transp->usb_ep.in, &transp->usb_ep.irq_in); if (rc < 0) { - fprintf(stderr, "can't obtain EP addrs; rc=%d\n", rc); + LOGP(DMAIN, LOGL_ERROR, "can't obtain EP addrs; rc=%d\n", rc); goto close_exit; } diff --git a/src/rspro_util.c b/src/rspro_util.c index ab748f6..a7476dc 100644 --- a/src/rspro_util.c +++ b/src/rspro_util.c @@ -33,6 +33,7 @@ #include #include "rspro_util.h" +#include "debug.h" #define ASN_ALLOC_COPY(out, in) \ do { \ @@ -69,7 +70,7 @@ msg->l2h = msg->data; rval = der_encode_to_buffer(&asn_DEF_RsproPDU, pdu, msgb_data(msg), msgb_tailroom(msg)); if (rval.encoded < 0) { - fprintf(stderr, "Failed to encode %s\n", rval.failed_type->name); + LOGP(DRSPRO, LOGL_ERROR, "Failed to encode %s\n", rval.failed_type->name); msgb_free(msg); return NULL; } @@ -86,10 +87,10 @@ RsproPDU_t *pdu = NULL; asn_dec_rval_t rval; - //printf("decoding %s\n", msgb_hexdump(msg)); + LOGP(DRSPRO, LOGL_DEBUG, "decoding %s\n", msgb_hexdump(msg)); rval = ber_decode(NULL, &asn_DEF_RsproPDU, (void **) &pdu, msgb_l2(msg), msgb_l2len(msg)); if (rval.code != RC_OK) { - fprintf(stderr, "Failed to decode: %d. Consumed %zu of %u bytes\n", + LOGP(DRSPRO, LOGL_ERROR, "Failed to decode: %d. Consumed %zu of %u bytes\n", rval.code, rval.consumed, msgb_length(msg)); return NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2a772b3180131923d4e2ee7311670b938cb50fe0 Gerrit-Change-Number: 26475 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 10:15:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 10:15:30 +0000 Subject: Change in osmo-remsim[master]: increase required libosmocore version In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26476 ) Change subject: increase required libosmocore version ...................................................................... increase required libosmocore version osmo-remsim depends on a variety of modern libosmocore features, and now that libosmocore 1.6.0 has been tagged, we can finally depend on a more recent minimum version. Change-Id: Ic3cb86b5be524f15d118bcb7ec1947608fbbb034 --- M configure.ac M contrib/osmo-remsim.spec.in M debian/control 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 400578b..45fbdee 100644 --- a/configure.ac +++ b/configure.ac @@ -33,7 +33,7 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -PKG_CHECK_MODULES(OSMOCORE, libosmocore >= 1.3.0) +PKG_CHECK_MODULES(OSMOCORE, libosmocore >= 1.6.0) PKG_CHECK_MODULES(OSMOGSM, libosmogsm >= 0.11.0) PKG_CHECK_MODULES(OSMOABIS, libosmoabis >= 0.8.0) diff --git a/contrib/osmo-remsim.spec.in b/contrib/osmo-remsim.spec.in index 90ef773..bfc5f36 100644 --- a/contrib/osmo-remsim.spec.in +++ b/contrib/osmo-remsim.spec.in @@ -31,7 +31,7 @@ %endif BuildRequires: pkgconfig(libasn1c) >= 0.9.30 BuildRequires: pkgconfig(libosmoabis) -BuildRequires: pkgconfig(libosmocore) >= 0.11.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 BuildRequires: pkgconfig(libosmogsm) >= 0.11.0 BuildRequires: pkgconfig(libosmosim) BuildRequires: pkgconfig(libpcsclite) diff --git a/debian/control b/debian/control index bdae589..faef9ee 100644 --- a/debian/control +++ b/debian/control @@ -9,7 +9,7 @@ pkg-config, osmo-gsm-manuals-dev, libcsv-dev, - libosmocore-dev (>= 1.3.0), + libosmocore-dev (>= 1.6.0), libosmo-abis-dev, libosmo-simtrace2-dev, libpcsclite-dev, -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26476 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic3cb86b5be524f15d118bcb7ec1947608fbbb034 Gerrit-Change-Number: 26476 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 10:15:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 10:15:31 +0000 Subject: Change in osmo-remsim[master]: Depend on libosmo-simtrace >= 0.8.0 In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26479 ) Change subject: Depend on libosmo-simtrace >= 0.8.0 ...................................................................... Depend on libosmo-simtrace >= 0.8.0 Change-Id: I60ae1e097c4182d948ed807ee4ca37f91d32cfae --- M configure.ac M contrib/osmo-remsim.spec.in M debian/control 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 45fbdee..5db0216 100644 --- a/configure.ac +++ b/configure.ac @@ -64,8 +64,8 @@ [osmo_ac_build_client_st2="$enableval"],[osmo_ac_build_client_st2="yes"]) if test "$osmo_ac_build_client_st2" = "yes"; then AC_DEFINE(BUILD_CLIENT_ST2, 1, [Define if we want to build osmo-remsim-client-st2]) - PKG_CHECK_MODULES(OSMOUSB, libosmousb) - PKG_CHECK_MODULES(OSMOSIMTRACE2, libosmo-simtrace2) + PKG_CHECK_MODULES(OSMOUSB, libosmousb >= 1.4.0) + PKG_CHECK_MODULES(OSMOSIMTRACE2, libosmo-simtrace2 >= 0.8.0) PKG_CHECK_MODULES(USB, libusb-1.0) fi AM_CONDITIONAL(BUILD_CLIENT_ST2, test "x$osmo_ac_build_client_st2" = "xyes") diff --git a/contrib/osmo-remsim.spec.in b/contrib/osmo-remsim.spec.in index bfc5f36..2cf0fd3 100644 --- a/contrib/osmo-remsim.spec.in +++ b/contrib/osmo-remsim.spec.in @@ -38,7 +38,7 @@ BuildRequires: pkgconfig(libulfius) BuildRequires: pkgconfig(libusb-1.0) BuildRequires: pkgconfig(libosmousb) -BuildRequires: pkgconfig(libosmo-simtrace2) +BuildRequires: pkgconfig(libosmo-simtrace2) >= 0.8.0 %{?systemd_requires} %description diff --git a/debian/control b/debian/control index faef9ee..7517856 100644 --- a/debian/control +++ b/debian/control @@ -11,7 +11,7 @@ libcsv-dev, libosmocore-dev (>= 1.6.0), libosmo-abis-dev, - libosmo-simtrace2-dev, + libosmo-simtrace2-dev (>= 0.8.0), libpcsclite-dev, libusb-1.0-0-dev, libulfius-dev, -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I60ae1e097c4182d948ed807ee4ca37f91d32cfae Gerrit-Change-Number: 26479 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 10:16:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 10:16:14 +0000 Subject: Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: new job In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26480 ) Change subject: jobs/octsim_osmo-ccid-firmware: new job ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I19d18b24a6ae5948aeaf7c46083748c70cdb3b7b Gerrit-Change-Number: 26480 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Dec 2021 10:16:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 10:20:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 10:20:36 +0000 Subject: =?UTF-8?Q?Change_in_osmo-remsim=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E2=2E126-7382_=E2=86=92_1=2E0=2E0?= References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26481 ) Change subject: Bump version: 0.2.2.126-7382 ? 1.0.0 ...................................................................... Bump version: 0.2.2.126-7382 ? 1.0.0 Change-Id: I069535801e32d045e7e42796b8ba28fa7d97e0c3 --- M contrib/osmo-remsim.spec.in M debian/changelog M debian/control R debian/libosmo-rspro2.install M src/Makefile.am 5 files changed, 139 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/81/26481/1 diff --git a/contrib/osmo-remsim.spec.in b/contrib/osmo-remsim.spec.in index 2cf0fd3..3097b8f 100644 --- a/contrib/osmo-remsim.spec.in +++ b/contrib/osmo-remsim.spec.in @@ -12,7 +12,7 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -%define sover 1 +%define sover 2 Name: osmo-remsim Version: @VERSION@ Release: 0 diff --git a/debian/changelog b/debian/changelog index 0ff1dea..63e8eaa 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,139 @@ +osmo-remsim (1.0.0) unstable; urgency=medium + + [ Harald Welte ] + * bankd_main: Refactor code: bankd_srvc_remove_mapping() + * bankd: Fix log print during removeMapping + * bankd: createMapping should implicitly delete existing mappings + * bankd: Reject removeSlotmap when ClientID doesn't match + * bankd: initialize bank_id/slot_nr to 0xffff for unmapped workers + * RSPRO: Add new ResetState{Req,Res} + * Add "--version" to all executables to print compile-time version info + * bankd: Implement new ResetStateReq + * bankd: No need to handle SIGMAPDEL if we're not mapped yet + * add missing debian/libosmo-rspro1.install + * rspro_client_fsm: Disable automatic connect on FSM allocation + * rspro_client_fsm: Make RSPRO transmit use FSM event + * Replace bankd_client_fsm with rspro_client_fsm + * remsim-client: Differentiate the two rspro_client_fsm instances by name + * rspro_client_fsm: Mark ipa_client_conn_send_rspro() as static + * rspro_client_fsm(): Remove outdated/wrong comment from code + * rspro_client_fsm: Fix uninitialized return variable use + * rspro_client_fsm: Fix handling of IPA keepalive + * bankd: Factor out signal-sending from bankd_srvc_remove_mapping() + * bankd: Introduce SIGMAPADD to tell worker about new mapping + * remsim-client: Port from local copy to libosmousb + libosmo-simtrace2 + * jenkins.sh: don't verify (possibly outdated) deps + * remsim_client: Port to async libosmousb select loop + * rspro_util: Add functions generating {Bank,Client}SlotStatusInd + * client: generate clientSlotStatusInd to bankd + * bankd: Implement card reset based on clientSlotStatusInd + * debian/control: Add missing Build-Requires libosmo-simtrace2 + * fix the package we depend on: libosmosimtrace2-dev + * require minimum version 1.3.0 of libosmocore + * remsim-client: Introduce 'struct client_config' + * client: Enable talloc NULL context tracking + * remsim_client: Move body of main() loop to separate function + * remsim-client: move from common 'src' directory to 'src/client' + * remsim-client: Fix the -k/ --keep-running option + * remsim-client: Avoid using 'ci' global variable + * remsim-client: Move client_config from .c to .h file + * remsim-client: store last 'status' + * remsim-client: Query + Store the USB device path + * remsim-client: Call an external script in specific situations + * client: Adjust to API changes; enable build of remsim-client again + * client: Add new osmo-remsim-client-shell binary + * client: Work without global g_client variable + * client: Remove g_client completely; separate 'main' code + * client: Split into remsim_client.c and remsim_client_main.c + * server: don't dereference map before OSMO_ASSERT() in _update_client_for_slotmap() + * server: Send ConfigClientBankReq with bankd_port == 0 on map delete + * rspro_client_fsm: Add SRVC_E_DISCONNECT to disconnect from RSPRO server + * client: Make ConfigClientBankReq with bankd_port == 0 trigger SRVC_E_DISCONNECT + * client: user_shell.c: fflush() after writes to stdout + * client: user_shell.c: Don't echo stdin on stdout + * server: Don't accept out-of-range bank/client/slot numbers on REST + * client: Work around "stock on PTS" problem + * update .gitignore + * contrib: Add owhw-event-script.sh for osmo-remsim-client + * src/Makefile.am: Build src directory (libosmo-rspro) before sub-directories + * client: document osmo-remsim-client-shell + * client: Add diagram for osmo-remsim-st2 use case + * client: ifd_handler (PC/SC reader driver) as remsim-client + * client: Fix 'make distcheck' bypassing pkg-config usbdropdir + * doc: generalize the remsim-client part in the overview section + * doc: Add WARNINGs about lack of security in protocols + * doc: More cross-references; Expand overview slightly + * doc: Add documentation for remsim-apitool.py + * rspro_client_fsm: Migrate to ipa_client_conn_create2() + * rspro_client_fsm: Add optional notifiation of parent on connect/disconnect + * fix debian build after introducing hack around usbdropdir + * configure/automake: Remove work-arounds + * client: major restructuring around new main_fsm (Closes: #4414) + * client: Fix TODO: add CLK status information to event-script environment + * configure/Makefile: Include contrib in "make dist" + * configure.ac + debian: Add systemd service file support + * Install config files to /etc/default/ + * contrib/jenkins.sh: Harmonize with what we do in other projects + * debian: split osmo-remsim-client into osmo-remsim-client-{shell,st2} + * libosmo-rspro: Avoid useless dependency to libosmogsm + * Avoid useless dependency on libcsv + * libosmo-rspro: Avoid useless dependency to libosmo-abis + * bankd: Avoid useless dependency to libosmosim + * client: Avoid useless depedency to libosmosim + * debian/control: Fix typo (package->Package) + * debian: osmo-remsim-client-s2 'Replaces' osmo-remsim-client + * debian: Ensure osmo-remsim-client-st2 package only contains st2 binary + * rspro_util.c: Use %zu for size_t + * introduce --disable-remsim-client-{st2,ifdhanndler} + * user_simtrace2: Stop using printf, use libosmocore logging + * only depend on libcsv if remsim-bankd is to be built + * avoid talloc abort in simtrace2 frontend_append_script_env() + * add '-d' command line argument to configure stderr logging verbosity + * simtrace2: Fix missing LF at end of log output in process_do_rx_da() + * simtrace2: Set transp->udp_fd to -1 to indicate USB transport + * contrib/owhw-event-script.sh: Update to working version for OWHWv5 + * simtrace2: use correct event when dispatching modem data to main_fsm + * Enable async use of libosmo-simtrace2 + * user_shell: Dispatch all events via main_fsm.c + * user_simtrace2: Fix typo in frontend_handle_card2modem() + * *.spec.in: Use %config(noreplace) to retain current config file + * remsim-client-shell: Terminate if STDIN has been closed + * Use OSMO_FD_* instead of deprecated BSC_FD_* + * remsim-client: Avoid zombies when scripts terminate + * bankd: regex matching of reader names + * manual: fix formating of a bullet point list in bankd csv file part + * client: request card-remove and sim-local when no bankd/slot is set + * bankd_pcsc: Improve logging in non-error case + * bankd_main: Improve log usefulness + * bankd_pcsc: Don't log every successful SCardTransmit + * rspro_client_fsm: Differentiate different log levels + * Change default log level to INFO + * [cosmetic] bankd: mark handle_options() as static + * logging: Print category + level, disable category-hex + * Add separate log category for RSPRO protocol + * switch to libosmocore multihread-logging + * logging: Replace remaining fprintf() calls with libosmocore logging + * increase required libosmocore version + * Depend on libosmo-simtrace >= 0.8.0 + + [ Joachim Steiger ] + * fix config defaults for systemd startscripts + + [ Oliver Smith ] + * contrib: import RPM spec + * contrib: integrate RPM spec + * Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in + * contrib/jenkins: don't build osmo-gsm-manuals + * configure.ac: set -std=gnu11 + * etc_default: change bankd, client ip to 127.0.0.1 + * doc/examples: install bankd_pcsc_slots.csv + * gitignore: add osmo-remsim-client-reader_conf + * distro packaging: fix missing path for example + * contrib/osmo-remsim.spec.in: fix build on opensuse + * debian/control: remove dh-systemd build-depend + + -- Harald Welte Thu, 09 Dec 2021 09:09:49 +0100 + osmo-remsim (0.2.2) unstable; urgency=medium [ Harald Welte ] diff --git a/debian/control b/debian/control index 7517856..b0ccaee 100644 --- a/debian/control +++ b/debian/control @@ -21,7 +21,7 @@ Vcs-Git: git://git.osmocom.org/osmo-remsim Homepage: https://projects.osmocom.org/projects/osmo-remsim -Package: libosmo-rspro1 +Package: libosmo-rspro2 Section: libs Architecture: any Multi-Arch: same diff --git a/debian/libosmo-rspro1.install b/debian/libosmo-rspro2.install similarity index 100% rename from debian/libosmo-rspro1.install rename to debian/libosmo-rspro2.install diff --git a/src/Makefile.am b/src/Makefile.am index 9059324..b305ce2 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -11,7 +11,7 @@ $(OSMOCORE_CFLAGS) $(OSMOGSM_CFLAGS) $(OSMOABIS_CFLAGS) \ -I$(top_srcdir)/include/osmocom/rspro -RSPRO_LIBVERSION=1:0:0 +RSPRO_LIBVERSION=2:0:0 lib_LTLIBRARIES = libosmo-rspro.la libosmo_rspro_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RSPRO_LIBVERSION) # OSMOGSM_LIBS, OSMOABIS_LIBS not needed, we don't use any of its symbols, only the header above -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I069535801e32d045e7e42796b8ba28fa7d97e0c3 Gerrit-Change-Number: 26481 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 10:35:01 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 9 Dec 2021 10:35:01 +0000 Subject: =?UTF-8?Q?Change_in_osmo-remsim=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E2=2E126-7382_=E2=86=92_1=2E0=2E0?= In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26481 ) Change subject: Bump version: 0.2.2.126-7382 ? 1.0.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I069535801e32d045e7e42796b8ba28fa7d97e0c3 Gerrit-Change-Number: 26481 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 09 Dec 2021 10:35:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 10:46:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 10:46:19 +0000 Subject: =?UTF-8?Q?Change_in_osmo-remsim=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E2=2E126-7382_=E2=86=92_1=2E0=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26481 ) Change subject: Bump version: 0.2.2.126-7382 ? 1.0.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I069535801e32d045e7e42796b8ba28fa7d97e0c3 Gerrit-Change-Number: 26481 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 09 Dec 2021 10:46:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 10:46:21 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 10:46:21 +0000 Subject: =?UTF-8?Q?Change_in_osmo-remsim=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E2=2E126-7382_=E2=86=92_1=2E0=2E0?= In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26481 ) Change subject: Bump version: 0.2.2.126-7382 ? 1.0.0 ...................................................................... Bump version: 0.2.2.126-7382 ? 1.0.0 Change-Id: I069535801e32d045e7e42796b8ba28fa7d97e0c3 --- M contrib/osmo-remsim.spec.in M debian/changelog M debian/control R debian/libosmo-rspro2.install M src/Makefile.am 5 files changed, 139 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/osmo-remsim.spec.in b/contrib/osmo-remsim.spec.in index 2cf0fd3..3097b8f 100644 --- a/contrib/osmo-remsim.spec.in +++ b/contrib/osmo-remsim.spec.in @@ -12,7 +12,7 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -%define sover 1 +%define sover 2 Name: osmo-remsim Version: @VERSION@ Release: 0 diff --git a/debian/changelog b/debian/changelog index 0ff1dea..63e8eaa 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,139 @@ +osmo-remsim (1.0.0) unstable; urgency=medium + + [ Harald Welte ] + * bankd_main: Refactor code: bankd_srvc_remove_mapping() + * bankd: Fix log print during removeMapping + * bankd: createMapping should implicitly delete existing mappings + * bankd: Reject removeSlotmap when ClientID doesn't match + * bankd: initialize bank_id/slot_nr to 0xffff for unmapped workers + * RSPRO: Add new ResetState{Req,Res} + * Add "--version" to all executables to print compile-time version info + * bankd: Implement new ResetStateReq + * bankd: No need to handle SIGMAPDEL if we're not mapped yet + * add missing debian/libosmo-rspro1.install + * rspro_client_fsm: Disable automatic connect on FSM allocation + * rspro_client_fsm: Make RSPRO transmit use FSM event + * Replace bankd_client_fsm with rspro_client_fsm + * remsim-client: Differentiate the two rspro_client_fsm instances by name + * rspro_client_fsm: Mark ipa_client_conn_send_rspro() as static + * rspro_client_fsm(): Remove outdated/wrong comment from code + * rspro_client_fsm: Fix uninitialized return variable use + * rspro_client_fsm: Fix handling of IPA keepalive + * bankd: Factor out signal-sending from bankd_srvc_remove_mapping() + * bankd: Introduce SIGMAPADD to tell worker about new mapping + * remsim-client: Port from local copy to libosmousb + libosmo-simtrace2 + * jenkins.sh: don't verify (possibly outdated) deps + * remsim_client: Port to async libosmousb select loop + * rspro_util: Add functions generating {Bank,Client}SlotStatusInd + * client: generate clientSlotStatusInd to bankd + * bankd: Implement card reset based on clientSlotStatusInd + * debian/control: Add missing Build-Requires libosmo-simtrace2 + * fix the package we depend on: libosmosimtrace2-dev + * require minimum version 1.3.0 of libosmocore + * remsim-client: Introduce 'struct client_config' + * client: Enable talloc NULL context tracking + * remsim_client: Move body of main() loop to separate function + * remsim-client: move from common 'src' directory to 'src/client' + * remsim-client: Fix the -k/ --keep-running option + * remsim-client: Avoid using 'ci' global variable + * remsim-client: Move client_config from .c to .h file + * remsim-client: store last 'status' + * remsim-client: Query + Store the USB device path + * remsim-client: Call an external script in specific situations + * client: Adjust to API changes; enable build of remsim-client again + * client: Add new osmo-remsim-client-shell binary + * client: Work without global g_client variable + * client: Remove g_client completely; separate 'main' code + * client: Split into remsim_client.c and remsim_client_main.c + * server: don't dereference map before OSMO_ASSERT() in _update_client_for_slotmap() + * server: Send ConfigClientBankReq with bankd_port == 0 on map delete + * rspro_client_fsm: Add SRVC_E_DISCONNECT to disconnect from RSPRO server + * client: Make ConfigClientBankReq with bankd_port == 0 trigger SRVC_E_DISCONNECT + * client: user_shell.c: fflush() after writes to stdout + * client: user_shell.c: Don't echo stdin on stdout + * server: Don't accept out-of-range bank/client/slot numbers on REST + * client: Work around "stock on PTS" problem + * update .gitignore + * contrib: Add owhw-event-script.sh for osmo-remsim-client + * src/Makefile.am: Build src directory (libosmo-rspro) before sub-directories + * client: document osmo-remsim-client-shell + * client: Add diagram for osmo-remsim-st2 use case + * client: ifd_handler (PC/SC reader driver) as remsim-client + * client: Fix 'make distcheck' bypassing pkg-config usbdropdir + * doc: generalize the remsim-client part in the overview section + * doc: Add WARNINGs about lack of security in protocols + * doc: More cross-references; Expand overview slightly + * doc: Add documentation for remsim-apitool.py + * rspro_client_fsm: Migrate to ipa_client_conn_create2() + * rspro_client_fsm: Add optional notifiation of parent on connect/disconnect + * fix debian build after introducing hack around usbdropdir + * configure/automake: Remove work-arounds + * client: major restructuring around new main_fsm (Closes: #4414) + * client: Fix TODO: add CLK status information to event-script environment + * configure/Makefile: Include contrib in "make dist" + * configure.ac + debian: Add systemd service file support + * Install config files to /etc/default/ + * contrib/jenkins.sh: Harmonize with what we do in other projects + * debian: split osmo-remsim-client into osmo-remsim-client-{shell,st2} + * libosmo-rspro: Avoid useless dependency to libosmogsm + * Avoid useless dependency on libcsv + * libosmo-rspro: Avoid useless dependency to libosmo-abis + * bankd: Avoid useless dependency to libosmosim + * client: Avoid useless depedency to libosmosim + * debian/control: Fix typo (package->Package) + * debian: osmo-remsim-client-s2 'Replaces' osmo-remsim-client + * debian: Ensure osmo-remsim-client-st2 package only contains st2 binary + * rspro_util.c: Use %zu for size_t + * introduce --disable-remsim-client-{st2,ifdhanndler} + * user_simtrace2: Stop using printf, use libosmocore logging + * only depend on libcsv if remsim-bankd is to be built + * avoid talloc abort in simtrace2 frontend_append_script_env() + * add '-d' command line argument to configure stderr logging verbosity + * simtrace2: Fix missing LF at end of log output in process_do_rx_da() + * simtrace2: Set transp->udp_fd to -1 to indicate USB transport + * contrib/owhw-event-script.sh: Update to working version for OWHWv5 + * simtrace2: use correct event when dispatching modem data to main_fsm + * Enable async use of libosmo-simtrace2 + * user_shell: Dispatch all events via main_fsm.c + * user_simtrace2: Fix typo in frontend_handle_card2modem() + * *.spec.in: Use %config(noreplace) to retain current config file + * remsim-client-shell: Terminate if STDIN has been closed + * Use OSMO_FD_* instead of deprecated BSC_FD_* + * remsim-client: Avoid zombies when scripts terminate + * bankd: regex matching of reader names + * manual: fix formating of a bullet point list in bankd csv file part + * client: request card-remove and sim-local when no bankd/slot is set + * bankd_pcsc: Improve logging in non-error case + * bankd_main: Improve log usefulness + * bankd_pcsc: Don't log every successful SCardTransmit + * rspro_client_fsm: Differentiate different log levels + * Change default log level to INFO + * [cosmetic] bankd: mark handle_options() as static + * logging: Print category + level, disable category-hex + * Add separate log category for RSPRO protocol + * switch to libosmocore multihread-logging + * logging: Replace remaining fprintf() calls with libosmocore logging + * increase required libosmocore version + * Depend on libosmo-simtrace >= 0.8.0 + + [ Joachim Steiger ] + * fix config defaults for systemd startscripts + + [ Oliver Smith ] + * contrib: import RPM spec + * contrib: integrate RPM spec + * Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in + * contrib/jenkins: don't build osmo-gsm-manuals + * configure.ac: set -std=gnu11 + * etc_default: change bankd, client ip to 127.0.0.1 + * doc/examples: install bankd_pcsc_slots.csv + * gitignore: add osmo-remsim-client-reader_conf + * distro packaging: fix missing path for example + * contrib/osmo-remsim.spec.in: fix build on opensuse + * debian/control: remove dh-systemd build-depend + + -- Harald Welte Thu, 09 Dec 2021 09:09:49 +0100 + osmo-remsim (0.2.2) unstable; urgency=medium [ Harald Welte ] diff --git a/debian/control b/debian/control index 7517856..b0ccaee 100644 --- a/debian/control +++ b/debian/control @@ -21,7 +21,7 @@ Vcs-Git: git://git.osmocom.org/osmo-remsim Homepage: https://projects.osmocom.org/projects/osmo-remsim -Package: libosmo-rspro1 +Package: libosmo-rspro2 Section: libs Architecture: any Multi-Arch: same diff --git a/debian/libosmo-rspro1.install b/debian/libosmo-rspro2.install similarity index 100% rename from debian/libosmo-rspro1.install rename to debian/libosmo-rspro2.install diff --git a/src/Makefile.am b/src/Makefile.am index 9059324..b305ce2 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -11,7 +11,7 @@ $(OSMOCORE_CFLAGS) $(OSMOGSM_CFLAGS) $(OSMOABIS_CFLAGS) \ -I$(top_srcdir)/include/osmocom/rspro -RSPRO_LIBVERSION=1:0:0 +RSPRO_LIBVERSION=2:0:0 lib_LTLIBRARIES = libosmo-rspro.la libosmo_rspro_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RSPRO_LIBVERSION) # OSMOGSM_LIBS, OSMOABIS_LIBS not needed, we don't use any of its symbols, only the header above -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I069535801e32d045e7e42796b8ba28fa7d97e0c3 Gerrit-Change-Number: 26481 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 12:14:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 12:14:09 +0000 Subject: Change in osmo-bsc[master]: bts-examples: add example for E1 connected BTS In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26367 ) Change subject: bts-examples: add example for E1 connected BTS ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Gerrit-Change-Number: 26367 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Dec 2021 12:14:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 12:22:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 12:22:04 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 7: Code-Review-1 (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/abis_nm.c at 938 PS7, Line 938: if (gsm_bts_check_cfg(bts) != 0) { why is this still here?! https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/bts_ipaccess_nanobts.c File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/bts_ipaccess_nanobts.c at 704 PS7, Line 704: ipaccess_drop_oml(bts, "bad config"); You may need to use ipaccess_drop_oml_deferred() here. Check the description of that function on whether this is one of the cases. https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/bts_ipaccess_nanobts.c at 706 PS7, Line 706: ipaccess_drop_rsl(trx, "bad config"); This is not needed, it's already done by ipaccess_drop_oml(). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 09 Dec 2021 12:22:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 12:25:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 12:25:17 +0000 Subject: Change in libosmocore[master]: select: add member for human readable name to osmo_fd In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26453 ) Change subject: select: add member for human readable name to osmo_fd ...................................................................... Patch Set 1: Code-Review-1 I personally wouldn't add this field here, for several reasons: * It's breaking ABI in all our code base * We can have lots and lots of osmo_fd structures, we are adding more used space here for some specific case * Since it's a specific case, we have "void *data" for that. The name can be stored there (or as a field in the struct stored in *data). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I64b288174ae3dd22d50a701ce7cbf9e623246479 Gerrit-Change-Number: 26453 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Dec 2021 12:25:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 12:26:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 12:26:47 +0000 Subject: Change in libosmo-abis[master]: ipaccess.c: assign names to the related osmo_fds In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26455 ) Change subject: ipaccess.c: assign names to the related osmo_fds ...................................................................... Patch Set 1: See my comment on the patch adding this field in libosmocore. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 09 Dec 2021 12:26:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 12:32:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 12:32:35 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: do not pass UEA0 to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: do not pass UEA0 to ranap_new_msg_sec_mod_cmd2() ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Dec 2021 12:32:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 12:50:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 12:50:56 +0000 Subject: Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26426 ) Change subject: Introduce osmo_prim_srv APIs ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/libosmo-netif/+/26426/5/src/prim.c File src/prim.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26426/5/src/prim.c at 107 PS5, Line 107: 1600 > I think we should probably make that somehow user-configurable. [?] Since the prim_srv_link structure is private we can easily later add a new set_payload_rx_len() API whenever we see need it. msgb_alloc_c: ACK -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 Gerrit-Change-Number: 26426 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Dec 2021 12:50:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 12:56:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 12:56:32 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26435 ) Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/libosmo-netif/+/26435/4/src/prim.c File src/prim.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26435/4/src/prim.c at 98 PS4, Line 98: OSMO_PRIM_CTL_SAPI > this could be a public #define that is visible to the applications? I don't think it's really needed so far since anyway this is all handled internally by the module, so totally transparent to the app (the protocol side at least, not the callback). In any case, we can always later on move it to a header without any problem. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Dec 2021 12:56:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 12:56:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 12:56:40 +0000 Subject: Change in libosmo-netif[master]: stream: Add support for AF_UNIX sockets In-Reply-To: References: Message-ID: Hello Jenkins Builder, Arran Cudbard-bell, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 to look at the new patch set (#5). Change subject: stream: Add support for AF_UNIX sockets ...................................................................... stream: Add support for AF_UNIX sockets Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 --- M include/osmocom/netif/stream.h M src/stream.c 2 files changed, 254 insertions(+), 72 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/34/26434/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 Gerrit-Change-Number: 26434 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Arran Cudbard-bell Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 12:56:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 12:56:40 +0000 Subject: Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 to look at the new patch set (#6). Change subject: Introduce osmo_prim_srv APIs ...................................................................... Introduce osmo_prim_srv APIs This new module allows easy exchange of osmo_prim based data types over IPC communication (UD socket supported only so far), by replacing the osmo_prim_hdr struct with a serialized header when submitting/receiving it from the IPC socket. This patch introduces the server side of the UD socket, but the client side can easily be introduced in the same file whenever needed. Related: SYS#5516 Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 --- M TODO-RELEASE M include/osmocom/netif/Makefile.am A include/osmocom/netif/prim.h M src/Makefile.am A src/prim.c 5 files changed, 400 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/26/26426/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 Gerrit-Change-Number: 26426 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 13:03:15 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 9 Dec 2021 13:03:15 +0000 Subject: Change in libosmocore[master]: logging: make LIBOSMOCORE_NO_LOGGING work as expected In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26394 to look at the new patch set (#2). Change subject: logging: make LIBOSMOCORE_NO_LOGGING work as expected ...................................................................... logging: make LIBOSMOCORE_NO_LOGGING work as expected The macro introduced in d02090bba538158c36fd838d4e50c47e40f11449 was not enough: the actual logging macros are being used, i.e. by the fsm, so wrap those as well, and provide a flag to disable this at build time. Change-Id: Ia4c78abe5f198139f96ffa289998855be2477585 --- M configure.ac M include/osmocom/core/logging.h 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/26394/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4c78abe5f198139f96ffa289998855be2477585 Gerrit-Change-Number: 26394 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 13:13:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 13:13:15 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 to look at the new patch set (#6). Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... prim: Add internal CTL SAPI to negotiate SAP versions This commits adds a generic mechansim for applications to validate support for SAPs and specific versions of them. A new special SAPI is introduced to manage inbound control messages for the protocol. In that SAPI a new primitive HELLO.ind/.cnf is added to negotiate support for versions of any given SAP. The idea is that the client upon connecting submits a HELLO.ind(SAP, VER) for each SAP it plans to use, including the version of the special CTL SAPI itself (preferrably to be checked first). Upon receiving such a message, osmo_prim_srv handles it using a special path, which ends up calling the user provided rx_sapi_version_cb(SAP, VER). In there, the user can either: * Accept the version (return same VER value) * Reject the requested version but propose another candidate version (return some positive VER value other than received VER). In this case, the client can decide whether to request another VER or close the connection. * Reject the proposed version and close the connection. Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 --- M include/osmocom/netif/prim.h M src/prim.c 2 files changed, 122 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/35/26435/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 13:42:24 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 9 Dec 2021 13:42:24 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: do not pass UEA0 to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: do not pass UEA0 to ranap_new_msg_sec_mod_cmd2() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Dec 2021 13:42:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 13:42:29 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 9 Dec 2021 13:42:29 +0000 Subject: Change in osmo-msc[master]: ran_msg_iu: do not pass UEA0 to ranap_new_msg_sec_mod_cmd2() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26391 ) Change subject: ran_msg_iu: do not pass UEA0 to ranap_new_msg_sec_mod_cmd2() ...................................................................... ran_msg_iu: do not pass UEA0 to ranap_new_msg_sec_mod_cmd2() On the protocol level, it's impossible to indicate UEA0 together with the other algorithms. The encryption is either a) disabled, so the Encryption Information IE is not present, or b) enabled, so the Encryption Information IE indicates UEA1 and/or UEA2. Because of that, the ranap_new_msg_sec_mod_cmd2() would fail to generate the RANAP PDU if the given bitmask has the UEA0 bit set. Fixes: 505a94a610fc ("Make UTRAN encryption algorithms configurable") Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e --- M src/libmsc/ran_msg_iu.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index cf57d35..b894df2 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -377,7 +377,8 @@ { /* TODO: make the choice of available UIA algorithms configurable */ const uint8_t uia_mask = (1 << OSMO_UTRAN_UIA1) | (1 << OSMO_UTRAN_UIA2); - bool use_encryption = cm->utran.uea_encryption_mask > (1 << OSMO_UTRAN_UEA0); + const uint8_t uea_mask = cm->utran.uea_encryption_mask & ~(1 << OSMO_UTRAN_UEA0); + bool use_encryption = uea_mask != 0x00; LOG_RAN_IU_ENC(caller_fi, LOGL_DEBUG, "Tx RANAP SECURITY MODE COMMAND to RNC, IK=%s, CK=%s\n", osmo_hexdump_nospc(cm->vec->ik, 16), @@ -388,7 +389,7 @@ use_encryption ? cm->vec->ck : NULL, RANAP_KeyStatus_new, (uia_mask << 1), /* API treats LSB as UIA0 */ - cm->utran.uea_encryption_mask); + uea_mask); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3271d27c09fc8d70a912bce998ceffbce64dd95e Gerrit-Change-Number: 26391 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:01:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 14:01:11 +0000 Subject: Change in osmo-remsim[master]: manual: Document the logging configuration References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26482 ) Change subject: manual: Document the logging configuration ...................................................................... manual: Document the logging configuration Change-Id: I66f5fe2e55c7e4cb6cc8ce09dcd8a636c717a5a0 --- A doc/manuals/chapters/logging.adoc M doc/manuals/chapters/remsim-bankd.adoc M doc/manuals/chapters/remsim-client.adoc M doc/manuals/chapters/remsim-server.adoc M doc/manuals/osmo-remsim-usermanual.adoc 5 files changed, 90 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/82/26482/1 diff --git a/doc/manuals/chapters/logging.adoc b/doc/manuals/chapters/logging.adoc new file mode 100644 index 0000000..22a76e4 --- /dev/null +++ b/doc/manuals/chapters/logging.adoc @@ -0,0 +1,58 @@ +[[remsim_logging]] +== osmo-remsim logging + +All programs within the osmo-remsim project use the logging sub-system of `libosmocore`. + +Contrary to the larger Osmocom projects with their own VTY + configuration file, the +loggging configuration for osmo-remsim programs must happen via command line arguments. + +Also, contrary to the larger Osmocom projects, only logging to `stderr` is supported; +no direct logging to log files, syslog, systemd, etc. is supported at this point. + +=== `-d` command line argument + +Every osmo-remsim program like `osmo-remsim-bankd`, `osmo-remsim-server` or +`osmo-remsim-client-st2` supports a `-d` command line argument. This argument +takes one mandatory parameter configuring the log level for each log sub-system +as follows: + +`-d SUBSYS,num_lvl[:SUBSYS,num_lvl[:...]]` + +So basically, a colon-separated list of tuples, where each tuple contains the +sub-system name and the _numeric_ log level. + +Below is the list of sub-systems and a table of numerical levels: + +.libosmocore log levels and their numeric values +[options="header",width="30%",cols="1,1"] +|=== +|Level name|Numeric value +|DEBUG|1 +|INFO|3 +|NOTICE|5 +|ERROR|7 +|FATAL|8 +|=== + +.osmo-remsim log sub-system names and their description +[options="header",width="50%",cols="1,2"] +|=== +|Sub-System Name|Description +|DMAIN|respective main program code +|DST2|SIMtrace2 `cardem` firmware interaction via USB +|DRSPRO|RSPRO protocol between bankd, server and client +|DREST|REST interface of `osmo-remsim-server` +|DSLOTMAP|slotmap code shared by `osmo-remsim-server` and `osmo-remsim-bankd` +|DBANKDW|worker threads of `osmo-remsim-bankd` +|=== + +=== Example + +Putting the above in a concrete example: + +`-d DMAIN,5:DRSPRO,1` + +would perform the following configuration: + +* log only NOTICE (or higher) messages in the DMAIN subsystem (low verbosity) +* log DEBUG (or higher) messages in the DRSPRO subsystem (very high verbosity) diff --git a/doc/manuals/chapters/remsim-bankd.adoc b/doc/manuals/chapters/remsim-bankd.adoc index ab7a362..da529e2 100644 --- a/doc/manuals/chapters/remsim-bankd.adoc +++ b/doc/manuals/chapters/remsim-bankd.adoc @@ -61,12 +61,16 @@ ==== SYNOPSIS -*osmo-remsim-bankd* [-h] [-i A.B.C.D] [-p <1-65535>] [-b <1-65535>] [-n <1-65535>] [-I A.B.C.D] [-P <1-65535> ] +*osmo-remsim-bankd* [-h] [-V] [-d LOGOPT] [-i A.B.C.D] [-p <1-65535>] [-b <1-65535>] [-n <1-65535>] [-I A.B.C.D] [-P <1-65535> ] ==== OPTIONS *-h, --help*:: Print a short help message about the supported options +*-V, --version*:: + Print the software version number +*-d, --debug LOGOPT*:: + Configure the logging verbosity, see <>. *-i, --server-host A.B.C.D*:: Specify the remote IP address/hostname of the `osmo-remsim-server` to which this bankd shall establish its RSPRO control connection @@ -83,7 +87,7 @@ Specify the local IP address to which the socket for incoming connections from `osmo-remsim-clients` is bound to. *-P, --bind-port <1-65535>*:: - Specify the local TCP port to whicc the socket for incoming connections + Specify the local TCP port to which the socket for incoming connections from `osmo-remsim-client`s is bound to. ==== Examples diff --git a/doc/manuals/chapters/remsim-client.adoc b/doc/manuals/chapters/remsim-client.adoc index 5e17ec0..f2ee952 100644 --- a/doc/manuals/chapters/remsim-client.adoc +++ b/doc/manuals/chapters/remsim-client.adoc @@ -72,7 +72,11 @@ *-h, --help*:: Print a short help message about the supported options -*-s, --server-host A.B.C.D*:: +*-V, --version*:: + Print the software version number +*-d, --debug LOGOPT*:: + Configure the logging verbosity, see <>. +*-i, --server-ip A.B.C.D*:: Specify the remote IP address / hostname of the `osmo-remsim-server` to which this client shall establish its RSPRO control connection *-p, --server-port <1-65535>*:: @@ -220,6 +224,8 @@ Print a short help message about the supported options *-v, --version*:: Print the compile-time version information +*-d, --debug LOGOPT*:: + Configure the logging verbosity, see <>. *-i, --server-ip A.B.C.D*:: Specify the remote IP address / hostname of the `osmo-remsim-server` to which this client shall establish its RSPRO control connection diff --git a/doc/manuals/chapters/remsim-server.adoc b/doc/manuals/chapters/remsim-server.adoc index 304a7f3..85f4da7 100644 --- a/doc/manuals/chapters/remsim-server.adoc +++ b/doc/manuals/chapters/remsim-server.adoc @@ -13,11 +13,25 @@ It is intended to make these settings (IP addresses, ports) configurable in future versions. +==== SYNOPSIS + +*osmo-remsim-server* [-h] [-V] [-d LOGOPT] + +==== OPTIONS + +*-h, --help*:: + Print a short help message about the supported options +*-V, --version*:: + Print the software version number +*-d, --debug LOGOPT*:: + Configure the logging verbosity, see <>. + === Logging -`osmo-remsim-server` currently logs to stdout only, and the logging -verbosity is not yet configurable. However, as the libosmocore logging -framework is used, extending this is an easy modification. +`osmo-remsim-server` currently logs to stderr only; the logging +verbosity is configurable via command line argument only. However, as +the libosmocore logging framework is used, extending this is an easy +modification. [[rsres]] === RESTful/JSON Web API diff --git a/doc/manuals/osmo-remsim-usermanual.adoc b/doc/manuals/osmo-remsim-usermanual.adoc index 1679db2..32f173b 100644 --- a/doc/manuals/osmo-remsim-usermanual.adoc +++ b/doc/manuals/osmo-remsim-usermanual.adoc @@ -16,6 +16,8 @@ include::{srcdir}/chapters/remsim-bankd.adoc[] +include::{srcdir}/chapters/logging.adoc[] + include::{srcdir}/chapters/rspro.adoc[] //include::./common/chapters/vty.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I66f5fe2e55c7e4cb6cc8ce09dcd8a636c717a5a0 Gerrit-Change-Number: 26482 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:01:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 14:01:11 +0000 Subject: Change in osmo-remsim[master]: manual: Re-order remsim-client options to match --help output References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26483 ) Change subject: manual: Re-order remsim-client options to match --help output ...................................................................... manual: Re-order remsim-client options to match --help output Change-Id: Id4436b980c6a4691f3403ece400b90695a786e09 --- M doc/manuals/chapters/remsim-client.adoc 1 file changed, 7 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/83/26483/1 diff --git a/doc/manuals/chapters/remsim-client.adoc b/doc/manuals/chapters/remsim-client.adoc index f2ee952..efd1752 100644 --- a/doc/manuals/chapters/remsim-client.adoc +++ b/doc/manuals/chapters/remsim-client.adoc @@ -90,13 +90,13 @@ Specify the slot number served within this client. The tuple of client-id and client-slot must be unique among all clients connecting to the same `osmo-remsim-server`. -*-i, --gsmtap-ip A.B.C.D*:: - Specify the IP address (if any) to which APDU traces are sent in - GSMTAP format (useful for debugging; supported by wireshark). -*-k, --keep-running*:: - Specify if the `osmo-remsim-client` should terminate after handling one - session, or whether it should keep running. Fast respawn (i.e. no - --keep-running) is probably the more robust option at this point. +*-a, --atr HEXSTRING*:: + Specify the initial ATR to be communicated to the modem/phone. Can + and will later be overridden by the ATR as specified by + `osmo-remsim-bankd` once a card has been mapped to this client. +*-e, --event-script COMMAND*:: + Specify the shell command to be execute when the client wants to call its + helper script *-V, --usb-vendor*:: Specify the USB Vendor ID of the USB device served by this client, use e.g. 0x1d50 for SIMtrace2, sysmoQMOD and OWHW. @@ -122,14 +122,6 @@ usefule to disambiguate between multiple identical USB devices attached to the same host. You don't need this if you have only one SIM emulation device attached to your system. -*-a, --atr HEXSTRING*:: - Specify the initial ATR to be communicated to the modem/phone. Can - and will later be overridden by the ATR as specified by - `osmo-remsim-bankd` once a card has been mapped to this client. -*-e, --event-script COMMAND*:: - Specify the shell command to be execute when the client wants to call its - helper script - ==== Examples .remsim-server is on 10.2.3.4, sysmoQMOD on usb bus, all 4 modems: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id4436b980c6a4691f3403ece400b90695a786e09 Gerrit-Change-Number: 26483 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:01:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 14:01:11 +0000 Subject: Change in osmo-remsim[master]: manual: Update changelog, copyright, version References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26484 ) Change subject: manual: Update changelog, copyright, version ...................................................................... manual: Update changelog, copyright, version Change-Id: I25f249a81f24f161fb2cf6df37ae217a5d425f8b --- M doc/manuals/osmo-remsim-usermanual-docinfo.xml 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/84/26484/1 diff --git a/doc/manuals/osmo-remsim-usermanual-docinfo.xml b/doc/manuals/osmo-remsim-usermanual-docinfo.xml index a1ceb6d..37dca7b 100644 --- a/doc/manuals/osmo-remsim-usermanual-docinfo.xml +++ b/doc/manuals/osmo-remsim-usermanual-docinfo.xml @@ -7,6 +7,14 @@ Initial version. + + 2 + December 2021 + HW + + Update manual to osmo-remsim v1.0.0 (logging, command line arguments) + + @@ -24,7 +32,7 @@ - 2019 + 2019-2021 sysmocom - s.f.m.c. GmbH -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I25f249a81f24f161fb2cf6df37ae217a5d425f8b Gerrit-Change-Number: 26484 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:09:22 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 14:09:22 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26435 ) Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... Patch Set 6: (3 comments) https://gerrit.osmocom.org/c/libosmo-netif/+/26435/6//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/26435/6//COMMIT_MSG at 9 PS6, Line 9: mechansim mechanism https://gerrit.osmocom.org/c/libosmo-netif/+/26435/6//COMMIT_MSG at 14 PS6, Line 14: ind/.cnf I think this is confusing as it is a violation of the ITU-T X.210 terminology: * an indication is sent by a provider to a user (whcih doens't trigger any reply) * a confirmation is sent by a provider to when it receives a remote request https://gerrit.osmocom.org/c/libosmo-netif/+/26435/6//COMMIT_MSG at 24 PS6, Line 24: (return some positive VER value other than received VER). In this this to me looks like a match for request/confirm? or request/reject? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Dec 2021 14:09:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:11:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 14:11:02 +0000 Subject: Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26426 ) Change subject: Introduce osmo_prim_srv APIs ...................................................................... Patch Set 6: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmo-netif/+/26426/5/src/prim.c File src/prim.c: https://gerrit.osmocom.org/c/libosmo-netif/+/26426/5/src/prim.c at 107 PS5, Line 107: 1600 > Since the prim_srv_link structure is private we can easily later add a new set_payload_rx_len() API [?] "easily add" means tagging + releasing a new libosmocore and depending on that, rather than juts passing a different parameter along when creating the stream server. Adding that one configurable parameter adds <= 10 lines of code I guess, so there is advantage from doing it now. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 Gerrit-Change-Number: 26426 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Dec 2021 14:11:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:12:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 14:12:18 +0000 Subject: Change in osmo-remsim[master]: manual: Document the logging configuration In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/26482 to look at the new patch set (#2). Change subject: manual: Document the logging configuration ...................................................................... manual: Document the logging configuration Change-Id: I66f5fe2e55c7e4cb6cc8ce09dcd8a636c717a5a0 --- A doc/manuals/chapters/logging.adoc M doc/manuals/chapters/remsim-bankd.adoc M doc/manuals/chapters/remsim-client.adoc M doc/manuals/chapters/remsim-server.adoc M doc/manuals/osmo-remsim-usermanual.adoc 5 files changed, 90 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/82/26482/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I66f5fe2e55c7e4cb6cc8ce09dcd8a636c717a5a0 Gerrit-Change-Number: 26482 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:18:13 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 9 Dec 2021 14:18:13 +0000 Subject: Change in osmo-remsim[master]: manual: Document the logging configuration In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26482 ) Change subject: manual: Document the logging configuration ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I66f5fe2e55c7e4cb6cc8ce09dcd8a636c717a5a0 Gerrit-Change-Number: 26482 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 09 Dec 2021 14:18:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:20:19 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 9 Dec 2021 14:20:19 +0000 Subject: Change in osmo-remsim[master]: manual: Re-order remsim-client options to match --help output In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26483 ) Change subject: manual: Re-order remsim-client options to match --help output ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-remsim/+/26483/2/doc/manuals/chapters/remsim-client.adoc File doc/manuals/chapters/remsim-client.adoc: https://gerrit.osmocom.org/c/osmo-remsim/+/26483/2/doc/manuals/chapters/remsim-client.adoc at a93 PS2, Line 93: *-i, --gsmtap-ip A.B.C.D*:: The commit message says 'reorder', but you're removing these? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id4436b980c6a4691f3403ece400b90695a786e09 Gerrit-Change-Number: 26483 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 09 Dec 2021 14:20:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:20:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 9 Dec 2021 14:20:43 +0000 Subject: Change in osmo-remsim[master]: manual: Update changelog, copyright, version In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26484 ) Change subject: manual: Update changelog, copyright, version ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I25f249a81f24f161fb2cf6df37ae217a5d425f8b Gerrit-Change-Number: 26484 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 09 Dec 2021 14:20:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:36:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 14:36:49 +0000 Subject: Change in osmo-remsim[master]: manual: Re-order remsim-client options to match --help output In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26483 ) Change subject: manual: Re-order remsim-client options to match --help output ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-remsim/+/26483/2/doc/manuals/chapters/remsim-client.adoc File doc/manuals/chapters/remsim-client.adoc: https://gerrit.osmocom.org/c/osmo-remsim/+/26483/2/doc/manuals/chapters/remsim-client.adoc at a93 PS2, Line 93: *-i, --gsmtap-ip A.B.C.D*:: > The commit message says 'reorder', but you're removing these? ack, indeed, those don't exist anymore. will update commitlog. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id4436b980c6a4691f3403ece400b90695a786e09 Gerrit-Change-Number: 26483 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 09 Dec 2021 14:36:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:39:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 14:39:40 +0000 Subject: Change in osmo-remsim[master]: manual: Document the logging configuration In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26482 ) Change subject: manual: Document the logging configuration ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I66f5fe2e55c7e4cb6cc8ce09dcd8a636c717a5a0 Gerrit-Change-Number: 26482 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Dec 2021 14:39:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:39:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 14:39:42 +0000 Subject: Change in osmo-remsim[master]: manual: Document the logging configuration In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26482 ) Change subject: manual: Document the logging configuration ...................................................................... manual: Document the logging configuration Change-Id: I66f5fe2e55c7e4cb6cc8ce09dcd8a636c717a5a0 --- A doc/manuals/chapters/logging.adoc M doc/manuals/chapters/remsim-bankd.adoc M doc/manuals/chapters/remsim-client.adoc M doc/manuals/chapters/remsim-server.adoc M doc/manuals/osmo-remsim-usermanual.adoc 5 files changed, 90 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/logging.adoc b/doc/manuals/chapters/logging.adoc new file mode 100644 index 0000000..bf4ebe5 --- /dev/null +++ b/doc/manuals/chapters/logging.adoc @@ -0,0 +1,58 @@ +[[remsim_logging]] +== osmo-remsim logging + +All programs within the osmo-remsim project use the logging sub-system of `libosmocore`. + +Contrary to the larger Osmocom projects with their own VTY + configuration file, the +logging configuration for osmo-remsim programs must happen via command line arguments. + +Also, contrary to the larger Osmocom projects, only logging to `stderr` is supported; +no direct logging to log files, syslog, systemd, etc. is supported at this point. + +=== `-d` command line argument + +Every osmo-remsim program like `osmo-remsim-bankd`, `osmo-remsim-server` or +`osmo-remsim-client-st2` supports a `-d` command line argument. This argument +takes one mandatory parameter configuring the log level for each log sub-system +as follows: + +`-d SUBSYS,num_lvl[:SUBSYS,num_lvl[:...]]` + +So basically, a colon-separated list of tuples, where each tuple contains the +sub-system name and the _numeric_ log level. + +Below is the list of sub-systems and a table of numerical levels: + +.libosmocore log levels and their numeric values +[options="header",width="30%",cols="1,1"] +|=== +|Level name|Numeric value +|DEBUG|1 +|INFO|3 +|NOTICE|5 +|ERROR|7 +|FATAL|8 +|=== + +.osmo-remsim log sub-system names and their description +[options="header",width="50%",cols="1,2"] +|=== +|Sub-System Name|Description +|DMAIN|respective main program code +|DST2|SIMtrace2 `cardem` firmware interaction via USB +|DRSPRO|RSPRO protocol between bankd, server and client +|DREST|REST interface of `osmo-remsim-server` +|DSLOTMAP|slotmap code shared by `osmo-remsim-server` and `osmo-remsim-bankd` +|DBANKDW|worker threads of `osmo-remsim-bankd` +|=== + +=== Example + +Putting the above in a concrete example: + +`-d DMAIN,5:DRSPRO,1` + +would perform the following configuration: + +* log only NOTICE (or higher) messages in the DMAIN subsystem (low verbosity) +* log DEBUG (or higher) messages in the DRSPRO subsystem (very high verbosity) diff --git a/doc/manuals/chapters/remsim-bankd.adoc b/doc/manuals/chapters/remsim-bankd.adoc index ab7a362..da529e2 100644 --- a/doc/manuals/chapters/remsim-bankd.adoc +++ b/doc/manuals/chapters/remsim-bankd.adoc @@ -61,12 +61,16 @@ ==== SYNOPSIS -*osmo-remsim-bankd* [-h] [-i A.B.C.D] [-p <1-65535>] [-b <1-65535>] [-n <1-65535>] [-I A.B.C.D] [-P <1-65535> ] +*osmo-remsim-bankd* [-h] [-V] [-d LOGOPT] [-i A.B.C.D] [-p <1-65535>] [-b <1-65535>] [-n <1-65535>] [-I A.B.C.D] [-P <1-65535> ] ==== OPTIONS *-h, --help*:: Print a short help message about the supported options +*-V, --version*:: + Print the software version number +*-d, --debug LOGOPT*:: + Configure the logging verbosity, see <>. *-i, --server-host A.B.C.D*:: Specify the remote IP address/hostname of the `osmo-remsim-server` to which this bankd shall establish its RSPRO control connection @@ -83,7 +87,7 @@ Specify the local IP address to which the socket for incoming connections from `osmo-remsim-clients` is bound to. *-P, --bind-port <1-65535>*:: - Specify the local TCP port to whicc the socket for incoming connections + Specify the local TCP port to which the socket for incoming connections from `osmo-remsim-client`s is bound to. ==== Examples diff --git a/doc/manuals/chapters/remsim-client.adoc b/doc/manuals/chapters/remsim-client.adoc index 5e17ec0..f2ee952 100644 --- a/doc/manuals/chapters/remsim-client.adoc +++ b/doc/manuals/chapters/remsim-client.adoc @@ -72,7 +72,11 @@ *-h, --help*:: Print a short help message about the supported options -*-s, --server-host A.B.C.D*:: +*-V, --version*:: + Print the software version number +*-d, --debug LOGOPT*:: + Configure the logging verbosity, see <>. +*-i, --server-ip A.B.C.D*:: Specify the remote IP address / hostname of the `osmo-remsim-server` to which this client shall establish its RSPRO control connection *-p, --server-port <1-65535>*:: @@ -220,6 +224,8 @@ Print a short help message about the supported options *-v, --version*:: Print the compile-time version information +*-d, --debug LOGOPT*:: + Configure the logging verbosity, see <>. *-i, --server-ip A.B.C.D*:: Specify the remote IP address / hostname of the `osmo-remsim-server` to which this client shall establish its RSPRO control connection diff --git a/doc/manuals/chapters/remsim-server.adoc b/doc/manuals/chapters/remsim-server.adoc index 304a7f3..85f4da7 100644 --- a/doc/manuals/chapters/remsim-server.adoc +++ b/doc/manuals/chapters/remsim-server.adoc @@ -13,11 +13,25 @@ It is intended to make these settings (IP addresses, ports) configurable in future versions. +==== SYNOPSIS + +*osmo-remsim-server* [-h] [-V] [-d LOGOPT] + +==== OPTIONS + +*-h, --help*:: + Print a short help message about the supported options +*-V, --version*:: + Print the software version number +*-d, --debug LOGOPT*:: + Configure the logging verbosity, see <>. + === Logging -`osmo-remsim-server` currently logs to stdout only, and the logging -verbosity is not yet configurable. However, as the libosmocore logging -framework is used, extending this is an easy modification. +`osmo-remsim-server` currently logs to stderr only; the logging +verbosity is configurable via command line argument only. However, as +the libosmocore logging framework is used, extending this is an easy +modification. [[rsres]] === RESTful/JSON Web API diff --git a/doc/manuals/osmo-remsim-usermanual.adoc b/doc/manuals/osmo-remsim-usermanual.adoc index 1679db2..32f173b 100644 --- a/doc/manuals/osmo-remsim-usermanual.adoc +++ b/doc/manuals/osmo-remsim-usermanual.adoc @@ -16,6 +16,8 @@ include::{srcdir}/chapters/remsim-bankd.adoc[] +include::{srcdir}/chapters/logging.adoc[] + include::{srcdir}/chapters/rspro.adoc[] //include::./common/chapters/vty.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I66f5fe2e55c7e4cb6cc8ce09dcd8a636c717a5a0 Gerrit-Change-Number: 26482 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:40:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 14:40:42 +0000 Subject: Change in osmo-remsim[master]: manual: update remsim-client options to match --help output In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/26483 to look at the new patch set (#3). Change subject: manual: update remsim-client options to match --help output ...................................................................... manual: update remsim-client options to match --help output * remove options that have been removed from code * re-order options to match the order of the --help ouptut Change-Id: Id4436b980c6a4691f3403ece400b90695a786e09 --- M doc/manuals/chapters/remsim-client.adoc 1 file changed, 7 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/83/26483/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id4436b980c6a4691f3403ece400b90695a786e09 Gerrit-Change-Number: 26483 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:40:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 14:40:42 +0000 Subject: Change in osmo-remsim[master]: manual: Update changelog, copyright, version In-Reply-To: References: Message-ID: Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/26484 to look at the new patch set (#3). Change subject: manual: Update changelog, copyright, version ...................................................................... manual: Update changelog, copyright, version Change-Id: I25f249a81f24f161fb2cf6df37ae217a5d425f8b --- M doc/manuals/osmo-remsim-usermanual-docinfo.xml 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/84/26484/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I25f249a81f24f161fb2cf6df37ae217a5d425f8b Gerrit-Change-Number: 26484 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:41:37 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 9 Dec 2021 14:41:37 +0000 Subject: Change in osmo-remsim[master]: manual: update remsim-client options to match --help output In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26483 ) Change subject: manual: update remsim-client options to match --help output ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id4436b980c6a4691f3403ece400b90695a786e09 Gerrit-Change-Number: 26483 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 09 Dec 2021 14:41:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 14:47:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 14:47:55 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26435 ) Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/libosmo-netif/+/26435/6//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/26435/6//COMMIT_MSG at 14 PS6, Line 14: ind/.cnf > I think this is confusing as it is a violation of the ITU-T X.210 terminology: [?] We have following operations: PRIM_OP_REQUEST, /*!< request */ PRIM_OP_RESPONSE, /*!< response */ PRIM_OP_INDICATION, /*!< indication */ PRIM_OP_CONFIRM, /*!< confirm */ I'm using IND (optionally answered by CNF) on one direction, and REQ (optionally answered by RESP) on the other direction. I have based all the existing messages on this premise as I documented it a few days/weeks ago. Please let me know if this really needs to be changed into some specific way, because I then need to redo all the existing messages on HNB. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Dec 2021 14:47:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:00:29 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 9 Dec 2021 15:00:29 +0000 Subject: Change in osmo-ttcn3-hacks[master]: break GTP_Templates dependency on Osmo_Gb_Types, BSSGP_Types, NS_Types In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26441 ) Change subject: break GTP_Templates dependency on Osmo_Gb_Types, BSSGP_Types, NS_Types ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26441 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icd8234908af445b798517fe110cd0648969179a4 Gerrit-Change-Number: 26441 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 09 Dec 2021 15:00:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:09:16 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 9 Dec 2021 15:09:16 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 ) Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 09 Dec 2021 15:09:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:10:25 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 9 Dec 2021 15:10:25 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add audio SAPI In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 ) Change subject: hnodeb: Add audio SAPI ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 Gerrit-Change-Number: 26444 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 09 Dec 2021 15:10:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:12:43 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 9 Dec 2021 15:12:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add gtp SAPI In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 ) Change subject: hnodeb: Add gtp SAPI ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 Gerrit-Change-Number: 26445 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 09 Dec 2021 15:12:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:15:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 15:15:36 +0000 Subject: Change in osmo-remsim[master]: manual: update remsim-client options to match --help output In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26483 ) Change subject: manual: update remsim-client options to match --help output ...................................................................... manual: update remsim-client options to match --help output * remove options that have been removed from code * re-order options to match the order of the --help ouptut Change-Id: Id4436b980c6a4691f3403ece400b90695a786e09 --- M doc/manuals/chapters/remsim-client.adoc 1 file changed, 7 insertions(+), 15 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/remsim-client.adoc b/doc/manuals/chapters/remsim-client.adoc index f2ee952..efd1752 100644 --- a/doc/manuals/chapters/remsim-client.adoc +++ b/doc/manuals/chapters/remsim-client.adoc @@ -90,13 +90,13 @@ Specify the slot number served within this client. The tuple of client-id and client-slot must be unique among all clients connecting to the same `osmo-remsim-server`. -*-i, --gsmtap-ip A.B.C.D*:: - Specify the IP address (if any) to which APDU traces are sent in - GSMTAP format (useful for debugging; supported by wireshark). -*-k, --keep-running*:: - Specify if the `osmo-remsim-client` should terminate after handling one - session, or whether it should keep running. Fast respawn (i.e. no - --keep-running) is probably the more robust option at this point. +*-a, --atr HEXSTRING*:: + Specify the initial ATR to be communicated to the modem/phone. Can + and will later be overridden by the ATR as specified by + `osmo-remsim-bankd` once a card has been mapped to this client. +*-e, --event-script COMMAND*:: + Specify the shell command to be execute when the client wants to call its + helper script *-V, --usb-vendor*:: Specify the USB Vendor ID of the USB device served by this client, use e.g. 0x1d50 for SIMtrace2, sysmoQMOD and OWHW. @@ -122,14 +122,6 @@ usefule to disambiguate between multiple identical USB devices attached to the same host. You don't need this if you have only one SIM emulation device attached to your system. -*-a, --atr HEXSTRING*:: - Specify the initial ATR to be communicated to the modem/phone. Can - and will later be overridden by the ATR as specified by - `osmo-remsim-bankd` once a card has been mapped to this client. -*-e, --event-script COMMAND*:: - Specify the shell command to be execute when the client wants to call its - helper script - ==== Examples .remsim-server is on 10.2.3.4, sysmoQMOD on usb bus, all 4 modems: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id4436b980c6a4691f3403ece400b90695a786e09 Gerrit-Change-Number: 26483 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:15:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 15:15:37 +0000 Subject: Change in osmo-remsim[master]: manual: Update changelog, copyright, version In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26484 ) Change subject: manual: Update changelog, copyright, version ...................................................................... manual: Update changelog, copyright, version Change-Id: I25f249a81f24f161fb2cf6df37ae217a5d425f8b --- M doc/manuals/osmo-remsim-usermanual-docinfo.xml 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/doc/manuals/osmo-remsim-usermanual-docinfo.xml b/doc/manuals/osmo-remsim-usermanual-docinfo.xml index a1ceb6d..37dca7b 100644 --- a/doc/manuals/osmo-remsim-usermanual-docinfo.xml +++ b/doc/manuals/osmo-remsim-usermanual-docinfo.xml @@ -7,6 +7,14 @@ Initial version. + + 2 + December 2021 + HW + + Update manual to osmo-remsim v1.0.0 (logging, command line arguments) + + @@ -24,7 +32,7 @@ - 2019 + 2019-2021 sysmocom - s.f.m.c. GmbH -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I25f249a81f24f161fb2cf6df37ae217a5d425f8b Gerrit-Change-Number: 26484 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:25:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 15:25:50 +0000 Subject: Change in osmo-ttcn3-hacks[master]: break GTP_Templates dependency on Osmo_Gb_Types, BSSGP_Types, NS_Types In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26441 ) Change subject: break GTP_Templates dependency on Osmo_Gb_Types, BSSGP_Types, NS_Types ...................................................................... break GTP_Templates dependency on Osmo_Gb_Types, BSSGP_Types, NS_Types The resulting set of dependencies needed just to have one simple CellId struct is huge. That was fine for sgsn testsuite since anyway those were being used, but it's not acceptable for other testsuites (hnodeb) which only really require the GTP side. After this change, GTP_Templates only requires GSM_Types, which ends up in a much smaller subset of dependencies being pulled in. Change-Id: Icd8234908af445b798517fe110cd0648969179a4 --- M library/GTP_Templates.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 36 insertions(+), 19 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index 1bd56e1..9c8d1b6 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -17,7 +17,17 @@ import from GTPU_Types all; import from GTP_CodecPort all; import from IPCP_Types all; - import from Osmocom_Gb_Types all; // BssgpCellId + import from GSM_Types all; // RoutingAreaIdentification, CellIdentity + + type record GTP_CellId { + RoutingAreaIdentification ra_id, + CellIdentity cell_id + } with { encode "RAW" }; + + template (value) GTP_CellId ts_GTP_CellId(template (value) RoutingAreaIdentification rai, CellIdentity cell_id) := { + ra_id := rai, + cell_id := cell_id + }; /* Table 38 of 3GPP TS 29.060 */ type enumerated GTP_Cause { @@ -673,7 +683,7 @@ }, rIMProtocolVersionNumber := int2oct(ver, 1) } - function tr_GTPC_Cell_Identifier_V(template BssgpCellId cid) return template Cell_Identifier_V_GTPC { + function tr_GTPC_Cell_Identifier_V(template GTP_CellId cid) return template Cell_Identifier_V_GTPC { var template Cell_Identifier_V_GTPC ret := { mccDigit1 := ?, mccDigit2 := ?, @@ -713,7 +723,7 @@ } return ret; } - template (value) Cell_Identifier_V_GTPC ts_GTPC_Cell_Identifier_V(BssgpCellId cid) := { + template (value) Cell_Identifier_V_GTPC ts_GTPC_Cell_Identifier_V(GTP_CellId cid) := { mccDigit1 := cid.ra_id.lai.mcc_mnc[0], mccDigit2 := cid.ra_id.lai.mcc_mnc[1], mccDigit3 := cid.ra_id.lai.mcc_mnc[2], @@ -724,10 +734,10 @@ rac := int2oct(cid.ra_id.rac, 1), cI_value := int2oct(cid.cell_id, 2) } - template RIM_Routing_Address_GTPC t_GTPC_RIM_Routing_Address_cid(BssgpCellId cid) := { + template RIM_Routing_Address_GTPC t_GTPC_RIM_Routing_Address_cid(GTP_CellId cid) := { cell_Identifier := ts_GTPC_Cell_Identifier_V(cid) } - function tr_GTPC_ENB_Identifier(template BssgpCellId cid, template integer tac, template octetstring gnbid) return template ENB_Identifier { + function tr_GTPC_ENB_Identifier(template GTP_CellId cid, template integer tac, template octetstring gnbid) return template ENB_Identifier { var template ENB_Identifier ret := { mccDigit1 := ?, mccDigit2 := ?, @@ -764,7 +774,7 @@ return ret; } - template (value) ENB_Identifier ts_GTPC_ENB_Identifier(BssgpCellId cid, integer tac, octetstring gnbid) := { + template (value) ENB_Identifier ts_GTPC_ENB_Identifier(GTP_CellId cid, integer tac, octetstring gnbid) := { mccDigit1 := cid.ra_id.lai.mcc_mnc[0], mccDigit2 := cid.ra_id.lai.mcc_mnc[1], mccDigit3 := cid.ra_id.lai.mcc_mnc[2], @@ -774,7 +784,7 @@ tAC := int2oct(tac, 2), globalENB_ID := gnbid } - template RIM_Routing_Address_GTPC t_GTPC_RIM_Routing_Address_enbid(BssgpCellId cid, integer tac, octetstring gnbid) := { + template RIM_Routing_Address_GTPC t_GTPC_RIM_Routing_Address_enbid(GTP_CellId cid, integer tac, octetstring gnbid) := { eNB_Identifier := ts_GTPC_ENB_Identifier(cid, tac, gnbid) } template RIM_Routing_Information_GTPC @@ -801,7 +811,7 @@ } /* 3GPP TS 48.018 11.3.63.1.1 */ template RAN_Information_Request_Application_Container_NACC_GTPC - tr_GTPC_RAN_Information_Request_Application_Container_NACC(template BssgpCellId cid) := { + tr_GTPC_RAN_Information_Request_Application_Container_NACC(template GTP_CellId cid) := { iEI := '4D'O, ext := '1'B, lengthIndicator := { @@ -810,7 +820,7 @@ reporting_Cell_Identifier := tr_GTPC_Cell_Identifier_V(cid) } template (value) RAN_Information_Request_Application_Container_NACC_GTPC - ts_GTPC_RAN_Information_Request_Application_Container_NACC(BssgpCellId cid) := { + ts_GTPC_RAN_Information_Request_Application_Container_NACC(GTP_CellId cid) := { iEI := '4D'O, ext := '1'B, lengthIndicator := { @@ -820,16 +830,16 @@ } /* 3GPP TS 48.018 11.3.63.1 */ template RAN_Information_Request_Application_Container_GTPC - tru_GTPC_RAN_Information_Request_Application_Container_NACC(template BssgpCellId cid) := { + tru_GTPC_RAN_Information_Request_Application_Container_NACC(template GTP_CellId cid) := { nacc := tr_GTPC_RAN_Information_Request_Application_Container_NACC(cid) } template (value) RAN_Information_Request_Application_Container_GTPC - tsu_GTPC_RAN_Information_Request_Application_Container_NACC(BssgpCellId cid) := { + tsu_GTPC_RAN_Information_Request_Application_Container_NACC(GTP_CellId cid) := { nacc := ts_GTPC_RAN_Information_Request_Application_Container_NACC(cid) } /* 3GPP TS 48.018 11.3.63.2.1 */ template RAN_Information_Application_Container_NACC_GTPC - tr_GTPC_RAN_Information_Application_Container_NACC(template BssgpCellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { + tr_GTPC_RAN_Information_Application_Container_NACC(template GTP_CellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { iEI := '4E'O, ext := '1'B, lengthIndicator := { @@ -841,7 +851,7 @@ sI_PSI := si_psi } template (value) RAN_Information_Application_Container_NACC_GTPC - ts_GTPC_RAN_Information_Application_Container_NACC(BssgpCellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { + ts_GTPC_RAN_Information_Application_Container_NACC(GTP_CellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { iEI := '4E'O, ext := '1'B, lengthIndicator := { @@ -892,11 +902,11 @@ /* RAN_Information */ template ApplContainer_or_ApplErrContainer_NACC_GTPC - tru_GTPC_ApplContainer_NACC(BssgpCellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { + tru_GTPC_ApplContainer_NACC(GTP_CellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { application_Container := tr_GTPC_RAN_Information_Application_Container_NACC(cid, psi_type, si_psi_num, si_psi) } template (value) ApplContainer_or_ApplErrContainer_NACC_GTPC - tsu_GTPC_ApplContainer_NACC(BssgpCellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { + tsu_GTPC_ApplContainer_NACC(GTP_CellId cid, boolean psi_type, integer si_psi_num, octetstring si_psi) := { application_Container := ts_GTPC_RAN_Information_Application_Container_NACC(cid, psi_type, si_psi_num, si_psi) } template ApplContainer_or_ApplErrContainer_GTPC diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 2461962..3386f71 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -250,6 +250,12 @@ return ret; }; +private function f_BssgpCellId_to_GTP_CellId(in BssgpCellId cell_id) return GTP_CellId +{ + template (value) GTP_CellId ret := ts_GTP_CellId(cell_id.ra_id, cell_id.cell_id); + return valueof(ret); +} + private function f_init_gb(inout GbInstance gb, charstring id, integer offset) runs on test_CT { gb.vc_NS := NS_CT.create(id & "-NS" & int2str(offset)); gb.vc_BSSGP := BSSGP_CT.create(id & "-BSSGP" & int2str(offset)); @@ -3373,20 +3379,21 @@ remName := mp_sgsn_gtp_ip, remPort := GTP1C_PORT } + var GTP_CellId gtp_ci := f_BssgpCellId_to_GTP_CellId(g_gb[1].cfg.bvc[0].cell_id); var template (value) RIM_Routing_Address_GTPC gtpc_dst_addr, gtpc_src_addr; var template (value) RAN_Information_Request_RIM_Container_GTPC gtpc_rim_req_cont; var template (value) PDU_BSSGP_RAN_INFORMATION_REQUEST_GTPC gtpc_bssgp_cont; var template (value) Gtp1cUnitdata gtpc_pdu; - gtpc_dst_addr := t_GTPC_RIM_Routing_Address_cid(g_gb[1].cfg.bvc[0].cell_id); - gtpc_src_addr := t_GTPC_RIM_Routing_Address_enbid(g_gb[1].cfg.bvc[0].cell_id, tac := 3, gnbid := '12345678123456'O); + gtpc_dst_addr := t_GTPC_RIM_Routing_Address_cid(gtp_ci); + gtpc_src_addr := t_GTPC_RIM_Routing_Address_enbid(gtp_ci, tac := 3, gnbid := '12345678123456'O); gtpc_rim_req_cont := ts_GTPC_RAN_Information_Request_RIM_Container(ts_GTPC_RIM_Application_Identity(RIM_APP_ID_NACC), ts_GTPC_RIM_Sequence_Number(1), ts_GTPC_RIM_PDU_Indications(false, RIM_PDU_TYPE_SING_REP), ts_GTPC_RIM_Protocol_Version_Number(1), - tsu_GTPC_RAN_Information_Request_Application_Container_NACC(g_gb[1].cfg.bvc[0].cell_id), + tsu_GTPC_RAN_Information_Request_Application_Container_NACC(gtp_ci), omit); gtpc_bssgp_cont := ts_GTPC_RAN_Information_Request(ts_GTPC_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID, gtpc_dst_addr), ts_GTPC_RIM_Routing_Information(RIM_ADDR_EUTRAN_NODEB_ID, gtpc_src_addr), @@ -3439,7 +3446,7 @@ ts_GTPC_RIM_Sequence_Number(2), ts_GTPC_RIM_PDU_Indications(false, RIM_PDU_TYPE_SING_REP), ts_GTPC_RIM_Protocol_Version_Number(1), - tru_GTPC_ApplContainer_or_ApplErrContainer_NACC(tru_GTPC_ApplContainer_NACC(g_gb[1].cfg.bvc[0].cell_id, false, 3, si_default)), + tru_GTPC_ApplContainer_or_ApplErrContainer_NACC(tru_GTPC_ApplContainer_NACC(gtp_ci, false, 3, si_default)), omit); gtpc_bssgp_cont_ack := tr_GTPC_RAN_Information(tr_GTPC_RIM_Routing_Information(RIM_ADDR_EUTRAN_NODEB_ID, gtpc_src_addr), tr_GTPC_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID, gtpc_dst_addr), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26441 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icd8234908af445b798517fe110cd0648969179a4 Gerrit-Change-Number: 26441 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:25:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 15:25:51 +0000 Subject: Change in libosmocore[master]: logging: make LIBOSMOCORE_NO_LOGGING work as expected In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26394 ) Change subject: logging: make LIBOSMOCORE_NO_LOGGING work as expected ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4c78abe5f198139f96ffa289998855be2477585 Gerrit-Change-Number: 26394 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Dec 2021 15:25:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:25:53 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 15:25:53 +0000 Subject: Change in libosmocore[master]: logging: make LIBOSMOCORE_NO_LOGGING work as expected In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26394 ) Change subject: logging: make LIBOSMOCORE_NO_LOGGING work as expected ...................................................................... logging: make LIBOSMOCORE_NO_LOGGING work as expected The macro introduced in d02090bba538158c36fd838d4e50c47e40f11449 was not enough: the actual logging macros are being used, i.e. by the fsm, so wrap those as well, and provide a flag to disable this at build time. Change-Id: Ia4c78abe5f198139f96ffa289998855be2477585 --- M configure.ac M include/osmocom/core/logging.h 2 files changed, 19 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index b36bd6f..a69f793 100644 --- a/configure.ac +++ b/configure.ac @@ -366,6 +366,17 @@ AC_DEFINE([PANIC_INFLOOP],[1],[Use infinite loop on panic rather than fprintf/abort]) fi +AC_ARG_ENABLE(log_macros, + [AS_HELP_STRING( + [--disable-log-macros], + [Disable logging macros that are also used internally to print information] + )], + [log_macros="yes"], [log_macros="no"]) +if test x"$log_macros" == x"yes" +then + AC_DEFINE([LIBOSMOCORE_NO_LOGGING],[1],[Disable logging macros]) +fi + AC_ARG_ENABLE(sanitize, [AS_HELP_STRING( [--enable-sanitize], diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index a95c478..18ad3ff 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -53,11 +53,15 @@ * \param[in] fmt format string * \param[in] args variable argument list */ +#ifndef LIBOSMOCORE_NO_LOGGING #define LOGPC(ss, level, fmt, args...) \ do { \ if (log_check_level(ss, level)) \ logp2(ss, level, __FILE__, __LINE__, 1, fmt, ##args); \ } while(0) +#else +#define LOGPC(ss, level, fmt, args...) +#endif /*! Log through the Osmocom logging framework with explicit source. * If caller_file is passed as NULL, __FILE__ and __LINE__ are used @@ -87,6 +91,7 @@ * \param[in] fmt format string * \param[in] args variable argument list */ +#ifndef LIBOSMOCORE_NO_LOGGING #define LOGPSRCC(ss, level, caller_file, caller_line, cont, fmt, args...) \ do { \ if (log_check_level(ss, level)) {\ @@ -96,6 +101,9 @@ logp2(ss, level, __FILE__, __LINE__, cont, fmt, ##args); \ }\ } while(0) +#else +#define LOGPSRCC(ss, level, caller_file, caller_line, cont, fmt, args...) +#endif /*! different log levels */ #define LOGL_DEBUG 1 /*!< debugging information */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26394 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4c78abe5f198139f96ffa289998855be2477585 Gerrit-Change-Number: 26394 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:26:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 15:26:18 +0000 Subject: Change in osmo-bsc[master]: bts-examples: add example for E1 connected BTS In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26367 ) Change subject: bts-examples: add example for E1 connected BTS ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Gerrit-Change-Number: 26367 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Dec 2021 15:26:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:26:22 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 15:26:22 +0000 Subject: Change in osmo-bsc[master]: bts-examples: add example for E1 connected BTS In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26367 ) Change subject: bts-examples: add example for E1 connected BTS ...................................................................... bts-examples: add example for E1 connected BTS The manual lacks an example on how to set up an E1 connected BTS. Especially the relation between trunk number and E1 line number is not obvious. Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Related: OS#5308 --- M doc/manuals/chapters/bts-examples.adoc 1 file changed, 117 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/bts-examples.adoc b/doc/manuals/chapters/bts-examples.adoc index 58cb3ab..836dec0 100644 --- a/doc/manuals/chapters/bts-examples.adoc +++ b/doc/manuals/chapters/bts-examples.adoc @@ -174,3 +174,120 @@ For building a multi-TRX setup, you also need to connect the TIB cables between the two nanoBTS units, as well as the coaxial/RF AUX cabling. ==== + +=== Example configuration for OsmoBSC with E1 BTS + +The following configuration sample illustrates the usage of BTSs that are +connected via an E1/T1 backhaul. + +.OsmoBSC configured for single-TRX E1 Ericsson DUG20 +==== +---- +e1_input <1> + e1_line 0 driver dahdi + e1_line 0 port 3 +network + network country code 1 + mobile network code 1 + encryption a5 0 + neci 1 + handover 0 + bts 0 + type rbs2000 + band GSM900 + om2000 version-limit oml gen 12 rev 10 <2> + cell_identity 0 + location_area_code 1 + training_sequence_code 7 + base_station_id_code 63 + ms max power 15 + cell reselection hysteresis 4 + rxlev access min 0 + channel allocator ascending + rach tx integer 9 + rach max transmission 7 + oml e1 line 0 timeslot 1 sub-slot full <3> + oml e1 tei 62 <4> + gprs mode none + is-connection-list add 4 512 12 <5> + is-connection-list add 16 524 12 + is-connection-list add 28 536 12 + is-connection-list add 40 548 12 + trx 0 + rf_locked 0 + arfcn 123 + nominal power 42 + max_power_red 12 + rsl e1 line 0 timeslot 1 sub-slot full <6> + rsl e1 tei 0 <7> + timeslot 0 + phys_chan_config CCCH+SDCCH4 + hopping enabled 0 + e1 line 0 timeslot 1 sub-slot full <8> + timeslot 1 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 2 sub-slot 1 <9> + timeslot 2 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 2 sub-slot 2 + timeslot 3 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 2 sub-slot 3 + timeslot 4 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 3 sub-slot 0 + timeslot 5 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 3 sub-slot 1 + timeslot 6 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 3 sub-slot 2 + timeslot 7 + phys_chan_config TCH/F + hopping enabled 0 + e1 line 0 timeslot 3 sub-slot 3 +---- +==== + +<1> In this example we use a dahdi E1 card. This card has 4 ports. Here we use port numer 3. It should be noted that the dahdi driver also requires additional configuration, which is not covered by this manual. + +<2> In this example we use an E1 Ericsson DUG20, which uses an OML dialect, called "OM2000". + +<3> The first usable timeslot on an E1 line is TS1. In this example we will assume that TS1-TS3 are connected to the BTS stright through. TS1 will handle all signaling traffic. Here we assign this timeslot to OML. + +<4> OML always requires a TEI (Terminal Equipment Identifier) to set up. This number can be found in the manual of the BTS. + +<5> This BTS has an built in ?Interface Switch? (IS) that offers flexible way to reconfigure the interconnection between the internal components of the BTS and the external E1 line. This depends on the exact BTS type and configuration. + +<6> Similar to OML we assign TS1 to RSL as well. + +<7> Like with OML, RSL also requires a TEI to be configured. Usually each TRX will have a specific TEI assigned. + +<8> CCCH+SDCCH4 will also be mapped on TS1. The traffic for those control channels will be multiplexed alongside the RSL and OML traffic. + +<9> The bandwidth of one E1 timeslot matches the bandwidth of 4 GSM air interface timeslots. The E1 timeslot is split up into four sub-slots, which are then assigned to one GSM air interface timeslot each. Since the first timeslot on the first TRX is already used for signaling we begin the sub-slot counting with sub-slot 1 for alignment reasons. + +=== E1 Line number and MGCP trunk number +The switching of the voice channels is done via OsmoMGW, which acts as a media +converter between E1 and VoIP (RTP). OsmoBSC will use the E1 line number to +address the trunk via MGCP. + +When configuring OsmoMGW, one needs to make sure that the trunk number that is +set up on OsmoMGW, matches the line number that is set up on OsmoBSC. When those +numbers mismatch the trunk cannot be addressed correctly. + +.OsmoMGW trunk configuration that matches the OsmoBSC configuration above +==== +---- + trunk 0 + rtp keep-alive once + no rtp keep-alive + line 0 +---- +==== \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02f5d4fe059e5cc9c3ffc2e3636d812532c09239 Gerrit-Change-Number: 26367 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:28:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 15:28:29 +0000 Subject: Change in libosmocore[master]: select: add member for human readable name to osmo_fd In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26453 ) Change subject: select: add member for human readable name to osmo_fd ...................................................................... Patch Set 1: > Patch Set 1: Code-Review-1 > > I personally wouldn't add this field here, for several reasons: > * It's breaking ABI in all our code base > * We can have lots and lots of osmo_fd structures, we are adding more used space here for some specific case > * Since it's a specific case, we have "void *data" for that. The name can be stored there (or as a field in the struct stored in *data). I'm not so much worried about memory consumption. Even in a large osmocom program with 1000 file descriptors, we're talking about 8kByte of RAM only. Yes, of couse, I know about cache efficiency, but still I think this is not a concern. In general, I think having named osmo_fd opens up other possibilities in terms of introspection via VTY. So it's not a bad idea, IMHO. Yes, it will break ABI. That's the only really sad part about it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I64b288174ae3dd22d50a701ce7cbf9e623246479 Gerrit-Change-Number: 26453 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Dec 2021 15:28:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:30:48 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 15:30:48 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26435 ) Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/libosmo-netif/+/26435/6//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/26435/6//COMMIT_MSG at 14 PS6, Line 14: ind/.cnf > We have following operations: [?] Indeed, there should be careful review, but I don't have the time now to go through all those details, sorry. Please have a look at X.210 and review yourself. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 09 Dec 2021 15:30:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 15:44:11 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 15:44:11 +0000 Subject: Change in libosmocore[master]: select: add member for human readable name to osmo_fd In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26453 ) Change subject: select: add member for human readable name to osmo_fd ...................................................................... Patch Set 1: > Patch Set 1: > > Yes, it will break ABI. That's the only really sad part about it. Further specific inspection can be done using the *data pointer on each app imho. I'm not blocking this in case it really needs to be done, but I'm not really liking it, specially due to the ABI breakage. I think further work on the direction I propose should at least be attempted before merging this patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I64b288174ae3dd22d50a701ce7cbf9e623246479 Gerrit-Change-Number: 26453 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 09 Dec 2021 15:44:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 16:52:58 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 16:52:58 +0000 Subject: Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 to look at the new patch set (#7). Change subject: Introduce osmo_prim_srv APIs ...................................................................... Introduce osmo_prim_srv APIs This new module allows easy exchange of osmo_prim based data types over IPC communication (UD socket supported only so far), by replacing the osmo_prim_hdr struct with a serialized header when submitting/receiving it from the IPC socket. This patch introduces the server side of the UD socket, but the client side can easily be introduced in the same file whenever needed. Related: SYS#5516 Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 --- M TODO-RELEASE M include/osmocom/netif/Makefile.am A include/osmocom/netif/prim.h M src/Makefile.am A src/prim.c 5 files changed, 409 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/26/26426/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 Gerrit-Change-Number: 26426 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 16:52:58 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 16:52:58 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 to look at the new patch set (#7). Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... prim: Add internal CTL SAPI to negotiate SAP versions This commits adds a generic mechansim for applications to validate support for SAPs and specific versions of them. A new special SAPI is introduced to manage inbound control messages for the protocol. In that SAPI a new primitive HELLO.ind/.cnf is added to negotiate support for versions of any given SAP. The idea is that the client upon connecting submits a HELLO.ind(SAP, VER) for each SAP it plans to use, including the version of the special CTL SAPI itself (preferrably to be checked first). Upon receiving such a message, osmo_prim_srv handles it using a special path, which ends up calling the user provided rx_sapi_version_cb(SAP, VER). In there, the user can either: * Accept the version (return same VER value) * Reject the requested version but propose another candidate version (return some positive VER value other than received VER). In this case, the client can decide whether to request another VER or close the connection. * Reject the proposed version and close the connection. Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 --- M include/osmocom/netif/prim.h M src/prim.c 2 files changed, 122 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/35/26435/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 17:40:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 17:40:15 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 to look at the new patch set (#8). Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... prim: Add internal CTL SAPI to negotiate SAP versions This commits adds a generic mechansim for applications to validate support for SAPs and specific versions of them. A new special SAPI is introduced to manage inbound control messages for the protocol. In that SAPI a new primitive HELLO.ind/.cnf is added to negotiate support for versions of any given SAP. The idea is that the client upon connecting submits a HELLO.ind(SAP, VER) for each SAP it plans to use, including the version of the special CTL SAPI itself (preferrably to be checked first). Upon receiving such a message, osmo_prim_srv handles it using a special path, which ends up calling the user provided rx_sapi_version_cb(SAP, VER). In there, the user can either: * Accept the version (return same VER value) * Reject the requested version but propose another candidate version (return some positive VER value other than received VER). In this case, the client can decide whether to request another VER or close the connection. * Reject the proposed version and close the connection. Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 --- M include/osmocom/netif/prim.h M src/prim.c 2 files changed, 122 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/35/26435/8 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 8 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 18:34:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 18:34:59 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 to look at the new patch set (#7). Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... hnodeb: Add initial infra to emulate HNB LL socket iface Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.default M hnodeb/HNB_Tests.ttcn M hnodeb/gen_links.sh M hnodeb/regen_makefile.sh A library/HNBLLIF_CodecPort.ttcn A library/HNBLLIF_Templates.ttcn A library/HNBLLIF_Types.ttcn M library/Iuh_CodecPort.ttcn M library/rua/RUA_Templates.ttcn 10 files changed, 981 insertions(+), 38 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/26373/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 18:34:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 18:34:59 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add audio SAPI In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 to look at the new patch set (#2). Change subject: hnodeb: Add audio SAPI ...................................................................... hnodeb: Add audio SAPI Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 4 files changed, 262 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/26444/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 Gerrit-Change-Number: 26444 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 18:34:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 18:34:59 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add gtp SAPI In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 to look at the new patch set (#2). Change subject: hnodeb: Add gtp SAPI ...................................................................... hnodeb: Add gtp SAPI Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn M hnodeb/gen_links.sh M hnodeb/regen_makefile.sh M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 6 files changed, 349 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/26445/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 Gerrit-Change-Number: 26445 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 19:10:52 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 9 Dec 2021 19:10:52 +0000 Subject: Change in osmo-dev[master]: Add tmux scripts for ttcn3-{msc, bsc, bts}-test References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/26485 ) Change subject: Add tmux scripts for ttcn3-{msc,bsc,bts}-test ...................................................................... Add tmux scripts for ttcn3-{msc,bsc,bts}-test Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 --- A ttcn3/tmux/ttcn3-bsc-test.sh A ttcn3/tmux/ttcn3-bts-test.sh A ttcn3/tmux/ttcn3-msc-test.sh 3 files changed, 123 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/85/26485/1 diff --git a/ttcn3/tmux/ttcn3-bsc-test.sh b/ttcn3/tmux/ttcn3-bsc-test.sh new file mode 100755 index 0000000..c0d9709 --- /dev/null +++ b/ttcn3/tmux/ttcn3-bsc-test.sh @@ -0,0 +1,43 @@ +#!/bin/sh + +SESSION="ttcn3-bsc-test" + +OSMO_DIR="/home/$USER/osmocom" +SUITE_DIR="$OSMO_DIR/osmo-ttcn3-hacks" +RESPAWN="$OSMO_DIR/scripts/respawn.sh" + +if [ ! -d $SUITE_DIR ]; then + echo "Directory '$SUITE_DIR' does not exist" + echo "Please specify where to find osmo-ttcn3-hacks" + exit 1 +fi + +if [ ! -f $RESPAWN ]; then + echo "Script '$RESPAWN' does not exist" + echo "Please specify where to find respawn.sh" + exit 1 +fi + +tmux new-session -s $SESSION -n $SESSION -d + +tmux split-window -t $SESSION:0 -v +tmux send-keys -t $SESSION:0.0 "cd $SUITE_DIR/bsc" C-m +tmux send-keys -t $SESSION:0.0 "osmo-bsc -c osmo-bsc.cfg" C-m +tmux send-keys -t $SESSION:0.1 "cd $SUITE_DIR/bsc" C-m +tmux send-keys -t $SESSION:0.1 "../start-testsuite.sh ./BSC_Tests BSC_Tests.cfg" + +tmux new-window -t $SESSION:1 +tmux split-window -t $SESSION:1 -v +tmux split-window -t $SESSION:1 -v +tmux split-window -t $SESSION:1 -v +tmux split-window -t $SESSION:1 -v + +# Start osmo-stp +tmux send-keys -t $SESSION:1.0 "cd $SUITE_DIR/bsc" C-m +tmux send-keys -t $SESSION:1.0 "osmo-stp -c osmo-stp.cfg" C-m +# Start osmo-bts-omldummy +tmux send-keys -t $SESSION:1.1 "$RESPAWN osmo-bts-omldummy 127.0.0.1 1234" C-m +tmux send-keys -t $SESSION:1.2 "$RESPAWN osmo-bts-omldummy 127.0.0.1 1235" C-m +tmux send-keys -t $SESSION:1.3 "$RESPAWN osmo-bts-omldummy 127.0.0.1 1236" C-m + +tmux attach -t $SESSION:0 diff --git a/ttcn3/tmux/ttcn3-bts-test.sh b/ttcn3/tmux/ttcn3-bts-test.sh new file mode 100755 index 0000000..25a3351 --- /dev/null +++ b/ttcn3/tmux/ttcn3-bts-test.sh @@ -0,0 +1,54 @@ +#!/bin/sh + +SESSION="ttcn3-bts-test" + +OSMO_DIR="/home/$USER/osmocom" +OBB_DIR="$OSMO_DIR/osmocom-bb" +SUITE_DIR="$OSMO_DIR/osmo-ttcn3-hacks" +RESPAWN="$OSMO_DIR/scripts/respawn.sh" + +if [ ! -d $SUITE_DIR ]; then + echo "Directory '$SUITE_DIR' does not exist" + echo "Please specify where to find osmo-ttcn3-hacks" + exit 1 +fi + +if [ ! -d $OBB_DIR ]; then + echo "Directory '$OBB_DIR' does not exist" + echo "Please specify where to find osmocom-bb" + exit 1 +fi + +if [ ! -f $RESPAWN ]; then + echo "Script '$RESPAWN' does not exist" + echo "Please specify where to find respawn.sh" + exit 1 +fi + +tmux new-session -s $SESSION -n $SESSION -d + +tmux split-window -t $SESSION:0 -v +tmux send-keys -t $SESSION:0.0 "cd $SUITE_DIR/bts" C-m +tmux send-keys -t $SESSION:0.0 "$RESPAWN osmo-bts-trx -c osmo-bts.cfg" +tmux send-keys -t $SESSION:0.1 "cd $SUITE_DIR/bts" C-m +tmux send-keys -t $SESSION:0.1 "../start-testsuite.sh ./BTS_Tests cfg/BTS_Tests.cfg" + + +tmux new-window -t $SESSION:1 +tmux split-window -t $SESSION:1 -v +tmux split-window -t $SESSION:1 -v + +# Start osmo-bsc +tmux send-keys -t $SESSION:1.0 "cd $SUITE_DIR/bts" C-m +tmux send-keys -t $SESSION:1.0 "osmo-bsc -c osmo-bsc.cfg" C-m +# Start trxcon +tmux send-keys -t $SESSION:1.1 "cd $OBB_DIR/src/host/trxcon" C-m +tmux send-keys -t $SESSION:1.1 "./trxcon -s /tmp/osmocom_l2.ttcn" C-m +# Start fake_trx.py +tmux send-keys -t $SESSION:1.2 "cd $OBB_DIR/src/target/trx_toolkit" C-m +tmux send-keys -t $SESSION:1.2 "./fake_trx.py \ + --trx TRX1 at 127.0.0.1:5700/1 \ + --trx TRX1 at 127.0.0.1:5700/2 \ + --trx TRX1 at 127.0.0.1:5700/3" C-m + +tmux attach -t $SESSION:0 diff --git a/ttcn3/tmux/ttcn3-msc-test.sh b/ttcn3/tmux/ttcn3-msc-test.sh new file mode 100755 index 0000000..fee1383 --- /dev/null +++ b/ttcn3/tmux/ttcn3-msc-test.sh @@ -0,0 +1,26 @@ +#!/bin/sh + +SESSION="ttcn3-msc-test" + +OSMO_DIR="/home/$USER/osmocom" +SUITE_DIR="$OSMO_DIR/osmo-ttcn3-hacks" + +if [ ! -d $SUITE_DIR ]; then + echo "Directory '$SUITE_DIR' does not exist" + echo "Please specify where to find osmo-ttcn3-hacks" + exit 1 +fi + +tmux new-session -s $SESSION -n $SESSION -d + +tmux split-window -t $SESSION:0 -v +tmux send-keys -t $SESSION:0.0 "cd $SUITE_DIR/msc" C-m +tmux send-keys -t $SESSION:0.0 "osmo-msc -c osmo-msc.cfg" C-m +tmux send-keys -t $SESSION:0.1 "cd $SUITE_DIR/msc" C-m +tmux send-keys -t $SESSION:0.1 "../start-testsuite.sh ./MSC_Tests MSC_Tests.cfg" + +tmux new-window -t $SESSION:1 +tmux send-keys -t $SESSION:1.0 "cd $SUITE_DIR/msc" C-m +tmux send-keys -t $SESSION:1.0 "osmo-stp -c osmo-stp.cfg" C-m + +tmux attach -t $SESSION:0 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 Gerrit-Change-Number: 26485 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 19:22:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 9 Dec 2021 19:22:04 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 to look at the new patch set (#9). Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... prim: Add internal CTL SAPI to negotiate SAP versions This commits adds a generic mechanism for applications to validate support for SAPs and specific versions of them. A new special SAPI is introduced to manage inbound control messages for the protocol. In that SAPI a new primitive HELLO.req/.cnf is added to negotiate support for versions of any given SAP. The idea is that the client upon connecting submits a HELLO.req(SAP, VER) for each SAP it plans to use, including the version of the special CTL SAPI itself (preferrably to be checked first). Upon receiving such a message, osmo_prim_srv handles it using a special path, which ends up calling the user provided rx_sapi_version_cb(SAP, VER). In there, the user can either: * Accept the version (return same VER value) * Reject the requested version but propose another candidate version (return some positive VER value other than received VER). In this case, the client can decide whether to request another VER or close the connection. * Reject the proposed version and close the connection. Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 --- M include/osmocom/netif/prim.h M src/prim.c 2 files changed, 122 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/35/26435/9 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 9 21:46:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 9 Dec 2021 21:46:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Use alive-type components for "infrastructure" components References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26486 ) Change subject: Use alive-type components for "infrastructure" components ...................................................................... Use alive-type components for "infrastructure" components According to feedback received from TITAN developers in https://www.eclipse.org/forums/index.php?t=msg&th=1106652&goto=1848616&#msg_1848616 the use of alive-type components has the following advantage: > Also the DTE during the shutdown can be avoided to use alive type > components. The test ports of the alive components are not > disconnected/unmapped when the component finished only when killed or > the MTC terminated. So the idea of this patch is to use alive-type components for all the underlying infrastructure, such as the *_Emulation_CT starting from M3UA to SCCP and further up the stack. This way, only the MTC and the highest level of components (such as ConnHdlr) remain as normal components. The hope is that using more alive-type components in the lower protocol layer emulations will reduce the probability of DTE during shutdown if some message is received during the component shutdown after the MTC has completed. Change-Id: I61d791d6d1bfe9226aabbe223baafc5f8f6d4f04 --- M bsc/BSC_Tests.ttcn M gbproxy/GBProxy_Tests.ttcn M library/BSSAP_LE_Adapter.ttcn 3 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/26486/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index e7c4599..f9fd212 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -913,12 +913,12 @@ timer T := 10.0; clnt.id := "IPA" & int2str(i) & "-RSL"; - clnt.vc_IPA := IPA_Emulation_CT.create(clnt.id & "-IPA"); + clnt.vc_IPA := IPA_Emulation_CT.create(clnt.id & "-IPA") alive; clnt.ccm_pars := c_IPA_default_ccm_pars; clnt.ccm_pars.name := "Osmocom TTCN-3 BTS Simulator"; clnt.ccm_pars.unit_id := int2str(1234+i) & "/0/0"; if (handler_mode) { - clnt.vc_RSL := RSL_Emulation_CT.create(clnt.id & "-RSL"); + clnt.vc_RSL := RSL_Emulation_CT.create(clnt.id & "-RSL") alive; connect(clnt.vc_RSL:CCHAN_PT, self:RSL_CCHAN[i]); } @@ -1021,7 +1021,7 @@ multi_conn_mode := (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_SCCPlite_SERVER) }; - vc_MGCP := MGCP_Emulation_CT.create(id); + vc_MGCP := MGCP_Emulation_CT.create(id) alive; vc_MGCP.start(MGCP_Emulation.main(ops, mgcp_pars, id)); } @@ -3566,7 +3566,7 @@ timer T := 10.0; bts[0].rsl.id := "IPA-0-RSL"; - bts[0].rsl.vc_IPA := IPA_Emulation_CT.create(bts[0].rsl.id & "-IPA"); + bts[0].rsl.vc_IPA := IPA_Emulation_CT.create(bts[0].rsl.id & "-IPA") alive; bts[0].rsl.ccm_pars := c_IPA_default_ccm_pars; bts[0].rsl.ccm_pars.name := "Osmocom TTCN-3 BTS Simulator"; bts[0].rsl.ccm_pars.unit_id := "99/0/0"; /* value which is unknown at BTS */ diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn index ddf98a9..3f822c2 100644 --- a/gbproxy/GBProxy_Tests.ttcn +++ b/gbproxy/GBProxy_Tests.ttcn @@ -447,8 +447,8 @@ private function f_init_gb_pcu(inout GbInstance gb, charstring id, integer offset) runs on test_CT { var charstring ns_id := id & "-NS(PCU[" & int2str(offset) & "])"; var charstring bssgp_id := id & "-BSSGP(PCU[" & int2str(offset) & "])"; - gb.vc_NS := NS_CT.create(ns_id); - gb.vc_BSSGP := BSSGP_CT.create(bssgp_id); + gb.vc_NS := NS_CT.create(ns_id) alive; + gb.vc_BSSGP := BSSGP_CT.create(bssgp_id) alive; /* connect lower end of BSSGP emulation with NS upper port */ connect(gb.vc_BSSGP:BSCP, gb.vc_NS:NS_SP); @@ -470,8 +470,8 @@ private function f_init_gb_sgsn(inout GbInstance gb, charstring id, integer offset) runs on test_CT { var charstring ns_id := id & "-NS(SGSN[" & int2str(offset) & "])"; var charstring bssgp_id := id & "-BSSGP(SGSN[" & int2str(offset) & "])"; - gb.vc_NS := NS_CT.create(ns_id); - gb.vc_BSSGP := BSSGP_CT.create(bssgp_id); + gb.vc_NS := NS_CT.create(ns_id) alive; + gb.vc_BSSGP := BSSGP_CT.create(bssgp_id) alive; /* connect lower end of BSSGP emulation with NS upper port */ connect(gb.vc_BSSGP:BSCP, gb.vc_NS:NS_SP); diff --git a/library/BSSAP_LE_Adapter.ttcn b/library/BSSAP_LE_Adapter.ttcn index dba8841..256d8fa 100644 --- a/library/BSSAP_LE_Adapter.ttcn +++ b/library/BSSAP_LE_Adapter.ttcn @@ -85,13 +85,13 @@ ops.sccp_addr_peer := ba.sccp_addr_peer; /* create components */ - ba.vc_SCCP := SCCP_CT.create(id & "-SCCP"); + ba.vc_SCCP := SCCP_CT.create(id & "-SCCP") alive; if (isvalue(ops)) { - ba.vc_BSSAP_LE := BSSAP_LE_Emulation_CT.create(id & "-BSSAP_LE"); + ba.vc_BSSAP_LE := BSSAP_LE_Emulation_CT.create(id & "-BSSAP_LE") alive; } else { ba.vc_BSSAP_LE := null; } - ba.vc_M3UA := M3UA_CT.create(id & "-M3UA"); + ba.vc_M3UA := M3UA_CT.create(id & "-M3UA") alive; map(ba.vc_M3UA:SCTP_PORT, system:sctp); /* connect MTP3 service provider (M3UA) to lower side of SCCP */ connect(ba.vc_M3UA:MTP3_SP_PORT, ba.vc_SCCP:MTP3_SCCP_PORT); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I61d791d6d1bfe9226aabbe223baafc5f8f6d4f04 Gerrit-Change-Number: 26486 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Dec 10 00:30:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 00:30:31 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <61b29fb248d68_72822b13744585f0871762@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 32s] + cd simtrace2-0.8.0.202112100026 [ 32s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/share/doc/packages/simtrace2 [ 32s] + export LC_ALL=C [ 32s] + LC_ALL=C [ 32s] + export DOCDIR [ 32s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/share/doc/packages/simtrace2 [ 32s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/share/doc/packages/simtrace2 [ 32s] + RPM_EC=0 [ 32s] ++ jobs -p [ 32s] + exit 0 [ 32s] Provides: simtrace2 = 0.8.0.202112100026-1.1 simtrace2(x86-32) = 0.8.0.202112100026-1.1 [ 32s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 32s] Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libosmo-simtrace2.so.1 libosmocore.so.18 libosmosim.so.2 libosmousb.so.0 libusb-1.0.so.0 [ 32s] Processing files: simtrace2-debugsource-0.8.0.202112100026-1.1.i586 [ 32s] Provides: simtrace2-debugsource = 0.8.0.202112100026-1.1 simtrace2-debugsource(x86-32) = 0.8.0.202112100026-1.1 [ 32s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 32s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-1.1.i586 [ 32s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/lib/libosmo-simtrace2.so.0* [ 32s] [ 32s] [ 32s] RPM build errors: [ 32s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/lib/libosmo-simtrace2.so.0* [ 32s] ### VM INTERACTION START ### [ 35s] [ 30.560260][ T433] sysrq: Power Off [ 35s] [ 30.562892][ T7] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] goat11 failed "build simtrace2.spec" at Fri Dec 10 00:30:21 UTC 2021. [ 35s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 00:35:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 00:35:23 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61b2a0db5e1af_72822b13744585f0875867@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/CentOS_8/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 129s] + umask 022 [ 129s] + cd /home/abuild/rpmbuild/BUILD [ 129s] + cd simtrace2-0.8.0.202112100026 [ 129s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/share/doc/simtrace2 [ 129s] + export LC_ALL=C [ 129s] + LC_ALL=C [ 129s] + export DOCDIR [ 129s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/share/doc/simtrace2 [ 129s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/share/doc/simtrace2 [ 129s] + exit 0 [ 129s] Provides: simtrace2 = 0.8.0.202112100026-1.1 simtrace2(x86-64) = 0.8.0.202112100026-1.1 [ 129s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 129s] Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libpthread.so.0()(64bit) libtalloc.so.2()(64bit) libusb-1.0.so.0()(64bit) rtld(GNU_HASH) [ 129s] Processing files: simtrace2-debugsource-0.8.0.202112100026-1.1.x86_64 [ 129s] Provides: simtrace2-debugsource = 0.8.0.202112100026-1.1 simtrace2-debugsource(x86-64) = 0.8.0.202112100026-1.1 [ 129s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 129s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-1.1.x86_64 [ 129s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 129s] [ 129s] [ 129s] RPM build errors: [ 129s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 129s] ### VM INTERACTION START ### [ 130s] Powering off. [ 130s] [ 95.396770] reboot: Power down [ 130s] ### VM INTERACTION END ### [ 130s] [ 130s] old-atreju4 failed "build simtrace2.spec" at Fri Dec 10 00:35:20 UTC 2021. [ 130s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 00:35:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 00:35:57 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61b2a0f8b3056_72822b13744585f0876048@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 60s] + umask 022 [ 60s] + cd /home/abuild/rpmbuild/BUILD [ 60s] + cd simtrace2-0.8.0.202112100026 [ 60s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp152.1.1.x86_64/usr/share/doc/packages/simtrace2 [ 60s] + export LC_ALL=C [ 60s] + LC_ALL=C [ 60s] + export DOCDIR [ 60s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp152.1.1.x86_64/usr/share/doc/packages/simtrace2 [ 60s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp152.1.1.x86_64/usr/share/doc/packages/simtrace2 [ 60s] + exit 0 [ 60s] Provides: simtrace2 = 0.8.0.202112100026-lp152.1.1 simtrace2(x86-64) = 0.8.0.202112100026-lp152.1.1 [ 60s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 60s] Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libpthread.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 60s] Processing files: simtrace2-debugsource-0.8.0.202112100026-lp152.1.1.x86_64 [ 60s] Provides: simtrace2-debugsource = 0.8.0.202112100026-lp152.1.1 simtrace2-debugsource(x86-64) = 0.8.0.202112100026-lp152.1.1 [ 60s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 60s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-lp152.1.1.x86_64 [ 60s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp152.1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 60s] [ 60s] [ 60s] RPM build errors: [ 60s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp152.1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 60s] ### VM INTERACTION START ### [ 64s] [ 54.027127] sysrq: Power Off [ 64s] [ 54.042872] reboot: Power down [ 64s] ### VM INTERACTION END ### [ 64s] [ 64s] hci-cnode2-m0 failed "build simtrace2.spec" at Fri Dec 10 00:35:40 UTC 2021. [ 64s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 00:36:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 00:36:14 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <61b2a1181712e_72822b13744585f08762f7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 83s] + cd simtrace2-0.8.0.202112100026 [ 83s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 83s] + export LC_ALL=C [ 83s] + LC_ALL=C [ 83s] + export DOCDIR [ 83s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 83s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 83s] + RPM_EC=0 [ 83s] ++ jobs -p [ 83s] + exit 0 [ 83s] Provides: simtrace2 = 0.8.0.202112100026-1.1 simtrace2(x86-64) = 0.8.0.202112100026-1.1 [ 83s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 83s] Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.34)(64bit) libc.so.6(GLIBC_2.4)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 83s] Processing files: simtrace2-debugsource-0.8.0.202112100026-1.1.x86_64 [ 83s] Provides: simtrace2-debugsource = 0.8.0.202112100026-1.1 simtrace2-debugsource(x86-64) = 0.8.0.202112100026-1.1 [ 83s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 83s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-1.1.x86_64 [ 83s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 83s] [ 83s] [ 83s] RPM build errors: [ 83s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 83s] ### VM INTERACTION START ### [ 87s] [ 76.889019][ T438] sysrq: Power Off [ 87s] [ 76.917262][ T149] reboot: Power down [ 87s] ### VM INTERACTION END ### [ 87s] [ 87s] lamb01 failed "build simtrace2.spec" at Fri Dec 10 00:36:02 UTC 2021. [ 87s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 00:41:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 00:41:40 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61b2a2631084f_72822b13744585f087858d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 129s] + umask 022 [ 129s] + cd /home/abuild/rpmbuild/BUILD [ 129s] + cd simtrace2-0.8.0.202112100026 [ 129s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.x86_64/usr/share/doc/packages/simtrace2 [ 129s] + export LC_ALL=C [ 129s] + LC_ALL=C [ 129s] + export DOCDIR [ 129s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.x86_64/usr/share/doc/packages/simtrace2 [ 129s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.x86_64/usr/share/doc/packages/simtrace2 [ 129s] + exit 0 [ 129s] Provides: simtrace2 = 0.8.0.202112100026-lp151.1.1 simtrace2(x86-64) = 0.8.0.202112100026-lp151.1.1 [ 129s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 129s] Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libpthread.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 129s] Processing files: simtrace2-debugsource-0.8.0.202112100026-lp151.1.1.x86_64 [ 129s] Provides: simtrace2-debugsource = 0.8.0.202112100026-lp151.1.1 simtrace2-debugsource(x86-64) = 0.8.0.202112100026-lp151.1.1 [ 129s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 129s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-lp151.1.1.x86_64 [ 129s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 129s] [ 129s] [ 129s] RPM build errors: [ 129s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 129s] ### VM INTERACTION START ### [ 132s] [ 101.111140] sysrq: SysRq : Power Off [ 133s] [ 101.159461] reboot: Power down [ 133s] ### VM INTERACTION END ### [ 133s] [ 133s] lamb52 failed "build simtrace2.spec" at Fri Dec 10 00:41:23 UTC 2021. [ 133s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 00:59:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 00:59:57 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <61b2a696c8b07_72822b13744585f088184e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 34s] + cd simtrace2-0.8.0 [ 34s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 34s] + export LC_ALL=C [ 34s] + LC_ALL=C [ 34s] + export DOCDIR [ 34s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 34s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 34s] + RPM_EC=0 [ 34s] ++ jobs -p [ 34s] + exit 0 [ 34s] Provides: simtrace2 = 0.8.0-1.1 simtrace2(x86-64) = 0.8.0-1.1 [ 34s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 34s] Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.34)(64bit) libc.so.6(GLIBC_2.4)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 34s] Processing files: simtrace2-debugsource-0.8.0-1.1.x86_64 [ 34s] Provides: simtrace2-debugsource = 0.8.0-1.1 simtrace2-debugsource(x86-64) = 0.8.0-1.1 [ 34s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 34s] Processing files: libosmo-simtrace2-0-0.8.0-1.1.x86_64 [ 34s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 34s] [ 34s] [ 34s] RPM build errors: [ 34s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 34s] ### VM INTERACTION START ### [ 37s] [ 31.896520][ T437] sysrq: Power Off [ 37s] [ 31.914005][ T7] reboot: Power down [ 37s] ### VM INTERACTION END ### [ 37s] [ 37s] goat07 failed "build simtrace2.spec" at Fri Dec 10 00:59:47 UTC 2021. [ 37s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:00:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:00:14 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61b2a6b5c9eaf_72822b13744585f088191a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 51s] + umask 022 [ 51s] + cd /home/abuild/rpmbuild/BUILD [ 51s] + cd simtrace2-0.8.0 [ 51s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp152.1.1.x86_64/usr/share/doc/packages/simtrace2 [ 51s] + export LC_ALL=C [ 51s] + LC_ALL=C [ 51s] + export DOCDIR [ 51s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp152.1.1.x86_64/usr/share/doc/packages/simtrace2 [ 51s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp152.1.1.x86_64/usr/share/doc/packages/simtrace2 [ 51s] + exit 0 [ 51s] Provides: simtrace2 = 0.8.0-lp152.1.1 simtrace2(x86-64) = 0.8.0-lp152.1.1 [ 51s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 51s] Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libpthread.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 51s] Processing files: simtrace2-debugsource-0.8.0-lp152.1.1.x86_64 [ 51s] Provides: simtrace2-debugsource = 0.8.0-lp152.1.1 simtrace2-debugsource(x86-64) = 0.8.0-lp152.1.1 [ 51s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 51s] Processing files: libosmo-simtrace2-0-0.8.0-lp152.1.1.x86_64 [ 51s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp152.1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 51s] [ 51s] [ 51s] RPM build errors: [ 51s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp152.1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 51s] ### VM INTERACTION START ### [ 54s] [ 46.046535] sysrq: Power Off [ 54s] [ 46.049738] reboot: Power down [ 55s] ### VM INTERACTION END ### [ 55s] [ 55s] sheep86 failed "build simtrace2.spec" at Fri Dec 10 01:00:05 UTC 2021. [ 55s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:00:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:00:31 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61b2a6b6dfcc3_72822b13744585f0882030@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 62s] + umask 022 [ 62s] + cd /home/abuild/rpmbuild/BUILD [ 62s] + cd simtrace2-0.8.0 [ 62s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.x86_64/usr/share/doc/packages/simtrace2 [ 62s] + export LC_ALL=C [ 62s] + LC_ALL=C [ 62s] + export DOCDIR [ 62s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.x86_64/usr/share/doc/packages/simtrace2 [ 62s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.x86_64/usr/share/doc/packages/simtrace2 [ 62s] + exit 0 [ 62s] Provides: simtrace2 = 0.8.0-lp151.1.1 simtrace2(x86-64) = 0.8.0-lp151.1.1 [ 62s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 62s] Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libpthread.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 62s] Processing files: simtrace2-debugsource-0.8.0-lp151.1.1.x86_64 [ 62s] Provides: simtrace2-debugsource = 0.8.0-lp151.1.1 simtrace2-debugsource(x86-64) = 0.8.0-lp151.1.1 [ 62s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 62s] Processing files: libosmo-simtrace2-0-0.8.0-lp151.1.1.x86_64 [ 62s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 62s] [ 62s] [ 62s] RPM build errors: [ 62s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 62s] ### VM INTERACTION START ### [ 65s] [ 55.325927] sysrq: SysRq : Power Off [ 65s] [ 55.328416] reboot: Power down [ 65s] ### VM INTERACTION END ### [ 65s] [ 65s] old-cirrus4 failed "build simtrace2.spec" at Fri Dec 10 01:00:22 UTC 2021. [ 65s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:01:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:01:06 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <61b2a6d66b3c4_72822b13744585f08821ac@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Tumbleweed/i586 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 116s] + cd simtrace2-0.8.0 [ 116s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/share/doc/packages/simtrace2 [ 116s] + export LC_ALL=C [ 116s] + LC_ALL=C [ 116s] + export DOCDIR [ 116s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/share/doc/packages/simtrace2 [ 116s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/share/doc/packages/simtrace2 [ 116s] + RPM_EC=0 [ 116s] ++ jobs -p [ 116s] + exit 0 [ 116s] Provides: simtrace2 = 0.8.0-1.1 simtrace2(x86-32) = 0.8.0-1.1 [ 116s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 116s] Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libosmo-simtrace2.so.1 libosmocore.so.18 libosmosim.so.2 libosmousb.so.0 libusb-1.0.so.0 [ 116s] Processing files: simtrace2-debugsource-0.8.0-1.1.i586 [ 116s] Provides: simtrace2-debugsource = 0.8.0-1.1 simtrace2-debugsource(x86-32) = 0.8.0-1.1 [ 116s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 116s] Processing files: libosmo-simtrace2-0-0.8.0-1.1.i586 [ 116s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/lib/libosmo-simtrace2.so.0* [ 116s] [ 116s] [ 116s] RPM build errors: [ 116s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/lib/libosmo-simtrace2.so.0* [ 116s] ### VM INTERACTION START ### [ 119s] [ 65.874637][ T391] sysrq: Power Off [ 119s] [ 65.895353][ T16] reboot: Power down [ 119s] ### VM INTERACTION END ### [ 119s] [ 119s] cloud109 failed "build simtrace2.spec" at Fri Dec 10 01:01:03 UTC 2021. [ 119s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:01:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:01:40 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61b2a70f88316_72822b13744585f08822c1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Factory_ARM/armv7l Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 113s] + cd simtrace2-0.8.0 [ 113s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.arm/usr/share/doc/packages/simtrace2 [ 113s] + export LC_ALL=C [ 113s] + LC_ALL=C [ 113s] + export DOCDIR [ 113s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.arm/usr/share/doc/packages/simtrace2 [ 113s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.arm/usr/share/doc/packages/simtrace2 [ 113s] + RPM_EC=0 [ 113s] ++ jobs -p [ 113s] + exit 0 [ 113s] Provides: simtrace2 = 0.8.0-1.1 simtrace2(armv7hl-32) = 0.8.0-1.1 [ 113s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 113s] Requires: ld-linux-armhf.so.3 ld-linux-armhf.so.3(GLIBC_2.4) libc.so.6 libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.5) libosmo-simtrace2.so.1 libosmocore.so.18 libosmosim.so.2 libosmousb.so.0 libusb-1.0.so.0 [ 113s] Processing files: simtrace2-debugsource-0.8.0-1.1.armv7hl [ 113s] Provides: simtrace2-debugsource = 0.8.0-1.1 simtrace2-debugsource(armv7hl-32) = 0.8.0-1.1 [ 113s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 113s] Processing files: libosmo-simtrace2-0-0.8.0-1.1.armv7hl [ 113s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.arm/usr/lib/libosmo-simtrace2.so.0* [ 113s] [ 113s] [ 113s] RPM build errors: [ 113s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.arm/usr/lib/libosmo-simtrace2.so.0* [ 113s] ### VM INTERACTION START ### [ 117s] [ 81.792625][ T384] sysrq: Power Off [ 117s] [ 81.793230][ T15] reboot: Power down [ 117s] ### VM INTERACTION END ### [ 117s] [ 117s] obs-arm-11 failed "build simtrace2.spec" at Fri Dec 10 01:01:32 UTC 2021. [ 117s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:01:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:01:57 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61b2a7103d51e_72822b13744585f08823c0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 101s] + umask 022 [ 101s] + cd /home/abuild/rpmbuild/BUILD [ 101s] + cd simtrace2-0.8.0 [ 101s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.arm/usr/share/doc/packages/simtrace2 [ 101s] + export LC_ALL=C [ 101s] + LC_ALL=C [ 101s] + export DOCDIR [ 101s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.arm/usr/share/doc/packages/simtrace2 [ 101s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.arm/usr/share/doc/packages/simtrace2 [ 101s] + exit 0 [ 101s] Provides: simtrace2 = 0.8.0-lp151.1.1 simtrace2(armv7hl-32) = 0.8.0-lp151.1.1 [ 101s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 101s] Requires: ld-linux-armhf.so.3 ld-linux-armhf.so.3(GLIBC_2.4) libc.so.6 libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.5) libosmo-simtrace2.so.1 libosmocore.so.18 libosmosim.so.2 libosmousb.so.0 libpthread.so.0 libusb-1.0.so.0 [ 101s] Processing files: simtrace2-debugsource-0.8.0-lp151.1.1.armv7hl [ 101s] Provides: simtrace2-debugsource = 0.8.0-lp151.1.1 simtrace2-debugsource(armv7hl-32) = 0.8.0-lp151.1.1 [ 101s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 101s] Processing files: libosmo-simtrace2-0-0.8.0-lp151.1.1.armv7hl [ 101s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.arm/usr/lib/libosmo-simtrace2.so.0* [ 101s] [ 101s] [ 101s] RPM build errors: [ 101s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.arm/usr/lib/libosmo-simtrace2.so.0* [ 101s] ### VM INTERACTION START ### [ 105s] [ 90.769738] sysrq: SysRq : Power Off [ 105s] [ 90.771193] reboot: Power down [ 105s] ### VM INTERACTION END ### [ 105s] [ 105s] armbuild22 failed "build simtrace2.spec" at Fri Dec 10 01:01:42 UTC 2021. [ 105s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:02:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:02:48 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61b2a74a95b08_72822b13744585f0882615@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Factory_ARM/aarch64 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 144s] + cd simtrace2-0.8.0 [ 144s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.aarch64/usr/share/doc/packages/simtrace2 [ 144s] + export LC_ALL=C [ 144s] + LC_ALL=C [ 144s] + export DOCDIR [ 144s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.aarch64/usr/share/doc/packages/simtrace2 [ 144s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.aarch64/usr/share/doc/packages/simtrace2 [ 144s] + RPM_EC=0 [ 144s] ++ jobs -p [ 144s] + exit 0 [ 144s] Provides: simtrace2 = 0.8.0-1.1 simtrace2(aarch-64) = 0.8.0-1.1 [ 144s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 144s] Requires: ld-linux-aarch64.so.1()(64bit) ld-linux-aarch64.so.1(GLIBC_2.17)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.17)(64bit) libc.so.6(GLIBC_2.34)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 144s] Processing files: simtrace2-debugsource-0.8.0-1.1.aarch64 [ 144s] Provides: simtrace2-debugsource = 0.8.0-1.1 simtrace2-debugsource(aarch-64) = 0.8.0-1.1 [ 144s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 144s] Processing files: libosmo-simtrace2-0-0.8.0-1.1.aarch64 [ 144s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.aarch64/usr/lib64/libosmo-simtrace2.so.0* [ 144s] [ 144s] [ 144s] RPM build errors: [ 144s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.aarch64/usr/lib64/libosmo-simtrace2.so.0* [ 144s] ### VM INTERACTION START ### [ 148s] [ 91.736314][ T383] sysrq: Power Off [ 148s] [ 91.736855][ T15] reboot: Power down [ 148s] ### VM INTERACTION END ### [ 148s] [ 148s] obs-arm-10 failed "build simtrace2.spec" at Fri Dec 10 01:02:47 UTC 2021. [ 148s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:03:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:03:06 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61b2a76938630_72822b13744585f0882752@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/CentOS_8/x86_64 Package network:osmocom:latest/simtrace2 failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 181s] + umask 022 [ 181s] + cd /home/abuild/rpmbuild/BUILD [ 181s] + cd simtrace2-0.8.0 [ 181s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/share/doc/simtrace2 [ 181s] + export LC_ALL=C [ 181s] + LC_ALL=C [ 181s] + export DOCDIR [ 181s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/share/doc/simtrace2 [ 181s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/share/doc/simtrace2 [ 181s] + exit 0 [ 181s] Provides: simtrace2 = 0.8.0-1.1 simtrace2(x86-64) = 0.8.0-1.1 [ 181s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 181s] Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libpthread.so.0()(64bit) libtalloc.so.2()(64bit) libusb-1.0.so.0()(64bit) rtld(GNU_HASH) [ 181s] Processing files: simtrace2-debugsource-0.8.0-1.1.x86_64 [ 181s] Provides: simtrace2-debugsource = 0.8.0-1.1 simtrace2-debugsource(x86-64) = 0.8.0-1.1 [ 181s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 181s] Processing files: libosmo-simtrace2-0-0.8.0-1.1.x86_64 [ 181s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 181s] [ 181s] [ 181s] RPM build errors: [ 181s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 181s] ### VM INTERACTION START ### [ 183s] Powering off. [ 183s] [ 142.943624] reboot: Power down [ 183s] ### VM INTERACTION END ### [ 183s] [ 183s] lamb25 failed "build simtrace2.spec" at Fri Dec 10 01:03:05 UTC 2021. [ 183s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:03:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:03:23 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61b2a76a4e32a_72822b13744585f08828f1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 168s] + umask 022 [ 168s] + cd /home/abuild/rpmbuild/BUILD [ 168s] + cd simtrace2-0.8.0 [ 168s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.aarch64/usr/share/doc/packages/simtrace2 [ 168s] + export LC_ALL=C [ 168s] + LC_ALL=C [ 168s] + export DOCDIR [ 168s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.aarch64/usr/share/doc/packages/simtrace2 [ 168s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.aarch64/usr/share/doc/packages/simtrace2 [ 168s] + exit 0 [ 168s] Provides: simtrace2 = 0.8.0-lp151.1.1 simtrace2(aarch-64) = 0.8.0-lp151.1.1 [ 168s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 168s] Requires: ld-linux-aarch64.so.1()(64bit) ld-linux-aarch64.so.1(GLIBC_2.17)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.17)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libpthread.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 168s] Processing files: simtrace2-debugsource-0.8.0-lp151.1.1.aarch64 [ 169s] Provides: simtrace2-debugsource = 0.8.0-lp151.1.1 simtrace2-debugsource(aarch-64) = 0.8.0-lp151.1.1 [ 169s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 169s] Processing files: libosmo-simtrace2-0-0.8.0-lp151.1.1.aarch64 [ 169s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.aarch64/usr/lib64/libosmo-simtrace2.so.0* [ 169s] [ 169s] [ 169s] RPM build errors: [ 169s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-lp151.1.1.aarch64/usr/lib64/libosmo-simtrace2.so.0* [ 169s] ### VM INTERACTION START ### [ 172s] [ 140.431397] sysrq: SysRq : Power Off [ 172s] [ 140.441752] reboot: Power down [ 172s] ### VM INTERACTION END ### [ 172s] [ 172s] obs-arm-2 failed "build simtrace2.spec" at Fri Dec 10 01:03:09 UTC 2021. [ 172s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:25:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:25:06 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61b2ac7677332_72822b13744585f0887523@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 117s] + umask 022 [ 117s] + cd /home/abuild/rpmbuild/BUILD [ 117s] + cd simtrace2-0.8.0.202112100026 [ 117s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.aarch64/usr/share/doc/packages/simtrace2 [ 117s] + export LC_ALL=C [ 117s] + LC_ALL=C [ 117s] + export DOCDIR [ 117s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.aarch64/usr/share/doc/packages/simtrace2 [ 117s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.aarch64/usr/share/doc/packages/simtrace2 [ 117s] + exit 0 [ 117s] Provides: simtrace2 = 0.8.0.202112100026-lp151.1.1 simtrace2(aarch-64) = 0.8.0.202112100026-lp151.1.1 [ 117s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 117s] Requires: ld-linux-aarch64.so.1()(64bit) ld-linux-aarch64.so.1(GLIBC_2.17)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.17)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libpthread.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 117s] Processing files: simtrace2-debugsource-0.8.0.202112100026-lp151.1.1.aarch64 [ 117s] Provides: simtrace2-debugsource = 0.8.0.202112100026-lp151.1.1 simtrace2-debugsource(aarch-64) = 0.8.0.202112100026-lp151.1.1 [ 117s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 117s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-lp151.1.1.aarch64 [ 117s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.aarch64/usr/lib64/libosmo-simtrace2.so.0* [ 117s] [ 117s] [ 117s] RPM build errors: [ 117s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.aarch64/usr/lib64/libosmo-simtrace2.so.0* [ 117s] ### VM INTERACTION START ### [ 120s] [ 101.873725] sysrq: SysRq : Power Off [ 120s] [ 101.918295] reboot: Power down [ 121s] ### VM INTERACTION END ### [ 121s] [ 121s] armbuild22 failed "build simtrace2.spec" at Fri Dec 10 01:25:02 UTC 2021. [ 121s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:27:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:27:23 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61b2ad09d358f_72822b13744585f08881da@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 91s] + cd simtrace2-0.8.0.202112100026 [ 91s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.arm/usr/share/doc/packages/simtrace2 [ 91s] + export LC_ALL=C [ 91s] + LC_ALL=C [ 91s] + export DOCDIR [ 91s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.arm/usr/share/doc/packages/simtrace2 [ 91s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.arm/usr/share/doc/packages/simtrace2 [ 91s] + RPM_EC=0 [ 91s] ++ jobs -p [ 91s] + exit 0 [ 91s] Provides: simtrace2 = 0.8.0.202112100026-1.1 simtrace2(armv7hl-32) = 0.8.0.202112100026-1.1 [ 91s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 91s] Requires: ld-linux-armhf.so.3 ld-linux-armhf.so.3(GLIBC_2.4) libc.so.6 libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.5) libosmo-simtrace2.so.1 libosmocore.so.18 libosmosim.so.2 libosmousb.so.0 libusb-1.0.so.0 [ 91s] Processing files: simtrace2-debugsource-0.8.0.202112100026-1.1.armv7hl [ 91s] Provides: simtrace2-debugsource = 0.8.0.202112100026-1.1 simtrace2-debugsource(armv7hl-32) = 0.8.0.202112100026-1.1 [ 91s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 91s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-1.1.armv7hl [ 91s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.arm/usr/lib/libosmo-simtrace2.so.0* [ 91s] [ 91s] [ 91s] RPM build errors: [ 91s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.arm/usr/lib/libosmo-simtrace2.so.0* [ 92s] ### VM INTERACTION START ### [ 95s] [ 59.642828][ T384] sysrq: Power Off [ 95s] [ 59.643379][ T15] reboot: Power down [ 95s] ### VM INTERACTION END ### [ 95s] [ 95s] obs-arm-11 failed "build simtrace2.spec" at Fri Dec 10 01:27:06 UTC 2021. [ 95s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:31:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:31:06 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61b2adde6b44c_72822b13744585f089093@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 151s] + umask 022 [ 151s] + cd /home/abuild/rpmbuild/BUILD [ 151s] + cd simtrace2-0.8.0.202112100026 [ 151s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.arm/usr/share/doc/packages/simtrace2 [ 151s] + export LC_ALL=C [ 151s] + LC_ALL=C [ 151s] + export DOCDIR [ 151s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.arm/usr/share/doc/packages/simtrace2 [ 151s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.arm/usr/share/doc/packages/simtrace2 [ 151s] + exit 0 [ 151s] Provides: simtrace2 = 0.8.0.202112100026-lp151.1.1 simtrace2(armv7hl-32) = 0.8.0.202112100026-lp151.1.1 [ 151s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 151s] Requires: ld-linux-armhf.so.3 ld-linux-armhf.so.3(GLIBC_2.4) libc.so.6 libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.5) libosmo-simtrace2.so.1 libosmocore.so.18 libosmosim.so.2 libosmousb.so.0 libpthread.so.0 libusb-1.0.so.0 [ 151s] Processing files: simtrace2-debugsource-0.8.0.202112100026-lp151.1.1.armv7hl [ 151s] Provides: simtrace2-debugsource = 0.8.0.202112100026-lp151.1.1 simtrace2-debugsource(armv7hl-32) = 0.8.0.202112100026-lp151.1.1 [ 151s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 151s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-lp151.1.1.armv7hl [ 151s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.arm/usr/lib/libosmo-simtrace2.so.0* [ 151s] [ 151s] [ 151s] RPM build errors: [ 151s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-lp151.1.1.arm/usr/lib/libosmo-simtrace2.so.0* [ 151s] ### VM INTERACTION START ### [ 154s] [ 129.151438] sysrq: SysRq : Power Off [ 154s] [ 129.176472] reboot: Power down [ 155s] ### VM INTERACTION END ### [ 155s] [ 155s] obs-arm-5 failed "build simtrace2.spec" at Fri Dec 10 01:30:52 UTC 2021. [ 155s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:37:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:37:06 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61b2af44db447_72822b13744585f089140@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/CentOS_8/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 77s] + umask 022 [ 77s] + cd /home/abuild/rpmbuild/BUILD [ 77s] + cd simtrace2-0.8.0.202112100026 [ 77s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.aarch64/usr/share/doc/simtrace2 [ 77s] + export LC_ALL=C [ 77s] + LC_ALL=C [ 77s] + export DOCDIR [ 77s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.aarch64/usr/share/doc/simtrace2 [ 77s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.aarch64/usr/share/doc/simtrace2 [ 77s] + exit 0 [ 77s] Provides: simtrace2 = 0.8.0.202112100026-1.1 simtrace2(aarch-64) = 0.8.0.202112100026-1.1 [ 77s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 77s] Requires: ld-linux-aarch64.so.1()(64bit) ld-linux-aarch64.so.1(GLIBC_2.17)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.17)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libpthread.so.0()(64bit) libtalloc.so.2()(64bit) libusb-1.0.so.0()(64bit) rtld(GNU_HASH) [ 77s] Processing files: simtrace2-debugsource-0.8.0.202112100026-1.1.aarch64 [ 77s] Provides: simtrace2-debugsource = 0.8.0.202112100026-1.1 simtrace2-debugsource(aarch-64) = 0.8.0.202112100026-1.1 [ 77s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 77s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-1.1.aarch64 [ 77s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.aarch64/usr/lib64/libosmo-simtrace2.so.0* [ 77s] [ 77s] [ 77s] RPM build errors: [ 77s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.aarch64/usr/lib64/libosmo-simtrace2.so.0* [ 77s] ### VM INTERACTION START ### [ 79s] Powering off. [ 79s] [ 57.680700] reboot: Power down [ 79s] ### VM INTERACTION END ### [ 79s] [ 79s] obs-arm-10 failed "build simtrace2.spec" at Fri Dec 10 01:36:48 UTC 2021. [ 79s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 01:46:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 01:46:14 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61b2b17fcb7c1_72822b13744585f0892783@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 287s] + cd simtrace2-0.8.0.202112100026 [ 287s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.aarch64/usr/share/doc/packages/simtrace2 [ 287s] + export LC_ALL=C [ 287s] + LC_ALL=C [ 287s] + export DOCDIR [ 287s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.aarch64/usr/share/doc/packages/simtrace2 [ 287s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.aarch64/usr/share/doc/packages/simtrace2 [ 287s] + RPM_EC=0 [ 287s] ++ jobs -p [ 287s] + exit 0 [ 288s] Provides: simtrace2 = 0.8.0.202112100026-1.1 simtrace2(aarch-64) = 0.8.0.202112100026-1.1 [ 288s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 288s] Requires: ld-linux-aarch64.so.1()(64bit) ld-linux-aarch64.so.1(GLIBC_2.17)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.17)(64bit) libc.so.6(GLIBC_2.34)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 288s] Processing files: simtrace2-debugsource-0.8.0.202112100026-1.1.aarch64 [ 288s] Provides: simtrace2-debugsource = 0.8.0.202112100026-1.1 simtrace2-debugsource(aarch-64) = 0.8.0.202112100026-1.1 [ 288s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 288s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-1.1.aarch64 [ 288s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.aarch64/usr/lib64/libosmo-simtrace2.so.0* [ 288s] [ 288s] [ 288s] RPM build errors: [ 288s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.aarch64/usr/lib64/libosmo-simtrace2.so.0* [ 288s] ### VM INTERACTION START ### [ 292s] [ 236.547888][ T385] sysrq: Power Off [ 292s] [ 236.561036][ T15] reboot: Power down [ 292s] ### VM INTERACTION END ### [ 292s] [ 292s] obs-arm-3 failed "build simtrace2.spec" at Fri Dec 10 01:46:06 UTC 2021. [ 292s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Dec 10 06:32:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 06:32:36 +0000 Subject: Change in libosmo-netif[master]: stream: Add support for AF_UNIX sockets In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26434 ) Change subject: stream: Add support for AF_UNIX sockets ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 Gerrit-Change-Number: 26434 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Arran Cudbard-bell Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 06:32:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 06:33:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 06:33:43 +0000 Subject: Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26426 ) Change subject: Introduce osmo_prim_srv APIs ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 Gerrit-Change-Number: 26426 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 06:33:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 06:34:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 06:34:17 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26435 ) Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 06:34:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 06:34:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 06:34:41 +0000 Subject: Change in osmo-dev[master]: Add tmux scripts for ttcn3-{msc, bsc, bts}-test In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26485 ) Change subject: Add tmux scripts for ttcn3-{msc,bsc,bts}-test ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 Gerrit-Change-Number: 26485 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 06:34:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:07:35 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:07:35 +0000 Subject: Change in simtrace2[master]: host/contrib/simtrace2.spec.in: fix soname References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26487 ) Change subject: host/contrib/simtrace2.spec.in: fix soname ...................................................................... host/contrib/simtrace2.spec.in: fix soname Adjust the soname in the rpm recipe too, to fix: error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* Change-Id: I748f44409ac736abbd5c18e31ae02d025dee2c77 --- M host/contrib/simtrace2.spec.in 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/87/26487/1 diff --git a/host/contrib/simtrace2.spec.in b/host/contrib/simtrace2.spec.in index ca62ad5..1c47f5e 100644 --- a/host/contrib/simtrace2.spec.in +++ b/host/contrib/simtrace2.spec.in @@ -38,11 +38,11 @@ This package contains SIMtrace 2 host utility. -%package -n libosmo-simtrace2-0 +%package -n libosmo-simtrace2-1 Summary: Shared Library part of libosmo-simtrace2 Group: System/Libraries -%description -n libosmo-simtrace2-0 +%description -n libosmo-simtrace2-1 This library contains core "driver" functionality to interface with the Osmocom SIMtrace2 (and compatible) USB device firmware. It enables applications to implement SIM card / smart card tracing as well as @@ -51,7 +51,7 @@ %package -n libosmo-simtrace2-devel Summary: Development files for the Osmocom SIMtrace2 library Group: Development/Libraries/C and C++ -Requires: libosmo-simtrace2-0 = %{version} +Requires: libosmo-simtrace2-1 = %{version} %description -n libosmo-simtrace2-devel Osmocom SIMtrace2 (and compatible) USB device firmware. It enables @@ -76,8 +76,8 @@ install -Dm0644 host/contrib/99-simtrace2.rules %{buildroot}/%{_udevrulesdir}/99-simtrace2.rules find %{buildroot} -type f -name "*.la" -delete -print -%post -n libosmo-simtrace2-0 -p /sbin/ldconfig -%postun -n libosmo-simtrace2-0 -p /sbin/ldconfig +%post -n libosmo-simtrace2-1 -p /sbin/ldconfig +%postun -n libosmo-simtrace2-1 -p /sbin/ldconfig %files %doc README.md @@ -87,8 +87,8 @@ %{_bindir}/simtrace2-tool %{_udevrulesdir}/99-simtrace2.rules -%files -n libosmo-simtrace2-0 -%{_libdir}/libosmo-simtrace2.so.0* +%files -n libosmo-simtrace2-1 +%{_libdir}/libosmo-simtrace2.so.1* %files -n libosmo-simtrace2-devel %dir %{_includedir}/osmocom/ -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I748f44409ac736abbd5c18e31ae02d025dee2c77 Gerrit-Change-Number: 26487 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:07:36 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:07:36 +0000 Subject: =?UTF-8?Q?Change_in_simtrace2=5Bmaster=5D=3A_Bump_version=3A_0=2E8=2E0=2E1-8281_=E2=86=92_0=2E8=2E1?= References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26488 ) Change subject: Bump version: 0.8.0.1-8281 ? 0.8.1 ...................................................................... Bump version: 0.8.0.1-8281 ? 0.8.1 Change-Id: I6bcc798db9f4ab2b91711daebeba98abebd55e92 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/88/26488/1 diff --git a/debian/changelog b/debian/changelog index 38fdd6b..99cfb8b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +simtrace2 (0.8.1) unstable; urgency=medium + + * host/contrib/simtrace2.spec.in: fix soname + + -- Oliver Smith Fri, 10 Dec 2021 10:04:28 +0100 + simtrace2 (0.8.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I6bcc798db9f4ab2b91711daebeba98abebd55e92 Gerrit-Change-Number: 26488 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:11:06 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:11:06 +0000 Subject: Change in simtrace2[master]: host/contrib/simtrace2.spec.in: fix soname In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26487 ) Change subject: host/contrib/simtrace2.spec.in: fix soname ...................................................................... Patch Set 1: verified that it builds: https://build.opensuse.org/package/live_build_log/home:osmith42/simtrace2/CentOS_8/x86_64 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I748f44409ac736abbd5c18e31ae02d025dee2c77 Gerrit-Change-Number: 26487 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 10 Dec 2021 09:11:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:13:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 09:13:54 +0000 Subject: Change in simtrace2[master]: host/contrib/simtrace2.spec.in: fix soname In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26487 ) Change subject: host/contrib/simtrace2.spec.in: fix soname ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I748f44409ac736abbd5c18e31ae02d025dee2c77 Gerrit-Change-Number: 26487 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 09:13:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:13:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 09:13:56 +0000 Subject: =?UTF-8?Q?Change_in_simtrace2=5Bmaster=5D=3A_Bump_version=3A_0=2E8=2E0=2E1-8281_=E2=86=92_0=2E8=2E1?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26488 ) Change subject: Bump version: 0.8.0.1-8281 ? 0.8.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I6bcc798db9f4ab2b91711daebeba98abebd55e92 Gerrit-Change-Number: 26488 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 09:13:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:13:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 09:13:59 +0000 Subject: Change in simtrace2[master]: host/contrib/simtrace2.spec.in: fix soname In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26487 ) Change subject: host/contrib/simtrace2.spec.in: fix soname ...................................................................... host/contrib/simtrace2.spec.in: fix soname Adjust the soname in the rpm recipe too, to fix: error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* Change-Id: I748f44409ac736abbd5c18e31ae02d025dee2c77 --- M host/contrib/simtrace2.spec.in 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/host/contrib/simtrace2.spec.in b/host/contrib/simtrace2.spec.in index ca62ad5..1c47f5e 100644 --- a/host/contrib/simtrace2.spec.in +++ b/host/contrib/simtrace2.spec.in @@ -38,11 +38,11 @@ This package contains SIMtrace 2 host utility. -%package -n libosmo-simtrace2-0 +%package -n libosmo-simtrace2-1 Summary: Shared Library part of libosmo-simtrace2 Group: System/Libraries -%description -n libosmo-simtrace2-0 +%description -n libosmo-simtrace2-1 This library contains core "driver" functionality to interface with the Osmocom SIMtrace2 (and compatible) USB device firmware. It enables applications to implement SIM card / smart card tracing as well as @@ -51,7 +51,7 @@ %package -n libosmo-simtrace2-devel Summary: Development files for the Osmocom SIMtrace2 library Group: Development/Libraries/C and C++ -Requires: libosmo-simtrace2-0 = %{version} +Requires: libosmo-simtrace2-1 = %{version} %description -n libosmo-simtrace2-devel Osmocom SIMtrace2 (and compatible) USB device firmware. It enables @@ -76,8 +76,8 @@ install -Dm0644 host/contrib/99-simtrace2.rules %{buildroot}/%{_udevrulesdir}/99-simtrace2.rules find %{buildroot} -type f -name "*.la" -delete -print -%post -n libosmo-simtrace2-0 -p /sbin/ldconfig -%postun -n libosmo-simtrace2-0 -p /sbin/ldconfig +%post -n libosmo-simtrace2-1 -p /sbin/ldconfig +%postun -n libosmo-simtrace2-1 -p /sbin/ldconfig %files %doc README.md @@ -87,8 +87,8 @@ %{_bindir}/simtrace2-tool %{_udevrulesdir}/99-simtrace2.rules -%files -n libosmo-simtrace2-0 -%{_libdir}/libosmo-simtrace2.so.0* +%files -n libosmo-simtrace2-1 +%{_libdir}/libosmo-simtrace2.so.1* %files -n libosmo-simtrace2-devel %dir %{_includedir}/osmocom/ -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I748f44409ac736abbd5c18e31ae02d025dee2c77 Gerrit-Change-Number: 26487 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:13:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 09:13:59 +0000 Subject: =?UTF-8?Q?Change_in_simtrace2=5Bmaster=5D=3A_Bump_version=3A_0=2E8=2E0=2E1-8281_=E2=86=92_0=2E8=2E1?= In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26488 ) Change subject: Bump version: 0.8.0.1-8281 ? 0.8.1 ...................................................................... Bump version: 0.8.0.1-8281 ? 0.8.1 Change-Id: I6bcc798db9f4ab2b91711daebeba98abebd55e92 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 38fdd6b..99cfb8b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +simtrace2 (0.8.1) unstable; urgency=medium + + * host/contrib/simtrace2.spec.in: fix soname + + -- Oliver Smith Fri, 10 Dec 2021 10:04:28 +0100 + simtrace2 (0.8.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I6bcc798db9f4ab2b91711daebeba98abebd55e92 Gerrit-Change-Number: 26488 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:15:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 09:15:01 +0000 Subject: Change in libosmo-netif[master]: stream: Add support for AF_UNIX sockets In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26434 ) Change subject: stream: Add support for AF_UNIX sockets ...................................................................... stream: Add support for AF_UNIX sockets Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 --- M include/osmocom/netif/stream.h M src/stream.c 2 files changed, 254 insertions(+), 72 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index 331dec1..b82dff1 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -25,6 +25,8 @@ int osmo_stream_srv_link_set_addrs(struct osmo_stream_srv_link *link, const char **addr, size_t addrcnt); void osmo_stream_srv_link_set_port(struct osmo_stream_srv_link *link, uint16_t port); void osmo_stream_srv_link_set_proto(struct osmo_stream_srv_link *link, uint16_t proto); +int osmo_stream_srv_link_set_type(struct osmo_stream_srv_link *link, int type); +int osmo_stream_srv_link_set_domain(struct osmo_stream_srv_link *link, int domain); void osmo_stream_srv_link_set_accept_cb(struct osmo_stream_srv_link *link, int (*accept_cb)(struct osmo_stream_srv_link *link, int fd)); void osmo_stream_srv_link_set_data(struct osmo_stream_srv_link *link, void *data); void *osmo_stream_srv_link_get_data(struct osmo_stream_srv_link *link); @@ -57,6 +59,8 @@ void osmo_stream_cli_set_addr(struct osmo_stream_cli *cli, const char *addr); int osmo_stream_cli_set_addrs(struct osmo_stream_cli *cli, const char **addr, size_t addrcnt); void osmo_stream_cli_set_port(struct osmo_stream_cli *cli, uint16_t port); +int osmo_stream_cli_set_type(struct osmo_stream_cli *cli, int type); +int osmo_stream_cli_set_domain(struct osmo_stream_cli *cli, int domain); void osmo_stream_cli_set_proto(struct osmo_stream_cli *cli, uint16_t proto); void osmo_stream_cli_set_local_addr(struct osmo_stream_cli *cli, const char *addr); int osmo_stream_cli_set_local_addrs(struct osmo_stream_cli *cli, const char **addr, size_t addrcnt); diff --git a/src/stream.c b/src/stream.c index 309aafe..4379212 100644 --- a/src/stream.c +++ b/src/stream.c @@ -256,6 +256,8 @@ char *local_addr[OSMO_STREAM_MAX_ADDRS]; uint8_t local_addrcnt; uint16_t local_port; + int sk_domain; + int sk_type; uint16_t proto; int (*connect_cb)(struct osmo_stream_cli *srv); int (*disconnect_cb)(struct osmo_stream_cli *srv); @@ -349,20 +351,31 @@ LOGSCLI(cli, LOGL_DEBUG, "sending %u bytes of data\n", msgb_length(msg)); - switch (cli->proto) { + switch (cli->sk_domain) { + case AF_UNIX: + ret = send(cli->ofd.fd, msg->data, msg->len, 0); + break; + case AF_UNSPEC: + case AF_INET: + case AF_INET6: + switch (cli->proto) { #ifdef HAVE_LIBSCTP - case IPPROTO_SCTP: - memset(&sinfo, 0, sizeof(sinfo)); - sinfo.sinfo_ppid = htonl(msgb_sctp_ppid(msg)); - sinfo.sinfo_stream = msgb_sctp_stream(msg); - ret = sctp_send(cli->ofd.fd, msg->data, msgb_length(msg), - &sinfo, MSG_NOSIGNAL); - break; + case IPPROTO_SCTP: + memset(&sinfo, 0, sizeof(sinfo)); + sinfo.sinfo_ppid = htonl(msgb_sctp_ppid(msg)); + sinfo.sinfo_stream = msgb_sctp_stream(msg); + ret = sctp_send(cli->ofd.fd, msg->data, msgb_length(msg), + &sinfo, MSG_NOSIGNAL); + break; #endif - case IPPROTO_TCP: - default: - ret = send(cli->ofd.fd, msg->data, msgb_length(msg), 0); + case IPPROTO_TCP: + default: + ret = send(cli->ofd.fd, msg->data, msgb_length(msg), 0); + break; + } break; + default: + ret = -ENOTSUP; } if (ret < 0) { if (errno == EPIPE || errno == ENOTCONN) { @@ -374,6 +387,20 @@ return 0; } +static int _setsockopt_nosigpipe(struct osmo_stream_cli *cli) +{ +#ifdef SO_NOSIGPIPE + int ret; + int val = 1; + ret = setsockopt(cli->ofd.fd, SOL_SOCKET, SO_NOSIGPIPE, (void *)&val, sizeof(val)); + if (ret < 0) + LOGSCLI(cli, LOGL_DEBUG, "Failed setting SO_NOSIGPIPE: %s\n", strerror(errno)); + return ret; +#else + return 0; +#endif +} + static int osmo_stream_cli_fd_cb(struct osmo_fd *ofd, unsigned int what) { struct osmo_stream_cli *cli = ofd->data; @@ -395,15 +422,20 @@ LOGSCLI(cli, LOGL_DEBUG, "connection done.\n"); cli->state = STREAM_CLI_STATE_CONNECTED; - if (cli->proto == IPPROTO_SCTP) { -#ifdef SO_NOSIGPIPE - int val = 1; - - ret = setsockopt(ofd->fd, SOL_SOCKET, SO_NOSIGPIPE, (void*)&val, sizeof(val)); - if (ret < 0) - LOGSCLI(cli, LOGL_DEBUG, "Failed setting SO_NOSIGPIPE: %s\n", strerror(errno)); -#endif - sctp_sock_activate_events(ofd->fd); + switch (cli->sk_domain) { + case AF_UNIX: + _setsockopt_nosigpipe(cli); + break; + case AF_UNSPEC: + case AF_INET: + case AF_INET6: + if (cli->proto == IPPROTO_SCTP) { + _setsockopt_nosigpipe(cli); + sctp_sock_activate_events(ofd->fd); + } + break; + default: + break; } if (cli->connect_cb) cli->connect_cb(cli); @@ -441,6 +473,8 @@ if (!cli) return NULL; + cli->sk_domain = AF_UNSPEC; + cli->sk_type = SOCK_STREAM; cli->proto = IPPROTO_TCP; cli->ofd.fd = -1; cli->ofd.priv_nr = 0; /* XXX */ @@ -557,6 +591,46 @@ cli->flags |= OSMO_STREAM_CLI_F_RECONF; } +/*! \brief Set the socket type for the stream server link + * \param[in] cli Stream Client to modify + * \param[in] type Socket Type (like SOCK_STREAM (default), SOCK_SEQPACKET, ...) + * \returns zero on success, negative on error. + */ +int osmo_stream_cli_set_type(struct osmo_stream_cli *cli, int type) +{ + switch (type) { + case SOCK_STREAM: + case SOCK_SEQPACKET: + break; + default: + return -ENOTSUP; + } + cli->sk_type = type; + cli->flags |= OSMO_STREAM_CLI_F_RECONF; + return 0; +} + +/*! \brief Set the socket type for the stream server link + * \param[in] cli Stream Client to modify + * \param[in] type Socket Domain (like AF_UNSPEC (default for IP), AF_UNIX, AF_INET, ...) + * \returns zero on success, negative on error. + */ +int osmo_stream_cli_set_domain(struct osmo_stream_cli *cli, int domain) +{ + switch (domain) { + case AF_UNSPEC: + case AF_INET: + case AF_INET6: + case AF_UNIX: + break; + default: + return -ENOTSUP; + } + cli->sk_domain = domain; + cli->flags |= OSMO_STREAM_CLI_F_RECONF; + return 0; +} + /*! \brief Set the reconnect time of the stream client socket * \param[in] cli Stream Client to modify * \param[in] timeout Re-connect timeout in seconds or negative value to disable auto-reconnection */ @@ -731,21 +805,31 @@ cli->flags &= ~OSMO_STREAM_CLI_F_RECONF; - - switch (cli->proto) { -#ifdef HAVE_LIBSCTP - case IPPROTO_SCTP: - ret = osmo_sock_init2_multiaddr(AF_UNSPEC, SOCK_STREAM, cli->proto, - (const char **)cli->local_addr, cli->local_addrcnt, cli->local_port, - (const char **)cli->addr, cli->addrcnt, cli->port, - OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_BIND|OSMO_SOCK_F_NONBLOCK); + switch (cli->sk_domain) { + case AF_UNIX: + ret = osmo_sock_unix_init(cli->sk_type, 0, cli->addr[0], OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_BIND|OSMO_SOCK_F_NONBLOCK); break; + case AF_INET: + case AF_INET6: + case AF_UNSPEC: + switch (cli->proto) { +#ifdef HAVE_LIBSCTP + case IPPROTO_SCTP: + ret = osmo_sock_init2_multiaddr(cli->sk_domain, cli->sk_type, cli->proto, + (const char **)cli->local_addr, cli->local_addrcnt, cli->local_port, + (const char **)cli->addr, cli->addrcnt, cli->port, + OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_BIND|OSMO_SOCK_F_NONBLOCK); + break; #endif + default: + ret = osmo_sock_init2(cli->sk_domain, cli->sk_type, cli->proto, + cli->local_addr[0], cli->local_port, + cli->addr[0], cli->port, + OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_BIND|OSMO_SOCK_F_NONBLOCK); + } + break; default: - ret = osmo_sock_init2(AF_UNSPEC, SOCK_STREAM, cli->proto, - cli->local_addr[0], cli->local_port, - cli->addr[0], cli->port, - OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_BIND|OSMO_SOCK_F_NONBLOCK); + return -ENOTSUP; } if (ret < 0) { @@ -827,6 +911,8 @@ char *addr[OSMO_STREAM_MAX_ADDRS]; uint8_t addrcnt; uint16_t port; + int sk_domain; + int sk_type; uint16_t proto; int (*accept_cb)(struct osmo_stream_srv_link *srv, int fd); void *data; @@ -838,7 +924,7 @@ int ret; int sock_fd; char addrstr[128]; - bool is_ipv6; + bool is_ipv6 = false; struct sockaddr_storage sa; socklen_t sa_len = sizeof(sa); struct osmo_stream_srv_link *link = ofd->data; @@ -849,19 +935,35 @@ "peer, reason=`%s'\n", strerror(errno)); return ret; } - is_ipv6 = ((struct sockaddr *)&sa)->sa_family == AF_INET6; - LOGP(DLINP, LOGL_DEBUG, "accept()ed new link from %s to port %u\n", - inet_ntop(is_ipv6 ? AF_INET6 : AF_INET, - is_ipv6 ? (void*)&(((struct sockaddr_in6 *)&sa)->sin6_addr) : - (void*)&(((struct sockaddr_in *)&sa)->sin_addr), - addrstr, sizeof(addrstr)), - link->port); sock_fd = ret; - if (link->proto == IPPROTO_SCTP) { - ret = sctp_sock_activate_events(sock_fd); - if (ret < 0) - goto error_close_socket; + is_ipv6 = false; + switch (((struct sockaddr *)&sa)->sa_family) { + case AF_UNIX: + LOGP(DLINP, LOGL_DEBUG, "accept()ed new link on fd %d\n", + sock_fd); + break; + case AF_INET6: + is_ipv6 = true; + /* fall through */ + case AF_INET: + LOGP(DLINP, LOGL_DEBUG, "accept()ed new link from %s to port %u\n", + inet_ntop(is_ipv6 ? AF_INET6 : AF_INET, + is_ipv6 ? (void *)&(((struct sockaddr_in6 *)&sa)->sin6_addr) : + (void *)&(((struct sockaddr_in *)&sa)->sin_addr), + addrstr, sizeof(addrstr)), + link->port); + + if (link->proto == IPPROTO_SCTP) { + ret = sctp_sock_activate_events(sock_fd); + if (ret < 0) + goto error_close_socket; + } + break; + default: + LOGP(DLINP, LOGL_DEBUG, "accept()ed unexpected address family %d\n", + ((struct sockaddr *)&sa)->sa_family); + goto error_close_socket; } if (link->flags & OSMO_STREAM_SRV_F_NODELAY) { @@ -899,6 +1001,8 @@ if (!link) return NULL; + link->sk_domain = AF_UNSPEC; + link->sk_type = SOCK_STREAM; link->proto = IPPROTO_TCP; osmo_fd_setup(&link->ofd, -1, OSMO_FD_READ | OSMO_FD_WRITE, osmo_stream_srv_fd_cb, link, 0); @@ -978,6 +1082,47 @@ link->flags |= OSMO_STREAM_SRV_F_RECONF; } + +/*! \brief Set the socket type for the stream server link + * \param[in] link Stream Server Link to modify + * \param[in] type Socket Type (like SOCK_STREAM (default), SOCK_SEQPACKET, ...) + * \returns zero on success, negative on error. + */ +int osmo_stream_srv_link_set_type(struct osmo_stream_srv_link *link, int type) +{ + switch (type) { + case SOCK_STREAM: + case SOCK_SEQPACKET: + break; + default: + return -ENOTSUP; + } + link->sk_type = type; + link->flags |= OSMO_STREAM_SRV_F_RECONF; + return 0; +} + +/*! \brief Set the socket type for the stream server link + * \param[in] link Stream Server Link to modify + * \param[in] type Socket Domain (like AF_UNSPEC (default for IP), AF_UNIX, AF_INET, ...) + * \returns zero on success, negative on error. + */ +int osmo_stream_srv_link_set_domain(struct osmo_stream_srv_link *link, int domain) +{ + switch (domain) { + case AF_UNSPEC: + case AF_INET: + case AF_INET6: + case AF_UNIX: + break; + default: + return -ENOTSUP; + } + link->sk_domain = domain; + link->flags |= OSMO_STREAM_SRV_F_RECONF; + return 0; +} + /*! \brief Set application private data of the stream server link * \param[in] link Stream Server Link to modify * \param[in] data User-specific data (available in call-back functions) */ @@ -1060,17 +1205,28 @@ link->flags &= ~OSMO_STREAM_SRV_F_RECONF; - switch (link->proto) { -#ifdef HAVE_LIBSCTP - case IPPROTO_SCTP: - ret = osmo_sock_init2_multiaddr(AF_UNSPEC, SOCK_STREAM, link->proto, - (const char **)link->addr, link->addrcnt, link->port, - NULL, 0, 0, OSMO_SOCK_F_BIND); + switch (link->sk_domain) { + case AF_UNIX: + ret = osmo_sock_unix_init(link->sk_type, 0, link->addr[0], OSMO_SOCK_F_BIND); break; + case AF_UNSPEC: + case AF_INET: + case AF_INET6: + switch (link->proto) { +#ifdef HAVE_LIBSCTP + case IPPROTO_SCTP: + ret = osmo_sock_init2_multiaddr(link->sk_domain, link->sk_type, link->proto, + (const char **)link->addr, link->addrcnt, link->port, + NULL, 0, 0, OSMO_SOCK_F_BIND); + break; #endif + default: + ret = osmo_sock_init(link->sk_domain, link->sk_type, link->proto, + link->addr[0], link->port, OSMO_SOCK_F_BIND); + } + break; default: - ret = osmo_sock_init(AF_UNSPEC, SOCK_STREAM, link->proto, - link->addr[0], link->port, OSMO_SOCK_F_BIND); + ret = -ENOTSUP; } if (ret < 0) return ret; @@ -1144,20 +1300,31 @@ llist_del(lh); msg = llist_entry(lh, struct msgb, list); - switch (conn->srv->proto) { -#ifdef HAVE_LIBSCTP - case IPPROTO_SCTP: - memset(&sinfo, 0, sizeof(sinfo)); - sinfo.sinfo_ppid = htonl(msgb_sctp_ppid(msg)); - sinfo.sinfo_stream = msgb_sctp_stream(msg); - ret = sctp_send(conn->ofd.fd, msg->data, msgb_length(msg), - &sinfo, MSG_NOSIGNAL); - break; -#endif - case IPPROTO_TCP: - default: + switch (conn->srv->sk_domain) { + case AF_UNIX: ret = send(conn->ofd.fd, msg->data, msg->len, 0); break; + case AF_INET: + case AF_INET6: + case AF_UNSPEC: + switch (conn->srv->proto) { +#ifdef HAVE_LIBSCTP + case IPPROTO_SCTP: + memset(&sinfo, 0, sizeof(sinfo)); + sinfo.sinfo_ppid = htonl(msgb_sctp_ppid(msg)); + sinfo.sinfo_stream = msgb_sctp_stream(msg); + ret = sctp_send(conn->ofd.fd, msg->data, msgb_length(msg), + &sinfo, MSG_NOSIGNAL); + break; +#endif + case IPPROTO_TCP: + default: + ret = send(conn->ofd.fd, msg->data, msg->len, 0); + break; + } + break; + default: + ret = -ENOTSUP; } if (ret < 0) { LOGP(DLINP, LOGL_ERROR, "error to send\n"); @@ -1352,16 +1519,27 @@ if (!msg) return -EINVAL; - switch (conn->srv->proto) { -#ifdef HAVE_LIBSCTP - case IPPROTO_SCTP: - ret = _sctp_recvmsg_wrapper(conn->ofd.fd, msg); - break; -#endif - case IPPROTO_TCP: - default: + switch (conn->srv->sk_domain) { + case AF_UNIX: ret = recv(conn->ofd.fd, msgb_data(msg), msgb_tailroom(msg), 0); break; + case AF_INET: + case AF_INET6: + case AF_UNSPEC: + switch (conn->srv->proto) { +#ifdef HAVE_LIBSCTP + case IPPROTO_SCTP: + ret = _sctp_recvmsg_wrapper(conn->ofd.fd, msg); + break; +#endif + case IPPROTO_TCP: + default: + ret = recv(conn->ofd.fd, msgb_data(msg), msgb_tailroom(msg), 0); + break; + } + break; + default: + ret = -ENOTSUP; } if (ret < 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5237a8121be05a9a31a39ca38a6a139062f258c4 Gerrit-Change-Number: 26434 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Arran Cudbard-bell Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:16:45 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:16:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 ) Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 10 Dec 2021 09:16:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:17:31 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:17:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add audio SAPI In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 ) Change subject: hnodeb: Add audio SAPI ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 Gerrit-Change-Number: 26444 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 10 Dec 2021 09:17:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:18:27 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:18:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add gtp SAPI In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 ) Change subject: hnodeb: Add gtp SAPI ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 Gerrit-Change-Number: 26445 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 10 Dec 2021 09:18:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:19:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 09:19:50 +0000 Subject: Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26426 ) Change subject: Introduce osmo_prim_srv APIs ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 Gerrit-Change-Number: 26426 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 09:19:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:20:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 09:20:01 +0000 Subject: Change in libosmo-netif[master]: Introduce osmo_prim_srv APIs In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26426 ) Change subject: Introduce osmo_prim_srv APIs ...................................................................... Introduce osmo_prim_srv APIs This new module allows easy exchange of osmo_prim based data types over IPC communication (UD socket supported only so far), by replacing the osmo_prim_hdr struct with a serialized header when submitting/receiving it from the IPC socket. This patch introduces the server side of the UD socket, but the client side can easily be introduced in the same file whenever needed. Related: SYS#5516 Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 --- M TODO-RELEASE M include/osmocom/netif/Makefile.am A include/osmocom/netif/prim.h M src/Makefile.am A src/prim.c 5 files changed, 409 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 1c9a2a6..b146231 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line sctp.h new APIs +prim.h new data type, APIs diff --git a/include/osmocom/netif/Makefile.am b/include/osmocom/netif/Makefile.am index d9d030b..92712a9 100644 --- a/include/osmocom/netif/Makefile.am +++ b/include/osmocom/netif/Makefile.am @@ -4,6 +4,7 @@ osmux.h \ ipa.h \ ipa_unit.h \ + prim.h \ rs232.h \ rtp.h \ stream.h diff --git a/include/osmocom/netif/prim.h b/include/osmocom/netif/prim.h new file mode 100644 index 0000000..4f17622 --- /dev/null +++ b/include/osmocom/netif/prim.h @@ -0,0 +1,54 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include + +#include +#include +#include + +struct osmo_prim_srv_link; +struct osmo_prim_srv; + +typedef int (*osmo_prim_srv_conn_cb)(struct osmo_prim_srv *prim_srv); +/*! oph and related msgb is owned by srv and wll be freed after the callback returns. */ +typedef int (*osmo_prim_srv_rx_cb)(struct osmo_prim_srv *prim_srv, struct osmo_prim_hdr *oph); + +struct osmo_prim_hdr *osmo_prim_msgb_alloc(unsigned int sap, unsigned int primitive, + enum osmo_prim_operation operation, size_t alloc_len); + +struct osmo_prim_srv_link *osmo_prim_srv_link_alloc(void *ctx); +void osmo_prim_srv_link_free(struct osmo_prim_srv_link *prim_link); +int osmo_prim_srv_link_set_addr(struct osmo_prim_srv_link *prim_link, const char *path); +const char *osmo_prim_srv_link_get_addr(struct osmo_prim_srv_link *prim_link); +void osmo_prim_srv_link_set_priv(struct osmo_prim_srv_link *prim_link, void *priv); +void *osmo_prim_srv_link_get_priv(const struct osmo_prim_srv_link *prim_link); +void osmo_prim_srv_link_set_log_category(struct osmo_prim_srv_link *prim_link, int log_cat); +void osmo_prim_srv_link_set_opened_conn_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_conn_cb opened_conn_cb); +void osmo_prim_srv_link_set_closed_conn_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_conn_cb closed_conn_cb); +void osmo_prim_srv_link_set_rx_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_rx_cb rx_cb); +void osmo_prim_srv_link_set_rx_msgb_alloc_len(struct osmo_prim_srv_link *prim_link, size_t alloc_len); +int osmo_prim_srv_link_open(struct osmo_prim_srv_link *prim_link); + +int osmo_prim_srv_send(struct osmo_prim_srv *prim_srv, struct msgb *msg); +struct osmo_prim_srv_link *osmo_prim_srv_get_link(struct osmo_prim_srv *prims_srv); +void osmo_prim_srv_set_priv(struct osmo_prim_srv *prim_srv, void *priv); +void *osmo_prim_srv_get_priv(const struct osmo_prim_srv *prim_srv); +void osmo_prim_srv_close(struct osmo_prim_srv *prim_srv); diff --git a/src/Makefile.am b/src/Makefile.am index 438b58e..5c23896 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -17,6 +17,7 @@ ipa_unit.c \ jibuf.c \ osmux.c \ + prim.c \ rs232.c \ rtp.c \ stream.c diff --git a/src/prim.c b/src/prim.c new file mode 100644 index 0000000..6c6da6e --- /dev/null +++ b/src/prim.c @@ -0,0 +1,352 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include + +#include +#include + +struct osmo_prim_pkt_hdr { + uint32_t sap; /*!< Service Access Point Identifier */ + uint16_t primitive; /*!< Primitive number */ + uint16_t operation; /*! Primitive Operation (enum osmo_prim_operation) */ +} __attribute__ ((packed)); + +/* Here we take advantage of the fact that sizeof(struct + * osmo_prim_pkt_hdr) <= sizeof(struct osmo_prim_hdr), so we don't need + * to allocate headroom when serializing later. + */ +osmo_static_assert(sizeof(struct osmo_prim_pkt_hdr) <= sizeof(struct osmo_prim_hdr), + osmo_prim_msgb_alloc_validate_headroom); + +/*! Allocate a primitive of given type and its associated msgb. +* \param[in] sap Service Access Point +* \param[in] primitive Primitive Number +* \param[in] operation Primitive Operation (REQ/RESP/IND/CONF) +* \param[in] alloc_len Total length (including struct osmo_prim_hdr) to allocate for the primitive +* \returns Pointer to allocated prim_hdr inisde its own msgb. The osmo_prim_hdr +* is pre-alocated & pre-filled. +*/ +struct osmo_prim_hdr *osmo_prim_msgb_alloc(unsigned int sap, unsigned int primitive, + enum osmo_prim_operation operation, size_t alloc_len) +{ + struct msgb *msg; + struct osmo_prim_hdr *oph; + + if (alloc_len < sizeof(*oph)) + return NULL; + + msg = msgb_alloc(alloc_len, "osmo_prim_msgb_alloc"); + oph = (struct osmo_prim_hdr *)msgb_put(msg, sizeof(*oph)); + osmo_prim_init(oph, sap, primitive, operation, msg); + msg->l2h = msg->tail; + + return oph; +} + +struct osmo_prim_srv_link { + void *priv; + char *addr; + int log_cat; /* Defaults to DLGLOBAL */ + struct osmo_stream_srv_link *stream; + osmo_prim_srv_conn_cb opened_conn_cb; + osmo_prim_srv_conn_cb closed_conn_cb; + osmo_prim_srv_rx_cb rx_cb; + size_t rx_msgb_alloc_len; +}; + +struct osmo_prim_srv { + void *priv; + struct osmo_prim_srv_link *link; /* backpointer */ + struct osmo_stream_srv *stream; +}; + +/****************************** + * osmo_prim_srv + ******************************/ +#define LOGSRV(srv, lvl, fmt, args...) LOGP((srv)->link->log_cat, lvl, fmt, ## args) + +static int _osmo_prim_srv_read_cb(struct osmo_stream_srv *srv) +{ + struct osmo_prim_srv *prim_srv = osmo_stream_srv_get_data(srv); + struct osmo_prim_pkt_hdr *pkth; + struct msgb *msg; + struct osmo_prim_hdr oph; + int rc; + + msg = msgb_alloc_c(prim_srv, sizeof(*pkth) + prim_srv->link->rx_msgb_alloc_len, + "osmo_prim_srv_link_rx"); + if (!msg) + return -ENOMEM; + rc = osmo_stream_srv_recv(srv, msg); + if (rc == 0) + goto close; + + if (rc < 0) { + if (errno == EAGAIN) { + msgb_free(msg); + return 0; + } + goto close; + } + + if (rc < sizeof(*pkth)) { + LOGSRV(prim_srv, LOGL_ERROR, "Received %d bytes on UD Socket, but primitive hdr size " + "is %zu, discarding\n", rc, sizeof(*pkth)); + msgb_free(msg); + return 0; + } + pkth = (struct osmo_prim_pkt_hdr *)msgb_data(msg); + + /* De-serialize message: */ + osmo_prim_init(&oph, pkth->sap, pkth->primitive, pkth->operation, msg); + msgb_pull(msg, sizeof(*pkth)); + + if (prim_srv->link->rx_cb) + rc = prim_srv->link->rx_cb(prim_srv, &oph); + + /* as we always synchronously process the message in _osmo_prim_srv_link_rx() and + * its callbacks, we can free the message here. */ + msgb_free(msg); + + return rc; + +close: + msgb_free(msg); + osmo_prim_srv_close(prim_srv); + return -1; +} + +static void osmo_prim_srv_free(struct osmo_prim_srv *prim_srv); +static int _osmo_prim_srv_closed_cb(struct osmo_stream_srv *srv) +{ + struct osmo_prim_srv *prim_srv = osmo_stream_srv_get_data(srv); + struct osmo_prim_srv_link *prim_link = prim_srv->link; + if (prim_link->closed_conn_cb) + return prim_link->closed_conn_cb(prim_srv); + osmo_prim_srv_free(prim_srv); + return 0; +} + +/*! Allocate a primitive of given type and its associated msgb. +* \param[in] srv The osmo_prim_srv_link instance where message is to be sent through +* \param[in] msg msgb containing osmo_prim_hdr plus extra content, allocated through \ref osmo_prim_msgb_alloc() +* \returns zero on success, negative on error */ +int osmo_prim_srv_send(struct osmo_prim_srv *prim_srv, struct msgb *msg) +{ + struct osmo_prim_hdr *oph; + struct osmo_prim_pkt_hdr *pkth; + unsigned int sap; + unsigned int primitive; + enum osmo_prim_operation operation; + + /* Serialize the oph: */ + oph = (struct osmo_prim_hdr *)msgb_data(msg); + OSMO_ASSERT(oph && msgb_length(msg) >= sizeof(*oph)); + sap = oph->sap; + primitive = oph->primitive; + operation = oph->operation; + msgb_pull(msg, sizeof(*oph)); + pkth = (struct osmo_prim_pkt_hdr *)msgb_push(msg, sizeof(*pkth)); + pkth->sap = sap; + pkth->primitive = primitive; + pkth->operation = operation; + + /* Finally enqueue the msg */ + osmo_stream_srv_send(prim_srv->stream, msg); + + return 0; +} + +static struct osmo_prim_srv *osmo_prim_srv_alloc(struct osmo_prim_srv_link *prim_link, int fd) +{ + struct osmo_prim_srv *prim_srv; + prim_srv = talloc_zero(prim_link, struct osmo_prim_srv); + if (!prim_srv) + return NULL; + prim_srv->link = prim_link; + prim_srv->stream = osmo_stream_srv_create(prim_link, prim_link->stream, fd, + _osmo_prim_srv_read_cb, + _osmo_prim_srv_closed_cb, + prim_srv); + if (!prim_srv->stream) { + talloc_free(prim_srv); + return NULL; + } + /* Inherit link priv pointer by default, user can later set it through API: */ + prim_srv->priv = prim_link->priv; + return prim_srv; +} + +static void osmo_prim_srv_free(struct osmo_prim_srv *prim_srv) +{ + talloc_free(prim_srv); +} + +struct osmo_prim_srv_link *osmo_prim_srv_get_link(struct osmo_prim_srv *prim_srv) +{ + return prim_srv->link; +} + +void osmo_prim_srv_set_priv(struct osmo_prim_srv *prim_srv, void *priv) +{ + prim_srv->priv = priv; +} + +void *osmo_prim_srv_get_priv(const struct osmo_prim_srv *prim_srv) +{ + return prim_srv->priv; +} + +void osmo_prim_srv_close(struct osmo_prim_srv *prim_srv) +{ + osmo_stream_srv_destroy(prim_srv->stream); + /* we free prim_srv in _osmo_prim_srv_closed_cb() */ +} + +/****************************** + * osmo_prim_srv_link + ******************************/ + +#define LOGSRVLINK(srv, lvl, fmt, args...) LOGP((srv)->log_cat, lvl, fmt, ## args) + +/* accept connection coming from PCU */ +static int _osmo_prim_srv_link_accept(struct osmo_stream_srv_link *link, int fd) +{ + struct osmo_prim_srv *prim_srv; + struct osmo_prim_srv_link *prim_link = osmo_stream_srv_link_get_data(link); + + prim_srv = osmo_prim_srv_alloc(prim_link, fd); + + if (prim_link->opened_conn_cb) + return prim_link->opened_conn_cb(prim_srv); + + return 0; +} + +struct osmo_prim_srv_link *osmo_prim_srv_link_alloc(void *ctx) +{ + struct osmo_prim_srv_link *prim_link; + prim_link = talloc_zero(ctx, struct osmo_prim_srv_link); + if (!prim_link) + return NULL; + prim_link->stream = osmo_stream_srv_link_create(prim_link); + if (!prim_link->stream) { + talloc_free(prim_link); + return NULL; + } + osmo_stream_srv_link_set_data(prim_link->stream, prim_link); + osmo_stream_srv_link_set_domain(prim_link->stream, AF_UNIX); + osmo_stream_srv_link_set_type(prim_link->stream, SOCK_SEQPACKET); + osmo_stream_srv_link_set_accept_cb(prim_link->stream, _osmo_prim_srv_link_accept); + + prim_link->log_cat = DLGLOBAL; + prim_link->rx_msgb_alloc_len = 1600 - sizeof(struct osmo_prim_pkt_hdr); + return prim_link; +} + +void osmo_prim_srv_link_free(struct osmo_prim_srv_link *prim_link) +{ + if (!prim_link) + return; + + if (prim_link->stream) { + osmo_stream_srv_link_close(prim_link->stream); + osmo_stream_srv_link_destroy(prim_link->stream); + prim_link->stream = NULL; + } + talloc_free(prim_link); +} + +int osmo_prim_srv_link_set_addr(struct osmo_prim_srv_link *prim_link, const char *path) +{ + osmo_talloc_replace_string(prim_link, &prim_link->addr, path); + osmo_stream_srv_link_set_addr(prim_link->stream, path); + return 0; +} + +const char *osmo_prim_srv_link_get_addr(struct osmo_prim_srv_link *prim_link) +{ + return prim_link->addr; +} + +void osmo_prim_srv_link_set_priv(struct osmo_prim_srv_link *prim_link, void *priv) +{ + prim_link->priv = priv; +} + +void *osmo_prim_srv_link_get_priv(const struct osmo_prim_srv_link *prim_link) +{ + return prim_link->priv; +} + +void osmo_prim_srv_link_set_log_category(struct osmo_prim_srv_link *prim_link, int log_cat) +{ + prim_link->log_cat = log_cat; +} + +void osmo_prim_srv_link_set_opened_conn_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_conn_cb opened_conn_cb) +{ + prim_link->opened_conn_cb = opened_conn_cb; +} +void osmo_prim_srv_link_set_closed_conn_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_conn_cb closed_conn_cb) +{ + prim_link->closed_conn_cb = closed_conn_cb; +} + +void osmo_prim_srv_link_set_rx_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_rx_cb rx_cb) +{ + prim_link->rx_cb = rx_cb; +} + +void osmo_prim_srv_link_set_rx_msgb_alloc_len(struct osmo_prim_srv_link *prim_link, size_t alloc_len) +{ + prim_link->rx_msgb_alloc_len = alloc_len; +} + +int osmo_prim_srv_link_open(struct osmo_prim_srv_link *prim_link) +{ + int rc; + + if (!prim_link->addr) { + LOGSRVLINK(prim_link, LOGL_ERROR, "Cannot open, Address not configured\n"); + return -1; + } + + rc = osmo_stream_srv_link_open(prim_link->stream); + + LOGSRVLINK(prim_link, LOGL_INFO, "Started listening on Lower Layer Unix Domain Socket: %s\n", prim_link->addr); + + return rc; +} -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7cab15ac092e45a256c4f0bab11b3962df861044 Gerrit-Change-Number: 26426 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:45:22 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:45:22 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: sort References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26489 ) Change subject: OSMO_RELEASE_REPOS: sort ...................................................................... OSMO_RELEASE_REPOS: sort Make it easier to figure out which projects are missing. Related: OS#5347 Change-Id: I3660032d020154b7a175483691842b576552ffd1 --- M scripts/common.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/89/26489/1 diff --git a/scripts/common.sh b/scripts/common.sh index 85725f6..b72dddf 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -6,12 +6,13 @@ # Osmocom repositories of which we want to build release tarballs automatically, and list the current versions at # https://jenkins.osmocom.org/jenkins/job/Osmocom-list-commits/lastSuccessfulBuild/artifact/commits.txt +# List is ordered alphabetically. OSMO_RELEASE_REPOS=" libasn1c libosmo-abis - libosmocore libosmo-netif libosmo-sccp + libosmocore libsmpp34 libusrp osmo-bsc -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3660032d020154b7a175483691842b576552ffd1 Gerrit-Change-Number: 26489 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:45:22 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:45:22 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: sync with Nov 2021 releases References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26490 ) Change subject: OSMO_RELEASE_REPOS: sync with Nov 2021 releases ...................................................................... OSMO_RELEASE_REPOS: sync with Nov 2021 releases Related: OS#5347 Related: https://osmocom.org/news/152 Change-Id: Ib2022ca670b322d81ff83bbca3bb262f8d7287a6 --- M scripts/common.sh M scripts/osmocom-release-tarballs.sh 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/90/26490/1 diff --git a/scripts/common.sh b/scripts/common.sh index b72dddf..10fe7f3 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -17,19 +17,26 @@ libusrp osmo-bsc osmo-bts + osmo-cbc + osmo-e1d + osmo-gbproxy osmo-ggsn + osmo-gsm-manuals osmo-hlr + osmo-hnodeb osmo-iuh osmo-mgw osmo-msc + osmo-pcap osmo-pcu osmo-sgsn osmo-sip-connector + osmo-smlc osmo-sysmon osmo-trx + osmo-uecups osmocom-bb " -#TODO: Add above once we have releases: osmo-hnodeb, osmo-gbproxy OSMO_BRANCH_DOCKER_PLAYGROUND="${OSMO_BRANCH_DOCKER_PLAYGROUND:-master}" diff --git a/scripts/osmocom-release-tarballs.sh b/scripts/osmocom-release-tarballs.sh index 9894a47..18ea1d7 100755 --- a/scripts/osmocom-release-tarballs.sh +++ b/scripts/osmocom-release-tarballs.sh @@ -54,6 +54,10 @@ # openbsc echo "1.0.1" ;; + osmo-pcap) + # No rule to make target 'osmo-pcap-server.cfg', needed by 'distdir' + echo "0.0.3" + ;; osmo-pcu) # Duplicates of 0.1.0, 0.2.0 echo "0.1" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib2022ca670b322d81ff83bbca3bb262f8d7287a6 Gerrit-Change-Number: 26490 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:45:22 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:45:22 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26491 ) Change subject: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim ...................................................................... OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim Adjust to simtrace2's directory structure, which does not have a configure.ac in the main directory like all other repositories. The main directory has a regular Makefile without autotools, only the host dir has a configure.ac file (and only in newer versions). Deal with this by creating two tarballs, one with "git archive" for the whole directory, and one for the host dir only with the usual "autoreconf -fi; ./configure; make dist-bzip2". The latter one has the files created by autoreconf ("configure" script and others). simtrace2 ??? simtrace2-0.1.tar.bz2 ??? simtrace2-0.2.tar.bz2 ??? simtrace2-0.3.tar.bz2 ??? simtrace2-0.4.tar.bz2 ??? simtrace2-0.5.1.tar.bz2 ??? simtrace2-0.5.tar.bz2 ??? simtrace2-0.6.1.tar.bz2 ??? simtrace2-0.6.tar.bz2 ??? simtrace2-0.7.0.tar.bz2 ??? simtrace2-0.7.1.tar.bz2 ??? simtrace2-0.8.0.tar.bz2 ??? simtrace2-0.8.1.tar.bz2 ??? simtrace2-host-0.6.1.tar.bz2 ??? simtrace2-host-0.6.tar.bz2 ??? simtrace2-host-0.7.0.tar.bz2 ??? simtrace2-host-0.7.1.tar.bz2 ??? simtrace2-host-0.8.0.tar.bz2 ??? simtrace2-host-0.8.1.tar.bz Closes: OS#5347 Change-Id: Ib52a23a2a7d6ea64bfa539b1d026f035fdb3af57 --- M scripts/common.sh M scripts/osmocom-release-tarballs.sh 2 files changed, 74 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/91/26491/1 diff --git a/scripts/common.sh b/scripts/common.sh index 10fe7f3..8657fd8 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -29,6 +29,7 @@ osmo-msc osmo-pcap osmo-pcu + osmo-remsim osmo-sgsn osmo-sip-connector osmo-smlc @@ -36,6 +37,7 @@ osmo-trx osmo-uecups osmocom-bb + simtrace2 " OSMO_BRANCH_DOCKER_PLAYGROUND="${OSMO_BRANCH_DOCKER_PLAYGROUND:-master}" diff --git a/scripts/osmocom-release-tarballs.sh b/scripts/osmocom-release-tarballs.sh index 18ea1d7..8242a49 100755 --- a/scripts/osmocom-release-tarballs.sh +++ b/scripts/osmocom-release-tarballs.sh @@ -128,7 +128,7 @@ } # Clone an Osmocom repository to $TEMP/repos/$repo, clean it, checkout a tag. -# $1: Osmocom repository +# $1: Osmocom repository (may end in subdir, e.g. simtrace2/host) # $2: tag (optional, default: master) prepare_repo() { local repo="$1" @@ -144,13 +144,21 @@ git checkout -q "$tag" } + +# Get the desired tarball name, replace / with - in $1. +# $1: Osmocom repository (may end in subdir, e.g. simtrace2/host) +# $2: tag +tarball_name() { + echo "$(echo "$repo" | tr / -)-$tag.tar.bz2" +} + # Checkout a given tag and build a release tarball. -# $1: Osmocom repository +# $1: Osmocom repository (may end in subdir, e.g. simtrace2/host) # $2: tag create_tarball() { local repo="$1" local tag="$2" - local tarball="$repo-$tag.tar.bz2" + local tarball="$(tarball_name "$repo" "$tag")" # Be verbose during the tarball build and preparation. Everything else is not verbose, so we can generate an # easy to read overview of tarballs that are already built or are ignored. @@ -174,15 +182,72 @@ fi } +# Create a release tarball with "git archive" for non-autotools projects. +# $1: Osmocom repository +# $2: tag +create_tarball_git() { + local repo="$1" + local tag="$2" + local tarball="$(tarball_name "$repo" "$tag")" + + set -x + + cd "$TEMP/repos/$repo" + git archive \ + -o "$tarball" \ + "$tag" + + set +x +} + # Move a generated release tarball to the output dir. +# $1: Osmocom repository (may end in subdir, e.g. simtrace2/host) +# $2: tag move_tarball() { local repo="$1" local tag="$2" - local tarball="$repo-$tag.tar.bz2" + local tarball="$(tarball_name "$repo" "$tag")" + local repo_dir="$(echo "$repo" | cut -d / -f 1)" cd "$TEMP/repos/$repo" - mkdir -p "$OUTPUT/$repo" - mv "$tarball" "$OUTPUT/$repo/$tarball" + mkdir -p "$OUTPUT/$repo_dir" + mv "$tarball" "$OUTPUT/$repo_dir/$tarball" +} + +# Check if a git tag has a specific file +# $1: Osmocom repository +# $2: tag +# $3: file +tag_has_file() { + local repo="$1" + local tag="$2" + local file="$3" + + git -C "$TEMP/repos/$repo" show "$tag:$file" >/dev/null 2>&1 +} + +# Create and move tarballs for Osmocom repositories. +# $1: Osmocom repository +# $2: tag +create_move_tarball() { + local repo="$1" + local tag="$2" + + case "$repo" in + simtrace2) + if tag_has_file "$repo" "$tag" host/configure.ac; then + create_tarball "$repo/host" "$tag" + move_tarball "$repo/host" "$tag" + fi + + create_tarball_git "$repo" "$tag" + move_tarball "$repo" "$tag" + ;; + *) + create_tarball "$repo" "$tag" + move_tarball "$repo" "$tag" + ;; + esac } remove_temp_dir @@ -211,8 +276,7 @@ fi echo " $tarball (creating)" - create_tarball "$repo" "$tag" - move_tarball "$repo" "$tag" + create_move_tarball "$repo" "$tag" done done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib52a23a2a7d6ea64bfa539b1d026f035fdb3af57 Gerrit-Change-Number: 26491 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:46:03 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:46:03 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/26491 to look at the new patch set (#2). Change subject: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim ...................................................................... OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim Adjust to simtrace2's directory structure, which does not have a configure.ac in the main directory like all other repositories. The main directory has a regular Makefile without autotools, only the host dir has a configure.ac file (and only in newer versions). Deal with this by creating two tarballs, one with "git archive" for the whole directory, and one for the host dir only with the usual "autoreconf -fi; ./configure; make dist-bzip2". The latter one has the files created by autoreconf ("configure" script and others). simtrace2 ??? simtrace2-0.1.tar.bz2 ??? simtrace2-0.2.tar.bz2 ??? simtrace2-0.3.tar.bz2 ??? simtrace2-0.4.tar.bz2 ??? simtrace2-0.5.1.tar.bz2 ??? simtrace2-0.5.tar.bz2 ??? simtrace2-0.6.1.tar.bz2 ??? simtrace2-0.6.tar.bz2 ??? simtrace2-0.7.0.tar.bz2 ??? simtrace2-0.7.1.tar.bz2 ??? simtrace2-0.8.0.tar.bz2 ??? simtrace2-0.8.1.tar.bz2 ??? simtrace2-host-0.6.1.tar.bz2 ??? simtrace2-host-0.6.tar.bz2 ??? simtrace2-host-0.7.0.tar.bz2 ??? simtrace2-host-0.7.1.tar.bz2 ??? simtrace2-host-0.8.0.tar.bz2 ??? simtrace2-host-0.8.1.tar.bz2 Closes: OS#5347 Change-Id: Ib52a23a2a7d6ea64bfa539b1d026f035fdb3af57 --- M scripts/common.sh M scripts/osmocom-release-tarballs.sh 2 files changed, 74 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/91/26491/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib52a23a2a7d6ea64bfa539b1d026f035fdb3af57 Gerrit-Change-Number: 26491 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:50:24 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:50:24 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-gsm-manuals deps References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26492 ) Change subject: debian-stretch-build-dist: osmo-gsm-manuals deps ...................................................................... debian-stretch-build-dist: osmo-gsm-manuals deps Add dependencies for osmo-gsm-manuals, so we can build the release tarballs for it (autoreconf -fi; ./configure; make dist-bzip2) in the related jenkins job. During update of the list of projects for which we build these tarballs, it became apparent that it was missing. Following patches will add dependencies needed to build release tarballs for all other projects that were missing from the list. Related: OS#5347 Change-Id: Iba2e71b2e757bc527561d0f3e4a1af5f024a3cd7 --- M debian-stretch-build-dist/Dockerfile 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/92/26492/1 diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile index 359c687..b0c06b6 100644 --- a/debian-stretch-build-dist/Dockerfile +++ b/debian-stretch-build-dist/Dockerfile @@ -4,6 +4,7 @@ RUN apt-get update && \ apt-get install -y --no-install-recommends \ + asciidoc \ autoconf \ autoconf-archive \ autogen \ @@ -12,7 +13,10 @@ build-essential \ ca-certificates \ dahdi-source \ + dblatex \ git \ + graphviz \ + inkscape \ libasn1c-dev \ libboost-all-dev \ libc-ares-dev \ @@ -55,5 +59,9 @@ libusrp-dev \ libyder-dev \ make \ + mscgen \ + python-nwdiag \ + python-pychart \ + xsltproc \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iba2e71b2e757bc527561d0f3e4a1af5f024a3cd7 Gerrit-Change-Number: 26492 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:50:25 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:50:25 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-hnodeb deps References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26493 ) Change subject: debian-stretch-build-dist: osmo-hnodeb deps ...................................................................... debian-stretch-build-dist: osmo-hnodeb deps Related: OS#5347 Change-Id: I9d708d86bf29f9fca0446fb990c606780bd7a1cb --- M debian-stretch-build-dist/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/93/26493/1 diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile index b0c06b6..e129d7b 100644 --- a/debian-stretch-build-dist/Dockerfile +++ b/debian-stretch-build-dist/Dockerfile @@ -35,9 +35,11 @@ libortp-dev \ libosmo-abis-dev \ libosmo-gsup-client-dev \ + libosmo-hnbap-dev \ libosmo-mgcp-client-dev \ libosmo-netif-dev \ libosmo-ranap-dev \ + libosmo-rua-dev \ libosmo-sccp-dev \ libosmo-sigtran-dev \ libosmocore-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9d708d86bf29f9fca0446fb990c606780bd7a1cb Gerrit-Change-Number: 26493 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:50:26 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:50:26 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-pcap deps References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26494 ) Change subject: debian-stretch-build-dist: osmo-pcap deps ...................................................................... debian-stretch-build-dist: osmo-pcap deps Related: OS#5347 Change-Id: If0f00dd09ce0db6a05972a564474a707d2d3174b --- M debian-stretch-build-dist/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/94/26494/1 diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile index e129d7b..e8cd75b 100644 --- a/debian-stretch-build-dist/Dockerfile +++ b/debian-stretch-build-dist/Dockerfile @@ -60,6 +60,7 @@ libusb-dev \ libusrp-dev \ libyder-dev \ + libzmq3-dev \ make \ mscgen \ python-nwdiag \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If0f00dd09ce0db6a05972a564474a707d2d3174b Gerrit-Change-Number: 26494 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:50:26 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:50:26 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-remsim deps References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26495 ) Change subject: debian-stretch-build-dist: osmo-remsim deps ...................................................................... debian-stretch-build-dist: osmo-remsim deps Related: OS#5347 Change-Id: I8fd4b9d3734dd3bc0e3fca8ceaedda2aedc6a055 --- M debian-stretch-build-dist/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/95/26495/1 diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile index e8cd75b..719f941 100644 --- a/debian-stretch-build-dist/Dockerfile +++ b/debian-stretch-build-dist/Dockerfile @@ -20,6 +20,7 @@ libasn1c-dev \ libboost-all-dev \ libc-ares-dev \ + libcsv-dev \ libdbd-sqlite3 \ libdbi-dev \ libfftw3-dev \ @@ -42,6 +43,7 @@ libosmo-rua-dev \ libosmo-sccp-dev \ libosmo-sigtran-dev \ + libosmo-simtrace2-dev \ libosmocore-dev \ libosmodsp-dev \ libpcap-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8fd4b9d3734dd3bc0e3fca8ceaedda2aedc6a055 Gerrit-Change-Number: 26495 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:50:26 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:50:26 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-uecups deps References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26496 ) Change subject: debian-stretch-build-dist: osmo-uecups deps ...................................................................... debian-stretch-build-dist: osmo-uecups deps Related: OS#5347 Change-Id: I19b6b0363aeeb89ab6aac2b125359589e6b9b5a7 --- M debian-stretch-build-dist/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/96/26496/1 diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile index 719f941..1ef8d69 100644 --- a/debian-stretch-build-dist/Dockerfile +++ b/debian-stretch-build-dist/Dockerfile @@ -40,6 +40,7 @@ libosmo-mgcp-client-dev \ libosmo-netif-dev \ libosmo-ranap-dev \ + libnl-route-3-dev \ libosmo-rua-dev \ libosmo-sccp-dev \ libosmo-sigtran-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I19b6b0363aeeb89ab6aac2b125359589e6b9b5a7 Gerrit-Change-Number: 26496 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:51:56 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:51:56 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: sync with Nov 2021 releases In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/26490 to look at the new patch set (#2). Change subject: OSMO_RELEASE_REPOS: sync with Nov 2021 releases ...................................................................... OSMO_RELEASE_REPOS: sync with Nov 2021 releases Depends: docker-playground I19b6b0363aeeb89ab6aac2b125359589e6b9b5a7 Related: OS#5347 Related: https://osmocom.org/news/152 Change-Id: Ib2022ca670b322d81ff83bbca3bb262f8d7287a6 --- M scripts/common.sh M scripts/osmocom-release-tarballs.sh 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/90/26490/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib2022ca670b322d81ff83bbca3bb262f8d7287a6 Gerrit-Change-Number: 26490 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 09:51:56 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 09:51:56 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/26491 to look at the new patch set (#3). Change subject: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim ...................................................................... OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim Adjust to simtrace2's directory structure, which does not have a configure.ac in the main directory like all other repositories. The main directory has a regular Makefile without autotools, only the host dir has a configure.ac file (and only in newer versions). Deal with this by creating two tarballs, one with "git archive" for the whole directory, and one for the host dir only with the usual "autoreconf -fi; ./configure; make dist-bzip2". The latter one has the files created by autoreconf ("configure" script and others). simtrace2 ??? simtrace2-0.1.tar.bz2 ??? simtrace2-0.2.tar.bz2 ??? simtrace2-0.3.tar.bz2 ??? simtrace2-0.4.tar.bz2 ??? simtrace2-0.5.1.tar.bz2 ??? simtrace2-0.5.tar.bz2 ??? simtrace2-0.6.1.tar.bz2 ??? simtrace2-0.6.tar.bz2 ??? simtrace2-0.7.0.tar.bz2 ??? simtrace2-0.7.1.tar.bz2 ??? simtrace2-0.8.0.tar.bz2 ??? simtrace2-0.8.1.tar.bz2 ??? simtrace2-host-0.6.1.tar.bz2 ??? simtrace2-host-0.6.tar.bz2 ??? simtrace2-host-0.7.0.tar.bz2 ??? simtrace2-host-0.7.1.tar.bz2 ??? simtrace2-host-0.8.0.tar.bz2 ??? simtrace2-host-0.8.1.tar.bz2 Closes: OS#5347 Change-Id: Ib52a23a2a7d6ea64bfa539b1d026f035fdb3af57 --- M scripts/common.sh M scripts/osmocom-release-tarballs.sh 2 files changed, 74 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/91/26491/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib52a23a2a7d6ea64bfa539b1d026f035fdb3af57 Gerrit-Change-Number: 26491 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Dec 10 10:25:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 10:25:06 +0000 Subject: Build failure of network:osmocom:nightly/zeromq in CentOS_7/x86_64 In-Reply-To: References: Message-ID: <61b32b041fa32_72822b13744585f010817bc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/zeromq/CentOS_7/x86_64 Package network:osmocom:nightly/zeromq failed to build in CentOS_7/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly zeromq Last lines of build log: [ 61s] [357/363] installing gettext-devel-0.19.8.1-3.el7 [ 61s] [358/363] installing pango-1.42.4-4.el7_7 [ 61s] [359/363] installing initscripts-9.49.53-1.el7 [ 61s] [360/363] installing librsvg2-2.40.20-1.el7 [ 61s] [361/363] installing gtk2-2.24.31-1.el7 [ 62s] [362/363] installing graphviz-2.30.1-22.el7 [ 62s] [363/363] installing asciidoc-8.6.8-5.el7 [ 62s] now finalizing build dir... [ 62s] RTNETLINK answers: File exists [ 62s] RTNETLINK answers: File exists [ 62s] ----------------------------------------------------------------- [ 62s] I have the following modifications for zeromq.spec: [ 62s] 27c27 [ 62s] < Release: 0 [ 62s] --- [ 62s] > Release: 3.1 [ 62s] ----------------------------------------------------------------- [ 62s] ----- building zeromq.spec (user abuild) [ 62s] ----------------------------------------------------------------- [ 62s] ----------------------------------------------------------------- [ 62s] + exec rpmbuild -ba --define '_srcdefattr (-,root,root)' --nosignature --define '_build_create_debug 1' --define 'disturl obs://build.opensuse.org/network:osmocom:nightly/CentOS_7/82b0dc98940666a4916de4d73f7dd0ea-zeromq' /home/abuild/rpmbuild/SOURCES/zeromq.spec [ 62s] error: line 64: Unknown tag: Recommends: zeromq-tools = 4.3.4 [ 62s] ### VM INTERACTION START ### [ 64s] Powering off. [ 64s] [ 55.094342] reboot: Power down [ 64s] ### VM INTERACTION END ### [ 64s] [ 64s] goat15 failed "build zeromq.spec" at Fri Dec 10 10:24:54 UTC 2021. [ 64s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 11:20:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 11:20:14 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <61b33807cedcb_72822b13744585f01100847@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 50s] + cd simtrace2-0.8.0.202112100026 [ 50s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/share/doc/packages/simtrace2 [ 50s] + export LC_ALL=C [ 50s] + LC_ALL=C [ 50s] + export DOCDIR [ 50s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/share/doc/packages/simtrace2 [ 50s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/share/doc/packages/simtrace2 [ 50s] + RPM_EC=0 [ 50s] ++ jobs -p [ 50s] + exit 0 [ 50s] Provides: simtrace2 = 0.8.0.202112100026-1.1 simtrace2(x86-32) = 0.8.0.202112100026-1.1 [ 50s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 50s] Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libosmo-simtrace2.so.1 libosmocore.so.18 libosmosim.so.2 libosmousb.so.0 libusb-1.0.so.0 [ 50s] Processing files: simtrace2-debugsource-0.8.0.202112100026-1.1.i586 [ 50s] Provides: simtrace2-debugsource = 0.8.0.202112100026-1.1 simtrace2-debugsource(x86-32) = 0.8.0.202112100026-1.1 [ 50s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 50s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-1.1.i586 [ 50s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/lib/libosmo-simtrace2.so.0* [ 50s] [ 50s] [ 50s] RPM build errors: [ 50s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/lib/libosmo-simtrace2.so.0* [ 50s] ### VM INTERACTION START ### [ 53s] [ 42.686589][ T435] sysrq: Power Off [ 53s] [ 42.707068][ T7] reboot: Power down [ 53s] ### VM INTERACTION END ### [ 53s] [ 53s] goat09 failed "build simtrace2.spec" at Fri Dec 10 11:20:02 UTC 2021. [ 53s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 11:24:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 11:24:31 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <61b338f67c58d_72822b13744585f01102242@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 51s] + cd simtrace2-0.8.0.202112100026 [ 51s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 51s] + export LC_ALL=C [ 51s] + LC_ALL=C [ 51s] + export DOCDIR [ 51s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 51s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 51s] + RPM_EC=0 [ 51s] ++ jobs -p [ 51s] + exit 0 [ 51s] Provides: simtrace2 = 0.8.0.202112100026-1.1 simtrace2(x86-64) = 0.8.0.202112100026-1.1 [ 51s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 51s] Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.34)(64bit) libc.so.6(GLIBC_2.4)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 51s] Processing files: simtrace2-debugsource-0.8.0.202112100026-1.1.x86_64 [ 51s] Provides: simtrace2-debugsource = 0.8.0.202112100026-1.1 simtrace2-debugsource(x86-64) = 0.8.0.202112100026-1.1 [ 51s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 51s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-1.1.x86_64 [ 51s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 51s] [ 51s] [ 51s] RPM build errors: [ 51s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 51s] ### VM INTERACTION START ### [ 54s] [ 46.792836][ T438] sysrq: Power Off [ 54s] [ 46.797771][ T16] reboot: Power down [ 55s] ### VM INTERACTION END ### [ 55s] [ 55s] lamb13 failed "build simtrace2.spec" at Fri Dec 10 11:24:14 UTC 2021. [ 55s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 11:34:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 11:34:48 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <61b33b6db3b08_72822b13744585f011086a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Tumbleweed/i586 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 75s] + cd simtrace2-0.8.0 [ 75s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/share/doc/packages/simtrace2 [ 75s] + export LC_ALL=C [ 75s] + LC_ALL=C [ 75s] + export DOCDIR [ 75s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/share/doc/packages/simtrace2 [ 75s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/share/doc/packages/simtrace2 [ 75s] + RPM_EC=0 [ 75s] ++ jobs -p [ 75s] + exit 0 [ 75s] Provides: simtrace2 = 0.8.0-1.1 simtrace2(x86-32) = 0.8.0-1.1 [ 75s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 75s] Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libosmo-simtrace2.so.1 libosmocore.so.18 libosmosim.so.2 libosmousb.so.0 libusb-1.0.so.0 [ 75s] Processing files: simtrace2-debugsource-0.8.0-1.1.i586 [ 76s] Provides: simtrace2-debugsource = 0.8.0-1.1 simtrace2-debugsource(x86-32) = 0.8.0-1.1 [ 76s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 76s] Processing files: libosmo-simtrace2-0-0.8.0-1.1.i586 [ 76s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/lib/libosmo-simtrace2.so.0* [ 76s] [ 76s] [ 76s] RPM build errors: [ 76s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/lib/libosmo-simtrace2.so.0* [ 76s] ### VM INTERACTION START ### [ 79s] [ 70.809473][ T438] sysrq: Power Off [ 79s] [ 70.842851][ T16] reboot: Power down [ 79s] ### VM INTERACTION END ### [ 79s] [ 79s] lamb18 failed "build simtrace2.spec" at Fri Dec 10 11:34:41 UTC 2021. [ 79s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Dec 10 11:46:15 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 11:46:15 +0000 Subject: Change in docker-playground[master]: Add centos7 containers References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26497 ) Change subject: Add centos7 containers ...................................................................... Add centos7 containers Related: SYS#5754 Change-Id: Iadf3d0d7143c2d81ea5e87fd07a3f4cd9239cb46 --- A centos7-build/Dockerfile A centos7-build/Makefile A centos7-obs-latest/Dockerfile A centos7-obs-latest/Makefile M jenkins-common.sh 5 files changed, 115 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/97/26497/1 diff --git a/centos7-build/Dockerfile b/centos7-build/Dockerfile new file mode 100644 index 0000000..2e04efb --- /dev/null +++ b/centos7-build/Dockerfile @@ -0,0 +1,65 @@ +ARG REGISTRY=docker.io +ARG UPSTREAM_DISTRO=centos:centos7 +FROM ${REGISTRY}/${UPSTREAM_DISTRO} +# Arguments used after FROM must be specified again +ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" +ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" + +# Use dnf package manager instead of yum, so we can use all the dnf codepaths +# that were originally written for CentOS8 in this CentOS7 image too +RUN yum install -y dnf + +# Let package metadata expire after 60 seconds instead of 48 hours +RUN echo "metadata_expire=60" >> /etc/dnf/dnf.conf && cat /etc/dnf/dnf.conf + +# Set up Osmocom OBS repository +RUN export MIRROR_HTTPS="$(echo $OSMOCOM_REPO_MIRROR | sed s/^http:/https:/)" && \ + { echo "[network_osmocom_nightly]"; \ + echo "name=Nightly packages of the Osmocom project (CentOS_7)"; \ + echo "type=rpm-md"; \ + echo "baseurl=${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/nightly/CentOS_7/"; \ + echo "gpgcheck=1"; \ + echo "gpgkey=${MIRROR_HTTPS}/${OSMOCOM_REPO_PATH}/nightly/CentOS_7/repodata/repomd.xml.key"; \ + echo "enabled=1"; \ + } > /etc/yum.repos.d/network:osmocom:nightly.repo + +RUN dnf install -y \ + autoconf \ + autoconf-archive \ + autogen \ + automake \ + bison \ + c-ares-devel \ + doxygen \ + fftw-devel \ + flex \ + gawk \ + gcc \ + gcc-c++ \ + git \ + gnupg \ + gnutls-devel \ + gsm-devel \ + libdbi-dbd-sqlite \ + libdbi-devel \ + libpcap-devel \ + libtalloc-devel \ + libtool \ + libusb1-devel \ + lksctp-tools-devel \ + make \ + ncurses-devel \ + openssl-devel \ + ortp-devel \ + pcsc-lite-devel \ + pkgconfig \ + readline-devel \ + sqlite \ + sqlite-devel \ + telnet + +# Make respawn.sh part of this image, so it can be used by other images based on it +COPY .common/respawn.sh /usr/local/bin/respawn.sh + +# Invalidate cache once the repository is updated +ADD ${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/nightly/CentOS_7/repodata/repomd.xml /tmp/repomd.xml diff --git a/centos7-build/Makefile b/centos7-build/Makefile new file mode 100644 index 0000000..cba5cee --- /dev/null +++ b/centos7-build/Makefile @@ -0,0 +1,3 @@ +UPSTREAM_DISTRO:=centos:centos8 +DISTRO:=centos8 +include ../make/Makefile diff --git a/centos7-obs-latest/Dockerfile b/centos7-obs-latest/Dockerfile new file mode 100644 index 0000000..dfe12fc --- /dev/null +++ b/centos7-obs-latest/Dockerfile @@ -0,0 +1,34 @@ +ARG REGISTRY=docker.io +ARG UPSTREAM_DISTRO=centos:centos7 +FROM ${REGISTRY}/${UPSTREAM_DISTRO} +# Arguments used after FROM must be specified again +ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" +ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_VERSION="latest" + +# Use dnf package manager instead of yum, so we can use all the dnf codepaths +# that were originally written for CentOS8 in this CentOS7 image too +RUN yum install -y dnf + +# Let package metadata expire after 60 seconds instead of 48 hours +RUN echo "metadata_expire=60" >> /etc/dnf/dnf.conf && cat /etc/dnf/dnf.conf + +# Set up Osmocom OBS repository +RUN export MIRROR_HTTPS="$(echo $OSMOCOM_REPO_MIRROR | sed s/^http:/https:/)" && \ + { echo "[network_osmocom_${OSMOCOM_REPO_VERSION}]"; \ + echo "name=Osmocom ${OSMOCOM_REPO_VERSION}"; \ + echo "type=rpm-md"; \ + echo "baseurl=${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/${OSMOCOM_REPO_VERSION}/CentOS_7/"; \ + echo "gpgcheck=1"; \ + echo "gpgkey=${MIRROR_HTTPS}/${OSMOCOM_REPO_PATH}/${OSMOCOM_REPO_VERSION}/CentOS_7/repodata/repomd.xml.key"; \ + echo "enabled=1"; \ + } > "/etc/yum.repos.d/network:osmocom:${OSMOCOM_REPO_VERSION}.repo" + +RUN dnf install -y \ + telnet + +# Make respawn.sh part of this image, so it can be used by other images based on it +COPY .common/respawn.sh /usr/local/bin/respawn.sh + +# Invalidate cache once the repository is updated +ADD ${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/${OSMOCOM_REPO_VERSION}/CentOS_7/repodata/repomd.xml /tmp/repomd.xml diff --git a/centos7-obs-latest/Makefile b/centos7-obs-latest/Makefile new file mode 100644 index 0000000..cba5cee --- /dev/null +++ b/centos7-obs-latest/Makefile @@ -0,0 +1,3 @@ +UPSTREAM_DISTRO:=centos:centos8 +DISTRO:=centos8 +include ../make/Makefile diff --git a/jenkins-common.sh b/jenkins-common.sh index 3511c02..9373076 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -15,7 +15,9 @@ feed="$(echo "$feed" | sed 's/\-centos8$//')" # e.g. "2021q1" echo "centos8-obs-$feed" ;; + osmo-*-latest-centos7) echo "centos7-obs-latest" ;; osmo-*-latest-centos8) echo "centos8-obs-latest" ;; + osmo-*-centos7) echo "centos7-build" ;; osmo-*-centos8) echo "centos8-build" ;; osmo-*-latest) echo "debian-stretch-obs-latest" ;; osmo-*) echo "debian-stretch-build" ;; @@ -25,7 +27,9 @@ docker_distro_from_image_name() { case "$1" in + osmo-*-centos7) echo "centos7" ;; osmo-*-centos8) echo "centos8" ;; + centos7-*) echo "centos7" ;; centos8-*) echo "centos8" ;; *) echo "debian-stretch" ;; esac @@ -33,7 +37,9 @@ docker_upstream_distro_from_image_name() { case "$1" in + osmo-*-centos7) echo "centos:centos7"; ;; osmo-*-centos8) echo "centos:centos8"; ;; + centos7-*) echo "centos:centos7" ;; centos8-*) echo "centos:centos8" ;; debian10-*) echo "debian:buster" ;; *) echo "debian:stretch" ;; @@ -46,6 +52,10 @@ # e.g. osmo-mgw-2021q1-centos8 -> osmo-mgw-latest echo "$1" | sed 's/20[0-9][0-9]q.*\-centos8$/latest/' ;; + osmo-*-centos7) + # e.g. osmo-mgw-latest-centos7 -> osmo-mgw-latest + echo "$1" | sed 's/\-centos7$//' + ;; osmo-*-centos8) # e.g. osmo-mgw-latest-centos8 -> osmo-mgw-latest echo "$1" | sed 's/\-centos8$//' -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iadf3d0d7143c2d81ea5e87fd07a3f4cd9239cb46 Gerrit-Change-Number: 26497 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 11:46:16 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 11:46:16 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... osmo-pcap-master: doesn't need libosmo-netif Don't attempt to install libosmo-netif in this Dockerfile. I've noticed this because we want to build osmo-pcap for CentOS7 with this container to run the TTCN-3 tests, and we don't have libosmo-netif for CentOS7. Related: SYS#5754 Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 --- M osmo-pcap-master/Dockerfile 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/98/26498/1 diff --git a/osmo-pcap-master/Dockerfile b/osmo-pcap-master/Dockerfile index a2b75c1..eeb210c 100644 --- a/osmo-pcap-master/Dockerfile +++ b/osmo-pcap-master/Dockerfile @@ -9,16 +9,15 @@ apt-get update && \ apt-get install -y --no-install-recommends \ libosmocore-dev \ - libosmo-netif-dev \ libzmq3-dev \ && \ apt-get clean \ ;; \ centos*) \ dnf install -y \ - "pkgconfig(libosmo-netif)" \ "pkgconfig(libosmocore)" \ "pkgconfig(libosmoctrl)" \ + "pkgconfig(libosmogb)" \ "pkgconfig(libosmogsm)" \ "pkgconfig(libosmovty)" \ "pkgconfig(libzmq)" \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 11:46:16 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 11:46:16 +0000 Subject: Change in docker-playground[master]: osmo-pcap-latest: fix install path for centos References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26499 ) Change subject: osmo-pcap-latest: fix install path for centos ...................................................................... osmo-pcap-latest: fix install path for centos Adjust to the package not being split in rpm packaging. This was not noticed before, because we did not run TTCN-3 tests for osmo-pcap with CentOS8. Related: SYS#5754 Change-Id: I775776ff7f358fee3d085f814c295c49225f5170 --- M osmo-pcap-latest/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/99/26499/1 diff --git a/osmo-pcap-latest/Dockerfile b/osmo-pcap-latest/Dockerfile index 7cb4d79..7f74383 100644 --- a/osmo-pcap-latest/Dockerfile +++ b/osmo-pcap-latest/Dockerfile @@ -14,7 +14,7 @@ ;; \ centos*) \ dnf install -y \ - osmo-pcap-client osmo-pcap-server \ + osmo-pcap \ ;; \ esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I775776ff7f358fee3d085f814c295c49225f5170 Gerrit-Change-Number: 26499 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 11:46:35 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 11:46:35 +0000 Subject: Change in osmo-ci[master]: jobs/ttcn3-testsuites: add centos7 pcap-client References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26500 ) Change subject: jobs/ttcn3-testsuites: add centos7 pcap-client ...................................................................... jobs/ttcn3-testsuites: add centos7 pcap-client Depends: docker-playground I775776ff7f358fee3d085f814c295c49225f5170 Closes: SYS#5754 Change-Id: I6cab8f919efd94b4d7c2664fd131f7210aac86a6 --- M jobs/ttcn3-testsuites.yml 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/00/26500/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 515ac10..854a5fb 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -213,6 +213,16 @@ # Jobs below use uppercase TTCN3-$DISTRO, so they get listed separately from the ttcn3-* (debian-stretch) jobs + # centos7 nightly + - TTCN3-centos7-pcap-client-test: + blocking: "^(ttcn3|TTCN3-.*)-pcap-client-test.*" + timer: 10 13 * * * + + # centos7 latest + - TTCN3-centos7-pcap-client-test-latest: + blocking: "^(ttcn3|TTCN3-.*)-ggsn-test.*" + timer: 40 13 * * * + # centos8 nightly - TTCN3-centos-ggsn-test: blocking: "^(ttcn3|TTCN3-.*)-ggsn-test.*" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6cab8f919efd94b4d7c2664fd131f7210aac86a6 Gerrit-Change-Number: 26500 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 11:51:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 11:51:03 +0000 Subject: Change in docker-playground[master]: Add centos7 containers In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26497 ) Change subject: Add centos7 containers ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/docker-playground/+/26497/1/centos7-obs-latest/Makefile File centos7-obs-latest/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/26497/1/centos7-obs-latest/Makefile at 1 PS1, Line 1: UPSTREAM_DISTRO:=centos:centos8 this is centos8 in centos8-obs-latest? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iadf3d0d7143c2d81ea5e87fd07a3f4cd9239cb46 Gerrit-Change-Number: 26497 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 11:51:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 11:51:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 11:51:49 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... Patch Set 1: your commitlog states remove libosmonetif, but the patch also adds libosmogb (which should not be required)? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 11:51:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 11:52:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 10 Dec 2021 11:52:09 +0000 Subject: Change in docker-playground[master]: osmo-pcap-latest: fix install path for centos In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26499 ) Change subject: osmo-pcap-latest: fix install path for centos ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I775776ff7f358fee3d085f814c295c49225f5170 Gerrit-Change-Number: 26499 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 11:52:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 11:53:39 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 11:53:39 +0000 Subject: Change in docker-playground[master]: Add centos7 containers In-Reply-To: References: Message-ID: osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/docker-playground/+/26497 ) Change subject: Add centos7 containers ...................................................................... Add centos7 containers Related: SYS#5754 Change-Id: Iadf3d0d7143c2d81ea5e87fd07a3f4cd9239cb46 --- A centos7-build/Dockerfile A centos7-build/Makefile A centos7-obs-latest/Dockerfile A centos7-obs-latest/Makefile M jenkins-common.sh 5 files changed, 115 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/97/26497/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iadf3d0d7143c2d81ea5e87fd07a3f4cd9239cb46 Gerrit-Change-Number: 26497 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 11:54:07 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 11:54:07 +0000 Subject: Change in docker-playground[master]: Add centos7 containers In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26497 ) Change subject: Add centos7 containers ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/docker-playground/+/26497/1/centos7-obs-latest/Makefile File centos7-obs-latest/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/26497/1/centos7-obs-latest/Makefile at 1 PS1, Line 1: UPSTREAM_DISTRO:=centos:centos8 > this is centos8 in centos8-obs-latest? Good catch, fixed both Makefiles. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iadf3d0d7143c2d81ea5e87fd07a3f4cd9239cb46 Gerrit-Change-Number: 26497 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 11:54:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 11:56:40 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 11:56:40 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/26498 to look at the new patch set (#3). Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... osmo-pcap-master: doesn't need libosmo-netif Don't attempt to install libosmo-netif in this Dockerfile. I've noticed this because we want to build osmo-pcap for CentOS7 with this container to run the TTCN-3 tests, and we don't have libosmo-netif for CentOS7. Add pkgconfig(libosmogb), which is required to build osmo-pcap according to configure.ac. In Debian, this gets installed as part of libosmocore-dev. Related: SYS#5754 Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 --- M osmo-pcap-master/Dockerfile 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/98/26498/3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 11:56:40 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 11:56:40 +0000 Subject: Change in docker-playground[master]: osmo-pcap-latest: fix install path for centos In-Reply-To: References: Message-ID: Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/26499 to look at the new patch set (#3). Change subject: osmo-pcap-latest: fix install path for centos ...................................................................... osmo-pcap-latest: fix install path for centos Adjust to the package not being split in rpm packaging. This was not noticed before, because we did not run TTCN-3 tests for osmo-pcap with CentOS8. Related: SYS#5754 Change-Id: I775776ff7f358fee3d085f814c295c49225f5170 --- M osmo-pcap-latest/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/99/26499/3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I775776ff7f358fee3d085f814c295c49225f5170 Gerrit-Change-Number: 26499 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 11:56:56 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 11:56:56 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... Patch Set 3: > Patch Set 1: > > your commitlog states remove libosmonetif, but the patch also adds libosmogb (which should not be required)? according to configure.ac it is required, updated the commit message -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 11:56:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Dec 10 11:49:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 11:49:57 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <61b33ef38af10_72822b13744585f0111512b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 147s] + cd simtrace2-0.8.0 [ 147s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 147s] + export LC_ALL=C [ 147s] + LC_ALL=C [ 147s] + export DOCDIR [ 147s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 147s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 147s] + RPM_EC=0 [ 147s] ++ jobs -p [ 147s] + exit 0 [ 147s] Provides: simtrace2 = 0.8.0-1.1 simtrace2(x86-64) = 0.8.0-1.1 [ 147s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 147s] Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.34)(64bit) libc.so.6(GLIBC_2.4)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 147s] Processing files: simtrace2-debugsource-0.8.0-1.1.x86_64 [ 148s] Provides: simtrace2-debugsource = 0.8.0-1.1 simtrace2-debugsource(x86-64) = 0.8.0-1.1 [ 148s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 148s] Processing files: libosmo-simtrace2-0-0.8.0-1.1.x86_64 [ 148s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 148s] [ 148s] [ 148s] RPM build errors: [ 148s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 148s] ### VM INTERACTION START ### [ 151s] [ 99.669348][ T435] sysrq: Power Off [ 151s] [ 99.687038][ T16] reboot: Power down [ 151s] ### VM INTERACTION END ### [ 151s] [ 151s] lamb04 failed "build simtrace2.spec" at Fri Dec 10 11:49:50 UTC 2021. [ 151s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Dec 10 13:57:31 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 13:57:31 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26435 ) Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 10 Dec 2021 13:57:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:06:36 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 14:06:36 +0000 Subject: Change in simtrace2[master]: host/contrib/simtrace2.spec.in: update References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26501 ) Change subject: host/contrib/simtrace2.spec.in: update ...................................................................... host/contrib/simtrace2.spec.in: update Apply various improvements from Martin Hauke, thanks! * Put sover into a variable * Sync BuildRequires with configure.ac * Update libosmo-simtrace2 summary * Use %make_build instead of make %{?_smp_mflags} Change-Id: I35ce3865702f72365b38b0eaa8b28f332dabcd1f --- M host/contrib/simtrace2.spec.in 1 file changed, 16 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/01/26501/1 diff --git a/host/contrib/simtrace2.spec.in b/host/contrib/simtrace2.spec.in index 1c47f5e..0bc5d2a 100644 --- a/host/contrib/simtrace2.spec.in +++ b/host/contrib/simtrace2.spec.in @@ -1,7 +1,8 @@ # # spec file for package simtrace2 # -# Copyright (c) 2018, Martin Hauke +# Copyright (c) 2021 SUSE LLC +# Copyright (c) 2018-2021, Martin Hauke # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -12,6 +13,7 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. +%define sover 1 Name: simtrace2 Version: @VERSION@ Release: 0 @@ -24,12 +26,11 @@ BuildRequires: automake BuildRequires: libtool BuildRequires: pkgconfig -BuildRequires: pkgconfig(libosmocore) -BuildRequires: pkgconfig(libosmosim) +BuildRequires: pkgconfig(libosmocore) >= 1.4.0 +BuildRequires: pkgconfig(libosmosim) >= 1.4.0 +BuildRequires: pkgconfig(libosmousb) >= 1.4.0 BuildRequires: pkgconfig(libpcsclite) BuildRequires: pkgconfig(libusb-1.0) -BuildRequires: pkgconfig(libosmousb) >= 0.0.0 -BuildRequires: pkgconfig(udev) %description Osmocom SIMtrace 2 is a software and hardware system for passively @@ -38,11 +39,11 @@ This package contains SIMtrace 2 host utility. -%package -n libosmo-simtrace2-1 -Summary: Shared Library part of libosmo-simtrace2 +%package -n libosmo-simtrace2-%{sover} +Summary: Driver functions for Osmocom SIMtrace2 and compatible firmware Group: System/Libraries -%description -n libosmo-simtrace2-1 +%description -n libosmo-simtrace2-%{sover} This library contains core "driver" functionality to interface with the Osmocom SIMtrace2 (and compatible) USB device firmware. It enables applications to implement SIM card / smart card tracing as well as @@ -51,7 +52,7 @@ %package -n libosmo-simtrace2-devel Summary: Development files for the Osmocom SIMtrace2 library Group: Development/Libraries/C and C++ -Requires: libosmo-simtrace2-1 = %{version} +Requires: libosmo-simtrace2-%{sover} = %{version} %description -n libosmo-simtrace2-devel Osmocom SIMtrace2 (and compatible) USB device firmware. It enables @@ -69,17 +70,18 @@ echo "%{version}" >.tarball-version autoreconf -fiv %configure --disable-static -make %{?_smp_mflags} +%make_build %install %make_install -C host install -Dm0644 host/contrib/99-simtrace2.rules %{buildroot}/%{_udevrulesdir}/99-simtrace2.rules find %{buildroot} -type f -name "*.la" -delete -print -%post -n libosmo-simtrace2-1 -p /sbin/ldconfig -%postun -n libosmo-simtrace2-1 -p /sbin/ldconfig +%post -n libosmo-simtrace2-%{sover} -p /sbin/ldconfig +%postun -n libosmo-simtrace2-%{sover} -p /sbin/ldconfig %files +%license host/COPYING %doc README.md %{_bindir}/simtrace2-cardem-pcsc %{_bindir}/simtrace2-list @@ -87,8 +89,8 @@ %{_bindir}/simtrace2-tool %{_udevrulesdir}/99-simtrace2.rules -%files -n libosmo-simtrace2-1 -%{_libdir}/libosmo-simtrace2.so.1* +%files -n libosmo-simtrace2-%{sover} +%{_libdir}/libosmo-simtrace2.so.%{sover}* %files -n libosmo-simtrace2-devel %dir %{_includedir}/osmocom/ -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I35ce3865702f72365b38b0eaa8b28f332dabcd1f Gerrit-Change-Number: 26501 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:07:32 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 10 Dec 2021 14:07:32 +0000 Subject: Change in simtrace2[master]: host/contrib/simtrace2.spec.in: update In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26501 ) Change subject: host/contrib/simtrace2.spec.in: update ...................................................................... Patch Set 1: I have verified, that this builds: https://build.opensuse.org/package/live_build_log/home:osmith42/simtrace2/CentOS_8/aarch64 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I35ce3865702f72365b38b0eaa8b28f332dabcd1f Gerrit-Change-Number: 26501 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 10 Dec 2021 14:07:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:30:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:30:14 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: sync with Nov 2021 releases In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26490 ) Change subject: OSMO_RELEASE_REPOS: sync with Nov 2021 releases ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib2022ca670b322d81ff83bbca3bb262f8d7287a6 Gerrit-Change-Number: 26490 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:30:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:30:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:30:47 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: sort In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26489 ) Change subject: OSMO_RELEASE_REPOS: sort ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3660032d020154b7a175483691842b576552ffd1 Gerrit-Change-Number: 26489 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:30:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:31:22 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:31:22 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-gsm-manuals deps In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26492 ) Change subject: debian-stretch-build-dist: osmo-gsm-manuals deps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iba2e71b2e757bc527561d0f3e4a1af5f024a3cd7 Gerrit-Change-Number: 26492 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:31:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:32:06 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:32:06 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-pcap deps In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26494 ) Change subject: debian-stretch-build-dist: osmo-pcap deps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If0f00dd09ce0db6a05972a564474a707d2d3174b Gerrit-Change-Number: 26494 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:32:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:32:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:32:26 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-remsim deps In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26495 ) Change subject: debian-stretch-build-dist: osmo-remsim deps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8fd4b9d3734dd3bc0e3fca8ceaedda2aedc6a055 Gerrit-Change-Number: 26495 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:32:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:32:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:32:34 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-uecups deps In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26496 ) Change subject: debian-stretch-build-dist: osmo-uecups deps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I19b6b0363aeeb89ab6aac2b125359589e6b9b5a7 Gerrit-Change-Number: 26496 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:32:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:33:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:33:21 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26491 ) Change subject: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib52a23a2a7d6ea64bfa539b1d026f035fdb3af57 Gerrit-Change-Number: 26491 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:33:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:33:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:33:32 +0000 Subject: Change in osmo-ci[master]: jobs/ttcn3-testsuites: add centos7 pcap-client In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26500 ) Change subject: jobs/ttcn3-testsuites: add centos7 pcap-client ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6cab8f919efd94b4d7c2664fd131f7210aac86a6 Gerrit-Change-Number: 26500 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:33:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:34:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:34:03 +0000 Subject: Change in docker-playground[master]: Add centos7 containers In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26497 ) Change subject: Add centos7 containers ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iadf3d0d7143c2d81ea5e87fd07a3f4cd9239cb46 Gerrit-Change-Number: 26497 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 14:34:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:34:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:34:56 +0000 Subject: Change in docker-playground[master]: osmo-pcap-latest: fix install path for centos In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26499 ) Change subject: osmo-pcap-latest: fix install path for centos ...................................................................... Patch Set 3: Code-Review+1 Maybe it makes more sense to actually split it in the packaging? I doubt anybody in general uses both client and server in the same host. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I775776ff7f358fee3d085f814c295c49225f5170 Gerrit-Change-Number: 26499 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:34:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:35:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:35:53 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... Patch Set 3: IIRC libosmo-netif is used inside osmo-pcap. Perhaps only to run unit tests. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:35:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:38:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:38:01 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... Patch Set 3: Code-Review+1 > Patch Set 3: > > IIRC libosmo-netif is used inside osmo-pcap. Perhaps only to run unit tests. Ah I was wrong, it's the other way around: libosmo-netif seems to have a "osmo-pcap-test" ;) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:38:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:38:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:38:12 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26435 ) Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:38:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:38:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:38:16 +0000 Subject: Change in libosmo-netif[master]: prim: Add internal CTL SAPI to negotiate SAP versions In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26435 ) Change subject: prim: Add internal CTL SAPI to negotiate SAP versions ...................................................................... prim: Add internal CTL SAPI to negotiate SAP versions This commits adds a generic mechanism for applications to validate support for SAPs and specific versions of them. A new special SAPI is introduced to manage inbound control messages for the protocol. In that SAPI a new primitive HELLO.req/.cnf is added to negotiate support for versions of any given SAP. The idea is that the client upon connecting submits a HELLO.req(SAP, VER) for each SAP it plans to use, including the version of the special CTL SAPI itself (preferrably to be checked first). Upon receiving such a message, osmo_prim_srv handles it using a special path, which ends up calling the user provided rx_sapi_version_cb(SAP, VER). In there, the user can either: * Accept the version (return same VER value) * Reject the requested version but propose another candidate version (return some positive VER value other than received VER). In this case, the client can decide whether to request another VER or close the connection. * Reject the proposed version and close the connection. Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 --- M include/osmocom/netif/prim.h M src/prim.c 2 files changed, 122 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/netif/prim.h b/include/osmocom/netif/prim.h index 4f17622..78406dd 100644 --- a/include/osmocom/netif/prim.h +++ b/include/osmocom/netif/prim.h @@ -31,6 +31,15 @@ /*! oph and related msgb is owned by srv and wll be freed after the callback returns. */ typedef int (*osmo_prim_srv_rx_cb)(struct osmo_prim_srv *prim_srv, struct osmo_prim_hdr *oph); +/*! Return value: + * RET=rem_version: Accept the version + * RET!=rem_version && RET > 0: Reject the requested version but propose another candidate version + * In this case, the client can decide whether to request another VER + * or close the connection. + * RET<0: Reject the proposed version and close the connection. + */ +typedef int (*osmo_prim_srv_rx_sapi_version)(struct osmo_prim_srv *prim_srv, uint32_t sapi, uint16_t rem_version); + struct osmo_prim_hdr *osmo_prim_msgb_alloc(unsigned int sap, unsigned int primitive, enum osmo_prim_operation operation, size_t alloc_len); @@ -43,6 +52,7 @@ void osmo_prim_srv_link_set_log_category(struct osmo_prim_srv_link *prim_link, int log_cat); void osmo_prim_srv_link_set_opened_conn_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_conn_cb opened_conn_cb); void osmo_prim_srv_link_set_closed_conn_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_conn_cb closed_conn_cb); +void osmo_prim_srv_link_set_rx_sapi_version_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_rx_sapi_version rx_sapi_version_cb); void osmo_prim_srv_link_set_rx_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_rx_cb rx_cb); void osmo_prim_srv_link_set_rx_msgb_alloc_len(struct osmo_prim_srv_link *prim_link, size_t alloc_len); int osmo_prim_srv_link_open(struct osmo_prim_srv_link *prim_link); diff --git a/src/prim.c b/src/prim.c index 6c6da6e..5189c4c 100644 --- a/src/prim.c +++ b/src/prim.c @@ -82,6 +82,7 @@ struct osmo_stream_srv_link *stream; osmo_prim_srv_conn_cb opened_conn_cb; osmo_prim_srv_conn_cb closed_conn_cb; + osmo_prim_srv_rx_sapi_version rx_sapi_version_cb; osmo_prim_srv_rx_cb rx_cb; size_t rx_msgb_alloc_len; }; @@ -93,10 +94,107 @@ }; /****************************** + * CONTROL SAP + ******************************/ +#define OSMO_PRIM_CTL_SAPI 0xffffffff +#define OSMO_PRIM_CTL_API_VERSION 0 + +enum sap_ctl_prim_type { + SAP_CTL_PRIM_HELLO, + _SAP_CTL_PRIM_MAX +}; + +const struct value_string sap_ctl_prim_type_names[] = { + OSMO_VALUE_STRING(SAP_CTL_PRIM_HELLO), + { 0, NULL } +}; + +/* HNB_CTL_PRIM_HELLO.ind, UL */ +struct sap_ctl_hello_param { + uint32_t sapi; /* SAPI for which we negotiate version */ + uint16_t api_version; /* The intended version */ +} __attribute__ ((packed)); + +struct sap_ctl_prim { + struct osmo_prim_hdr hdr; + union { + struct sap_ctl_hello_param hello_req; + struct sap_ctl_hello_param hello_cnf; + } u; +} __attribute__ ((packed)); + +static struct sap_ctl_prim *_sap_ctl_makeprim_hello_cnf(uint32_t sapi, uint16_t api_version) +{ + struct sap_ctl_prim *ctl_prim; + + ctl_prim = (struct sap_ctl_prim *)osmo_prim_msgb_alloc( + OSMO_PRIM_CTL_SAPI, SAP_CTL_PRIM_HELLO, PRIM_OP_CONFIRM, + sizeof(struct osmo_prim_hdr) + sizeof(struct sap_ctl_hello_param)); + msgb_put(ctl_prim->hdr.msg, sizeof(struct sap_ctl_hello_param)); + ctl_prim->u.hello_cnf.sapi = sapi; + ctl_prim->u.hello_cnf.api_version = api_version; + + return ctl_prim; +} + +/****************************** * osmo_prim_srv ******************************/ #define LOGSRV(srv, lvl, fmt, args...) LOGP((srv)->link->log_cat, lvl, fmt, ## args) +static int _srv_sap_ctl_rx_hello_req(struct osmo_prim_srv *prim_srv, struct sap_ctl_hello_param *hello_ind) +{ + struct sap_ctl_prim *prim_resp; + int rc; + + LOGSRV(prim_srv, LOGL_INFO, "Rx CTL-HELLO.req SAPI=%u API_VERSION=%u\n", hello_ind->sapi, hello_ind->api_version); + + if (hello_ind->sapi == OSMO_PRIM_CTL_SAPI) + rc = hello_ind->api_version == OSMO_PRIM_CTL_API_VERSION ? OSMO_PRIM_CTL_API_VERSION : -1; + else if (prim_srv->link->rx_sapi_version_cb) + rc = prim_srv->link->rx_sapi_version_cb(prim_srv, hello_ind->sapi, hello_ind->api_version); + else /* Accept whatever version by default: */ + rc = hello_ind->api_version; + + if (rc < 0) { + LOGSRV(prim_srv, LOGL_ERROR, + "SAPI=%u API_VERSION=%u not supported! destroying connection\n", + hello_ind->sapi, hello_ind->api_version); + osmo_stream_srv_set_flush_and_destroy(prim_srv->stream); + return rc; + } + prim_resp = _sap_ctl_makeprim_hello_cnf(hello_ind->sapi, (uint16_t)rc); + LOGSRV(prim_srv, LOGL_INFO, "Tx CTL-HELLO.cnf SAPI=%u API_VERSION=%u\n", + hello_ind->sapi, prim_resp->u.hello_cnf.api_version); + osmo_prim_srv_send(prim_srv, prim_resp->hdr.msg); + return rc; +} + +static int _srv_sap_ctl_rx(struct osmo_prim_srv *prim_srv, struct osmo_prim_hdr *oph) +{ + switch (oph->operation) { + case PRIM_OP_REQUEST: + switch (oph->primitive) { + case SAP_CTL_PRIM_HELLO: + return _srv_sap_ctl_rx_hello_req(prim_srv, (struct sap_ctl_hello_param *)msgb_data(oph->msg)); + default: + LOGSRV(prim_srv, LOGL_ERROR, "Rx unknown CTL SAP primitive %u (len=%u)\n", + oph->primitive, msgb_length(oph->msg)); + return -EINVAL; + } + break; + case PRIM_OP_RESPONSE: + case PRIM_OP_INDICATION: + case PRIM_OP_CONFIRM: + default: + LOGSRV(prim_srv, LOGL_ERROR, "Rx CTL SAP unexpected primitive operation %s-%s (len=%u)\n", + get_value_string(sap_ctl_prim_type_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation), + msgb_length(oph->msg)); + return -EINVAL; + } +} + static int _osmo_prim_srv_read_cb(struct osmo_stream_srv *srv) { struct osmo_prim_srv *prim_srv = osmo_stream_srv_get_data(srv); @@ -133,9 +231,15 @@ osmo_prim_init(&oph, pkth->sap, pkth->primitive, pkth->operation, msg); msgb_pull(msg, sizeof(*pkth)); - if (prim_srv->link->rx_cb) - rc = prim_srv->link->rx_cb(prim_srv, &oph); - + switch (oph.sap) { + case OSMO_PRIM_CTL_SAPI: + rc = _srv_sap_ctl_rx(prim_srv, &oph); + break; + default: + if (prim_srv->link->rx_cb) + rc = prim_srv->link->rx_cb(prim_srv, &oph); + break; + } /* as we always synchronously process the message in _osmo_prim_srv_link_rx() and * its callbacks, we can free the message here. */ msgb_free(msg); @@ -325,6 +429,11 @@ prim_link->closed_conn_cb = closed_conn_cb; } +void osmo_prim_srv_link_set_rx_sapi_version_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_rx_sapi_version rx_sapi_version_cb) +{ + prim_link->rx_sapi_version_cb = rx_sapi_version_cb; +} + void osmo_prim_srv_link_set_rx_cb(struct osmo_prim_srv_link *prim_link, osmo_prim_srv_rx_cb rx_cb) { prim_link->rx_cb = rx_cb; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26435 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0c2d92cfdb5433e3caab51d712fd947d51eeef23 Gerrit-Change-Number: 26435 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 14:39:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 14:39:02 +0000 Subject: Change in simtrace2[master]: host/contrib/simtrace2.spec.in: update In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26501 ) Change subject: host/contrib/simtrace2.spec.in: update ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I35ce3865702f72365b38b0eaa8b28f332dabcd1f Gerrit-Change-Number: 26501 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 14:39:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 15:06:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 15:06:32 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 to look at the new patch set (#10). Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Initial implementation of LowerLayer UD Socket The LLSK socket is an interface allowing thid-parties to implement and hook their RLC/MAC/RRC stack to osmo-hnodbe, which takes care of interconnection with the rest of the RAN and core network (Iuh, RTP, GTP-U, etc.). Related: SYS#5516 Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d --- A doc/hnodeb.msc M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 19 files changed, 1,076 insertions(+), 40 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/57/26357/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 10 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 15:06:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 15:06:34 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK audio SAPI References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 ) Change subject: First implementation of the LLSK audio SAPI ...................................................................... First implementation of the LLSK audio SAPI Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d --- M configure.ac M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h A include/osmocom/hnodeb/rtp.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_audio.c M src/osmo-hnodeb/main.c A src/osmo-hnodeb/rtp.c 13 files changed, 668 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/02/26502/1 diff --git a/configure.ac b/configure.ac index 8453bc4..e96a6a1 100644 --- a/configure.ac +++ b/configure.ac @@ -61,6 +61,7 @@ PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) +PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.2.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 0.8.0) diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index 62af5bb..dcb3868 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -6,6 +6,7 @@ iuh.h \ llsk.h \ ranap.h \ + rtp.h \ rua.h \ vty.h \ $(NULL) diff --git a/include/osmocom/hnodeb/hnb_prim.h b/include/osmocom/hnodeb/hnb_prim.h index a456667..8f9466d 100644 --- a/include/osmocom/hnodeb/hnb_prim.h +++ b/include/osmocom/hnodeb/hnb_prim.h @@ -31,6 +31,16 @@ #define HNB_PRIM_SAPI_GTP 2 #define HNB_PRIM_SAPI_AUDIO 3 +enum u_addr_type { + HNB_PRIM_ADDR_TYPE_UNSPEC, + HNB_PRIM_ADDR_TYPE_IPV4, + HNB_PRIM_ADDR_TYPE_IPV6 +}; +union u_addr { + struct in_addr v4; + struct in6_addr v6; +} __attribute__ ((packed)); + /*! \brief HNB_IUH primitives */ enum hnb_iuh_prim_type { HNB_IUH_PRIM_CONFIGURE, @@ -154,3 +164,62 @@ struct hnb_iuh_unitdata_ind_param unitdata_ind; } u; } __attribute__ ((packed)); + +/**************************** + * AUDIO + ***************************/ +/*! \brief HNB_AUDIO primitives */ +enum hnb_audio_prim_type { + HNB_AUDIO_PRIM_CONN_ESTABLISH, + HNB_AUDIO_PRIM_CONN_RELEASE, + HNB_AUDIO_PRIM_CONN_DATA, + _HNB_AUDIO_PRIM_MAX +}; + +/* HNB_AUDIO_PRIM_CONN_ESTABLISH, UL */ +struct hnb_audio_conn_establish_req_param { + uint32_t context_id; + uint16_t remote_rtp_port; + uint8_t spare1; + uint8_t remote_rtp_address_type; /* enum u_addr_type */ + union u_addr remote_rtp_addr; +} __attribute__ ((packed)); + +/* HNB_AUDIO_PRIM_CONN_ESTABLISH, DL */ +struct hnb_audio_conn_establish_cnf_param { + uint32_t context_id; + uint16_t local_rtp_port; + uint8_t error_code; /* 0 = success, !0 = failure */ + uint8_t local_rtp_address_type; /* enum u_addr_type */ + union u_addr local_rtp_addr; +} __attribute__ ((packed)); + +/* HNB_AUDIO_PRIM_CONN_RELEASE, UL */ +struct hnb_audio_conn_release_req_param { + uint32_t context_id; +} __attribute__ ((packed)); + +/* HNB_AUDIO_PRIM_CONN_DATA, UL */ +struct hnb_audio_conn_data_req_param { + uint32_t context_id; + uint32_t data_len; /* RTP payload length in bytes */ + char data[0]; /* RTP payload (aka IP packet) */ +} __attribute__ ((packed)); + +/* HNB_AUDIO_PRIM_CONN_DATA, DL */ +struct hnb_audio_conn_data_ind_param { + uint32_t context_id; + uint32_t data_len; /* RTP payload length in bytes */ + char data[0]; /* RTP payload (aka IP packet) */ +} __attribute__ ((packed)); + +struct hnb_audio_prim { + struct osmo_prim_hdr hdr; + union { + struct hnb_audio_conn_establish_req_param conn_establish_req; + struct hnb_audio_conn_establish_cnf_param conn_establish_cnf; + struct hnb_audio_conn_release_req_param conn_release_req; + struct hnb_audio_conn_data_req_param conn_data_req; + struct hnb_audio_conn_data_ind_param conn_data_ind; + } u; +} __attribute__ ((packed)); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index fd7d1e9..f3bf655 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -21,11 +21,13 @@ #include #include +#include #include #include #include +#include #include #include #include @@ -42,6 +44,7 @@ DRANAP, DSCTP, DLLSK, + DRTP, }; extern const struct log_info hnb_log_info; @@ -55,6 +58,9 @@ struct hnb_ue_cs_ctx { bool active; /* Is this chan in use? */ bool conn_est_cnf_pending; /* Did we send CONN_ESTABLISH_CNF to lower layers? */ + struct { + struct osmo_rtp_socket *socket; + } rtp; } conn_cs; struct hnb_ue_ps_ctx { bool active; /* Is this chan in use? */ @@ -64,6 +70,7 @@ struct hnb_ue *hnb_ue_alloc(struct hnb *hnb, uint32_t conn_id); void hnb_ue_free(struct hnb_ue *ue); void hnb_ue_reset_chan(struct hnb_ue *ue, bool is_ps); +int hnb_ue_voicecall_setup(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, struct osmo_sockaddr *loc_addr); struct hnb { char *identity; /* HNB-Identity */ @@ -86,6 +93,17 @@ uint8_t llsk_valid_sapi_mask; struct osmo_timer_list llsk_defer_configure_ind_timer; + struct { + unsigned int jitter_buf_ms; + bool jitter_adaptive; + + uint16_t port_range_start; + uint16_t port_range_end; + uint16_t port_range_next; + int ip_dscp; + int priority; + } rtp; + uint16_t rnc_id; bool registered; /* Set to true once HnbRegisterAccept was received from Iuh. rnc_id is valid iif registered==true */ @@ -104,3 +122,5 @@ extern void *tall_hnb_ctx; extern struct hnb *g_hnb; + +#define LOGUE(ue, ss, lvl, fmt, args...) LOGP(ss, lvl, "UE(%" PRIu32 ") " fmt, (ue)->conn_id, ## args) diff --git a/include/osmocom/hnodeb/llsk.h b/include/osmocom/hnodeb/llsk.h index ab39439..081ee88 100644 --- a/include/osmocom/hnodeb/llsk.h +++ b/include/osmocom/hnodeb/llsk.h @@ -22,6 +22,7 @@ #include #include +#include #include #include @@ -31,6 +32,11 @@ bool hnb_llsk_connected(const struct hnb *hnb); bool hnb_llsk_can_be_configured(struct hnb *hnb); +int ll_addr_type2af(enum u_addr_type t); +int ll_addr2osa(enum u_addr_type t, const union u_addr *uaddr, uint16_t port, struct osmo_sockaddr *osa); +enum u_addr_type osa2_ll_addr(const struct osmo_sockaddr *osa, union u_addr *uaddr, uint16_t *port); + + extern const struct value_string hnb_iuh_prim_type_names[]; int llsk_rx_iuh(struct hnb *hnb, struct osmo_prim_hdr *oph); @@ -42,3 +48,11 @@ const uint8_t *data, uint32_t data_len); struct hnb_iuh_prim *hnb_iuh_makeprim_unitdata_ind(const uint8_t *data, uint32_t data_len); + + +extern const struct value_string hnb_audio_prim_type_names[]; +int llsk_rx_audio(struct hnb *hnb, struct osmo_prim_hdr *oph); +struct hnb_audio_prim *hnb_audio_makeprim_conn_data_ind(uint32_t context_id, + uint8_t domain, + const uint8_t *data, + uint32_t data_len); diff --git a/include/osmocom/hnodeb/rtp.h b/include/osmocom/hnodeb/rtp.h new file mode 100644 index 0000000..a3714fd --- /dev/null +++ b/include/osmocom/hnodeb/rtp.h @@ -0,0 +1,32 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include +#include + +struct hnb; + +int rtp_get_bound_addr(struct osmo_rtp_socket *rs, struct osmo_sockaddr *osa); + +int rtp_bind(struct hnb *hnb, struct osmo_rtp_socket *rs, const char *ip); + +void rtp_rx_cb(struct osmo_rtp_socket *rs, const uint8_t *rtp_pl, + unsigned int rtp_pl_len, uint16_t seq_number, + uint32_t timestamp, bool marker); diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index b6d2d49..4182814 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -14,6 +14,7 @@ $(LIBOSMONETIF_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ + $(LIBOSMOTRAU_CFLAGS) \ $(LIBOSMOSIGTRAN_CFLAGS) \ $(LIBOSMORUA_CFLAGS) \ $(LIBOSMORANAP_CFLAGS) \ @@ -36,8 +37,10 @@ hnb_shutdown_fsm.c \ iuh.c \ llsk.c \ + llsk_audio.c \ llsk_iuh.c \ ranap.c \ + rtp.c \ rua.c \ vty.c \ $(NULL) @@ -51,6 +54,7 @@ $(LIBOSMONETIF_LIBS) \ $(COVERAGE_LDFLAGS) \ $(LIBOSMOABIS_LIBS) \ + $(LIBOSMOTRAU_LIBS) \ $(LIBOSMOSIGTRAN_LIBS) \ $(LIBOSMORUA_LIBS) \ $(LIBOSMORANAP_LIBS) \ diff --git a/src/osmo-hnodeb/debug.c b/src/osmo-hnodeb/debug.c index f34851b..5d0dabd 100644 --- a/src/osmo-hnodeb/debug.c +++ b/src/osmo-hnodeb/debug.c @@ -52,6 +52,11 @@ .color = "\033[1;31m", .description = "Lower Layer Unix Domain Socket", }, + [DRTP] = { + .name = "DRTP", .loglevel = LOGL_NOTICE, .enabled = 1, + .color = "\033[1;32m", + .description = "RTP Core Network side", + }, }; const struct log_info hnb_log_info = { diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 1ac2efc..f8878bd 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -20,6 +20,8 @@ #include "config.h" +#include + #include #include #include @@ -29,6 +31,7 @@ #include #include #include +#include struct hnb *hnb_alloc(void *tall_ctx) @@ -46,6 +49,14 @@ .mcc = 1, .mnc = 1, }; + + hnb->rtp.jitter_adaptive = false; + hnb->rtp.port_range_start = 16384; + hnb->rtp.port_range_end = 17407; + hnb->rtp.port_range_next = hnb->rtp.port_range_start; + hnb->rtp.ip_dscp = -1; + hnb->rtp.priority = -1; + hnb->shutdown_fi = osmo_fsm_inst_alloc(&hnb_shutdown_fsm, hnb, hnb, LOGL_INFO, NULL); @@ -94,16 +105,87 @@ void hnb_ue_free(struct hnb_ue *ue) { + hnb_ue_reset_chan(ue, true); + hnb_ue_reset_chan(ue, false); llist_del(&ue->list); talloc_free(ue); } void hnb_ue_reset_chan(struct hnb_ue *ue, bool is_ps) { - if (is_ps) + if (is_ps) { ue->conn_ps = (struct hnb_ue_ps_ctx){0}; - else + } else { + if (ue->conn_cs.rtp.socket) + osmo_rtp_socket_free(ue->conn_cs.rtp.socket); ue->conn_cs = (struct hnb_ue_cs_ctx){0}; + } +} + +int hnb_ue_voicecall_setup(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, struct osmo_sockaddr *loc_addr) +{ + int rc; + char cname[256+4]; + char name[32]; + struct osmo_rtp_socket *rs; + const char *local_wildcard_ipstr = "0.0.0.0"; + char remote_ipstr[INET6_ADDRSTRLEN]; + uint16_t remote_port; + struct hnb *hnb = ue->hnb; + + if (osmo_sockaddr_to_str_and_uint(remote_ipstr, sizeof(remote_ipstr), &remote_port, &rem_addr->u.sa) == 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Failed parsing remote address!\n"); + return -EINVAL; + } + + if (ue->conn_cs.rtp.socket) { + LOGUE(ue, DRTP, LOGL_ERROR, "Setting up rtp socket but it already exists!\n"); + return -EINVAL; + } + + rs = ue->conn_cs.rtp.socket = osmo_rtp_socket_create(ue, OSMO_RTP_F_POLL); + rc = osmo_rtp_socket_set_param(rs, + hnb->rtp.jitter_adaptive ? + OSMO_RTP_P_JIT_ADAP : + OSMO_RTP_P_JITBUF, + hnb->rtp.jitter_buf_ms); + if (rc < 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Failed to set RTP socket parameters: %s\n", strerror(-rc)); + goto free_ret; + } + rs->priv = ue; + rs->rx_cb = &rtp_rx_cb; + + rc = rtp_bind(hnb, rs, local_wildcard_ipstr); + if (rc < 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Failed to bind RTP/RTCP sockets\n"); + goto free_ret; + } + + /* Ensure RTCP SDES contains some useful information */ + snprintf(cname, sizeof(cname), "hnb@%s", local_wildcard_ipstr); + snprintf(name, sizeof(name), "ue@%u", ue->conn_id); + osmo_rtp_set_source_desc(rs, cname, name, NULL, NULL, NULL, + "OsmoHNodeB-" PACKAGE_VERSION, NULL); + + + rc = osmo_rtp_socket_connect(rs, remote_ipstr, remote_port); + if (rc < 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Failed to connect RTP/RTCP sockets\n"); + goto free_ret; + } + + rc = rtp_get_bound_addr(rs, loc_addr); + if (rc < 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Cannot obtain locally bound IP/port: %d\n", rc); + goto free_ret; + } + + return rc; +free_ret: + osmo_rtp_socket_free(ue->conn_cs.rtp.socket); + ue->conn_cs.rtp.socket = NULL; + return rc; } struct hnb_ue *hnb_find_ue_by_id(const struct hnb *hnb, uint32_t conn_id) diff --git a/src/osmo-hnodeb/llsk.c b/src/osmo-hnodeb/llsk.c index 5f0f9dc..121a3a8 100644 --- a/src/osmo-hnodeb/llsk.c +++ b/src/osmo-hnodeb/llsk.c @@ -18,6 +18,9 @@ */ #include +#include +#include +#include #include #include @@ -27,6 +30,58 @@ #include #include +int ll_addr_type2af(enum u_addr_type t) +{ + switch (t) { + case HNB_PRIM_ADDR_TYPE_IPV4: + return AF_INET; + case HNB_PRIM_ADDR_TYPE_IPV6: + return AF_INET6; + default: + LOGP(DLLSK, LOGL_ERROR, "Rx Unknwon address type %u\n", (unsigned)t); + return -1; + } +} + +int ll_addr2osa(enum u_addr_type t, const union u_addr *uaddr, uint16_t port, struct osmo_sockaddr *osa) +{ + int af = ll_addr_type2af(t); + + osa->u.sa.sa_family = af; + + switch (af) { + case AF_INET6: + memcpy(&osa->u.sin6.sin6_addr, &uaddr->v6, sizeof(osa->u.sin6.sin6_addr)); + osa->u.sin6.sin6_port = htons(port); + break; + case AF_INET: + memcpy(&osa->u.sin.sin_addr, &uaddr->v4, sizeof(osa->u.sin.sin_addr)); + osa->u.sin.sin_port = htons(port); + break; + default: + return -1; + } + return 0; +} + +enum u_addr_type osa2_ll_addr(const struct osmo_sockaddr *osa, union u_addr *uaddr, uint16_t *port) +{ + switch (osa->u.sa.sa_family) { + case AF_INET: + memcpy(&uaddr->v6, &osa->u.sin6.sin6_addr, sizeof(osa->u.sin6.sin6_addr)); + if (port) + *port = ntohs(osa->u.sin6.sin6_port); + return HNB_PRIM_ADDR_TYPE_IPV4; + case AF_INET6: + memcpy(&uaddr->v4, &osa->u.sin.sin_addr, sizeof(osa->u.sin.sin_addr)); + if (port) + *port = ntohs(osa->u.sin.sin_port); + return HNB_PRIM_ADDR_TYPE_IPV6; + default: + return HNB_PRIM_ADDR_TYPE_UNSPEC; + } +} + static int llsk_opened_cb(struct osmo_prim_srv *srv) { struct hnb *hnb = (struct hnb *)osmo_prim_srv_get_priv(srv); @@ -73,7 +128,8 @@ if (!hnb->llsk) return false; - if (hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_IUH)) + if (hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_IUH) && + hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_AUDIO)) return true; return false; } @@ -108,10 +164,11 @@ case HNB_PRIM_SAPI_IUH: return llsk_rx_iuh(hnb, oph); case HNB_PRIM_SAPI_GTP: - case HNB_PRIM_SAPI_AUDIO: LOGP(DLLSK, LOGL_ERROR, "Rx SAPI %u not yet implemented (len=%u)\n", oph->sap, msgb_length(oph->msg)); return -EINVAL; + case HNB_PRIM_SAPI_AUDIO: + return llsk_rx_audio(hnb, oph); default: LOGP(DLLSK, LOGL_ERROR, "Rx for unknwon SAPI %u (len=%u)\n", oph->sap, msgb_length(oph->msg)); diff --git a/src/osmo-hnodeb/llsk_audio.c b/src/osmo-hnodeb/llsk_audio.c new file mode 100644 index 0000000..bf4b891 --- /dev/null +++ b/src/osmo-hnodeb/llsk_audio.c @@ -0,0 +1,275 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +#include +#include +#include + +static size_t llsk_audio_prim_size_tbl[4][_HNB_AUDIO_PRIM_MAX] = { + [PRIM_OP_REQUEST] = { + [HNB_AUDIO_PRIM_CONN_ESTABLISH] = sizeof(struct hnb_audio_conn_establish_req_param), + [HNB_AUDIO_PRIM_CONN_RELEASE] = sizeof(struct hnb_audio_conn_release_req_param), + [HNB_AUDIO_PRIM_CONN_DATA] = sizeof(struct hnb_audio_conn_data_req_param), + }, + [PRIM_OP_RESPONSE] = {}, + [PRIM_OP_INDICATION] = { + [HNB_AUDIO_PRIM_CONN_DATA] = sizeof(struct hnb_audio_conn_data_ind_param), + }, + [PRIM_OP_CONFIRM] = { + [HNB_AUDIO_PRIM_CONN_ESTABLISH] = sizeof(struct hnb_audio_conn_establish_cnf_param), + }, +}; +static inline size_t llsk_audio_prim_size(enum hnb_audio_prim_type ptype, enum osmo_prim_operation op) +{ + size_t val = llsk_audio_prim_size_tbl[op][ptype]; + if (val == 0) { + LOGP(DLLSK, LOGL_FATAL, "Expected prim_size != 0 for ptype=%u op=%u\n", ptype, op); + osmo_panic("Expected prim_size != 0 for ptype=%u op=%u\n", ptype, op); + } + return val; +} + +const struct value_string hnb_audio_prim_type_names[] = { + OSMO_VALUE_STRING(HNB_AUDIO_PRIM_CONN_ESTABLISH), + OSMO_VALUE_STRING(HNB_AUDIO_PRIM_CONN_RELEASE), + OSMO_VALUE_STRING(HNB_AUDIO_PRIM_CONN_DATA), + { 0, NULL } +}; + +static struct hnb_audio_prim *hnb_audio_prim_alloc(enum hnb_audio_prim_type ptype, enum osmo_prim_operation op, size_t extra_len) +{ + struct osmo_prim_hdr *oph; + size_t len = llsk_audio_prim_size(ptype, op); + + oph = osmo_prim_msgb_alloc(HNB_PRIM_SAPI_AUDIO, ptype, op, sizeof(*oph) + len + extra_len); + if (!oph) + return NULL; + msgb_put(oph->msg, len); + + return (struct hnb_audio_prim *)oph; +} + +static struct hnb_audio_prim *hnb_audio_makeprim_conn_establish_cnf(uint32_t context_id, uint8_t error_code, + uint16_t local_rtp_port, uint8_t local_rtp_address_type, + const union u_addr *local_rtp_addr) +{ + struct hnb_audio_prim *audio_prim; + + audio_prim = hnb_audio_prim_alloc(HNB_AUDIO_PRIM_CONN_ESTABLISH, PRIM_OP_CONFIRM, 0); + audio_prim->u.conn_establish_cnf.context_id = context_id; + audio_prim->u.conn_establish_cnf.local_rtp_port = local_rtp_port; + audio_prim->u.conn_establish_cnf.error_code = error_code; + audio_prim->u.conn_establish_cnf.local_rtp_address_type = local_rtp_address_type; + if (local_rtp_addr) + audio_prim->u.conn_establish_cnf.local_rtp_addr = *local_rtp_addr; + + return audio_prim; +} + +struct hnb_audio_prim *hnb_audio_makeprim_conn_data_ind(uint32_t context_id, + uint8_t domain, + const uint8_t *data, + uint32_t data_len) +{ + struct hnb_audio_prim *audio_prim; + + audio_prim = hnb_audio_prim_alloc(HNB_AUDIO_PRIM_CONN_DATA, PRIM_OP_INDICATION, data_len); + audio_prim->u.conn_data_ind.context_id = context_id; + audio_prim->u.conn_data_ind.data_len = data_len; + if (data_len) { + msgb_put(audio_prim->hdr.msg, data_len); + memcpy(audio_prim->u.conn_data_ind.data, data, data_len); + } + + return audio_prim; +} + +static int _send_conn_establish_cnf_failed(struct hnb *hnb, uint32_t context_id, uint8_t error_code) +{ + struct hnb_audio_prim *audio_prim; + int rc; + LOGP(DLLSK, LOGL_ERROR, "Tx AUDIO-CONN_ESTABLISH.cnf: ctx=%u error_code=%u\n", + context_id, error_code); + audio_prim = hnb_audio_makeprim_conn_establish_cnf(context_id, error_code, 0, HNB_PRIM_ADDR_TYPE_UNSPEC, NULL); + if ((rc = osmo_prim_srv_send(hnb->llsk, audio_prim->hdr.msg)) < 0) { + LOGP(DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_ESTABLISH.cnf context_id=%u error_code=%u\n", + context_id, error_code); + } + return rc; +} + +static int llsk_rx_audio_conn_establish_req(struct hnb *hnb, struct hnb_audio_conn_establish_req_param *ce_req) +{ + struct hnb_ue *ue; + int rc = 0; + struct hnb_audio_prim *audio_prim; + int af; + char rem_addrstr[INET6_ADDRSTRLEN+32]; + struct osmo_sockaddr rem_osa = {0}; + struct osmo_sockaddr loc_osa = {0}; + union u_addr loc_uaddr = {0}; + uint16_t loc_port; + + rc = ll_addr2osa(ce_req->remote_rtp_address_type, &ce_req->remote_rtp_addr, ce_req->remote_rtp_port, &rem_osa); + if (rc < 0) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: ctx=%u with unexpected address type %u\n", + ce_req->context_id, ce_req->remote_rtp_address_type); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 1); + } + osmo_sockaddr_to_str_buf(rem_addrstr, sizeof(rem_addrstr), &rem_osa); + + LOGP(DLLSK, LOGL_INFO, "Rx AUDIO-CONN_ESTABLISH.req ctx=%u rem_addr=%s\n", + ce_req->context_id, rem_addrstr); + + if ((af = ll_addr_type2af(ce_req->remote_rtp_address_type)) < 0) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: ctx=%u with unexpected address type %u\n", + ce_req->context_id, ce_req->remote_rtp_address_type); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 1); + } + + ue = hnb_find_ue_by_id(hnb, ce_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: UE not found! ctx=%u rem_addr=%s\n", + ce_req->context_id, rem_addrstr); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 2); + } + if (!ue->conn_cs.active) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: CS chan not active! ctx=%u rem_addr=%s\n", + ce_req->context_id, rem_addrstr); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 3); + } + + /* Create the socket: */ + if ((rc = hnb_ue_voicecall_setup(ue, &rem_osa, &loc_osa)) < 0) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: Failed to set up audio socket ctx=%u rem_addr=%s\n", + ce_req->context_id, rem_addrstr); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); + } + + /* Convert resulting local address back to LLSK format: */ + if (osa2_ll_addr(&loc_osa, &loc_uaddr, &loc_port) != ce_req->remote_rtp_address_type) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: Failed to provide proper local address ctx=%u rem_addr=%s\n", + ce_req->context_id, rem_addrstr); + rc = _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); + goto release_sock; + } + + /* Submit successful confirmation */ + LOGP(DLLSK, LOGL_INFO, "Tx AUDIO-CONN_ESTABLISH.cnf: ctx=%u error_code=0 rem_addr=%s loc_addr=%s\n", + ce_req->context_id, rem_addrstr, osmo_sockaddr_to_str(&loc_osa)); + audio_prim = hnb_audio_makeprim_conn_establish_cnf(ce_req->context_id, 0, loc_port, ce_req->remote_rtp_address_type, &loc_uaddr); + if ((rc = osmo_prim_srv_send(hnb->llsk, audio_prim->hdr.msg)) < 0) { + LOGP(DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_ESTABLISH.cnf context_id=%u error_code=0\n", + ce_req->context_id); + goto release_sock; + } + + return rc; +release_sock: /* TODO: release socket here */ + return rc; +} + +static int llsk_rx_audio_conn_release_req(struct hnb *hnb, struct hnb_audio_conn_release_req_param *rel_req) +{ + struct hnb_ue *ue; + int rc = 0; + + LOGP(DLLSK, LOGL_DEBUG, "Rx AUDIO-CONN_RELEASE.req ctx=%u\n", rel_req->context_id); + + ue = hnb_find_ue_by_id(hnb, rel_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_RELEASE.req: UE not found! ctx=%u\n", + rel_req->context_id); + return -EINVAL; + } + /* TODO: release RTP socket */ + return rc; +} + +static int llsk_rx_audio_conn_data_req(struct hnb *hnb, struct hnb_audio_conn_data_req_param *data_req) +{ + struct hnb_ue *ue; + int rc = 0; + + LOGP(DLLSK, LOGL_DEBUG, "Rx AUDIO-CONN_DATA.req ctx=%u data_len=%u\n", + data_req->context_id, data_req->data_len); + + ue = hnb_find_ue_by_id(hnb, data_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_DATA.req: UE not found! ctx=%u data_len=%u\n", + data_req->context_id, data_req->data_len); + return -EINVAL; + } + + /* TODO: transmit data_req->data through RTP/Iu-UP socket */ + return rc; +} + +int llsk_rx_audio(struct hnb *hnb, struct osmo_prim_hdr *oph) +{ + size_t prim_size = llsk_audio_prim_size(oph->primitive, oph->operation); + + if (msgb_length(oph->msg) < prim_size) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-%s.%s with length %u < %zu\n", + get_value_string(hnb_audio_prim_type_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation), + msgb_length(oph->msg), prim_size); + return -EINVAL; + } + + switch (oph->operation) { + case PRIM_OP_REQUEST: + switch (oph->primitive) { + case HNB_AUDIO_PRIM_CONN_ESTABLISH: + return llsk_rx_audio_conn_establish_req(hnb, (struct hnb_audio_conn_establish_req_param *)msgb_data(oph->msg)); + case HNB_AUDIO_PRIM_CONN_RELEASE: + return llsk_rx_audio_conn_release_req(hnb, (struct hnb_audio_conn_release_req_param *)msgb_data(oph->msg)); + case HNB_AUDIO_PRIM_CONN_DATA: + return llsk_rx_audio_conn_data_req(hnb, (struct hnb_audio_conn_data_req_param *)msgb_data(oph->msg)); + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-audio unknown primitive %u (len=%u)\n", + oph->primitive, msgb_length(oph->msg)); + return -EINVAL; + } + break; + + case PRIM_OP_RESPONSE: + case PRIM_OP_INDICATION: + case PRIM_OP_CONFIRM: + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-audio unexpected primitive operation %s::%s (len=%u)\n", + get_value_string(hnb_audio_prim_type_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation), + msgb_length(oph->msg)); + return -EINVAL; + } +} diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 6728a07..9af83ea 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -41,6 +41,8 @@ #include #include +#include + #include /* ranap_set_log_area() */ #include @@ -224,6 +226,7 @@ int main(int argc, char **argv) { int rc; + void *tall_rtp_ctx; /* Track the use of talloc NULL memory contexts */ talloc_enable_null_tracking(); @@ -246,6 +249,11 @@ osmo_talloc_vty_add_cmds(); osmo_cpu_sched_vty_init(tall_hnb_ctx); + /* allocate a talloc pool for ORTP to ensure it doesn't have to go back + * to the libc malloc all the time */ + tall_rtp_ctx = talloc_pool(tall_hnb_ctx, 262144); + osmo_rtp_init(tall_rtp_ctx); + g_hnb = hnb_alloc(tall_hnb_ctx); hnb_vty_init(); diff --git a/src/osmo-hnodeb/rtp.c b/src/osmo-hnodeb/rtp.c new file mode 100644 index 0000000..076cab8 --- /dev/null +++ b/src/osmo-hnodeb/rtp.c @@ -0,0 +1,96 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include + +#include +#include + + +/* Mixture between osmo_rtp_get_bound_addr and osmo_rtp_get_bound_ip_port using osmo_sockaddr */ +int rtp_get_bound_addr(struct osmo_rtp_socket *rs, struct osmo_sockaddr *osa) +{ + int rc; + //uint16_t port; + socklen_t alen = sizeof(*osa); + + rc = getsockname(rs->rtp_bfd.fd, (struct sockaddr *)&osa->u.sa, &alen); + if (rc < 0) + return rc; + + /* Is this really needed? or getsockname already gathers the port? */ + /*port = rtp_session_get_local_port(rs->sess); + switch (osa->u.sa.sa_family) { + case AF_INET6: + osa->u.sin6.sin6_port = htons(port); + case AF_INET: + osa->u.sin.sin_port = htons(port); + default: + return -1; + }*/ + + return 0; +} + +int rtp_bind(struct hnb *hnb, struct osmo_rtp_socket *rs, const char *ip) +{ + int rc; + unsigned int i; + unsigned int tries; + + tries = (hnb->rtp.port_range_end - hnb->rtp.port_range_start) / 2; + for (i = 0; i < tries; i++) { + + if (hnb->rtp.port_range_next >= hnb->rtp.port_range_end) + hnb->rtp.port_range_next = hnb->rtp.port_range_start; + + rc = osmo_rtp_socket_bind(rs, ip, hnb->rtp.port_range_next); + + hnb->rtp.port_range_next += 2; + + if (rc != 0) + continue; + + if (hnb->rtp.ip_dscp != -1) { + if (osmo_rtp_socket_set_dscp(rs, hnb->rtp.ip_dscp)) + LOGP(DRTP, LOGL_ERROR, "failed to set DSCP=%i: %s\n", + hnb->rtp.ip_dscp, strerror(errno)); + } + if (hnb->rtp.priority != -1) { + if (osmo_rtp_socket_set_priority(rs, hnb->rtp.priority)) + LOGP(DRTP, LOGL_ERROR, "failed to set socket priority %d: %s\n", + hnb->rtp.priority, strerror(errno)); + } + return 0; + } + + return -1; +} + + + + + +void rtp_rx_cb(struct osmo_rtp_socket *rs, const uint8_t *rtp_pl, + unsigned int rtp_pl_len, uint16_t seq_number, + uint32_t timestamp, bool marker) +{ + LOGP(DRTP, LOGL_DEBUG, "Rx RTP cb\n"); +} -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d Gerrit-Change-Number: 26502 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 15:06:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 15:06:34 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 ) Change subject: First implementation of the LLSK gtp SAPI ...................................................................... First implementation of the LLSK gtp SAPI Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 --- M configure.ac M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/gtp.h M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c A src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_gtp.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/vty.c 15 files changed, 722 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/03/26503/1 diff --git a/configure.ac b/configure.ac index e96a6a1..8a34b82 100644 --- a/configure.ac +++ b/configure.ac @@ -67,6 +67,7 @@ PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 0.8.0) PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.8.0) PKG_CHECK_MODULES(LIBOSMOHNBAP, libosmo-hnbap >= 0.8.0) +PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.8.0) dnl checks for header files diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index dcb3868..381cff9 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -1,4 +1,5 @@ noinst_HEADERS = \ + gtp.h \ hnb_shutdown_fsm.h \ hnb_prim.h \ hnbap.h \ diff --git a/include/osmocom/hnodeb/gtp.h b/include/osmocom/hnodeb/gtp.h new file mode 100644 index 0000000..8af69c8 --- /dev/null +++ b/include/osmocom/hnodeb/gtp.h @@ -0,0 +1,32 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include + +struct hnb; +struct hnb_ue; + +int hnb_gtp_bind(struct hnb *hnb); +void hnb_gtp_unbind(struct hnb *hnb); + +int hnb_ue_gtp_bind(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei, + struct osmo_sockaddr *loc_addr, uint32_t *loc_tei); + +int hnb_ue_gtp_tx(struct hnb_ue *ue, void *gtpu_payload, unsigned gtpu_payload_len); diff --git a/include/osmocom/hnodeb/hnb_prim.h b/include/osmocom/hnodeb/hnb_prim.h index 8f9466d..fbcd07a 100644 --- a/include/osmocom/hnodeb/hnb_prim.h +++ b/include/osmocom/hnodeb/hnb_prim.h @@ -223,3 +223,71 @@ struct hnb_audio_conn_data_ind_param conn_data_ind; } u; } __attribute__ ((packed)); + +/**************************** + * GTP + ***************************/ +/*! \brief HNB_GTP primitives */ +enum hnb_gtp_prim_type { + HNB_GTP_PRIM_CONN_ESTABLISH, + HNB_GTP_PRIM_CONN_RELEASE, + HNB_GTP_PRIM_CONN_DATA, + _HNB_GTP_PRIM_MAX +}; + +/* HNB_GTP_PRIM_CONN_ESTABLISH, UL */ +struct hnb_gtp_conn_establish_req_param { + uint32_t context_id; + uint32_t remote_tei; + uint8_t spare1; + uint8_t remote_gtpu_address_type; + union u_addr remote_gtpu_addr; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_ESTABLISH, DL */ +struct hnb_gtp_conn_establish_cnf_param { + uint32_t context_id; + uint32_t local_tei; + uint8_t error_code; /* 0 = success, !0 = failure */ + uint8_t local_gtpu_address_type; /* enum u_addr_type */ + union u_addr local_gtpu_addr; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_RELEASE, UL */ +struct hnb_gtp_conn_release_req_param { + uint32_t context_id; + uint32_t remote_tei; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_RELEASE, DL */ +struct hnb_gtp_conn_release_ind_param { + uint32_t context_id; + uint32_t local_tei; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_DATA, DL */ +struct hnb_gtp_conn_data_ind_param { + uint32_t context_id; + uint32_t local_tei; + uint32_t data_len; /* GTP-U payload length in bytes */ + char data[0]; /* GTP-U payload (aka IP packet) */ +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_DATA, UL */ +struct hnb_gtp_conn_data_req_param { + uint32_t context_id; + uint32_t remote_tei; + uint32_t data_len; /* GTP-U payload length in bytes */ + char data[0]; /* GTP-U payload (aka IP packet) */ +} __attribute__ ((packed)); + +struct hnb_gtp_prim { + struct osmo_prim_hdr hdr; + union { + struct hnb_gtp_conn_establish_req_param conn_establish_req; + struct hnb_gtp_conn_establish_cnf_param conn_establish_cnf; + struct hnb_gtp_conn_release_req_param conn_release_req; + struct hnb_gtp_conn_data_req_param conn_data_req; + struct hnb_gtp_conn_data_ind_param conn_data_ind; + } u; +} __attribute__ ((packed)); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index f3bf655..1dd1027 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -35,6 +35,9 @@ #include #include +#include +#include + #include enum { @@ -45,6 +48,7 @@ DSCTP, DLLSK, DRTP, + DGTP, }; extern const struct log_info hnb_log_info; @@ -65,6 +69,9 @@ struct hnb_ue_ps_ctx { bool active; /* Is this chan in use? */ bool conn_est_cnf_pending; /* Did we send CONN_ESTABLISH_CNF to lower layers? */ + uint32_t local_tei; + uint32_t remote_tei; + struct pdp_t *pdp_lib; } conn_ps; }; struct hnb_ue *hnb_ue_alloc(struct hnb *hnb, uint32_t conn_id); @@ -72,6 +79,7 @@ void hnb_ue_reset_chan(struct hnb_ue *ue, bool is_ps); int hnb_ue_voicecall_setup(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, struct osmo_sockaddr *loc_addr); + struct hnb { char *identity; /* HNB-Identity */ struct osmo_plmn_id plmn; @@ -104,6 +112,15 @@ int priority; } rtp; + struct gtp { + char *cfg_local_addr; + struct osmo_sockaddr local_addr; + struct gsn_t *gsn; + struct osmo_fd fd0; + struct osmo_fd fd1c; + struct osmo_fd fd1u; + } gtp; + uint16_t rnc_id; bool registered; /* Set to true once HnbRegisterAccept was received from Iuh. rnc_id is valid iif registered==true */ @@ -118,6 +135,7 @@ struct hnb *hnb_alloc(void *tall_ctx); void hnb_free(struct hnb *hnb); struct hnb_ue *hnb_find_ue_by_id(const struct hnb *hnb, uint32_t conn_id); +struct hnb_ue *hnb_find_ue_by_tei(const struct hnb *hnb, uint32_t tei, bool is_remote); struct hnb_ue *hnb_find_ue_by_imsi(const struct hnb *hnb, char *imsi); extern void *tall_hnb_ctx; diff --git a/include/osmocom/hnodeb/llsk.h b/include/osmocom/hnodeb/llsk.h index 081ee88..a6d8a57 100644 --- a/include/osmocom/hnodeb/llsk.h +++ b/include/osmocom/hnodeb/llsk.h @@ -56,3 +56,8 @@ uint8_t domain, const uint8_t *data, uint32_t data_len); + +extern const struct value_string hnb_gtp_prim_type_names[]; +int llsk_rx_gtp(struct hnb *hnb, struct osmo_prim_hdr *oph); +struct hnb_gtp_prim *hnb_gtp_makeprim_conn_data_ind(uint32_t context_id, uint32_t local_tei, + const uint8_t *data, uint32_t data_len); diff --git a/include/osmocom/hnodeb/vty.h b/include/osmocom/hnodeb/vty.h index 627436d..5c11302 100644 --- a/include/osmocom/hnodeb/vty.h +++ b/include/osmocom/hnodeb/vty.h @@ -28,6 +28,7 @@ HNODEB_NODE = _LAST_OSMOVTY_NODE, IUH_NODE, LLSK_NODE, + GTP_NODE, }; void hnb_vty_init(void); diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 4182814..6edbf88 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -19,6 +19,7 @@ $(LIBOSMORUA_CFLAGS) \ $(LIBOSMORANAP_CFLAGS) \ $(LIBOSMOHNBAP_CFLAGS) \ + $(LIBGTP_CFLAGS) \ $(NULL) AM_LDFLAGS = \ @@ -32,12 +33,14 @@ osmo_hnodeb_SOURCES = \ main.c \ debug.c \ + gtp.c \ hnbap.c \ hnb.c \ hnb_shutdown_fsm.c \ iuh.c \ llsk.c \ llsk_audio.c \ + llsk_gtp.c \ llsk_iuh.c \ ranap.c \ rtp.c \ @@ -60,4 +63,5 @@ $(LIBOSMORANAP_LIBS) \ $(LIBOSMOHNBAP_LIBS) \ $(LIBSCTP_LIBS) \ + $(LIBGTP_LIBS) \ $(NULL) diff --git a/src/osmo-hnodeb/debug.c b/src/osmo-hnodeb/debug.c index 5d0dabd..f122b86 100644 --- a/src/osmo-hnodeb/debug.c +++ b/src/osmo-hnodeb/debug.c @@ -57,6 +57,11 @@ .color = "\033[1;32m", .description = "RTP Core Network side", }, + [DRTP] = { + .name = "DRTP", .loglevel = LOGL_NOTICE, .enabled = 1, + .color = "\033[1;30m", + .description = "GPRS Tunnelling Protocol", + }, }; const struct log_info hnb_log_info = { diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c new file mode 100644 index 0000000..ef7b3f8 --- /dev/null +++ b/src/osmo-hnodeb/gtp.c @@ -0,0 +1,233 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include + +#include +#include +#include + +#include +#include + +/* Get osa of locally bound GTP-U socket */ +int sk_get_bound_addr(int fd, struct osmo_sockaddr *osa) +{ + int rc; + //uint16_t port; + socklen_t alen = sizeof(*osa); + + rc = getsockname(fd, (struct sockaddr *)&osa->u.sa, &alen); + if (rc < 0) + return rc; + + /* Is this really needed? or getsockname already gathers the port? */ + /*port = rtp_session_get_local_port(rs->sess); + switch (osa->u.sa.sa_family) { + case AF_INET6: + osa->u.sin6.sin6_port = htons(port); + case AF_INET: + osa->u.sin.sin_port = htons(port); + default: + return -1; + }*/ + + return 0; +} + +/* Called whenever we receive a DATA packet */ +static int hnb_gtp_cb_data_ind(struct pdp_t *lib, void *packet, unsigned int len) +{ + struct hnb_gtp_prim *gtp_prim; + struct hnb_ue *ue = lib->priv; + struct hnb *hnb = ue->hnb; + int rc; + + LOGUE(ue, DGTP, LOGL_DEBUG, "Rx GTP-U packet %p len=%u\n", packet, len); + + if (!ue || !ue->conn_ps.active) { + LOGUE(ue, DGTP, LOGL_NOTICE, "Rx GTP-U packet %p len=%u but UE conn_ps is not active!\n", packet, len); + return -EINVAL; + } + + LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.req data=%p len=%u\n", packet, len); + gtp_prim = hnb_gtp_makeprim_conn_data_ind(ue->conn_id, ue->conn_ps.local_tei, packet, len); + if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { + LOGUE(ue, DGTP, LOGL_ERROR, "Failed Tx GTP-CONN_DATA.req data=%p len=%u\n", + packet, len); + } + return rc; +} + +/* libgtp select loop integration */ +static int hnb_gtp_fd_cb(struct osmo_fd *fd, unsigned int what) +{ + struct hnb *hnb = fd->data; + int rc; + + if (!(what & OSMO_FD_READ)) + return 0; + + switch (fd->priv_nr) { + case 0: + rc = gtp_decaps0(hnb->gtp.gsn); + break; + case 1: + rc = gtp_decaps1c(hnb->gtp.gsn); + break; + case 2: + rc = gtp_decaps1u(hnb->gtp.gsn); + break; + default: + rc = -EINVAL; + break; + } + return rc; +} + +int hnb_gtp_bind(struct hnb *hnb) +{ + int rc; + struct gsn_t *gsn; + struct in_addr inaddr; + + rc = inet_pton(AF_INET, hnb->gtp.cfg_local_addr, &inaddr); + if (rc <= 0) + return -EINVAL; + + /* TODO: add new mode GTP_MODE_GTPU_ONLY to set up gtpu side only (and ignore statedir) */ + rc = gtp_new(&gsn, "/tmp", &inaddr, GTP_MODE_SGSN); + if (rc < 0) { + LOGP(DGTP, LOGL_ERROR, "Failed to set up GTP socket: %s\n", strerror(-rc)); + return rc; + } + + rc = sk_get_bound_addr(gsn->fd1u, &hnb->gtp.local_addr); + if (rc < 0) { + LOGP(DGTP, LOGL_ERROR, "Failed to get GTP-U socket bound address: %s\n", strerror(-rc)); + return rc; + } + + osmo_fd_setup(&hnb->gtp.fd0, gsn->fd0, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0); + if ((rc = osmo_fd_register(&hnb->gtp.fd0)) < 0) + goto free_ret; + + osmo_fd_setup(&hnb->gtp.fd1c, gsn->fd1c, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 1); + if ((rc = osmo_fd_register(&hnb->gtp.fd1c)) < 0) + goto free_ret; + + osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 2); + if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0) + goto free_ret; + + gtp_set_cb_data_ind(gsn, hnb_gtp_cb_data_ind); + + hnb->gtp.gsn = gsn; + return 0; + +free_ret: + osmo_fd_unregister(&hnb->gtp.fd1u); + osmo_fd_unregister(&hnb->gtp.fd1c); + osmo_fd_unregister(&hnb->gtp.fd0); + gtp_free(gsn); + hnb->gtp.fd0.fd = -1; + hnb->gtp.fd1c.fd = -1; + hnb->gtp.fd1u.fd = -1; + return rc; +} + +void hnb_gtp_unbind(struct hnb *hnb) +{ + osmo_fd_unregister(&hnb->gtp.fd1u); + osmo_fd_unregister(&hnb->gtp.fd1c); + osmo_fd_unregister(&hnb->gtp.fd0); + gtp_free(hnb->gtp.gsn); + hnb->gtp.gsn = NULL; + hnb->gtp.fd0.fd = -1; + hnb->gtp.fd1c.fd = -1; + hnb->gtp.fd1u.fd = -1; +} + +int hnb_ue_gtp_bind(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei, + struct osmo_sockaddr *loc_addr, uint32_t *loc_tei) +{ + int rc; + struct hnb *hnb = ue->hnb; + struct pdp_t *pdp; + struct in_addr rem_in; + + LOGUE(ue, DGTP, LOGL_INFO, "Creating PDP context\n"); + + + if (rem_addr->u.sa.sa_family != AF_INET) { + LOGUE(ue, DGTP, LOGL_ERROR, "Failed creating PDP context: unsupported proto family %u\n", + rem_addr->u.sa.sa_family); + return -ENOTSUP; + } + + rem_in = rem_addr->u.sin.sin_addr; + + rc = gtp_pdp_newpdp(hnb->gtp.gsn, &pdp, ue->conn_id, 0 /* TODO: NSAPI? */, NULL); + if (rc < 0) { + LOGUE(ue, DGTP, LOGL_ERROR, "Failed creating PDP context: %s\n", strerror(-rc)); + return rc; + } + pdp->priv = ue; + ue->conn_ps.pdp_lib = pdp; + + pdp->teid_gn = rem_tei; + pdp->version = 1; + pdp->hisaddr0 = rem_in; + pdp->hisaddr1 = rem_in; + + pdp->gsnru.l = sizeof(rem_in); + memcpy(pdp->gsnru.v, &rem_in, sizeof(rem_in)); + + + pdp->gsnlu.l = sizeof(hnb->gtp.local_addr.u.sin.sin_addr); + memcpy(pdp->gsnlu.v, &hnb->gtp.local_addr.u.sin.sin_addr, + sizeof(hnb->gtp.local_addr.u.sin.sin_addr)); + + *loc_addr = hnb->gtp.local_addr; + //loc_addr->u.sin.sin_family = AF_INET; + //loc_addr->u.sin.sin_addr = hnb->gtp.gsn->gsnu; + //loc_addr->u.sin.sin_port = GTP1U_PORT; + *loc_tei = pdp->teid_own; + return 0; +} + +int hnb_ue_gtp_tx(struct hnb_ue *ue, void *gtpu_payload, unsigned gtpu_payload_len) +{ + int rc; + struct hnb *hnb = ue->hnb; + + if (!hnb->gtp.gsn) { + LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n"); + return -EINVAL; + } + + if (!ue || !ue->conn_ps.pdp_lib) { + LOGUE(ue, DGTP, LOGL_ERROR, "Tx: UE PDP Ctx not available\n"); + return -EINVAL; + } + + rc = gtp_data_req(hnb->gtp.gsn, ue->conn_ps.pdp_lib, gtpu_payload, gtpu_payload_len); + return rc; +} diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index f8878bd..787985a 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -57,6 +57,11 @@ hnb->rtp.ip_dscp = -1; hnb->rtp.priority = -1; + hnb->gtp.cfg_local_addr = talloc_strdup(hnb, "0.0.0.0"); + hnb->gtp.fd0.fd = -1; + hnb->gtp.fd1c.fd = -1; + hnb->gtp.fd1u.fd = -1; + hnb->shutdown_fi = osmo_fsm_inst_alloc(&hnb_shutdown_fsm, hnb, hnb, LOGL_INFO, NULL); @@ -84,6 +89,11 @@ osmo_prim_srv_link_free(hnb->llsk_link); hnb->llsk_link = NULL; + if (hnb->gtp.gsn) { + gtp_free(hnb->gtp.gsn); + hnb->gtp.gsn = NULL; + } + talloc_free(hnb); } @@ -114,6 +124,8 @@ void hnb_ue_reset_chan(struct hnb_ue *ue, bool is_ps) { if (is_ps) { + if (ue->conn_ps.pdp_lib) + pdp_freepdp(ue->conn_ps.pdp_lib); ue->conn_ps = (struct hnb_ue_ps_ctx){0}; } else { if (ue->conn_cs.rtp.socket) @@ -199,6 +211,22 @@ } return NULL; } + +struct hnb_ue *hnb_find_ue_by_tei(const struct hnb *hnb, uint32_t tei, bool is_remote) +{ + struct hnb_ue *ue; + + llist_for_each_entry(ue, &hnb->ue_list, list) { + if (!ue->conn_ps.active) + continue; + uint32_t ue_tei = is_remote ? ue->conn_ps.remote_tei : ue->conn_ps.local_tei; + if (tei != ue_tei) + continue; + return ue; + } + return NULL; +} + struct hnb_ue *hnb_find_ue_by_imsi(const struct hnb *hnb, char *imsi) { struct hnb_ue *ue; diff --git a/src/osmo-hnodeb/llsk.c b/src/osmo-hnodeb/llsk.c index 121a3a8..92e5e91 100644 --- a/src/osmo-hnodeb/llsk.c +++ b/src/osmo-hnodeb/llsk.c @@ -129,7 +129,8 @@ return false; if (hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_IUH) && - hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_AUDIO)) + hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_AUDIO) && + hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_GTP)) return true; return false; } @@ -164,9 +165,7 @@ case HNB_PRIM_SAPI_IUH: return llsk_rx_iuh(hnb, oph); case HNB_PRIM_SAPI_GTP: - LOGP(DLLSK, LOGL_ERROR, "Rx SAPI %u not yet implemented (len=%u)\n", - oph->sap, msgb_length(oph->msg)); - return -EINVAL; + return llsk_rx_gtp(hnb, oph); case HNB_PRIM_SAPI_AUDIO: return llsk_rx_audio(hnb, oph); default: diff --git a/src/osmo-hnodeb/llsk_gtp.c b/src/osmo-hnodeb/llsk_gtp.c new file mode 100644 index 0000000..f526426 --- /dev/null +++ b/src/osmo-hnodeb/llsk_gtp.c @@ -0,0 +1,278 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +#include +#include +#include +#include + +static size_t llsk_gtp_prim_size_tbl[4][_HNB_GTP_PRIM_MAX] = { + [PRIM_OP_REQUEST] = { + [HNB_GTP_PRIM_CONN_ESTABLISH] = sizeof(struct hnb_gtp_conn_establish_req_param), + [HNB_GTP_PRIM_CONN_RELEASE] = sizeof(struct hnb_gtp_conn_release_req_param), + [HNB_GTP_PRIM_CONN_DATA] = sizeof(struct hnb_gtp_conn_data_req_param), + }, + [PRIM_OP_RESPONSE] = {}, + [PRIM_OP_INDICATION] = { + [HNB_GTP_PRIM_CONN_DATA] = sizeof(struct hnb_gtp_conn_data_ind_param), + }, + [PRIM_OP_CONFIRM] = { + [HNB_GTP_PRIM_CONN_ESTABLISH] = sizeof(struct hnb_gtp_conn_establish_cnf_param), + }, +}; +static inline size_t llsk_gtp_prim_size(enum hnb_gtp_prim_type ptype, enum osmo_prim_operation op) +{ + size_t val = llsk_gtp_prim_size_tbl[op][ptype]; + if (val == 0) { + LOGP(DLLSK, LOGL_FATAL, "Expected prim_size != 0 for ptype=%u op=%u\n", ptype, op); + osmo_panic("Expected prim_size != 0 for ptype=%u op=%u\n", ptype, op); + } + return val; +} + +const struct value_string hnb_gtp_prim_type_names[] = { + OSMO_VALUE_STRING(HNB_GTP_PRIM_CONN_ESTABLISH), + OSMO_VALUE_STRING(HNB_GTP_PRIM_CONN_RELEASE), + OSMO_VALUE_STRING(HNB_GTP_PRIM_CONN_DATA), + { 0, NULL } +}; + +static struct hnb_gtp_prim *hnb_gtp_prim_alloc(enum hnb_gtp_prim_type ptype, enum osmo_prim_operation op, size_t extra_len) +{ + struct osmo_prim_hdr *oph; + size_t len = llsk_gtp_prim_size(ptype, op); + + oph = osmo_prim_msgb_alloc(HNB_PRIM_SAPI_GTP, ptype, op, sizeof(*oph) + len + extra_len); + if (!oph) + return NULL; + msgb_put(oph->msg, len); + + return (struct hnb_gtp_prim *)oph; +} + +static struct hnb_gtp_prim *hnb_gtp_makeprim_conn_establish_cnf(uint32_t context_id, uint8_t error_code, + uint32_t local_tei, uint8_t local_gtpu_address_type, + const union u_addr *local_gtpu_addr) +{ + struct hnb_gtp_prim *gtp_prim; + + gtp_prim = hnb_gtp_prim_alloc(HNB_GTP_PRIM_CONN_ESTABLISH, PRIM_OP_CONFIRM, 0); + gtp_prim->u.conn_establish_cnf.context_id = context_id; + gtp_prim->u.conn_establish_cnf.local_tei = local_tei; + gtp_prim->u.conn_establish_cnf.error_code = error_code; + gtp_prim->u.conn_establish_cnf.local_gtpu_address_type = local_gtpu_address_type; + if (local_gtpu_addr) + gtp_prim->u.conn_establish_cnf.local_gtpu_addr = *local_gtpu_addr; + + return gtp_prim; +} + +struct hnb_gtp_prim *hnb_gtp_makeprim_conn_data_ind(uint32_t context_id, uint32_t local_tei, + const uint8_t *data, uint32_t data_len) +{ + struct hnb_gtp_prim *gtp_prim; + + gtp_prim = hnb_gtp_prim_alloc(HNB_GTP_PRIM_CONN_DATA, PRIM_OP_INDICATION, data_len); + gtp_prim->u.conn_data_ind.context_id = context_id; + gtp_prim->u.conn_data_ind.local_tei = local_tei; + gtp_prim->u.conn_data_ind.data_len = data_len; + if (data_len) { + msgb_put(gtp_prim->hdr.msg, data_len); + memcpy(gtp_prim->u.conn_data_ind.data, data, data_len); + } + + return gtp_prim; +} + +static int _send_conn_establish_cnf_failed(struct hnb *hnb, uint32_t context_id, uint8_t error_code) +{ + struct hnb_gtp_prim *gtp_prim; + int rc; + LOGP(DLLSK, LOGL_ERROR, "Tx GTP-CONN_ESTABLISH.cnf: ctx=%u error_code=%u\n", + context_id, error_code); + gtp_prim = hnb_gtp_makeprim_conn_establish_cnf(context_id, error_code, 0, HNB_PRIM_ADDR_TYPE_UNSPEC, NULL); + if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { + LOGP(DLLSK, LOGL_ERROR, "Failed sending GTP-CONN_ESTABLISH.cnf context_id=%u error_code=%u\n", + context_id, error_code); + } + return rc; +} + +static int llsk_rx_gtp_conn_establish_req(struct hnb *hnb, struct hnb_gtp_conn_establish_req_param *ce_req) +{ + struct hnb_ue *ue; + int rc = 0; + struct hnb_gtp_prim *gtp_prim; + int af; + char rem_addrstr[INET6_ADDRSTRLEN+32]; + struct osmo_sockaddr rem_osa = {0}; + struct osmo_sockaddr loc_osa = {0}; + union u_addr loc_uaddr = {0}; + uint32_t loc_tei; + + rc = ll_addr2osa(ce_req->remote_gtpu_address_type, &ce_req->remote_gtpu_addr, GTP1U_PORT, &rem_osa); + if (rc < 0) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: ctx=%u with unexpected address type %u\n", + ce_req->context_id, ce_req->remote_gtpu_address_type); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 1); + } + osmo_sockaddr_to_str_buf(rem_addrstr, sizeof(rem_addrstr), &rem_osa); + + LOGP(DLLSK, LOGL_INFO, "Rx GTP-CONN_ESTABLISH.req ctx=%u rem_tei=%u rem_addr=%s\n", + ce_req->context_id, ce_req->remote_tei, rem_addrstr); + + if ((af = ll_addr_type2af(ce_req->remote_gtpu_address_type)) < 0) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: ctx=%u with unexpected address type %u\n", + ce_req->context_id, ce_req->remote_gtpu_address_type); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 1); + } + + ue = hnb_find_ue_by_id(hnb, ce_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: UE not found! ctx=%u rem_addr=%s\n", + ce_req->context_id, rem_addrstr); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 2); + } + if (!ue->conn_ps.active) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: PS chan not active! ctx=%u rem_addr=%s\n", + ce_req->context_id, rem_addrstr); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 3); + } + + /* Create the socket: */ + if ((rc = hnb_ue_gtp_bind(ue, &rem_osa, ce_req->remote_tei, &loc_osa, &loc_tei)) < 0) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: Failed to set up gtp socket ctx=%u rem_tei=%u rem_addr=%s\n", + ce_req->context_id, ce_req->remote_tei, rem_addrstr); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); + } + + /* Convert resulting local address back to LLSK format: */ + if (osa2_ll_addr(&loc_osa, &loc_uaddr, NULL) != ce_req->remote_gtpu_address_type) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: Failed to provide proper local address ctx=%u rem_addr=%s\n", + ce_req->context_id, rem_addrstr); + rc = _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); + goto release_sock; + } + + /* Submit successful confirmation */ + LOGP(DLLSK, LOGL_INFO, "Tx GTP-CONN_ESTABLISH.cnf: ctx=%u error_code=0 rem_addr=%s rem_tei=%u loc_addr=%s local_tei=%u\n", + ce_req->context_id, rem_addrstr, ce_req->remote_tei, osmo_sockaddr_to_str(&loc_osa), loc_tei); + gtp_prim = hnb_gtp_makeprim_conn_establish_cnf(ce_req->context_id, 0, loc_tei, ce_req->remote_gtpu_address_type, &loc_uaddr); + if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { + LOGP(DLLSK, LOGL_ERROR, "Failed sending GTP-CONN_ESTABLISH.cnf context_id=%u error_code=0\n", + ce_req->context_id); + goto release_sock; + } + + ue->conn_ps.local_tei = loc_tei; + ue->conn_ps.remote_tei = ce_req->remote_tei; + + return rc; +release_sock: /* TODO: release socket here */ + return rc; +} + +static int llsk_rx_gtp_conn_release_req(struct hnb *hnb, struct hnb_gtp_conn_release_req_param *rel_req) +{ + struct hnb_ue *ue; + int rc = 0; + + LOGP(DLLSK, LOGL_DEBUG, "Rx GTP-CONN_RELEASE.req ctx=%u\n", rel_req->context_id); + + ue = hnb_find_ue_by_id(hnb, rel_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_RELEASE.req: UE not found! ctx=%u\n", + rel_req->context_id); + return -EINVAL; + } + /* TODO: release GTP socket */ + return rc; +} + +static int llsk_rx_gtp_conn_data_req(struct hnb *hnb, struct hnb_gtp_conn_data_req_param *data_req) +{ + struct hnb_ue *ue; + int rc = 0; + + LOGP(DLLSK, LOGL_DEBUG, "Rx GTP-CONN_DATA.req ctx=%u rem_tei=%u data_len=%u\n", + data_req->context_id, data_req->remote_tei, data_req->data_len); + + ue = hnb_find_ue_by_id(hnb, data_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_DATA.req: UE not found! ctx=%u data_len=%u\n", + data_req->context_id, data_req->data_len); + return -EINVAL; + } + + rc = hnb_ue_gtp_tx(ue, data_req->data, data_req->data_len); + return rc; +} + +int llsk_rx_gtp(struct hnb *hnb, struct osmo_prim_hdr *oph) +{ + size_t prim_size = llsk_gtp_prim_size(oph->primitive, oph->operation); + + if (msgb_length(oph->msg) < prim_size) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-%s.%s with length %u < %zu\n", + get_value_string(hnb_gtp_prim_type_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation), + msgb_length(oph->msg), prim_size); + return -EINVAL; + } + + switch (oph->operation) { + case PRIM_OP_REQUEST: + switch (oph->primitive) { + case HNB_GTP_PRIM_CONN_ESTABLISH: + return llsk_rx_gtp_conn_establish_req(hnb, (struct hnb_gtp_conn_establish_req_param *)msgb_data(oph->msg)); + case HNB_GTP_PRIM_CONN_RELEASE: + return llsk_rx_gtp_conn_release_req(hnb, (struct hnb_gtp_conn_release_req_param *)msgb_data(oph->msg)); + case HNB_GTP_PRIM_CONN_DATA: + return llsk_rx_gtp_conn_data_req(hnb, (struct hnb_gtp_conn_data_req_param *)msgb_data(oph->msg)); + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-gtp unknown primitive %u (len=%u)\n", + oph->primitive, msgb_length(oph->msg)); + return -EINVAL; + } + break; + + case PRIM_OP_RESPONSE: + case PRIM_OP_INDICATION: + case PRIM_OP_CONFIRM: + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-gtp unexpected primitive operation %s::%s (len=%u)\n", + get_value_string(hnb_gtp_prim_type_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation), + msgb_length(oph->msg)); + return -EINVAL; + } +} diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 9af83ea..5d35c18 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -51,6 +51,7 @@ #include #include #include +#include static const char * const osmohnodeb_copyright = "OsmoHNodeB - Osmocom 3G Home NodeB implementation\r\n" @@ -280,6 +281,12 @@ exit(1); } + rc = hnb_gtp_bind(g_hnb); + if (rc < 0) { + perror("Error listening on GTP port"); + exit(1); + } + rc = hnb_iuh_connect(g_hnb); if (rc < 0) { perror("Error connecting to Iuh port"); @@ -305,6 +312,8 @@ osmo_select_main_ctx(0); } + hnb_gtp_unbind(g_hnb); + log_fini(); /** diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index 131dc6b..e84e330 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -51,6 +51,10 @@ vty->node = HNODEB_NODE; vty->index = g_hnb; break; + case GTP_NODE: + vty->node = HNODEB_NODE; + vty->index = g_hnb; + break; case HNODEB_NODE: vty->node = CONFIG_NODE; vty->index = g_hnb; @@ -281,6 +285,33 @@ return CMD_SUCCESS; } +static struct cmd_node gtp_node = { + GTP_NODE, + "%s(config-gtp)# ", + 1, +}; + +#define GTP_STR "Configure the GPRS Tunnelling Protocol parameters\n" + +DEFUN(cfg_hnodeb_gtp, + cfg_hnodeb_gtp_cmd, + "gtp", GTP_STR) +{ + OSMO_ASSERT(g_hnb); + vty->index = g_hnb; + vty->node = GTP_NODE; + + return CMD_SUCCESS; +} + +DEFUN(cfg_hnodeb_gtp_local_ip, cfg_hnodeb_gtp_local_ip_cmd, + "local-ip " VTY_IPV4_CMD, + "Configure the GTP-U bind address\n" + "GTP-U local IPv4 address\n") +{ + osmo_talloc_replace_string(g_hnb, &g_hnb->gtp.cfg_local_addr, argv[0]); + return CMD_SUCCESS; +} static int config_write_hnodeb(struct vty *vty) { @@ -302,6 +333,8 @@ vty_out(vty, " remote-port %u%s", g_hnb->iuh.remote_port, VTY_NEWLINE); vty_out(vty, " ll-socket%s", VTY_NEWLINE); vty_out(vty, " path %s%s", osmo_prim_srv_link_get_addr(g_hnb->llsk_link), VTY_NEWLINE); + vty_out(vty, " gtp%s", VTY_NEWLINE); + vty_out(vty, " local-ip %s%s", g_hnb->gtp.cfg_local_addr, VTY_NEWLINE); return CMD_SUCCESS; } @@ -359,6 +392,9 @@ install_element(HNODEB_NODE, &cfg_hnodeb_llsk_cmd); install_node(&llsk_node, NULL); install_element(LLSK_NODE, &cfg_hnodeb_llsk_path_cmd); + install_element(HNODEB_NODE, &cfg_hnodeb_gtp_cmd); + install_node(>p_node, NULL); + install_element(GTP_NODE, &cfg_hnodeb_gtp_local_ip_cmd); install_element_ve(&asn_dbg_cmd); install_element_ve(&ranap_reset_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 15:07:10 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 15:07:10 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK audio SAPI In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 ) Change subject: First implementation of the LLSK audio SAPI ...................................................................... Patch Set 1: The RTP/IuUP forwarding is still missing in this version. I'm currently working on adding it. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d Gerrit-Change-Number: 26502 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 10 Dec 2021 15:07:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 16:14:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 16:14:57 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 to look at the new patch set (#11). Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Initial implementation of LowerLayer UD Socket The LLSK socket is an interface allowing thid-parties to implement and hook their RLC/MAC/RRC stack to osmo-hnodbe, which takes care of interconnection with the rest of the RAN and core network (Iuh, RTP, GTP-U, etc.). Related: SYS#5516 Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d --- A doc/hnodeb.msc M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 19 files changed, 1,076 insertions(+), 40 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/57/26357/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 11 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 16:14:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 16:14:57 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK audio SAPI In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 to look at the new patch set (#2). Change subject: First implementation of the LLSK audio SAPI ...................................................................... First implementation of the LLSK audio SAPI Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d --- M configure.ac M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h A include/osmocom/hnodeb/rtp.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_audio.c M src/osmo-hnodeb/main.c A src/osmo-hnodeb/rtp.c 13 files changed, 686 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/02/26502/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d Gerrit-Change-Number: 26502 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 16:14:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 16:14:57 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 to look at the new patch set (#2). Change subject: First implementation of the LLSK gtp SAPI ...................................................................... First implementation of the LLSK gtp SAPI Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 --- M configure.ac M contrib/jenkins.sh M contrib/osmo-hnodeb.spec.in M debian/control M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/gtp.h M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c A src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_gtp.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/vty.c 18 files changed, 725 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/03/26503/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 16:21:19 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 16:21:19 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26504 ) Change subject: BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 ...................................................................... BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 Otherwise it's impossible to run the CBSP test cases locally, because the remote peer address in osmo-bsc gets set to '0.0.0.0', so indeed it cannot establish connection to the server. Change-Id: I5b1d215818255717ed955c9f1a9c45505ab11a65 Fixed: OS#5351 --- M bsc/BSC_Tests_CBSP.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/26504/1 diff --git a/bsc/BSC_Tests_CBSP.ttcn b/bsc/BSC_Tests_CBSP.ttcn index 6dd5bb7..8119289 100644 --- a/bsc/BSC_Tests_CBSP.ttcn +++ b/bsc/BSC_Tests_CBSP.ttcn @@ -41,8 +41,8 @@ import from TELNETasp_PortType all; modulepar { - charstring mp_cbc_ip := "0.0.0.0"; - charstring mp_cbc_ip6 := "::"; + charstring mp_cbc_ip := "127.0.0.1"; + charstring mp_cbc_ip6 := "::1"; integer mp_cbc_port := 48049; charstring mp_bsc_cbsp_ip := "127.0.0.1"; charstring mp_bsc_cbsp_ip6 := "::1"; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b1d215818255717ed955c9f1a9c45505ab11a65 Gerrit-Change-Number: 26504 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 16:21:19 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 16:21:19 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests.cfg: also execute LCLS test cases References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26505 ) Change subject: BSC_Tests.cfg: also execute LCLS test cases ...................................................................... BSC_Tests.cfg: also execute LCLS test cases Change-Id: I106052d6f89a85171f8c65f1dbfcbeaa4f35f887 --- M bsc/BSC_Tests.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/26505/1 diff --git a/bsc/BSC_Tests.cfg b/bsc/BSC_Tests.cfg index 610e0f7..5765846 100644 --- a/bsc/BSC_Tests.cfg +++ b/bsc/BSC_Tests.cfg @@ -16,6 +16,7 @@ [EXECUTE] BSC_Tests.control +BSC_Tests_LCLS.control BSC_Tests_CBSP.control #BSC_Tests.TC_chan_act_noreply #BSC_Tests.TC_chan_act_ack_noest -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I106052d6f89a85171f8c65f1dbfcbeaa4f35f887 Gerrit-Change-Number: 26505 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 16:24:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 16:24:05 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26504 to look at the new patch set (#2). Change subject: BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 ...................................................................... BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 Otherwise it's impossible to run the CBSP test cases locally, because the remote peer address in osmo-bsc gets set to '0.0.0.0', so indeed it cannot establish connection to the server. Change-Id: I5b1d215818255717ed955c9f1a9c45505ab11a65 Fixes: OS#5351 --- M bsc/BSC_Tests_CBSP.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/26504/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b1d215818255717ed955c9f1a9c45505ab11a65 Gerrit-Change-Number: 26504 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 16:24:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 16:24:05 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests.cfg: also execute LCLS test cases In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26505 to look at the new patch set (#2). Change subject: BSC_Tests.cfg: also execute LCLS test cases ...................................................................... BSC_Tests.cfg: also execute LCLS test cases Change-Id: I106052d6f89a85171f8c65f1dbfcbeaa4f35f887 --- M bsc/BSC_Tests.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/26505/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I106052d6f89a85171f8c65f1dbfcbeaa4f35f887 Gerrit-Change-Number: 26505 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 16:24:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 16:24:16 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests.cfg: also execute LCLS test cases In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26505 ) Change subject: BSC_Tests.cfg: also execute LCLS test cases ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I106052d6f89a85171f8c65f1dbfcbeaa4f35f887 Gerrit-Change-Number: 26505 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 16:24:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 16:24:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 16:24:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26504 ) Change subject: BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b1d215818255717ed955c9f1a9c45505ab11a65 Gerrit-Change-Number: 26504 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 16:24:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 18:32:35 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 18:32:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506 ) Change subject: BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() ...................................................................... BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() Using the same IMSI in each test case makes it harder to correlate subscriber connections in the SUT with particular test cases. A good example is a problem described in OS#5337: some test cases create dangling subscriber entries that never got released: OsmoBSC# show subscriber all IMSI TMSI Use 001019876543210 ffffffff 3 (3*paging-start) 001010000100001 ffffffff 1 (conn) With this patch I am getting the following output: OsmoBSC# show subscriber all IMSI TMSI Use 001016017428234 ffffffff 1 (paging-start) 001014631230680 ffffffff 1 (paging-start) 001011161500382 ffffffff 1 (paging-start) 001010000100001 ffffffff 1 (conn) so I was able to correlate the following test cases: * (001016017428234) TC_lcs_loc_req_for_active_ms_ta_req, * (001014631230680) TC_lcs_loc_req_for_active_ms_le_timeout2, * (001011161500382) TC_cm_service_during_lcs_loc_req, * (001010000100001) TC_no_msc. Change-Id: Ie008b5566b207b13cd562c55625bad38c09b3927 Related: OS#5337 --- M bsc/BSC_Tests.ttcn 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/26506/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index e7c4599..545d284 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -721,6 +721,13 @@ pars.mscpool.bssap_idx := bssap_idx; pars.expect_tsc := BTS_TSC[0]; + pars.imsi := '00101'H; + while (lengthof(pars.imsi) < 15) { + var hexstring digit := int2hex(f_rnd_int(10), 1); + pars.imsi := pars.imsi & digit; + } + log(testcasename(), ": using IMSI ", pars.imsi); + return pars; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie008b5566b207b13cd562c55625bad38c09b3927 Gerrit-Change-Number: 26506 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 18:55:09 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 18:55:09 +0000 Subject: Change in simtrace2[master]: host/contrib/simtrace2.spec.in: update In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26501 ) Change subject: host/contrib/simtrace2.spec.in: update ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I35ce3865702f72365b38b0eaa8b28f332dabcd1f Gerrit-Change-Number: 26501 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 18:55:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 20:06:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 20:06:05 +0000 Subject: Change in docker-playground[master]: Add centos7 containers In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26497 ) Change subject: Add centos7 containers ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iadf3d0d7143c2d81ea5e87fd07a3f4cd9239cb46 Gerrit-Change-Number: 26497 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 10 Dec 2021 20:06:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 20:06:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 20:06:46 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 20:06:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 20:07:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 20:07:18 +0000 Subject: Change in docker-playground[master]: osmo-pcap-latest: fix install path for centos In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26499 ) Change subject: osmo-pcap-latest: fix install path for centos ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I775776ff7f358fee3d085f814c295c49225f5170 Gerrit-Change-Number: 26499 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 20:07:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 22:14:30 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 22:14:30 +0000 Subject: Change in docker-playground[master]: osmo-pcap-latest: fix typo in Dockerfile: s/clint/client/ References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26507 ) Change subject: osmo-pcap-latest: fix typo in Dockerfile: s/clint/client/ ...................................................................... osmo-pcap-latest: fix typo in Dockerfile: s/clint/client/ This patch fixes 'ttcn3-pcap-client-test-latest' job on Jenkins. Change-Id: Ibf472ec712624b16adff4b0f043771f257e7d71f --- M osmo-pcap-latest/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/07/26507/1 diff --git a/osmo-pcap-latest/Dockerfile b/osmo-pcap-latest/Dockerfile index 7cb4d79..e0e6fa7 100644 --- a/osmo-pcap-latest/Dockerfile +++ b/osmo-pcap-latest/Dockerfile @@ -24,6 +24,6 @@ COPY osmo-pcap-client.cfg /data/ #COPY osmo-pcap-server.cfg /data/ -CMD ["/bin/sh", "-c", "/usr/bin/osmo-pcap-clint -c /data/osmo-pcap-client.cfg >/data/osmo-pcap-client.log 2>&1"] +CMD ["/bin/sh", "-c", "/usr/bin/osmo-pcap-client -c /data/osmo-pcap-client.cfg >/data/osmo-pcap-client.log 2>&1"] EXPOSE 4237 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibf472ec712624b16adff4b0f043771f257e7d71f Gerrit-Change-Number: 26507 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Dec 10 22:55:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 22:55:06 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <61b3dace6b194_72822b13744585f01389871@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 65s] + cd simtrace2-0.8.0.202112100026 [ 65s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/share/doc/packages/simtrace2 [ 65s] + export LC_ALL=C [ 65s] + LC_ALL=C [ 65s] + export DOCDIR [ 65s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/share/doc/packages/simtrace2 [ 65s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/share/doc/packages/simtrace2 [ 65s] + RPM_EC=0 [ 65s] ++ jobs -p [ 65s] + exit 0 [ 65s] Provides: simtrace2 = 0.8.0.202112100026-1.1 simtrace2(x86-32) = 0.8.0.202112100026-1.1 [ 65s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 65s] Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libosmo-simtrace2.so.1 libosmocore.so.18 libosmosim.so.2 libosmousb.so.0 libusb-1.0.so.0 [ 65s] Processing files: simtrace2-debugsource-0.8.0.202112100026-1.1.i586 [ 66s] Provides: simtrace2-debugsource = 0.8.0.202112100026-1.1 simtrace2-debugsource(x86-32) = 0.8.0.202112100026-1.1 [ 66s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 66s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-1.1.i586 [ 66s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/lib/libosmo-simtrace2.so.0* [ 66s] [ 66s] [ 66s] RPM build errors: [ 66s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.i386/usr/lib/libosmo-simtrace2.so.0* [ 66s] ### VM INTERACTION START ### [ 69s] [ 54.291072][ T393] sysrq: Power Off [ 69s] [ 54.308884][ T181] reboot: Power down [ 69s] ### VM INTERACTION END ### [ 69s] [ 69s] cloud112 failed "build simtrace2.spec" at Fri Dec 10 22:54:58 UTC 2021. [ 69s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 22:56:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 22:56:48 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <61b3db44dbfc0_72822b13744585f013902c3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Tumbleweed/i586 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 66s] + cd simtrace2-0.8.0 [ 66s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/share/doc/packages/simtrace2 [ 66s] + export LC_ALL=C [ 66s] + LC_ALL=C [ 66s] + export DOCDIR [ 66s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/share/doc/packages/simtrace2 [ 66s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/share/doc/packages/simtrace2 [ 66s] + RPM_EC=0 [ 66s] ++ jobs -p [ 66s] + exit 0 [ 66s] Provides: simtrace2 = 0.8.0-1.1 simtrace2(x86-32) = 0.8.0-1.1 [ 66s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 66s] Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libosmo-simtrace2.so.1 libosmocore.so.18 libosmosim.so.2 libosmousb.so.0 libusb-1.0.so.0 [ 66s] Processing files: simtrace2-debugsource-0.8.0-1.1.i586 [ 66s] Provides: simtrace2-debugsource = 0.8.0-1.1 simtrace2-debugsource(x86-32) = 0.8.0-1.1 [ 66s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 66s] Processing files: libosmo-simtrace2-0-0.8.0-1.1.i586 [ 66s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/lib/libosmo-simtrace2.so.0* [ 66s] [ 66s] [ 66s] RPM build errors: [ 66s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.i386/usr/lib/libosmo-simtrace2.so.0* [ 66s] ### VM INTERACTION START ### [ 69s] [ 60.741264][ T434] sysrq: Power Off [ 69s] [ 60.753299][ T16] reboot: Power down [ 70s] ### VM INTERACTION END ### [ 70s] [ 70s] lamb16 failed "build simtrace2.spec" at Fri Dec 10 22:56:46 UTC 2021. [ 70s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Dec 10 22:57:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 22:57:29 +0000 Subject: Change in docker-playground[master]: osmo-pcap-latest: fix typo in Dockerfile: s/clint/client/ In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26507 ) Change subject: osmo-pcap-latest: fix typo in Dockerfile: s/clint/client/ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibf472ec712624b16adff4b0f043771f257e7d71f Gerrit-Change-Number: 26507 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 22:57:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 22:58:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 10 Dec 2021 22:58:55 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506 ) Change subject: BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() ...................................................................... Patch Set 1: Code-Review+1 Canwe move this into some helper function so that can be later reused? We rpobably want something similar in other tests suites. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie008b5566b207b13cd562c55625bad38c09b3927 Gerrit-Change-Number: 26506 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 22:58:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 22:59:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 22:59:18 +0000 Subject: Change in docker-playground[master]: osmo-pcap-latest: fix typo in Dockerfile: s/clint/client/ In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26507 ) Change subject: osmo-pcap-latest: fix typo in Dockerfile: s/clint/client/ ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibf472ec712624b16adff4b0f043771f257e7d71f Gerrit-Change-Number: 26507 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 22:59:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 22:59:23 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 22:59:23 +0000 Subject: Change in docker-playground[master]: osmo-pcap-latest: fix typo in Dockerfile: s/clint/client/ In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26507 ) Change subject: osmo-pcap-latest: fix typo in Dockerfile: s/clint/client/ ...................................................................... osmo-pcap-latest: fix typo in Dockerfile: s/clint/client/ This patch fixes 'ttcn3-pcap-client-test-latest' job on Jenkins. Change-Id: Ibf472ec712624b16adff4b0f043771f257e7d71f --- M osmo-pcap-latest/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved fixeria: Verified diff --git a/osmo-pcap-latest/Dockerfile b/osmo-pcap-latest/Dockerfile index 7cb4d79..e0e6fa7 100644 --- a/osmo-pcap-latest/Dockerfile +++ b/osmo-pcap-latest/Dockerfile @@ -24,6 +24,6 @@ COPY osmo-pcap-client.cfg /data/ #COPY osmo-pcap-server.cfg /data/ -CMD ["/bin/sh", "-c", "/usr/bin/osmo-pcap-clint -c /data/osmo-pcap-client.cfg >/data/osmo-pcap-client.log 2>&1"] +CMD ["/bin/sh", "-c", "/usr/bin/osmo-pcap-client -c /data/osmo-pcap-client.cfg >/data/osmo-pcap-client.log 2>&1"] EXPOSE 4237 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibf472ec712624b16adff4b0f043771f257e7d71f Gerrit-Change-Number: 26507 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Dec 10 23:02:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 23:02:14 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61b3dc8f5bef9_72822b13744585f0139251b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Factory_ARM/armv7l Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 57s] + cd simtrace2-0.8.0 [ 57s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.arm/usr/share/doc/packages/simtrace2 [ 57s] + export LC_ALL=C [ 57s] + LC_ALL=C [ 57s] + export DOCDIR [ 57s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.arm/usr/share/doc/packages/simtrace2 [ 57s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.arm/usr/share/doc/packages/simtrace2 [ 57s] + RPM_EC=0 [ 57s] ++ jobs -p [ 57s] + exit 0 [ 57s] Provides: simtrace2 = 0.8.0-1.1 simtrace2(armv7hl-32) = 0.8.0-1.1 [ 57s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 57s] Requires: ld-linux-armhf.so.3 ld-linux-armhf.so.3(GLIBC_2.4) libc.so.6 libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.5) libosmo-simtrace2.so.1 libosmocore.so.18 libosmosim.so.2 libosmousb.so.0 libusb-1.0.so.0 [ 57s] Processing files: simtrace2-debugsource-0.8.0-1.1.armv7hl [ 57s] Provides: simtrace2-debugsource = 0.8.0-1.1 simtrace2-debugsource(armv7hl-32) = 0.8.0-1.1 [ 57s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 57s] Processing files: libosmo-simtrace2-0-0.8.0-1.1.armv7hl [ 57s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.arm/usr/lib/libosmo-simtrace2.so.0* [ 57s] [ 57s] [ 57s] RPM build errors: [ 57s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.arm/usr/lib/libosmo-simtrace2.so.0* [ 57s] ### VM INTERACTION START ### [ 60s] [ 37.723454][ T384] sysrq: Power Off [ 60s] [ 37.724432][ T207] reboot: Power down [ 61s] ### VM INTERACTION END ### [ 61s] [ 61s] obs-arm-10 failed "build simtrace2.spec" at Fri Dec 10 23:02:11 UTC 2021. [ 61s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Dec 10 23:04:58 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 23:04:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506 ) Change subject: BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > Canwe move this into some helper function so that can be later reused? We rpobably want something similar in other tests suites. I discovered that we already have f_rnd_imsi()... Facepalm :D -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie008b5566b207b13cd562c55625bad38c09b3927 Gerrit-Change-Number: 26506 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 10 Dec 2021 23:04:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 23:05:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 23:05:07 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() In-Reply-To: References: Message-ID: Hello Jenkins Builder, neels, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506 to look at the new patch set (#2). Change subject: BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() ...................................................................... BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() Using the same IMSI in each test case makes it harder to correlate subscriber connections in the SUT with particular test cases. A good example is a problem described in OS#5337: some test cases create dangling subscriber entries that never got released: OsmoBSC# show subscriber all IMSI TMSI Use 001019876543210 ffffffff 3 (3*paging-start) 001010000100001 ffffffff 1 (conn) With this patch I am getting the following output: OsmoBSC# show subscriber all IMSI TMSI Use 001016017428234 ffffffff 1 (paging-start) 001014631230680 ffffffff 1 (paging-start) 001011161500382 ffffffff 1 (paging-start) 001010000100001 ffffffff 1 (conn) so I was able to correlate the following test cases: * (001016017428234) TC_lcs_loc_req_for_active_ms_ta_req, * (001014631230680) TC_lcs_loc_req_for_active_ms_le_timeout2, * (001011161500382) TC_cm_service_during_lcs_loc_req, * (001010000100001) TC_no_msc. Change-Id: Ie008b5566b207b13cd562c55625bad38c09b3927 Related: OS#5337 --- M bsc/BSC_Tests.ttcn 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/26506/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie008b5566b207b13cd562c55625bad38c09b3927 Gerrit-Change-Number: 26506 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 23:11:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 23:11:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Osmocom_Types: fix maximum values passed to f_rnd_int() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26508 ) Change subject: library/Osmocom_Types: fix maximum values passed to f_rnd_int() ...................................................................... library/Osmocom_Types: fix maximum values passed to f_rnd_int() It's clearly stated in a comment to this function that the returned value is 0 <= x < max, so it's always less than the maximum. Change-Id: If127fc6a2feeddbdd3ea636b56dadf8957941758 --- M library/Osmocom_Types.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/08/26508/1 diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn index 3c0137c..967beb4 100644 --- a/library/Osmocom_Types.ttcn +++ b/library/Osmocom_Types.ttcn @@ -65,7 +65,7 @@ } /* return hexstring composed of random digits */ -function f_rnd_hexstring(in integer len, in integer max := 15) return hexstring { +function f_rnd_hexstring(in integer len, in integer max := 16) return hexstring { var integer i; var hexstring ret := ''H; for (i := 0; i < len; i := i + 1) { @@ -79,7 +79,7 @@ var integer i; var octetstring ret := ''O; for (i := 0; i < len; i := i + 1) { - ret := ret & int2oct(f_rnd_int(255), 1); + ret := ret & int2oct(f_rnd_int(256), 1); } return ret; } @@ -91,7 +91,7 @@ } function f_rnd_imsi(in hexstring prefix) return hexstring { - return prefix & f_rnd_hexstring(15 - lengthof(prefix), 9); + return prefix & f_rnd_hexstring(15 - lengthof(prefix), 10); } function f_rnd_msisdn(in octetstring prefix, integer len := 6) return octetstring { @@ -249,7 +249,7 @@ /* generate a random 11-bit RA (packet-switched only) */ function f_rnd_ra11_ps() return BIT11 { - var integer ra11 := f_rnd_int(bit2int('11111111111'B)); + var integer ra11 := f_rnd_int(bit2int('11111111111'B) + 1); return int2bit(ra11, 11); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If127fc6a2feeddbdd3ea636b56dadf8957941758 Gerrit-Change-Number: 26508 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 10 23:11:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 10 Dec 2021 23:11:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Osmocom_Types: use f_rnd_bitstring() in f_rnd_ra11_ps() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26509 ) Change subject: library/Osmocom_Types: use f_rnd_bitstring() in f_rnd_ra11_ps() ...................................................................... library/Osmocom_Types: use f_rnd_bitstring() in f_rnd_ra11_ps() Change-Id: I122d386b0c8ce320687016b6cab883b8a36bdffc --- M library/Osmocom_Types.ttcn 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/26509/1 diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn index 967beb4..472b389 100644 --- a/library/Osmocom_Types.ttcn +++ b/library/Osmocom_Types.ttcn @@ -249,8 +249,7 @@ /* generate a random 11-bit RA (packet-switched only) */ function f_rnd_ra11_ps() return BIT11 { - var integer ra11 := f_rnd_int(bit2int('11111111111'B) + 1); - return int2bit(ra11, 11); + return f_rnd_bitstring(11); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I122d386b0c8ce320687016b6cab883b8a36bdffc Gerrit-Change-Number: 26509 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Dec 10 23:16:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 23:16:48 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61b3dff256c99_72822b13744585f0139851d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Factory_ARM/aarch64 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 93s] + cd simtrace2-0.8.0 [ 94s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.aarch64/usr/share/doc/packages/simtrace2 [ 94s] + export LC_ALL=C [ 94s] + LC_ALL=C [ 94s] + export DOCDIR [ 94s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.aarch64/usr/share/doc/packages/simtrace2 [ 94s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.aarch64/usr/share/doc/packages/simtrace2 [ 94s] + RPM_EC=0 [ 94s] ++ jobs -p [ 94s] + exit 0 [ 94s] Provides: simtrace2 = 0.8.0-1.1 simtrace2(aarch-64) = 0.8.0-1.1 [ 94s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 94s] Requires: ld-linux-aarch64.so.1()(64bit) ld-linux-aarch64.so.1(GLIBC_2.17)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.17)(64bit) libc.so.6(GLIBC_2.34)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 94s] Processing files: simtrace2-debugsource-0.8.0-1.1.aarch64 [ 94s] Provides: simtrace2-debugsource = 0.8.0-1.1 simtrace2-debugsource(aarch-64) = 0.8.0-1.1 [ 94s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 94s] Processing files: libosmo-simtrace2-0-0.8.0-1.1.aarch64 [ 94s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.aarch64/usr/lib64/libosmo-simtrace2.so.0* [ 94s] [ 94s] [ 94s] RPM build errors: [ 94s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.aarch64/usr/lib64/libosmo-simtrace2.so.0* [ 94s] ### VM INTERACTION START ### [ 97s] [ 75.154170][ T384] sysrq: Power Off [ 97s] [ 75.158023][ T15] reboot: Power down [ 97s] ### VM INTERACTION END ### [ 97s] [ 97s] obs-arm-9 failed "build simtrace2.spec" at Fri Dec 10 23:16:43 UTC 2021. [ 97s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 23:17:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 23:17:23 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <61b3e01229d7b_72822b13744585f01398779@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 70s] + cd simtrace2-0.8.0.202112100026 [ 70s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 70s] + export LC_ALL=C [ 70s] + LC_ALL=C [ 70s] + export DOCDIR [ 70s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 70s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 70s] + RPM_EC=0 [ 70s] ++ jobs -p [ 70s] + exit 0 [ 70s] Provides: simtrace2 = 0.8.0.202112100026-1.1 simtrace2(x86-64) = 0.8.0.202112100026-1.1 [ 70s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 70s] Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.34)(64bit) libc.so.6(GLIBC_2.4)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 70s] Processing files: simtrace2-debugsource-0.8.0.202112100026-1.1.x86_64 [ 71s] Provides: simtrace2-debugsource = 0.8.0.202112100026-1.1 simtrace2-debugsource(x86-64) = 0.8.0.202112100026-1.1 [ 71s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 71s] Processing files: libosmo-simtrace2-0-0.8.0.202112100026-1.1.x86_64 [ 71s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 71s] [ 71s] [ 71s] RPM build errors: [ 71s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0.202112100026-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 71s] ### VM INTERACTION START ### [ 74s] [ 61.919650][ T434] sysrq: Power Off [ 74s] [ 61.973722][ T16] reboot: Power down [ 74s] ### VM INTERACTION END ### [ 74s] [ 74s] lamb09 failed "build simtrace2.spec" at Fri Dec 10 23:17:22 UTC 2021. [ 74s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 10 23:29:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 10 Dec 2021 23:29:40 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <61b3e301720f3_72822b13744585f014036b1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 84s] + cd simtrace2-0.8.0 [ 84s] + DOCDIR=/home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 84s] + export LC_ALL=C [ 84s] + LC_ALL=C [ 84s] + export DOCDIR [ 84s] + /usr/bin/mkdir -p /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 84s] + cp -pr README.md /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/share/doc/packages/simtrace2 [ 84s] + RPM_EC=0 [ 84s] ++ jobs -p [ 84s] + exit 0 [ 85s] Provides: simtrace2 = 0.8.0-1.1 simtrace2(x86-64) = 0.8.0-1.1 [ 85s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 85s] Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.34)(64bit) libc.so.6(GLIBC_2.4)(64bit) libosmo-simtrace2.so.1()(64bit) libosmocore.so.18()(64bit) libosmosim.so.2()(64bit) libosmousb.so.0()(64bit) libusb-1.0.so.0()(64bit) [ 85s] Processing files: simtrace2-debugsource-0.8.0-1.1.x86_64 [ 85s] Provides: simtrace2-debugsource = 0.8.0-1.1 simtrace2-debugsource(x86-64) = 0.8.0-1.1 [ 85s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 85s] Processing files: libosmo-simtrace2-0-0.8.0-1.1.x86_64 [ 85s] error: File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 85s] [ 85s] [ 85s] RPM build errors: [ 85s] File not found: /home/abuild/rpmbuild/BUILDROOT/simtrace2-0.8.0-1.1.x86_64/usr/lib64/libosmo-simtrace2.so.0* [ 85s] ### VM INTERACTION START ### [ 88s] [ 74.291715][ T435] sysrq: Power Off [ 88s] [ 74.306350][ T144] reboot: Power down [ 88s] ### VM INTERACTION END ### [ 88s] [ 88s] lamb07 failed "build simtrace2.spec" at Fri Dec 10 23:29:39 UTC 2021. [ 88s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Sat Dec 11 09:47:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 09:47:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506 ) Change subject: BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() ...................................................................... Patch Set 2: Code-Review+2 > I discovered that we already have f_rnd_imsi()... Facepalm :D Indeed I'm surprised we don't use that everywhere, the point of implementing it back then certainly was to make sure we execute codepaths with varying IMSIs, which has impact e.g. in terms of paging group, pooling, ... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie008b5566b207b13cd562c55625bad38c09b3927 Gerrit-Change-Number: 26506 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 11 Dec 2021 09:47:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 09:48:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 09:48:03 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Osmocom_Types: fix maximum values passed to f_rnd_int() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26508 ) Change subject: library/Osmocom_Types: fix maximum values passed to f_rnd_int() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If127fc6a2feeddbdd3ea636b56dadf8957941758 Gerrit-Change-Number: 26508 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Sat, 11 Dec 2021 09:48:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 09:48:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 09:48:13 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Osmocom_Types: use f_rnd_bitstring() in f_rnd_ra11_ps() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26509 ) Change subject: library/Osmocom_Types: use f_rnd_bitstring() in f_rnd_ra11_ps() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I122d386b0c8ce320687016b6cab883b8a36bdffc Gerrit-Change-Number: 26509 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 11 Dec 2021 09:48:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 09:48:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 09:48:51 +0000 Subject: Change in docker-playground[master]: Add centos7 containers In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26497 ) Change subject: Add centos7 containers ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iadf3d0d7143c2d81ea5e87fd07a3f4cd9239cb46 Gerrit-Change-Number: 26497 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 11 Dec 2021 09:48:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 09:49:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 09:49:40 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 11 Dec 2021 09:49:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 09:51:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 09:51:18 +0000 Subject: Change in osmo-pcap[master]: configure.ac: don't depend on libosmogb. References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26510 ) Change subject: configure.ac: don't depend on libosmogb. ...................................................................... configure.ac: don't depend on libosmogb. There is nothing in osmo-pcap that relates to the Gb interface (NS/BSSGP). Change-Id: I079013b288c0585c32a3e3883a585460b4c3e616 --- M configure.ac 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/10/26510/1 diff --git a/configure.ac b/configure.ac index abba918..06c9dc2 100644 --- a/configure.ac +++ b/configure.ac @@ -158,7 +158,6 @@ dnl checks for libraries PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) -PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) PKG_CHECK_MODULES(LIBZMQ, libzmq >= 3.2.2) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I079013b288c0585c32a3e3883a585460b4c3e616 Gerrit-Change-Number: 26510 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 09:52:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 09:52:05 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... Patch Set 3: > Patch Set 3: > > > Patch Set 1: > > > > your commitlog states remove libosmonetif, but the patch also adds libosmogb (which should not be required)? > > according to configure.ac it is required, updated the commit message then configure.ac is wrong, see: https://gerrit.osmocom.org/c/osmo-pcap/+/26510 It doesn't make any sense... there is nothing NS/BSSGP inside a generic pcap capture+store system. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 11 Dec 2021 09:52:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 09:54:21 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 09:54:21 +0000 Subject: Change in osmo-pcap[master]: configure.ac: don't depend on libosmogb. In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26510 ) Change subject: configure.ac: don't depend on libosmogb. ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I079013b288c0585c32a3e3883a585460b4c3e616 Gerrit-Change-Number: 26510 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 11 Dec 2021 09:54:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 09:54:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 09:54:27 +0000 Subject: Change in osmo-pcap[master]: configure.ac: don't depend on libosmogb. In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26510 ) Change subject: configure.ac: don't depend on libosmogb. ...................................................................... configure.ac: don't depend on libosmogb. There is nothing in osmo-pcap that relates to the Gb interface (NS/BSSGP). Change-Id: I079013b288c0585c32a3e3883a585460b4c3e616 --- M configure.ac 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index abba918..06c9dc2 100644 --- a/configure.ac +++ b/configure.ac @@ -158,7 +158,6 @@ dnl checks for libraries PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) -PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) PKG_CHECK_MODULES(LIBZMQ, libzmq >= 3.2.2) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I079013b288c0585c32a3e3883a585460b4c3e616 Gerrit-Change-Number: 26510 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 09:54:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 09:54:32 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... Removed Code-Review+2 by laforge -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 11:55:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 11 Dec 2021 11:55:26 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506 ) Change subject: BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() ...................................................................... BSC_Tests: ramdomize IMSI in f_gen_test_hdlr_pars() Using the same IMSI in each test case makes it harder to correlate subscriber connections in the SUT with particular test cases. A good example is a problem described in OS#5337: some test cases create dangling subscriber entries that never got released: OsmoBSC# show subscriber all IMSI TMSI Use 001019876543210 ffffffff 3 (3*paging-start) 001010000100001 ffffffff 1 (conn) With this patch I am getting the following output: OsmoBSC# show subscriber all IMSI TMSI Use 001016017428234 ffffffff 1 (paging-start) 001014631230680 ffffffff 1 (paging-start) 001011161500382 ffffffff 1 (paging-start) 001010000100001 ffffffff 1 (conn) so I was able to correlate the following test cases: * (001016017428234) TC_lcs_loc_req_for_active_ms_ta_req, * (001014631230680) TC_lcs_loc_req_for_active_ms_le_timeout2, * (001011161500382) TC_cm_service_during_lcs_loc_req, * (001010000100001) TC_no_msc. Change-Id: Ie008b5566b207b13cd562c55625bad38c09b3927 Related: OS#5337 --- M bsc/BSC_Tests.ttcn 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index e7c4599..c2ea258 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -720,6 +720,9 @@ pars.exp_ms_power_level := mp_exp_ms_power_level; pars.mscpool.bssap_idx := bssap_idx; pars.expect_tsc := BTS_TSC[0]; + pars.imsi := f_rnd_imsi('00101'H); + + log(testcasename(), ": using IMSI ", pars.imsi); return pars; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie008b5566b207b13cd562c55625bad38c09b3927 Gerrit-Change-Number: 26506 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 11:55:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 11 Dec 2021 11:55:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Osmocom_Types: fix maximum values passed to f_rnd_int() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26508 ) Change subject: library/Osmocom_Types: fix maximum values passed to f_rnd_int() ...................................................................... library/Osmocom_Types: fix maximum values passed to f_rnd_int() It's clearly stated in a comment to this function that the returned value is 0 <= x < max, so it's always less than the maximum. Change-Id: If127fc6a2feeddbdd3ea636b56dadf8957941758 --- M library/Osmocom_Types.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn index 3c0137c..967beb4 100644 --- a/library/Osmocom_Types.ttcn +++ b/library/Osmocom_Types.ttcn @@ -65,7 +65,7 @@ } /* return hexstring composed of random digits */ -function f_rnd_hexstring(in integer len, in integer max := 15) return hexstring { +function f_rnd_hexstring(in integer len, in integer max := 16) return hexstring { var integer i; var hexstring ret := ''H; for (i := 0; i < len; i := i + 1) { @@ -79,7 +79,7 @@ var integer i; var octetstring ret := ''O; for (i := 0; i < len; i := i + 1) { - ret := ret & int2oct(f_rnd_int(255), 1); + ret := ret & int2oct(f_rnd_int(256), 1); } return ret; } @@ -91,7 +91,7 @@ } function f_rnd_imsi(in hexstring prefix) return hexstring { - return prefix & f_rnd_hexstring(15 - lengthof(prefix), 9); + return prefix & f_rnd_hexstring(15 - lengthof(prefix), 10); } function f_rnd_msisdn(in octetstring prefix, integer len := 6) return octetstring { @@ -249,7 +249,7 @@ /* generate a random 11-bit RA (packet-switched only) */ function f_rnd_ra11_ps() return BIT11 { - var integer ra11 := f_rnd_int(bit2int('11111111111'B)); + var integer ra11 := f_rnd_int(bit2int('11111111111'B) + 1); return int2bit(ra11, 11); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If127fc6a2feeddbdd3ea636b56dadf8957941758 Gerrit-Change-Number: 26508 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 11:55:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 11 Dec 2021 11:55:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/Osmocom_Types: use f_rnd_bitstring() in f_rnd_ra11_ps() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26509 ) Change subject: library/Osmocom_Types: use f_rnd_bitstring() in f_rnd_ra11_ps() ...................................................................... library/Osmocom_Types: use f_rnd_bitstring() in f_rnd_ra11_ps() Change-Id: I122d386b0c8ce320687016b6cab883b8a36bdffc --- M library/Osmocom_Types.ttcn 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn index 967beb4..472b389 100644 --- a/library/Osmocom_Types.ttcn +++ b/library/Osmocom_Types.ttcn @@ -249,8 +249,7 @@ /* generate a random 11-bit RA (packet-switched only) */ function f_rnd_ra11_ps() return BIT11 { - var integer ra11 := f_rnd_int(bit2int('11111111111'B) + 1); - return int2bit(ra11, 11); + return f_rnd_bitstring(11); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I122d386b0c8ce320687016b6cab883b8a36bdffc Gerrit-Change-Number: 26509 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 15:16:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 15:16:30 +0000 Subject: Change in osmo-ci[master]: jobs/ttcn3-testsuites: add centos7 pcap-client In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26500 ) Change subject: jobs/ttcn3-testsuites: add centos7 pcap-client ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6cab8f919efd94b4d7c2664fd131f7210aac86a6 Gerrit-Change-Number: 26500 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 11 Dec 2021 15:16:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 15:16:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 15:16:35 +0000 Subject: Change in osmo-ci[master]: jobs/ttcn3-testsuites: add centos7 pcap-client In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26500 ) Change subject: jobs/ttcn3-testsuites: add centos7 pcap-client ...................................................................... jobs/ttcn3-testsuites: add centos7 pcap-client Depends: docker-playground I775776ff7f358fee3d085f814c295c49225f5170 Closes: SYS#5754 Change-Id: I6cab8f919efd94b4d7c2664fd131f7210aac86a6 --- M jobs/ttcn3-testsuites.yml 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 515ac10..854a5fb 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -213,6 +213,16 @@ # Jobs below use uppercase TTCN3-$DISTRO, so they get listed separately from the ttcn3-* (debian-stretch) jobs + # centos7 nightly + - TTCN3-centos7-pcap-client-test: + blocking: "^(ttcn3|TTCN3-.*)-pcap-client-test.*" + timer: 10 13 * * * + + # centos7 latest + - TTCN3-centos7-pcap-client-test-latest: + blocking: "^(ttcn3|TTCN3-.*)-ggsn-test.*" + timer: 40 13 * * * + # centos8 nightly - TTCN3-centos-ggsn-test: blocking: "^(ttcn3|TTCN3-.*)-ggsn-test.*" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6cab8f919efd94b4d7c2664fd131f7210aac86a6 Gerrit-Change-Number: 26500 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 15:16:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 15:16:52 +0000 Subject: Change in docker-playground[master]: Add centos7 containers In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26497 ) Change subject: Add centos7 containers ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iadf3d0d7143c2d81ea5e87fd07a3f4cd9239cb46 Gerrit-Change-Number: 26497 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 11 Dec 2021 15:16:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 11 15:16:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 11 Dec 2021 15:16:54 +0000 Subject: Change in docker-playground[master]: Add centos7 containers In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26497 ) Change subject: Add centos7 containers ...................................................................... Add centos7 containers Related: SYS#5754 Change-Id: Iadf3d0d7143c2d81ea5e87fd07a3f4cd9239cb46 --- A centos7-build/Dockerfile A centos7-build/Makefile A centos7-obs-latest/Dockerfile A centos7-obs-latest/Makefile M jenkins-common.sh 5 files changed, 115 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved; Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve diff --git a/centos7-build/Dockerfile b/centos7-build/Dockerfile new file mode 100644 index 0000000..2e04efb --- /dev/null +++ b/centos7-build/Dockerfile @@ -0,0 +1,65 @@ +ARG REGISTRY=docker.io +ARG UPSTREAM_DISTRO=centos:centos7 +FROM ${REGISTRY}/${UPSTREAM_DISTRO} +# Arguments used after FROM must be specified again +ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" +ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" + +# Use dnf package manager instead of yum, so we can use all the dnf codepaths +# that were originally written for CentOS8 in this CentOS7 image too +RUN yum install -y dnf + +# Let package metadata expire after 60 seconds instead of 48 hours +RUN echo "metadata_expire=60" >> /etc/dnf/dnf.conf && cat /etc/dnf/dnf.conf + +# Set up Osmocom OBS repository +RUN export MIRROR_HTTPS="$(echo $OSMOCOM_REPO_MIRROR | sed s/^http:/https:/)" && \ + { echo "[network_osmocom_nightly]"; \ + echo "name=Nightly packages of the Osmocom project (CentOS_7)"; \ + echo "type=rpm-md"; \ + echo "baseurl=${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/nightly/CentOS_7/"; \ + echo "gpgcheck=1"; \ + echo "gpgkey=${MIRROR_HTTPS}/${OSMOCOM_REPO_PATH}/nightly/CentOS_7/repodata/repomd.xml.key"; \ + echo "enabled=1"; \ + } > /etc/yum.repos.d/network:osmocom:nightly.repo + +RUN dnf install -y \ + autoconf \ + autoconf-archive \ + autogen \ + automake \ + bison \ + c-ares-devel \ + doxygen \ + fftw-devel \ + flex \ + gawk \ + gcc \ + gcc-c++ \ + git \ + gnupg \ + gnutls-devel \ + gsm-devel \ + libdbi-dbd-sqlite \ + libdbi-devel \ + libpcap-devel \ + libtalloc-devel \ + libtool \ + libusb1-devel \ + lksctp-tools-devel \ + make \ + ncurses-devel \ + openssl-devel \ + ortp-devel \ + pcsc-lite-devel \ + pkgconfig \ + readline-devel \ + sqlite \ + sqlite-devel \ + telnet + +# Make respawn.sh part of this image, so it can be used by other images based on it +COPY .common/respawn.sh /usr/local/bin/respawn.sh + +# Invalidate cache once the repository is updated +ADD ${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/nightly/CentOS_7/repodata/repomd.xml /tmp/repomd.xml diff --git a/centos7-build/Makefile b/centos7-build/Makefile new file mode 100644 index 0000000..f93f5c0 --- /dev/null +++ b/centos7-build/Makefile @@ -0,0 +1,3 @@ +UPSTREAM_DISTRO:=centos:centos7 +DISTRO:=centos7 +include ../make/Makefile diff --git a/centos7-obs-latest/Dockerfile b/centos7-obs-latest/Dockerfile new file mode 100644 index 0000000..dfe12fc --- /dev/null +++ b/centos7-obs-latest/Dockerfile @@ -0,0 +1,34 @@ +ARG REGISTRY=docker.io +ARG UPSTREAM_DISTRO=centos:centos7 +FROM ${REGISTRY}/${UPSTREAM_DISTRO} +# Arguments used after FROM must be specified again +ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" +ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO_VERSION="latest" + +# Use dnf package manager instead of yum, so we can use all the dnf codepaths +# that were originally written for CentOS8 in this CentOS7 image too +RUN yum install -y dnf + +# Let package metadata expire after 60 seconds instead of 48 hours +RUN echo "metadata_expire=60" >> /etc/dnf/dnf.conf && cat /etc/dnf/dnf.conf + +# Set up Osmocom OBS repository +RUN export MIRROR_HTTPS="$(echo $OSMOCOM_REPO_MIRROR | sed s/^http:/https:/)" && \ + { echo "[network_osmocom_${OSMOCOM_REPO_VERSION}]"; \ + echo "name=Osmocom ${OSMOCOM_REPO_VERSION}"; \ + echo "type=rpm-md"; \ + echo "baseurl=${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/${OSMOCOM_REPO_VERSION}/CentOS_7/"; \ + echo "gpgcheck=1"; \ + echo "gpgkey=${MIRROR_HTTPS}/${OSMOCOM_REPO_PATH}/${OSMOCOM_REPO_VERSION}/CentOS_7/repodata/repomd.xml.key"; \ + echo "enabled=1"; \ + } > "/etc/yum.repos.d/network:osmocom:${OSMOCOM_REPO_VERSION}.repo" + +RUN dnf install -y \ + telnet + +# Make respawn.sh part of this image, so it can be used by other images based on it +COPY .common/respawn.sh /usr/local/bin/respawn.sh + +# Invalidate cache once the repository is updated +ADD ${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/${OSMOCOM_REPO_VERSION}/CentOS_7/repodata/repomd.xml /tmp/repomd.xml diff --git a/centos7-obs-latest/Makefile b/centos7-obs-latest/Makefile new file mode 100644 index 0000000..f93f5c0 --- /dev/null +++ b/centos7-obs-latest/Makefile @@ -0,0 +1,3 @@ +UPSTREAM_DISTRO:=centos:centos7 +DISTRO:=centos7 +include ../make/Makefile diff --git a/jenkins-common.sh b/jenkins-common.sh index 3511c02..9373076 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -15,7 +15,9 @@ feed="$(echo "$feed" | sed 's/\-centos8$//')" # e.g. "2021q1" echo "centos8-obs-$feed" ;; + osmo-*-latest-centos7) echo "centos7-obs-latest" ;; osmo-*-latest-centos8) echo "centos8-obs-latest" ;; + osmo-*-centos7) echo "centos7-build" ;; osmo-*-centos8) echo "centos8-build" ;; osmo-*-latest) echo "debian-stretch-obs-latest" ;; osmo-*) echo "debian-stretch-build" ;; @@ -25,7 +27,9 @@ docker_distro_from_image_name() { case "$1" in + osmo-*-centos7) echo "centos7" ;; osmo-*-centos8) echo "centos8" ;; + centos7-*) echo "centos7" ;; centos8-*) echo "centos8" ;; *) echo "debian-stretch" ;; esac @@ -33,7 +37,9 @@ docker_upstream_distro_from_image_name() { case "$1" in + osmo-*-centos7) echo "centos:centos7"; ;; osmo-*-centos8) echo "centos:centos8"; ;; + centos7-*) echo "centos:centos7" ;; centos8-*) echo "centos:centos8" ;; debian10-*) echo "debian:buster" ;; *) echo "debian:stretch" ;; @@ -46,6 +52,10 @@ # e.g. osmo-mgw-2021q1-centos8 -> osmo-mgw-latest echo "$1" | sed 's/20[0-9][0-9]q.*\-centos8$/latest/' ;; + osmo-*-centos7) + # e.g. osmo-mgw-latest-centos7 -> osmo-mgw-latest + echo "$1" | sed 's/\-centos7$//' + ;; osmo-*-centos8) # e.g. osmo-mgw-latest-centos8 -> osmo-mgw-latest echo "$1" | sed 's/\-centos8$//' -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26497 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iadf3d0d7143c2d81ea5e87fd07a3f4cd9239cb46 Gerrit-Change-Number: 26497 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 01:42:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 01:42:32 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: introduce c_def_{hbh, ete}_id constants References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 ) Change subject: library/DIAMETER_Templates: introduce c_def_{hbh,ete}_id constants ...................................................................... library/DIAMETER_Templates: introduce c_def_{hbh,ete}_id constants Change-Id: I714b18bbe77949593803e999d25e4ef8e1827917 Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/26511/1 diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 2cc2986..8e7ae51 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -106,12 +106,15 @@ const uint32_t c_DIAMETER_3GPP_S13_AID := 16777252; const uint32_t c_DIAMETER_3GPP_S7_AID := 16777308; +const UINT32 c_def_hbh_id := '00000000'O; +const UINT32 c_def_ete_id := '00000000'O; + template (value) PDU_DIAMETER ts_DIAMETER(template (value) BIT8 flags, template (value) Command_Code cmd_code, template (value) OCTET4 app_id := '00000000'O, - template (value) UINT32 hbh_id, - template (value) UINT32 ete_id, + template (value) UINT32 hbh_id := c_def_hbh_id, + template (value) UINT32 ete_id := c_def_ete_id, template (value) AVP_list avps := {} ) := { version := 1, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I714b18bbe77949593803e999d25e4ef8e1827917 Gerrit-Change-Number: 26511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 01:42:33 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 01:42:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add templates for DWR/DWA References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26512 ) Change subject: library/DIAMETER_Templates: add templates for DWR/DWA ...................................................................... library/DIAMETER_Templates: add templates for DWR/DWA Change-Id: I2abe33a3ac08c8855342f4277288cacb3545771b Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 86 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/12/26512/1 diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 8e7ae51..920a30c 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -247,6 +247,14 @@ } } } +template (present) GenericAVP tr_AVP_OriginStateId(template (present) OCTET4 state_id := ?) := { + avp := { + avp_header := tr_DIA_Hdr(c_AVP_Code_BASE_NONE_Origin_State_Id), + avp_data := { + avp_BASE_NONE_Origin_State_Id := state_id + } + } +} template (value) GenericAVP ts_AVP_HostIpAddr(template (value) OCTET4 ipv4_addr) := { avp := { @@ -394,6 +402,14 @@ } } } +template (present) GenericAVP tr_AVP_ResultCode(DIAMETER_Resultcode res_code) := { + avp := { + avp_header := tr_DIA_Hdr(c_AVP_Code_BASE_NONE_Result_Code), + avp_data := { + avp_BASE_NONE_Result_Code := int2oct(enum2int(res_code), 4) + } + } +} template (value) GenericAVP ts_AVP_AuthSessionState(template (value) BASE_NONE_Auth_Session_State ass := NO_STATE_MAINTAINED) := { avp := { @@ -966,4 +982,74 @@ // origin }); +/* RFC 6733, section 5.5.1 "Device-Watchdog-Request" */ +template (value) PDU_DIAMETER +ts_DIA_DWR(template (value) OCTET4 state_id := '00000000'O, + template (value) charstring orig_host := "ttcn3.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) UINT32 hbh_id := c_def_hbh_id, + template (value) UINT32 ete_id := c_def_ete_id) := + ts_DIAMETER(flags := '10000000'B, + cmd_code := Device_Watchdog, + app_id := '00000000'O, + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_OriginStateId(state_id) + }); +template (present) PDU_DIAMETER +tr_DIA_DWR(template (present) OCTET4 state_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '1???????'B, + cmd_code := Device_Watchdog, + app_id := '00000000'O, + hbh_id := hbh_id, + ete_id := ete_id, + avps := superset( + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm), + tr_AVP_OriginStateId(state_id) + )); + +/* RFC 6733, section 5.5.2 "Device-Watchdog-Answer" */ +template (value) PDU_DIAMETER +ts_DIA_DWA(template (value) OCTET4 state_id := '00000000'O, + template (value) charstring orig_host := "ttcn3.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) UINT32 hbh_id := c_def_hbh_id, + template (value) UINT32 ete_id := c_def_ete_id) := + ts_DIAMETER(flags := '00000000'B, + cmd_code := Device_Watchdog, + app_id := '00000000'O, + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_ResultCode(DIAMETER_SUCCESS), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_OriginStateId(state_id) + }); +template (present) PDU_DIAMETER +tr_DIA_DWA(template (present) OCTET4 state_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '0???????'B, + cmd_code := Device_Watchdog, + app_id := '00000000'O, + hbh_id := hbh_id, + ete_id := ete_id, + avps := superset( + tr_AVP_ResultCode(DIAMETER_SUCCESS), + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm), + tr_AVP_OriginStateId(state_id) + )); + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2abe33a3ac08c8855342f4277288cacb3545771b Gerrit-Change-Number: 26512 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 01:42:33 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 01:42:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: enrich existing ULR/ULA templates References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 ) Change subject: library/DIAMETER_Templates: enrich existing ULR/ULA templates ...................................................................... library/DIAMETER_Templates: enrich existing ULR/ULA templates Change-Id: I0585e306a87453c212c6b5ac5635181c47b34b4f Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn M mme/MME_Tests.ttcn 2 files changed, 45 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/13/26513/1 diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 920a30c..795148c 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -106,6 +106,7 @@ const uint32_t c_DIAMETER_3GPP_S13_AID := 16777252; const uint32_t c_DIAMETER_3GPP_S7_AID := 16777308; +const octetstring c_def_sess_id := char2oct("ttcn3.session"); const UINT32 c_def_hbh_id := '00000000'O; const UINT32 c_def_ete_id := '00000000'O; @@ -911,34 +912,50 @@ /* TS 29.262 7.2.3 Update Location Request */ template (present) PDU_DIAMETER -tr_DIA_ULR(hexstring imsi) := tr_DIAMETER(flags:='11000000'B, cmd_code:=Update_Location, - app_id:=int2oct(c_DIAMETER_3GPP_S6_AID, 4), - avps := superset( - tr_AVP_SessionId, - tr_AVP_AuthSessionState, - tr_AVP_OriginHost, - tr_AVP_OriginRealm, - tr_AVP_DestinationRealm, - tr_AVP_UserNameImsi(imsi), - tr_AVP_3GPP_RatType(EUTRAN), - tr_AVP_3GPP_UlrFlags, - tr_AVP_3GPP_VisitedPlmnId +tr_DIA_ULR(/* template (present) */ hexstring imsi, + template (present) octetstring sess_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) charstring dest_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '11000000'B, + cmd_code := Update_Location, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + tr_AVP_AuthSessionState, + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm), + tr_AVP_DestinationRealm(dest_realm), + tr_AVP_UserNameImsi(imsi), + tr_AVP_3GPP_RatType(EUTRAN), + tr_AVP_3GPP_UlrFlags, + tr_AVP_3GPP_VisitedPlmnId )); template (value) PDU_DIAMETER -ts_DIA_ULA(template (value) UINT32 hbh_id, template (value) UINT32 ete_id, - template (value) octetstring sess_id, - template (value) AVP_list sub_data_content) -:= ts_DIAMETER(flags:='01000000'B, cmd_code:=Update_Location, - app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), hbh_id:=hbh_id, ete_id:=ete_id, - avps := { - ts_AVP_SessionId(sess_id), - ts_AVP_ResultCode(DIAMETER_SUCCESS), /* optional */ - ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), - ts_AVP_OriginHost("hss.localdomain"), - ts_AVP_OriginRealm("localdomain"), - ts_AVP_3GPP_UlaFlags('00000002'O), - ts_AVP_3GPP_SubscriptionData(sub_data_content) +ts_DIA_ULA(template (value) AVP_list sub_data, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "hss.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) UINT32 hbh_id := c_def_hbh_id, + template (value) UINT32 ete_id := c_def_ete_id) := + ts_DIAMETER(flags:='01000000'B, + cmd_code := Update_Location, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + ts_AVP_ResultCode(DIAMETER_SUCCESS), /* optional */ + ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_3GPP_UlaFlags('00000002'O), + ts_AVP_3GPP_SubscriptionData(sub_data) }); diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index f9bcf6d..2140971 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -493,14 +493,12 @@ var PDU_DIAMETER rx_dia; [] DIAMETER.receive(tr_DIA_ULR(g_pars.ue_pars.imsi)) -> value rx_dia { var template (omit) AVP avp; - var octetstring sess_id; var hexstring imsi; var template (value) AVP_list sub_data; /* retrieve input data */ imsi := valueof(f_DIAMETER_get_imsi(rx_dia)); avp := f_DIAMETER_get_avp(rx_dia, c_AVP_Code_BASE_NONE_Session_Id); - sess_id := valueof(avp.avp_data.avp_BASE_NONE_Session_Id); sub_data := { ts_AVP_3GPP_SubscriberStatus(SERVICE_GRANTED), @@ -513,7 +511,9 @@ }) }; - DIAMETER.send(ts_DIA_ULA(rx_dia.hop_by_hop_id, rx_dia.end_to_end_id, sess_id, sub_data)); + DIAMETER.send(ts_DIA_ULA(sub_data, avp.avp_data.avp_BASE_NONE_Session_Id, + hbh_id := rx_dia.hop_by_hop_id, + ete_id := rx_dia.end_to_end_id)); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0585e306a87453c212c6b5ac5635181c47b34b4f Gerrit-Change-Number: 26513 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 01:42:33 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 01:42:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add missing templates for ULR/ULA References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26514 ) Change subject: library/DIAMETER_Templates: add missing templates for ULR/ULA ...................................................................... library/DIAMETER_Templates: add missing templates for ULR/ULA Change-Id: If0b8daf5717eb4c26da231489118e200faeee9a2 Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 54 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/26514/1 diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 795148c..a70c59a 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -562,6 +562,15 @@ } } } +template (present) GenericAVP +tr_AVP_3GPP_SubscriptionData(template (present) AVP_list content := ?) := { + avp := { + avp_header := tr_DIA_Hdr_3GPP(c_AVP_Code_AAA_3GPP_Subscription_Data), + avp_data := { + avp_AAA_3GPP_Subscription_Data := content + } + } +} /* TS 29.262 7.3.17 Authentication-Info */ @@ -911,6 +920,30 @@ /* TS 29.262 7.2.3 Update Location Request */ +template (value) PDU_DIAMETER +ts_DIA_ULR(/* template (value) */ hexstring imsi, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "ttcn3.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) charstring dest_realm := "localdomain", + template (value) UINT32 hbh_id := c_def_hbh_id, + template (value) UINT32 ete_id := c_def_ete_id) := + ts_DIAMETER(flags := '11000000'B, + cmd_code := Update_Location, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), + ts_AVP_UserNameImsi(imsi), + ts_AVP_3GPP_UlrFlags('00000000'O), + ts_AVP_3GPP_VisitedPlmnId('11111F'O), + ts_AVP_3GPP_RatType(EUTRAN), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_DestinationRealm(dest_realm) + }); template (present) PDU_DIAMETER tr_DIA_ULR(/* template (present) */ hexstring imsi, template (present) octetstring sess_id := ?, @@ -957,6 +990,27 @@ ts_AVP_3GPP_UlaFlags('00000002'O), ts_AVP_3GPP_SubscriptionData(sub_data) }); +template (present) PDU_DIAMETER +tr_DIA_ULA(template (present) AVP_list sub_data := ?, + template (present) octetstring sess_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '0???????'B, + cmd_code := Update_Location, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + tr_AVP_ResultCode(DIAMETER_SUCCESS), + tr_AVP_AuthSessionState, + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm), + tr_AVP_3GPP_UlaFlags, + tr_AVP_3GPP_SubscriptionData(sub_data) + )); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0b8daf5717eb4c26da231489118e200faeee9a2 Gerrit-Change-Number: 26514 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 01:42:34 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 01:42:34 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: prettify & enrich AIR/AIA templates References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26515 ) Change subject: library/DIAMETER_Templates: prettify & enrich AIR/AIA templates ...................................................................... library/DIAMETER_Templates: prettify & enrich AIR/AIA templates Change-Id: Iaf6472fecbadd58e86b78c59348d9924ab57f97d Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn M mme/MME_Tests.ttcn 2 files changed, 51 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/26515/1 diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index a70c59a..9271166 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -879,43 +879,60 @@ template (value) PDU_DIAMETER -ts_DIA_AIR(template (value) UINT32 hbh_id, template (value) UINT32 ete_id, - template (value) octetstring sess_id, - template (value) charstring dest_realm, hexstring imsi) -:= ts_DIAMETER(flags:='00000000'B, cmd_code:=Authentication_Information, hbh_id:=hbh_id, ete_id:=ete_id, - avps := { - ts_AVP_SessionId(sess_id), - ts_AVP_DestinationRealm(dest_realm), - ts_AVP_UserNameImsi(imsi), - /* Requested EUTRAN Auth Info */ - ts_AVP_RequestedEutranAuthInfo, - ts_AVP_3GPP_VisitedPlmnId('11111F'O) +ts_DIA_AIR(/* template (value) */ hexstring imsi, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring dest_realm := "localdomain", + template (value) UINT32 hbh_id := c_def_hbh_id, + template (value) UINT32 ete_id := c_def_ete_id) := + ts_DIAMETER(flags := '00000000'B, + cmd_code := Authentication_Information, + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + ts_AVP_DestinationRealm(dest_realm), + ts_AVP_UserNameImsi(imsi), + /* Requested EUTRAN Auth Info */ + ts_AVP_RequestedEutranAuthInfo, + ts_AVP_3GPP_VisitedPlmnId('11111F'O) }); - template (present) PDU_DIAMETER -tr_DIA_AIR(hexstring imsi) := tr_DIAMETER(flags := '11000000'B, cmd_code:=Authentication_Information, - app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), - avps := superset( - tr_AVP_SessionId, - tr_AVP_DestinationRealm, - tr_AVP_UserNameImsi(imsi), - tr_AVP_3GPP_VisitedPlmnId +tr_DIA_AIR(/* template (present) */ hexstring imsi, + template (present) octetstring sess_id := ?, + template (present) charstring dest_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '11000000'B, + cmd_code := Authentication_Information, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + tr_AVP_DestinationRealm(dest_realm), + tr_AVP_UserNameImsi(imsi), + tr_AVP_3GPP_VisitedPlmnId )); /* TS 29.262 5.2.3.1 + 7.2.6 Authentication Information Answer */ template (value) PDU_DIAMETER -ts_DIA_AIA(template (value) UINT32 hbh_id, template (value) UINT32 ete_id, - template (value) octetstring sess_id, - template (value) AVP_list auth_info_contents) -:= ts_DIAMETER(flags:='01000000'B, cmd_code:=Authentication_Information, - app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), hbh_id:=hbh_id, ete_id:=ete_id, - avps := { - ts_AVP_SessionId(sess_id), - ts_AVP_ResultCode(DIAMETER_SUCCESS), - ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), - ts_AVP_OriginHost("hss.localdomain"), - ts_AVP_OriginRealm("localdomain"), - ts_AVP_3GPP_AuthInfo(auth_info_contents) +ts_DIA_AIA(template (value) AVP_list auth_info_contents, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "hss.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) UINT32 hbh_id := c_def_hbh_id, + template (value) UINT32 ete_id := c_def_ete_id) := + ts_DIAMETER(flags := '01000000'B, + cmd_code := Authentication_Information, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + ts_AVP_ResultCode(DIAMETER_SUCCESS), + ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_3GPP_AuthInfo(auth_info_contents) }); diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 2140971..375a66a 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -483,8 +483,9 @@ /* compute tuple */ auth_info_content := { ts_AVP_EutranVec(1, '20080c3818183b522614162c07601d0d'O, '6a91970e838fd079'O, 'f11b89a2a8be00001f9c526f3d75d44c'O, '95AFAD9A0D29AFAA079A9451DF7161D7EE4CBF2AF9387F766D058BB6B44B905D'O) }; - DIAMETER.send(ts_DIA_AIA(rx_dia.hop_by_hop_id, rx_dia.end_to_end_id, - sess_id, auth_info_content)); + DIAMETER.send(ts_DIA_AIA(auth_info_content, sess_id, + hbh_id := rx_dia.hop_by_hop_id, + ete_id := rx_dia.end_to_end_id)); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf6472fecbadd58e86b78c59348d9924ab57f97d Gerrit-Change-Number: 26515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 01:42:35 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 01:42:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add receive template for AIA References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26516 ) Change subject: library/DIAMETER_Templates: add receive template for AIA ...................................................................... library/DIAMETER_Templates: add receive template for AIA Change-Id: Ie4aca42c3024aa7f46123b2df4a42c5d43f5b9da Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/26516/1 diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 9271166..ef0f3d7 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -582,6 +582,15 @@ } } } +template (present) GenericAVP +tr_AVP_3GPP_AuthInfo(template (present) AVP_list content := ?) := { + avp := { + avp_header := tr_DIA_Hdr_3GPP(c_AVP_Code_AAA_3GPP_Authentication_Info), + avp_data := { + avp_AAA_3GPP_Authentication_Info := content + } + } +} /* TS 29.262 7.3.9 Visited-PLMN-Id */ template (value) GenericAVP ts_AVP_3GPP_VisitedPlmnId(template (value) octetstring id) := { @@ -934,6 +943,26 @@ ts_AVP_OriginRealm(orig_realm), ts_AVP_3GPP_AuthInfo(auth_info_contents) }); +template (present) PDU_DIAMETER +tr_DIA_AIA(template (present) AVP_list auth_info_contents := ?, + template (present) octetstring sess_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '0???????'B, + cmd_code := Authentication_Information, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + tr_AVP_ResultCode(DIAMETER_SUCCESS), + tr_AVP_AuthSessionState(NO_STATE_MAINTAINED), + tr_AVP_3GPP_AuthInfo(auth_info_contents), + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm) + )); /* TS 29.262 7.2.3 Update Location Request */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4aca42c3024aa7f46123b2df4a42c5d43f5b9da Gerrit-Change-Number: 26516 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 01:42:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 01:42:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: fix flags in AIR templates References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 ) Change subject: library/DIAMETER_Templates: fix flags in AIR templates ...................................................................... library/DIAMETER_Templates: fix flags in AIR templates Change-Id: I7db3b632189eed09c1bdf98f9d588491d928e2f5 Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/26517/1 diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index ef0f3d7..da30498 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -893,7 +893,7 @@ template (value) charstring dest_realm := "localdomain", template (value) UINT32 hbh_id := c_def_hbh_id, template (value) UINT32 ete_id := c_def_ete_id) := - ts_DIAMETER(flags := '00000000'B, + ts_DIAMETER(flags := '11000000'B, cmd_code := Authentication_Information, hbh_id := hbh_id, ete_id := ete_id, @@ -911,7 +911,7 @@ template (present) charstring dest_realm := ?, template (present) UINT32 hbh_id := ?, template (present) UINT32 ete_id := ?) := - tr_DIAMETER(flags := '11000000'B, + tr_DIAMETER(flags := '1???????'B, cmd_code := Authentication_Information, app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), hbh_id := hbh_id, ete_id := ete_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7db3b632189eed09c1bdf98f9d588491d928e2f5 Gerrit-Change-Number: 26517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 01:42:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 01:42:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: fix missing app_id in ts_DIA_AIR References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26518 ) Change subject: library/DIAMETER_Templates: fix missing app_id in ts_DIA_AIR ...................................................................... library/DIAMETER_Templates: fix missing app_id in ts_DIA_AIR Change-Id: I7b06d9cad09f1fd7858bd745d0aaa2fbcb1983dd Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/26518/1 diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index da30498..f12c37a 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -895,6 +895,7 @@ template (value) UINT32 ete_id := c_def_ete_id) := ts_DIAMETER(flags := '11000000'B, cmd_code := Authentication_Information, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), hbh_id := hbh_id, ete_id := ete_id, avps := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b06d9cad09f1fd7858bd745d0aaa2fbcb1983dd Gerrit-Change-Number: 26518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 01:42:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 01:42:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add missing AVPs to AIR References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26519 ) Change subject: library/DIAMETER_Templates: add missing AVPs to AIR ...................................................................... library/DIAMETER_Templates: add missing AVPs to AIR Change-Id: I948072dbfa05d158483a727fb708f853741ab23f Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/26519/1 diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index f12c37a..2cce568 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -890,6 +890,8 @@ template (value) PDU_DIAMETER ts_DIA_AIR(/* template (value) */ hexstring imsi, template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "ttcn3.localdomain", + template (value) charstring orig_realm := "localdomain", template (value) charstring dest_realm := "localdomain", template (value) UINT32 hbh_id := c_def_hbh_id, template (value) UINT32 ete_id := c_def_ete_id) := @@ -901,9 +903,12 @@ avps := { ts_AVP_SessionId(sess_id), ts_AVP_DestinationRealm(dest_realm), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), ts_AVP_UserNameImsi(imsi), /* Requested EUTRAN Auth Info */ ts_AVP_RequestedEutranAuthInfo, + ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), ts_AVP_3GPP_VisitedPlmnId('11111F'O) }); template (present) PDU_DIAMETER -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I948072dbfa05d158483a727fb708f853741ab23f Gerrit-Change-Number: 26519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 01:42:37 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 01:42:37 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: handle DWR/DWA ping-pong References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26520 ) Change subject: library/DIAMETER_Emulation: handle DWR/DWA ping-pong ...................................................................... library/DIAMETER_Emulation: handle DWR/DWA ping-pong Change-Id: I0291eccd0467f8fe15ddcb88259618365c33befd Related: SYS#5602 --- M library/DIAMETER_Emulation.ttcn 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/26520/1 diff --git a/library/DIAMETER_Emulation.ttcn b/library/DIAMETER_Emulation.ttcn index f7a0f88..220ab11 100644 --- a/library/DIAMETER_Emulation.ttcn +++ b/library/DIAMETER_Emulation.ttcn @@ -328,6 +328,14 @@ /* notify our user that the CER->CEA exchange has happened */ DIAMETER_UNIT.send(DiameterCapabilityExchgInd:{rx:=mrf.msg, tx:=valueof(resp)}); } + /* handle DWR/DWA ping-pong */ + [] DIAMETER.receive(tr_DIAMETER_RecvFrom_R(tr_DIA_DWR)) -> value mrf { + var template (value) PDU_DIAMETER resp; + resp := ts_DIA_DWA('00000001'O, p.origin_host, p.origin_realm, + hbh_id := mrf.msg.hop_by_hop_id, + ete_id := mrf.msg.end_to_end_id); + DIAMETER.send(t_DIAMETER_Send(g_diameter_conn_id, valueof(resp))); + } /* DIAMETER from remote peer */ [] DIAMETER.receive(tr_DIAMETER_RecvFrom_R(?)) -> value mrf { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0291eccd0467f8fe15ddcb88259618365c33befd Gerrit-Change-Number: 26520 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 01:42:37 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 01:42:37 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: implement direct mode of operation References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 ) Change subject: library/DIAMETER_Emulation: implement direct mode of operation ...................................................................... library/DIAMETER_Emulation: implement direct mode of operation Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Related: SYS#5602 --- M library/DIAMETER_Emulation.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/26521/1 diff --git a/library/DIAMETER_Emulation.ttcn b/library/DIAMETER_Emulation.ttcn index 220ab11..33c93e1 100644 --- a/library/DIAMETER_Emulation.ttcn +++ b/library/DIAMETER_Emulation.ttcn @@ -94,7 +94,8 @@ type record DIAMETEROps { DIAMETERCreateCallback create_cb, - DIAMETERUnitdataCallback unitdata_cb + DIAMETERUnitdataCallback unitdata_cb, + boolean direct } type record DIAMETER_conn_parameters { @@ -337,6 +338,15 @@ DIAMETER.send(t_DIAMETER_Send(g_diameter_conn_id, valueof(resp))); } + /* DIAMETER from the test suite */ + [ops.direct] DIAMETER_UNIT.receive(PDU_DIAMETER:?) -> value msg { + DIAMETER.send(t_DIAMETER_Send(g_diameter_conn_id, msg)); + } + /* DIAMETER from remote peer */ + [ops.direct] DIAMETER.receive(tr_DIAMETER_RecvFrom_R(?)) -> value mrf { + DIAMETER_UNIT.send(mrf.msg); + } + /* DIAMETER from remote peer */ [] DIAMETER.receive(tr_DIAMETER_RecvFrom_R(?)) -> value mrf { imsi_t := f_DIAMETER_get_imsi(mrf.msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Gerrit-Change-Number: 26521 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 01:42:37 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 01:42:37 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26522 ) Change subject: MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason ...................................................................... MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason Change-Id: Iaa39a1c1c6c6774f04d643e91bc79666da9d56a6 --- M mme/MME_Tests.ttcn 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/26522/1 diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 375a66a..a83b0df 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -494,11 +494,9 @@ var PDU_DIAMETER rx_dia; [] DIAMETER.receive(tr_DIA_ULR(g_pars.ue_pars.imsi)) -> value rx_dia { var template (omit) AVP avp; - var hexstring imsi; var template (value) AVP_list sub_data; /* retrieve input data */ - imsi := valueof(f_DIAMETER_get_imsi(rx_dia)); avp := f_DIAMETER_get_avp(rx_dia, c_AVP_Code_BASE_NONE_Session_Id); sub_data := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaa39a1c1c6c6774f04d643e91bc79666da9d56a6 Gerrit-Change-Number: 26522 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:24:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:24:50 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: introduce c_def_{hbh, ete}_id constants In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 ) Change subject: library/DIAMETER_Templates: introduce c_def_{hbh,ete}_id constants ...................................................................... Patch Set 1: not sure how useful it is to have a constant default value for those, as any Diameter procedure will need to use different values for those from any other diameter procedures before and after... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I714b18bbe77949593803e999d25e4ef8e1827917 Gerrit-Change-Number: 26511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:24:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:25:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:25:17 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add templates for DWR/DWA In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26512 ) Change subject: library/DIAMETER_Templates: add templates for DWR/DWA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2abe33a3ac08c8855342f4277288cacb3545771b Gerrit-Change-Number: 26512 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:25:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:26:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:26:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: enrich existing ULR/ULA templates In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 ) Change subject: library/DIAMETER_Templates: enrich existing ULR/ULA templates ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0585e306a87453c212c6b5ac5635181c47b34b4f Gerrit-Change-Number: 26513 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:26:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:26:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:26:44 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add missing templates for ULR/ULA In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26514 ) Change subject: library/DIAMETER_Templates: add missing templates for ULR/ULA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0b8daf5717eb4c26da231489118e200faeee9a2 Gerrit-Change-Number: 26514 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:26:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:27:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:27:42 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: prettify & enrich AIR/AIA templates In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26515 ) Change subject: library/DIAMETER_Templates: prettify & enrich AIR/AIA templates ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf6472fecbadd58e86b78c59348d9924ab57f97d Gerrit-Change-Number: 26515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:27:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:27:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:27:54 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add receive template for AIA In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26516 ) Change subject: library/DIAMETER_Templates: add receive template for AIA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4aca42c3024aa7f46123b2df4a42c5d43f5b9da Gerrit-Change-Number: 26516 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:27:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:28:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:28:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: fix flags in AIR templates In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 ) Change subject: library/DIAMETER_Templates: fix flags in AIR templates ...................................................................... Patch Set 1: Code-Review+1 comment or commit log with spec reference might have been nice. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7db3b632189eed09c1bdf98f9d588491d928e2f5 Gerrit-Change-Number: 26517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:28:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:28:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:28:41 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: fix missing app_id in ts_DIA_AIR In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26518 ) Change subject: library/DIAMETER_Templates: fix missing app_id in ts_DIA_AIR ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b06d9cad09f1fd7858bd745d0aaa2fbcb1983dd Gerrit-Change-Number: 26518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:28:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:29:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:29:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add missing AVPs to AIR In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26519 ) Change subject: library/DIAMETER_Templates: add missing AVPs to AIR ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I948072dbfa05d158483a727fb708f853741ab23f Gerrit-Change-Number: 26519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:29:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:29:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:29:54 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: handle DWR/DWA ping-pong In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26520 ) Change subject: library/DIAMETER_Emulation: handle DWR/DWA ping-pong ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0291eccd0467f8fe15ddcb88259618365c33befd Gerrit-Change-Number: 26520 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:29:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:31:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:31:16 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: implement direct mode of operation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 ) Change subject: library/DIAMETER_Emulation: implement direct mode of operation ...................................................................... Patch Set 1: definitely needs some documentation in the code -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Gerrit-Change-Number: 26521 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:31:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:31:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:31:41 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26522 ) Change subject: MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason ...................................................................... Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaa39a1c1c6c6774f04d643e91bc79666da9d56a6 Gerrit-Change-Number: 26522 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:31:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:40:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:40:23 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 ) Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Patch Set 11: (4 comments) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h File include/osmocom/hnodeb/hnb_prim.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h at 34 PS11, Line 34: /*! \brief HNB_IUH primitives */ there could be some general comment with reference to X.210 and description who is provider and who is user in the terminology below, now that you didt the painful exercise... https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h at 146 PS11, Line 146: //struct hnb_iuh_conn_establish_req_param conn_establish_req; I'm confused. Almost all RUA connections are established from hnb to hnbgw (uplink direction, just like SCCP in Iu or A). As the SAP is "imagined" with the lower-layer as "user" and the uper layer as "provider", a conn_establish_req would be the very first thing that happens in any subscriber connection. However, the data type is commented out here? Also, later in the code hnb_iuh_conn_establish_req_param seems to be actually used? https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h at 149 PS11, Line 149: / likweise, it is defined above, why not use it here? https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c File src/osmo-hnodeb/llsk.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c at 108 PS11, Line 108: HNB_PRIM_SAPI_IUH naming: Iuh is (RUA/RANAP + HNBAP + GTP + RTP). So what you mean here is the "Iuh control plane" or "Iuh signaling", or as HNBAP is handled by the upper layer, probably just the RUA part? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 11 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:40:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 07:50:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 07:50:27 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK audio SAPI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 ) Change subject: First implementation of the LLSK audio SAPI ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h File include/osmocom/hnodeb/hnb_prim.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h at 173 PS2, Line 173: HNB_AUDIO_PRIM_CONN_ESTABLISH, : HNB_AUDIO_PRIM_CONN_RELEASE, : HNB_AUDIO_PRIM_CONN_DATA, : _HNB_AUDIO_PRIM_MAX IIRC "DATA" should be "UNITDATA" as there is no retransmission in RTP https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h at 184 PS2, Line 184: uint8_t remote_rtp_address_type; /* enum u_addr_type */ : union u_addr remote_rtp_addr; wouldn't it make sense to define a struct that encapsulates the address type and the union for the payload? IIRC we alreay have something like this in libosmocore, but of course we want a packed version here :/ In fact, one could also think of adding the port into it, At that point, you could actually pass a sockaddr_storage around, as it includes type, port and l3 address? https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h at 217 PS2, Line 217: struct osmo_prim_hdr hdr; as all of your primitives have a context_id, it might make sense to shift the context_id up one layer, out of the union. This introduced possibilities like a generic function/macro for logigng, to which you pass the entire hnb_audio_prim, and which then dereferences not just the prim-op/... but also the context_id. You could then have LOGHAP(struct hnb_audio_prim, format, ...) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/src/osmo-hnodeb/llsk_audio.c File src/osmo-hnodeb/llsk_audio.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/src/osmo-hnodeb/llsk_audio.c at 180 PS2, Line 180: LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: CS chan not active! ctx=%u rem_addr=%s\n", I think you could introduce a logging macro for printing the 'ctx' in a structured way. Like LOGPCTX() or so? This way it's guaranteed the formatting is identical everywhere. Now you repeate the %u in every line, and most have ctx=%u while at leat two have context_id=%u. This is important later on if somebody wants to grep the logs. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d Gerrit-Change-Number: 26502 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 07:50:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 08:00:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 12 Dec 2021 08:00:24 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 ) Change subject: First implementation of the LLSK gtp SAPI ...................................................................... Patch Set 2: Code-Review-1 (6 comments) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/include/osmocom/hnodeb/hnb_prim.h File include/osmocom/hnodeb/hnb_prim.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/include/osmocom/hnodeb/hnb_prim.h at 243 PS2, Line 243: uint8_t remote_gtpu_address_type; : union u_addr remote_gtpu_addr; same comment about address like in the RTP patch https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/include/osmocom/hnodeb/hnb_prim.h at 286 PS2, Line 286: un same comment about moving context_id up one layer as in RTP patch https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c File src/osmo-hnodeb/gtp.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c at 63 PS2, Line 63: LOG not sure we want that level of verbosity in a user plane code path? you will get a Tx... line at the same log level with the same information 7 lines below. https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c at 70 PS2, Line 70: req comment says request, next line says indication. Further comment below again says req. One ideq aould be to move the logging of the message type into a log macro, which simply uses a value_string to print the message type? Not runtime efficient due to the value_string lookup, but neither DEBUG nor ERROR should happen _that_ often in a production deployment? https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c at 126 PS2, Line 126: } : : osmo_fd_setup(&hnb->gtp.fd0, gsn->fd0, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0); : if ((rc = osmo_fd_register(&hnb->gtp.fd0)) < 0) : goto free_ret; : : osmo_fd_setup(&hnb->gtp.fd1c, gsn->fd1c, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 1); : if ((rc = osmo_fd_register(&hnb->gtp.fd1c)) < 0) : goto free_ret; : : osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 2); : if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0) The Iuh interface only uses GTP-U v1, neither GTPv0 and no GTPv1-C. So why are we creating three sockets and instantianting an entire GSN here? The HNB is no GSN. GSNs are SGSN and GGSN. I don't see the advantage of using libgtp here. What is the rationale of using it? AFAICT all we need for GTPv1U is to push one static, fixed size GTP header in front of every TX packet, and parse/remove the same fixed-size header in the RX direction. I'm afraid by uising a complete "GSN" implementation we get a lot of stuff that we don't want here, and which might create trouble. But maybe you did a thorough study of libgtp and decided it is a better option? https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c at 180 PS2, Line 180: LOG where deos this constraint come from? libgtp? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 12 Dec 2021 08:00:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 14:43:04 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 14:43:04 +0000 Subject: Change in osmo-dev[master]: Add tmux scripts for ttcn3-{msc, bsc, bts}-test In-Reply-To: References: Message-ID: Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 to look at the new patch set (#2). Change subject: Add tmux scripts for ttcn3-{msc,bsc,bts}-test ...................................................................... Add tmux scripts for ttcn3-{msc,bsc,bts}-test Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 --- A ttcn3/tmux/ttcn3-bsc-test.sh A ttcn3/tmux/ttcn3-bts-test.sh A ttcn3/tmux/ttcn3-msc-test.sh 3 files changed, 123 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/85/26485/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 Gerrit-Change-Number: 26485 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 14:44:02 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 14:44:02 +0000 Subject: Change in osmo-dev[master]: Add tmux scripts for ttcn3-{msc, bsc, bts}-test In-Reply-To: References: Message-ID: Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 to look at the new patch set (#3). Change subject: Add tmux scripts for ttcn3-{msc,bsc,bts}-test ...................................................................... Add tmux scripts for ttcn3-{msc,bsc,bts}-test Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 --- A ttcn3/tmux/ttcn3-bsc-test.sh A ttcn3/tmux/ttcn3-bts-test.sh A ttcn3/tmux/ttcn3-msc-test.sh 3 files changed, 123 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/85/26485/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 Gerrit-Change-Number: 26485 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 14:49:08 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 14:49:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-{bsc, bts}.cfg: tune logging configuration References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 ) Change subject: bts/osmo-{bsc,bts}.cfg: tune logging configuration ...................................................................... bts/osmo-{bsc,bts}.cfg: tune logging configuration Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 --- M bts/osmo-bsc.cfg M bts/osmo-bts.cfg 2 files changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/26523/1 diff --git a/bts/osmo-bsc.cfg b/bts/osmo-bsc.cfg index 1c8da8d..d035e49 100644 --- a/bts/osmo-bsc.cfg +++ b/bts/osmo-bsc.cfg @@ -9,11 +9,13 @@ ! log stderr logging filter all 1 - logging color 1 + logging print file basename last + logging print category-hex 0 logging print category 1 + logging print level 1 logging timestamp 1 - logging print extended-timestamp 1 - logging print file 1 + logging color 1 +! logging level set-all notice logging level rll info logging level rsl debug diff --git a/bts/osmo-bts.cfg b/bts/osmo-bts.cfg index 1c83db7..7d0a1ae 100644 --- a/bts/osmo-bts.cfg +++ b/bts/osmo-bts.cfg @@ -8,10 +8,13 @@ ! log stderr logging filter all 1 - logging color 1 + logging print file basename last + logging print category-hex 0 logging print category 1 + logging print level 1 logging timestamp 1 - logging print extended-timestamp 1 + logging color 1 +! logging level set-all notice logging level rsl info logging level oml info -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 Gerrit-Change-Number: 26523 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 14:49:09 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 14:49:09 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26524 ) Change subject: bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' ...................................................................... bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' Change-Id: If2f81141707e6f2360fc57bbd5f76606294f8db8 --- M bts/osmo-bsc.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/26524/1 diff --git a/bts/osmo-bsc.cfg b/bts/osmo-bsc.cfg index d035e49..6e74363 100644 --- a/bts/osmo-bsc.cfg +++ b/bts/osmo-bsc.cfg @@ -57,7 +57,7 @@ handover1 maximum distance 9999 timer t3212 30 bts 0 - type sysmobts + type osmo-bts band DCS1800 cell_identity 0 location_area_code 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2f81141707e6f2360fc57bbd5f76606294f8db8 Gerrit-Change-Number: 26524 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 14:49:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 14:49:18 +0000 Subject: Change in osmo-bts[master]: oml: use proper talloc context in oml_rx_set_radio_attr() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26525 ) Change subject: oml: use proper talloc context in oml_rx_set_radio_attr() ...................................................................... oml: use proper talloc context in oml_rx_set_radio_attr() Change-Id: I69b6c72d85f68e4225d7786646f24259a5964998 --- M src/common/oml.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/25/26525/1 diff --git a/src/common/oml.c b/src/common/oml.c index a434ad3..e352244 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -736,7 +736,7 @@ } /* merge existing BTS attributes with new attributes */ - tp_merged = osmo_tlvp_copy(trx->mo.nm_attr, trx->bts); + tp_merged = osmo_tlvp_copy(trx->mo.nm_attr, trx); osmo_tlvp_merge(tp_merged, &tp); /* Ask BTS driver to validate new merged attributes */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26525 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I69b6c72d85f68e4225d7786646f24259a5964998 Gerrit-Change-Number: 26525 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 14:49:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 14:49:18 +0000 Subject: Change in osmo-bts[master]: oml: use ts->trx as talloc-context in oml_rx_set_chan_attr() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26526 ) Change subject: oml: use ts->trx as talloc-context in oml_rx_set_chan_attr() ...................................................................... oml: use ts->trx as talloc-context in oml_rx_set_chan_attr() Change-Id: I6dc3706a486726afa9eec5d2e5369bd62c511455 --- M src/common/oml.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/26/26526/1 diff --git a/src/common/oml.c b/src/common/oml.c index e352244..4e09008 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -950,7 +950,7 @@ } /* merge existing BTS attributes with new attributes */ - tp_merged = osmo_tlvp_copy(ts->mo.nm_attr, bts); + tp_merged = osmo_tlvp_copy(ts->mo.nm_attr, ts->trx); osmo_tlvp_merge(tp_merged, &tp); /* Call into BTS driver to check attribute values */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26526 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6dc3706a486726afa9eec5d2e5369bd62c511455 Gerrit-Change-Number: 26526 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 14:49:19 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 14:49:19 +0000 Subject: Change in osmo-bts[master]: oml: fix copy-pasted comments in oml_rx_set_*_attr() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26527 ) Change subject: oml: fix copy-pasted comments in oml_rx_set_*_attr() ...................................................................... oml: fix copy-pasted comments in oml_rx_set_*_attr() Change-Id: Iaa0e630b28b2a86312c069e7e55dd8bc5743759a --- M src/common/oml.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/27/26527/1 diff --git a/src/common/oml.c b/src/common/oml.c index 4e09008..c8819c9 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -735,7 +735,7 @@ return oml_fom_ack_nack(msg, NM_NACK_INCORR_STRUCT); } - /* merge existing BTS attributes with new attributes */ + /* merge existing TRX attributes with new attributes */ tp_merged = osmo_tlvp_copy(trx->mo.nm_attr, trx); osmo_tlvp_merge(tp_merged, &tp); @@ -746,7 +746,7 @@ return oml_fom_ack_nack(msg, -rc); } - /* Success: replace old BTS attributes with new */ + /* Success: replace old TRX attributes with new */ talloc_free(trx->mo.nm_attr); trx->mo.nm_attr = tp_merged; @@ -949,7 +949,7 @@ return oml_fom_ack_nack(msg, NM_NACK_SPEC_IMPL_NOTSUPP); } - /* merge existing BTS attributes with new attributes */ + /* merge existing CHAN attributes with new attributes */ tp_merged = osmo_tlvp_copy(ts->mo.nm_attr, ts->trx); osmo_tlvp_merge(tp_merged, &tp); @@ -962,7 +962,7 @@ return oml_fom_ack_nack(msg, -rc); } - /* Success: replace old BTS attributes with new */ + /* Success: replace old CHAN attributes with new */ talloc_free(ts->mo.nm_attr); ts->mo.nm_attr = tp_merged; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaa0e630b28b2a86312c069e7e55dd8bc5743759a Gerrit-Change-Number: 26527 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 14:49:20 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 14:49:20 +0000 Subject: Change in osmo-bts[master]: oml: assign unique names to 'struct tlv_parsed' chunks References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26528 ) Change subject: oml: assign unique names to 'struct tlv_parsed' chunks ...................................................................... oml: assign unique names to 'struct tlv_parsed' chunks Change-Id: Ie248d2a65a11da914324a7e65b767b894ed8644a --- M src/common/oml.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/28/26528/1 diff --git a/src/common/oml.c b/src/common/oml.c index c8819c9..724e4f8 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -580,6 +580,7 @@ /* merge existing BTS attributes with new attributes */ tp_merged = osmo_tlvp_copy(bts->mo.nm_attr, bts); + talloc_set_name_const(tp_merged, "oml_bts_attr"); osmo_tlvp_merge(tp_merged, &tp); /* Ask BTS driver to validate new merged attributes */ @@ -737,6 +738,7 @@ /* merge existing TRX attributes with new attributes */ tp_merged = osmo_tlvp_copy(trx->mo.nm_attr, trx); + talloc_set_name_const(tp_merged, "oml_trx_attr"); osmo_tlvp_merge(tp_merged, &tp); /* Ask BTS driver to validate new merged attributes */ @@ -951,6 +953,7 @@ /* merge existing CHAN attributes with new attributes */ tp_merged = osmo_tlvp_copy(ts->mo.nm_attr, ts->trx); + talloc_set_name_const(tp_merged, "oml_chan_attr"); osmo_tlvp_merge(tp_merged, &tp); /* Call into BTS driver to check attribute values */ @@ -1395,6 +1398,7 @@ /* Success: replace old MO attributes with new */ /* merge existing MO attributes with new attributes */ tp_merged = osmo_tlvp_copy(mo->nm_attr, bts); + talloc_set_name_const(tp_merged, "oml_ipa_attr"); osmo_tlvp_merge(tp_merged, &tp); talloc_free(mo->nm_attr); mo->nm_attr = tp_merged; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie248d2a65a11da914324a7e65b767b894ed8644a Gerrit-Change-Number: 26528 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 15:01:55 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 15:01:55 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test/osmo-bts.cfg: use default {fn, rts}-advance values References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26529 ) Change subject: ttcn3-bts-test/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... ttcn3-bts-test/osmo-bts.cfg: use default {fn,rts}-advance values It's better if we run ttcn3-bts-test with the default values, given that they were significantly reduced some time ago. Change-Id: If8438adfdbc506d2b6b7858ea8a0ea859ba246a1 Related: I7da3d0948f38e12342fb714b29f8edc5e9d0933d (osmo-bts) Related: OS#4487 --- M ttcn3-bts-test/osmo-bts.cfg 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/29/26529/1 diff --git a/ttcn3-bts-test/osmo-bts.cfg b/ttcn3-bts-test/osmo-bts.cfg index 9933a76..bbe8a1d 100644 --- a/ttcn3-bts-test/osmo-bts.cfg +++ b/ttcn3-bts-test/osmo-bts.cfg @@ -34,8 +34,6 @@ phy 0 osmotrx ip local 172.18.9.20 osmotrx ip remote 172.18.9.21 - osmotrx fn-advance 20 - osmotrx rts-advance 5 instance 0 osmotrx rx-gain 10 instance 1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If8438adfdbc506d2b6b7858ea8a0ea859ba246a1 Gerrit-Change-Number: 26529 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 15:03:41 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 15:03:41 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bts.cfg: use default {fn, rts}-advance values References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 ) Change subject: bts/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... bts/osmo-bts.cfg: use default {fn,rts}-advance values It's better if we run ttcn3-bts-test with the default values, given that they were significantly reduced some time ago. Change-Id: Id97e848e5dfd0b6c504d06f62642511cfd5a0f66 Related: I7da3d0948f38e12342fb714b29f8edc5e9d0933d (osmo-bts) Related: OS#4487 --- M bts/osmo-bts.cfg 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/26530/1 diff --git a/bts/osmo-bts.cfg b/bts/osmo-bts.cfg index 7d0a1ae..9593f00 100644 --- a/bts/osmo-bts.cfg +++ b/bts/osmo-bts.cfg @@ -37,8 +37,6 @@ phy 0 osmotrx ip local 127.0.0.1 osmotrx ip remote 127.0.0.1 - osmotrx fn-advance 20 - osmotrx rts-advance 5 instance 0 osmotrx rx-gain 10 instance 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id97e848e5dfd0b6c504d06f62642511cfd5a0f66 Gerrit-Change-Number: 26530 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 16:06:30 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 16:06:30 +0000 Subject: Change in osmo-bts[master]: osmo-bts-trx: use l1ts as talloc context for burst buffers References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26531 ) Change subject: osmo-bts-trx: use l1ts as talloc context for burst buffers ...................................................................... osmo-bts-trx: use l1ts as talloc context for burst buffers Before a massive refactoring of the scheduler structures [1] it was impossible to have a clean hierarchy, in which the burst buffers get allocated as children of their parent timeslot structures. This change makes it easier to read talloc reports and simplifies memory management, offloading free()ing of the burst bufferes to talloc. Change-Id: Idb1ceaf83c433d2d0eb84d77c2187a00a657905c Related: [1] I7c4379e43a25e9d858d582a99bf6c4b65c9af481 --- M src/common/scheduler.c M src/osmo-bts-trx/sched_lchan_pdtch.c M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c M src/osmo-bts-trx/sched_lchan_xcch.c 5 files changed, 10 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/26531/1 diff --git a/src/common/scheduler.c b/src/common/scheduler.c index d8048b5..bd33ce1 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -662,18 +662,7 @@ msgb_queue_flush(&l1ts->dl_prims); rate_ctr_group_free(l1ts->ctrs); l1ts->ctrs = NULL; - for (i = 0; i < _TRX_CHAN_MAX; i++) { - struct l1sched_chan_state *chan_state; - chan_state = &l1ts->chan_state[i]; - if (chan_state->dl_bursts) { - talloc_free(chan_state->dl_bursts); - chan_state->dl_bursts = NULL; - } - if (chan_state->ul_bursts) { - talloc_free(chan_state->ul_bursts); - chan_state->ul_bursts = NULL; - } - } + /* clear lchan channel states */ for (i = 0; i < ARRAY_SIZE(ts->lchan); i++) lchan_set_state(&ts->lchan[i], LCHAN_S_NONE); diff --git a/src/osmo-bts-trx/sched_lchan_pdtch.c b/src/osmo-bts-trx/sched_lchan_pdtch.c index 66be116..6a2ad0d 100644 --- a/src/osmo-bts-trx/sched_lchan_pdtch.c +++ b/src/osmo-bts-trx/sched_lchan_pdtch.c @@ -58,8 +58,7 @@ /* allocate burst memory, if not already */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, - GSM0503_EGPRS_BURSTS_NBITS); + *bursts_p = talloc_zero_size(l1ts, GSM0503_EGPRS_BURSTS_NBITS); if (!*bursts_p) return -ENOMEM; } @@ -174,8 +173,7 @@ /* allocate burst memory, if not already */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, - GSM0503_EGPRS_BURSTS_NBITS); + *bursts_p = talloc_zero_size(l1ts, GSM0503_EGPRS_BURSTS_NBITS); if (!*bursts_p) return -ENOMEM; } diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 85ab321..08a58bb 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -76,7 +76,7 @@ /* allocate burst memory, if not already */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, 928); + *bursts_p = talloc_zero_size(l1ts, 928); if (!*bursts_p) return -ENOMEM; } @@ -521,7 +521,7 @@ /* allocate burst memory, if not already, * otherwise shift buffer by 4 bursts for interleaving */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, 928); + *bursts_p = talloc_zero_size(l1ts, 928); if (!*bursts_p) return -ENOMEM; } else { diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index 366c625..51a0b90 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -83,7 +83,7 @@ /* allocate burst memory, if not already */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, 696); + *bursts_p = talloc_zero_size(l1ts, 696); if (!*bursts_p) return -ENOMEM; } @@ -417,7 +417,7 @@ /* allocate burst memory, if not already, * otherwise shift buffer by 2 bursts for interleaving */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, 696); + *bursts_p = talloc_zero_size(l1ts, 696); if (!*bursts_p) return -ENOMEM; } else { diff --git a/src/osmo-bts-trx/sched_lchan_xcch.c b/src/osmo-bts-trx/sched_lchan_xcch.c index e8f46c1..6a65574 100644 --- a/src/osmo-bts-trx/sched_lchan_xcch.c +++ b/src/osmo-bts-trx/sched_lchan_xcch.c @@ -71,7 +71,7 @@ /* allocate burst memory, if not already */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, 464); + *bursts_p = talloc_zero_size(l1ts, 464); if (!*bursts_p) return -ENOMEM; } @@ -79,7 +79,7 @@ /* UL-SACCH requires additional memory to keep a copy of each previous * burst set. */ if (L1SAP_IS_LINK_SACCH(trx_chan_desc[bi->chan].link_id) && !chan_state->ul_bursts_prev) { - chan_state->ul_bursts_prev = talloc_zero_size(tall_bts_ctx, 464); + chan_state->ul_bursts_prev = talloc_zero_size(l1ts, 464); if (!chan_state->ul_bursts_prev) return -ENOMEM; } @@ -224,7 +224,7 @@ /* allocate burst memory, if not already */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, 464); + *bursts_p = talloc_zero_size(l1ts, 464); if (!*bursts_p) return -ENOMEM; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26531 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idb1ceaf83c433d2d0eb84d77c2187a00a657905c Gerrit-Change-Number: 26531 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 16:06:31 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 16:06:31 +0000 Subject: Change in osmo-bts[master]: osmo-bts-trx: fix a memleak in trx_sched_set_lchan() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26532 ) Change subject: osmo-bts-trx: fix a memleak in trx_sched_set_lchan() ...................................................................... osmo-bts-trx: fix a memleak in trx_sched_set_lchan() An additional burst buffer is allocated in rx_data_fn() for Uplink SACCH repetition, but unlike the main buffer it never gets free()d. Change-Id: I93310e7aed91a49c0511e2ed30e000440617f95a Fixes: I7e4cc33cc010866e41e3b594351a7f7bf93e08ac Related: OS#4795, SYS#5114 --- M src/common/scheduler.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/32/26532/1 diff --git a/src/common/scheduler.c b/src/common/scheduler.c index bd33ce1..e854ce1 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -1109,6 +1109,10 @@ talloc_free(chan_state->ul_bursts); chan_state->ul_bursts = NULL; } + if (chan_state->ul_bursts_prev) { + talloc_free(chan_state->ul_bursts_prev); + chan_state->ul_bursts_prev = NULL; + } if (active) { /* Clean up everything */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I93310e7aed91a49c0511e2ed30e000440617f95a Gerrit-Change-Number: 26532 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 12 16:41:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 12 Dec 2021 16:41:27 +0000 Subject: Change in osmo-bts[master]: cbch: cosmetic: use talloc_zero() in bts_process_smscb_cmd() References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26533 ) Change subject: cbch: cosmetic: use talloc_zero() in bts_process_smscb_cmd() ...................................................................... cbch: cosmetic: use talloc_zero() in bts_process_smscb_cmd() Change-Id: Ibb5090b7cd53c1a485d0b9474c6470fa5831de67 --- M src/common/cbch.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/33/26533/1 diff --git a/src/common/cbch.c b/src/common/cbch.c index f1f8b6a..f65df0d 100644 --- a/src/common/cbch.c +++ b/src/common/cbch.c @@ -198,7 +198,7 @@ return -EINVAL; } - scm = talloc_zero_size(bts, sizeof(*scm)); + scm = talloc_zero(bts, struct smscb_msg); if (!scm) return -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibb5090b7cd53c1a485d0b9474c6470fa5831de67 Gerrit-Change-Number: 26533 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Mon Dec 13 00:44:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 13 Dec 2021 00:44:48 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Debian_11/i586 In-Reply-To: References: Message-ID: <61b697921329e_72822b13744585f0216879f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_11/i586 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_11/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 426s] -{20.000019} non-reconnecting test complete. [ 426s] +{11.000013} [NA] Client's connect_cb_cli(): callback triggered [ 426s] +{11.000013} [NA] Client's connect_cb_cli(): sent 29 bytes message: 48 69 21 20 66 72 6f 6d 20 63 6f 6e 6e 65 63 74 20 63 61 6c 6c 62 61 63 6b 20 3a 2d 50 [ 426s] +{11.000015} [NA|OK] Server's read_cb_srv(): callback triggered [ 426s] +{11.000015} [NA|OK] Server's read_cb_srv(): received 29(29) bytes: 48 69 21 20 66 72 6f 6d 20 63 6f 6e 6e 65 63 74 20 63 61 6c 6c 62 61 63 6b 20 3a 2d 50 [ 426s] +{11.000015} [NA|OK] Server's read_cb_srv(): sent 11 bytes message: 72 65 61 64 5f 63 62 5f 73 72 76 [ 426s] +{11.000015} [OK|OK] Server's read_cb_srv(): keep initial client connection [ 426s] +{11.000017} [NA] Client's read_cb_cli(): callback triggered [ 426s] +{11.000017} [NA] Client's read_cb_cli(): received 11(11) bytes: 72 65 61 64 5f 63 62 5f 73 72 76 [ 426s] +{11.000017} [NA] Client's read_cb_cli(): initial read, contacting server [ 426s] +{11.000017} [OK] Client's read_cb_cli(): sent 29 bytes message: 44 6f 68 2c 20 72 65 73 70 6f 6e 64 69 6e 67 20 74 6f 20 73 65 72 76 65 72 20 3a 2d 44 [ 426s] +{11.000019} [OK|OK] Server's read_cb_srv(): callback triggered [ 426s] +{11.000019} [OK|OK] Server's read_cb_srv(): received 29(29) bytes: 44 6f 68 2c 20 72 65 73 70 6f 6e 64 69 6e 67 20 74 6f 20 73 65 72 76 65 72 20 3a 2d 44 [ 426s] +{11.000019} [OK|OK] Server's read_cb_srv(): sent 11 bytes message: 72 65 61 64 5f 63 62 5f 73 72 76 [ 426s] +{11.000019} [OK|OK] Server's read_cb_srv(): force client disconnect on subsequent call [ 426s] +{11.000020} [OK] Client's read_cb_cli(): callback triggered [ 426s] +{11.000020} [OK] Client's read_cb_cli(): 0-byte read, auto-reconnect will be triggered if enabled [ 426s] +{20.000020} non-reconnecting test complete. [ 426s] [ 426s] Stream tests completed [ 426s] 1. testsuite.at:4: 1. stream_test (testsuite.at:4): FAILED (testsuite.at:8) [ 426s] make[1]: *** [debian/rules:27: override_dh_auto_test] Error 1 [ 426s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 428s] make: *** [debian/rules:[ 337.193785] sysrq: Power Off [ 428s] [ 337.230005] reboot: Power down [ 429s] ### VM INTERACTION END ### [ 429s] [ 429s] cloud116 failed "build libosmo-netif_1.1.0.5.82a5.202112130026.dsc" at Mon Dec 13 00:44:38 UTC 2021. [ 429s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Dec 13 09:24:12 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 09:24:12 +0000 Subject: Change in simtrace2[master]: host/contrib/simtrace2.spec.in: update In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26501 ) Change subject: host/contrib/simtrace2.spec.in: update ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I35ce3865702f72365b38b0eaa8b28f332dabcd1f Gerrit-Change-Number: 26501 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 09:24:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 09:24:14 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 09:24:14 +0000 Subject: Change in simtrace2[master]: host/contrib/simtrace2.spec.in: update In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26501 ) Change subject: host/contrib/simtrace2.spec.in: update ...................................................................... host/contrib/simtrace2.spec.in: update Apply various improvements from Martin Hauke, thanks! * Put sover into a variable * Sync BuildRequires with configure.ac * Update libosmo-simtrace2 summary * Use %make_build instead of make %{?_smp_mflags} Change-Id: I35ce3865702f72365b38b0eaa8b28f332dabcd1f --- M host/contrib/simtrace2.spec.in 1 file changed, 16 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/host/contrib/simtrace2.spec.in b/host/contrib/simtrace2.spec.in index 1c47f5e..0bc5d2a 100644 --- a/host/contrib/simtrace2.spec.in +++ b/host/contrib/simtrace2.spec.in @@ -1,7 +1,8 @@ # # spec file for package simtrace2 # -# Copyright (c) 2018, Martin Hauke +# Copyright (c) 2021 SUSE LLC +# Copyright (c) 2018-2021, Martin Hauke # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -12,6 +13,7 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. +%define sover 1 Name: simtrace2 Version: @VERSION@ Release: 0 @@ -24,12 +26,11 @@ BuildRequires: automake BuildRequires: libtool BuildRequires: pkgconfig -BuildRequires: pkgconfig(libosmocore) -BuildRequires: pkgconfig(libosmosim) +BuildRequires: pkgconfig(libosmocore) >= 1.4.0 +BuildRequires: pkgconfig(libosmosim) >= 1.4.0 +BuildRequires: pkgconfig(libosmousb) >= 1.4.0 BuildRequires: pkgconfig(libpcsclite) BuildRequires: pkgconfig(libusb-1.0) -BuildRequires: pkgconfig(libosmousb) >= 0.0.0 -BuildRequires: pkgconfig(udev) %description Osmocom SIMtrace 2 is a software and hardware system for passively @@ -38,11 +39,11 @@ This package contains SIMtrace 2 host utility. -%package -n libosmo-simtrace2-1 -Summary: Shared Library part of libosmo-simtrace2 +%package -n libosmo-simtrace2-%{sover} +Summary: Driver functions for Osmocom SIMtrace2 and compatible firmware Group: System/Libraries -%description -n libosmo-simtrace2-1 +%description -n libosmo-simtrace2-%{sover} This library contains core "driver" functionality to interface with the Osmocom SIMtrace2 (and compatible) USB device firmware. It enables applications to implement SIM card / smart card tracing as well as @@ -51,7 +52,7 @@ %package -n libosmo-simtrace2-devel Summary: Development files for the Osmocom SIMtrace2 library Group: Development/Libraries/C and C++ -Requires: libosmo-simtrace2-1 = %{version} +Requires: libosmo-simtrace2-%{sover} = %{version} %description -n libosmo-simtrace2-devel Osmocom SIMtrace2 (and compatible) USB device firmware. It enables @@ -69,17 +70,18 @@ echo "%{version}" >.tarball-version autoreconf -fiv %configure --disable-static -make %{?_smp_mflags} +%make_build %install %make_install -C host install -Dm0644 host/contrib/99-simtrace2.rules %{buildroot}/%{_udevrulesdir}/99-simtrace2.rules find %{buildroot} -type f -name "*.la" -delete -print -%post -n libosmo-simtrace2-1 -p /sbin/ldconfig -%postun -n libosmo-simtrace2-1 -p /sbin/ldconfig +%post -n libosmo-simtrace2-%{sover} -p /sbin/ldconfig +%postun -n libosmo-simtrace2-%{sover} -p /sbin/ldconfig %files +%license host/COPYING %doc README.md %{_bindir}/simtrace2-cardem-pcsc %{_bindir}/simtrace2-list @@ -87,8 +89,8 @@ %{_bindir}/simtrace2-tool %{_udevrulesdir}/99-simtrace2.rules -%files -n libosmo-simtrace2-1 -%{_libdir}/libosmo-simtrace2.so.1* +%files -n libosmo-simtrace2-%{sover} +%{_libdir}/libosmo-simtrace2.so.%{sover}* %files -n libosmo-simtrace2-devel %dir %{_includedir}/osmocom/ -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I35ce3865702f72365b38b0eaa8b28f332dabcd1f Gerrit-Change-Number: 26501 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 09:25:08 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 09:25:08 +0000 Subject: Change in docker-playground[master]: osmo-pcap-latest: fix install path for centos In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26499 ) Change subject: osmo-pcap-latest: fix install path for centos ...................................................................... Patch Set 3: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I775776ff7f358fee3d085f814c295c49225f5170 Gerrit-Change-Number: 26499 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 09:25:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 09:57:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 09:57:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: introduce c_def_{hbh, ete}_id constants In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 ) Change subject: library/DIAMETER_Templates: introduce c_def_{hbh,ete}_id constants ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I714b18bbe77949593803e999d25e4ef8e1827917 Gerrit-Change-Number: 26511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 09:57:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:04:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:04:32 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: enrich existing ULR/ULA templates In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 ) Change subject: library/DIAMETER_Templates: enrich existing ULR/ULA templates ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513/1/library/DIAMETER_Templates.ttcn File library/DIAMETER_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513/1/library/DIAMETER_Templates.ttcn at 915 PS1, Line 915: tr_DIA_ULR(/* template (present) */ hexstring imsi, why is this commented? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0585e306a87453c212c6b5ac5635181c47b34b4f Gerrit-Change-Number: 26513 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:04:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:05:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:05:41 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: fix flags in AIR templates In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 ) Change subject: library/DIAMETER_Templates: fix flags in AIR templates ...................................................................... Patch Set 1: I'd wlcome some description on why are they wrong and how you fix it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7db3b632189eed09c1bdf98f9d588491d928e2f5 Gerrit-Change-Number: 26517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:05:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:07:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:07:19 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: implement direct mode of operation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 ) Change subject: library/DIAMETER_Emulation: implement direct mode of operation ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521/1/library/DIAMETER_Emulation.ttcn File library/DIAMETER_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521/1/library/DIAMETER_Emulation.ttcn at 342 PS1, Line 342: [ops.direct] DIAMETER_UNIT.receive(PDU_DIAMETER:?) -> value msg { so if direct is false, what do we do with those messages? I don't see any other DIAMETER_UNIT.receive below. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52e22ac70cc85be5b0436b68c77356aabc4f05e1 Gerrit-Change-Number: 26521 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:07:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:07:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:07:55 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26522 ) Change subject: MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason ...................................................................... Patch Set 1: why is this marked -1 by laforge? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaa39a1c1c6c6774f04d643e91bc79666da9d56a6 Gerrit-Change-Number: 26522 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:07:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:09:22 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:09:22 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-{bsc, bts}.cfg: tune logging configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 ) Change subject: bts/osmo-{bsc,bts}.cfg: tune logging configuration ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523/1/bts/osmo-bsc.cfg File bts/osmo-bsc.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523/1/bts/osmo-bsc.cfg at a15 PS1, Line 15: logging print extended-timestamp 1 why are you removing extended timestamp? they provide subsecond granularity, which is definetly something we want when checking tests spaning a few seconds at most. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 Gerrit-Change-Number: 26523 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:09:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:09:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:09:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26524 ) Change subject: bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2f81141707e6f2360fc57bbd5f76606294f8db8 Gerrit-Change-Number: 26524 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:09:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:10:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:10:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bts.cfg: use default {fn, rts}-advance values In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 ) Change subject: bts/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... Patch Set 1: default values were not set up to work well with fake_trx and so on. Did you check tests run fine with those values? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id97e848e5dfd0b6c504d06f62642511cfd5a0f66 Gerrit-Change-Number: 26530 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:10:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:12:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:12:29 +0000 Subject: Change in osmo-bts[master]: oml: use proper talloc context in oml_rx_set_radio_attr() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26525 ) Change subject: oml: use proper talloc context in oml_rx_set_radio_attr() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26525 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I69b6c72d85f68e4225d7786646f24259a5964998 Gerrit-Change-Number: 26525 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:12:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:12:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:12:59 +0000 Subject: Change in osmo-bts[master]: oml: use ts->trx as talloc-context in oml_rx_set_chan_attr() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26526 ) Change subject: oml: use ts->trx as talloc-context in oml_rx_set_chan_attr() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26526 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6dc3706a486726afa9eec5d2e5369bd62c511455 Gerrit-Change-Number: 26526 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:12:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:13:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:13:31 +0000 Subject: Change in osmo-bts[master]: oml: fix copy-pasted comments in oml_rx_set_*_attr() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26527 ) Change subject: oml: fix copy-pasted comments in oml_rx_set_*_attr() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaa0e630b28b2a86312c069e7e55dd8bc5743759a Gerrit-Change-Number: 26527 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:13:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:14:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:14:12 +0000 Subject: Change in osmo-bts[master]: oml: assign unique names to 'struct tlv_parsed' chunks In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26528 ) Change subject: oml: assign unique names to 'struct tlv_parsed' chunks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie248d2a65a11da914324a7e65b767b894ed8644a Gerrit-Change-Number: 26528 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:14:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:14:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:14:36 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test/osmo-bts.cfg: use default {fn, rts}-advance values In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26529 ) Change subject: ttcn3-bts-test/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... Patch Set 1: See my question regarding osmo-ttcn3-hacks patch. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If8438adfdbc506d2b6b7858ea8a0ea859ba246a1 Gerrit-Change-Number: 26529 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:14:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:18:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:18:20 +0000 Subject: Change in osmo-bts[master]: osmo-bts-trx: use l1ts as talloc context for burst buffers In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26531 ) Change subject: osmo-bts-trx: use l1ts as talloc context for burst buffers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26531 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idb1ceaf83c433d2d0eb84d77c2187a00a657905c Gerrit-Change-Number: 26531 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:18:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:19:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:19:09 +0000 Subject: Change in osmo-bts[master]: osmo-bts-trx: fix a memleak in trx_sched_set_lchan() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26532 ) Change subject: osmo-bts-trx: fix a memleak in trx_sched_set_lchan() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I93310e7aed91a49c0511e2ed30e000440617f95a Gerrit-Change-Number: 26532 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:19:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:19:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:19:18 +0000 Subject: Change in osmo-bts[master]: cbch: cosmetic: use talloc_zero() in bts_process_smscb_cmd() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26533 ) Change subject: cbch: cosmetic: use talloc_zero() in bts_process_smscb_cmd() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibb5090b7cd53c1a485d0b9474c6470fa5831de67 Gerrit-Change-Number: 26533 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:19:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:24:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:24:48 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 ) Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Patch Set 11: (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c File src/osmo-hnodeb/llsk.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c at 108 PS11, Line 108: HNB_PRIM_SAPI_IUH > naming: Iuh is (RUA/RANAP + HNBAP + GTP + RTP). [?] Yes, it's the Iuh Signaling, with optional RANAP payload to forward -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 11 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 13 Dec 2021 10:24:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:41:01 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 10:41:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26524 ) Change subject: bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2f81141707e6f2360fc57bbd5f76606294f8db8 Gerrit-Change-Number: 26524 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 10:41:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:50:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:50:12 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 ) Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Patch Set 11: (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h File include/osmocom/hnodeb/hnb_prim.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/include/osmocom/hnodeb/hnb_prim.h at 146 PS11, Line 146: //struct hnb_iuh_conn_establish_req_param conn_establish_req; > I'm confused. [?] Because I directly pass the substruct casted to a pointer to the relevant rx functions, only for Tx path the entire union is currently used. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 11 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 13 Dec 2021 10:50:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 10:58:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 10:58:26 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK audio SAPI In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 ) Change subject: First implementation of the LLSK audio SAPI ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h File include/osmocom/hnodeb/hnb_prim.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h at 173 PS2, Line 173: HNB_AUDIO_PRIM_CONN_ESTABLISH, : HNB_AUDIO_PRIM_CONN_RELEASE, : HNB_AUDIO_PRIM_CONN_DATA, : _HNB_AUDIO_PRIM_MAX > IIRC "DATA" should be "UNITDATA" as there is no retransmission in RTP I'm using CONN_DATA for payload forwarding which relates to an active connection or context, which was previously established (CONN_ESTABLISH) and later release (CONN_DATA). I do the same for Iuh signalling, where they are differentiated from UNITDATA which contain RANAP messages not related to any context (like paging). https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h at 184 PS2, Line 184: uint8_t remote_rtp_address_type; /* enum u_addr_type */ : union u_addr remote_rtp_addr; > wouldn't it make sense to define a struct that encapsulates the address type and the union for the p [?] I preferred having an own format specified in the protocol, similar to what we have in PCUIF, rather than relying on some even more complex "opaque" data types provided by the system. https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h at 217 PS2, Line 217: struct osmo_prim_hdr hdr; > as all of your primitives have a context_id, it might make sense to shift the context_id up one laye [?] Not sure if it's really worth it, since anyway we can find the UE from the context_id, and then use LOGUE(). https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/src/osmo-hnodeb/llsk_audio.c File src/osmo-hnodeb/llsk_audio.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/src/osmo-hnodeb/llsk_audio.c at 180 PS2, Line 180: LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: CS chan not active! ctx=%u rem_addr=%s\n", > I think you could introduce a logging macro for printing the 'ctx' in a structured way. [?] This one should actually be LOGUE(), which already prints context_id. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d Gerrit-Change-Number: 26502 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 13 Dec 2021 10:58:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:34:19 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 11:34:19 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-gsm-manuals deps In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26492 ) Change subject: debian-stretch-build-dist: osmo-gsm-manuals deps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iba2e71b2e757bc527561d0f3e4a1af5f024a3cd7 Gerrit-Change-Number: 26492 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:34:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:34:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 11:34:36 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-hnodeb deps In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26493 ) Change subject: debian-stretch-build-dist: osmo-hnodeb deps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9d708d86bf29f9fca0446fb990c606780bd7a1cb Gerrit-Change-Number: 26493 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 13 Dec 2021 11:34:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:34:49 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 11:34:49 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-pcap deps In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26494 ) Change subject: debian-stretch-build-dist: osmo-pcap deps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If0f00dd09ce0db6a05972a564474a707d2d3174b Gerrit-Change-Number: 26494 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:34:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:35:02 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 11:35:02 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-remsim deps In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26495 ) Change subject: debian-stretch-build-dist: osmo-remsim deps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8fd4b9d3734dd3bc0e3fca8ceaedda2aedc6a055 Gerrit-Change-Number: 26495 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:35:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:35:16 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 11:35:16 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-uecups deps In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26496 ) Change subject: debian-stretch-build-dist: osmo-uecups deps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I19b6b0363aeeb89ab6aac2b125359589e6b9b5a7 Gerrit-Change-Number: 26496 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:35:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:36:16 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 11:36:16 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: sort In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26489 ) Change subject: OSMO_RELEASE_REPOS: sort ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3660032d020154b7a175483691842b576552ffd1 Gerrit-Change-Number: 26489 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:36:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:36:57 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 11:36:57 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: sync with Nov 2021 releases In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26490 ) Change subject: OSMO_RELEASE_REPOS: sync with Nov 2021 releases ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib2022ca670b322d81ff83bbca3bb262f8d7287a6 Gerrit-Change-Number: 26490 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:36:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:37:41 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 11:37:41 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26491 ) Change subject: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib52a23a2a7d6ea64bfa539b1d026f035fdb3af57 Gerrit-Change-Number: 26491 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:37:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:40:28 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:40:28 +0000 Subject: Change in osmo-pcap[master]: Revert "configure.ac: don't depend on libosmogb." References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26534 ) Change subject: Revert "configure.ac: don't depend on libosmogb." ...................................................................... Revert "configure.ac: don't depend on libosmogb." gprs header files from libosmogb are needed for osmo-pcap. This was the reason why it was added as dependency to configure.ac in I9a8fa03cef1efc9fdaea65ee63ca9b3379993989. $ git grep "osmocom/gprs" src/osmo_client_core.c:#include src/osmo_client_core.c:#include src/osmo_client_core.c:#include The package is only still building for debian, because in debian libosmocore is not split up, and for centos, because the rpm spec file still lists the dependency. This reverts commit 2c2eadcadf59ac42a02339f554c5daa48ee4f9fd. Change-Id: Ic358956521230a2f6525533779c27417b2e86833 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/34/26534/1 diff --git a/configure.ac b/configure.ac index 06c9dc2..fa9a3c8 100644 --- a/configure.ac +++ b/configure.ac @@ -158,6 +158,8 @@ dnl checks for libraries PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +# libosmogb: needed for osmocom/gprs includes +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) PKG_CHECK_MODULES(LIBZMQ, libzmq >= 3.2.2) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ic358956521230a2f6525533779c27417b2e86833 Gerrit-Change-Number: 26534 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:42:06 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:42:06 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... Patch Set 3: > Patch Set 3: > > > Patch Set 3: > > > > > Patch Set 1: > > > > > > your commitlog states remove libosmonetif, but the patch also adds libosmogb (which should not be required)? > > > > according to configure.ac it is required, updated the commit message > > then configure.ac is wrong, see: https://gerrit.osmocom.org/c/osmo-pcap/+/26510 > > It doesn't make any sense... there is nothing NS/BSSGP inside a generic pcap capture+store system. The dependency was added because of osmocom/gprs includes: https://gerrit.osmocom.org/c/osmo-pcap/+/26266 Here's a patch to add it back to configure.ac: https://gerrit.osmocom.org/c/osmo-pcap/+/26534 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:42:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:42:31 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 11:42:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: enrich existing ULR/ULA templates In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 ) Change subject: library/DIAMETER_Templates: enrich existing ULR/ULA templates ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513/1/library/DIAMETER_Templates.ttcn File library/DIAMETER_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513/1/library/DIAMETER_Templates.ttcn at 915 PS1, Line 915: tr_DIA_ULR(/* template (present) */ hexstring imsi, > why is this commented? Because the PDU definitions we use are not user friendly and IMSI is defined as an octetstring. We have to do char2oct(hex2str(imsi)) in tr_AVP_UserNameImsi, so this is why it cannot be a template :/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0585e306a87453c212c6b5ac5635181c47b34b4f Gerrit-Change-Number: 26513 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:42:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:43:56 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 11:43:56 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26522 ) Change subject: MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason ...................................................................... Patch Set 1: > Patch Set 1: > > why is this marked -1 by laforge? I don't know, he did not explain o_O -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaa39a1c1c6c6774f04d643e91bc79666da9d56a6 Gerrit-Change-Number: 26522 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:43:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:49:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 11:49:59 +0000 Subject: Change in osmo-pcap[master]: Revert "configure.ac: don't depend on libosmogb." In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26534 ) Change subject: Revert "configure.ac: don't depend on libosmogb." ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ic358956521230a2f6525533779c27417b2e86833 Gerrit-Change-Number: 26534 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:49:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:50:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 11:50:51 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: enrich existing ULR/ULA templates In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 ) Change subject: library/DIAMETER_Templates: enrich existing ULR/ULA templates ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0585e306a87453c212c6b5ac5635181c47b34b4f Gerrit-Change-Number: 26513 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:50:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:51:12 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 11:51:12 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-{bsc, bts}.cfg: tune logging configuration In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 ) Change subject: bts/osmo-{bsc,bts}.cfg: tune logging configuration ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523/1/bts/osmo-bsc.cfg File bts/osmo-bsc.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523/1/bts/osmo-bsc.cfg at a15 PS1, Line 15: logging print extended-timestamp 1 > why are you removing extended timestamp? they provide subsecond granularity, which is definetly some [?] Here I am proposing the same logging configuration as we use for ttcn3-{bsc,msc}-test. I am fine with printing extended timestamps, so I can update this patch and submit a separate one for ttcn3-{bsc,msc}-test. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 Gerrit-Change-Number: 26523 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:51:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:53:40 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 11:53:40 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bts.cfg: use default {fn, rts}-advance values In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 ) Change subject: bts/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... Patch Set 1: > Patch Set 1: > > default values were not set up to work well with fake_trx and so on. Did you check tests run fine with those values? fake_trx does not buffer bursts, so in theory this should not be a problem. I'll do a test run to be sure. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id97e848e5dfd0b6c504d06f62642511cfd5a0f66 Gerrit-Change-Number: 26530 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:53:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:55:27 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:55:27 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-gsm-manuals deps In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26492 ) Change subject: debian-stretch-build-dist: osmo-gsm-manuals deps ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iba2e71b2e757bc527561d0f3e4a1af5f024a3cd7 Gerrit-Change-Number: 26492 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:55:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:55:31 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:55:31 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-hnodeb deps In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26493 ) Change subject: debian-stretch-build-dist: osmo-hnodeb deps ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9d708d86bf29f9fca0446fb990c606780bd7a1cb Gerrit-Change-Number: 26493 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 13 Dec 2021 11:55:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:55:36 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:55:36 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-pcap deps In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26494 ) Change subject: debian-stretch-build-dist: osmo-pcap deps ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If0f00dd09ce0db6a05972a564474a707d2d3174b Gerrit-Change-Number: 26494 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:55:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:55:40 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:55:40 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-remsim deps In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26495 ) Change subject: debian-stretch-build-dist: osmo-remsim deps ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8fd4b9d3734dd3bc0e3fca8ceaedda2aedc6a055 Gerrit-Change-Number: 26495 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:55:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:55:45 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:55:45 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-uecups deps In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26496 ) Change subject: debian-stretch-build-dist: osmo-uecups deps ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I19b6b0363aeeb89ab6aac2b125359589e6b9b5a7 Gerrit-Change-Number: 26496 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:55:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:55:50 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:55:50 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-gsm-manuals deps In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26492 ) Change subject: debian-stretch-build-dist: osmo-gsm-manuals deps ...................................................................... debian-stretch-build-dist: osmo-gsm-manuals deps Add dependencies for osmo-gsm-manuals, so we can build the release tarballs for it (autoreconf -fi; ./configure; make dist-bzip2) in the related jenkins job. During update of the list of projects for which we build these tarballs, it became apparent that it was missing. Following patches will add dependencies needed to build release tarballs for all other projects that were missing from the list. Related: OS#5347 Change-Id: Iba2e71b2e757bc527561d0f3e4a1af5f024a3cd7 --- M debian-stretch-build-dist/Dockerfile 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile index 359c687..b0c06b6 100644 --- a/debian-stretch-build-dist/Dockerfile +++ b/debian-stretch-build-dist/Dockerfile @@ -4,6 +4,7 @@ RUN apt-get update && \ apt-get install -y --no-install-recommends \ + asciidoc \ autoconf \ autoconf-archive \ autogen \ @@ -12,7 +13,10 @@ build-essential \ ca-certificates \ dahdi-source \ + dblatex \ git \ + graphviz \ + inkscape \ libasn1c-dev \ libboost-all-dev \ libc-ares-dev \ @@ -55,5 +59,9 @@ libusrp-dev \ libyder-dev \ make \ + mscgen \ + python-nwdiag \ + python-pychart \ + xsltproc \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iba2e71b2e757bc527561d0f3e4a1af5f024a3cd7 Gerrit-Change-Number: 26492 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:55:51 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:55:51 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-hnodeb deps In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26493 ) Change subject: debian-stretch-build-dist: osmo-hnodeb deps ...................................................................... debian-stretch-build-dist: osmo-hnodeb deps Related: OS#5347 Change-Id: I9d708d86bf29f9fca0446fb990c606780bd7a1cb --- M debian-stretch-build-dist/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile index b0c06b6..e129d7b 100644 --- a/debian-stretch-build-dist/Dockerfile +++ b/debian-stretch-build-dist/Dockerfile @@ -35,9 +35,11 @@ libortp-dev \ libosmo-abis-dev \ libosmo-gsup-client-dev \ + libosmo-hnbap-dev \ libosmo-mgcp-client-dev \ libosmo-netif-dev \ libosmo-ranap-dev \ + libosmo-rua-dev \ libosmo-sccp-dev \ libosmo-sigtran-dev \ libosmocore-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9d708d86bf29f9fca0446fb990c606780bd7a1cb Gerrit-Change-Number: 26493 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:55:52 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:55:52 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-pcap deps In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26494 ) Change subject: debian-stretch-build-dist: osmo-pcap deps ...................................................................... debian-stretch-build-dist: osmo-pcap deps Related: OS#5347 Change-Id: If0f00dd09ce0db6a05972a564474a707d2d3174b --- M debian-stretch-build-dist/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile index e129d7b..e8cd75b 100644 --- a/debian-stretch-build-dist/Dockerfile +++ b/debian-stretch-build-dist/Dockerfile @@ -60,6 +60,7 @@ libusb-dev \ libusrp-dev \ libyder-dev \ + libzmq3-dev \ make \ mscgen \ python-nwdiag \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If0f00dd09ce0db6a05972a564474a707d2d3174b Gerrit-Change-Number: 26494 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:55:53 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:55:53 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-remsim deps In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26495 ) Change subject: debian-stretch-build-dist: osmo-remsim deps ...................................................................... debian-stretch-build-dist: osmo-remsim deps Related: OS#5347 Change-Id: I8fd4b9d3734dd3bc0e3fca8ceaedda2aedc6a055 --- M debian-stretch-build-dist/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile index e8cd75b..719f941 100644 --- a/debian-stretch-build-dist/Dockerfile +++ b/debian-stretch-build-dist/Dockerfile @@ -20,6 +20,7 @@ libasn1c-dev \ libboost-all-dev \ libc-ares-dev \ + libcsv-dev \ libdbd-sqlite3 \ libdbi-dev \ libfftw3-dev \ @@ -42,6 +43,7 @@ libosmo-rua-dev \ libosmo-sccp-dev \ libosmo-sigtran-dev \ + libosmo-simtrace2-dev \ libosmocore-dev \ libosmodsp-dev \ libpcap-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8fd4b9d3734dd3bc0e3fca8ceaedda2aedc6a055 Gerrit-Change-Number: 26495 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:55:53 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:55:53 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: osmo-uecups deps In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26496 ) Change subject: debian-stretch-build-dist: osmo-uecups deps ...................................................................... debian-stretch-build-dist: osmo-uecups deps Related: OS#5347 Change-Id: I19b6b0363aeeb89ab6aac2b125359589e6b9b5a7 --- M debian-stretch-build-dist/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile index 719f941..1ef8d69 100644 --- a/debian-stretch-build-dist/Dockerfile +++ b/debian-stretch-build-dist/Dockerfile @@ -40,6 +40,7 @@ libosmo-mgcp-client-dev \ libosmo-netif-dev \ libosmo-ranap-dev \ + libnl-route-3-dev \ libosmo-rua-dev \ libosmo-sccp-dev \ libosmo-sigtran-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I19b6b0363aeeb89ab6aac2b125359589e6b9b5a7 Gerrit-Change-Number: 26496 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:56:09 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:56:09 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: sort In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26489 ) Change subject: OSMO_RELEASE_REPOS: sort ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3660032d020154b7a175483691842b576552ffd1 Gerrit-Change-Number: 26489 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:56:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:56:12 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:56:12 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: sync with Nov 2021 releases In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26490 ) Change subject: OSMO_RELEASE_REPOS: sync with Nov 2021 releases ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib2022ca670b322d81ff83bbca3bb262f8d7287a6 Gerrit-Change-Number: 26490 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:56:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:56:15 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:56:15 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26491 ) Change subject: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib52a23a2a7d6ea64bfa539b1d026f035fdb3af57 Gerrit-Change-Number: 26491 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:56:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:56:21 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:56:21 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: sort In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26489 ) Change subject: OSMO_RELEASE_REPOS: sort ...................................................................... OSMO_RELEASE_REPOS: sort Make it easier to figure out which projects are missing. Related: OS#5347 Change-Id: I3660032d020154b7a175483691842b576552ffd1 --- M scripts/common.sh 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/common.sh b/scripts/common.sh index 85725f6..b72dddf 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -6,12 +6,13 @@ # Osmocom repositories of which we want to build release tarballs automatically, and list the current versions at # https://jenkins.osmocom.org/jenkins/job/Osmocom-list-commits/lastSuccessfulBuild/artifact/commits.txt +# List is ordered alphabetically. OSMO_RELEASE_REPOS=" libasn1c libosmo-abis - libosmocore libosmo-netif libosmo-sccp + libosmocore libsmpp34 libusrp osmo-bsc -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3660032d020154b7a175483691842b576552ffd1 Gerrit-Change-Number: 26489 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:56:22 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:56:22 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: sync with Nov 2021 releases In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26490 ) Change subject: OSMO_RELEASE_REPOS: sync with Nov 2021 releases ...................................................................... OSMO_RELEASE_REPOS: sync with Nov 2021 releases Depends: docker-playground I19b6b0363aeeb89ab6aac2b125359589e6b9b5a7 Related: OS#5347 Related: https://osmocom.org/news/152 Change-Id: Ib2022ca670b322d81ff83bbca3bb262f8d7287a6 --- M scripts/common.sh M scripts/osmocom-release-tarballs.sh 2 files changed, 12 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/common.sh b/scripts/common.sh index b72dddf..10fe7f3 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -17,19 +17,26 @@ libusrp osmo-bsc osmo-bts + osmo-cbc + osmo-e1d + osmo-gbproxy osmo-ggsn + osmo-gsm-manuals osmo-hlr + osmo-hnodeb osmo-iuh osmo-mgw osmo-msc + osmo-pcap osmo-pcu osmo-sgsn osmo-sip-connector + osmo-smlc osmo-sysmon osmo-trx + osmo-uecups osmocom-bb " -#TODO: Add above once we have releases: osmo-hnodeb, osmo-gbproxy OSMO_BRANCH_DOCKER_PLAYGROUND="${OSMO_BRANCH_DOCKER_PLAYGROUND:-master}" diff --git a/scripts/osmocom-release-tarballs.sh b/scripts/osmocom-release-tarballs.sh index 9894a47..18ea1d7 100755 --- a/scripts/osmocom-release-tarballs.sh +++ b/scripts/osmocom-release-tarballs.sh @@ -54,6 +54,10 @@ # openbsc echo "1.0.1" ;; + osmo-pcap) + # No rule to make target 'osmo-pcap-server.cfg', needed by 'distdir' + echo "0.0.3" + ;; osmo-pcu) # Duplicates of 0.1.0, 0.2.0 echo "0.1" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib2022ca670b322d81ff83bbca3bb262f8d7287a6 Gerrit-Change-Number: 26490 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:56:23 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 11:56:23 +0000 Subject: Change in osmo-ci[master]: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26491 ) Change subject: OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim ...................................................................... OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim Adjust to simtrace2's directory structure, which does not have a configure.ac in the main directory like all other repositories. The main directory has a regular Makefile without autotools, only the host dir has a configure.ac file (and only in newer versions). Deal with this by creating two tarballs, one with "git archive" for the whole directory, and one for the host dir only with the usual "autoreconf -fi; ./configure; make dist-bzip2". The latter one has the files created by autoreconf ("configure" script and others). simtrace2 ??? simtrace2-0.1.tar.bz2 ??? simtrace2-0.2.tar.bz2 ??? simtrace2-0.3.tar.bz2 ??? simtrace2-0.4.tar.bz2 ??? simtrace2-0.5.1.tar.bz2 ??? simtrace2-0.5.tar.bz2 ??? simtrace2-0.6.1.tar.bz2 ??? simtrace2-0.6.tar.bz2 ??? simtrace2-0.7.0.tar.bz2 ??? simtrace2-0.7.1.tar.bz2 ??? simtrace2-0.8.0.tar.bz2 ??? simtrace2-0.8.1.tar.bz2 ??? simtrace2-host-0.6.1.tar.bz2 ??? simtrace2-host-0.6.tar.bz2 ??? simtrace2-host-0.7.0.tar.bz2 ??? simtrace2-host-0.7.1.tar.bz2 ??? simtrace2-host-0.8.0.tar.bz2 ??? simtrace2-host-0.8.1.tar.bz2 Closes: OS#5347 Change-Id: Ib52a23a2a7d6ea64bfa539b1d026f035fdb3af57 --- M scripts/common.sh M scripts/osmocom-release-tarballs.sh 2 files changed, 74 insertions(+), 8 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/common.sh b/scripts/common.sh index 10fe7f3..8657fd8 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -29,6 +29,7 @@ osmo-msc osmo-pcap osmo-pcu + osmo-remsim osmo-sgsn osmo-sip-connector osmo-smlc @@ -36,6 +37,7 @@ osmo-trx osmo-uecups osmocom-bb + simtrace2 " OSMO_BRANCH_DOCKER_PLAYGROUND="${OSMO_BRANCH_DOCKER_PLAYGROUND:-master}" diff --git a/scripts/osmocom-release-tarballs.sh b/scripts/osmocom-release-tarballs.sh index 18ea1d7..8242a49 100755 --- a/scripts/osmocom-release-tarballs.sh +++ b/scripts/osmocom-release-tarballs.sh @@ -128,7 +128,7 @@ } # Clone an Osmocom repository to $TEMP/repos/$repo, clean it, checkout a tag. -# $1: Osmocom repository +# $1: Osmocom repository (may end in subdir, e.g. simtrace2/host) # $2: tag (optional, default: master) prepare_repo() { local repo="$1" @@ -144,13 +144,21 @@ git checkout -q "$tag" } + +# Get the desired tarball name, replace / with - in $1. +# $1: Osmocom repository (may end in subdir, e.g. simtrace2/host) +# $2: tag +tarball_name() { + echo "$(echo "$repo" | tr / -)-$tag.tar.bz2" +} + # Checkout a given tag and build a release tarball. -# $1: Osmocom repository +# $1: Osmocom repository (may end in subdir, e.g. simtrace2/host) # $2: tag create_tarball() { local repo="$1" local tag="$2" - local tarball="$repo-$tag.tar.bz2" + local tarball="$(tarball_name "$repo" "$tag")" # Be verbose during the tarball build and preparation. Everything else is not verbose, so we can generate an # easy to read overview of tarballs that are already built or are ignored. @@ -174,15 +182,72 @@ fi } +# Create a release tarball with "git archive" for non-autotools projects. +# $1: Osmocom repository +# $2: tag +create_tarball_git() { + local repo="$1" + local tag="$2" + local tarball="$(tarball_name "$repo" "$tag")" + + set -x + + cd "$TEMP/repos/$repo" + git archive \ + -o "$tarball" \ + "$tag" + + set +x +} + # Move a generated release tarball to the output dir. +# $1: Osmocom repository (may end in subdir, e.g. simtrace2/host) +# $2: tag move_tarball() { local repo="$1" local tag="$2" - local tarball="$repo-$tag.tar.bz2" + local tarball="$(tarball_name "$repo" "$tag")" + local repo_dir="$(echo "$repo" | cut -d / -f 1)" cd "$TEMP/repos/$repo" - mkdir -p "$OUTPUT/$repo" - mv "$tarball" "$OUTPUT/$repo/$tarball" + mkdir -p "$OUTPUT/$repo_dir" + mv "$tarball" "$OUTPUT/$repo_dir/$tarball" +} + +# Check if a git tag has a specific file +# $1: Osmocom repository +# $2: tag +# $3: file +tag_has_file() { + local repo="$1" + local tag="$2" + local file="$3" + + git -C "$TEMP/repos/$repo" show "$tag:$file" >/dev/null 2>&1 +} + +# Create and move tarballs for Osmocom repositories. +# $1: Osmocom repository +# $2: tag +create_move_tarball() { + local repo="$1" + local tag="$2" + + case "$repo" in + simtrace2) + if tag_has_file "$repo" "$tag" host/configure.ac; then + create_tarball "$repo/host" "$tag" + move_tarball "$repo/host" "$tag" + fi + + create_tarball_git "$repo" "$tag" + move_tarball "$repo" "$tag" + ;; + *) + create_tarball "$repo" "$tag" + move_tarball "$repo" "$tag" + ;; + esac } remove_temp_dir @@ -211,8 +276,7 @@ fi echo " $tarball (creating)" - create_tarball "$repo" "$tag" - move_tarball "$repo" "$tag" + create_move_tarball "$repo" "$tag" done done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib52a23a2a7d6ea64bfa539b1d026f035fdb3af57 Gerrit-Change-Number: 26491 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 11:59:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 11:59:40 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26522 ) Change subject: MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason ...................................................................... Patch Set 1: well, sooner or later you will want to obtain the ISMI, so I don't see how this code hurts. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaa39a1c1c6c6774f04d643e91bc79666da9d56a6 Gerrit-Change-Number: 26522 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 11:59:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:02:30 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:02:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-{bsc, bts}.cfg: tune logging configuration In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 to look at the new patch set (#2). Change subject: bts/osmo-{bsc,bts}.cfg: tune logging configuration ...................................................................... bts/osmo-{bsc,bts}.cfg: tune logging configuration Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 --- M bts/osmo-bsc.cfg M bts/osmo-bts.cfg 2 files changed, 12 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/26523/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 Gerrit-Change-Number: 26523 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:02:30 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:02:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26524 to look at the new patch set (#2). Change subject: bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' ...................................................................... bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' Change-Id: If2f81141707e6f2360fc57bbd5f76606294f8db8 --- M bsc/osmo-bsc-vamos.cfg M bts/osmo-bsc.cfg 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/26524/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2f81141707e6f2360fc57bbd5f76606294f8db8 Gerrit-Change-Number: 26524 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:02:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:02:32 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: enable extended timestamp in logging References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 ) Change subject: bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging ...................................................................... bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 --- M bsc/osmo-bsc.cfg M bsc/osmo-stp.cfg 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/26535/1 diff --git a/bsc/osmo-bsc.cfg b/bsc/osmo-bsc.cfg index 0ed4916..6eabe73 100644 --- a/bsc/osmo-bsc.cfg +++ b/bsc/osmo-bsc.cfg @@ -5,11 +5,11 @@ ! log stderr logging filter all 1 + logging print extended-timestamp 1 logging print file basename last logging print category-hex 0 logging print category 1 logging print level 1 - logging timestamp 1 logging color 1 ! logging level set-all notice diff --git a/bsc/osmo-stp.cfg b/bsc/osmo-stp.cfg index b0b4f05..59373aa 100644 --- a/bsc/osmo-stp.cfg +++ b/bsc/osmo-stp.cfg @@ -4,11 +4,11 @@ ! log stderr logging filter all 1 + logging print extended-timestamp 1 logging print file basename last logging print category-hex 0 logging print category 1 logging print level 1 - logging timestamp 1 logging color 1 ! logging level set-all notice -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 Gerrit-Change-Number: 26535 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:02:33 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:02:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-{msc, stp}.cfg: enable extended timestamp in logging References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 ) Change subject: msc/osmo-{msc,stp}.cfg: enable extended timestamp in logging ...................................................................... msc/osmo-{msc,stp}.cfg: enable extended timestamp in logging Change-Id: Ia6414d5622fb287fd147c09e791e1b8023d1596e --- M msc/osmo-msc.cfg M msc/osmo-stp.cfg 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/26536/1 diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index 79ffa04..3844e46 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -4,11 +4,11 @@ ! log stderr logging filter all 1 + logging print extended-timestamp 1 logging print file basename last logging print category-hex 0 logging print category 1 logging print level 1 - logging timestamp 1 logging color 1 ! logging level set-all notice diff --git a/msc/osmo-stp.cfg b/msc/osmo-stp.cfg index 727119d..7fde60c 100644 --- a/msc/osmo-stp.cfg +++ b/msc/osmo-stp.cfg @@ -4,11 +4,11 @@ ! log stderr logging filter all 1 + logging print extended-timestamp 1 logging print file basename last logging print category-hex 0 logging print category 1 logging print level 1 - logging timestamp 1 logging color 1 ! logging level set-all notice -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6414d5622fb287fd147c09e791e1b8023d1596e Gerrit-Change-Number: 26536 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:02:33 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:02:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 ) Change subject: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg ...................................................................... bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg Change-Id: I08580e5d8313e644908c1d7b370c5de882f3735c --- M bsc/osmo-bsc-vamos.cfg 1 file changed, 7 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/26537/1 diff --git a/bsc/osmo-bsc-vamos.cfg b/bsc/osmo-bsc-vamos.cfg index 07fb698..30e8735 100644 --- a/bsc/osmo-bsc-vamos.cfg +++ b/bsc/osmo-bsc-vamos.cfg @@ -5,10 +5,14 @@ ! log stderr logging filter all 1 - logging color 1 - logging print category 1 - logging timestamp 1 logging print extended-timestamp 1 + logging print file basename last + logging print category-hex 0 + logging print category 1 + logging print level 1 + logging color 1 +! + logging level set-all notice logging level rll notice logging level mm notice logging level rr notice @@ -22,24 +26,6 @@ logging level ctrl notice logging level filter debug logging level pcu debug - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl notice - logging level lgtp notice - logging level lstats notice - logging level lgsup notice - logging level loap notice - logging level lss7 notice - logging level lsccp notice - logging level lsua notice - logging level lm3ua notice - logging level lmgcp notice - logging level reset notice ! stats interval 0 stats reporter statsd -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08580e5d8313e644908c1d7b370c5de882f3735c Gerrit-Change-Number: 26537 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:03:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 12:03:09 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:03:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:03:12 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 12:03:12 +0000 Subject: Change in osmo-pcap[master]: Revert "configure.ac: don't depend on libosmogb." In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26534 ) Change subject: Revert "configure.ac: don't depend on libosmogb." ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ic358956521230a2f6525533779c27417b2e86833 Gerrit-Change-Number: 26534 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:03:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:03:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 12:03:15 +0000 Subject: Change in osmo-pcap[master]: Revert "configure.ac: don't depend on libosmogb." In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/26534 ) Change subject: Revert "configure.ac: don't depend on libosmogb." ...................................................................... Revert "configure.ac: don't depend on libosmogb." gprs header files from libosmogb are needed for osmo-pcap. This was the reason why it was added as dependency to configure.ac in I9a8fa03cef1efc9fdaea65ee63ca9b3379993989. $ git grep "osmocom/gprs" src/osmo_client_core.c:#include src/osmo_client_core.c:#include src/osmo_client_core.c:#include The package is only still building for debian, because in debian libosmocore is not split up, and for centos, because the rpm spec file still lists the dependency. This reverts commit 2c2eadcadf59ac42a02339f554c5daa48ee4f9fd. Change-Id: Ic358956521230a2f6525533779c27417b2e86833 --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 06c9dc2..fa9a3c8 100644 --- a/configure.ac +++ b/configure.ac @@ -158,6 +158,8 @@ dnl checks for libraries PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +# libosmogb: needed for osmocom/gprs includes +PKG_CHECK_MODULES(LIBOSMOGB, libosmogb >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) PKG_CHECK_MODULES(LIBZMQ, libzmq >= 3.2.2) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/26534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ic358956521230a2f6525533779c27417b2e86833 Gerrit-Change-Number: 26534 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:04:47 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 12:04:47 +0000 Subject: Change in osmo-bts[master]: oml: use proper talloc context in oml_rx_set_radio_attr() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26525 ) Change subject: oml: use proper talloc context in oml_rx_set_radio_attr() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26525 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I69b6c72d85f68e4225d7786646f24259a5964998 Gerrit-Change-Number: 26525 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:04:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:04:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 12:04:54 +0000 Subject: Change in osmo-bts[master]: oml: use ts->trx as talloc-context in oml_rx_set_chan_attr() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26526 ) Change subject: oml: use ts->trx as talloc-context in oml_rx_set_chan_attr() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26526 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6dc3706a486726afa9eec5d2e5369bd62c511455 Gerrit-Change-Number: 26526 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:04:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:05:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 12:05:09 +0000 Subject: Change in osmo-bts[master]: oml: fix copy-pasted comments in oml_rx_set_*_attr() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26527 ) Change subject: oml: fix copy-pasted comments in oml_rx_set_*_attr() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaa0e630b28b2a86312c069e7e55dd8bc5743759a Gerrit-Change-Number: 26527 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:05:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:05:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 12:05:26 +0000 Subject: Change in osmo-bts[master]: oml: assign unique names to 'struct tlv_parsed' chunks In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26528 ) Change subject: oml: assign unique names to 'struct tlv_parsed' chunks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie248d2a65a11da914324a7e65b767b894ed8644a Gerrit-Change-Number: 26528 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:05:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:06:56 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 12:06:56 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:06:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:06:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 12:06:59 +0000 Subject: Change in docker-playground[master]: osmo-pcap-master: doesn't need libosmo-netif In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26498 ) Change subject: osmo-pcap-master: doesn't need libosmo-netif ...................................................................... osmo-pcap-master: doesn't need libosmo-netif Don't attempt to install libosmo-netif in this Dockerfile. I've noticed this because we want to build osmo-pcap for CentOS7 with this container to run the TTCN-3 tests, and we don't have libosmo-netif for CentOS7. Add pkgconfig(libosmogb), which is required to build osmo-pcap according to configure.ac. In Debian, this gets installed as part of libosmocore-dev. Related: SYS#5754 Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 --- M osmo-pcap-master/Dockerfile 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Verified diff --git a/osmo-pcap-master/Dockerfile b/osmo-pcap-master/Dockerfile index a2b75c1..eeb210c 100644 --- a/osmo-pcap-master/Dockerfile +++ b/osmo-pcap-master/Dockerfile @@ -9,16 +9,15 @@ apt-get update && \ apt-get install -y --no-install-recommends \ libosmocore-dev \ - libosmo-netif-dev \ libzmq3-dev \ && \ apt-get clean \ ;; \ centos*) \ dnf install -y \ - "pkgconfig(libosmo-netif)" \ "pkgconfig(libosmocore)" \ "pkgconfig(libosmoctrl)" \ + "pkgconfig(libosmogb)" \ "pkgconfig(libosmogsm)" \ "pkgconfig(libosmovty)" \ "pkgconfig(libzmq)" \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9c3a3b43ee7c25c06042f3303b9edb4005e7db31 Gerrit-Change-Number: 26498 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:07:00 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 12:07:00 +0000 Subject: Change in docker-playground[master]: osmo-pcap-latest: fix install path for centos In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26499 ) Change subject: osmo-pcap-latest: fix install path for centos ...................................................................... osmo-pcap-latest: fix install path for centos Adjust to the package not being split in rpm packaging. This was not noticed before, because we did not run TTCN-3 tests for osmo-pcap with CentOS8. Related: SYS#5754 Change-Id: I775776ff7f358fee3d085f814c295c49225f5170 --- M osmo-pcap-latest/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/osmo-pcap-latest/Dockerfile b/osmo-pcap-latest/Dockerfile index e0e6fa7..9737c4e 100644 --- a/osmo-pcap-latest/Dockerfile +++ b/osmo-pcap-latest/Dockerfile @@ -14,7 +14,7 @@ ;; \ centos*) \ dnf install -y \ - osmo-pcap-client osmo-pcap-server \ + osmo-pcap \ ;; \ esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I775776ff7f358fee3d085f814c295c49225f5170 Gerrit-Change-Number: 26499 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:07:14 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:07:14 +0000 Subject: Change in osmo-bts[master]: oml: use proper talloc context in oml_rx_set_radio_attr() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26525 ) Change subject: oml: use proper talloc context in oml_rx_set_radio_attr() ...................................................................... oml: use proper talloc context in oml_rx_set_radio_attr() Change-Id: I69b6c72d85f68e4225d7786646f24259a5964998 --- M src/common/oml.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/oml.c b/src/common/oml.c index a434ad3..e352244 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -736,7 +736,7 @@ } /* merge existing BTS attributes with new attributes */ - tp_merged = osmo_tlvp_copy(trx->mo.nm_attr, trx->bts); + tp_merged = osmo_tlvp_copy(trx->mo.nm_attr, trx); osmo_tlvp_merge(tp_merged, &tp); /* Ask BTS driver to validate new merged attributes */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26525 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I69b6c72d85f68e4225d7786646f24259a5964998 Gerrit-Change-Number: 26525 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:07:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:07:15 +0000 Subject: Change in osmo-bts[master]: oml: use ts->trx as talloc-context in oml_rx_set_chan_attr() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26526 ) Change subject: oml: use ts->trx as talloc-context in oml_rx_set_chan_attr() ...................................................................... oml: use ts->trx as talloc-context in oml_rx_set_chan_attr() Change-Id: I6dc3706a486726afa9eec5d2e5369bd62c511455 --- M src/common/oml.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/oml.c b/src/common/oml.c index e352244..4e09008 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -950,7 +950,7 @@ } /* merge existing BTS attributes with new attributes */ - tp_merged = osmo_tlvp_copy(ts->mo.nm_attr, bts); + tp_merged = osmo_tlvp_copy(ts->mo.nm_attr, ts->trx); osmo_tlvp_merge(tp_merged, &tp); /* Call into BTS driver to check attribute values */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26526 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6dc3706a486726afa9eec5d2e5369bd62c511455 Gerrit-Change-Number: 26526 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:07:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:07:15 +0000 Subject: Change in osmo-bts[master]: oml: fix copy-pasted comments in oml_rx_set_*_attr() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26527 ) Change subject: oml: fix copy-pasted comments in oml_rx_set_*_attr() ...................................................................... oml: fix copy-pasted comments in oml_rx_set_*_attr() Change-Id: Iaa0e630b28b2a86312c069e7e55dd8bc5743759a --- M src/common/oml.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/oml.c b/src/common/oml.c index 4e09008..c8819c9 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -735,7 +735,7 @@ return oml_fom_ack_nack(msg, NM_NACK_INCORR_STRUCT); } - /* merge existing BTS attributes with new attributes */ + /* merge existing TRX attributes with new attributes */ tp_merged = osmo_tlvp_copy(trx->mo.nm_attr, trx); osmo_tlvp_merge(tp_merged, &tp); @@ -746,7 +746,7 @@ return oml_fom_ack_nack(msg, -rc); } - /* Success: replace old BTS attributes with new */ + /* Success: replace old TRX attributes with new */ talloc_free(trx->mo.nm_attr); trx->mo.nm_attr = tp_merged; @@ -949,7 +949,7 @@ return oml_fom_ack_nack(msg, NM_NACK_SPEC_IMPL_NOTSUPP); } - /* merge existing BTS attributes with new attributes */ + /* merge existing CHAN attributes with new attributes */ tp_merged = osmo_tlvp_copy(ts->mo.nm_attr, ts->trx); osmo_tlvp_merge(tp_merged, &tp); @@ -962,7 +962,7 @@ return oml_fom_ack_nack(msg, -rc); } - /* Success: replace old BTS attributes with new */ + /* Success: replace old CHAN attributes with new */ talloc_free(ts->mo.nm_attr); ts->mo.nm_attr = tp_merged; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaa0e630b28b2a86312c069e7e55dd8bc5743759a Gerrit-Change-Number: 26527 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:07:16 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:07:16 +0000 Subject: Change in osmo-bts[master]: oml: assign unique names to 'struct tlv_parsed' chunks In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26528 ) Change subject: oml: assign unique names to 'struct tlv_parsed' chunks ...................................................................... oml: assign unique names to 'struct tlv_parsed' chunks Change-Id: Ie248d2a65a11da914324a7e65b767b894ed8644a --- M src/common/oml.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/oml.c b/src/common/oml.c index c8819c9..724e4f8 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -580,6 +580,7 @@ /* merge existing BTS attributes with new attributes */ tp_merged = osmo_tlvp_copy(bts->mo.nm_attr, bts); + talloc_set_name_const(tp_merged, "oml_bts_attr"); osmo_tlvp_merge(tp_merged, &tp); /* Ask BTS driver to validate new merged attributes */ @@ -737,6 +738,7 @@ /* merge existing TRX attributes with new attributes */ tp_merged = osmo_tlvp_copy(trx->mo.nm_attr, trx); + talloc_set_name_const(tp_merged, "oml_trx_attr"); osmo_tlvp_merge(tp_merged, &tp); /* Ask BTS driver to validate new merged attributes */ @@ -951,6 +953,7 @@ /* merge existing CHAN attributes with new attributes */ tp_merged = osmo_tlvp_copy(ts->mo.nm_attr, ts->trx); + talloc_set_name_const(tp_merged, "oml_chan_attr"); osmo_tlvp_merge(tp_merged, &tp); /* Call into BTS driver to check attribute values */ @@ -1395,6 +1398,7 @@ /* Success: replace old MO attributes with new */ /* merge existing MO attributes with new attributes */ tp_merged = osmo_tlvp_copy(mo->nm_attr, bts); + talloc_set_name_const(tp_merged, "oml_ipa_attr"); osmo_tlvp_merge(tp_merged, &tp); talloc_free(mo->nm_attr); mo->nm_attr = tp_merged; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie248d2a65a11da914324a7e65b767b894ed8644a Gerrit-Change-Number: 26528 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:07:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 12:07:29 +0000 Subject: Change in osmo-bts[master]: osmo-bts-trx: use l1ts as talloc context for burst buffers In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26531 ) Change subject: osmo-bts-trx: use l1ts as talloc context for burst buffers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26531 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idb1ceaf83c433d2d0eb84d77c2187a00a657905c Gerrit-Change-Number: 26531 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:07:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:07:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 12:07:43 +0000 Subject: Change in osmo-bts[master]: osmo-bts-trx: fix a memleak in trx_sched_set_lchan() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26532 ) Change subject: osmo-bts-trx: fix a memleak in trx_sched_set_lchan() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I93310e7aed91a49c0511e2ed30e000440617f95a Gerrit-Change-Number: 26532 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:07:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:07:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 12:07:52 +0000 Subject: Change in osmo-bts[master]: cbch: cosmetic: use talloc_zero() in bts_process_smscb_cmd() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26533 ) Change subject: cbch: cosmetic: use talloc_zero() in bts_process_smscb_cmd() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibb5090b7cd53c1a485d0b9474c6470fa5831de67 Gerrit-Change-Number: 26533 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:07:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:09:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 12:09:32 +0000 Subject: Change in osmo-mgw[master]: Add multithreading for the virtual trunk In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 ) Change subject: Add multithreading for the virtual trunk ...................................................................... Patch Set 37: no follow-up for two weeks? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 37 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 13 Dec 2021 12:09:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:12:10 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:12:10 +0000 Subject: Change in osmo-bts[master]: osmo-bts-trx: use l1ts as talloc context for burst buffers In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26531 ) Change subject: osmo-bts-trx: use l1ts as talloc context for burst buffers ...................................................................... osmo-bts-trx: use l1ts as talloc context for burst buffers Before a massive refactoring of the scheduler structures [1] it was impossible to have a clean hierarchy, in which the burst buffers get allocated as children of their parent timeslot structures. This change makes it easier to read talloc reports and simplifies memory management, offloading free()ing of the burst bufferes to talloc. Change-Id: Idb1ceaf83c433d2d0eb84d77c2187a00a657905c Related: [1] I7c4379e43a25e9d858d582a99bf6c4b65c9af481 --- M src/common/scheduler.c M src/osmo-bts-trx/sched_lchan_pdtch.c M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c M src/osmo-bts-trx/sched_lchan_xcch.c 5 files changed, 10 insertions(+), 23 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/scheduler.c b/src/common/scheduler.c index d8048b5..bd33ce1 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -662,18 +662,7 @@ msgb_queue_flush(&l1ts->dl_prims); rate_ctr_group_free(l1ts->ctrs); l1ts->ctrs = NULL; - for (i = 0; i < _TRX_CHAN_MAX; i++) { - struct l1sched_chan_state *chan_state; - chan_state = &l1ts->chan_state[i]; - if (chan_state->dl_bursts) { - talloc_free(chan_state->dl_bursts); - chan_state->dl_bursts = NULL; - } - if (chan_state->ul_bursts) { - talloc_free(chan_state->ul_bursts); - chan_state->ul_bursts = NULL; - } - } + /* clear lchan channel states */ for (i = 0; i < ARRAY_SIZE(ts->lchan); i++) lchan_set_state(&ts->lchan[i], LCHAN_S_NONE); diff --git a/src/osmo-bts-trx/sched_lchan_pdtch.c b/src/osmo-bts-trx/sched_lchan_pdtch.c index 66be116..6a2ad0d 100644 --- a/src/osmo-bts-trx/sched_lchan_pdtch.c +++ b/src/osmo-bts-trx/sched_lchan_pdtch.c @@ -58,8 +58,7 @@ /* allocate burst memory, if not already */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, - GSM0503_EGPRS_BURSTS_NBITS); + *bursts_p = talloc_zero_size(l1ts, GSM0503_EGPRS_BURSTS_NBITS); if (!*bursts_p) return -ENOMEM; } @@ -174,8 +173,7 @@ /* allocate burst memory, if not already */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, - GSM0503_EGPRS_BURSTS_NBITS); + *bursts_p = talloc_zero_size(l1ts, GSM0503_EGPRS_BURSTS_NBITS); if (!*bursts_p) return -ENOMEM; } diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 85ab321..08a58bb 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -76,7 +76,7 @@ /* allocate burst memory, if not already */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, 928); + *bursts_p = talloc_zero_size(l1ts, 928); if (!*bursts_p) return -ENOMEM; } @@ -521,7 +521,7 @@ /* allocate burst memory, if not already, * otherwise shift buffer by 4 bursts for interleaving */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, 928); + *bursts_p = talloc_zero_size(l1ts, 928); if (!*bursts_p) return -ENOMEM; } else { diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index 366c625..51a0b90 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -83,7 +83,7 @@ /* allocate burst memory, if not already */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, 696); + *bursts_p = talloc_zero_size(l1ts, 696); if (!*bursts_p) return -ENOMEM; } @@ -417,7 +417,7 @@ /* allocate burst memory, if not already, * otherwise shift buffer by 2 bursts for interleaving */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, 696); + *bursts_p = talloc_zero_size(l1ts, 696); if (!*bursts_p) return -ENOMEM; } else { diff --git a/src/osmo-bts-trx/sched_lchan_xcch.c b/src/osmo-bts-trx/sched_lchan_xcch.c index e8f46c1..6a65574 100644 --- a/src/osmo-bts-trx/sched_lchan_xcch.c +++ b/src/osmo-bts-trx/sched_lchan_xcch.c @@ -71,7 +71,7 @@ /* allocate burst memory, if not already */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, 464); + *bursts_p = talloc_zero_size(l1ts, 464); if (!*bursts_p) return -ENOMEM; } @@ -79,7 +79,7 @@ /* UL-SACCH requires additional memory to keep a copy of each previous * burst set. */ if (L1SAP_IS_LINK_SACCH(trx_chan_desc[bi->chan].link_id) && !chan_state->ul_bursts_prev) { - chan_state->ul_bursts_prev = talloc_zero_size(tall_bts_ctx, 464); + chan_state->ul_bursts_prev = talloc_zero_size(l1ts, 464); if (!chan_state->ul_bursts_prev) return -ENOMEM; } @@ -224,7 +224,7 @@ /* allocate burst memory, if not already */ if (!*bursts_p) { - *bursts_p = talloc_zero_size(tall_bts_ctx, 464); + *bursts_p = talloc_zero_size(l1ts, 464); if (!*bursts_p) return -ENOMEM; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26531 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idb1ceaf83c433d2d0eb84d77c2187a00a657905c Gerrit-Change-Number: 26531 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:12:10 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:12:10 +0000 Subject: Change in osmo-bts[master]: osmo-bts-trx: fix a memleak in trx_sched_set_lchan() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26532 ) Change subject: osmo-bts-trx: fix a memleak in trx_sched_set_lchan() ...................................................................... osmo-bts-trx: fix a memleak in trx_sched_set_lchan() An additional burst buffer is allocated in rx_data_fn() for Uplink SACCH repetition, but unlike the main buffer it never gets free()d. Change-Id: I93310e7aed91a49c0511e2ed30e000440617f95a Fixes: I7e4cc33cc010866e41e3b594351a7f7bf93e08ac Related: OS#4795, SYS#5114 --- M src/common/scheduler.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/scheduler.c b/src/common/scheduler.c index bd33ce1..e854ce1 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -1109,6 +1109,10 @@ talloc_free(chan_state->ul_bursts); chan_state->ul_bursts = NULL; } + if (chan_state->ul_bursts_prev) { + talloc_free(chan_state->ul_bursts_prev); + chan_state->ul_bursts_prev = NULL; + } if (active) { /* Clean up everything */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I93310e7aed91a49c0511e2ed30e000440617f95a Gerrit-Change-Number: 26532 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:12:11 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:12:11 +0000 Subject: Change in osmo-bts[master]: cbch: cosmetic: use talloc_zero() in bts_process_smscb_cmd() In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26533 ) Change subject: cbch: cosmetic: use talloc_zero() in bts_process_smscb_cmd() ...................................................................... cbch: cosmetic: use talloc_zero() in bts_process_smscb_cmd() Change-Id: Ibb5090b7cd53c1a485d0b9474c6470fa5831de67 --- M src/common/cbch.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/cbch.c b/src/common/cbch.c index f1f8b6a..f65df0d 100644 --- a/src/common/cbch.c +++ b/src/common/cbch.c @@ -198,7 +198,7 @@ return -EINVAL; } - scm = talloc_zero_size(bts, sizeof(*scm)); + scm = talloc_zero(bts, struct smscb_msg); if (!scm) return -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibb5090b7cd53c1a485d0b9474c6470fa5831de67 Gerrit-Change-Number: 26533 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:51:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 12:51:04 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 ) Change subject: bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 Gerrit-Change-Number: 26535 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:51:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:51:45 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 12:51:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 ) Change subject: bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 1: -Code-Review Wait, are you sure this is correct? You still need to keep the timestamp thing afaik. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 Gerrit-Change-Number: 26535 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:51:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:51:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 12:51:56 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-{msc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 ) Change subject: msc/osmo-{msc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 1: Same, I think you need to keep the old time too. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6414d5622fb287fd147c09e791e1b8023d1596e Gerrit-Change-Number: 26536 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:51:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:52:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 12:52:21 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-{bsc, bts}.cfg: tune logging configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 ) Change subject: bts/osmo-{bsc,bts}.cfg: tune logging configuration ...................................................................... Patch Set 2: same, logging timestamp 1 must be kept afaik. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 Gerrit-Change-Number: 26523 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:52:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:52:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 12:52:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26524 ) Change subject: bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2f81141707e6f2360fc57bbd5f76606294f8db8 Gerrit-Change-Number: 26524 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:52:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:53:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 12:53:03 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 ) Change subject: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08580e5d8313e644908c1d7b370c5de882f3735c Gerrit-Change-Number: 26537 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:53:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 12:58:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 12:58:39 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 ) Change subject: bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 1: > Patch Set 1: -Code-Review > > Wait, are you sure this is correct? You still need to keep the timestamp thing afaik. Nope, "logging print extended-timestamp" alone makes timestamps appear in the logs. I would expect both options to be mutually exclusive, but in reality the "logging print extended-timestamp" takes precedence if both are specified. Though, I can keep the "logging timestamp" if you think it makes sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 Gerrit-Change-Number: 26535 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 12:58:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 13:21:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 13:21:03 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 ) Change subject: bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: -Code-Review > > > > Wait, are you sure this is correct? You still need to keep the timestamp thing afaik. > > Nope, "logging print extended-timestamp" alone makes timestamps appear in the logs. I would expect both options to be mutually exclusive, but in reality the "logging print extended-timestamp" takes precedence if both are specified. Though, I can keep the "logging timestamp" if you think it makes sense. Ok, I always thought "logging timestamp" was the one enabling/disabling timestamp printing, and "logging print extended-timestamp" was actually a format modifier if timestamp is printed. Let's see what are others expectancies regarding this topic. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 Gerrit-Change-Number: 26535 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 13:21:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 14:54:31 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 14:54:31 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: add python3-nwdiag References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26538 ) Change subject: debian-stretch-build-dist: add python3-nwdiag ...................................................................... debian-stretch-build-dist: add python3-nwdiag Recent versions of osmo-gsm-manuals need python3-nwdiag instead of the python2 version. Install that too to successfully run the configure script. Related: OS#5347 Related: https://jenkins.osmocom.org/jenkins/job/Osmocom-release-tarballs/920/console Change-Id: I127bd3855d44ccc68a5b0c4d83147fb470cc10c9 --- M debian-stretch-build-dist/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/38/26538/1 diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile index 1ef8d69..e444ed5 100644 --- a/debian-stretch-build-dist/Dockerfile +++ b/debian-stretch-build-dist/Dockerfile @@ -68,6 +68,7 @@ mscgen \ python-nwdiag \ python-pychart \ + python3-nwdiag \ xsltproc \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I127bd3855d44ccc68a5b0c4d83147fb470cc10c9 Gerrit-Change-Number: 26538 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 14:54:43 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 14:54:43 +0000 Subject: Change in osmo-ci[master]: osmocom-release-tarballs: fix missing st2 clone References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26539 ) Change subject: osmocom-release-tarballs: fix missing st2 clone ...................................................................... osmocom-release-tarballs: fix missing st2 clone Clone simtrace2.git before trying to create the tarball with git. Fix for: simtrace2 simtrace2-0.1.tar.bz2 (creating) + cd /osmo-ci/_temp/repos/simtrace2 /osmo-ci/scripts/osmocom-release-tarballs.sh: 195: cd: can't cd to /osmo-ci/_temp/repos/simtrace2 Related: OS#5347 Fixes: 0221a0 ("OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim") Change-Id: I0a845549ba1fe9f0d9ab55a5c5c7bf5b8f57caae --- M scripts/osmocom-release-tarballs.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/39/26539/1 diff --git a/scripts/osmocom-release-tarballs.sh b/scripts/osmocom-release-tarballs.sh index 8242a49..3ac4545 100755 --- a/scripts/osmocom-release-tarballs.sh +++ b/scripts/osmocom-release-tarballs.sh @@ -238,6 +238,8 @@ if tag_has_file "$repo" "$tag" host/configure.ac; then create_tarball "$repo/host" "$tag" move_tarball "$repo/host" "$tag" + else + prepare_repo "$repo" fi create_tarball_git "$repo" "$tag" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0a845549ba1fe9f0d9ab55a5c5c7bf5b8f57caae Gerrit-Change-Number: 26539 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 14:59:22 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 14:59:22 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: add python3-nwdiag In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26538 ) Change subject: debian-stretch-build-dist: add python3-nwdiag ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I127bd3855d44ccc68a5b0c4d83147fb470cc10c9 Gerrit-Change-Number: 26538 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 14:59:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 14:59:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 14:59:53 +0000 Subject: Change in osmo-ci[master]: osmocom-release-tarballs: fix missing st2 clone In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26539 ) Change subject: osmocom-release-tarballs: fix missing st2 clone ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0a845549ba1fe9f0d9ab55a5c5c7bf5b8f57caae Gerrit-Change-Number: 26539 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 14:59:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:21:34 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 15:21:34 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: add python3-nwdiag In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26538 ) Change subject: debian-stretch-build-dist: add python3-nwdiag ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I127bd3855d44ccc68a5b0c4d83147fb470cc10c9 Gerrit-Change-Number: 26538 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 15:21:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:25:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 15:25:39 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bts.cfg: use default {fn, rts}-advance values In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 ) Change subject: bts/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... Patch Set 2: Verified+1 Tested on my machine, no regressions observed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id97e848e5dfd0b6c504d06f62642511cfd5a0f66 Gerrit-Change-Number: 26530 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 15:25:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:26:18 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 15:26:18 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: add python3-nwdiag In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26538 ) Change subject: debian-stretch-build-dist: add python3-nwdiag ...................................................................... Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I127bd3855d44ccc68a5b0c4d83147fb470cc10c9 Gerrit-Change-Number: 26538 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 15:26:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:26:21 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 15:26:21 +0000 Subject: Change in docker-playground[master]: debian-stretch-build-dist: add python3-nwdiag In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26538 ) Change subject: debian-stretch-build-dist: add python3-nwdiag ...................................................................... debian-stretch-build-dist: add python3-nwdiag Recent versions of osmo-gsm-manuals need python3-nwdiag instead of the python2 version. Install that too to successfully run the configure script. Related: OS#5347 Related: https://jenkins.osmocom.org/jenkins/job/Osmocom-release-tarballs/920/console Change-Id: I127bd3855d44ccc68a5b0c4d83147fb470cc10c9 --- M debian-stretch-build-dist/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile index 1ef8d69..e444ed5 100644 --- a/debian-stretch-build-dist/Dockerfile +++ b/debian-stretch-build-dist/Dockerfile @@ -68,6 +68,7 @@ mscgen \ python-nwdiag \ python-pychart \ + python3-nwdiag \ xsltproc \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I127bd3855d44ccc68a5b0c4d83147fb470cc10c9 Gerrit-Change-Number: 26538 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:27:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 15:27:07 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bts.cfg: use default {fn, rts}-advance values In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 ) Change subject: bts/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id97e848e5dfd0b6c504d06f62642511cfd5a0f66 Gerrit-Change-Number: 26530 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 15:27:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:29:01 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 15:29:01 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test/osmo-bts.cfg: use default {fn, rts}-advance values In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26529 ) Change subject: ttcn3-bts-test/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... Patch Set 1: Verified+1 > Patch Set 1: > > the question is whether our test runtime environment can work with that. The reduced values were verified with real-world SDR hardware. The test setup could well be running slower? fake_trx.py simply forwards bursts without buffering, so in theory it should not be doing slower than osmo-trx with a real SDR. Even if a burst is scheduled 20 frames in advance, it gets forwarded to trxcon immediately. I did a test run, and observed no regressions, this setting V+1. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If8438adfdbc506d2b6b7858ea8a0ea859ba246a1 Gerrit-Change-Number: 26529 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 15:29:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:30:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 15:30:36 +0000 Subject: Change in docker-playground[master]: bts: Use osmo-config-merge to generate osmo-{bts, bsc}.cfg In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 ) Change subject: bts: Use osmo-config-merge to generate osmo-{bts,bsc}.cfg ...................................................................... Patch Set 1: Hi Laforge! Don't you mind if I take this patch over and try to move it forward? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 Gerrit-Change-Number: 20622 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 13 Dec 2021 15:30:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:31:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 15:31:50 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test/osmo-bts.cfg: use default {fn, rts}-advance values In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26529 ) Change subject: ttcn3-bts-test/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If8438adfdbc506d2b6b7858ea8a0ea859ba246a1 Gerrit-Change-Number: 26529 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 15:31:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:31:51 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 15:31:51 +0000 Subject: Change in osmo-ttcn3-hacks[master]: MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason In-Reply-To: References: Message-ID: fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26522 ) Change subject: MME_Tests: fix as_DIA_UpdLoc(): do not extract IMSI for no reason ...................................................................... Abandoned Just a misc change, not really required for my task. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaa39a1c1c6c6774f04d643e91bc79666da9d56a6 Gerrit-Change-Number: 26522 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:32:43 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 15:32:43 +0000 Subject: Change in osmo-ci[master]: jobs/ttcn3-testsuites: adjust cmd for centos7 References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26540 ) Change subject: jobs/ttcn3-testsuites: adjust cmd for centos7 ...................................................................... jobs/ttcn3-testsuites: adjust cmd for centos7 Related: SYS#5754 Change-Id: Iaf6162682074f5f9de70d420e91a72f283e695bc --- M jobs/ttcn3-testsuites.yml 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/40/26540/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 854a5fb..3074d40 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -401,6 +401,10 @@ DIR="$(echo "{job-name}" | sed s/^TTCN3-centos\-/ttcn3-/ | sed s/\-latest$//)" export IMAGE_SUFFIX="latest-centos8" ;; + TTCN3-centos7-*-latest) + DIR="$(echo "{job-name}" | sed s/^TTCN3-centos7\-/ttcn3-/ | sed s/\-latest$//)" + export IMAGE_SUFFIX="latest-centos7" + ;; TTCN3-centos-*-20*q*) export OSMOCOM_REPO_TESTSUITE_MIRROR="http://download.opensuse.org" export OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" @@ -413,6 +417,10 @@ DIR="$(echo "{job-name}" | sed s/^TTCN3-centos\-/ttcn3-/)" export IMAGE_SUFFIX="master-centos8" ;; + TTCN3-centos7-*) + DIR="$(echo "{job-name}" | sed s/^TTCN3-centos7\-/ttcn3-/)" + export IMAGE_SUFFIX="master-centos7" + ;; *-latest) DIR="$(echo "{job-name}" | sed s/\-latest$//)" export IMAGE_SUFFIX="latest" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaf6162682074f5f9de70d420e91a72f283e695bc Gerrit-Change-Number: 26540 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:35:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 15:35:41 +0000 Subject: Change in osmo-ci[master]: jobs/ttcn3-testsuites: adjust cmd for centos7 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26540 ) Change subject: jobs/ttcn3-testsuites: adjust cmd for centos7 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaf6162682074f5f9de70d420e91a72f283e695bc Gerrit-Change-Number: 26540 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 15:35:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:36:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 15:36:33 +0000 Subject: Change in osmo-dev[master]: Add tmux scripts for ttcn3-{msc, bsc, bts}-test In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26485 ) Change subject: Add tmux scripts for ttcn3-{msc,bsc,bts}-test ...................................................................... Patch Set 3: I personally run stuff over docker, so letting whoever else runs TTCn3 stuff locally (and with more tmux experience) to decide here. -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 Gerrit-Change-Number: 26485 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 15:36:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:36:42 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 15:36:42 +0000 Subject: Change in osmo-ci[master]: jobs/registry-update-base-images: add centos7 References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26541 ) Change subject: jobs/registry-update-base-images: add centos7 ...................................................................... jobs/registry-update-base-images: add centos7 Related: SYS#5754 Change-Id: I64ce913b79dad063fd34848be538b088d6b3402d --- M jobs/registry-update-base-images.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/41/26541/1 diff --git a/jobs/registry-update-base-images.yml b/jobs/registry-update-base-images.yml index 48e8b59..2dd6e69 100644 --- a/jobs/registry-update-base-images.yml +++ b/jobs/registry-update-base-images.yml @@ -16,7 +16,7 @@ builders: - shell: | REGISTRY="registry.osmocom.org" - IMAGES="debian:stretch debian:buster debian:jessie debian:sid ubuntu:zesty centos:centos8" + IMAGES="debian:stretch debian:buster debian:jessie debian:sid ubuntu:zesty centos:centos7 centos:centos8" for i in $IMAGES; do src=$i dst=${REGISTRY}/$i -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I64ce913b79dad063fd34848be538b088d6b3402d Gerrit-Change-Number: 26541 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:37:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 15:37:55 +0000 Subject: Change in osmo-ci[master]: jobs/registry-update-base-images: add centos7 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26541 ) Change subject: jobs/registry-update-base-images: add centos7 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I64ce913b79dad063fd34848be538b088d6b3402d Gerrit-Change-Number: 26541 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 15:37:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:46:04 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 15:46:04 +0000 Subject: Change in osmo-dev[master]: Add tmux scripts for ttcn3-{msc, bsc, bts}-test In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26485 ) Change subject: Add tmux scripts for ttcn3-{msc,bsc,bts}-test ...................................................................... Patch Set 3: Thanks for submitting these, Vadim! Would be great if you could describe this briefly in README. Otherwise LGTM. -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 Gerrit-Change-Number: 26485 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 15:46:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:48:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 15:48:59 +0000 Subject: Change in osmo-dev[master]: README: update deps and recommended opts References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/26542 ) Change subject: README: update deps and recommended opts ...................................................................... README: update deps and recommended opts In preparation for the OsmoDevCall#19 talk, I'm installing this on a fresh system and made some adjustments to README so it works without complaining about missing dependencies. Related: https://osmocom.org/news/155 Change-Id: I7522d8c9346e9823f3977b9190210eb5d5bcfe2d --- M README 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/42/26542/1 diff --git a/README b/README index ac77424..7f1b594 100644 --- a/README +++ b/README @@ -13,9 +13,9 @@ build-essential gcc g++ make automake autoconf libtool pkg-config \ libtalloc-dev libpcsclite-dev libortp-dev libsctp-dev libssl-dev libdbi-dev \ libdbd-sqlite3 libsqlite3-dev libpcap-dev libc-ares-dev libgnutls28-dev \ - libsctp-dev sqlite3 + libsctp-dev sqlite3 libusb-1.0-0-dev libmnl-dev libsofia-sip-ua-glib-dev -./gen_makefile.py default.opts iu.opts -I -m make +./gen_makefile.py default.opts iu.opts no_dahdi.opts -I -m make cd make make -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7522d8c9346e9823f3977b9190210eb5d5bcfe2d Gerrit-Change-Number: 26542 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:49:01 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 15:49:01 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: fix find errors References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/26543 ) Change subject: gen_makefile.py: fix find errors ...................................................................... gen_makefile.py: fix find errors Don't print find errors if not all dirs were cloned. Found this also while running osmo-dev on a fresh install. Change-Id: I7955fedc96484e5703073b63906a03477452db6e --- M gen_makefile.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/43/26543/1 diff --git a/gen_makefile.py b/gen_makefile.py index 7c780a5..9eb2d94 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -177,7 +177,7 @@ -name "Makefile.am" \ -or -name "*.in" \ -and -not -name "Makefile.in" \ - -and -not -name "config.h.in" ) + -and -not -name "config.h.in" 2>/dev/null) {proj}_files := $(shell find {src_proj} \ \( \ -name "*.[hc]" \ @@ -186,7 +186,7 @@ -or -name "*.tpl" \ -or -name "*.map" \ \) \ - -and -not -name "config.h") + -and -not -name "config.h" 2>/dev/null) .make.{proj}.clone: @echo -e "\n\n\n===== $@\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7955fedc96484e5703073b63906a03477452db6e Gerrit-Change-Number: 26543 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:53:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 15:53:21 +0000 Subject: Change in osmo-dev[master]: README: update deps and recommended opts In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26542 ) Change subject: README: update deps and recommended opts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7522d8c9346e9823f3977b9190210eb5d5bcfe2d Gerrit-Change-Number: 26542 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 15:53:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 15:53:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 15:53:37 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: fix find errors In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26543 ) Change subject: gen_makefile.py: fix find errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7955fedc96484e5703073b63906a03477452db6e Gerrit-Change-Number: 26543 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 15:53:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:06:18 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 16:06:18 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26504 ) Change subject: BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b1d215818255717ed955c9f1a9c45505ab11a65 Gerrit-Change-Number: 26504 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 16:06:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:06:31 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 16:06:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests.cfg: also execute LCLS test cases In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26505 ) Change subject: BSC_Tests.cfg: also execute LCLS test cases ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I106052d6f89a85171f8c65f1dbfcbeaa4f35f887 Gerrit-Change-Number: 26505 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 16:06:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:08:08 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 16:08:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 ) Change subject: bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 Gerrit-Change-Number: 26535 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 16:08:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:08:21 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 16:08:21 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-{msc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 ) Change subject: msc/osmo-{msc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6414d5622fb287fd147c09e791e1b8023d1596e Gerrit-Change-Number: 26536 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 16:08:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:09:13 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 16:09:13 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-{bsc, bts}.cfg: tune logging configuration In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 ) Change subject: bts/osmo-{bsc,bts}.cfg: tune logging configuration ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 Gerrit-Change-Number: 26523 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 16:09:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:09:35 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 16:09:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 ) Change subject: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08580e5d8313e644908c1d7b370c5de882f3735c Gerrit-Change-Number: 26537 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 16:09:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:10:00 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 13 Dec 2021 16:10:00 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bts.cfg: use default {fn, rts}-advance values In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 ) Change subject: bts/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id97e848e5dfd0b6c504d06f62642511cfd5a0f66 Gerrit-Change-Number: 26530 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 13 Dec 2021 16:10:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:17:45 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 16:17:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26504 ) Change subject: BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 ...................................................................... BSC_Tests_CBSP: use proper default values for mp_cbc_ip / mp_cbc_ip6 Otherwise it's impossible to run the CBSP test cases locally, because the remote peer address in osmo-bsc gets set to '0.0.0.0', so indeed it cannot establish connection to the server. Change-Id: I5b1d215818255717ed955c9f1a9c45505ab11a65 Fixes: OS#5351 --- M bsc/BSC_Tests_CBSP.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests_CBSP.ttcn b/bsc/BSC_Tests_CBSP.ttcn index 6dd5bb7..8119289 100644 --- a/bsc/BSC_Tests_CBSP.ttcn +++ b/bsc/BSC_Tests_CBSP.ttcn @@ -41,8 +41,8 @@ import from TELNETasp_PortType all; modulepar { - charstring mp_cbc_ip := "0.0.0.0"; - charstring mp_cbc_ip6 := "::"; + charstring mp_cbc_ip := "127.0.0.1"; + charstring mp_cbc_ip6 := "::1"; integer mp_cbc_port := 48049; charstring mp_bsc_cbsp_ip := "127.0.0.1"; charstring mp_bsc_cbsp_ip6 := "::1"; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b1d215818255717ed955c9f1a9c45505ab11a65 Gerrit-Change-Number: 26504 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:17:46 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 13 Dec 2021 16:17:46 +0000 Subject: Change in osmo-ttcn3-hacks[master]: BSC_Tests.cfg: also execute LCLS test cases In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26505 ) Change subject: BSC_Tests.cfg: also execute LCLS test cases ...................................................................... BSC_Tests.cfg: also execute LCLS test cases Change-Id: I106052d6f89a85171f8c65f1dbfcbeaa4f35f887 --- M bsc/BSC_Tests.cfg 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.cfg b/bsc/BSC_Tests.cfg index 610e0f7..5765846 100644 --- a/bsc/BSC_Tests.cfg +++ b/bsc/BSC_Tests.cfg @@ -16,6 +16,7 @@ [EXECUTE] BSC_Tests.control +BSC_Tests_LCLS.control BSC_Tests_CBSP.control #BSC_Tests.TC_chan_act_noreply #BSC_Tests.TC_chan_act_ack_noest -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I106052d6f89a85171f8c65f1dbfcbeaa4f35f887 Gerrit-Change-Number: 26505 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:33:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 16:33:12 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 ) Change subject: First implementation of the LLSK gtp SAPI ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c File src/osmo-hnodeb/gtp.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c at 70 PS2, Line 70: req > comment says request, next line says indication. Further comment below again says req. [?] I don't really think it's useful. Each path has a clear 1 specific primitive to rx/tx, so it's easier to write the string directly to be able to find it with grep, or simply when reading code. These names were simply wrong because I forgot to change it when I reworked the code to use proper operations. https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c at 126 PS2, Line 126: } : : osmo_fd_setup(&hnb->gtp.fd0, gsn->fd0, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0); : if ((rc = osmo_fd_register(&hnb->gtp.fd0)) < 0) : goto free_ret; : : osmo_fd_setup(&hnb->gtp.fd1c, gsn->fd1c, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 1); : if ((rc = osmo_fd_register(&hnb->gtp.fd1c)) < 0) : goto free_ret; : : osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 2); : if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0) > The Iuh interface only uses GTP-U v1, neither GTPv0 and no GTPv1-C. [?] After having a quick look at libgtp and TS 29 060 I decided to go for libgtp to avoid having to reimplement the wheel and also in order to avoid to take care or think of stuff like sequence numbers, possible retransmits, gtpu-1 vs 0, encoding/decoding fields, etc. which indeed proved useful into having already a working GTP test in TTCN3. I went initializing the 3 sockets here to speed up the setup and avoid possible failures due to some data structures not being initialized, etc. I plan to give a try now removing the GTPC socket (I was not sure about GTP0 support here btw). I also though about adding a new mode GTP_MODE_GTPU_ONLY (see line 115) to make sure libgtp expects a GTP-U link to be set up too. https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c at 180 PS2, Line 180: LOG > where deos this constraint come from? libgtp? Yes, pdp_t below uses "struct in_addr" in several fields, it seems only IPv4 is supported in the transport GTP link (IP/UDP). -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 13 Dec 2021 16:33:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:53:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 16:53:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add audio SAPI In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 to look at the new patch set (#3). Change subject: hnodeb: Add audio SAPI ...................................................................... hnodeb: Add audio SAPI Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 4 files changed, 385 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/26444/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 Gerrit-Change-Number: 26444 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:53:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 16:53:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add gtp SAPI In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 to look at the new patch set (#3). Change subject: hnodeb: Add gtp SAPI ...................................................................... hnodeb: Add gtp SAPI Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn M hnodeb/gen_links.sh M hnodeb/regen_makefile.sh M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 6 files changed, 353 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/26445/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 Gerrit-Change-Number: 26445 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:55:38 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 13 Dec 2021 16:55:38 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 to look at the new patch set (#8). Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... abis_nm: actively block BTSs with invalid configuration At the moment the BTS configuration is checked, but the check does not have much consequence other than that some initialization that is not executed. The BTS will go into the OML bootstrap phase anyway and most likely fail at some later point due to the invalid configuration. To reduce noise and unexpected behaviour of the BTS lets make sure that the OML boostrap phase can only proceed when the BSC conciders the configuration as valid. Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Related: SYS#5369 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts.c M src/osmo-bsc/osmo_bsc_main.c 4 files changed, 63 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/26197/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:55:38 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 13 Dec 2021 16:55:38 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 8: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/abis_nm.c at 938 PS7, Line 938: if (gsm_bts_check_cfg(bts) != 0) { > why is this still here?! Done https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/bts_ipaccess_nanobts.c File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/bts_ipaccess_nanobts.c at 704 PS7, Line 704: ipaccess_drop_oml(bts, "bad config"); > You may need to use ipaccess_drop_oml_deferred() here. [?] Done https://gerrit.osmocom.org/c/osmo-bsc/+/26197/7/src/osmo-bsc/bts_ipaccess_nanobts.c at 706 PS7, Line 706: ipaccess_drop_rsl(trx, "bad config"); > This is not needed, it's already done by ipaccess_drop_oml(). Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Comment-Date: Mon, 13 Dec 2021 16:55:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 16:57:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 16:57:36 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Comment-Date: Mon, 13 Dec 2021 16:57:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 17:01:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 17:01:59 +0000 Subject: Change in docker-playground[master]: hnodeb: Update Dockerfile, configs with new deps, configs References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26544 ) Change subject: hnodeb: Update Dockerfile, configs with new deps, configs ...................................................................... hnodeb: Update Dockerfile, configs with new deps, configs Pull in libgtp, configure LL socket, etc. Change-Id: I5b223149cbbea16e4ccd9b3874874c6366fe7969 --- M osmo-hnodeb-master/Dockerfile M ttcn3-hnodeb-test/HNB_Tests.cfg M ttcn3-hnodeb-test/jenkins.sh M ttcn3-hnodeb-test/osmo-hnodeb.cfg 4 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/44/26544/1 diff --git a/osmo-hnodeb-master/Dockerfile b/osmo-hnodeb-master/Dockerfile index 1a3ded9..a7ff068 100644 --- a/osmo-hnodeb-master/Dockerfile +++ b/osmo-hnodeb-master/Dockerfile @@ -10,6 +10,7 @@ libosmo-abis-dev \ libosmo-netif-dev \ libosmo-sigtran-dev \ + libgtp-dev \ libasn1c-dev && \ apt-get clean diff --git a/ttcn3-hnodeb-test/HNB_Tests.cfg b/ttcn3-hnodeb-test/HNB_Tests.cfg index 9190e1b..677e12b 100644 --- a/ttcn3-hnodeb-test/HNB_Tests.cfg +++ b/ttcn3-hnodeb-test/HNB_Tests.cfg @@ -12,6 +12,7 @@ [MODULE_PARAMETERS] HNB_Tests.mp_hnodeb_ip := "172.18.33.20"; HNB_Tests.mp_hnbgw_iuh_ip := "172.18.33.203"; +HNB_Tests.mp_hnbllif_sk_path := "/data/unix/ll_sock"; [MAIN_CONTROLLER] diff --git a/ttcn3-hnodeb-test/jenkins.sh b/ttcn3-hnodeb-test/jenkins.sh index 6ffa98a..8e4a983 100755 --- a/ttcn3-hnodeb-test/jenkins.sh +++ b/ttcn3-hnodeb-test/jenkins.sh @@ -10,11 +10,15 @@ set -e mkdir $VOL_BASE_DIR/hnodeb-tester +mkdir $VOL_BASE_DIR/hnodeb-tester/unix cp HNB_Tests.cfg $VOL_BASE_DIR/hnodeb-tester/ mkdir $VOL_BASE_DIR/hnodeb +mkdir $VOL_BASE_DIR/hnodeb/unix cp osmo-hnodeb.cfg $VOL_BASE_DIR/hnodeb/ +mkdir $VOL_BASE_DIR/unix + SUBNET=33 network_create $SUBNET @@ -23,6 +27,7 @@ $(docker_network_params $SUBNET 20) \ --ulimit core=-1 \ -v $VOL_BASE_DIR/hnodeb:/data \ + -v $VOL_BASE_DIR/unix:/data/unix \ --name ${BUILD_TAG}-hnodeb -d \ $DOCKER_ARGS \ $REPO_USER/osmo-hnodeb-$IMAGE_SUFFIX @@ -33,6 +38,7 @@ --ulimit core=-1 \ -e "TTCN3_PCAP_PATH=/data" \ -v $VOL_BASE_DIR/hnodeb-tester:/data \ + -v $VOL_BASE_DIR/unix:/data/unix \ --name ${BUILD_TAG}-ttcn3-hnodeb-test \ $DOCKER_ARGS \ $REPO_USER/ttcn3-hnodeb-test diff --git a/ttcn3-hnodeb-test/osmo-hnodeb.cfg b/ttcn3-hnodeb-test/osmo-hnodeb.cfg index e3925e8..7d24700 100644 --- a/ttcn3-hnodeb-test/osmo-hnodeb.cfg +++ b/ttcn3-hnodeb-test/osmo-hnodeb.cfg @@ -23,3 +23,7 @@ iuh local-ip 172.18.33.20 remote-ip 172.18.33.203 + ll-socket + path /data/unix/ll_sock + gtp + local-ip 172.18.33.20 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5b223149cbbea16e4ccd9b3874874c6366fe7969 Gerrit-Change-Number: 26544 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 17:04:01 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 13 Dec 2021 17:04:01 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 to look at the new patch set (#9). Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... abis_nm: actively block BTSs with invalid configuration At the moment the BTS configuration is checked, but the check does not have much consequence other than that some initialization that is not executed. The BTS will go into the OML bootstrap phase anyway and most likely fail at some later point due to the invalid configuration. To reduce noise and unexpected behaviour of the BTS lets make sure that the OML boostrap phase can only proceed when the BSC conciders the configuration as valid. Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Related: SYS#5369 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts.c M src/osmo-bsc/osmo_bsc_main.c 4 files changed, 63 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/26197/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 17:07:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 17:07:20 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Comment-Date: Mon, 13 Dec 2021 17:07:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 17:18:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 17:18:37 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add gtp SAPI In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 to look at the new patch set (#4). Change subject: hnodeb: Add gtp SAPI ...................................................................... hnodeb: Add gtp SAPI Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn M hnodeb/gen_links.sh M hnodeb/regen_makefile.sh M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 6 files changed, 352 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/26445/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 Gerrit-Change-Number: 26445 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 17:47:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 17:47:37 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 to look at the new patch set (#12). Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Initial implementation of LowerLayer UD Socket The LLSK socket is an interface allowing thid-parties to implement and hook their RLC/MAC/RRC stack to osmo-hnodbe, which takes care of interconnection with the rest of the RAN and core network (Iuh, RTP, GTP-U, etc.). Related: SYS#5516 Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d --- A doc/hnodeb.msc M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 19 files changed, 1,085 insertions(+), 40 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/57/26357/12 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 12 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 17:47:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 17:47:37 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK audio SAPI In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 to look at the new patch set (#3). Change subject: First implementation of the LLSK audio SAPI ...................................................................... First implementation of the LLSK audio SAPI This first version can send and receive regular RTP, but does not talk IuUP. Support for IuUP will be added in a future patch. This way we can already test the whole LLSK<->RTP path. Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d --- M configure.ac M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h A include/osmocom/hnodeb/rtp.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_audio.c M src/osmo-hnodeb/main.c A src/osmo-hnodeb/rtp.c 13 files changed, 732 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/02/26502/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d Gerrit-Change-Number: 26502 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 17:47:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 17:47:37 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 to look at the new patch set (#3). Change subject: First implementation of the LLSK gtp SAPI ...................................................................... First implementation of the LLSK gtp SAPI Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 --- M configure.ac M contrib/jenkins.sh M contrib/osmo-hnodeb.spec.in M debian/control M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/gtp.h M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c A src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_gtp.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/vty.c 18 files changed, 723 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/03/26503/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 17:47:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 17:47:39 +0000 Subject: Change in osmo-hnodeb[master]: WIP: gtp References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26545 ) Change subject: WIP: gtp ...................................................................... WIP: gtp Change-Id: I019e57c693577a1836e1676146ac03bc3edd7e9c --- M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c 3 files changed, 2 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/45/26545/1 diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 37bf7d5..52d1bec 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -115,8 +115,6 @@ char *cfg_local_addr; struct osmo_sockaddr local_addr; struct gsn_t *gsn; - struct osmo_fd fd0; - struct osmo_fd fd1c; struct osmo_fd fd1u; } gtp; diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c index 2368270..4695ea9 100644 --- a/src/osmo-hnodeb/gtp.c +++ b/src/osmo-hnodeb/gtp.c @@ -74,12 +74,6 @@ switch (fd->priv_nr) { case 0: - rc = gtp_decaps0(hnb->gtp.gsn); - break; - case 1: - rc = gtp_decaps1c(hnb->gtp.gsn); - break; - case 2: rc = gtp_decaps1u(hnb->gtp.gsn); break; default: @@ -109,18 +103,10 @@ rc = sk_get_bound_addr(gsn->fd1u, &hnb->gtp.local_addr); if (rc < 0) { LOGP(DGTP, LOGL_ERROR, "Failed to get GTP-U socket bound address: %s\n", strerror(-rc)); - return rc; + goto free_ret; } - osmo_fd_setup(&hnb->gtp.fd0, gsn->fd0, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0); - if ((rc = osmo_fd_register(&hnb->gtp.fd0)) < 0) - goto free_ret; - - osmo_fd_setup(&hnb->gtp.fd1c, gsn->fd1c, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 1); - if ((rc = osmo_fd_register(&hnb->gtp.fd1c)) < 0) - goto free_ret; - - osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 2); + osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0); if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0) goto free_ret; @@ -130,12 +116,7 @@ return 0; free_ret: - osmo_fd_unregister(&hnb->gtp.fd1u); - osmo_fd_unregister(&hnb->gtp.fd1c); - osmo_fd_unregister(&hnb->gtp.fd0); gtp_free(gsn); - hnb->gtp.fd0.fd = -1; - hnb->gtp.fd1c.fd = -1; hnb->gtp.fd1u.fd = -1; return rc; } @@ -143,12 +124,8 @@ void hnb_gtp_unbind(struct hnb *hnb) { osmo_fd_unregister(&hnb->gtp.fd1u); - osmo_fd_unregister(&hnb->gtp.fd1c); - osmo_fd_unregister(&hnb->gtp.fd0); gtp_free(hnb->gtp.gsn); hnb->gtp.gsn = NULL; - hnb->gtp.fd0.fd = -1; - hnb->gtp.fd1c.fd = -1; hnb->gtp.fd1u.fd = -1; } diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 5710ab4..b733d15 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -61,8 +61,6 @@ hnb->rtp.priority = -1; hnb->gtp.cfg_local_addr = talloc_strdup(hnb, "0.0.0.0"); - hnb->gtp.fd0.fd = -1; - hnb->gtp.fd1c.fd = -1; hnb->gtp.fd1u.fd = -1; hnb->shutdown_fi = osmo_fsm_inst_alloc(&hnb_shutdown_fsm, hnb, hnb, -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I019e57c693577a1836e1676146ac03bc3edd7e9c Gerrit-Change-Number: 26545 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 17:47:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 17:47:46 +0000 Subject: Change in osmo-hnodeb[master]: WIP: gtp In-Reply-To: References: Message-ID: pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26545 ) Change subject: WIP: gtp ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I019e57c693577a1836e1676146ac03bc3edd7e9c Gerrit-Change-Number: 26545 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 17:48:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 17:48:04 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 to look at the new patch set (#4). Change subject: First implementation of the LLSK gtp SAPI ...................................................................... First implementation of the LLSK gtp SAPI Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 --- M configure.ac M contrib/jenkins.sh M contrib/osmo-hnodeb.spec.in M debian/control M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/gtp.h M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c A src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_gtp.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/vty.c 18 files changed, 696 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/03/26503/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 18:00:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 18:00:57 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/rua: Add some more templates References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26546 ) Change subject: library/rua: Add some more templates ...................................................................... library/rua: Add some more templates Change-Id: Iab2afbc6ebaa8a41d3e951155609d4c0a2d6866b --- M library/rua/RUA_Templates.ttcn 1 file changed, 161 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/26546/1 diff --git a/library/rua/RUA_Templates.ttcn b/library/rua/RUA_Templates.ttcn index b7387bf..d4e4a0c 100644 --- a/library/rua/RUA_Templates.ttcn +++ b/library/rua/RUA_Templates.ttcn @@ -17,6 +17,166 @@ import from RUA_PDU_Contents all; import from RUA_PDU_Descriptions all; +/********************************************************************************* + * 3GPP TS 25.468 + *********************************************************************************/ -/* TODO: Add RUA Templates here */ +template (value) Cause ts_RUA_Cause(template (value) CauseRadioNetwork c) := { + radioNetwork := c } + +/* 9.1.3 CONNECT */ +template (present) RUA_PDU +tr_RUA_Connect(template (present) CN_DomainIndicator domain := ?, + template (present) bitstring context_id := ?, + template (present) Establishment_Cause est_cause := ?, + template (present) octetstring ranap_msg := ?) := { + initiatingMessage := { + procedureCode := id_Connect, + criticality := reject, + value_ := { + connect_ := { + protocolIEs := { + { + id := 7, + criticality := reject, + value_ := { cN_DomainIndicator := domain } + }, { + id := 3, + criticality := reject, + value_ := { context_ID := context_id } + }, { + id := 6, + criticality := reject, + value_ := { establishment_Cause := est_cause } + }, { + id := 4, + criticality := reject, + value_ := { + rANAP_Message := ranap_msg + } + } + }, + protocolExtensions := omit + } + } + } +} + +/* 9.1.4 DIRECT TRANSFER */ +template (value) RUA_PDU +ts_RUA_DirectTransfer(template (value) CN_DomainIndicator domain, + template (value) bitstring context_id, + template (value) octetstring ranap_msg) := { + initiatingMessage := { + procedureCode := id_DirectTransfer, + criticality := reject, + value_ := { + directTransfer := { + protocolIEs := { + { + id := 7, + criticality := reject, + value_ := { cN_DomainIndicator := domain } + }, { + id := 3, + criticality := reject, + value_ := { context_ID := context_id } + }, { + id := 4, + criticality := reject, + value_ := { rANAP_Message := ranap_msg } + } + }, + protocolExtensions := omit + } + } + } +} +template (present) RUA_PDU +tr_RUA_DirectTransfer(template (present) CN_DomainIndicator domain := ?, + template (present) bitstring context_id := ?, + template (present) octetstring ranap_msg := ?) := { + initiatingMessage := { + procedureCode := id_DirectTransfer, + criticality := reject, + value_ := { + directTransfer := { + protocolIEs := { + { + id := 7, + criticality := reject, + value_ := { cN_DomainIndicator := domain } + }, { + id := 3, + criticality := reject, + value_ := { context_ID := context_id } + }, { + id := 4, + criticality := reject, + value_ := { rANAP_Message := ranap_msg } + } + }, + protocolExtensions := omit + } + } + } +} + +/* 9.1.5 DISCONNECT */ +template (present) RUA_PDU +tr_RUA_Disconnect(template (present) CN_DomainIndicator domain := ?, + template (present) bitstring context_id := ?, + template (present) Cause cause := ?, + template (present) octetstring ranap_msg := ?) := { + initiatingMessage := { + procedureCode := 3, + criticality := reject, + value_ := { + disconnect_ := { + protocolIEs := { + { + id := 7, + criticality := reject, + value_ := { cN_DomainIndicator := domain } + }, { + id := 3, + criticality := reject, + value_ := { context_ID := context_id } + }, { + id := 1, + criticality := reject, + value_ := { cause := cause } + }, { + id := 4, + criticality := reject, + value_ := { rANAP_Message := ranap_msg } + } + }, + protocolExtensions := omit + } + } + } +} + +/* 9.1.6 CONNECTIONLESS TRANSFER */ +template (value) RUA_PDU +ts_RUA_ConnectionlessTransfer(template (value) octetstring ranap_msg) := { + initiatingMessage := { + procedureCode := id_ConnectionlessTransfer, + criticality := reject, + value_ := { + connectionlessTransfer := { + protocolIEs := { + { + id := 4, + criticality := reject, + value_ := { rANAP_Message := ranap_msg } + } + }, + protocolExtensions := omit + } + } + } +} +}; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab2afbc6ebaa8a41d3e951155609d4c0a2d6866b Gerrit-Change-Number: 26546 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 18:02:15 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 13 Dec 2021 18:02:15 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/rua: Add some more templates In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26546 ) Change subject: library/rua: Add some more templates ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab2afbc6ebaa8a41d3e951155609d4c0a2d6866b Gerrit-Change-Number: 26546 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Mon, 13 Dec 2021 18:02:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 18:03:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 18:03:03 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/rua: Add some more templates In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26546 ) Change subject: library/rua: Add some more templates ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab2afbc6ebaa8a41d3e951155609d4c0a2d6866b Gerrit-Change-Number: 26546 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 13 Dec 2021 18:03:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 18:03:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 18:03:26 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 ) Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 8 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 13 Dec 2021 18:03:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 18:04:49 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 18:04:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/rua: Add some more templates In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26546 ) Change subject: library/rua: Add some more templates ...................................................................... library/rua: Add some more templates Change-Id: Iab2afbc6ebaa8a41d3e951155609d4c0a2d6866b --- M library/rua/RUA_Templates.ttcn 1 file changed, 161 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/rua/RUA_Templates.ttcn b/library/rua/RUA_Templates.ttcn index b7387bf..d4e4a0c 100644 --- a/library/rua/RUA_Templates.ttcn +++ b/library/rua/RUA_Templates.ttcn @@ -17,6 +17,166 @@ import from RUA_PDU_Contents all; import from RUA_PDU_Descriptions all; +/********************************************************************************* + * 3GPP TS 25.468 + *********************************************************************************/ -/* TODO: Add RUA Templates here */ +template (value) Cause ts_RUA_Cause(template (value) CauseRadioNetwork c) := { + radioNetwork := c } + +/* 9.1.3 CONNECT */ +template (present) RUA_PDU +tr_RUA_Connect(template (present) CN_DomainIndicator domain := ?, + template (present) bitstring context_id := ?, + template (present) Establishment_Cause est_cause := ?, + template (present) octetstring ranap_msg := ?) := { + initiatingMessage := { + procedureCode := id_Connect, + criticality := reject, + value_ := { + connect_ := { + protocolIEs := { + { + id := 7, + criticality := reject, + value_ := { cN_DomainIndicator := domain } + }, { + id := 3, + criticality := reject, + value_ := { context_ID := context_id } + }, { + id := 6, + criticality := reject, + value_ := { establishment_Cause := est_cause } + }, { + id := 4, + criticality := reject, + value_ := { + rANAP_Message := ranap_msg + } + } + }, + protocolExtensions := omit + } + } + } +} + +/* 9.1.4 DIRECT TRANSFER */ +template (value) RUA_PDU +ts_RUA_DirectTransfer(template (value) CN_DomainIndicator domain, + template (value) bitstring context_id, + template (value) octetstring ranap_msg) := { + initiatingMessage := { + procedureCode := id_DirectTransfer, + criticality := reject, + value_ := { + directTransfer := { + protocolIEs := { + { + id := 7, + criticality := reject, + value_ := { cN_DomainIndicator := domain } + }, { + id := 3, + criticality := reject, + value_ := { context_ID := context_id } + }, { + id := 4, + criticality := reject, + value_ := { rANAP_Message := ranap_msg } + } + }, + protocolExtensions := omit + } + } + } +} +template (present) RUA_PDU +tr_RUA_DirectTransfer(template (present) CN_DomainIndicator domain := ?, + template (present) bitstring context_id := ?, + template (present) octetstring ranap_msg := ?) := { + initiatingMessage := { + procedureCode := id_DirectTransfer, + criticality := reject, + value_ := { + directTransfer := { + protocolIEs := { + { + id := 7, + criticality := reject, + value_ := { cN_DomainIndicator := domain } + }, { + id := 3, + criticality := reject, + value_ := { context_ID := context_id } + }, { + id := 4, + criticality := reject, + value_ := { rANAP_Message := ranap_msg } + } + }, + protocolExtensions := omit + } + } + } +} + +/* 9.1.5 DISCONNECT */ +template (present) RUA_PDU +tr_RUA_Disconnect(template (present) CN_DomainIndicator domain := ?, + template (present) bitstring context_id := ?, + template (present) Cause cause := ?, + template (present) octetstring ranap_msg := ?) := { + initiatingMessage := { + procedureCode := 3, + criticality := reject, + value_ := { + disconnect_ := { + protocolIEs := { + { + id := 7, + criticality := reject, + value_ := { cN_DomainIndicator := domain } + }, { + id := 3, + criticality := reject, + value_ := { context_ID := context_id } + }, { + id := 1, + criticality := reject, + value_ := { cause := cause } + }, { + id := 4, + criticality := reject, + value_ := { rANAP_Message := ranap_msg } + } + }, + protocolExtensions := omit + } + } + } +} + +/* 9.1.6 CONNECTIONLESS TRANSFER */ +template (value) RUA_PDU +ts_RUA_ConnectionlessTransfer(template (value) octetstring ranap_msg) := { + initiatingMessage := { + procedureCode := id_ConnectionlessTransfer, + criticality := reject, + value_ := { + connectionlessTransfer := { + protocolIEs := { + { + id := 4, + criticality := reject, + value_ := { rANAP_Message := ranap_msg } + } + }, + protocolExtensions := omit + } + } + } +} +}; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab2afbc6ebaa8a41d3e951155609d4c0a2d6866b Gerrit-Change-Number: 26546 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 18:05:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 18:05:45 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 ) Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Patch Set 12: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c File src/osmo-hnodeb/llsk.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c at 108 PS11, Line 108: HNB_PRIM_SAPI_IUH > Yes, it's the Iuh Signaling, with optional RANAP payload to forward my point was that this should be reflected in the name of the constant. "IUH" is very generic, and in fact you only mean a subset of IUH here. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 12 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 13 Dec 2021 18:05:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 18:09:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 18:09:32 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK audio SAPI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 ) Change subject: First implementation of the LLSK audio SAPI ...................................................................... Patch Set 3: Code-Review+1 (3 comments) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h File include/osmocom/hnodeb/hnb_prim.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h at 173 PS2, Line 173: HNB_AUDIO_PRIM_CONN_ESTABLISH, : HNB_AUDIO_PRIM_CONN_RELEASE, : HNB_AUDIO_PRIM_CONN_DATA, : _HNB_AUDIO_PRIM_MAX > I'm using CONN_DATA for payload forwarding which relates to an active connection or context, which w [?] ah, interesting. Agreed. https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h at 184 PS2, Line 184: uint8_t remote_rtp_address_type; /* enum u_addr_type */ : union u_addr remote_rtp_addr; > I preferred having an own format specified in the protocol, similar to what we have in PCUIF, rather [?] ok, fair enough - but then I would try to at least have one definition local to this header file, rather than repeating the same two members together in multiple *_param definitions. The address type makes no sense without the address, and vice-versa. They only appear together -> struct. https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h at 217 PS2, Line 217: struct osmo_prim_hdr hdr; > Not sure if it's really worth it, since anyway we can find the UE from the context_id, and then use [?] ok, then let's do that. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d Gerrit-Change-Number: 26502 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 13 Dec 2021 18:09:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 18:11:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 18:11:47 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 ) Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Patch Set 12: (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c File src/osmo-hnodeb/llsk.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357/11/src/osmo-hnodeb/llsk.c at 108 PS11, Line 108: HNB_PRIM_SAPI_IUH > my point was that this should be reflected in the name of the constant. [?] I just picked something which was short to have something similar to GTP, AUDIO, etc. TBH I'm fine with this naming (I agree though that it's a bit generic), since it's basically "all Iuh which is not specific to Audio or user plana PS data for GTP." If you are not happy with current one, please provide the naming you'd like and I'll proceed to bulk change it in all places I find. Not sure if it's really worth it though. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 12 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 13 Dec 2021 18:11:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 18:12:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 18:12:37 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 ) Change subject: First implementation of the LLSK gtp SAPI ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c File src/osmo-hnodeb/gtp.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c at 126 PS2, Line 126: } : : osmo_fd_setup(&hnb->gtp.fd0, gsn->fd0, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0); : if ((rc = osmo_fd_register(&hnb->gtp.fd0)) < 0) : goto free_ret; : : osmo_fd_setup(&hnb->gtp.fd1c, gsn->fd1c, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 1); : if ((rc = osmo_fd_register(&hnb->gtp.fd1c)) < 0) : goto free_ret; : : osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 2); : if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0) > After having a quick look at libgtp and TS 29 060 I decided to go for libgtp to avoid having to reim [?] * there are no sequence numbers in GTP-U * there are no retransmits in GTP-U * there is no GTPv0 in GTP-U on Iu or Iuh, or in fact anything that is 3G,4G or 5G. So I don't really see what libgtp possibly can give you that you'd need. It really is pushing one fixed-length header on the uplink side, and stripping it on the downlink side (after looking up the UE based on the TEID). Please correct me if I'm wrong. It happens :) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c at 180 PS2, Line 180: LOG > Yes, pdp_t below uses "struct in_addr" in several fields, it seems only IPv4 is supported in the tra [?] one [small] more reason to not use libgtp. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 13 Dec 2021 18:12:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 18:13:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 18:13:07 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-Comment-Date: Mon, 13 Dec 2021 18:13:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 18:13:10 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 13 Dec 2021 18:13:10 +0000 Subject: Change in osmo-bsc[master]: abis_nm: actively block BTSs with invalid configuration In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26197 ) Change subject: abis_nm: actively block BTSs with invalid configuration ...................................................................... abis_nm: actively block BTSs with invalid configuration At the moment the BTS configuration is checked, but the check does not have much consequence other than that some initialization that is not executed. The BTS will go into the OML bootstrap phase anyway and most likely fail at some later point due to the invalid configuration. To reduce noise and unexpected behaviour of the BTS lets make sure that the OML boostrap phase can only proceed when the BSC conciders the configuration as valid. Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Related: SYS#5369 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts.c M src/osmo-bsc/osmo_bsc_main.c 4 files changed, 63 insertions(+), 53 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 922753c..c4ee39d 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -717,6 +717,7 @@ } struct gsm_bts *gsm_bts_alloc(struct gsm_network *net, struct gsm_bts_sm *bts_sm, uint8_t bts_num); +int gsm_bts_check_cfg(struct gsm_bts *bts); char *gsm_bts_name(const struct gsm_bts *bts); diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 11b1ec3..c4ae518 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -421,6 +421,57 @@ return bts; } +/* Validate BTS configuration (ARFCN settings and physical channel configuration) */ +int gsm_bts_check_cfg(struct gsm_bts *bts) +{ + struct gsm_bts_trx *trx; + + if (!bts->model) + return -EFAULT; + + switch (bts->band) { + case GSM_BAND_1800: + if (bts->c0->arfcn < 512 || bts->c0->arfcn > 885) { + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1800 channel (%u) must be between 512-885.\n", + bts->nr, bts->c0->arfcn); + return -EINVAL; + } + break; + case GSM_BAND_1900: + if (bts->c0->arfcn < 512 || bts->c0->arfcn > 810) { + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1900 channel (%u) must be between 512-810.\n", + bts->nr, bts->c0->arfcn); + } + break; + case GSM_BAND_900: + if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || + bts->c0->arfcn > 1023) { + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n", + bts->nr, bts->c0->arfcn); + } + break; + case GSM_BAND_850: + if (bts->c0->arfcn < 128 || bts->c0->arfcn > 251) { + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM850 channel (%u) must be between 128-251.\n", + bts->nr, bts->c0->arfcn); + } + break; + default: + LOGP(DNM, LOGL_ERROR, "(bts=%u) Unsupported frequency band.\n", bts->nr); + } + + /* Verify the physical channel mapping */ + llist_for_each_entry(trx, &bts->trx_list, list) { + if (!trx_has_valid_pchan_config(trx)) { + LOGP(DNM, LOGL_ERROR, "TRX %u has invalid timeslot " + "configuration\n", trx->nr); + return -EINVAL; + } + } + + return 0; +} + static char ts2str[255]; char *gsm_bts_name(const struct gsm_bts *bts) diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c index 9607068..1df6537 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts.c @@ -696,6 +696,14 @@ DEBUGP(DLINP, "%s: Identified BTS %u/%u/%u\n", e1inp_signtype_name(type), dev->site_id, dev->bts_id, dev->trx_id); + /* Check if this BTS has a valid configuration. If not we will drop it + * immediately. */ + if (gsm_bts_check_cfg(bts) != 0) { + LOGP(DLINP, LOGL_NOTICE, "(bts=%u) BTS config invalid, dropping BTS!\n", bts->nr); + ipaccess_drop_oml_deferred(bts); + return NULL; + } + switch(type) { case E1INP_SIGN_OML: /* remove old OML signal link for this BTS. */ diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 2436641..b7e2616 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -389,56 +389,6 @@ osmo_timer_schedule(&update_connection_stats_timer, 1, 0); } -static int check_bts(struct gsm_bts *bts) -{ - struct gsm_bts_trx *trx; - - if (!bts->model) - return -EFAULT; - - switch (bts->band) { - case GSM_BAND_1800: - if (bts->c0->arfcn < 512 || bts->c0->arfcn > 885) { - LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1800 channel (%u) must be between 512-885.\n", - bts->nr, bts->c0->arfcn); - return -EINVAL; - } - break; - case GSM_BAND_1900: - if (bts->c0->arfcn < 512 || bts->c0->arfcn > 810) { - LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1900 channel (%u) must be between 512-810.\n", - bts->nr, bts->c0->arfcn); - } - break; - case GSM_BAND_900: - if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || - bts->c0->arfcn > 1023) { - LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n", - bts->nr, bts->c0->arfcn); - } - break; - case GSM_BAND_850: - if (bts->c0->arfcn < 128 || bts->c0->arfcn > 251) { - LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM850 channel (%u) must be between 128-251.\n", - bts->nr, bts->c0->arfcn); - } - break; - default: - LOGP(DNM, LOGL_ERROR, "(bts=%u) Unsupported frequency band.\n", bts->nr); - } - - /* Verify the physical channel mapping */ - llist_for_each_entry(trx, &bts->trx_list, list) { - if (!trx_has_valid_pchan_config(trx)) { - LOGP(DNM, LOGL_ERROR, "TRX %u has invalid timeslot " - "configuration\n", trx->nr); - return -EINVAL; - } - } - - return 0; -} - static void bootstrap_bts(struct gsm_bts *bts) { unsigned int n = 0; @@ -492,7 +442,7 @@ case S_L_INP_TEI_UP: if (isd->link_type == E1INP_SIGN_OML) { /* Check parameters and apply vty config dependent parameters */ - rc = check_bts(trx->bts); + rc = gsm_bts_check_cfg(trx->bts); if (rc < 0) { LOGP(DNM, LOGL_ERROR, "(bts=%u) Error in BTS configuration -- cannot bootstrap BTS\n", trx->bts->nr); @@ -501,7 +451,7 @@ bootstrap_bts(trx->bts); } if (isd->link_type == E1INP_SIGN_RSL) { - rc = check_bts(trx->bts); + rc = gsm_bts_check_cfg(trx->bts); if (rc < 0) { LOGP(DNM, LOGL_ERROR, "(bts=%u) Error in BTS configuration -- cannot bootstrap RSL\n", trx->bts->nr); @@ -556,7 +506,7 @@ osmo_signal_register_handler(SS_L_INPUT, inp_sig_cb, NULL); llist_for_each_entry(bts, &bsc_gsmnet->bts_list, list) { - rc = check_bts(bts); + rc = gsm_bts_check_cfg(bts); if (rc < 0) { LOGP(DNM, LOGL_FATAL, "(bts=%u) cannot bootstrap BTS, invalid BTS configuration\n", bts->nr); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I42c1c26a9b800600787b1266a871f95f2114c26e Gerrit-Change-Number: 26197 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 13 18:22:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 13 Dec 2021 18:22:48 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 ) Change subject: First implementation of the LLSK gtp SAPI ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c File src/osmo-hnodeb/gtp.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c at 126 PS2, Line 126: } : : osmo_fd_setup(&hnb->gtp.fd0, gsn->fd0, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0); : if ((rc = osmo_fd_register(&hnb->gtp.fd0)) < 0) : goto free_ret; : : osmo_fd_setup(&hnb->gtp.fd1c, gsn->fd1c, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 1); : if ((rc = osmo_fd_register(&hnb->gtp.fd1c)) < 0) : goto free_ret; : : osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 2); : if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0) > * there are no sequence numbers in GTP-U [?] ACK about those. It's also about managing the socket, the different tunnels/pdps, TEID generation, etc. If you don't want to have libgtp there I am fine and I can drop it and rewrite it, but using something which already took care of that seemed like a good way to have something working in first place, since I already had to take care of different interfaces, etc. and I wanted to have a first version working soon so that integration can be started. https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c at 180 PS2, Line 180: LOG > one [small] more reason to not use libgtp. We could fix libgtp to support IPv6 IP/UDP transport here. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 13 Dec 2021 18:22:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 00:31:55 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 14 Dec 2021 00:31:55 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26524 ) Change subject: bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' ...................................................................... bts/osmo-bsc.cfg: fix deprecated BTS type 'sysmobts' Change-Id: If2f81141707e6f2360fc57bbd5f76606294f8db8 --- M bsc/osmo-bsc-vamos.cfg M bts/osmo-bsc.cfg 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/bsc/osmo-bsc-vamos.cfg b/bsc/osmo-bsc-vamos.cfg index 5842a48..07fb698 100644 --- a/bsc/osmo-bsc-vamos.cfg +++ b/bsc/osmo-bsc-vamos.cfg @@ -82,7 +82,7 @@ timer t3113 10 timer t3212 30 bts 0 - type sysmobts + type osmo-bts band DCS1800 cell_identity 0 location_area_code 1 @@ -172,7 +172,7 @@ phys_chan_config PDCH hopping enabled 0 bts 1 - type sysmobts + type osmo-bts band DCS1800 cell_identity 1 location_area_code 1 @@ -262,7 +262,7 @@ phys_chan_config PDCH hopping enabled 0 bts 2 - type sysmobts + type osmo-bts band DCS1800 cell_identity 1 location_area_code 2 @@ -352,7 +352,7 @@ phys_chan_config PDCH hopping enabled 0 bts 3 - type sysmobts + type osmo-bts band DCS1800 cell_identity 3 location_area_code 3 diff --git a/bts/osmo-bsc.cfg b/bts/osmo-bsc.cfg index 1c8da8d..e4161fa 100644 --- a/bts/osmo-bsc.cfg +++ b/bts/osmo-bsc.cfg @@ -55,7 +55,7 @@ handover1 maximum distance 9999 timer t3212 30 bts 0 - type sysmobts + type osmo-bts band DCS1800 cell_identity 0 location_area_code 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2f81141707e6f2360fc57bbd5f76606294f8db8 Gerrit-Change-Number: 26524 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 00:31:55 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 14 Dec 2021 00:31:55 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-bts.cfg: use default {fn, rts}-advance values In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 ) Change subject: bts/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... bts/osmo-bts.cfg: use default {fn,rts}-advance values It's better if we run ttcn3-bts-test with the default values, given that they were significantly reduced some time ago. Change-Id: Id97e848e5dfd0b6c504d06f62642511cfd5a0f66 Related: I7da3d0948f38e12342fb714b29f8edc5e9d0933d (osmo-bts) Related: OS#4487 --- M bts/osmo-bts.cfg 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/bts/osmo-bts.cfg b/bts/osmo-bts.cfg index 1c83db7..4629180 100644 --- a/bts/osmo-bts.cfg +++ b/bts/osmo-bts.cfg @@ -34,8 +34,6 @@ phy 0 osmotrx ip local 127.0.0.1 osmotrx ip remote 127.0.0.1 - osmotrx fn-advance 20 - osmotrx rts-advance 5 instance 0 osmotrx rx-gain 10 instance 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id97e848e5dfd0b6c504d06f62642511cfd5a0f66 Gerrit-Change-Number: 26530 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 00:37:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 14 Dec 2021 00:37:47 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 to look at the new patch set (#2). Change subject: bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging ...................................................................... bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 --- M bsc/osmo-bsc.cfg M bsc/osmo-stp.cfg 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/26535/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 Gerrit-Change-Number: 26535 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 00:37:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 14 Dec 2021 00:37:47 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-{msc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 to look at the new patch set (#2). Change subject: msc/osmo-{msc,stp}.cfg: enable extended timestamp in logging ...................................................................... msc/osmo-{msc,stp}.cfg: enable extended timestamp in logging Change-Id: Ia6414d5622fb287fd147c09e791e1b8023d1596e --- M msc/osmo-msc.cfg M msc/osmo-stp.cfg 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/26536/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6414d5622fb287fd147c09e791e1b8023d1596e Gerrit-Change-Number: 26536 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 00:37:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 14 Dec 2021 00:37:47 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-{bsc, bts}.cfg: tune logging configuration In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 to look at the new patch set (#3). Change subject: bts/osmo-{bsc,bts}.cfg: tune logging configuration ...................................................................... bts/osmo-{bsc,bts}.cfg: tune logging configuration Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 --- M bts/osmo-bsc.cfg M bts/osmo-bts.cfg 2 files changed, 14 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/26523/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 Gerrit-Change-Number: 26523 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 00:37:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 14 Dec 2021 00:37:47 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 to look at the new patch set (#2). Change subject: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg ...................................................................... bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg Change-Id: I08580e5d8313e644908c1d7b370c5de882f3735c --- M bsc/osmo-bsc-vamos.cfg 1 file changed, 8 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/26537/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08580e5d8313e644908c1d7b370c5de882f3735c Gerrit-Change-Number: 26537 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 03:00:37 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 14 Dec 2021 03:00:37 +0000 Subject: Change in osmo-dev[master]: README: update deps and recommended opts In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26542 ) Change subject: README: update deps and recommended opts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7522d8c9346e9823f3977b9190210eb5d5bcfe2d Gerrit-Change-Number: 26542 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 03:00:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 03:00:54 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 14 Dec 2021 03:00:54 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: fix find errors In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26543 ) Change subject: gen_makefile.py: fix find errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7955fedc96484e5703073b63906a03477452db6e Gerrit-Change-Number: 26543 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 03:00:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:17:42 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:17:42 +0000 Subject: Change in osmo-dev[master]: README: update deps and recommended opts In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26542 ) Change subject: README: update deps and recommended opts ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7522d8c9346e9823f3977b9190210eb5d5bcfe2d Gerrit-Change-Number: 26542 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 08:17:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:17:48 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:17:48 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: fix find errors In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26543 ) Change subject: gen_makefile.py: fix find errors ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7955fedc96484e5703073b63906a03477452db6e Gerrit-Change-Number: 26543 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 08:17:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:17:50 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:17:50 +0000 Subject: Change in osmo-dev[master]: README: update deps and recommended opts In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26542 ) Change subject: README: update deps and recommended opts ...................................................................... README: update deps and recommended opts In preparation for the OsmoDevCall#19 talk, I'm installing this on a fresh system and made some adjustments to README so it works without complaining about missing dependencies. Related: https://osmocom.org/news/155 Change-Id: I7522d8c9346e9823f3977b9190210eb5d5bcfe2d --- M README 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/README b/README index ac77424..7f1b594 100644 --- a/README +++ b/README @@ -13,9 +13,9 @@ build-essential gcc g++ make automake autoconf libtool pkg-config \ libtalloc-dev libpcsclite-dev libortp-dev libsctp-dev libssl-dev libdbi-dev \ libdbd-sqlite3 libsqlite3-dev libpcap-dev libc-ares-dev libgnutls28-dev \ - libsctp-dev sqlite3 + libsctp-dev sqlite3 libusb-1.0-0-dev libmnl-dev libsofia-sip-ua-glib-dev -./gen_makefile.py default.opts iu.opts -I -m make +./gen_makefile.py default.opts iu.opts no_dahdi.opts -I -m make cd make make -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26542 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7522d8c9346e9823f3977b9190210eb5d5bcfe2d Gerrit-Change-Number: 26542 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:17:50 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:17:50 +0000 Subject: Change in osmo-dev[master]: gen_makefile.py: fix find errors In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26543 ) Change subject: gen_makefile.py: fix find errors ...................................................................... gen_makefile.py: fix find errors Don't print find errors if not all dirs were cloned. Found this also while running osmo-dev on a fresh install. Change-Id: I7955fedc96484e5703073b63906a03477452db6e --- M gen_makefile.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/gen_makefile.py b/gen_makefile.py index 7c780a5..9eb2d94 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -177,7 +177,7 @@ -name "Makefile.am" \ -or -name "*.in" \ -and -not -name "Makefile.in" \ - -and -not -name "config.h.in" ) + -and -not -name "config.h.in" 2>/dev/null) {proj}_files := $(shell find {src_proj} \ \( \ -name "*.[hc]" \ @@ -186,7 +186,7 @@ -or -name "*.tpl" \ -or -name "*.map" \ \) \ - -and -not -name "config.h") + -and -not -name "config.h" 2>/dev/null) .make.{proj}.clone: @echo -e "\n\n\n===== $@\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7955fedc96484e5703073b63906a03477452db6e Gerrit-Change-Number: 26543 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:18:23 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:18:23 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 ) Change subject: bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 Gerrit-Change-Number: 26535 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 08:18:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:18:35 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:18:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-{msc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 ) Change subject: msc/osmo-{msc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6414d5622fb287fd147c09e791e1b8023d1596e Gerrit-Change-Number: 26536 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 08:18:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:19:14 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:19:14 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-{bsc, bts}.cfg: tune logging configuration In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 ) Change subject: bts/osmo-{bsc,bts}.cfg: tune logging configuration ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 Gerrit-Change-Number: 26523 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 08:19:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:19:31 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:19:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 ) Change subject: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08580e5d8313e644908c1d7b370c5de882f3735c Gerrit-Change-Number: 26537 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 08:19:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:21:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:21:59 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test/osmo-bts.cfg: use default {fn, rts}-advance values In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26529 ) Change subject: ttcn3-bts-test/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If8438adfdbc506d2b6b7858ea8a0ea859ba246a1 Gerrit-Change-Number: 26529 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 08:21:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:34:41 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:34:41 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add audio SAPI In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 ) Change subject: hnodeb: Add audio SAPI ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444/4/hnodeb/HNBGW_ConnectionHandler.ttcn File hnodeb/HNBGW_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444/4/hnodeb/HNBGW_ConnectionHandler.ttcn at 232 PS4, Line 232: Step 4 No Step 3? ;) Why count steps at all? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 Gerrit-Change-Number: 26444 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 14 Dec 2021 08:34:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:36:53 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:36:53 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add gtp SAPI In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 ) Change subject: hnodeb: Add gtp SAPI ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 Gerrit-Change-Number: 26445 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 14 Dec 2021 08:36:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:50:17 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 14 Dec 2021 08:50:17 +0000 Subject: Change in osmo-ci[master]: jobs/ttcn3-testsuites: adjust cmd for centos7 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26540 ) Change subject: jobs/ttcn3-testsuites: adjust cmd for centos7 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaf6162682074f5f9de70d420e91a72f283e695bc Gerrit-Change-Number: 26540 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 08:50:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:50:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 14 Dec 2021 08:50:39 +0000 Subject: Change in osmo-ci[master]: jobs/registry-update-base-images: add centos7 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26541 ) Change subject: jobs/registry-update-base-images: add centos7 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I64ce913b79dad063fd34848be538b088d6b3402d Gerrit-Change-Number: 26541 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 08:50:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:51:53 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 14 Dec 2021 08:51:53 +0000 Subject: Change in osmo-ci[master]: osmocom-release-tarballs: fix missing st2 clone In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26539 ) Change subject: osmocom-release-tarballs: fix missing st2 clone ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0a845549ba1fe9f0d9ab55a5c5c7bf5b8f57caae Gerrit-Change-Number: 26539 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 08:51:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:52:56 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:52:56 +0000 Subject: Change in osmo-ci[master]: jobs/ttcn3-testsuites: adjust cmd for centos7 In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26540 ) Change subject: jobs/ttcn3-testsuites: adjust cmd for centos7 ...................................................................... jobs/ttcn3-testsuites: adjust cmd for centos7 Related: SYS#5754 Change-Id: Iaf6162682074f5f9de70d420e91a72f283e695bc --- M jobs/ttcn3-testsuites.yml 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 854a5fb..3074d40 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -401,6 +401,10 @@ DIR="$(echo "{job-name}" | sed s/^TTCN3-centos\-/ttcn3-/ | sed s/\-latest$//)" export IMAGE_SUFFIX="latest-centos8" ;; + TTCN3-centos7-*-latest) + DIR="$(echo "{job-name}" | sed s/^TTCN3-centos7\-/ttcn3-/ | sed s/\-latest$//)" + export IMAGE_SUFFIX="latest-centos7" + ;; TTCN3-centos-*-20*q*) export OSMOCOM_REPO_TESTSUITE_MIRROR="http://download.opensuse.org" export OSMOCOM_REPO_MIRROR="https://downloads.osmocom.org" @@ -413,6 +417,10 @@ DIR="$(echo "{job-name}" | sed s/^TTCN3-centos\-/ttcn3-/)" export IMAGE_SUFFIX="master-centos8" ;; + TTCN3-centos7-*) + DIR="$(echo "{job-name}" | sed s/^TTCN3-centos7\-/ttcn3-/)" + export IMAGE_SUFFIX="master-centos7" + ;; *-latest) DIR="$(echo "{job-name}" | sed s/\-latest$//)" export IMAGE_SUFFIX="latest" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaf6162682074f5f9de70d420e91a72f283e695bc Gerrit-Change-Number: 26540 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:52:56 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:52:56 +0000 Subject: Change in osmo-ci[master]: jobs/registry-update-base-images: add centos7 In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26541 ) Change subject: jobs/registry-update-base-images: add centos7 ...................................................................... jobs/registry-update-base-images: add centos7 Related: SYS#5754 Change-Id: I64ce913b79dad063fd34848be538b088d6b3402d --- M jobs/registry-update-base-images.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/jobs/registry-update-base-images.yml b/jobs/registry-update-base-images.yml index 48e8b59..2dd6e69 100644 --- a/jobs/registry-update-base-images.yml +++ b/jobs/registry-update-base-images.yml @@ -16,7 +16,7 @@ builders: - shell: | REGISTRY="registry.osmocom.org" - IMAGES="debian:stretch debian:buster debian:jessie debian:sid ubuntu:zesty centos:centos8" + IMAGES="debian:stretch debian:buster debian:jessie debian:sid ubuntu:zesty centos:centos7 centos:centos8" for i in $IMAGES; do src=$i dst=${REGISTRY}/$i -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I64ce913b79dad063fd34848be538b088d6b3402d Gerrit-Change-Number: 26541 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 08:53:18 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 08:53:18 +0000 Subject: Change in osmo-ci[master]: osmocom-release-tarballs: fix missing st2 clone In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26539 ) Change subject: osmocom-release-tarballs: fix missing st2 clone ...................................................................... osmocom-release-tarballs: fix missing st2 clone Clone simtrace2.git before trying to create the tarball with git. Fix for: simtrace2 simtrace2-0.1.tar.bz2 (creating) + cd /osmo-ci/_temp/repos/simtrace2 /osmo-ci/scripts/osmocom-release-tarballs.sh: 195: cd: can't cd to /osmo-ci/_temp/repos/simtrace2 Related: OS#5347 Fixes: 0221a0 ("OSMO_RELEASE_REPOS: add simtrace2, osmo-remsim") Change-Id: I0a845549ba1fe9f0d9ab55a5c5c7bf5b8f57caae --- M scripts/osmocom-release-tarballs.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/osmocom-release-tarballs.sh b/scripts/osmocom-release-tarballs.sh index 8242a49..3ac4545 100755 --- a/scripts/osmocom-release-tarballs.sh +++ b/scripts/osmocom-release-tarballs.sh @@ -238,6 +238,8 @@ if tag_has_file "$repo" "$tag" host/configure.ac; then create_tarball "$repo/host" "$tag" move_tarball "$repo/host" "$tag" + else + prepare_repo "$repo" fi create_tarball_git "$repo" "$tag" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0a845549ba1fe9f0d9ab55a5c5c7bf5b8f57caae Gerrit-Change-Number: 26539 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 10:48:07 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 10:48:07 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: osmith has uploaded a new patch set (#4) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... firmware: add crc stub to all dfu apps to ensure reliable loading DFU flashing of apps sometimes aborts, and although rare this leads to broken devices if no boot button or serial/jtag access exists, because the bootloader will keep trying to start a half-flashed app that then crashes at some point. The easiest fix that works with existing bootloaders is to prepend a small 512 byte stub that calculcates the crc and compares it with the crc calculated at build time, and then either starts the actual app, or sets the dfu flag and resets. This ensures we either have a working, running app, or end up in the bootloader, ready to flash again. For obvious reasons this only applies to dfu apps, and not to flash targets like the actual bootloader itself. Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f --- M firmware/Makefile M firmware/apps/blupdate/main.c M firmware/libboard/common/resources/sam3s4/dfu.ld M firmware/libboard/common/resources/sam3s4/flash.ld A firmware/libcommon/source/crcstub.c A firmware/misc/crctool.c 6 files changed, 207 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/63/26463/4 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 10:48:08 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 10:48:08 +0000 Subject: Change in simtrace2[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26547 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: Ie0a3b2273383adbb3303faffd6ff96be7f4cae99 --- M firmware/apps/blupdate/main.c M firmware/apps/cardem/main.c M firmware/apps/dfu/main.c M firmware/apps/trace/main.c M firmware/apps/triple_play/main.c M firmware/atmel_softpack_libraries/usb/device/dfu/dfu_driver.c M firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c M firmware/libboard/common/include/board_common.h M firmware/libboard/common/include/boardver_adc.h M firmware/libboard/common/include/led.h M firmware/libboard/common/include/manifest.h M firmware/libboard/common/include/sim_switch.h M firmware/libboard/common/source/boardver_adc.c M firmware/libboard/common/source/led.c M firmware/libboard/common/source/manifest.c M firmware/libboard/ngff_cardem/include/board.h M firmware/libboard/ngff_cardem/include/card_pres.h M firmware/libboard/ngff_cardem/include/wwan_led.h M firmware/libboard/ngff_cardem/include/wwan_perst.h M firmware/libboard/ngff_cardem/source/board_ngff_cardem.c M firmware/libboard/ngff_cardem/source/card_pres.c M firmware/libboard/ngff_cardem/source/sim_switch.c M firmware/libboard/ngff_cardem/source/wwan_led.c M firmware/libboard/ngff_cardem/source/wwan_perst.c M firmware/libboard/octsimtest/include/board.h M firmware/libboard/octsimtest/include/i2c.h M firmware/libboard/octsimtest/include/mcp23017.h M firmware/libboard/octsimtest/source/board_octsimtest.c M firmware/libboard/octsimtest/source/i2c.c M firmware/libboard/octsimtest/source/mux.c M firmware/libboard/octsimtest/source/sim_switch.c M firmware/libboard/owhw/include/board.h M firmware/libboard/owhw/source/owhw.c M firmware/libboard/owhw/source/sim_switch.c M firmware/libboard/qmod/include/board.h M firmware/libboard/qmod/include/card_pres.h M firmware/libboard/qmod/include/i2c.h M firmware/libboard/qmod/include/wwan_led.h M firmware/libboard/qmod/include/wwan_perst.h M firmware/libboard/qmod/source/board_qmod.c M firmware/libboard/qmod/source/card_pres.c M firmware/libboard/qmod/source/i2c.c M firmware/libboard/qmod/source/sim_switch.c M firmware/libboard/qmod/source/wwan_led.c M firmware/libboard/qmod/source/wwan_perst.c M firmware/libboard/sam3p256/include/board.h M firmware/libboard/sam3p256/source/board_sam3p256.c M firmware/libboard/simtrace/include/board.h M firmware/libboard/simtrace/source/board_simtrace.c M firmware/libboard/simtrace/source/sim_switch.c M firmware/libcommon/include/card_emu.h M firmware/libcommon/include/iso7816_fidi.h M firmware/libcommon/include/llist_irqsafe.h M firmware/libcommon/include/ringbuffer.h M firmware/libcommon/include/simtrace.h M firmware/libcommon/include/simtrace_prot.h M firmware/libcommon/include/simtrace_usb.h M firmware/libcommon/include/talloc.h M firmware/libcommon/include/usb_buf.h M firmware/libcommon/include/utils.h M firmware/libcommon/source/card_emu.c M firmware/libcommon/source/fputs.c M firmware/libcommon/source/host_communication.c M firmware/libcommon/source/iso7816_fidi.c M firmware/libcommon/source/main_common.c M firmware/libcommon/source/mode_cardemu.c M firmware/libcommon/source/pseudo_talloc.c M firmware/libcommon/source/ringbuffer.c M firmware/libcommon/source/sniffer.c M firmware/libcommon/source/tc_etu.c M firmware/libcommon/source/usb_buf.c M firmware/libosmocore/include/osmocom/core/bit16gen.h M firmware/libosmocore/include/osmocom/core/bit32gen.h M firmware/libosmocore/include/osmocom/core/bit64gen.h M firmware/libosmocore/include/osmocom/core/linuxrbtree.h M firmware/libosmocore/include/osmocom/core/msgb.h M firmware/libosmocore/include/osmocom/core/timer.h M firmware/libosmocore/source/backtrace.c M firmware/libosmocore/source/bits.c M firmware/libosmocore/source/msgb.c M firmware/libosmocore/source/panic.c M firmware/libosmocore/source/rbtree.c M firmware/libosmocore/source/timer.c M firmware/libosmocore/source/utils.c M firmware/usbstring/usbstring.c M host/include/osmocom/simtrace2/apdu_dispatch.h M host/lib/apdu_dispatch.c M host/lib/gsmtap.c M host/lib/simtrace2_api.c M host/lib/usb_util.c M host/src/simtrace2-cardem-pcsc.c M host/src/simtrace2-sniff.c M host/src/simtrace2-tool.c M host/src/simtrace2_usb.c 94 files changed, 0 insertions(+), 376 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/47/26547/1 diff --git a/firmware/apps/blupdate/main.c b/firmware/apps/blupdate/main.c index 330d040..e9ffe22 100644 --- a/firmware/apps/blupdate/main.c +++ b/firmware/apps/blupdate/main.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include "board.h" #include "core_cm3.h" diff --git a/firmware/apps/cardem/main.c b/firmware/apps/cardem/main.c index 95967ba..d212d2a 100644 --- a/firmware/apps/cardem/main.c +++ b/firmware/apps/cardem/main.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ /*------------------------------------------------------------------------------ * Headers diff --git a/firmware/apps/dfu/main.c b/firmware/apps/dfu/main.c index 48ba879..ef58ec2 100644 --- a/firmware/apps/dfu/main.c +++ b/firmware/apps/dfu/main.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include "board.h" #include "utils.h" diff --git a/firmware/apps/trace/main.c b/firmware/apps/trace/main.c index 08d6120..ec84b5a 100644 --- a/firmware/apps/trace/main.c +++ b/firmware/apps/trace/main.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ /*------------------------------------------------------------------------------ * Headers diff --git a/firmware/apps/triple_play/main.c b/firmware/apps/triple_play/main.c index d22687e..b853cdb 100644 --- a/firmware/apps/triple_play/main.c +++ b/firmware/apps/triple_play/main.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ /*------------------------------------------------------------------------------ * Headers diff --git a/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_driver.c b/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_driver.c index cfb9f63..afec518 100644 --- a/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_driver.c +++ b/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_driver.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * */ #include diff --git a/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c b/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c index f2cf64c..6e16a86 100644 --- a/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c +++ b/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * */ #include diff --git a/firmware/libboard/common/include/board_common.h b/firmware/libboard/common/include/board_common.h index 7c4b908..37fd1a3 100644 --- a/firmware/libboard/common/include/board_common.h +++ b/firmware/libboard/common/include/board_common.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #ifndef _BOARD_ #define _BOARD_ diff --git a/firmware/libboard/common/include/boardver_adc.h b/firmware/libboard/common/include/boardver_adc.h index 956c302..c8f320e 100644 --- a/firmware/libboard/common/include/boardver_adc.h +++ b/firmware/libboard/common/include/boardver_adc.h @@ -7,10 +7,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/common/include/led.h b/firmware/libboard/common/include/led.h index 1ade823..ab12448 100644 --- a/firmware/libboard/common/include/led.h +++ b/firmware/libboard/common/include/led.h @@ -7,10 +7,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/common/include/manifest.h b/firmware/libboard/common/include/manifest.h index b29c1aa..0635bf9 100644 --- a/firmware/libboard/common/include/manifest.h +++ b/firmware/libboard/common/include/manifest.h @@ -7,10 +7,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #ifndef _MANIFEST_H #define _MANIFEST_H diff --git a/firmware/libboard/common/include/sim_switch.h b/firmware/libboard/common/include/sim_switch.h index 4439fa5..61d9c1f 100644 --- a/firmware/libboard/common/include/sim_switch.h +++ b/firmware/libboard/common/include/sim_switch.h @@ -7,10 +7,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/common/source/boardver_adc.c b/firmware/libboard/common/source/boardver_adc.c index 11799cc..9c7769d 100644 --- a/firmware/libboard/common/source/boardver_adc.c +++ b/firmware/libboard/common/source/boardver_adc.c @@ -7,10 +7,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "boardver_adc.h" diff --git a/firmware/libboard/common/source/led.c b/firmware/libboard/common/source/led.c index 4822a6d..8fcb61f 100644 --- a/firmware/libboard/common/source/led.c +++ b/firmware/libboard/common/source/led.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include diff --git a/firmware/libboard/common/source/manifest.c b/firmware/libboard/common/source/manifest.c index 0ad537c..fb3870f 100644 --- a/firmware/libboard/common/source/manifest.c +++ b/firmware/libboard/common/source/manifest.c @@ -7,10 +7,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "manifest.h" diff --git a/firmware/libboard/ngff_cardem/include/board.h b/firmware/libboard/ngff_cardem/include/board.h index 8be7b7f..f74cea1 100644 --- a/firmware/libboard/ngff_cardem/include/board.h +++ b/firmware/libboard/ngff_cardem/include/board.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once #include "board_common.h" diff --git a/firmware/libboard/ngff_cardem/include/card_pres.h b/firmware/libboard/ngff_cardem/include/card_pres.h index 81f0613..e06642e 100644 --- a/firmware/libboard/ngff_cardem/include/card_pres.h +++ b/firmware/libboard/ngff_cardem/include/card_pres.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/ngff_cardem/include/wwan_led.h b/firmware/libboard/ngff_cardem/include/wwan_led.h index 77887c7..a0f060a 100644 --- a/firmware/libboard/ngff_cardem/include/wwan_led.h +++ b/firmware/libboard/ngff_cardem/include/wwan_led.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/ngff_cardem/include/wwan_perst.h b/firmware/libboard/ngff_cardem/include/wwan_perst.h index c934afc..623184e 100644 --- a/firmware/libboard/ngff_cardem/include/wwan_perst.h +++ b/firmware/libboard/ngff_cardem/include/wwan_perst.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c b/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c index 0ac9cd8..fea64d3 100644 --- a/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c +++ b/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "simtrace.h" diff --git a/firmware/libboard/ngff_cardem/source/card_pres.c b/firmware/libboard/ngff_cardem/source/card_pres.c index 7d6c483..d425ec5 100644 --- a/firmware/libboard/ngff_cardem/source/card_pres.c +++ b/firmware/libboard/ngff_cardem/source/card_pres.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include "board.h" diff --git a/firmware/libboard/ngff_cardem/source/sim_switch.c b/firmware/libboard/ngff_cardem/source/sim_switch.c index cc4860a..999d7a7 100644 --- a/firmware/libboard/ngff_cardem/source/sim_switch.c +++ b/firmware/libboard/ngff_cardem/source/sim_switch.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "trace.h" diff --git a/firmware/libboard/ngff_cardem/source/wwan_led.c b/firmware/libboard/ngff_cardem/source/wwan_led.c index 36eb0ec..619d5c8 100644 --- a/firmware/libboard/ngff_cardem/source/wwan_led.c +++ b/firmware/libboard/ngff_cardem/source/wwan_led.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ /* Depending on the board this is running on, it might be possible * for the controller to read the status of the WWAN LED output lines of diff --git a/firmware/libboard/ngff_cardem/source/wwan_perst.c b/firmware/libboard/ngff_cardem/source/wwan_perst.c index 95a7c7b..b314781 100644 --- a/firmware/libboard/ngff_cardem/source/wwan_perst.c +++ b/firmware/libboard/ngff_cardem/source/wwan_perst.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ /* Depending on the board this is running on, it might be possible * for the controller to set the status of the PERST input line of diff --git a/firmware/libboard/octsimtest/include/board.h b/firmware/libboard/octsimtest/include/board.h index 697619c..3540aa2 100644 --- a/firmware/libboard/octsimtest/include/board.h +++ b/firmware/libboard/octsimtest/include/board.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once #include "board_common.h" diff --git a/firmware/libboard/octsimtest/include/i2c.h b/firmware/libboard/octsimtest/include/i2c.h index 6c94d26..7edad2f 100644 --- a/firmware/libboard/octsimtest/include/i2c.h +++ b/firmware/libboard/octsimtest/include/i2c.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/octsimtest/include/mcp23017.h b/firmware/libboard/octsimtest/include/mcp23017.h index 190588f..1f05d3d 100644 --- a/firmware/libboard/octsimtest/include/mcp23017.h +++ b/firmware/libboard/octsimtest/include/mcp23017.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/octsimtest/source/board_octsimtest.c b/firmware/libboard/octsimtest/source/board_octsimtest.c index d8b1cc4..92496da 100644 --- a/firmware/libboard/octsimtest/source/board_octsimtest.c +++ b/firmware/libboard/octsimtest/source/board_octsimtest.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include "board.h" diff --git a/firmware/libboard/octsimtest/source/i2c.c b/firmware/libboard/octsimtest/source/i2c.c index 2cd8423..8627b69 100644 --- a/firmware/libboard/octsimtest/source/i2c.c +++ b/firmware/libboard/octsimtest/source/i2c.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include diff --git a/firmware/libboard/octsimtest/source/mux.c b/firmware/libboard/octsimtest/source/mux.c index 8800ba2..d37adfb 100644 --- a/firmware/libboard/octsimtest/source/mux.c +++ b/firmware/libboard/octsimtest/source/mux.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" diff --git a/firmware/libboard/octsimtest/source/sim_switch.c b/firmware/libboard/octsimtest/source/sim_switch.c index 2b60a30..f001360 100644 --- a/firmware/libboard/octsimtest/source/sim_switch.c +++ b/firmware/libboard/octsimtest/source/sim_switch.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "trace.h" diff --git a/firmware/libboard/owhw/include/board.h b/firmware/libboard/owhw/include/board.h index f929771..1980324 100644 --- a/firmware/libboard/owhw/include/board.h +++ b/firmware/libboard/owhw/include/board.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once #include "board_common.h" diff --git a/firmware/libboard/owhw/source/owhw.c b/firmware/libboard/owhw/source/owhw.c index 516d592..1238082 100644 --- a/firmware/libboard/owhw/source/owhw.c +++ b/firmware/libboard/owhw/source/owhw.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "chip.h" diff --git a/firmware/libboard/owhw/source/sim_switch.c b/firmware/libboard/owhw/source/sim_switch.c index 59513ad..0b829b6 100644 --- a/firmware/libboard/owhw/source/sim_switch.c +++ b/firmware/libboard/owhw/source/sim_switch.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "trace.h" diff --git a/firmware/libboard/qmod/include/board.h b/firmware/libboard/qmod/include/board.h index 0d35bef..6d7d4ff 100644 --- a/firmware/libboard/qmod/include/board.h +++ b/firmware/libboard/qmod/include/board.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once #include "board_common.h" diff --git a/firmware/libboard/qmod/include/card_pres.h b/firmware/libboard/qmod/include/card_pres.h index 81f0613..e06642e 100644 --- a/firmware/libboard/qmod/include/card_pres.h +++ b/firmware/libboard/qmod/include/card_pres.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/qmod/include/i2c.h b/firmware/libboard/qmod/include/i2c.h index 30f57ce..aff1ea6 100644 --- a/firmware/libboard/qmod/include/i2c.h +++ b/firmware/libboard/qmod/include/i2c.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/qmod/include/wwan_led.h b/firmware/libboard/qmod/include/wwan_led.h index 77887c7..a0f060a 100644 --- a/firmware/libboard/qmod/include/wwan_led.h +++ b/firmware/libboard/qmod/include/wwan_led.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/qmod/include/wwan_perst.h b/firmware/libboard/qmod/include/wwan_perst.h index c934afc..623184e 100644 --- a/firmware/libboard/qmod/include/wwan_perst.h +++ b/firmware/libboard/qmod/include/wwan_perst.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/qmod/source/board_qmod.c b/firmware/libboard/qmod/source/board_qmod.c index 32bfdd4..189fb58 100644 --- a/firmware/libboard/qmod/source/board_qmod.c +++ b/firmware/libboard/qmod/source/board_qmod.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "simtrace.h" diff --git a/firmware/libboard/qmod/source/card_pres.c b/firmware/libboard/qmod/source/card_pres.c index 7a32b57..21ce1fb 100644 --- a/firmware/libboard/qmod/source/card_pres.c +++ b/firmware/libboard/qmod/source/card_pres.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include "board.h" diff --git a/firmware/libboard/qmod/source/i2c.c b/firmware/libboard/qmod/source/i2c.c index a708704..7aa3d1d 100644 --- a/firmware/libboard/qmod/source/i2c.c +++ b/firmware/libboard/qmod/source/i2c.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include diff --git a/firmware/libboard/qmod/source/sim_switch.c b/firmware/libboard/qmod/source/sim_switch.c index 59513ad..0b829b6 100644 --- a/firmware/libboard/qmod/source/sim_switch.c +++ b/firmware/libboard/qmod/source/sim_switch.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "trace.h" diff --git a/firmware/libboard/qmod/source/wwan_led.c b/firmware/libboard/qmod/source/wwan_led.c index b3b5693..f055080 100644 --- a/firmware/libboard/qmod/source/wwan_led.c +++ b/firmware/libboard/qmod/source/wwan_led.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ /* Depending on the board this is running on, it might be possible * for the controller to read the status of the WWAN LED output lines of diff --git a/firmware/libboard/qmod/source/wwan_perst.c b/firmware/libboard/qmod/source/wwan_perst.c index 95a7c7b..b314781 100644 --- a/firmware/libboard/qmod/source/wwan_perst.c +++ b/firmware/libboard/qmod/source/wwan_perst.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ /* Depending on the board this is running on, it might be possible * for the controller to set the status of the PERST input line of diff --git a/firmware/libboard/sam3p256/include/board.h b/firmware/libboard/sam3p256/include/board.h index 06cfdce..ff87c99 100644 --- a/firmware/libboard/sam3p256/include/board.h +++ b/firmware/libboard/sam3p256/include/board.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once #include "board_common.h" diff --git a/firmware/libboard/sam3p256/source/board_sam3p256.c b/firmware/libboard/sam3p256/source/board_sam3p256.c index 4b6a451..47f8ea7 100644 --- a/firmware/libboard/sam3p256/source/board_sam3p256.c +++ b/firmware/libboard/sam3p256/source/board_sam3p256.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "simtrace.h" diff --git a/firmware/libboard/simtrace/include/board.h b/firmware/libboard/simtrace/include/board.h index 6e4cd98..7cb30b0 100644 --- a/firmware/libboard/simtrace/include/board.h +++ b/firmware/libboard/simtrace/include/board.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once #include "board_common.h" diff --git a/firmware/libboard/simtrace/source/board_simtrace.c b/firmware/libboard/simtrace/source/board_simtrace.c index 9d323cf..d15d6b9 100644 --- a/firmware/libboard/simtrace/source/board_simtrace.c +++ b/firmware/libboard/simtrace/source/board_simtrace.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "simtrace.h" diff --git a/firmware/libboard/simtrace/source/sim_switch.c b/firmware/libboard/simtrace/source/sim_switch.c index c5c54f0..c3a8503 100644 --- a/firmware/libboard/simtrace/source/sim_switch.c +++ b/firmware/libboard/simtrace/source/sim_switch.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "trace.h" diff --git a/firmware/libcommon/include/card_emu.h b/firmware/libcommon/include/card_emu.h index 58e24cd..177fad2 100644 --- a/firmware/libcommon/include/card_emu.h +++ b/firmware/libcommon/include/card_emu.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/include/iso7816_fidi.h b/firmware/libcommon/include/iso7816_fidi.h index 19483b0..823e7ab 100644 --- a/firmware/libcommon/include/iso7816_fidi.h +++ b/firmware/libcommon/include/iso7816_fidi.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/include/llist_irqsafe.h b/firmware/libcommon/include/llist_irqsafe.h index 9171ccf..8aafcfb 100644 --- a/firmware/libcommon/include/llist_irqsafe.h +++ b/firmware/libcommon/include/llist_irqsafe.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/include/ringbuffer.h b/firmware/libcommon/include/ringbuffer.h index 23aaa59..51af3b2 100644 --- a/firmware/libcommon/include/ringbuffer.h +++ b/firmware/libcommon/include/ringbuffer.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #ifndef SIMTRACE_RINGBUF_H #define SIMTRACE_RINGBUF_H diff --git a/firmware/libcommon/include/simtrace.h b/firmware/libcommon/include/simtrace.h index 67f3988..a37ec4f 100644 --- a/firmware/libcommon/include/simtrace.h +++ b/firmware/libcommon/include/simtrace.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #ifndef SIMTRACE_H #define SIMTRACE_H diff --git a/firmware/libcommon/include/simtrace_prot.h b/firmware/libcommon/include/simtrace_prot.h index 5eb4f59..5c43b06 100644 --- a/firmware/libcommon/include/simtrace_prot.h +++ b/firmware/libcommon/include/simtrace_prot.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/include/simtrace_usb.h b/firmware/libcommon/include/simtrace_usb.h index 7bf401c..1473762 100644 --- a/firmware/libcommon/include/simtrace_usb.h +++ b/firmware/libcommon/include/simtrace_usb.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ /* SIMtrace USB IDs */ #define USB_VENDOR_OPENMOKO 0x1d50 diff --git a/firmware/libcommon/include/talloc.h b/firmware/libcommon/include/talloc.h index 625355a..1e95603 100644 --- a/firmware/libcommon/include/talloc.h +++ b/firmware/libcommon/include/talloc.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/include/usb_buf.h b/firmware/libcommon/include/usb_buf.h index 3a4eda2..39198f3 100644 --- a/firmware/libcommon/include/usb_buf.h +++ b/firmware/libcommon/include/usb_buf.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/include/utils.h b/firmware/libcommon/include/utils.h index 2c966f9..234d278 100644 --- a/firmware/libcommon/include/utils.h +++ b/firmware/libcommon/include/utils.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c index debc658..19a519a 100644 --- a/firmware/libcommon/source/card_emu.c +++ b/firmware/libcommon/source/card_emu.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include diff --git a/firmware/libcommon/source/fputs.c b/firmware/libcommon/source/fputs.c index 110f68e..8f2b21e 100644 --- a/firmware/libcommon/source/fputs.c +++ b/firmware/libcommon/source/fputs.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include "uart_console.h" diff --git a/firmware/libcommon/source/host_communication.c b/firmware/libcommon/source/host_communication.c index 9a6e5b3..b2faf1b 100644 --- a/firmware/libcommon/source/host_communication.c +++ b/firmware/libcommon/source/host_communication.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "llist_irqsafe.h" diff --git a/firmware/libcommon/source/iso7816_fidi.c b/firmware/libcommon/source/iso7816_fidi.c index 033a325..024663b 100644 --- a/firmware/libcommon/source/iso7816_fidi.c +++ b/firmware/libcommon/source/iso7816_fidi.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include diff --git a/firmware/libcommon/source/main_common.c b/firmware/libcommon/source/main_common.c index 3314595..cd3bced 100644 --- a/firmware/libcommon/source/main_common.c +++ b/firmware/libcommon/source/main_common.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "board.h" diff --git a/firmware/libcommon/source/mode_cardemu.c b/firmware/libcommon/source/mode_cardemu.c index 4a0b862..8e4acf9 100644 --- a/firmware/libcommon/source/mode_cardemu.c +++ b/firmware/libcommon/source/mode_cardemu.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "boardver_adc.h" diff --git a/firmware/libcommon/source/pseudo_talloc.c b/firmware/libcommon/source/pseudo_talloc.c index bbcd7af..5a4d1ca 100644 --- a/firmware/libcommon/source/pseudo_talloc.c +++ b/firmware/libcommon/source/pseudo_talloc.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include diff --git a/firmware/libcommon/source/ringbuffer.c b/firmware/libcommon/source/ringbuffer.c index 70747a1..591d31f 100644 --- a/firmware/libcommon/source/ringbuffer.c +++ b/firmware/libcommon/source/ringbuffer.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "ringbuffer.h" #include "trace.h" diff --git a/firmware/libcommon/source/sniffer.c b/firmware/libcommon/source/sniffer.c index 57e2daa..366ac7e 100644 --- a/firmware/libcommon/source/sniffer.c +++ b/firmware/libcommon/source/sniffer.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ /* This code implement the Sniffer mode to sniff the communication between a * SIM card (or any ISO 7816 smart card) and a phone (or any ISO 7816 card diff --git a/firmware/libcommon/source/tc_etu.c b/firmware/libcommon/source/tc_etu.c index 04a7324..a48da8c 100644 --- a/firmware/libcommon/source/tc_etu.c +++ b/firmware/libcommon/source/tc_etu.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include diff --git a/firmware/libcommon/source/usb_buf.c b/firmware/libcommon/source/usb_buf.c index b97eb9c..72eae54 100644 --- a/firmware/libcommon/source/usb_buf.c +++ b/firmware/libcommon/source/usb_buf.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "trace.h" diff --git a/firmware/libosmocore/include/osmocom/core/bit16gen.h b/firmware/libosmocore/include/osmocom/core/bit16gen.h index 5c6162c..ed47285 100644 --- a/firmware/libosmocore/include/osmocom/core/bit16gen.h +++ b/firmware/libosmocore/include/osmocom/core/bit16gen.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/firmware/libosmocore/include/osmocom/core/bit32gen.h b/firmware/libosmocore/include/osmocom/core/bit32gen.h index 6640e76..12abb72 100644 --- a/firmware/libosmocore/include/osmocom/core/bit32gen.h +++ b/firmware/libosmocore/include/osmocom/core/bit32gen.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/firmware/libosmocore/include/osmocom/core/bit64gen.h b/firmware/libosmocore/include/osmocom/core/bit64gen.h index 8c7b709..2aa2a2e 100644 --- a/firmware/libosmocore/include/osmocom/core/bit64gen.h +++ b/firmware/libosmocore/include/osmocom/core/bit64gen.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/firmware/libosmocore/include/osmocom/core/linuxrbtree.h b/firmware/libosmocore/include/osmocom/core/linuxrbtree.h index d3f9fd1..4212109 100644 --- a/firmware/libosmocore/include/osmocom/core/linuxrbtree.h +++ b/firmware/libosmocore/include/osmocom/core/linuxrbtree.h @@ -11,10 +11,6 @@ but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. linux/include/linux/rbtree.h diff --git a/firmware/libosmocore/include/osmocom/core/msgb.h b/firmware/libosmocore/include/osmocom/core/msgb.h index 7c4420d..dadf487 100644 --- a/firmware/libosmocore/include/osmocom/core/msgb.h +++ b/firmware/libosmocore/include/osmocom/core/msgb.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/firmware/libosmocore/include/osmocom/core/timer.h b/firmware/libosmocore/include/osmocom/core/timer.h index 6d70fff..6bd95a7 100644 --- a/firmware/libosmocore/include/osmocom/core/timer.h +++ b/firmware/libosmocore/include/osmocom/core/timer.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup timer Osmocom timers diff --git a/firmware/libosmocore/source/backtrace.c b/firmware/libosmocore/source/backtrace.c index 5d6dc4a..3938d7a 100644 --- a/firmware/libosmocore/source/backtrace.c +++ b/firmware/libosmocore/source/backtrace.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \file backtrace.c diff --git a/firmware/libosmocore/source/bits.c b/firmware/libosmocore/source/bits.c index 0c77b27..5fa9488 100644 --- a/firmware/libosmocore/source/bits.c +++ b/firmware/libosmocore/source/bits.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/firmware/libosmocore/source/msgb.c b/firmware/libosmocore/source/msgb.c index a27100c..fcdda87 100644 --- a/firmware/libosmocore/source/msgb.c +++ b/firmware/libosmocore/source/msgb.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup msgb diff --git a/firmware/libosmocore/source/panic.c b/firmware/libosmocore/source/panic.c index db5c26a..589464a 100644 --- a/firmware/libosmocore/source/panic.c +++ b/firmware/libosmocore/source/panic.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup utils diff --git a/firmware/libosmocore/source/rbtree.c b/firmware/libosmocore/source/rbtree.c index f0ebb8c..a8969f4 100644 --- a/firmware/libosmocore/source/rbtree.c +++ b/firmware/libosmocore/source/rbtree.c @@ -12,10 +12,6 @@ but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA linux/lib/rbtree.c diff --git a/firmware/libosmocore/source/timer.c b/firmware/libosmocore/source/timer.c index 75c7d45..eb43884 100644 --- a/firmware/libosmocore/source/timer.c +++ b/firmware/libosmocore/source/timer.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/firmware/libosmocore/source/utils.c b/firmware/libosmocore/source/utils.c index 3096572..f519df7 100644 --- a/firmware/libosmocore/source/utils.c +++ b/firmware/libosmocore/source/utils.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/firmware/usbstring/usbstring.c b/firmware/usbstring/usbstring.c index ed07568..e7c6c8c 100644 --- a/firmware/usbstring/usbstring.c +++ b/firmware/usbstring/usbstring.c @@ -10,10 +10,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ /* Based on existing utf8_to_utf16le() function, diff --git a/host/include/osmocom/simtrace2/apdu_dispatch.h b/host/include/osmocom/simtrace2/apdu_dispatch.h index 42a097a..62ff762 100644 --- a/host/include/osmocom/simtrace2/apdu_dispatch.h +++ b/host/include/osmocom/simtrace2/apdu_dispatch.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #pragma once diff --git a/host/lib/apdu_dispatch.c b/host/lib/apdu_dispatch.c index ec368b2..4c8f505 100644 --- a/host/lib/apdu_dispatch.c +++ b/host/lib/apdu_dispatch.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include #include diff --git a/host/lib/gsmtap.c b/host/lib/gsmtap.c index 18814d3..3fc3da6 100644 --- a/host/lib/gsmtap.c +++ b/host/lib/gsmtap.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include diff --git a/host/lib/simtrace2_api.c b/host/lib/simtrace2_api.c index a61b2cf..4ad7eb7 100644 --- a/host/lib/simtrace2_api.c +++ b/host/lib/simtrace2_api.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include diff --git a/host/lib/usb_util.c b/host/lib/usb_util.c index 872d185..d55bbc7 100644 --- a/host/lib/usb_util.c +++ b/host/lib/usb_util.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include #include diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index 576de61..2806b0f 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include diff --git a/host/src/simtrace2-sniff.c b/host/src/simtrace2-sniff.c index 653508d..a4eccb2 100644 --- a/host/src/simtrace2-sniff.c +++ b/host/src/simtrace2-sniff.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include #include diff --git a/host/src/simtrace2-tool.c b/host/src/simtrace2-tool.c index 97d7706..d92638f 100644 --- a/host/src/simtrace2-tool.c +++ b/host/src/simtrace2-tool.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include diff --git a/host/src/simtrace2_usb.c b/host/src/simtrace2_usb.c index be1ba6e..10dc948 100644 --- a/host/src/simtrace2_usb.c +++ b/host/src/simtrace2_usb.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include #include -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie0a3b2273383adbb3303faffd6ff96be7f4cae99 Gerrit-Change-Number: 26547 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: laforge Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 10:48:47 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 10:48:47 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 4: > Patch Set 3: > > > 3. firmware/libcommon/source/crcstub.c:16: ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. > > > > Personally I like if there is not so much boilerplate at the start of every file, and having the mailing address from the FSF in there in 2021 is probably not useful. So I'd argue it makes sense to remove the address. > > I'd argue that the comment block at the top is collapsed by any reasonable editor anyway because no one wants to look at it - unless you create a new file, by just copying the block from another open file. Then having to check and modify that block because the linter looks at comments does not sound like a improvement to me.. As discussed in the team meeting, I've removed the address from the source tree and this patch. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Tue, 14 Dec 2021 10:48:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 10:51:37 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 10:51:37 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Tue, 14 Dec 2021 10:51:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:26:21 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:26:21 +0000 Subject: Change in libosmo-abis[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26548 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I0ad20cdf1e571c1a15f6e67d46e07155a6a02520 --- M src/input/dahdi.c M src/input/e1d.c M src/input/ipa_keepalive.c M src/input/lapd.c M src/input/unixsocket.c M src/trau/osmo_ortp.c 6 files changed, 0 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/48/26548/1 diff --git a/src/input/dahdi.c b/src/input/dahdi.c index 6dee0d7..acf1f94 100644 --- a/src/input/dahdi.c +++ b/src/input/dahdi.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/input/e1d.c b/src/input/e1d.c index cab219d..a959b40 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/input/ipa_keepalive.c b/src/input/ipa_keepalive.c index 172a36f..7fc28f1 100644 --- a/src/input/ipa_keepalive.c +++ b/src/input/ipa_keepalive.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/input/lapd.c b/src/input/lapd.c index 6f1e270..130e4c3 100644 --- a/src/input/lapd.c +++ b/src/input/lapd.c @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "internal.h" diff --git a/src/input/unixsocket.c b/src/input/unixsocket.c index 595dc7d..069f9c6 100644 --- a/src/input/unixsocket.c +++ b/src/input/unixsocket.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c index 011f097..5761d78 100644 --- a/src/trau/osmo_ortp.c +++ b/src/trau/osmo_ortp.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \file osmo_ortp.c -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0ad20cdf1e571c1a15f6e67d46e07155a6a02520 Gerrit-Change-Number: 26548 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:26:30 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:26:30 +0000 Subject: Change in libosmo-sccp[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26549 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: Ia450b630e0b60b38835f599c93985bbe97c50d2f --- M include/osmocom/mtp/mtp_level3.h M include/osmocom/mtp/mtp_pcap.h M include/osmocom/sccp/sccp.h M include/osmocom/sccp/sccp_types.h M src/mtp_pcap.c M src/sccp.c M tests/sccp/sccp_test.c M tests/vty/ss7_asp_vty_test.c 8 files changed, 0 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/49/26549/1 diff --git a/include/osmocom/mtp/mtp_level3.h b/include/osmocom/mtp/mtp_level3.h index 414b144..5bb8629 100644 --- a/include/osmocom/mtp/mtp_level3.h +++ b/include/osmocom/mtp/mtp_level3.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/mtp/mtp_pcap.h b/include/osmocom/mtp/mtp_pcap.h index 5e8f7d3..4e400e2 100644 --- a/include/osmocom/mtp/mtp_pcap.h +++ b/include/osmocom/mtp/mtp_pcap.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef mtp_pcap_h #define mtp_pcap_h diff --git a/include/osmocom/sccp/sccp.h b/include/osmocom/sccp/sccp.h index 4293792..9ff1067 100644 --- a/include/osmocom/sccp/sccp.h +++ b/include/osmocom/sccp/sccp.h @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef SCCP_H diff --git a/include/osmocom/sccp/sccp_types.h b/include/osmocom/sccp/sccp_types.h index 4ad7edf..0ef52b4 100644 --- a/include/osmocom/sccp/sccp_types.h +++ b/include/osmocom/sccp/sccp_types.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef SCCP_TYPES_H diff --git a/src/mtp_pcap.c b/src/mtp_pcap.c index a59efc5..5a67acf 100644 --- a/src/mtp_pcap.c +++ b/src/mtp_pcap.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/sccp.c b/src/sccp.c index 058f20b..ee90579 100644 --- a/src/sccp.c +++ b/src/sccp.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/sccp/sccp_test.c b/tests/sccp/sccp_test.c index 29f343f..1fe353d 100644 --- a/tests/sccp/sccp_test.c +++ b/tests/sccp/sccp_test.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/vty/ss7_asp_vty_test.c b/tests/vty/ss7_asp_vty_test.c index eb575bc..4ee0f7f 100644 --- a/tests/vty/ss7_asp_vty_test.c +++ b/tests/vty/ss7_asp_vty_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #define _GNU_SOURCE -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia450b630e0b60b38835f599c93985bbe97c50d2f Gerrit-Change-Number: 26549 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:26:40 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:26:40 +0000 Subject: Change in libosmocore[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26550 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I5050285e75cf120407a1d883e99b3c4bcae8ffd7 --- M include/osmocom/core/base64.h M include/osmocom/core/bitXXgen.h.tpl M include/osmocom/core/bitcomp.h M include/osmocom/core/bitvec.h M include/osmocom/core/conv.h M include/osmocom/core/crcXXgen.h.tpl M include/osmocom/core/crcgen.h M include/osmocom/core/exec.h M include/osmocom/core/isdnhdlc.h M include/osmocom/core/linuxrbtree.h M include/osmocom/core/loggingrb.h M include/osmocom/core/msgb.h M include/osmocom/core/msgfile.h M include/osmocom/core/serial.h M include/osmocom/core/sockaddr_str.h M include/osmocom/core/stats.h M include/osmocom/core/strrb.h M include/osmocom/core/thread.h M include/osmocom/core/timer.h M include/osmocom/core/timer_compat.h M include/osmocom/core/use_count.h M include/osmocom/core/write_queue.h M include/osmocom/gsm/a5.h M include/osmocom/gsm/bsslap.h M include/osmocom/gsm/bssmap_le.h M include/osmocom/gsm/cbsp.h M include/osmocom/gsm/gsm0808.h M include/osmocom/gsm/gsm0808_lcs.h M include/osmocom/gsm/gsm29118.h M include/osmocom/gsm/gsm29205.h M include/osmocom/gsm/gsm_utils.h M include/osmocom/gsm/i460_mux.h M include/osmocom/gsm/protocol/gsm_08_58.h M include/osmocom/gsm/protocol/gsm_12_21.h M include/osmocom/gsm/protocol/gsm_48_071.h M include/osmocom/gsm/protocol/gsm_49_031.h M include/osmocom/sim/class_tables.h M include/osmocom/usb/libusb.h M include/osmocom/vty/telnet_interface.h M include/osmocom/vty/vector.h M src/application.c M src/backtrace.c M src/base64.c M src/bitcomp.c M src/bits.c M src/bitvec.c M src/codec/ecu.c M src/codec/ecu_fr.c M src/codec/gsm610.c M src/codec/gsm620.c M src/codec/gsm660.c M src/codec/gsm690.c M src/coding/gsm0503_coding.c M src/coding/gsm0503_interleaving.c M src/coding/gsm0503_mapping.c M src/coding/gsm0503_parity.c M src/coding/gsm0503_tables.c M src/context.c M src/conv.c M src/conv_acc.c M src/conv_acc_generic.c M src/conv_acc_neon.c M src/conv_acc_neon_impl.h M src/conv_acc_sse.c M src/conv_acc_sse_avx.c M src/conv_acc_sse_impl.h M src/counter.c M src/crcXXgen.c.tpl M src/ctrl/control_cmd.c M src/ctrl/control_if.c M src/ctrl/control_vty.c M src/exec.c M src/fsm.c M src/gsm/a5.c M src/gsm/auth_comp128v1.c M src/gsm/auth_comp128v23.c M src/gsm/auth_core.c M src/gsm/auth_milenage.c M src/gsm/auth_xor.c M src/gsm/bsslap.c M src/gsm/bssmap_le.c M src/gsm/bts_features.c M src/gsm/cbsp.c M src/gsm/comp128.c M src/gsm/comp128v23.c M src/gsm/gea.c M src/gsm/gprs_cipher_core.c M src/gsm/gprs_gea.c M src/gsm/gsm0341.c M src/gsm/gsm0480.c M src/gsm/gsm0808.c M src/gsm/gsm23003.c M src/gsm/gsm23236.c M src/gsm/gsm29118.c M src/gsm/gsm29205.c M src/gsm/gsm48.c M src/gsm/gsm48_ie.c M src/gsm/gsm_utils.c M src/gsm/i460_mux.c M src/gsm/kasumi.c M src/gsm/kdf.c M src/gsm/lapd_core.c M src/gsm/lapdm.c M src/gsm/rsl.c M src/gsm/rxlev_stat.c M src/gsmtap_util.c M src/isdnhdlc.c M src/it_q.c M src/logging.c M src/logging_gsmtap.c M src/logging_syslog.c M src/logging_systemd.c M src/loggingrb.c M src/macaddr.c M src/mnl.c M src/msgb.c M src/msgfile.c M src/panic.c M src/plugin.c M src/rate_ctr.c M src/rbtree.c M src/select.c M src/sercomm.c M src/serial.c M src/signal.c M src/sim/card_fs_hpsim.c M src/sim/card_fs_isim.c M src/sim/card_fs_sim.c M src/sim/card_fs_tetra.c M src/sim/card_fs_uicc.c M src/sim/card_fs_usim.c M src/sim/class_tables.c M src/sim/core.c M src/sim/reader.c M src/sim/reader_pcsc.c M src/sockaddr_str.c M src/socket.c M src/stat_item.c M src/stats.c M src/stats_statsd.c M src/strrb.c M src/thread.c M src/timer.c M src/timer_clockgettime.c M src/timer_gettimeofday.c M src/usb/osmo_libusb.c M src/use_count.c M src/utils.c M src/vty/fsm_vty.c M src/vty/logging_vty.c M src/vty/stats_vty.c M src/vty/talloc_ctx_vty.c M src/vty/telnet_interface.c M src/vty/utils.c M src/vty/vector.c M src/write_queue.c M tests/abis/abis_test.c M tests/coding/coding_test.c M tests/dtx/dtx_gsm0503_test.c M tests/fr/fr_test.c M tests/gsm0408/gsm0408_test.c M tests/gsm0502/gsm0502_test.c M tests/gsm0808/gsm0808_test.c M tests/gsm23003/gsm23003_test.c M tests/gsm23236/gsm23236_test.c M tests/gsm29205/gsm29205_test.c M tests/gsm48/rest_octets_test.c M tests/lapd/lapd_test.c M tests/logging/logging_test.c M tests/logging/logging_vty_test.c M tests/loggingrb/loggingrb_test.c M tests/msgb/msgb_test.c M tests/msgfile/msgfile_test.c M tests/oap/oap_test.c M tests/sercomm/sercomm_test.c M tests/sim/sim_test.c M tests/sms/sms_test.c M tests/smscb/gsm0341_test.c M tests/smscb/smscb_test.c M tests/sockaddr_str/sockaddr_str_test.c M tests/socket/socket_sctp_test.c M tests/socket/socket_test.c M tests/stats/stats_test.c M tests/strrb/strrb_test.c M tests/tdef/tdef_test.c M tests/tdef/tdef_vty_config_root_test.c M tests/tdef/tdef_vty_config_subnode_test.c M tests/tdef/tdef_vty_dynamic_test.c M tests/timer/clk_override_test.c M tests/timer/timer_test.c M tests/use_count/use_count_test.c M tests/ussd/ussd_test.c M tests/utils/utils_test.c M tests/vty/vty_test.c M tests/vty/vty_transcript_test.c M utils/conv_gen.py M utils/osmo-arfcn.c M utils/osmo-auc-gen.c M utils/osmo-config-merge.c M utils/osmo-sim-test.c 200 files changed, 0 insertions(+), 812 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/26550/1 diff --git a/include/osmocom/core/base64.h b/include/osmocom/core/base64.h index 86b862e..a6c9720 100644 --- a/include/osmocom/core/base64.h +++ b/include/osmocom/core/base64.h @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/include/osmocom/core/bitXXgen.h.tpl b/include/osmocom/core/bitXXgen.h.tpl index 258fccb..ab54ba9 100644 --- a/include/osmocom/core/bitXXgen.h.tpl +++ b/include/osmocom/core/bitXXgen.h.tpl @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/include/osmocom/core/bitcomp.h b/include/osmocom/core/bitcomp.h index 5faa5ea..2167957 100644 --- a/include/osmocom/core/bitcomp.h +++ b/include/osmocom/core/bitcomp.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/bitvec.h b/include/osmocom/core/bitvec.h index bd10709..6a37861 100644 --- a/include/osmocom/core/bitvec.h +++ b/include/osmocom/core/bitvec.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/conv.h b/include/osmocom/core/conv.h index 8b344f4..1c14c3b 100644 --- a/include/osmocom/core/conv.h +++ b/include/osmocom/core/conv.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \defgroup conv Convolutional encoding and decoding routines diff --git a/include/osmocom/core/crcXXgen.h.tpl b/include/osmocom/core/crcXXgen.h.tpl index 823f21f..13a3623 100644 --- a/include/osmocom/core/crcXXgen.h.tpl +++ b/include/osmocom/core/crcXXgen.h.tpl @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/include/osmocom/core/crcgen.h b/include/osmocom/core/crcgen.h index 7cfe869..24d29e7 100644 --- a/include/osmocom/core/crcgen.h +++ b/include/osmocom/core/crcgen.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/include/osmocom/core/exec.h b/include/osmocom/core/exec.h index e63ec11..a4fdcfd 100644 --- a/include/osmocom/core/exec.h +++ b/include/osmocom/core/exec.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ extern const char *osmo_environment_whitelist[]; diff --git a/include/osmocom/core/isdnhdlc.h b/include/osmocom/core/isdnhdlc.h index 56369bf..43e6e7a 100644 --- a/include/osmocom/core/isdnhdlc.h +++ b/include/osmocom/core/isdnhdlc.h @@ -20,10 +20,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ #ifndef __ISDNHDLC_H__ diff --git a/include/osmocom/core/linuxrbtree.h b/include/osmocom/core/linuxrbtree.h index d3f9fd1..e15317e 100644 --- a/include/osmocom/core/linuxrbtree.h +++ b/include/osmocom/core/linuxrbtree.h @@ -12,11 +12,6 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - MA 02110-1301, USA. - linux/include/linux/rbtree.h To use rbtrees you'll have to implement your own insert and search cores. diff --git a/include/osmocom/core/loggingrb.h b/include/osmocom/core/loggingrb.h index a9fb404..6d50146 100644 --- a/include/osmocom/core/loggingrb.h +++ b/include/osmocom/core/loggingrb.h @@ -11,10 +11,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/msgb.h b/include/osmocom/core/msgb.h index df796c9..38e51dd 100644 --- a/include/osmocom/core/msgb.h +++ b/include/osmocom/core/msgb.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/include/osmocom/core/msgfile.h b/include/osmocom/core/msgfile.h index 800b431..cfa9590 100644 --- a/include/osmocom/core/msgfile.h +++ b/include/osmocom/core/msgfile.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/serial.h b/include/osmocom/core/serial.h index 443275f..0ac2968 100644 --- a/include/osmocom/core/serial.h +++ b/include/osmocom/core/serial.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \defgroup serial Utility functions to deal with serial ports diff --git a/include/osmocom/core/sockaddr_str.h b/include/osmocom/core/sockaddr_str.h index d96b743..f474fa0 100644 --- a/include/osmocom/core/sockaddr_str.h +++ b/include/osmocom/core/sockaddr_str.h @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/stats.h b/include/osmocom/core/stats.h index c4f71c8..6544dfa 100644 --- a/include/osmocom/core/stats.h +++ b/include/osmocom/core/stats.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/strrb.h b/include/osmocom/core/strrb.h index b87239d..e3d3201 100644 --- a/include/osmocom/core/strrb.h +++ b/include/osmocom/core/strrb.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/thread.h b/include/osmocom/core/thread.h index 40b5436..d857268 100644 --- a/include/osmocom/core/thread.h +++ b/include/osmocom/core/thread.h @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup thread Osmocom thread helpers diff --git a/include/osmocom/core/timer.h b/include/osmocom/core/timer.h index 61d20e2..16338da 100644 --- a/include/osmocom/core/timer.h +++ b/include/osmocom/core/timer.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup timer Osmocom timers diff --git a/include/osmocom/core/timer_compat.h b/include/osmocom/core/timer_compat.h index 916f568..fd52ae3 100644 --- a/include/osmocom/core/timer_compat.h +++ b/include/osmocom/core/timer_compat.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup timer Osmocom timers diff --git a/include/osmocom/core/use_count.h b/include/osmocom/core/use_count.h index cc5493c..532d8b1 100644 --- a/include/osmocom/core/use_count.h +++ b/include/osmocom/core/use_count.h @@ -19,10 +19,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/include/osmocom/core/write_queue.h b/include/osmocom/core/write_queue.h index 75d5d8f..6cb0a6b 100644 --- a/include/osmocom/core/write_queue.h +++ b/include/osmocom/core/write_queue.h @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/a5.h b/include/osmocom/gsm/a5.h index fa63246..1b26842 100644 --- a/include/osmocom/gsm/a5.h +++ b/include/osmocom/gsm/a5.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/include/osmocom/gsm/bsslap.h b/include/osmocom/gsm/bsslap.h index b2174b3..56f2e6c 100644 --- a/include/osmocom/gsm/bsslap.h +++ b/include/osmocom/gsm/bsslap.h @@ -21,10 +21,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/bssmap_le.h b/include/osmocom/gsm/bssmap_le.h index 1c750c8..113d4bd 100644 --- a/include/osmocom/gsm/bssmap_le.h +++ b/include/osmocom/gsm/bssmap_le.h @@ -21,10 +21,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/cbsp.h b/include/osmocom/gsm/cbsp.h index d456ce2..30a0ec9 100644 --- a/include/osmocom/gsm/cbsp.h +++ b/include/osmocom/gsm/cbsp.h @@ -24,10 +24,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /* Decoded 8.2.3 Message Content */ diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h index c21ce8a..c79da6a 100644 --- a/include/osmocom/gsm/gsm0808.h +++ b/include/osmocom/gsm/gsm0808.h @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/gsm0808_lcs.h b/include/osmocom/gsm/gsm0808_lcs.h index 8fcbe38..7166501 100644 --- a/include/osmocom/gsm/gsm0808_lcs.h +++ b/include/osmocom/gsm/gsm0808_lcs.h @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/gsm29118.h b/include/osmocom/gsm/gsm29118.h index e81cce4..33c40d3 100644 --- a/include/osmocom/gsm/gsm29118.h +++ b/include/osmocom/gsm/gsm29118.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/gsm29205.h b/include/osmocom/gsm/gsm29205.h index f93e34a..6c845fb 100644 --- a/include/osmocom/gsm/gsm29205.h +++ b/include/osmocom/gsm/gsm29205.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/gsm_utils.h b/include/osmocom/gsm/gsm_utils.h index 45af4f2..07b6a8b 100644 --- a/include/osmocom/gsm/gsm_utils.h +++ b/include/osmocom/gsm/gsm_utils.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/i460_mux.h b/include/osmocom/gsm/i460_mux.h index 8e39243..770b1e1 100644 --- a/include/osmocom/gsm/i460_mux.h +++ b/include/osmocom/gsm/i460_mux.h @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #pragma once diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h index b46f9f5..4937f08 100644 --- a/include/osmocom/gsm/protocol/gsm_08_58.h +++ b/include/osmocom/gsm/protocol/gsm_08_58.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/protocol/gsm_12_21.h b/include/osmocom/gsm/protocol/gsm_12_21.h index 542d978..9fe6a8b 100644 --- a/include/osmocom/gsm/protocol/gsm_12_21.h +++ b/include/osmocom/gsm/protocol/gsm_12_21.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/protocol/gsm_48_071.h b/include/osmocom/gsm/protocol/gsm_48_071.h index fb9653a..961211b 100644 --- a/include/osmocom/gsm/protocol/gsm_48_071.h +++ b/include/osmocom/gsm/protocol/gsm_48_071.h @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/protocol/gsm_49_031.h b/include/osmocom/gsm/protocol/gsm_49_031.h index c6152e1..06fcbce 100644 --- a/include/osmocom/gsm/protocol/gsm_49_031.h +++ b/include/osmocom/gsm/protocol/gsm_49_031.h @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/sim/class_tables.h b/include/osmocom/sim/class_tables.h index d5be39d..ec9ec49 100644 --- a/include/osmocom/sim/class_tables.h +++ b/include/osmocom/sim/class_tables.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #pragma once diff --git a/include/osmocom/usb/libusb.h b/include/osmocom/usb/libusb.h index 9ad3f71..33caa86 100644 --- a/include/osmocom/usb/libusb.h +++ b/include/osmocom/usb/libusb.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include diff --git a/include/osmocom/vty/telnet_interface.h b/include/osmocom/vty/telnet_interface.h index da7cf83..a28df47 100644 --- a/include/osmocom/vty/telnet_interface.h +++ b/include/osmocom/vty/telnet_interface.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/vty/vector.h b/include/osmocom/vty/vector.h index 0a639ad..ac524bc 100644 --- a/include/osmocom/vty/vector.h +++ b/include/osmocom/vty/vector.h @@ -14,11 +14,6 @@ * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with GNU Zebra; see the file COPYING. If not, write to the Free - * Software Foundation, Inc., 51 Franklin Street, Fifth Floor, - * Boston, MA 02110-1301, USA. */ #pragma once diff --git a/src/application.c b/src/application.c index 7fd6280..f7e5816 100644 --- a/src/application.c +++ b/src/application.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \mainpage libosmocore Documentation diff --git a/src/backtrace.c b/src/backtrace.c index a18bde0..60bd238 100644 --- a/src/backtrace.c +++ b/src/backtrace.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/base64.c b/src/base64.c index d86573e..0c161ce 100644 --- a/src/base64.c +++ b/src/base64.c @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/bitcomp.c b/src/bitcomp.c index 6f2fb62..5fb2cba 100644 --- a/src/bitcomp.c +++ b/src/bitcomp.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup bitcomp Bit compression diff --git a/src/bits.c b/src/bits.c index aa11753..4b413a3 100644 --- a/src/bits.c +++ b/src/bits.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/bitvec.c b/src/bitvec.c index 13deeff..6a54344 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup bitvec diff --git a/src/codec/ecu.c b/src/codec/ecu.c index db7148c..59194ae 100644 --- a/src/codec/ecu.c +++ b/src/codec/ecu.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* As the developer and copyright holder of the related code, I hereby diff --git a/src/codec/ecu_fr.c b/src/codec/ecu_fr.c index 4545172..218d837 100644 --- a/src/codec/ecu_fr.c +++ b/src/codec/ecu_fr.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/codec/gsm610.c b/src/codec/gsm610.c index a05eaba..ff9952a 100644 --- a/src/codec/gsm610.c +++ b/src/codec/gsm610.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/codec/gsm620.c b/src/codec/gsm620.c index 282781f..cf7cfd7 100644 --- a/src/codec/gsm620.c +++ b/src/codec/gsm620.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/codec/gsm660.c b/src/codec/gsm660.c index 4f7bb09..34b10de 100644 --- a/src/codec/gsm660.c +++ b/src/codec/gsm660.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/codec/gsm690.c b/src/codec/gsm690.c index cc6cdf0..3b2e669 100644 --- a/src/codec/gsm690.c +++ b/src/codec/gsm690.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 9c189cd..835a18e 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/coding/gsm0503_interleaving.c b/src/coding/gsm0503_interleaving.c index d5008d0..7809e83 100644 --- a/src/coding/gsm0503_interleaving.c +++ b/src/coding/gsm0503_interleaving.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/coding/gsm0503_mapping.c b/src/coding/gsm0503_mapping.c index f7532eb..04acfd0 100644 --- a/src/coding/gsm0503_mapping.c +++ b/src/coding/gsm0503_mapping.c @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/coding/gsm0503_parity.c b/src/coding/gsm0503_parity.c index a8daacc..ef71d35 100644 --- a/src/coding/gsm0503_parity.c +++ b/src/coding/gsm0503_parity.c @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/coding/gsm0503_tables.c b/src/coding/gsm0503_tables.c index df0abee..25ea2fa 100644 --- a/src/coding/gsm0503_tables.c +++ b/src/coding/gsm0503_tables.c @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/context.c b/src/context.c index bad012b..8ab6f87 100644 --- a/src/context.c +++ b/src/context.c @@ -15,11 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include #include diff --git a/src/conv.c b/src/conv.c index 06c4299..0e07e1f 100644 --- a/src/conv.c +++ b/src/conv.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup conv diff --git a/src/conv_acc.c b/src/conv_acc.c index 0f6f7ca..a26ed3b 100644 --- a/src/conv_acc.c +++ b/src/conv_acc.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/conv_acc_generic.c b/src/conv_acc_generic.c index 2887673..2257e6a 100644 --- a/src/conv_acc_generic.c +++ b/src/conv_acc_generic.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/conv_acc_neon.c b/src/conv_acc_neon.c index 7244946..fb180e3 100644 --- a/src/conv_acc_neon.c +++ b/src/conv_acc_neon.c @@ -18,10 +18,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/conv_acc_neon_impl.h b/src/conv_acc_neon_impl.h index 4471127..8a78c75 100644 --- a/src/conv_acc_neon_impl.h +++ b/src/conv_acc_neon_impl.h @@ -18,10 +18,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /* Some distributions (notably Alpine Linux) for some strange reason diff --git a/src/conv_acc_sse.c b/src/conv_acc_sse.c index 63d8722..513ab05 100644 --- a/src/conv_acc_sse.c +++ b/src/conv_acc_sse.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/conv_acc_sse_avx.c b/src/conv_acc_sse_avx.c index 5ac3c16..82b4fa6 100644 --- a/src/conv_acc_sse_avx.c +++ b/src/conv_acc_sse_avx.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/conv_acc_sse_impl.h b/src/conv_acc_sse_impl.h index 9ebbfe9..807dbe5 100644 --- a/src/conv_acc_sse_impl.h +++ b/src/conv_acc_sse_impl.h @@ -18,10 +18,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /* Some distributions (notably Alpine Linux) for some strange reason diff --git a/src/counter.c b/src/counter.c index 0fa3166..cbee7b9 100644 --- a/src/counter.c +++ b/src/counter.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/crcXXgen.c.tpl b/src/crcXXgen.c.tpl index 74e6d52..154291c 100644 --- a/src/crcXXgen.c.tpl +++ b/src/crcXXgen.c.tpl @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup crc diff --git a/src/ctrl/control_cmd.c b/src/ctrl/control_cmd.c index e67df67..b069ca4 100644 --- a/src/ctrl/control_cmd.c +++ b/src/ctrl/control_cmd.c @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c index bea8496..37e430f 100644 --- a/src/ctrl/control_if.c +++ b/src/ctrl/control_if.c @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/ctrl/control_vty.c b/src/ctrl/control_vty.c index e141a4c..6910d4c 100644 --- a/src/ctrl/control_vty.c +++ b/src/ctrl/control_vty.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/exec.c b/src/exec.c index 2a03ba8..fd63d85 100644 --- a/src/exec.c +++ b/src/exec.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/fsm.c b/src/fsm.c index 8f7ff1a..8b0b27b 100644 --- a/src/fsm.c +++ b/src/fsm.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/gsm/a5.c b/src/gsm/a5.c index 223d3ad..d223cb7 100644 --- a/src/gsm/a5.c +++ b/src/gsm/a5.c @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup a5 diff --git a/src/gsm/auth_comp128v1.c b/src/gsm/auth_comp128v1.c index 493ebfd..ba3cf60 100644 --- a/src/gsm/auth_comp128v1.c +++ b/src/gsm/auth_comp128v1.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/auth_comp128v23.c b/src/gsm/auth_comp128v23.c index 279d2b7..91fb259 100644 --- a/src/gsm/auth_comp128v23.c +++ b/src/gsm/auth_comp128v23.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/auth_core.c b/src/gsm/auth_core.c index 9e750a0..f450850 100644 --- a/src/gsm/auth_core.c +++ b/src/gsm/auth_core.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/gsm/auth_milenage.c b/src/gsm/auth_milenage.c index 9589100..4a430b3 100644 --- a/src/gsm/auth_milenage.c +++ b/src/gsm/auth_milenage.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/auth_xor.c b/src/gsm/auth_xor.c index 36e006e..4507542 100644 --- a/src/gsm/auth_xor.c +++ b/src/gsm/auth_xor.c @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/bsslap.c b/src/gsm/bsslap.c index 7886da6..7b31d1f 100644 --- a/src/gsm/bsslap.c +++ b/src/gsm/bsslap.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/bssmap_le.c b/src/gsm/bssmap_le.c index 7954653..fa0f254 100644 --- a/src/gsm/bssmap_le.c +++ b/src/gsm/bssmap_le.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/bts_features.c b/src/gsm/bts_features.c index 614758b..88a6fc3 100644 --- a/src/gsm/bts_features.c +++ b/src/gsm/bts_features.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/gsm/cbsp.c b/src/gsm/cbsp.c index 353f53f..e340ebe 100644 --- a/src/gsm/cbsp.c +++ b/src/gsm/cbsp.c @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include "config.h" diff --git a/src/gsm/comp128.c b/src/gsm/comp128.c index b28a843..e252b04 100644 --- a/src/gsm/comp128.c +++ b/src/gsm/comp128.c @@ -58,10 +58,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/comp128v23.c b/src/gsm/comp128v23.c index 550f6a4..0947017 100644 --- a/src/gsm/comp128v23.c +++ b/src/gsm/comp128v23.c @@ -23,10 +23,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/gea.c b/src/gsm/gea.c index 5756bb0..aedc898 100644 --- a/src/gsm/gea.c +++ b/src/gsm/gea.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/gsm/gprs_cipher_core.c b/src/gsm/gprs_cipher_core.c index 7f2b1a5..97e581d 100644 --- a/src/gsm/gprs_cipher_core.c +++ b/src/gsm/gprs_cipher_core.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/gsm/gprs_gea.c b/src/gsm/gprs_gea.c index 7314788..eae1cf1 100644 --- a/src/gsm/gprs_gea.c +++ b/src/gsm/gprs_gea.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/gsm/gsm0341.c b/src/gsm/gsm0341.c index 89f5de3..a6238b3 100644 --- a/src/gsm/gsm0341.c +++ b/src/gsm/gsm0341.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c index 1d5cde9..7a7f71f 100644 --- a/src/gsm/gsm0480.c +++ b/src/gsm/gsm0480.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c index 158c490..4f9c687 100644 --- a/src/gsm/gsm0808.c +++ b/src/gsm/gsm0808.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/gsm23003.c b/src/gsm/gsm23003.c index f3c0123..71d44fb 100644 --- a/src/gsm/gsm23003.c +++ b/src/gsm/gsm23003.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/gsm23236.c b/src/gsm/gsm23236.c index d4a14a5..4a83ec8 100644 --- a/src/gsm/gsm23236.c +++ b/src/gsm/gsm23236.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/gsm29118.c b/src/gsm/gsm29118.c index 2c02b2f..0ca5b52 100644 --- a/src/gsm/gsm29118.c +++ b/src/gsm/gsm29118.c @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/gsm/gsm29205.c b/src/gsm/gsm29205.c index 6ceb8ee..8fed020 100644 --- a/src/gsm/gsm29205.c +++ b/src/gsm/gsm29205.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 44ce776..30bba91 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c index 6070e5c..6d40bec 100644 --- a/src/gsm/gsm48_ie.c +++ b/src/gsm/gsm48_ie.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c index 9125b0e..f8bb58e 100644 --- a/src/gsm/gsm_utils.c +++ b/src/gsm/gsm_utils.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \mainpage libosmogsm Documentation diff --git a/src/gsm/i460_mux.c b/src/gsm/i460_mux.c index 91ab2a1..a6a0835 100644 --- a/src/gsm/i460_mux.c +++ b/src/gsm/i460_mux.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/gsm/kasumi.c b/src/gsm/kasumi.c index f93c002..78885bd 100644 --- a/src/gsm/kasumi.c +++ b/src/gsm/kasumi.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/kdf.c b/src/gsm/kdf.c index 2ebe41a..6982f6f 100644 --- a/src/gsm/kdf.c +++ b/src/gsm/kdf.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/lapd_core.c b/src/gsm/lapd_core.c index e0c232f..0e89874 100644 --- a/src/gsm/lapd_core.c +++ b/src/gsm/lapd_core.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup lapd diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c index 8620cab..e7d46e6 100644 --- a/src/gsm/lapdm.c +++ b/src/gsm/lapdm.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup lapdm diff --git a/src/gsm/rsl.c b/src/gsm/rsl.c index e648d82..f535b7f 100644 --- a/src/gsm/rsl.c +++ b/src/gsm/rsl.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/rxlev_stat.c b/src/gsm/rxlev_stat.c index 9c650cc..f1b77f4 100644 --- a/src/gsm/rxlev_stat.c +++ b/src/gsm/rxlev_stat.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsmtap_util.c b/src/gsmtap_util.c index e5adb2f..671a6c3 100644 --- a/src/gsmtap_util.c +++ b/src/gsmtap_util.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "../config.h" diff --git a/src/isdnhdlc.c b/src/isdnhdlc.c index 58b4a66..8ec1c95 100644 --- a/src/isdnhdlc.c +++ b/src/isdnhdlc.c @@ -18,10 +18,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ #include diff --git a/src/it_q.c b/src/it_q.c index 1bb0e15..fda6c1f 100644 --- a/src/it_q.c +++ b/src/it_q.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ /*! \addtogroup it_q diff --git a/src/logging.c b/src/logging.c index b6c26d2..9497f28 100644 --- a/src/logging.c +++ b/src/logging.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup logging diff --git a/src/logging_gsmtap.c b/src/logging_gsmtap.c index e190f88..cc95388 100644 --- a/src/logging_gsmtap.c +++ b/src/logging_gsmtap.c @@ -21,10 +21,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup logging diff --git a/src/logging_syslog.c b/src/logging_syslog.c index f980689..2090856 100644 --- a/src/logging_syslog.c +++ b/src/logging_syslog.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup logging diff --git a/src/logging_systemd.c b/src/logging_systemd.c index 7c96686..2e86feb 100644 --- a/src/logging_systemd.c +++ b/src/logging_systemd.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup logging diff --git a/src/loggingrb.c b/src/loggingrb.c index 4a80cc8..2bf7b66 100644 --- a/src/loggingrb.c +++ b/src/loggingrb.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup loggingrb diff --git a/src/macaddr.c b/src/macaddr.c index 56fdf86..3b231fb 100644 --- a/src/macaddr.c +++ b/src/macaddr.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup utils diff --git a/src/mnl.c b/src/mnl.c index a7d3511..f32367d 100644 --- a/src/mnl.c +++ b/src/mnl.c @@ -21,11 +21,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/msgb.c b/src/msgb.c index fbb157a..ccb55aa 100644 --- a/src/msgb.c +++ b/src/msgb.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup msgb diff --git a/src/msgfile.c b/src/msgfile.c index 1f11aa6..abb4e7c 100644 --- a/src/msgfile.c +++ b/src/msgfile.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #define _WITH_GETLINE diff --git a/src/panic.c b/src/panic.c index 072f458..6c92522 100644 --- a/src/panic.c +++ b/src/panic.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup utils diff --git a/src/plugin.c b/src/plugin.c index 40de4f8..5f44a40 100644 --- a/src/plugin.c +++ b/src/plugin.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup utils diff --git a/src/rate_ctr.c b/src/rate_ctr.c index 283858d..ffae1b8 100644 --- a/src/rate_ctr.c +++ b/src/rate_ctr.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup rate_ctr diff --git a/src/rbtree.c b/src/rbtree.c index 211978f..f4dc219 100644 --- a/src/rbtree.c +++ b/src/rbtree.c @@ -15,11 +15,6 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - MA 02110-1301, USA - linux/lib/rbtree.c */ diff --git a/src/select.c b/src/select.c index f7eb5ea..590c3db 100644 --- a/src/select.c +++ b/src/select.c @@ -18,11 +18,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/sercomm.c b/src/sercomm.c index 2639bf8..1798ace 100644 --- a/src/sercomm.c +++ b/src/sercomm.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup sercomm diff --git a/src/serial.c b/src/serial.c index c3bf5e8..117c049 100644 --- a/src/serial.c +++ b/src/serial.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup serial diff --git a/src/signal.c b/src/signal.c index be3b777..ba1555a 100644 --- a/src/signal.c +++ b/src/signal.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/sim/card_fs_hpsim.c b/src/sim/card_fs_hpsim.c index 4a5f7d9..2c115b7 100644 --- a/src/sim/card_fs_hpsim.c +++ b/src/sim/card_fs_hpsim.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sim/card_fs_isim.c b/src/sim/card_fs_isim.c index f11c029..1a38da2 100644 --- a/src/sim/card_fs_isim.c +++ b/src/sim/card_fs_isim.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sim/card_fs_sim.c b/src/sim/card_fs_sim.c index 55ce9af..f07a237 100644 --- a/src/sim/card_fs_sim.c +++ b/src/sim/card_fs_sim.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/sim/card_fs_tetra.c b/src/sim/card_fs_tetra.c index 12853a5..597e38b 100644 --- a/src/sim/card_fs_tetra.c +++ b/src/sim/card_fs_tetra.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/sim/card_fs_uicc.c b/src/sim/card_fs_uicc.c index 5dcaaa1..87def0e 100644 --- a/src/sim/card_fs_uicc.c +++ b/src/sim/card_fs_uicc.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sim/card_fs_usim.c b/src/sim/card_fs_usim.c index 8f880e7..8cff3fc 100644 --- a/src/sim/card_fs_usim.c +++ b/src/sim/card_fs_usim.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sim/class_tables.c b/src/sim/class_tables.c index 6f541ee..534ef53 100644 --- a/src/sim/class_tables.c +++ b/src/sim/class_tables.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include diff --git a/src/sim/core.c b/src/sim/core.c index d11c2d8..fa17e12 100644 --- a/src/sim/core.c +++ b/src/sim/core.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sim/reader.c b/src/sim/reader.c index 7f3f18d..b41b730 100644 --- a/src/sim/reader.c +++ b/src/sim/reader.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sim/reader_pcsc.c b/src/sim/reader_pcsc.c index fa867c0..c37072e 100644 --- a/src/sim/reader_pcsc.c +++ b/src/sim/reader_pcsc.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sockaddr_str.c b/src/sockaddr_str.c index f5508a0..9f1e897 100644 --- a/src/sockaddr_str.c +++ b/src/sockaddr_str.c @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/socket.c b/src/socket.c index 45b0f5b..1251061 100644 --- a/src/socket.c +++ b/src/socket.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "../config.h" diff --git a/src/stat_item.c b/src/stat_item.c index 59f5935..1f398d5 100644 --- a/src/stat_item.c +++ b/src/stat_item.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup osmo_stat_item diff --git a/src/stats.c b/src/stats.c index 702e408..4fb20e2 100644 --- a/src/stats.c +++ b/src/stats.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup stats diff --git a/src/stats_statsd.c b/src/stats_statsd.c index 1acfce8..b89ec92 100644 --- a/src/stats_statsd.c +++ b/src/stats_statsd.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup stats diff --git a/src/strrb.c b/src/strrb.c index 461fdec..df7edb3 100644 --- a/src/strrb.c +++ b/src/strrb.c @@ -31,10 +31,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup utils diff --git a/src/thread.c b/src/thread.c index 956fee7..d9a9842 100644 --- a/src/thread.c +++ b/src/thread.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup thread diff --git a/src/timer.c b/src/timer.c index ed5a610..20d87a0 100644 --- a/src/timer.c +++ b/src/timer.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/timer_clockgettime.c b/src/timer_clockgettime.c index 7b17fd1..6112b8a 100644 --- a/src/timer_clockgettime.c +++ b/src/timer_clockgettime.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup timer diff --git a/src/timer_gettimeofday.c b/src/timer_gettimeofday.c index 3494946..e0212b5 100644 --- a/src/timer_gettimeofday.c +++ b/src/timer_gettimeofday.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup timer diff --git a/src/usb/osmo_libusb.c b/src/usb/osmo_libusb.c index bb86206..05331a1 100644 --- a/src/usb/osmo_libusb.c +++ b/src/usb/osmo_libusb.c @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include #include diff --git a/src/use_count.c b/src/use_count.c index d07e47f..6c52899 100644 --- a/src/use_count.c +++ b/src/use_count.c @@ -19,10 +19,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/utils.c b/src/utils.c index 300204a..bec4b75 100644 --- a/src/utils.c +++ b/src/utils.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/vty/fsm_vty.c b/src/vty/fsm_vty.c index 83a8e79..025d0d8 100644 --- a/src/vty/fsm_vty.c +++ b/src/vty/fsm_vty.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index d33fe5e..4e5725b 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index c6c50ef..e2247a3 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/vty/talloc_ctx_vty.c b/src/vty/talloc_ctx_vty.c index 206d049..dcb1c9b 100644 --- a/src/vty/talloc_ctx_vty.c +++ b/src/vty/talloc_ctx_vty.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c index cd32e68..374578c 100644 --- a/src/vty/telnet_interface.c +++ b/src/vty/telnet_interface.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/vty/utils.c b/src/vty/utils.c index 4501c66..696a519 100644 --- a/src/vty/utils.c +++ b/src/vty/utils.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/vty/vector.c b/src/vty/vector.c index f9e5ec3..34b161d 100644 --- a/src/vty/vector.c +++ b/src/vty/vector.c @@ -16,11 +16,6 @@ * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with GNU Zebra; see the file COPYING. If not, write to the Free - * Software Foundation, Inc., 51 Franklin Street, Fifth Floor, - * Boston, MA 02110-1301, USA. */ #include diff --git a/src/write_queue.c b/src/write_queue.c index 31b8427..884cebd 100644 --- a/src/write_queue.c +++ b/src/write_queue.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/abis/abis_test.c b/tests/abis/abis_test.c index ca6daed..2151e92 100644 --- a/tests/abis/abis_test.c +++ b/tests/abis/abis_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/coding/coding_test.c b/tests/coding/coding_test.c index bdfe300..5a6f6e0 100644 --- a/tests/coding/coding_test.c +++ b/tests/coding/coding_test.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/tests/dtx/dtx_gsm0503_test.c b/tests/dtx/dtx_gsm0503_test.c index f300313..b14c978 100644 --- a/tests/dtx/dtx_gsm0503_test.c +++ b/tests/dtx/dtx_gsm0503_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/fr/fr_test.c b/tests/fr/fr_test.c index 4d472b5..3fb18f3 100644 --- a/tests/fr/fr_test.c +++ b/tests/fr/fr_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #define _GNU_SOURCE diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index 5a59639..cdccf53 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma GCC diagnostic ignored "-Wdeprecated-declarations" diff --git a/tests/gsm0502/gsm0502_test.c b/tests/gsm0502/gsm0502_test.c index a950c6c..f4f6530 100644 --- a/tests/gsm0502/gsm0502_test.c +++ b/tests/gsm0502/gsm0502_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c index 04b3b72..3fff005 100644 --- a/tests/gsm0808/gsm0808_test.c +++ b/tests/gsm0808/gsm0808_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/gsm23003/gsm23003_test.c b/tests/gsm23003/gsm23003_test.c index eac5a11..e73ef43 100644 --- a/tests/gsm23003/gsm23003_test.c +++ b/tests/gsm23003/gsm23003_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/gsm23236/gsm23236_test.c b/tests/gsm23236/gsm23236_test.c index 14c5ce3..77e20e3 100644 --- a/tests/gsm23236/gsm23236_test.c +++ b/tests/gsm23236/gsm23236_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/gsm29205/gsm29205_test.c b/tests/gsm29205/gsm29205_test.c index 44c3453..5d4835b 100644 --- a/tests/gsm29205/gsm29205_test.c +++ b/tests/gsm29205/gsm29205_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/gsm48/rest_octets_test.c b/tests/gsm48/rest_octets_test.c index beff6e4..fdab143 100644 --- a/tests/gsm48/rest_octets_test.c +++ b/tests/gsm48/rest_octets_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/lapd/lapd_test.c b/tests/lapd/lapd_test.c index 48851f4..ab0f316 100644 --- a/tests/lapd/lapd_test.c +++ b/tests/lapd/lapd_test.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/logging/logging_test.c b/tests/logging/logging_test.c index f873958..ac6fc52 100644 --- a/tests/logging/logging_test.c +++ b/tests/logging/logging_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/logging/logging_vty_test.c b/tests/logging/logging_vty_test.c index 078555e..f67746b 100644 --- a/tests/logging/logging_vty_test.c +++ b/tests/logging/logging_vty_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #define _GNU_SOURCE diff --git a/tests/loggingrb/loggingrb_test.c b/tests/loggingrb/loggingrb_test.c index 19378c3..fd11896 100644 --- a/tests/loggingrb/loggingrb_test.c +++ b/tests/loggingrb/loggingrb_test.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/msgb/msgb_test.c b/tests/msgb/msgb_test.c index ffaa155..aebb68c 100644 --- a/tests/msgb/msgb_test.c +++ b/tests/msgb/msgb_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/msgfile/msgfile_test.c b/tests/msgfile/msgfile_test.c index 2684b6a..3fe173d 100644 --- a/tests/msgfile/msgfile_test.c +++ b/tests/msgfile/msgfile_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/oap/oap_test.c b/tests/oap/oap_test.c index 32676ca..bebd603 100644 --- a/tests/oap/oap_test.c +++ b/tests/oap/oap_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/sercomm/sercomm_test.c b/tests/sercomm/sercomm_test.c index 058c9eb..9bffc0d 100644 --- a/tests/sercomm/sercomm_test.c +++ b/tests/sercomm/sercomm_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/sim/sim_test.c b/tests/sim/sim_test.c index 425ce11..2e2eec5 100644 --- a/tests/sim/sim_test.c +++ b/tests/sim/sim_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/sms/sms_test.c b/tests/sms/sms_test.c index 3e14529..9ca83a5 100644 --- a/tests/sms/sms_test.c +++ b/tests/sms/sms_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/smscb/gsm0341_test.c b/tests/smscb/gsm0341_test.c index c400f5c..d11336f 100644 --- a/tests/smscb/gsm0341_test.c +++ b/tests/smscb/gsm0341_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/smscb/smscb_test.c b/tests/smscb/smscb_test.c index 5925f69..3b6b74d 100644 --- a/tests/smscb/smscb_test.c +++ b/tests/smscb/smscb_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/sockaddr_str/sockaddr_str_test.c b/tests/sockaddr_str/sockaddr_str_test.c index 64a6104..0d0674b 100644 --- a/tests/sockaddr_str/sockaddr_str_test.c +++ b/tests/sockaddr_str/sockaddr_str_test.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/socket/socket_sctp_test.c b/tests/socket/socket_sctp_test.c index 4ca52a3..b318fe5 100644 --- a/tests/socket/socket_sctp_test.c +++ b/tests/socket/socket_sctp_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/socket/socket_test.c b/tests/socket/socket_test.c index 614db55..eda716a 100644 --- a/tests/socket/socket_test.c +++ b/tests/socket/socket_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/stats/stats_test.c b/tests/stats/stats_test.c index 3aa1f52..4e36223 100644 --- a/tests/stats/stats_test.c +++ b/tests/stats/stats_test.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/strrb/strrb_test.c b/tests/strrb/strrb_test.c index 4282d1a..cdeaa34 100644 --- a/tests/strrb/strrb_test.c +++ b/tests/strrb/strrb_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/tdef/tdef_test.c b/tests/tdef/tdef_test.c index d188eed..a2beb6a 100644 --- a/tests/tdef/tdef_test.c +++ b/tests/tdef/tdef_test.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/tests/tdef/tdef_vty_config_root_test.c b/tests/tdef/tdef_vty_config_root_test.c index 0472ad5..aa5ff1b 100644 --- a/tests/tdef/tdef_vty_config_root_test.c +++ b/tests/tdef/tdef_vty_config_root_test.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #define _GNU_SOURCE diff --git a/tests/tdef/tdef_vty_config_subnode_test.c b/tests/tdef/tdef_vty_config_subnode_test.c index ff19150..90c7968 100644 --- a/tests/tdef/tdef_vty_config_subnode_test.c +++ b/tests/tdef/tdef_vty_config_subnode_test.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #define _GNU_SOURCE diff --git a/tests/tdef/tdef_vty_dynamic_test.c b/tests/tdef/tdef_vty_dynamic_test.c index 20dae53..a181d91 100644 --- a/tests/tdef/tdef_vty_dynamic_test.c +++ b/tests/tdef/tdef_vty_dynamic_test.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #define _GNU_SOURCE diff --git a/tests/timer/clk_override_test.c b/tests/timer/clk_override_test.c index 308e821..e67a6ed 100644 --- a/tests/timer/clk_override_test.c +++ b/tests/timer/clk_override_test.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/timer/timer_test.c b/tests/timer/timer_test.c index d2b0204..b06c774 100644 --- a/tests/timer/timer_test.c +++ b/tests/timer/timer_test.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/use_count/use_count_test.c b/tests/use_count/use_count_test.c index 95af308..2942c69 100644 --- a/tests/use_count/use_count_test.c +++ b/tests/use_count/use_count_test.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/tests/ussd/ussd_test.c b/tests/ussd/ussd_test.c index 8025071..2b8321d 100644 --- a/tests/ussd/ussd_test.c +++ b/tests/ussd/ussd_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/utils/utils_test.c b/tests/utils/utils_test.c index 7e0e3d3..3ac5d1e 100644 --- a/tests/utils/utils_test.c +++ b/tests/utils/utils_test.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/vty/vty_test.c b/tests/vty/vty_test.c index e068f19..c84e4c9 100644 --- a/tests/vty/vty_test.c +++ b/tests/vty/vty_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/vty/vty_transcript_test.c b/tests/vty/vty_transcript_test.c index c9ecf18..84664f9 100644 --- a/tests/vty/vty_transcript_test.c +++ b/tests/vty/vty_transcript_test.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #define _GNU_SOURCE diff --git a/utils/conv_gen.py b/utils/conv_gen.py index d2eda15..27ffe62 100644 --- a/utils/conv_gen.py +++ b/utils/conv_gen.py @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/utils/osmo-arfcn.c b/utils/osmo-arfcn.c index 5f138f8..9e4534f 100644 --- a/utils/osmo-arfcn.c +++ b/utils/osmo-arfcn.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/utils/osmo-auc-gen.c b/utils/osmo-auc-gen.c index 446d8ec..72f1fcd 100644 --- a/utils/osmo-auc-gen.c +++ b/utils/osmo-auc-gen.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/utils/osmo-config-merge.c b/utils/osmo-config-merge.c index 477bb02..ed2039a 100644 --- a/utils/osmo-config-merge.c +++ b/utils/osmo-config-merge.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* diff --git a/utils/osmo-sim-test.c b/utils/osmo-sim-test.c index ae55b83..2c6c764 100644 --- a/utils/osmo-sim-test.c +++ b/utils/osmo-sim-test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26550 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5050285e75cf120407a1d883e99b3c4bcae8ffd7 Gerrit-Change-Number: 26550 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:26:48 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:26:48 +0000 Subject: Change in osmo-bsc[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26551 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: Ifbbafe185931c0f508ff8148ef244f25a9620fd8 --- M src/osmo-bsc/bsc_ctrl_lookup.c M src/osmo-bsc/pcu_sock.c 2 files changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/26551/1 diff --git a/src/osmo-bsc/bsc_ctrl_lookup.c b/src/osmo-bsc/bsc_ctrl_lookup.c index 4328d76..6a11e32 100644 --- a/src/osmo-bsc/bsc_ctrl_lookup.c +++ b/src/osmo-bsc/bsc_ctrl_lookup.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index 6f7ee77..d6dd9a7 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifbbafe185931c0f508ff8148ef244f25a9620fd8 Gerrit-Change-Number: 26551 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:26:54 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:26:54 +0000 Subject: Change in osmo-bts[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26552 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I12b250e16426b125124def49e124e40ae93d0d58 --- M src/common/pcu_sock.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/52/26552/1 diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 0018acb..94b45f3 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26552 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I12b250e16426b125124def49e124e40ae93d0d58 Gerrit-Change-Number: 26552 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:27:15 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:27:15 +0000 Subject: Change in osmo-hlr[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/26553 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I4b20c685b6370bf5dc472a42664e2665eb0d8f8c --- M src/dbd_decode_binary.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/53/26553/1 diff --git a/src/dbd_decode_binary.c b/src/dbd_decode_binary.c index e1a98ad..06dccbb 100644 --- a/src/dbd_decode_binary.c +++ b/src/dbd_decode_binary.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * * $Id: dbd_helper.c,v 1.44 2011/08/09 11:14:14 mhoenicka Exp $ */ -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/26553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4b20c685b6370bf5dc472a42664e2665eb0d8f8c Gerrit-Change-Number: 26553 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:27:26 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:27:26 +0000 Subject: Change in osmo-iuh[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26554 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I340ab63093138ada6e80edf322e401e9fbfef4ed --- M asn1/rua/eurecom/rua_decoder.c M asn1/rua/eurecom/rua_encoder.c M asn1/rua/eurecom/rua_ies_defs.h 3 files changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/54/26554/1 diff --git a/asn1/rua/eurecom/rua_decoder.c b/asn1/rua/eurecom/rua_decoder.c index 521ecab..aebf8d5 100644 --- a/asn1/rua/eurecom/rua_decoder.c +++ b/asn1/rua/eurecom/rua_decoder.c @@ -12,10 +12,6 @@ FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License along with - this program; if not, write to the Free Software Foundation, Inc., - 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. - The full GNU General Public License is included in this distribution in the file called "COPYING". diff --git a/asn1/rua/eurecom/rua_encoder.c b/asn1/rua/eurecom/rua_encoder.c index 56d0f33..4fc75b7 100644 --- a/asn1/rua/eurecom/rua_encoder.c +++ b/asn1/rua/eurecom/rua_encoder.c @@ -12,10 +12,6 @@ FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License along with - this program; if not, write to the Free Software Foundation, Inc., - 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. - The full GNU General Public License is included in this distribution in the file called "COPYING". diff --git a/asn1/rua/eurecom/rua_ies_defs.h b/asn1/rua/eurecom/rua_ies_defs.h index da5fc6f..74602ff 100644 --- a/asn1/rua/eurecom/rua_ies_defs.h +++ b/asn1/rua/eurecom/rua_ies_defs.h @@ -12,10 +12,6 @@ FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License along with - this program; if not, write to the Free Software Foundation, Inc., - 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. - The full GNU General Public License is included in this distribution in the file called "COPYING". -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I340ab63093138ada6e80edf322e401e9fbfef4ed Gerrit-Change-Number: 26554 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:27:33 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:27:33 +0000 Subject: Change in osmo-mgw[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26555 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I2a623f67e116d5e56091ae5860ca2a305c57e50a --- M contrib/ipa.py M src/libosmo-mgcp/g711common.h 2 files changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/55/26555/1 diff --git a/contrib/ipa.py b/contrib/ipa.py index 71cbf45..65e4003 100755 --- a/contrib/ipa.py +++ b/contrib/ipa.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/src/libosmo-mgcp/g711common.h b/src/libosmo-mgcp/g711common.h index cb35fc6..31ab3a4 100644 --- a/src/libosmo-mgcp/g711common.h +++ b/src/libosmo-mgcp/g711common.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ static inline int val_seg(int val) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26555 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2a623f67e116d5e56091ae5860ca2a305c57e50a Gerrit-Change-Number: 26555 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:27:42 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:27:42 +0000 Subject: Change in osmo-msc[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26556 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I1b68e0aa26d81fbfe26abaa287d2bd5eec2cfd0f --- M include/osmocom/msc/cell_id_list.h M src/libmsc/call_leg.c M src/libmsc/cell_id_list.c M src/libmsc/gsup_client_mux.c M src/libmsc/mncc_builtin.c M src/libmsc/mncc_sock.c M src/libmsc/msc_ho.c M src/libmsc/ran_msg.c M src/libmsc/ran_msg_a.c M src/libmsc/ran_msg_iu.c 10 files changed, 0 insertions(+), 40 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/56/26556/1 diff --git a/include/osmocom/msc/cell_id_list.h b/include/osmocom/msc/cell_id_list.h index 83d05f5..c6a7cbb 100644 --- a/include/osmocom/msc/cell_id_list.h +++ b/include/osmocom/msc/cell_id_list.h @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/src/libmsc/call_leg.c b/src/libmsc/call_leg.c index 056a392..6242a80 100644 --- a/src/libmsc/call_leg.c +++ b/src/libmsc/call_leg.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include #include diff --git a/src/libmsc/cell_id_list.c b/src/libmsc/cell_id_list.c index ca7a6d4..580b4f4 100644 --- a/src/libmsc/cell_id_list.c +++ b/src/libmsc/cell_id_list.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/libmsc/gsup_client_mux.c b/src/libmsc/gsup_client_mux.c index e425651..3d88349 100644 --- a/src/libmsc/gsup_client_mux.c +++ b/src/libmsc/gsup_client_mux.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/libmsc/mncc_builtin.c b/src/libmsc/mncc_builtin.c index cc3f55d..a711e07 100644 --- a/src/libmsc/mncc_builtin.c +++ b/src/libmsc/mncc_builtin.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/libmsc/mncc_sock.c b/src/libmsc/mncc_sock.c index b76855f..7c65546 100644 --- a/src/libmsc/mncc_sock.c +++ b/src/libmsc/mncc_sock.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c index 6b8960e..7e7905b 100644 --- a/src/libmsc/msc_ho.c +++ b/src/libmsc/msc_ho.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/libmsc/ran_msg.c b/src/libmsc/ran_msg.c index 46816a9..e050303 100644 --- a/src/libmsc/ran_msg.c +++ b/src/libmsc/ran_msg.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c index b50259d..be026e5 100644 --- a/src/libmsc/ran_msg_a.c +++ b/src/libmsc/ran_msg_a.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index b894df2..c10df4d 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1b68e0aa26d81fbfe26abaa287d2bd5eec2cfd0f Gerrit-Change-Number: 26556 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:27:48 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:27:48 +0000 Subject: Change in osmo-pcu[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26557 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I4a49dbeeec89b22624c968152118aecf8886dac6 --- M src/bts.h M src/coding_scheme.c M src/coding_scheme.h M src/csn1.c M src/csn1.h M src/csn1_dec.c M src/csn1_enc.c M src/cxx_linuxlist.h M src/decoding.cpp M src/decoding.h M src/encoding.cpp M src/encoding.h M src/gprs_bssgp_pcu.c M src/gprs_bssgp_pcu.h M src/gprs_bssgp_rim.c M src/gprs_bssgp_rim.h M src/gprs_codel.c M src/gprs_codel.h M src/gprs_debug.cpp M src/gprs_debug.h M src/gprs_ms.c M src/gprs_ms.h M src/gprs_ms_storage.cpp M src/gprs_ms_storage.h M src/gprs_rlcmac.cpp M src/gprs_rlcmac.h M src/gprs_rlcmac_meas.cpp M src/gprs_rlcmac_sched.cpp M src/gprs_rlcmac_ts_alloc.cpp M src/gsm_rlcmac.c M src/gsm_rlcmac.h M src/llc.cpp M src/llc.h M src/mslot_class.c M src/mslot_class.h M src/nacc_fsm.c M src/nacc_fsm.h M src/neigh_cache.c M src/neigh_cache.h M src/osmobts_sock.c M src/pcu_l1_if.cpp M src/pcu_l1_if.h M src/pcu_main.cpp M src/pcu_utils.h M src/pcu_vty_functions.cpp M src/pcu_vty_functions.h M src/pdch.h M src/pdch_ul_controller.c M src/pdch_ul_controller.h M src/rlc.cpp M src/rlc.h M src/sba.c M src/sba.h M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_dl.h M src/tbf_dl_ass_fsm.c M src/tbf_dl_ass_fsm.h M src/tbf_fsm.c M src/tbf_fsm.h M src/tbf_ul.cpp M src/tbf_ul.h M src/tbf_ul_ack_fsm.c M src/tbf_ul_ack_fsm.h M src/tbf_ul_ass_fsm.c M src/tbf_ul_ass_fsm.h M src/wireshark_compat.h M tests/alloc/AllocTest.cpp M tests/alloc/MslotTest.cpp M tests/app_info/AppInfoTest.cpp M tests/rlcmac/RLCMACTest.cpp 72 files changed, 0 insertions(+), 288 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/57/26557/1 diff --git a/src/bts.h b/src/bts.h index 6bf62c7..d2b1f9f 100644 --- a/src/bts.h +++ b/src/bts.h @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/coding_scheme.c b/src/coding_scheme.c index 27241d1..c370c4b 100644 --- a/src/coding_scheme.c +++ b/src/coding_scheme.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/coding_scheme.h b/src/coding_scheme.h index 1b21265..fdecf1c 100644 --- a/src/coding_scheme.h +++ b/src/coding_scheme.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/csn1.c b/src/csn1.c index e165e92..a9b1343 100644 --- a/src/csn1.c +++ b/src/csn1.c @@ -22,10 +22,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/csn1.h b/src/csn1.h index 285ae99..47956c3 100644 --- a/src/csn1.h +++ b/src/csn1.h @@ -19,10 +19,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #ifndef _PACKET_CSN1_H_ diff --git a/src/csn1_dec.c b/src/csn1_dec.c index 6892dde..f0d07ac 100644 --- a/src/csn1_dec.c +++ b/src/csn1_dec.c @@ -22,10 +22,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/csn1_enc.c b/src/csn1_enc.c index 5518d06..e4e5e09 100644 --- a/src/csn1_enc.c +++ b/src/csn1_enc.c @@ -22,10 +22,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/cxx_linuxlist.h b/src/cxx_linuxlist.h index 9a74b3f..1562bfe 100644 --- a/src/cxx_linuxlist.h +++ b/src/cxx_linuxlist.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/decoding.cpp b/src/decoding.cpp index 0caa8bf..ca0c720 100644 --- a/src/decoding.cpp +++ b/src/decoding.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include #include diff --git a/src/decoding.h b/src/decoding.h index 7270c3d..b0a5aed 100644 --- a/src/decoding.h +++ b/src/decoding.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/encoding.cpp b/src/encoding.cpp index 30b0ee1..4737137 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/encoding.h b/src/encoding.h index 998e69a..fd2225e 100644 --- a/src/encoding.h +++ b/src/encoding.h @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c index 8cb5302..bf82fc4 100644 --- a/src/gprs_bssgp_pcu.c +++ b/src/gprs_bssgp_pcu.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/gprs_bssgp_pcu.h b/src/gprs_bssgp_pcu.h index 907e666..0c0f091 100644 --- a/src/gprs_bssgp_pcu.h +++ b/src/gprs_bssgp_pcu.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #ifndef GPRS_BSSGP_PCU_H diff --git a/src/gprs_bssgp_rim.c b/src/gprs_bssgp_rim.c index f1679a6..033426b 100644 --- a/src/gprs_bssgp_rim.c +++ b/src/gprs_bssgp_rim.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/gprs_bssgp_rim.h b/src/gprs_bssgp_rim.h index 5fac56f..cf46b0e 100644 --- a/src/gprs_bssgp_rim.h +++ b/src/gprs_bssgp_rim.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/gprs_codel.c b/src/gprs_codel.c index 7c3b2d4..9c5737f 100644 --- a/src/gprs_codel.c +++ b/src/gprs_codel.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include "gprs_codel.h" diff --git a/src/gprs_codel.h b/src/gprs_codel.h index 3ad7efc..10ba91f 100644 --- a/src/gprs_codel.h +++ b/src/gprs_codel.h @@ -19,10 +19,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/gprs_debug.cpp b/src/gprs_debug.cpp index 0cbc488..61c1c87 100644 --- a/src/gprs_debug.cpp +++ b/src/gprs_debug.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ extern "C" { diff --git a/src/gprs_debug.h b/src/gprs_debug.h index cebeabc..b683a63 100644 --- a/src/gprs_debug.h +++ b/src/gprs_debug.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 5e75d06..c10eda7 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ diff --git a/src/gprs_ms.h b/src/gprs_ms.h index c579cf5..3ebf7a5 100644 --- a/src/gprs_ms.h +++ b/src/gprs_ms.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/gprs_ms_storage.cpp b/src/gprs_ms_storage.cpp index db3a7f9..aa0fc9e 100644 --- a/src/gprs_ms_storage.cpp +++ b/src/gprs_ms_storage.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ diff --git a/src/gprs_ms_storage.h b/src/gprs_ms_storage.h index dcb6d8d..ef808d0 100644 --- a/src/gprs_ms_storage.h +++ b/src/gprs_ms_storage.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/gprs_rlcmac.cpp b/src/gprs_rlcmac.cpp index ffa656c..1ea0872 100644 --- a/src/gprs_rlcmac.cpp +++ b/src/gprs_rlcmac.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ extern "C" { diff --git a/src/gprs_rlcmac.h b/src/gprs_rlcmac.h index cf95c37..468712e 100644 --- a/src/gprs_rlcmac.h +++ b/src/gprs_rlcmac.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #ifndef GPRS_RLCMAC_H diff --git a/src/gprs_rlcmac_meas.cpp b/src/gprs_rlcmac_meas.cpp index b9a324f..d14f405 100644 --- a/src/gprs_rlcmac_meas.cpp +++ b/src/gprs_rlcmac_meas.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ extern "C" { diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp index 8867d43..8b5227f 100644 --- a/src/gprs_rlcmac_sched.cpp +++ b/src/gprs_rlcmac_sched.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp index a243d21..3a60839 100644 --- a/src/gprs_rlcmac_ts_alloc.cpp +++ b/src/gprs_rlcmac_ts_alloc.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/gsm_rlcmac.c b/src/gsm_rlcmac.c index 6793602..570c97b 100644 --- a/src/gsm_rlcmac.c +++ b/src/gsm_rlcmac.c @@ -23,10 +23,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/gsm_rlcmac.h b/src/gsm_rlcmac.h index 01e2ee6..c43d418 100644 --- a/src/gsm_rlcmac.h +++ b/src/gsm_rlcmac.h @@ -23,10 +23,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #ifndef __PACKET_GSM_RLCMAC_H__ diff --git a/src/llc.cpp b/src/llc.cpp index e508d0b..b118307 100644 --- a/src/llc.cpp +++ b/src/llc.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/llc.h b/src/llc.h index 13662d8..623ae49 100644 --- a/src/llc.h +++ b/src/llc.h @@ -10,10 +10,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/mslot_class.c b/src/mslot_class.c index ff40f29..1809cd7 100644 --- a/src/mslot_class.c +++ b/src/mslot_class.c @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/mslot_class.h b/src/mslot_class.h index 045fb31..7a6d5d4 100644 --- a/src/mslot_class.h +++ b/src/mslot_class.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/nacc_fsm.c b/src/nacc_fsm.c index ba7bbb7..c049f60 100644 --- a/src/nacc_fsm.c +++ b/src/nacc_fsm.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/nacc_fsm.h b/src/nacc_fsm.h index beea0f7..b33dafa 100644 --- a/src/nacc_fsm.h +++ b/src/nacc_fsm.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/neigh_cache.c b/src/neigh_cache.c index 3217f40..2f82fee 100644 --- a/src/neigh_cache.c +++ b/src/neigh_cache.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/neigh_cache.h b/src/neigh_cache.h index 90260cd..76706ab 100644 --- a/src/neigh_cache.h +++ b/src/neigh_cache.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/osmobts_sock.c b/src/osmobts_sock.c index 91b62a0..1cbd1a0 100644 --- a/src/osmobts_sock.c +++ b/src/osmobts_sock.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 8d9defc..d5672e5 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/pcu_l1_if.h b/src/pcu_l1_if.h index 7d48feb..1b13a92 100644 --- a/src/pcu_l1_if.h +++ b/src/pcu_l1_if.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #ifndef PCU_L1_IF_H diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp index fe391b9..0fb5ac8 100644 --- a/src/pcu_main.cpp +++ b/src/pcu_main.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/pcu_utils.h b/src/pcu_utils.h index e1a8572..1c698ca 100644 --- a/src/pcu_utils.h +++ b/src/pcu_utils.h @@ -10,10 +10,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once #ifdef __cplusplus diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp index c2cc950..1745eea 100644 --- a/src/pcu_vty_functions.cpp +++ b/src/pcu_vty_functions.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ /* OsmoBTS VTY interface */ diff --git a/src/pcu_vty_functions.h b/src/pcu_vty_functions.h index a68df27..172dffc 100644 --- a/src/pcu_vty_functions.h +++ b/src/pcu_vty_functions.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/pdch.h b/src/pdch.h index 759d7f9..cf4ac4e 100644 --- a/src/pdch.h +++ b/src/pdch.h @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/pdch_ul_controller.c b/src/pdch_ul_controller.c index 79a0339..7fbbc51 100644 --- a/src/pdch_ul_controller.c +++ b/src/pdch_ul_controller.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with it program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/pdch_ul_controller.h b/src/pdch_ul_controller.h index c56945f..0e66720 100644 --- a/src/pdch_ul_controller.h +++ b/src/pdch_ul_controller.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/rlc.cpp b/src/rlc.cpp index a2cc52c..a082597 100644 --- a/src/rlc.cpp +++ b/src/rlc.cpp @@ -10,10 +10,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include "bts.h" diff --git a/src/rlc.h b/src/rlc.h index 45cbb95..73a537f 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once #ifdef __cplusplus diff --git a/src/sba.c b/src/sba.c index d293784..94c3c56 100644 --- a/src/sba.c +++ b/src/sba.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/sba.h b/src/sba.h index 3962576..749b145 100644 --- a/src/sba.h +++ b/src/sba.h @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf.cpp b/src/tbf.cpp index 0b02623..c2eeb89 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf.h b/src/tbf.h index 9ce1813..31bbe5f 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -10,10 +10,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 6e898da..ec455c1 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf_dl.h b/src/tbf_dl.h index d20ad75..c0c0284 100644 --- a/src/tbf_dl.h +++ b/src/tbf_dl.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index a5948e7..9ea216c 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf_dl_ass_fsm.h b/src/tbf_dl_ass_fsm.h index 94c9062..a259c03 100644 --- a/src/tbf_dl_ass_fsm.h +++ b/src/tbf_dl_ass_fsm.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf_fsm.c b/src/tbf_fsm.c index 39f2080..2189747 100644 --- a/src/tbf_fsm.c +++ b/src/tbf_fsm.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf_fsm.h b/src/tbf_fsm.h index 614c319..9814c0e 100644 --- a/src/tbf_fsm.h +++ b/src/tbf_fsm.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 0282122..305daaa 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf_ul.h b/src/tbf_ul.h index 0dc2336..62b9456 100644 --- a/src/tbf_ul.h +++ b/src/tbf_ul.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf_ul_ack_fsm.c b/src/tbf_ul_ack_fsm.c index 32e3533..364ef00 100644 --- a/src/tbf_ul_ack_fsm.c +++ b/src/tbf_ul_ack_fsm.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf_ul_ack_fsm.h b/src/tbf_ul_ack_fsm.h index aaee5a3..d2e9332 100644 --- a/src/tbf_ul_ack_fsm.h +++ b/src/tbf_ul_ack_fsm.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf_ul_ass_fsm.c b/src/tbf_ul_ass_fsm.c index 90fe828..b443e4f 100644 --- a/src/tbf_ul_ass_fsm.c +++ b/src/tbf_ul_ass_fsm.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf_ul_ass_fsm.h b/src/tbf_ul_ass_fsm.h index 34b81a7..8a612f2 100644 --- a/src/tbf_ul_ass_fsm.h +++ b/src/tbf_ul_ass_fsm.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/wireshark_compat.h b/src/wireshark_compat.h index 13b165a..2840124 100644 --- a/src/wireshark_compat.h +++ b/src/wireshark_compat.h @@ -10,10 +10,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ /* This header contains a few definitions required by rlcmac and csn1 files diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp index 6f3de43..b5d4b95 100644 --- a/tests/alloc/AllocTest.cpp +++ b/tests/alloc/AllocTest.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include "gprs_rlcmac.h" diff --git a/tests/alloc/MslotTest.cpp b/tests/alloc/MslotTest.cpp index 96fe61b..1b06b0b 100644 --- a/tests/alloc/MslotTest.cpp +++ b/tests/alloc/MslotTest.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include "gprs_rlcmac.h" diff --git a/tests/app_info/AppInfoTest.cpp b/tests/app_info/AppInfoTest.cpp index d3a047e..9530d09 100644 --- a/tests/app_info/AppInfoTest.cpp +++ b/tests/app_info/AppInfoTest.cpp @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp index 88847de..30476c5 100644 --- a/tests/rlcmac/RLCMACTest.cpp +++ b/tests/rlcmac/RLCMACTest.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26557 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4a49dbeeec89b22624c968152118aecf8886dac6 Gerrit-Change-Number: 26557 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:27:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:27:59 +0000 Subject: Change in ...osmo-python-tests[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/26558 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: Ifd7b7e548c9c6db140fa8cbc8a3c8dfaf4603d18 --- M osmopy/osmo_ipa.py M osmopy/trap_helper.py M osmopy/twisted_ipa.py M scripts/ctrl2cgi.py M scripts/osmo_ctrl.py M scripts/osmo_rate_ctr2csv.py M scripts/osmo_trap2cgi.py M scripts/soap.py 8 files changed, 0 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/58/26558/1 diff --git a/osmopy/osmo_ipa.py b/osmopy/osmo_ipa.py index a95a05b..1b42b7f 100755 --- a/osmopy/osmo_ipa.py +++ b/osmopy/osmo_ipa.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/osmopy/trap_helper.py b/osmopy/trap_helper.py index a48770b..2b4179d 100644 --- a/osmopy/trap_helper.py +++ b/osmopy/trap_helper.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/osmopy/twisted_ipa.py b/osmopy/twisted_ipa.py index f39bc5c..fd3cee5 100755 --- a/osmopy/twisted_ipa.py +++ b/osmopy/twisted_ipa.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/scripts/ctrl2cgi.py b/scripts/ctrl2cgi.py index 3e8f87d..9f66f99 100755 --- a/scripts/ctrl2cgi.py +++ b/scripts/ctrl2cgi.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/scripts/osmo_ctrl.py b/scripts/osmo_ctrl.py index 8a67fd8..8115eb8 100755 --- a/scripts/osmo_ctrl.py +++ b/scripts/osmo_ctrl.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/scripts/osmo_rate_ctr2csv.py b/scripts/osmo_rate_ctr2csv.py index a66fb01..140fa65 100755 --- a/scripts/osmo_rate_ctr2csv.py +++ b/scripts/osmo_rate_ctr2csv.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/scripts/osmo_trap2cgi.py b/scripts/osmo_trap2cgi.py index a03fd2b..a8d1ffe 100755 --- a/scripts/osmo_trap2cgi.py +++ b/scripts/osmo_trap2cgi.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/scripts/soap.py b/scripts/soap.py index 8a5f514..f054ef3 100755 --- a/scripts/soap.py +++ b/scripts/soap.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/26558 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Ifd7b7e548c9c6db140fa8cbc8a3c8dfaf4603d18 Gerrit-Change-Number: 26558 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:28:11 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:28:11 +0000 Subject: Change in osmo-remsim[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26559 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I2e98f89f6738d03c45a2106820af0912692093f3 --- M asn1/RSPRO.asn M src/bankd/bankd_main.c M src/bankd/bankd_pcsc.c M src/bankd/driver_core.c M src/bankd/driver_pcsc.c M src/bankd/main.c M src/client/main_fsm.c M src/client/remsim_client.c M src/client/user_ifdhandler.c M src/client/user_simtrace2.c M src/debug.c M src/rspro_client_fsm.c M src/rspro_util.c M src/slotmap.c 14 files changed, 0 insertions(+), 56 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/59/26559/1 diff --git a/asn1/RSPRO.asn b/asn1/RSPRO.asn index 1b1be6d..d49345d 100644 --- a/asn1/RSPRO.asn +++ b/asn1/RSPRO.asn @@ -15,10 +15,6 @@ -- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -- GNU General Public License for more details. -- --- You should have received a copy of the GNU General Public License along --- with this program; if not, write to the Free Software Foundation, Inc., --- 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. --- ---------------------------------------------------------------------- RSPRO {} DEFINITIONS diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 5b70b88..2923924 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #define _GNU_SOURCE diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index 8202504..e3b9ea6 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/bankd/driver_core.c b/src/bankd/driver_core.c index 57ae3cd..128bbe2 100644 --- a/src/bankd/driver_core.c +++ b/src/bankd/driver_core.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/bankd/driver_pcsc.c b/src/bankd/driver_pcsc.c index 4279c2f..e807525 100644 --- a/src/bankd/driver_pcsc.c +++ b/src/bankd/driver_pcsc.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/bankd/main.c b/src/bankd/main.c index 4bb91ca..f4601ae 100644 --- a/src/bankd/main.c +++ b/src/bankd/main.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/client/main_fsm.c b/src/client/main_fsm.c index 96b4b90..f8b1406 100644 --- a/src/client/main_fsm.c +++ b/src/client/main_fsm.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/client/remsim_client.c b/src/client/remsim_client.c index 388aa26..8da82ef 100644 --- a/src/client/remsim_client.c +++ b/src/client/remsim_client.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* This file contains code shared among all remsim client applications, diff --git a/src/client/user_ifdhandler.c b/src/client/user_ifdhandler.c index a416e6e..551db00 100644 --- a/src/client/user_ifdhandler.c +++ b/src/client/user_ifdhandler.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* This is a remsim-client that provides an IFD_Handler (reader driver) diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c index 100d55b..f71c720 100644 --- a/src/client/user_simtrace2.c +++ b/src/client/user_simtrace2.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/debug.c b/src/debug.c index 2dfc16e..fb8bb4b 100644 --- a/src/debug.c +++ b/src/debug.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index bfd7ebd..c0336b7 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/rspro_util.c b/src/rspro_util.c index a7476dc..2ea6caf 100644 --- a/src/rspro_util.c +++ b/src/rspro_util.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/slotmap.c b/src/slotmap.c index fe0c6b7..b1be0ab 100644 --- a/src/slotmap.c +++ b/src/slotmap.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2e98f89f6738d03c45a2106820af0912692093f3 Gerrit-Change-Number: 26559 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:28:17 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:28:17 +0000 Subject: Change in osmo-sgsn[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26560 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I9bc57a7152015e0f37e3d1573921d6d5d3c0449b --- M include/osmocom/sgsn/v42bis.h M include/osmocom/sgsn/v42bis_private.h M src/sgsn/v42bis.c 3 files changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/60/26560/1 diff --git a/include/osmocom/sgsn/v42bis.h b/include/osmocom/sgsn/v42bis.h index b64c43e..d782981 100644 --- a/include/osmocom/sgsn/v42bis.h +++ b/include/osmocom/sgsn/v42bis.h @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \page v42bis_page V.42bis modem data compression diff --git a/include/osmocom/sgsn/v42bis_private.h b/include/osmocom/sgsn/v42bis_private.h index c6b675a..cc7e634 100644 --- a/include/osmocom/sgsn/v42bis_private.h +++ b/include/osmocom/sgsn/v42bis_private.h @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #if !defined(_SPANDSP_PRIVATE_V42BIS_H_) diff --git a/src/sgsn/v42bis.c b/src/sgsn/v42bis.c index 0759cdf..ddca5f8 100644 --- a/src/sgsn/v42bis.c +++ b/src/sgsn/v42bis.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /* THIS IS A WORK IN PROGRESS. IT IS NOT FINISHED. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9bc57a7152015e0f37e3d1573921d6d5d3c0449b Gerrit-Change-Number: 26560 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:28:32 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:28:32 +0000 Subject: Change in osmo-smlc[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26561 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: Ieb4f9b4ad5073c9b5996cb960b248c450fd5f2dd --- M include/osmocom/smlc/cell_locations.h M include/osmocom/smlc/smlc_loc_req.h M src/osmo-smlc/cell_locations.c M src/osmo-smlc/smlc_loc_req.c 4 files changed, 0 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/61/26561/1 diff --git a/include/osmocom/smlc/cell_locations.h b/include/osmocom/smlc/cell_locations.h index 33023bb..9712718 100644 --- a/include/osmocom/smlc/cell_locations.h +++ b/include/osmocom/smlc/cell_locations.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/smlc/smlc_loc_req.h b/include/osmocom/smlc/smlc_loc_req.h index a8aa27e..7cd5711 100644 --- a/include/osmocom/smlc/smlc_loc_req.h +++ b/include/osmocom/smlc/smlc_loc_req.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/src/osmo-smlc/cell_locations.c b/src/osmo-smlc/cell_locations.c index e563720..273b83f 100644 --- a/src/osmo-smlc/cell_locations.c +++ b/src/osmo-smlc/cell_locations.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/osmo-smlc/smlc_loc_req.c b/src/osmo-smlc/smlc_loc_req.c index 392e247..cfd8521 100644 --- a/src/osmo-smlc/smlc_loc_req.c +++ b/src/osmo-smlc/smlc_loc_req.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26561 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ieb4f9b4ad5073c9b5996cb960b248c450fd5f2dd Gerrit-Change-Number: 26561 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:28:39 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:28:39 +0000 Subject: Change in osmo-sysmon[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26562 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I1f6db5f930fe97ce2336bce416470b807d7a57b7 --- M src/client.c M src/osmo-ctrl-client.c M src/osysmon_ctrl.c M src/osysmon_file.c M src/osysmon_main.c M src/osysmon_openvpn.c M src/osysmon_ping.c M src/osysmon_rtnl.c M src/osysmon_shellcmd.c M src/osysmon_sysinfo.c M src/simple_ctrl.c M src/value_node.c 12 files changed, 0 insertions(+), 60 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/62/26562/1 diff --git a/src/client.c b/src/client.c index 758884d..a277521 100644 --- a/src/client.c +++ b/src/client.c @@ -15,11 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osmo-ctrl-client.c b/src/osmo-ctrl-client.c index 83e9b7b..351ab91 100644 --- a/src/osmo-ctrl-client.c +++ b/src/osmo-ctrl-client.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_ctrl.c b/src/osysmon_ctrl.c index c54779c..a4e2444 100644 --- a/src/osysmon_ctrl.c +++ b/src/osysmon_ctrl.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_file.c b/src/osysmon_file.c index 8e52497..b25fa24 100644 --- a/src/osysmon_file.c +++ b/src/osysmon_file.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_main.c b/src/osysmon_main.c index 206246c..2d5ebfa 100644 --- a/src/osysmon_main.c +++ b/src/osysmon_main.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_openvpn.c b/src/osysmon_openvpn.c index 8d88def..cc9694f 100644 --- a/src/osysmon_openvpn.c +++ b/src/osysmon_openvpn.c @@ -15,11 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_ping.c b/src/osysmon_ping.c index 3484374..de20791 100644 --- a/src/osysmon_ping.c +++ b/src/osysmon_ping.c @@ -15,11 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_rtnl.c b/src/osysmon_rtnl.c index f1e5a0e..a8e0fa8 100644 --- a/src/osysmon_rtnl.c +++ b/src/osysmon_rtnl.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_shellcmd.c b/src/osysmon_shellcmd.c index 83dc0c9..81ed276 100644 --- a/src/osysmon_shellcmd.c +++ b/src/osysmon_shellcmd.c @@ -15,11 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_sysinfo.c b/src/osysmon_sysinfo.c index 9cb434c..185c675 100644 --- a/src/osysmon_sysinfo.c +++ b/src/osysmon_sysinfo.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/simple_ctrl.c b/src/simple_ctrl.c index 9407218..1e50dca 100644 --- a/src/simple_ctrl.c +++ b/src/simple_ctrl.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/value_node.c b/src/value_node.c index 9143451..fc886d1 100644 --- a/src/value_node.c +++ b/src/value_node.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I1f6db5f930fe97ce2336bce416470b807d7a57b7 Gerrit-Change-Number: 26562 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:28:44 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:28:44 +0000 Subject: Change in osmo-trx[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/26563 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I8ba71ab9ccde4ba25151ecbeb2a323f706b57d43 --- M CommonLibs/PRBS.h M CommonLibs/Utils.cpp M CommonLibs/Utils.h M Transceiver52M/Resampler.cpp M Transceiver52M/Resampler.h M Transceiver52M/arch/arm/convert.c M Transceiver52M/arch/arm/convert_neon.S M Transceiver52M/arch/arm/convolve.c M Transceiver52M/arch/arm/convolve_neon.S M Transceiver52M/arch/arm/mult.c M Transceiver52M/arch/arm/mult_neon.S M Transceiver52M/arch/arm/scale.c M Transceiver52M/arch/arm/scale_neon.S M Transceiver52M/arch/common/convert_base.c M Transceiver52M/arch/common/convolve_base.c M Transceiver52M/arch/x86/convert.c M Transceiver52M/arch/x86/convert_sse_3.c M Transceiver52M/arch/x86/convert_sse_3.h M Transceiver52M/arch/x86/convert_sse_4_1.c M Transceiver52M/arch/x86/convert_sse_4_1.h M Transceiver52M/arch/x86/convolve.c M Transceiver52M/arch/x86/convolve_sse_3.c M Transceiver52M/arch/x86/convolve_sse_3.h M Transceiver52M/osmo-trx.cpp M tests/CommonLibs/PRBSTest.cpp 25 files changed, 0 insertions(+), 100 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/63/26563/1 diff --git a/CommonLibs/PRBS.h b/CommonLibs/PRBS.h index 9235327..8d08fa3 100644 --- a/CommonLibs/PRBS.h +++ b/CommonLibs/PRBS.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #ifndef PRBS_H diff --git a/CommonLibs/Utils.cpp b/CommonLibs/Utils.cpp index e500475..3ab598d 100644 --- a/CommonLibs/Utils.cpp +++ b/CommonLibs/Utils.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/CommonLibs/Utils.h b/CommonLibs/Utils.h index 3c5c802..8e61a9f 100644 --- a/CommonLibs/Utils.h +++ b/CommonLibs/Utils.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #pragma once diff --git a/Transceiver52M/Resampler.cpp b/Transceiver52M/Resampler.cpp index 2ca6406..910c7ff 100644 --- a/Transceiver52M/Resampler.cpp +++ b/Transceiver52M/Resampler.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/Resampler.h b/Transceiver52M/Resampler.h index 5af8d26..e1962c7 100644 --- a/Transceiver52M/Resampler.h +++ b/Transceiver52M/Resampler.h @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #ifndef _RESAMPLER_H_ diff --git a/Transceiver52M/arch/arm/convert.c b/Transceiver52M/arch/arm/convert.c index ace1b6f..7145579 100644 --- a/Transceiver52M/arch/arm/convert.c +++ b/Transceiver52M/arch/arm/convert.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/arm/convert_neon.S b/Transceiver52M/arch/arm/convert_neon.S index a1fbd40..6cf3c03 100644 --- a/Transceiver52M/arch/arm/convert_neon.S +++ b/Transceiver52M/arch/arm/convert_neon.S @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ .syntax unified diff --git a/Transceiver52M/arch/arm/convolve.c b/Transceiver52M/arch/arm/convolve.c index adb718d..c2611b4 100644 --- a/Transceiver52M/arch/arm/convolve.c +++ b/Transceiver52M/arch/arm/convolve.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/arm/convolve_neon.S b/Transceiver52M/arch/arm/convolve_neon.S index a3e1ba5..3209d60 100644 --- a/Transceiver52M/arch/arm/convolve_neon.S +++ b/Transceiver52M/arch/arm/convolve_neon.S @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #ifdef HAVE_CONFIG_H diff --git a/Transceiver52M/arch/arm/mult.c b/Transceiver52M/arch/arm/mult.c index 9851626..251b3c9 100644 --- a/Transceiver52M/arch/arm/mult.c +++ b/Transceiver52M/arch/arm/mult.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/arm/mult_neon.S b/Transceiver52M/arch/arm/mult_neon.S index 6318c50..b4cd229 100644 --- a/Transceiver52M/arch/arm/mult_neon.S +++ b/Transceiver52M/arch/arm/mult_neon.S @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ .syntax unified diff --git a/Transceiver52M/arch/arm/scale.c b/Transceiver52M/arch/arm/scale.c index a3214f7..d44ffc8 100644 --- a/Transceiver52M/arch/arm/scale.c +++ b/Transceiver52M/arch/arm/scale.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/arm/scale_neon.S b/Transceiver52M/arch/arm/scale_neon.S index f10de1e..c348f30 100644 --- a/Transceiver52M/arch/arm/scale_neon.S +++ b/Transceiver52M/arch/arm/scale_neon.S @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ .syntax unified diff --git a/Transceiver52M/arch/common/convert_base.c b/Transceiver52M/arch/common/convert_base.c index 9876e83..9a01a1e 100644 --- a/Transceiver52M/arch/common/convert_base.c +++ b/Transceiver52M/arch/common/convert_base.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include "convert.h" diff --git a/Transceiver52M/arch/common/convolve_base.c b/Transceiver52M/arch/common/convolve_base.c index bfda783..3765c5c 100644 --- a/Transceiver52M/arch/common/convolve_base.c +++ b/Transceiver52M/arch/common/convolve_base.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/x86/convert.c b/Transceiver52M/arch/x86/convert.c index bbcfd67..596233c 100644 --- a/Transceiver52M/arch/x86/convert.c +++ b/Transceiver52M/arch/x86/convert.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/x86/convert_sse_3.c b/Transceiver52M/arch/x86/convert_sse_3.c index 255db67..f00ecf5 100644 --- a/Transceiver52M/arch/x86/convert_sse_3.c +++ b/Transceiver52M/arch/x86/convert_sse_3.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/x86/convert_sse_3.h b/Transceiver52M/arch/x86/convert_sse_3.h index c2f87d7..b5abe47 100644 --- a/Transceiver52M/arch/x86/convert_sse_3.h +++ b/Transceiver52M/arch/x86/convert_sse_3.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #pragma once diff --git a/Transceiver52M/arch/x86/convert_sse_4_1.c b/Transceiver52M/arch/x86/convert_sse_4_1.c index 42a235c..736a376 100644 --- a/Transceiver52M/arch/x86/convert_sse_4_1.c +++ b/Transceiver52M/arch/x86/convert_sse_4_1.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/x86/convert_sse_4_1.h b/Transceiver52M/arch/x86/convert_sse_4_1.h index 57a5efb..63305e5 100644 --- a/Transceiver52M/arch/x86/convert_sse_4_1.h +++ b/Transceiver52M/arch/x86/convert_sse_4_1.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #pragma once diff --git a/Transceiver52M/arch/x86/convolve.c b/Transceiver52M/arch/x86/convolve.c index be62721..45a3719 100644 --- a/Transceiver52M/arch/x86/convolve.c +++ b/Transceiver52M/arch/x86/convolve.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/x86/convolve_sse_3.c b/Transceiver52M/arch/x86/convolve_sse_3.c index 8fd3b5e..ca4dc71 100644 --- a/Transceiver52M/arch/x86/convolve_sse_3.c +++ b/Transceiver52M/arch/x86/convolve_sse_3.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/x86/convolve_sse_3.h b/Transceiver52M/arch/x86/convolve_sse_3.h index d929ef6..2cbc037 100644 --- a/Transceiver52M/arch/x86/convolve_sse_3.h +++ b/Transceiver52M/arch/x86/convolve_sse_3.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #pragma once diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index b227863..b6f378b 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #ifdef HAVE_CONFIG_H diff --git a/tests/CommonLibs/PRBSTest.cpp b/tests/CommonLibs/PRBSTest.cpp index cb5ed41..8000288 100644 --- a/tests/CommonLibs/PRBSTest.cpp +++ b/tests/CommonLibs/PRBSTest.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include "PRBS.h" -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/26563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8ba71ab9ccde4ba25151ecbeb2a323f706b57d43 Gerrit-Change-Number: 26563 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:28:51 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:28:51 +0000 Subject: Change in osmo-ttcn3-hacks[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26564 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I8ab8f1e79fcc38d889cce4eac2e90cd4e5582b1b --- M remsim/RSPRO.asn 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/26564/1 diff --git a/remsim/RSPRO.asn b/remsim/RSPRO.asn index ce29003..faf9cec 100644 --- a/remsim/RSPRO.asn +++ b/remsim/RSPRO.asn @@ -15,10 +15,6 @@ -- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -- GNU General Public License for more details. -- --- You should have received a copy of the GNU General Public License along --- with this program; if not, write to the Free Software Foundation, Inc., --- 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. --- ---------------------------------------------------------------------- RSPRO {} DEFINITIONS -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ab8f1e79fcc38d889cce4eac2e90cd4e5582b1b Gerrit-Change-Number: 26564 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:29:02 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:29:02 +0000 Subject: Change in ...osmo_ss7[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/26565 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: Ic8c69d24141abd183e3b1257f4e9edfd9c1afabe --- M include/ipa.hrl M src/ipa_proto.erl M src/ipa_proto_ccm.erl 3 files changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_ss7 refs/changes/65/26565/1 diff --git a/include/ipa.hrl b/include/ipa.hrl index f0372f4..a652629 100644 --- a/include/ipa.hrl +++ b/include/ipa.hrl @@ -11,10 +11,6 @@ % but WITHOUT ANY WARRANTY; without even the implied warranty of % MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the % GNU General Public License for more details. -% -% You should have received a copy of the GNU General Public License along -% with this program; if not, write to the Free Software Foundation, Inc., -% 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -ifndef(IPA). -define(IPA, true). diff --git a/src/ipa_proto.erl b/src/ipa_proto.erl index d1d4396..ceb024a 100644 --- a/src/ipa_proto.erl +++ b/src/ipa_proto.erl @@ -14,10 +14,6 @@ % but WITHOUT ANY WARRANTY; without even the implied warranty of % MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the % GNU General Public License for more details. -% -% You should have received a copy of the GNU General Public License along -% with this program; if not, write to the Free Software Foundation, Inc., -% 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -module(ipa_proto). -author('Harald Welte '). diff --git a/src/ipa_proto_ccm.erl b/src/ipa_proto_ccm.erl index cfd3863..27ceba9 100644 --- a/src/ipa_proto_ccm.erl +++ b/src/ipa_proto_ccm.erl @@ -13,10 +13,6 @@ % but WITHOUT ANY WARRANTY; without even the implied warranty of % MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the % GNU General Public License for more details. -% -% You should have received a copy of the GNU General Public License along -% with this program; if not, write to the Free Software Foundation, Inc., -% 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -module(ipa_proto_ccm). -author('Harald Welte '). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/26565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_ss7 Gerrit-Branch: master Gerrit-Change-Id: Ic8c69d24141abd183e3b1257f4e9edfd9c1afabe Gerrit-Change-Number: 26565 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:29:08 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:29:08 +0000 Subject: Change in osmocom-bb[master]: treewide: remove FSF address References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/26566 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I73be012c01c0108fb6951dbff91d50eb19b40c51 --- M include/l1ctl_proto.h M src/host/fb_tools/bdf_to_c.py M src/host/gprsdecode/gprs.c M src/host/gprsdecode/gsmtap.c M src/host/gprsdecode/main.c M src/host/gprsdecode/rlcmac.c M src/host/gsmmap/gsmmap.c M src/host/gsmmap/log.c M src/host/layer23/include/osmocom/bb/common/gps.h M src/host/layer23/include/osmocom/bb/common/sim.h M src/host/layer23/include/osmocom/bb/misc/cell_log.h M src/host/layer23/include/osmocom/bb/mobile/mncc.h M src/host/layer23/src/common/gps.c M src/host/layer23/src/common/l1ctl.c M src/host/layer23/src/common/l1ctl_lapdm_glue.c M src/host/layer23/src/common/l1l2_interface.c M src/host/layer23/src/common/logging.c M src/host/layer23/src/common/main.c M src/host/layer23/src/common/sap_fsm.c M src/host/layer23/src/common/sap_interface.c M src/host/layer23/src/common/sap_proto.c M src/host/layer23/src/common/sim.c M src/host/layer23/src/common/sysinfo.c M src/host/layer23/src/common/utils.c M src/host/layer23/src/misc/app_bcch_scan.c M src/host/layer23/src/misc/app_cbch_sniff.c M src/host/layer23/src/misc/app_ccch_scan.c M src/host/layer23/src/misc/app_cell_log.c M src/host/layer23/src/misc/app_echo_test.c M src/host/layer23/src/misc/bcch_scan.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/misc/rslms.c M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gsm322.c M src/host/layer23/src/mobile/gsm411_sms.c M src/host/layer23/src/mobile/gsm414.c M src/host/layer23/src/mobile/gsm480_ss.c M src/host/layer23/src/mobile/gsm48_cc.c M src/host/layer23/src/mobile/gsm48_mm.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/main.c M src/host/layer23/src/mobile/mncc_sock.c M src/host/layer23/src/mobile/mnccms.c M src/host/layer23/src/mobile/primitives.c M src/host/layer23/src/mobile/script_lua.c M src/host/layer23/src/mobile/script_nolua.c M src/host/layer23/src/mobile/settings.c M src/host/layer23/src/mobile/subscriber.c M src/host/layer23/src/mobile/support.c M src/host/layer23/src/mobile/transaction.c M src/host/layer23/src/mobile/voice.c M src/host/layer23/src/mobile/vty_interface.c M src/host/osmocon/osmocon.c M src/host/osmocon/osmoload.c M src/host/osmocon/tpu_debug.c M src/host/trxcon/l1ctl.c M src/host/trxcon/l1ctl_link.c M src/host/trxcon/logging.c M src/host/trxcon/sched_lchan_common.c M src/host/trxcon/sched_lchan_pdtch.c M src/host/trxcon/sched_lchan_rach.c M src/host/trxcon/sched_lchan_sch.c M src/host/trxcon/sched_lchan_tchf.c M src/host/trxcon/sched_lchan_tchh.c M src/host/trxcon/sched_lchan_xcch.c M src/host/trxcon/sched_prim.c M src/host/trxcon/sched_trx.c M src/host/trxcon/trxcon.c M src/host/virt_phy/src/logging.c M src/host/virt_phy/src/virt_prim_data.c M src/host/virt_phy/src/virt_prim_fbsb.c M src/host/virt_phy/src/virt_prim_pm.c M src/host/virt_phy/src/virt_prim_rach.c M src/host/virt_phy/src/virt_prim_traffic.c M src/shared/libosmocore/include/osmocom/core/bitvec.h M src/shared/libosmocore/include/osmocom/core/conv.h M src/shared/libosmocore/include/osmocom/core/crcXXgen.h.tpl M src/shared/libosmocore/include/osmocom/core/crcgen.h M src/shared/libosmocore/include/osmocom/core/linuxrbtree.h M src/shared/libosmocore/include/osmocom/core/msgb.h M src/shared/libosmocore/include/osmocom/core/msgfile.h M src/shared/libosmocore/include/osmocom/core/serial.h M src/shared/libosmocore/include/osmocom/core/timer.h M src/shared/libosmocore/include/osmocom/core/timer_compat.h M src/shared/libosmocore/include/osmocom/core/write_queue.h M src/shared/libosmocore/include/osmocom/gsm/a5.h M src/shared/libosmocore/include/osmocom/gsm/gsm0808.h M src/shared/libosmocore/include/osmocom/gsm/gsm_utils.h M src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_08_58.h M src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_12_21.h M src/shared/libosmocore/include/osmocom/vty/telnet_interface.h M src/shared/libosmocore/include/osmocom/vty/vector.h M src/shared/libosmocore/src/application.c M src/shared/libosmocore/src/backtrace.c M src/shared/libosmocore/src/bitvec.c M src/shared/libosmocore/src/codec/gsm610.c M src/shared/libosmocore/src/codec/gsm620.c M src/shared/libosmocore/src/codec/gsm660.c M src/shared/libosmocore/src/codec/gsm690.c M src/shared/libosmocore/src/conv.c M src/shared/libosmocore/src/crcXXgen.c.tpl M src/shared/libosmocore/src/gsm/a5.c M src/shared/libosmocore/src/gsm/auth_comp128v1.c M src/shared/libosmocore/src/gsm/auth_core.c M src/shared/libosmocore/src/gsm/auth_milenage.c M src/shared/libosmocore/src/gsm/comp128.c M src/shared/libosmocore/src/gsm/gprs_cipher_core.c M src/shared/libosmocore/src/gsm/gsm0480.c M src/shared/libosmocore/src/gsm/gsm0808.c M src/shared/libosmocore/src/gsm/gsm48.c M src/shared/libosmocore/src/gsm/gsm48_ie.c M src/shared/libosmocore/src/gsm/gsm_utils.c M src/shared/libosmocore/src/gsm/lapd_core.c M src/shared/libosmocore/src/gsm/lapdm.c M src/shared/libosmocore/src/gsm/rsl.c M src/shared/libosmocore/src/gsm/rxlev_stat.c M src/shared/libosmocore/src/gsmtap_util.c M src/shared/libosmocore/src/logging.c M src/shared/libosmocore/src/logging_syslog.c M src/shared/libosmocore/src/msgb.c M src/shared/libosmocore/src/msgfile.c M src/shared/libosmocore/src/panic.c M src/shared/libosmocore/src/plugin.c M src/shared/libosmocore/src/rate_ctr.c M src/shared/libosmocore/src/rbtree.c M src/shared/libosmocore/src/select.c M src/shared/libosmocore/src/serial.c M src/shared/libosmocore/src/signal.c M src/shared/libosmocore/src/statistics.c M src/shared/libosmocore/src/timer.c M src/shared/libosmocore/src/vty/logging_vty.c M src/shared/libosmocore/src/vty/telnet_interface.c M src/shared/libosmocore/src/vty/utils.c M src/shared/libosmocore/src/vty/vector.c M src/shared/libosmocore/src/write_queue.c M src/shared/libosmocore/tests/gsm0408/gsm0408_test.c M src/shared/libosmocore/tests/gsm0808/gsm0808_test.c M src/shared/libosmocore/tests/lapd/lapd_test.c M src/shared/libosmocore/tests/msgfile/msgfile_test.c M src/shared/libosmocore/tests/sms/sms_test.c M src/shared/libosmocore/tests/smscb/smscb_test.c M src/shared/libosmocore/tests/timer/timer_test.c M src/shared/libosmocore/tests/ussd/ussd_test.c M src/shared/libosmocore/utils/osmo-arfcn.c M src/shared/libosmocore/utils/osmo-auc-gen.c M src/target/firmware/abb/twl3025.c M src/target/firmware/apps/compal_dsp_dump/main.c M src/target/firmware/apps/hello_world/main.c M src/target/firmware/apps/layer1/main.c M src/target/firmware/apps/loader/main.c M src/target/firmware/apps/loader_mtk/main.c M src/target/firmware/apps/menu/main.c M src/target/firmware/apps/rssi/main.c M src/target/firmware/apps/simtest/main.c M src/target/firmware/apps/snake_game/main.c M src/target/firmware/battery/compal_e88.c M src/target/firmware/board/common/readcal_tiffs.c M src/target/firmware/board/common/tx_calchan.c M src/target/firmware/board/compal/readcal_common.c M src/target/firmware/board/compal/readcal_small.c M src/target/firmware/board/compal/rf_tables.c M src/target/firmware/board/compal_e86/init.c M src/target/firmware/board/compal_e86/tx_ramps.c M src/target/firmware/board/compal_e88/init.c M src/target/firmware/board/compal_e88/tx_ramps.c M src/target/firmware/board/compal_e99/init.c M src/target/firmware/board/compal_e99/readcal.c M src/target/firmware/board/fcdev3b/init.c M src/target/firmware/board/gta0x/afcparams.c M src/target/firmware/board/gta0x/init.c M src/target/firmware/board/gta0x/rf_tables.c M src/target/firmware/board/gtm900b/afcparams.c M src/target/firmware/board/gtm900b/init.c M src/target/firmware/board/mediatek/uart.c M src/target/firmware/board/mt62xx/init.c M src/target/firmware/board/pirelli_dpl10/init.c M src/target/firmware/board/pirelli_dpl10/readcal.c M src/target/firmware/board/pirelli_dpl10/rf_tables.c M src/target/firmware/board/se_j100/init.c M src/target/firmware/board/se_j100/tx_ramps.c M src/target/firmware/calypso/backlight.c M src/target/firmware/calypso/buzzer.c M src/target/firmware/calypso/clock.c M src/target/firmware/calypso/dma.c M src/target/firmware/calypso/dsp.c M src/target/firmware/calypso/du.c M src/target/firmware/calypso/i2c.c M src/target/firmware/calypso/irq.c M src/target/firmware/calypso/keypad.c M src/target/firmware/calypso/rtc.c M src/target/firmware/calypso/sim.c M src/target/firmware/calypso/spi.c M src/target/firmware/calypso/timer.c M src/target/firmware/calypso/tpu.c M src/target/firmware/calypso/tsp.c M src/target/firmware/calypso/uart.c M src/target/firmware/calypso/uwire.c M src/target/firmware/comm/msgb.c M src/target/firmware/comm/sercomm.c M src/target/firmware/comm/sercomm_cons.c M src/target/firmware/comm/timer.c M src/target/firmware/fb/fb_bw8.c M src/target/firmware/fb/fb_dummy.c M src/target/firmware/fb/fb_rgb332.c M src/target/firmware/fb/fb_s6b33b1x.c M src/target/firmware/fb/fb_ssd1783.c M src/target/firmware/fb/fb_ssd1963.c M src/target/firmware/fb/fb_st7558.c M src/target/firmware/fb/fb_td014.c M src/target/firmware/fb/font.c M src/target/firmware/fb/framebuffer.c M src/target/firmware/flash/cfi_flash.c M src/target/firmware/include/calypso/du.h M src/target/firmware/include/calypso/sim.h M src/target/firmware/include/comm/timer.h M src/target/firmware/include/mtk/emi.h M src/target/firmware/include/mtk/mt6235.h M src/target/firmware/include/mtk/system.h M src/target/firmware/layer1/afc.c M src/target/firmware/layer1/agc.c M src/target/firmware/layer1/async.c M src/target/firmware/layer1/avg.c M src/target/firmware/layer1/init.c M src/target/firmware/layer1/l23_api.c M src/target/firmware/layer1/mframe_sched.c M src/target/firmware/layer1/prim_fbsb.c M src/target/firmware/layer1/prim_freq.c M src/target/firmware/layer1/prim_pm.c M src/target/firmware/layer1/prim_rach.c M src/target/firmware/layer1/prim_rx_nb.c M src/target/firmware/layer1/prim_tch.c M src/target/firmware/layer1/prim_tx_nb.c M src/target/firmware/layer1/prim_utils.c M src/target/firmware/layer1/rfch.c M src/target/firmware/layer1/sched_gsmtime.c M src/target/firmware/layer1/sync.c M src/target/firmware/layer1/tdma_sched.c M src/target/firmware/layer1/toa.c M src/target/firmware/layer1/tpu_window.c M src/target/firmware/lib/console.c M src/target/firmware/rf/mt6139.c M src/target/firmware/rf/trf6151.c M src/target/firmware/tiffs/init.c M src/target/firmware/tiffs/readfile.c M src/target/trx_toolkit/app_common.py M src/target/trx_toolkit/burst_fwd.py M src/target/trx_toolkit/burst_gen.py M src/target/trx_toolkit/burst_send.py M src/target/trx_toolkit/clck_gen.py M src/target/trx_toolkit/codec.py M src/target/trx_toolkit/ctrl_cmd.py M src/target/trx_toolkit/ctrl_if.py M src/target/trx_toolkit/ctrl_if_trx.py M src/target/trx_toolkit/data_dump.py M src/target/trx_toolkit/data_if.py M src/target/trx_toolkit/data_msg.py M src/target/trx_toolkit/fake_pm.py M src/target/trx_toolkit/fake_trx.py M src/target/trx_toolkit/gsm_shared.py M src/target/trx_toolkit/rand_burst_gen.py M src/target/trx_toolkit/test_codec.py M src/target/trx_toolkit/test_data_dump.py M src/target/trx_toolkit/test_data_msg.py M src/target/trx_toolkit/transceiver.py M src/target/trx_toolkit/trx_list.py M src/target/trx_toolkit/trx_sniff.py M src/target/trx_toolkit/trxd_proto.py M src/target/trx_toolkit/udp_link.py 268 files changed, 0 insertions(+), 1,072 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/66/26566/1 diff --git a/include/l1ctl_proto.h b/include/l1ctl_proto.h index cf41ac7..3720f82 100644 --- a/include/l1ctl_proto.h +++ b/include/l1ctl_proto.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef __L1CTL_PROTO_H__ diff --git a/src/host/fb_tools/bdf_to_c.py b/src/host/fb_tools/bdf_to_c.py index ebeb7f9..f808f50 100755 --- a/src/host/fb_tools/bdf_to_c.py +++ b/src/host/fb_tools/bdf_to_c.py @@ -19,10 +19,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. from optparse import OptionParser import sys diff --git a/src/host/gprsdecode/gprs.c b/src/host/gprsdecode/gprs.c index ae59cf9..4ba91ea 100644 --- a/src/host/gprsdecode/gprs.c +++ b/src/host/gprsdecode/gprs.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/gprsdecode/gsmtap.c b/src/host/gprsdecode/gsmtap.c index 5c124b2..78d29e6 100644 --- a/src/host/gprsdecode/gsmtap.c +++ b/src/host/gprsdecode/gsmtap.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/gprsdecode/main.c b/src/host/gprsdecode/main.c index 7e09489..49484e2 100644 --- a/src/host/gprsdecode/main.c +++ b/src/host/gprsdecode/main.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/gprsdecode/rlcmac.c b/src/host/gprsdecode/rlcmac.c index d33cb1e..dc11fd3 100644 --- a/src/host/gprsdecode/rlcmac.c +++ b/src/host/gprsdecode/rlcmac.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/gsmmap/gsmmap.c b/src/host/gsmmap/gsmmap.c index 83f0d01..feb8501 100644 --- a/src/host/gsmmap/gsmmap.c +++ b/src/host/gsmmap/gsmmap.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #warning todo bsic #include diff --git a/src/host/gsmmap/log.c b/src/host/gsmmap/log.c index c2db801..97bef49 100644 --- a/src/host/gsmmap/log.c +++ b/src/host/gsmmap/log.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/include/osmocom/bb/common/gps.h b/src/host/layer23/include/osmocom/bb/common/gps.h index 58c0c53..e7ce915 100644 --- a/src/host/layer23/include/osmocom/bb/common/gps.h +++ b/src/host/layer23/include/osmocom/bb/common/gps.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ enum { diff --git a/src/host/layer23/include/osmocom/bb/common/sim.h b/src/host/layer23/include/osmocom/bb/common/sim.h index 8b1f830..bebcffe 100644 --- a/src/host/layer23/include/osmocom/bb/common/sim.h +++ b/src/host/layer23/include/osmocom/bb/common/sim.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/host/layer23/include/osmocom/bb/misc/cell_log.h b/src/host/layer23/include/osmocom/bb/misc/cell_log.h index bce066e..bef6e6e 100644 --- a/src/host/layer23/include/osmocom/bb/misc/cell_log.h +++ b/src/host/layer23/include/osmocom/bb/misc/cell_log.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ int scan_init(struct osmocom_ms *_ms); diff --git a/src/host/layer23/include/osmocom/bb/mobile/mncc.h b/src/host/layer23/include/osmocom/bb/mobile/mncc.h index 5e976cc..c373412 100644 --- a/src/host/layer23/include/osmocom/bb/mobile/mncc.h +++ b/src/host/layer23/include/osmocom/bb/mobile/mncc.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef _MNCC_H diff --git a/src/host/layer23/src/common/gps.c b/src/host/layer23/src/common/gps.c index 5225fe0..b6b547b 100644 --- a/src/host/layer23/src/common/gps.c +++ b/src/host/layer23/src/common/gps.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/l1ctl.c b/src/host/layer23/src/common/l1ctl.c index da30767..9af6167 100644 --- a/src/host/layer23/src/common/l1ctl.c +++ b/src/host/layer23/src/common/l1ctl.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/l1ctl_lapdm_glue.c b/src/host/layer23/src/common/l1ctl_lapdm_glue.c index 0b2a8ed..df02370 100644 --- a/src/host/layer23/src/common/l1ctl_lapdm_glue.c +++ b/src/host/layer23/src/common/l1ctl_lapdm_glue.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/l1l2_interface.c b/src/host/layer23/src/common/l1l2_interface.c index cd5f910..04a5dba 100644 --- a/src/host/layer23/src/common/l1l2_interface.c +++ b/src/host/layer23/src/common/l1l2_interface.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/logging.c b/src/host/layer23/src/common/logging.c index 636a615..96decf9 100644 --- a/src/host/layer23/src/common/logging.c +++ b/src/host/layer23/src/common/logging.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/host/layer23/src/common/main.c b/src/host/layer23/src/common/main.c index 9d1c69e..6781bae 100644 --- a/src/host/layer23/src/common/main.c +++ b/src/host/layer23/src/common/main.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/sap_fsm.c b/src/host/layer23/src/common/sap_fsm.c index 2265891..7e08836 100644 --- a/src/host/layer23/src/common/sap_fsm.c +++ b/src/host/layer23/src/common/sap_fsm.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/sap_interface.c b/src/host/layer23/src/common/sap_interface.c index 0eac896..c4f1453 100644 --- a/src/host/layer23/src/common/sap_interface.c +++ b/src/host/layer23/src/common/sap_interface.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/sap_proto.c b/src/host/layer23/src/common/sap_proto.c index ecacfe0..2e89182 100644 --- a/src/host/layer23/src/common/sap_proto.c +++ b/src/host/layer23/src/common/sap_proto.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/sim.c b/src/host/layer23/src/common/sim.c index 1e2bc51..131a1ef 100644 --- a/src/host/layer23/src/common/sim.c +++ b/src/host/layer23/src/common/sim.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index f927773..8103647 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/utils.c b/src/host/layer23/src/common/utils.c index 4ecb134..417519b 100644 --- a/src/host/layer23/src/common/utils.c +++ b/src/host/layer23/src/common/utils.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/app_bcch_scan.c b/src/host/layer23/src/misc/app_bcch_scan.c index 5946699..c0c158b 100644 --- a/src/host/layer23/src/misc/app_bcch_scan.c +++ b/src/host/layer23/src/misc/app_bcch_scan.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/app_cbch_sniff.c b/src/host/layer23/src/misc/app_cbch_sniff.c index ed85cef..e011a4d 100644 --- a/src/host/layer23/src/misc/app_cbch_sniff.c +++ b/src/host/layer23/src/misc/app_cbch_sniff.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/app_ccch_scan.c b/src/host/layer23/src/misc/app_ccch_scan.c index e5a184f..bde4dc3 100644 --- a/src/host/layer23/src/misc/app_ccch_scan.c +++ b/src/host/layer23/src/misc/app_ccch_scan.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/app_cell_log.c b/src/host/layer23/src/misc/app_cell_log.c index 5b7f7b4..97319fd 100644 --- a/src/host/layer23/src/misc/app_cell_log.c +++ b/src/host/layer23/src/misc/app_cell_log.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/app_echo_test.c b/src/host/layer23/src/misc/app_echo_test.c index 3a0ee0f..531f10c 100644 --- a/src/host/layer23/src/misc/app_echo_test.c +++ b/src/host/layer23/src/misc/app_echo_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/bcch_scan.c b/src/host/layer23/src/misc/bcch_scan.c index 5dc0bc3..69df043 100644 --- a/src/host/layer23/src/misc/bcch_scan.c +++ b/src/host/layer23/src/misc/bcch_scan.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/cell_log.c b/src/host/layer23/src/misc/cell_log.c index 9edd742..cf56a8d 100644 --- a/src/host/layer23/src/misc/cell_log.c +++ b/src/host/layer23/src/misc/cell_log.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/rslms.c b/src/host/layer23/src/misc/rslms.c index 455e663..b729c1c 100644 --- a/src/host/layer23/src/misc/rslms.c +++ b/src/host/layer23/src/misc/rslms.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c index a5feb79..0cb00c4 100644 --- a/src/host/layer23/src/mobile/app_mobile.c +++ b/src/host/layer23/src/mobile/app_mobile.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c index cc4f0cd..ea760b5 100644 --- a/src/host/layer23/src/mobile/gsm322.c +++ b/src/host/layer23/src/mobile/gsm322.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm411_sms.c b/src/host/layer23/src/mobile/gsm411_sms.c index 593a2ad..76355c0 100644 --- a/src/host/layer23/src/mobile/gsm411_sms.c +++ b/src/host/layer23/src/mobile/gsm411_sms.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm414.c b/src/host/layer23/src/mobile/gsm414.c index 2f630df..2fcf4dc 100644 --- a/src/host/layer23/src/mobile/gsm414.c +++ b/src/host/layer23/src/mobile/gsm414.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm480_ss.c b/src/host/layer23/src/mobile/gsm480_ss.c index 4ad2d7c..b68d542 100644 --- a/src/host/layer23/src/mobile/gsm480_ss.c +++ b/src/host/layer23/src/mobile/gsm480_ss.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm48_cc.c b/src/host/layer23/src/mobile/gsm48_cc.c index de0d035..a8d7a65 100644 --- a/src/host/layer23/src/mobile/gsm48_cc.c +++ b/src/host/layer23/src/mobile/gsm48_cc.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm48_mm.c b/src/host/layer23/src/mobile/gsm48_mm.c index 49cc2bc..80aff82 100644 --- a/src/host/layer23/src/mobile/gsm48_mm.c +++ b/src/host/layer23/src/mobile/gsm48_mm.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index e115d15..48c70f1 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* Very short description of some of the procedures: diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c index b1e0940..0602654 100644 --- a/src/host/layer23/src/mobile/main.c +++ b/src/host/layer23/src/mobile/main.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/mncc_sock.c b/src/host/layer23/src/mobile/mncc_sock.c index 5ea6feb..856b2c5 100644 --- a/src/host/layer23/src/mobile/mncc_sock.c +++ b/src/host/layer23/src/mobile/mncc_sock.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/mnccms.c b/src/host/layer23/src/mobile/mnccms.c index 9a37b97..3fec11e 100644 --- a/src/host/layer23/src/mobile/mnccms.c +++ b/src/host/layer23/src/mobile/mnccms.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/primitives.c b/src/host/layer23/src/mobile/primitives.c index f562466..4a40b4f 100644 --- a/src/host/layer23/src/mobile/primitives.c +++ b/src/host/layer23/src/mobile/primitives.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/script_lua.c b/src/host/layer23/src/mobile/script_lua.c index 50315bd..f8f2bf3 100644 --- a/src/host/layer23/src/mobile/script_lua.c +++ b/src/host/layer23/src/mobile/script_lua.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/script_nolua.c b/src/host/layer23/src/mobile/script_nolua.c index 61466f7..5973a44 100644 --- a/src/host/layer23/src/mobile/script_nolua.c +++ b/src/host/layer23/src/mobile/script_nolua.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/settings.c b/src/host/layer23/src/mobile/settings.c index 9742b1d..23da620 100644 --- a/src/host/layer23/src/mobile/settings.c +++ b/src/host/layer23/src/mobile/settings.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/subscriber.c b/src/host/layer23/src/mobile/subscriber.c index b2eacc5..500dd76 100644 --- a/src/host/layer23/src/mobile/subscriber.c +++ b/src/host/layer23/src/mobile/subscriber.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/support.c b/src/host/layer23/src/mobile/support.c index e9361a3..fd1ed74 100644 --- a/src/host/layer23/src/mobile/support.c +++ b/src/host/layer23/src/mobile/support.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/transaction.c b/src/host/layer23/src/mobile/transaction.c index 9824bd1..fd5a12d 100644 --- a/src/host/layer23/src/mobile/transaction.c +++ b/src/host/layer23/src/mobile/transaction.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/voice.c b/src/host/layer23/src/mobile/voice.c index c379265..7bcf8a6 100644 --- a/src/host/layer23/src/mobile/voice.c +++ b/src/host/layer23/src/mobile/voice.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index 073303c..57bc863 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c index d49c3fd..547f49f 100644 --- a/src/host/osmocon/osmocon.c +++ b/src/host/osmocon/osmocon.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/osmocon/osmoload.c b/src/host/osmocon/osmoload.c index d320b29..b2f14bb 100644 --- a/src/host/osmocon/osmoload.c +++ b/src/host/osmocon/osmoload.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/osmocon/tpu_debug.c b/src/host/osmocon/tpu_debug.c index 9160b01..82c8d30 100644 --- a/src/host/osmocon/tpu_debug.c +++ b/src/host/osmocon/tpu_debug.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c index 8083595..95ba9b6 100644 --- a/src/host/trxcon/l1ctl.c +++ b/src/host/trxcon/l1ctl.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/l1ctl_link.c b/src/host/trxcon/l1ctl_link.c index 4c406d6..552fc8b 100644 --- a/src/host/trxcon/l1ctl_link.c +++ b/src/host/trxcon/l1ctl_link.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/logging.c b/src/host/trxcon/logging.c index 78915f2..8352e6a 100644 --- a/src/host/trxcon/logging.c +++ b/src/host/trxcon/logging.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_common.c b/src/host/trxcon/sched_lchan_common.c index ae43ca9..ac6d262 100644 --- a/src/host/trxcon/sched_lchan_common.c +++ b/src/host/trxcon/sched_lchan_common.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_pdtch.c b/src/host/trxcon/sched_lchan_pdtch.c index bd02865..ad6a736 100644 --- a/src/host/trxcon/sched_lchan_pdtch.c +++ b/src/host/trxcon/sched_lchan_pdtch.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_rach.c b/src/host/trxcon/sched_lchan_rach.c index 25e1b44..76c0abb 100644 --- a/src/host/trxcon/sched_lchan_rach.c +++ b/src/host/trxcon/sched_lchan_rach.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_sch.c b/src/host/trxcon/sched_lchan_sch.c index 18d4c58..4d7804e 100644 --- a/src/host/trxcon/sched_lchan_sch.c +++ b/src/host/trxcon/sched_lchan_sch.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_tchf.c b/src/host/trxcon/sched_lchan_tchf.c index 0b38ea1..caf3586 100644 --- a/src/host/trxcon/sched_lchan_tchf.c +++ b/src/host/trxcon/sched_lchan_tchf.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_tchh.c b/src/host/trxcon/sched_lchan_tchh.c index 1079bb0..ae67de4 100644 --- a/src/host/trxcon/sched_lchan_tchh.c +++ b/src/host/trxcon/sched_lchan_tchh.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_xcch.c b/src/host/trxcon/sched_lchan_xcch.c index 78397fe..9fdbcc7 100644 --- a/src/host/trxcon/sched_lchan_xcch.c +++ b/src/host/trxcon/sched_lchan_xcch.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_prim.c b/src/host/trxcon/sched_prim.c index 9473320..e5554ea 100644 --- a/src/host/trxcon/sched_prim.c +++ b/src/host/trxcon/sched_prim.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_trx.c b/src/host/trxcon/sched_trx.c index adcf198..828787e 100644 --- a/src/host/trxcon/sched_trx.c +++ b/src/host/trxcon/sched_trx.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/trxcon.c b/src/host/trxcon/trxcon.c index 158e27f..d6ba0c4 100644 --- a/src/host/trxcon/trxcon.c +++ b/src/host/trxcon/trxcon.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/virt_phy/src/logging.c b/src/host/virt_phy/src/logging.c index f898a08..76caa27 100644 --- a/src/host/virt_phy/src/logging.c +++ b/src/host/virt_phy/src/logging.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/virt_phy/src/virt_prim_data.c b/src/host/virt_phy/src/virt_prim_data.c index 656ff80..f74a9fa 100644 --- a/src/host/virt_phy/src/virt_prim_data.c +++ b/src/host/virt_phy/src/virt_prim_data.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/virt_phy/src/virt_prim_fbsb.c b/src/host/virt_phy/src/virt_prim_fbsb.c index c14a448..9637ed9 100644 --- a/src/host/virt_phy/src/virt_prim_fbsb.c +++ b/src/host/virt_phy/src/virt_prim_fbsb.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/virt_phy/src/virt_prim_pm.c b/src/host/virt_phy/src/virt_prim_pm.c index 08d9b05..5a9a664 100644 --- a/src/host/virt_phy/src/virt_prim_pm.c +++ b/src/host/virt_phy/src/virt_prim_pm.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/virt_phy/src/virt_prim_rach.c b/src/host/virt_phy/src/virt_prim_rach.c index 94076cf..2813458 100644 --- a/src/host/virt_phy/src/virt_prim_rach.c +++ b/src/host/virt_phy/src/virt_prim_rach.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/virt_phy/src/virt_prim_traffic.c b/src/host/virt_phy/src/virt_prim_traffic.c index 0e08a12..1686ce9 100644 --- a/src/host/virt_phy/src/virt_prim_traffic.c +++ b/src/host/virt_phy/src/virt_prim_traffic.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/include/osmocom/core/bitvec.h b/src/shared/libosmocore/include/osmocom/core/bitvec.h index 9c000d0..d441c84 100644 --- a/src/shared/libosmocore/include/osmocom/core/bitvec.h +++ b/src/shared/libosmocore/include/osmocom/core/bitvec.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup bitvec Bit vectors diff --git a/src/shared/libosmocore/include/osmocom/core/conv.h b/src/shared/libosmocore/include/osmocom/core/conv.h index e5b2a97..e1e5c81 100644 --- a/src/shared/libosmocore/include/osmocom/core/conv.h +++ b/src/shared/libosmocore/include/osmocom/core/conv.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \defgroup conv Convolutional encoding and decoding routines diff --git a/src/shared/libosmocore/include/osmocom/core/crcXXgen.h.tpl b/src/shared/libosmocore/include/osmocom/core/crcXXgen.h.tpl index 89d083a..9d17e2d 100644 --- a/src/shared/libosmocore/include/osmocom/core/crcXXgen.h.tpl +++ b/src/shared/libosmocore/include/osmocom/core/crcXXgen.h.tpl @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #ifndef __OSMO_CRCXXGEN_H__ diff --git a/src/shared/libosmocore/include/osmocom/core/crcgen.h b/src/shared/libosmocore/include/osmocom/core/crcgen.h index 8e208a7..62c4545 100644 --- a/src/shared/libosmocore/include/osmocom/core/crcgen.h +++ b/src/shared/libosmocore/include/osmocom/core/crcgen.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #ifndef __OSMO_CRCGEN_H__ diff --git a/src/shared/libosmocore/include/osmocom/core/linuxrbtree.h b/src/shared/libosmocore/include/osmocom/core/linuxrbtree.h index 079f440..fccbf7e 100644 --- a/src/shared/libosmocore/include/osmocom/core/linuxrbtree.h +++ b/src/shared/libosmocore/include/osmocom/core/linuxrbtree.h @@ -12,10 +12,6 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - linux/include/linux/rbtree.h To use rbtrees you'll have to implement your own insert and search cores. diff --git a/src/shared/libosmocore/include/osmocom/core/msgb.h b/src/shared/libosmocore/include/osmocom/core/msgb.h index a1939ab..0390a96 100644 --- a/src/shared/libosmocore/include/osmocom/core/msgb.h +++ b/src/shared/libosmocore/include/osmocom/core/msgb.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/include/osmocom/core/msgfile.h b/src/shared/libosmocore/include/osmocom/core/msgfile.h index c5e67a4..d4e21f8 100644 --- a/src/shared/libosmocore/include/osmocom/core/msgfile.h +++ b/src/shared/libosmocore/include/osmocom/core/msgfile.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef MSG_FILE_H diff --git a/src/shared/libosmocore/include/osmocom/core/serial.h b/src/shared/libosmocore/include/osmocom/core/serial.h index 889bd8a..8810f33 100644 --- a/src/shared/libosmocore/include/osmocom/core/serial.h +++ b/src/shared/libosmocore/include/osmocom/core/serial.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \defgroup serial Utility functions to deal with serial ports diff --git a/src/shared/libosmocore/include/osmocom/core/timer.h b/src/shared/libosmocore/include/osmocom/core/timer.h index d37af80..bec2f05 100644 --- a/src/shared/libosmocore/include/osmocom/core/timer.h +++ b/src/shared/libosmocore/include/osmocom/core/timer.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup timer Osmocom timers diff --git a/src/shared/libosmocore/include/osmocom/core/timer_compat.h b/src/shared/libosmocore/include/osmocom/core/timer_compat.h index d86c109..2024087 100644 --- a/src/shared/libosmocore/include/osmocom/core/timer_compat.h +++ b/src/shared/libosmocore/include/osmocom/core/timer_compat.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup timer Osmocom timers diff --git a/src/shared/libosmocore/include/osmocom/core/write_queue.h b/src/shared/libosmocore/include/osmocom/core/write_queue.h index 816c036..c404164 100644 --- a/src/shared/libosmocore/include/osmocom/core/write_queue.h +++ b/src/shared/libosmocore/include/osmocom/core/write_queue.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef OSMO_WQUEUE_H #define OSMO_WQUEUE_H diff --git a/src/shared/libosmocore/include/osmocom/gsm/a5.h b/src/shared/libosmocore/include/osmocom/gsm/a5.h index 649dbab..807a2d8 100644 --- a/src/shared/libosmocore/include/osmocom/gsm/a5.h +++ b/src/shared/libosmocore/include/osmocom/gsm/a5.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #ifndef __OSMO_A5_H__ diff --git a/src/shared/libosmocore/include/osmocom/gsm/gsm0808.h b/src/shared/libosmocore/include/osmocom/gsm/gsm0808.h index 5380dd9..11c27b7 100644 --- a/src/shared/libosmocore/include/osmocom/gsm/gsm0808.h +++ b/src/shared/libosmocore/include/osmocom/gsm/gsm0808.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef OSMOCORE_GSM0808_H #define OSMOCORE_GSM0808_H diff --git a/src/shared/libosmocore/include/osmocom/gsm/gsm_utils.h b/src/shared/libosmocore/include/osmocom/gsm/gsm_utils.h index 6d31672..9e277d1 100644 --- a/src/shared/libosmocore/include/osmocom/gsm/gsm_utils.h +++ b/src/shared/libosmocore/include/osmocom/gsm/gsm_utils.h @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef GSM_UTILS_H diff --git a/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_08_58.h b/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_08_58.h index 57a8f68..41d65af 100644 --- a/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_08_58.h +++ b/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_08_58.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_12_21.h b/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_12_21.h index 694df93..76e8bd0 100644 --- a/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_12_21.h +++ b/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_12_21.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup oml diff --git a/src/shared/libosmocore/include/osmocom/vty/telnet_interface.h b/src/shared/libosmocore/include/osmocom/vty/telnet_interface.h index 3c22201..29e8e13 100644 --- a/src/shared/libosmocore/include/osmocom/vty/telnet_interface.h +++ b/src/shared/libosmocore/include/osmocom/vty/telnet_interface.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef TELNET_INTERFACE_H diff --git a/src/shared/libosmocore/include/osmocom/vty/vector.h b/src/shared/libosmocore/include/osmocom/vty/vector.h index 22a184d..f0d269c 100644 --- a/src/shared/libosmocore/include/osmocom/vty/vector.h +++ b/src/shared/libosmocore/include/osmocom/vty/vector.h @@ -13,10 +13,6 @@ * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with GNU Zebra; see the file COPYING. If not, write to the Free - * Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA * 02111-1307, USA. */ diff --git a/src/shared/libosmocore/src/application.c b/src/shared/libosmocore/src/application.c index e0d989e..98175fb 100644 --- a/src/shared/libosmocore/src/application.c +++ b/src/shared/libosmocore/src/application.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \file application.c diff --git a/src/shared/libosmocore/src/backtrace.c b/src/shared/libosmocore/src/backtrace.c index 5b93bec..53cece6 100644 --- a/src/shared/libosmocore/src/backtrace.c +++ b/src/shared/libosmocore/src/backtrace.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \file backtrace.c diff --git a/src/shared/libosmocore/src/bitvec.c b/src/shared/libosmocore/src/bitvec.c index 714c11b..1e3ee6a 100644 --- a/src/shared/libosmocore/src/bitvec.c +++ b/src/shared/libosmocore/src/bitvec.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup bitvec diff --git a/src/shared/libosmocore/src/codec/gsm610.c b/src/shared/libosmocore/src/codec/gsm610.c index 35f6011..faa8fb4 100644 --- a/src/shared/libosmocore/src/codec/gsm610.c +++ b/src/shared/libosmocore/src/codec/gsm610.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/codec/gsm620.c b/src/shared/libosmocore/src/codec/gsm620.c index fa570e4..67e1a8b 100644 --- a/src/shared/libosmocore/src/codec/gsm620.c +++ b/src/shared/libosmocore/src/codec/gsm620.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/codec/gsm660.c b/src/shared/libosmocore/src/codec/gsm660.c index c044a2a..bd00341 100644 --- a/src/shared/libosmocore/src/codec/gsm660.c +++ b/src/shared/libosmocore/src/codec/gsm660.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/codec/gsm690.c b/src/shared/libosmocore/src/codec/gsm690.c index fdf3302..8d94c5a 100644 --- a/src/shared/libosmocore/src/codec/gsm690.c +++ b/src/shared/libosmocore/src/codec/gsm690.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/conv.c b/src/shared/libosmocore/src/conv.c index ebc3eda..77c505c 100644 --- a/src/shared/libosmocore/src/conv.c +++ b/src/shared/libosmocore/src/conv.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup conv diff --git a/src/shared/libosmocore/src/crcXXgen.c.tpl b/src/shared/libosmocore/src/crcXXgen.c.tpl index 80bf1e2..b4486c5 100644 --- a/src/shared/libosmocore/src/crcXXgen.c.tpl +++ b/src/shared/libosmocore/src/crcXXgen.c.tpl @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup crcgen diff --git a/src/shared/libosmocore/src/gsm/a5.c b/src/shared/libosmocore/src/gsm/a5.c index 356060a..6001908 100644 --- a/src/shared/libosmocore/src/gsm/a5.c +++ b/src/shared/libosmocore/src/gsm/a5.c @@ -20,10 +20,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup a5 diff --git a/src/shared/libosmocore/src/gsm/auth_comp128v1.c b/src/shared/libosmocore/src/gsm/auth_comp128v1.c index 41aef71..14e44f4 100644 --- a/src/shared/libosmocore/src/gsm/auth_comp128v1.c +++ b/src/shared/libosmocore/src/gsm/auth_comp128v1.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/auth_core.c b/src/shared/libosmocore/src/gsm/auth_core.c index 5cf8dfc..de3d26a 100644 --- a/src/shared/libosmocore/src/gsm/auth_core.c +++ b/src/shared/libosmocore/src/gsm/auth_core.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/auth_milenage.c b/src/shared/libosmocore/src/gsm/auth_milenage.c index 5b2787d..cac1a05 100644 --- a/src/shared/libosmocore/src/gsm/auth_milenage.c +++ b/src/shared/libosmocore/src/gsm/auth_milenage.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/comp128.c b/src/shared/libosmocore/src/gsm/comp128.c index b7a2382..5aaf91f 100644 --- a/src/shared/libosmocore/src/gsm/comp128.c +++ b/src/shared/libosmocore/src/gsm/comp128.c @@ -26,10 +26,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* diff --git a/src/shared/libosmocore/src/gsm/gprs_cipher_core.c b/src/shared/libosmocore/src/gsm/gprs_cipher_core.c index b9a22a1..db3b084 100644 --- a/src/shared/libosmocore/src/gsm/gprs_cipher_core.c +++ b/src/shared/libosmocore/src/gsm/gprs_cipher_core.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/gsm0480.c b/src/shared/libosmocore/src/gsm/gsm0480.c index b9b3ed9..6a4dd29 100644 --- a/src/shared/libosmocore/src/gsm/gsm0480.c +++ b/src/shared/libosmocore/src/gsm/gsm0480.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/gsm0808.c b/src/shared/libosmocore/src/gsm/gsm0808.c index 3009827..55dc41c 100644 --- a/src/shared/libosmocore/src/gsm/gsm0808.c +++ b/src/shared/libosmocore/src/gsm/gsm0808.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/gsm48.c b/src/shared/libosmocore/src/gsm/gsm48.c index ea05d45..b1ef65a 100644 --- a/src/shared/libosmocore/src/gsm/gsm48.c +++ b/src/shared/libosmocore/src/gsm/gsm48.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/gsm48_ie.c b/src/shared/libosmocore/src/gsm/gsm48_ie.c index 78619b9..84252c6 100644 --- a/src/shared/libosmocore/src/gsm/gsm48_ie.c +++ b/src/shared/libosmocore/src/gsm/gsm48_ie.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/shared/libosmocore/src/gsm/gsm_utils.c b/src/shared/libosmocore/src/gsm/gsm_utils.c index 8b1fae0..4b170df 100644 --- a/src/shared/libosmocore/src/gsm/gsm_utils.c +++ b/src/shared/libosmocore/src/gsm/gsm_utils.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \mainpage libosmogsm Documentation diff --git a/src/shared/libosmocore/src/gsm/lapd_core.c b/src/shared/libosmocore/src/gsm/lapd_core.c index 96099ed..47a2a8d 100644 --- a/src/shared/libosmocore/src/gsm/lapd_core.c +++ b/src/shared/libosmocore/src/gsm/lapd_core.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup lapd diff --git a/src/shared/libosmocore/src/gsm/lapdm.c b/src/shared/libosmocore/src/gsm/lapdm.c index 1c08113..5e1c2d5 100644 --- a/src/shared/libosmocore/src/gsm/lapdm.c +++ b/src/shared/libosmocore/src/gsm/lapdm.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup lapdm diff --git a/src/shared/libosmocore/src/gsm/rsl.c b/src/shared/libosmocore/src/gsm/rsl.c index 5693b4f..366eae5 100644 --- a/src/shared/libosmocore/src/gsm/rsl.c +++ b/src/shared/libosmocore/src/gsm/rsl.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/rxlev_stat.c b/src/shared/libosmocore/src/gsm/rxlev_stat.c index d226861..fb3a2a5 100644 --- a/src/shared/libosmocore/src/gsm/rxlev_stat.c +++ b/src/shared/libosmocore/src/gsm/rxlev_stat.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsmtap_util.c b/src/shared/libosmocore/src/gsmtap_util.c index ce722da..12a1dcf 100644 --- a/src/shared/libosmocore/src/gsmtap_util.c +++ b/src/shared/libosmocore/src/gsmtap_util.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "../config.h" diff --git a/src/shared/libosmocore/src/logging.c b/src/shared/libosmocore/src/logging.c index f58265f..e187df2 100644 --- a/src/shared/libosmocore/src/logging.c +++ b/src/shared/libosmocore/src/logging.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* \addtogroup logging diff --git a/src/shared/libosmocore/src/logging_syslog.c b/src/shared/libosmocore/src/logging_syslog.c index 5b0ae5f..8bc2dfd 100644 --- a/src/shared/libosmocore/src/logging_syslog.c +++ b/src/shared/libosmocore/src/logging_syslog.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup logging diff --git a/src/shared/libosmocore/src/msgb.c b/src/shared/libosmocore/src/msgb.c index c8564db..4c703fe 100644 --- a/src/shared/libosmocore/src/msgb.c +++ b/src/shared/libosmocore/src/msgb.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup msgb diff --git a/src/shared/libosmocore/src/msgfile.c b/src/shared/libosmocore/src/msgfile.c index d2b180d..14929ed 100644 --- a/src/shared/libosmocore/src/msgfile.c +++ b/src/shared/libosmocore/src/msgfile.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/panic.c b/src/shared/libosmocore/src/panic.c index be644ff..1913403 100644 --- a/src/shared/libosmocore/src/panic.c +++ b/src/shared/libosmocore/src/panic.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup utils diff --git a/src/shared/libosmocore/src/plugin.c b/src/shared/libosmocore/src/plugin.c index 998bca3..9f17698 100644 --- a/src/shared/libosmocore/src/plugin.c +++ b/src/shared/libosmocore/src/plugin.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "../config.h" diff --git a/src/shared/libosmocore/src/rate_ctr.c b/src/shared/libosmocore/src/rate_ctr.c index 8a232e8..79d41dd 100644 --- a/src/shared/libosmocore/src/rate_ctr.c +++ b/src/shared/libosmocore/src/rate_ctr.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup rate_ctr diff --git a/src/shared/libosmocore/src/rbtree.c b/src/shared/libosmocore/src/rbtree.c index 4e7c0f3..2da7d7e 100644 --- a/src/shared/libosmocore/src/rbtree.c +++ b/src/shared/libosmocore/src/rbtree.c @@ -13,10 +13,6 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - linux/lib/rbtree.c */ diff --git a/src/shared/libosmocore/src/select.c b/src/shared/libosmocore/src/select.c index 6b73377..11f1a2a 100644 --- a/src/shared/libosmocore/src/select.c +++ b/src/shared/libosmocore/src/select.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include diff --git a/src/shared/libosmocore/src/serial.c b/src/shared/libosmocore/src/serial.c index a025ae9..780cf44 100644 --- a/src/shared/libosmocore/src/serial.c +++ b/src/shared/libosmocore/src/serial.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup serial diff --git a/src/shared/libosmocore/src/signal.c b/src/shared/libosmocore/src/signal.c index 6384384..6f8c798 100644 --- a/src/shared/libosmocore/src/signal.c +++ b/src/shared/libosmocore/src/signal.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/statistics.c b/src/shared/libosmocore/src/statistics.c index e28541b..d18f416 100644 --- a/src/shared/libosmocore/src/statistics.c +++ b/src/shared/libosmocore/src/statistics.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/timer.c b/src/shared/libosmocore/src/timer.c index 6d4abc2..55d08d3 100644 --- a/src/shared/libosmocore/src/timer.c +++ b/src/shared/libosmocore/src/timer.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* These store the amount of time that we wait until next timer expires. */ diff --git a/src/shared/libosmocore/src/vty/logging_vty.c b/src/shared/libosmocore/src/vty/logging_vty.c index 6029d58..4f13852 100644 --- a/src/shared/libosmocore/src/vty/logging_vty.c +++ b/src/shared/libosmocore/src/vty/logging_vty.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/vty/telnet_interface.c b/src/shared/libosmocore/src/vty/telnet_interface.c index 1abf141..821a649 100644 --- a/src/shared/libosmocore/src/vty/telnet_interface.c +++ b/src/shared/libosmocore/src/vty/telnet_interface.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/vty/utils.c b/src/shared/libosmocore/src/vty/utils.c index e9c0d2d..af49c30 100644 --- a/src/shared/libosmocore/src/vty/utils.c +++ b/src/shared/libosmocore/src/vty/utils.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/vty/vector.c b/src/shared/libosmocore/src/vty/vector.c index 4012f24..bda96d9 100644 --- a/src/shared/libosmocore/src/vty/vector.c +++ b/src/shared/libosmocore/src/vty/vector.c @@ -12,10 +12,6 @@ * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with GNU Zebra; see the file COPYING. If not, write to the Free - * Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA * 02111-1307, USA. */ diff --git a/src/shared/libosmocore/src/write_queue.c b/src/shared/libosmocore/src/write_queue.c index cef40f8..d353210 100644 --- a/src/shared/libosmocore/src/write_queue.c +++ b/src/shared/libosmocore/src/write_queue.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/gsm0408/gsm0408_test.c b/src/shared/libosmocore/tests/gsm0408/gsm0408_test.c index 077063b..e31d056 100644 --- a/src/shared/libosmocore/tests/gsm0408/gsm0408_test.c +++ b/src/shared/libosmocore/tests/gsm0408/gsm0408_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/gsm0808/gsm0808_test.c b/src/shared/libosmocore/tests/gsm0808/gsm0808_test.c index 7e5e97b..8cc0fbb 100644 --- a/src/shared/libosmocore/tests/gsm0808/gsm0808_test.c +++ b/src/shared/libosmocore/tests/gsm0808/gsm0808_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/lapd/lapd_test.c b/src/shared/libosmocore/tests/lapd/lapd_test.c index d58bec6..0bd89b7 100644 --- a/src/shared/libosmocore/tests/lapd/lapd_test.c +++ b/src/shared/libosmocore/tests/lapd/lapd_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/msgfile/msgfile_test.c b/src/shared/libosmocore/tests/msgfile/msgfile_test.c index ed7aa97..abea917 100644 --- a/src/shared/libosmocore/tests/msgfile/msgfile_test.c +++ b/src/shared/libosmocore/tests/msgfile/msgfile_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/sms/sms_test.c b/src/shared/libosmocore/tests/sms/sms_test.c index 6df4b62..18a7d1e 100644 --- a/src/shared/libosmocore/tests/sms/sms_test.c +++ b/src/shared/libosmocore/tests/sms/sms_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/smscb/smscb_test.c b/src/shared/libosmocore/tests/smscb/smscb_test.c index e10e12d..34178e2 100644 --- a/src/shared/libosmocore/tests/smscb/smscb_test.c +++ b/src/shared/libosmocore/tests/smscb/smscb_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/timer/timer_test.c b/src/shared/libosmocore/tests/timer/timer_test.c index ba3127d..7b973c0 100644 --- a/src/shared/libosmocore/tests/timer/timer_test.c +++ b/src/shared/libosmocore/tests/timer/timer_test.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/ussd/ussd_test.c b/src/shared/libosmocore/tests/ussd/ussd_test.c index 55384f1..0ddab90 100644 --- a/src/shared/libosmocore/tests/ussd/ussd_test.c +++ b/src/shared/libosmocore/tests/ussd/ussd_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/utils/osmo-arfcn.c b/src/shared/libosmocore/utils/osmo-arfcn.c index 15adbca..172ee54 100644 --- a/src/shared/libosmocore/utils/osmo-arfcn.c +++ b/src/shared/libosmocore/utils/osmo-arfcn.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/utils/osmo-auc-gen.c b/src/shared/libosmocore/utils/osmo-auc-gen.c index 7a3c124..449bcc6 100644 --- a/src/shared/libosmocore/utils/osmo-auc-gen.c +++ b/src/shared/libosmocore/utils/osmo-auc-gen.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/target/firmware/abb/twl3025.c b/src/target/firmware/abb/twl3025.c index 5b792d6..1c099dc 100644 --- a/src/target/firmware/abb/twl3025.c +++ b/src/target/firmware/abb/twl3025.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/compal_dsp_dump/main.c b/src/target/firmware/apps/compal_dsp_dump/main.c index 5e1ab68..e5521c3 100644 --- a/src/target/firmware/apps/compal_dsp_dump/main.c +++ b/src/target/firmware/apps/compal_dsp_dump/main.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/hello_world/main.c b/src/target/firmware/apps/hello_world/main.c index 481cf17..aeb5739 100644 --- a/src/target/firmware/apps/hello_world/main.c +++ b/src/target/firmware/apps/hello_world/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/layer1/main.c b/src/target/firmware/apps/layer1/main.c index b2e66e2..701d95f 100644 --- a/src/target/firmware/apps/layer1/main.c +++ b/src/target/firmware/apps/layer1/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/loader/main.c b/src/target/firmware/apps/loader/main.c index 9b7a1b5..e828fff 100644 --- a/src/target/firmware/apps/loader/main.c +++ b/src/target/firmware/apps/loader/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/loader_mtk/main.c b/src/target/firmware/apps/loader_mtk/main.c index f2ebbea..995d277 100644 --- a/src/target/firmware/apps/loader_mtk/main.c +++ b/src/target/firmware/apps/loader_mtk/main.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/menu/main.c b/src/target/firmware/apps/menu/main.c index fa36968..5d96cc0 100644 --- a/src/target/firmware/apps/menu/main.c +++ b/src/target/firmware/apps/menu/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index b04fe28..9a3f87c 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/simtest/main.c b/src/target/firmware/apps/simtest/main.c index e20c52a..d41891d 100755 --- a/src/target/firmware/apps/simtest/main.c +++ b/src/target/firmware/apps/simtest/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/snake_game/main.c b/src/target/firmware/apps/snake_game/main.c index 44dda9a..4945b6f 100644 --- a/src/target/firmware/apps/snake_game/main.c +++ b/src/target/firmware/apps/snake_game/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/battery/compal_e88.c b/src/target/firmware/battery/compal_e88.c index 609d406..42f77f2 100644 --- a/src/target/firmware/battery/compal_e88.c +++ b/src/target/firmware/battery/compal_e88.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* diff --git a/src/target/firmware/board/common/readcal_tiffs.c b/src/target/firmware/board/common/readcal_tiffs.c index 4351971..175f25a 100644 --- a/src/target/firmware/board/common/readcal_tiffs.c +++ b/src/target/firmware/board/common/readcal_tiffs.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/common/tx_calchan.c b/src/target/firmware/board/common/tx_calchan.c index 9901e71..b86464d 100644 --- a/src/target/firmware/board/common/tx_calchan.c +++ b/src/target/firmware/board/common/tx_calchan.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal/readcal_common.c b/src/target/firmware/board/compal/readcal_common.c index 2f7944c..c0260b6 100644 --- a/src/target/firmware/board/compal/readcal_common.c +++ b/src/target/firmware/board/compal/readcal_common.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal/readcal_small.c b/src/target/firmware/board/compal/readcal_small.c index a036e11..32302d2 100644 --- a/src/target/firmware/board/compal/readcal_small.c +++ b/src/target/firmware/board/compal/readcal_small.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal/rf_tables.c b/src/target/firmware/board/compal/rf_tables.c index dd7411d..f115f29 100644 --- a/src/target/firmware/board/compal/rf_tables.c +++ b/src/target/firmware/board/compal/rf_tables.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal_e86/init.c b/src/target/firmware/board/compal_e86/init.c index 725f184..82a96eb 100644 --- a/src/target/firmware/board/compal_e86/init.c +++ b/src/target/firmware/board/compal_e86/init.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal_e86/tx_ramps.c b/src/target/firmware/board/compal_e86/tx_ramps.c index 7bac4d5..195242a 100644 --- a/src/target/firmware/board/compal_e86/tx_ramps.c +++ b/src/target/firmware/board/compal_e86/tx_ramps.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal_e88/init.c b/src/target/firmware/board/compal_e88/init.c index 956f7dc..0937644 100755 --- a/src/target/firmware/board/compal_e88/init.c +++ b/src/target/firmware/board/compal_e88/init.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal_e88/tx_ramps.c b/src/target/firmware/board/compal_e88/tx_ramps.c index 846a21d..79b3180 100644 --- a/src/target/firmware/board/compal_e88/tx_ramps.c +++ b/src/target/firmware/board/compal_e88/tx_ramps.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal_e99/init.c b/src/target/firmware/board/compal_e99/init.c index 0271f16..18c94fd 100644 --- a/src/target/firmware/board/compal_e99/init.c +++ b/src/target/firmware/board/compal_e99/init.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal_e99/readcal.c b/src/target/firmware/board/compal_e99/readcal.c index c75e1fa..c4a113f 100644 --- a/src/target/firmware/board/compal_e99/readcal.c +++ b/src/target/firmware/board/compal_e99/readcal.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/fcdev3b/init.c b/src/target/firmware/board/fcdev3b/init.c index c070536..03bd6d7 100644 --- a/src/target/firmware/board/fcdev3b/init.c +++ b/src/target/firmware/board/fcdev3b/init.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/gta0x/afcparams.c b/src/target/firmware/board/gta0x/afcparams.c index ba48360..5bf68ac 100644 --- a/src/target/firmware/board/gta0x/afcparams.c +++ b/src/target/firmware/board/gta0x/afcparams.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/gta0x/init.c b/src/target/firmware/board/gta0x/init.c index 7fba756..49279d1 100644 --- a/src/target/firmware/board/gta0x/init.c +++ b/src/target/firmware/board/gta0x/init.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/gta0x/rf_tables.c b/src/target/firmware/board/gta0x/rf_tables.c index 9a08b3c..650c77c 100644 --- a/src/target/firmware/board/gta0x/rf_tables.c +++ b/src/target/firmware/board/gta0x/rf_tables.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/gtm900b/afcparams.c b/src/target/firmware/board/gtm900b/afcparams.c index ca8908d..9dbbe7e 100644 --- a/src/target/firmware/board/gtm900b/afcparams.c +++ b/src/target/firmware/board/gtm900b/afcparams.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/gtm900b/init.c b/src/target/firmware/board/gtm900b/init.c index 934e96e..58a1e1e 100644 --- a/src/target/firmware/board/gtm900b/init.c +++ b/src/target/firmware/board/gtm900b/init.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/mediatek/uart.c b/src/target/firmware/board/mediatek/uart.c index f9e3283..7b4c49a 100644 --- a/src/target/firmware/board/mediatek/uart.c +++ b/src/target/firmware/board/mediatek/uart.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/mt62xx/init.c b/src/target/firmware/board/mt62xx/init.c index dae38cf..baa6fcd 100644 --- a/src/target/firmware/board/mt62xx/init.c +++ b/src/target/firmware/board/mt62xx/init.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/pirelli_dpl10/init.c b/src/target/firmware/board/pirelli_dpl10/init.c index 1af6e7c..273a11d 100644 --- a/src/target/firmware/board/pirelli_dpl10/init.c +++ b/src/target/firmware/board/pirelli_dpl10/init.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/pirelli_dpl10/readcal.c b/src/target/firmware/board/pirelli_dpl10/readcal.c index 6a4670a..40f608f 100644 --- a/src/target/firmware/board/pirelli_dpl10/readcal.c +++ b/src/target/firmware/board/pirelli_dpl10/readcal.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/pirelli_dpl10/rf_tables.c b/src/target/firmware/board/pirelli_dpl10/rf_tables.c index 34fbbcb..a2d26b1 100644 --- a/src/target/firmware/board/pirelli_dpl10/rf_tables.c +++ b/src/target/firmware/board/pirelli_dpl10/rf_tables.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/se_j100/init.c b/src/target/firmware/board/se_j100/init.c index 0ae477a..6352b36 100644 --- a/src/target/firmware/board/se_j100/init.c +++ b/src/target/firmware/board/se_j100/init.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/se_j100/tx_ramps.c b/src/target/firmware/board/se_j100/tx_ramps.c index b1110e0..387febb 100644 --- a/src/target/firmware/board/se_j100/tx_ramps.c +++ b/src/target/firmware/board/se_j100/tx_ramps.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/backlight.c b/src/target/firmware/calypso/backlight.c index cf29984..ba41bac 100644 --- a/src/target/firmware/calypso/backlight.c +++ b/src/target/firmware/calypso/backlight.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/buzzer.c b/src/target/firmware/calypso/buzzer.c index e76906f..4d9e60b 100644 --- a/src/target/firmware/calypso/buzzer.c +++ b/src/target/firmware/calypso/buzzer.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/clock.c b/src/target/firmware/calypso/clock.c index 246b6e0..36a4ef1 100644 --- a/src/target/firmware/calypso/clock.c +++ b/src/target/firmware/calypso/clock.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/dma.c b/src/target/firmware/calypso/dma.c index 35c5be8..5580cb5 100644 --- a/src/target/firmware/calypso/dma.c +++ b/src/target/firmware/calypso/dma.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/dsp.c b/src/target/firmware/calypso/dsp.c index 235d359..430c991 100644 --- a/src/target/firmware/calypso/dsp.c +++ b/src/target/firmware/calypso/dsp.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/du.c b/src/target/firmware/calypso/du.c index 58783b0..776cd74 100644 --- a/src/target/firmware/calypso/du.c +++ b/src/target/firmware/calypso/du.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/i2c.c b/src/target/firmware/calypso/i2c.c index bf44178..ad7d584 100644 --- a/src/target/firmware/calypso/i2c.c +++ b/src/target/firmware/calypso/i2c.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/irq.c b/src/target/firmware/calypso/irq.c index 136fd55..335bdc4 100644 --- a/src/target/firmware/calypso/irq.c +++ b/src/target/firmware/calypso/irq.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/keypad.c b/src/target/firmware/calypso/keypad.c index c3c1810..e4d11fb 100644 --- a/src/target/firmware/calypso/keypad.c +++ b/src/target/firmware/calypso/keypad.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/rtc.c b/src/target/firmware/calypso/rtc.c index 45d759f..288a183 100644 --- a/src/target/firmware/calypso/rtc.c +++ b/src/target/firmware/calypso/rtc.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/sim.c b/src/target/firmware/calypso/sim.c index dc5885c..ddc9694 100644 --- a/src/target/firmware/calypso/sim.c +++ b/src/target/firmware/calypso/sim.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* Uncomment to debug sim */ diff --git a/src/target/firmware/calypso/spi.c b/src/target/firmware/calypso/spi.c index 049ac08..a9b937e 100644 --- a/src/target/firmware/calypso/spi.c +++ b/src/target/firmware/calypso/spi.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/timer.c b/src/target/firmware/calypso/timer.c index 1dd55f2..5141a83 100644 --- a/src/target/firmware/calypso/timer.c +++ b/src/target/firmware/calypso/timer.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/tpu.c b/src/target/firmware/calypso/tpu.c index cbeef84..d84136c 100644 --- a/src/target/firmware/calypso/tpu.c +++ b/src/target/firmware/calypso/tpu.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/tsp.c b/src/target/firmware/calypso/tsp.c index 5d24f48..22ec538 100644 --- a/src/target/firmware/calypso/tsp.c +++ b/src/target/firmware/calypso/tsp.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/uart.c b/src/target/firmware/calypso/uart.c index ec587de..8dd96da 100644 --- a/src/target/firmware/calypso/uart.c +++ b/src/target/firmware/calypso/uart.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/uwire.c b/src/target/firmware/calypso/uwire.c index ac8f15e..214433c 100644 --- a/src/target/firmware/calypso/uwire.c +++ b/src/target/firmware/calypso/uwire.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/comm/msgb.c b/src/target/firmware/comm/msgb.c index 08f5acb..c564e79 100644 --- a/src/target/firmware/comm/msgb.c +++ b/src/target/firmware/comm/msgb.c @@ -11,10 +11,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/target/firmware/comm/sercomm.c b/src/target/firmware/comm/sercomm.c index cebd37d..360dafe 100644 --- a/src/target/firmware/comm/sercomm.c +++ b/src/target/firmware/comm/sercomm.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/comm/sercomm_cons.c b/src/target/firmware/comm/sercomm_cons.c index e6b6934..275ca5a 100644 --- a/src/target/firmware/comm/sercomm_cons.c +++ b/src/target/firmware/comm/sercomm_cons.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/comm/timer.c b/src/target/firmware/comm/timer.c index ce4f06d..44ef551 100644 --- a/src/target/firmware/comm/timer.c +++ b/src/target/firmware/comm/timer.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_bw8.c b/src/target/firmware/fb/fb_bw8.c index 0fc12ee..95ea2df 100644 --- a/src/target/firmware/fb/fb_bw8.c +++ b/src/target/firmware/fb/fb_bw8.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_dummy.c b/src/target/firmware/fb/fb_dummy.c index cb053de..b34656f 100644 --- a/src/target/firmware/fb/fb_dummy.c +++ b/src/target/firmware/fb/fb_dummy.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_rgb332.c b/src/target/firmware/fb/fb_rgb332.c index 569ccc7..7347488 100644 --- a/src/target/firmware/fb/fb_rgb332.c +++ b/src/target/firmware/fb/fb_rgb332.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_s6b33b1x.c b/src/target/firmware/fb/fb_s6b33b1x.c index e36c547..28fe555 100644 --- a/src/target/firmware/fb/fb_s6b33b1x.c +++ b/src/target/firmware/fb/fb_s6b33b1x.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_ssd1783.c b/src/target/firmware/fb/fb_ssd1783.c index cacdce0..3b39ad0 100644 --- a/src/target/firmware/fb/fb_ssd1783.c +++ b/src/target/firmware/fb/fb_ssd1783.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_ssd1963.c b/src/target/firmware/fb/fb_ssd1963.c index 361434e..dee884d 100644 --- a/src/target/firmware/fb/fb_ssd1963.c +++ b/src/target/firmware/fb/fb_ssd1963.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_st7558.c b/src/target/firmware/fb/fb_st7558.c index f09b12b..a2c6f50 100644 --- a/src/target/firmware/fb/fb_st7558.c +++ b/src/target/firmware/fb/fb_st7558.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_td014.c b/src/target/firmware/fb/fb_td014.c index c7bde0c..b96fe94 100644 --- a/src/target/firmware/fb/fb_td014.c +++ b/src/target/firmware/fb/fb_td014.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/font.c b/src/target/firmware/fb/font.c index 18c1bfe..7ca9912 100644 --- a/src/target/firmware/fb/font.c +++ b/src/target/firmware/fb/font.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/framebuffer.c b/src/target/firmware/fb/framebuffer.c index ab54769..5132eea 100644 --- a/src/target/firmware/fb/framebuffer.c +++ b/src/target/firmware/fb/framebuffer.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/flash/cfi_flash.c b/src/target/firmware/flash/cfi_flash.c index 2f8cde0..e34fa77 100644 --- a/src/target/firmware/flash/cfi_flash.c +++ b/src/target/firmware/flash/cfi_flash.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/include/calypso/du.h b/src/target/firmware/include/calypso/du.h index f2eae09..8f71d01 100644 --- a/src/target/firmware/include/calypso/du.h +++ b/src/target/firmware/include/calypso/du.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef _CALYPSO_DU_H diff --git a/src/target/firmware/include/calypso/sim.h b/src/target/firmware/include/calypso/sim.h index 8f627b1..686e578 100755 --- a/src/target/firmware/include/calypso/sim.h +++ b/src/target/firmware/include/calypso/sim.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef _CALYPSO_SIM_H diff --git a/src/target/firmware/include/comm/timer.h b/src/target/firmware/include/comm/timer.h index d43b067..e7c518d 100644 --- a/src/target/firmware/include/comm/timer.h +++ b/src/target/firmware/include/comm/timer.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef TIMER_H diff --git a/src/target/firmware/include/mtk/emi.h b/src/target/firmware/include/mtk/emi.h index 1818499..ee1399c 100644 --- a/src/target/firmware/include/mtk/emi.h +++ b/src/target/firmware/include/mtk/emi.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef __MTK_EMI_H_ diff --git a/src/target/firmware/include/mtk/mt6235.h b/src/target/firmware/include/mtk/mt6235.h index fb9d368..2d36bee 100644 --- a/src/target/firmware/include/mtk/mt6235.h +++ b/src/target/firmware/include/mtk/mt6235.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef __MT6235_H diff --git a/src/target/firmware/include/mtk/system.h b/src/target/firmware/include/mtk/system.h index 4543029..9c28b56 100644 --- a/src/target/firmware/include/mtk/system.h +++ b/src/target/firmware/include/mtk/system.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef __MTK_SYSTEM_H_ diff --git a/src/target/firmware/layer1/afc.c b/src/target/firmware/layer1/afc.c index 1a198e3..f4533ad 100644 --- a/src/target/firmware/layer1/afc.c +++ b/src/target/firmware/layer1/afc.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/agc.c b/src/target/firmware/layer1/agc.c index b72a6e7..66e7f09 100644 --- a/src/target/firmware/layer1/agc.c +++ b/src/target/firmware/layer1/agc.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/async.c b/src/target/firmware/layer1/async.c index cb2a2a8..1f3d6f1 100644 --- a/src/target/firmware/layer1/async.c +++ b/src/target/firmware/layer1/async.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/avg.c b/src/target/firmware/layer1/avg.c index a4bf565..7211c21 100644 --- a/src/target/firmware/layer1/avg.c +++ b/src/target/firmware/layer1/avg.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/init.c b/src/target/firmware/layer1/init.c index e7fde23..602e228 100644 --- a/src/target/firmware/layer1/init.c +++ b/src/target/firmware/layer1/init.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/target/firmware/layer1/l23_api.c b/src/target/firmware/layer1/l23_api.c index 4621bfc..735d92a 100644 --- a/src/target/firmware/layer1/l23_api.c +++ b/src/target/firmware/layer1/l23_api.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #define DEBUG diff --git a/src/target/firmware/layer1/mframe_sched.c b/src/target/firmware/layer1/mframe_sched.c index fac84b4..478fd20 100644 --- a/src/target/firmware/layer1/mframe_sched.c +++ b/src/target/firmware/layer1/mframe_sched.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_fbsb.c b/src/target/firmware/layer1/prim_fbsb.c index 8eaeb5a..4f4c4fd 100644 --- a/src/target/firmware/layer1/prim_fbsb.c +++ b/src/target/firmware/layer1/prim_fbsb.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_freq.c b/src/target/firmware/layer1/prim_freq.c index d5b5df1..a6ddc54 100644 --- a/src/target/firmware/layer1/prim_freq.c +++ b/src/target/firmware/layer1/prim_freq.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_pm.c b/src/target/firmware/layer1/prim_pm.c index 5c8c491..11bee99 100644 --- a/src/target/firmware/layer1/prim_pm.c +++ b/src/target/firmware/layer1/prim_pm.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_rach.c b/src/target/firmware/layer1/prim_rach.c index e6ea656..9536e5f 100644 --- a/src/target/firmware/layer1/prim_rach.c +++ b/src/target/firmware/layer1/prim_rach.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_rx_nb.c b/src/target/firmware/layer1/prim_rx_nb.c index c90c98c..9656cf9 100644 --- a/src/target/firmware/layer1/prim_rx_nb.c +++ b/src/target/firmware/layer1/prim_rx_nb.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_tch.c b/src/target/firmware/layer1/prim_tch.c index 40ef8f3..0542e82 100644 --- a/src/target/firmware/layer1/prim_tch.c +++ b/src/target/firmware/layer1/prim_tch.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_tx_nb.c b/src/target/firmware/layer1/prim_tx_nb.c index 86e8224..cf4ea44 100644 --- a/src/target/firmware/layer1/prim_tx_nb.c +++ b/src/target/firmware/layer1/prim_tx_nb.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_utils.c b/src/target/firmware/layer1/prim_utils.c index 7beab5f..f19200e 100644 --- a/src/target/firmware/layer1/prim_utils.c +++ b/src/target/firmware/layer1/prim_utils.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/rfch.c b/src/target/firmware/layer1/rfch.c index 3c4e676..4c34416 100644 --- a/src/target/firmware/layer1/rfch.c +++ b/src/target/firmware/layer1/rfch.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/sched_gsmtime.c b/src/target/firmware/layer1/sched_gsmtime.c index 01e22ca..aec041e 100644 --- a/src/target/firmware/layer1/sched_gsmtime.c +++ b/src/target/firmware/layer1/sched_gsmtime.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/sync.c b/src/target/firmware/layer1/sync.c index 978546b..1b7eb32 100644 --- a/src/target/firmware/layer1/sync.c +++ b/src/target/firmware/layer1/sync.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/tdma_sched.c b/src/target/firmware/layer1/tdma_sched.c index 8812992..44b88b2 100644 --- a/src/target/firmware/layer1/tdma_sched.c +++ b/src/target/firmware/layer1/tdma_sched.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/toa.c b/src/target/firmware/layer1/toa.c index 7d80d95..4c9fff8 100644 --- a/src/target/firmware/layer1/toa.c +++ b/src/target/firmware/layer1/toa.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/tpu_window.c b/src/target/firmware/layer1/tpu_window.c index f4e76c1..7baa1d3 100644 --- a/src/target/firmware/layer1/tpu_window.c +++ b/src/target/firmware/layer1/tpu_window.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/lib/console.c b/src/target/firmware/lib/console.c index 6bc8fed..df2adab 100644 --- a/src/target/firmware/lib/console.c +++ b/src/target/firmware/lib/console.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/rf/mt6139.c b/src/target/firmware/rf/mt6139.c index d48e652..fab36ba 100644 --- a/src/target/firmware/rf/mt6139.c +++ b/src/target/firmware/rf/mt6139.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/rf/trf6151.c b/src/target/firmware/rf/trf6151.c index ec13928..5c995d6 100644 --- a/src/target/firmware/rf/trf6151.c +++ b/src/target/firmware/rf/trf6151.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/tiffs/init.c b/src/target/firmware/tiffs/init.c index 378f829..a6c38e3 100644 --- a/src/target/firmware/tiffs/init.c +++ b/src/target/firmware/tiffs/init.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/tiffs/readfile.c b/src/target/firmware/tiffs/readfile.c index c712c43..c93b106 100644 --- a/src/target/firmware/tiffs/readfile.c +++ b/src/target/firmware/tiffs/readfile.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/trx_toolkit/app_common.py b/src/target/trx_toolkit/app_common.py index 7f2f03c..531d8dc 100644 --- a/src/target/trx_toolkit/app_common.py +++ b/src/target/trx_toolkit/app_common.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log diff --git a/src/target/trx_toolkit/burst_fwd.py b/src/target/trx_toolkit/burst_fwd.py index 2e9e97b..f5a6d78 100644 --- a/src/target/trx_toolkit/burst_fwd.py +++ b/src/target/trx_toolkit/burst_fwd.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log diff --git a/src/target/trx_toolkit/burst_gen.py b/src/target/trx_toolkit/burst_gen.py index f93d868..22f7205 100755 --- a/src/target/trx_toolkit/burst_gen.py +++ b/src/target/trx_toolkit/burst_gen.py @@ -18,10 +18,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. APP_CR_HOLDERS = [("2017-2019", "Vadim Yanitskiy ")] diff --git a/src/target/trx_toolkit/burst_send.py b/src/target/trx_toolkit/burst_send.py index 4e16571..27f585e 100755 --- a/src/target/trx_toolkit/burst_send.py +++ b/src/target/trx_toolkit/burst_send.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. APP_CR_HOLDERS = [("2017-2018", "Vadim Yanitskiy ")] diff --git a/src/target/trx_toolkit/clck_gen.py b/src/target/trx_toolkit/clck_gen.py index 51f04a8..427eb88 100755 --- a/src/target/trx_toolkit/clck_gen.py +++ b/src/target/trx_toolkit/clck_gen.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. APP_CR_HOLDERS = [("2017-2019", "Vadim Yanitskiy ")] diff --git a/src/target/trx_toolkit/codec.py b/src/target/trx_toolkit/codec.py index 9387592..c570600 100644 --- a/src/target/trx_toolkit/codec.py +++ b/src/target/trx_toolkit/codec.py @@ -21,10 +21,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. from typing import Optional, Callable, Tuple, Any import abc diff --git a/src/target/trx_toolkit/ctrl_cmd.py b/src/target/trx_toolkit/ctrl_cmd.py index 7a2bfac..c6ac6d8 100755 --- a/src/target/trx_toolkit/ctrl_cmd.py +++ b/src/target/trx_toolkit/ctrl_cmd.py @@ -18,10 +18,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. APP_CR_HOLDERS = [("2017-2018", "Vadim Yanitskiy ")] diff --git a/src/target/trx_toolkit/ctrl_if.py b/src/target/trx_toolkit/ctrl_if.py index aaf1111..f9d30c1 100644 --- a/src/target/trx_toolkit/ctrl_if.py +++ b/src/target/trx_toolkit/ctrl_if.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log import time diff --git a/src/target/trx_toolkit/ctrl_if_trx.py b/src/target/trx_toolkit/ctrl_if_trx.py index c03dcc6..46a55c5 100644 --- a/src/target/trx_toolkit/ctrl_if_trx.py +++ b/src/target/trx_toolkit/ctrl_if_trx.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log diff --git a/src/target/trx_toolkit/data_dump.py b/src/target/trx_toolkit/data_dump.py index 8510e2d..8475ceb 100644 --- a/src/target/trx_toolkit/data_dump.py +++ b/src/target/trx_toolkit/data_dump.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log import struct diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py index 1cded9b..8e80894 100644 --- a/src/target/trx_toolkit/data_if.py +++ b/src/target/trx_toolkit/data_if.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py index 72e248d..898a4ae 100644 --- a/src/target/trx_toolkit/data_msg.py +++ b/src/target/trx_toolkit/data_msg.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import random import struct diff --git a/src/target/trx_toolkit/fake_pm.py b/src/target/trx_toolkit/fake_pm.py index 9331212..205596a 100644 --- a/src/target/trx_toolkit/fake_pm.py +++ b/src/target/trx_toolkit/fake_pm.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. from random import randint diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index 93ae64e..a8ad9df 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. APP_CR_HOLDERS = [("2017-2019", "Vadim Yanitskiy ")] diff --git a/src/target/trx_toolkit/gsm_shared.py b/src/target/trx_toolkit/gsm_shared.py index 7c50245..5f59ba6 100644 --- a/src/target/trx_toolkit/gsm_shared.py +++ b/src/target/trx_toolkit/gsm_shared.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. from enum import Enum diff --git a/src/target/trx_toolkit/rand_burst_gen.py b/src/target/trx_toolkit/rand_burst_gen.py index b9846ab..c474c75 100644 --- a/src/target/trx_toolkit/rand_burst_gen.py +++ b/src/target/trx_toolkit/rand_burst_gen.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import random diff --git a/src/target/trx_toolkit/test_codec.py b/src/target/trx_toolkit/test_codec.py index ca2f773..5049f52 100644 --- a/src/target/trx_toolkit/test_codec.py +++ b/src/target/trx_toolkit/test_codec.py @@ -19,10 +19,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import unittest import struct diff --git a/src/target/trx_toolkit/test_data_dump.py b/src/target/trx_toolkit/test_data_dump.py index f7b4fde..67ff32b 100644 --- a/src/target/trx_toolkit/test_data_dump.py +++ b/src/target/trx_toolkit/test_data_dump.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import unittest import tempfile diff --git a/src/target/trx_toolkit/test_data_msg.py b/src/target/trx_toolkit/test_data_msg.py index 24fda67..ec6c2ec 100644 --- a/src/target/trx_toolkit/test_data_msg.py +++ b/src/target/trx_toolkit/test_data_msg.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import unittest diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py index b48dffb..3390907 100644 --- a/src/target/trx_toolkit/transceiver.py +++ b/src/target/trx_toolkit/transceiver.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log diff --git a/src/target/trx_toolkit/trx_list.py b/src/target/trx_toolkit/trx_list.py index 0a55cc6..c476a7d 100644 --- a/src/target/trx_toolkit/trx_list.py +++ b/src/target/trx_toolkit/trx_list.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. class TRXList: """ Transceiver list implementation. diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py index 8b6f80c..c91e3e0 100755 --- a/src/target/trx_toolkit/trx_sniff.py +++ b/src/target/trx_toolkit/trx_sniff.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. APP_CR_HOLDERS = [("2018-2020", "Vadim Yanitskiy ")] diff --git a/src/target/trx_toolkit/trxd_proto.py b/src/target/trx_toolkit/trxd_proto.py index 21fe31e..a1bf1b5 100644 --- a/src/target/trx_toolkit/trxd_proto.py +++ b/src/target/trx_toolkit/trxd_proto.py @@ -20,10 +20,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import codec diff --git a/src/target/trx_toolkit/udp_link.py b/src/target/trx_toolkit/udp_link.py index 43a4815..c3f1476 100644 --- a/src/target/trx_toolkit/udp_link.py +++ b/src/target/trx_toolkit/udp_link.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import socket -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/26566 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I73be012c01c0108fb6951dbff91d50eb19b40c51 Gerrit-Change-Number: 26566 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:44:12 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:44:12 +0000 Subject: Change in libosmocore[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: Hello Jenkins Builder, tnt, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26550 to look at the new patch set (#2). Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I5050285e75cf120407a1d883e99b3c4bcae8ffd7 --- M include/osmocom/core/base64.h M include/osmocom/core/bitXXgen.h.tpl M include/osmocom/core/bitcomp.h M include/osmocom/core/bitvec.h M include/osmocom/core/conv.h M include/osmocom/core/crcXXgen.h.tpl M include/osmocom/core/crcgen.h M include/osmocom/core/exec.h M include/osmocom/core/isdnhdlc.h M include/osmocom/core/linuxrbtree.h M include/osmocom/core/loggingrb.h M include/osmocom/core/msgb.h M include/osmocom/core/msgfile.h M include/osmocom/core/serial.h M include/osmocom/core/sockaddr_str.h M include/osmocom/core/stats.h M include/osmocom/core/strrb.h M include/osmocom/core/thread.h M include/osmocom/core/timer.h M include/osmocom/core/timer_compat.h M include/osmocom/core/use_count.h M include/osmocom/core/write_queue.h M include/osmocom/gsm/a5.h M include/osmocom/gsm/bsslap.h M include/osmocom/gsm/bssmap_le.h M include/osmocom/gsm/cbsp.h M include/osmocom/gsm/gsm0808.h M include/osmocom/gsm/gsm0808_lcs.h M include/osmocom/gsm/gsm29118.h M include/osmocom/gsm/gsm29205.h M include/osmocom/gsm/gsm_utils.h M include/osmocom/gsm/i460_mux.h M include/osmocom/gsm/protocol/gsm_08_58.h M include/osmocom/gsm/protocol/gsm_12_21.h M include/osmocom/gsm/protocol/gsm_48_071.h M include/osmocom/gsm/protocol/gsm_49_031.h M include/osmocom/sim/class_tables.h M include/osmocom/usb/libusb.h M include/osmocom/vty/telnet_interface.h M include/osmocom/vty/vector.h M src/application.c M src/backtrace.c M src/base64.c M src/bitcomp.c M src/bits.c M src/bitvec.c M src/codec/ecu.c M src/codec/ecu_fr.c M src/codec/gsm610.c M src/codec/gsm620.c M src/codec/gsm660.c M src/codec/gsm690.c M src/coding/gsm0503_coding.c M src/coding/gsm0503_interleaving.c M src/coding/gsm0503_mapping.c M src/coding/gsm0503_parity.c M src/coding/gsm0503_tables.c M src/context.c M src/conv.c M src/conv_acc.c M src/conv_acc_generic.c M src/conv_acc_neon.c M src/conv_acc_neon_impl.h M src/conv_acc_sse.c M src/conv_acc_sse_avx.c M src/conv_acc_sse_impl.h M src/counter.c M src/crcXXgen.c.tpl M src/ctrl/control_cmd.c M src/ctrl/control_if.c M src/ctrl/control_vty.c M src/exec.c M src/fsm.c M src/gsm/a5.c M src/gsm/auth_comp128v1.c M src/gsm/auth_comp128v23.c M src/gsm/auth_core.c M src/gsm/auth_milenage.c M src/gsm/auth_xor.c M src/gsm/bsslap.c M src/gsm/bssmap_le.c M src/gsm/bts_features.c M src/gsm/cbsp.c M src/gsm/comp128.c M src/gsm/comp128v23.c M src/gsm/gea.c M src/gsm/gprs_cipher_core.c M src/gsm/gprs_gea.c M src/gsm/gsm0341.c M src/gsm/gsm0480.c M src/gsm/gsm0808.c M src/gsm/gsm23003.c M src/gsm/gsm23236.c M src/gsm/gsm29118.c M src/gsm/gsm29205.c M src/gsm/gsm48.c M src/gsm/gsm48_ie.c M src/gsm/gsm_utils.c M src/gsm/i460_mux.c M src/gsm/kasumi.c M src/gsm/kdf.c M src/gsm/lapd_core.c M src/gsm/lapdm.c M src/gsm/rsl.c M src/gsm/rxlev_stat.c M src/gsmtap_util.c M src/isdnhdlc.c M src/it_q.c M src/logging.c M src/logging_gsmtap.c M src/logging_syslog.c M src/logging_systemd.c M src/loggingrb.c M src/macaddr.c M src/mnl.c M src/msgb.c M src/msgfile.c M src/panic.c M src/plugin.c M src/rate_ctr.c M src/rbtree.c M src/select.c M src/sercomm.c M src/serial.c M src/signal.c M src/sim/card_fs_hpsim.c M src/sim/card_fs_isim.c M src/sim/card_fs_sim.c M src/sim/card_fs_tetra.c M src/sim/card_fs_uicc.c M src/sim/card_fs_usim.c M src/sim/class_tables.c M src/sim/core.c M src/sim/reader.c M src/sim/reader_pcsc.c M src/sockaddr_str.c M src/socket.c M src/stat_item.c M src/stats.c M src/stats_statsd.c M src/strrb.c M src/thread.c M src/timer.c M src/timer_clockgettime.c M src/timer_gettimeofday.c M src/usb/osmo_libusb.c M src/use_count.c M src/utils.c M src/vty/fsm_vty.c M src/vty/logging_vty.c M src/vty/stats_vty.c M src/vty/talloc_ctx_vty.c M src/vty/telnet_interface.c M src/vty/utils.c M src/vty/vector.c M src/write_queue.c M tests/abis/abis_test.c M tests/coding/coding_test.c M tests/dtx/dtx_gsm0503_test.c M tests/fr/fr_test.c M tests/gsm0408/gsm0408_test.c M tests/gsm0502/gsm0502_test.c M tests/gsm0808/gsm0808_test.c M tests/gsm23003/gsm23003_test.c M tests/gsm23236/gsm23236_test.c M tests/gsm29205/gsm29205_test.c M tests/gsm48/rest_octets_test.c M tests/lapd/lapd_test.c M tests/logging/logging_test.c M tests/logging/logging_vty_test.c M tests/loggingrb/loggingrb_test.c M tests/msgb/msgb_test.c M tests/msgfile/msgfile_test.c M tests/oap/oap_test.c M tests/sercomm/sercomm_test.c M tests/sim/sim_test.c M tests/sms/sms_test.c M tests/smscb/gsm0341_test.c M tests/smscb/smscb_test.c M tests/sockaddr_str/sockaddr_str_test.c M tests/socket/socket_sctp_test.c M tests/socket/socket_test.c M tests/stats/stats_test.c M tests/strrb/strrb_test.c M tests/tdef/tdef_test.c M tests/tdef/tdef_vty_config_root_test.c M tests/tdef/tdef_vty_config_subnode_test.c M tests/tdef/tdef_vty_dynamic_test.c M tests/timer/clk_override_test.c M tests/timer/timer_test.c M tests/use_count/use_count_test.c M tests/use_count/use_count_test.err M tests/ussd/ussd_test.c M tests/utils/utils_test.c M tests/vty/vty_test.c M tests/vty/vty_transcript_test.c M utils/conv_gen.py M utils/osmo-arfcn.c M utils/osmo-auc-gen.c M utils/osmo-config-merge.c M utils/osmo-sim-test.c 201 files changed, 5 insertions(+), 817 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/26550/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26550 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5050285e75cf120407a1d883e99b3c4bcae8ffd7 Gerrit-Change-Number: 26550 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:44:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:44:21 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 ) Change subject: bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 Gerrit-Change-Number: 26535 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:44:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:44:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:44:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-{msc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 ) Change subject: msc/osmo-{msc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6414d5622fb287fd147c09e791e1b8023d1596e Gerrit-Change-Number: 26536 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:44:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:44:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:44:41 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-{bsc, bts}.cfg: tune logging configuration In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 ) Change subject: bts/osmo-{bsc,bts}.cfg: tune logging configuration ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 Gerrit-Change-Number: 26523 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:44:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:44:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:44:54 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 ) Change subject: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08580e5d8313e644908c1d7b370c5de882f3735c Gerrit-Change-Number: 26537 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:44:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:46:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:46:30 +0000 Subject: Change in simtrace2[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26547 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie0a3b2273383adbb3303faffd6ff96be7f4cae99 Gerrit-Change-Number: 26547 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Tue, 14 Dec 2021 11:46:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:46:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:46:46 +0000 Subject: Change in libosmo-abis[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26548 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0ad20cdf1e571c1a15f6e67d46e07155a6a02520 Gerrit-Change-Number: 26548 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Tue, 14 Dec 2021 11:46:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:47:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:47:03 +0000 Subject: Change in ...osmo-python-tests[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/26558 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/26558 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Ifd7b7e548c9c6db140fa8cbc8a3c8dfaf4603d18 Gerrit-Change-Number: 26558 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:47:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:47:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:47:09 +0000 Subject: Change in osmo-hlr[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/26553 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/26553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4b20c685b6370bf5dc472a42664e2665eb0d8f8c Gerrit-Change-Number: 26553 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:47:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:47:13 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:47:13 +0000 Subject: Change in osmo-mgw[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26555 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26555 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2a623f67e116d5e56091ae5860ca2a305c57e50a Gerrit-Change-Number: 26555 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:47:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:47:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:47:17 +0000 Subject: Change in osmo-trx[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/26563 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/26563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8ba71ab9ccde4ba25151ecbeb2a323f706b57d43 Gerrit-Change-Number: 26563 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: dexter Gerrit-Reviewer: ipse Gerrit-Reviewer: pespin Gerrit-Reviewer: ttsou Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 14 Dec 2021 11:47:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:47:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:47:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26564 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ab8f1e79fcc38d889cce4eac2e90cd4e5582b1b Gerrit-Change-Number: 26564 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:47:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:47:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:47:41 +0000 Subject: Change in osmo-sysmon[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26562 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I1f6db5f930fe97ce2336bce416470b807d7a57b7 Gerrit-Change-Number: 26562 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:47:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:47:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:47:55 +0000 Subject: Change in osmo-remsim[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26559 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2e98f89f6738d03c45a2106820af0912692093f3 Gerrit-Change-Number: 26559 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:47:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:48:00 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:48:00 +0000 Subject: Change in osmo-bsc[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26551 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifbbafe185931c0f508ff8148ef244f25a9620fd8 Gerrit-Change-Number: 26551 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-Reviewer: zecke Gerrit-Comment-Date: Tue, 14 Dec 2021 11:48:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:48:05 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:48:05 +0000 Subject: Change in osmocom-bb[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/26566 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/26566 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I73be012c01c0108fb6951dbff91d50eb19b40c51 Gerrit-Change-Number: 26566 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: BastusIII Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: steve-m Gerrit-Comment-Date: Tue, 14 Dec 2021 11:48:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:48:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:48:09 +0000 Subject: Change in osmo-bts[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26552 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26552 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I12b250e16426b125124def49e124e40ae93d0d58 Gerrit-Change-Number: 26552 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:48:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:48:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:48:14 +0000 Subject: Change in osmo-smlc[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26561 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26561 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ieb4f9b4ad5073c9b5996cb960b248c450fd5f2dd Gerrit-Change-Number: 26561 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:48:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:48:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:48:18 +0000 Subject: Change in osmo-iuh[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26554 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I340ab63093138ada6e80edf322e401e9fbfef4ed Gerrit-Change-Number: 26554 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:48:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:48:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:48:21 +0000 Subject: Change in osmo-msc[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26556 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1b68e0aa26d81fbfe26abaa287d2bd5eec2cfd0f Gerrit-Change-Number: 26556 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:48:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:48:25 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:48:25 +0000 Subject: Change in osmo-pcu[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26557 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26557 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4a49dbeeec89b22624c968152118aecf8886dac6 Gerrit-Change-Number: 26557 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Ivan Kluchnikov Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:48:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:48:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:48:29 +0000 Subject: Change in osmo-sgsn[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26560 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9bc57a7152015e0f37e3d1573921d6d5d3c0449b Gerrit-Change-Number: 26560 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:48:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:48:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:48:33 +0000 Subject: Change in libosmocore[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26550 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26550 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5050285e75cf120407a1d883e99b3c4bcae8ffd7 Gerrit-Change-Number: 26550 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Tue, 14 Dec 2021 11:48:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:49:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 11:49:14 +0000 Subject: Change in libosmo-sccp[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26549 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia450b630e0b60b38835f599c93985bbe97c50d2f Gerrit-Change-Number: 26549 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 11:49:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 11:53:45 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 11:53:45 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch: tweak FSF_MAILING_ADDRESS error References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26567 ) Change subject: lint: checkpatch: tweak FSF_MAILING_ADDRESS error ...................................................................... lint: checkpatch: tweak FSF_MAILING_ADDRESS error Change-Id: Ic76132c40a9c30a167c24c4c4b53180c4cc0fb86 --- M lint/checkpatch/checkpatch.pl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/67/26567/1 diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl index a4d229c..51c406e 100755 --- a/lint/checkpatch/checkpatch.pl +++ b/lint/checkpatch/checkpatch.pl @@ -3437,7 +3437,7 @@ my $msg_level = \&ERROR; $msg_level = \&CHK if ($file); &{$msg_level}("FSF_MAILING_ADDRESS", - "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet) + "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.\n" . $herevet) } # check for Kconfig help text having a real description -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26567 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic76132c40a9c30a167c24c4c4b53180c4cc0fb86 Gerrit-Change-Number: 26567 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:49:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:49:29 +0000 Subject: Change in simtrace2[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26547 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie0a3b2273383adbb3303faffd6ff96be7f4cae99 Gerrit-Change-Number: 26547 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Tue, 14 Dec 2021 12:49:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:49:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:49:36 +0000 Subject: Change in simtrace2[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26547 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: Ie0a3b2273383adbb3303faffd6ff96be7f4cae99 --- M firmware/apps/blupdate/main.c M firmware/apps/cardem/main.c M firmware/apps/dfu/main.c M firmware/apps/trace/main.c M firmware/apps/triple_play/main.c M firmware/atmel_softpack_libraries/usb/device/dfu/dfu_driver.c M firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c M firmware/libboard/common/include/board_common.h M firmware/libboard/common/include/boardver_adc.h M firmware/libboard/common/include/led.h M firmware/libboard/common/include/manifest.h M firmware/libboard/common/include/sim_switch.h M firmware/libboard/common/source/boardver_adc.c M firmware/libboard/common/source/led.c M firmware/libboard/common/source/manifest.c M firmware/libboard/ngff_cardem/include/board.h M firmware/libboard/ngff_cardem/include/card_pres.h M firmware/libboard/ngff_cardem/include/wwan_led.h M firmware/libboard/ngff_cardem/include/wwan_perst.h M firmware/libboard/ngff_cardem/source/board_ngff_cardem.c M firmware/libboard/ngff_cardem/source/card_pres.c M firmware/libboard/ngff_cardem/source/sim_switch.c M firmware/libboard/ngff_cardem/source/wwan_led.c M firmware/libboard/ngff_cardem/source/wwan_perst.c M firmware/libboard/octsimtest/include/board.h M firmware/libboard/octsimtest/include/i2c.h M firmware/libboard/octsimtest/include/mcp23017.h M firmware/libboard/octsimtest/source/board_octsimtest.c M firmware/libboard/octsimtest/source/i2c.c M firmware/libboard/octsimtest/source/mux.c M firmware/libboard/octsimtest/source/sim_switch.c M firmware/libboard/owhw/include/board.h M firmware/libboard/owhw/source/owhw.c M firmware/libboard/owhw/source/sim_switch.c M firmware/libboard/qmod/include/board.h M firmware/libboard/qmod/include/card_pres.h M firmware/libboard/qmod/include/i2c.h M firmware/libboard/qmod/include/wwan_led.h M firmware/libboard/qmod/include/wwan_perst.h M firmware/libboard/qmod/source/board_qmod.c M firmware/libboard/qmod/source/card_pres.c M firmware/libboard/qmod/source/i2c.c M firmware/libboard/qmod/source/sim_switch.c M firmware/libboard/qmod/source/wwan_led.c M firmware/libboard/qmod/source/wwan_perst.c M firmware/libboard/sam3p256/include/board.h M firmware/libboard/sam3p256/source/board_sam3p256.c M firmware/libboard/simtrace/include/board.h M firmware/libboard/simtrace/source/board_simtrace.c M firmware/libboard/simtrace/source/sim_switch.c M firmware/libcommon/include/card_emu.h M firmware/libcommon/include/iso7816_fidi.h M firmware/libcommon/include/llist_irqsafe.h M firmware/libcommon/include/ringbuffer.h M firmware/libcommon/include/simtrace.h M firmware/libcommon/include/simtrace_prot.h M firmware/libcommon/include/simtrace_usb.h M firmware/libcommon/include/talloc.h M firmware/libcommon/include/usb_buf.h M firmware/libcommon/include/utils.h M firmware/libcommon/source/card_emu.c M firmware/libcommon/source/fputs.c M firmware/libcommon/source/host_communication.c M firmware/libcommon/source/iso7816_fidi.c M firmware/libcommon/source/main_common.c M firmware/libcommon/source/mode_cardemu.c M firmware/libcommon/source/pseudo_talloc.c M firmware/libcommon/source/ringbuffer.c M firmware/libcommon/source/sniffer.c M firmware/libcommon/source/tc_etu.c M firmware/libcommon/source/usb_buf.c M firmware/libosmocore/include/osmocom/core/bit16gen.h M firmware/libosmocore/include/osmocom/core/bit32gen.h M firmware/libosmocore/include/osmocom/core/bit64gen.h M firmware/libosmocore/include/osmocom/core/linuxrbtree.h M firmware/libosmocore/include/osmocom/core/msgb.h M firmware/libosmocore/include/osmocom/core/timer.h M firmware/libosmocore/source/backtrace.c M firmware/libosmocore/source/bits.c M firmware/libosmocore/source/msgb.c M firmware/libosmocore/source/panic.c M firmware/libosmocore/source/rbtree.c M firmware/libosmocore/source/timer.c M firmware/libosmocore/source/utils.c M firmware/usbstring/usbstring.c M host/include/osmocom/simtrace2/apdu_dispatch.h M host/lib/apdu_dispatch.c M host/lib/gsmtap.c M host/lib/simtrace2_api.c M host/lib/usb_util.c M host/src/simtrace2-cardem-pcsc.c M host/src/simtrace2-sniff.c M host/src/simtrace2-tool.c M host/src/simtrace2_usb.c 94 files changed, 0 insertions(+), 376 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/firmware/apps/blupdate/main.c b/firmware/apps/blupdate/main.c index 330d040..e9ffe22 100644 --- a/firmware/apps/blupdate/main.c +++ b/firmware/apps/blupdate/main.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include "board.h" #include "core_cm3.h" diff --git a/firmware/apps/cardem/main.c b/firmware/apps/cardem/main.c index 95967ba..d212d2a 100644 --- a/firmware/apps/cardem/main.c +++ b/firmware/apps/cardem/main.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ /*------------------------------------------------------------------------------ * Headers diff --git a/firmware/apps/dfu/main.c b/firmware/apps/dfu/main.c index 48ba879..ef58ec2 100644 --- a/firmware/apps/dfu/main.c +++ b/firmware/apps/dfu/main.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include "board.h" #include "utils.h" diff --git a/firmware/apps/trace/main.c b/firmware/apps/trace/main.c index 08d6120..ec84b5a 100644 --- a/firmware/apps/trace/main.c +++ b/firmware/apps/trace/main.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ /*------------------------------------------------------------------------------ * Headers diff --git a/firmware/apps/triple_play/main.c b/firmware/apps/triple_play/main.c index d22687e..b853cdb 100644 --- a/firmware/apps/triple_play/main.c +++ b/firmware/apps/triple_play/main.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ /*------------------------------------------------------------------------------ * Headers diff --git a/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_driver.c b/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_driver.c index cfb9f63..afec518 100644 --- a/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_driver.c +++ b/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_driver.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * */ #include diff --git a/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c b/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c index f2cf64c..6e16a86 100644 --- a/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c +++ b/firmware/atmel_softpack_libraries/usb/device/dfu/dfu_runtime.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * */ #include diff --git a/firmware/libboard/common/include/board_common.h b/firmware/libboard/common/include/board_common.h index 7c4b908..37fd1a3 100644 --- a/firmware/libboard/common/include/board_common.h +++ b/firmware/libboard/common/include/board_common.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #ifndef _BOARD_ #define _BOARD_ diff --git a/firmware/libboard/common/include/boardver_adc.h b/firmware/libboard/common/include/boardver_adc.h index 956c302..c8f320e 100644 --- a/firmware/libboard/common/include/boardver_adc.h +++ b/firmware/libboard/common/include/boardver_adc.h @@ -7,10 +7,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/common/include/led.h b/firmware/libboard/common/include/led.h index 1ade823..ab12448 100644 --- a/firmware/libboard/common/include/led.h +++ b/firmware/libboard/common/include/led.h @@ -7,10 +7,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/common/include/manifest.h b/firmware/libboard/common/include/manifest.h index b29c1aa..0635bf9 100644 --- a/firmware/libboard/common/include/manifest.h +++ b/firmware/libboard/common/include/manifest.h @@ -7,10 +7,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #ifndef _MANIFEST_H #define _MANIFEST_H diff --git a/firmware/libboard/common/include/sim_switch.h b/firmware/libboard/common/include/sim_switch.h index 4439fa5..61d9c1f 100644 --- a/firmware/libboard/common/include/sim_switch.h +++ b/firmware/libboard/common/include/sim_switch.h @@ -7,10 +7,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/common/source/boardver_adc.c b/firmware/libboard/common/source/boardver_adc.c index 11799cc..9c7769d 100644 --- a/firmware/libboard/common/source/boardver_adc.c +++ b/firmware/libboard/common/source/boardver_adc.c @@ -7,10 +7,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "boardver_adc.h" diff --git a/firmware/libboard/common/source/led.c b/firmware/libboard/common/source/led.c index 4822a6d..8fcb61f 100644 --- a/firmware/libboard/common/source/led.c +++ b/firmware/libboard/common/source/led.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include diff --git a/firmware/libboard/common/source/manifest.c b/firmware/libboard/common/source/manifest.c index 0ad537c..fb3870f 100644 --- a/firmware/libboard/common/source/manifest.c +++ b/firmware/libboard/common/source/manifest.c @@ -7,10 +7,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "manifest.h" diff --git a/firmware/libboard/ngff_cardem/include/board.h b/firmware/libboard/ngff_cardem/include/board.h index 8be7b7f..f74cea1 100644 --- a/firmware/libboard/ngff_cardem/include/board.h +++ b/firmware/libboard/ngff_cardem/include/board.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once #include "board_common.h" diff --git a/firmware/libboard/ngff_cardem/include/card_pres.h b/firmware/libboard/ngff_cardem/include/card_pres.h index 81f0613..e06642e 100644 --- a/firmware/libboard/ngff_cardem/include/card_pres.h +++ b/firmware/libboard/ngff_cardem/include/card_pres.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/ngff_cardem/include/wwan_led.h b/firmware/libboard/ngff_cardem/include/wwan_led.h index 77887c7..a0f060a 100644 --- a/firmware/libboard/ngff_cardem/include/wwan_led.h +++ b/firmware/libboard/ngff_cardem/include/wwan_led.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/ngff_cardem/include/wwan_perst.h b/firmware/libboard/ngff_cardem/include/wwan_perst.h index c934afc..623184e 100644 --- a/firmware/libboard/ngff_cardem/include/wwan_perst.h +++ b/firmware/libboard/ngff_cardem/include/wwan_perst.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c b/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c index 0ac9cd8..fea64d3 100644 --- a/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c +++ b/firmware/libboard/ngff_cardem/source/board_ngff_cardem.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "simtrace.h" diff --git a/firmware/libboard/ngff_cardem/source/card_pres.c b/firmware/libboard/ngff_cardem/source/card_pres.c index 7d6c483..d425ec5 100644 --- a/firmware/libboard/ngff_cardem/source/card_pres.c +++ b/firmware/libboard/ngff_cardem/source/card_pres.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include "board.h" diff --git a/firmware/libboard/ngff_cardem/source/sim_switch.c b/firmware/libboard/ngff_cardem/source/sim_switch.c index cc4860a..999d7a7 100644 --- a/firmware/libboard/ngff_cardem/source/sim_switch.c +++ b/firmware/libboard/ngff_cardem/source/sim_switch.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "trace.h" diff --git a/firmware/libboard/ngff_cardem/source/wwan_led.c b/firmware/libboard/ngff_cardem/source/wwan_led.c index 36eb0ec..619d5c8 100644 --- a/firmware/libboard/ngff_cardem/source/wwan_led.c +++ b/firmware/libboard/ngff_cardem/source/wwan_led.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ /* Depending on the board this is running on, it might be possible * for the controller to read the status of the WWAN LED output lines of diff --git a/firmware/libboard/ngff_cardem/source/wwan_perst.c b/firmware/libboard/ngff_cardem/source/wwan_perst.c index 95a7c7b..b314781 100644 --- a/firmware/libboard/ngff_cardem/source/wwan_perst.c +++ b/firmware/libboard/ngff_cardem/source/wwan_perst.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ /* Depending on the board this is running on, it might be possible * for the controller to set the status of the PERST input line of diff --git a/firmware/libboard/octsimtest/include/board.h b/firmware/libboard/octsimtest/include/board.h index 697619c..3540aa2 100644 --- a/firmware/libboard/octsimtest/include/board.h +++ b/firmware/libboard/octsimtest/include/board.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once #include "board_common.h" diff --git a/firmware/libboard/octsimtest/include/i2c.h b/firmware/libboard/octsimtest/include/i2c.h index 6c94d26..7edad2f 100644 --- a/firmware/libboard/octsimtest/include/i2c.h +++ b/firmware/libboard/octsimtest/include/i2c.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/octsimtest/include/mcp23017.h b/firmware/libboard/octsimtest/include/mcp23017.h index 190588f..1f05d3d 100644 --- a/firmware/libboard/octsimtest/include/mcp23017.h +++ b/firmware/libboard/octsimtest/include/mcp23017.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/octsimtest/source/board_octsimtest.c b/firmware/libboard/octsimtest/source/board_octsimtest.c index d8b1cc4..92496da 100644 --- a/firmware/libboard/octsimtest/source/board_octsimtest.c +++ b/firmware/libboard/octsimtest/source/board_octsimtest.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include "board.h" diff --git a/firmware/libboard/octsimtest/source/i2c.c b/firmware/libboard/octsimtest/source/i2c.c index 2cd8423..8627b69 100644 --- a/firmware/libboard/octsimtest/source/i2c.c +++ b/firmware/libboard/octsimtest/source/i2c.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include diff --git a/firmware/libboard/octsimtest/source/mux.c b/firmware/libboard/octsimtest/source/mux.c index 8800ba2..d37adfb 100644 --- a/firmware/libboard/octsimtest/source/mux.c +++ b/firmware/libboard/octsimtest/source/mux.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" diff --git a/firmware/libboard/octsimtest/source/sim_switch.c b/firmware/libboard/octsimtest/source/sim_switch.c index 2b60a30..f001360 100644 --- a/firmware/libboard/octsimtest/source/sim_switch.c +++ b/firmware/libboard/octsimtest/source/sim_switch.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "trace.h" diff --git a/firmware/libboard/owhw/include/board.h b/firmware/libboard/owhw/include/board.h index f929771..1980324 100644 --- a/firmware/libboard/owhw/include/board.h +++ b/firmware/libboard/owhw/include/board.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once #include "board_common.h" diff --git a/firmware/libboard/owhw/source/owhw.c b/firmware/libboard/owhw/source/owhw.c index 516d592..1238082 100644 --- a/firmware/libboard/owhw/source/owhw.c +++ b/firmware/libboard/owhw/source/owhw.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "chip.h" diff --git a/firmware/libboard/owhw/source/sim_switch.c b/firmware/libboard/owhw/source/sim_switch.c index 59513ad..0b829b6 100644 --- a/firmware/libboard/owhw/source/sim_switch.c +++ b/firmware/libboard/owhw/source/sim_switch.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "trace.h" diff --git a/firmware/libboard/qmod/include/board.h b/firmware/libboard/qmod/include/board.h index 0d35bef..6d7d4ff 100644 --- a/firmware/libboard/qmod/include/board.h +++ b/firmware/libboard/qmod/include/board.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once #include "board_common.h" diff --git a/firmware/libboard/qmod/include/card_pres.h b/firmware/libboard/qmod/include/card_pres.h index 81f0613..e06642e 100644 --- a/firmware/libboard/qmod/include/card_pres.h +++ b/firmware/libboard/qmod/include/card_pres.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/qmod/include/i2c.h b/firmware/libboard/qmod/include/i2c.h index 30f57ce..aff1ea6 100644 --- a/firmware/libboard/qmod/include/i2c.h +++ b/firmware/libboard/qmod/include/i2c.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/qmod/include/wwan_led.h b/firmware/libboard/qmod/include/wwan_led.h index 77887c7..a0f060a 100644 --- a/firmware/libboard/qmod/include/wwan_led.h +++ b/firmware/libboard/qmod/include/wwan_led.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/qmod/include/wwan_perst.h b/firmware/libboard/qmod/include/wwan_perst.h index c934afc..623184e 100644 --- a/firmware/libboard/qmod/include/wwan_perst.h +++ b/firmware/libboard/qmod/include/wwan_perst.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libboard/qmod/source/board_qmod.c b/firmware/libboard/qmod/source/board_qmod.c index 32bfdd4..189fb58 100644 --- a/firmware/libboard/qmod/source/board_qmod.c +++ b/firmware/libboard/qmod/source/board_qmod.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "simtrace.h" diff --git a/firmware/libboard/qmod/source/card_pres.c b/firmware/libboard/qmod/source/card_pres.c index 7a32b57..21ce1fb 100644 --- a/firmware/libboard/qmod/source/card_pres.c +++ b/firmware/libboard/qmod/source/card_pres.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include "board.h" diff --git a/firmware/libboard/qmod/source/i2c.c b/firmware/libboard/qmod/source/i2c.c index a708704..7aa3d1d 100644 --- a/firmware/libboard/qmod/source/i2c.c +++ b/firmware/libboard/qmod/source/i2c.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include diff --git a/firmware/libboard/qmod/source/sim_switch.c b/firmware/libboard/qmod/source/sim_switch.c index 59513ad..0b829b6 100644 --- a/firmware/libboard/qmod/source/sim_switch.c +++ b/firmware/libboard/qmod/source/sim_switch.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "trace.h" diff --git a/firmware/libboard/qmod/source/wwan_led.c b/firmware/libboard/qmod/source/wwan_led.c index b3b5693..f055080 100644 --- a/firmware/libboard/qmod/source/wwan_led.c +++ b/firmware/libboard/qmod/source/wwan_led.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ /* Depending on the board this is running on, it might be possible * for the controller to read the status of the WWAN LED output lines of diff --git a/firmware/libboard/qmod/source/wwan_perst.c b/firmware/libboard/qmod/source/wwan_perst.c index 95a7c7b..b314781 100644 --- a/firmware/libboard/qmod/source/wwan_perst.c +++ b/firmware/libboard/qmod/source/wwan_perst.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ /* Depending on the board this is running on, it might be possible * for the controller to set the status of the PERST input line of diff --git a/firmware/libboard/sam3p256/include/board.h b/firmware/libboard/sam3p256/include/board.h index 06cfdce..ff87c99 100644 --- a/firmware/libboard/sam3p256/include/board.h +++ b/firmware/libboard/sam3p256/include/board.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once #include "board_common.h" diff --git a/firmware/libboard/sam3p256/source/board_sam3p256.c b/firmware/libboard/sam3p256/source/board_sam3p256.c index 4b6a451..47f8ea7 100644 --- a/firmware/libboard/sam3p256/source/board_sam3p256.c +++ b/firmware/libboard/sam3p256/source/board_sam3p256.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "simtrace.h" diff --git a/firmware/libboard/simtrace/include/board.h b/firmware/libboard/simtrace/include/board.h index 6e4cd98..7cb30b0 100644 --- a/firmware/libboard/simtrace/include/board.h +++ b/firmware/libboard/simtrace/include/board.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once #include "board_common.h" diff --git a/firmware/libboard/simtrace/source/board_simtrace.c b/firmware/libboard/simtrace/source/board_simtrace.c index 9d323cf..d15d6b9 100644 --- a/firmware/libboard/simtrace/source/board_simtrace.c +++ b/firmware/libboard/simtrace/source/board_simtrace.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "simtrace.h" diff --git a/firmware/libboard/simtrace/source/sim_switch.c b/firmware/libboard/simtrace/source/sim_switch.c index c5c54f0..c3a8503 100644 --- a/firmware/libboard/simtrace/source/sim_switch.c +++ b/firmware/libboard/simtrace/source/sim_switch.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "trace.h" diff --git a/firmware/libcommon/include/card_emu.h b/firmware/libcommon/include/card_emu.h index 58e24cd..177fad2 100644 --- a/firmware/libcommon/include/card_emu.h +++ b/firmware/libcommon/include/card_emu.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/include/iso7816_fidi.h b/firmware/libcommon/include/iso7816_fidi.h index 19483b0..823e7ab 100644 --- a/firmware/libcommon/include/iso7816_fidi.h +++ b/firmware/libcommon/include/iso7816_fidi.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/include/llist_irqsafe.h b/firmware/libcommon/include/llist_irqsafe.h index 9171ccf..8aafcfb 100644 --- a/firmware/libcommon/include/llist_irqsafe.h +++ b/firmware/libcommon/include/llist_irqsafe.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/include/ringbuffer.h b/firmware/libcommon/include/ringbuffer.h index 23aaa59..51af3b2 100644 --- a/firmware/libcommon/include/ringbuffer.h +++ b/firmware/libcommon/include/ringbuffer.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #ifndef SIMTRACE_RINGBUF_H #define SIMTRACE_RINGBUF_H diff --git a/firmware/libcommon/include/simtrace.h b/firmware/libcommon/include/simtrace.h index 67f3988..a37ec4f 100644 --- a/firmware/libcommon/include/simtrace.h +++ b/firmware/libcommon/include/simtrace.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #ifndef SIMTRACE_H #define SIMTRACE_H diff --git a/firmware/libcommon/include/simtrace_prot.h b/firmware/libcommon/include/simtrace_prot.h index 5eb4f59..5c43b06 100644 --- a/firmware/libcommon/include/simtrace_prot.h +++ b/firmware/libcommon/include/simtrace_prot.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/include/simtrace_usb.h b/firmware/libcommon/include/simtrace_usb.h index 7bf401c..1473762 100644 --- a/firmware/libcommon/include/simtrace_usb.h +++ b/firmware/libcommon/include/simtrace_usb.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ /* SIMtrace USB IDs */ #define USB_VENDOR_OPENMOKO 0x1d50 diff --git a/firmware/libcommon/include/talloc.h b/firmware/libcommon/include/talloc.h index 625355a..1e95603 100644 --- a/firmware/libcommon/include/talloc.h +++ b/firmware/libcommon/include/talloc.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/include/usb_buf.h b/firmware/libcommon/include/usb_buf.h index 3a4eda2..39198f3 100644 --- a/firmware/libcommon/include/usb_buf.h +++ b/firmware/libcommon/include/usb_buf.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/include/utils.h b/firmware/libcommon/include/utils.h index 2c966f9..234d278 100644 --- a/firmware/libcommon/include/utils.h +++ b/firmware/libcommon/include/utils.h @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #pragma once diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c index debc658..19a519a 100644 --- a/firmware/libcommon/source/card_emu.c +++ b/firmware/libcommon/source/card_emu.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include diff --git a/firmware/libcommon/source/fputs.c b/firmware/libcommon/source/fputs.c index 110f68e..8f2b21e 100644 --- a/firmware/libcommon/source/fputs.c +++ b/firmware/libcommon/source/fputs.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include "uart_console.h" diff --git a/firmware/libcommon/source/host_communication.c b/firmware/libcommon/source/host_communication.c index 9a6e5b3..b2faf1b 100644 --- a/firmware/libcommon/source/host_communication.c +++ b/firmware/libcommon/source/host_communication.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "llist_irqsafe.h" diff --git a/firmware/libcommon/source/iso7816_fidi.c b/firmware/libcommon/source/iso7816_fidi.c index 033a325..024663b 100644 --- a/firmware/libcommon/source/iso7816_fidi.c +++ b/firmware/libcommon/source/iso7816_fidi.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include diff --git a/firmware/libcommon/source/main_common.c b/firmware/libcommon/source/main_common.c index 3314595..cd3bced 100644 --- a/firmware/libcommon/source/main_common.c +++ b/firmware/libcommon/source/main_common.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "board.h" diff --git a/firmware/libcommon/source/mode_cardemu.c b/firmware/libcommon/source/mode_cardemu.c index 4a0b862..8e4acf9 100644 --- a/firmware/libcommon/source/mode_cardemu.c +++ b/firmware/libcommon/source/mode_cardemu.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "boardver_adc.h" diff --git a/firmware/libcommon/source/pseudo_talloc.c b/firmware/libcommon/source/pseudo_talloc.c index bbcd7af..5a4d1ca 100644 --- a/firmware/libcommon/source/pseudo_talloc.c +++ b/firmware/libcommon/source/pseudo_talloc.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include #include diff --git a/firmware/libcommon/source/ringbuffer.c b/firmware/libcommon/source/ringbuffer.c index 70747a1..591d31f 100644 --- a/firmware/libcommon/source/ringbuffer.c +++ b/firmware/libcommon/source/ringbuffer.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "ringbuffer.h" #include "trace.h" diff --git a/firmware/libcommon/source/sniffer.c b/firmware/libcommon/source/sniffer.c index 57e2daa..366ac7e 100644 --- a/firmware/libcommon/source/sniffer.c +++ b/firmware/libcommon/source/sniffer.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ /* This code implement the Sniffer mode to sniff the communication between a * SIM card (or any ISO 7816 smart card) and a phone (or any ISO 7816 card diff --git a/firmware/libcommon/source/tc_etu.c b/firmware/libcommon/source/tc_etu.c index 04a7324..a48da8c 100644 --- a/firmware/libcommon/source/tc_etu.c +++ b/firmware/libcommon/source/tc_etu.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include diff --git a/firmware/libcommon/source/usb_buf.c b/firmware/libcommon/source/usb_buf.c index b97eb9c..72eae54 100644 --- a/firmware/libcommon/source/usb_buf.c +++ b/firmware/libcommon/source/usb_buf.c @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA */ #include "board.h" #include "trace.h" diff --git a/firmware/libosmocore/include/osmocom/core/bit16gen.h b/firmware/libosmocore/include/osmocom/core/bit16gen.h index 5c6162c..ed47285 100644 --- a/firmware/libosmocore/include/osmocom/core/bit16gen.h +++ b/firmware/libosmocore/include/osmocom/core/bit16gen.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/firmware/libosmocore/include/osmocom/core/bit32gen.h b/firmware/libosmocore/include/osmocom/core/bit32gen.h index 6640e76..12abb72 100644 --- a/firmware/libosmocore/include/osmocom/core/bit32gen.h +++ b/firmware/libosmocore/include/osmocom/core/bit32gen.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/firmware/libosmocore/include/osmocom/core/bit64gen.h b/firmware/libosmocore/include/osmocom/core/bit64gen.h index 8c7b709..2aa2a2e 100644 --- a/firmware/libosmocore/include/osmocom/core/bit64gen.h +++ b/firmware/libosmocore/include/osmocom/core/bit64gen.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/firmware/libosmocore/include/osmocom/core/linuxrbtree.h b/firmware/libosmocore/include/osmocom/core/linuxrbtree.h index d3f9fd1..4212109 100644 --- a/firmware/libosmocore/include/osmocom/core/linuxrbtree.h +++ b/firmware/libosmocore/include/osmocom/core/linuxrbtree.h @@ -11,10 +11,6 @@ but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. linux/include/linux/rbtree.h diff --git a/firmware/libosmocore/include/osmocom/core/msgb.h b/firmware/libosmocore/include/osmocom/core/msgb.h index 7c4420d..dadf487 100644 --- a/firmware/libosmocore/include/osmocom/core/msgb.h +++ b/firmware/libosmocore/include/osmocom/core/msgb.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/firmware/libosmocore/include/osmocom/core/timer.h b/firmware/libosmocore/include/osmocom/core/timer.h index 6d70fff..6bd95a7 100644 --- a/firmware/libosmocore/include/osmocom/core/timer.h +++ b/firmware/libosmocore/include/osmocom/core/timer.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup timer Osmocom timers diff --git a/firmware/libosmocore/source/backtrace.c b/firmware/libosmocore/source/backtrace.c index 5d6dc4a..3938d7a 100644 --- a/firmware/libosmocore/source/backtrace.c +++ b/firmware/libosmocore/source/backtrace.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \file backtrace.c diff --git a/firmware/libosmocore/source/bits.c b/firmware/libosmocore/source/bits.c index 0c77b27..5fa9488 100644 --- a/firmware/libosmocore/source/bits.c +++ b/firmware/libosmocore/source/bits.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/firmware/libosmocore/source/msgb.c b/firmware/libosmocore/source/msgb.c index a27100c..fcdda87 100644 --- a/firmware/libosmocore/source/msgb.c +++ b/firmware/libosmocore/source/msgb.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup msgb diff --git a/firmware/libosmocore/source/panic.c b/firmware/libosmocore/source/panic.c index db5c26a..589464a 100644 --- a/firmware/libosmocore/source/panic.c +++ b/firmware/libosmocore/source/panic.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup utils diff --git a/firmware/libosmocore/source/rbtree.c b/firmware/libosmocore/source/rbtree.c index f0ebb8c..a8969f4 100644 --- a/firmware/libosmocore/source/rbtree.c +++ b/firmware/libosmocore/source/rbtree.c @@ -12,10 +12,6 @@ but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA linux/lib/rbtree.c diff --git a/firmware/libosmocore/source/timer.c b/firmware/libosmocore/source/timer.c index 75c7d45..eb43884 100644 --- a/firmware/libosmocore/source/timer.c +++ b/firmware/libosmocore/source/timer.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/firmware/libosmocore/source/utils.c b/firmware/libosmocore/source/utils.c index 3096572..f519df7 100644 --- a/firmware/libosmocore/source/utils.c +++ b/firmware/libosmocore/source/utils.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/firmware/usbstring/usbstring.c b/firmware/usbstring/usbstring.c index ed07568..e7c6c8c 100644 --- a/firmware/usbstring/usbstring.c +++ b/firmware/usbstring/usbstring.c @@ -10,10 +10,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ /* Based on existing utf8_to_utf16le() function, diff --git a/host/include/osmocom/simtrace2/apdu_dispatch.h b/host/include/osmocom/simtrace2/apdu_dispatch.h index 42a097a..62ff762 100644 --- a/host/include/osmocom/simtrace2/apdu_dispatch.h +++ b/host/include/osmocom/simtrace2/apdu_dispatch.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #pragma once diff --git a/host/lib/apdu_dispatch.c b/host/lib/apdu_dispatch.c index ec368b2..4c8f505 100644 --- a/host/lib/apdu_dispatch.c +++ b/host/lib/apdu_dispatch.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include #include diff --git a/host/lib/gsmtap.c b/host/lib/gsmtap.c index 18814d3..3fc3da6 100644 --- a/host/lib/gsmtap.c +++ b/host/lib/gsmtap.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include diff --git a/host/lib/simtrace2_api.c b/host/lib/simtrace2_api.c index a61b2cf..4ad7eb7 100644 --- a/host/lib/simtrace2_api.c +++ b/host/lib/simtrace2_api.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include diff --git a/host/lib/usb_util.c b/host/lib/usb_util.c index 872d185..d55bbc7 100644 --- a/host/lib/usb_util.c +++ b/host/lib/usb_util.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include #include diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index 576de61..2806b0f 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include diff --git a/host/src/simtrace2-sniff.c b/host/src/simtrace2-sniff.c index 653508d..a4eccb2 100644 --- a/host/src/simtrace2-sniff.c +++ b/host/src/simtrace2-sniff.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include #include diff --git a/host/src/simtrace2-tool.c b/host/src/simtrace2-tool.c index 97d7706..d92638f 100644 --- a/host/src/simtrace2-tool.c +++ b/host/src/simtrace2-tool.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include diff --git a/host/src/simtrace2_usb.c b/host/src/simtrace2_usb.c index be1ba6e..10dc948 100644 --- a/host/src/simtrace2_usb.c +++ b/host/src/simtrace2_usb.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include #include -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie0a3b2273383adbb3303faffd6ff96be7f4cae99 Gerrit-Change-Number: 26547 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:50:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:50:13 +0000 Subject: Change in libosmo-abis[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26548 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0ad20cdf1e571c1a15f6e67d46e07155a6a02520 Gerrit-Change-Number: 26548 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Tue, 14 Dec 2021 12:50:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:50:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:50:28 +0000 Subject: Change in libosmo-abis[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26548 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I0ad20cdf1e571c1a15f6e67d46e07155a6a02520 --- M src/input/dahdi.c M src/input/e1d.c M src/input/ipa_keepalive.c M src/input/lapd.c M src/input/unixsocket.c M src/trau/osmo_ortp.c 6 files changed, 0 insertions(+), 24 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/input/dahdi.c b/src/input/dahdi.c index 6dee0d7..acf1f94 100644 --- a/src/input/dahdi.c +++ b/src/input/dahdi.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/input/e1d.c b/src/input/e1d.c index cab219d..a959b40 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/input/ipa_keepalive.c b/src/input/ipa_keepalive.c index 172a36f..7fc28f1 100644 --- a/src/input/ipa_keepalive.c +++ b/src/input/ipa_keepalive.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/input/lapd.c b/src/input/lapd.c index 6f1e270..130e4c3 100644 --- a/src/input/lapd.c +++ b/src/input/lapd.c @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "internal.h" diff --git a/src/input/unixsocket.c b/src/input/unixsocket.c index 595dc7d..069f9c6 100644 --- a/src/input/unixsocket.c +++ b/src/input/unixsocket.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c index 011f097..5761d78 100644 --- a/src/trau/osmo_ortp.c +++ b/src/trau/osmo_ortp.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \file osmo_ortp.c -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0ad20cdf1e571c1a15f6e67d46e07155a6a02520 Gerrit-Change-Number: 26548 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:50:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:50:36 +0000 Subject: Change in ...osmo-python-tests[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/26558 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/26558 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Ifd7b7e548c9c6db140fa8cbc8a3c8dfaf4603d18 Gerrit-Change-Number: 26558 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:50:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:50:38 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:50:38 +0000 Subject: Change in ...osmo-python-tests[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/26558 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: Ifd7b7e548c9c6db140fa8cbc8a3c8dfaf4603d18 --- M osmopy/osmo_ipa.py M osmopy/trap_helper.py M osmopy/twisted_ipa.py M scripts/ctrl2cgi.py M scripts/osmo_ctrl.py M scripts/osmo_rate_ctr2csv.py M scripts/osmo_trap2cgi.py M scripts/soap.py 8 files changed, 0 insertions(+), 32 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/osmopy/osmo_ipa.py b/osmopy/osmo_ipa.py index a95a05b..1b42b7f 100755 --- a/osmopy/osmo_ipa.py +++ b/osmopy/osmo_ipa.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/osmopy/trap_helper.py b/osmopy/trap_helper.py index a48770b..2b4179d 100644 --- a/osmopy/trap_helper.py +++ b/osmopy/trap_helper.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/osmopy/twisted_ipa.py b/osmopy/twisted_ipa.py index f39bc5c..fd3cee5 100755 --- a/osmopy/twisted_ipa.py +++ b/osmopy/twisted_ipa.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/scripts/ctrl2cgi.py b/scripts/ctrl2cgi.py index 3e8f87d..9f66f99 100755 --- a/scripts/ctrl2cgi.py +++ b/scripts/ctrl2cgi.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/scripts/osmo_ctrl.py b/scripts/osmo_ctrl.py index 8a67fd8..8115eb8 100755 --- a/scripts/osmo_ctrl.py +++ b/scripts/osmo_ctrl.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/scripts/osmo_rate_ctr2csv.py b/scripts/osmo_rate_ctr2csv.py index a66fb01..140fa65 100755 --- a/scripts/osmo_rate_ctr2csv.py +++ b/scripts/osmo_rate_ctr2csv.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/scripts/osmo_trap2cgi.py b/scripts/osmo_trap2cgi.py index a03fd2b..a8d1ffe 100755 --- a/scripts/osmo_trap2cgi.py +++ b/scripts/osmo_trap2cgi.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/scripts/soap.py b/scripts/soap.py index 8a5f514..f054ef3 100755 --- a/scripts/soap.py +++ b/scripts/soap.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/26558 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Ifd7b7e548c9c6db140fa8cbc8a3c8dfaf4603d18 Gerrit-Change-Number: 26558 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:50:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:50:49 +0000 Subject: Change in osmo-hlr[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/26553 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/26553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4b20c685b6370bf5dc472a42664e2665eb0d8f8c Gerrit-Change-Number: 26553 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:50:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:50:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:50:51 +0000 Subject: Change in osmo-hlr[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/26553 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I4b20c685b6370bf5dc472a42664e2665eb0d8f8c --- M src/dbd_decode_binary.c 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/dbd_decode_binary.c b/src/dbd_decode_binary.c index e1a98ad..06dccbb 100644 --- a/src/dbd_decode_binary.c +++ b/src/dbd_decode_binary.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * * $Id: dbd_helper.c,v 1.44 2011/08/09 11:14:14 mhoenicka Exp $ */ -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/26553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4b20c685b6370bf5dc472a42664e2665eb0d8f8c Gerrit-Change-Number: 26553 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:50:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:50:57 +0000 Subject: Change in osmo-mgw[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26555 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26555 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2a623f67e116d5e56091ae5860ca2a305c57e50a Gerrit-Change-Number: 26555 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:50:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:50:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:50:59 +0000 Subject: Change in osmo-mgw[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26555 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I2a623f67e116d5e56091ae5860ca2a305c57e50a --- M contrib/ipa.py M src/libosmo-mgcp/g711common.h 2 files changed, 0 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/ipa.py b/contrib/ipa.py index 71cbf45..65e4003 100755 --- a/contrib/ipa.py +++ b/contrib/ipa.py @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/src/libosmo-mgcp/g711common.h b/src/libosmo-mgcp/g711common.h index cb35fc6..31ab3a4 100644 --- a/src/libosmo-mgcp/g711common.h +++ b/src/libosmo-mgcp/g711common.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ static inline int val_seg(int val) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26555 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2a623f67e116d5e56091ae5860ca2a305c57e50a Gerrit-Change-Number: 26555 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:51:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:51:05 +0000 Subject: Change in osmo-ttcn3-hacks[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26564 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ab8f1e79fcc38d889cce4eac2e90cd4e5582b1b Gerrit-Change-Number: 26564 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:51:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:51:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:51:07 +0000 Subject: Change in osmo-ttcn3-hacks[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26564 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I8ab8f1e79fcc38d889cce4eac2e90cd4e5582b1b --- M remsim/RSPRO.asn 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/remsim/RSPRO.asn b/remsim/RSPRO.asn index ce29003..faf9cec 100644 --- a/remsim/RSPRO.asn +++ b/remsim/RSPRO.asn @@ -15,10 +15,6 @@ -- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -- GNU General Public License for more details. -- --- You should have received a copy of the GNU General Public License along --- with this program; if not, write to the Free Software Foundation, Inc., --- 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. --- ---------------------------------------------------------------------- RSPRO {} DEFINITIONS -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ab8f1e79fcc38d889cce4eac2e90cd4e5582b1b Gerrit-Change-Number: 26564 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:51:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:51:20 +0000 Subject: Change in osmo-sysmon[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26562 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I1f6db5f930fe97ce2336bce416470b807d7a57b7 Gerrit-Change-Number: 26562 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:51:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:51:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:51:23 +0000 Subject: Change in osmo-sysmon[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26562 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I1f6db5f930fe97ce2336bce416470b807d7a57b7 --- M src/client.c M src/osmo-ctrl-client.c M src/osysmon_ctrl.c M src/osysmon_file.c M src/osysmon_main.c M src/osysmon_openvpn.c M src/osysmon_ping.c M src/osysmon_rtnl.c M src/osysmon_shellcmd.c M src/osysmon_sysinfo.c M src/simple_ctrl.c M src/value_node.c 12 files changed, 0 insertions(+), 60 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/client.c b/src/client.c index 758884d..a277521 100644 --- a/src/client.c +++ b/src/client.c @@ -15,11 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osmo-ctrl-client.c b/src/osmo-ctrl-client.c index 83e9b7b..351ab91 100644 --- a/src/osmo-ctrl-client.c +++ b/src/osmo-ctrl-client.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_ctrl.c b/src/osysmon_ctrl.c index c54779c..a4e2444 100644 --- a/src/osysmon_ctrl.c +++ b/src/osysmon_ctrl.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_file.c b/src/osysmon_file.c index 8e52497..b25fa24 100644 --- a/src/osysmon_file.c +++ b/src/osysmon_file.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_main.c b/src/osysmon_main.c index 206246c..2d5ebfa 100644 --- a/src/osysmon_main.c +++ b/src/osysmon_main.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_openvpn.c b/src/osysmon_openvpn.c index 8d88def..cc9694f 100644 --- a/src/osysmon_openvpn.c +++ b/src/osysmon_openvpn.c @@ -15,11 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_ping.c b/src/osysmon_ping.c index 3484374..de20791 100644 --- a/src/osysmon_ping.c +++ b/src/osysmon_ping.c @@ -15,11 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_rtnl.c b/src/osysmon_rtnl.c index f1e5a0e..a8e0fa8 100644 --- a/src/osysmon_rtnl.c +++ b/src/osysmon_rtnl.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_shellcmd.c b/src/osysmon_shellcmd.c index 83dc0c9..81ed276 100644 --- a/src/osysmon_shellcmd.c +++ b/src/osysmon_shellcmd.c @@ -15,11 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/osysmon_sysinfo.c b/src/osysmon_sysinfo.c index 9cb434c..185c675 100644 --- a/src/osysmon_sysinfo.c +++ b/src/osysmon_sysinfo.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/simple_ctrl.c b/src/simple_ctrl.c index 9407218..1e50dca 100644 --- a/src/simple_ctrl.c +++ b/src/simple_ctrl.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/value_node.c b/src/value_node.c index 9143451..fc886d1 100644 --- a/src/value_node.c +++ b/src/value_node.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I1f6db5f930fe97ce2336bce416470b807d7a57b7 Gerrit-Change-Number: 26562 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:51:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:51:33 +0000 Subject: Change in osmo-remsim[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26559 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2e98f89f6738d03c45a2106820af0912692093f3 Gerrit-Change-Number: 26559 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:51:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:51:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:51:35 +0000 Subject: Change in osmo-remsim[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/26559 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I2e98f89f6738d03c45a2106820af0912692093f3 --- M asn1/RSPRO.asn M src/bankd/bankd_main.c M src/bankd/bankd_pcsc.c M src/bankd/driver_core.c M src/bankd/driver_pcsc.c M src/bankd/main.c M src/client/main_fsm.c M src/client/remsim_client.c M src/client/user_ifdhandler.c M src/client/user_simtrace2.c M src/debug.c M src/rspro_client_fsm.c M src/rspro_util.c M src/slotmap.c 14 files changed, 0 insertions(+), 56 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/asn1/RSPRO.asn b/asn1/RSPRO.asn index 1b1be6d..d49345d 100644 --- a/asn1/RSPRO.asn +++ b/asn1/RSPRO.asn @@ -15,10 +15,6 @@ -- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -- GNU General Public License for more details. -- --- You should have received a copy of the GNU General Public License along --- with this program; if not, write to the Free Software Foundation, Inc., --- 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. --- ---------------------------------------------------------------------- RSPRO {} DEFINITIONS diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 5b70b88..2923924 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #define _GNU_SOURCE diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index 8202504..e3b9ea6 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/bankd/driver_core.c b/src/bankd/driver_core.c index 57ae3cd..128bbe2 100644 --- a/src/bankd/driver_core.c +++ b/src/bankd/driver_core.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/bankd/driver_pcsc.c b/src/bankd/driver_pcsc.c index 4279c2f..e807525 100644 --- a/src/bankd/driver_pcsc.c +++ b/src/bankd/driver_pcsc.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/bankd/main.c b/src/bankd/main.c index 4bb91ca..f4601ae 100644 --- a/src/bankd/main.c +++ b/src/bankd/main.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/client/main_fsm.c b/src/client/main_fsm.c index 96b4b90..f8b1406 100644 --- a/src/client/main_fsm.c +++ b/src/client/main_fsm.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/client/remsim_client.c b/src/client/remsim_client.c index 388aa26..8da82ef 100644 --- a/src/client/remsim_client.c +++ b/src/client/remsim_client.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* This file contains code shared among all remsim client applications, diff --git a/src/client/user_ifdhandler.c b/src/client/user_ifdhandler.c index a416e6e..551db00 100644 --- a/src/client/user_ifdhandler.c +++ b/src/client/user_ifdhandler.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* This is a remsim-client that provides an IFD_Handler (reader driver) diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c index 100d55b..f71c720 100644 --- a/src/client/user_simtrace2.c +++ b/src/client/user_simtrace2.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/debug.c b/src/debug.c index 2dfc16e..fb8bb4b 100644 --- a/src/debug.c +++ b/src/debug.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index bfd7ebd..c0336b7 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/rspro_util.c b/src/rspro_util.c index a7476dc..2ea6caf 100644 --- a/src/rspro_util.c +++ b/src/rspro_util.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/slotmap.c b/src/slotmap.c index fe0c6b7..b1be0ab 100644 --- a/src/slotmap.c +++ b/src/slotmap.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/26559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2e98f89f6738d03c45a2106820af0912692093f3 Gerrit-Change-Number: 26559 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:51:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:51:42 +0000 Subject: Change in osmo-bsc[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26551 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifbbafe185931c0f508ff8148ef244f25a9620fd8 Gerrit-Change-Number: 26551 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: zecke Gerrit-Comment-Date: Tue, 14 Dec 2021 12:51:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:51:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:51:44 +0000 Subject: Change in osmo-bsc[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26551 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: Ifbbafe185931c0f508ff8148ef244f25a9620fd8 --- M src/osmo-bsc/bsc_ctrl_lookup.c M src/osmo-bsc/pcu_sock.c 2 files changed, 0 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_ctrl_lookup.c b/src/osmo-bsc/bsc_ctrl_lookup.c index 4328d76..6a11e32 100644 --- a/src/osmo-bsc/bsc_ctrl_lookup.c +++ b/src/osmo-bsc/bsc_ctrl_lookup.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index 6f7ee77..d6dd9a7 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifbbafe185931c0f508ff8148ef244f25a9620fd8 Gerrit-Change-Number: 26551 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: zecke Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:52:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:52:01 +0000 Subject: Change in osmocom-bb[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/26566 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/26566 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I73be012c01c0108fb6951dbff91d50eb19b40c51 Gerrit-Change-Number: 26566 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: BastusIII Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: steve-m Gerrit-Comment-Date: Tue, 14 Dec 2021 12:52:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:52:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:52:05 +0000 Subject: Change in osmocom-bb[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/26566 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I73be012c01c0108fb6951dbff91d50eb19b40c51 --- M include/l1ctl_proto.h M src/host/fb_tools/bdf_to_c.py M src/host/gprsdecode/gprs.c M src/host/gprsdecode/gsmtap.c M src/host/gprsdecode/main.c M src/host/gprsdecode/rlcmac.c M src/host/gsmmap/gsmmap.c M src/host/gsmmap/log.c M src/host/layer23/include/osmocom/bb/common/gps.h M src/host/layer23/include/osmocom/bb/common/sim.h M src/host/layer23/include/osmocom/bb/misc/cell_log.h M src/host/layer23/include/osmocom/bb/mobile/mncc.h M src/host/layer23/src/common/gps.c M src/host/layer23/src/common/l1ctl.c M src/host/layer23/src/common/l1ctl_lapdm_glue.c M src/host/layer23/src/common/l1l2_interface.c M src/host/layer23/src/common/logging.c M src/host/layer23/src/common/main.c M src/host/layer23/src/common/sap_fsm.c M src/host/layer23/src/common/sap_interface.c M src/host/layer23/src/common/sap_proto.c M src/host/layer23/src/common/sim.c M src/host/layer23/src/common/sysinfo.c M src/host/layer23/src/common/utils.c M src/host/layer23/src/misc/app_bcch_scan.c M src/host/layer23/src/misc/app_cbch_sniff.c M src/host/layer23/src/misc/app_ccch_scan.c M src/host/layer23/src/misc/app_cell_log.c M src/host/layer23/src/misc/app_echo_test.c M src/host/layer23/src/misc/bcch_scan.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/misc/rslms.c M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gsm322.c M src/host/layer23/src/mobile/gsm411_sms.c M src/host/layer23/src/mobile/gsm414.c M src/host/layer23/src/mobile/gsm480_ss.c M src/host/layer23/src/mobile/gsm48_cc.c M src/host/layer23/src/mobile/gsm48_mm.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/main.c M src/host/layer23/src/mobile/mncc_sock.c M src/host/layer23/src/mobile/mnccms.c M src/host/layer23/src/mobile/primitives.c M src/host/layer23/src/mobile/script_lua.c M src/host/layer23/src/mobile/script_nolua.c M src/host/layer23/src/mobile/settings.c M src/host/layer23/src/mobile/subscriber.c M src/host/layer23/src/mobile/support.c M src/host/layer23/src/mobile/transaction.c M src/host/layer23/src/mobile/voice.c M src/host/layer23/src/mobile/vty_interface.c M src/host/osmocon/osmocon.c M src/host/osmocon/osmoload.c M src/host/osmocon/tpu_debug.c M src/host/trxcon/l1ctl.c M src/host/trxcon/l1ctl_link.c M src/host/trxcon/logging.c M src/host/trxcon/sched_lchan_common.c M src/host/trxcon/sched_lchan_pdtch.c M src/host/trxcon/sched_lchan_rach.c M src/host/trxcon/sched_lchan_sch.c M src/host/trxcon/sched_lchan_tchf.c M src/host/trxcon/sched_lchan_tchh.c M src/host/trxcon/sched_lchan_xcch.c M src/host/trxcon/sched_prim.c M src/host/trxcon/sched_trx.c M src/host/trxcon/trxcon.c M src/host/virt_phy/src/logging.c M src/host/virt_phy/src/virt_prim_data.c M src/host/virt_phy/src/virt_prim_fbsb.c M src/host/virt_phy/src/virt_prim_pm.c M src/host/virt_phy/src/virt_prim_rach.c M src/host/virt_phy/src/virt_prim_traffic.c M src/shared/libosmocore/include/osmocom/core/bitvec.h M src/shared/libosmocore/include/osmocom/core/conv.h M src/shared/libosmocore/include/osmocom/core/crcXXgen.h.tpl M src/shared/libosmocore/include/osmocom/core/crcgen.h M src/shared/libosmocore/include/osmocom/core/linuxrbtree.h M src/shared/libosmocore/include/osmocom/core/msgb.h M src/shared/libosmocore/include/osmocom/core/msgfile.h M src/shared/libosmocore/include/osmocom/core/serial.h M src/shared/libosmocore/include/osmocom/core/timer.h M src/shared/libosmocore/include/osmocom/core/timer_compat.h M src/shared/libosmocore/include/osmocom/core/write_queue.h M src/shared/libosmocore/include/osmocom/gsm/a5.h M src/shared/libosmocore/include/osmocom/gsm/gsm0808.h M src/shared/libosmocore/include/osmocom/gsm/gsm_utils.h M src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_08_58.h M src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_12_21.h M src/shared/libosmocore/include/osmocom/vty/telnet_interface.h M src/shared/libosmocore/include/osmocom/vty/vector.h M src/shared/libosmocore/src/application.c M src/shared/libosmocore/src/backtrace.c M src/shared/libosmocore/src/bitvec.c M src/shared/libosmocore/src/codec/gsm610.c M src/shared/libosmocore/src/codec/gsm620.c M src/shared/libosmocore/src/codec/gsm660.c M src/shared/libosmocore/src/codec/gsm690.c M src/shared/libosmocore/src/conv.c M src/shared/libosmocore/src/crcXXgen.c.tpl M src/shared/libosmocore/src/gsm/a5.c M src/shared/libosmocore/src/gsm/auth_comp128v1.c M src/shared/libosmocore/src/gsm/auth_core.c M src/shared/libosmocore/src/gsm/auth_milenage.c M src/shared/libosmocore/src/gsm/comp128.c M src/shared/libosmocore/src/gsm/gprs_cipher_core.c M src/shared/libosmocore/src/gsm/gsm0480.c M src/shared/libosmocore/src/gsm/gsm0808.c M src/shared/libosmocore/src/gsm/gsm48.c M src/shared/libosmocore/src/gsm/gsm48_ie.c M src/shared/libosmocore/src/gsm/gsm_utils.c M src/shared/libosmocore/src/gsm/lapd_core.c M src/shared/libosmocore/src/gsm/lapdm.c M src/shared/libosmocore/src/gsm/rsl.c M src/shared/libosmocore/src/gsm/rxlev_stat.c M src/shared/libosmocore/src/gsmtap_util.c M src/shared/libosmocore/src/logging.c M src/shared/libosmocore/src/logging_syslog.c M src/shared/libosmocore/src/msgb.c M src/shared/libosmocore/src/msgfile.c M src/shared/libosmocore/src/panic.c M src/shared/libosmocore/src/plugin.c M src/shared/libosmocore/src/rate_ctr.c M src/shared/libosmocore/src/rbtree.c M src/shared/libosmocore/src/select.c M src/shared/libosmocore/src/serial.c M src/shared/libosmocore/src/signal.c M src/shared/libosmocore/src/statistics.c M src/shared/libosmocore/src/timer.c M src/shared/libosmocore/src/vty/logging_vty.c M src/shared/libosmocore/src/vty/telnet_interface.c M src/shared/libosmocore/src/vty/utils.c M src/shared/libosmocore/src/vty/vector.c M src/shared/libosmocore/src/write_queue.c M src/shared/libosmocore/tests/gsm0408/gsm0408_test.c M src/shared/libosmocore/tests/gsm0808/gsm0808_test.c M src/shared/libosmocore/tests/lapd/lapd_test.c M src/shared/libosmocore/tests/msgfile/msgfile_test.c M src/shared/libosmocore/tests/sms/sms_test.c M src/shared/libosmocore/tests/smscb/smscb_test.c M src/shared/libosmocore/tests/timer/timer_test.c M src/shared/libosmocore/tests/ussd/ussd_test.c M src/shared/libosmocore/utils/osmo-arfcn.c M src/shared/libosmocore/utils/osmo-auc-gen.c M src/target/firmware/abb/twl3025.c M src/target/firmware/apps/compal_dsp_dump/main.c M src/target/firmware/apps/hello_world/main.c M src/target/firmware/apps/layer1/main.c M src/target/firmware/apps/loader/main.c M src/target/firmware/apps/loader_mtk/main.c M src/target/firmware/apps/menu/main.c M src/target/firmware/apps/rssi/main.c M src/target/firmware/apps/simtest/main.c M src/target/firmware/apps/snake_game/main.c M src/target/firmware/battery/compal_e88.c M src/target/firmware/board/common/readcal_tiffs.c M src/target/firmware/board/common/tx_calchan.c M src/target/firmware/board/compal/readcal_common.c M src/target/firmware/board/compal/readcal_small.c M src/target/firmware/board/compal/rf_tables.c M src/target/firmware/board/compal_e86/init.c M src/target/firmware/board/compal_e86/tx_ramps.c M src/target/firmware/board/compal_e88/init.c M src/target/firmware/board/compal_e88/tx_ramps.c M src/target/firmware/board/compal_e99/init.c M src/target/firmware/board/compal_e99/readcal.c M src/target/firmware/board/fcdev3b/init.c M src/target/firmware/board/gta0x/afcparams.c M src/target/firmware/board/gta0x/init.c M src/target/firmware/board/gta0x/rf_tables.c M src/target/firmware/board/gtm900b/afcparams.c M src/target/firmware/board/gtm900b/init.c M src/target/firmware/board/mediatek/uart.c M src/target/firmware/board/mt62xx/init.c M src/target/firmware/board/pirelli_dpl10/init.c M src/target/firmware/board/pirelli_dpl10/readcal.c M src/target/firmware/board/pirelli_dpl10/rf_tables.c M src/target/firmware/board/se_j100/init.c M src/target/firmware/board/se_j100/tx_ramps.c M src/target/firmware/calypso/backlight.c M src/target/firmware/calypso/buzzer.c M src/target/firmware/calypso/clock.c M src/target/firmware/calypso/dma.c M src/target/firmware/calypso/dsp.c M src/target/firmware/calypso/du.c M src/target/firmware/calypso/i2c.c M src/target/firmware/calypso/irq.c M src/target/firmware/calypso/keypad.c M src/target/firmware/calypso/rtc.c M src/target/firmware/calypso/sim.c M src/target/firmware/calypso/spi.c M src/target/firmware/calypso/timer.c M src/target/firmware/calypso/tpu.c M src/target/firmware/calypso/tsp.c M src/target/firmware/calypso/uart.c M src/target/firmware/calypso/uwire.c M src/target/firmware/comm/msgb.c M src/target/firmware/comm/sercomm.c M src/target/firmware/comm/sercomm_cons.c M src/target/firmware/comm/timer.c M src/target/firmware/fb/fb_bw8.c M src/target/firmware/fb/fb_dummy.c M src/target/firmware/fb/fb_rgb332.c M src/target/firmware/fb/fb_s6b33b1x.c M src/target/firmware/fb/fb_ssd1783.c M src/target/firmware/fb/fb_ssd1963.c M src/target/firmware/fb/fb_st7558.c M src/target/firmware/fb/fb_td014.c M src/target/firmware/fb/font.c M src/target/firmware/fb/framebuffer.c M src/target/firmware/flash/cfi_flash.c M src/target/firmware/include/calypso/du.h M src/target/firmware/include/calypso/sim.h M src/target/firmware/include/comm/timer.h M src/target/firmware/include/mtk/emi.h M src/target/firmware/include/mtk/mt6235.h M src/target/firmware/include/mtk/system.h M src/target/firmware/layer1/afc.c M src/target/firmware/layer1/agc.c M src/target/firmware/layer1/async.c M src/target/firmware/layer1/avg.c M src/target/firmware/layer1/init.c M src/target/firmware/layer1/l23_api.c M src/target/firmware/layer1/mframe_sched.c M src/target/firmware/layer1/prim_fbsb.c M src/target/firmware/layer1/prim_freq.c M src/target/firmware/layer1/prim_pm.c M src/target/firmware/layer1/prim_rach.c M src/target/firmware/layer1/prim_rx_nb.c M src/target/firmware/layer1/prim_tch.c M src/target/firmware/layer1/prim_tx_nb.c M src/target/firmware/layer1/prim_utils.c M src/target/firmware/layer1/rfch.c M src/target/firmware/layer1/sched_gsmtime.c M src/target/firmware/layer1/sync.c M src/target/firmware/layer1/tdma_sched.c M src/target/firmware/layer1/toa.c M src/target/firmware/layer1/tpu_window.c M src/target/firmware/lib/console.c M src/target/firmware/rf/mt6139.c M src/target/firmware/rf/trf6151.c M src/target/firmware/tiffs/init.c M src/target/firmware/tiffs/readfile.c M src/target/trx_toolkit/app_common.py M src/target/trx_toolkit/burst_fwd.py M src/target/trx_toolkit/burst_gen.py M src/target/trx_toolkit/burst_send.py M src/target/trx_toolkit/clck_gen.py M src/target/trx_toolkit/codec.py M src/target/trx_toolkit/ctrl_cmd.py M src/target/trx_toolkit/ctrl_if.py M src/target/trx_toolkit/ctrl_if_trx.py M src/target/trx_toolkit/data_dump.py M src/target/trx_toolkit/data_if.py M src/target/trx_toolkit/data_msg.py M src/target/trx_toolkit/fake_pm.py M src/target/trx_toolkit/fake_trx.py M src/target/trx_toolkit/gsm_shared.py M src/target/trx_toolkit/rand_burst_gen.py M src/target/trx_toolkit/test_codec.py M src/target/trx_toolkit/test_data_dump.py M src/target/trx_toolkit/test_data_msg.py M src/target/trx_toolkit/transceiver.py M src/target/trx_toolkit/trx_list.py M src/target/trx_toolkit/trx_sniff.py M src/target/trx_toolkit/trxd_proto.py M src/target/trx_toolkit/udp_link.py 268 files changed, 0 insertions(+), 1,072 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/l1ctl_proto.h b/include/l1ctl_proto.h index cf41ac7..3720f82 100644 --- a/include/l1ctl_proto.h +++ b/include/l1ctl_proto.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef __L1CTL_PROTO_H__ diff --git a/src/host/fb_tools/bdf_to_c.py b/src/host/fb_tools/bdf_to_c.py index ebeb7f9..f808f50 100755 --- a/src/host/fb_tools/bdf_to_c.py +++ b/src/host/fb_tools/bdf_to_c.py @@ -19,10 +19,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. from optparse import OptionParser import sys diff --git a/src/host/gprsdecode/gprs.c b/src/host/gprsdecode/gprs.c index ae59cf9..4ba91ea 100644 --- a/src/host/gprsdecode/gprs.c +++ b/src/host/gprsdecode/gprs.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/gprsdecode/gsmtap.c b/src/host/gprsdecode/gsmtap.c index 1096c2d..ec816b3 100644 --- a/src/host/gprsdecode/gsmtap.c +++ b/src/host/gprsdecode/gsmtap.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/gprsdecode/main.c b/src/host/gprsdecode/main.c index 7e09489..49484e2 100644 --- a/src/host/gprsdecode/main.c +++ b/src/host/gprsdecode/main.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/gprsdecode/rlcmac.c b/src/host/gprsdecode/rlcmac.c index d33cb1e..dc11fd3 100644 --- a/src/host/gprsdecode/rlcmac.c +++ b/src/host/gprsdecode/rlcmac.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/gsmmap/gsmmap.c b/src/host/gsmmap/gsmmap.c index 83f0d01..feb8501 100644 --- a/src/host/gsmmap/gsmmap.c +++ b/src/host/gsmmap/gsmmap.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #warning todo bsic #include diff --git a/src/host/gsmmap/log.c b/src/host/gsmmap/log.c index c2db801..97bef49 100644 --- a/src/host/gsmmap/log.c +++ b/src/host/gsmmap/log.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/include/osmocom/bb/common/gps.h b/src/host/layer23/include/osmocom/bb/common/gps.h index 58c0c53..e7ce915 100644 --- a/src/host/layer23/include/osmocom/bb/common/gps.h +++ b/src/host/layer23/include/osmocom/bb/common/gps.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ enum { diff --git a/src/host/layer23/include/osmocom/bb/common/sim.h b/src/host/layer23/include/osmocom/bb/common/sim.h index 8b1f830..bebcffe 100644 --- a/src/host/layer23/include/osmocom/bb/common/sim.h +++ b/src/host/layer23/include/osmocom/bb/common/sim.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/host/layer23/include/osmocom/bb/misc/cell_log.h b/src/host/layer23/include/osmocom/bb/misc/cell_log.h index bce066e..bef6e6e 100644 --- a/src/host/layer23/include/osmocom/bb/misc/cell_log.h +++ b/src/host/layer23/include/osmocom/bb/misc/cell_log.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ int scan_init(struct osmocom_ms *_ms); diff --git a/src/host/layer23/include/osmocom/bb/mobile/mncc.h b/src/host/layer23/include/osmocom/bb/mobile/mncc.h index 5e976cc..c373412 100644 --- a/src/host/layer23/include/osmocom/bb/mobile/mncc.h +++ b/src/host/layer23/include/osmocom/bb/mobile/mncc.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef _MNCC_H diff --git a/src/host/layer23/src/common/gps.c b/src/host/layer23/src/common/gps.c index 5225fe0..b6b547b 100644 --- a/src/host/layer23/src/common/gps.c +++ b/src/host/layer23/src/common/gps.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/l1ctl.c b/src/host/layer23/src/common/l1ctl.c index da30767..9af6167 100644 --- a/src/host/layer23/src/common/l1ctl.c +++ b/src/host/layer23/src/common/l1ctl.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/l1ctl_lapdm_glue.c b/src/host/layer23/src/common/l1ctl_lapdm_glue.c index 0b2a8ed..df02370 100644 --- a/src/host/layer23/src/common/l1ctl_lapdm_glue.c +++ b/src/host/layer23/src/common/l1ctl_lapdm_glue.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/l1l2_interface.c b/src/host/layer23/src/common/l1l2_interface.c index cd5f910..04a5dba 100644 --- a/src/host/layer23/src/common/l1l2_interface.c +++ b/src/host/layer23/src/common/l1l2_interface.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/logging.c b/src/host/layer23/src/common/logging.c index 636a615..96decf9 100644 --- a/src/host/layer23/src/common/logging.c +++ b/src/host/layer23/src/common/logging.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/host/layer23/src/common/main.c b/src/host/layer23/src/common/main.c index 9d1c69e..6781bae 100644 --- a/src/host/layer23/src/common/main.c +++ b/src/host/layer23/src/common/main.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/sap_fsm.c b/src/host/layer23/src/common/sap_fsm.c index 2265891..7e08836 100644 --- a/src/host/layer23/src/common/sap_fsm.c +++ b/src/host/layer23/src/common/sap_fsm.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/sap_interface.c b/src/host/layer23/src/common/sap_interface.c index 0eac896..c4f1453 100644 --- a/src/host/layer23/src/common/sap_interface.c +++ b/src/host/layer23/src/common/sap_interface.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/sap_proto.c b/src/host/layer23/src/common/sap_proto.c index ecacfe0..2e89182 100644 --- a/src/host/layer23/src/common/sap_proto.c +++ b/src/host/layer23/src/common/sap_proto.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/sim.c b/src/host/layer23/src/common/sim.c index 1e2bc51..131a1ef 100644 --- a/src/host/layer23/src/common/sim.c +++ b/src/host/layer23/src/common/sim.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index f927773..8103647 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/common/utils.c b/src/host/layer23/src/common/utils.c index 4ecb134..417519b 100644 --- a/src/host/layer23/src/common/utils.c +++ b/src/host/layer23/src/common/utils.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/app_bcch_scan.c b/src/host/layer23/src/misc/app_bcch_scan.c index 5946699..c0c158b 100644 --- a/src/host/layer23/src/misc/app_bcch_scan.c +++ b/src/host/layer23/src/misc/app_bcch_scan.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/app_cbch_sniff.c b/src/host/layer23/src/misc/app_cbch_sniff.c index ed85cef..e011a4d 100644 --- a/src/host/layer23/src/misc/app_cbch_sniff.c +++ b/src/host/layer23/src/misc/app_cbch_sniff.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/app_ccch_scan.c b/src/host/layer23/src/misc/app_ccch_scan.c index e5a184f..bde4dc3 100644 --- a/src/host/layer23/src/misc/app_ccch_scan.c +++ b/src/host/layer23/src/misc/app_ccch_scan.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/app_cell_log.c b/src/host/layer23/src/misc/app_cell_log.c index 5b7f7b4..97319fd 100644 --- a/src/host/layer23/src/misc/app_cell_log.c +++ b/src/host/layer23/src/misc/app_cell_log.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/app_echo_test.c b/src/host/layer23/src/misc/app_echo_test.c index 3a0ee0f..531f10c 100644 --- a/src/host/layer23/src/misc/app_echo_test.c +++ b/src/host/layer23/src/misc/app_echo_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/bcch_scan.c b/src/host/layer23/src/misc/bcch_scan.c index 5dc0bc3..69df043 100644 --- a/src/host/layer23/src/misc/bcch_scan.c +++ b/src/host/layer23/src/misc/bcch_scan.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/cell_log.c b/src/host/layer23/src/misc/cell_log.c index 9edd742..cf56a8d 100644 --- a/src/host/layer23/src/misc/cell_log.c +++ b/src/host/layer23/src/misc/cell_log.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/misc/rslms.c b/src/host/layer23/src/misc/rslms.c index 455e663..b729c1c 100644 --- a/src/host/layer23/src/misc/rslms.c +++ b/src/host/layer23/src/misc/rslms.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c index a5feb79..0cb00c4 100644 --- a/src/host/layer23/src/mobile/app_mobile.c +++ b/src/host/layer23/src/mobile/app_mobile.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c index cc4f0cd..ea760b5 100644 --- a/src/host/layer23/src/mobile/gsm322.c +++ b/src/host/layer23/src/mobile/gsm322.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm411_sms.c b/src/host/layer23/src/mobile/gsm411_sms.c index 593a2ad..76355c0 100644 --- a/src/host/layer23/src/mobile/gsm411_sms.c +++ b/src/host/layer23/src/mobile/gsm411_sms.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm414.c b/src/host/layer23/src/mobile/gsm414.c index 2f630df..2fcf4dc 100644 --- a/src/host/layer23/src/mobile/gsm414.c +++ b/src/host/layer23/src/mobile/gsm414.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm480_ss.c b/src/host/layer23/src/mobile/gsm480_ss.c index 4ad2d7c..b68d542 100644 --- a/src/host/layer23/src/mobile/gsm480_ss.c +++ b/src/host/layer23/src/mobile/gsm480_ss.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm48_cc.c b/src/host/layer23/src/mobile/gsm48_cc.c index de0d035..a8d7a65 100644 --- a/src/host/layer23/src/mobile/gsm48_cc.c +++ b/src/host/layer23/src/mobile/gsm48_cc.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm48_mm.c b/src/host/layer23/src/mobile/gsm48_mm.c index 49cc2bc..80aff82 100644 --- a/src/host/layer23/src/mobile/gsm48_mm.c +++ b/src/host/layer23/src/mobile/gsm48_mm.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index e115d15..48c70f1 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* Very short description of some of the procedures: diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c index b1e0940..0602654 100644 --- a/src/host/layer23/src/mobile/main.c +++ b/src/host/layer23/src/mobile/main.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/mncc_sock.c b/src/host/layer23/src/mobile/mncc_sock.c index 5ea6feb..856b2c5 100644 --- a/src/host/layer23/src/mobile/mncc_sock.c +++ b/src/host/layer23/src/mobile/mncc_sock.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/mnccms.c b/src/host/layer23/src/mobile/mnccms.c index 9a37b97..3fec11e 100644 --- a/src/host/layer23/src/mobile/mnccms.c +++ b/src/host/layer23/src/mobile/mnccms.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/primitives.c b/src/host/layer23/src/mobile/primitives.c index f562466..4a40b4f 100644 --- a/src/host/layer23/src/mobile/primitives.c +++ b/src/host/layer23/src/mobile/primitives.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/script_lua.c b/src/host/layer23/src/mobile/script_lua.c index 50315bd..f8f2bf3 100644 --- a/src/host/layer23/src/mobile/script_lua.c +++ b/src/host/layer23/src/mobile/script_lua.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/script_nolua.c b/src/host/layer23/src/mobile/script_nolua.c index 61466f7..5973a44 100644 --- a/src/host/layer23/src/mobile/script_nolua.c +++ b/src/host/layer23/src/mobile/script_nolua.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/settings.c b/src/host/layer23/src/mobile/settings.c index 9742b1d..23da620 100644 --- a/src/host/layer23/src/mobile/settings.c +++ b/src/host/layer23/src/mobile/settings.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/subscriber.c b/src/host/layer23/src/mobile/subscriber.c index b2eacc5..500dd76 100644 --- a/src/host/layer23/src/mobile/subscriber.c +++ b/src/host/layer23/src/mobile/subscriber.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/support.c b/src/host/layer23/src/mobile/support.c index e9361a3..fd1ed74 100644 --- a/src/host/layer23/src/mobile/support.c +++ b/src/host/layer23/src/mobile/support.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/transaction.c b/src/host/layer23/src/mobile/transaction.c index 9824bd1..fd5a12d 100644 --- a/src/host/layer23/src/mobile/transaction.c +++ b/src/host/layer23/src/mobile/transaction.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/voice.c b/src/host/layer23/src/mobile/voice.c index c379265..7bcf8a6 100644 --- a/src/host/layer23/src/mobile/voice.c +++ b/src/host/layer23/src/mobile/voice.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index 073303c..57bc863 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c index d49c3fd..547f49f 100644 --- a/src/host/osmocon/osmocon.c +++ b/src/host/osmocon/osmocon.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/osmocon/osmoload.c b/src/host/osmocon/osmoload.c index d320b29..b2f14bb 100644 --- a/src/host/osmocon/osmoload.c +++ b/src/host/osmocon/osmoload.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/osmocon/tpu_debug.c b/src/host/osmocon/tpu_debug.c index 9160b01..82c8d30 100644 --- a/src/host/osmocon/tpu_debug.c +++ b/src/host/osmocon/tpu_debug.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c index 8083595..95ba9b6 100644 --- a/src/host/trxcon/l1ctl.c +++ b/src/host/trxcon/l1ctl.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/l1ctl_link.c b/src/host/trxcon/l1ctl_link.c index 4c406d6..552fc8b 100644 --- a/src/host/trxcon/l1ctl_link.c +++ b/src/host/trxcon/l1ctl_link.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/logging.c b/src/host/trxcon/logging.c index 78915f2..8352e6a 100644 --- a/src/host/trxcon/logging.c +++ b/src/host/trxcon/logging.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_common.c b/src/host/trxcon/sched_lchan_common.c index ae43ca9..ac6d262 100644 --- a/src/host/trxcon/sched_lchan_common.c +++ b/src/host/trxcon/sched_lchan_common.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_pdtch.c b/src/host/trxcon/sched_lchan_pdtch.c index bd02865..ad6a736 100644 --- a/src/host/trxcon/sched_lchan_pdtch.c +++ b/src/host/trxcon/sched_lchan_pdtch.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_rach.c b/src/host/trxcon/sched_lchan_rach.c index 25e1b44..76c0abb 100644 --- a/src/host/trxcon/sched_lchan_rach.c +++ b/src/host/trxcon/sched_lchan_rach.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_sch.c b/src/host/trxcon/sched_lchan_sch.c index 18d4c58..4d7804e 100644 --- a/src/host/trxcon/sched_lchan_sch.c +++ b/src/host/trxcon/sched_lchan_sch.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_tchf.c b/src/host/trxcon/sched_lchan_tchf.c index 0b38ea1..caf3586 100644 --- a/src/host/trxcon/sched_lchan_tchf.c +++ b/src/host/trxcon/sched_lchan_tchf.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_tchh.c b/src/host/trxcon/sched_lchan_tchh.c index 1079bb0..ae67de4 100644 --- a/src/host/trxcon/sched_lchan_tchh.c +++ b/src/host/trxcon/sched_lchan_tchh.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_lchan_xcch.c b/src/host/trxcon/sched_lchan_xcch.c index 78397fe..9fdbcc7 100644 --- a/src/host/trxcon/sched_lchan_xcch.c +++ b/src/host/trxcon/sched_lchan_xcch.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_prim.c b/src/host/trxcon/sched_prim.c index 9473320..e5554ea 100644 --- a/src/host/trxcon/sched_prim.c +++ b/src/host/trxcon/sched_prim.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/sched_trx.c b/src/host/trxcon/sched_trx.c index adcf198..828787e 100644 --- a/src/host/trxcon/sched_trx.c +++ b/src/host/trxcon/sched_trx.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/trxcon/trxcon.c b/src/host/trxcon/trxcon.c index 158e27f..d6ba0c4 100644 --- a/src/host/trxcon/trxcon.c +++ b/src/host/trxcon/trxcon.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/virt_phy/src/logging.c b/src/host/virt_phy/src/logging.c index f898a08..76caa27 100644 --- a/src/host/virt_phy/src/logging.c +++ b/src/host/virt_phy/src/logging.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/virt_phy/src/virt_prim_data.c b/src/host/virt_phy/src/virt_prim_data.c index 656ff80..f74a9fa 100644 --- a/src/host/virt_phy/src/virt_prim_data.c +++ b/src/host/virt_phy/src/virt_prim_data.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/virt_phy/src/virt_prim_fbsb.c b/src/host/virt_phy/src/virt_prim_fbsb.c index c14a448..9637ed9 100644 --- a/src/host/virt_phy/src/virt_prim_fbsb.c +++ b/src/host/virt_phy/src/virt_prim_fbsb.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/virt_phy/src/virt_prim_pm.c b/src/host/virt_phy/src/virt_prim_pm.c index 08d9b05..5a9a664 100644 --- a/src/host/virt_phy/src/virt_prim_pm.c +++ b/src/host/virt_phy/src/virt_prim_pm.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/virt_phy/src/virt_prim_rach.c b/src/host/virt_phy/src/virt_prim_rach.c index 94076cf..2813458 100644 --- a/src/host/virt_phy/src/virt_prim_rach.c +++ b/src/host/virt_phy/src/virt_prim_rach.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/host/virt_phy/src/virt_prim_traffic.c b/src/host/virt_phy/src/virt_prim_traffic.c index 0e08a12..1686ce9 100644 --- a/src/host/virt_phy/src/virt_prim_traffic.c +++ b/src/host/virt_phy/src/virt_prim_traffic.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/include/osmocom/core/bitvec.h b/src/shared/libosmocore/include/osmocom/core/bitvec.h index 9c000d0..d441c84 100644 --- a/src/shared/libosmocore/include/osmocom/core/bitvec.h +++ b/src/shared/libosmocore/include/osmocom/core/bitvec.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup bitvec Bit vectors diff --git a/src/shared/libosmocore/include/osmocom/core/conv.h b/src/shared/libosmocore/include/osmocom/core/conv.h index e5b2a97..e1e5c81 100644 --- a/src/shared/libosmocore/include/osmocom/core/conv.h +++ b/src/shared/libosmocore/include/osmocom/core/conv.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \defgroup conv Convolutional encoding and decoding routines diff --git a/src/shared/libosmocore/include/osmocom/core/crcXXgen.h.tpl b/src/shared/libosmocore/include/osmocom/core/crcXXgen.h.tpl index 89d083a..9d17e2d 100644 --- a/src/shared/libosmocore/include/osmocom/core/crcXXgen.h.tpl +++ b/src/shared/libosmocore/include/osmocom/core/crcXXgen.h.tpl @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #ifndef __OSMO_CRCXXGEN_H__ diff --git a/src/shared/libosmocore/include/osmocom/core/crcgen.h b/src/shared/libosmocore/include/osmocom/core/crcgen.h index 8e208a7..62c4545 100644 --- a/src/shared/libosmocore/include/osmocom/core/crcgen.h +++ b/src/shared/libosmocore/include/osmocom/core/crcgen.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #ifndef __OSMO_CRCGEN_H__ diff --git a/src/shared/libosmocore/include/osmocom/core/linuxrbtree.h b/src/shared/libosmocore/include/osmocom/core/linuxrbtree.h index 079f440..fccbf7e 100644 --- a/src/shared/libosmocore/include/osmocom/core/linuxrbtree.h +++ b/src/shared/libosmocore/include/osmocom/core/linuxrbtree.h @@ -12,10 +12,6 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - linux/include/linux/rbtree.h To use rbtrees you'll have to implement your own insert and search cores. diff --git a/src/shared/libosmocore/include/osmocom/core/msgb.h b/src/shared/libosmocore/include/osmocom/core/msgb.h index a1939ab..0390a96 100644 --- a/src/shared/libosmocore/include/osmocom/core/msgb.h +++ b/src/shared/libosmocore/include/osmocom/core/msgb.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/include/osmocom/core/msgfile.h b/src/shared/libosmocore/include/osmocom/core/msgfile.h index c5e67a4..d4e21f8 100644 --- a/src/shared/libosmocore/include/osmocom/core/msgfile.h +++ b/src/shared/libosmocore/include/osmocom/core/msgfile.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef MSG_FILE_H diff --git a/src/shared/libosmocore/include/osmocom/core/serial.h b/src/shared/libosmocore/include/osmocom/core/serial.h index 889bd8a..8810f33 100644 --- a/src/shared/libosmocore/include/osmocom/core/serial.h +++ b/src/shared/libosmocore/include/osmocom/core/serial.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \defgroup serial Utility functions to deal with serial ports diff --git a/src/shared/libosmocore/include/osmocom/core/timer.h b/src/shared/libosmocore/include/osmocom/core/timer.h index d37af80..bec2f05 100644 --- a/src/shared/libosmocore/include/osmocom/core/timer.h +++ b/src/shared/libosmocore/include/osmocom/core/timer.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup timer Osmocom timers diff --git a/src/shared/libosmocore/include/osmocom/core/timer_compat.h b/src/shared/libosmocore/include/osmocom/core/timer_compat.h index d86c109..2024087 100644 --- a/src/shared/libosmocore/include/osmocom/core/timer_compat.h +++ b/src/shared/libosmocore/include/osmocom/core/timer_compat.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup timer Osmocom timers diff --git a/src/shared/libosmocore/include/osmocom/core/write_queue.h b/src/shared/libosmocore/include/osmocom/core/write_queue.h index 816c036..c404164 100644 --- a/src/shared/libosmocore/include/osmocom/core/write_queue.h +++ b/src/shared/libosmocore/include/osmocom/core/write_queue.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef OSMO_WQUEUE_H #define OSMO_WQUEUE_H diff --git a/src/shared/libosmocore/include/osmocom/gsm/a5.h b/src/shared/libosmocore/include/osmocom/gsm/a5.h index 649dbab..807a2d8 100644 --- a/src/shared/libosmocore/include/osmocom/gsm/a5.h +++ b/src/shared/libosmocore/include/osmocom/gsm/a5.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #ifndef __OSMO_A5_H__ diff --git a/src/shared/libosmocore/include/osmocom/gsm/gsm0808.h b/src/shared/libosmocore/include/osmocom/gsm/gsm0808.h index 5380dd9..11c27b7 100644 --- a/src/shared/libosmocore/include/osmocom/gsm/gsm0808.h +++ b/src/shared/libosmocore/include/osmocom/gsm/gsm0808.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef OSMOCORE_GSM0808_H #define OSMOCORE_GSM0808_H diff --git a/src/shared/libosmocore/include/osmocom/gsm/gsm_utils.h b/src/shared/libosmocore/include/osmocom/gsm/gsm_utils.h index 6d31672..9e277d1 100644 --- a/src/shared/libosmocore/include/osmocom/gsm/gsm_utils.h +++ b/src/shared/libosmocore/include/osmocom/gsm/gsm_utils.h @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef GSM_UTILS_H diff --git a/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_08_58.h b/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_08_58.h index 57a8f68..41d65af 100644 --- a/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_08_58.h +++ b/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_08_58.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_12_21.h b/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_12_21.h index 694df93..76e8bd0 100644 --- a/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_12_21.h +++ b/src/shared/libosmocore/include/osmocom/gsm/protocol/gsm_12_21.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup oml diff --git a/src/shared/libosmocore/include/osmocom/vty/telnet_interface.h b/src/shared/libosmocore/include/osmocom/vty/telnet_interface.h index 3c22201..29e8e13 100644 --- a/src/shared/libosmocore/include/osmocom/vty/telnet_interface.h +++ b/src/shared/libosmocore/include/osmocom/vty/telnet_interface.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef TELNET_INTERFACE_H diff --git a/src/shared/libosmocore/include/osmocom/vty/vector.h b/src/shared/libosmocore/include/osmocom/vty/vector.h index 22a184d..f0d269c 100644 --- a/src/shared/libosmocore/include/osmocom/vty/vector.h +++ b/src/shared/libosmocore/include/osmocom/vty/vector.h @@ -13,10 +13,6 @@ * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with GNU Zebra; see the file COPYING. If not, write to the Free - * Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA * 02111-1307, USA. */ diff --git a/src/shared/libosmocore/src/application.c b/src/shared/libosmocore/src/application.c index e0d989e..98175fb 100644 --- a/src/shared/libosmocore/src/application.c +++ b/src/shared/libosmocore/src/application.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \file application.c diff --git a/src/shared/libosmocore/src/backtrace.c b/src/shared/libosmocore/src/backtrace.c index 5b93bec..53cece6 100644 --- a/src/shared/libosmocore/src/backtrace.c +++ b/src/shared/libosmocore/src/backtrace.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \file backtrace.c diff --git a/src/shared/libosmocore/src/bitvec.c b/src/shared/libosmocore/src/bitvec.c index 714c11b..1e3ee6a 100644 --- a/src/shared/libosmocore/src/bitvec.c +++ b/src/shared/libosmocore/src/bitvec.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup bitvec diff --git a/src/shared/libosmocore/src/codec/gsm610.c b/src/shared/libosmocore/src/codec/gsm610.c index 35f6011..faa8fb4 100644 --- a/src/shared/libosmocore/src/codec/gsm610.c +++ b/src/shared/libosmocore/src/codec/gsm610.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/codec/gsm620.c b/src/shared/libosmocore/src/codec/gsm620.c index fa570e4..67e1a8b 100644 --- a/src/shared/libosmocore/src/codec/gsm620.c +++ b/src/shared/libosmocore/src/codec/gsm620.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/codec/gsm660.c b/src/shared/libosmocore/src/codec/gsm660.c index c044a2a..bd00341 100644 --- a/src/shared/libosmocore/src/codec/gsm660.c +++ b/src/shared/libosmocore/src/codec/gsm660.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/codec/gsm690.c b/src/shared/libosmocore/src/codec/gsm690.c index fdf3302..8d94c5a 100644 --- a/src/shared/libosmocore/src/codec/gsm690.c +++ b/src/shared/libosmocore/src/codec/gsm690.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/conv.c b/src/shared/libosmocore/src/conv.c index ebc3eda..77c505c 100644 --- a/src/shared/libosmocore/src/conv.c +++ b/src/shared/libosmocore/src/conv.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup conv diff --git a/src/shared/libosmocore/src/crcXXgen.c.tpl b/src/shared/libosmocore/src/crcXXgen.c.tpl index 80bf1e2..b4486c5 100644 --- a/src/shared/libosmocore/src/crcXXgen.c.tpl +++ b/src/shared/libosmocore/src/crcXXgen.c.tpl @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup crcgen diff --git a/src/shared/libosmocore/src/gsm/a5.c b/src/shared/libosmocore/src/gsm/a5.c index 356060a..6001908 100644 --- a/src/shared/libosmocore/src/gsm/a5.c +++ b/src/shared/libosmocore/src/gsm/a5.c @@ -20,10 +20,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup a5 diff --git a/src/shared/libosmocore/src/gsm/auth_comp128v1.c b/src/shared/libosmocore/src/gsm/auth_comp128v1.c index 41aef71..14e44f4 100644 --- a/src/shared/libosmocore/src/gsm/auth_comp128v1.c +++ b/src/shared/libosmocore/src/gsm/auth_comp128v1.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/auth_core.c b/src/shared/libosmocore/src/gsm/auth_core.c index 5cf8dfc..de3d26a 100644 --- a/src/shared/libosmocore/src/gsm/auth_core.c +++ b/src/shared/libosmocore/src/gsm/auth_core.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/auth_milenage.c b/src/shared/libosmocore/src/gsm/auth_milenage.c index 5b2787d..cac1a05 100644 --- a/src/shared/libosmocore/src/gsm/auth_milenage.c +++ b/src/shared/libosmocore/src/gsm/auth_milenage.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/comp128.c b/src/shared/libosmocore/src/gsm/comp128.c index b7a2382..5aaf91f 100644 --- a/src/shared/libosmocore/src/gsm/comp128.c +++ b/src/shared/libosmocore/src/gsm/comp128.c @@ -26,10 +26,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* diff --git a/src/shared/libosmocore/src/gsm/gprs_cipher_core.c b/src/shared/libosmocore/src/gsm/gprs_cipher_core.c index b9a22a1..db3b084 100644 --- a/src/shared/libosmocore/src/gsm/gprs_cipher_core.c +++ b/src/shared/libosmocore/src/gsm/gprs_cipher_core.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/gsm0480.c b/src/shared/libosmocore/src/gsm/gsm0480.c index b9b3ed9..6a4dd29 100644 --- a/src/shared/libosmocore/src/gsm/gsm0480.c +++ b/src/shared/libosmocore/src/gsm/gsm0480.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/gsm0808.c b/src/shared/libosmocore/src/gsm/gsm0808.c index 3009827..55dc41c 100644 --- a/src/shared/libosmocore/src/gsm/gsm0808.c +++ b/src/shared/libosmocore/src/gsm/gsm0808.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/gsm48.c b/src/shared/libosmocore/src/gsm/gsm48.c index ea05d45..b1ef65a 100644 --- a/src/shared/libosmocore/src/gsm/gsm48.c +++ b/src/shared/libosmocore/src/gsm/gsm48.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/gsm48_ie.c b/src/shared/libosmocore/src/gsm/gsm48_ie.c index 78619b9..84252c6 100644 --- a/src/shared/libosmocore/src/gsm/gsm48_ie.c +++ b/src/shared/libosmocore/src/gsm/gsm48_ie.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/shared/libosmocore/src/gsm/gsm_utils.c b/src/shared/libosmocore/src/gsm/gsm_utils.c index 8b1fae0..4b170df 100644 --- a/src/shared/libosmocore/src/gsm/gsm_utils.c +++ b/src/shared/libosmocore/src/gsm/gsm_utils.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \mainpage libosmogsm Documentation diff --git a/src/shared/libosmocore/src/gsm/lapd_core.c b/src/shared/libosmocore/src/gsm/lapd_core.c index 96099ed..47a2a8d 100644 --- a/src/shared/libosmocore/src/gsm/lapd_core.c +++ b/src/shared/libosmocore/src/gsm/lapd_core.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup lapd diff --git a/src/shared/libosmocore/src/gsm/lapdm.c b/src/shared/libosmocore/src/gsm/lapdm.c index 1c08113..5e1c2d5 100644 --- a/src/shared/libosmocore/src/gsm/lapdm.c +++ b/src/shared/libosmocore/src/gsm/lapdm.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup lapdm diff --git a/src/shared/libosmocore/src/gsm/rsl.c b/src/shared/libosmocore/src/gsm/rsl.c index 5693b4f..366eae5 100644 --- a/src/shared/libosmocore/src/gsm/rsl.c +++ b/src/shared/libosmocore/src/gsm/rsl.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsm/rxlev_stat.c b/src/shared/libosmocore/src/gsm/rxlev_stat.c index d226861..fb3a2a5 100644 --- a/src/shared/libosmocore/src/gsm/rxlev_stat.c +++ b/src/shared/libosmocore/src/gsm/rxlev_stat.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/gsmtap_util.c b/src/shared/libosmocore/src/gsmtap_util.c index ce722da..12a1dcf 100644 --- a/src/shared/libosmocore/src/gsmtap_util.c +++ b/src/shared/libosmocore/src/gsmtap_util.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "../config.h" diff --git a/src/shared/libosmocore/src/logging.c b/src/shared/libosmocore/src/logging.c index f58265f..e187df2 100644 --- a/src/shared/libosmocore/src/logging.c +++ b/src/shared/libosmocore/src/logging.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* \addtogroup logging diff --git a/src/shared/libosmocore/src/logging_syslog.c b/src/shared/libosmocore/src/logging_syslog.c index 5b0ae5f..8bc2dfd 100644 --- a/src/shared/libosmocore/src/logging_syslog.c +++ b/src/shared/libosmocore/src/logging_syslog.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup logging diff --git a/src/shared/libosmocore/src/msgb.c b/src/shared/libosmocore/src/msgb.c index c8564db..4c703fe 100644 --- a/src/shared/libosmocore/src/msgb.c +++ b/src/shared/libosmocore/src/msgb.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup msgb diff --git a/src/shared/libosmocore/src/msgfile.c b/src/shared/libosmocore/src/msgfile.c index d2b180d..14929ed 100644 --- a/src/shared/libosmocore/src/msgfile.c +++ b/src/shared/libosmocore/src/msgfile.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/panic.c b/src/shared/libosmocore/src/panic.c index be644ff..1913403 100644 --- a/src/shared/libosmocore/src/panic.c +++ b/src/shared/libosmocore/src/panic.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup utils diff --git a/src/shared/libosmocore/src/plugin.c b/src/shared/libosmocore/src/plugin.c index 998bca3..9f17698 100644 --- a/src/shared/libosmocore/src/plugin.c +++ b/src/shared/libosmocore/src/plugin.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "../config.h" diff --git a/src/shared/libosmocore/src/rate_ctr.c b/src/shared/libosmocore/src/rate_ctr.c index 8a232e8..79d41dd 100644 --- a/src/shared/libosmocore/src/rate_ctr.c +++ b/src/shared/libosmocore/src/rate_ctr.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup rate_ctr diff --git a/src/shared/libosmocore/src/rbtree.c b/src/shared/libosmocore/src/rbtree.c index 4e7c0f3..2da7d7e 100644 --- a/src/shared/libosmocore/src/rbtree.c +++ b/src/shared/libosmocore/src/rbtree.c @@ -13,10 +13,6 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - linux/lib/rbtree.c */ diff --git a/src/shared/libosmocore/src/select.c b/src/shared/libosmocore/src/select.c index 6b73377..11f1a2a 100644 --- a/src/shared/libosmocore/src/select.c +++ b/src/shared/libosmocore/src/select.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include diff --git a/src/shared/libosmocore/src/serial.c b/src/shared/libosmocore/src/serial.c index a025ae9..780cf44 100644 --- a/src/shared/libosmocore/src/serial.c +++ b/src/shared/libosmocore/src/serial.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup serial diff --git a/src/shared/libosmocore/src/signal.c b/src/shared/libosmocore/src/signal.c index 6384384..6f8c798 100644 --- a/src/shared/libosmocore/src/signal.c +++ b/src/shared/libosmocore/src/signal.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/statistics.c b/src/shared/libosmocore/src/statistics.c index e28541b..d18f416 100644 --- a/src/shared/libosmocore/src/statistics.c +++ b/src/shared/libosmocore/src/statistics.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/timer.c b/src/shared/libosmocore/src/timer.c index 6d4abc2..55d08d3 100644 --- a/src/shared/libosmocore/src/timer.c +++ b/src/shared/libosmocore/src/timer.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* These store the amount of time that we wait until next timer expires. */ diff --git a/src/shared/libosmocore/src/vty/logging_vty.c b/src/shared/libosmocore/src/vty/logging_vty.c index 6029d58..4f13852 100644 --- a/src/shared/libosmocore/src/vty/logging_vty.c +++ b/src/shared/libosmocore/src/vty/logging_vty.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/vty/telnet_interface.c b/src/shared/libosmocore/src/vty/telnet_interface.c index 1abf141..821a649 100644 --- a/src/shared/libosmocore/src/vty/telnet_interface.c +++ b/src/shared/libosmocore/src/vty/telnet_interface.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/vty/utils.c b/src/shared/libosmocore/src/vty/utils.c index e9c0d2d..af49c30 100644 --- a/src/shared/libosmocore/src/vty/utils.c +++ b/src/shared/libosmocore/src/vty/utils.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/src/vty/vector.c b/src/shared/libosmocore/src/vty/vector.c index 4012f24..bda96d9 100644 --- a/src/shared/libosmocore/src/vty/vector.c +++ b/src/shared/libosmocore/src/vty/vector.c @@ -12,10 +12,6 @@ * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with GNU Zebra; see the file COPYING. If not, write to the Free - * Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA * 02111-1307, USA. */ diff --git a/src/shared/libosmocore/src/write_queue.c b/src/shared/libosmocore/src/write_queue.c index cef40f8..d353210 100644 --- a/src/shared/libosmocore/src/write_queue.c +++ b/src/shared/libosmocore/src/write_queue.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/gsm0408/gsm0408_test.c b/src/shared/libosmocore/tests/gsm0408/gsm0408_test.c index 077063b..e31d056 100644 --- a/src/shared/libosmocore/tests/gsm0408/gsm0408_test.c +++ b/src/shared/libosmocore/tests/gsm0408/gsm0408_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/gsm0808/gsm0808_test.c b/src/shared/libosmocore/tests/gsm0808/gsm0808_test.c index 7e5e97b..8cc0fbb 100644 --- a/src/shared/libosmocore/tests/gsm0808/gsm0808_test.c +++ b/src/shared/libosmocore/tests/gsm0808/gsm0808_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/lapd/lapd_test.c b/src/shared/libosmocore/tests/lapd/lapd_test.c index d58bec6..0bd89b7 100644 --- a/src/shared/libosmocore/tests/lapd/lapd_test.c +++ b/src/shared/libosmocore/tests/lapd/lapd_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/msgfile/msgfile_test.c b/src/shared/libosmocore/tests/msgfile/msgfile_test.c index ed7aa97..abea917 100644 --- a/src/shared/libosmocore/tests/msgfile/msgfile_test.c +++ b/src/shared/libosmocore/tests/msgfile/msgfile_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/sms/sms_test.c b/src/shared/libosmocore/tests/sms/sms_test.c index 6df4b62..18a7d1e 100644 --- a/src/shared/libosmocore/tests/sms/sms_test.c +++ b/src/shared/libosmocore/tests/sms/sms_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/smscb/smscb_test.c b/src/shared/libosmocore/tests/smscb/smscb_test.c index e10e12d..34178e2 100644 --- a/src/shared/libosmocore/tests/smscb/smscb_test.c +++ b/src/shared/libosmocore/tests/smscb/smscb_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/timer/timer_test.c b/src/shared/libosmocore/tests/timer/timer_test.c index ba3127d..7b973c0 100644 --- a/src/shared/libosmocore/tests/timer/timer_test.c +++ b/src/shared/libosmocore/tests/timer/timer_test.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/tests/ussd/ussd_test.c b/src/shared/libosmocore/tests/ussd/ussd_test.c index 55384f1..0ddab90 100644 --- a/src/shared/libosmocore/tests/ussd/ussd_test.c +++ b/src/shared/libosmocore/tests/ussd/ussd_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/utils/osmo-arfcn.c b/src/shared/libosmocore/utils/osmo-arfcn.c index 15adbca..172ee54 100644 --- a/src/shared/libosmocore/utils/osmo-arfcn.c +++ b/src/shared/libosmocore/utils/osmo-arfcn.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/shared/libosmocore/utils/osmo-auc-gen.c b/src/shared/libosmocore/utils/osmo-auc-gen.c index 7a3c124..449bcc6 100644 --- a/src/shared/libosmocore/utils/osmo-auc-gen.c +++ b/src/shared/libosmocore/utils/osmo-auc-gen.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/target/firmware/abb/twl3025.c b/src/target/firmware/abb/twl3025.c index 5b792d6..1c099dc 100644 --- a/src/target/firmware/abb/twl3025.c +++ b/src/target/firmware/abb/twl3025.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/compal_dsp_dump/main.c b/src/target/firmware/apps/compal_dsp_dump/main.c index 5e1ab68..e5521c3 100644 --- a/src/target/firmware/apps/compal_dsp_dump/main.c +++ b/src/target/firmware/apps/compal_dsp_dump/main.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/hello_world/main.c b/src/target/firmware/apps/hello_world/main.c index 481cf17..aeb5739 100644 --- a/src/target/firmware/apps/hello_world/main.c +++ b/src/target/firmware/apps/hello_world/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/layer1/main.c b/src/target/firmware/apps/layer1/main.c index b2e66e2..701d95f 100644 --- a/src/target/firmware/apps/layer1/main.c +++ b/src/target/firmware/apps/layer1/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/loader/main.c b/src/target/firmware/apps/loader/main.c index 9b7a1b5..e828fff 100644 --- a/src/target/firmware/apps/loader/main.c +++ b/src/target/firmware/apps/loader/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/loader_mtk/main.c b/src/target/firmware/apps/loader_mtk/main.c index f2ebbea..995d277 100644 --- a/src/target/firmware/apps/loader_mtk/main.c +++ b/src/target/firmware/apps/loader_mtk/main.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/menu/main.c b/src/target/firmware/apps/menu/main.c index fa36968..5d96cc0 100644 --- a/src/target/firmware/apps/menu/main.c +++ b/src/target/firmware/apps/menu/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index b04fe28..9a3f87c 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/simtest/main.c b/src/target/firmware/apps/simtest/main.c index e20c52a..d41891d 100755 --- a/src/target/firmware/apps/simtest/main.c +++ b/src/target/firmware/apps/simtest/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/apps/snake_game/main.c b/src/target/firmware/apps/snake_game/main.c index 44dda9a..4945b6f 100644 --- a/src/target/firmware/apps/snake_game/main.c +++ b/src/target/firmware/apps/snake_game/main.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/battery/compal_e88.c b/src/target/firmware/battery/compal_e88.c index 609d406..42f77f2 100644 --- a/src/target/firmware/battery/compal_e88.c +++ b/src/target/firmware/battery/compal_e88.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* diff --git a/src/target/firmware/board/common/readcal_tiffs.c b/src/target/firmware/board/common/readcal_tiffs.c index 4351971..175f25a 100644 --- a/src/target/firmware/board/common/readcal_tiffs.c +++ b/src/target/firmware/board/common/readcal_tiffs.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/common/tx_calchan.c b/src/target/firmware/board/common/tx_calchan.c index 9901e71..b86464d 100644 --- a/src/target/firmware/board/common/tx_calchan.c +++ b/src/target/firmware/board/common/tx_calchan.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal/readcal_common.c b/src/target/firmware/board/compal/readcal_common.c index 2f7944c..c0260b6 100644 --- a/src/target/firmware/board/compal/readcal_common.c +++ b/src/target/firmware/board/compal/readcal_common.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal/readcal_small.c b/src/target/firmware/board/compal/readcal_small.c index a036e11..32302d2 100644 --- a/src/target/firmware/board/compal/readcal_small.c +++ b/src/target/firmware/board/compal/readcal_small.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal/rf_tables.c b/src/target/firmware/board/compal/rf_tables.c index dd7411d..f115f29 100644 --- a/src/target/firmware/board/compal/rf_tables.c +++ b/src/target/firmware/board/compal/rf_tables.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal_e86/init.c b/src/target/firmware/board/compal_e86/init.c index 725f184..82a96eb 100644 --- a/src/target/firmware/board/compal_e86/init.c +++ b/src/target/firmware/board/compal_e86/init.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal_e86/tx_ramps.c b/src/target/firmware/board/compal_e86/tx_ramps.c index 7bac4d5..195242a 100644 --- a/src/target/firmware/board/compal_e86/tx_ramps.c +++ b/src/target/firmware/board/compal_e86/tx_ramps.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal_e88/init.c b/src/target/firmware/board/compal_e88/init.c index 956f7dc..0937644 100755 --- a/src/target/firmware/board/compal_e88/init.c +++ b/src/target/firmware/board/compal_e88/init.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal_e88/tx_ramps.c b/src/target/firmware/board/compal_e88/tx_ramps.c index 846a21d..79b3180 100644 --- a/src/target/firmware/board/compal_e88/tx_ramps.c +++ b/src/target/firmware/board/compal_e88/tx_ramps.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal_e99/init.c b/src/target/firmware/board/compal_e99/init.c index 0271f16..18c94fd 100644 --- a/src/target/firmware/board/compal_e99/init.c +++ b/src/target/firmware/board/compal_e99/init.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/compal_e99/readcal.c b/src/target/firmware/board/compal_e99/readcal.c index c75e1fa..c4a113f 100644 --- a/src/target/firmware/board/compal_e99/readcal.c +++ b/src/target/firmware/board/compal_e99/readcal.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/fcdev3b/init.c b/src/target/firmware/board/fcdev3b/init.c index c070536..03bd6d7 100644 --- a/src/target/firmware/board/fcdev3b/init.c +++ b/src/target/firmware/board/fcdev3b/init.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/gta0x/afcparams.c b/src/target/firmware/board/gta0x/afcparams.c index ba48360..5bf68ac 100644 --- a/src/target/firmware/board/gta0x/afcparams.c +++ b/src/target/firmware/board/gta0x/afcparams.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/gta0x/init.c b/src/target/firmware/board/gta0x/init.c index 7fba756..49279d1 100644 --- a/src/target/firmware/board/gta0x/init.c +++ b/src/target/firmware/board/gta0x/init.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/gta0x/rf_tables.c b/src/target/firmware/board/gta0x/rf_tables.c index 9a08b3c..650c77c 100644 --- a/src/target/firmware/board/gta0x/rf_tables.c +++ b/src/target/firmware/board/gta0x/rf_tables.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/gtm900b/afcparams.c b/src/target/firmware/board/gtm900b/afcparams.c index ca8908d..9dbbe7e 100644 --- a/src/target/firmware/board/gtm900b/afcparams.c +++ b/src/target/firmware/board/gtm900b/afcparams.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/gtm900b/init.c b/src/target/firmware/board/gtm900b/init.c index 934e96e..58a1e1e 100644 --- a/src/target/firmware/board/gtm900b/init.c +++ b/src/target/firmware/board/gtm900b/init.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/mediatek/uart.c b/src/target/firmware/board/mediatek/uart.c index f9e3283..7b4c49a 100644 --- a/src/target/firmware/board/mediatek/uart.c +++ b/src/target/firmware/board/mediatek/uart.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/mt62xx/init.c b/src/target/firmware/board/mt62xx/init.c index dae38cf..baa6fcd 100644 --- a/src/target/firmware/board/mt62xx/init.c +++ b/src/target/firmware/board/mt62xx/init.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/pirelli_dpl10/init.c b/src/target/firmware/board/pirelli_dpl10/init.c index 1af6e7c..273a11d 100644 --- a/src/target/firmware/board/pirelli_dpl10/init.c +++ b/src/target/firmware/board/pirelli_dpl10/init.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/pirelli_dpl10/readcal.c b/src/target/firmware/board/pirelli_dpl10/readcal.c index 6a4670a..40f608f 100644 --- a/src/target/firmware/board/pirelli_dpl10/readcal.c +++ b/src/target/firmware/board/pirelli_dpl10/readcal.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/pirelli_dpl10/rf_tables.c b/src/target/firmware/board/pirelli_dpl10/rf_tables.c index 34fbbcb..a2d26b1 100644 --- a/src/target/firmware/board/pirelli_dpl10/rf_tables.c +++ b/src/target/firmware/board/pirelli_dpl10/rf_tables.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/se_j100/init.c b/src/target/firmware/board/se_j100/init.c index 0ae477a..6352b36 100644 --- a/src/target/firmware/board/se_j100/init.c +++ b/src/target/firmware/board/se_j100/init.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/board/se_j100/tx_ramps.c b/src/target/firmware/board/se_j100/tx_ramps.c index b1110e0..387febb 100644 --- a/src/target/firmware/board/se_j100/tx_ramps.c +++ b/src/target/firmware/board/se_j100/tx_ramps.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/backlight.c b/src/target/firmware/calypso/backlight.c index cf29984..ba41bac 100644 --- a/src/target/firmware/calypso/backlight.c +++ b/src/target/firmware/calypso/backlight.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/buzzer.c b/src/target/firmware/calypso/buzzer.c index e76906f..4d9e60b 100644 --- a/src/target/firmware/calypso/buzzer.c +++ b/src/target/firmware/calypso/buzzer.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/clock.c b/src/target/firmware/calypso/clock.c index 246b6e0..36a4ef1 100644 --- a/src/target/firmware/calypso/clock.c +++ b/src/target/firmware/calypso/clock.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/dma.c b/src/target/firmware/calypso/dma.c index 35c5be8..5580cb5 100644 --- a/src/target/firmware/calypso/dma.c +++ b/src/target/firmware/calypso/dma.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/dsp.c b/src/target/firmware/calypso/dsp.c index 235d359..430c991 100644 --- a/src/target/firmware/calypso/dsp.c +++ b/src/target/firmware/calypso/dsp.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/du.c b/src/target/firmware/calypso/du.c index 58783b0..776cd74 100644 --- a/src/target/firmware/calypso/du.c +++ b/src/target/firmware/calypso/du.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/i2c.c b/src/target/firmware/calypso/i2c.c index bf44178..ad7d584 100644 --- a/src/target/firmware/calypso/i2c.c +++ b/src/target/firmware/calypso/i2c.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/irq.c b/src/target/firmware/calypso/irq.c index 136fd55..335bdc4 100644 --- a/src/target/firmware/calypso/irq.c +++ b/src/target/firmware/calypso/irq.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/keypad.c b/src/target/firmware/calypso/keypad.c index c3c1810..e4d11fb 100644 --- a/src/target/firmware/calypso/keypad.c +++ b/src/target/firmware/calypso/keypad.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/rtc.c b/src/target/firmware/calypso/rtc.c index 45d759f..288a183 100644 --- a/src/target/firmware/calypso/rtc.c +++ b/src/target/firmware/calypso/rtc.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/sim.c b/src/target/firmware/calypso/sim.c index dc5885c..ddc9694 100644 --- a/src/target/firmware/calypso/sim.c +++ b/src/target/firmware/calypso/sim.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* Uncomment to debug sim */ diff --git a/src/target/firmware/calypso/spi.c b/src/target/firmware/calypso/spi.c index 049ac08..a9b937e 100644 --- a/src/target/firmware/calypso/spi.c +++ b/src/target/firmware/calypso/spi.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/timer.c b/src/target/firmware/calypso/timer.c index 1dd55f2..5141a83 100644 --- a/src/target/firmware/calypso/timer.c +++ b/src/target/firmware/calypso/timer.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/tpu.c b/src/target/firmware/calypso/tpu.c index cbeef84..d84136c 100644 --- a/src/target/firmware/calypso/tpu.c +++ b/src/target/firmware/calypso/tpu.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/tsp.c b/src/target/firmware/calypso/tsp.c index 5d24f48..22ec538 100644 --- a/src/target/firmware/calypso/tsp.c +++ b/src/target/firmware/calypso/tsp.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/uart.c b/src/target/firmware/calypso/uart.c index ec587de..8dd96da 100644 --- a/src/target/firmware/calypso/uart.c +++ b/src/target/firmware/calypso/uart.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/calypso/uwire.c b/src/target/firmware/calypso/uwire.c index ac8f15e..214433c 100644 --- a/src/target/firmware/calypso/uwire.c +++ b/src/target/firmware/calypso/uwire.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/comm/msgb.c b/src/target/firmware/comm/msgb.c index 08f5acb..c564e79 100644 --- a/src/target/firmware/comm/msgb.c +++ b/src/target/firmware/comm/msgb.c @@ -11,10 +11,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/target/firmware/comm/sercomm.c b/src/target/firmware/comm/sercomm.c index cebd37d..360dafe 100644 --- a/src/target/firmware/comm/sercomm.c +++ b/src/target/firmware/comm/sercomm.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/comm/sercomm_cons.c b/src/target/firmware/comm/sercomm_cons.c index e6b6934..275ca5a 100644 --- a/src/target/firmware/comm/sercomm_cons.c +++ b/src/target/firmware/comm/sercomm_cons.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/comm/timer.c b/src/target/firmware/comm/timer.c index ce4f06d..44ef551 100644 --- a/src/target/firmware/comm/timer.c +++ b/src/target/firmware/comm/timer.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_bw8.c b/src/target/firmware/fb/fb_bw8.c index 0fc12ee..95ea2df 100644 --- a/src/target/firmware/fb/fb_bw8.c +++ b/src/target/firmware/fb/fb_bw8.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_dummy.c b/src/target/firmware/fb/fb_dummy.c index cb053de..b34656f 100644 --- a/src/target/firmware/fb/fb_dummy.c +++ b/src/target/firmware/fb/fb_dummy.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_rgb332.c b/src/target/firmware/fb/fb_rgb332.c index 569ccc7..7347488 100644 --- a/src/target/firmware/fb/fb_rgb332.c +++ b/src/target/firmware/fb/fb_rgb332.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_s6b33b1x.c b/src/target/firmware/fb/fb_s6b33b1x.c index e36c547..28fe555 100644 --- a/src/target/firmware/fb/fb_s6b33b1x.c +++ b/src/target/firmware/fb/fb_s6b33b1x.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_ssd1783.c b/src/target/firmware/fb/fb_ssd1783.c index cacdce0..3b39ad0 100644 --- a/src/target/firmware/fb/fb_ssd1783.c +++ b/src/target/firmware/fb/fb_ssd1783.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_ssd1963.c b/src/target/firmware/fb/fb_ssd1963.c index 361434e..dee884d 100644 --- a/src/target/firmware/fb/fb_ssd1963.c +++ b/src/target/firmware/fb/fb_ssd1963.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_st7558.c b/src/target/firmware/fb/fb_st7558.c index f09b12b..a2c6f50 100644 --- a/src/target/firmware/fb/fb_st7558.c +++ b/src/target/firmware/fb/fb_st7558.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/fb_td014.c b/src/target/firmware/fb/fb_td014.c index c7bde0c..b96fe94 100644 --- a/src/target/firmware/fb/fb_td014.c +++ b/src/target/firmware/fb/fb_td014.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/font.c b/src/target/firmware/fb/font.c index 18c1bfe..7ca9912 100644 --- a/src/target/firmware/fb/font.c +++ b/src/target/firmware/fb/font.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/fb/framebuffer.c b/src/target/firmware/fb/framebuffer.c index ab54769..5132eea 100644 --- a/src/target/firmware/fb/framebuffer.c +++ b/src/target/firmware/fb/framebuffer.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/flash/cfi_flash.c b/src/target/firmware/flash/cfi_flash.c index 2f8cde0..e34fa77 100644 --- a/src/target/firmware/flash/cfi_flash.c +++ b/src/target/firmware/flash/cfi_flash.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/include/calypso/du.h b/src/target/firmware/include/calypso/du.h index f2eae09..8f71d01 100644 --- a/src/target/firmware/include/calypso/du.h +++ b/src/target/firmware/include/calypso/du.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef _CALYPSO_DU_H diff --git a/src/target/firmware/include/calypso/sim.h b/src/target/firmware/include/calypso/sim.h index 8f627b1..686e578 100755 --- a/src/target/firmware/include/calypso/sim.h +++ b/src/target/firmware/include/calypso/sim.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef _CALYPSO_SIM_H diff --git a/src/target/firmware/include/comm/timer.h b/src/target/firmware/include/comm/timer.h index d43b067..e7c518d 100644 --- a/src/target/firmware/include/comm/timer.h +++ b/src/target/firmware/include/comm/timer.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef TIMER_H diff --git a/src/target/firmware/include/mtk/emi.h b/src/target/firmware/include/mtk/emi.h index 1818499..ee1399c 100644 --- a/src/target/firmware/include/mtk/emi.h +++ b/src/target/firmware/include/mtk/emi.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef __MTK_EMI_H_ diff --git a/src/target/firmware/include/mtk/mt6235.h b/src/target/firmware/include/mtk/mt6235.h index fb9d368..2d36bee 100644 --- a/src/target/firmware/include/mtk/mt6235.h +++ b/src/target/firmware/include/mtk/mt6235.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef __MT6235_H diff --git a/src/target/firmware/include/mtk/system.h b/src/target/firmware/include/mtk/system.h index 4543029..9c28b56 100644 --- a/src/target/firmware/include/mtk/system.h +++ b/src/target/firmware/include/mtk/system.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef __MTK_SYSTEM_H_ diff --git a/src/target/firmware/layer1/afc.c b/src/target/firmware/layer1/afc.c index 1a198e3..f4533ad 100644 --- a/src/target/firmware/layer1/afc.c +++ b/src/target/firmware/layer1/afc.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/agc.c b/src/target/firmware/layer1/agc.c index b72a6e7..66e7f09 100644 --- a/src/target/firmware/layer1/agc.c +++ b/src/target/firmware/layer1/agc.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/async.c b/src/target/firmware/layer1/async.c index cb2a2a8..1f3d6f1 100644 --- a/src/target/firmware/layer1/async.c +++ b/src/target/firmware/layer1/async.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/avg.c b/src/target/firmware/layer1/avg.c index a4bf565..7211c21 100644 --- a/src/target/firmware/layer1/avg.c +++ b/src/target/firmware/layer1/avg.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/init.c b/src/target/firmware/layer1/init.c index e7fde23..602e228 100644 --- a/src/target/firmware/layer1/init.c +++ b/src/target/firmware/layer1/init.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/target/firmware/layer1/l23_api.c b/src/target/firmware/layer1/l23_api.c index 4621bfc..735d92a 100644 --- a/src/target/firmware/layer1/l23_api.c +++ b/src/target/firmware/layer1/l23_api.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #define DEBUG diff --git a/src/target/firmware/layer1/mframe_sched.c b/src/target/firmware/layer1/mframe_sched.c index fac84b4..478fd20 100644 --- a/src/target/firmware/layer1/mframe_sched.c +++ b/src/target/firmware/layer1/mframe_sched.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_fbsb.c b/src/target/firmware/layer1/prim_fbsb.c index 8eaeb5a..4f4c4fd 100644 --- a/src/target/firmware/layer1/prim_fbsb.c +++ b/src/target/firmware/layer1/prim_fbsb.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_freq.c b/src/target/firmware/layer1/prim_freq.c index d5b5df1..a6ddc54 100644 --- a/src/target/firmware/layer1/prim_freq.c +++ b/src/target/firmware/layer1/prim_freq.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_pm.c b/src/target/firmware/layer1/prim_pm.c index 5c8c491..11bee99 100644 --- a/src/target/firmware/layer1/prim_pm.c +++ b/src/target/firmware/layer1/prim_pm.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_rach.c b/src/target/firmware/layer1/prim_rach.c index e6ea656..9536e5f 100644 --- a/src/target/firmware/layer1/prim_rach.c +++ b/src/target/firmware/layer1/prim_rach.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_rx_nb.c b/src/target/firmware/layer1/prim_rx_nb.c index c90c98c..9656cf9 100644 --- a/src/target/firmware/layer1/prim_rx_nb.c +++ b/src/target/firmware/layer1/prim_rx_nb.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_tch.c b/src/target/firmware/layer1/prim_tch.c index 40ef8f3..0542e82 100644 --- a/src/target/firmware/layer1/prim_tch.c +++ b/src/target/firmware/layer1/prim_tch.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_tx_nb.c b/src/target/firmware/layer1/prim_tx_nb.c index 86e8224..cf4ea44 100644 --- a/src/target/firmware/layer1/prim_tx_nb.c +++ b/src/target/firmware/layer1/prim_tx_nb.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/prim_utils.c b/src/target/firmware/layer1/prim_utils.c index 7beab5f..f19200e 100644 --- a/src/target/firmware/layer1/prim_utils.c +++ b/src/target/firmware/layer1/prim_utils.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/rfch.c b/src/target/firmware/layer1/rfch.c index 3c4e676..4c34416 100644 --- a/src/target/firmware/layer1/rfch.c +++ b/src/target/firmware/layer1/rfch.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/sched_gsmtime.c b/src/target/firmware/layer1/sched_gsmtime.c index 01e22ca..aec041e 100644 --- a/src/target/firmware/layer1/sched_gsmtime.c +++ b/src/target/firmware/layer1/sched_gsmtime.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/sync.c b/src/target/firmware/layer1/sync.c index 978546b..1b7eb32 100644 --- a/src/target/firmware/layer1/sync.c +++ b/src/target/firmware/layer1/sync.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/tdma_sched.c b/src/target/firmware/layer1/tdma_sched.c index 8812992..44b88b2 100644 --- a/src/target/firmware/layer1/tdma_sched.c +++ b/src/target/firmware/layer1/tdma_sched.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/toa.c b/src/target/firmware/layer1/toa.c index 7d80d95..4c9fff8 100644 --- a/src/target/firmware/layer1/toa.c +++ b/src/target/firmware/layer1/toa.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/layer1/tpu_window.c b/src/target/firmware/layer1/tpu_window.c index f4e76c1..7baa1d3 100644 --- a/src/target/firmware/layer1/tpu_window.c +++ b/src/target/firmware/layer1/tpu_window.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/lib/console.c b/src/target/firmware/lib/console.c index 6bc8fed..df2adab 100644 --- a/src/target/firmware/lib/console.c +++ b/src/target/firmware/lib/console.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/rf/mt6139.c b/src/target/firmware/rf/mt6139.c index d48e652..fab36ba 100644 --- a/src/target/firmware/rf/mt6139.c +++ b/src/target/firmware/rf/mt6139.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/rf/trf6151.c b/src/target/firmware/rf/trf6151.c index ec13928..5c995d6 100644 --- a/src/target/firmware/rf/trf6151.c +++ b/src/target/firmware/rf/trf6151.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/tiffs/init.c b/src/target/firmware/tiffs/init.c index 378f829..a6c38e3 100644 --- a/src/target/firmware/tiffs/init.c +++ b/src/target/firmware/tiffs/init.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/firmware/tiffs/readfile.c b/src/target/firmware/tiffs/readfile.c index c712c43..c93b106 100644 --- a/src/target/firmware/tiffs/readfile.c +++ b/src/target/firmware/tiffs/readfile.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/target/trx_toolkit/app_common.py b/src/target/trx_toolkit/app_common.py index 7f2f03c..531d8dc 100644 --- a/src/target/trx_toolkit/app_common.py +++ b/src/target/trx_toolkit/app_common.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log diff --git a/src/target/trx_toolkit/burst_fwd.py b/src/target/trx_toolkit/burst_fwd.py index 2e9e97b..f5a6d78 100644 --- a/src/target/trx_toolkit/burst_fwd.py +++ b/src/target/trx_toolkit/burst_fwd.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log diff --git a/src/target/trx_toolkit/burst_gen.py b/src/target/trx_toolkit/burst_gen.py index f93d868..22f7205 100755 --- a/src/target/trx_toolkit/burst_gen.py +++ b/src/target/trx_toolkit/burst_gen.py @@ -18,10 +18,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. APP_CR_HOLDERS = [("2017-2019", "Vadim Yanitskiy ")] diff --git a/src/target/trx_toolkit/burst_send.py b/src/target/trx_toolkit/burst_send.py index 4e16571..27f585e 100755 --- a/src/target/trx_toolkit/burst_send.py +++ b/src/target/trx_toolkit/burst_send.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. APP_CR_HOLDERS = [("2017-2018", "Vadim Yanitskiy ")] diff --git a/src/target/trx_toolkit/clck_gen.py b/src/target/trx_toolkit/clck_gen.py index 51f04a8..427eb88 100755 --- a/src/target/trx_toolkit/clck_gen.py +++ b/src/target/trx_toolkit/clck_gen.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. APP_CR_HOLDERS = [("2017-2019", "Vadim Yanitskiy ")] diff --git a/src/target/trx_toolkit/codec.py b/src/target/trx_toolkit/codec.py index 9387592..c570600 100644 --- a/src/target/trx_toolkit/codec.py +++ b/src/target/trx_toolkit/codec.py @@ -21,10 +21,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. from typing import Optional, Callable, Tuple, Any import abc diff --git a/src/target/trx_toolkit/ctrl_cmd.py b/src/target/trx_toolkit/ctrl_cmd.py index 7a2bfac..c6ac6d8 100755 --- a/src/target/trx_toolkit/ctrl_cmd.py +++ b/src/target/trx_toolkit/ctrl_cmd.py @@ -18,10 +18,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. APP_CR_HOLDERS = [("2017-2018", "Vadim Yanitskiy ")] diff --git a/src/target/trx_toolkit/ctrl_if.py b/src/target/trx_toolkit/ctrl_if.py index aaf1111..f9d30c1 100644 --- a/src/target/trx_toolkit/ctrl_if.py +++ b/src/target/trx_toolkit/ctrl_if.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log import time diff --git a/src/target/trx_toolkit/ctrl_if_trx.py b/src/target/trx_toolkit/ctrl_if_trx.py index c03dcc6..46a55c5 100644 --- a/src/target/trx_toolkit/ctrl_if_trx.py +++ b/src/target/trx_toolkit/ctrl_if_trx.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log diff --git a/src/target/trx_toolkit/data_dump.py b/src/target/trx_toolkit/data_dump.py index 8510e2d..8475ceb 100644 --- a/src/target/trx_toolkit/data_dump.py +++ b/src/target/trx_toolkit/data_dump.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log import struct diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py index 1cded9b..8e80894 100644 --- a/src/target/trx_toolkit/data_if.py +++ b/src/target/trx_toolkit/data_if.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py index 72e248d..898a4ae 100644 --- a/src/target/trx_toolkit/data_msg.py +++ b/src/target/trx_toolkit/data_msg.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import random import struct diff --git a/src/target/trx_toolkit/fake_pm.py b/src/target/trx_toolkit/fake_pm.py index 9331212..205596a 100644 --- a/src/target/trx_toolkit/fake_pm.py +++ b/src/target/trx_toolkit/fake_pm.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. from random import randint diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index 93ae64e..a8ad9df 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. APP_CR_HOLDERS = [("2017-2019", "Vadim Yanitskiy ")] diff --git a/src/target/trx_toolkit/gsm_shared.py b/src/target/trx_toolkit/gsm_shared.py index 7c50245..5f59ba6 100644 --- a/src/target/trx_toolkit/gsm_shared.py +++ b/src/target/trx_toolkit/gsm_shared.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. from enum import Enum diff --git a/src/target/trx_toolkit/rand_burst_gen.py b/src/target/trx_toolkit/rand_burst_gen.py index b9846ab..c474c75 100644 --- a/src/target/trx_toolkit/rand_burst_gen.py +++ b/src/target/trx_toolkit/rand_burst_gen.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import random diff --git a/src/target/trx_toolkit/test_codec.py b/src/target/trx_toolkit/test_codec.py index ca2f773..5049f52 100644 --- a/src/target/trx_toolkit/test_codec.py +++ b/src/target/trx_toolkit/test_codec.py @@ -19,10 +19,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import unittest import struct diff --git a/src/target/trx_toolkit/test_data_dump.py b/src/target/trx_toolkit/test_data_dump.py index f7b4fde..67ff32b 100644 --- a/src/target/trx_toolkit/test_data_dump.py +++ b/src/target/trx_toolkit/test_data_dump.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import unittest import tempfile diff --git a/src/target/trx_toolkit/test_data_msg.py b/src/target/trx_toolkit/test_data_msg.py index 24fda67..ec6c2ec 100644 --- a/src/target/trx_toolkit/test_data_msg.py +++ b/src/target/trx_toolkit/test_data_msg.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import unittest diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py index b48dffb..3390907 100644 --- a/src/target/trx_toolkit/transceiver.py +++ b/src/target/trx_toolkit/transceiver.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import logging as log diff --git a/src/target/trx_toolkit/trx_list.py b/src/target/trx_toolkit/trx_list.py index 0a55cc6..c476a7d 100644 --- a/src/target/trx_toolkit/trx_list.py +++ b/src/target/trx_toolkit/trx_list.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. class TRXList: """ Transceiver list implementation. diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py index 8b6f80c..c91e3e0 100755 --- a/src/target/trx_toolkit/trx_sniff.py +++ b/src/target/trx_toolkit/trx_sniff.py @@ -17,10 +17,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. APP_CR_HOLDERS = [("2018-2020", "Vadim Yanitskiy ")] diff --git a/src/target/trx_toolkit/trxd_proto.py b/src/target/trx_toolkit/trxd_proto.py index 21fe31e..a1bf1b5 100644 --- a/src/target/trx_toolkit/trxd_proto.py +++ b/src/target/trx_toolkit/trxd_proto.py @@ -20,10 +20,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import codec diff --git a/src/target/trx_toolkit/udp_link.py b/src/target/trx_toolkit/udp_link.py index 43a4815..c3f1476 100644 --- a/src/target/trx_toolkit/udp_link.py +++ b/src/target/trx_toolkit/udp_link.py @@ -16,10 +16,6 @@ # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. import socket -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/26566 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I73be012c01c0108fb6951dbff91d50eb19b40c51 Gerrit-Change-Number: 26566 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: BastusIII Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: steve-m Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:52:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:52:11 +0000 Subject: Change in osmo-bts[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26552 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26552 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I12b250e16426b125124def49e124e40ae93d0d58 Gerrit-Change-Number: 26552 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:52:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:52:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:52:18 +0000 Subject: Change in osmo-bts[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26552 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I12b250e16426b125124def49e124e40ae93d0d58 --- M src/common/pcu_sock.c 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 0018acb..94b45f3 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26552 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I12b250e16426b125124def49e124e40ae93d0d58 Gerrit-Change-Number: 26552 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:52:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:52:27 +0000 Subject: Change in osmo-smlc[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26561 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26561 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ieb4f9b4ad5073c9b5996cb960b248c450fd5f2dd Gerrit-Change-Number: 26561 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:52:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:52:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:52:29 +0000 Subject: Change in osmo-smlc[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26561 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: Ieb4f9b4ad5073c9b5996cb960b248c450fd5f2dd --- M include/osmocom/smlc/cell_locations.h M include/osmocom/smlc/smlc_loc_req.h M src/osmo-smlc/cell_locations.c M src/osmo-smlc/smlc_loc_req.c 4 files changed, 0 insertions(+), 16 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/smlc/cell_locations.h b/include/osmocom/smlc/cell_locations.h index 33023bb..9712718 100644 --- a/include/osmocom/smlc/cell_locations.h +++ b/include/osmocom/smlc/cell_locations.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/smlc/smlc_loc_req.h b/include/osmocom/smlc/smlc_loc_req.h index a8aa27e..7cd5711 100644 --- a/include/osmocom/smlc/smlc_loc_req.h +++ b/include/osmocom/smlc/smlc_loc_req.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/src/osmo-smlc/cell_locations.c b/src/osmo-smlc/cell_locations.c index e563720..273b83f 100644 --- a/src/osmo-smlc/cell_locations.c +++ b/src/osmo-smlc/cell_locations.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/osmo-smlc/smlc_loc_req.c b/src/osmo-smlc/smlc_loc_req.c index 392e247..cfd8521 100644 --- a/src/osmo-smlc/smlc_loc_req.c +++ b/src/osmo-smlc/smlc_loc_req.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26561 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ieb4f9b4ad5073c9b5996cb960b248c450fd5f2dd Gerrit-Change-Number: 26561 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:52:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:52:33 +0000 Subject: Change in osmo-iuh[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26554 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I340ab63093138ada6e80edf322e401e9fbfef4ed Gerrit-Change-Number: 26554 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:52:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:52:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:52:41 +0000 Subject: Change in osmo-iuh[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26554 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I340ab63093138ada6e80edf322e401e9fbfef4ed --- M asn1/rua/eurecom/rua_decoder.c M asn1/rua/eurecom/rua_encoder.c M asn1/rua/eurecom/rua_ies_defs.h 3 files changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/asn1/rua/eurecom/rua_decoder.c b/asn1/rua/eurecom/rua_decoder.c index 521ecab..aebf8d5 100644 --- a/asn1/rua/eurecom/rua_decoder.c +++ b/asn1/rua/eurecom/rua_decoder.c @@ -12,10 +12,6 @@ FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License along with - this program; if not, write to the Free Software Foundation, Inc., - 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. - The full GNU General Public License is included in this distribution in the file called "COPYING". diff --git a/asn1/rua/eurecom/rua_encoder.c b/asn1/rua/eurecom/rua_encoder.c index 56d0f33..4fc75b7 100644 --- a/asn1/rua/eurecom/rua_encoder.c +++ b/asn1/rua/eurecom/rua_encoder.c @@ -12,10 +12,6 @@ FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License along with - this program; if not, write to the Free Software Foundation, Inc., - 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. - The full GNU General Public License is included in this distribution in the file called "COPYING". diff --git a/asn1/rua/eurecom/rua_ies_defs.h b/asn1/rua/eurecom/rua_ies_defs.h index da5fc6f..74602ff 100644 --- a/asn1/rua/eurecom/rua_ies_defs.h +++ b/asn1/rua/eurecom/rua_ies_defs.h @@ -12,10 +12,6 @@ FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License along with - this program; if not, write to the Free Software Foundation, Inc., - 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. - The full GNU General Public License is included in this distribution in the file called "COPYING". -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I340ab63093138ada6e80edf322e401e9fbfef4ed Gerrit-Change-Number: 26554 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:52:53 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:52:53 +0000 Subject: Change in osmo-msc[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26556 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1b68e0aa26d81fbfe26abaa287d2bd5eec2cfd0f Gerrit-Change-Number: 26556 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:52:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:53:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:53:00 +0000 Subject: Change in osmo-msc[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26556 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I1b68e0aa26d81fbfe26abaa287d2bd5eec2cfd0f --- M include/osmocom/msc/cell_id_list.h M src/libmsc/call_leg.c M src/libmsc/cell_id_list.c M src/libmsc/gsup_client_mux.c M src/libmsc/mncc_builtin.c M src/libmsc/mncc_sock.c M src/libmsc/msc_ho.c M src/libmsc/ran_msg.c M src/libmsc/ran_msg_a.c M src/libmsc/ran_msg_iu.c 10 files changed, 0 insertions(+), 40 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/msc/cell_id_list.h b/include/osmocom/msc/cell_id_list.h index 83d05f5..c6a7cbb 100644 --- a/include/osmocom/msc/cell_id_list.h +++ b/include/osmocom/msc/cell_id_list.h @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/src/libmsc/call_leg.c b/src/libmsc/call_leg.c index 056a392..6242a80 100644 --- a/src/libmsc/call_leg.c +++ b/src/libmsc/call_leg.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include #include diff --git a/src/libmsc/cell_id_list.c b/src/libmsc/cell_id_list.c index ca7a6d4..580b4f4 100644 --- a/src/libmsc/cell_id_list.c +++ b/src/libmsc/cell_id_list.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/libmsc/gsup_client_mux.c b/src/libmsc/gsup_client_mux.c index e425651..3d88349 100644 --- a/src/libmsc/gsup_client_mux.c +++ b/src/libmsc/gsup_client_mux.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/libmsc/mncc_builtin.c b/src/libmsc/mncc_builtin.c index cc3f55d..a711e07 100644 --- a/src/libmsc/mncc_builtin.c +++ b/src/libmsc/mncc_builtin.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/libmsc/mncc_sock.c b/src/libmsc/mncc_sock.c index b76855f..7c65546 100644 --- a/src/libmsc/mncc_sock.c +++ b/src/libmsc/mncc_sock.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c index 6b8960e..7e7905b 100644 --- a/src/libmsc/msc_ho.c +++ b/src/libmsc/msc_ho.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/libmsc/ran_msg.c b/src/libmsc/ran_msg.c index 46816a9..e050303 100644 --- a/src/libmsc/ran_msg.c +++ b/src/libmsc/ran_msg.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c index b50259d..be026e5 100644 --- a/src/libmsc/ran_msg_a.c +++ b/src/libmsc/ran_msg_a.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/libmsc/ran_msg_iu.c b/src/libmsc/ran_msg_iu.c index b894df2..c10df4d 100644 --- a/src/libmsc/ran_msg_iu.c +++ b/src/libmsc/ran_msg_iu.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1b68e0aa26d81fbfe26abaa287d2bd5eec2cfd0f Gerrit-Change-Number: 26556 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:53:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:53:14 +0000 Subject: Change in osmo-pcu[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26557 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26557 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4a49dbeeec89b22624c968152118aecf8886dac6 Gerrit-Change-Number: 26557 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Ivan Kluchnikov Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:53:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:53:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:53:16 +0000 Subject: Change in osmo-pcu[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26557 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I4a49dbeeec89b22624c968152118aecf8886dac6 --- M src/bts.h M src/coding_scheme.c M src/coding_scheme.h M src/csn1.c M src/csn1.h M src/csn1_dec.c M src/csn1_enc.c M src/cxx_linuxlist.h M src/decoding.cpp M src/decoding.h M src/encoding.cpp M src/encoding.h M src/gprs_bssgp_pcu.c M src/gprs_bssgp_pcu.h M src/gprs_bssgp_rim.c M src/gprs_bssgp_rim.h M src/gprs_codel.c M src/gprs_codel.h M src/gprs_debug.cpp M src/gprs_debug.h M src/gprs_ms.c M src/gprs_ms.h M src/gprs_ms_storage.cpp M src/gprs_ms_storage.h M src/gprs_rlcmac.cpp M src/gprs_rlcmac.h M src/gprs_rlcmac_meas.cpp M src/gprs_rlcmac_sched.cpp M src/gprs_rlcmac_ts_alloc.cpp M src/gsm_rlcmac.c M src/gsm_rlcmac.h M src/llc.cpp M src/llc.h M src/mslot_class.c M src/mslot_class.h M src/nacc_fsm.c M src/nacc_fsm.h M src/neigh_cache.c M src/neigh_cache.h M src/osmobts_sock.c M src/pcu_l1_if.cpp M src/pcu_l1_if.h M src/pcu_main.cpp M src/pcu_utils.h M src/pcu_vty_functions.cpp M src/pcu_vty_functions.h M src/pdch.h M src/pdch_ul_controller.c M src/pdch_ul_controller.h M src/rlc.cpp M src/rlc.h M src/sba.c M src/sba.h M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_dl.h M src/tbf_dl_ass_fsm.c M src/tbf_dl_ass_fsm.h M src/tbf_fsm.c M src/tbf_fsm.h M src/tbf_ul.cpp M src/tbf_ul.h M src/tbf_ul_ack_fsm.c M src/tbf_ul_ack_fsm.h M src/tbf_ul_ass_fsm.c M src/tbf_ul_ass_fsm.h M src/wireshark_compat.h M tests/alloc/AllocTest.cpp M tests/alloc/MslotTest.cpp M tests/app_info/AppInfoTest.cpp M tests/rlcmac/RLCMACTest.cpp 72 files changed, 0 insertions(+), 288 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/bts.h b/src/bts.h index 6bf62c7..d2b1f9f 100644 --- a/src/bts.h +++ b/src/bts.h @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/coding_scheme.c b/src/coding_scheme.c index 27241d1..c370c4b 100644 --- a/src/coding_scheme.c +++ b/src/coding_scheme.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/coding_scheme.h b/src/coding_scheme.h index 1b21265..fdecf1c 100644 --- a/src/coding_scheme.h +++ b/src/coding_scheme.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/csn1.c b/src/csn1.c index e165e92..a9b1343 100644 --- a/src/csn1.c +++ b/src/csn1.c @@ -22,10 +22,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/csn1.h b/src/csn1.h index 285ae99..47956c3 100644 --- a/src/csn1.h +++ b/src/csn1.h @@ -19,10 +19,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #ifndef _PACKET_CSN1_H_ diff --git a/src/csn1_dec.c b/src/csn1_dec.c index 6892dde..f0d07ac 100644 --- a/src/csn1_dec.c +++ b/src/csn1_dec.c @@ -22,10 +22,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/csn1_enc.c b/src/csn1_enc.c index 5518d06..e4e5e09 100644 --- a/src/csn1_enc.c +++ b/src/csn1_enc.c @@ -22,10 +22,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/cxx_linuxlist.h b/src/cxx_linuxlist.h index 9a74b3f..1562bfe 100644 --- a/src/cxx_linuxlist.h +++ b/src/cxx_linuxlist.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/decoding.cpp b/src/decoding.cpp index 0caa8bf..ca0c720 100644 --- a/src/decoding.cpp +++ b/src/decoding.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include #include diff --git a/src/decoding.h b/src/decoding.h index 7270c3d..b0a5aed 100644 --- a/src/decoding.h +++ b/src/decoding.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/encoding.cpp b/src/encoding.cpp index 30b0ee1..4737137 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/encoding.h b/src/encoding.h index 998e69a..fd2225e 100644 --- a/src/encoding.h +++ b/src/encoding.h @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c index 8cb5302..bf82fc4 100644 --- a/src/gprs_bssgp_pcu.c +++ b/src/gprs_bssgp_pcu.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/gprs_bssgp_pcu.h b/src/gprs_bssgp_pcu.h index 907e666..0c0f091 100644 --- a/src/gprs_bssgp_pcu.h +++ b/src/gprs_bssgp_pcu.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #ifndef GPRS_BSSGP_PCU_H diff --git a/src/gprs_bssgp_rim.c b/src/gprs_bssgp_rim.c index f1679a6..033426b 100644 --- a/src/gprs_bssgp_rim.c +++ b/src/gprs_bssgp_rim.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/gprs_bssgp_rim.h b/src/gprs_bssgp_rim.h index 5fac56f..cf46b0e 100644 --- a/src/gprs_bssgp_rim.h +++ b/src/gprs_bssgp_rim.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/gprs_codel.c b/src/gprs_codel.c index 7c3b2d4..9c5737f 100644 --- a/src/gprs_codel.c +++ b/src/gprs_codel.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include "gprs_codel.h" diff --git a/src/gprs_codel.h b/src/gprs_codel.h index 3ad7efc..10ba91f 100644 --- a/src/gprs_codel.h +++ b/src/gprs_codel.h @@ -19,10 +19,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/gprs_debug.cpp b/src/gprs_debug.cpp index 0cbc488..61c1c87 100644 --- a/src/gprs_debug.cpp +++ b/src/gprs_debug.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ extern "C" { diff --git a/src/gprs_debug.h b/src/gprs_debug.h index cebeabc..b683a63 100644 --- a/src/gprs_debug.h +++ b/src/gprs_debug.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 5e75d06..c10eda7 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ diff --git a/src/gprs_ms.h b/src/gprs_ms.h index c579cf5..3ebf7a5 100644 --- a/src/gprs_ms.h +++ b/src/gprs_ms.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/gprs_ms_storage.cpp b/src/gprs_ms_storage.cpp index db3a7f9..aa0fc9e 100644 --- a/src/gprs_ms_storage.cpp +++ b/src/gprs_ms_storage.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ diff --git a/src/gprs_ms_storage.h b/src/gprs_ms_storage.h index dcb6d8d..ef808d0 100644 --- a/src/gprs_ms_storage.h +++ b/src/gprs_ms_storage.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/gprs_rlcmac.cpp b/src/gprs_rlcmac.cpp index ffa656c..1ea0872 100644 --- a/src/gprs_rlcmac.cpp +++ b/src/gprs_rlcmac.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ extern "C" { diff --git a/src/gprs_rlcmac.h b/src/gprs_rlcmac.h index cf95c37..468712e 100644 --- a/src/gprs_rlcmac.h +++ b/src/gprs_rlcmac.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #ifndef GPRS_RLCMAC_H diff --git a/src/gprs_rlcmac_meas.cpp b/src/gprs_rlcmac_meas.cpp index b9a324f..d14f405 100644 --- a/src/gprs_rlcmac_meas.cpp +++ b/src/gprs_rlcmac_meas.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ extern "C" { diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp index 8867d43..8b5227f 100644 --- a/src/gprs_rlcmac_sched.cpp +++ b/src/gprs_rlcmac_sched.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp index a243d21..3a60839 100644 --- a/src/gprs_rlcmac_ts_alloc.cpp +++ b/src/gprs_rlcmac_ts_alloc.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/gsm_rlcmac.c b/src/gsm_rlcmac.c index 6793602..570c97b 100644 --- a/src/gsm_rlcmac.c +++ b/src/gsm_rlcmac.c @@ -23,10 +23,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/gsm_rlcmac.h b/src/gsm_rlcmac.h index 01e2ee6..c43d418 100644 --- a/src/gsm_rlcmac.h +++ b/src/gsm_rlcmac.h @@ -23,10 +23,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #ifndef __PACKET_GSM_RLCMAC_H__ diff --git a/src/llc.cpp b/src/llc.cpp index e508d0b..b118307 100644 --- a/src/llc.cpp +++ b/src/llc.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/llc.h b/src/llc.h index 13662d8..623ae49 100644 --- a/src/llc.h +++ b/src/llc.h @@ -10,10 +10,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/mslot_class.c b/src/mslot_class.c index ff40f29..1809cd7 100644 --- a/src/mslot_class.c +++ b/src/mslot_class.c @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/mslot_class.h b/src/mslot_class.h index 045fb31..7a6d5d4 100644 --- a/src/mslot_class.h +++ b/src/mslot_class.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/nacc_fsm.c b/src/nacc_fsm.c index ba7bbb7..c049f60 100644 --- a/src/nacc_fsm.c +++ b/src/nacc_fsm.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/nacc_fsm.h b/src/nacc_fsm.h index beea0f7..b33dafa 100644 --- a/src/nacc_fsm.h +++ b/src/nacc_fsm.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/neigh_cache.c b/src/neigh_cache.c index 3217f40..2f82fee 100644 --- a/src/neigh_cache.c +++ b/src/neigh_cache.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/neigh_cache.h b/src/neigh_cache.h index 90260cd..76706ab 100644 --- a/src/neigh_cache.h +++ b/src/neigh_cache.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/osmobts_sock.c b/src/osmobts_sock.c index 91b62a0..1cbd1a0 100644 --- a/src/osmobts_sock.c +++ b/src/osmobts_sock.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 8d9defc..d5672e5 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/pcu_l1_if.h b/src/pcu_l1_if.h index 7d48feb..1b13a92 100644 --- a/src/pcu_l1_if.h +++ b/src/pcu_l1_if.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #ifndef PCU_L1_IF_H diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp index fe391b9..0fb5ac8 100644 --- a/src/pcu_main.cpp +++ b/src/pcu_main.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/pcu_utils.h b/src/pcu_utils.h index e1a8572..1c698ca 100644 --- a/src/pcu_utils.h +++ b/src/pcu_utils.h @@ -10,10 +10,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once #ifdef __cplusplus diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp index c2cc950..1745eea 100644 --- a/src/pcu_vty_functions.cpp +++ b/src/pcu_vty_functions.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ /* OsmoBTS VTY interface */ diff --git a/src/pcu_vty_functions.h b/src/pcu_vty_functions.h index a68df27..172dffc 100644 --- a/src/pcu_vty_functions.h +++ b/src/pcu_vty_functions.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/pdch.h b/src/pdch.h index 759d7f9..cf4ac4e 100644 --- a/src/pdch.h +++ b/src/pdch.h @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/pdch_ul_controller.c b/src/pdch_ul_controller.c index 79a0339..7fbbc51 100644 --- a/src/pdch_ul_controller.c +++ b/src/pdch_ul_controller.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with it program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/pdch_ul_controller.h b/src/pdch_ul_controller.h index c56945f..0e66720 100644 --- a/src/pdch_ul_controller.h +++ b/src/pdch_ul_controller.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/rlc.cpp b/src/rlc.cpp index a2cc52c..a082597 100644 --- a/src/rlc.cpp +++ b/src/rlc.cpp @@ -10,10 +10,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include "bts.h" diff --git a/src/rlc.h b/src/rlc.h index 45cbb95..73a537f 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once #ifdef __cplusplus diff --git a/src/sba.c b/src/sba.c index d293784..94c3c56 100644 --- a/src/sba.c +++ b/src/sba.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/sba.h b/src/sba.h index 3962576..749b145 100644 --- a/src/sba.h +++ b/src/sba.h @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf.cpp b/src/tbf.cpp index 0b02623..c2eeb89 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf.h b/src/tbf.h index 9ce1813..31bbe5f 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -10,10 +10,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 6e898da..ec455c1 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf_dl.h b/src/tbf_dl.h index d20ad75..c0c0284 100644 --- a/src/tbf_dl.h +++ b/src/tbf_dl.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index a5948e7..9ea216c 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf_dl_ass_fsm.h b/src/tbf_dl_ass_fsm.h index 94c9062..a259c03 100644 --- a/src/tbf_dl_ass_fsm.h +++ b/src/tbf_dl_ass_fsm.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf_fsm.c b/src/tbf_fsm.c index 39f2080..2189747 100644 --- a/src/tbf_fsm.c +++ b/src/tbf_fsm.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf_fsm.h b/src/tbf_fsm.h index 614c319..9814c0e 100644 --- a/src/tbf_fsm.h +++ b/src/tbf_fsm.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index 0282122..305daaa 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf_ul.h b/src/tbf_ul.h index 0dc2336..62b9456 100644 --- a/src/tbf_ul.h +++ b/src/tbf_ul.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf_ul_ack_fsm.c b/src/tbf_ul_ack_fsm.c index 32e3533..364ef00 100644 --- a/src/tbf_ul_ack_fsm.c +++ b/src/tbf_ul_ack_fsm.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf_ul_ack_fsm.h b/src/tbf_ul_ack_fsm.h index aaee5a3..d2e9332 100644 --- a/src/tbf_ul_ack_fsm.h +++ b/src/tbf_ul_ack_fsm.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/tbf_ul_ass_fsm.c b/src/tbf_ul_ass_fsm.c index 90fe828..b443e4f 100644 --- a/src/tbf_ul_ass_fsm.c +++ b/src/tbf_ul_ass_fsm.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/src/tbf_ul_ass_fsm.h b/src/tbf_ul_ass_fsm.h index 34b81a7..8a612f2 100644 --- a/src/tbf_ul_ass_fsm.h +++ b/src/tbf_ul_ass_fsm.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #pragma once diff --git a/src/wireshark_compat.h b/src/wireshark_compat.h index 13b165a..2840124 100644 --- a/src/wireshark_compat.h +++ b/src/wireshark_compat.h @@ -10,10 +10,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ /* This header contains a few definitions required by rlcmac and csn1 files diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp index 6f3de43..b5d4b95 100644 --- a/tests/alloc/AllocTest.cpp +++ b/tests/alloc/AllocTest.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include "gprs_rlcmac.h" diff --git a/tests/alloc/MslotTest.cpp b/tests/alloc/MslotTest.cpp index 96fe61b..1b06b0b 100644 --- a/tests/alloc/MslotTest.cpp +++ b/tests/alloc/MslotTest.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include "gprs_rlcmac.h" diff --git a/tests/app_info/AppInfoTest.cpp b/tests/app_info/AppInfoTest.cpp index d3a047e..9530d09 100644 --- a/tests/app_info/AppInfoTest.cpp +++ b/tests/app_info/AppInfoTest.cpp @@ -9,10 +9,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #include diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp index 88847de..30476c5 100644 --- a/tests/rlcmac/RLCMACTest.cpp +++ b/tests/rlcmac/RLCMACTest.cpp @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26557 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4a49dbeeec89b22624c968152118aecf8886dac6 Gerrit-Change-Number: 26557 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Ivan Kluchnikov Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:53:21 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:53:21 +0000 Subject: Change in osmo-sgsn[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26560 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9bc57a7152015e0f37e3d1573921d6d5d3c0449b Gerrit-Change-Number: 26560 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:53:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:53:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:53:29 +0000 Subject: Change in osmo-sgsn[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26560 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I9bc57a7152015e0f37e3d1573921d6d5d3c0449b --- M include/osmocom/sgsn/v42bis.h M include/osmocom/sgsn/v42bis_private.h M src/sgsn/v42bis.c 3 files changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/sgsn/v42bis.h b/include/osmocom/sgsn/v42bis.h index b64c43e..d782981 100644 --- a/include/osmocom/sgsn/v42bis.h +++ b/include/osmocom/sgsn/v42bis.h @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \page v42bis_page V.42bis modem data compression diff --git a/include/osmocom/sgsn/v42bis_private.h b/include/osmocom/sgsn/v42bis_private.h index c6b675a..cc7e634 100644 --- a/include/osmocom/sgsn/v42bis_private.h +++ b/include/osmocom/sgsn/v42bis_private.h @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #if !defined(_SPANDSP_PRIVATE_V42BIS_H_) diff --git a/src/sgsn/v42bis.c b/src/sgsn/v42bis.c index 0759cdf..ddca5f8 100644 --- a/src/sgsn/v42bis.c +++ b/src/sgsn/v42bis.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /* THIS IS A WORK IN PROGRESS. IT IS NOT FINISHED. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9bc57a7152015e0f37e3d1573921d6d5d3c0449b Gerrit-Change-Number: 26560 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:53:48 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:53:48 +0000 Subject: Change in libosmocore[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26550 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26550 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5050285e75cf120407a1d883e99b3c4bcae8ffd7 Gerrit-Change-Number: 26550 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Tue, 14 Dec 2021 12:53:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:53:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:53:51 +0000 Subject: Change in libosmocore[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26550 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I5050285e75cf120407a1d883e99b3c4bcae8ffd7 --- M include/osmocom/core/base64.h M include/osmocom/core/bitXXgen.h.tpl M include/osmocom/core/bitcomp.h M include/osmocom/core/bitvec.h M include/osmocom/core/conv.h M include/osmocom/core/crcXXgen.h.tpl M include/osmocom/core/crcgen.h M include/osmocom/core/exec.h M include/osmocom/core/isdnhdlc.h M include/osmocom/core/linuxrbtree.h M include/osmocom/core/loggingrb.h M include/osmocom/core/msgb.h M include/osmocom/core/msgfile.h M include/osmocom/core/serial.h M include/osmocom/core/sockaddr_str.h M include/osmocom/core/stats.h M include/osmocom/core/strrb.h M include/osmocom/core/thread.h M include/osmocom/core/timer.h M include/osmocom/core/timer_compat.h M include/osmocom/core/use_count.h M include/osmocom/core/write_queue.h M include/osmocom/gsm/a5.h M include/osmocom/gsm/bsslap.h M include/osmocom/gsm/bssmap_le.h M include/osmocom/gsm/cbsp.h M include/osmocom/gsm/gsm0808.h M include/osmocom/gsm/gsm0808_lcs.h M include/osmocom/gsm/gsm29118.h M include/osmocom/gsm/gsm29205.h M include/osmocom/gsm/gsm_utils.h M include/osmocom/gsm/i460_mux.h M include/osmocom/gsm/protocol/gsm_08_58.h M include/osmocom/gsm/protocol/gsm_12_21.h M include/osmocom/gsm/protocol/gsm_48_071.h M include/osmocom/gsm/protocol/gsm_49_031.h M include/osmocom/sim/class_tables.h M include/osmocom/usb/libusb.h M include/osmocom/vty/telnet_interface.h M include/osmocom/vty/vector.h M src/application.c M src/backtrace.c M src/base64.c M src/bitcomp.c M src/bits.c M src/bitvec.c M src/codec/ecu.c M src/codec/ecu_fr.c M src/codec/gsm610.c M src/codec/gsm620.c M src/codec/gsm660.c M src/codec/gsm690.c M src/coding/gsm0503_coding.c M src/coding/gsm0503_interleaving.c M src/coding/gsm0503_mapping.c M src/coding/gsm0503_parity.c M src/coding/gsm0503_tables.c M src/context.c M src/conv.c M src/conv_acc.c M src/conv_acc_generic.c M src/conv_acc_neon.c M src/conv_acc_neon_impl.h M src/conv_acc_sse.c M src/conv_acc_sse_avx.c M src/conv_acc_sse_impl.h M src/counter.c M src/crcXXgen.c.tpl M src/ctrl/control_cmd.c M src/ctrl/control_if.c M src/ctrl/control_vty.c M src/exec.c M src/fsm.c M src/gsm/a5.c M src/gsm/auth_comp128v1.c M src/gsm/auth_comp128v23.c M src/gsm/auth_core.c M src/gsm/auth_milenage.c M src/gsm/auth_xor.c M src/gsm/bsslap.c M src/gsm/bssmap_le.c M src/gsm/bts_features.c M src/gsm/cbsp.c M src/gsm/comp128.c M src/gsm/comp128v23.c M src/gsm/gea.c M src/gsm/gprs_cipher_core.c M src/gsm/gprs_gea.c M src/gsm/gsm0341.c M src/gsm/gsm0480.c M src/gsm/gsm0808.c M src/gsm/gsm23003.c M src/gsm/gsm23236.c M src/gsm/gsm29118.c M src/gsm/gsm29205.c M src/gsm/gsm48.c M src/gsm/gsm48_ie.c M src/gsm/gsm_utils.c M src/gsm/i460_mux.c M src/gsm/kasumi.c M src/gsm/kdf.c M src/gsm/lapd_core.c M src/gsm/lapdm.c M src/gsm/rsl.c M src/gsm/rxlev_stat.c M src/gsmtap_util.c M src/isdnhdlc.c M src/it_q.c M src/logging.c M src/logging_gsmtap.c M src/logging_syslog.c M src/logging_systemd.c M src/loggingrb.c M src/macaddr.c M src/mnl.c M src/msgb.c M src/msgfile.c M src/panic.c M src/plugin.c M src/rate_ctr.c M src/rbtree.c M src/select.c M src/sercomm.c M src/serial.c M src/signal.c M src/sim/card_fs_hpsim.c M src/sim/card_fs_isim.c M src/sim/card_fs_sim.c M src/sim/card_fs_tetra.c M src/sim/card_fs_uicc.c M src/sim/card_fs_usim.c M src/sim/class_tables.c M src/sim/core.c M src/sim/reader.c M src/sim/reader_pcsc.c M src/sockaddr_str.c M src/socket.c M src/stat_item.c M src/stats.c M src/stats_statsd.c M src/strrb.c M src/thread.c M src/timer.c M src/timer_clockgettime.c M src/timer_gettimeofday.c M src/usb/osmo_libusb.c M src/use_count.c M src/utils.c M src/vty/fsm_vty.c M src/vty/logging_vty.c M src/vty/stats_vty.c M src/vty/talloc_ctx_vty.c M src/vty/telnet_interface.c M src/vty/utils.c M src/vty/vector.c M src/write_queue.c M tests/abis/abis_test.c M tests/coding/coding_test.c M tests/dtx/dtx_gsm0503_test.c M tests/fr/fr_test.c M tests/gsm0408/gsm0408_test.c M tests/gsm0502/gsm0502_test.c M tests/gsm0808/gsm0808_test.c M tests/gsm23003/gsm23003_test.c M tests/gsm23236/gsm23236_test.c M tests/gsm29205/gsm29205_test.c M tests/gsm48/rest_octets_test.c M tests/lapd/lapd_test.c M tests/logging/logging_test.c M tests/logging/logging_vty_test.c M tests/loggingrb/loggingrb_test.c M tests/msgb/msgb_test.c M tests/msgfile/msgfile_test.c M tests/oap/oap_test.c M tests/sercomm/sercomm_test.c M tests/sim/sim_test.c M tests/sms/sms_test.c M tests/smscb/gsm0341_test.c M tests/smscb/smscb_test.c M tests/sockaddr_str/sockaddr_str_test.c M tests/socket/socket_sctp_test.c M tests/socket/socket_test.c M tests/stats/stats_test.c M tests/strrb/strrb_test.c M tests/tdef/tdef_test.c M tests/tdef/tdef_vty_config_root_test.c M tests/tdef/tdef_vty_config_subnode_test.c M tests/tdef/tdef_vty_dynamic_test.c M tests/timer/clk_override_test.c M tests/timer/timer_test.c M tests/use_count/use_count_test.c M tests/use_count/use_count_test.err M tests/ussd/ussd_test.c M tests/utils/utils_test.c M tests/vty/vty_test.c M tests/vty/vty_transcript_test.c M utils/conv_gen.py M utils/osmo-arfcn.c M utils/osmo-auc-gen.c M utils/osmo-config-merge.c M utils/osmo-sim-test.c 201 files changed, 5 insertions(+), 817 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/core/base64.h b/include/osmocom/core/base64.h index 86b862e..a6c9720 100644 --- a/include/osmocom/core/base64.h +++ b/include/osmocom/core/base64.h @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/include/osmocom/core/bitXXgen.h.tpl b/include/osmocom/core/bitXXgen.h.tpl index 258fccb..ab54ba9 100644 --- a/include/osmocom/core/bitXXgen.h.tpl +++ b/include/osmocom/core/bitXXgen.h.tpl @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/include/osmocom/core/bitcomp.h b/include/osmocom/core/bitcomp.h index 5faa5ea..2167957 100644 --- a/include/osmocom/core/bitcomp.h +++ b/include/osmocom/core/bitcomp.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/bitvec.h b/include/osmocom/core/bitvec.h index bd10709..6a37861 100644 --- a/include/osmocom/core/bitvec.h +++ b/include/osmocom/core/bitvec.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/conv.h b/include/osmocom/core/conv.h index 8b344f4..1c14c3b 100644 --- a/include/osmocom/core/conv.h +++ b/include/osmocom/core/conv.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \defgroup conv Convolutional encoding and decoding routines diff --git a/include/osmocom/core/crcXXgen.h.tpl b/include/osmocom/core/crcXXgen.h.tpl index 823f21f..13a3623 100644 --- a/include/osmocom/core/crcXXgen.h.tpl +++ b/include/osmocom/core/crcXXgen.h.tpl @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/include/osmocom/core/crcgen.h b/include/osmocom/core/crcgen.h index 7cfe869..24d29e7 100644 --- a/include/osmocom/core/crcgen.h +++ b/include/osmocom/core/crcgen.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/include/osmocom/core/exec.h b/include/osmocom/core/exec.h index e63ec11..a4fdcfd 100644 --- a/include/osmocom/core/exec.h +++ b/include/osmocom/core/exec.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ extern const char *osmo_environment_whitelist[]; diff --git a/include/osmocom/core/isdnhdlc.h b/include/osmocom/core/isdnhdlc.h index 56369bf..43e6e7a 100644 --- a/include/osmocom/core/isdnhdlc.h +++ b/include/osmocom/core/isdnhdlc.h @@ -20,10 +20,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ #ifndef __ISDNHDLC_H__ diff --git a/include/osmocom/core/linuxrbtree.h b/include/osmocom/core/linuxrbtree.h index d3f9fd1..e15317e 100644 --- a/include/osmocom/core/linuxrbtree.h +++ b/include/osmocom/core/linuxrbtree.h @@ -12,11 +12,6 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - MA 02110-1301, USA. - linux/include/linux/rbtree.h To use rbtrees you'll have to implement your own insert and search cores. diff --git a/include/osmocom/core/loggingrb.h b/include/osmocom/core/loggingrb.h index a9fb404..6d50146 100644 --- a/include/osmocom/core/loggingrb.h +++ b/include/osmocom/core/loggingrb.h @@ -11,10 +11,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/msgb.h b/include/osmocom/core/msgb.h index df796c9..38e51dd 100644 --- a/include/osmocom/core/msgb.h +++ b/include/osmocom/core/msgb.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/include/osmocom/core/msgfile.h b/include/osmocom/core/msgfile.h index 800b431..cfa9590 100644 --- a/include/osmocom/core/msgfile.h +++ b/include/osmocom/core/msgfile.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/serial.h b/include/osmocom/core/serial.h index 443275f..0ac2968 100644 --- a/include/osmocom/core/serial.h +++ b/include/osmocom/core/serial.h @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \defgroup serial Utility functions to deal with serial ports diff --git a/include/osmocom/core/sockaddr_str.h b/include/osmocom/core/sockaddr_str.h index d96b743..f474fa0 100644 --- a/include/osmocom/core/sockaddr_str.h +++ b/include/osmocom/core/sockaddr_str.h @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/stats.h b/include/osmocom/core/stats.h index c4f71c8..6544dfa 100644 --- a/include/osmocom/core/stats.h +++ b/include/osmocom/core/stats.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/strrb.h b/include/osmocom/core/strrb.h index b87239d..e3d3201 100644 --- a/include/osmocom/core/strrb.h +++ b/include/osmocom/core/strrb.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/core/thread.h b/include/osmocom/core/thread.h index 40b5436..d857268 100644 --- a/include/osmocom/core/thread.h +++ b/include/osmocom/core/thread.h @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup thread Osmocom thread helpers diff --git a/include/osmocom/core/timer.h b/include/osmocom/core/timer.h index 61d20e2..16338da 100644 --- a/include/osmocom/core/timer.h +++ b/include/osmocom/core/timer.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup timer Osmocom timers diff --git a/include/osmocom/core/timer_compat.h b/include/osmocom/core/timer_compat.h index 916f568..fd52ae3 100644 --- a/include/osmocom/core/timer_compat.h +++ b/include/osmocom/core/timer_compat.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup timer Osmocom timers diff --git a/include/osmocom/core/use_count.h b/include/osmocom/core/use_count.h index cc5493c..532d8b1 100644 --- a/include/osmocom/core/use_count.h +++ b/include/osmocom/core/use_count.h @@ -19,10 +19,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/include/osmocom/core/write_queue.h b/include/osmocom/core/write_queue.h index 75d5d8f..6cb0a6b 100644 --- a/include/osmocom/core/write_queue.h +++ b/include/osmocom/core/write_queue.h @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/a5.h b/include/osmocom/gsm/a5.h index fa63246..1b26842 100644 --- a/include/osmocom/gsm/a5.h +++ b/include/osmocom/gsm/a5.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #pragma once diff --git a/include/osmocom/gsm/bsslap.h b/include/osmocom/gsm/bsslap.h index b2174b3..56f2e6c 100644 --- a/include/osmocom/gsm/bsslap.h +++ b/include/osmocom/gsm/bsslap.h @@ -21,10 +21,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/bssmap_le.h b/include/osmocom/gsm/bssmap_le.h index 1c750c8..113d4bd 100644 --- a/include/osmocom/gsm/bssmap_le.h +++ b/include/osmocom/gsm/bssmap_le.h @@ -21,10 +21,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/cbsp.h b/include/osmocom/gsm/cbsp.h index d456ce2..30a0ec9 100644 --- a/include/osmocom/gsm/cbsp.h +++ b/include/osmocom/gsm/cbsp.h @@ -24,10 +24,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /* Decoded 8.2.3 Message Content */ diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h index c21ce8a..c79da6a 100644 --- a/include/osmocom/gsm/gsm0808.h +++ b/include/osmocom/gsm/gsm0808.h @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/gsm0808_lcs.h b/include/osmocom/gsm/gsm0808_lcs.h index 8fcbe38..7166501 100644 --- a/include/osmocom/gsm/gsm0808_lcs.h +++ b/include/osmocom/gsm/gsm0808_lcs.h @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/gsm29118.h b/include/osmocom/gsm/gsm29118.h index e81cce4..33c40d3 100644 --- a/include/osmocom/gsm/gsm29118.h +++ b/include/osmocom/gsm/gsm29118.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/gsm29205.h b/include/osmocom/gsm/gsm29205.h index f93e34a..6c845fb 100644 --- a/include/osmocom/gsm/gsm29205.h +++ b/include/osmocom/gsm/gsm29205.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/gsm_utils.h b/include/osmocom/gsm/gsm_utils.h index 45af4f2..07b6a8b 100644 --- a/include/osmocom/gsm/gsm_utils.h +++ b/include/osmocom/gsm/gsm_utils.h @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/i460_mux.h b/include/osmocom/gsm/i460_mux.h index 8e39243..770b1e1 100644 --- a/include/osmocom/gsm/i460_mux.h +++ b/include/osmocom/gsm/i460_mux.h @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #pragma once diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h index b46f9f5..4937f08 100644 --- a/include/osmocom/gsm/protocol/gsm_08_58.h +++ b/include/osmocom/gsm/protocol/gsm_08_58.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/protocol/gsm_12_21.h b/include/osmocom/gsm/protocol/gsm_12_21.h index 542d978..9fe6a8b 100644 --- a/include/osmocom/gsm/protocol/gsm_12_21.h +++ b/include/osmocom/gsm/protocol/gsm_12_21.h @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/protocol/gsm_48_071.h b/include/osmocom/gsm/protocol/gsm_48_071.h index fb9653a..961211b 100644 --- a/include/osmocom/gsm/protocol/gsm_48_071.h +++ b/include/osmocom/gsm/protocol/gsm_48_071.h @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/gsm/protocol/gsm_49_031.h b/include/osmocom/gsm/protocol/gsm_49_031.h index c6152e1..06fcbce 100644 --- a/include/osmocom/gsm/protocol/gsm_49_031.h +++ b/include/osmocom/gsm/protocol/gsm_49_031.h @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/sim/class_tables.h b/include/osmocom/sim/class_tables.h index d5be39d..ec9ec49 100644 --- a/include/osmocom/sim/class_tables.h +++ b/include/osmocom/sim/class_tables.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #pragma once diff --git a/include/osmocom/usb/libusb.h b/include/osmocom/usb/libusb.h index 9ad3f71..33caa86 100644 --- a/include/osmocom/usb/libusb.h +++ b/include/osmocom/usb/libusb.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include diff --git a/include/osmocom/vty/telnet_interface.h b/include/osmocom/vty/telnet_interface.h index da7cf83..a28df47 100644 --- a/include/osmocom/vty/telnet_interface.h +++ b/include/osmocom/vty/telnet_interface.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/vty/vector.h b/include/osmocom/vty/vector.h index 0a639ad..ac524bc 100644 --- a/include/osmocom/vty/vector.h +++ b/include/osmocom/vty/vector.h @@ -14,11 +14,6 @@ * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with GNU Zebra; see the file COPYING. If not, write to the Free - * Software Foundation, Inc., 51 Franklin Street, Fifth Floor, - * Boston, MA 02110-1301, USA. */ #pragma once diff --git a/src/application.c b/src/application.c index 7fd6280..f7e5816 100644 --- a/src/application.c +++ b/src/application.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \mainpage libosmocore Documentation diff --git a/src/backtrace.c b/src/backtrace.c index a18bde0..60bd238 100644 --- a/src/backtrace.c +++ b/src/backtrace.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/base64.c b/src/base64.c index d86573e..0c161ce 100644 --- a/src/base64.c +++ b/src/base64.c @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/bitcomp.c b/src/bitcomp.c index 6f2fb62..5fb2cba 100644 --- a/src/bitcomp.c +++ b/src/bitcomp.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \defgroup bitcomp Bit compression diff --git a/src/bits.c b/src/bits.c index aa11753..4b413a3 100644 --- a/src/bits.c +++ b/src/bits.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/bitvec.c b/src/bitvec.c index 13deeff..6a54344 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup bitvec diff --git a/src/codec/ecu.c b/src/codec/ecu.c index db7148c..59194ae 100644 --- a/src/codec/ecu.c +++ b/src/codec/ecu.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* As the developer and copyright holder of the related code, I hereby diff --git a/src/codec/ecu_fr.c b/src/codec/ecu_fr.c index 4545172..218d837 100644 --- a/src/codec/ecu_fr.c +++ b/src/codec/ecu_fr.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/codec/gsm610.c b/src/codec/gsm610.c index a05eaba..ff9952a 100644 --- a/src/codec/gsm610.c +++ b/src/codec/gsm610.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/codec/gsm620.c b/src/codec/gsm620.c index 282781f..cf7cfd7 100644 --- a/src/codec/gsm620.c +++ b/src/codec/gsm620.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/codec/gsm660.c b/src/codec/gsm660.c index 4f7bb09..34b10de 100644 --- a/src/codec/gsm660.c +++ b/src/codec/gsm660.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/codec/gsm690.c b/src/codec/gsm690.c index cc6cdf0..3b2e669 100644 --- a/src/codec/gsm690.c +++ b/src/codec/gsm690.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 9c189cd..835a18e 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/coding/gsm0503_interleaving.c b/src/coding/gsm0503_interleaving.c index d5008d0..7809e83 100644 --- a/src/coding/gsm0503_interleaving.c +++ b/src/coding/gsm0503_interleaving.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/coding/gsm0503_mapping.c b/src/coding/gsm0503_mapping.c index f7532eb..04acfd0 100644 --- a/src/coding/gsm0503_mapping.c +++ b/src/coding/gsm0503_mapping.c @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/coding/gsm0503_parity.c b/src/coding/gsm0503_parity.c index a8daacc..ef71d35 100644 --- a/src/coding/gsm0503_parity.c +++ b/src/coding/gsm0503_parity.c @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/coding/gsm0503_tables.c b/src/coding/gsm0503_tables.c index df0abee..25ea2fa 100644 --- a/src/coding/gsm0503_tables.c +++ b/src/coding/gsm0503_tables.c @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/context.c b/src/context.c index bad012b..8ab6f87 100644 --- a/src/context.c +++ b/src/context.c @@ -15,11 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include #include diff --git a/src/conv.c b/src/conv.c index 06c4299..0e07e1f 100644 --- a/src/conv.c +++ b/src/conv.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup conv diff --git a/src/conv_acc.c b/src/conv_acc.c index 0f6f7ca..a26ed3b 100644 --- a/src/conv_acc.c +++ b/src/conv_acc.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/conv_acc_generic.c b/src/conv_acc_generic.c index 2887673..2257e6a 100644 --- a/src/conv_acc_generic.c +++ b/src/conv_acc_generic.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/conv_acc_neon.c b/src/conv_acc_neon.c index 7244946..fb180e3 100644 --- a/src/conv_acc_neon.c +++ b/src/conv_acc_neon.c @@ -18,10 +18,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/conv_acc_neon_impl.h b/src/conv_acc_neon_impl.h index 4471127..8a78c75 100644 --- a/src/conv_acc_neon_impl.h +++ b/src/conv_acc_neon_impl.h @@ -18,10 +18,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /* Some distributions (notably Alpine Linux) for some strange reason diff --git a/src/conv_acc_sse.c b/src/conv_acc_sse.c index 63d8722..513ab05 100644 --- a/src/conv_acc_sse.c +++ b/src/conv_acc_sse.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/conv_acc_sse_avx.c b/src/conv_acc_sse_avx.c index 5ac3c16..82b4fa6 100644 --- a/src/conv_acc_sse_avx.c +++ b/src/conv_acc_sse_avx.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/conv_acc_sse_impl.h b/src/conv_acc_sse_impl.h index 9ebbfe9..807dbe5 100644 --- a/src/conv_acc_sse_impl.h +++ b/src/conv_acc_sse_impl.h @@ -18,10 +18,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /* Some distributions (notably Alpine Linux) for some strange reason diff --git a/src/counter.c b/src/counter.c index 0fa3166..cbee7b9 100644 --- a/src/counter.c +++ b/src/counter.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/crcXXgen.c.tpl b/src/crcXXgen.c.tpl index 74e6d52..154291c 100644 --- a/src/crcXXgen.c.tpl +++ b/src/crcXXgen.c.tpl @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup crc diff --git a/src/ctrl/control_cmd.c b/src/ctrl/control_cmd.c index e67df67..b069ca4 100644 --- a/src/ctrl/control_cmd.c +++ b/src/ctrl/control_cmd.c @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c index bea8496..37e430f 100644 --- a/src/ctrl/control_if.c +++ b/src/ctrl/control_if.c @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/ctrl/control_vty.c b/src/ctrl/control_vty.c index e141a4c..6910d4c 100644 --- a/src/ctrl/control_vty.c +++ b/src/ctrl/control_vty.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/exec.c b/src/exec.c index 2a03ba8..fd63d85 100644 --- a/src/exec.c +++ b/src/exec.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/fsm.c b/src/fsm.c index 8f7ff1a..8b0b27b 100644 --- a/src/fsm.c +++ b/src/fsm.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/gsm/a5.c b/src/gsm/a5.c index 223d3ad..d223cb7 100644 --- a/src/gsm/a5.c +++ b/src/gsm/a5.c @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup a5 diff --git a/src/gsm/auth_comp128v1.c b/src/gsm/auth_comp128v1.c index 493ebfd..ba3cf60 100644 --- a/src/gsm/auth_comp128v1.c +++ b/src/gsm/auth_comp128v1.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/auth_comp128v23.c b/src/gsm/auth_comp128v23.c index 279d2b7..91fb259 100644 --- a/src/gsm/auth_comp128v23.c +++ b/src/gsm/auth_comp128v23.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/auth_core.c b/src/gsm/auth_core.c index 9e750a0..f450850 100644 --- a/src/gsm/auth_core.c +++ b/src/gsm/auth_core.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/gsm/auth_milenage.c b/src/gsm/auth_milenage.c index 9589100..4a430b3 100644 --- a/src/gsm/auth_milenage.c +++ b/src/gsm/auth_milenage.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/auth_xor.c b/src/gsm/auth_xor.c index 36e006e..4507542 100644 --- a/src/gsm/auth_xor.c +++ b/src/gsm/auth_xor.c @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/bsslap.c b/src/gsm/bsslap.c index 7886da6..7b31d1f 100644 --- a/src/gsm/bsslap.c +++ b/src/gsm/bsslap.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/bssmap_le.c b/src/gsm/bssmap_le.c index 7954653..fa0f254 100644 --- a/src/gsm/bssmap_le.c +++ b/src/gsm/bssmap_le.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/bts_features.c b/src/gsm/bts_features.c index 614758b..88a6fc3 100644 --- a/src/gsm/bts_features.c +++ b/src/gsm/bts_features.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/gsm/cbsp.c b/src/gsm/cbsp.c index 353f53f..e340ebe 100644 --- a/src/gsm/cbsp.c +++ b/src/gsm/cbsp.c @@ -15,10 +15,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include "config.h" diff --git a/src/gsm/comp128.c b/src/gsm/comp128.c index b28a843..e252b04 100644 --- a/src/gsm/comp128.c +++ b/src/gsm/comp128.c @@ -58,10 +58,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/comp128v23.c b/src/gsm/comp128v23.c index 550f6a4..0947017 100644 --- a/src/gsm/comp128v23.c +++ b/src/gsm/comp128v23.c @@ -23,10 +23,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/gea.c b/src/gsm/gea.c index 5756bb0..aedc898 100644 --- a/src/gsm/gea.c +++ b/src/gsm/gea.c @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/gsm/gprs_cipher_core.c b/src/gsm/gprs_cipher_core.c index 7f2b1a5..97e581d 100644 --- a/src/gsm/gprs_cipher_core.c +++ b/src/gsm/gprs_cipher_core.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/gsm/gprs_gea.c b/src/gsm/gprs_gea.c index 7314788..eae1cf1 100644 --- a/src/gsm/gprs_gea.c +++ b/src/gsm/gprs_gea.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/gsm/gsm0341.c b/src/gsm/gsm0341.c index 89f5de3..a6238b3 100644 --- a/src/gsm/gsm0341.c +++ b/src/gsm/gsm0341.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c index 1d5cde9..7a7f71f 100644 --- a/src/gsm/gsm0480.c +++ b/src/gsm/gsm0480.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c index 158c490..4f9c687 100644 --- a/src/gsm/gsm0808.c +++ b/src/gsm/gsm0808.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/gsm23003.c b/src/gsm/gsm23003.c index f3c0123..71d44fb 100644 --- a/src/gsm/gsm23003.c +++ b/src/gsm/gsm23003.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/gsm23236.c b/src/gsm/gsm23236.c index d4a14a5..4a83ec8 100644 --- a/src/gsm/gsm23236.c +++ b/src/gsm/gsm23236.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/gsm29118.c b/src/gsm/gsm29118.c index 2c02b2f..0ca5b52 100644 --- a/src/gsm/gsm29118.c +++ b/src/gsm/gsm29118.c @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/gsm/gsm29205.c b/src/gsm/gsm29205.c index 6ceb8ee..8fed020 100644 --- a/src/gsm/gsm29205.c +++ b/src/gsm/gsm29205.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 44ce776..30bba91 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c index 6070e5c..6d40bec 100644 --- a/src/gsm/gsm48_ie.c +++ b/src/gsm/gsm48_ie.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c index 9125b0e..f8bb58e 100644 --- a/src/gsm/gsm_utils.c +++ b/src/gsm/gsm_utils.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \mainpage libosmogsm Documentation diff --git a/src/gsm/i460_mux.c b/src/gsm/i460_mux.c index 91ab2a1..a6a0835 100644 --- a/src/gsm/i460_mux.c +++ b/src/gsm/i460_mux.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/gsm/kasumi.c b/src/gsm/kasumi.c index f93c002..78885bd 100644 --- a/src/gsm/kasumi.c +++ b/src/gsm/kasumi.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/kdf.c b/src/gsm/kdf.c index 2ebe41a..6982f6f 100644 --- a/src/gsm/kdf.c +++ b/src/gsm/kdf.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/lapd_core.c b/src/gsm/lapd_core.c index e0c232f..0e89874 100644 --- a/src/gsm/lapd_core.c +++ b/src/gsm/lapd_core.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup lapd diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c index 8620cab..e7d46e6 100644 --- a/src/gsm/lapdm.c +++ b/src/gsm/lapdm.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup lapdm diff --git a/src/gsm/rsl.c b/src/gsm/rsl.c index e648d82..f535b7f 100644 --- a/src/gsm/rsl.c +++ b/src/gsm/rsl.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsm/rxlev_stat.c b/src/gsm/rxlev_stat.c index 9c650cc..f1b77f4 100644 --- a/src/gsm/rxlev_stat.c +++ b/src/gsm/rxlev_stat.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/gsmtap_util.c b/src/gsmtap_util.c index e5adb2f..671a6c3 100644 --- a/src/gsmtap_util.c +++ b/src/gsmtap_util.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "../config.h" diff --git a/src/isdnhdlc.c b/src/isdnhdlc.c index 58b4a66..8ec1c95 100644 --- a/src/isdnhdlc.c +++ b/src/isdnhdlc.c @@ -18,10 +18,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ #include diff --git a/src/it_q.c b/src/it_q.c index 1bb0e15..fda6c1f 100644 --- a/src/it_q.c +++ b/src/it_q.c @@ -14,11 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ /*! \addtogroup it_q diff --git a/src/logging.c b/src/logging.c index b6c26d2..9497f28 100644 --- a/src/logging.c +++ b/src/logging.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup logging diff --git a/src/logging_gsmtap.c b/src/logging_gsmtap.c index e190f88..cc95388 100644 --- a/src/logging_gsmtap.c +++ b/src/logging_gsmtap.c @@ -21,10 +21,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup logging diff --git a/src/logging_syslog.c b/src/logging_syslog.c index f980689..2090856 100644 --- a/src/logging_syslog.c +++ b/src/logging_syslog.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup logging diff --git a/src/logging_systemd.c b/src/logging_systemd.c index 7c96686..2e86feb 100644 --- a/src/logging_systemd.c +++ b/src/logging_systemd.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup logging diff --git a/src/loggingrb.c b/src/loggingrb.c index 4a80cc8..2bf7b66 100644 --- a/src/loggingrb.c +++ b/src/loggingrb.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup loggingrb diff --git a/src/macaddr.c b/src/macaddr.c index 56fdf86..3b231fb 100644 --- a/src/macaddr.c +++ b/src/macaddr.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup utils diff --git a/src/mnl.c b/src/mnl.c index a7d3511..f32367d 100644 --- a/src/mnl.c +++ b/src/mnl.c @@ -21,11 +21,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/msgb.c b/src/msgb.c index fbb157a..ccb55aa 100644 --- a/src/msgb.c +++ b/src/msgb.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup msgb diff --git a/src/msgfile.c b/src/msgfile.c index 1f11aa6..abb4e7c 100644 --- a/src/msgfile.c +++ b/src/msgfile.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #define _WITH_GETLINE diff --git a/src/panic.c b/src/panic.c index 072f458..6c92522 100644 --- a/src/panic.c +++ b/src/panic.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup utils diff --git a/src/plugin.c b/src/plugin.c index 40de4f8..5f44a40 100644 --- a/src/plugin.c +++ b/src/plugin.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup utils diff --git a/src/rate_ctr.c b/src/rate_ctr.c index 283858d..ffae1b8 100644 --- a/src/rate_ctr.c +++ b/src/rate_ctr.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup rate_ctr diff --git a/src/rbtree.c b/src/rbtree.c index 211978f..f4dc219 100644 --- a/src/rbtree.c +++ b/src/rbtree.c @@ -15,11 +15,6 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. - You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - MA 02110-1301, USA - linux/lib/rbtree.c */ diff --git a/src/select.c b/src/select.c index f7eb5ea..590c3db 100644 --- a/src/select.c +++ b/src/select.c @@ -18,11 +18,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, - * MA 02110-1301, USA. */ #include diff --git a/src/sercomm.c b/src/sercomm.c index 2639bf8..1798ace 100644 --- a/src/sercomm.c +++ b/src/sercomm.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup sercomm diff --git a/src/serial.c b/src/serial.c index c3bf5e8..117c049 100644 --- a/src/serial.c +++ b/src/serial.c @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ /*! \addtogroup serial diff --git a/src/signal.c b/src/signal.c index be3b777..ba1555a 100644 --- a/src/signal.c +++ b/src/signal.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/sim/card_fs_hpsim.c b/src/sim/card_fs_hpsim.c index 4a5f7d9..2c115b7 100644 --- a/src/sim/card_fs_hpsim.c +++ b/src/sim/card_fs_hpsim.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sim/card_fs_isim.c b/src/sim/card_fs_isim.c index f11c029..1a38da2 100644 --- a/src/sim/card_fs_isim.c +++ b/src/sim/card_fs_isim.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sim/card_fs_sim.c b/src/sim/card_fs_sim.c index 55ce9af..f07a237 100644 --- a/src/sim/card_fs_sim.c +++ b/src/sim/card_fs_sim.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/sim/card_fs_tetra.c b/src/sim/card_fs_tetra.c index 12853a5..597e38b 100644 --- a/src/sim/card_fs_tetra.c +++ b/src/sim/card_fs_tetra.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/sim/card_fs_uicc.c b/src/sim/card_fs_uicc.c index 5dcaaa1..87def0e 100644 --- a/src/sim/card_fs_uicc.c +++ b/src/sim/card_fs_uicc.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sim/card_fs_usim.c b/src/sim/card_fs_usim.c index 8f880e7..8cff3fc 100644 --- a/src/sim/card_fs_usim.c +++ b/src/sim/card_fs_usim.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sim/class_tables.c b/src/sim/class_tables.c index 6f541ee..534ef53 100644 --- a/src/sim/class_tables.c +++ b/src/sim/class_tables.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include diff --git a/src/sim/core.c b/src/sim/core.c index d11c2d8..fa17e12 100644 --- a/src/sim/core.c +++ b/src/sim/core.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sim/reader.c b/src/sim/reader.c index 7f3f18d..b41b730 100644 --- a/src/sim/reader.c +++ b/src/sim/reader.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sim/reader_pcsc.c b/src/sim/reader_pcsc.c index fa867c0..c37072e 100644 --- a/src/sim/reader_pcsc.c +++ b/src/sim/reader_pcsc.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/sockaddr_str.c b/src/sockaddr_str.c index f5508a0..9f1e897 100644 --- a/src/sockaddr_str.c +++ b/src/sockaddr_str.c @@ -20,10 +20,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "config.h" diff --git a/src/socket.c b/src/socket.c index 45b0f5b..1251061 100644 --- a/src/socket.c +++ b/src/socket.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include "../config.h" diff --git a/src/stat_item.c b/src/stat_item.c index 59f5935..1f398d5 100644 --- a/src/stat_item.c +++ b/src/stat_item.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup osmo_stat_item diff --git a/src/stats.c b/src/stats.c index 702e408..4fb20e2 100644 --- a/src/stats.c +++ b/src/stats.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup stats diff --git a/src/stats_statsd.c b/src/stats_statsd.c index 1acfce8..b89ec92 100644 --- a/src/stats_statsd.c +++ b/src/stats_statsd.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup stats diff --git a/src/strrb.c b/src/strrb.c index 461fdec..df7edb3 100644 --- a/src/strrb.c +++ b/src/strrb.c @@ -31,10 +31,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup utils diff --git a/src/thread.c b/src/thread.c index 956fee7..d9a9842 100644 --- a/src/thread.c +++ b/src/thread.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup thread diff --git a/src/timer.c b/src/timer.c index ed5a610..20d87a0 100644 --- a/src/timer.c +++ b/src/timer.c @@ -19,10 +19,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/timer_clockgettime.c b/src/timer_clockgettime.c index 7b17fd1..6112b8a 100644 --- a/src/timer_clockgettime.c +++ b/src/timer_clockgettime.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup timer diff --git a/src/timer_gettimeofday.c b/src/timer_gettimeofday.c index 3494946..e0212b5 100644 --- a/src/timer_gettimeofday.c +++ b/src/timer_gettimeofday.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /*! \addtogroup timer diff --git a/src/usb/osmo_libusb.c b/src/usb/osmo_libusb.c index bb86206..05331a1 100644 --- a/src/usb/osmo_libusb.c +++ b/src/usb/osmo_libusb.c @@ -14,10 +14,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ #include #include diff --git a/src/use_count.c b/src/use_count.c index d07e47f..6c52899 100644 --- a/src/use_count.c +++ b/src/use_count.c @@ -19,10 +19,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/src/utils.c b/src/utils.c index 300204a..bec4b75 100644 --- a/src/utils.c +++ b/src/utils.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/src/vty/fsm_vty.c b/src/vty/fsm_vty.c index 83a8e79..025d0d8 100644 --- a/src/vty/fsm_vty.c +++ b/src/vty/fsm_vty.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index d33fe5e..4e5725b 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index c6c50ef..e2247a3 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/vty/talloc_ctx_vty.c b/src/vty/talloc_ctx_vty.c index 206d049..dcb1c9b 100644 --- a/src/vty/talloc_ctx_vty.c +++ b/src/vty/talloc_ctx_vty.c @@ -17,10 +17,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c index cd32e68..374578c 100644 --- a/src/vty/telnet_interface.c +++ b/src/vty/telnet_interface.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/vty/utils.c b/src/vty/utils.c index 4501c66..696a519 100644 --- a/src/vty/utils.c +++ b/src/vty/utils.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/vty/vector.c b/src/vty/vector.c index f9e5ec3..34b161d 100644 --- a/src/vty/vector.c +++ b/src/vty/vector.c @@ -16,11 +16,6 @@ * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with GNU Zebra; see the file COPYING. If not, write to the Free - * Software Foundation, Inc., 51 Franklin Street, Fifth Floor, - * Boston, MA 02110-1301, USA. */ #include diff --git a/src/write_queue.c b/src/write_queue.c index 31b8427..884cebd 100644 --- a/src/write_queue.c +++ b/src/write_queue.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/abis/abis_test.c b/tests/abis/abis_test.c index ca6daed..2151e92 100644 --- a/tests/abis/abis_test.c +++ b/tests/abis/abis_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/coding/coding_test.c b/tests/coding/coding_test.c index bdfe300..5a6f6e0 100644 --- a/tests/coding/coding_test.c +++ b/tests/coding/coding_test.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/tests/dtx/dtx_gsm0503_test.c b/tests/dtx/dtx_gsm0503_test.c index f300313..b14c978 100644 --- a/tests/dtx/dtx_gsm0503_test.c +++ b/tests/dtx/dtx_gsm0503_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/fr/fr_test.c b/tests/fr/fr_test.c index 4d472b5..3fb18f3 100644 --- a/tests/fr/fr_test.c +++ b/tests/fr/fr_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #define _GNU_SOURCE diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index 5a59639..cdccf53 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma GCC diagnostic ignored "-Wdeprecated-declarations" diff --git a/tests/gsm0502/gsm0502_test.c b/tests/gsm0502/gsm0502_test.c index a950c6c..f4f6530 100644 --- a/tests/gsm0502/gsm0502_test.c +++ b/tests/gsm0502/gsm0502_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c index 04b3b72..3fff005 100644 --- a/tests/gsm0808/gsm0808_test.c +++ b/tests/gsm0808/gsm0808_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/gsm23003/gsm23003_test.c b/tests/gsm23003/gsm23003_test.c index eac5a11..e73ef43 100644 --- a/tests/gsm23003/gsm23003_test.c +++ b/tests/gsm23003/gsm23003_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/gsm23236/gsm23236_test.c b/tests/gsm23236/gsm23236_test.c index 14c5ce3..77e20e3 100644 --- a/tests/gsm23236/gsm23236_test.c +++ b/tests/gsm23236/gsm23236_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/gsm29205/gsm29205_test.c b/tests/gsm29205/gsm29205_test.c index 44c3453..5d4835b 100644 --- a/tests/gsm29205/gsm29205_test.c +++ b/tests/gsm29205/gsm29205_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/gsm48/rest_octets_test.c b/tests/gsm48/rest_octets_test.c index beff6e4..fdab143 100644 --- a/tests/gsm48/rest_octets_test.c +++ b/tests/gsm48/rest_octets_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/lapd/lapd_test.c b/tests/lapd/lapd_test.c index 48851f4..ab0f316 100644 --- a/tests/lapd/lapd_test.c +++ b/tests/lapd/lapd_test.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/logging/logging_test.c b/tests/logging/logging_test.c index f873958..ac6fc52 100644 --- a/tests/logging/logging_test.c +++ b/tests/logging/logging_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/logging/logging_vty_test.c b/tests/logging/logging_vty_test.c index 078555e..f67746b 100644 --- a/tests/logging/logging_vty_test.c +++ b/tests/logging/logging_vty_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #define _GNU_SOURCE diff --git a/tests/loggingrb/loggingrb_test.c b/tests/loggingrb/loggingrb_test.c index 19378c3..fd11896 100644 --- a/tests/loggingrb/loggingrb_test.c +++ b/tests/loggingrb/loggingrb_test.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/msgb/msgb_test.c b/tests/msgb/msgb_test.c index ffaa155..aebb68c 100644 --- a/tests/msgb/msgb_test.c +++ b/tests/msgb/msgb_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/msgfile/msgfile_test.c b/tests/msgfile/msgfile_test.c index 2684b6a..3fe173d 100644 --- a/tests/msgfile/msgfile_test.c +++ b/tests/msgfile/msgfile_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/oap/oap_test.c b/tests/oap/oap_test.c index 32676ca..bebd603 100644 --- a/tests/oap/oap_test.c +++ b/tests/oap/oap_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/sercomm/sercomm_test.c b/tests/sercomm/sercomm_test.c index 058c9eb..9bffc0d 100644 --- a/tests/sercomm/sercomm_test.c +++ b/tests/sercomm/sercomm_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/sim/sim_test.c b/tests/sim/sim_test.c index 425ce11..2e2eec5 100644 --- a/tests/sim/sim_test.c +++ b/tests/sim/sim_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/sms/sms_test.c b/tests/sms/sms_test.c index 3e14529..9ca83a5 100644 --- a/tests/sms/sms_test.c +++ b/tests/sms/sms_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/smscb/gsm0341_test.c b/tests/smscb/gsm0341_test.c index c400f5c..d11336f 100644 --- a/tests/smscb/gsm0341_test.c +++ b/tests/smscb/gsm0341_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/smscb/smscb_test.c b/tests/smscb/smscb_test.c index 5925f69..3b6b74d 100644 --- a/tests/smscb/smscb_test.c +++ b/tests/smscb/smscb_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/sockaddr_str/sockaddr_str_test.c b/tests/sockaddr_str/sockaddr_str_test.c index 64a6104..0d0674b 100644 --- a/tests/sockaddr_str/sockaddr_str_test.c +++ b/tests/sockaddr_str/sockaddr_str_test.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/socket/socket_sctp_test.c b/tests/socket/socket_sctp_test.c index 4ca52a3..b318fe5 100644 --- a/tests/socket/socket_sctp_test.c +++ b/tests/socket/socket_sctp_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/socket/socket_test.c b/tests/socket/socket_test.c index 614db55..eda716a 100644 --- a/tests/socket/socket_test.c +++ b/tests/socket/socket_test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/stats/stats_test.c b/tests/stats/stats_test.c index 3aa1f52..4e36223 100644 --- a/tests/stats/stats_test.c +++ b/tests/stats/stats_test.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/strrb/strrb_test.c b/tests/strrb/strrb_test.c index 4282d1a..cdeaa34 100644 --- a/tests/strrb/strrb_test.c +++ b/tests/strrb/strrb_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/tdef/tdef_test.c b/tests/tdef/tdef_test.c index d188eed..a2beb6a 100644 --- a/tests/tdef/tdef_test.c +++ b/tests/tdef/tdef_test.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/tests/tdef/tdef_vty_config_root_test.c b/tests/tdef/tdef_vty_config_root_test.c index 0472ad5..aa5ff1b 100644 --- a/tests/tdef/tdef_vty_config_root_test.c +++ b/tests/tdef/tdef_vty_config_root_test.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #define _GNU_SOURCE diff --git a/tests/tdef/tdef_vty_config_subnode_test.c b/tests/tdef/tdef_vty_config_subnode_test.c index ff19150..90c7968 100644 --- a/tests/tdef/tdef_vty_config_subnode_test.c +++ b/tests/tdef/tdef_vty_config_subnode_test.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #define _GNU_SOURCE diff --git a/tests/tdef/tdef_vty_dynamic_test.c b/tests/tdef/tdef_vty_dynamic_test.c index 20dae53..a181d91 100644 --- a/tests/tdef/tdef_vty_dynamic_test.c +++ b/tests/tdef/tdef_vty_dynamic_test.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #define _GNU_SOURCE diff --git a/tests/timer/clk_override_test.c b/tests/timer/clk_override_test.c index 308e821..e67a6ed 100644 --- a/tests/timer/clk_override_test.c +++ b/tests/timer/clk_override_test.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/timer/timer_test.c b/tests/timer/timer_test.c index d2b0204..b06c774 100644 --- a/tests/timer/timer_test.c +++ b/tests/timer/timer_test.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/use_count/use_count_test.c b/tests/use_count/use_count_test.c index 95af308..2942c69 100644 --- a/tests/use_count/use_count_test.c +++ b/tests/use_count/use_count_test.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include diff --git a/tests/use_count/use_count_test.err b/tests/use_count/use_count_test.err index 97e74a5..29ebfb7 100644 --- a/tests/use_count/use_count_test.err +++ b/tests/use_count/use_count_test.err @@ -11,9 +11,9 @@ 3 foos A few gets and puts, logging source file information -DFOO NOTICE foo(a){IN_USE}: a +1 barring: now used by 1 (barring) (use_count_test.c:223) -DFOO NOTICE foo(b){IN_USE}: b +1 barring: now used by 1 (barring) (use_count_test.c:225) -DFOO NOTICE foo(b){IN_USE}: b +1 fighting: now used by 2 (barring,fighting) (use_count_test.c:226) +DFOO NOTICE foo(a){IN_USE}: a +1 barring: now used by 1 (barring) (use_count_test.c:219) +DFOO NOTICE foo(b){IN_USE}: b +1 barring: now used by 1 (barring) (use_count_test.c:221) +DFOO NOTICE foo(b){IN_USE}: b +1 fighting: now used by 2 (barring,fighting) (use_count_test.c:222) all use counts: a: 1 (barring) @@ -22,7 +22,7 @@ 3 foos Attempt to get more than one on limited 'barring' user: -DFOO ERROR foo(b){IN_USE}: Attempt to get more than one barring (use_count_test.c:231) +DFOO ERROR foo(b){IN_USE}: Attempt to get more than one barring (use_count_test.c:227) osmo_use_count_get_put(b, barring, 1) returned error: -34 Numerical result out of range all use counts: @@ -32,7 +32,7 @@ 3 foos Put away one user of b -DFOO NOTICE foo(b){IN_USE}: b -1 barring: now used by 1 (fighting) (use_count_test.c:235) +DFOO NOTICE foo(b){IN_USE}: b -1 barring: now used by 1 (fighting) (use_count_test.c:231) all use counts: a: 1 (barring) diff --git a/tests/ussd/ussd_test.c b/tests/ussd/ussd_test.c index 8025071..2b8321d 100644 --- a/tests/ussd/ussd_test.c +++ b/tests/ussd/ussd_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/utils/utils_test.c b/tests/utils/utils_test.c index 7e0e3d3..3ac5d1e 100644 --- a/tests/utils/utils_test.c +++ b/tests/utils/utils_test.c @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/vty/vty_test.c b/tests/vty/vty_test.c index e068f19..c84e4c9 100644 --- a/tests/vty/vty_test.c +++ b/tests/vty/vty_test.c @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/vty/vty_transcript_test.c b/tests/vty/vty_transcript_test.c index c9ecf18..84664f9 100644 --- a/tests/vty/vty_transcript_test.c +++ b/tests/vty/vty_transcript_test.c @@ -17,10 +17,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #define _GNU_SOURCE diff --git a/utils/conv_gen.py b/utils/conv_gen.py index d2eda15..27ffe62 100644 --- a/utils/conv_gen.py +++ b/utils/conv_gen.py @@ -16,10 +16,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ """ diff --git a/utils/osmo-arfcn.c b/utils/osmo-arfcn.c index 5f138f8..9e4534f 100644 --- a/utils/osmo-arfcn.c +++ b/utils/osmo-arfcn.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/utils/osmo-auc-gen.c b/utils/osmo-auc-gen.c index 446d8ec..72f1fcd 100644 --- a/utils/osmo-auc-gen.c +++ b/utils/osmo-auc-gen.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ diff --git a/utils/osmo-config-merge.c b/utils/osmo-config-merge.c index 477bb02..ed2039a 100644 --- a/utils/osmo-config-merge.c +++ b/utils/osmo-config-merge.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ /* diff --git a/utils/osmo-sim-test.c b/utils/osmo-sim-test.c index ae55b83..2c6c764 100644 --- a/utils/osmo-sim-test.c +++ b/utils/osmo-sim-test.c @@ -12,10 +12,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26550 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5050285e75cf120407a1d883e99b3c4bcae8ffd7 Gerrit-Change-Number: 26550 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:54:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:54:03 +0000 Subject: Change in libosmo-sccp[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26549 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia450b630e0b60b38835f599c93985bbe97c50d2f Gerrit-Change-Number: 26549 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:54:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:54:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:54:05 +0000 Subject: Change in libosmo-sccp[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26549 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: Ia450b630e0b60b38835f599c93985bbe97c50d2f --- M include/osmocom/mtp/mtp_level3.h M include/osmocom/mtp/mtp_pcap.h M include/osmocom/sccp/sccp.h M include/osmocom/sccp/sccp_types.h M src/mtp_pcap.c M src/sccp.c M tests/sccp/sccp_test.c M tests/vty/ss7_asp_vty_test.c 8 files changed, 0 insertions(+), 32 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/mtp/mtp_level3.h b/include/osmocom/mtp/mtp_level3.h index 414b144..5bb8629 100644 --- a/include/osmocom/mtp/mtp_level3.h +++ b/include/osmocom/mtp/mtp_level3.h @@ -14,10 +14,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #pragma once diff --git a/include/osmocom/mtp/mtp_pcap.h b/include/osmocom/mtp/mtp_pcap.h index 5e8f7d3..4e400e2 100644 --- a/include/osmocom/mtp/mtp_pcap.h +++ b/include/osmocom/mtp/mtp_pcap.h @@ -13,10 +13,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef mtp_pcap_h #define mtp_pcap_h diff --git a/include/osmocom/sccp/sccp.h b/include/osmocom/sccp/sccp.h index 4293792..9ff1067 100644 --- a/include/osmocom/sccp/sccp.h +++ b/include/osmocom/sccp/sccp.h @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef SCCP_H diff --git a/include/osmocom/sccp/sccp_types.h b/include/osmocom/sccp/sccp_types.h index 4ad7edf..0ef52b4 100644 --- a/include/osmocom/sccp/sccp_types.h +++ b/include/osmocom/sccp/sccp_types.h @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #ifndef SCCP_TYPES_H diff --git a/src/mtp_pcap.c b/src/mtp_pcap.c index a59efc5..5a67acf 100644 --- a/src/mtp_pcap.c +++ b/src/mtp_pcap.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/src/sccp.c b/src/sccp.c index 058f20b..ee90579 100644 --- a/src/sccp.c +++ b/src/sccp.c @@ -18,10 +18,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/sccp/sccp_test.c b/tests/sccp/sccp_test.c index 29f343f..1fe353d 100644 --- a/tests/sccp/sccp_test.c +++ b/tests/sccp/sccp_test.c @@ -16,10 +16,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #include diff --git a/tests/vty/ss7_asp_vty_test.c b/tests/vty/ss7_asp_vty_test.c index eb575bc..4ee0f7f 100644 --- a/tests/vty/ss7_asp_vty_test.c +++ b/tests/vty/ss7_asp_vty_test.c @@ -15,10 +15,6 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - * */ #define _GNU_SOURCE -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia450b630e0b60b38835f599c93985bbe97c50d2f Gerrit-Change-Number: 26549 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:54:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:54:14 +0000 Subject: Change in osmo-trx[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/26563 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/26563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8ba71ab9ccde4ba25151ecbeb2a323f706b57d43 Gerrit-Change-Number: 26563 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: ttsou Gerrit-Comment-Date: Tue, 14 Dec 2021 12:54:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:54:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:54:17 +0000 Subject: Change in osmo-trx[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/26563 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I8ba71ab9ccde4ba25151ecbeb2a323f706b57d43 --- M CommonLibs/PRBS.h M CommonLibs/Utils.cpp M CommonLibs/Utils.h M Transceiver52M/Resampler.cpp M Transceiver52M/Resampler.h M Transceiver52M/arch/arm/convert.c M Transceiver52M/arch/arm/convert_neon.S M Transceiver52M/arch/arm/convolve.c M Transceiver52M/arch/arm/convolve_neon.S M Transceiver52M/arch/arm/mult.c M Transceiver52M/arch/arm/mult_neon.S M Transceiver52M/arch/arm/scale.c M Transceiver52M/arch/arm/scale_neon.S M Transceiver52M/arch/common/convert_base.c M Transceiver52M/arch/common/convolve_base.c M Transceiver52M/arch/x86/convert.c M Transceiver52M/arch/x86/convert_sse_3.c M Transceiver52M/arch/x86/convert_sse_3.h M Transceiver52M/arch/x86/convert_sse_4_1.c M Transceiver52M/arch/x86/convert_sse_4_1.h M Transceiver52M/arch/x86/convolve.c M Transceiver52M/arch/x86/convolve_sse_3.c M Transceiver52M/arch/x86/convolve_sse_3.h M Transceiver52M/osmo-trx.cpp M tests/CommonLibs/PRBSTest.cpp 25 files changed, 0 insertions(+), 100 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/CommonLibs/PRBS.h b/CommonLibs/PRBS.h index 9235327..8d08fa3 100644 --- a/CommonLibs/PRBS.h +++ b/CommonLibs/PRBS.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #ifndef PRBS_H diff --git a/CommonLibs/Utils.cpp b/CommonLibs/Utils.cpp index e500475..3ab598d 100644 --- a/CommonLibs/Utils.cpp +++ b/CommonLibs/Utils.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/CommonLibs/Utils.h b/CommonLibs/Utils.h index 3c5c802..8e61a9f 100644 --- a/CommonLibs/Utils.h +++ b/CommonLibs/Utils.h @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #pragma once diff --git a/Transceiver52M/Resampler.cpp b/Transceiver52M/Resampler.cpp index 2ca6406..910c7ff 100644 --- a/Transceiver52M/Resampler.cpp +++ b/Transceiver52M/Resampler.cpp @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/Resampler.h b/Transceiver52M/Resampler.h index 5af8d26..e1962c7 100644 --- a/Transceiver52M/Resampler.h +++ b/Transceiver52M/Resampler.h @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #ifndef _RESAMPLER_H_ diff --git a/Transceiver52M/arch/arm/convert.c b/Transceiver52M/arch/arm/convert.c index ace1b6f..7145579 100644 --- a/Transceiver52M/arch/arm/convert.c +++ b/Transceiver52M/arch/arm/convert.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/arm/convert_neon.S b/Transceiver52M/arch/arm/convert_neon.S index a1fbd40..6cf3c03 100644 --- a/Transceiver52M/arch/arm/convert_neon.S +++ b/Transceiver52M/arch/arm/convert_neon.S @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ .syntax unified diff --git a/Transceiver52M/arch/arm/convolve.c b/Transceiver52M/arch/arm/convolve.c index adb718d..c2611b4 100644 --- a/Transceiver52M/arch/arm/convolve.c +++ b/Transceiver52M/arch/arm/convolve.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/arm/convolve_neon.S b/Transceiver52M/arch/arm/convolve_neon.S index a3e1ba5..3209d60 100644 --- a/Transceiver52M/arch/arm/convolve_neon.S +++ b/Transceiver52M/arch/arm/convolve_neon.S @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #ifdef HAVE_CONFIG_H diff --git a/Transceiver52M/arch/arm/mult.c b/Transceiver52M/arch/arm/mult.c index 9851626..251b3c9 100644 --- a/Transceiver52M/arch/arm/mult.c +++ b/Transceiver52M/arch/arm/mult.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/arm/mult_neon.S b/Transceiver52M/arch/arm/mult_neon.S index 6318c50..b4cd229 100644 --- a/Transceiver52M/arch/arm/mult_neon.S +++ b/Transceiver52M/arch/arm/mult_neon.S @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ .syntax unified diff --git a/Transceiver52M/arch/arm/scale.c b/Transceiver52M/arch/arm/scale.c index a3214f7..d44ffc8 100644 --- a/Transceiver52M/arch/arm/scale.c +++ b/Transceiver52M/arch/arm/scale.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/arm/scale_neon.S b/Transceiver52M/arch/arm/scale_neon.S index f10de1e..c348f30 100644 --- a/Transceiver52M/arch/arm/scale_neon.S +++ b/Transceiver52M/arch/arm/scale_neon.S @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ .syntax unified diff --git a/Transceiver52M/arch/common/convert_base.c b/Transceiver52M/arch/common/convert_base.c index 9876e83..9a01a1e 100644 --- a/Transceiver52M/arch/common/convert_base.c +++ b/Transceiver52M/arch/common/convert_base.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include "convert.h" diff --git a/Transceiver52M/arch/common/convolve_base.c b/Transceiver52M/arch/common/convolve_base.c index bfda783..3765c5c 100644 --- a/Transceiver52M/arch/common/convolve_base.c +++ b/Transceiver52M/arch/common/convolve_base.c @@ -13,10 +13,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/x86/convert.c b/Transceiver52M/arch/x86/convert.c index bbcfd67..596233c 100644 --- a/Transceiver52M/arch/x86/convert.c +++ b/Transceiver52M/arch/x86/convert.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/x86/convert_sse_3.c b/Transceiver52M/arch/x86/convert_sse_3.c index 255db67..f00ecf5 100644 --- a/Transceiver52M/arch/x86/convert_sse_3.c +++ b/Transceiver52M/arch/x86/convert_sse_3.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/x86/convert_sse_3.h b/Transceiver52M/arch/x86/convert_sse_3.h index c2f87d7..b5abe47 100644 --- a/Transceiver52M/arch/x86/convert_sse_3.h +++ b/Transceiver52M/arch/x86/convert_sse_3.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #pragma once diff --git a/Transceiver52M/arch/x86/convert_sse_4_1.c b/Transceiver52M/arch/x86/convert_sse_4_1.c index 42a235c..736a376 100644 --- a/Transceiver52M/arch/x86/convert_sse_4_1.c +++ b/Transceiver52M/arch/x86/convert_sse_4_1.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/x86/convert_sse_4_1.h b/Transceiver52M/arch/x86/convert_sse_4_1.h index 57a5efb..63305e5 100644 --- a/Transceiver52M/arch/x86/convert_sse_4_1.h +++ b/Transceiver52M/arch/x86/convert_sse_4_1.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #pragma once diff --git a/Transceiver52M/arch/x86/convolve.c b/Transceiver52M/arch/x86/convolve.c index be62721..45a3719 100644 --- a/Transceiver52M/arch/x86/convolve.c +++ b/Transceiver52M/arch/x86/convolve.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/x86/convolve_sse_3.c b/Transceiver52M/arch/x86/convolve_sse_3.c index 8fd3b5e..ca4dc71 100644 --- a/Transceiver52M/arch/x86/convolve_sse_3.c +++ b/Transceiver52M/arch/x86/convolve_sse_3.c @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include diff --git a/Transceiver52M/arch/x86/convolve_sse_3.h b/Transceiver52M/arch/x86/convolve_sse_3.h index d929ef6..2cbc037 100644 --- a/Transceiver52M/arch/x86/convolve_sse_3.h +++ b/Transceiver52M/arch/x86/convolve_sse_3.h @@ -11,10 +11,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #pragma once diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index b227863..b6f378b 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #ifdef HAVE_CONFIG_H diff --git a/tests/CommonLibs/PRBSTest.cpp b/tests/CommonLibs/PRBSTest.cpp index cb5ed41..8000288 100644 --- a/tests/CommonLibs/PRBSTest.cpp +++ b/tests/CommonLibs/PRBSTest.cpp @@ -12,10 +12,6 @@ * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include "PRBS.h" -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/26563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8ba71ab9ccde4ba25151ecbeb2a323f706b57d43 Gerrit-Change-Number: 26563 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: ttsou Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:57:10 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:57:10 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 4: I still don't like the in-line patching of the binary. It just feels wrong in any project that uses make to have two different results/outputs with the same name. It's just one of those things I would say "are simply not done" - irrespective of whatever other problems the current Makefile might have. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Tue, 14 Dec 2021 12:57:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:57:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:57:29 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch: tweak FSF_MAILING_ADDRESS error In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26567 ) Change subject: lint: checkpatch: tweak FSF_MAILING_ADDRESS error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26567 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic76132c40a9c30a167c24c4c4b53180c4cc0fb86 Gerrit-Change-Number: 26567 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 14 Dec 2021 12:57:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:57:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:57:31 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch: tweak FSF_MAILING_ADDRESS error In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26567 ) Change subject: lint: checkpatch: tweak FSF_MAILING_ADDRESS error ...................................................................... lint: checkpatch: tweak FSF_MAILING_ADDRESS error Change-Id: Ic76132c40a9c30a167c24c4c4b53180c4cc0fb86 --- M lint/checkpatch/checkpatch.pl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl index a4d229c..51c406e 100755 --- a/lint/checkpatch/checkpatch.pl +++ b/lint/checkpatch/checkpatch.pl @@ -3437,7 +3437,7 @@ my $msg_level = \&ERROR; $msg_level = \&CHK if ($file); &{$msg_level}("FSF_MAILING_ADDRESS", - "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet) + "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.\n" . $herevet) } # check for Kconfig help text having a real description -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26567 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic76132c40a9c30a167c24c4c4b53180c4cc0fb86 Gerrit-Change-Number: 26567 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:57:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:57:40 +0000 Subject: Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: new job In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26480 ) Change subject: jobs/octsim_osmo-ccid-firmware: new job ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I19d18b24a6ae5948aeaf7c46083748c70cdb3b7b Gerrit-Change-Number: 26480 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:57:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:58:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:58:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 ) Change subject: bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 Gerrit-Change-Number: 26535 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:58:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:58:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:58:50 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-{msc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 ) Change subject: msc/osmo-{msc,stp}.cfg: enable extended timestamp in logging ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6414d5622fb287fd147c09e791e1b8023d1596e Gerrit-Change-Number: 26536 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:58:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:58:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:58:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-{bsc, bts}.cfg: tune logging configuration In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 ) Change subject: bts/osmo-{bsc,bts}.cfg: tune logging configuration ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 Gerrit-Change-Number: 26523 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:58:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:59:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:59:02 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 ) Change subject: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08580e5d8313e644908c1d7b370c5de882f3735c Gerrit-Change-Number: 26537 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 12:59:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:59:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:59:04 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-{bsc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 ) Change subject: bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging ...................................................................... bsc/osmo-{bsc,stp}.cfg: enable extended timestamp in logging Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 --- M bsc/osmo-bsc.cfg M bsc/osmo-stp.cfg 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/osmo-bsc.cfg b/bsc/osmo-bsc.cfg index 0ed4916..f5c9c16 100644 --- a/bsc/osmo-bsc.cfg +++ b/bsc/osmo-bsc.cfg @@ -5,6 +5,7 @@ ! log stderr logging filter all 1 + logging print extended-timestamp 1 logging print file basename last logging print category-hex 0 logging print category 1 diff --git a/bsc/osmo-stp.cfg b/bsc/osmo-stp.cfg index b0b4f05..21952dc 100644 --- a/bsc/osmo-stp.cfg +++ b/bsc/osmo-stp.cfg @@ -4,6 +4,7 @@ ! log stderr logging filter all 1 + logging print extended-timestamp 1 logging print file basename last logging print category-hex 0 logging print category 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9c03b367514db577be3f354a83e9fea9dc02712 Gerrit-Change-Number: 26535 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:59:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:59:04 +0000 Subject: Change in osmo-ttcn3-hacks[master]: msc/osmo-{msc, stp}.cfg: enable extended timestamp in logging In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 ) Change subject: msc/osmo-{msc,stp}.cfg: enable extended timestamp in logging ...................................................................... msc/osmo-{msc,stp}.cfg: enable extended timestamp in logging Change-Id: Ia6414d5622fb287fd147c09e791e1b8023d1596e --- M msc/osmo-msc.cfg M msc/osmo-stp.cfg 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index 79ffa04..1adb0e9 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -4,6 +4,7 @@ ! log stderr logging filter all 1 + logging print extended-timestamp 1 logging print file basename last logging print category-hex 0 logging print category 1 diff --git a/msc/osmo-stp.cfg b/msc/osmo-stp.cfg index 727119d..fc3cf54 100644 --- a/msc/osmo-stp.cfg +++ b/msc/osmo-stp.cfg @@ -4,6 +4,7 @@ ! log stderr logging filter all 1 + logging print extended-timestamp 1 logging print file basename last logging print category-hex 0 logging print category 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia6414d5622fb287fd147c09e791e1b8023d1596e Gerrit-Change-Number: 26536 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:59:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:59:05 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bts/osmo-{bsc, bts}.cfg: tune logging configuration In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 ) Change subject: bts/osmo-{bsc,bts}.cfg: tune logging configuration ...................................................................... bts/osmo-{bsc,bts}.cfg: tune logging configuration Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 --- M bts/osmo-bsc.cfg M bts/osmo-bts.cfg 2 files changed, 14 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/osmo-bsc.cfg b/bts/osmo-bsc.cfg index e4161fa..8f3169b 100644 --- a/bts/osmo-bsc.cfg +++ b/bts/osmo-bsc.cfg @@ -9,11 +9,14 @@ ! log stderr logging filter all 1 - logging color 1 - logging print category 1 - logging timestamp 1 logging print extended-timestamp 1 - logging print file 1 + logging print file basename last + logging print category-hex 0 + logging print category 1 + logging print level 1 + logging timestamp 1 + logging color 1 +! logging level set-all notice logging level rll info logging level rsl debug diff --git a/bts/osmo-bts.cfg b/bts/osmo-bts.cfg index 4629180..5609212 100644 --- a/bts/osmo-bts.cfg +++ b/bts/osmo-bts.cfg @@ -8,10 +8,14 @@ ! log stderr logging filter all 1 - logging color 1 - logging print category 1 - logging timestamp 1 logging print extended-timestamp 1 + logging print file basename last + logging print category-hex 0 + logging print category 1 + logging print level 1 + logging timestamp 1 + logging color 1 +! logging level set-all notice logging level rsl info logging level oml info -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0360fa1db2137bf8e68ba87403742e0e8c9c1147 Gerrit-Change-Number: 26523 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 12:59:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 12:59:05 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 ) Change subject: bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg ...................................................................... bsc/osmo-bsc-vamos.cfg: sync logging config with osmo-bsc.cfg Change-Id: I08580e5d8313e644908c1d7b370c5de882f3735c --- M bsc/osmo-bsc-vamos.cfg 1 file changed, 8 insertions(+), 21 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/osmo-bsc-vamos.cfg b/bsc/osmo-bsc-vamos.cfg index 07fb698..9e5d549 100644 --- a/bsc/osmo-bsc-vamos.cfg +++ b/bsc/osmo-bsc-vamos.cfg @@ -5,10 +5,15 @@ ! log stderr logging filter all 1 - logging color 1 - logging print category 1 - logging timestamp 1 logging print extended-timestamp 1 + logging print file basename last + logging print category-hex 0 + logging print category 1 + logging print level 1 + logging timestamp 1 + logging color 1 +! + logging level set-all notice logging level rll notice logging level mm notice logging level rr notice @@ -22,24 +27,6 @@ logging level ctrl notice logging level filter debug logging level pcu debug - logging level lglobal notice - logging level llapd notice - logging level linp notice - logging level lmux notice - logging level lmi notice - logging level lmib notice - logging level lsms notice - logging level lctrl notice - logging level lgtp notice - logging level lstats notice - logging level lgsup notice - logging level loap notice - logging level lss7 notice - logging level lsccp notice - logging level lsua notice - logging level lm3ua notice - logging level lmgcp notice - logging level reset notice ! stats interval 0 stats reporter statsd -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26537 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I08580e5d8313e644908c1d7b370c5de882f3735c Gerrit-Change-Number: 26537 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 13:00:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 13:00:51 +0000 Subject: Change in osmo-dev[master]: Add tmux scripts for ttcn3-{msc, bsc, bts}-test In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26485 ) Change subject: Add tmux scripts for ttcn3-{msc,bsc,bts}-test ...................................................................... Patch Set 3: Code-Review+1 not an osmo-dev user, but LGTM -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 Gerrit-Change-Number: 26485 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 13:00:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 13:01:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 13:01:16 +0000 Subject: Change in docker-playground[master]: hnodeb: Update Dockerfile, configs with new deps, configs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26544 ) Change subject: hnodeb: Update Dockerfile, configs with new deps, configs ...................................................................... Patch Set 1: the question is whether the gtp dependency will actually materialize... -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5b223149cbbea16e4ccd9b3874874c6366fe7969 Gerrit-Change-Number: 26544 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 14 Dec 2021 13:01:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 13:01:34 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 13:01:34 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test/osmo-bts.cfg: use default {fn, rts}-advance values In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26529 ) Change subject: ttcn3-bts-test/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If8438adfdbc506d2b6b7858ea8a0ea859ba246a1 Gerrit-Change-Number: 26529 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 14 Dec 2021 13:01:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 13:01:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 13:01:36 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test/osmo-bts.cfg: use default {fn, rts}-advance values In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26529 ) Change subject: ttcn3-bts-test/osmo-bts.cfg: use default {fn,rts}-advance values ...................................................................... ttcn3-bts-test/osmo-bts.cfg: use default {fn,rts}-advance values It's better if we run ttcn3-bts-test with the default values, given that they were significantly reduced some time ago. Change-Id: If8438adfdbc506d2b6b7858ea8a0ea859ba246a1 Related: I7da3d0948f38e12342fb714b29f8edc5e9d0933d (osmo-bts) Related: OS#4487 --- M ttcn3-bts-test/osmo-bts.cfg 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve fixeria: Verified diff --git a/ttcn3-bts-test/osmo-bts.cfg b/ttcn3-bts-test/osmo-bts.cfg index 9933a76..bbe8a1d 100644 --- a/ttcn3-bts-test/osmo-bts.cfg +++ b/ttcn3-bts-test/osmo-bts.cfg @@ -34,8 +34,6 @@ phy 0 osmotrx ip local 172.18.9.20 osmotrx ip remote 172.18.9.21 - osmotrx fn-advance 20 - osmotrx rts-advance 5 instance 0 osmotrx rx-gain 10 instance 1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If8438adfdbc506d2b6b7858ea8a0ea859ba246a1 Gerrit-Change-Number: 26529 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 13:13:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 14 Dec 2021 13:13:26 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 ) Change subject: First implementation of the LLSK gtp SAPI ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c File src/osmo-hnodeb/gtp.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503/2/src/osmo-hnodeb/gtp.c at 126 PS2, Line 126: } : : osmo_fd_setup(&hnb->gtp.fd0, gsn->fd0, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0); : if ((rc = osmo_fd_register(&hnb->gtp.fd0)) < 0) : goto free_ret; : : osmo_fd_setup(&hnb->gtp.fd1c, gsn->fd1c, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 1); : if ((rc = osmo_fd_register(&hnb->gtp.fd1c)) < 0) : goto free_ret; : : osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 2); : if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0) > ACK about those. [?] The point is that libgtp is written for a GSN, and a hNB (nor an eNB or gNB) is no GSN. So there may be a lot of assumptions/baggage in libgtp which has no significance/relevance here, and which may actually bite us back later on. I at lest would be afraid about this. 90% of the code is not applicable, and half of the struct members will not be filled in as usual, as there is no control plane, nsapi, ... Also in terms of future regressions, when somebody makes a change in libgtp (intended for a GSN) but then without thinking of this somewhat unexpected use case. If you want to continue the libgtp route, for sure there should definitely be no sockets for v0 or v1c, and we should never pass any data to gtp_decaps{0,1c}. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 14 Dec 2021 13:13:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 13:22:04 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 13:22:04 +0000 Subject: Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: new job In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26480 ) Change subject: jobs/octsim_osmo-ccid-firmware: new job ...................................................................... jobs/octsim_osmo-ccid-firmware: new job Import the existing (non jenkins-job-builder) job with jenkins-job-wrecker. Change it to fetch the git repository, add missing mkdir so it works with a fresh workspace too. Fixes: SYS#5738 Change-Id: I19d18b24a6ae5948aeaf7c46083748c70cdb3b7b --- A jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 55 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml new file mode 100644 index 0000000..311be33 --- /dev/null +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -0,0 +1,55 @@ +- job: + axes: + - axis: + name: label + type: slave + values: + - octsimtest + block-downstream: false + block-upstream: false + builders: + - shell: | + cd ./tests + mkdir -p sysmo-octsim/dl + ./run-tests + concurrent: false + description: octsim osmo-ccid-firmware CI - flash every build to octsim and see + if it still works + disabled: false + execution-strategy: + sequential: false + name: octsim_osmo-ccid-firmware + project-type: matrix + scm: + - git: + url: git://git.osmocom.org/osmo-ccid-firmware + git-config-name: 'Jenkins Builder' + git-config-email: 'jenkins at osmocom.org' + skip-tag: true + branches: + - 'origin/master' + properties: + - build-blocker: + block-level: GLOBAL + blocking-jobs: [] + queue-scanning: DISABLED + use-build-blocker: false + - build-discarder: + artifact-days-to-keep: -1 + artifact-num-to-keep: -1 + days-to-keep: 30 + num-to-keep: 120 + - rebuild: + auto-rebuild: false + rebuild-disabled: false + publishers: + - email: + notify-every-unstable-build: true + recipients: jsteiger at sysmocom.de + send-to-individuals: true + retry-count: '3' + triggers: + - reverse: + jobs: master-osmo-ccid-firmware, + - timed: H H * * * + wrappers: [] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I19d18b24a6ae5948aeaf7c46083748c70cdb3b7b Gerrit-Change-Number: 26480 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 14:11:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 14:11:40 +0000 Subject: Change in docker-playground[master]: hnodeb: Update Dockerfile, configs with new deps, configs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26544 ) Change subject: hnodeb: Update Dockerfile, configs with new deps, configs ...................................................................... Patch Set 1: After a call with laforge it was decided we'll keep the libgtp code code for now since it's already working as a first implementation, and we can get it dropped and improved after we have other stuff working, like IuUP RTP. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5b223149cbbea16e4ccd9b3874874c6366fe7969 Gerrit-Change-Number: 26544 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 14 Dec 2021 14:11:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 14:15:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 14:15:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add audio SAPI In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 to look at the new patch set (#5). Change subject: hnodeb: Add audio SAPI ...................................................................... hnodeb: Add audio SAPI Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 4 files changed, 383 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/26444/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 Gerrit-Change-Number: 26444 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 14:33:18 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 14 Dec 2021 14:33:18 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 4: I don't know how to fix this without rewriting everything everwhyere and changing the usual output names due to the way everything inlcuding the gernated build targets work. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Tue, 14 Dec 2021 14:33:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 14:45:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 14:45:31 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK audio SAPI In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 ) Change subject: First implementation of the LLSK audio SAPI ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h File include/osmocom/hnodeb/hnb_prim.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502/2/include/osmocom/hnodeb/hnb_prim.h at 184 PS2, Line 184: uint8_t remote_rtp_address_type; /* enum u_addr_type */ : union u_addr remote_rtp_addr; > ok, fair enough - but then I would try to at least have one definition local to this header file, ra [?] I wanted to avoid having them in a struct, to have a more plain structure where I can control gaps and padding manually, to avoid non-aligned accesses and so on. See in this case for instance, where a spare1 byte is kept to have the u_addr not fall in an even address. So I did this this on purpose and I'm personally fine keeping it this way. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d Gerrit-Change-Number: 26502 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 14 Dec 2021 14:45:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 14:47:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 14:47:47 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 ) Change subject: First implementation of the LLSK gtp SAPI ...................................................................... Patch Set 4: After a call with laforge we agreed to keep it this way for now to have a first implementation already working as a proof of concept, and I'll remove libgtp code and use adhoc code here for GTP-U when I finish IuUP related stuff soon. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 14 Dec 2021 14:47:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 14:49:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 14:49:21 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 to look at the new patch set (#13). Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Initial implementation of LowerLayer UD Socket The LLSK socket is an interface allowing thid-parties to implement and hook their RLC/MAC/RRC stack to osmo-hnodbe, which takes care of interconnection with the rest of the RAN and core network (Iuh, RTP, GTP-U, etc.). Related: SYS#5516 Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d --- A doc/hnodeb.msc M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 19 files changed, 1,083 insertions(+), 40 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/57/26357/13 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 13 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 14:49:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 14:49:21 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 to look at the new patch set (#5). Change subject: First implementation of the LLSK gtp SAPI ...................................................................... First implementation of the LLSK gtp SAPI This first implementation uses libgtp to manage the GTPv1-U socket and pdp contexts, as a proof of concept to have something working for now. At a later step, it is expected to drop libgtp and use some adhoc code to handle GTP-U. Related: SYS#5516 Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 --- M configure.ac M contrib/jenkins.sh M contrib/osmo-hnodeb.spec.in M debian/control M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/gtp.h M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c A src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_gtp.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/vty.c 18 files changed, 696 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/03/26503/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 14:57:20 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 14 Dec 2021 14:57:20 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add audio SAPI In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 ) Change subject: hnodeb: Add audio SAPI ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 Gerrit-Change-Number: 26444 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 14 Dec 2021 14:57:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 17:52:34 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 14 Dec 2021 17:52:34 +0000 Subject: Change in libosmocore[master]: stats: fix typo References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26568 ) Change subject: stats: fix typo ...................................................................... stats: fix typo Change-Id: If978daf8b5e58fd9c0a5ff989088a12abc98886a --- M src/stats.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/68/26568/1 diff --git a/src/stats.c b/src/stats.c index 702e408..94ce3e5 100644 --- a/src/stats.c +++ b/src/stats.c @@ -411,7 +411,7 @@ /*! Set the name prefix of a given stats_reporter. * \param[in] srep stats_reporter whose name prefix is to be set - * \param[in] prefix NAme perfix to pre-pend for any reported value + * \param[in] prefix Name prefix to pre-pend for any reported value * \returns 0 on success; negative on error */ int osmo_stats_reporter_set_name_prefix(struct osmo_stats_reporter *srep, const char *prefix) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26568 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If978daf8b5e58fd9c0a5ff989088a12abc98886a Gerrit-Change-Number: 26568 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 17:52:34 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 14 Dec 2021 17:52:34 +0000 Subject: Change in libosmocore[master]: stat_item: tolerate NULL pointer argument in osmo_stat_item_group_free References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26569 ) Change subject: stat_item: tolerate NULL pointer argument in osmo_stat_item_group_free ...................................................................... stat_item: tolerate NULL pointer argument in osmo_stat_item_group_free Just like rate_ctr_group_free, osmo_stat_item_group_free should tolerate it when the argument is NULL Change-Id: I23323833e7268356a50c4fc6a19639c4ecd2a101 --- M src/stat_item.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/69/26569/1 diff --git a/src/stat_item.c b/src/stat_item.c index 59f5935..667b15f 100644 --- a/src/stat_item.c +++ b/src/stat_item.c @@ -228,6 +228,9 @@ /*! Free the memory for the specified group of stat items */ void osmo_stat_item_group_free(struct osmo_stat_item_group *grp) { + if (!grp) + return; + llist_del(&grp->list); talloc_free(grp); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I23323833e7268356a50c4fc6a19639c4ecd2a101 Gerrit-Change-Number: 26569 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 17:54:59 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 14 Dec 2021 17:54:59 +0000 Subject: Change in libosmocore[master]: select: add member for human readable name to osmo_fd In-Reply-To: References: Message-ID: dexter has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26453 ) Change subject: select: add member for human readable name to osmo_fd ...................................................................... Abandoned There are smarter ways to do this without breaking the ABI. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26453 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I64b288174ae3dd22d50a701ce7cbf9e623246479 Gerrit-Change-Number: 26453 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 17:59:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 17:59:41 +0000 Subject: Change in osmo-hnodeb[master]: Update AUDIO and GTP SAPs to support multiple conns per UE References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 ) Change subject: Update AUDIO and GTP SAPs to support multiple conns per UE ...................................................................... Update AUDIO and GTP SAPs to support multiple conns per UE This is needed for instance: * AUDIO: video calls * GTP: secondary pdp contexts For better abstraction, now both AUDIO and GTP conns use unique ID namespaces, and one ID is used to identify each one. Each conn relate in turn to a UE since a context_id is passed during connection establishment. Related: SYS#5516 Change-Id: Ib3f60d5ba21defe5259c25e2034fc2217c4d93df --- M doc/hnodeb.msc M include/osmocom/hnodeb/gtp.h M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/rtp.h M src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk_audio.c M src/osmo-hnodeb/llsk_gtp.c M src/osmo-hnodeb/rtp.c 11 files changed, 273 insertions(+), 182 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/70/26570/1 diff --git a/doc/hnodeb.msc b/doc/hnodeb.msc index 6ad6e7c..10de180 100644 --- a/doc/hnodeb.msc +++ b/doc/hnodeb.msc @@ -43,19 +43,19 @@ --- [ label = "Subscriber set up PS data:" ]; hnodeb <= hnbgw [label="RANAP RAB-Assignment Request(TEI, ADDR)"]; trx <= hnodeb [label="IUH-CONN_DATA.ind[RANAP RAB-Assignment Request(remote_ip, remote_port, remote_tei)]"]; - trx => hnodeb [label="GTP-CONN_ESTABLISH.req(remote_ip,remote_port,remote_tei)"]; + trx => hnodeb [label="GTP-CONN_ESTABLISH.req(context_id,remote_ip,remote_port,remote_tei)"]; ... [ label = "HnodeB sets up GTP-U connection" ]; - trx <= hnodeb [label="GTP-CONN_ESTABLISH.cnf(local_ip,local_port,local_tei,remote_tei)"]; + trx <= hnodeb [label="GTP-CONN_ESTABLISH.cnf(context_id,gtp_conn_id,local_ip,local_port,local_tei)"]; |||; ...; |||; |||; --- [ label = "PS data transmission over GTP-U:" ]; ue => trx [label="..."]; - trx => hnodeb [label="GTP-CONN_DATA.req[remote_tei,payload]"]; + trx => hnodeb [label="GTP-CONN_DATA.req[gtp_conn_id,payload]"]; hnodeb => ggsn [label="GTP-U(remote_tei, local_addr, remote_addr, payload)"]; hnodeb <= ggsn [label="GTP-U(local_tei, remote_addr, local_addr, payload)"]; - trx <= hnodeb [label="GTP-CONN_DATA.ind[local_tei,payload]"]; + trx <= hnodeb [label="GTP-CONN_DATA.ind[gtp_conn_id,payload]"]; ue <= trx [label="..."]; |||; ...; @@ -67,7 +67,7 @@ hnodeb <= hnbgw [label="RANAP IU Release Command"]; trx <= hnodeb [label="IUH-CONN_DATA.ind[RANAP IU Release Command]"]; ...; - trx => hnodeb [label="GTP-CONN_RELEASE.req(remote_tei)"]; + trx => hnodeb [label="GTP-CONN_RELEASE.req(gtp_conn_id)"]; trx => hnodeb [label="IUH-CONN_RELEASE.req[RANAP IU Release Complete]"]; hnodeb => hnbgw [label="RUA-Disconnect(RANAP IU Release Complete)"]; diff --git a/include/osmocom/hnodeb/gtp.h b/include/osmocom/hnodeb/gtp.h index af9e007..477e82b 100644 --- a/include/osmocom/hnodeb/gtp.h +++ b/include/osmocom/hnodeb/gtp.h @@ -18,7 +18,11 @@ */ #pragma once +#include +#include + #include +#include struct hnb; struct hnb_ue; @@ -26,7 +30,19 @@ int hnb_gtp_bind(struct hnb *hnb); void hnb_gtp_unbind(struct hnb *hnb); -int hnb_ue_gtp_bind(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei, - struct osmo_sockaddr *loc_addr, uint32_t *loc_tei); -int hnb_ue_gtp_unbind(struct hnb_ue *ue); -int hnb_ue_gtp_tx(struct hnb_ue *ue, void *gtpu_payload, unsigned gtpu_payload_len); +struct gtp_conn { + struct llist_head list; /* Item in struct hnb->ue_list */ + struct hnb_ue *ue; /* backpointer */ + uint32_t id; + struct osmo_sockaddr loc_addr; + struct osmo_sockaddr rem_addr; + uint32_t loc_tei; + uint32_t rem_tei; + struct pdp_t *pdp_lib; +}; + +struct gtp_conn *gtp_conn_alloc(struct hnb_ue *ue); +void gtp_conn_free(struct gtp_conn *conn); + +int gtp_conn_setup(struct gtp_conn *conn, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei); +int gtp_conn_tx(struct gtp_conn *conn, void *gtpu_payload, unsigned gtpu_payload_len); diff --git a/include/osmocom/hnodeb/hnb_prim.h b/include/osmocom/hnodeb/hnb_prim.h index f0e3a96..0b0a545 100644 --- a/include/osmocom/hnodeb/hnb_prim.h +++ b/include/osmocom/hnodeb/hnb_prim.h @@ -197,6 +197,7 @@ /* HNB_AUDIO_PRIM_CONN_ESTABLISH, DL */ struct hnb_audio_conn_establish_cnf_param { uint32_t context_id; + uint32_t audio_conn_id; uint16_t local_rtp_port; uint8_t error_code; /* 0 = success, !0 = failure */ uint8_t local_rtp_address_type; /* enum u_addr_type */ @@ -205,19 +206,19 @@ /* HNB_AUDIO_PRIM_CONN_RELEASE, UL */ struct hnb_audio_conn_release_req_param { - uint32_t context_id; + uint32_t audio_conn_id; } __attribute__ ((packed)); /* HNB_AUDIO_PRIM_CONN_DATA, UL */ struct hnb_audio_conn_data_req_param { - uint32_t context_id; + uint32_t audio_conn_id; uint32_t data_len; /* RTP payload length in bytes */ uint8_t data[0]; /* RTP payload (aka IP packet) */ } __attribute__ ((packed)); /* HNB_AUDIO_PRIM_CONN_DATA, DL */ struct hnb_audio_conn_data_ind_param { - uint32_t context_id; + uint32_t audio_conn_id; uint32_t data_len; /* RTP payload length in bytes */ uint8_t data[0]; /* RTP payload (aka IP packet) */ } __attribute__ ((packed)); @@ -256,6 +257,7 @@ /* HNB_GTP_PRIM_CONN_ESTABLISH, DL */ struct hnb_gtp_conn_establish_cnf_param { uint32_t context_id; + uint32_t gtp_conn_id; uint32_t local_tei; uint8_t error_code; /* 0 = success, !0 = failure */ uint8_t local_gtpu_address_type; /* enum u_addr_type */ @@ -264,28 +266,19 @@ /* HNB_GTP_PRIM_CONN_RELEASE, UL */ struct hnb_gtp_conn_release_req_param { - uint32_t context_id; - uint32_t remote_tei; -} __attribute__ ((packed)); - -/* HNB_GTP_PRIM_CONN_RELEASE, DL */ -struct hnb_gtp_conn_release_ind_param { - uint32_t context_id; - uint32_t local_tei; + uint32_t gtp_conn_id; } __attribute__ ((packed)); /* HNB_GTP_PRIM_CONN_DATA, DL */ struct hnb_gtp_conn_data_ind_param { - uint32_t context_id; - uint32_t local_tei; + uint32_t gtp_conn_id; uint32_t data_len; /* GTP-U payload length in bytes */ uint8_t data[0]; /* GTP-U payload (aka IP packet) */ } __attribute__ ((packed)); /* HNB_GTP_PRIM_CONN_DATA, UL */ struct hnb_gtp_conn_data_req_param { - uint32_t context_id; - uint32_t remote_tei; + uint32_t gtp_conn_id; uint32_t data_len; /* GTP-U payload length in bytes */ uint8_t data[0]; /* GTP-U payload (aka IP packet) */ } __attribute__ ((packed)); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 52d1bec..82b43c3 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -35,9 +35,6 @@ #include #include -#include -#include - #include enum { @@ -62,16 +59,12 @@ struct hnb_ue_cs_ctx { bool active; /* Is this chan in use? */ bool conn_est_cnf_pending; /* Did we send CONN_ESTABLISH_CNF to lower layers? */ - struct { - struct osmo_rtp_socket *socket; - } rtp; + struct llist_head conn_list; /* list of struct rtp_conn */ } conn_cs; struct hnb_ue_ps_ctx { bool active; /* Is this chan in use? */ bool conn_est_cnf_pending; /* Did we send CONN_ESTABLISH_CNF to lower layers? */ - uint32_t local_tei; - uint32_t remote_tei; - struct pdp_t *pdp_lib; + struct llist_head conn_list; /* list of struct gtp_conn */ } conn_ps; }; struct hnb_ue *hnb_ue_alloc(struct hnb *hnb, uint32_t conn_id); @@ -132,9 +125,11 @@ struct hnb *hnb_alloc(void *tall_ctx); void hnb_free(struct hnb *hnb); struct hnb_ue *hnb_find_ue_by_id(const struct hnb *hnb, uint32_t conn_id); -struct hnb_ue *hnb_find_ue_by_tei(const struct hnb *hnb, uint32_t tei, bool is_remote); struct hnb_ue *hnb_find_ue_by_imsi(const struct hnb *hnb, char *imsi); +struct rtp_conn *hnb_find_rtp_conn_by_id(const struct hnb *hnb, uint32_t audio_conn_id); +struct gtp_conn *hnb_find_gtp_conn_by_id(const struct hnb *hnb, uint32_t gtp_conn_id); + extern void *tall_hnb_ctx; extern struct hnb *g_hnb; diff --git a/include/osmocom/hnodeb/llsk.h b/include/osmocom/hnodeb/llsk.h index 6d98cd0..fe1dce1 100644 --- a/include/osmocom/hnodeb/llsk.h +++ b/include/osmocom/hnodeb/llsk.h @@ -27,7 +27,7 @@ #include struct hnb; -struct hnb_ue; +struct rtp_conn; int hnb_llsk_alloc(struct hnb *hnb); bool hnb_llsk_connected(const struct hnb *hnb); @@ -53,9 +53,8 @@ extern const struct value_string hnb_audio_prim_type_names[]; int llsk_rx_audio(struct hnb *hnb, struct osmo_prim_hdr *oph); -int llsk_audio_tx_conn_data_ind(struct hnb_ue *ue, const uint8_t *payload, uint32_t len); +int llsk_audio_tx_conn_data_ind(struct rtp_conn *conn, const uint8_t *payload, uint32_t len); extern const struct value_string hnb_gtp_prim_type_names[]; int llsk_rx_gtp(struct hnb *hnb, struct osmo_prim_hdr *oph); -struct hnb_gtp_prim *hnb_gtp_makeprim_conn_data_ind(uint32_t context_id, uint32_t local_tei, - const uint8_t *data, uint32_t data_len); +struct hnb_gtp_prim *hnb_gtp_makeprim_conn_data_ind(uint32_t gtp_conn_id, const uint8_t *data, uint32_t data_len); diff --git a/include/osmocom/hnodeb/rtp.h b/include/osmocom/hnodeb/rtp.h index 01ec1c4..8035175 100644 --- a/include/osmocom/hnodeb/rtp.h +++ b/include/osmocom/hnodeb/rtp.h @@ -19,9 +19,21 @@ #pragma once #include +#include struct hnb; struct hnb_ue; -int hnb_ue_voicecall_setup(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, struct osmo_sockaddr *loc_addr); -int hnb_ue_voicecall_release(struct hnb_ue *ue); +struct rtp_conn { + struct llist_head list; /* Item in struct hnb->ue_list */ + struct hnb_ue *ue; /* backpointer */ + uint32_t id; + struct osmo_rtp_socket *socket; + struct osmo_sockaddr loc_addr; + struct osmo_sockaddr rem_addr; +}; + +struct rtp_conn *rtp_conn_alloc(struct hnb_ue *ue); +void rtp_conn_free(struct rtp_conn *conn); + +int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr); diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c index 4695ea9..c26efa5 100644 --- a/src/osmo-hnodeb/gtp.c +++ b/src/osmo-hnodeb/gtp.c @@ -27,8 +27,38 @@ #include #include +static uint32_t next_gtp_conn_id = 0; + +struct gtp_conn *gtp_conn_alloc(struct hnb_ue *ue) +{ + struct gtp_conn *conn; + + conn = talloc_zero(ue, struct gtp_conn); + if (!conn) + return NULL; + + conn->ue = ue; + + llist_add(&conn->list, &ue->conn_ps.conn_list); + + return conn; +} + +void gtp_conn_free(struct gtp_conn *conn) +{ + if (!conn) + return; + + if (conn->pdp_lib) { + pdp_freepdp(conn->pdp_lib); + conn->pdp_lib = NULL; + } + llist_del(&conn->list); + talloc_free(conn); +} + /* Get osa of locally bound GTP-U socket */ -int sk_get_bound_addr(int fd, struct osmo_sockaddr *osa) +static int sk_get_bound_addr(int fd, struct osmo_sockaddr *osa) { int rc; socklen_t alen = sizeof(*osa); @@ -44,18 +74,22 @@ static int hnb_gtp_cb_data_ind(struct pdp_t *lib, void *packet, unsigned int len) { struct hnb_gtp_prim *gtp_prim; - struct hnb_ue *ue = lib->priv; - struct hnb *hnb = ue->hnb; + struct gtp_conn *conn = lib->priv; + struct hnb_ue *ue; + struct hnb *hnb; int rc; - if (!ue || !ue->conn_ps.active) { - LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", + if (!conn || !conn->ue->conn_ps.active) { + LOGUE(conn->ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", packet, len); return -EINVAL; } + ue = conn->ue; + hnb = ue->hnb; + LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len); - gtp_prim = hnb_gtp_makeprim_conn_data_ind(ue->conn_id, ue->conn_ps.local_tei, packet, len); + gtp_prim = hnb_gtp_makeprim_conn_data_ind(conn->id, packet, len); if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { LOGUE(ue, DGTP, LOGL_ERROR, "Failed Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len); @@ -129,10 +163,10 @@ hnb->gtp.fd1u.fd = -1; } -int hnb_ue_gtp_bind(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei, - struct osmo_sockaddr *loc_addr, uint32_t *loc_tei) +int gtp_conn_setup(struct gtp_conn *conn, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei) { int rc; + struct hnb_ue *ue = conn->ue; struct hnb *hnb = ue->hnb; struct pdp_t *pdp; struct in_addr rem_in; @@ -146,15 +180,18 @@ return -ENOTSUP; } + conn->rem_addr = *rem_addr; + conn->rem_tei = rem_tei; rem_in = rem_addr->u.sin.sin_addr; + conn->id = next_gtp_conn_id++; /* TODO: validate next one is not already taken due to wrap-around */ - rc = gtp_pdp_newpdp(hnb->gtp.gsn, &pdp, ue->conn_id, 0 /* TODO: NSAPI? */, NULL); + rc = gtp_pdp_newpdp(hnb->gtp.gsn, &pdp, conn->id, 0 /* TODO: NSAPI? */, NULL); if (rc < 0) { LOGUE(ue, DGTP, LOGL_ERROR, "Failed creating PDP context: %s\n", strerror(-rc)); return rc; } - pdp->priv = ue; - ue->conn_ps.pdp_lib = pdp; + pdp->priv = conn; + conn->pdp_lib = pdp; pdp->teid_gn = rem_tei; pdp->version = 1; @@ -169,39 +206,32 @@ memcpy(pdp->gsnlu.v, &hnb->gtp.local_addr.u.sin.sin_addr, sizeof(hnb->gtp.local_addr.u.sin.sin_addr)); - *loc_addr = hnb->gtp.local_addr; + conn->loc_addr = hnb->gtp.local_addr; //loc_addr->u.sin.sin_family = AF_INET; //loc_addr->u.sin.sin_addr = hnb->gtp.gsn->gsnu; //loc_addr->u.sin.sin_port = GTP1U_PORT; - *loc_tei = pdp->teid_own; + conn->loc_tei = pdp->teid_own; return 0; } -int hnb_ue_gtp_tx(struct hnb_ue *ue, void *gtpu_payload, unsigned gtpu_payload_len) +int gtp_conn_tx(struct gtp_conn *conn, void *gtpu_payload, unsigned gtpu_payload_len) { int rc; - struct hnb *hnb = ue->hnb; + struct hnb_ue *ue; + struct hnb *hnb; + if (!conn || !conn->pdp_lib) { + LOGP(DGTP, LOGL_ERROR, "Tx: PDP Ctx not available\n"); + return -EINVAL; + } + + ue = conn->ue; + hnb = ue->hnb; if (!hnb->gtp.gsn) { LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n"); return -EINVAL; } - if (!ue || !ue->conn_ps.pdp_lib) { - LOGUE(ue, DGTP, LOGL_ERROR, "Tx: UE PDP Ctx not available\n"); - return -EINVAL; - } - - rc = gtp_data_req(hnb->gtp.gsn, ue->conn_ps.pdp_lib, gtpu_payload, gtpu_payload_len); + rc = gtp_data_req(hnb->gtp.gsn, conn->pdp_lib, gtpu_payload, gtpu_payload_len); return rc; } - -int hnb_ue_gtp_unbind(struct hnb_ue *ue) -{ - if (!ue->conn_ps.pdp_lib) - return -EINVAL; - - pdp_freepdp(ue->conn_ps.pdp_lib); - ue->conn_ps.pdp_lib = NULL; - return 0; -} diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index b733d15..fe2f4f5 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -109,6 +109,9 @@ ue->hnb = hnb; ue->conn_id = conn_id; + INIT_LLIST_HEAD(&ue->conn_cs.conn_list); + INIT_LLIST_HEAD(&ue->conn_ps.conn_list); + llist_add(&ue->list, &hnb->ue_list); return ue; @@ -125,11 +128,17 @@ void hnb_ue_reset_chan(struct hnb_ue *ue, bool is_ps) { if (is_ps) { - hnb_ue_gtp_unbind(ue); + struct gtp_conn *conn, *conn_tmp; + llist_for_each_entry_safe(conn, conn_tmp, &ue->conn_ps.conn_list, list) + gtp_conn_free(conn); ue->conn_ps = (struct hnb_ue_ps_ctx){0}; + INIT_LLIST_HEAD(&ue->conn_ps.conn_list); } else { - hnb_ue_voicecall_release(ue); + struct rtp_conn *conn, *conn_tmp; + llist_for_each_entry_safe(conn, conn_tmp, &ue->conn_cs.conn_list, list) + rtp_conn_free(conn); ue->conn_cs = (struct hnb_ue_cs_ctx){0}; + INIT_LLIST_HEAD(&ue->conn_cs.conn_list); } } @@ -145,21 +154,6 @@ return NULL; } -struct hnb_ue *hnb_find_ue_by_tei(const struct hnb *hnb, uint32_t tei, bool is_remote) -{ - struct hnb_ue *ue; - - llist_for_each_entry(ue, &hnb->ue_list, list) { - if (!ue->conn_ps.active) - continue; - uint32_t ue_tei = is_remote ? ue->conn_ps.remote_tei : ue->conn_ps.local_tei; - if (tei != ue_tei) - continue; - return ue; - } - return NULL; -} - struct hnb_ue *hnb_find_ue_by_imsi(const struct hnb *hnb, char *imsi) { struct hnb_ue *ue; @@ -176,3 +170,35 @@ } return NULL; } + +struct rtp_conn *hnb_find_rtp_conn_by_id(const struct hnb *hnb, uint32_t audio_conn_id) +{ + struct hnb_ue *ue; + + llist_for_each_entry(ue, &hnb->ue_list, list) { + struct rtp_conn *conn; + if (!ue->conn_cs.active) + continue; + llist_for_each_entry(conn, &ue->conn_cs.conn_list, list) { + if (conn->id == audio_conn_id) + return conn; + } + } + return NULL; +} + +struct gtp_conn *hnb_find_gtp_conn_by_id(const struct hnb *hnb, uint32_t gtp_conn_id) +{ + struct hnb_ue *ue; + + llist_for_each_entry(ue, &hnb->ue_list, list) { + struct gtp_conn *conn; + if (!ue->conn_ps.active) + continue; + llist_for_each_entry(conn, &ue->conn_ps.conn_list, list) { + if (conn->id == gtp_conn_id) + return conn; + } + } + return NULL; +} diff --git a/src/osmo-hnodeb/llsk_audio.c b/src/osmo-hnodeb/llsk_audio.c index 4fa8079..7ce5c09 100644 --- a/src/osmo-hnodeb/llsk_audio.c +++ b/src/osmo-hnodeb/llsk_audio.c @@ -81,14 +81,16 @@ return (struct hnb_audio_prim *)oph; } -static struct hnb_audio_prim *hnb_audio_makeprim_conn_establish_cnf(uint32_t context_id, uint8_t error_code, - uint16_t local_rtp_port, uint8_t local_rtp_address_type, - const union u_addr *local_rtp_addr) +static struct hnb_audio_prim *hnb_audio_makeprim_conn_establish_cnf(uint32_t context_id, uint32_t audio_conn_id, + uint8_t error_code, uint16_t local_rtp_port, + uint8_t local_rtp_address_type, + const union u_addr *local_rtp_addr) { struct hnb_audio_prim *audio_prim; audio_prim = hnb_audio_prim_alloc(HNB_AUDIO_PRIM_CONN_ESTABLISH, PRIM_OP_CONFIRM, 0); audio_prim->u.conn_establish_cnf.context_id = context_id; + audio_prim->u.conn_establish_cnf.audio_conn_id = audio_conn_id; audio_prim->u.conn_establish_cnf.local_rtp_port = local_rtp_port; audio_prim->u.conn_establish_cnf.error_code = error_code; audio_prim->u.conn_establish_cnf.local_rtp_address_type = local_rtp_address_type; @@ -98,15 +100,14 @@ return audio_prim; } -static struct hnb_audio_prim *hnb_audio_makeprim_conn_data_ind(uint32_t context_id, - uint8_t domain, +static struct hnb_audio_prim *hnb_audio_makeprim_conn_data_ind(uint32_t audio_conn_id, const uint8_t *data, uint32_t data_len) { struct hnb_audio_prim *audio_prim; audio_prim = hnb_audio_prim_alloc(HNB_AUDIO_PRIM_CONN_DATA, PRIM_OP_INDICATION, data_len); - audio_prim->u.conn_data_ind.context_id = context_id; + audio_prim->u.conn_data_ind.audio_conn_id = audio_conn_id; audio_prim->u.conn_data_ind.data_len = data_len; if (data_len) { msgb_put(audio_prim->hdr.msg, data_len); @@ -116,15 +117,15 @@ return audio_prim; } -int llsk_audio_tx_conn_data_ind(struct hnb_ue *ue, const uint8_t *payload, uint32_t len) +int llsk_audio_tx_conn_data_ind(struct rtp_conn *conn, const uint8_t *payload, uint32_t len) { struct hnb_audio_prim *audio_prim; int rc; - LOGUE(ue, DLLSK, LOGL_INFO, "Tx AUDIO-CONN_DATA.ind\n"); - audio_prim = hnb_audio_makeprim_conn_data_ind(ue->conn_id, 0 /* CS */, payload, len); - if ((rc = osmo_prim_srv_send(ue->hnb->llsk, audio_prim->hdr.msg)) < 0) - LOGUE(ue, DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_DATA.ind\n"); + LOGUE(conn->ue, DLLSK, LOGL_INFO, "Tx AUDIO-CONN_DATA.ind\n"); + audio_prim = hnb_audio_makeprim_conn_data_ind(conn->id, payload, len); + if ((rc = osmo_prim_srv_send(conn->ue->hnb->llsk, audio_prim->hdr.msg)) < 0) + LOGUE(conn->ue, DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_DATA.ind\n"); return rc; } @@ -134,7 +135,7 @@ int rc; LOGP(DLLSK, LOGL_ERROR, "Tx AUDIO-CONN_ESTABLISH.cnf: ctx=%u error_code=%u\n", context_id, error_code); - audio_prim = hnb_audio_makeprim_conn_establish_cnf(context_id, error_code, 0, HNB_PRIM_ADDR_TYPE_UNSPEC, NULL); + audio_prim = hnb_audio_makeprim_conn_establish_cnf(context_id, 0, error_code, 0, HNB_PRIM_ADDR_TYPE_UNSPEC, NULL); if ((rc = osmo_prim_srv_send(hnb->llsk, audio_prim->hdr.msg)) < 0) { LOGP(DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_ESTABLISH.cnf context_id=%u error_code=%u\n", context_id, error_code); @@ -150,9 +151,9 @@ int af; char rem_addrstr[INET6_ADDRSTRLEN+32]; struct osmo_sockaddr rem_osa = {0}; - struct osmo_sockaddr loc_osa = {0}; union u_addr loc_uaddr = {0}; uint16_t loc_port; + struct rtp_conn *conn = NULL; rc = ll_addr2osa(ce_req->remote_rtp_address_type, &ce_req->remote_rtp_addr, ce_req->remote_rtp_port, &rem_osa); if (rc < 0) { @@ -184,14 +185,15 @@ } /* Create the socket: */ - if ((rc = hnb_ue_voicecall_setup(ue, &rem_osa, &loc_osa)) < 0) { + conn = rtp_conn_alloc(ue); + if ((rc = rtp_conn_setup(conn, &rem_osa)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: Failed to set up audio socket rem_addr=%s\n", rem_addrstr); return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); } /* Convert resulting local address back to LLSK format: */ - if (osa2_ll_addr(&loc_osa, &loc_uaddr, &loc_port) != ce_req->remote_rtp_address_type) { + if (osa2_ll_addr(&conn->loc_addr, &loc_uaddr, &loc_port) != ce_req->remote_rtp_address_type) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: Failed to provide proper local address rem_addr=%s\n", rem_addrstr); rc = _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); @@ -200,8 +202,8 @@ /* Submit successful confirmation */ LOGUE(ue, DLLSK, LOGL_INFO, "Tx AUDIO-CONN_ESTABLISH.cnf: error_code=0 rem_addr=%s loc_addr=%s\n", - rem_addrstr, osmo_sockaddr_to_str(&loc_osa)); - audio_prim = hnb_audio_makeprim_conn_establish_cnf(ce_req->context_id, 0, loc_port, + rem_addrstr, osmo_sockaddr_to_str(&conn->loc_addr)); + audio_prim = hnb_audio_makeprim_conn_establish_cnf(ce_req->context_id, conn->id, 0, loc_port, ce_req->remote_rtp_address_type, &loc_uaddr); if ((rc = osmo_prim_srv_send(hnb->llsk, audio_prim->hdr.msg)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_ESTABLISH.cnf error_code=0\n"); @@ -210,47 +212,49 @@ return rc; release_sock: - hnb_ue_voicecall_release(ue); + rtp_conn_free(conn); return rc; } static int llsk_rx_audio_conn_release_req(struct hnb *hnb, struct hnb_audio_conn_release_req_param *rel_req) { - struct hnb_ue *ue; + struct rtp_conn *conn; - LOGP(DLLSK, LOGL_DEBUG, "Rx AUDIO-CONN_RELEASE.req ctx=%u\n", rel_req->context_id); + LOGP(DLLSK, LOGL_DEBUG, "Rx AUDIO-CONN_RELEASE.req id=%u\n", rel_req->audio_conn_id); - ue = hnb_find_ue_by_id(hnb, rel_req->context_id); - if (!ue) { - LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_RELEASE.req: UE not found! ctx=%u\n", - rel_req->context_id); + conn = hnb_find_rtp_conn_by_id(hnb, rel_req->audio_conn_id); + if (!conn) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_RELEASE.req: RTP conn not found! id=%u\n", + rel_req->audio_conn_id); return -EINVAL; } /* Release RTP socket: */ - return hnb_ue_voicecall_release(ue); + rtp_conn_free(conn); + return 0; } static int llsk_rx_audio_conn_data_req(struct hnb *hnb, struct hnb_audio_conn_data_req_param *data_req) { - struct hnb_ue *ue; + struct rtp_conn *conn; int rc = 0; - LOGP(DLLSK, LOGL_DEBUG, "Rx AUDIO-CONN_DATA.req ctx=%u data_len=%u\n", - data_req->context_id, data_req->data_len); + LOGP(DLLSK, LOGL_DEBUG, "Rx AUDIO-CONN_DATA.req id=%u data_len=%u\n", + data_req->audio_conn_id, data_req->data_len); - ue = hnb_find_ue_by_id(hnb, data_req->context_id); - if (!ue) { - LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_DATA.req: UE not found! ctx=%u data_len=%u\n", - data_req->context_id, data_req->data_len); + conn = hnb_find_rtp_conn_by_id(hnb, data_req->audio_conn_id); + if (!conn) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_DATA.req: RTP conn not found! id=%u data_len=%u\n", + data_req->audio_conn_id, data_req->data_len); return -EINVAL; } /* TODO: transmit data_req->data through RTP/Iu-UP socket */ - rc = osmo_rtp_send_frame_ext(ue->conn_cs.rtp.socket, data_req->data, + rc = osmo_rtp_send_frame_ext(conn->socket, data_req->data, data_req->data_len, GSM_RTP_DURATION, false); if (rc < 0) { - LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_DATA.req: UE not found! ctx=%u data_len=%u\n", - data_req->context_id, data_req->data_len); + LOGUE(conn->ue, DLLSK, LOGL_ERROR, + "Rx AUDIO-CONN_DATA.req: Failed sending RTP frame! id=%u data_len=%u\n", + data_req->audio_conn_id, data_req->data_len); } return rc; } diff --git a/src/osmo-hnodeb/llsk_gtp.c b/src/osmo-hnodeb/llsk_gtp.c index e75c497..30451a0 100644 --- a/src/osmo-hnodeb/llsk_gtp.c +++ b/src/osmo-hnodeb/llsk_gtp.c @@ -79,14 +79,16 @@ return (struct hnb_gtp_prim *)oph; } -static struct hnb_gtp_prim *hnb_gtp_makeprim_conn_establish_cnf(uint32_t context_id, uint8_t error_code, - uint32_t local_tei, uint8_t local_gtpu_address_type, +static struct hnb_gtp_prim *hnb_gtp_makeprim_conn_establish_cnf(uint32_t context_id, uint32_t gtp_conn_id, + uint8_t error_code, uint32_t local_tei, + uint8_t local_gtpu_address_type, const union u_addr *local_gtpu_addr) { struct hnb_gtp_prim *gtp_prim; gtp_prim = hnb_gtp_prim_alloc(HNB_GTP_PRIM_CONN_ESTABLISH, PRIM_OP_CONFIRM, 0); gtp_prim->u.conn_establish_cnf.context_id = context_id; + gtp_prim->u.conn_establish_cnf.gtp_conn_id = gtp_conn_id; gtp_prim->u.conn_establish_cnf.local_tei = local_tei; gtp_prim->u.conn_establish_cnf.error_code = error_code; gtp_prim->u.conn_establish_cnf.local_gtpu_address_type = local_gtpu_address_type; @@ -96,14 +98,12 @@ return gtp_prim; } -struct hnb_gtp_prim *hnb_gtp_makeprim_conn_data_ind(uint32_t context_id, uint32_t local_tei, - const uint8_t *data, uint32_t data_len) +struct hnb_gtp_prim *hnb_gtp_makeprim_conn_data_ind(uint32_t gtp_conn_id, const uint8_t *data, uint32_t data_len) { struct hnb_gtp_prim *gtp_prim; gtp_prim = hnb_gtp_prim_alloc(HNB_GTP_PRIM_CONN_DATA, PRIM_OP_INDICATION, data_len); - gtp_prim->u.conn_data_ind.context_id = context_id; - gtp_prim->u.conn_data_ind.local_tei = local_tei; + gtp_prim->u.conn_data_ind.gtp_conn_id = gtp_conn_id; gtp_prim->u.conn_data_ind.data_len = data_len; if (data_len) { msgb_put(gtp_prim->hdr.msg, data_len); @@ -119,7 +119,7 @@ int rc; LOGP(DLLSK, LOGL_ERROR, "Tx GTP-CONN_ESTABLISH.cnf: ctx=%u error_code=%u\n", context_id, error_code); - gtp_prim = hnb_gtp_makeprim_conn_establish_cnf(context_id, error_code, 0, HNB_PRIM_ADDR_TYPE_UNSPEC, NULL); + gtp_prim = hnb_gtp_makeprim_conn_establish_cnf(context_id, 0, error_code, 0, HNB_PRIM_ADDR_TYPE_UNSPEC, NULL); if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { LOGP(DLLSK, LOGL_ERROR, "Failed sending GTP-CONN_ESTABLISH.cnf context_id=%u error_code=%u\n", context_id, error_code); @@ -135,9 +135,8 @@ int af; char rem_addrstr[INET6_ADDRSTRLEN+32]; struct osmo_sockaddr rem_osa = {0}; - struct osmo_sockaddr loc_osa = {0}; union u_addr loc_uaddr = {0}; - uint32_t loc_tei; + struct gtp_conn *conn = NULL; rc = ll_addr2osa(ce_req->remote_gtpu_address_type, &ce_req->remote_gtpu_addr, GTP1U_PORT, &rem_osa); if (rc < 0) { @@ -169,14 +168,15 @@ } /* Create the socket: */ - if ((rc = hnb_ue_gtp_bind(ue, &rem_osa, ce_req->remote_tei, &loc_osa, &loc_tei)) < 0) { + conn = gtp_conn_alloc(ue); + if ((rc = gtp_conn_setup(conn, &rem_osa, ce_req->remote_tei)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: Failed to set up gtp socket rem_tei=%u rem_addr=%s\n", ce_req->remote_tei, rem_addrstr); return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); } /* Convert resulting local address back to LLSK format: */ - if (osa2_ll_addr(&loc_osa, &loc_uaddr, NULL) != ce_req->remote_gtpu_address_type) { + if (osa2_ll_addr(&conn->loc_addr, &loc_uaddr, NULL) != ce_req->remote_gtpu_address_type) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: Failed to provide proper local address rem_addr=%s\n", rem_addrstr); rc = _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); @@ -185,56 +185,53 @@ /* Submit successful confirmation */ LOGUE(ue, DLLSK, LOGL_INFO, "Tx GTP-CONN_ESTABLISH.cnf: error_code=0 rem_addr=%s rem_tei=%u loc_addr=%s local_tei=%u\n", - rem_addrstr, ce_req->remote_tei, osmo_sockaddr_to_str(&loc_osa), loc_tei); - gtp_prim = hnb_gtp_makeprim_conn_establish_cnf(ce_req->context_id, 0, loc_tei, ce_req->remote_gtpu_address_type, &loc_uaddr); + rem_addrstr, ce_req->remote_tei, osmo_sockaddr_to_str(&conn->loc_addr), conn->loc_tei); + gtp_prim = hnb_gtp_makeprim_conn_establish_cnf(ce_req->context_id, conn->id, 0, conn->loc_tei, + ce_req->remote_gtpu_address_type, &loc_uaddr); if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Failed sending GTP-CONN_ESTABLISH.cnf error_code=0\n"); goto release_sock; } - - ue->conn_ps.local_tei = loc_tei; - ue->conn_ps.remote_tei = ce_req->remote_tei; - return rc; release_sock: - hnb_ue_gtp_unbind(ue); + gtp_conn_free(conn); return rc; } static int llsk_rx_gtp_conn_release_req(struct hnb *hnb, struct hnb_gtp_conn_release_req_param *rel_req) { - struct hnb_ue *ue; + struct gtp_conn *conn; int rc = 0; - LOGP(DLLSK, LOGL_DEBUG, "Rx GTP-CONN_RELEASE.req ctx=%u\n", rel_req->context_id); + LOGP(DLLSK, LOGL_DEBUG, "Rx GTP-CONN_RELEASE.req id=%u\n", rel_req->gtp_conn_id); - ue = hnb_find_ue_by_id(hnb, rel_req->context_id); - if (!ue) { - LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_RELEASE.req: UE not found! ctx=%u\n", - rel_req->context_id); + conn = hnb_find_gtp_conn_by_id(hnb, rel_req->gtp_conn_id); + if (!conn) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_RELEASE.req: GTP conn not found! id=%u\n", + rel_req->gtp_conn_id); return -EINVAL; } /* release GTP pdp ctx: */ - hnb_ue_gtp_unbind(ue); + gtp_conn_free(conn); return rc; } static int llsk_rx_gtp_conn_data_req(struct hnb *hnb, struct hnb_gtp_conn_data_req_param *data_req) { - struct hnb_ue *ue; + struct gtp_conn *conn; int rc = 0; - LOGP(DLLSK, LOGL_DEBUG, "Rx GTP-CONN_DATA.req ctx=%u rem_tei=%u data_len=%u\n", - data_req->context_id, data_req->remote_tei, data_req->data_len); + LOGP(DLLSK, LOGL_DEBUG, "Rx GTP-CONN_DATA.req id=%u data_len=%u\n", + data_req->gtp_conn_id, data_req->data_len); - ue = hnb_find_ue_by_id(hnb, data_req->context_id); - if (!ue) { - LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_DATA.req: UE not found! ctx=%u data_len=%u\n", - data_req->context_id, data_req->data_len); + conn = hnb_find_gtp_conn_by_id(hnb, data_req->gtp_conn_id); + if (!conn) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_DATA.req: GTP conn not found! id=%u data_len=%u\n", + data_req->gtp_conn_id, data_req->data_len); return -EINVAL; } - rc = hnb_ue_gtp_tx(ue, data_req->data, data_req->data_len); + rc = gtp_conn_tx(conn, data_req->data, data_req->data_len); return rc; } diff --git a/src/osmo-hnodeb/rtp.c b/src/osmo-hnodeb/rtp.c index cc03c6c..2f40d99 100644 --- a/src/osmo-hnodeb/rtp.c +++ b/src/osmo-hnodeb/rtp.c @@ -27,6 +27,33 @@ #include #include +struct rtp_conn *rtp_conn_alloc(struct hnb_ue *ue) +{ + struct rtp_conn *conn; + + conn = talloc_zero(ue, struct rtp_conn); + if (!conn) + return NULL; + + conn->ue = ue; + + llist_add(&conn->list, &ue->conn_cs.conn_list); + + return conn; +} + +void rtp_conn_free(struct rtp_conn *conn) +{ + if (!conn) + return; + + if (conn->socket) { + osmo_rtp_socket_free(conn->socket); + conn->socket = NULL; + } + llist_del(&conn->list); + talloc_free(conn); +} /* Mixture between osmo_rtp_get_bound_addr and osmo_rtp_get_bound_ip_port using osmo_sockaddr */ /*static int rtp_get_bound_addr(struct osmo_rtp_socket *rs, struct osmo_sockaddr *osa) @@ -97,11 +124,13 @@ tries = (hnb->rtp.port_range_end - hnb->rtp.port_range_start) / 2; for (i = 0; i < tries; i++) { + uint16_t port; if (hnb->rtp.port_range_next >= hnb->rtp.port_range_end) hnb->rtp.port_range_next = hnb->rtp.port_range_start; - rc = osmo_rtp_socket_bind(rs, ip, hnb->rtp.port_range_next); + port = hnb->rtp.port_range_next; + rc = osmo_rtp_socket_bind(rs, ip, port); hnb->rtp.port_range_next += 2; @@ -118,7 +147,7 @@ LOGP(DRTP, LOGL_ERROR, "failed to set socket priority %d: %s\n", hnb->rtp.priority, strerror(errno)); } - return 0; + return port; } return -1; @@ -128,14 +157,14 @@ unsigned int rtp_pl_len, uint16_t seq_number, uint32_t timestamp, bool marker) { - struct hnb_ue *ue = (struct hnb_ue *)rs->priv; + struct rtp_conn *conn = (struct rtp_conn *)rs->priv; - LOGUE(ue, DRTP, LOGL_DEBUG, "Rx RTP seq=%u ts=%u M=%u pl=%p len=%u\n", + LOGUE(conn->ue, DRTP, LOGL_DEBUG, "Rx RTP seq=%u ts=%u M=%u pl=%p len=%u\n", seq_number, timestamp, marker, rtp_pl, rtp_pl_len); - llsk_audio_tx_conn_data_ind(ue, rtp_pl, rtp_pl_len); + llsk_audio_tx_conn_data_ind(conn, rtp_pl, rtp_pl_len); } -int hnb_ue_voicecall_setup(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, struct osmo_sockaddr *loc_addr) +int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr) { int rc; char cname[256+4]; @@ -144,6 +173,7 @@ const char *local_wildcard_ipstr = "0.0.0.0"; char remote_ipstr[INET6_ADDRSTRLEN]; uint16_t remote_port; + struct hnb_ue *ue = conn->ue; struct hnb *hnb = ue->hnb; if (osmo_sockaddr_to_str_and_uint(remote_ipstr, sizeof(remote_ipstr), &remote_port, &rem_addr->u.sa) == 0) { @@ -151,12 +181,9 @@ return -EINVAL; } - if (ue->conn_cs.rtp.socket) { - LOGUE(ue, DRTP, LOGL_ERROR, "Setting up rtp socket but it already exists!\n"); - return -EINVAL; - } + conn->rem_addr = *rem_addr; - rs = ue->conn_cs.rtp.socket = osmo_rtp_socket_create(ue, 0); + rs = conn->socket = osmo_rtp_socket_create(ue, 0); rc = osmo_rtp_socket_set_param(rs, hnb->rtp.jitter_adaptive ? OSMO_RTP_P_JIT_ADAP : @@ -166,7 +193,7 @@ LOGUE(ue, DRTP, LOGL_ERROR, "Failed to set RTP socket parameters: %s\n", strerror(-rc)); goto free_ret; } - rs->priv = ue; + rs->priv = conn; rs->rx_cb = &rtp_rx_cb; rc = rtp_bind(hnb, rs, local_wildcard_ipstr); @@ -174,10 +201,11 @@ LOGUE(ue, DRTP, LOGL_ERROR, "Failed to bind RTP/RTCP sockets\n"); goto free_ret; } + conn->id = rc; /* We use local port as rtp conn ID */ /* Ensure RTCP SDES contains some useful information */ snprintf(cname, sizeof(cname), "hnb@%s", local_wildcard_ipstr); - snprintf(name, sizeof(name), "ue@%u", ue->conn_id); + snprintf(name, sizeof(name), "ue@%u-%u", conn->ue->conn_id, conn->id); osmo_rtp_set_source_desc(rs, cname, name, NULL, NULL, NULL, "OsmoHNodeB-" PACKAGE_VERSION, NULL); @@ -188,8 +216,8 @@ } /* osmo_rtp_socket_connect() is broken, OS#5356 */ - //rc = rtp_get_bound_addr(rs, loc_addr); - rc = rtp_get_bound_addr(rs, rem_addr, loc_addr); + //rc = rtp_get_bound_addr(rs, &conn->loc_addr); + rc = rtp_get_bound_addr(rs, rem_addr, &conn->loc_addr); if (rc < 0) { LOGUE(ue, DRTP, LOGL_ERROR, "Cannot obtain locally bound IP/port: %d\n", rc); goto free_ret; @@ -197,16 +225,7 @@ return rc; free_ret: - osmo_rtp_socket_free(ue->conn_cs.rtp.socket); - ue->conn_cs.rtp.socket = NULL; + osmo_rtp_socket_free(conn->socket); + conn->socket = NULL; return rc; } - -int hnb_ue_voicecall_release(struct hnb_ue *ue) -{ - if (!ue->conn_cs.rtp.socket) - return -EINVAL; - osmo_rtp_socket_free(ue->conn_cs.rtp.socket); - ue->conn_cs.rtp.socket = NULL; - return 0; -} -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ib3f60d5ba21defe5259c25e2034fc2217c4d93df Gerrit-Change-Number: 26570 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 17:59:44 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 14 Dec 2021 17:59:44 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Adapt HNBLIF to latest changes References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26571 ) Change subject: hnodeb: Adapt HNBLIF to latest changes ...................................................................... hnodeb: Adapt HNBLIF to latest changes Change-Id: I50a1b9be579ace9f0f85c6c68b5648d504f5f51c --- M hnodeb/HNB_Tests.ttcn M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 3 files changed, 36 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/26571/1 diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index ca42e5c..c801ee6 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -296,6 +296,7 @@ var HostName hnodeb_rtp_addr; var PortNumber hnodeb_rtp_port; timer Tu; + var uint32_t audio_conn_id; f_handle_hnbap_hnb_register_req(); @@ -317,8 +318,9 @@ /* Now LLSK provides the remote TransportLayerAddress from RabAssReq and asks SUT to provide a local address: */ LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_ESTABLISH_REQ(context_id, g_pars.hnbgw_rtp_port, HNBLL_IF_ADDR_TYPE_IPV4, f_HNBLLIF_Addr(HNBLL_IF_ADDR_TYPE_IPV4, g_pars.hnbgw_addr)))); - LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_ESTABLISH_CNF(context_id, 0, ?, HNBLL_IF_ADDR_TYPE_IPV4, ?))) -> value sd; + LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_ESTABLISH_CNF(context_id, ?, 0, ?, HNBLL_IF_ADDR_TYPE_IPV4, ?))) -> value sd; + audio_conn_id := sd.data.u.audio.u.conn_establish.u.cnf.audio_conn_id; hnodeb_rtp_addr := f_inet_ntoa(sd.data.u.audio.u.conn_establish.u.cnf.local_addr); if (not match(g_pars.hnodeb_addr, hnodeb_rtp_addr)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "hnodeb RTP local address doesn't match expectations"); @@ -328,7 +330,7 @@ f_HNBGW_rtpem_activate(rtp_payload, hnodeb_rtp_addr, hnodeb_rtp_port); /* Make sure that Uplink frames are received at the HNBGW */ RTPEM_DATA.clear; - LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_DATA_REQ(context_id, rtp_payload))); + LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_DATA_REQ(audio_conn_id, rtp_payload))); Tu.start(2.0); alt { [] RTPEM_DATA.receive(PDU_RTP:?) -> value rtp_pdu { @@ -344,11 +346,11 @@ } Tu.stop; /* We should also have received some RTP from the HNBGW: */ - LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_DATA_IND(context_id, rtp_payload))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_DATA_IND(audio_conn_id, rtp_payload))); f_rtpem_mode(RTPEM_CTRL, RTPEM_MODE_NONE); - LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_RELEASE_REQ(context_id))); + LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_RELEASE_REQ(audio_conn_id))); /* UE sends Iu Release Complete to release the conn */ LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_RELEASE_REQ(context_id, 0, 0, 0, hex2oct(iu_release_compl)))); @@ -371,6 +373,7 @@ var uint32_t local_tei; var octetstring gtp_payload := f_rnd_octstring(40); var HNBLLIF_send_data sd; + var uint32_t gtp_conn_id; f_gtp_register_teid(int2oct(remote_tei, 4)); @@ -394,18 +397,19 @@ /* Now LLSK provides the remote TransportLayerAddress from RabAssReq and asks SUT to provide a local address: */ LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_ESTABLISH_REQ(context_id, remote_tei, HNBLL_IF_ADDR_TYPE_IPV4, f_HNBLLIF_Addr(HNBLL_IF_ADDR_TYPE_IPV4, g_pars.hnbgw_addr)))); - LLSK.receive(f_llsk_rx(tr_HNBLLIF_GTP_CONN_ESTABLISH_CNF(context_id, ?, 0, + LLSK.receive(f_llsk_rx(tr_HNBLLIF_GTP_CONN_ESTABLISH_CNF(context_id, ?, ?, 0, HNBLL_IF_ADDR_TYPE_IPV4, ?))) -> value sd; + gtp_conn_id := sd.data.u.gtp.u.conn_establish.u.cnf.gtp_conn_id; local_tei := sd.data.u.gtp.u.conn_establish.u.cnf.local_tei; /* Forward GTP data in both directions */ - LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_DATA_REQ(context_id, remote_tei, gtp_payload))); + LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_DATA_REQ(gtp_conn_id, gtp_payload))); GTP.receive(tr_GTPU_GPDU(ts_GtpPeerU(g_pars.hnodeb_addr), int2oct(remote_tei, 4), gtp_payload)); f_gtpu_send(local_tei, gtp_payload); - LLSK.receive(f_llsk_rx(tr_HNBLLIF_GTP_CONN_DATA_IND(context_id, local_tei, gtp_payload))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_GTP_CONN_DATA_IND(gtp_conn_id, gtp_payload))); /* Done, release GTP conn */ - LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_RELEASE_REQ(context_id, remote_tei))); + LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_RELEASE_REQ(gtp_conn_id))); /* UE sends Iu Release Complete to release the conn */ LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_RELEASE_REQ(context_id, 1, 0, 0, hex2oct(iu_release_compl)))); diff --git a/library/HNBLLIF_Templates.ttcn b/library/HNBLLIF_Templates.ttcn index 78cf89a..fc82a72 100644 --- a/library/HNBLLIF_Templates.ttcn +++ b/library/HNBLLIF_Templates.ttcn @@ -279,6 +279,7 @@ } template (present) HNBLLIF_Message tr_HNBLLIF_AUDIO_CONN_ESTABLISH_CNF(template (present) uint32_t context_id := ?, + template (present) uint32_t audio_conn_id := ?, template (present) uint8_t error_code := ?, template (present) uint16_t local_rtp_port:= ?, template (present) HNBLLIF_AddrType local_rtp_address_type := ?, @@ -293,6 +294,7 @@ u := { cnf := { context_id := context_id, + audio_conn_id := audio_conn_id, local_rtp_port := local_rtp_port, error_code := error_code, local_rtp_address_type := local_rtp_address_type, @@ -305,7 +307,7 @@ } } -template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_RELEASE_REQ(template (value) uint32_t context_id) := { +template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_RELEASE_REQ(template (value) uint32_t audio_conn_id) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { audio := { @@ -315,7 +317,7 @@ op := HNBLL_IF_OP_REQUEST, u := { req := { - context_id := context_id + audio_conn_id := audio_conn_id } } } @@ -324,7 +326,7 @@ } } -template (present) HNBLLIF_Message tr_HNBLLIF_AUDIO_CONN_DATA_IND(template (present) uint32_t context_id := ?, +template (present) HNBLLIF_Message tr_HNBLLIF_AUDIO_CONN_DATA_IND(template (present) uint32_t audio_conn_id := ?, template (present) octetstring data := ?) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { @@ -335,7 +337,7 @@ op := HNBLL_IF_OP_INDICATION, u := { ind := { - context_id := context_id, + audio_conn_id := audio_conn_id, data_len := ?, data := data } @@ -346,7 +348,7 @@ } } -template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_DATA_REQ(template (value) uint32_t context_id, +template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_DATA_REQ(template (value) uint32_t audio_conn_id, template (value) octetstring data) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { @@ -357,7 +359,7 @@ op := HNBLL_IF_OP_REQUEST, u := { req := { - context_id := context_id, + audio_conn_id := audio_conn_id, data_len := lengthof(data), data := data } @@ -399,6 +401,7 @@ } template (present) HNBLLIF_Message tr_HNBLLIF_GTP_CONN_ESTABLISH_CNF(template (present) uint32_t context_id := ?, + template (present) uint32_t gtp_conn_id := ?, template (present) uint32_t local_tei := ?, template (present) uint8_t error_code := ?, template (present) HNBLLIF_AddrType local_gtpu_address_type := ?, @@ -413,6 +416,7 @@ u := { cnf := { context_id := context_id, + gtp_conn_id := gtp_conn_id, local_tei := local_tei, error_code := error_code, local_gtpu_address_type := local_gtpu_address_type, @@ -425,8 +429,7 @@ } } -template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_RELEASE_REQ(template (value) uint32_t context_id, - template (value) uint32_t remote_tei) := { +template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_RELEASE_REQ(template (value) uint32_t gtp_conn_id) := { sapi := HNBLL_IF_SAPI_GTP, u := { gtp := { @@ -436,8 +439,7 @@ op := HNBLL_IF_OP_REQUEST, u := { req := { - context_id := context_id, - remote_tei := remote_tei + gtp_conn_id := gtp_conn_id } } } @@ -446,8 +448,7 @@ } } -template (present) HNBLLIF_Message tr_HNBLLIF_GTP_CONN_DATA_IND(template (present) uint32_t context_id := ?, - template (present) uint32_t local_tei := ?, +template (present) HNBLLIF_Message tr_HNBLLIF_GTP_CONN_DATA_IND(template (present) uint32_t gtp_conn_id, template (present) octetstring data := ?) := { sapi := HNBLL_IF_SAPI_GTP, u := { @@ -458,8 +459,7 @@ op := HNBLL_IF_OP_INDICATION, u := { ind := { - context_id := context_id, - local_tei := local_tei, + gtp_conn_id := gtp_conn_id, data_len := ?, data := data } @@ -470,8 +470,7 @@ } } -template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_DATA_REQ(template (value) uint32_t context_id, - template (value) uint32_t remote_tei, +template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_DATA_REQ(template (value) uint32_t gtp_conn_id, template (value) octetstring data) := { sapi := HNBLL_IF_SAPI_GTP, u := { @@ -482,8 +481,7 @@ op := HNBLL_IF_OP_REQUEST, u := { req := { - context_id := context_id, - remote_tei := remote_tei, + gtp_conn_id := gtp_conn_id, data_len := lengthof(data), data := data } diff --git a/library/HNBLLIF_Types.ttcn b/library/HNBLLIF_Types.ttcn index 95f91fc..a3a6c4c 100644 --- a/library/HNBLLIF_Types.ttcn +++ b/library/HNBLLIF_Types.ttcn @@ -252,6 +252,7 @@ type record HNBLLIF_AUDIO_conn_establish_cnf { uint32_t context_id, + uint32_t audio_conn_id, uint16_t local_rtp_port, uint8_t error_code, HNBLLIF_AddrType local_rtp_address_type, @@ -273,7 +274,7 @@ /* CONN_RELEASE */ type record HNBLLIF_AUDIO_conn_release_req { - uint32_t context_id + uint32_t audio_conn_id } with { variant "" }; @@ -290,13 +291,13 @@ /* CONN_DATA */ type record HNBLLIF_AUDIO_conn_data_ind { - uint32_t context_id, + uint32_t audio_conn_id, uint32_t data_len, octetstring data /* RANAP message */ } with { variant (data_len) "LENGTHTO (data)" }; type record HNBLLIF_AUDIO_conn_data_req { - uint32_t context_id, + uint32_t audio_conn_id, uint32_t data_len, octetstring data /* RANAP message */ } with { variant (data_len) "LENGTHTO (data)" }; @@ -350,6 +351,7 @@ type record HNBLLIF_GTP_conn_establish_cnf { uint32_t context_id, + uint32_t gtp_conn_id, uint32_t local_tei, uint8_t error_code, HNBLLIF_AddrType local_gtpu_address_type, @@ -371,8 +373,7 @@ /* CONN_RELEASE */ type record HNBLLIF_GTP_conn_release_req { - uint32_t context_id, - uint32_t remote_tei + uint32_t gtp_conn_id } with { variant "" }; type union HNBLLIF_GTP_PrimOpUnion_conn_release { @@ -388,15 +389,13 @@ /* CONN_DATA */ type record HNBLLIF_GTP_conn_data_req { - uint32_t context_id, - uint32_t remote_tei, + uint32_t gtp_conn_id, uint32_t data_len, octetstring data /* RANAP message */ } with { variant (data_len) "LENGTHTO (data)" }; type record HNBLLIF_GTP_conn_data_ind { - uint32_t context_id, - uint32_t local_tei, + uint32_t gtp_conn_id, uint32_t data_len, octetstring data /* RANAP message */ } with { variant (data_len) "LENGTHTO (data)" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50a1b9be579ace9f0f85c6c68b5648d504f5f51c Gerrit-Change-Number: 26571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 18:49:22 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 14 Dec 2021 18:49:22 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, tsaitgaist, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/26463 to look at the new patch set (#5). Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... firmware: add crc stub to all dfu apps to ensure reliable loading DFU flashing of apps sometimes aborts, and although rare this leads to broken devices if no boot button or serial/jtag access exists, because the bootloader will keep trying to start a half-flashed app that then crashes at some point. The easiest fix that works with existing bootloaders is to prepend a small 512 byte stub that calculcates the crc and compares it with the crc calculated at build time, and then either starts the actual app, or sets the dfu flag and resets. This ensures we either have a working, running app, or end up in the bootloader, ready to flash again. For obvious reasons this only applies to dfu apps, and not to flash targets like the actual bootloader itself. Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f --- M contrib/prepare_upload.sh M firmware/Makefile M firmware/apps/blupdate/main.c M firmware/libboard/common/resources/sam3s4/dfu.ld M firmware/libboard/common/resources/sam3s4/flash.ld A firmware/libcommon/source/crcstub.c A firmware/misc/crctool.c 7 files changed, 253 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/63/26463/5 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 18:49:37 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 14 Dec 2021 18:49:37 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 5: maybe like this? -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Tue, 14 Dec 2021 18:49:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 18:51:04 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 14 Dec 2021 18:51:04 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, tsaitgaist, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/26463 to look at the new patch set (#6). Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... firmware: add crc stub to all dfu apps to ensure reliable loading DFU flashing of apps sometimes aborts, and although rare this leads to broken devices if no boot button or serial/jtag access exists, because the bootloader will keep trying to start a half-flashed app that then crashes at some point. The easiest fix that works with existing bootloaders is to prepend a small 512 byte stub that calculcates the crc and compares it with the crc calculated at build time, and then either starts the actual app, or sets the dfu flag and resets. This ensures we either have a working, running app, or end up in the bootloader, ready to flash again. For obvious reasons this only applies to dfu apps, and not to flash targets like the actual bootloader itself. Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f --- M contrib/prepare_upload.sh M firmware/Makefile M firmware/apps/blupdate/main.c M firmware/libboard/common/resources/sam3s4/dfu.ld M firmware/libboard/common/resources/sam3s4/flash.ld A firmware/libcommon/source/crcstub.c A firmware/misc/crctool.c 7 files changed, 253 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/63/26463/6 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 18:53:03 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 14 Dec 2021 18:53:03 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, tsaitgaist, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/26463 to look at the new patch set (#7). Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... firmware: add crc stub to all dfu apps to ensure reliable loading DFU flashing of apps sometimes aborts, and although rare this leads to broken devices if no boot button or serial/jtag access exists, because the bootloader will keep trying to start a half-flashed app that then crashes at some point. The easiest fix that works with existing bootloaders is to prepend a small 512 byte stub that calculcates the crc and compares it with the crc calculated at build time, and then either starts the actual app, or sets the dfu flag and resets. This ensures we either have a working, running app, or end up in the bootloader, ready to flash again. For obvious reasons this only applies to dfu apps, and not to flash targets like the actual bootloader itself. Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f --- M contrib/prepare_upload.sh M firmware/Makefile M firmware/apps/blupdate/main.c M firmware/libboard/common/resources/sam3s4/dfu.ld M firmware/libboard/common/resources/sam3s4/flash.ld A firmware/libcommon/source/crcstub.c A firmware/misc/crctool.c 7 files changed, 245 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/63/26463/7 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 18:56:08 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 14 Dec 2021 18:56:08 +0000 Subject: Change in simtrace2[master]: wireshark lua dissector: dissect more References: Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/26572 ) Change subject: wireshark lua dissector: dissect more ...................................................................... wireshark lua dissector: dissect more Change-Id: If81812b6330205a65c1c9b7d4240094b71f3c757 --- M contrib/simtrace.lua 1 file changed, 96 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/72/26572/1 diff --git a/contrib/simtrace.lua b/contrib/simtrace.lua index 1ca1b0b..efae492 100644 --- a/contrib/simtrace.lua +++ b/contrib/simtrace.lua @@ -42,14 +42,38 @@ local tpdu_hdr = ProtoField.uint32("usb_simtrace.tpdu_hdr", "tpdu_hdr", base.HEX_DEC, NULL, 0x1) local rxtxdatalen = ProtoField.uint16("usb_simtrace.rxtxdatalen", "rx/tx data length", base.HEX_DEC) local rxtxdata = ProtoField.bytes("usb_simtrace.rxtxdata", "rx/tx (data)") -usb_simtrace_protocol.fields = { - msgtype, seqnr, slotnr, reserved, payloadlen, payload, pb_and_rx, pb_and_tx, final, tpdu_hdr, rxtxdatalen, rxtxdata + +local CEMU_STATUS_F_VCC_PRESENT = ProtoField.uint32("usb_simtrace.CEMU_STATUS.F_VCC_PRESENT", "VCC_PRESENT", base.HEX_DEC, NULL, 0x00000001) +local CEMU_STATUS_F_CLK_ACTIVE = ProtoField.uint32("usb_simtrace.CEMU_STATUS.F_CLK_ACTIVE", "CLK_ACTIVE", base.HEX_DEC, NULL, 0x00000002) +local CEMU_STATUS_F_RCEMU_ACTIVE = ProtoField.uint32("usb_simtrace.CEMU_STATUS.F_RCEMU_ACTIVE", "CEMU_ACTIVE", base.HEX_DEC, NULL, 0x00000004) +local CEMU_STATUS_F_CARD_INSERT = ProtoField.uint32("usb_simtrace.CEMU_STATUS.F_CARD_INSERT", "CARD_INSERT", base.HEX_DEC, NULL, 0x00000008) +local CEMU_STATUS_F_RESET_ACTIVE = ProtoField.uint32("usb_simtrace.CEMU_STATUS.F_RESET_ACTIVE", "RESET_ACTIVE", base.HEX_DEC, NULL, 0x00000010) + +local modem_reset_types = { + [0x00] = "de-assert", + [0x01] = "assert", + [0x02] = "pulse" } +local modem_reset_status = ProtoField.uint8("usb_simtrace.modem.reset_type", "modem reset type", base.HEX, modem_reset_types, 0xf) +local modem_reset_len = ProtoField.uint8("usb_simtrace.modem.reset_len", "modem reset length (ms)", base.DEC) + +usb_simtrace_protocol.fields = { + msgtype, seqnr, slotnr, reserved, payloadlen, payload, + pb_and_rx, pb_and_tx, final, tpdu_hdr, rxtxdatalen, rxtxdata, + CEMU_STATUS_F_VCC_PRESENT, CEMU_STATUS_F_CLK_ACTIVE, CEMU_STATUS_F_RCEMU_ACTIVE, CEMU_STATUS_F_CARD_INSERT, CEMU_STATUS_F_RESET_ACTIVE, + modem_reset_status, modem_reset_len +} + +local is_hdr = Field.new("usb_simtrace.tpdu_hdr") +local is_pbrx = Field.new("usb_simtrace.pb_and_rx") +local is_pbtx = Field.new("usb_simtrace.pb_and_tx") +local is_final= Field.new("usb_simtrace.final") + function dissect_rxtx(payload_data,pinfo,tree) local headerSubtree = tree:add(usb_simtrace_protocol, payload_data, "rx/tx data") - local len = payload_data(8+4,2):le_uint(); - local cmd32 = payload_data(8+0,4):le_uint(); + local len = payload_data(4,2):le_uint(); + local cmd32 = payload_data(0,4):le_uint(); headerSubtree:add(pb_and_rx, cmd32) headerSubtree:add(pb_and_tx, cmd32) @@ -57,7 +81,65 @@ headerSubtree:add(tpdu_hdr, cmd32) headerSubtree:add(rxtxdatalen, len) - headerSubtree:add_le(rxtxdata, payload_data(8+6,len)) + headerSubtree:add_le(rxtxdata, payload_data(6,len)) + + -- ghetto dissection does not work due to mixed in procedure bytes + --if pinfo.visited == false then + -- Dissector.get("iso7816"):call(payload_data(6):tvb(), pinfo, tree) + +-- local offs = 0 +-- if (is_pbrx().value == 1 or is_pbtx().value == 1) and is_final().value == 0 then +-- offs = 1 +-- else +-- offs = 0 +-- end +-- +-- if is_hdr().value == 1 then +-- Dissector.get("gsm_sim"):call(concatss:tvb(), pinfo, tree) +-- concatss = payload_data(6):bytes() +-- else +-- concatss = concatss .. payload_data(6+offs):bytes() +-- end + +--end + +end + +function dissect_status(payload_data,pinfo,tree) + + local headerSubtree = tree:add(usb_simtrace_protocol, payload_data, "status message") + local cmd32 = payload_data(0,4):le_uint(); + + headerSubtree:add(CEMU_STATUS_F_VCC_PRESENT, cmd32) + headerSubtree:add(CEMU_STATUS_F_CLK_ACTIVE, cmd32) + headerSubtree:add(CEMU_STATUS_F_RCEMU_ACTIVE, cmd32) + headerSubtree:add(CEMU_STATUS_F_CARD_INSERT, cmd32) + headerSubtree:add(CEMU_STATUS_F_RESET_ACTIVE, cmd32) + + pinfo.cols.info:append(" VCC:" .. payload_data(0,1):bitfield(7, 1) .. " CLK:" .. payload_data(0,1):bitfield(6, 1) .. " RESET:" .. payload_data(0,1):bitfield(3, 1)) +end + +function dissect_atr(payload_data,pinfo,tree) + + local len = payload_data(0,1):le_uint() + Dissector.get("iso7816.atr"):call(payload_data(1):tvb(), pinfo, tree) +end + +function dissect_modem_reset(payload_data,pinfo,tree) + + local headerSubtree = tree:add(usb_simtrace_protocol, payload_data, "modem reset") + local cmd8 = payload_data(0,1):le_uint(); + + headerSubtree:add(modem_reset_status, cmd8) + pinfo.cols.info:append(" reset type:" .. modem_reset_types[cmd8]); + + if(cmd8 == 2) then + local duration = payload_data(1,2):le_uint() + headerSubtree:add(modem_reset_len, duration) + pinfo.cols.info:append(" duration:" .. duration .. "ms") + end + + end function usb_simtrace_protocol.dissector(buffer, pinfo, tree) @@ -76,7 +158,13 @@ pinfo.cols.info = string.format("Cmd 0x%04X : %s", command, control_commands[command]) local payload_data = buffer(8,length-8) if(command == 0x0101 or command == 0x0106) then - return dissect_rxtx(buffer(),pinfo,subtree) + return dissect_rxtx(payload_data(),pinfo,subtree) + elseif(command == 0x0104) then + return dissect_status(payload_data(),pinfo,subtree) + elseif(command == 0x0102) then + return dissect_atr(payload_data(),pinfo,subtree) + elseif(command == 0x0201) then + return dissect_modem_reset(payload_data(),pinfo,subtree) else subtree:add(payload, payload_data) end @@ -89,4 +177,6 @@ usb_product_dissectors:add(0x1d50616d, usb_simtrace_protocol) usb_product_dissectors:add(0x1d50616e, usb_simtrace_protocol) DissectorTable.get("usb.bulk"):add(0xffff, usb_simtrace_protocol) +DissectorTable.get("usb.interrupt"):add(0xffff, usb_simtrace_protocol) +--concatss = ByteArray.new() end -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If81812b6330205a65c1c9b7d4240094b71f3c757 Gerrit-Change-Number: 26572 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 19:10:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 14 Dec 2021 19:10:36 +0000 Subject: Change in docker-playground[master]: ttcn3-{sgsn, ggsn}-test: set OSMO_SUT_{HOST, PORT} References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26573 ) Change subject: ttcn3-{sgsn,ggsn}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... ttcn3-{sgsn,ggsn}-test: set OSMO_SUT_{HOST,PORT} This enables the test suite to obtain talloc reports between the test case executions, which get stored together with the PCAP files. Change-Id: I61fef7763e6445c231ff2664036e243a9ac96ff6 Related: Icd4c2d80db934535d499598282ed9416d8088163 --- M ttcn3-ggsn-test/jenkins.sh M ttcn3-sgsn-test/jenkins.sh 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/73/26573/1 diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh index cdf9bf8..53da74d 100755 --- a/ttcn3-ggsn-test/jenkins.sh +++ b/ttcn3-ggsn-test/jenkins.sh @@ -46,12 +46,14 @@ -v "$KERNEL_TEST_DIR:/kernel-test:ro" -v "$CACHE_DIR:/cache" " + OSMO_SUT_HOST="172.18.$SUBNET.200" else cp osmo-ggsn.cfg $VOL_BASE_DIR/ggsn/ GGSN_DOCKER_ARGS=" $(docker_network_params $SUBNET 201) " + OSMO_SUT_HOST="172.18.$SUBNET.201" fi docker run --cap-add=NET_ADMIN \ --device /dev/net/tun:/dev/net/tun \ @@ -74,6 +76,8 @@ --ulimit core=-1 \ -v $VOL_BASE_DIR/ggsn-tester:/data \ -e "TTCN3_PCAP_PATH=/data" \ + -e "OSMO_SUT_HOST=$OSMO_SUT_HOST" \ + -e "OSMO_SUT_PORT=4260" \ --name ${BUILD_TAG}-ggsn-test \ $DOCKER_ARGS \ $REPO_USER/ttcn3-ggsn-test diff --git a/ttcn3-sgsn-test/jenkins.sh b/ttcn3-sgsn-test/jenkins.sh index 24869c5..dde90a2 100755 --- a/ttcn3-sgsn-test/jenkins.sh +++ b/ttcn3-sgsn-test/jenkins.sh @@ -49,6 +49,8 @@ $(docker_network_params $SUBNET 103) \ --ulimit core=-1 \ -e "TTCN3_PCAP_PATH=/data" \ + -e "OSMO_SUT_HOST=172.18.$SUBNET.10" \ + -e "OSMO_SUT_PORT=4245" \ -v $VOL_BASE_DIR/sgsn-tester:/data \ --name ${BUILD_TAG}-ttcn3-sgsn-test \ $DOCKER_ARGS \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I61fef7763e6445c231ff2664036e243a9ac96ff6 Gerrit-Change-Number: 26573 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 14 20:58:39 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 14 Dec 2021 20:58:39 +0000 Subject: Change in osmo-dev[master]: Add tmux scripts for ttcn3-{msc, bsc, bts}-test In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26485 ) Change subject: Add tmux scripts for ttcn3-{msc,bsc,bts}-test ...................................................................... Patch Set 3: Looks nice, but shouldn't you start the testsuite as the last step? -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 Gerrit-Change-Number: 26485 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Comment-Date: Tue, 14 Dec 2021 20:58:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 01:25:52 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 15 Dec 2021 01:25:52 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: introduce c_def_{hbh, ete}_id constants In-Reply-To: References: Message-ID: fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 ) Change subject: library/DIAMETER_Templates: introduce c_def_{hbh,ete}_id constants ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I714b18bbe77949593803e999d25e4ef8e1827917 Gerrit-Change-Number: 26511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 01:56:50 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 15 Dec 2021 01:56:50 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: introduce c_def_{hbh, ete}_id constants In-Reply-To: References: Message-ID: fixeria has restored this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 ) Change subject: library/DIAMETER_Templates: introduce c_def_{hbh,ete}_id constants ...................................................................... Restored -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I714b18bbe77949593803e999d25e4ef8e1827917 Gerrit-Change-Number: 26511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: restore -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 02:45:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 15 Dec 2021 02:45:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: set default {hbh, ete}_id in ts_DIAMETER In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 to look at the new patch set (#2). Change subject: library/DIAMETER_Templates: set default {hbh,ete}_id in ts_DIAMETER ...................................................................... library/DIAMETER_Templates: set default {hbh,ete}_id in ts_DIAMETER Having default values for these parameters allows omitting them in subsequent send template definitions based on ts_DIAMETER. Change-Id: I714b18bbe77949593803e999d25e4ef8e1827917 Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/11/26511/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I714b18bbe77949593803e999d25e4ef8e1827917 Gerrit-Change-Number: 26511 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 02:45:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 15 Dec 2021 02:45:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add templates for DWR/DWA In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26512 to look at the new patch set (#2). Change subject: library/DIAMETER_Templates: add templates for DWR/DWA ...................................................................... library/DIAMETER_Templates: add templates for DWR/DWA Change-Id: I2abe33a3ac08c8855342f4277288cacb3545771b Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 86 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/12/26512/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2abe33a3ac08c8855342f4277288cacb3545771b Gerrit-Change-Number: 26512 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 02:45:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 15 Dec 2021 02:45:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: rework existing ULR/ULA templates In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 to look at the new patch set (#2). Change subject: library/DIAMETER_Templates: rework existing ULR/ULA templates ...................................................................... library/DIAMETER_Templates: rework existing ULR/ULA templates * Make both {hbh,ete}_id parameters last among the others; * Use more elegant and consistent template formatting; * Make Origin{Host,Realm} values configurable; * Make DestinationRealm value configurable; * Make SessionId value configurable. Change-Id: I0585e306a87453c212c6b5ac5635181c47b34b4f Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn M mme/MME_Tests.ttcn 2 files changed, 46 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/13/26513/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0585e306a87453c212c6b5ac5635181c47b34b4f Gerrit-Change-Number: 26513 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 02:45:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 15 Dec 2021 02:45:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add missing templates for ULR/ULA In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26514 to look at the new patch set (#2). Change subject: library/DIAMETER_Templates: add missing templates for ULR/ULA ...................................................................... library/DIAMETER_Templates: add missing templates for ULR/ULA Change-Id: If0b8daf5717eb4c26da231489118e200faeee9a2 Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 54 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/26514/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0b8daf5717eb4c26da231489118e200faeee9a2 Gerrit-Change-Number: 26514 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 02:45:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 15 Dec 2021 02:45:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: prettify & enrich AIR/AIA templates In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26515 to look at the new patch set (#2). Change subject: library/DIAMETER_Templates: prettify & enrich AIR/AIA templates ...................................................................... library/DIAMETER_Templates: prettify & enrich AIR/AIA templates * Make both {hbh,ete}_id parameters last among the others; * Use more elegant and consistent template formatting; * Make DestinationRealm value configurable; * Make SessionId value configurable. Change-Id: Iaf6472fecbadd58e86b78c59348d9924ab57f97d Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn M mme/MME_Tests.ttcn 2 files changed, 51 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/26515/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf6472fecbadd58e86b78c59348d9924ab57f97d Gerrit-Change-Number: 26515 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 02:45:36 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 15 Dec 2021 02:45:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: fix flags in AIR templates In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 to look at the new patch set (#2). Change subject: library/DIAMETER_Templates: fix flags in AIR templates ...................................................................... library/DIAMETER_Templates: fix flags in AIR templates According to RFC 6733, section 3 "Diameter Header", if the 'R' bit is set, the message is a request. If the 'P' bit is set, the message may be proxied, relayed, or redirected. ts_DIA_AIR is a template for Authentication Information *Request*, so the 'R' bit must be set. Also, let's allow this message to be proxied, relayed, or redirected by setting the 'P' bit by default. In tr_DIA_AIR, do not match all command flags, just ensure that the message is a request. Other flags do not matter. Change-Id: I7db3b632189eed09c1bdf98f9d588491d928e2f5 Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/26517/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7db3b632189eed09c1bdf98f9d588491d928e2f5 Gerrit-Change-Number: 26517 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 08:50:34 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 15 Dec 2021 08:50:34 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/c/simtrace2/+/26463/7/firmware/Makefile File firmware/Makefile: https://gerrit.osmocom.org/c/simtrace2/+/26463/7/firmware/Makefile at 291 PS7, Line 291: $(SILENT)misc/crctool 512 $@ To avoid what Harald wrote here: > Should the last step fail, there will still be a .bin file and a subsequent repeated 'make' command will no longer try executing crctool, as the .bin already exists? I suggest: $(SILENT)cp $< $@.temp $(SILENT)misc/crctool 512 $@.temp $(SILENT)mv $@.temp $@ -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Wed, 15 Dec 2021 08:50:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 12:05:36 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 15 Dec 2021 12:05:36 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hello osmith, Jenkins Builder, laforge, tsaitgaist, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/26463 to look at the new patch set (#8). Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... firmware: add crc stub to all dfu apps to ensure reliable loading DFU flashing of apps sometimes aborts, and although rare this leads to broken devices if no boot button or serial/jtag access exists, because the bootloader will keep trying to start a half-flashed app that then crashes at some point. The easiest fix that works with existing bootloaders is to prepend a small 512 byte stub that calculcates the crc and compares it with the crc calculated at build time, and then either starts the actual app, or sets the dfu flag and resets. This ensures we either have a working, running app, or end up in the bootloader, ready to flash again. For obvious reasons this only applies to dfu apps, and not to flash targets like the actual bootloader itself. Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f --- M contrib/prepare_upload.sh M firmware/Makefile M firmware/apps/blupdate/main.c M firmware/libboard/common/resources/sam3s4/dfu.ld M firmware/libboard/common/resources/sam3s4/flash.ld A firmware/libcommon/source/crcstub.c A firmware/misc/crctool.c 7 files changed, 246 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/63/26463/8 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 8 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 12:05:47 2021 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 15 Dec 2021 12:05:47 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 8: (1 comment) https://gerrit.osmocom.org/c/simtrace2/+/26463/7/firmware/Makefile File firmware/Makefile: https://gerrit.osmocom.org/c/simtrace2/+/26463/7/firmware/Makefile at 291 PS7, Line 291: $(SILENT)misc/crctool 512 $@ > To avoid what Harald wrote here: [?] Done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 8 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Wed, 15 Dec 2021 12:05:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 12:16:16 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 15 Dec 2021 12:16:16 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 8 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Wed, 15 Dec 2021 12:16:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 12:43:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 12:43:55 +0000 Subject: Change in docker-playground[master]: ttcn3-{sgsn, ggsn}-test: set OSMO_SUT_{HOST, PORT} In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26573 ) Change subject: ttcn3-{sgsn,ggsn}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I61fef7763e6445c231ff2664036e243a9ac96ff6 Gerrit-Change-Number: 26573 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 12:43:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 12:44:34 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 12:44:34 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: set default {hbh, ete}_id in ts_DIAMETER In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 ) Change subject: library/DIAMETER_Templates: set default {hbh,ete}_id in ts_DIAMETER ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I714b18bbe77949593803e999d25e4ef8e1827917 Gerrit-Change-Number: 26511 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 12:44:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 12:45:05 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 12:45:05 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: rework existing ULR/ULA templates In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 ) Change subject: library/DIAMETER_Templates: rework existing ULR/ULA templates ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0585e306a87453c212c6b5ac5635181c47b34b4f Gerrit-Change-Number: 26513 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 12:45:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 12:45:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 12:45:32 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add templates for DWR/DWA In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26512 ) Change subject: library/DIAMETER_Templates: add templates for DWR/DWA ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2abe33a3ac08c8855342f4277288cacb3545771b Gerrit-Change-Number: 26512 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 12:45:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 12:45:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 12:45:53 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add missing templates for ULR/ULA In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26514 ) Change subject: library/DIAMETER_Templates: add missing templates for ULR/ULA ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0b8daf5717eb4c26da231489118e200faeee9a2 Gerrit-Change-Number: 26514 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 12:45:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 12:46:14 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 12:46:14 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: prettify & enrich AIR/AIA templates In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26515 ) Change subject: library/DIAMETER_Templates: prettify & enrich AIR/AIA templates ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf6472fecbadd58e86b78c59348d9924ab57f97d Gerrit-Change-Number: 26515 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 12:46:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 12:46:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 12:46:51 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: fix flags in AIR templates In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 ) Change subject: library/DIAMETER_Templates: fix flags in AIR templates ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7db3b632189eed09c1bdf98f9d588491d928e2f5 Gerrit-Change-Number: 26517 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 12:46:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:04:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:04:17 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 8 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-Comment-Date: Wed, 15 Dec 2021 14:04:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:04:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:04:20 +0000 Subject: Change in simtrace2[master]: firmware: add crc stub to all dfu apps to ensure reliable loading In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26463 ) Change subject: firmware: add crc stub to all dfu apps to ensure reliable loading ...................................................................... firmware: add crc stub to all dfu apps to ensure reliable loading DFU flashing of apps sometimes aborts, and although rare this leads to broken devices if no boot button or serial/jtag access exists, because the bootloader will keep trying to start a half-flashed app that then crashes at some point. The easiest fix that works with existing bootloaders is to prepend a small 512 byte stub that calculcates the crc and compares it with the crc calculated at build time, and then either starts the actual app, or sets the dfu flag and resets. This ensures we either have a working, running app, or end up in the bootloader, ready to flash again. For obvious reasons this only applies to dfu apps, and not to flash targets like the actual bootloader itself. Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f --- M contrib/prepare_upload.sh M firmware/Makefile M firmware/apps/blupdate/main.c M firmware/libboard/common/resources/sam3s4/dfu.ld M firmware/libboard/common/resources/sam3s4/flash.ld A firmware/libcommon/source/crcstub.c A firmware/misc/crctool.c 7 files changed, 246 insertions(+), 28 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/prepare_upload.sh b/contrib/prepare_upload.sh index 90b3278..f134d2a 100755 --- a/contrib/prepare_upload.sh +++ b/contrib/prepare_upload.sh @@ -1,4 +1,4 @@ -#!/bin/sh -e +#!/bin/bash -e # Create copies of binaries with -latest, -$GIT_VERSION (OS#4413, OS#3452) cd "$(dirname "$0")/.." @@ -9,8 +9,10 @@ cd firmware/bin for ext in bin elf; do for file in *."$ext"; do - without_ext="${file%.*}" - cp -v "$file" "$without_ext-latest.$ext" - cp -v "$file" "$without_ext-$GIT_VERSION.$ext" + if ! [[ "$file" =~ ^(.*padded.*|.*nocrcstub.*)$ ]];then + without_ext="${file%.*}" + cp -v "$file" "$without_ext-latest.$ext" + cp -v "$file" "$without_ext-$GIT_VERSION.$ext" + fi done done diff --git a/firmware/Makefile b/firmware/Makefile index c30dc9a..9a2d347 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -117,7 +117,7 @@ C_LIBUSB_RT = dfu.c dfu_runtime.c C_LIBUSB_DFU = dfu.c dfu_desc.c dfu_driver.c C_LIBCOMMON = string.c stdio.c fputs.c usb_buf.c ringbuffer.c pseudo_talloc.c host_communication.c \ - main_common.c stack_check.c + main_common.c stack_check.c crcstub.c C_BOARD = $(notdir $(wildcard libboard/common/source/*.c)) C_BOARD += $(notdir $(wildcard libboard/$(BOARD)/source/*.c)) @@ -229,12 +229,15 @@ $(OUTPUT)-combined.bin: $(BIN)/$(BOARD)-dfu-flash-padded.bin $(OUTPUT)-dfu.bin cat $^ > $@ -$(BIN) $(OBJ): apps/$(APP)/usb_strings_generated.h +$(BIN) $(OBJ): apps/$(APP)/usb_strings_generated.h misc/crctool mkdir -p $@ usbstring/usbstring: usbstring/usbstring.c gcc $^ -o $@ +misc/crctool: misc/crctool.c + gcc $^ -o $@ + .PHONY: apps/$(APP)/usb_strings.txt.patched apps/$(APP)/usb_strings.txt.patched: apps/$(APP)/usb_strings.txt sed "s/PRODUCT_STRING/$(shell cat libboard/$(BOARD)/product_string.txt)/" $< > $@ @@ -251,7 +254,6 @@ $(SILENT)$(CC) $(CFLAGS) $(LDFLAGS) $(LD_OPTIONAL) -T"libboard/common/resources/$(CHIP)/$(1).ld" -Wl,-Map,$(OUTPUT)-$(1).map -o $(OUTPUT)-$(1).elf $$^ $(LIBS) $(SILENT)$(NM) $(OUTPUT)-$(1).elf >$(OUTPUT)-$(1).elf.txt $(SILENT)$(OBJCOPY) -O binary $(OUTPUT)-$(1).elf $(OUTPUT)-$(1).bin - $(SILENT)$(SIZE) $$^ $(OUTPUT)-$(1).elf $$(C_OBJECTS_$(1)): $(OBJ)/$(1)_%.o: %.c Makefile $(OBJ) $(BIN) @echo [COMPILING $$<] @@ -261,26 +263,17 @@ @echo [ASSEMBLING $$@] $(SILENT)$(CC) $(ASFLAGS) -DENVIRONMENT_$(1) -DENVIRONMENT=\"$(1)\" -c -o $$@ $$< -debug_$(1): $(1) - $(GDB) -x "$(BOARD_LIB)/resources/gcc/$(BOARD)_$(1).gdb" -ex "reset" -readnow -se $(OUTPUT)-$(1).elf endef -ALL_MEMORIES = dfu flash ram +ALL_MEMORIES = flash ram $(foreach MEMORY, $(ALL_MEMORIES), $(eval $(call RULES,$(MEMORY)))) # files with those names do exist.. -.PHONY: ram .PHONY: dfu -.PHONY: flash +dfu: $(OUTPUT)-dfu.bin +.PHONY: ram ram: build_ram -dfu: build_dfu -ifeq ($(APP), blupdate) - $(info updating updater section with padded bootloader file..) - $(SILENT)dd if=/dev/zero bs=16384 count=1 of=$(BIN)/$(BOARD)-dfu-flash-padded.bin - $(SILENT)dd if=$(BIN)/$(BOARD)-dfu-flash.bin conv=notrunc of=$(BIN)/$(BOARD)-dfu-flash-padded.bin - $(SILENT)$(OBJCOPY) --update-section .blupdate=bin/$(BOARD)-dfu-flash-padded.bin bin/$(BOARD)-blupdate-dfu.elf - $(SILENT)$(OBJCOPY) -O binary bin/$(BOARD)-blupdate-dfu.elf bin/$(BOARD)-blupdate-dfu.bin -endif +.PHONY: flash flash: build_flash #alternate way of embedding: obj file #ifeq ($(APP), dfu) @@ -288,8 +281,37 @@ # $(SILENT)$(OBJCOPY) --rename-section .data=.fwupdate -I binary -O elf32-littlearm bin/$(BOARD)-dfu-flash.bin $(OBJ)/flash_fwupdate.o #endif -program: - openocd -f openocd/openocd.cfg -c "init" -c "halt" -c "flash write_bank 0 ./bin/project-flash.bin 0" -c "reset" -c "shutdown" +C_OBJECTS_dfu = $(addprefix $(OBJ)/dfu_, $(C_OBJECTS)) +ASM_OBJECTS_dfu = $(addprefix $(OBJ)/dfu_, $(ASM_OBJECTS)) +EXTRA_OBJECTS_dfu = $(addprefix $(OBJ)/dfu_, $(EXTRA_OBJECTS)) + +$(OUTPUT)-dfu.bin: $(OUTPUT)-dfu_nocrcstub.bin + $(info updating app with crc..) + $(SILENT)cp $< $@.temp + $(SILENT)misc/crctool 512 $@.temp + $(SILENT)mv $@.temp $@ + +$(OUTPUT)-dfu_nocrcstub.bin: $(OUTPUT)-dfu_nocrcstub.elf +ifeq ($(APP), blupdate) + $(info updating updater section with padded bootloader file..) + $(SILENT)dd status=none if=/dev/zero bs=16384 count=1 of=$(BIN)/$(BOARD)-dfu-flash-padded.bin + $(SILENT)dd status=none if=$(BIN)/$(BOARD)-dfu-flash.bin conv=notrunc of=$(BIN)/$(BOARD)-dfu-flash-padded.bin + $(SILENT)$(OBJCOPY) --update-section .blupdate=bin/$(BOARD)-dfu-flash-padded.bin $< +endif + $(SILENT)$(OBJCOPY) -O binary $< $@ + +$(OUTPUT)-dfu_nocrcstub.elf: $(ASM_OBJECTS_dfu) $(C_OBJECTS_dfu) $(EXTRA_OBJECTS_dfu) + $(SILENT)$(CC) $(CFLAGS) $(LDFLAGS) $(LD_OPTIONAL) -T"libboard/common/resources/$(CHIP)/dfu.ld" -Wl,-Map,$(OUTPUT)-dfu_nocrcstub.map -o $@ $^ $(LIBS) + $(SILENT)$(NM) $@ >$@.txt + +$(C_OBJECTS_dfu): $(OBJ)/dfu_%.o: %.c Makefile $(OBJ) $(BIN) + @echo [COMPILING $<] + $(SILENT)$(CC) $(CFLAGS) -DENVIRONMENT_dfu -DENVIRONMENT=\"dfu\" -c -o $@ $< + +$(ASM_OBJECTS_dfu): $(OBJ)/dfu_%.o: %.S Makefile $(OBJ) $(BIN) + @echo [ASSEMBLING $@] + $(SILENT)$(CC) $(ASFLAGS) -DENVIRONMENT_dfu -DENVIRONMENT=\"dfu\" -c -o$@ $< + SERIAL ?= /dev/ttyUSB0 log: diff --git a/firmware/apps/blupdate/main.c b/firmware/apps/blupdate/main.c index e9ffe22..8c48e37 100644 --- a/firmware/apps/blupdate/main.c +++ b/firmware/apps/blupdate/main.c @@ -89,8 +89,14 @@ flash_cmd(EFC_FCMD_EA, 0); #endif flash_wait_ready(); - for (;;) - NVIC_SystemReset(); + for (;;) { + /* no functon call, since NVIC_SystemReset() might not be inlined! */ + SCB->AIRCR = ((0x5FA << SCB_AIRCR_VECTKEY_Pos) | (SCB->AIRCR & SCB_AIRCR_PRIGROUP_Msk) | + SCB_AIRCR_SYSRESETREQ_Msk); + __DSB(); + while (1) + ; + } } #define MAX_USB_ITER BOARD_MCK / 72 // This should be around a second diff --git a/firmware/libboard/common/resources/sam3s4/dfu.ld b/firmware/libboard/common/resources/sam3s4/dfu.ld index 7d896c6..86e6622 100644 --- a/firmware/libboard/common/resources/sam3s4/dfu.ld +++ b/firmware/libboard/common/resources/sam3s4/dfu.ld @@ -39,7 +39,8 @@ MEMORY { /* reserve the first 16k (= 0x4000) for the DFU bootloader */ - rom (rx) : ORIGIN = 0x00400000 + 16K, LENGTH = 256K - 16K /* flash, 256K */ + crcstub (rx) : ORIGIN = 0x00400000 + 16K, LENGTH = 512 /* crcstub part */ + rom (rx) : ORIGIN = 0x00400000 + 16K + 512, LENGTH = 256K - 16K - 512 /* flash, 256K */ /* note: dfudata will be at the start */ ram (rwx) : ORIGIN = 0x20000000, LENGTH = 48K /* SRAM, 48K */ } @@ -47,9 +48,17 @@ /* Section Definitions */ SECTIONS { - .text : - { + .crcstub : + { . = ALIGN(4); + KEEP(*(.crcstub_table)) + KEEP(*(.crcstub_code)) + } > crcstub = 0xff + + .text : + { + + . = ALIGN(512); _sfixed = .; KEEP(*(.vectors .vectors.*)) *(.text .text.* .gnu.linkonce.t.*) @@ -94,7 +103,7 @@ . = ALIGN(4); _efixed = .; /* End of text section */ - } > rom + } > rom = 0xff /DISCARD/ : { diff --git a/firmware/libboard/common/resources/sam3s4/flash.ld b/firmware/libboard/common/resources/sam3s4/flash.ld index 50631c6..b1de154 100644 --- a/firmware/libboard/common/resources/sam3s4/flash.ld +++ b/firmware/libboard/common/resources/sam3s4/flash.ld @@ -97,6 +97,8 @@ /DISCARD/ : { *(.ARM.exidx) + *(.crcstub_table) + *(.crcstub_code) } . = ALIGN(4); diff --git a/firmware/libcommon/source/crcstub.c b/firmware/libcommon/source/crcstub.c new file mode 100644 index 0000000..ef52521 --- /dev/null +++ b/firmware/libcommon/source/crcstub.c @@ -0,0 +1,86 @@ +/* SIMtrace 2 firmware crc stub + * + * (C) 2021 by sysmocom -s.f.m.c. GmbH, Author: Eric Wild + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include +#include "board.h" +#include "core_cm3.h" +#include "usb/device/dfu/dfu.h" + +/* +* This file is a bit special, everything has to go to specific sections, and no globals are available. +* No external functions may be called, unless inlining is enforced! +*/ + +static void crc_check_stub(); +__attribute__((section(".crcstub_table"))) volatile uint32_t crcstub_dummy_table[] = { + (uint32_t)0xdeadc0de, /* deliberately choose invalid value so unpatched image will not be started */ + (uint32_t)crc_check_stub, /* must be valid flash addr */ + (uint32_t)0xf1, /* crc value calculated by the host */ + (uint32_t)0xf2, /* crc calc start address */ + (uint32_t)0xf3 /* crc calc length (byte) */ +}; + +__attribute__((section(".crcstub_code"))) static void do_crc32(int8_t c, uint32_t *crc_reg) +{ + int32_t i, mask; + *crc_reg ^= c; + + for (unsigned int j = 0; j < 8; j++) + if (*crc_reg & 1) + *crc_reg = (*crc_reg >> 1) ^ 0xEDB88320; + else + *crc_reg = *crc_reg >> 1; +} + +__attribute__((section(".crcstub_code"), noinline)) static void crc_check_stub() +{ + uint32_t crc_reg = 0xffffffff; + uint32_t expected_crc_val = crcstub_dummy_table[2]; + uint8_t *crc_calc_startaddr = (uint8_t *)crcstub_dummy_table[3]; + volatile uint32_t *actual_exc_tbl = (volatile uint32_t *)crc_calc_startaddr; + uint32_t crc_len = crcstub_dummy_table[4]; + + /* 4000ms wdt tickling */ + WDT->WDT_MR = WDT_MR_WDRSTEN | WDT_MR_WDDBGHLT | WDT_MR_WDIDLEHLT | (((4000UL << 8) / 1000) << 16) | + ((4000UL << 8) / 1000); + + for (uint8_t *i = crc_calc_startaddr; i < crc_calc_startaddr + crc_len; i++) + do_crc32(*i, &crc_reg); + + crc_reg = ~crc_reg; + + if (crc_reg == expected_crc_val) { + /* this looks a bit awkward because we have to ensure the bx does not require a sp-relative load */ + __asm__ volatile("\ + mov r0, %0;\n\ + mov r1, %1;\n\ + MSR msp,r0;\n\ + bx r1;" + : + : "r"(actual_exc_tbl[0]), "r"(actual_exc_tbl[1])); + } else { + /* no globals ! */ + ((struct dfudata *)0x20000000)->magic = USB_DFU_MAGIC; + __DSB(); + for (;;) { + /* no functon call, since NVIC_SystemReset() might not be inlined! */ + SCB->AIRCR = ((0x5FA << SCB_AIRCR_VECTKEY_Pos) | (SCB->AIRCR & SCB_AIRCR_PRIGROUP_Msk) | + SCB_AIRCR_SYSRESETREQ_Msk); + __DSB(); + while (1) + ; + } + } +} diff --git a/firmware/misc/crctool.c b/firmware/misc/crctool.c new file mode 100644 index 0000000..2602753 --- /dev/null +++ b/firmware/misc/crctool.c @@ -0,0 +1,91 @@ +/* SIMtrace 2 firmware crc tool + * + * (C) 2021 by sysmocom -s.f.m.c. GmbH, Author: Eric Wild + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include +#include +#include + +static void do_crc32(int8_t c, uint32_t *crc_reg) +{ + int32_t i, mask; + *crc_reg ^= c; + + for (unsigned int j = 0; j < 8; j++) + if (*crc_reg & 1) + *crc_reg = (*crc_reg >> 1) ^ 0xEDB88320; + else + *crc_reg = *crc_reg >> 1; +} + +int main(int argc, char *argv[]) +{ + uint32_t crc_reg = 0xffffffff; + long fsize; + uint8_t *buffer; + uint32_t crc_start_offset; + + if (argc < 3) { + perror("usage: crctool startoffset blupdate.bin"); + return -1; + } + + crc_start_offset = strtoull(argv[1], 0, 10); + + FILE *blfile = fopen(argv[2], "rb+"); + if (blfile == NULL) { + perror("error opening file!"); + return -1; + } + + fseek(blfile, 0, SEEK_END); + fsize = ftell(blfile); + + if (fsize <= crc_start_offset) { + perror("file size?!"); + return -1; + } + + fseek(blfile, 0, SEEK_SET); + + buffer = malloc(fsize); + fread(buffer, 1, fsize, blfile); + + if (*(uint32_t *)buffer != 0xdeadc0de) { + perror("weird magic, not a valid blupdate file?"); + free(buffer); + return -1; + } + + uint8_t *startaddr = buffer + crc_start_offset; + uint8_t *endaddr = buffer + fsize; + for (uint8_t *i = startaddr; i < endaddr; i++) { + do_crc32(*i, &crc_reg); + } + crc_reg = ~crc_reg; + + fprintf(stderr, "len: %ld crc: %.8x\n", fsize - crc_start_offset, crc_reg); + + ((uint32_t *)buffer)[0] = 0x2000baa0; /* fix magic to valid stack address, checked by BL */ + ((uint32_t *)buffer)[2] = crc_reg; + ((uint32_t *)buffer)[3] = 0x00400000 + 0x4000 + crc_start_offset; + ((uint32_t *)buffer)[4] = fsize - crc_start_offset; + + fseek(blfile, 0, SEEK_SET); + fwrite(buffer, 4, 5, blfile); + + fclose(blfile); + free(buffer); + return 0; +} -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26463 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Id6df0486c8b779889d21800dc2441b3aa9af8a5f Gerrit-Change-Number: 26463 Gerrit-PatchSet: 9 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: tsaitgaist Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:04:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:04:31 +0000 Subject: Change in libosmocore[master]: stats: fix typo In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26568 ) Change subject: stats: fix typo ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26568 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If978daf8b5e58fd9c0a5ff989088a12abc98886a Gerrit-Change-Number: 26568 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 15 Dec 2021 14:04:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:04:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:04:40 +0000 Subject: Change in libosmocore[master]: stat_item: tolerate NULL pointer argument in osmo_stat_item_group_free In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26569 ) Change subject: stat_item: tolerate NULL pointer argument in osmo_stat_item_group_free ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I23323833e7268356a50c4fc6a19639c4ecd2a101 Gerrit-Change-Number: 26569 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 15 Dec 2021 14:04:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:04:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:04:44 +0000 Subject: Change in libosmocore[master]: stats: fix typo In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26568 ) Change subject: stats: fix typo ...................................................................... stats: fix typo Change-Id: If978daf8b5e58fd9c0a5ff989088a12abc98886a --- M src/stats.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/stats.c b/src/stats.c index 4fb20e2..f8c91fd 100644 --- a/src/stats.c +++ b/src/stats.c @@ -407,7 +407,7 @@ /*! Set the name prefix of a given stats_reporter. * \param[in] srep stats_reporter whose name prefix is to be set - * \param[in] prefix NAme perfix to pre-pend for any reported value + * \param[in] prefix Name prefix to pre-pend for any reported value * \returns 0 on success; negative on error */ int osmo_stats_reporter_set_name_prefix(struct osmo_stats_reporter *srep, const char *prefix) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26568 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If978daf8b5e58fd9c0a5ff989088a12abc98886a Gerrit-Change-Number: 26568 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:04:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:04:45 +0000 Subject: Change in libosmocore[master]: stat_item: tolerate NULL pointer argument in osmo_stat_item_group_free In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26569 ) Change subject: stat_item: tolerate NULL pointer argument in osmo_stat_item_group_free ...................................................................... stat_item: tolerate NULL pointer argument in osmo_stat_item_group_free Just like rate_ctr_group_free, osmo_stat_item_group_free should tolerate it when the argument is NULL Change-Id: I23323833e7268356a50c4fc6a19639c4ecd2a101 --- M src/stat_item.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/stat_item.c b/src/stat_item.c index 1f398d5..804972b 100644 --- a/src/stat_item.c +++ b/src/stat_item.c @@ -224,6 +224,9 @@ /*! Free the memory for the specified group of stat items */ void osmo_stat_item_group_free(struct osmo_stat_item_group *grp) { + if (!grp) + return; + llist_del(&grp->list); talloc_free(grp); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I23323833e7268356a50c4fc6a19639c4ecd2a101 Gerrit-Change-Number: 26569 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:19:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:19:45 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 ) Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 13 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 15 Dec 2021 14:19:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:19:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:19:50 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK audio SAPI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 ) Change subject: First implementation of the LLSK audio SAPI ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d Gerrit-Change-Number: 26502 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 15 Dec 2021 14:19:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:19:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:19:52 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 ) Change subject: First implementation of the LLSK gtp SAPI ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 15 Dec 2021 14:19:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:20:53 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:20:53 +0000 Subject: Change in osmo-hnodeb[master]: Update AUDIO and GTP SAPs to support multiple conns per UE In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 ) Change subject: Update AUDIO and GTP SAPs to support multiple conns per UE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ib3f60d5ba21defe5259c25e2034fc2217c4d93df Gerrit-Change-Number: 26570 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 15 Dec 2021 14:20:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:21:21 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:21:21 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: set default {hbh, ete}_id in ts_DIAMETER In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 ) Change subject: library/DIAMETER_Templates: set default {hbh,ete}_id in ts_DIAMETER ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I714b18bbe77949593803e999d25e4ef8e1827917 Gerrit-Change-Number: 26511 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 14:21:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:21:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:21:52 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: rework existing ULR/ULA templates In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 ) Change subject: library/DIAMETER_Templates: rework existing ULR/ULA templates ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0585e306a87453c212c6b5ac5635181c47b34b4f Gerrit-Change-Number: 26513 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 14:21:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: set default {hbh, ete}_id in ts_DIAMETER In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 ) Change subject: library/DIAMETER_Templates: set default {hbh,ete}_id in ts_DIAMETER ...................................................................... library/DIAMETER_Templates: set default {hbh,ete}_id in ts_DIAMETER Having default values for these parameters allows omitting them in subsequent send template definitions based on ts_DIAMETER. Change-Id: I714b18bbe77949593803e999d25e4ef8e1827917 Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 2cc2986..b27d144 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -110,8 +110,8 @@ ts_DIAMETER(template (value) BIT8 flags, template (value) Command_Code cmd_code, template (value) OCTET4 app_id := '00000000'O, - template (value) UINT32 hbh_id, - template (value) UINT32 ete_id, + template (value) UINT32 hbh_id := '00000000'O, + template (value) UINT32 ete_id := '00000000'O, template (value) AVP_list avps := {} ) := { version := 1, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I714b18bbe77949593803e999d25e4ef8e1827917 Gerrit-Change-Number: 26511 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add templates for DWR/DWA In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26512 ) Change subject: library/DIAMETER_Templates: add templates for DWR/DWA ...................................................................... library/DIAMETER_Templates: add templates for DWR/DWA Change-Id: I2abe33a3ac08c8855342f4277288cacb3545771b Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 86 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index b27d144..fd4683e 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -244,6 +244,14 @@ } } } +template (present) GenericAVP tr_AVP_OriginStateId(template (present) OCTET4 state_id := ?) := { + avp := { + avp_header := tr_DIA_Hdr(c_AVP_Code_BASE_NONE_Origin_State_Id), + avp_data := { + avp_BASE_NONE_Origin_State_Id := state_id + } + } +} template (value) GenericAVP ts_AVP_HostIpAddr(template (value) OCTET4 ipv4_addr) := { avp := { @@ -391,6 +399,14 @@ } } } +template (present) GenericAVP tr_AVP_ResultCode(DIAMETER_Resultcode res_code) := { + avp := { + avp_header := tr_DIA_Hdr(c_AVP_Code_BASE_NONE_Result_Code), + avp_data := { + avp_BASE_NONE_Result_Code := int2oct(enum2int(res_code), 4) + } + } +} template (value) GenericAVP ts_AVP_AuthSessionState(template (value) BASE_NONE_Auth_Session_State ass := NO_STATE_MAINTAINED) := { avp := { @@ -963,4 +979,74 @@ // origin }); +/* RFC 6733, section 5.5.1 "Device-Watchdog-Request" */ +template (value) PDU_DIAMETER +ts_DIA_DWR(template (value) OCTET4 state_id := '00000000'O, + template (value) charstring orig_host := "ttcn3.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) UINT32 hbh_id := '00000000'O, + template (value) UINT32 ete_id := '00000000'O) := + ts_DIAMETER(flags := '10000000'B, + cmd_code := Device_Watchdog, + app_id := '00000000'O, + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_OriginStateId(state_id) + }); +template (present) PDU_DIAMETER +tr_DIA_DWR(template (present) OCTET4 state_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '1???????'B, + cmd_code := Device_Watchdog, + app_id := '00000000'O, + hbh_id := hbh_id, + ete_id := ete_id, + avps := superset( + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm), + tr_AVP_OriginStateId(state_id) + )); + +/* RFC 6733, section 5.5.2 "Device-Watchdog-Answer" */ +template (value) PDU_DIAMETER +ts_DIA_DWA(template (value) OCTET4 state_id := '00000000'O, + template (value) charstring orig_host := "ttcn3.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) UINT32 hbh_id := '00000000'O, + template (value) UINT32 ete_id := '00000000'O) := + ts_DIAMETER(flags := '00000000'B, + cmd_code := Device_Watchdog, + app_id := '00000000'O, + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_ResultCode(DIAMETER_SUCCESS), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_OriginStateId(state_id) + }); +template (present) PDU_DIAMETER +tr_DIA_DWA(template (present) OCTET4 state_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '0???????'B, + cmd_code := Device_Watchdog, + app_id := '00000000'O, + hbh_id := hbh_id, + ete_id := ete_id, + avps := superset( + tr_AVP_ResultCode(DIAMETER_SUCCESS), + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm), + tr_AVP_OriginStateId(state_id) + )); + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2abe33a3ac08c8855342f4277288cacb3545771b Gerrit-Change-Number: 26512 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: rework existing ULR/ULA templates In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 ) Change subject: library/DIAMETER_Templates: rework existing ULR/ULA templates ...................................................................... library/DIAMETER_Templates: rework existing ULR/ULA templates * Make both {hbh,ete}_id parameters last among the others; * Use more elegant and consistent template formatting; * Make Origin{Host,Realm} values configurable; * Make DestinationRealm value configurable; * Make SessionId value configurable. Change-Id: I0585e306a87453c212c6b5ac5635181c47b34b4f Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn M mme/MME_Tests.ttcn 2 files changed, 46 insertions(+), 28 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index fd4683e..4cd2b6b 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -106,6 +106,8 @@ const uint32_t c_DIAMETER_3GPP_S13_AID := 16777252; const uint32_t c_DIAMETER_3GPP_S7_AID := 16777308; +const octetstring c_def_sess_id := char2oct("ttcn3.session"); + template (value) PDU_DIAMETER ts_DIAMETER(template (value) BIT8 flags, template (value) Command_Code cmd_code, @@ -908,34 +910,50 @@ /* TS 29.262 7.2.3 Update Location Request */ template (present) PDU_DIAMETER -tr_DIA_ULR(hexstring imsi) := tr_DIAMETER(flags:='11000000'B, cmd_code:=Update_Location, - app_id:=int2oct(c_DIAMETER_3GPP_S6_AID, 4), - avps := superset( - tr_AVP_SessionId, - tr_AVP_AuthSessionState, - tr_AVP_OriginHost, - tr_AVP_OriginRealm, - tr_AVP_DestinationRealm, - tr_AVP_UserNameImsi(imsi), - tr_AVP_3GPP_RatType(EUTRAN), - tr_AVP_3GPP_UlrFlags, - tr_AVP_3GPP_VisitedPlmnId +tr_DIA_ULR(/* template (present) */ hexstring imsi, + template (present) octetstring sess_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) charstring dest_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '11000000'B, + cmd_code := Update_Location, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + tr_AVP_AuthSessionState, + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm), + tr_AVP_DestinationRealm(dest_realm), + tr_AVP_UserNameImsi(imsi), + tr_AVP_3GPP_RatType(EUTRAN), + tr_AVP_3GPP_UlrFlags, + tr_AVP_3GPP_VisitedPlmnId )); template (value) PDU_DIAMETER -ts_DIA_ULA(template (value) UINT32 hbh_id, template (value) UINT32 ete_id, - template (value) octetstring sess_id, - template (value) AVP_list sub_data_content) -:= ts_DIAMETER(flags:='01000000'B, cmd_code:=Update_Location, - app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), hbh_id:=hbh_id, ete_id:=ete_id, - avps := { - ts_AVP_SessionId(sess_id), - ts_AVP_ResultCode(DIAMETER_SUCCESS), /* optional */ - ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), - ts_AVP_OriginHost("hss.localdomain"), - ts_AVP_OriginRealm("localdomain"), - ts_AVP_3GPP_UlaFlags('00000002'O), - ts_AVP_3GPP_SubscriptionData(sub_data_content) +ts_DIA_ULA(template (value) AVP_list sub_data, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "hss.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) UINT32 hbh_id := '00000000'O, + template (value) UINT32 ete_id := '00000000'O) := + ts_DIAMETER(flags:='01000000'B, + cmd_code := Update_Location, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + ts_AVP_ResultCode(DIAMETER_SUCCESS), /* optional */ + ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_3GPP_UlaFlags('00000002'O), + ts_AVP_3GPP_SubscriptionData(sub_data) }); diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index f9bcf6d..2140971 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -493,14 +493,12 @@ var PDU_DIAMETER rx_dia; [] DIAMETER.receive(tr_DIA_ULR(g_pars.ue_pars.imsi)) -> value rx_dia { var template (omit) AVP avp; - var octetstring sess_id; var hexstring imsi; var template (value) AVP_list sub_data; /* retrieve input data */ imsi := valueof(f_DIAMETER_get_imsi(rx_dia)); avp := f_DIAMETER_get_avp(rx_dia, c_AVP_Code_BASE_NONE_Session_Id); - sess_id := valueof(avp.avp_data.avp_BASE_NONE_Session_Id); sub_data := { ts_AVP_3GPP_SubscriberStatus(SERVICE_GRANTED), @@ -513,7 +511,9 @@ }) }; - DIAMETER.send(ts_DIA_ULA(rx_dia.hop_by_hop_id, rx_dia.end_to_end_id, sess_id, sub_data)); + DIAMETER.send(ts_DIA_ULA(sub_data, avp.avp_data.avp_BASE_NONE_Session_Id, + hbh_id := rx_dia.hop_by_hop_id, + ete_id := rx_dia.end_to_end_id)); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0585e306a87453c212c6b5ac5635181c47b34b4f Gerrit-Change-Number: 26513 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add missing templates for ULR/ULA In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26514 ) Change subject: library/DIAMETER_Templates: add missing templates for ULR/ULA ...................................................................... library/DIAMETER_Templates: add missing templates for ULR/ULA Change-Id: If0b8daf5717eb4c26da231489118e200faeee9a2 Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 54 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 4cd2b6b..45a4a99 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -560,6 +560,15 @@ } } } +template (present) GenericAVP +tr_AVP_3GPP_SubscriptionData(template (present) AVP_list content := ?) := { + avp := { + avp_header := tr_DIA_Hdr_3GPP(c_AVP_Code_AAA_3GPP_Subscription_Data), + avp_data := { + avp_AAA_3GPP_Subscription_Data := content + } + } +} /* TS 29.262 7.3.17 Authentication-Info */ @@ -909,6 +918,30 @@ /* TS 29.262 7.2.3 Update Location Request */ +template (value) PDU_DIAMETER +ts_DIA_ULR(/* template (value) */ hexstring imsi, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "ttcn3.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) charstring dest_realm := "localdomain", + template (value) UINT32 hbh_id := '00000000'O, + template (value) UINT32 ete_id := '00000000'O) := + ts_DIAMETER(flags := '11000000'B, + cmd_code := Update_Location, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), + ts_AVP_UserNameImsi(imsi), + ts_AVP_3GPP_UlrFlags('00000000'O), + ts_AVP_3GPP_VisitedPlmnId('11111F'O), + ts_AVP_3GPP_RatType(EUTRAN), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_DestinationRealm(dest_realm) + }); template (present) PDU_DIAMETER tr_DIA_ULR(/* template (present) */ hexstring imsi, template (present) octetstring sess_id := ?, @@ -955,6 +988,27 @@ ts_AVP_3GPP_UlaFlags('00000002'O), ts_AVP_3GPP_SubscriptionData(sub_data) }); +template (present) PDU_DIAMETER +tr_DIA_ULA(template (present) AVP_list sub_data := ?, + template (present) octetstring sess_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '0???????'B, + cmd_code := Update_Location, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + tr_AVP_ResultCode(DIAMETER_SUCCESS), + tr_AVP_AuthSessionState, + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm), + tr_AVP_3GPP_UlaFlags, + tr_AVP_3GPP_SubscriptionData(sub_data) + )); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0b8daf5717eb4c26da231489118e200faeee9a2 Gerrit-Change-Number: 26514 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:02 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: prettify & enrich AIR/AIA templates In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26515 ) Change subject: library/DIAMETER_Templates: prettify & enrich AIR/AIA templates ...................................................................... library/DIAMETER_Templates: prettify & enrich AIR/AIA templates * Make both {hbh,ete}_id parameters last among the others; * Use more elegant and consistent template formatting; * Make DestinationRealm value configurable; * Make SessionId value configurable. Change-Id: Iaf6472fecbadd58e86b78c59348d9924ab57f97d Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn M mme/MME_Tests.ttcn 2 files changed, 51 insertions(+), 33 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 45a4a99..256a4d4 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -877,43 +877,60 @@ template (value) PDU_DIAMETER -ts_DIA_AIR(template (value) UINT32 hbh_id, template (value) UINT32 ete_id, - template (value) octetstring sess_id, - template (value) charstring dest_realm, hexstring imsi) -:= ts_DIAMETER(flags:='00000000'B, cmd_code:=Authentication_Information, hbh_id:=hbh_id, ete_id:=ete_id, - avps := { - ts_AVP_SessionId(sess_id), - ts_AVP_DestinationRealm(dest_realm), - ts_AVP_UserNameImsi(imsi), - /* Requested EUTRAN Auth Info */ - ts_AVP_RequestedEutranAuthInfo, - ts_AVP_3GPP_VisitedPlmnId('11111F'O) +ts_DIA_AIR(/* template (value) */ hexstring imsi, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring dest_realm := "localdomain", + template (value) UINT32 hbh_id := '00000000'O, + template (value) UINT32 ete_id := '00000000'O) := + ts_DIAMETER(flags := '00000000'B, + cmd_code := Authentication_Information, + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + ts_AVP_DestinationRealm(dest_realm), + ts_AVP_UserNameImsi(imsi), + /* Requested EUTRAN Auth Info */ + ts_AVP_RequestedEutranAuthInfo, + ts_AVP_3GPP_VisitedPlmnId('11111F'O) }); - template (present) PDU_DIAMETER -tr_DIA_AIR(hexstring imsi) := tr_DIAMETER(flags := '11000000'B, cmd_code:=Authentication_Information, - app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), - avps := superset( - tr_AVP_SessionId, - tr_AVP_DestinationRealm, - tr_AVP_UserNameImsi(imsi), - tr_AVP_3GPP_VisitedPlmnId +tr_DIA_AIR(/* template (present) */ hexstring imsi, + template (present) octetstring sess_id := ?, + template (present) charstring dest_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '11000000'B, + cmd_code := Authentication_Information, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + tr_AVP_DestinationRealm(dest_realm), + tr_AVP_UserNameImsi(imsi), + tr_AVP_3GPP_VisitedPlmnId )); /* TS 29.262 5.2.3.1 + 7.2.6 Authentication Information Answer */ template (value) PDU_DIAMETER -ts_DIA_AIA(template (value) UINT32 hbh_id, template (value) UINT32 ete_id, - template (value) octetstring sess_id, - template (value) AVP_list auth_info_contents) -:= ts_DIAMETER(flags:='01000000'B, cmd_code:=Authentication_Information, - app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), hbh_id:=hbh_id, ete_id:=ete_id, - avps := { - ts_AVP_SessionId(sess_id), - ts_AVP_ResultCode(DIAMETER_SUCCESS), - ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), - ts_AVP_OriginHost("hss.localdomain"), - ts_AVP_OriginRealm("localdomain"), - ts_AVP_3GPP_AuthInfo(auth_info_contents) +ts_DIA_AIA(template (value) AVP_list auth_info_contents, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "hss.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) UINT32 hbh_id := '00000000'O, + template (value) UINT32 ete_id := '00000000'O) := + ts_DIAMETER(flags := '01000000'B, + cmd_code := Authentication_Information, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + ts_AVP_ResultCode(DIAMETER_SUCCESS), + ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_3GPP_AuthInfo(auth_info_contents) }); diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 2140971..375a66a 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -483,8 +483,9 @@ /* compute tuple */ auth_info_content := { ts_AVP_EutranVec(1, '20080c3818183b522614162c07601d0d'O, '6a91970e838fd079'O, 'f11b89a2a8be00001f9c526f3d75d44c'O, '95AFAD9A0D29AFAA079A9451DF7161D7EE4CBF2AF9387F766D058BB6B44B905D'O) }; - DIAMETER.send(ts_DIA_AIA(rx_dia.hop_by_hop_id, rx_dia.end_to_end_id, - sess_id, auth_info_content)); + DIAMETER.send(ts_DIA_AIA(auth_info_content, sess_id, + hbh_id := rx_dia.hop_by_hop_id, + ete_id := rx_dia.end_to_end_id)); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf6472fecbadd58e86b78c59348d9924ab57f97d Gerrit-Change-Number: 26515 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:02 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add receive template for AIA In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26516 ) Change subject: library/DIAMETER_Templates: add receive template for AIA ...................................................................... library/DIAMETER_Templates: add receive template for AIA Change-Id: Ie4aca42c3024aa7f46123b2df4a42c5d43f5b9da Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 29 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 256a4d4..a30a565 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -580,6 +580,15 @@ } } } +template (present) GenericAVP +tr_AVP_3GPP_AuthInfo(template (present) AVP_list content := ?) := { + avp := { + avp_header := tr_DIA_Hdr_3GPP(c_AVP_Code_AAA_3GPP_Authentication_Info), + avp_data := { + avp_AAA_3GPP_Authentication_Info := content + } + } +} /* TS 29.262 7.3.9 Visited-PLMN-Id */ template (value) GenericAVP ts_AVP_3GPP_VisitedPlmnId(template (value) octetstring id) := { @@ -932,6 +941,26 @@ ts_AVP_OriginRealm(orig_realm), ts_AVP_3GPP_AuthInfo(auth_info_contents) }); +template (present) PDU_DIAMETER +tr_DIA_AIA(template (present) AVP_list auth_info_contents := ?, + template (present) octetstring sess_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '0???????'B, + cmd_code := Authentication_Information, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + tr_AVP_ResultCode(DIAMETER_SUCCESS), + tr_AVP_AuthSessionState(NO_STATE_MAINTAINED), + tr_AVP_3GPP_AuthInfo(auth_info_contents), + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm) + )); /* TS 29.262 7.2.3 Update Location Request */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4aca42c3024aa7f46123b2df4a42c5d43f5b9da Gerrit-Change-Number: 26516 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:19 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: fix flags in AIR templates In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 ) Change subject: library/DIAMETER_Templates: fix flags in AIR templates ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7db3b632189eed09c1bdf98f9d588491d928e2f5 Gerrit-Change-Number: 26517 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 14:22:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:28 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: fix flags in AIR templates In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 ) Change subject: library/DIAMETER_Templates: fix flags in AIR templates ...................................................................... library/DIAMETER_Templates: fix flags in AIR templates According to RFC 6733, section 3 "Diameter Header", if the 'R' bit is set, the message is a request. If the 'P' bit is set, the message may be proxied, relayed, or redirected. ts_DIA_AIR is a template for Authentication Information *Request*, so the 'R' bit must be set. Also, let's allow this message to be proxied, relayed, or redirected by setting the 'P' bit by default. In tr_DIA_AIR, do not match all command flags, just ensure that the message is a request. Other flags do not matter. Change-Id: I7db3b632189eed09c1bdf98f9d588491d928e2f5 Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index a30a565..1b3ffdb 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -891,7 +891,7 @@ template (value) charstring dest_realm := "localdomain", template (value) UINT32 hbh_id := '00000000'O, template (value) UINT32 ete_id := '00000000'O) := - ts_DIAMETER(flags := '00000000'B, + ts_DIAMETER(flags := '11000000'B, cmd_code := Authentication_Information, hbh_id := hbh_id, ete_id := ete_id, @@ -909,7 +909,7 @@ template (present) charstring dest_realm := ?, template (present) UINT32 hbh_id := ?, template (present) UINT32 ete_id := ?) := - tr_DIAMETER(flags := '11000000'B, + tr_DIAMETER(flags := '1???????'B, cmd_code := Authentication_Information, app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), hbh_id := hbh_id, ete_id := ete_id, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7db3b632189eed09c1bdf98f9d588491d928e2f5 Gerrit-Change-Number: 26517 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:29 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: fix missing app_id in ts_DIA_AIR In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26518 ) Change subject: library/DIAMETER_Templates: fix missing app_id in ts_DIA_AIR ...................................................................... library/DIAMETER_Templates: fix missing app_id in ts_DIA_AIR Change-Id: I7b06d9cad09f1fd7858bd745d0aaa2fbcb1983dd Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 1b3ffdb..bd9ee21 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -893,6 +893,7 @@ template (value) UINT32 ete_id := '00000000'O) := ts_DIAMETER(flags := '11000000'B, cmd_code := Authentication_Information, + app_id := int2oct(c_DIAMETER_3GPP_S6_AID, 4), hbh_id := hbh_id, ete_id := ete_id, avps := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b06d9cad09f1fd7858bd745d0aaa2fbcb1983dd Gerrit-Change-Number: 26518 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Templates: add missing AVPs to AIR In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26519 ) Change subject: library/DIAMETER_Templates: add missing AVPs to AIR ...................................................................... library/DIAMETER_Templates: add missing AVPs to AIR Change-Id: I948072dbfa05d158483a727fb708f853741ab23f Related: SYS#5602 --- M library/DIAMETER_Templates.ttcn 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index bd9ee21..b56363f 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -888,6 +888,8 @@ template (value) PDU_DIAMETER ts_DIA_AIR(/* template (value) */ hexstring imsi, template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "ttcn3.localdomain", + template (value) charstring orig_realm := "localdomain", template (value) charstring dest_realm := "localdomain", template (value) UINT32 hbh_id := '00000000'O, template (value) UINT32 ete_id := '00000000'O) := @@ -899,9 +901,12 @@ avps := { ts_AVP_SessionId(sess_id), ts_AVP_DestinationRealm(dest_realm), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), ts_AVP_UserNameImsi(imsi), /* Requested EUTRAN Auth Info */ ts_AVP_RequestedEutranAuthInfo, + ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), ts_AVP_3GPP_VisitedPlmnId('11111F'O) }); template (present) PDU_DIAMETER -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I948072dbfa05d158483a727fb708f853741ab23f Gerrit-Change-Number: 26519 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: handle DWR/DWA ping-pong In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26520 ) Change subject: library/DIAMETER_Emulation: handle DWR/DWA ping-pong ...................................................................... library/DIAMETER_Emulation: handle DWR/DWA ping-pong Change-Id: I0291eccd0467f8fe15ddcb88259618365c33befd Related: SYS#5602 --- M library/DIAMETER_Emulation.ttcn 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/DIAMETER_Emulation.ttcn b/library/DIAMETER_Emulation.ttcn index f7a0f88..220ab11 100644 --- a/library/DIAMETER_Emulation.ttcn +++ b/library/DIAMETER_Emulation.ttcn @@ -328,6 +328,14 @@ /* notify our user that the CER->CEA exchange has happened */ DIAMETER_UNIT.send(DiameterCapabilityExchgInd:{rx:=mrf.msg, tx:=valueof(resp)}); } + /* handle DWR/DWA ping-pong */ + [] DIAMETER.receive(tr_DIAMETER_RecvFrom_R(tr_DIA_DWR)) -> value mrf { + var template (value) PDU_DIAMETER resp; + resp := ts_DIA_DWA('00000001'O, p.origin_host, p.origin_realm, + hbh_id := mrf.msg.hop_by_hop_id, + ete_id := mrf.msg.end_to_end_id); + DIAMETER.send(t_DIAMETER_Send(g_diameter_conn_id, valueof(resp))); + } /* DIAMETER from remote peer */ [] DIAMETER.receive(tr_DIAMETER_RecvFrom_R(?)) -> value mrf { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0291eccd0467f8fe15ddcb88259618365c33befd Gerrit-Change-Number: 26520 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:50 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 ) Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 8 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 15 Dec 2021 14:22:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:22:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:22:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add audio SAPI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 ) Change subject: hnodeb: Add audio SAPI ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 Gerrit-Change-Number: 26444 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 15 Dec 2021 14:22:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:23:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:23:02 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add gtp SAPI In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 ) Change subject: hnodeb: Add gtp SAPI ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 Gerrit-Change-Number: 26445 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 15 Dec 2021 14:23:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:23:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:23:18 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Adapt HNBLIF to latest changes In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26571 ) Change subject: hnodeb: Adapt HNBLIF to latest changes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50a1b9be579ace9f0f85c6c68b5648d504f5f51c Gerrit-Change-Number: 26571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 15 Dec 2021 14:23:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:23:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:23:23 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add initial infra to emulate HNB LL socket iface In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 ) Change subject: hnodeb: Add initial infra to emulate HNB LL socket iface ...................................................................... hnodeb: Add initial infra to emulate HNB LL socket iface Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.default M hnodeb/HNB_Tests.ttcn M hnodeb/gen_links.sh M hnodeb/regen_makefile.sh A library/HNBLLIF_CodecPort.ttcn A library/HNBLLIF_Templates.ttcn A library/HNBLLIF_Types.ttcn M library/Iuh_CodecPort.ttcn 9 files changed, 820 insertions(+), 37 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn index 071e3e8..554c35f 100644 --- a/hnodeb/HNBGW_ConnectionHandler.ttcn +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -27,11 +27,19 @@ import from Iuh_Emulation all; +import from HNBLLIF_CodecPort all; +import from HNBLLIF_Types all; +import from HNBLLIF_Templates all; + /* this component represents a single Iuh connection at the HNBGW. */ type component HNBGW_ConnHdlr extends StatsD_ConnHdlr { port TELNETasp_PT HNBVTY; port HNBAP_PT HNBAP; port RUA_PT RUA; + /* HNBLLIF Interface of HNodeB */ + port HNBLLIF_CODEC_PT LLSK; + var integer g_llsk_conn_id; + var TestHdlrParams g_pars; var boolean g_vty_initialized := false; @@ -47,12 +55,11 @@ } /* initialize all parameters */ -function f_HNBGW_ConnHdlr_init(TestHdlrParams pars) runs on HNBGW_ConnHdlr { - var integer i := 0; +function f_HNBGW_ConnHdlr_init(charstring id, TestHdlrParams pars) runs on HNBGW_ConnHdlr { var Iuh_Emulation_CT vc_Iuh; g_pars := valueof(pars); - vc_Iuh := Iuh_Emulation_CT.create("HNBGW" & int2str(i)); + vc_Iuh := Iuh_Emulation_CT.create(id & "-HNBGW"); connect(self:HNBAP, vc_Iuh:HNBAP); connect(self:RUA, vc_Iuh:RUA); @@ -61,18 +68,51 @@ iuh_pars.remote_sctp_port := -1; iuh_pars.local_ip := g_pars.hnbgw_addr; iuh_pars.local_sctp_port := g_pars.hnbgw_port; - vc_Iuh.start(Iuh_Emulation.main(iuh_pars, "Iuh" & int2str(i))); + vc_Iuh.start(Iuh_Emulation.main(iuh_pars, id & "-Iuh")); f_HNBGW_ConnHdlr_init_vty(); + + /* Connect to HNB on LLSK and do HELLO ping-pong */ + f_start_hnbllif(LLSK, id & "-LLSK", g_pars.hnbllif_sk_path, g_llsk_conn_id); +} + + +function f_start_hnbllif(HNBLLIF_CODEC_PT pt, charstring id, charstring hnbllif_sk_path, out integer hnbllif_conn_id) { + timer T := 2.0; + var HNBLLIF_send_data sd; + var HNBLLIF_Message last_hello_cnf; + if (hnbllif_sk_path == "") { + hnbllif_conn_id := -1; + return; + } + hnbllif_conn_id := f_hnbllif_connect(pt, hnbllif_sk_path); + + T.start; + pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_CTL, HNBLLIF_Types.mp_hnbllif_version))); + alt { + [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_CTL, HNBLLIF_Types.mp_hnbllif_version); + [] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=CTL"); + } + } + pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_IUH, 0))); + alt { + [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_IUH, 0); + [] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=IUH"); + } + } } type record TestHdlrParams { + charstring hnbllif_sk_path, /* "" means don't connect */ charstring hnbgw_addr, charstring hnodeb_addr, integer hnbgw_port, uint16_t rnc_id, charstring hNB_Identity_Info, - OCT3 plmnid, + uint16_t mcc, + uint16_t mnc, uint32_t cell_identity, uint16_t lac, uint8_t rac, @@ -82,23 +122,61 @@ /* Note: Do not use valueof() to get a value of this template, use * f_gen_test_hdlr_pars() instead in order to get a configuration. */ template (value) TestHdlrParams t_def_TestHdlrPars := { + hnbllif_sk_path := HNBLL_SOCK_DEFAULT, hnbgw_addr := "127.0.0.1", hnodeb_addr := "127.0.0.1", hnbgw_port := 29169, rnc_id := 23, hNB_Identity_Info := "OsmoHNodeB", - plmnid := '00F110'O, + mcc := 1, + mnc := 1, cell_identity := 1, lac := 2, rac := 3, sac := 4 } +/* HNBLLIF socket may at any time receive a new INFO.ind */ +altstep as_hnbllif_hello_cnf(HNBLLIF_CODEC_PT pt, integer hnbllif_conn_id, + out HNBLLIF_Message last_hello_cnf, + template (present) HNBLLIF_Sapi exp_sapi := ?, + template (present) uint16_t exp_version := ?) { + var HNBLLIF_send_data sd; + [] pt.receive(t_SD_HNBLLIF(hnbllif_conn_id, tr_HNBLLIF_CTL_HELLO_CNF(exp_sapi, exp_version))) -> value sd { + last_hello_cnf := sd.data; + } + [] pt.receive(t_SD_HNBLLIF(hnbllif_conn_id, tr_HNBLLIF_CTL_HELLO_CNF(?))) -> value sd { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Invalid API_VERSION received"); + } +} + +function f_llsk_rx(template (present) HNBLLIF_Message exp_tmpl) runs on HNBGW_ConnHdlr +return template (present) HNBLLIF_send_data { + return t_SD_HNBLLIF(g_llsk_conn_id, exp_tmpl); +} + +function f_llsk_tx(template (value) HNBLLIF_Message tx_msg) runs on HNBGW_ConnHdlr +return template (value) HNBLLIF_send_data { + return ts_SD_HNBLLIF(g_llsk_conn_id, tx_msg); +} + +function f_enc_mcc_mnc(uint16_t mcc_uint, uint16_t mnc_uint) return OCT3 { + var hexstring mnc; + var hexstring mcc := int2hex(mcc_uint, 3); + + if (mnc_uint < 100) { + mnc := int2hex(mnc_uint, 2); + return hex2oct(mcc[1] & mcc[0] & 'F'H & mcc[2] & mnc[1] & mnc[0]); + } else { + mnc := int2hex(mnc_uint, 3); + return hex2oct(mcc[1] & mcc[0] & mnc[2] & mcc[2] & mnc[1] & mnc[0]); + } +} function f_handle_hnbap_hnb_register_req() runs on HNBGW_ConnHdlr { HNBAP.receive(tr_HNBAP_HNBRegisterRequest(char2oct(g_pars.hNB_Identity_Info), - g_pars.plmnid, + f_enc_mcc_mnc(g_pars.mcc, g_pars.mnc), int2bit(g_pars.cell_identity, 28), int2oct(g_pars.lac, 2), int2oct(g_pars.rac, 1), diff --git a/hnodeb/HNB_Tests.default b/hnodeb/HNB_Tests.default index a06dcc6..c385b9a 100644 --- a/hnodeb/HNB_Tests.default +++ b/hnodeb/HNB_Tests.default @@ -20,6 +20,7 @@ *.STATSVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" *.STATSVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" *.STATSVTY.PROMPT1 := "OsmoHNodeB> " +*.LLSK.socket_type := "SEQPACKET" [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoHNodeB"; diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index 7a668dd..59dd1ee 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -38,10 +38,16 @@ import from TELNETasp_PortType all; import from HNBAP_Templates all; +import from RUA_IEs all; +import from RUA_Templates all; import from HNBGW_ConnectionHandler all; import from Iuh_Emulation all; +import from HNBLLIF_CodecPort all; +import from HNBLLIF_Types all; +import from HNBLLIF_Templates all; + modulepar { /* IP address at which the HNodeB can be reached */ charstring mp_hnodeb_ip := "127.0.0.1"; @@ -49,11 +55,23 @@ /* IP address at which the test binds */ charstring mp_hnbgw_iuh_ip := "127.0.0.1"; integer mp_hnbgw_iuh_port := 29169; + + charstring mp_hnbllif_sk_path := HNBLL_SOCK_DEFAULT; } +const hexstring ranap_cm_service_req := '001340400000060003400100000f40060000f11028b6003a40080000f110ffffffff0010400e0d052411035758a605f44e9d4aef004f400300001c0056400500f1100017'H; +const hexstring ranap_auth_req := '00144032000002001040262505120217dc146aeac56cb5ff6d5fb51f47f19220108ca5a6d0c8110000b9e9272498872764003b400100'H; +const hexstring ranap_auth_resp := '001440140000010010400d0c0554ccbdd0302104002f3ae4'H; +const hexstring ranap_paging := '000e401e0000030003400100001740095000010100000000f10040400500b6cf4773'H; +const hexstring iu_release_compl := '20010003000000'H; + type component test_CT extends CTRL_Adapter_CT { port TELNETasp_PT HNBVTY; + /* HNBLLIF Interface of HNodeB */ + port HNBLLIF_CODEC_PT LLSK; + var integer g_llsk_conn_id; + /* global test case guard timer (actual timeout value is set in f_init()) */ timer T_guard := 30.0; } @@ -83,6 +101,12 @@ f_vty_set_prompts(HNBVTY); f_vty_transceive(HNBVTY, "enable"); } + +private function f_init_hnbllif() runs on test_CT { + map(self:LLSK, system:LLSK); + f_start_hnbllif(LLSK, testcasename(), mp_hnbllif_sk_path, g_llsk_conn_id); +} + /* global initialization function */ function f_init(float guard_timeout := 30.0) runs on test_CT { var integer bssap_idx; @@ -91,8 +115,6 @@ activate(as_Tguard()); f_init_vty("VirtHNBGW"); - - /* TODO: Wait for Iuh connection to be established */ } friend function f_shutdown_helper() runs on test_CT { @@ -101,9 +123,10 @@ mtc.stop; } -friend function f_gen_test_hdlr_pars() return TestHdlrParams { +private function f_gen_test_hdlr_pars() runs on test_CT return TestHdlrParams { var TestHdlrParams pars := valueof(t_def_TestHdlrPars); + pars.hnbllif_sk_path := mp_hnbllif_sk_path; pars.hnodeb_addr := mp_hnodeb_ip; pars.hnbgw_addr := mp_hnbgw_iuh_ip; pars.hnbgw_port := mp_hnbgw_iuh_port; @@ -113,27 +136,10 @@ type function void_fn(charstring id) runs on HNBGW_ConnHdlr; /* helper function to create and connect a HNBGW_ConnHdlr component */ -private function f_connect_handler(inout HNBGW_ConnHdlr vc_conn, integer bssap_idx := 0) runs on test_CT { - /*connect(vc_conn:RAN, g_bssap[bssap_idx].vc_RAN:PROC); - connect(vc_conn:MGCP_PROC, vc_MGCP:MGCP_PROC); - connect(vc_conn:RSL, bts[0].rsl.vc_RSL:CLIENT_PT); - connect(vc_conn:RSL_PROC, bts[0].rsl.vc_RSL:RSL_PROC); - if (isvalue(bts[1])) { - connect(vc_conn:RSL1, bts[1].rsl.vc_RSL:CLIENT_PT); - connect(vc_conn:RSL1_PROC, bts[1].rsl.vc_RSL:RSL_PROC); +private function f_connect_handler(inout HNBGW_ConnHdlr vc_conn, TestHdlrParams pars) runs on test_CT { + if (pars.hnbllif_sk_path != "") { + map(vc_conn:LLSK, system:LLSK); } - if (isvalue(bts[2])) { - connect(vc_conn:RSL2, bts[2].rsl.vc_RSL:CLIENT_PT); - connect(vc_conn:RSL2_PROC, bts[2].rsl.vc_RSL:RSL_PROC); - } - connect(vc_conn:BSSAP, g_bssap[bssap_idx].vc_RAN:CLIENT); - if (mp_enable_lcs_tests) { - connect(vc_conn:BSSAP_LE, g_bssap_le.vc_BSSAP_LE:CLIENT); - connect(vc_conn:BSSAP_LE_PROC, g_bssap_le.vc_BSSAP_LE:PROC); - } - connect(vc_conn:MGCP, vc_MGCP:MGCP_CLIENT); - connect(vc_conn:MGCP_MULTI, vc_MGCP:MGCP_CLIENT_MULTI); - connect(vc_conn:STATSD_PROC, vc_STATSD:STATSD_PROC);*/ } function f_start_handler_create(TestHdlrParams pars) @@ -141,7 +147,7 @@ var charstring id := testcasename(); var HNBGW_ConnHdlr vc_conn; vc_conn := HNBGW_ConnHdlr.create(id); - f_connect_handler(vc_conn); + f_connect_handler(vc_conn, pars); return vc_conn; } @@ -168,27 +174,29 @@ /* first function inside ConnHdlr component; sets g_pars + starts function */ private function f_handler_init(void_fn fn, charstring id, TestHdlrParams pars) runs on HNBGW_ConnHdlr { - f_HNBGW_ConnHdlr_init(pars); + f_HNBGW_ConnHdlr_init(id, pars); HNBAP.receive(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); /* Wait for HNB to connect to us */ fn.apply(id); } -private function f_tc_hnb_register_request(charstring id) runs on HNBGW_ConnHdlr { +private function f_tc_hnb_register_request_accept(charstring id) runs on HNBGW_ConnHdlr { f_handle_hnbap_hnb_register_req(); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONFIGURE_IND(g_pars.mcc, g_pars.mnc, g_pars.cell_identity, + g_pars.lac, g_pars.rac, g_pars.sac, g_pars.rnc_id))); f_sleep(1.0); } testcase TC_hnb_register_request_accept() runs on test_CT { var HNBGW_ConnHdlr vc_conn; f_init(); - vc_conn := f_start_handler(refers(f_tc_hnb_register_request)); + vc_conn := f_start_handler(refers(f_tc_hnb_register_request_accept)); vc_conn.done; f_shutdown_helper(); } private function f_tc_hnb_register_reject(charstring id) runs on HNBGW_ConnHdlr { HNBAP.receive(tr_HNBAP_HNBRegisterRequest(char2oct(g_pars.hNB_Identity_Info), - g_pars.plmnid, + f_enc_mcc_mnc(g_pars.mcc, g_pars.mnc), int2bit(g_pars.cell_identity, 28), int2oct(g_pars.lac, 2), int2oct(g_pars.rac, 1), @@ -206,9 +214,74 @@ f_shutdown_helper(); } +private function f_tc_mo_conn(charstring id) runs on HNBGW_ConnHdlr { + const integer context_id := 30; + const bitstring context_id_bstr := '000000000000000000011110'B; /* encoded context_id */ + const Establishment_Cause est_cause := normal_call; + f_handle_hnbap_hnb_register_req(); + + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONFIGURE_IND(g_pars.mcc, g_pars.mnc, g_pars.cell_identity, + g_pars.lac, g_pars.rac, g_pars.sac, g_pars.rnc_id))); + + /* Now an UE attempts CM Service Request: */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_ESTABLISH_REQ(context_id, 1, enum2int(est_cause), hex2oct(ranap_cm_service_req)))); + /* The related RUA Connect + RANAP message is received on Iuh: */ + RUA.receive(tr_RUA_Connect(ps_domain, context_id_bstr, est_cause, hex2oct(ranap_cm_service_req))); + + /* Now HNBGW answers with RUA-DirectTransfer(RANAP-AuthenticationRequest) */ + RUA.send(ts_RUA_DirectTransfer(ps_domain, context_id_bstr, hex2oct(ranap_auth_req))); + + /* Now on LLSK first the Conn establishment is confirmed and then we receive data */ + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONN_ESTABLISH_CNF(context_id, 1, 0))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONN_DATA_IND(context_id, 1, hex2oct(ranap_auth_req)))); + + /* UE answers with RANAPAuthenticationResponse: */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_DATA_REQ(context_id, 1, hex2oct(ranap_auth_resp)))); + RUA.receive(tr_RUA_DirectTransfer(ps_domain, context_id_bstr, hex2oct(ranap_auth_resp))); + + /* UE sends Iu Release Complete to release the conn */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_RELEASE_REQ(context_id, 1, 0, 0, hex2oct(iu_release_compl)))); + RUA.receive(tr_RUA_Disconnect(ps_domain, context_id_bstr, ts_RUA_Cause(normal), hex2oct(iu_release_compl))); +} +testcase TC_mo_conn() runs on test_CT { + var HNBGW_ConnHdlr vc_conn; + + f_init(); + vc_conn := f_start_handler(refers(f_tc_mo_conn)); + vc_conn.done; + f_shutdown_helper(); +} + + +private function f_tc_paging(charstring id) runs on HNBGW_ConnHdlr { + const integer context_id := 30; + const bitstring context_id_bstr := '000000000000000000011110'B; /* encoded context_id */ + f_handle_hnbap_hnb_register_req(); + + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONFIGURE_IND(g_pars.mcc, g_pars.mnc, g_pars.cell_identity, + g_pars.lac, g_pars.rac, g_pars.sac, g_pars.rnc_id))); + + /* HNBGW sends RUA-ConnectionlessTransfer(RANAP-Paging) */ + RUA.send(ts_RUA_ConnectionlessTransfer(hex2oct(ranap_paging))); + + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_UNITDATA_IND(hex2oct(ranap_paging)))); + + /* Here it would continue with UE-side answers with RUA-Connect(RANAP-PagingResponse) */ +} +testcase TC_paging() runs on test_CT { + var HNBGW_ConnHdlr vc_conn; + + f_init(); + vc_conn := f_start_handler(refers(f_tc_paging)); + vc_conn.done; + f_shutdown_helper(); +} + control { execute( TC_hnb_register_request_accept() ); execute( TC_hnb_register_request_reject() ); + execute( TC_mo_conn() ); + execute( TC_paging() ); } } diff --git a/hnodeb/gen_links.sh b/hnodeb/gen_links.sh index ba946e8..6ddb4c0 100755 --- a/hnodeb/gen_links.sh +++ b/hnodeb/gen_links.sh @@ -27,6 +27,10 @@ FILES="SCTPasp_PT.cc SCTPasp_PT.hh SCTPasp_PortType.ttcn SCTPasp_Types.ttcn" gen_links $DIR $FILES +DIR=$BASEDIR/titan.TestPorts.UNIX_DOMAIN_SOCKETasp/src +FILES="UD_PT.cc UD_PT.hh UD_PortType.ttcn UD_Types.ttcn" +gen_links $DIR $FILES + DIR=$BASEDIR/titan.ProtocolModules.SDP/src FILES="SDP_EncDec.cc SDP_Types.ttcn SDP_parse_.tab.c SDP_parse_.tab.h SDP_parse_parser.h SDP_parser.l SDP_parser.y lex.SDP_parse_.c" @@ -51,7 +55,8 @@ gen_links $DIR $FILES DIR=../library -FILES="Iuh_Types.ttcn Iuh_CodecPort.ttcn Iuh_CodecPort_CtrlFunctDef.cc Iuh_CodecPort_CtrlFunct.ttcn Iuh_Emulation.ttcn DNS_Helpers.ttcn " +FILES="HNBLLIF_Types.ttcn HNBLLIF_Templates.ttcn HNBLLIF_CodecPort.ttcn " +FILES+="Iuh_Types.ttcn Iuh_CodecPort.ttcn Iuh_CodecPort_CtrlFunctDef.cc Iuh_CodecPort_CtrlFunct.ttcn Iuh_Emulation.ttcn DNS_Helpers.ttcn " FILES+="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn RTP_CodecPort.ttcn RTP_CodecPort_CtrlFunct.ttcn RTP_CodecPort_CtrlFunctDef.cc RTP_Emulation.ttcn IuUP_Types.ttcn IuUP_EncDec.cc IuUP_Emulation.ttcn " FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcn " diff --git a/hnodeb/regen_makefile.sh b/hnodeb/regen_makefile.sh index 9ebfaf2..2d13504 100755 --- a/hnodeb/regen_makefile.sh +++ b/hnodeb/regen_makefile.sh @@ -24,6 +24,7 @@ TELNETasp_PT.cc HNBAP_EncDec.cc RUA_EncDec.cc + UD_PT.cc " export CPPFLAGS_TTCN3=" diff --git a/library/HNBLLIF_CodecPort.ttcn b/library/HNBLLIF_CodecPort.ttcn new file mode 100644 index 0000000..00f53fc --- /dev/null +++ b/library/HNBLLIF_CodecPort.ttcn @@ -0,0 +1,95 @@ +/* OsmoHNodeB Lower Layer Socket Interface codec port in TTCN-3 + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * All rights reserved. + * Author: Pau Espin Pedrol + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module HNBLLIF_CodecPort { + +import from Osmocom_Types all; +import from HNBLLIF_Types all; +import from UD_PortType all; +import from UD_Types all; + +type record HNBLLIF_send_data { + HNBLLIF_Message data, + integer id +}; + +private function HNBLLIF_to_UD(in HNBLLIF_send_data pin, out UD_send_data pout) { + pout.id := pin.id; + pout.data := enc_HNBLLIF_Message(pin.data); +} with { extension "prototype(fast)" }; + +private function UD_to_HNBLLIF(in UD_send_data pin, out HNBLLIF_send_data pout) { + pout.id := pin.id; + pout.data := dec_HNBLLIF_Message(pin.data); +} with { extension "prototype(fast)" }; + +type port HNBLLIF_CODEC_PT message { + out UD_close, UD_listen, UD_shutdown, UD_connect, HNBLLIF_send_data; + in UD_listen_result, UD_connect_result, UD_connected, HNBLLIF_send_data; +} with { extension "user UD_PT + out ( + UD_close -> UD_close:simple; + UD_listen -> UD_listen:simple; + UD_shutdown -> UD_shutdown:simple; + UD_connect -> UD_connect:simple; + HNBLLIF_send_data -> UD_send_data: function(HNBLLIF_to_UD) + ) + in ( + UD_listen_result -> UD_listen_result:simple; + UD_connect_result -> UD_connect_result:simple; + UD_send_data -> HNBLLIF_send_data: function(UD_to_HNBLLIF); + UD_connected -> UD_connected:simple + )" +}; + +template HNBLLIF_send_data t_SD_HNBLLIF(integer id, template HNBLLIF_Message pdu) := { + data := pdu, + id := id +} +template (value) HNBLLIF_send_data ts_SD_HNBLLIF(integer id, template (value) HNBLLIF_Message pdu) := { + data := pdu, + id := id +} + +function f_hnbllif_connect(HNBLLIF_CODEC_PT pt, charstring sock) return integer { + var UD_connect_result res; + timer T := 5.0; + + T.start; + pt.send(UD_connect:{sock, -1}); + alt { + [] pt.receive(UD_connect_result:?) -> value res { + if (ispresent(res.result) and ispresent(res.result.result_code) and + res.result.result_code == ERROR) { + if (ispresent(res.result.err)) { + setverdict(fail, "Error connecting to HNBLL socket ", sock, ": ", res.result.err); + } else { + setverdict(fail, "Error connecting to HNBLL socket ", sock); + } + mtc.stop; + } else { + return res.id; + } + } + [] T.timeout { + setverdict(fail, "Timeout connecting to HNBLL socket ", sock); + mtc.stop; + } + } + return -23; +} + +function f_hnbllif_close(HNBLLIF_CODEC_PT pt, integer id) +{ + pt.send(UD_close:{id := id}); +} + +} diff --git a/library/HNBLLIF_Templates.ttcn b/library/HNBLLIF_Templates.ttcn new file mode 100644 index 0000000..f330fdf --- /dev/null +++ b/library/HNBLLIF_Templates.ttcn @@ -0,0 +1,251 @@ +/* Osmocom HNBLL Interface Templates, as per osmo-hnodeb/include/osmocom/hnodeb/hnb_prim.h + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * All rights reserved. + * Author: Pau Espin Pedrol + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module HNBLLIF_Templates { + +import from General_Types all; +import from Osmocom_Types all; +import from HNBLLIF_Types all; + +/********************** + * CTL SAPI + **********************/ +template (value) HNBLLIF_Message ts_HNBLLIF_CTL_HELLO_REQ(template (value) HNBLLIF_Sapi sapi, + template (value) uint16_t api_version) := { + sapi := HNBLL_IF_SAPI_CTL, + u := { + ctl := { + prim := HNBLL_IF_CTL_MSG_HELLO, + u := { + hello := { + op := HNBLL_IF_OP_REQUEST, + u := { + req := { + sapi := sapi, + api_version := api_version + } + } + } + } + } + } +} + +template (present) HNBLLIF_Message tr_HNBLLIF_CTL_HELLO_CNF(template (present) HNBLLIF_Sapi sapi := ?, + template (present) uint32_t api_version := ?) := { + sapi := HNBLL_IF_SAPI_CTL, + u := { + ctl := { + prim := HNBLL_IF_CTL_MSG_HELLO, + u := { + hello := { + op := HNBLL_IF_OP_CONFIRM, + u := { + cnf := { + sapi := sapi, + api_version := api_version + } + } + } + } + } + } +} + + +/********************** + * IUH SAPI + **********************/ + +template (present) HNBLLIF_Message tr_HNBLLIF_IUH_CONFIGURE_IND(template (present) uint16_t mcc := ?, + template (present) uint16_t mnc := ?, + template (present) uint16_t cell_identity := ?, + template (present) uint16_t lac := ?, + template (present) uint8_t rac := ?, + template (present) uint16_t sac := ?, + template (present) uint16_t rnc_id := ?) := { + sapi := HNBLL_IF_SAPI_IUH, + u := { + iuh := { + prim := HNBLL_IF_IUH_MSG_CONFIGURE, + u := { + configure := { + op := HNBLL_IF_OP_INDICATION, + u := { + ind := { + mcc := mcc, + mnc := mnc, + cell_identity := cell_identity, + lac := lac, + rac := rac, + reserved := ?, + sac := sac, + rnc_id := rnc_id + } + } + } + } + } + } +} + +template (value) HNBLLIF_Message ts_HNBLLIF_IUH_CONN_ESTABLISH_REQ(template (value) uint32_t context_id, + template (value) uint8_t domain, + template (value) uint8_t est_cause, + template (value) octetstring data) := { + sapi := HNBLL_IF_SAPI_IUH, + u := { + iuh := { + prim := HNBLL_IF_IUH_MSG_CONN_ESTABLISH, + u := { + conn_establish := { + op := HNBLL_IF_OP_REQUEST, + u := { + req := { + context_id := context_id, + domain := domain, + est_cause := est_cause, + reserved := 0, + data_len := lengthof(data), + data := data + } + } + } + } + } + } +} + +template (present) HNBLLIF_Message tr_HNBLLIF_IUH_CONN_ESTABLISH_CNF(template (present) uint32_t context_id := ?, + template (present) uint8_t domain := ?, + template (present) uint8_t est_cause := ?) := { + sapi := HNBLL_IF_SAPI_IUH, + u := { + iuh := { + prim := HNBLL_IF_IUH_MSG_CONN_ESTABLISH, + u := { + conn_establish := { + op := HNBLL_IF_OP_CONFIRM, + u := { + cnf := { + context_id := context_id, + domain := domain, + est_cause := est_cause + } + } + } + } + } + } +} + +template (value) HNBLLIF_Message ts_HNBLLIF_IUH_CONN_RELEASE_REQ(template (value) uint32_t context_id, + template (value) uint8_t domain, + template (value) uint8_t cause_type, + template (value) uint8_t cause, + template (value) octetstring data) := { + sapi := HNBLL_IF_SAPI_IUH, + u := { + iuh := { + prim := HNBLL_IF_IUH_MSG_CONN_RELEASE, + u := { + conn_release := { + op := HNBLL_IF_OP_REQUEST, + u := { + req := { + context_id := context_id, + domain := domain, + spare1 := 0, + cause_type := cause_type, + cause := cause, + data_len := lengthof(data), + data := data + } + } + } + } + } + } +} + +template (present) HNBLLIF_Message tr_HNBLLIF_IUH_CONN_DATA_IND(template (present) uint32_t context_id := ?, + template (present) uint8_t domain := ?, + template (present) octetstring data := ?) := { + sapi := HNBLL_IF_SAPI_IUH, + u := { + iuh := { + prim := HNBLL_IF_IUH_MSG_CONN_DATA, + u := { + conn_data := { + op := HNBLL_IF_OP_INDICATION, + u := { + ind := { + context_id := context_id, + domain := domain, + spare1 := ?, + spare2 := ?, + data_len := ?, + data := data + } + } + } + } + } + } +} + +template (value) HNBLLIF_Message ts_HNBLLIF_IUH_CONN_DATA_REQ(template (value) uint32_t context_id, + template (value) uint8_t domain, + template (value) octetstring data) := { + sapi := HNBLL_IF_SAPI_IUH, + u := { + iuh := { + prim := HNBLL_IF_IUH_MSG_CONN_DATA, + u := { + conn_data := { + op := HNBLL_IF_OP_REQUEST, + u := { + req := { + context_id := context_id, + domain := domain, + spare1 := 0, + spare2 := 0, + data_len := lengthof(data), + data := data + } + } + } + } + } + } +} + +template (present) HNBLLIF_Message tr_HNBLLIF_IUH_UNITDATA_IND(template (present) octetstring data := ?) := { + sapi := HNBLL_IF_SAPI_IUH, + u := { + iuh := { + prim := HNBLL_IF_IUH_MSG_UNITDATA, + u := { + unitdata := { + op := HNBLL_IF_OP_INDICATION, + u := { + ind := { + data_len := ?, + data := data + } + } + } + } + } + } +} + +} with { encode "RAW" variant "BYTEORDER(first)" }; diff --git a/library/HNBLLIF_Types.ttcn b/library/HNBLLIF_Types.ttcn new file mode 100644 index 0000000..f9c8cc5 --- /dev/null +++ b/library/HNBLLIF_Types.ttcn @@ -0,0 +1,275 @@ +/* Osmocom HNBLL Interface Types, as per osmo-hnodeb/include/osmocom/hnodeb/hnb_prim.h + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * All rights reserved. + * Author: Pau Espin Pedrol + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module HNBLLIF_Types { + +import from General_Types all; +import from Osmocom_Types all; +import from Native_Functions all; + +modulepar { + /* HNBLLIF version supported by the IUT */ + HNBLLIF_Version mp_hnbllif_version := 0; +}; + +const charstring HNBLL_SOCK_DEFAULT := "/tmp/hnb_prim_sock"; +type integer HNBLLIF_Version (0); /* supported versions */ + +/********************** + * CTL SAPI + **********************/ + + +type enumerated HNBLLIF_CTL_MsgType { + HNBLL_IF_CTL_MSG_HELLO ('0000'O) +} with { variant "FIELDLENGTH(16)" }; + +type record HNBLLIF_CTL_hello_req { + HNBLLIF_Sapi sapi, + uint16_t api_version +} with { variant "" }; + +type record HNBLLIF_CTL_hello_cnf { + HNBLLIF_Sapi sapi, + uint16_t api_version +} with { variant "" }; + +type union HNBLLIF_CTL_PrimOpUnion_hello { + HNBLLIF_CTL_hello_req req, + HNBLLIF_CTL_hello_cnf cnf, + octetstring other +} with { variant "" }; + +type record HNBLLIF_CTL_PrimOp_hello { + HNBLLIF_Operation op, + HNBLLIF_CTL_PrimOpUnion_hello u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + cnf, op = HNBLL_IF_OP_CONFIRM; + other, OTHERWISE)" +}; + +type union HNBLLIF_CTL_PrimUnion { + HNBLLIF_CTL_PrimOp_hello hello, + octetstring other +} with { variant "" }; + +type record HNBLLIF_CTL_PrimHdr { + HNBLLIF_CTL_MsgType prim, + HNBLLIF_CTL_PrimUnion u +} with { variant (u) "CROSSTAG( hello, prim = HNBLL_IF_CTL_MSG_HELLO; + other, OTHERWISE)" +}; + +/********************** + * IUH SAPI + **********************/ +type enumerated HNBLLIF_IUH_MsgType { + HNBLL_IF_IUH_MSG_CONFIGURE ('0000'O), + HNBLL_IF_IUH_MSG_CONN_ESTABLISH ('0001'O), + HNBLL_IF_IUH_MSG_CONN_RELEASE ('0002'O), + HNBLL_IF_IUH_MSG_CONN_DATA ('0003'O), + HNBLL_IF_IUH_MSG_UNITDATA ('0004'O) +} with { variant "FIELDLENGTH(16)" }; + +/* CONFIGURE */ +type record HNBLLIF_IUH_configure_ind { + uint16_t mcc, + uint16_t mnc, + uint16_t cell_identity, + uint16_t lac, + uint8_t rac, + uint8_t reserved, + uint16_t sac, + uint16_t rnc_id +} with { variant "" }; + +type union HNBLLIF_IUH_PrimOpUnion_configure { + HNBLLIF_IUH_configure_ind ind, + octetstring other +} with { variant "" }; + +type record HNBLLIF_IUH_PrimOp_configure { + HNBLLIF_Operation op, + HNBLLIF_IUH_PrimOpUnion_configure u +} with { variant (u) "CROSSTAG( ind, op = HNBLL_IF_OP_INDICATION; + other, OTHERWISE)" +}; + +/* CONN_ESTABLISH */ +type record HNBLLIF_IUH_conn_establish_req { + uint32_t context_id, + uint8_t domain, + uint8_t est_cause, + uint16_t reserved, //uint16_t nas_node_selector_bitlen; + //uint8_t nas_node_selector[128]; /* TODO: check whether we can decrease this buffer size */ + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type record HNBLLIF_IUH_conn_establish_cnf { + uint32_t context_id, + uint8_t domain, + uint8_t est_cause +} with { variant "" }; + +type union HNBLLIF_IUH_PrimOpUnion_conn_establish { + HNBLLIF_IUH_conn_establish_req req, + HNBLLIF_IUH_conn_establish_cnf cnf, + octetstring other +} with { variant "" }; +type record HNBLLIF_IUH_PrimOp_conn_establish { + HNBLLIF_Operation op, + HNBLLIF_IUH_PrimOpUnion_conn_establish u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + cnf, op = HNBLL_IF_OP_CONFIRM; + other, OTHERWISE)" +}; + +/* CONN_RELEASE */ +type record HNBLLIF_IUH_conn_release_req { + uint32_t context_id, + uint8_t domain, + uint8_t spare1, + uint8_t cause_type, + uint8_t cause, + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + + +type union HNBLLIF_IUH_PrimOpUnion_conn_release { + HNBLLIF_IUH_conn_release_req req, + octetstring other +} with { variant "" }; +type record HNBLLIF_IUH_PrimOp_conn_release { + HNBLLIF_Operation op, + HNBLLIF_IUH_PrimOpUnion_conn_release u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + other, OTHERWISE)" +}; + +/* CONN_DATA */ +type record HNBLLIF_IUH_conn_data_ind { + uint32_t context_id, + uint8_t domain, + uint8_t spare1, + uint16_t spare2, + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type record HNBLLIF_IUH_conn_data_req { + uint32_t context_id, + uint8_t domain, + uint8_t spare1, + uint16_t spare2, + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type union HNBLLIF_IUH_PrimOpUnion_conn_data { + HNBLLIF_IUH_conn_data_req req, + HNBLLIF_IUH_conn_data_ind ind, + octetstring other +} with { variant "" }; +type record HNBLLIF_IUH_PrimOp_conn_data { + HNBLLIF_Operation op, + HNBLLIF_IUH_PrimOpUnion_conn_data u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + ind, op = HNBLL_IF_OP_INDICATION; + other, OTHERWISE)" +}; + +/* UNITDATA */ +type record HNBLLIF_IUH_unitdata_ind { + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type record HNBLLIF_IUH_unitdata_req { + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type union HNBLLIF_IUH_PrimOpUnion_unitdata { + HNBLLIF_IUH_unitdata_req req, + HNBLLIF_IUH_unitdata_ind ind, + octetstring other +} with { variant "" }; +type record HNBLLIF_IUH_PrimOp_unitdata { + HNBLLIF_Operation op, + HNBLLIF_IUH_PrimOpUnion_unitdata u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + ind, op = HNBLL_IF_OP_INDICATION; + other, OTHERWISE)" +}; + +type union HNBLLIF_IUH_PrimUnion { + HNBLLIF_IUH_PrimOp_configure configure, + HNBLLIF_IUH_PrimOp_conn_establish conn_establish, + HNBLLIF_IUH_PrimOp_conn_release conn_release, + HNBLLIF_IUH_PrimOp_conn_data conn_data, + HNBLLIF_IUH_PrimOp_unitdata unitdata, + octetstring other +} with { variant "" }; + +type record HNBLLIF_IUH_PrimHdr { + HNBLLIF_IUH_MsgType prim, + HNBLLIF_IUH_PrimUnion u +} with { variant (u) "CROSSTAG( configure, prim = HNBLL_IF_IUH_MSG_CONFIGURE; + conn_establish, prim = HNBLL_IF_IUH_MSG_CONN_ESTABLISH; + conn_release, prim = HNBLL_IF_IUH_MSG_CONN_RELEASE; + conn_data, prim = HNBLL_IF_IUH_MSG_CONN_DATA; + unitdata, prim = HNBLL_IF_IUH_MSG_UNITDATA; + other, OTHERWISE)" +}; + + +/********************** +* General +**********************/ +type enumerated HNBLLIF_Sapi { + HNBLL_IF_SAPI_CTL (-1), + HNBLL_IF_SAPI_IUH ('00000001'O)//, + //HNBLL_IF_SAPI_GTP ('00000002'O), + //HNBLL_IF_SAPI_AUDIO ('00000003'O), +} with { variant "FIELDLENGTH(32)" + variant "COMP(2scompl)" +}; + +type enumerated HNBLLIF_Operation { + HNBLL_IF_OP_REQUEST ('0000'O), + HNBLL_IF_OP_RESPONSE ('0001'O), + HNBLL_IF_OP_INDICATION ('0002'O), + HNBLL_IF_OP_CONFIRM ('0003'O) +} with { variant "FIELDLENGTH(16)" }; + +type union HNBLLIF_SapiUnion { + HNBLLIF_CTL_PrimHdr ctl, + HNBLLIF_IUH_PrimHdr iuh, + octetstring other +} with { variant "" }; + +type record HNBLLIF_Message { + HNBLLIF_Sapi sapi, + HNBLLIF_SapiUnion u +} with { variant (u) "CROSSTAG( ctl, sapi = HNBLL_IF_SAPI_CTL; + iuh, sapi = HNBLL_IF_SAPI_IUH; + other, OTHERWISE)" +}; + +external function enc_HNBLLIF_Message(in HNBLLIF_Message pdu) return octetstring + with { extension "prototype(convert) encode(RAW)" }; +external function dec_HNBLLIF_Message(in octetstring stream) return HNBLLIF_Message + with { extension "prototype(convert) decode(RAW)" }; + + +} with { encode "RAW" variant "BYTEORDER(first)" }; diff --git a/library/Iuh_CodecPort.ttcn b/library/Iuh_CodecPort.ttcn index 569a27f..6bedc0b 100644 --- a/library/Iuh_CodecPort.ttcn +++ b/library/Iuh_CodecPort.ttcn @@ -96,7 +96,11 @@ } case (0) { /* FIXME: lower layers report sinfo_ppid=0: */ - pout.msg.hnbap := dec_HNBAP_PDU(pin.msg); + if (match(pin.msg, '000100380000070003000C02404F736D6F484E6F64654200080001000009000300F110000B0004000000100006000200020007000103000A00020004'O)) { + pout.msg.hnbap := dec_HNBAP_PDU(pin.msg); + } else { + pout.msg.rua := dec_RUA_PDU(pin.msg); + } } case else { pout.msg.payload := pin.msg; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia864a672643a0e42f5afea6fd901e621478c87c0 Gerrit-Change-Number: 26373 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:23:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:23:23 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add audio SAPI In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 ) Change subject: hnodeb: Add audio SAPI ...................................................................... hnodeb: Add audio SAPI Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 4 files changed, 383 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn index 554c35f..3c4bc6f 100644 --- a/hnodeb/HNBGW_ConnectionHandler.ttcn +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -27,6 +27,9 @@ import from Iuh_Emulation all; +import from RTP_Types all; +import from RTP_Emulation all; + import from HNBLLIF_CodecPort all; import from HNBLLIF_Types all; import from HNBLLIF_Templates all; @@ -40,6 +43,9 @@ port HNBLLIF_CODEC_PT LLSK; var integer g_llsk_conn_id; + var RTP_Emulation_CT vc_RTPEM; + port RTPEM_CTRL_PT RTPEM_CTRL; + port RTPEM_DATA_PT RTPEM_DATA; var TestHdlrParams g_pars; var boolean g_vty_initialized := false; @@ -102,6 +108,13 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=IUH"); } } + pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_AUDIO, 0))); + alt { + [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_AUDIO, 0); + [] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=AUDIO"); + } + } } type record TestHdlrParams { @@ -109,6 +122,7 @@ charstring hnbgw_addr, charstring hnodeb_addr, integer hnbgw_port, + integer hnbgw_rtp_port, uint16_t rnc_id, charstring hNB_Identity_Info, uint16_t mcc, @@ -126,6 +140,7 @@ hnbgw_addr := "127.0.0.1", hnodeb_addr := "127.0.0.1", hnbgw_port := 29169, + hnbgw_rtp_port := 9000, rnc_id := 23, hNB_Identity_Info := "OsmoHNodeB", mcc := 1, @@ -185,6 +200,38 @@ HNBAP.send(ts_HNBAP_HNBRegisterAccept(g_pars.rnc_id)); } +/* Initialize and start the RTP emulation component for a ConnHdlr */ +function f_HNBGW_rtpem_activate(inout octetstring payload, + HostName remote_host, + PortNumber remote_port, + RtpemConfig cfg := c_RtpemDefaultCfg, + RtpemMode mode := RTPEM_MODE_BIDIR) +runs on HNBGW_ConnHdlr { + /* Step 0: initialize, connect and start the emulation component */ + vc_RTPEM := RTP_Emulation_CT.create(testcasename() & "-RTPEM"); + map(vc_RTPEM:RTP, system:RTP); + map(vc_RTPEM:RTCP, system:RTCP); + connect(vc_RTPEM:CTRL, self:RTPEM_CTRL); + connect(vc_RTPEM:DATA, self:RTPEM_DATA); + vc_RTPEM.start(RTP_Emulation.f_main()); + /* Configure the RTP parameters (TCH/FS). TODO: IuUP */ + var integer payload_len := 33; + var octetstring hdr := 'D0'O; + + /* Pad the payload to conform the expected length */ + payload := f_pad_oct(hdr & payload, payload_len, '00'O); + cfg.tx_fixed_payload := payload; + f_rtpem_configure(RTPEM_CTRL, cfg); + + /* Bind the RTP emulation to the configured address */ + f_rtpem_bind(RTPEM_CTRL, g_pars.hnbgw_addr, g_pars.hnbgw_rtp_port); + + /* Connect to the IUT's address/port parsed from CRCX ACK */ + f_rtpem_connect(RTPEM_CTRL, remote_host, remote_port); + + /* Set the given RTP emulation mode */ + f_rtpem_mode(RTPEM_CTRL, mode); +} } diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index 59dd1ee..05cd2bf 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -24,6 +24,7 @@ import from General_Types all; import from Osmocom_Types all; import from IPL4asp_Types all; +import from Native_Functions all; import from Osmocom_CTRL_Functions all; import from Osmocom_CTRL_Types all; @@ -44,6 +45,9 @@ import from HNBGW_ConnectionHandler all; import from Iuh_Emulation all; +import from RTP_Types all; +import from RTP_Emulation all; + import from HNBLLIF_CodecPort all; import from HNBLLIF_Types all; import from HNBLLIF_Templates all; @@ -63,6 +67,7 @@ const hexstring ranap_auth_req := '00144032000002001040262505120217dc146aeac56cb5ff6d5fb51f47f19220108ca5a6d0c8110000b9e9272498872764003b400100'H; const hexstring ranap_auth_resp := '001440140000010010400d0c0554ccbdd0302104002f3ae4'H; const hexstring ranap_paging := '000e401e0000030003400100001740095000010100000000f10040400500b6cf4773'H; +const hexstring ranap_rab_ass_req := '0000005900000100364052000001003500487824cd80102fa7201a2c0000f44c080a028000514000272028140067400000222814003c40000000503d02000227c03500010a0901a200000000000000000000000000401f4a0000400100'H; const hexstring iu_release_compl := '20010003000000'H; type component test_CT extends CTRL_Adapter_CT { @@ -277,11 +282,89 @@ f_shutdown_helper(); } +private function f_tc_cs_mo_call(charstring id) runs on HNBGW_ConnHdlr { + const integer context_id := 30; + const bitstring context_id_bstr := '000000000000000000011110'B; /* encoded context_id */ + const Establishment_Cause est_cause := normal_call; + var HNBLLIF_send_data sd; + var PDU_RTP rtp_pdu; + var octetstring rtp_payload; + var HostName hnodeb_rtp_addr; + var PortNumber hnodeb_rtp_port; + timer Tu; + + f_handle_hnbap_hnb_register_req(); + + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONFIGURE_IND(g_pars.mcc, g_pars.mnc, g_pars.cell_identity, + g_pars.lac, g_pars.rac, g_pars.sac, g_pars.rnc_id))); + + /* Now an UE attempts CM Service Request: */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_ESTABLISH_REQ(context_id, 0, enum2int(est_cause), hex2oct(ranap_cm_service_req)))); + /* The related RUA Connect + RANAP message is received on Iuh: */ + RUA.receive(tr_RUA_Connect(cs_domain, context_id_bstr, est_cause, hex2oct(ranap_cm_service_req))); + + /* Now HNBGW answers with RUA-DirectTransfer(RANAP-RabASsReq) */ + RUA.send(ts_RUA_DirectTransfer(cs_domain, context_id_bstr, hex2oct(ranap_rab_ass_req))); + + /* Now on LLSK first the Conn establishment is confirmed and then we receive data */ + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONN_ESTABLISH_CNF(context_id, 0, 0))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONN_DATA_IND(context_id, 0, hex2oct(ranap_rab_ass_req)))); + + /* Now LLSK provides the remote TransportLayerAddress from RabAssReq and asks SUT to provide a local address: */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_ESTABLISH_REQ(context_id, g_pars.hnbgw_rtp_port, HNBLL_IF_ADDR_TYPE_IPV4, + f_HNBLLIF_Addr(HNBLL_IF_ADDR_TYPE_IPV4, g_pars.hnbgw_addr)))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_ESTABLISH_CNF(context_id, 0, ?, HNBLL_IF_ADDR_TYPE_IPV4, ?))) -> value sd; + + hnodeb_rtp_addr := f_inet_ntoa(sd.data.u.audio.u.conn_establish.u.cnf.local_addr); + if (not match(g_pars.hnodeb_addr, hnodeb_rtp_addr)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "hnodeb RTP local address doesn't match expectations"); + } + hnodeb_rtp_port := sd.data.u.audio.u.conn_establish.u.cnf.local_rtp_port; + rtp_payload := f_rnd_octstring(6); + f_HNBGW_rtpem_activate(rtp_payload, hnodeb_rtp_addr, hnodeb_rtp_port); + /* Make sure that Uplink frames are received at the HNBGW */ + RTPEM_DATA.clear; + LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_DATA_REQ(context_id, rtp_payload))); + Tu.start(2.0); + alt { + [] RTPEM_DATA.receive(PDU_RTP:?) -> value rtp_pdu { + if (rtp_pdu.data != rtp_payload) { + log("Unexpected RTP payload received!"); + repeat; + } + } + [] RTPEM_DATA.receive { repeat; } + [] Tu.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for Uplink speech frames"); + } + } + Tu.stop; + /* We should also have received some RTP from the HNBGW: */ + LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_DATA_IND(context_id, rtp_payload))); + + f_rtpem_mode(RTPEM_CTRL, RTPEM_MODE_NONE); + + LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_RELEASE_REQ(context_id))); + + /* UE sends Iu Release Complete to release the conn */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_RELEASE_REQ(context_id, 0, 0, 0, hex2oct(iu_release_compl)))); + RUA.receive(tr_RUA_Disconnect(cs_domain, context_id_bstr, ts_RUA_Cause(normal), hex2oct(iu_release_compl))); +} +testcase TC_cs_mo_call() runs on test_CT { + var HNBGW_ConnHdlr vc_conn; + + f_init(); + vc_conn := f_start_handler(refers(f_tc_cs_mo_call)); + vc_conn.done; + f_shutdown_helper(); +} + control { execute( TC_hnb_register_request_accept() ); execute( TC_hnb_register_request_reject() ); execute( TC_mo_conn() ); execute( TC_paging() ); + execute( TC_cs_mo_call() ); } } diff --git a/library/HNBLLIF_Templates.ttcn b/library/HNBLLIF_Templates.ttcn index f330fdf..3fa49b7 100644 --- a/library/HNBLLIF_Templates.ttcn +++ b/library/HNBLLIF_Templates.ttcn @@ -248,4 +248,123 @@ } } +/********************** + * AUDIO SAPI + **********************/ + +template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_ESTABLISH_REQ(template (value) uint32_t context_id, + template (value) uint16_t remote_rtp_port, + template (value) HNBLLIF_AddrType remote_rtp_address_type, + template (value) HNBLLIF_Addr remote_addr) := { + sapi := HNBLL_IF_SAPI_AUDIO, + u := { + audio := { + prim := HNBLL_IF_AUDIO_MSG_CONN_ESTABLISH, + u := { + conn_establish := { + op := HNBLL_IF_OP_REQUEST, + u := { + req := { + context_id := context_id, + remote_rtp_port := remote_rtp_port, + reserved := 0, + remote_rtp_address_type := remote_rtp_address_type, + remote_addr := remote_addr + } + } + } + } + } + } +} + +template (present) HNBLLIF_Message tr_HNBLLIF_AUDIO_CONN_ESTABLISH_CNF(template (present) uint32_t context_id := ?, + template (present) uint8_t error_code := ?, + template (present) uint16_t local_rtp_port:= ?, + template (present) HNBLLIF_AddrType local_rtp_address_type := ?, + template (present) HNBLLIF_Addr local_addr := ?) := { + sapi := HNBLL_IF_SAPI_AUDIO, + u := { + audio := { + prim := HNBLL_IF_AUDIO_MSG_CONN_ESTABLISH, + u := { + conn_establish := { + op := HNBLL_IF_OP_CONFIRM, + u := { + cnf := { + context_id := context_id, + local_rtp_port := local_rtp_port, + error_code := error_code, + local_rtp_address_type := local_rtp_address_type, + local_addr := local_addr + } + } + } + } + } + } +} + +template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_RELEASE_REQ(template (value) uint32_t context_id) := { + sapi := HNBLL_IF_SAPI_AUDIO, + u := { + audio := { + prim := HNBLL_IF_AUDIO_MSG_CONN_RELEASE, + u := { + conn_release := { + op := HNBLL_IF_OP_REQUEST, + u := { + req := { + context_id := context_id + } + } + } + } + } + } +} + +template (present) HNBLLIF_Message tr_HNBLLIF_AUDIO_CONN_DATA_IND(template (present) uint32_t context_id := ?, + template (present) octetstring data := ?) := { + sapi := HNBLL_IF_SAPI_AUDIO, + u := { + audio := { + prim := HNBLL_IF_AUDIO_MSG_CONN_DATA, + u := { + conn_data := { + op := HNBLL_IF_OP_INDICATION, + u := { + ind := { + context_id := context_id, + data_len := ?, + data := data + } + } + } + } + } + } +} + +template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_DATA_REQ(template (value) uint32_t context_id, + template (value) octetstring data) := { + sapi := HNBLL_IF_SAPI_AUDIO, + u := { + audio := { + prim := HNBLL_IF_AUDIO_MSG_CONN_DATA, + u := { + conn_data := { + op := HNBLL_IF_OP_REQUEST, + u := { + req := { + context_id := context_id, + data_len := lengthof(data), + data := data + } + } + } + } + } + } +} } with { encode "RAW" variant "BYTEORDER(first)" }; diff --git a/library/HNBLLIF_Types.ttcn b/library/HNBLLIF_Types.ttcn index f9c8cc5..befd7bb 100644 --- a/library/HNBLLIF_Types.ttcn +++ b/library/HNBLLIF_Types.ttcn @@ -232,15 +232,121 @@ other, OTHERWISE)" }; +/********************** + * AUDIO SAPI + **********************/ +type enumerated HNBLLIF_AUDIO_MsgType { + HNBLL_IF_AUDIO_MSG_CONN_ESTABLISH ('0000'O), + HNBLL_IF_AUDIO_MSG_CONN_RELEASE ('0001'O), + HNBLL_IF_AUDIO_MSG_CONN_DATA ('0002'O) +} with { variant "FIELDLENGTH(16)" }; + +/* CONN_ESTABLISH */ +type record HNBLLIF_AUDIO_conn_establish_req { + uint32_t context_id, + uint16_t remote_rtp_port, + uint8_t reserved, + HNBLLIF_AddrType remote_rtp_address_type, + HNBLLIF_Addr remote_addr +} with { variant "" }; + +type record HNBLLIF_AUDIO_conn_establish_cnf { + uint32_t context_id, + uint16_t local_rtp_port, + uint8_t error_code, + HNBLLIF_AddrType local_rtp_address_type, + HNBLLIF_Addr local_addr +} with { variant "" }; + +type union HNBLLIF_AUDIO_PrimOpUnion_conn_establish { + HNBLLIF_AUDIO_conn_establish_req req, + HNBLLIF_AUDIO_conn_establish_cnf cnf, + octetstring other +} with { variant "" }; +type record HNBLLIF_AUDIO_PrimOp_conn_establish { + HNBLLIF_Operation op, + HNBLLIF_AUDIO_PrimOpUnion_conn_establish u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + cnf, op = HNBLL_IF_OP_CONFIRM; + other, OTHERWISE)" +}; + +/* CONN_RELEASE */ +type record HNBLLIF_AUDIO_conn_release_req { + uint32_t context_id +} with { variant "" }; + + +type union HNBLLIF_AUDIO_PrimOpUnion_conn_release { + HNBLLIF_AUDIO_conn_release_req req, + octetstring other +} with { variant "" }; +type record HNBLLIF_AUDIO_PrimOp_conn_release { + HNBLLIF_Operation op, + HNBLLIF_AUDIO_PrimOpUnion_conn_release u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + other, OTHERWISE)" +}; + +/* CONN_DATA */ +type record HNBLLIF_AUDIO_conn_data_ind { + uint32_t context_id, + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type record HNBLLIF_AUDIO_conn_data_req { + uint32_t context_id, + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type union HNBLLIF_AUDIO_PrimOpUnion_conn_data { + HNBLLIF_AUDIO_conn_data_req req, + HNBLLIF_AUDIO_conn_data_ind ind, + octetstring other +} with { variant "" }; +type record HNBLLIF_AUDIO_PrimOp_conn_data { + HNBLLIF_Operation op, + HNBLLIF_AUDIO_PrimOpUnion_conn_data u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + ind, op = HNBLL_IF_OP_INDICATION; + other, OTHERWISE)" +}; + +type union HNBLLIF_AUDIO_PrimUnion { + HNBLLIF_AUDIO_PrimOp_conn_establish conn_establish, + HNBLLIF_AUDIO_PrimOp_conn_release conn_release, + HNBLLIF_AUDIO_PrimOp_conn_data conn_data, + octetstring other +} with { variant "" }; + +type record HNBLLIF_AUDIO_PrimHdr { + HNBLLIF_AUDIO_MsgType prim, + HNBLLIF_AUDIO_PrimUnion u +} with { variant (u) "CROSSTAG( conn_establish, prim = HNBLL_IF_AUDIO_MSG_CONN_ESTABLISH; + conn_release, prim = HNBLL_IF_AUDIO_MSG_CONN_RELEASE; + conn_data, prim = HNBLL_IF_AUDIO_MSG_CONN_DATA; + other, OTHERWISE)" +}; + /********************** * General **********************/ + +type enumerated HNBLLIF_AddrType { + HNBLL_IF_ADDR_TYPE_UNSPEC ('00'O), + HNBLL_IF_ADDR_TYPE_IPV4 ('01'O), + HNBLL_IF_ADDR_TYPE_IPV6 ('02'O) +} with { variant "FIELDLENGTH(8)" }; +type octetstring HNBLLIF_Addr length(16); + type enumerated HNBLLIF_Sapi { HNBLL_IF_SAPI_CTL (-1), - HNBLL_IF_SAPI_IUH ('00000001'O)//, + HNBLL_IF_SAPI_IUH ('00000001'O), //HNBLL_IF_SAPI_GTP ('00000002'O), - //HNBLL_IF_SAPI_AUDIO ('00000003'O), + HNBLL_IF_SAPI_AUDIO ('00000003'O) } with { variant "FIELDLENGTH(32)" variant "COMP(2scompl)" }; @@ -255,6 +361,7 @@ type union HNBLLIF_SapiUnion { HNBLLIF_CTL_PrimHdr ctl, HNBLLIF_IUH_PrimHdr iuh, + HNBLLIF_AUDIO_PrimHdr audio, octetstring other } with { variant "" }; @@ -263,6 +370,7 @@ HNBLLIF_SapiUnion u } with { variant (u) "CROSSTAG( ctl, sapi = HNBLL_IF_SAPI_CTL; iuh, sapi = HNBLL_IF_SAPI_IUH; + audio, sapi = HNBLL_IF_SAPI_AUDIO; other, OTHERWISE)" }; @@ -271,5 +379,29 @@ external function dec_HNBLLIF_Message(in octetstring stream) return HNBLLIF_Message with { extension "prototype(convert) decode(RAW)" }; +function f_HNBLLIF_AF2addr_type(AddressFamily address_family) +return HNBLLIF_AddrType { + if (address_family == AF_INET) { + return HNBLL_IF_ADDR_TYPE_IPV4; + } else if (address_family == AF_INET6) { + return HNBLL_IF_ADDR_TYPE_IPV6; + } else { + return HNBLL_IF_ADDR_TYPE_UNSPEC; + } +} + +function f_HNBLLIF_Addr(HNBLLIF_AddrType addr_type, charstring addr_str) +return HNBLLIF_Addr { + var HNBLLIF_Addr addr; + + if (addr_type == HNBLL_IF_ADDR_TYPE_IPV4) { + addr := f_inet_addr(addr_str); + } else { + addr := f_inet6_addr(addr_str); + } + + return addr; +} + } with { encode "RAW" variant "BYTEORDER(first)" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20544f67c2450bc3cd4bcb3ee638de1958bf5783 Gerrit-Change-Number: 26444 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:23:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:23:24 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Add gtp SAPI In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 ) Change subject: hnodeb: Add gtp SAPI ...................................................................... hnodeb: Add gtp SAPI Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn M hnodeb/gen_links.sh M hnodeb/regen_makefile.sh M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 6 files changed, 352 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn index 3c4bc6f..b069a11 100644 --- a/hnodeb/HNBGW_ConnectionHandler.ttcn +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -34,8 +34,13 @@ import from HNBLLIF_Types all; import from HNBLLIF_Templates all; +import from GTP_Emulation all; +import from GTP_Templates all; +import from GTP_CodecPort all; +import from GTPU_Types all; + /* this component represents a single Iuh connection at the HNBGW. */ -type component HNBGW_ConnHdlr extends StatsD_ConnHdlr { +type component HNBGW_ConnHdlr extends StatsD_ConnHdlr, GTP_ConnHdlr { port TELNETasp_PT HNBVTY; port HNBAP_PT HNBAP; port RUA_PT RUA; @@ -46,6 +51,10 @@ var RTP_Emulation_CT vc_RTPEM; port RTPEM_CTRL_PT RTPEM_CTRL; port RTPEM_DATA_PT RTPEM_DATA; + + var GTP_Emulation_CT vc_GTP; + + var TestHdlrParams g_pars; var boolean g_vty_initialized := false; @@ -60,11 +69,8 @@ } } -/* initialize all parameters */ -function f_HNBGW_ConnHdlr_init(charstring id, TestHdlrParams pars) runs on HNBGW_ConnHdlr { +private function f_HNBGW_ConnHdlr_init_iuh(charstring id) runs on HNBGW_ConnHdlr { var Iuh_Emulation_CT vc_Iuh; - - g_pars := valueof(pars); vc_Iuh := Iuh_Emulation_CT.create(id & "-HNBGW"); connect(self:HNBAP, vc_Iuh:HNBAP); connect(self:RUA, vc_Iuh:RUA); @@ -75,7 +81,30 @@ iuh_pars.local_ip := g_pars.hnbgw_addr; iuh_pars.local_sctp_port := g_pars.hnbgw_port; vc_Iuh.start(Iuh_Emulation.main(iuh_pars, id & "-Iuh")); +} +private function f_HNBGW_ConnHdlr_init_gtp(charstring id) runs on HNBGW_ConnHdlr { + id := id & "-GTP"; + + var GtpEmulationCfg gtp_cfg := { + gtpc_bind_ip := g_pars.hnbgw_addr, + gtpc_bind_port := GTP1C_PORT, + gtpu_bind_ip := g_pars.hnbgw_addr, + gtpu_bind_port := GTP1U_PORT, + sgsn_role := false + }; + + vc_GTP := GTP_Emulation_CT.create(id); + connect(self:GTP, vc_GTP:CLIENT); + connect(self:GTP_PROC, vc_GTP:CLIENT_PROC); + vc_GTP.start(GTP_Emulation.main(gtp_cfg)); +} + +/* initialize all parameters */ +function f_HNBGW_ConnHdlr_init(charstring id, TestHdlrParams pars) runs on HNBGW_ConnHdlr { + g_pars := valueof(pars); + f_HNBGW_ConnHdlr_init_iuh(id); + f_HNBGW_ConnHdlr_init_gtp(id); f_HNBGW_ConnHdlr_init_vty(); /* Connect to HNB on LLSK and do HELLO ping-pong */ @@ -115,6 +144,13 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=AUDIO"); } } + pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_GTP, 0))); + alt { + [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_GTP, 0); + [] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=GTP"); + } + } } type record TestHdlrParams { @@ -151,6 +187,17 @@ sac := 4 } +template (value) GtpPeer ts_GtpPeerU(charstring ip) := { + connId := 1, + remName := ip, + remPort := GTP1U_PORT +} + +function f_gtpu_send(uint32_t tei, octetstring payload) runs on HNBGW_ConnHdlr { + var GtpPeer peer := valueof(ts_GtpPeerU(g_pars.hnodeb_addr)); + GTP.send(ts_GTP1U_GPDU(peer, 0 /*seq*/, int2oct(tei, 4), payload)); +} + /* HNBLLIF socket may at any time receive a new INFO.ind */ altstep as_hnbllif_hello_cnf(HNBLLIF_CODEC_PT pt, integer hnbllif_conn_id, out HNBLLIF_Message last_hello_cnf, diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index 05cd2bf..ca42e5c 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -52,6 +52,10 @@ import from HNBLLIF_Types all; import from HNBLLIF_Templates all; +import from GTPU_Types all; +import from GTP_Templates all; +import from GTP_Emulation all; + modulepar { /* IP address at which the HNodeB can be reached */ charstring mp_hnodeb_ip := "127.0.0.1"; @@ -359,12 +363,70 @@ f_shutdown_helper(); } +private function f_tc_ps_mo_gtp_ping_pong(charstring id) runs on HNBGW_ConnHdlr { + const integer context_id := 30; + const bitstring context_id_bstr := '000000000000000000011110'B; /* encoded context_id */ + const Establishment_Cause est_cause := normal_call; + var uint32_t remote_tei := 8888; + var uint32_t local_tei; + var octetstring gtp_payload := f_rnd_octstring(40); + var HNBLLIF_send_data sd; + + f_gtp_register_teid(int2oct(remote_tei, 4)); + + f_handle_hnbap_hnb_register_req(); + + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONFIGURE_IND(g_pars.mcc, g_pars.mnc, g_pars.cell_identity, + g_pars.lac, g_pars.rac, g_pars.sac, g_pars.rnc_id))); + + /* Now an UE attempts CM Service Request: */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_ESTABLISH_REQ(context_id, 1, enum2int(est_cause), hex2oct(ranap_cm_service_req)))); + /* The related RUA Connect + RANAP message is received on Iuh: */ + RUA.receive(tr_RUA_Connect(ps_domain, context_id_bstr, est_cause, hex2oct(ranap_cm_service_req))); + + /* Now HNBGW answers with RUA-DirectTransfer(RANAP-RabASsReq) */ + RUA.send(ts_RUA_DirectTransfer(ps_domain, context_id_bstr, hex2oct(ranap_rab_ass_req))); + + /* Now on LLSK first the Conn establishment is confirmed and then we receive data */ + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONN_ESTABLISH_CNF(context_id, 1, 0))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_IUH_CONN_DATA_IND(context_id, 1, hex2oct(ranap_rab_ass_req)))); + + /* Now LLSK provides the remote TransportLayerAddress from RabAssReq and asks SUT to provide a local address: */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_ESTABLISH_REQ(context_id, remote_tei, HNBLL_IF_ADDR_TYPE_IPV4, + f_HNBLLIF_Addr(HNBLL_IF_ADDR_TYPE_IPV4, g_pars.hnbgw_addr)))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_GTP_CONN_ESTABLISH_CNF(context_id, ?, 0, + HNBLL_IF_ADDR_TYPE_IPV4, ?))) -> value sd; + local_tei := sd.data.u.gtp.u.conn_establish.u.cnf.local_tei; + + /* Forward GTP data in both directions */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_DATA_REQ(context_id, remote_tei, gtp_payload))); + GTP.receive(tr_GTPU_GPDU(ts_GtpPeerU(g_pars.hnodeb_addr), int2oct(remote_tei, 4), gtp_payload)); + f_gtpu_send(local_tei, gtp_payload); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_GTP_CONN_DATA_IND(context_id, local_tei, gtp_payload))); + + /* Done, release GTP conn */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_RELEASE_REQ(context_id, remote_tei))); + + /* UE sends Iu Release Complete to release the conn */ + LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_RELEASE_REQ(context_id, 1, 0, 0, hex2oct(iu_release_compl)))); + RUA.receive(tr_RUA_Disconnect(ps_domain, context_id_bstr, ts_RUA_Cause(normal), hex2oct(iu_release_compl))); +} +testcase TC_ps_mo_gtp_ping_pong() runs on test_CT { + var HNBGW_ConnHdlr vc_conn; + + f_init(); + vc_conn := f_start_handler(refers(f_tc_ps_mo_gtp_ping_pong)); + vc_conn.done; + f_shutdown_helper(); +} + control { execute( TC_hnb_register_request_accept() ); execute( TC_hnb_register_request_reject() ); execute( TC_mo_conn() ); execute( TC_paging() ); execute( TC_cs_mo_call() ); + execute( TC_ps_mo_gtp_ping_pong() ); } } diff --git a/hnodeb/gen_links.sh b/hnodeb/gen_links.sh index 6ddb4c0..84495e9 100755 --- a/hnodeb/gen_links.sh +++ b/hnodeb/gen_links.sh @@ -44,6 +44,10 @@ FILES="TELNETasp_PT.cc TELNETasp_PT.hh TELNETasp_PortType.ttcn" gen_links $DIR $FILES +DIR=$BASEDIR/titan.ProtocolModules.GTP_v13.5.0/src +FILES="GTPC_EncDec.cc GTPC_Types.ttcn GTPU_EncDec.cc GTPU_Types.ttcn" +gen_links $DIR $FILES + DIR=../library/hnbap FILES="HNBAP_CommonDataTypes.asn HNBAP_Constants.asn HNBAP_Containers.asn HNBAP_IEs.asn HNBAP_PDU_Contents.asn HNBAP_PDU_Descriptions.asn " FILES+="HNBAP_EncDec.cc HNBAP_Types.ttcn HNBAP_Templates.ttcn " @@ -59,7 +63,7 @@ FILES+="Iuh_Types.ttcn Iuh_CodecPort.ttcn Iuh_CodecPort_CtrlFunctDef.cc Iuh_CodecPort_CtrlFunct.ttcn Iuh_Emulation.ttcn DNS_Helpers.ttcn " FILES+="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn RTP_CodecPort.ttcn RTP_CodecPort_CtrlFunct.ttcn RTP_CodecPort_CtrlFunctDef.cc RTP_Emulation.ttcn IuUP_Types.ttcn IuUP_EncDec.cc IuUP_Emulation.ttcn " FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcn " - +FILES+="GTP_CodecPort.ttcn GTP_CodecPort_CtrlFunct.ttcn GTP_CodecPort_CtrlFunctDef.cc GTP_Emulation.ttcn GTP_Templates.ttcn IPCP_Types.ttcn GSM_Types.ttcn " gen_links $DIR $FILES ignore_pp_results diff --git a/hnodeb/regen_makefile.sh b/hnodeb/regen_makefile.sh index 2d13504..10f5c21 100755 --- a/hnodeb/regen_makefile.sh +++ b/hnodeb/regen_makefile.sh @@ -25,6 +25,9 @@ HNBAP_EncDec.cc RUA_EncDec.cc UD_PT.cc + GTPC_EncDec.cc + GTPU_EncDec.cc + GTP_CodecPort_CtrlFunctDef.cc " export CPPFLAGS_TTCN3=" diff --git a/library/HNBLLIF_Templates.ttcn b/library/HNBLLIF_Templates.ttcn index 3fa49b7..78cf89a 100644 --- a/library/HNBLLIF_Templates.ttcn +++ b/library/HNBLLIF_Templates.ttcn @@ -367,4 +367,131 @@ } } } + + +/********************** + * GTP SAPI + **********************/ +template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_ESTABLISH_REQ(template (value) uint32_t context_id, + template (value) uint32_t remote_tei, + template (value) HNBLLIF_AddrType remote_gtpu_address_type, + template (value) HNBLLIF_Addr remote_gtpu_addr) := { + sapi := HNBLL_IF_SAPI_GTP, + u := { + gtp := { + prim := HNBLL_IF_GTP_MSG_CONN_ESTABLISH, + u := { + conn_establish := { + op := HNBLL_IF_OP_REQUEST, + u := { + req := { + context_id := context_id, + remote_tei := remote_tei, + reserved := 0, + remote_gtpu_address_type := remote_gtpu_address_type, + remote_gtpu_addr := remote_gtpu_addr + } + } + } + } + } + } +} + +template (present) HNBLLIF_Message tr_HNBLLIF_GTP_CONN_ESTABLISH_CNF(template (present) uint32_t context_id := ?, + template (present) uint32_t local_tei := ?, + template (present) uint8_t error_code := ?, + template (present) HNBLLIF_AddrType local_gtpu_address_type := ?, + template (present) HNBLLIF_Addr local_gtpu_addr := ?) := { + sapi := HNBLL_IF_SAPI_GTP, + u := { + gtp := { + prim := HNBLL_IF_GTP_MSG_CONN_ESTABLISH, + u := { + conn_establish := { + op := HNBLL_IF_OP_CONFIRM, + u := { + cnf := { + context_id := context_id, + local_tei := local_tei, + error_code := error_code, + local_gtpu_address_type := local_gtpu_address_type, + local_gtpu_addr := local_gtpu_addr + } + } + } + } + } + } +} + +template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_RELEASE_REQ(template (value) uint32_t context_id, + template (value) uint32_t remote_tei) := { + sapi := HNBLL_IF_SAPI_GTP, + u := { + gtp := { + prim := HNBLL_IF_GTP_MSG_CONN_RELEASE, + u := { + conn_release := { + op := HNBLL_IF_OP_REQUEST, + u := { + req := { + context_id := context_id, + remote_tei := remote_tei + } + } + } + } + } + } +} + +template (present) HNBLLIF_Message tr_HNBLLIF_GTP_CONN_DATA_IND(template (present) uint32_t context_id := ?, + template (present) uint32_t local_tei := ?, + template (present) octetstring data := ?) := { + sapi := HNBLL_IF_SAPI_GTP, + u := { + gtp := { + prim := HNBLL_IF_GTP_MSG_CONN_DATA, + u := { + conn_data := { + op := HNBLL_IF_OP_INDICATION, + u := { + ind := { + context_id := context_id, + local_tei := local_tei, + data_len := ?, + data := data + } + } + } + } + } + } +} + +template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_DATA_REQ(template (value) uint32_t context_id, + template (value) uint32_t remote_tei, + template (value) octetstring data) := { + sapi := HNBLL_IF_SAPI_GTP, + u := { + gtp := { + prim := HNBLL_IF_GTP_MSG_CONN_DATA, + u := { + conn_data := { + op := HNBLL_IF_OP_REQUEST, + u := { + req := { + context_id := context_id, + remote_tei := remote_tei, + data_len := lengthof(data), + data := data + } + } + } + } + } + } +} + } with { encode "RAW" variant "BYTEORDER(first)" }; diff --git a/library/HNBLLIF_Types.ttcn b/library/HNBLLIF_Types.ttcn index befd7bb..95f91fc 100644 --- a/library/HNBLLIF_Types.ttcn +++ b/library/HNBLLIF_Types.ttcn @@ -330,6 +330,106 @@ other, OTHERWISE)" }; +/********************** + * GTP SAPI + **********************/ +type enumerated HNBLLIF_GTP_MsgType { + HNBLL_IF_GTP_MSG_CONN_ESTABLISH ('0000'O), + HNBLL_IF_GTP_MSG_CONN_RELEASE ('0001'O), + HNBLL_IF_GTP_MSG_CONN_DATA ('0002'O) +} with { variant "FIELDLENGTH(16)" }; + +/* CONN_ESTABLISH */ +type record HNBLLIF_GTP_conn_establish_req { + uint32_t context_id, + uint32_t remote_tei, + uint8_t reserved, + HNBLLIF_AddrType remote_gtpu_address_type, + HNBLLIF_Addr remote_gtpu_addr +} with { variant "" }; + +type record HNBLLIF_GTP_conn_establish_cnf { + uint32_t context_id, + uint32_t local_tei, + uint8_t error_code, + HNBLLIF_AddrType local_gtpu_address_type, + HNBLLIF_Addr local_gtpu_addr +} with { variant "" }; + +type union HNBLLIF_GTP_PrimOpUnion_conn_establish { + HNBLLIF_GTP_conn_establish_req req, + HNBLLIF_GTP_conn_establish_cnf cnf, + octetstring other +} with { variant "" }; +type record HNBLLIF_GTP_PrimOp_conn_establish { + HNBLLIF_Operation op, + HNBLLIF_GTP_PrimOpUnion_conn_establish u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + cnf, op = HNBLL_IF_OP_CONFIRM; + other, OTHERWISE)" +}; + +/* CONN_RELEASE */ +type record HNBLLIF_GTP_conn_release_req { + uint32_t context_id, + uint32_t remote_tei +} with { variant "" }; + +type union HNBLLIF_GTP_PrimOpUnion_conn_release { + HNBLLIF_GTP_conn_release_req req, + octetstring other +} with { variant "" }; +type record HNBLLIF_GTP_PrimOp_conn_release { + HNBLLIF_Operation op, + HNBLLIF_GTP_PrimOpUnion_conn_release u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + other, OTHERWISE)" +}; + +/* CONN_DATA */ +type record HNBLLIF_GTP_conn_data_req { + uint32_t context_id, + uint32_t remote_tei, + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type record HNBLLIF_GTP_conn_data_ind { + uint32_t context_id, + uint32_t local_tei, + uint32_t data_len, + octetstring data /* RANAP message */ +} with { variant (data_len) "LENGTHTO (data)" }; + +type union HNBLLIF_GTP_PrimOpUnion_conn_data { + HNBLLIF_GTP_conn_data_req req, + HNBLLIF_GTP_conn_data_ind ind, + octetstring other +} with { variant "" }; +type record HNBLLIF_GTP_PrimOp_conn_data { + HNBLLIF_Operation op, + HNBLLIF_GTP_PrimOpUnion_conn_data u +} with { variant (u) "CROSSTAG( req, op = HNBLL_IF_OP_REQUEST; + ind, op = HNBLL_IF_OP_INDICATION; + other, OTHERWISE)" +}; + +type union HNBLLIF_GTP_PrimUnion { + HNBLLIF_GTP_PrimOp_conn_establish conn_establish, + HNBLLIF_GTP_PrimOp_conn_release conn_release, + HNBLLIF_GTP_PrimOp_conn_data conn_data, + octetstring other +} with { variant "" }; + +type record HNBLLIF_GTP_PrimHdr { + HNBLLIF_GTP_MsgType prim, + HNBLLIF_GTP_PrimUnion u +} with { variant (u) "CROSSTAG( conn_establish, prim = HNBLL_IF_GTP_MSG_CONN_ESTABLISH; + conn_release, prim = HNBLL_IF_GTP_MSG_CONN_RELEASE; + conn_data, prim = HNBLL_IF_GTP_MSG_CONN_DATA; + other, OTHERWISE)" +}; + /********************** * General @@ -345,7 +445,7 @@ type enumerated HNBLLIF_Sapi { HNBLL_IF_SAPI_CTL (-1), HNBLL_IF_SAPI_IUH ('00000001'O), - //HNBLL_IF_SAPI_GTP ('00000002'O), + HNBLL_IF_SAPI_GTP ('00000002'O), HNBLL_IF_SAPI_AUDIO ('00000003'O) } with { variant "FIELDLENGTH(32)" variant "COMP(2scompl)" @@ -361,6 +461,7 @@ type union HNBLLIF_SapiUnion { HNBLLIF_CTL_PrimHdr ctl, HNBLLIF_IUH_PrimHdr iuh, + HNBLLIF_GTP_PrimHdr gtp, HNBLLIF_AUDIO_PrimHdr audio, octetstring other } with { variant "" }; @@ -370,6 +471,7 @@ HNBLLIF_SapiUnion u } with { variant (u) "CROSSTAG( ctl, sapi = HNBLL_IF_SAPI_CTL; iuh, sapi = HNBLL_IF_SAPI_IUH; + gtp, sapi = HNBLL_IF_SAPI_GTP; audio, sapi = HNBLL_IF_SAPI_AUDIO; other, OTHERWISE)" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4de00641089abbd03273ce5a2d9325659ac7d42 Gerrit-Change-Number: 26445 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:23:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:23:50 +0000 Subject: Change in docker-playground[master]: ttcn3-{sgsn, ggsn}-test: set OSMO_SUT_{HOST, PORT} In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26573 ) Change subject: ttcn3-{sgsn,ggsn}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I61fef7763e6445c231ff2664036e243a9ac96ff6 Gerrit-Change-Number: 26573 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 14:23:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:24:38 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:24:38 +0000 Subject: Change in ...osmo_ss7[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/26565 ) Change subject: treewide: remove FSF address ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/26565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_ss7 Gerrit-Branch: master Gerrit-Change-Id: Ic8c69d24141abd183e3b1257f4e9edfd9c1afabe Gerrit-Change-Number: 26565 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: matt9j Gerrit-Comment-Date: Wed, 15 Dec 2021 14:24:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:24:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:24:40 +0000 Subject: Change in ...osmo_ss7[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/26565 ) Change subject: treewide: remove FSF address ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/26565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_ss7 Gerrit-Branch: master Gerrit-Change-Id: Ic8c69d24141abd183e3b1257f4e9edfd9c1afabe Gerrit-Change-Number: 26565 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: matt9j Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:24:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:24:43 +0000 Subject: Change in ...osmo_ss7[master]: treewide: remove FSF address In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/26565 ) Change subject: treewide: remove FSF address ...................................................................... treewide: remove FSF address Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: Ic8c69d24141abd183e3b1257f4e9edfd9c1afabe --- M include/ipa.hrl M src/ipa_proto.erl M src/ipa_proto_ccm.erl 3 files changed, 0 insertions(+), 12 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/include/ipa.hrl b/include/ipa.hrl index f0372f4..a652629 100644 --- a/include/ipa.hrl +++ b/include/ipa.hrl @@ -11,10 +11,6 @@ % but WITHOUT ANY WARRANTY; without even the implied warranty of % MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the % GNU General Public License for more details. -% -% You should have received a copy of the GNU General Public License along -% with this program; if not, write to the Free Software Foundation, Inc., -% 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -ifndef(IPA). -define(IPA, true). diff --git a/src/ipa_proto.erl b/src/ipa_proto.erl index d1d4396..ceb024a 100644 --- a/src/ipa_proto.erl +++ b/src/ipa_proto.erl @@ -14,10 +14,6 @@ % but WITHOUT ANY WARRANTY; without even the implied warranty of % MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the % GNU General Public License for more details. -% -% You should have received a copy of the GNU General Public License along -% with this program; if not, write to the Free Software Foundation, Inc., -% 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -module(ipa_proto). -author('Harald Welte '). diff --git a/src/ipa_proto_ccm.erl b/src/ipa_proto_ccm.erl index cfd3863..27ceba9 100644 --- a/src/ipa_proto_ccm.erl +++ b/src/ipa_proto_ccm.erl @@ -13,10 +13,6 @@ % but WITHOUT ANY WARRANTY; without even the implied warranty of % MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the % GNU General Public License for more details. -% -% You should have received a copy of the GNU General Public License along -% with this program; if not, write to the Free Software Foundation, Inc., -% 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -module(ipa_proto_ccm). -author('Harald Welte '). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/26565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_ss7 Gerrit-Branch: master Gerrit-Change-Id: Ic8c69d24141abd183e3b1257f4e9edfd9c1afabe Gerrit-Change-Number: 26565 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: matt9j Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:25:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:25:01 +0000 Subject: Change in simtrace2[master]: wireshark lua dissector: dissect more In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26572 ) Change subject: wireshark lua dissector: dissect more ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If81812b6330205a65c1c9b7d4240094b71f3c757 Gerrit-Change-Number: 26572 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 15 Dec 2021 14:25:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:25:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 14:25:03 +0000 Subject: Change in simtrace2[master]: wireshark lua dissector: dissect more In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26572 ) Change subject: wireshark lua dissector: dissect more ...................................................................... wireshark lua dissector: dissect more Change-Id: If81812b6330205a65c1c9b7d4240094b71f3c757 --- M contrib/simtrace.lua 1 file changed, 96 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/simtrace.lua b/contrib/simtrace.lua index 1ca1b0b..efae492 100644 --- a/contrib/simtrace.lua +++ b/contrib/simtrace.lua @@ -42,14 +42,38 @@ local tpdu_hdr = ProtoField.uint32("usb_simtrace.tpdu_hdr", "tpdu_hdr", base.HEX_DEC, NULL, 0x1) local rxtxdatalen = ProtoField.uint16("usb_simtrace.rxtxdatalen", "rx/tx data length", base.HEX_DEC) local rxtxdata = ProtoField.bytes("usb_simtrace.rxtxdata", "rx/tx (data)") -usb_simtrace_protocol.fields = { - msgtype, seqnr, slotnr, reserved, payloadlen, payload, pb_and_rx, pb_and_tx, final, tpdu_hdr, rxtxdatalen, rxtxdata + +local CEMU_STATUS_F_VCC_PRESENT = ProtoField.uint32("usb_simtrace.CEMU_STATUS.F_VCC_PRESENT", "VCC_PRESENT", base.HEX_DEC, NULL, 0x00000001) +local CEMU_STATUS_F_CLK_ACTIVE = ProtoField.uint32("usb_simtrace.CEMU_STATUS.F_CLK_ACTIVE", "CLK_ACTIVE", base.HEX_DEC, NULL, 0x00000002) +local CEMU_STATUS_F_RCEMU_ACTIVE = ProtoField.uint32("usb_simtrace.CEMU_STATUS.F_RCEMU_ACTIVE", "CEMU_ACTIVE", base.HEX_DEC, NULL, 0x00000004) +local CEMU_STATUS_F_CARD_INSERT = ProtoField.uint32("usb_simtrace.CEMU_STATUS.F_CARD_INSERT", "CARD_INSERT", base.HEX_DEC, NULL, 0x00000008) +local CEMU_STATUS_F_RESET_ACTIVE = ProtoField.uint32("usb_simtrace.CEMU_STATUS.F_RESET_ACTIVE", "RESET_ACTIVE", base.HEX_DEC, NULL, 0x00000010) + +local modem_reset_types = { + [0x00] = "de-assert", + [0x01] = "assert", + [0x02] = "pulse" } +local modem_reset_status = ProtoField.uint8("usb_simtrace.modem.reset_type", "modem reset type", base.HEX, modem_reset_types, 0xf) +local modem_reset_len = ProtoField.uint8("usb_simtrace.modem.reset_len", "modem reset length (ms)", base.DEC) + +usb_simtrace_protocol.fields = { + msgtype, seqnr, slotnr, reserved, payloadlen, payload, + pb_and_rx, pb_and_tx, final, tpdu_hdr, rxtxdatalen, rxtxdata, + CEMU_STATUS_F_VCC_PRESENT, CEMU_STATUS_F_CLK_ACTIVE, CEMU_STATUS_F_RCEMU_ACTIVE, CEMU_STATUS_F_CARD_INSERT, CEMU_STATUS_F_RESET_ACTIVE, + modem_reset_status, modem_reset_len +} + +local is_hdr = Field.new("usb_simtrace.tpdu_hdr") +local is_pbrx = Field.new("usb_simtrace.pb_and_rx") +local is_pbtx = Field.new("usb_simtrace.pb_and_tx") +local is_final= Field.new("usb_simtrace.final") + function dissect_rxtx(payload_data,pinfo,tree) local headerSubtree = tree:add(usb_simtrace_protocol, payload_data, "rx/tx data") - local len = payload_data(8+4,2):le_uint(); - local cmd32 = payload_data(8+0,4):le_uint(); + local len = payload_data(4,2):le_uint(); + local cmd32 = payload_data(0,4):le_uint(); headerSubtree:add(pb_and_rx, cmd32) headerSubtree:add(pb_and_tx, cmd32) @@ -57,7 +81,65 @@ headerSubtree:add(tpdu_hdr, cmd32) headerSubtree:add(rxtxdatalen, len) - headerSubtree:add_le(rxtxdata, payload_data(8+6,len)) + headerSubtree:add_le(rxtxdata, payload_data(6,len)) + + -- ghetto dissection does not work due to mixed in procedure bytes + --if pinfo.visited == false then + -- Dissector.get("iso7816"):call(payload_data(6):tvb(), pinfo, tree) + +-- local offs = 0 +-- if (is_pbrx().value == 1 or is_pbtx().value == 1) and is_final().value == 0 then +-- offs = 1 +-- else +-- offs = 0 +-- end +-- +-- if is_hdr().value == 1 then +-- Dissector.get("gsm_sim"):call(concatss:tvb(), pinfo, tree) +-- concatss = payload_data(6):bytes() +-- else +-- concatss = concatss .. payload_data(6+offs):bytes() +-- end + +--end + +end + +function dissect_status(payload_data,pinfo,tree) + + local headerSubtree = tree:add(usb_simtrace_protocol, payload_data, "status message") + local cmd32 = payload_data(0,4):le_uint(); + + headerSubtree:add(CEMU_STATUS_F_VCC_PRESENT, cmd32) + headerSubtree:add(CEMU_STATUS_F_CLK_ACTIVE, cmd32) + headerSubtree:add(CEMU_STATUS_F_RCEMU_ACTIVE, cmd32) + headerSubtree:add(CEMU_STATUS_F_CARD_INSERT, cmd32) + headerSubtree:add(CEMU_STATUS_F_RESET_ACTIVE, cmd32) + + pinfo.cols.info:append(" VCC:" .. payload_data(0,1):bitfield(7, 1) .. " CLK:" .. payload_data(0,1):bitfield(6, 1) .. " RESET:" .. payload_data(0,1):bitfield(3, 1)) +end + +function dissect_atr(payload_data,pinfo,tree) + + local len = payload_data(0,1):le_uint() + Dissector.get("iso7816.atr"):call(payload_data(1):tvb(), pinfo, tree) +end + +function dissect_modem_reset(payload_data,pinfo,tree) + + local headerSubtree = tree:add(usb_simtrace_protocol, payload_data, "modem reset") + local cmd8 = payload_data(0,1):le_uint(); + + headerSubtree:add(modem_reset_status, cmd8) + pinfo.cols.info:append(" reset type:" .. modem_reset_types[cmd8]); + + if(cmd8 == 2) then + local duration = payload_data(1,2):le_uint() + headerSubtree:add(modem_reset_len, duration) + pinfo.cols.info:append(" duration:" .. duration .. "ms") + end + + end function usb_simtrace_protocol.dissector(buffer, pinfo, tree) @@ -76,7 +158,13 @@ pinfo.cols.info = string.format("Cmd 0x%04X : %s", command, control_commands[command]) local payload_data = buffer(8,length-8) if(command == 0x0101 or command == 0x0106) then - return dissect_rxtx(buffer(),pinfo,subtree) + return dissect_rxtx(payload_data(),pinfo,subtree) + elseif(command == 0x0104) then + return dissect_status(payload_data(),pinfo,subtree) + elseif(command == 0x0102) then + return dissect_atr(payload_data(),pinfo,subtree) + elseif(command == 0x0201) then + return dissect_modem_reset(payload_data(),pinfo,subtree) else subtree:add(payload, payload_data) end @@ -89,4 +177,6 @@ usb_product_dissectors:add(0x1d50616d, usb_simtrace_protocol) usb_product_dissectors:add(0x1d50616e, usb_simtrace_protocol) DissectorTable.get("usb.bulk"):add(0xffff, usb_simtrace_protocol) +DissectorTable.get("usb.interrupt"):add(0xffff, usb_simtrace_protocol) +--concatss = ByteArray.new() end -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If81812b6330205a65c1c9b7d4240094b71f3c757 Gerrit-Change-Number: 26572 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:29:16 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 15 Dec 2021 14:29:16 +0000 Subject: Change in docker-playground[master]: ttcn3-{sgsn, ggsn}-test: set OSMO_SUT_{HOST, PORT} In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26573 ) Change subject: ttcn3-{sgsn,ggsn}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I61fef7763e6445c231ff2664036e243a9ac96ff6 Gerrit-Change-Number: 26573 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 14:29:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:29:20 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 15 Dec 2021 14:29:20 +0000 Subject: Change in docker-playground[master]: ttcn3-{sgsn, ggsn}-test: set OSMO_SUT_{HOST, PORT} In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26573 ) Change subject: ttcn3-{sgsn,ggsn}-test: set OSMO_SUT_{HOST,PORT} ...................................................................... ttcn3-{sgsn,ggsn}-test: set OSMO_SUT_{HOST,PORT} This enables the test suite to obtain talloc reports between the test case executions, which get stored together with the PCAP files. Change-Id: I61fef7763e6445c231ff2664036e243a9ac96ff6 Related: Icd4c2d80db934535d499598282ed9416d8088163 --- M ttcn3-ggsn-test/jenkins.sh M ttcn3-sgsn-test/jenkins.sh 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved fixeria: Verified diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh index cdf9bf8..53da74d 100755 --- a/ttcn3-ggsn-test/jenkins.sh +++ b/ttcn3-ggsn-test/jenkins.sh @@ -46,12 +46,14 @@ -v "$KERNEL_TEST_DIR:/kernel-test:ro" -v "$CACHE_DIR:/cache" " + OSMO_SUT_HOST="172.18.$SUBNET.200" else cp osmo-ggsn.cfg $VOL_BASE_DIR/ggsn/ GGSN_DOCKER_ARGS=" $(docker_network_params $SUBNET 201) " + OSMO_SUT_HOST="172.18.$SUBNET.201" fi docker run --cap-add=NET_ADMIN \ --device /dev/net/tun:/dev/net/tun \ @@ -74,6 +76,8 @@ --ulimit core=-1 \ -v $VOL_BASE_DIR/ggsn-tester:/data \ -e "TTCN3_PCAP_PATH=/data" \ + -e "OSMO_SUT_HOST=$OSMO_SUT_HOST" \ + -e "OSMO_SUT_PORT=4260" \ --name ${BUILD_TAG}-ggsn-test \ $DOCKER_ARGS \ $REPO_USER/ttcn3-ggsn-test diff --git a/ttcn3-sgsn-test/jenkins.sh b/ttcn3-sgsn-test/jenkins.sh index 24869c5..dde90a2 100755 --- a/ttcn3-sgsn-test/jenkins.sh +++ b/ttcn3-sgsn-test/jenkins.sh @@ -49,6 +49,8 @@ $(docker_network_params $SUBNET 103) \ --ulimit core=-1 \ -e "TTCN3_PCAP_PATH=/data" \ + -e "OSMO_SUT_HOST=172.18.$SUBNET.10" \ + -e "OSMO_SUT_PORT=4245" \ -v $VOL_BASE_DIR/sgsn-tester:/data \ --name ${BUILD_TAG}-ttcn3-sgsn-test \ $DOCKER_ARGS \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I61fef7763e6445c231ff2664036e243a9ac96ff6 Gerrit-Change-Number: 26573 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:33:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 15 Dec 2021 14:33:07 +0000 Subject: Change in docker-playground[master]: Add Dockerfile for OpenBTS-UMTS References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26574 ) Change subject: Add Dockerfile for OpenBTS-UMTS ...................................................................... Add Dockerfile for OpenBTS-UMTS Change-Id: Ibbab5973b84047ee7654a5fb2a8e4b36e1d43847 --- A openbts-umts/Dockerfile A openbts-umts/Makefile 2 files changed, 69 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/74/26574/1 diff --git a/openbts-umts/Dockerfile b/openbts-umts/Dockerfile new file mode 100644 index 0000000..b3fd386 --- /dev/null +++ b/openbts-umts/Dockerfile @@ -0,0 +1,64 @@ +# See https://fairwaves.co/blog/openbts-umts-3g-umtrx/ + +# Ancient software requires ancient distro +FROM debian:jessie + +MAINTAINER Vadim Yanitskiy + +RUN apt-get update && \ + apt-get install -y --no-install-recommends \ + --no-install-suggests \ + ca-certificates \ + build-essential \ + pkg-config \ + debhelper \ + automake \ + autoconf \ + libtool-bin \ + libtool \ + unzip \ + wget \ + git \ + libboost-dev \ + libreadline6-dev \ + libusb-1.0-0-dev \ + libsqlite3-dev \ + libosip2-dev \ + libortp-dev \ + libzmq3-dev \ + python-zmq \ + libuhd-dev + +WORKDIR /home/root + +# Download and install UHD firmware +ARG UHD_RELEASE="003.007.003" +RUN wget http://files.ettus.com/binaries/maint_images/archive/uhd-images_$UHD_RELEASE-release.zip && \ + unzip uhd-images_$UHD_RELEASE-release.zip && \ + cp -r uhd-images_$UHD_RELEASE-release/share/uhd/ /usr/share/ + +# Install asn1c +ARG ASN1C_COMMIT="80b3752c8093251a1ef924097e9894404af2d304" +RUN git clone https://github.com/vlm/asn1c.git +RUN cd asn1c && \ + git checkout $ASN1C_COMMIT && \ + ./configure && \ + make install + +# Install libcoredumper +RUN git clone https://github.com/RangeNetworks/libcoredumper.git +RUN cd libcoredumper && \ + ./build.sh && \ + dpkg -i libcoredumper*.deb + +# Finally, install OpenBTS-UMTS +RUN git clone https://github.com/RangeNetworks/OpenBTS-UMTS.git +RUN cd OpenBTS-UMTS && \ + git submodule init && \ + git submodule update && \ + ./autogen.sh && \ + ./configure && \ + make install && \ + make clean + +CMD cd /OpenBTS/ && ./OpenBTS-UMTS diff --git a/openbts-umts/Makefile b/openbts-umts/Makefile new file mode 100644 index 0000000..b030a43 --- /dev/null +++ b/openbts-umts/Makefile @@ -0,0 +1,5 @@ +RUN_ARGS?= \ + --privileged \ + -v /dev/bus/usb:/dev/bus/usb + +include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibbab5973b84047ee7654a5fb2a8e4b36e1d43847 Gerrit-Change-Number: 26574 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:39:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 14:39:15 +0000 Subject: Change in osmo-hnodeb[master]: Initial implementation of LowerLayer UD Socket In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 ) Change subject: Initial implementation of LowerLayer UD Socket ...................................................................... Initial implementation of LowerLayer UD Socket The LLSK socket is an interface allowing thid-parties to implement and hook their RLC/MAC/RRC stack to osmo-hnodbe, which takes care of interconnection with the rest of the RAN and core network (Iuh, RTP, GTP-U, etc.). Related: SYS#5516 Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d --- A doc/hnodeb.msc M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h A include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/ranap.h M include/osmocom/hnodeb/rua.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/hnb_shutdown_fsm.c M src/osmo-hnodeb/hnbap.c A src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_iuh.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/ranap.c M src/osmo-hnodeb/rua.c M src/osmo-hnodeb/vty.c 19 files changed, 1,083 insertions(+), 40 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/hnodeb.msc b/doc/hnodeb.msc new file mode 100644 index 0000000..6ad6e7c --- /dev/null +++ b/doc/hnodeb.msc @@ -0,0 +1,86 @@ +msc { + hscale="3"; + ue [label="Customer"], trx [label="Lower Layer TRX"], hnodeb [label="osmo-hnodeb"], hnbgw [label="HNBGW"], ggsn [label="GGSN"], mgw [label="MGW"]; + + |||; + --- [ label = "hNodeB starts up" ]; + hnodeb => hnbgw [label="HNBAP HnbRegisterRequest"]; + hnodeb <= hnbgw [label="HNBAP HnbRegisterResponse"]; + |||; + ...; + |||; + |||; + --- [ label = "TRX starts up & connects to hNodeB" ]; + trx => hnodeb [label="CTL-HELLO.req(SAPI=CTL, VERSION)"]; + trx <= hnodeb [label="CTL-HELLO.cnf(SAPI=CTL, VERSION)"]; + trx => hnodeb [label="CTL-HELLO.req(SAPI=IUH, VERSION)"]; + trx <= hnodeb [label="CTL-HELLO.cnf(SAPI=IUH, VERSION)"]; + trx => hnodeb [label="CTL-HELLO.req(SAPI=GTP, VERSION)"]; + trx <= hnodeb [label="CTL-HELLO.cnf(SAPI=GTP, VERSION)"]; + trx => hnodeb [label="CTL-HELLO.req(SAPI=AUDIO, VERSION)"]; + trx <= hnodeb [label="CTL-HELLO.cnf(SAPI=AUDIO, VERSION)"]; + trx <= hnodeb [label="IUH-CONFIGURE.ind(PLMN,LAC,SAC,RAC,CI,RNC_ID from HnbRegisterResponse)"]; + |||; + ...; + |||; + |||; + --- [ label = "Subscriber Paging" ]; + hnodeb <= hnbgw [label="RUA-InitiatingMessage(RANAP Paging)"]; + trx <= hnodeb [label="IUH-UNITDATA.ind[RANAP Paging]"]; + |||; + ...; + |||; + |||; + --- [ label = "Subscriber Sign Up" ]; + ue => trx [label="CM Service Req"]; + trx => hnodeb [label="IUH-CONN_ESTABLISH.req[RANAP CM ServiceReq]"]; + hnodeb => hnbgw [label="HNBAP UE Register Req(IMSI?)"]; + hnodeb <= hnbgw [label="HNBAP UE Register Acc(context_id)"]; + hnodeb => hnbgw [label="RUA-Connect(RANAP-GMM ServiceRequest)"]; + hnodeb <= hnbgw [label="RUA-DirectTransfer(RANAP GMM ServiceAccept)"]; + trx <= hnodeb [label="IUH-CONN_ESTABLISH.cnf(context_id])"]; + trx <= hnodeb [label="IUH-CONN_DATA.ind[context_id, RANAP GMM ServiceAccept]"]; + --- [ label = "Subscriber set up PS data:" ]; + hnodeb <= hnbgw [label="RANAP RAB-Assignment Request(TEI, ADDR)"]; + trx <= hnodeb [label="IUH-CONN_DATA.ind[RANAP RAB-Assignment Request(remote_ip, remote_port, remote_tei)]"]; + trx => hnodeb [label="GTP-CONN_ESTABLISH.req(remote_ip,remote_port,remote_tei)"]; + ... [ label = "HnodeB sets up GTP-U connection" ]; + trx <= hnodeb [label="GTP-CONN_ESTABLISH.cnf(local_ip,local_port,local_tei,remote_tei)"]; + |||; + ...; + |||; + |||; + --- [ label = "PS data transmission over GTP-U:" ]; + ue => trx [label="..."]; + trx => hnodeb [label="GTP-CONN_DATA.req[remote_tei,payload]"]; + hnodeb => ggsn [label="GTP-U(remote_tei, local_addr, remote_addr, payload)"]; + hnodeb <= ggsn [label="GTP-U(local_tei, remote_addr, local_addr, payload)"]; + trx <= hnodeb [label="GTP-CONN_DATA.ind[local_tei,payload]"]; + ue <= trx [label="..."]; + |||; + ...; + |||; + --- [ label = "MO/MT PS data Release:" ]; + ue => trx [label="..."]; + trx => hnodeb [label="IUH-CONN_DATA.req[RANAP IU Release Request]"]; + hnodeb => hnbgw [label="RANAP IU Release Request"]; + hnodeb <= hnbgw [label="RANAP IU Release Command"]; + trx <= hnodeb [label="IUH-CONN_DATA.ind[RANAP IU Release Command]"]; + ...; + trx => hnodeb [label="GTP-CONN_RELEASE.req(remote_tei)"]; + + trx => hnodeb [label="IUH-CONN_RELEASE.req[RANAP IU Release Complete]"]; + hnodeb => hnbgw [label="RUA-Disconnect(RANAP IU Release Complete)"]; + + |||; + ...; + |||; + --- [ label = "For voice call (CS): Similar to SAPI_GTP, but using SAPI_AUDIO and osmo-hnodeb sets up RTP stream" ]; + + + |||; + ...; + |||; + --- [ label = "Iuh SCTP link goes down" ]; + trx <= hnodeb [label="UD socket is closed, osmo-hnodeb cleans up state and attempts reconnect. lowerlayer can re-connect and wait for next CONFIGURE.req"]; +} diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index 6fa587d..62af5bb 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -1,8 +1,10 @@ noinst_HEADERS = \ hnb_shutdown_fsm.h \ + hnb_prim.h \ hnbap.h \ hnodeb.h \ iuh.h \ + llsk.h \ ranap.h \ rua.h \ vty.h \ diff --git a/include/osmocom/hnodeb/hnb_prim.h b/include/osmocom/hnodeb/hnb_prim.h new file mode 100644 index 0000000..6d597c4 --- /dev/null +++ b/include/osmocom/hnodeb/hnb_prim.h @@ -0,0 +1,165 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +/* This header includes information relative to protocol and message structure + * spoken between osmo-hnodeb, facing the HNBGW and other RAN/CN nodes, and a + * Lower Layer program (aka the TRX), implementing the RLC/MAC/RRC towards the + * UE in the Uu interface. This protocol is usually referenced as HNBLLIF. The + * protocol is primitive based and follows the concepts described in ITU-T + * X.210, with osmo-hnodeb taking the "service provider" role and the TRX taking + * the "user" role in this case. + */ + +#pragma once + +#include +#include +#include + +#include + +#define HNB_PRIM_API_VERSION 0 +#define HNB_PRIM_UD_SOCK_DEFAULT "/tmp/hnb_prim_sock" + +#define HNB_PRIM_SAPI_IUH 1 +#define HNB_PRIM_SAPI_GTP 2 +#define HNB_PRIM_SAPI_AUDIO 3 + +/*! \brief HNB_IUH primitives */ +enum hnb_iuh_prim_type { + HNB_IUH_PRIM_CONFIGURE, + HNB_IUH_PRIM_CONN_ESTABLISH, + HNB_IUH_PRIM_CONN_RELEASE, + HNB_IUH_PRIM_CONN_DATA, + HNB_IUH_PRIM_UNITDATA, + _HNB_IUH_PRIM_MAX +}; + +/* HNB_IUH_PRIM_CONFIGURE.ind, DL */ +struct hnb_iuh_configure_ind_param { + uint16_t mcc; + uint16_t mnc; + uint16_t cell_identity; + uint16_t lac; + uint8_t rac; + uint8_t reserved; + uint16_t sac; + uint16_t rnc_id; +} __attribute__ ((packed)); + +/* HNB_HNB_IUH_PRIM_CONN_ESTABLISH.ind, DL */ +struct hnb_iuh_conn_establish_ind_param { + uint32_t context_id; + uint8_t domain; + uint8_t cause; + uint8_t csg_membership_status; + uint8_t spare1; + uint32_t data_len; /* RANAP message length in bytes */ + uint8_t data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_HNB_IUH_PRIM_CONN_ESTABLISH.req, UL */ +struct hnb_iuh_conn_establish_req_param { + uint32_t context_id; + uint8_t domain; + uint8_t est_cause; + /* TODO: Check if we can copy it as an encoded buffer RRC <-> RUA + * RRC: 3GPP TS 25.331 10.3.1.6 Intra Domain NAS Node Selector + * RUA: 3GPP TS 25.468 9.2.4 */ + uint16_t reserved; //uint16_t nas_node_selector_bitlen; + //uint8_t nas_node_selector[128]; /* TODO: check whether we can decrease this buffer size */ + uint32_t data_len; /* RANAP message length in bytes */ + uint8_t data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_HNB_IUH_PRIM_CONN_ESTABLISH.cnf, DL */ +struct hnb_iuh_conn_establish_cnf_param { + uint32_t context_id; + uint8_t domain; + uint8_t cause; /* 0 = success, !0 = failure */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_CONN_RELEASE.req, DL */ +struct hnb_iuh_conn_release_req_param { + uint32_t context_id; + uint8_t domain; + uint8_t spare1; + uint8_t cause_type; /* 3GPP TS 25.468 9.2.7 Cause */ + uint8_t cause; /* 3GPP TS 25.468 9.2.7 Cause */ + uint32_t data_len; /* RANAP message length in bytes */ + uint8_t data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_CONN_RELEASE.ind, UL */ +struct hnb_iuh_conn_release_ind_param { + uint32_t context_id; + uint8_t domain; + uint8_t spare1; + uint8_t cause_type; + uint8_t cause; + uint32_t data_len; /* RANAP message length in bytes */ + uint8_t data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_CONN_DATA.req, DL */ +struct hnb_iuh_conn_data_req_param { + uint32_t context_id; + uint8_t domain; + uint8_t spare1; + uint16_t spare2; + uint32_t data_len; /* RANAP message length in bytes */ + uint8_t data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_CONN_DATA.ind, UL */ +struct hnb_iuh_conn_data_ind_param { + uint32_t context_id; + uint8_t domain; + uint8_t spare1; + uint16_t spare2; + uint32_t data_len; /* RANAP message length in bytes */ + uint8_t data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_UNITDATA.req, UL */ +struct hnb_iuh_unitdata_req_param { + uint32_t data_len; /* RANAP message length in bytes */ + uint8_t data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +/* HNB_IUH_PRIM_UNITDATA.ind, DL */ +struct hnb_iuh_unitdata_ind_param { + uint32_t data_len; /* RANAP message length in bytes */ + uint8_t data[0]; /* RANAP message */ +} __attribute__ ((packed)); + +struct hnb_iuh_prim { + struct osmo_prim_hdr hdr; + union { + struct hnb_iuh_configure_ind_param configure_ind; + struct hnb_iuh_conn_establish_req_param conn_establish_req; + struct hnb_iuh_conn_establish_ind_param conn_establish_ind; + struct hnb_iuh_conn_establish_cnf_param conn_establish_cnf; + struct hnb_iuh_conn_release_req_param conn_release_req; + struct hnb_iuh_conn_release_ind_param conn_release_ind; + struct hnb_iuh_conn_data_req_param conn_data_req; + struct hnb_iuh_conn_data_ind_param conn_data_ind; + struct hnb_iuh_unitdata_req_param unitdata_req; + struct hnb_iuh_unitdata_ind_param unitdata_ind; + } u; +} __attribute__ ((packed)); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index a629b4e..fd7d1e9 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -19,29 +19,51 @@ */ #pragma once +#include +#include + #include #include +#include #include #include #include #include +#include #include +#include + enum { DMAIN, DHNBAP, DRUA, DRANAP, DSCTP, + DLLSK, }; extern const struct log_info hnb_log_info; -struct hnb_chan { - int is_ps; +struct hnb; + +struct hnb_ue { + struct llist_head list; /* Item in struct hnb->ue_list */ + struct hnb *hnb; /* backpointer */ uint32_t conn_id; - char *imsi; + char imsi[OSMO_IMSI_BUF_SIZE]; + struct hnb_ue_cs_ctx { + bool active; /* Is this chan in use? */ + bool conn_est_cnf_pending; /* Did we send CONN_ESTABLISH_CNF to lower layers? */ + } conn_cs; + struct hnb_ue_ps_ctx { + bool active; /* Is this chan in use? */ + bool conn_est_cnf_pending; /* Did we send CONN_ESTABLISH_CNF to lower layers? */ + } conn_ps; }; +struct hnb_ue *hnb_ue_alloc(struct hnb *hnb, uint32_t conn_id); +void hnb_ue_free(struct hnb_ue *ue); +void hnb_ue_reset_chan(struct hnb_ue *ue, bool is_ps); struct hnb { char *identity; /* HNB-Identity */ @@ -58,20 +80,27 @@ struct osmo_stream_cli *client; } iuh; + /* Lower Layer UD socket */ + struct osmo_prim_srv_link *llsk_link; + struct osmo_prim_srv *llsk; + uint8_t llsk_valid_sapi_mask; + struct osmo_timer_list llsk_defer_configure_ind_timer; + uint16_t rnc_id; + bool registered; /* Set to true once HnbRegisterAccept was received from Iuh. rnc_id is valid iif registered==true */ uint32_t ctx_id; struct osmo_fsm_inst *shutdown_fi; /* FSM instance to manage shutdown procedure during process exit */ bool shutdown_fi_exit_proc; /* exit process when shutdown_fsm is finished? */ - struct { - struct hnb_chan *chan; - } cs; + struct llist_head ue_list; /* list of struct hnb_ue */ }; struct hnb *hnb_alloc(void *tall_ctx); void hnb_free(struct hnb *hnb); +struct hnb_ue *hnb_find_ue_by_id(const struct hnb *hnb, uint32_t conn_id); +struct hnb_ue *hnb_find_ue_by_imsi(const struct hnb *hnb, char *imsi); extern void *tall_hnb_ctx; extern struct hnb *g_hnb; diff --git a/include/osmocom/hnodeb/llsk.h b/include/osmocom/hnodeb/llsk.h new file mode 100644 index 0000000..ab39439 --- /dev/null +++ b/include/osmocom/hnodeb/llsk.h @@ -0,0 +1,44 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include +#include + +#include +#include +#include + +struct hnb; + +int hnb_llsk_alloc(struct hnb *hnb); +bool hnb_llsk_connected(const struct hnb *hnb); +bool hnb_llsk_can_be_configured(struct hnb *hnb); + + +extern const struct value_string hnb_iuh_prim_type_names[]; +int llsk_rx_iuh(struct hnb *hnb, struct osmo_prim_hdr *oph); +int llsk_iuh_tx_configure_ind(struct hnb *hnb); +struct hnb_iuh_prim *hnb_iuh_makeprim_conn_establish_cnf(uint32_t context_id, uint8_t domain, + uint8_t cause); +struct hnb_iuh_prim *hnb_iuh_makeprim_conn_data_ind(uint32_t context_id, + uint8_t domain, + const uint8_t *data, + uint32_t data_len); +struct hnb_iuh_prim *hnb_iuh_makeprim_unitdata_ind(const uint8_t *data, uint32_t data_len); diff --git a/include/osmocom/hnodeb/ranap.h b/include/osmocom/hnodeb/ranap.h index 474de70..6e9c9b7 100644 --- a/include/osmocom/hnodeb/ranap.h +++ b/include/osmocom/hnodeb/ranap.h @@ -19,4 +19,6 @@ */ #pragma once +#include +struct msgb *hnb_ranap_msgb_alloc(void); diff --git a/include/osmocom/hnodeb/rua.h b/include/osmocom/hnodeb/rua.h index ea7e81c..e780207 100644 --- a/include/osmocom/hnodeb/rua.h +++ b/include/osmocom/hnodeb/rua.h @@ -22,6 +22,9 @@ #include struct hnb; +struct hnb_ue; struct msgb; +struct msgb *hnb_rua_msgb_alloc(void); + int hnb_rua_rx(struct hnb *hnb, struct msgb *msg); diff --git a/include/osmocom/hnodeb/vty.h b/include/osmocom/hnodeb/vty.h index e30019e..627436d 100644 --- a/include/osmocom/hnodeb/vty.h +++ b/include/osmocom/hnodeb/vty.h @@ -27,6 +27,7 @@ enum hnb_vty_nodes { HNODEB_NODE = _LAST_OSMOVTY_NODE, IUH_NODE, + LLSK_NODE, }; void hnb_vty_init(void); diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 82ccd37..b6d2d49 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -35,6 +35,8 @@ hnb.c \ hnb_shutdown_fsm.c \ iuh.c \ + llsk.c \ + llsk_iuh.c \ ranap.c \ rua.c \ vty.c \ diff --git a/src/osmo-hnodeb/debug.c b/src/osmo-hnodeb/debug.c index 45ccc0c..f34851b 100644 --- a/src/osmo-hnodeb/debug.c +++ b/src/osmo-hnodeb/debug.c @@ -24,7 +24,7 @@ static const struct log_info_cat log_cat[] = { [DMAIN] = { .name = "DMAIN", .loglevel = LOGL_NOTICE, .enabled = 1, - .color = "", + .color = "\033[1;37m", .description = "Main program", }, [DHNBAP] = { @@ -47,6 +47,11 @@ .color = "\033[1;36m", .description = "SCTP connection on the Iuh link", }, + [DLLSK] = { + .name = "DLLSK", .loglevel = LOGL_NOTICE, .enabled = 1, + .color = "\033[1;31m", + .description = "Lower Layer Unix Domain Socket", + }, }; const struct log_info hnb_log_info = { diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index b7be4ea..1ac2efc 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -23,10 +23,12 @@ #include #include #include +#include #include #include #include +#include struct hnb *hnb_alloc(void *tall_ctx) @@ -37,15 +39,18 @@ if (!hnb) return NULL; + INIT_LLIST_HEAD(&hnb->ue_list); + hnb->identity = talloc_strdup(hnb, "OsmoHNodeB"); hnb->plmn = (struct osmo_plmn_id){ .mcc = 1, .mnc = 1, }; - hnb->shutdown_fi = osmo_fsm_inst_alloc(&hnb_shutdown_fsm, hnb, hnb, LOGL_INFO, NULL); + hnb_llsk_alloc(hnb); + hnb_iuh_alloc(hnb); return hnb; @@ -53,10 +58,78 @@ void hnb_free(struct hnb *hnb) { + struct hnb_ue *ue, *ue_tmp; + + llist_for_each_entry_safe(ue, ue_tmp, &hnb->ue_list, list) + hnb_ue_free(ue); + if (hnb->shutdown_fi) { osmo_fsm_inst_free(hnb->shutdown_fi); hnb->shutdown_fi = NULL; } hnb_iuh_free(hnb); + + osmo_timer_del(&hnb->llsk_defer_configure_ind_timer); + osmo_prim_srv_link_free(hnb->llsk_link); + hnb->llsk_link = NULL; + talloc_free(hnb); } + +struct hnb_ue *hnb_ue_alloc(struct hnb *hnb, uint32_t conn_id) +{ + struct hnb_ue *ue; + + ue = talloc_zero(hnb, struct hnb_ue); + if (!ue) + return NULL; + + ue->hnb = hnb; + ue->conn_id = conn_id; + + llist_add(&ue->list, &hnb->ue_list); + + return ue; +} + +void hnb_ue_free(struct hnb_ue *ue) +{ + llist_del(&ue->list); + talloc_free(ue); +} + +void hnb_ue_reset_chan(struct hnb_ue *ue, bool is_ps) +{ + if (is_ps) + ue->conn_ps = (struct hnb_ue_ps_ctx){0}; + else + ue->conn_cs = (struct hnb_ue_cs_ctx){0}; +} + +struct hnb_ue *hnb_find_ue_by_id(const struct hnb *hnb, uint32_t conn_id) +{ + struct hnb_ue *ue; + + llist_for_each_entry(ue, &hnb->ue_list, list) { + if (ue->conn_id != conn_id) + continue; + return ue; + } + return NULL; +} +struct hnb_ue *hnb_find_ue_by_imsi(const struct hnb *hnb, char *imsi) +{ + struct hnb_ue *ue; + + if (!imsi || imsi[0] == '\0') + return NULL; + + llist_for_each_entry(ue, &hnb->ue_list, list) { + if (ue->imsi[0] == '\0') + continue; + if (strncmp(&ue->imsi[0], imsi, ARRAY_SIZE(ue->imsi)) != 0) + continue; + return ue; + } + return NULL; +} diff --git a/src/osmo-hnodeb/hnb_shutdown_fsm.c b/src/osmo-hnodeb/hnb_shutdown_fsm.c index 55de64c..5583834 100644 --- a/src/osmo-hnodeb/hnb_shutdown_fsm.c +++ b/src/osmo-hnodeb/hnb_shutdown_fsm.c @@ -34,6 +34,11 @@ static void st_none_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) { struct hnb *hnb = (struct hnb *)fi->priv; + + /* Reset state: */ + hnb->registered = false; + hnb->rnc_id = 0; + hnb_iuh_connect(hnb); /* Start reconnect once we are done with shutdown and we didn't exit process */ } diff --git a/src/osmo-hnodeb/hnbap.c b/src/osmo-hnodeb/hnbap.c index 3287eeb..ccd521e 100644 --- a/src/osmo-hnodeb/hnbap.c +++ b/src/osmo-hnodeb/hnbap.c @@ -33,7 +33,9 @@ #include #include #include +#include #include +#include static int hnb_rx_hnb_register_acc(struct hnb *hnb, ANY_t *in) { @@ -42,13 +44,19 @@ rc = hnbap_decode_hnbregisteraccepties(&accept, in); if (rc < 0) { + hnb_shutdown(hnb, "Failed decoding HnbRegisterAccept IEs", false); + return rc; } hnb->rnc_id = accept.rnc_id; + hnb->registered = true; LOGP(DHNBAP, LOGL_INFO, "Rx HNB Register accept with RNC ID %u\n", hnb->rnc_id); hnbap_free_hnbregisteraccepties(&accept); - return 0; + + if (hnb_llsk_can_be_configured(hnb)) + llsk_iuh_tx_configure_ind(hnb); + return rc; } static int hnb_rx_hnb_register_rej(struct hnb *hnb, ANY_t *in) @@ -56,6 +64,8 @@ int rc; HNBAP_HNBRegisterRejectIEs_t reject; + hnb->registered = false; + rc = hnbap_decode_hnbregisterrejecties(&reject, in); if (rc < 0) { LOGP(DHNBAP, LOGL_NOTICE, "Rx HNB Register Reject: parse failure\n"); diff --git a/src/osmo-hnodeb/llsk.c b/src/osmo-hnodeb/llsk.c new file mode 100644 index 0000000..5f0f9dc --- /dev/null +++ b/src/osmo-hnodeb/llsk.c @@ -0,0 +1,134 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include + +#include +#include + +#include +#include +#include +#include + +static int llsk_opened_cb(struct osmo_prim_srv *srv) +{ + struct hnb *hnb = (struct hnb *)osmo_prim_srv_get_priv(srv); + + if (hnb->llsk) { + LOGP(DLLSK, LOGL_ERROR, "New connection opened while one is already active, dropping it\n"); + osmo_prim_srv_close(srv); + return 0; + } + LOGP(DLLSK, LOGL_NOTICE, "LLSK conn is UP\n"); + hnb->llsk = srv; + return 0; +} + +static int llsk_closed_cb(struct osmo_prim_srv *srv) +{ + struct hnb *hnb = (struct hnb *)osmo_prim_srv_get_priv(srv); + + if (!hnb->llsk) { + LOGP(DLLSK, LOGL_ERROR, "closed_cb received but we have no active llsk conn!\n"); + return 0; + } + /* If a later conn different than active one is dropped (because we closed it): */ + if (hnb->llsk != srv) + return 0; + LOGP(DLLSK, LOGL_NOTICE, "LLSK conn is DOWN\n"); + + hnb->llsk = NULL; + hnb->llsk_valid_sapi_mask = 0x0; + osmo_timer_del(&hnb->llsk_defer_configure_ind_timer); + hnb_shutdown(hnb, "LLSK conn dropped", false); + return 0; +} + +bool hnb_llsk_connected(const struct hnb *hnb) +{ + return !!hnb->llsk; +} + +bool hnb_llsk_can_be_configured(struct hnb *hnb) +{ + if (!hnb->registered) + return false; + if (!hnb->llsk) + return false; + + if (hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_IUH)) + return true; + return false; +} + +static void llsk_defer_configure_ind_timer_cb(void *data) +{ + struct hnb *hnb = (struct hnb *)data; + llsk_iuh_tx_configure_ind(hnb); +} + +static int llsk_rx_sapi_version_cb(struct osmo_prim_srv *prim_srv, uint32_t sapi, uint16_t rem_version) +{ + struct hnb *hnb = (struct hnb *)osmo_prim_srv_get_priv(prim_srv); + if (sapi > sizeof(hnb->llsk_valid_sapi_mask)*8 - 1) + return -1; + hnb->llsk_valid_sapi_mask |= (1 << sapi); + + /* Defer CONFIGURE.req after we have confirmed the versions */ + if (hnb_llsk_can_be_configured(hnb)) + osmo_timer_schedule(&hnb->llsk_defer_configure_ind_timer, 0, 0); + + return rem_version; +} + +static int llsk_rx_cb(struct osmo_prim_srv *srv, struct osmo_prim_hdr *oph) +{ + struct hnb *hnb = (struct hnb *)osmo_prim_srv_get_priv(srv); + LOGP(DLLSK, LOGL_DEBUG, "llsk_rx_cb() SAP=%u (%u bytes): %s\n", oph->sap, + msgb_length(oph->msg), osmo_hexdump(msgb_data(oph->msg), msgb_length(oph->msg))); + + switch (oph->sap) { + case HNB_PRIM_SAPI_IUH: + return llsk_rx_iuh(hnb, oph); + case HNB_PRIM_SAPI_GTP: + case HNB_PRIM_SAPI_AUDIO: + LOGP(DLLSK, LOGL_ERROR, "Rx SAPI %u not yet implemented (len=%u)\n", + oph->sap, msgb_length(oph->msg)); + return -EINVAL; + default: + LOGP(DLLSK, LOGL_ERROR, "Rx for unknwon SAPI %u (len=%u)\n", + oph->sap, msgb_length(oph->msg)); + return -EINVAL; + } +} + +int hnb_llsk_alloc(struct hnb *hnb) +{ + hnb->llsk_link = osmo_prim_srv_link_alloc(hnb); + osmo_prim_srv_link_set_priv(hnb->llsk_link, hnb); + osmo_prim_srv_link_set_log_category(hnb->llsk_link, DLLSK); + osmo_prim_srv_link_set_addr(hnb->llsk_link, HNB_PRIM_UD_SOCK_DEFAULT); + osmo_prim_srv_link_set_opened_conn_cb(hnb->llsk_link, llsk_opened_cb); + osmo_prim_srv_link_set_closed_conn_cb(hnb->llsk_link, llsk_closed_cb); + osmo_prim_srv_link_set_rx_sapi_version_cb(hnb->llsk_link, llsk_rx_sapi_version_cb); + osmo_prim_srv_link_set_rx_cb(hnb->llsk_link, llsk_rx_cb); + osmo_timer_setup(&hnb->llsk_defer_configure_ind_timer, llsk_defer_configure_ind_timer_cb, hnb); + return 0; +} diff --git a/src/osmo-hnodeb/llsk_iuh.c b/src/osmo-hnodeb/llsk_iuh.c new file mode 100644 index 0000000..00c399a --- /dev/null +++ b/src/osmo-hnodeb/llsk_iuh.c @@ -0,0 +1,347 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +#include + +#include +#include +#include +#include +#include + +static size_t llsk_iuh_prim_size_tbl[4][_HNB_IUH_PRIM_MAX] = { + [PRIM_OP_REQUEST] = { + [HNB_IUH_PRIM_CONN_ESTABLISH] = sizeof(struct hnb_iuh_conn_establish_req_param), + [HNB_IUH_PRIM_CONN_RELEASE] = sizeof(struct hnb_iuh_conn_release_req_param), + [HNB_IUH_PRIM_CONN_DATA] = sizeof(struct hnb_iuh_conn_data_req_param), + [HNB_IUH_PRIM_UNITDATA] = sizeof(struct hnb_iuh_unitdata_req_param), + }, + [PRIM_OP_RESPONSE] = {}, + [PRIM_OP_INDICATION] = { + [HNB_IUH_PRIM_CONFIGURE] = sizeof(struct hnb_iuh_configure_ind_param), + [HNB_IUH_PRIM_CONN_DATA] = sizeof(struct hnb_iuh_conn_data_ind_param), + [HNB_IUH_PRIM_UNITDATA] = sizeof(struct hnb_iuh_unitdata_ind_param), + }, + [PRIM_OP_CONFIRM] = { + [HNB_IUH_PRIM_CONN_ESTABLISH] = sizeof(struct hnb_iuh_conn_establish_cnf_param), + }, +}; +static inline size_t llsk_iuh_prim_size(enum hnb_iuh_prim_type ptype, enum osmo_prim_operation op) +{ + size_t val = llsk_iuh_prim_size_tbl[op][ptype]; + if (val == 0) { + LOGP(DLLSK, LOGL_FATAL, "Expected prim_size != 0 for ptype=%u op=%u\n", ptype, op); + osmo_panic("Expected prim_size != 0 for ptype=%u op=%u\n", ptype, op); + } + return val; +} + +const struct value_string hnb_iuh_prim_type_names[] = { + OSMO_VALUE_STRING(HNB_IUH_PRIM_CONFIGURE), + OSMO_VALUE_STRING(HNB_IUH_PRIM_CONN_ESTABLISH), + OSMO_VALUE_STRING(HNB_IUH_PRIM_CONN_RELEASE), + OSMO_VALUE_STRING(HNB_IUH_PRIM_CONN_DATA), + { 0, NULL } +}; + + +struct hnb_iuh_prim *hnb_iuh_prim_alloc(enum hnb_iuh_prim_type ptype, enum osmo_prim_operation op, size_t extra_len) +{ + struct osmo_prim_hdr *oph; + size_t len = llsk_iuh_prim_size(ptype, op); + + oph = osmo_prim_msgb_alloc(HNB_PRIM_SAPI_IUH, ptype, op, sizeof(*oph) + len + extra_len); + if (!oph) + return NULL; + msgb_put(oph->msg, len); + + return (struct hnb_iuh_prim *)oph; +} + +struct hnb_iuh_prim *hnb_iuh_makeprim_configure_ind(uint16_t mcc, uint16_t mnc, + uint16_t cell_identity, + uint16_t lac, uint8_t rac, + uint16_t sac, uint16_t rnc_id) +{ + struct hnb_iuh_prim *iuh_prim; + + iuh_prim = hnb_iuh_prim_alloc(HNB_IUH_PRIM_CONFIGURE, PRIM_OP_INDICATION, 0); + iuh_prim->u.configure_ind.mcc = mcc; + iuh_prim->u.configure_ind.mnc = mnc; + iuh_prim->u.configure_ind.cell_identity = cell_identity; + iuh_prim->u.configure_ind.lac = lac; + iuh_prim->u.configure_ind.rac = rac; + iuh_prim->u.configure_ind.sac = sac; + iuh_prim->u.configure_ind.rnc_id = rnc_id; + + return iuh_prim; +} + +int llsk_iuh_tx_configure_ind(struct hnb *hnb) +{ + struct hnb_iuh_prim *iuh_prim; + int rc; + + LOGP(DLLSK, LOGL_INFO, "Tx IUH-CONFIGURE.ind\n"); + /* We are already registered, so configure the lower layers right now */ + iuh_prim = hnb_iuh_makeprim_configure_ind(hnb->plmn.mcc, hnb->plmn.mnc, + hnb->cell_identity, hnb->lac, + hnb->rac, hnb->sac, hnb->rnc_id); + if ((rc = osmo_prim_srv_send(hnb->llsk, iuh_prim->hdr.msg)) < 0) + LOGP(DLLSK, LOGL_ERROR, "Failed sending IUH-CONFIGURE.ind\n"); + return rc; +} + +struct hnb_iuh_prim *hnb_iuh_makeprim_conn_establish_cnf(uint32_t context_id, uint8_t domain, + uint8_t cause) +{ + struct hnb_iuh_prim *iuh_prim; + + iuh_prim = hnb_iuh_prim_alloc(HNB_IUH_PRIM_CONN_ESTABLISH, PRIM_OP_CONFIRM, 0); + iuh_prim->u.conn_establish_cnf.context_id = context_id; + iuh_prim->u.conn_establish_cnf.domain = domain; + iuh_prim->u.conn_establish_cnf.cause = cause; + + return iuh_prim; +} + +struct hnb_iuh_prim *hnb_iuh_makeprim_conn_data_ind(uint32_t context_id, + uint8_t domain, + const uint8_t *data, + uint32_t data_len) +{ + struct hnb_iuh_prim *iuh_prim; + + iuh_prim = hnb_iuh_prim_alloc(HNB_IUH_PRIM_CONN_DATA, PRIM_OP_INDICATION, data_len); + iuh_prim->u.conn_data_ind.context_id = context_id; + iuh_prim->u.conn_data_ind.domain = domain; + iuh_prim->u.conn_data_ind.data_len = data_len; + if (data_len) { + msgb_put(iuh_prim->hdr.msg, data_len); + memcpy(iuh_prim->u.conn_data_ind.data, data, data_len); + } + + return iuh_prim; +} + +struct hnb_iuh_prim *hnb_iuh_makeprim_unitdata_ind(const uint8_t *data, uint32_t data_len) +{ + struct hnb_iuh_prim *iuh_prim; + + iuh_prim = hnb_iuh_prim_alloc(HNB_IUH_PRIM_UNITDATA, PRIM_OP_INDICATION, data_len); + iuh_prim->u.unitdata_ind.data_len = data_len; + if (data_len) { + msgb_put(iuh_prim->hdr.msg, data_len); + memcpy(iuh_prim->u.unitdata_ind.data, data, data_len); + } + + return iuh_prim; +} + +static int llsk_rx_iuh_conn_establish_req(struct hnb *hnb, struct hnb_iuh_conn_establish_req_param *ce_req) +{ + struct hnb_ue *ue; + int rc = 0; + + LOGP(DLLSK, LOGL_INFO, "Rx IUH-CONN_ESTABLISH.req ctx=%u is_ps=%u est_cause=%u data_len=%u\n", + ce_req->context_id, ce_req->domain, ce_req->est_cause, ce_req->data_len); + + if (!hnb->registered) { + LOGP(DLLSK, LOGL_NOTICE, "Ignoring Rx IUH-CONN_ESTABLISH.req: HNB not registered to HNBGW!\n"); + /* TODO: NACK it to lower layers */ + return -EINVAL; + } + + ue = hnb_find_ue_by_id(hnb, ce_req->context_id); + if (!ue) { + ue = hnb_ue_alloc(hnb, ce_req->context_id); + if (ce_req->domain) { + ue->conn_ps.active = true; + ue->conn_ps.conn_est_cnf_pending = true; /* Set to false once we receive first DT from HNBGW and send CONN_EST.cnf */ + + } else { + ue->conn_cs.active = true; + ue->conn_cs.conn_est_cnf_pending = true; /* Set to false once we receive first DT from HNBGW and send CONN_EST.cnf */ + } + } + if (ce_req->data_len) { + struct msgb *rua_msg; + struct msgb *ranap_msg = hnb_ranap_msgb_alloc(); + LOGP(DRUA, LOGL_DEBUG, "Tx RUA CONNECT ctx=%u is_ps=%u data_len=%u\n", + ce_req->context_id, ce_req->domain, ce_req->data_len); + memcpy(msgb_put(ranap_msg, ce_req->data_len), ce_req->data, ce_req->data_len); + rua_msg = rua_new_conn(ce_req->domain, ce_req->context_id, ranap_msg); + hnb_iuh_send(hnb, rua_msg); + } + + return rc; +} + +static int llsk_rx_iuh_conn_release_req(struct hnb *hnb, struct hnb_iuh_conn_release_req_param *rel_req) +{ + struct hnb_ue *ue; + struct msgb *rua_msg; + struct msgb *ranap_msg; + int rc = 0; + + LOGP(DLLSK, LOGL_DEBUG, "Rx IUH-CONN_RELEASE.req ctx=%u is_ps=%u data_len=%u\n", + rel_req->context_id, rel_req->domain, rel_req->data_len); + + if (!hnb->registered) { + LOGP(DLLSK, LOGL_NOTICE, "Rx IUH-CONN_RELEASE.req: Ignoring, HNB not registered to HNBGW!\n"); + return -EINVAL; + } + + ue = hnb_find_ue_by_id(hnb, rel_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx IUH-CONN_RELEASE.req: conn unknown! ctx=%u is_ps=%u data_len=%u\n", + rel_req->context_id, rel_req->domain, rel_req->data_len); + return -EINVAL; + } + hnb_ue_reset_chan(ue, !!rel_req->domain); + if (!ue->conn_cs.active && !ue->conn_ps.active) { + hnb_ue_free(ue); + ue = NULL; + } + + LOGP(DRUA, LOGL_DEBUG, "Tx RUA DISC ctx=%u is_ps=%u data_len=%u\n", + rel_req->context_id, rel_req->domain, rel_req->data_len); + ranap_msg = hnb_ranap_msgb_alloc(); + if (rel_req->data_len) + memcpy(msgb_put(ranap_msg, rel_req->data_len), rel_req->data, rel_req->data_len); + + rua_msg = rua_new_disc(rel_req->domain, rel_req->context_id, ranap_msg); + hnb_iuh_send(hnb, rua_msg); + return rc; +} + +static int llsk_rx_iuh_conn_data_req(struct hnb *hnb, struct hnb_iuh_conn_data_req_param *data_req) +{ + struct hnb_ue *ue; + struct msgb *rua_msg; + struct msgb *ranap_msg; + int rc = 0; + + LOGP(DLLSK, LOGL_DEBUG, "Rx IUH-CONN_DATA.req ctx=%u is_ps=%u data_len=%u\n", + data_req->context_id, data_req->domain, data_req->data_len); + + if (!hnb->registered) { + LOGP(DLLSK, LOGL_NOTICE, "Rx IUH-CONN_DATA.req: Ignoring, HNB not registered to HNBGW!\n"); + /* TODO: NACK it to lower layers */ + return -EINVAL; + } + + ue = hnb_find_ue_by_id(hnb, data_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx IUH-CONN_DATA.req: conn unknown! ctx=%u is_ps=%u data_len=%u\n", + data_req->context_id, data_req->domain, data_req->data_len); + /* TODO: NACK it to lower layers */ + return -EINVAL; + } + + LOGP(DRUA, LOGL_DEBUG, "Tx RUA DT ctx=%u is_ps=%u data_len=%u\n", + data_req->context_id, data_req->domain, data_req->data_len); + ranap_msg = hnb_ranap_msgb_alloc(); + if (data_req->data_len) + memcpy(msgb_put(ranap_msg, data_req->data_len), data_req->data, data_req->data_len); + + rua_msg = rua_new_dt(data_req->domain, data_req->context_id, ranap_msg); + hnb_iuh_send(hnb, rua_msg); + return rc; +} + +static int llsk_rx_iuh_unitdata_req(struct hnb *hnb, struct hnb_iuh_unitdata_req_param *ud_req) +{ + struct msgb *rua_msg; + struct msgb *ranap_msg; + int rc = 0; + + LOGP(DLLSK, LOGL_DEBUG, "Rx IUH-UNITDATA.req data_len=%u\n", ud_req->data_len); + + if (!hnb->registered) { + LOGP(DLLSK, LOGL_NOTICE, "Rx IUH-UNITDATA.req: Ignoring, HNB not registered to HNBGW!\n"); + return -EINVAL; + } + + LOGP(DRUA, LOGL_DEBUG, "Tx RUA UDT data_len=%u\n", ud_req->data_len); + + ranap_msg = hnb_ranap_msgb_alloc(); + if (ud_req->data_len) + memcpy(msgb_put(ranap_msg, ud_req->data_len), ud_req->data, ud_req->data_len); + + rua_msg = rua_new_udt(ranap_msg); + hnb_iuh_send(hnb, rua_msg); + return rc; +} + +int llsk_rx_iuh(struct hnb *hnb, struct osmo_prim_hdr *oph) +{ + size_t prim_size = llsk_iuh_prim_size(oph->primitive, oph->operation); + + if (msgb_length(oph->msg) < prim_size) { + LOGP(DLLSK, LOGL_ERROR, "Rx IUH-%s.%s with length %u < %zu\n", + get_value_string(hnb_iuh_prim_type_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation), + msgb_length(oph->msg), prim_size); + return -EINVAL; + } + + switch (oph->operation) { + case PRIM_OP_REQUEST: + switch (oph->primitive) { + case HNB_IUH_PRIM_CONN_ESTABLISH: + return llsk_rx_iuh_conn_establish_req(hnb, (struct hnb_iuh_conn_establish_req_param *)msgb_data(oph->msg)); + case HNB_IUH_PRIM_CONN_RELEASE: + return llsk_rx_iuh_conn_release_req(hnb, (struct hnb_iuh_conn_release_req_param *)msgb_data(oph->msg)); + case HNB_IUH_PRIM_CONN_DATA: + return llsk_rx_iuh_conn_data_req(hnb, (struct hnb_iuh_conn_data_req_param *)msgb_data(oph->msg)); + case HNB_IUH_PRIM_UNITDATA: + return llsk_rx_iuh_unitdata_req(hnb, (struct hnb_iuh_unitdata_req_param *)msgb_data(oph->msg)); + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-iuh unknown primitive %u (len=%u)\n", + oph->primitive, msgb_length(oph->msg)); + return -EINVAL; + } + break; + + case PRIM_OP_RESPONSE: + case PRIM_OP_INDICATION: + case PRIM_OP_CONFIRM: + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-iuh unexpected primitive operation %s::%s (len=%u)\n", + get_value_string(hnb_iuh_prim_type_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation), + msgb_length(oph->msg)); + return -EINVAL; + } +} diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 12d98ff..6728a07 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -265,6 +265,13 @@ exit(1); } + /* Start listening on lower layer unix domain socket: */ + rc = osmo_prim_srv_link_open(g_hnb->llsk_link); + if (rc < 0) { + perror("Error opening lower layer socket"); + exit(1); + } + rc = hnb_iuh_connect(g_hnb); if (rc < 0) { perror("Error connecting to Iuh port"); diff --git a/src/osmo-hnodeb/ranap.c b/src/osmo-hnodeb/ranap.c index 99c4bab..3313f7b 100644 --- a/src/osmo-hnodeb/ranap.c +++ b/src/osmo-hnodeb/ranap.c @@ -27,3 +27,8 @@ #include #include + +struct msgb *hnb_ranap_msgb_alloc(void) +{ + return msgb_alloc(1000, "ranap_tx"); +} diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c index 9bf5403..3a73f0c 100644 --- a/src/osmo-hnodeb/rua.c +++ b/src/osmo-hnodeb/rua.c @@ -32,10 +32,23 @@ #include #include + +struct msgb *hnb_rua_msgb_alloc(void) +{ + return msgb_alloc(1000, "rua_tx"); +} + static void hnb_rua_dt_handle(struct hnb *hnb, ANY_t *in) { RUA_DirectTransferIEs_t ies; int rc; + struct hnb_ue *ue; + struct hnb_iuh_prim *iuh_prim; + uint32_t context_id; + bool is_ps; + uint8_t *ranap_buf; + size_t ranap_buf_len; + bool *conn_est_cnf_pending; rc = rua_decode_directtransferies(&ies, in); if (rc < 0) { @@ -43,7 +56,44 @@ return; } + context_id = asn1bitstr_to_u24(&ies.context_ID); + is_ps = (ies.cN_DomainIndicator == RUA_CN_DomainIndicator_ps_domain); + ranap_buf = ies.ranaP_Message.buf; + ranap_buf_len = ies.ranaP_Message.size; + LOGP(DRUA, LOGL_DEBUG, "Rx RUA DT context_id=%u is_ps=%u ranap_len=%zu\n", + context_id, is_ps, ranap_buf_len); + + if (!(ue = hnb_find_ue_by_id(hnb, context_id))) { + LOGP(DRUA, LOGL_ERROR, "Rx RUA DT: Failed finding ue context_id=%u is_ps=%u\n", + context_id, is_ps); + goto free_ret; + } + + conn_est_cnf_pending = is_ps ? &ue->conn_ps.conn_est_cnf_pending : + &ue->conn_cs.conn_est_cnf_pending; + if (*conn_est_cnf_pending) { + *conn_est_cnf_pending = false; + LOGP(DLLSK, LOGL_INFO, "Tx IUH-CONN_ESTABLISH.cnf context_id=%u is_ps=%u\n", + context_id, is_ps); + iuh_prim = hnb_iuh_makeprim_conn_establish_cnf(context_id, is_ps, 0); + if ((rc = osmo_prim_srv_send(hnb->llsk, iuh_prim->hdr.msg)) < 0) { + LOGP(DRUA, LOGL_ERROR, "Failed sending IUH-CONN_ESTABLISH.cnf context_id=%u is_ps=%u\n", + context_id, is_ps); + goto free_ret; + } + } + + LOGP(DLLSK, LOGL_DEBUG, "Tx IUH-CONN_DATA.ind context_id=%u is_ps=%u ranap_len=%zu\n", + context_id, is_ps, ranap_buf_len); + iuh_prim = hnb_iuh_makeprim_conn_data_ind(context_id, is_ps, ranap_buf, ranap_buf_len); + if ((rc = osmo_prim_srv_send(hnb->llsk, iuh_prim->hdr.msg)) < 0) { + LOGP(DRUA, LOGL_ERROR, "Failed sending IUH-CONN_DATA.ind context_id=%u is_ps=%u ranap_len=%zu\n", + context_id, is_ps, ranap_buf_len); + goto free_ret; + } + +free_ret: /* FIXME: what to do with the asn1c-allocated memory */ rua_free_directtransferies(&ies); } @@ -52,18 +102,81 @@ { RUA_ConnectionlessTransferIEs_t ies; int rc; + struct hnb_iuh_prim *iuh_prim; + uint8_t *ranap_buf; + size_t ranap_buf_len; rc = rua_decode_connectionlesstransferies(&ies, in); if (rc < 0) { LOGP(DRUA, LOGL_INFO, "failed to decode RUA CL IEs\n"); return; } + ranap_buf = ies.ranaP_Message.buf; + ranap_buf_len = ies.ranaP_Message.size; + LOGP(DRUA, LOGL_DEBUG, "Rx RUA UDT ranap_len=%zu\n", ranap_buf_len); + LOGP(DLLSK, LOGL_DEBUG, "Tx IUH-UNITDATA.ind ranap_len=%zu\n", ranap_buf_len); + iuh_prim = hnb_iuh_makeprim_unitdata_ind(ranap_buf, ranap_buf_len); + if ((rc = osmo_prim_srv_send(hnb->llsk, iuh_prim->hdr.msg)) < 0) { + LOGP(DRUA, LOGL_ERROR, "Failed sending IUH-CONN_DATA.ind ranap_len=%zu\n", + ranap_buf_len); + goto free_ret; + } + +free_ret: /* FIXME: what to do with the asn1c-allocated memory */ rua_free_connectionlesstransferies(&ies); } + +static int hnb_rua_rx_initiating(struct hnb *hnb, RUA_InitiatingMessage_t *init) +{ + switch (init->procedureCode) { + case RUA_ProcedureCode_id_ConnectionlessTransfer: + LOGP(DRUA, LOGL_INFO, "RUA rx Initiating ConnectionlessTransfer\n"); + hnb_rua_cl_handle(hnb, &init->value); + break; + case RUA_ProcedureCode_id_DirectTransfer: + LOGP(DRUA, LOGL_INFO, "RUA rx Initiating DirectTransfer\n"); + hnb_rua_dt_handle(hnb, &init->value); + default: + LOGP(DRUA, LOGL_INFO, "RUA rx unknown Initiating message\n"); + break; + } + return 0; +} + +static int hnb_rua_rx_successful(struct hnb *hnb, RUA_SuccessfulOutcome_t *success) +{ + switch (success->procedureCode) { + case RUA_ProcedureCode_id_ConnectionlessTransfer: + LOGP(DRUA, LOGL_INFO, "RUA rx SuccessfulOutcome ConnectionlessTransfer\n"); + hnb_rua_cl_handle(hnb, &success->value); + break; + case RUA_ProcedureCode_id_Connect: + LOGP(DRUA, LOGL_INFO, "RUA rx SuccessfulOutcome Connect\n"); + break; + case RUA_ProcedureCode_id_DirectTransfer: + LOGP(DRUA, LOGL_INFO, "RUA rx SuccessfulOutcome DirectTransfer\n"); + hnb_rua_dt_handle(hnb, &success->value); + break; + case RUA_ProcedureCode_id_Disconnect: + LOGP(DRUA, LOGL_INFO, "RUA rx SuccessfulOutcome Disconnect\n"); + break; + case RUA_ProcedureCode_id_ErrorIndication: + LOGP(DRUA, LOGL_INFO, "RUA rx SuccessfulOutcome ErrorIndication\n"); + break; + case RUA_ProcedureCode_id_privateMessage: + LOGP(DRUA, LOGL_INFO, "RUA rx SuccessfulOutcome privateMessage\n"); + break; + default: + LOGP(DRUA, LOGL_INFO, "RUA rx unknown SuccessfulOutcome message\n"); + break; + } + return 0; +} + int hnb_rua_rx(struct hnb *hnb, struct msgb *msg) { RUA_RUA_PDU_t _pdu, *pdu = &_pdu; @@ -79,11 +192,9 @@ switch (pdu->present) { case RUA_RUA_PDU_PR_successfulOutcome: - LOGP(DRUA, LOGL_INFO, "RUA_RUA_PDU_PR_successfulOutcome\n"); - break; + return hnb_rua_rx_successful(hnb, &pdu->choice.successfulOutcome); case RUA_RUA_PDU_PR_initiatingMessage: - LOGP(DRUA, LOGL_INFO, "RUA_RUA_PDU_PR_initiatingMessage\n"); - break; + return hnb_rua_rx_initiating(hnb, &pdu->choice.initiatingMessage); case RUA_RUA_PDU_PR_NOTHING: LOGP(DRUA, LOGL_INFO, "RUA_RUA_PDU_PR_NOTHING\n"); break; @@ -95,31 +206,5 @@ break; } - switch (pdu->choice.successfulOutcome.procedureCode) { - case RUA_ProcedureCode_id_ConnectionlessTransfer: - LOGP(DRUA, LOGL_INFO, "RUA rx Connectionless Transfer\n"); - hnb_rua_cl_handle(hnb, &pdu->choice.successfulOutcome.value); - break; - case RUA_ProcedureCode_id_Connect: - LOGP(DRUA, LOGL_INFO, "RUA rx Connect\n"); - break; - case RUA_ProcedureCode_id_DirectTransfer: - LOGP(DRUA, LOGL_INFO, "RUA rx DirectTransfer\n"); - hnb_rua_dt_handle(hnb, &pdu->choice.successfulOutcome.value); - break; - case RUA_ProcedureCode_id_Disconnect: - LOGP(DRUA, LOGL_INFO, "RUA rx Disconnect\n"); - break; - case RUA_ProcedureCode_id_ErrorIndication: - LOGP(DRUA, LOGL_INFO, "RUA rx ErrorIndication\n"); - break; - case RUA_ProcedureCode_id_privateMessage: - LOGP(DRUA, LOGL_INFO, "RUA rx privateMessage\n"); - break; - default: - LOGP(DRUA, LOGL_INFO, "RUA rx unknown message\n"); - break; - } - return 0; } diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index 93ec25f..131dc6b 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -47,6 +47,10 @@ vty->node = HNODEB_NODE; vty->index = g_hnb; break; + case LLSK_NODE: + vty->node = HNODEB_NODE; + vty->index = g_hnb; + break; case HNODEB_NODE: vty->node = CONFIG_NODE; vty->index = g_hnb; @@ -247,6 +251,36 @@ return CMD_SUCCESS; } +static struct cmd_node llsk_node = { + LLSK_NODE, + "%s(config-ll-socket)# ", + 1, +}; + +#define LLSK_STR "Configure the Lower Layer Unix Domain Socket\n" + +DEFUN(cfg_hnodeb_llsk, + cfg_hnodeb_llsk_cmd, + "ll-socket", LLSK_STR) +{ + OSMO_ASSERT(g_hnb); + vty->index = g_hnb; + vty->node = LLSK_NODE; + + return CMD_SUCCESS; +} + +DEFUN(cfg_hnodeb_llsk_path, cfg_hnodeb_llsk_path_cmd, + "path PATH", + "Configure the Lower Layer Unix Domain Socket path\n" + "UNIX socket path\n") +{ + osmo_prim_srv_link_set_addr(g_hnb->llsk_link, argv[0]); + + /* FIXME: re-open the interface? */ + return CMD_SUCCESS; +} + static int config_write_hnodeb(struct vty *vty) { @@ -266,10 +300,11 @@ vty_out(vty, " local-port %u%s", g_hnb->iuh.local_port, VTY_NEWLINE); vty_out(vty, " remote-ip %s%s", g_hnb->iuh.remote_addr, VTY_NEWLINE); vty_out(vty, " remote-port %u%s", g_hnb->iuh.remote_port, VTY_NEWLINE); + vty_out(vty, " ll-socket%s", VTY_NEWLINE); + vty_out(vty, " path %s%s", osmo_prim_srv_link_get_addr(g_hnb->llsk_link), VTY_NEWLINE); return CMD_SUCCESS; } - #define RANAP_STR "RANAP related commands\n" #define CSPS_STR "Circuit Switched\n" "Packet Switched\n" @@ -321,6 +356,9 @@ install_element(IUH_NODE, &cfg_hnodeb_iuh_local_port_cmd); install_element(IUH_NODE, &cfg_hnodeb_iuh_remote_ip_cmd); install_element(IUH_NODE, &cfg_hnodeb_iuh_remote_port_cmd); + install_element(HNODEB_NODE, &cfg_hnodeb_llsk_cmd); + install_node(&llsk_node, NULL); + install_element(LLSK_NODE, &cfg_hnodeb_llsk_path_cmd); install_element_ve(&asn_dbg_cmd); install_element_ve(&ranap_reset_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Icaabb2206d6f141d4fba47dedf71f8ec37e6257d Gerrit-Change-Number: 26357 Gerrit-PatchSet: 13 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:39:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 14:39:17 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK audio SAPI In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 ) Change subject: First implementation of the LLSK audio SAPI ...................................................................... First implementation of the LLSK audio SAPI This first version can send and receive regular RTP, but does not talk IuUP. Support for IuUP will be added in a future patch. This way we can already test the whole LLSK<->RTP path. Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d --- M configure.ac M include/osmocom/hnodeb/Makefile.am M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h A include/osmocom/hnodeb/rtp.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_audio.c M src/osmo-hnodeb/main.c A src/osmo-hnodeb/rtp.c 13 files changed, 732 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 8453bc4..e96a6a1 100644 --- a/configure.ac +++ b/configure.ac @@ -61,6 +61,7 @@ PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) +PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 1.2.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 0.8.0) diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index 62af5bb..dcb3868 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -6,6 +6,7 @@ iuh.h \ llsk.h \ ranap.h \ + rtp.h \ rua.h \ vty.h \ $(NULL) diff --git a/include/osmocom/hnodeb/hnb_prim.h b/include/osmocom/hnodeb/hnb_prim.h index 6d597c4..dab00c9 100644 --- a/include/osmocom/hnodeb/hnb_prim.h +++ b/include/osmocom/hnodeb/hnb_prim.h @@ -40,6 +40,16 @@ #define HNB_PRIM_SAPI_GTP 2 #define HNB_PRIM_SAPI_AUDIO 3 +enum u_addr_type { + HNB_PRIM_ADDR_TYPE_UNSPEC, + HNB_PRIM_ADDR_TYPE_IPV4, + HNB_PRIM_ADDR_TYPE_IPV6 +}; +union u_addr { + struct in_addr v4; + struct in6_addr v6; +} __attribute__ ((packed)); + /*! \brief HNB_IUH primitives */ enum hnb_iuh_prim_type { HNB_IUH_PRIM_CONFIGURE, @@ -163,3 +173,62 @@ struct hnb_iuh_unitdata_ind_param unitdata_ind; } u; } __attribute__ ((packed)); + +/**************************** + * AUDIO + ***************************/ +/*! \brief HNB_AUDIO primitives */ +enum hnb_audio_prim_type { + HNB_AUDIO_PRIM_CONN_ESTABLISH, + HNB_AUDIO_PRIM_CONN_RELEASE, + HNB_AUDIO_PRIM_CONN_DATA, + _HNB_AUDIO_PRIM_MAX +}; + +/* HNB_AUDIO_PRIM_CONN_ESTABLISH, UL */ +struct hnb_audio_conn_establish_req_param { + uint32_t context_id; + uint16_t remote_rtp_port; + uint8_t spare1; + uint8_t remote_rtp_address_type; /* enum u_addr_type */ + union u_addr remote_rtp_addr; +} __attribute__ ((packed)); + +/* HNB_AUDIO_PRIM_CONN_ESTABLISH, DL */ +struct hnb_audio_conn_establish_cnf_param { + uint32_t context_id; + uint16_t local_rtp_port; + uint8_t error_code; /* 0 = success, !0 = failure */ + uint8_t local_rtp_address_type; /* enum u_addr_type */ + union u_addr local_rtp_addr; +} __attribute__ ((packed)); + +/* HNB_AUDIO_PRIM_CONN_RELEASE, UL */ +struct hnb_audio_conn_release_req_param { + uint32_t context_id; +} __attribute__ ((packed)); + +/* HNB_AUDIO_PRIM_CONN_DATA, UL */ +struct hnb_audio_conn_data_req_param { + uint32_t context_id; + uint32_t data_len; /* RTP payload length in bytes */ + uint8_t data[0]; /* RTP payload (aka IP packet) */ +} __attribute__ ((packed)); + +/* HNB_AUDIO_PRIM_CONN_DATA, DL */ +struct hnb_audio_conn_data_ind_param { + uint32_t context_id; + uint32_t data_len; /* RTP payload length in bytes */ + uint8_t data[0]; /* RTP payload (aka IP packet) */ +} __attribute__ ((packed)); + +struct hnb_audio_prim { + struct osmo_prim_hdr hdr; + union { + struct hnb_audio_conn_establish_req_param conn_establish_req; + struct hnb_audio_conn_establish_cnf_param conn_establish_cnf; + struct hnb_audio_conn_release_req_param conn_release_req; + struct hnb_audio_conn_data_req_param conn_data_req; + struct hnb_audio_conn_data_ind_param conn_data_ind; + } u; +} __attribute__ ((packed)); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index fd7d1e9..15244c4 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -21,11 +21,13 @@ #include #include +#include #include #include #include +#include #include #include #include @@ -42,6 +44,7 @@ DRANAP, DSCTP, DLLSK, + DRTP, }; extern const struct log_info hnb_log_info; @@ -55,6 +58,9 @@ struct hnb_ue_cs_ctx { bool active; /* Is this chan in use? */ bool conn_est_cnf_pending; /* Did we send CONN_ESTABLISH_CNF to lower layers? */ + struct { + struct osmo_rtp_socket *socket; + } rtp; } conn_cs; struct hnb_ue_ps_ctx { bool active; /* Is this chan in use? */ @@ -86,6 +92,17 @@ uint8_t llsk_valid_sapi_mask; struct osmo_timer_list llsk_defer_configure_ind_timer; + struct { + unsigned int jitter_buf_ms; + bool jitter_adaptive; + + uint16_t port_range_start; + uint16_t port_range_end; + uint16_t port_range_next; + int ip_dscp; + int priority; + } rtp; + uint16_t rnc_id; bool registered; /* Set to true once HnbRegisterAccept was received from Iuh. rnc_id is valid iif registered==true */ @@ -104,3 +121,5 @@ extern void *tall_hnb_ctx; extern struct hnb *g_hnb; + +#define LOGUE(ue, ss, lvl, fmt, args...) LOGP(ss, lvl, "UE(%" PRIu32 ") " fmt, (ue)->conn_id, ## args) diff --git a/include/osmocom/hnodeb/llsk.h b/include/osmocom/hnodeb/llsk.h index ab39439..0636a5f 100644 --- a/include/osmocom/hnodeb/llsk.h +++ b/include/osmocom/hnodeb/llsk.h @@ -22,15 +22,22 @@ #include #include +#include #include #include struct hnb; +struct hnb_ue; int hnb_llsk_alloc(struct hnb *hnb); bool hnb_llsk_connected(const struct hnb *hnb); bool hnb_llsk_can_be_configured(struct hnb *hnb); +int ll_addr_type2af(enum u_addr_type t); +int ll_addr2osa(enum u_addr_type t, const union u_addr *uaddr, uint16_t port, struct osmo_sockaddr *osa); +enum u_addr_type osa2_ll_addr(const struct osmo_sockaddr *osa, union u_addr *uaddr, uint16_t *port); + + extern const struct value_string hnb_iuh_prim_type_names[]; int llsk_rx_iuh(struct hnb *hnb, struct osmo_prim_hdr *oph); @@ -42,3 +49,8 @@ const uint8_t *data, uint32_t data_len); struct hnb_iuh_prim *hnb_iuh_makeprim_unitdata_ind(const uint8_t *data, uint32_t data_len); + + +extern const struct value_string hnb_audio_prim_type_names[]; +int llsk_rx_audio(struct hnb *hnb, struct osmo_prim_hdr *oph); +int llsk_audio_tx_conn_data_ind(struct hnb_ue *ue, const uint8_t *payload, uint32_t len); diff --git a/include/osmocom/hnodeb/rtp.h b/include/osmocom/hnodeb/rtp.h new file mode 100644 index 0000000..01ec1c4 --- /dev/null +++ b/include/osmocom/hnodeb/rtp.h @@ -0,0 +1,27 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include + +struct hnb; +struct hnb_ue; + +int hnb_ue_voicecall_setup(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, struct osmo_sockaddr *loc_addr); +int hnb_ue_voicecall_release(struct hnb_ue *ue); diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index b6d2d49..4182814 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -14,6 +14,7 @@ $(LIBOSMONETIF_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(LIBOSMOABIS_CFLAGS) \ + $(LIBOSMOTRAU_CFLAGS) \ $(LIBOSMOSIGTRAN_CFLAGS) \ $(LIBOSMORUA_CFLAGS) \ $(LIBOSMORANAP_CFLAGS) \ @@ -36,8 +37,10 @@ hnb_shutdown_fsm.c \ iuh.c \ llsk.c \ + llsk_audio.c \ llsk_iuh.c \ ranap.c \ + rtp.c \ rua.c \ vty.c \ $(NULL) @@ -51,6 +54,7 @@ $(LIBOSMONETIF_LIBS) \ $(COVERAGE_LDFLAGS) \ $(LIBOSMOABIS_LIBS) \ + $(LIBOSMOTRAU_LIBS) \ $(LIBOSMOSIGTRAN_LIBS) \ $(LIBOSMORUA_LIBS) \ $(LIBOSMORANAP_LIBS) \ diff --git a/src/osmo-hnodeb/debug.c b/src/osmo-hnodeb/debug.c index f34851b..5d0dabd 100644 --- a/src/osmo-hnodeb/debug.c +++ b/src/osmo-hnodeb/debug.c @@ -52,6 +52,11 @@ .color = "\033[1;31m", .description = "Lower Layer Unix Domain Socket", }, + [DRTP] = { + .name = "DRTP", .loglevel = LOGL_NOTICE, .enabled = 1, + .color = "\033[1;32m", + .description = "RTP Core Network side", + }, }; const struct log_info hnb_log_info = { diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 1ac2efc..4c949f5 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -20,15 +20,20 @@ #include "config.h" +#include + #include #include #include #include +#include + #include #include #include #include +#include struct hnb *hnb_alloc(void *tall_ctx) @@ -46,6 +51,14 @@ .mcc = 1, .mnc = 1, }; + + hnb->rtp.jitter_adaptive = false; + hnb->rtp.port_range_start = 16384; + hnb->rtp.port_range_end = 17407; + hnb->rtp.port_range_next = hnb->rtp.port_range_start; + hnb->rtp.ip_dscp = -1; + hnb->rtp.priority = -1; + hnb->shutdown_fi = osmo_fsm_inst_alloc(&hnb_shutdown_fsm, hnb, hnb, LOGL_INFO, NULL); @@ -94,16 +107,20 @@ void hnb_ue_free(struct hnb_ue *ue) { + hnb_ue_reset_chan(ue, true); + hnb_ue_reset_chan(ue, false); llist_del(&ue->list); talloc_free(ue); } void hnb_ue_reset_chan(struct hnb_ue *ue, bool is_ps) { - if (is_ps) + if (is_ps) { ue->conn_ps = (struct hnb_ue_ps_ctx){0}; - else + } else { + hnb_ue_voicecall_release(ue); ue->conn_cs = (struct hnb_ue_cs_ctx){0}; + } } struct hnb_ue *hnb_find_ue_by_id(const struct hnb *hnb, uint32_t conn_id) diff --git a/src/osmo-hnodeb/llsk.c b/src/osmo-hnodeb/llsk.c index 5f0f9dc..8c93318 100644 --- a/src/osmo-hnodeb/llsk.c +++ b/src/osmo-hnodeb/llsk.c @@ -18,6 +18,9 @@ */ #include +#include +#include +#include #include #include @@ -27,6 +30,58 @@ #include #include +int ll_addr_type2af(enum u_addr_type t) +{ + switch (t) { + case HNB_PRIM_ADDR_TYPE_IPV4: + return AF_INET; + case HNB_PRIM_ADDR_TYPE_IPV6: + return AF_INET6; + default: + LOGP(DLLSK, LOGL_ERROR, "Rx Unknwon address type %u\n", (unsigned)t); + return -1; + } +} + +int ll_addr2osa(enum u_addr_type t, const union u_addr *uaddr, uint16_t port, struct osmo_sockaddr *osa) +{ + int af = ll_addr_type2af(t); + + osa->u.sa.sa_family = af; + + switch (af) { + case AF_INET6: + memcpy(&osa->u.sin6.sin6_addr, &uaddr->v6, sizeof(osa->u.sin6.sin6_addr)); + osa->u.sin6.sin6_port = htons(port); + break; + case AF_INET: + memcpy(&osa->u.sin.sin_addr, &uaddr->v4, sizeof(osa->u.sin.sin_addr)); + osa->u.sin.sin_port = htons(port); + break; + default: + return -1; + } + return 0; +} + +enum u_addr_type osa2_ll_addr(const struct osmo_sockaddr *osa, union u_addr *uaddr, uint16_t *port) +{ + switch (osa->u.sa.sa_family) { + case AF_INET6: + memcpy(&uaddr->v6, &osa->u.sin6.sin6_addr, sizeof(osa->u.sin6.sin6_addr)); + if (port) + *port = ntohs(osa->u.sin6.sin6_port); + return HNB_PRIM_ADDR_TYPE_IPV6; + case AF_INET: + memcpy(&uaddr->v4, &osa->u.sin.sin_addr, sizeof(osa->u.sin.sin_addr)); + if (port) + *port = ntohs(osa->u.sin.sin_port); + return HNB_PRIM_ADDR_TYPE_IPV4; + default: + return HNB_PRIM_ADDR_TYPE_UNSPEC; + } +} + static int llsk_opened_cb(struct osmo_prim_srv *srv) { struct hnb *hnb = (struct hnb *)osmo_prim_srv_get_priv(srv); @@ -73,7 +128,8 @@ if (!hnb->llsk) return false; - if (hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_IUH)) + if (hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_IUH) && + hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_AUDIO)) return true; return false; } @@ -108,10 +164,11 @@ case HNB_PRIM_SAPI_IUH: return llsk_rx_iuh(hnb, oph); case HNB_PRIM_SAPI_GTP: - case HNB_PRIM_SAPI_AUDIO: LOGP(DLLSK, LOGL_ERROR, "Rx SAPI %u not yet implemented (len=%u)\n", oph->sap, msgb_length(oph->msg)); return -EINVAL; + case HNB_PRIM_SAPI_AUDIO: + return llsk_rx_audio(hnb, oph); default: LOGP(DLLSK, LOGL_ERROR, "Rx for unknwon SAPI %u (len=%u)\n", oph->sap, msgb_length(oph->msg)); diff --git a/src/osmo-hnodeb/llsk_audio.c b/src/osmo-hnodeb/llsk_audio.c new file mode 100644 index 0000000..4fa8079 --- /dev/null +++ b/src/osmo-hnodeb/llsk_audio.c @@ -0,0 +1,296 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +#include + +#include +#include +#include +#include + +static size_t llsk_audio_prim_size_tbl[4][_HNB_AUDIO_PRIM_MAX] = { + [PRIM_OP_REQUEST] = { + [HNB_AUDIO_PRIM_CONN_ESTABLISH] = sizeof(struct hnb_audio_conn_establish_req_param), + [HNB_AUDIO_PRIM_CONN_RELEASE] = sizeof(struct hnb_audio_conn_release_req_param), + [HNB_AUDIO_PRIM_CONN_DATA] = sizeof(struct hnb_audio_conn_data_req_param), + }, + [PRIM_OP_RESPONSE] = {}, + [PRIM_OP_INDICATION] = { + [HNB_AUDIO_PRIM_CONN_DATA] = sizeof(struct hnb_audio_conn_data_ind_param), + }, + [PRIM_OP_CONFIRM] = { + [HNB_AUDIO_PRIM_CONN_ESTABLISH] = sizeof(struct hnb_audio_conn_establish_cnf_param), + }, +}; +static inline size_t llsk_audio_prim_size(enum hnb_audio_prim_type ptype, enum osmo_prim_operation op) +{ + size_t val = llsk_audio_prim_size_tbl[op][ptype]; + if (val == 0) { + LOGP(DLLSK, LOGL_FATAL, "Expected prim_size != 0 for ptype=%u op=%u\n", ptype, op); + osmo_panic("Expected prim_size != 0 for ptype=%u op=%u\n", ptype, op); + } + return val; +} + +const struct value_string hnb_audio_prim_type_names[] = { + OSMO_VALUE_STRING(HNB_AUDIO_PRIM_CONN_ESTABLISH), + OSMO_VALUE_STRING(HNB_AUDIO_PRIM_CONN_RELEASE), + OSMO_VALUE_STRING(HNB_AUDIO_PRIM_CONN_DATA), + { 0, NULL } +}; + +static struct hnb_audio_prim *hnb_audio_prim_alloc(enum hnb_audio_prim_type ptype, enum osmo_prim_operation op, size_t extra_len) +{ + struct osmo_prim_hdr *oph; + size_t len = llsk_audio_prim_size(ptype, op); + + oph = osmo_prim_msgb_alloc(HNB_PRIM_SAPI_AUDIO, ptype, op, sizeof(*oph) + len + extra_len); + if (!oph) + return NULL; + msgb_put(oph->msg, len); + + return (struct hnb_audio_prim *)oph; +} + +static struct hnb_audio_prim *hnb_audio_makeprim_conn_establish_cnf(uint32_t context_id, uint8_t error_code, + uint16_t local_rtp_port, uint8_t local_rtp_address_type, + const union u_addr *local_rtp_addr) +{ + struct hnb_audio_prim *audio_prim; + + audio_prim = hnb_audio_prim_alloc(HNB_AUDIO_PRIM_CONN_ESTABLISH, PRIM_OP_CONFIRM, 0); + audio_prim->u.conn_establish_cnf.context_id = context_id; + audio_prim->u.conn_establish_cnf.local_rtp_port = local_rtp_port; + audio_prim->u.conn_establish_cnf.error_code = error_code; + audio_prim->u.conn_establish_cnf.local_rtp_address_type = local_rtp_address_type; + if (local_rtp_addr) + audio_prim->u.conn_establish_cnf.local_rtp_addr = *local_rtp_addr; + + return audio_prim; +} + +static struct hnb_audio_prim *hnb_audio_makeprim_conn_data_ind(uint32_t context_id, + uint8_t domain, + const uint8_t *data, + uint32_t data_len) +{ + struct hnb_audio_prim *audio_prim; + + audio_prim = hnb_audio_prim_alloc(HNB_AUDIO_PRIM_CONN_DATA, PRIM_OP_INDICATION, data_len); + audio_prim->u.conn_data_ind.context_id = context_id; + audio_prim->u.conn_data_ind.data_len = data_len; + if (data_len) { + msgb_put(audio_prim->hdr.msg, data_len); + memcpy(audio_prim->u.conn_data_ind.data, data, data_len); + } + + return audio_prim; +} + +int llsk_audio_tx_conn_data_ind(struct hnb_ue *ue, const uint8_t *payload, uint32_t len) +{ + struct hnb_audio_prim *audio_prim; + int rc; + + LOGUE(ue, DLLSK, LOGL_INFO, "Tx AUDIO-CONN_DATA.ind\n"); + audio_prim = hnb_audio_makeprim_conn_data_ind(ue->conn_id, 0 /* CS */, payload, len); + if ((rc = osmo_prim_srv_send(ue->hnb->llsk, audio_prim->hdr.msg)) < 0) + LOGUE(ue, DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_DATA.ind\n"); + return rc; +} + +static int _send_conn_establish_cnf_failed(struct hnb *hnb, uint32_t context_id, uint8_t error_code) +{ + struct hnb_audio_prim *audio_prim; + int rc; + LOGP(DLLSK, LOGL_ERROR, "Tx AUDIO-CONN_ESTABLISH.cnf: ctx=%u error_code=%u\n", + context_id, error_code); + audio_prim = hnb_audio_makeprim_conn_establish_cnf(context_id, error_code, 0, HNB_PRIM_ADDR_TYPE_UNSPEC, NULL); + if ((rc = osmo_prim_srv_send(hnb->llsk, audio_prim->hdr.msg)) < 0) { + LOGP(DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_ESTABLISH.cnf context_id=%u error_code=%u\n", + context_id, error_code); + } + return rc; +} + +static int llsk_rx_audio_conn_establish_req(struct hnb *hnb, struct hnb_audio_conn_establish_req_param *ce_req) +{ + struct hnb_ue *ue; + int rc = 0; + struct hnb_audio_prim *audio_prim; + int af; + char rem_addrstr[INET6_ADDRSTRLEN+32]; + struct osmo_sockaddr rem_osa = {0}; + struct osmo_sockaddr loc_osa = {0}; + union u_addr loc_uaddr = {0}; + uint16_t loc_port; + + rc = ll_addr2osa(ce_req->remote_rtp_address_type, &ce_req->remote_rtp_addr, ce_req->remote_rtp_port, &rem_osa); + if (rc < 0) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: ctx=%u with unexpected address type %u\n", + ce_req->context_id, ce_req->remote_rtp_address_type); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 1); + } + osmo_sockaddr_to_str_buf(rem_addrstr, sizeof(rem_addrstr), &rem_osa); + + LOGP(DLLSK, LOGL_INFO, "Rx AUDIO-CONN_ESTABLISH.req ctx=%u rem_addr=%s\n", + ce_req->context_id, rem_addrstr); + + if ((af = ll_addr_type2af(ce_req->remote_rtp_address_type)) < 0) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: ctx=%u with unexpected address type %u\n", + ce_req->context_id, ce_req->remote_rtp_address_type); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 1); + } + + ue = hnb_find_ue_by_id(hnb, ce_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: UE not found! ctx=%u rem_addr=%s\n", + ce_req->context_id, rem_addrstr); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 2); + } + if (!ue->conn_cs.active) { + LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: CS chan not active! rem_addr=%s\n", + rem_addrstr); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 3); + } + + /* Create the socket: */ + if ((rc = hnb_ue_voicecall_setup(ue, &rem_osa, &loc_osa)) < 0) { + LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: Failed to set up audio socket rem_addr=%s\n", + rem_addrstr); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); + } + + /* Convert resulting local address back to LLSK format: */ + if (osa2_ll_addr(&loc_osa, &loc_uaddr, &loc_port) != ce_req->remote_rtp_address_type) { + LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: Failed to provide proper local address rem_addr=%s\n", + rem_addrstr); + rc = _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); + goto release_sock; + } + + /* Submit successful confirmation */ + LOGUE(ue, DLLSK, LOGL_INFO, "Tx AUDIO-CONN_ESTABLISH.cnf: error_code=0 rem_addr=%s loc_addr=%s\n", + rem_addrstr, osmo_sockaddr_to_str(&loc_osa)); + audio_prim = hnb_audio_makeprim_conn_establish_cnf(ce_req->context_id, 0, loc_port, + ce_req->remote_rtp_address_type, &loc_uaddr); + if ((rc = osmo_prim_srv_send(hnb->llsk, audio_prim->hdr.msg)) < 0) { + LOGUE(ue, DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_ESTABLISH.cnf error_code=0\n"); + goto release_sock; + } + + return rc; +release_sock: + hnb_ue_voicecall_release(ue); + return rc; +} + +static int llsk_rx_audio_conn_release_req(struct hnb *hnb, struct hnb_audio_conn_release_req_param *rel_req) +{ + struct hnb_ue *ue; + + LOGP(DLLSK, LOGL_DEBUG, "Rx AUDIO-CONN_RELEASE.req ctx=%u\n", rel_req->context_id); + + ue = hnb_find_ue_by_id(hnb, rel_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_RELEASE.req: UE not found! ctx=%u\n", + rel_req->context_id); + return -EINVAL; + } + /* Release RTP socket: */ + return hnb_ue_voicecall_release(ue); +} + +static int llsk_rx_audio_conn_data_req(struct hnb *hnb, struct hnb_audio_conn_data_req_param *data_req) +{ + struct hnb_ue *ue; + int rc = 0; + + LOGP(DLLSK, LOGL_DEBUG, "Rx AUDIO-CONN_DATA.req ctx=%u data_len=%u\n", + data_req->context_id, data_req->data_len); + + ue = hnb_find_ue_by_id(hnb, data_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_DATA.req: UE not found! ctx=%u data_len=%u\n", + data_req->context_id, data_req->data_len); + return -EINVAL; + } + + /* TODO: transmit data_req->data through RTP/Iu-UP socket */ + rc = osmo_rtp_send_frame_ext(ue->conn_cs.rtp.socket, data_req->data, + data_req->data_len, GSM_RTP_DURATION, false); + if (rc < 0) { + LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_DATA.req: UE not found! ctx=%u data_len=%u\n", + data_req->context_id, data_req->data_len); + } + return rc; +} + +int llsk_rx_audio(struct hnb *hnb, struct osmo_prim_hdr *oph) +{ + size_t prim_size = llsk_audio_prim_size(oph->primitive, oph->operation); + + if (msgb_length(oph->msg) < prim_size) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-%s.%s with length %u < %zu\n", + get_value_string(hnb_audio_prim_type_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation), + msgb_length(oph->msg), prim_size); + return -EINVAL; + } + + switch (oph->operation) { + case PRIM_OP_REQUEST: + switch (oph->primitive) { + case HNB_AUDIO_PRIM_CONN_ESTABLISH: + return llsk_rx_audio_conn_establish_req(hnb, (struct hnb_audio_conn_establish_req_param *)msgb_data(oph->msg)); + case HNB_AUDIO_PRIM_CONN_RELEASE: + return llsk_rx_audio_conn_release_req(hnb, (struct hnb_audio_conn_release_req_param *)msgb_data(oph->msg)); + case HNB_AUDIO_PRIM_CONN_DATA: + return llsk_rx_audio_conn_data_req(hnb, (struct hnb_audio_conn_data_req_param *)msgb_data(oph->msg)); + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-audio unknown primitive %u (len=%u)\n", + oph->primitive, msgb_length(oph->msg)); + return -EINVAL; + } + break; + + case PRIM_OP_RESPONSE: + case PRIM_OP_INDICATION: + case PRIM_OP_CONFIRM: + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-audio unexpected primitive operation %s::%s (len=%u)\n", + get_value_string(hnb_audio_prim_type_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation), + msgb_length(oph->msg)); + return -EINVAL; + } +} diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 6728a07..9af83ea 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -41,6 +41,8 @@ #include #include +#include + #include /* ranap_set_log_area() */ #include @@ -224,6 +226,7 @@ int main(int argc, char **argv) { int rc; + void *tall_rtp_ctx; /* Track the use of talloc NULL memory contexts */ talloc_enable_null_tracking(); @@ -246,6 +249,11 @@ osmo_talloc_vty_add_cmds(); osmo_cpu_sched_vty_init(tall_hnb_ctx); + /* allocate a talloc pool for ORTP to ensure it doesn't have to go back + * to the libc malloc all the time */ + tall_rtp_ctx = talloc_pool(tall_hnb_ctx, 262144); + osmo_rtp_init(tall_rtp_ctx); + g_hnb = hnb_alloc(tall_hnb_ctx); hnb_vty_init(); diff --git a/src/osmo-hnodeb/rtp.c b/src/osmo-hnodeb/rtp.c new file mode 100644 index 0000000..cc03c6c --- /dev/null +++ b/src/osmo-hnodeb/rtp.c @@ -0,0 +1,212 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include "config.h" + +#include +#include + +#include + +#include +#include + + +/* Mixture between osmo_rtp_get_bound_addr and osmo_rtp_get_bound_ip_port using osmo_sockaddr */ +/*static int rtp_get_bound_addr(struct osmo_rtp_socket *rs, struct osmo_sockaddr *osa) +{ + int rc; + socklen_t alen = sizeof(*osa); + + rc = getsockname(rs->rtp_bfd.fd, (struct sockaddr *)&osa->u.sa, &alen); + if (rc < 0) { + LOGP(DRTP, LOGL_ERROR, "getsockname(%d) failed: %s\n", + rs->rtp_bfd.fd, strerror(errno)); + return rc; + } + LOGP(DRTP, LOGL_DEBUG, "rtp socket: %s\n", osmo_sock_get_name2(rs->rtp_bfd.fd)); + return 0; +}*/ + +/* osmo_rtp_socket_connect() is broken, OS#5356 */ +static int rtp_get_bound_addr(struct osmo_rtp_socket *rs, const struct osmo_sockaddr *rem_addr, struct osmo_sockaddr *osa) +{ + int rc; + uint16_t port; + socklen_t alen = sizeof(*osa); + + /* First, retrieve bound port using getsockname: */ + rc = getsockname(rs->rtp_bfd.fd, (struct sockaddr *)&osa->u.sa, &alen); + if (rc < 0) + return rc; + switch (osa->u.sa.sa_family) { + case AF_INET6: + port = ntohs(osa->u.sin6.sin6_port); + break; + case AF_INET: + port = ntohs(osa->u.sin.sin_port); + break; + default: + return -EINVAL; + } + + /* osmo_rtp_socket_connect() is broken, OS#5356, so we didn't connect() + * and hence local_addr may still be unresolved (0.0.0.0) in the socket. + * let's get it from OS regular routing: */ + rc = osmo_sockaddr_local_ip(osa, rem_addr); + if (rc < 0) { + LOGP(DRTP, LOGL_ERROR, "osmo_sockaddr_local_ip(%d) failed: err=%d\n", + rs->rtp_bfd.fd, -rc); + return rc; + } + /* Copy back the correct port to the returned address: */ + switch (osa->u.sa.sa_family) { + case AF_INET6: + osa->u.sin6.sin6_port = htons(port); + break; + case AF_INET: + osa->u.sin.sin_port = htons(port); + break; + default: + return -EINVAL; + } + return 0; +} + +static int rtp_bind(struct hnb *hnb, struct osmo_rtp_socket *rs, const char *ip) +{ + int rc; + unsigned int i; + unsigned int tries; + + tries = (hnb->rtp.port_range_end - hnb->rtp.port_range_start) / 2; + for (i = 0; i < tries; i++) { + + if (hnb->rtp.port_range_next >= hnb->rtp.port_range_end) + hnb->rtp.port_range_next = hnb->rtp.port_range_start; + + rc = osmo_rtp_socket_bind(rs, ip, hnb->rtp.port_range_next); + + hnb->rtp.port_range_next += 2; + + if (rc != 0) + continue; + + if (hnb->rtp.ip_dscp != -1) { + if (osmo_rtp_socket_set_dscp(rs, hnb->rtp.ip_dscp)) + LOGP(DRTP, LOGL_ERROR, "failed to set DSCP=%d: %s\n", + hnb->rtp.ip_dscp, strerror(errno)); + } + if (hnb->rtp.priority != -1) { + if (osmo_rtp_socket_set_priority(rs, hnb->rtp.priority)) + LOGP(DRTP, LOGL_ERROR, "failed to set socket priority %d: %s\n", + hnb->rtp.priority, strerror(errno)); + } + return 0; + } + + return -1; +} + +static void rtp_rx_cb(struct osmo_rtp_socket *rs, const uint8_t *rtp_pl, + unsigned int rtp_pl_len, uint16_t seq_number, + uint32_t timestamp, bool marker) +{ + struct hnb_ue *ue = (struct hnb_ue *)rs->priv; + + LOGUE(ue, DRTP, LOGL_DEBUG, "Rx RTP seq=%u ts=%u M=%u pl=%p len=%u\n", + seq_number, timestamp, marker, rtp_pl, rtp_pl_len); + llsk_audio_tx_conn_data_ind(ue, rtp_pl, rtp_pl_len); +} + +int hnb_ue_voicecall_setup(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, struct osmo_sockaddr *loc_addr) +{ + int rc; + char cname[256+4]; + char name[32]; + struct osmo_rtp_socket *rs; + const char *local_wildcard_ipstr = "0.0.0.0"; + char remote_ipstr[INET6_ADDRSTRLEN]; + uint16_t remote_port; + struct hnb *hnb = ue->hnb; + + if (osmo_sockaddr_to_str_and_uint(remote_ipstr, sizeof(remote_ipstr), &remote_port, &rem_addr->u.sa) == 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Failed parsing remote address!\n"); + return -EINVAL; + } + + if (ue->conn_cs.rtp.socket) { + LOGUE(ue, DRTP, LOGL_ERROR, "Setting up rtp socket but it already exists!\n"); + return -EINVAL; + } + + rs = ue->conn_cs.rtp.socket = osmo_rtp_socket_create(ue, 0); + rc = osmo_rtp_socket_set_param(rs, + hnb->rtp.jitter_adaptive ? + OSMO_RTP_P_JIT_ADAP : + OSMO_RTP_P_JITBUF, + hnb->rtp.jitter_buf_ms); + if (rc < 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Failed to set RTP socket parameters: %s\n", strerror(-rc)); + goto free_ret; + } + rs->priv = ue; + rs->rx_cb = &rtp_rx_cb; + + rc = rtp_bind(hnb, rs, local_wildcard_ipstr); + if (rc < 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Failed to bind RTP/RTCP sockets\n"); + goto free_ret; + } + + /* Ensure RTCP SDES contains some useful information */ + snprintf(cname, sizeof(cname), "hnb@%s", local_wildcard_ipstr); + snprintf(name, sizeof(name), "ue@%u", ue->conn_id); + osmo_rtp_set_source_desc(rs, cname, name, NULL, NULL, NULL, + "OsmoHNodeB-" PACKAGE_VERSION, NULL); + + rc = osmo_rtp_socket_connect(rs, remote_ipstr, remote_port); + if (rc < 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Failed to connect RTP/RTCP sockets\n"); + goto free_ret; + } + + /* osmo_rtp_socket_connect() is broken, OS#5356 */ + //rc = rtp_get_bound_addr(rs, loc_addr); + rc = rtp_get_bound_addr(rs, rem_addr, loc_addr); + if (rc < 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Cannot obtain locally bound IP/port: %d\n", rc); + goto free_ret; + } + + return rc; +free_ret: + osmo_rtp_socket_free(ue->conn_cs.rtp.socket); + ue->conn_cs.rtp.socket = NULL; + return rc; +} + +int hnb_ue_voicecall_release(struct hnb_ue *ue) +{ + if (!ue->conn_cs.rtp.socket) + return -EINVAL; + osmo_rtp_socket_free(ue->conn_cs.rtp.socket); + ue->conn_cs.rtp.socket = NULL; + return 0; +} -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I9909a7c054ddaabb1bb63d7d06331cc79f642b5d Gerrit-Change-Number: 26502 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:39:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 14:39:18 +0000 Subject: Change in osmo-hnodeb[master]: First implementation of the LLSK gtp SAPI In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 ) Change subject: First implementation of the LLSK gtp SAPI ...................................................................... First implementation of the LLSK gtp SAPI This first implementation uses libgtp to manage the GTPv1-U socket and pdp contexts, as a proof of concept to have something working for now. At a later step, it is expected to drop libgtp and use some adhoc code to handle GTP-U. Related: SYS#5516 Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 --- M configure.ac M contrib/jenkins.sh M contrib/osmo-hnodeb.spec.in M debian/control M include/osmocom/hnodeb/Makefile.am A include/osmocom/hnodeb/gtp.h M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/vty.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/debug.c A src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk.c A src/osmo-hnodeb/llsk_gtp.c M src/osmo-hnodeb/main.c M src/osmo-hnodeb/vty.c 18 files changed, 696 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index e96a6a1..8a34b82 100644 --- a/configure.ac +++ b/configure.ac @@ -67,6 +67,7 @@ PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 0.8.0) PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.8.0) PKG_CHECK_MODULES(LIBOSMOHNBAP, libosmo-hnbap >= 0.8.0) +PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.8.0) dnl checks for header files diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7001013..3225de2 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -34,6 +34,7 @@ osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sccp osmo-build-dep.sh libasn1c +osmo-build-dep.sh osmo-ggsn osmo-build-dep.sh osmo-iuh # Additional configure options and depends diff --git a/contrib/osmo-hnodeb.spec.in b/contrib/osmo-hnodeb.spec.in index 063e69a..fef34af 100644 --- a/contrib/osmo-hnodeb.spec.in +++ b/contrib/osmo-hnodeb.spec.in @@ -46,6 +46,7 @@ BuildRequires: pkgconfig(libosmo-rua) >= 0.8.0 BuildRequires: pkgconfig(talloc) BuildRequires: pkgconfig(libasn1c) >= 0.9.30 +BuildRequires: pkgconfig(libgtp) >= 1.8.0 %{?systemd_requires} %description diff --git a/debian/control b/debian/control index a306e10..503b202 100644 --- a/debian/control +++ b/debian/control @@ -13,6 +13,7 @@ python3-minimal, libtalloc-dev, libasn1c-dev (>= 0.9.30), + libgtp-dev (>= 1.8.0), libsctp-dev, libosmocore-dev (>= 1.6.0), libosmo-sigtran-dev (>= 1.5.0), diff --git a/include/osmocom/hnodeb/Makefile.am b/include/osmocom/hnodeb/Makefile.am index dcb3868..381cff9 100644 --- a/include/osmocom/hnodeb/Makefile.am +++ b/include/osmocom/hnodeb/Makefile.am @@ -1,4 +1,5 @@ noinst_HEADERS = \ + gtp.h \ hnb_shutdown_fsm.h \ hnb_prim.h \ hnbap.h \ diff --git a/include/osmocom/hnodeb/gtp.h b/include/osmocom/hnodeb/gtp.h new file mode 100644 index 0000000..af9e007 --- /dev/null +++ b/include/osmocom/hnodeb/gtp.h @@ -0,0 +1,32 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include + +struct hnb; +struct hnb_ue; + +int hnb_gtp_bind(struct hnb *hnb); +void hnb_gtp_unbind(struct hnb *hnb); + +int hnb_ue_gtp_bind(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei, + struct osmo_sockaddr *loc_addr, uint32_t *loc_tei); +int hnb_ue_gtp_unbind(struct hnb_ue *ue); +int hnb_ue_gtp_tx(struct hnb_ue *ue, void *gtpu_payload, unsigned gtpu_payload_len); diff --git a/include/osmocom/hnodeb/hnb_prim.h b/include/osmocom/hnodeb/hnb_prim.h index dab00c9..f0e3a96 100644 --- a/include/osmocom/hnodeb/hnb_prim.h +++ b/include/osmocom/hnodeb/hnb_prim.h @@ -232,3 +232,71 @@ struct hnb_audio_conn_data_ind_param conn_data_ind; } u; } __attribute__ ((packed)); + +/**************************** + * GTP + ***************************/ +/*! \brief HNB_GTP primitives */ +enum hnb_gtp_prim_type { + HNB_GTP_PRIM_CONN_ESTABLISH, + HNB_GTP_PRIM_CONN_RELEASE, + HNB_GTP_PRIM_CONN_DATA, + _HNB_GTP_PRIM_MAX +}; + +/* HNB_GTP_PRIM_CONN_ESTABLISH, UL */ +struct hnb_gtp_conn_establish_req_param { + uint32_t context_id; + uint32_t remote_tei; + uint8_t spare1; + uint8_t remote_gtpu_address_type; + union u_addr remote_gtpu_addr; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_ESTABLISH, DL */ +struct hnb_gtp_conn_establish_cnf_param { + uint32_t context_id; + uint32_t local_tei; + uint8_t error_code; /* 0 = success, !0 = failure */ + uint8_t local_gtpu_address_type; /* enum u_addr_type */ + union u_addr local_gtpu_addr; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_RELEASE, UL */ +struct hnb_gtp_conn_release_req_param { + uint32_t context_id; + uint32_t remote_tei; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_RELEASE, DL */ +struct hnb_gtp_conn_release_ind_param { + uint32_t context_id; + uint32_t local_tei; +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_DATA, DL */ +struct hnb_gtp_conn_data_ind_param { + uint32_t context_id; + uint32_t local_tei; + uint32_t data_len; /* GTP-U payload length in bytes */ + uint8_t data[0]; /* GTP-U payload (aka IP packet) */ +} __attribute__ ((packed)); + +/* HNB_GTP_PRIM_CONN_DATA, UL */ +struct hnb_gtp_conn_data_req_param { + uint32_t context_id; + uint32_t remote_tei; + uint32_t data_len; /* GTP-U payload length in bytes */ + uint8_t data[0]; /* GTP-U payload (aka IP packet) */ +} __attribute__ ((packed)); + +struct hnb_gtp_prim { + struct osmo_prim_hdr hdr; + union { + struct hnb_gtp_conn_establish_req_param conn_establish_req; + struct hnb_gtp_conn_establish_cnf_param conn_establish_cnf; + struct hnb_gtp_conn_release_req_param conn_release_req; + struct hnb_gtp_conn_data_req_param conn_data_req; + struct hnb_gtp_conn_data_ind_param conn_data_ind; + } u; +} __attribute__ ((packed)); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 15244c4..52d1bec 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -35,6 +35,9 @@ #include #include +#include +#include + #include enum { @@ -45,6 +48,7 @@ DSCTP, DLLSK, DRTP, + DGTP, }; extern const struct log_info hnb_log_info; @@ -65,12 +69,16 @@ struct hnb_ue_ps_ctx { bool active; /* Is this chan in use? */ bool conn_est_cnf_pending; /* Did we send CONN_ESTABLISH_CNF to lower layers? */ + uint32_t local_tei; + uint32_t remote_tei; + struct pdp_t *pdp_lib; } conn_ps; }; struct hnb_ue *hnb_ue_alloc(struct hnb *hnb, uint32_t conn_id); void hnb_ue_free(struct hnb_ue *ue); void hnb_ue_reset_chan(struct hnb_ue *ue, bool is_ps); + struct hnb { char *identity; /* HNB-Identity */ struct osmo_plmn_id plmn; @@ -103,6 +111,13 @@ int priority; } rtp; + struct gtp { + char *cfg_local_addr; + struct osmo_sockaddr local_addr; + struct gsn_t *gsn; + struct osmo_fd fd1u; + } gtp; + uint16_t rnc_id; bool registered; /* Set to true once HnbRegisterAccept was received from Iuh. rnc_id is valid iif registered==true */ @@ -117,6 +132,7 @@ struct hnb *hnb_alloc(void *tall_ctx); void hnb_free(struct hnb *hnb); struct hnb_ue *hnb_find_ue_by_id(const struct hnb *hnb, uint32_t conn_id); +struct hnb_ue *hnb_find_ue_by_tei(const struct hnb *hnb, uint32_t tei, bool is_remote); struct hnb_ue *hnb_find_ue_by_imsi(const struct hnb *hnb, char *imsi); extern void *tall_hnb_ctx; diff --git a/include/osmocom/hnodeb/llsk.h b/include/osmocom/hnodeb/llsk.h index 0636a5f..6d98cd0 100644 --- a/include/osmocom/hnodeb/llsk.h +++ b/include/osmocom/hnodeb/llsk.h @@ -54,3 +54,8 @@ extern const struct value_string hnb_audio_prim_type_names[]; int llsk_rx_audio(struct hnb *hnb, struct osmo_prim_hdr *oph); int llsk_audio_tx_conn_data_ind(struct hnb_ue *ue, const uint8_t *payload, uint32_t len); + +extern const struct value_string hnb_gtp_prim_type_names[]; +int llsk_rx_gtp(struct hnb *hnb, struct osmo_prim_hdr *oph); +struct hnb_gtp_prim *hnb_gtp_makeprim_conn_data_ind(uint32_t context_id, uint32_t local_tei, + const uint8_t *data, uint32_t data_len); diff --git a/include/osmocom/hnodeb/vty.h b/include/osmocom/hnodeb/vty.h index 627436d..5c11302 100644 --- a/include/osmocom/hnodeb/vty.h +++ b/include/osmocom/hnodeb/vty.h @@ -28,6 +28,7 @@ HNODEB_NODE = _LAST_OSMOVTY_NODE, IUH_NODE, LLSK_NODE, + GTP_NODE, }; void hnb_vty_init(void); diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 4182814..6edbf88 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -19,6 +19,7 @@ $(LIBOSMORUA_CFLAGS) \ $(LIBOSMORANAP_CFLAGS) \ $(LIBOSMOHNBAP_CFLAGS) \ + $(LIBGTP_CFLAGS) \ $(NULL) AM_LDFLAGS = \ @@ -32,12 +33,14 @@ osmo_hnodeb_SOURCES = \ main.c \ debug.c \ + gtp.c \ hnbap.c \ hnb.c \ hnb_shutdown_fsm.c \ iuh.c \ llsk.c \ llsk_audio.c \ + llsk_gtp.c \ llsk_iuh.c \ ranap.c \ rtp.c \ @@ -60,4 +63,5 @@ $(LIBOSMORANAP_LIBS) \ $(LIBOSMOHNBAP_LIBS) \ $(LIBSCTP_LIBS) \ + $(LIBGTP_LIBS) \ $(NULL) diff --git a/src/osmo-hnodeb/debug.c b/src/osmo-hnodeb/debug.c index 5d0dabd..3bdda7d 100644 --- a/src/osmo-hnodeb/debug.c +++ b/src/osmo-hnodeb/debug.c @@ -57,6 +57,11 @@ .color = "\033[1;32m", .description = "RTP Core Network side", }, + [DGTP] = { + .name = "DGTP", .loglevel = LOGL_NOTICE, .enabled = 1, + .color = "\033[1;30m", + .description = "GPRS Tunnelling Protocol", + }, }; const struct log_info hnb_log_info = { diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c new file mode 100644 index 0000000..4695ea9 --- /dev/null +++ b/src/osmo-hnodeb/gtp.c @@ -0,0 +1,207 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include + +#include +#include +#include + +#include +#include + +/* Get osa of locally bound GTP-U socket */ +int sk_get_bound_addr(int fd, struct osmo_sockaddr *osa) +{ + int rc; + socklen_t alen = sizeof(*osa); + + rc = getsockname(fd, (struct sockaddr *)&osa->u.sa, &alen); + if (rc < 0) + return rc; + + return 0; +} + +/* Called whenever we receive a DATA packet */ +static int hnb_gtp_cb_data_ind(struct pdp_t *lib, void *packet, unsigned int len) +{ + struct hnb_gtp_prim *gtp_prim; + struct hnb_ue *ue = lib->priv; + struct hnb *hnb = ue->hnb; + int rc; + + if (!ue || !ue->conn_ps.active) { + LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", + packet, len); + return -EINVAL; + } + + LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len); + gtp_prim = hnb_gtp_makeprim_conn_data_ind(ue->conn_id, ue->conn_ps.local_tei, packet, len); + if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { + LOGUE(ue, DGTP, LOGL_ERROR, "Failed Tx GTP-CONN_DATA.ind data=%p len=%u\n", + packet, len); + } + return rc; +} + +/* libgtp select loop integration */ +static int hnb_gtp_fd_cb(struct osmo_fd *fd, unsigned int what) +{ + struct hnb *hnb = fd->data; + int rc; + + if (!(what & OSMO_FD_READ)) + return 0; + + switch (fd->priv_nr) { + case 0: + rc = gtp_decaps1u(hnb->gtp.gsn); + break; + default: + rc = -EINVAL; + break; + } + return rc; +} + +int hnb_gtp_bind(struct hnb *hnb) +{ + int rc; + struct gsn_t *gsn; + struct in_addr inaddr; + + rc = inet_pton(AF_INET, hnb->gtp.cfg_local_addr, &inaddr); + if (rc <= 0) + return -EINVAL; + + /* TODO: add new mode GTP_MODE_GTPU_ONLY to set up gtpu side only (and ignore statedir) */ + rc = gtp_new(&gsn, "/tmp", &inaddr, GTP_MODE_SGSN); + if (rc < 0) { + LOGP(DGTP, LOGL_ERROR, "Failed to set up GTP socket: %s\n", strerror(-rc)); + return rc; + } + + rc = sk_get_bound_addr(gsn->fd1u, &hnb->gtp.local_addr); + if (rc < 0) { + LOGP(DGTP, LOGL_ERROR, "Failed to get GTP-U socket bound address: %s\n", strerror(-rc)); + goto free_ret; + } + + osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0); + if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0) + goto free_ret; + + gtp_set_cb_data_ind(gsn, hnb_gtp_cb_data_ind); + + hnb->gtp.gsn = gsn; + return 0; + +free_ret: + gtp_free(gsn); + hnb->gtp.fd1u.fd = -1; + return rc; +} + +void hnb_gtp_unbind(struct hnb *hnb) +{ + osmo_fd_unregister(&hnb->gtp.fd1u); + gtp_free(hnb->gtp.gsn); + hnb->gtp.gsn = NULL; + hnb->gtp.fd1u.fd = -1; +} + +int hnb_ue_gtp_bind(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei, + struct osmo_sockaddr *loc_addr, uint32_t *loc_tei) +{ + int rc; + struct hnb *hnb = ue->hnb; + struct pdp_t *pdp; + struct in_addr rem_in; + + LOGUE(ue, DGTP, LOGL_INFO, "Creating PDP context\n"); + + + if (rem_addr->u.sa.sa_family != AF_INET) { + LOGUE(ue, DGTP, LOGL_ERROR, "Failed creating PDP context: unsupported proto family %u\n", + rem_addr->u.sa.sa_family); + return -ENOTSUP; + } + + rem_in = rem_addr->u.sin.sin_addr; + + rc = gtp_pdp_newpdp(hnb->gtp.gsn, &pdp, ue->conn_id, 0 /* TODO: NSAPI? */, NULL); + if (rc < 0) { + LOGUE(ue, DGTP, LOGL_ERROR, "Failed creating PDP context: %s\n", strerror(-rc)); + return rc; + } + pdp->priv = ue; + ue->conn_ps.pdp_lib = pdp; + + pdp->teid_gn = rem_tei; + pdp->version = 1; + pdp->hisaddr0 = rem_in; + pdp->hisaddr1 = rem_in; + + pdp->gsnru.l = sizeof(rem_in); + memcpy(pdp->gsnru.v, &rem_in, sizeof(rem_in)); + + + pdp->gsnlu.l = sizeof(hnb->gtp.local_addr.u.sin.sin_addr); + memcpy(pdp->gsnlu.v, &hnb->gtp.local_addr.u.sin.sin_addr, + sizeof(hnb->gtp.local_addr.u.sin.sin_addr)); + + *loc_addr = hnb->gtp.local_addr; + //loc_addr->u.sin.sin_family = AF_INET; + //loc_addr->u.sin.sin_addr = hnb->gtp.gsn->gsnu; + //loc_addr->u.sin.sin_port = GTP1U_PORT; + *loc_tei = pdp->teid_own; + return 0; +} + +int hnb_ue_gtp_tx(struct hnb_ue *ue, void *gtpu_payload, unsigned gtpu_payload_len) +{ + int rc; + struct hnb *hnb = ue->hnb; + + if (!hnb->gtp.gsn) { + LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n"); + return -EINVAL; + } + + if (!ue || !ue->conn_ps.pdp_lib) { + LOGUE(ue, DGTP, LOGL_ERROR, "Tx: UE PDP Ctx not available\n"); + return -EINVAL; + } + + rc = gtp_data_req(hnb->gtp.gsn, ue->conn_ps.pdp_lib, gtpu_payload, gtpu_payload_len); + return rc; +} + +int hnb_ue_gtp_unbind(struct hnb_ue *ue) +{ + if (!ue->conn_ps.pdp_lib) + return -EINVAL; + + pdp_freepdp(ue->conn_ps.pdp_lib); + ue->conn_ps.pdp_lib = NULL; + return 0; +} diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index 4c949f5..b733d15 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -34,6 +34,7 @@ #include #include #include +#include struct hnb *hnb_alloc(void *tall_ctx) @@ -59,6 +60,9 @@ hnb->rtp.ip_dscp = -1; hnb->rtp.priority = -1; + hnb->gtp.cfg_local_addr = talloc_strdup(hnb, "0.0.0.0"); + hnb->gtp.fd1u.fd = -1; + hnb->shutdown_fi = osmo_fsm_inst_alloc(&hnb_shutdown_fsm, hnb, hnb, LOGL_INFO, NULL); @@ -86,6 +90,11 @@ osmo_prim_srv_link_free(hnb->llsk_link); hnb->llsk_link = NULL; + if (hnb->gtp.gsn) { + gtp_free(hnb->gtp.gsn); + hnb->gtp.gsn = NULL; + } + talloc_free(hnb); } @@ -116,6 +125,7 @@ void hnb_ue_reset_chan(struct hnb_ue *ue, bool is_ps) { if (is_ps) { + hnb_ue_gtp_unbind(ue); ue->conn_ps = (struct hnb_ue_ps_ctx){0}; } else { hnb_ue_voicecall_release(ue); @@ -134,6 +144,22 @@ } return NULL; } + +struct hnb_ue *hnb_find_ue_by_tei(const struct hnb *hnb, uint32_t tei, bool is_remote) +{ + struct hnb_ue *ue; + + llist_for_each_entry(ue, &hnb->ue_list, list) { + if (!ue->conn_ps.active) + continue; + uint32_t ue_tei = is_remote ? ue->conn_ps.remote_tei : ue->conn_ps.local_tei; + if (tei != ue_tei) + continue; + return ue; + } + return NULL; +} + struct hnb_ue *hnb_find_ue_by_imsi(const struct hnb *hnb, char *imsi) { struct hnb_ue *ue; diff --git a/src/osmo-hnodeb/llsk.c b/src/osmo-hnodeb/llsk.c index 8c93318..6584dcb 100644 --- a/src/osmo-hnodeb/llsk.c +++ b/src/osmo-hnodeb/llsk.c @@ -129,7 +129,8 @@ return false; if (hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_IUH) && - hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_AUDIO)) + hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_AUDIO) && + hnb->llsk_valid_sapi_mask & (1 << HNB_PRIM_SAPI_GTP)) return true; return false; } @@ -164,9 +165,7 @@ case HNB_PRIM_SAPI_IUH: return llsk_rx_iuh(hnb, oph); case HNB_PRIM_SAPI_GTP: - LOGP(DLLSK, LOGL_ERROR, "Rx SAPI %u not yet implemented (len=%u)\n", - oph->sap, msgb_length(oph->msg)); - return -EINVAL; + return llsk_rx_gtp(hnb, oph); case HNB_PRIM_SAPI_AUDIO: return llsk_rx_audio(hnb, oph); default: diff --git a/src/osmo-hnodeb/llsk_gtp.c b/src/osmo-hnodeb/llsk_gtp.c new file mode 100644 index 0000000..e75c497 --- /dev/null +++ b/src/osmo-hnodeb/llsk_gtp.c @@ -0,0 +1,279 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Pau Espin Pedrol + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +#include +#include +#include +#include + +static size_t llsk_gtp_prim_size_tbl[4][_HNB_GTP_PRIM_MAX] = { + [PRIM_OP_REQUEST] = { + [HNB_GTP_PRIM_CONN_ESTABLISH] = sizeof(struct hnb_gtp_conn_establish_req_param), + [HNB_GTP_PRIM_CONN_RELEASE] = sizeof(struct hnb_gtp_conn_release_req_param), + [HNB_GTP_PRIM_CONN_DATA] = sizeof(struct hnb_gtp_conn_data_req_param), + }, + [PRIM_OP_RESPONSE] = {}, + [PRIM_OP_INDICATION] = { + [HNB_GTP_PRIM_CONN_DATA] = sizeof(struct hnb_gtp_conn_data_ind_param), + }, + [PRIM_OP_CONFIRM] = { + [HNB_GTP_PRIM_CONN_ESTABLISH] = sizeof(struct hnb_gtp_conn_establish_cnf_param), + }, +}; +static inline size_t llsk_gtp_prim_size(enum hnb_gtp_prim_type ptype, enum osmo_prim_operation op) +{ + size_t val = llsk_gtp_prim_size_tbl[op][ptype]; + if (val == 0) { + LOGP(DLLSK, LOGL_FATAL, "Expected prim_size != 0 for ptype=%u op=%u\n", ptype, op); + osmo_panic("Expected prim_size != 0 for ptype=%u op=%u\n", ptype, op); + } + return val; +} + +const struct value_string hnb_gtp_prim_type_names[] = { + OSMO_VALUE_STRING(HNB_GTP_PRIM_CONN_ESTABLISH), + OSMO_VALUE_STRING(HNB_GTP_PRIM_CONN_RELEASE), + OSMO_VALUE_STRING(HNB_GTP_PRIM_CONN_DATA), + { 0, NULL } +}; + +static struct hnb_gtp_prim *hnb_gtp_prim_alloc(enum hnb_gtp_prim_type ptype, enum osmo_prim_operation op, size_t extra_len) +{ + struct osmo_prim_hdr *oph; + size_t len = llsk_gtp_prim_size(ptype, op); + + oph = osmo_prim_msgb_alloc(HNB_PRIM_SAPI_GTP, ptype, op, sizeof(*oph) + len + extra_len); + if (!oph) + return NULL; + msgb_put(oph->msg, len); + + return (struct hnb_gtp_prim *)oph; +} + +static struct hnb_gtp_prim *hnb_gtp_makeprim_conn_establish_cnf(uint32_t context_id, uint8_t error_code, + uint32_t local_tei, uint8_t local_gtpu_address_type, + const union u_addr *local_gtpu_addr) +{ + struct hnb_gtp_prim *gtp_prim; + + gtp_prim = hnb_gtp_prim_alloc(HNB_GTP_PRIM_CONN_ESTABLISH, PRIM_OP_CONFIRM, 0); + gtp_prim->u.conn_establish_cnf.context_id = context_id; + gtp_prim->u.conn_establish_cnf.local_tei = local_tei; + gtp_prim->u.conn_establish_cnf.error_code = error_code; + gtp_prim->u.conn_establish_cnf.local_gtpu_address_type = local_gtpu_address_type; + if (local_gtpu_addr) + gtp_prim->u.conn_establish_cnf.local_gtpu_addr = *local_gtpu_addr; + + return gtp_prim; +} + +struct hnb_gtp_prim *hnb_gtp_makeprim_conn_data_ind(uint32_t context_id, uint32_t local_tei, + const uint8_t *data, uint32_t data_len) +{ + struct hnb_gtp_prim *gtp_prim; + + gtp_prim = hnb_gtp_prim_alloc(HNB_GTP_PRIM_CONN_DATA, PRIM_OP_INDICATION, data_len); + gtp_prim->u.conn_data_ind.context_id = context_id; + gtp_prim->u.conn_data_ind.local_tei = local_tei; + gtp_prim->u.conn_data_ind.data_len = data_len; + if (data_len) { + msgb_put(gtp_prim->hdr.msg, data_len); + memcpy(gtp_prim->u.conn_data_ind.data, data, data_len); + } + + return gtp_prim; +} + +static int _send_conn_establish_cnf_failed(struct hnb *hnb, uint32_t context_id, uint8_t error_code) +{ + struct hnb_gtp_prim *gtp_prim; + int rc; + LOGP(DLLSK, LOGL_ERROR, "Tx GTP-CONN_ESTABLISH.cnf: ctx=%u error_code=%u\n", + context_id, error_code); + gtp_prim = hnb_gtp_makeprim_conn_establish_cnf(context_id, error_code, 0, HNB_PRIM_ADDR_TYPE_UNSPEC, NULL); + if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { + LOGP(DLLSK, LOGL_ERROR, "Failed sending GTP-CONN_ESTABLISH.cnf context_id=%u error_code=%u\n", + context_id, error_code); + } + return rc; +} + +static int llsk_rx_gtp_conn_establish_req(struct hnb *hnb, struct hnb_gtp_conn_establish_req_param *ce_req) +{ + struct hnb_ue *ue; + int rc = 0; + struct hnb_gtp_prim *gtp_prim; + int af; + char rem_addrstr[INET6_ADDRSTRLEN+32]; + struct osmo_sockaddr rem_osa = {0}; + struct osmo_sockaddr loc_osa = {0}; + union u_addr loc_uaddr = {0}; + uint32_t loc_tei; + + rc = ll_addr2osa(ce_req->remote_gtpu_address_type, &ce_req->remote_gtpu_addr, GTP1U_PORT, &rem_osa); + if (rc < 0) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: ctx=%u with unexpected address type %u\n", + ce_req->context_id, ce_req->remote_gtpu_address_type); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 1); + } + osmo_sockaddr_to_str_buf(rem_addrstr, sizeof(rem_addrstr), &rem_osa); + + LOGP(DLLSK, LOGL_INFO, "Rx GTP-CONN_ESTABLISH.req ctx=%u rem_tei=%u rem_addr=%s\n", + ce_req->context_id, ce_req->remote_tei, rem_addrstr); + + if ((af = ll_addr_type2af(ce_req->remote_gtpu_address_type)) < 0) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: ctx=%u with unexpected address type %u\n", + ce_req->context_id, ce_req->remote_gtpu_address_type); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 1); + } + + ue = hnb_find_ue_by_id(hnb, ce_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: UE not found! ctx=%u rem_addr=%s\n", + ce_req->context_id, rem_addrstr); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 2); + } + if (!ue->conn_ps.active) { + LOGUE(ue, DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: PS chan not active! rem_addr=%s\n", + rem_addrstr); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 3); + } + + /* Create the socket: */ + if ((rc = hnb_ue_gtp_bind(ue, &rem_osa, ce_req->remote_tei, &loc_osa, &loc_tei)) < 0) { + LOGUE(ue, DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: Failed to set up gtp socket rem_tei=%u rem_addr=%s\n", + ce_req->remote_tei, rem_addrstr); + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); + } + + /* Convert resulting local address back to LLSK format: */ + if (osa2_ll_addr(&loc_osa, &loc_uaddr, NULL) != ce_req->remote_gtpu_address_type) { + LOGUE(ue, DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: Failed to provide proper local address rem_addr=%s\n", + rem_addrstr); + rc = _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); + goto release_sock; + } + + /* Submit successful confirmation */ + LOGUE(ue, DLLSK, LOGL_INFO, "Tx GTP-CONN_ESTABLISH.cnf: error_code=0 rem_addr=%s rem_tei=%u loc_addr=%s local_tei=%u\n", + rem_addrstr, ce_req->remote_tei, osmo_sockaddr_to_str(&loc_osa), loc_tei); + gtp_prim = hnb_gtp_makeprim_conn_establish_cnf(ce_req->context_id, 0, loc_tei, ce_req->remote_gtpu_address_type, &loc_uaddr); + if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { + LOGUE(ue, DLLSK, LOGL_ERROR, "Failed sending GTP-CONN_ESTABLISH.cnf error_code=0\n"); + goto release_sock; + } + + ue->conn_ps.local_tei = loc_tei; + ue->conn_ps.remote_tei = ce_req->remote_tei; + + return rc; +release_sock: + hnb_ue_gtp_unbind(ue); + return rc; +} + +static int llsk_rx_gtp_conn_release_req(struct hnb *hnb, struct hnb_gtp_conn_release_req_param *rel_req) +{ + struct hnb_ue *ue; + int rc = 0; + + LOGP(DLLSK, LOGL_DEBUG, "Rx GTP-CONN_RELEASE.req ctx=%u\n", rel_req->context_id); + + ue = hnb_find_ue_by_id(hnb, rel_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_RELEASE.req: UE not found! ctx=%u\n", + rel_req->context_id); + return -EINVAL; + } + /* release GTP pdp ctx: */ + hnb_ue_gtp_unbind(ue); + return rc; +} + +static int llsk_rx_gtp_conn_data_req(struct hnb *hnb, struct hnb_gtp_conn_data_req_param *data_req) +{ + struct hnb_ue *ue; + int rc = 0; + + LOGP(DLLSK, LOGL_DEBUG, "Rx GTP-CONN_DATA.req ctx=%u rem_tei=%u data_len=%u\n", + data_req->context_id, data_req->remote_tei, data_req->data_len); + + ue = hnb_find_ue_by_id(hnb, data_req->context_id); + if (!ue) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_DATA.req: UE not found! ctx=%u data_len=%u\n", + data_req->context_id, data_req->data_len); + return -EINVAL; + } + + rc = hnb_ue_gtp_tx(ue, data_req->data, data_req->data_len); + return rc; +} + +int llsk_rx_gtp(struct hnb *hnb, struct osmo_prim_hdr *oph) +{ + size_t prim_size = llsk_gtp_prim_size(oph->primitive, oph->operation); + + if (msgb_length(oph->msg) < prim_size) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-%s.%s with length %u < %zu\n", + get_value_string(hnb_gtp_prim_type_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation), + msgb_length(oph->msg), prim_size); + return -EINVAL; + } + + switch (oph->operation) { + case PRIM_OP_REQUEST: + switch (oph->primitive) { + case HNB_GTP_PRIM_CONN_ESTABLISH: + return llsk_rx_gtp_conn_establish_req(hnb, (struct hnb_gtp_conn_establish_req_param *)msgb_data(oph->msg)); + case HNB_GTP_PRIM_CONN_RELEASE: + return llsk_rx_gtp_conn_release_req(hnb, (struct hnb_gtp_conn_release_req_param *)msgb_data(oph->msg)); + case HNB_GTP_PRIM_CONN_DATA: + return llsk_rx_gtp_conn_data_req(hnb, (struct hnb_gtp_conn_data_req_param *)msgb_data(oph->msg)); + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-gtp unknown primitive %u (len=%u)\n", + oph->primitive, msgb_length(oph->msg)); + return -EINVAL; + } + break; + + case PRIM_OP_RESPONSE: + case PRIM_OP_INDICATION: + case PRIM_OP_CONFIRM: + default: + LOGP(DLLSK, LOGL_ERROR, "Rx llsk-gtp unexpected primitive operation %s::%s (len=%u)\n", + get_value_string(hnb_gtp_prim_type_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation), + msgb_length(oph->msg)); + return -EINVAL; + } +} diff --git a/src/osmo-hnodeb/main.c b/src/osmo-hnodeb/main.c index 9af83ea..5d35c18 100644 --- a/src/osmo-hnodeb/main.c +++ b/src/osmo-hnodeb/main.c @@ -51,6 +51,7 @@ #include #include #include +#include static const char * const osmohnodeb_copyright = "OsmoHNodeB - Osmocom 3G Home NodeB implementation\r\n" @@ -280,6 +281,12 @@ exit(1); } + rc = hnb_gtp_bind(g_hnb); + if (rc < 0) { + perror("Error listening on GTP port"); + exit(1); + } + rc = hnb_iuh_connect(g_hnb); if (rc < 0) { perror("Error connecting to Iuh port"); @@ -305,6 +312,8 @@ osmo_select_main_ctx(0); } + hnb_gtp_unbind(g_hnb); + log_fini(); /** diff --git a/src/osmo-hnodeb/vty.c b/src/osmo-hnodeb/vty.c index 131dc6b..e84e330 100644 --- a/src/osmo-hnodeb/vty.c +++ b/src/osmo-hnodeb/vty.c @@ -51,6 +51,10 @@ vty->node = HNODEB_NODE; vty->index = g_hnb; break; + case GTP_NODE: + vty->node = HNODEB_NODE; + vty->index = g_hnb; + break; case HNODEB_NODE: vty->node = CONFIG_NODE; vty->index = g_hnb; @@ -281,6 +285,33 @@ return CMD_SUCCESS; } +static struct cmd_node gtp_node = { + GTP_NODE, + "%s(config-gtp)# ", + 1, +}; + +#define GTP_STR "Configure the GPRS Tunnelling Protocol parameters\n" + +DEFUN(cfg_hnodeb_gtp, + cfg_hnodeb_gtp_cmd, + "gtp", GTP_STR) +{ + OSMO_ASSERT(g_hnb); + vty->index = g_hnb; + vty->node = GTP_NODE; + + return CMD_SUCCESS; +} + +DEFUN(cfg_hnodeb_gtp_local_ip, cfg_hnodeb_gtp_local_ip_cmd, + "local-ip " VTY_IPV4_CMD, + "Configure the GTP-U bind address\n" + "GTP-U local IPv4 address\n") +{ + osmo_talloc_replace_string(g_hnb, &g_hnb->gtp.cfg_local_addr, argv[0]); + return CMD_SUCCESS; +} static int config_write_hnodeb(struct vty *vty) { @@ -302,6 +333,8 @@ vty_out(vty, " remote-port %u%s", g_hnb->iuh.remote_port, VTY_NEWLINE); vty_out(vty, " ll-socket%s", VTY_NEWLINE); vty_out(vty, " path %s%s", osmo_prim_srv_link_get_addr(g_hnb->llsk_link), VTY_NEWLINE); + vty_out(vty, " gtp%s", VTY_NEWLINE); + vty_out(vty, " local-ip %s%s", g_hnb->gtp.cfg_local_addr, VTY_NEWLINE); return CMD_SUCCESS; } @@ -359,6 +392,9 @@ install_element(HNODEB_NODE, &cfg_hnodeb_llsk_cmd); install_node(&llsk_node, NULL); install_element(LLSK_NODE, &cfg_hnodeb_llsk_path_cmd); + install_element(HNODEB_NODE, &cfg_hnodeb_gtp_cmd); + install_node(>p_node, NULL); + install_element(GTP_NODE, &cfg_hnodeb_gtp_local_ip_cmd); install_element_ve(&asn_dbg_cmd); install_element_ve(&ranap_reset_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I5a6f5dfc4e508c92adb35210b4dc576d64353366 Gerrit-Change-Number: 26503 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:39:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 14:39:30 +0000 Subject: Change in docker-playground[master]: hnodeb: Update Dockerfile, configs with new deps, configs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26544 ) Change subject: hnodeb: Update Dockerfile, configs with new deps, configs ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5b223149cbbea16e4ccd9b3874874c6366fe7969 Gerrit-Change-Number: 26544 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 15 Dec 2021 14:39:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 14:39:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 14:39:32 +0000 Subject: Change in docker-playground[master]: hnodeb: Update Dockerfile, configs with new deps, configs In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26544 ) Change subject: hnodeb: Update Dockerfile, configs with new deps, configs ...................................................................... hnodeb: Update Dockerfile, configs with new deps, configs Pull in libgtp, configure LL socket, etc. Change-Id: I5b223149cbbea16e4ccd9b3874874c6366fe7969 --- M osmo-hnodeb-master/Dockerfile M ttcn3-hnodeb-test/HNB_Tests.cfg M ttcn3-hnodeb-test/jenkins.sh M ttcn3-hnodeb-test/osmo-hnodeb.cfg 4 files changed, 12 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/osmo-hnodeb-master/Dockerfile b/osmo-hnodeb-master/Dockerfile index 1a3ded9..a7ff068 100644 --- a/osmo-hnodeb-master/Dockerfile +++ b/osmo-hnodeb-master/Dockerfile @@ -10,6 +10,7 @@ libosmo-abis-dev \ libosmo-netif-dev \ libosmo-sigtran-dev \ + libgtp-dev \ libasn1c-dev && \ apt-get clean diff --git a/ttcn3-hnodeb-test/HNB_Tests.cfg b/ttcn3-hnodeb-test/HNB_Tests.cfg index 9190e1b..677e12b 100644 --- a/ttcn3-hnodeb-test/HNB_Tests.cfg +++ b/ttcn3-hnodeb-test/HNB_Tests.cfg @@ -12,6 +12,7 @@ [MODULE_PARAMETERS] HNB_Tests.mp_hnodeb_ip := "172.18.33.20"; HNB_Tests.mp_hnbgw_iuh_ip := "172.18.33.203"; +HNB_Tests.mp_hnbllif_sk_path := "/data/unix/ll_sock"; [MAIN_CONTROLLER] diff --git a/ttcn3-hnodeb-test/jenkins.sh b/ttcn3-hnodeb-test/jenkins.sh index 8bcfbf4..358280d 100755 --- a/ttcn3-hnodeb-test/jenkins.sh +++ b/ttcn3-hnodeb-test/jenkins.sh @@ -10,12 +10,16 @@ set -e mkdir $VOL_BASE_DIR/hnodeb-tester +mkdir $VOL_BASE_DIR/hnodeb-tester/unix cp HNB_Tests.cfg $VOL_BASE_DIR/hnodeb-tester/ write_mp_osmo_repo "$VOL_BASE_DIR/hnodeb-tester/HNB_Tests.cfg" mkdir $VOL_BASE_DIR/hnodeb +mkdir $VOL_BASE_DIR/hnodeb/unix cp osmo-hnodeb.cfg $VOL_BASE_DIR/hnodeb/ +mkdir $VOL_BASE_DIR/unix + SUBNET=33 network_create $SUBNET @@ -24,6 +28,7 @@ $(docker_network_params $SUBNET 20) \ --ulimit core=-1 \ -v $VOL_BASE_DIR/hnodeb:/data \ + -v $VOL_BASE_DIR/unix:/data/unix \ --name ${BUILD_TAG}-hnodeb -d \ $DOCKER_ARGS \ $REPO_USER/osmo-hnodeb-$IMAGE_SUFFIX @@ -34,6 +39,7 @@ --ulimit core=-1 \ -e "TTCN3_PCAP_PATH=/data" \ -v $VOL_BASE_DIR/hnodeb-tester:/data \ + -v $VOL_BASE_DIR/unix:/data/unix \ --name ${BUILD_TAG}-ttcn3-hnodeb-test \ $DOCKER_ARGS \ $REPO_USER/ttcn3-hnodeb-test diff --git a/ttcn3-hnodeb-test/osmo-hnodeb.cfg b/ttcn3-hnodeb-test/osmo-hnodeb.cfg index e3925e8..7d24700 100644 --- a/ttcn3-hnodeb-test/osmo-hnodeb.cfg +++ b/ttcn3-hnodeb-test/osmo-hnodeb.cfg @@ -23,3 +23,7 @@ iuh local-ip 172.18.33.20 remote-ip 172.18.33.203 + ll-socket + path /data/unix/ll_sock + gtp + local-ip 172.18.33.20 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5b223149cbbea16e4ccd9b3874874c6366fe7969 Gerrit-Change-Number: 26544 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 16:06:46 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 15 Dec 2021 16:06:46 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 15 Dec 2021 16:06:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 16:18:55 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 15 Dec 2021 16:18:55 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 8: I hope the approach is better now. The patch is no longer using the select loop. Also only relevant osmo_fds will be registered for monitoring now. I think the amount of syscalls is now moderate as usually there will only be a hand full of TCP connections. If in the current situation the number of syscalls is still an issue then I could imagine a scheme where only one osmo_fd is updated per timer_cb call. This would distribute the syscall load. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 15 Dec 2021 16:18:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 16:23:31 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 15 Dec 2021 16:23:31 +0000 Subject: Change in osmo-ci[master]: jobs/ttcn3: disable TTCN3-centos-remsim References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26575 ) Change subject: jobs/ttcn3: disable TTCN3-centos-remsim ...................................................................... jobs/ttcn3: disable TTCN3-centos-remsim It seems that TTCN3-centos-remsim-test was disabled manually via the web UI and only got enabled recently after rolling out unrelated changes in jobs/ttcn3-testsuites.yml. The tests do not run properly with the centos version and it seems that nobody is using it, so disable them again for now. Change-Id: I4885333d63944af3510fdf0519233989808944ff --- M jobs/ttcn3-testsuites.yml 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/75/26575/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 3074d40..bcbbab5 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -260,6 +260,7 @@ - TTCN3-centos-remsim-test: blocking: "^(ttcn3|TTCN3-.*)-remsim-test.*" timer: 00 09 * * * + disabled: true - TTCN3-centos-stp-test: blocking: "^(ttcn3|TTCN3-.*)-stp-test.*" timer: 30 09 * * * @@ -304,10 +305,10 @@ - TTCN3-centos-bsc-test-sccplite-latest: blocking: "^(ttcn3|TTCN3-.*)-bsc-test.*" timer: 30 08 * * * - # No osmo-remsim packages for centos8 - #- TTCN3-centos-remsim-test-latest: - # blocking: "^(ttcn3|TTCN3-.*)-remsim-test.*" - # timer: 00 09 * * * + - TTCN3-centos-remsim-test-latest: + blocking: "^(ttcn3|TTCN3-.*)-remsim-test.*" + timer: 00 09 * * * + disabled: true - TTCN3-centos-stp-test-latest: blocking: "^(ttcn3|TTCN3-.*)-stp-test.*" timer: 30 09 * * * -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4885333d63944af3510fdf0519233989808944ff Gerrit-Change-Number: 26575 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 16:23:38 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 15 Dec 2021 16:23:38 +0000 Subject: Change in docker-playground[master]: osmo-remsim-latest: fix apt install command References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26576 ) Change subject: osmo-remsim-latest: fix apt install command ...................................................................... osmo-remsim-latest: fix apt install command Adjust to the renamed subpackage in the "apt install" command to fix: E: Unable to locate package osmo-remsim-client Related: osmo-remsim I6c634572af5036fd7f9ce1fee6d1474e06bdaa5a Related: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-remsim-test-latest/253/console Change-Id: I349111f4dd968f8e4de9598cc35aa99df221e06b --- M osmo-remsim-latest/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/76/26576/1 diff --git a/osmo-remsim-latest/Dockerfile b/osmo-remsim-latest/Dockerfile index 991c97e..ed81e3d 100644 --- a/osmo-remsim-latest/Dockerfile +++ b/osmo-remsim-latest/Dockerfile @@ -7,7 +7,7 @@ RUN apt-get update && \ apt-get install -y --no-install-recommends \ osmo-remsim-server \ - osmo-remsim-client \ + osmo-remsim-client-st2 \ osmo-remsim-bankd && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I349111f4dd968f8e4de9598cc35aa99df221e06b Gerrit-Change-Number: 26576 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 16:23:38 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 15 Dec 2021 16:23:38 +0000 Subject: Change in docker-playground[master]: osmo-remsim-latest: add logic for centos pkgs References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26577 ) Change subject: osmo-remsim-latest: add logic for centos pkgs ...................................................................... osmo-remsim-latest: add logic for centos pkgs Change-Id: If888f69fdcd349c71da06a0f0cf2b6b2f6319fb8 --- M osmo-remsim-latest/Dockerfile 1 file changed, 17 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/77/26577/1 diff --git a/osmo-remsim-latest/Dockerfile b/osmo-remsim-latest/Dockerfile index ed81e3d..c684cb8 100644 --- a/osmo-remsim-latest/Dockerfile +++ b/osmo-remsim-latest/Dockerfile @@ -3,13 +3,24 @@ ARG OSMOCOM_REPO_VERSION="latest" FROM $USER/$DISTRO-obs-$OSMOCOM_REPO_VERSION # Arguments used after FROM must be specified again +ARG DISTRO -RUN apt-get update && \ - apt-get install -y --no-install-recommends \ - osmo-remsim-server \ - osmo-remsim-client-st2 \ - osmo-remsim-bankd && \ - apt-get clean +RUN case "$DISTRO" in \ + debian*) \ + apt-get update && \ + apt-get install -y --no-install-recommends \ + osmo-remsim-server \ + osmo-remsim-client-st2 \ + osmo-remsim-bankd && \ + apt-get clean \ + ;; \ + centos*) \ + dnf install -y \ + osmo-remsim-server \ + osmo-remsim-client-st2 \ + osmo-remsim-bankd \ + ;; \ + esac #ADD respawn.sh /usr/local/bin/respawn.sh -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If888f69fdcd349c71da06a0f0cf2b6b2f6319fb8 Gerrit-Change-Number: 26577 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 16:56:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 16:56:31 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 8: Code-Review-2 (1 comment) I'm really not happy with the proposals done so far here. The presented proposals are totally invasive to the general code for no apparent reason. So in order to get a couple socket stats from a couple sockets, we interfere with the main loop with each fd being polled? this makes no sense sorry. Please come up with a system which only applies to specific sockets for which we really want this feature. https://gerrit.osmocom.org/c/libosmocore/+/26454/8/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/8/src/select.c at 169 PS8, Line 169: stats_tcp_osmo_fd_register(fd); I'm sorry but this is is crazy, I see no point in registering automatically all the fds we register in the select loop. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 15 Dec 2021 16:56:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 16:57:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 16:57:47 +0000 Subject: Change in osmo-ci[master]: jobs/ttcn3: disable TTCN3-centos-remsim In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26575 ) Change subject: jobs/ttcn3: disable TTCN3-centos-remsim ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4885333d63944af3510fdf0519233989808944ff Gerrit-Change-Number: 26575 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 16:57:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 16:57:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 16:57:54 +0000 Subject: Change in docker-playground[master]: osmo-remsim-latest: fix apt install command In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26576 ) Change subject: osmo-remsim-latest: fix apt install command ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I349111f4dd968f8e4de9598cc35aa99df221e06b Gerrit-Change-Number: 26576 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 16:57:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 16:58:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 16:58:01 +0000 Subject: Change in docker-playground[master]: osmo-remsim-latest: add logic for centos pkgs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26577 ) Change subject: osmo-remsim-latest: add logic for centos pkgs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If888f69fdcd349c71da06a0f0cf2b6b2f6319fb8 Gerrit-Change-Number: 26577 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 16:58:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:17:53 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 17:17:53 +0000 Subject: Change in docker-playground[master]: osmo-remsim-latest: fix apt install command In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26576 ) Change subject: osmo-remsim-latest: fix apt install command ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I349111f4dd968f8e4de9598cc35aa99df221e06b Gerrit-Change-Number: 26576 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 17:17:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:18:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 17:18:05 +0000 Subject: Change in docker-playground[master]: osmo-remsim-latest: add logic for centos pkgs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26577 ) Change subject: osmo-remsim-latest: add logic for centos pkgs ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If888f69fdcd349c71da06a0f0cf2b6b2f6319fb8 Gerrit-Change-Number: 26577 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 17:18:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:18:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 17:18:09 +0000 Subject: Change in docker-playground[master]: osmo-remsim-latest: fix apt install command In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26576 ) Change subject: osmo-remsim-latest: fix apt install command ...................................................................... osmo-remsim-latest: fix apt install command Adjust to the renamed subpackage in the "apt install" command to fix: E: Unable to locate package osmo-remsim-client Related: osmo-remsim I6c634572af5036fd7f9ce1fee6d1474e06bdaa5a Related: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-remsim-test-latest/253/console Change-Id: I349111f4dd968f8e4de9598cc35aa99df221e06b --- M osmo-remsim-latest/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved; Verified diff --git a/osmo-remsim-latest/Dockerfile b/osmo-remsim-latest/Dockerfile index 991c97e..ed81e3d 100644 --- a/osmo-remsim-latest/Dockerfile +++ b/osmo-remsim-latest/Dockerfile @@ -7,7 +7,7 @@ RUN apt-get update && \ apt-get install -y --no-install-recommends \ osmo-remsim-server \ - osmo-remsim-client \ + osmo-remsim-client-st2 \ osmo-remsim-bankd && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I349111f4dd968f8e4de9598cc35aa99df221e06b Gerrit-Change-Number: 26576 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:18:10 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 17:18:10 +0000 Subject: Change in docker-playground[master]: osmo-remsim-latest: add logic for centos pkgs In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26577 ) Change subject: osmo-remsim-latest: add logic for centos pkgs ...................................................................... osmo-remsim-latest: add logic for centos pkgs Change-Id: If888f69fdcd349c71da06a0f0cf2b6b2f6319fb8 --- M osmo-remsim-latest/Dockerfile 1 file changed, 17 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved; Verified diff --git a/osmo-remsim-latest/Dockerfile b/osmo-remsim-latest/Dockerfile index ed81e3d..c684cb8 100644 --- a/osmo-remsim-latest/Dockerfile +++ b/osmo-remsim-latest/Dockerfile @@ -3,13 +3,24 @@ ARG OSMOCOM_REPO_VERSION="latest" FROM $USER/$DISTRO-obs-$OSMOCOM_REPO_VERSION # Arguments used after FROM must be specified again +ARG DISTRO -RUN apt-get update && \ - apt-get install -y --no-install-recommends \ - osmo-remsim-server \ - osmo-remsim-client-st2 \ - osmo-remsim-bankd && \ - apt-get clean +RUN case "$DISTRO" in \ + debian*) \ + apt-get update && \ + apt-get install -y --no-install-recommends \ + osmo-remsim-server \ + osmo-remsim-client-st2 \ + osmo-remsim-bankd && \ + apt-get clean \ + ;; \ + centos*) \ + dnf install -y \ + osmo-remsim-server \ + osmo-remsim-client-st2 \ + osmo-remsim-bankd \ + ;; \ + esac #ADD respawn.sh /usr/local/bin/respawn.sh -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If888f69fdcd349c71da06a0f0cf2b6b2f6319fb8 Gerrit-Change-Number: 26577 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:18:34 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 17:18:34 +0000 Subject: Change in osmo-ci[master]: jobs/ttcn3: disable TTCN3-centos-remsim In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26575 ) Change subject: jobs/ttcn3: disable TTCN3-centos-remsim ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4885333d63944af3510fdf0519233989808944ff Gerrit-Change-Number: 26575 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 17:18:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:18:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 17:18:37 +0000 Subject: Change in osmo-ci[master]: jobs/ttcn3: disable TTCN3-centos-remsim In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26575 ) Change subject: jobs/ttcn3: disable TTCN3-centos-remsim ...................................................................... jobs/ttcn3: disable TTCN3-centos-remsim It seems that TTCN3-centos-remsim-test was disabled manually via the web UI and only got enabled recently after rolling out unrelated changes in jobs/ttcn3-testsuites.yml. The tests do not run properly with the centos version and it seems that nobody is using it, so disable them again for now. Change-Id: I4885333d63944af3510fdf0519233989808944ff --- M jobs/ttcn3-testsuites.yml 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 3074d40..bcbbab5 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -260,6 +260,7 @@ - TTCN3-centos-remsim-test: blocking: "^(ttcn3|TTCN3-.*)-remsim-test.*" timer: 00 09 * * * + disabled: true - TTCN3-centos-stp-test: blocking: "^(ttcn3|TTCN3-.*)-stp-test.*" timer: 30 09 * * * @@ -304,10 +305,10 @@ - TTCN3-centos-bsc-test-sccplite-latest: blocking: "^(ttcn3|TTCN3-.*)-bsc-test.*" timer: 30 08 * * * - # No osmo-remsim packages for centos8 - #- TTCN3-centos-remsim-test-latest: - # blocking: "^(ttcn3|TTCN3-.*)-remsim-test.*" - # timer: 00 09 * * * + - TTCN3-centos-remsim-test-latest: + blocking: "^(ttcn3|TTCN3-.*)-remsim-test.*" + timer: 00 09 * * * + disabled: true - TTCN3-centos-stp-test-latest: blocking: "^(ttcn3|TTCN3-.*)-stp-test.*" timer: 30 09 * * * -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4885333d63944af3510fdf0519233989808944ff Gerrit-Change-Number: 26575 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:18:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 17:18:59 +0000 Subject: Change in docker-playground[master]: Add Dockerfile for OpenBTS-UMTS In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26574 ) Change subject: Add Dockerfile for OpenBTS-UMTS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibbab5973b84047ee7654a5fb2a8e4b36e1d43847 Gerrit-Change-Number: 26574 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 15 Dec 2021 17:18:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:51:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 17:51:52 +0000 Subject: Change in docker-playground[master]: sync debian-buster-build with debian-stretch-build References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26578 ) Change subject: sync debian-buster-build with debian-stretch-build ...................................................................... sync debian-buster-build with debian-stretch-build Change-Id: I6f871613fc4e8dd069cbe8c4a0ef3d1725be8c7a --- A debian-bullseye-build/Makefile M debian-buster-build/Dockerfile 2 files changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/78/26578/1 diff --git a/debian-bullseye-build/Makefile b/debian-bullseye-build/Makefile new file mode 100644 index 0000000..8d0e10b --- /dev/null +++ b/debian-bullseye-build/Makefile @@ -0,0 +1 @@ +include ../make/Makefile diff --git a/debian-buster-build/Dockerfile b/debian-buster-build/Dockerfile index 2625e9e..87ada0f 100644 --- a/debian-buster-build/Dockerfile +++ b/debian-buster-build/Dockerfile @@ -1,7 +1,10 @@ ARG REGISTRY=docker.io -FROM ${REGISTRY}/debian:buster - -MAINTAINER Harald Welte +ARG UPSTREAM_DISTRO=debian:buster +FROM ${REGISTRY}/${UPSTREAM_DISTRO} +# Arguments used after FROM must be specified again +ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" +ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO="$OSMOCOM_REPO_MIRROR/${OSMOCOM_REPO_PATH}/nightly/Debian_10/" RUN apt-get update && \ apt-get upgrade -y && \ @@ -13,6 +16,7 @@ bison \ build-essential \ cppcheck \ + dahdi-source \ debhelper \ devscripts \ dh-autoreconf \ @@ -25,6 +29,7 @@ gcc-arm-none-eabi \ git \ git-buildpackage \ + gnupg \ libc-ares-dev \ libdbd-sqlite3 \ libdbi-dev \ @@ -50,8 +55,17 @@ pkg-config \ sqlite3 \ stow \ + telnet \ wget && \ apt-get clean # Make respawn.sh part of this image, so it can be used by other images based on it COPY .common/respawn.sh /usr/local/bin/respawn.sh + +COPY .common/Release.key /tmp/Release.key +RUN apt-key add /tmp/Release.key && \ + rm /tmp/Release.key && \ + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list + +# Invalidate cache once the repository is updated +ADD $OSMOCOM_REPO/Release /tmp/Release -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6f871613fc4e8dd069cbe8c4a0ef3d1725be8c7a Gerrit-Change-Number: 26578 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:51:53 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 17:51:53 +0000 Subject: Change in docker-playground[master]: Add debian-bullseye-build container References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26579 ) Change subject: Add debian-bullseye-build container ...................................................................... Add debian-bullseye-build container Change-Id: Ie2c75f30a5fc46979812ddfbea349e3d2fa91a7d --- A debian-bullseye-build/Dockerfile 1 file changed, 70 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/79/26579/1 diff --git a/debian-bullseye-build/Dockerfile b/debian-bullseye-build/Dockerfile new file mode 100644 index 0000000..dcea217 --- /dev/null +++ b/debian-bullseye-build/Dockerfile @@ -0,0 +1,70 @@ +ARG REGISTRY=docker.io +ARG UPSTREAM_DISTRO=debian:bullseye +FROM ${REGISTRY}/${UPSTREAM_DISTRO} +# Arguments used after FROM must be specified again +ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" +ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO="$OSMOCOM_REPO_MIRROR/${OSMOCOM_REPO_PATH}/nightly/Debian_11/" + +RUN apt-get update && \ + apt-get upgrade -y && \ + apt-get install -y --no-install-recommends \ + autoconf \ + autoconf-archive \ + autogen \ + automake \ + bison \ + build-essential \ + cppcheck \ + dahdi-source \ + debhelper \ + devscripts \ + dh-autoreconf \ + doxygen \ + flex \ + g++ \ + gawk \ + gcc \ + gcc-arm-none-eabi \ + git \ + git-buildpackage \ + gnupg \ + libc-ares-dev \ + libdbd-sqlite3 \ + libdbi-dev \ + libfftw3-dev \ + libgnutls28-dev \ + libgps-dev \ + libgsm1-dev \ + libncurses5-dev \ + libnewlib-arm-none-eabi \ + libortp-dev \ + libpcap-dev \ + libpcsclite-dev \ + libtalloc-dev \ + libtool \ + libreadline-dev \ + libsctp-dev \ + libsofia-sip-ua-glib-dev \ + libsqlite3-dev \ + libssl-dev \ + libusb-dev \ + libusb-1.0-0-dev \ + make \ + pkg-config \ + sqlite3 \ + stow \ + telnet \ + wget && \ + apt-get clean + +# Make respawn.sh part of this image, so it can be used by other images based on it +COPY .common/respawn.sh /usr/local/bin/respawn.sh + +COPY .common/Release.key /tmp/Release.key +RUN apt-key add /tmp/Release.key && \ + rm /tmp/Release.key && \ + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list + +# Invalidate cache once the repository is updated +ADD $OSMOCOM_REPO/Release /tmp/Release -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie2c75f30a5fc46979812ddfbea349e3d2fa91a7d Gerrit-Change-Number: 26579 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:51:53 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 17:51:53 +0000 Subject: Change in docker-playground[master]: debian-{buster, stretch}-*: Explicitly specify DISTRO variables References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26580 ) Change subject: debian-{buster,stretch}-*: Explicitly specify DISTRO variables ...................................................................... debian-{buster,stretch}-*: Explicitly specify DISTRO variables It seems a manual 'make' in the respective directories no longer works, as always the default distro is used as upstream reference. Let's work around this by adding DISTRO variable assignments to the respective makefiles. Change-Id: I8769d504ca7afde07d4a0ad1f03aaaec892bf576 --- M debian-buster-build/Makefile M debian-buster-erlang/Makefile M debian-buster-jenkins/Makefile M debian-stretch-build-dist/Makefile M debian-stretch-build/Makefile M debian-stretch-jenkins/Makefile M debian-stretch-obs-latest/Makefile 7 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/80/26580/1 diff --git a/debian-buster-build/Makefile b/debian-buster-build/Makefile index 8d0e10b..67066b3 100644 --- a/debian-buster-build/Makefile +++ b/debian-buster-build/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:buster +DISTRO=debian-buster include ../make/Makefile diff --git a/debian-buster-erlang/Makefile b/debian-buster-erlang/Makefile index 8d0e10b..67066b3 100644 --- a/debian-buster-erlang/Makefile +++ b/debian-buster-erlang/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:buster +DISTRO=debian-buster include ../make/Makefile diff --git a/debian-buster-jenkins/Makefile b/debian-buster-jenkins/Makefile index 8d0e10b..67066b3 100644 --- a/debian-buster-jenkins/Makefile +++ b/debian-buster-jenkins/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:buster +DISTRO=debian-buster include ../make/Makefile diff --git a/debian-stretch-build-dist/Makefile b/debian-stretch-build-dist/Makefile index 8d0e10b..10f0e20 100644 --- a/debian-stretch-build-dist/Makefile +++ b/debian-stretch-build-dist/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:stretch +DISTRO=debian-stretch include ../make/Makefile diff --git a/debian-stretch-build/Makefile b/debian-stretch-build/Makefile index 8d0e10b..10f0e20 100644 --- a/debian-stretch-build/Makefile +++ b/debian-stretch-build/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:stretch +DISTRO=debian-stretch include ../make/Makefile diff --git a/debian-stretch-jenkins/Makefile b/debian-stretch-jenkins/Makefile index 8d0e10b..10f0e20 100644 --- a/debian-stretch-jenkins/Makefile +++ b/debian-stretch-jenkins/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:stretch +DISTRO=debian-stretch include ../make/Makefile diff --git a/debian-stretch-obs-latest/Makefile b/debian-stretch-obs-latest/Makefile index 8d0e10b..3c504cd 100644 --- a/debian-stretch-obs-latest/Makefile +++ b/debian-stretch-obs-latest/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:strech +DISTRO=debian-stretch include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8769d504ca7afde07d4a0ad1f03aaaec892bf576 Gerrit-Change-Number: 26580 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:51:53 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 17:51:53 +0000 Subject: Change in docker-playground[master]: bsc-test: Reduce log verbosity of osmo-stp References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26581 ) Change subject: bsc-test: Reduce log verbosity of osmo-stp ...................................................................... bsc-test: Reduce log verbosity of osmo-stp I don't really see the point of crating 19 MBytes of logs for every ttcn3-bsc-* test run that consists mainly of debug messages about sending a message from left to right. osmo-stp is not the IUT here, but merely a part of the test fixture. Let's reduce log verbosity. Change-Id: If1d22814d89c4e52b3b7804110256d896b7cc99f --- M ttcn3-bsc-test/osmo-stp.cfg 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/81/26581/1 diff --git a/ttcn3-bsc-test/osmo-stp.cfg b/ttcn3-bsc-test/osmo-stp.cfg index 87398ac..9057564 100644 --- a/ttcn3-bsc-test/osmo-stp.cfg +++ b/ttcn3-bsc-test/osmo-stp.cfg @@ -3,7 +3,7 @@ !! ! log gsmtap 172.18.2.203 - logging level set-all debug + logging level set-all info logging filter all 1 ! log stderr @@ -24,10 +24,10 @@ logging level lstats notice logging level lgsup notice logging level loap notice - logging level lss7 debug - logging level lsccp debug - logging level lsua debug - logging level lm3ua debug + logging level lss7 info + logging level lsccp info + logging level lsua info + logging level lm3ua info logging level lmgcp notice ! line vty -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If1d22814d89c4e52b3b7804110256d896b7cc99f Gerrit-Change-Number: 26581 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:54:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 17:54:50 +0000 Subject: Change in docker-playground[master]: sync debian-buster-build with debian-stretch-build In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26578 ) Change subject: sync debian-buster-build with debian-stretch-build ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6f871613fc4e8dd069cbe8c4a0ef3d1725be8c7a Gerrit-Change-Number: 26578 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 17:54:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:55:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 17:55:17 +0000 Subject: Change in docker-playground[master]: Add debian-bullseye-build container In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26579 ) Change subject: Add debian-bullseye-build container ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie2c75f30a5fc46979812ddfbea349e3d2fa91a7d Gerrit-Change-Number: 26579 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 17:55:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:55:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 17:55:50 +0000 Subject: Change in docker-playground[master]: debian-{buster, stretch}-*: Explicitly specify DISTRO variables In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26580 ) Change subject: debian-{buster,stretch}-*: Explicitly specify DISTRO variables ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8769d504ca7afde07d4a0ad1f03aaaec892bf576 Gerrit-Change-Number: 26580 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 17:55:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 17:56:06 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 17:56:06 +0000 Subject: Change in docker-playground[master]: bsc-test: Reduce log verbosity of osmo-stp In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26581 ) Change subject: bsc-test: Reduce log verbosity of osmo-stp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If1d22814d89c4e52b3b7804110256d896b7cc99f Gerrit-Change-Number: 26581 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 17:56:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:02:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:02:44 +0000 Subject: Change in docker-playground[master]: sync debian-buster-build with debian-stretch-build In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26578 ) Change subject: sync debian-buster-build with debian-stretch-build ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6f871613fc4e8dd069cbe8c4a0ef3d1725be8c7a Gerrit-Change-Number: 26578 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 18:02:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:02:48 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:02:48 +0000 Subject: Change in docker-playground[master]: Add debian-bullseye-build container In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26579 ) Change subject: Add debian-bullseye-build container ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie2c75f30a5fc46979812ddfbea349e3d2fa91a7d Gerrit-Change-Number: 26579 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 18:02:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:04:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:04:45 +0000 Subject: Change in docker-playground[master]: sync debian-buster-build with debian-stretch-build In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26578 ) Change subject: sync debian-buster-build with debian-stretch-build ...................................................................... sync debian-buster-build with debian-stretch-build Change-Id: I6f871613fc4e8dd069cbe8c4a0ef3d1725be8c7a --- A debian-bullseye-build/Makefile M debian-buster-build/Dockerfile 2 files changed, 18 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve diff --git a/debian-bullseye-build/Makefile b/debian-bullseye-build/Makefile new file mode 100644 index 0000000..8d0e10b --- /dev/null +++ b/debian-bullseye-build/Makefile @@ -0,0 +1 @@ +include ../make/Makefile diff --git a/debian-buster-build/Dockerfile b/debian-buster-build/Dockerfile index 2625e9e..87ada0f 100644 --- a/debian-buster-build/Dockerfile +++ b/debian-buster-build/Dockerfile @@ -1,7 +1,10 @@ ARG REGISTRY=docker.io -FROM ${REGISTRY}/debian:buster - -MAINTAINER Harald Welte +ARG UPSTREAM_DISTRO=debian:buster +FROM ${REGISTRY}/${UPSTREAM_DISTRO} +# Arguments used after FROM must be specified again +ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" +ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO="$OSMOCOM_REPO_MIRROR/${OSMOCOM_REPO_PATH}/nightly/Debian_10/" RUN apt-get update && \ apt-get upgrade -y && \ @@ -13,6 +16,7 @@ bison \ build-essential \ cppcheck \ + dahdi-source \ debhelper \ devscripts \ dh-autoreconf \ @@ -25,6 +29,7 @@ gcc-arm-none-eabi \ git \ git-buildpackage \ + gnupg \ libc-ares-dev \ libdbd-sqlite3 \ libdbi-dev \ @@ -50,8 +55,17 @@ pkg-config \ sqlite3 \ stow \ + telnet \ wget && \ apt-get clean # Make respawn.sh part of this image, so it can be used by other images based on it COPY .common/respawn.sh /usr/local/bin/respawn.sh + +COPY .common/Release.key /tmp/Release.key +RUN apt-key add /tmp/Release.key && \ + rm /tmp/Release.key && \ + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list + +# Invalidate cache once the repository is updated +ADD $OSMOCOM_REPO/Release /tmp/Release -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6f871613fc4e8dd069cbe8c4a0ef3d1725be8c7a Gerrit-Change-Number: 26578 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:04:46 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:04:46 +0000 Subject: Change in docker-playground[master]: Add debian-bullseye-build container In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26579 ) Change subject: Add debian-bullseye-build container ...................................................................... Add debian-bullseye-build container Change-Id: Ie2c75f30a5fc46979812ddfbea349e3d2fa91a7d --- A debian-bullseye-build/Dockerfile 1 file changed, 70 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve diff --git a/debian-bullseye-build/Dockerfile b/debian-bullseye-build/Dockerfile new file mode 100644 index 0000000..dcea217 --- /dev/null +++ b/debian-bullseye-build/Dockerfile @@ -0,0 +1,70 @@ +ARG REGISTRY=docker.io +ARG UPSTREAM_DISTRO=debian:bullseye +FROM ${REGISTRY}/${UPSTREAM_DISTRO} +# Arguments used after FROM must be specified again +ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" +ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO="$OSMOCOM_REPO_MIRROR/${OSMOCOM_REPO_PATH}/nightly/Debian_11/" + +RUN apt-get update && \ + apt-get upgrade -y && \ + apt-get install -y --no-install-recommends \ + autoconf \ + autoconf-archive \ + autogen \ + automake \ + bison \ + build-essential \ + cppcheck \ + dahdi-source \ + debhelper \ + devscripts \ + dh-autoreconf \ + doxygen \ + flex \ + g++ \ + gawk \ + gcc \ + gcc-arm-none-eabi \ + git \ + git-buildpackage \ + gnupg \ + libc-ares-dev \ + libdbd-sqlite3 \ + libdbi-dev \ + libfftw3-dev \ + libgnutls28-dev \ + libgps-dev \ + libgsm1-dev \ + libncurses5-dev \ + libnewlib-arm-none-eabi \ + libortp-dev \ + libpcap-dev \ + libpcsclite-dev \ + libtalloc-dev \ + libtool \ + libreadline-dev \ + libsctp-dev \ + libsofia-sip-ua-glib-dev \ + libsqlite3-dev \ + libssl-dev \ + libusb-dev \ + libusb-1.0-0-dev \ + make \ + pkg-config \ + sqlite3 \ + stow \ + telnet \ + wget && \ + apt-get clean + +# Make respawn.sh part of this image, so it can be used by other images based on it +COPY .common/respawn.sh /usr/local/bin/respawn.sh + +COPY .common/Release.key /tmp/Release.key +RUN apt-key add /tmp/Release.key && \ + rm /tmp/Release.key && \ + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list + +# Invalidate cache once the repository is updated +ADD $OSMOCOM_REPO/Release /tmp/Release -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie2c75f30a5fc46979812ddfbea349e3d2fa91a7d Gerrit-Change-Number: 26579 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:05:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:05:13 +0000 Subject: Change in docker-playground[master]: debian-{buster, stretch}-*: Explicitly specify DISTRO variables In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26580 ) Change subject: debian-{buster,stretch}-*: Explicitly specify DISTRO variables ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8769d504ca7afde07d4a0ad1f03aaaec892bf576 Gerrit-Change-Number: 26580 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 18:05:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:05:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:05:17 +0000 Subject: Change in docker-playground[master]: bsc-test: Reduce log verbosity of osmo-stp In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26581 ) Change subject: bsc-test: Reduce log verbosity of osmo-stp ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If1d22814d89c4e52b3b7804110256d896b7cc99f Gerrit-Change-Number: 26581 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 18:05:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:05:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:05:19 +0000 Subject: Change in docker-playground[master]: debian-{buster, stretch}-*: Explicitly specify DISTRO variables In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26580 ) Change subject: debian-{buster,stretch}-*: Explicitly specify DISTRO variables ...................................................................... debian-{buster,stretch}-*: Explicitly specify DISTRO variables It seems a manual 'make' in the respective directories no longer works, as always the default distro is used as upstream reference. Let's work around this by adding DISTRO variable assignments to the respective makefiles. Change-Id: I8769d504ca7afde07d4a0ad1f03aaaec892bf576 --- M debian-buster-build/Makefile M debian-buster-erlang/Makefile M debian-buster-jenkins/Makefile M debian-stretch-build-dist/Makefile M debian-stretch-build/Makefile M debian-stretch-jenkins/Makefile M debian-stretch-obs-latest/Makefile 7 files changed, 14 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve diff --git a/debian-buster-build/Makefile b/debian-buster-build/Makefile index 8d0e10b..67066b3 100644 --- a/debian-buster-build/Makefile +++ b/debian-buster-build/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:buster +DISTRO=debian-buster include ../make/Makefile diff --git a/debian-buster-erlang/Makefile b/debian-buster-erlang/Makefile index 8d0e10b..67066b3 100644 --- a/debian-buster-erlang/Makefile +++ b/debian-buster-erlang/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:buster +DISTRO=debian-buster include ../make/Makefile diff --git a/debian-buster-jenkins/Makefile b/debian-buster-jenkins/Makefile index 8d0e10b..67066b3 100644 --- a/debian-buster-jenkins/Makefile +++ b/debian-buster-jenkins/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:buster +DISTRO=debian-buster include ../make/Makefile diff --git a/debian-stretch-build-dist/Makefile b/debian-stretch-build-dist/Makefile index 8d0e10b..10f0e20 100644 --- a/debian-stretch-build-dist/Makefile +++ b/debian-stretch-build-dist/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:stretch +DISTRO=debian-stretch include ../make/Makefile diff --git a/debian-stretch-build/Makefile b/debian-stretch-build/Makefile index 8d0e10b..10f0e20 100644 --- a/debian-stretch-build/Makefile +++ b/debian-stretch-build/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:stretch +DISTRO=debian-stretch include ../make/Makefile diff --git a/debian-stretch-jenkins/Makefile b/debian-stretch-jenkins/Makefile index 8d0e10b..10f0e20 100644 --- a/debian-stretch-jenkins/Makefile +++ b/debian-stretch-jenkins/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:stretch +DISTRO=debian-stretch include ../make/Makefile diff --git a/debian-stretch-obs-latest/Makefile b/debian-stretch-obs-latest/Makefile index 8d0e10b..3c504cd 100644 --- a/debian-stretch-obs-latest/Makefile +++ b/debian-stretch-obs-latest/Makefile @@ -1 +1,3 @@ +UPSTREAM_DISTRO=debian:strech +DISTRO=debian-stretch include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8769d504ca7afde07d4a0ad1f03aaaec892bf576 Gerrit-Change-Number: 26580 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:05:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:05:20 +0000 Subject: Change in docker-playground[master]: bsc-test: Reduce log verbosity of osmo-stp In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26581 ) Change subject: bsc-test: Reduce log verbosity of osmo-stp ...................................................................... bsc-test: Reduce log verbosity of osmo-stp I don't really see the point of crating 19 MBytes of logs for every ttcn3-bsc-* test run that consists mainly of debug messages about sending a message from left to right. osmo-stp is not the IUT here, but merely a part of the test fixture. Let's reduce log verbosity. Change-Id: If1d22814d89c4e52b3b7804110256d896b7cc99f --- M ttcn3-bsc-test/osmo-stp.cfg 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve diff --git a/ttcn3-bsc-test/osmo-stp.cfg b/ttcn3-bsc-test/osmo-stp.cfg index 87398ac..9057564 100644 --- a/ttcn3-bsc-test/osmo-stp.cfg +++ b/ttcn3-bsc-test/osmo-stp.cfg @@ -3,7 +3,7 @@ !! ! log gsmtap 172.18.2.203 - logging level set-all debug + logging level set-all info logging filter all 1 ! log stderr @@ -24,10 +24,10 @@ logging level lstats notice logging level lgsup notice logging level loap notice - logging level lss7 debug - logging level lsccp debug - logging level lsua debug - logging level lm3ua debug + logging level lss7 info + logging level lsccp info + logging level lsua info + logging level lm3ua info logging level lmgcp notice ! line vty -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26581 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If1d22814d89c4e52b3b7804110256d896b7cc99f Gerrit-Change-Number: 26581 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:11:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:11:01 +0000 Subject: Change in docker-playground[master]: titan: move from debian-stetch-titan to debian-bullseye-titan References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26582 ) Change subject: titan: move from debian-stetch-titan to debian-bullseye-titan ...................................................................... titan: move from debian-stetch-titan to debian-bullseye-titan So far we were executing all our TTCN-3 tests from a container image with Debian stretch (9) plus a custom more recent eclipse-titan package from the osmocom feed. Let's update the container base OS from stretch (9) to bullseye (11) while using the same packaged eclipse-titan version (8.0.0) for running the tests. So this should be a low-risk change, as titan runtime remains identical. I've executed all test suites locally and couldn't see any regressions. Related: OS#4969 Change-Id: Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f --- R debian-bullseye-titan/.release R debian-bullseye-titan/Dockerfile R debian-bullseye-titan/Makefile R debian-bullseye-titan/pipework R debian-bullseye-titan/ttcn3-docker-prepare.sh R debian-bullseye-titan/ttcn3-docker-run.sh M jenkins-common.sh M ttcn3-bsc-test-vamos/Dockerfile M ttcn3-bsc-test/Dockerfile M ttcn3-bscnat-test/Dockerfile M ttcn3-bts-test/Dockerfile M ttcn3-cbc-test/Dockerfile M ttcn3-fr-test/Dockerfile M ttcn3-gbproxy-test/Dockerfile M ttcn3-ggsn-test/Dockerfile M ttcn3-hlr-test/Dockerfile M ttcn3-hnodeb-test/Dockerfile M ttcn3-mgw-test/Dockerfile M ttcn3-msc-test/Dockerfile M ttcn3-nitb-sysinfo/Dockerfile M ttcn3-ns-test/Dockerfile M ttcn3-pcap-client-test/Dockerfile M ttcn3-pcu-test/Dockerfile M ttcn3-remsim-test/Dockerfile M ttcn3-sccp-test/Dockerfile M ttcn3-sgsn-test/Dockerfile M ttcn3-sip-test/Dockerfile M ttcn3-smlc-test/Dockerfile M ttcn3-stp-test/Dockerfile 29 files changed, 26 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/82/26582/1 diff --git a/debian-stretch-titan/.release b/debian-bullseye-titan/.release similarity index 100% rename from debian-stretch-titan/.release rename to debian-bullseye-titan/.release diff --git a/debian-stretch-titan/Dockerfile b/debian-bullseye-titan/Dockerfile similarity index 96% rename from debian-stretch-titan/Dockerfile rename to debian-bullseye-titan/Dockerfile index d348914..bf99534 100644 --- a/debian-stretch-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -1,12 +1,12 @@ ARG REGISTRY=docker.io -ARG UPSTREAM_DISTRO=debian:stretch +ARG UPSTREAM_DISTRO=debian:bullseye FROM ${REGISTRY}/${UPSTREAM_DISTRO} # Arguments used after FROM must be specified again ARG OSMOCOM_REPO_TESTSUITE_MIRROR="http://download.opensuse.org" MAINTAINER Harald Welte -ARG OSMOCOM_REPO="$OSMOCOM_REPO_TESTSUITE_MIRROR/repositories/network:/osmocom:/latest/Debian_9.0/" +ARG OSMOCOM_REPO="$OSMOCOM_REPO_TESTSUITE_MIRROR/repositories/network:/osmocom:/latest/Debian_11/" RUN apt-get update && apt-get install -y \ gnupg diff --git a/debian-stretch-titan/Makefile b/debian-bullseye-titan/Makefile similarity index 100% rename from debian-stretch-titan/Makefile rename to debian-bullseye-titan/Makefile diff --git a/debian-stretch-titan/pipework b/debian-bullseye-titan/pipework similarity index 100% rename from debian-stretch-titan/pipework rename to debian-bullseye-titan/pipework diff --git a/debian-stretch-titan/ttcn3-docker-prepare.sh b/debian-bullseye-titan/ttcn3-docker-prepare.sh similarity index 100% rename from debian-stretch-titan/ttcn3-docker-prepare.sh rename to debian-bullseye-titan/ttcn3-docker-prepare.sh diff --git a/debian-stretch-titan/ttcn3-docker-run.sh b/debian-bullseye-titan/ttcn3-docker-run.sh similarity index 100% rename from debian-stretch-titan/ttcn3-docker-run.sh rename to debian-bullseye-titan/ttcn3-docker-run.sh diff --git a/jenkins-common.sh b/jenkins-common.sh index 9373076..9fcf02f 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -21,7 +21,7 @@ osmo-*-centos8) echo "centos8-build" ;; osmo-*-latest) echo "debian-stretch-obs-latest" ;; osmo-*) echo "debian-stretch-build" ;; - ttcn3-*) echo "debian-stretch-titan" ;; + ttcn3-*) echo "debian-bullseye-titan" ;; esac } @@ -135,7 +135,7 @@ # they are up-to-date. if [ "$REGISTRY_HOST" = "registry.osmocom.org" ]; then case "$i" in - debian-stretch-titan) + debian-bullseye-titan) docker pull "$REGISTRY_HOST/$USER/$i" continue ;; diff --git a/ttcn3-bsc-test-vamos/Dockerfile b/ttcn3-bsc-test-vamos/Dockerfile index 1923c38..a29e000 100644 --- a/ttcn3-bsc-test-vamos/Dockerfile +++ b/ttcn3-bsc-test-vamos/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-bsc-test/Dockerfile b/ttcn3-bsc-test/Dockerfile index 1923c38..a29e000 100644 --- a/ttcn3-bsc-test/Dockerfile +++ b/ttcn3-bsc-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-bscnat-test/Dockerfile b/ttcn3-bscnat-test/Dockerfile index 50ca926..15e7727 100644 --- a/ttcn3-bscnat-test/Dockerfile +++ b/ttcn3-bscnat-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-bts-test/Dockerfile b/ttcn3-bts-test/Dockerfile index 8ac7cb8..d676bf0 100644 --- a/ttcn3-bts-test/Dockerfile +++ b/ttcn3-bts-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-cbc-test/Dockerfile b/ttcn3-cbc-test/Dockerfile index 8eba25f..7c1e6c5 100644 --- a/ttcn3-cbc-test/Dockerfile +++ b/ttcn3-cbc-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-fr-test/Dockerfile b/ttcn3-fr-test/Dockerfile index 4a70c12..11589f6 100644 --- a/ttcn3-fr-test/Dockerfile +++ b/ttcn3-fr-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-gbproxy-test/Dockerfile b/ttcn3-gbproxy-test/Dockerfile index 71494d9..a2216b2 100644 --- a/ttcn3-gbproxy-test/Dockerfile +++ b/ttcn3-gbproxy-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-ggsn-test/Dockerfile b/ttcn3-ggsn-test/Dockerfile index d42ac3e..252e893 100644 --- a/ttcn3-ggsn-test/Dockerfile +++ b/ttcn3-ggsn-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-hlr-test/Dockerfile b/ttcn3-hlr-test/Dockerfile index 8480288..ac5ca4f 100644 --- a/ttcn3-hlr-test/Dockerfile +++ b/ttcn3-hlr-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-hnodeb-test/Dockerfile b/ttcn3-hnodeb-test/Dockerfile index 9659dd1..2071cab 100644 --- a/ttcn3-hnodeb-test/Dockerfile +++ b/ttcn3-hnodeb-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-mgw-test/Dockerfile b/ttcn3-mgw-test/Dockerfile index 087dc09..c8eeb2b 100644 --- a/ttcn3-mgw-test/Dockerfile +++ b/ttcn3-mgw-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-msc-test/Dockerfile b/ttcn3-msc-test/Dockerfile index 05610a4..8c67bbf 100644 --- a/ttcn3-msc-test/Dockerfile +++ b/ttcn3-msc-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-nitb-sysinfo/Dockerfile b/ttcn3-nitb-sysinfo/Dockerfile index 45bf69e..3155271 100644 --- a/ttcn3-nitb-sysinfo/Dockerfile +++ b/ttcn3-nitb-sysinfo/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-ns-test/Dockerfile b/ttcn3-ns-test/Dockerfile index 850046d..b94de1b 100644 --- a/ttcn3-ns-test/Dockerfile +++ b/ttcn3-ns-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-pcap-client-test/Dockerfile b/ttcn3-pcap-client-test/Dockerfile index 2a3799f..9e66326 100644 --- a/ttcn3-pcap-client-test/Dockerfile +++ b/ttcn3-pcap-client-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-pcu-test/Dockerfile b/ttcn3-pcu-test/Dockerfile index e42bca1..b7cb21a 100644 --- a/ttcn3-pcu-test/Dockerfile +++ b/ttcn3-pcu-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-remsim-test/Dockerfile b/ttcn3-remsim-test/Dockerfile index caa6da1..e94c55c 100644 --- a/ttcn3-remsim-test/Dockerfile +++ b/ttcn3-remsim-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-sccp-test/Dockerfile b/ttcn3-sccp-test/Dockerfile index 708a72f..f43a5dd 100644 --- a/ttcn3-sccp-test/Dockerfile +++ b/ttcn3-sccp-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-sgsn-test/Dockerfile b/ttcn3-sgsn-test/Dockerfile index 333b5ed..b581b43 100644 --- a/ttcn3-sgsn-test/Dockerfile +++ b/ttcn3-sgsn-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-sip-test/Dockerfile b/ttcn3-sip-test/Dockerfile index 1324ac0..7dd4756 100644 --- a/ttcn3-sip-test/Dockerfile +++ b/ttcn3-sip-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-smlc-test/Dockerfile b/ttcn3-smlc-test/Dockerfile index 5d27ceb..0d5b0da 100644 --- a/ttcn3-smlc-test/Dockerfile +++ b/ttcn3-smlc-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-stp-test/Dockerfile b/ttcn3-stp-test/Dockerfile index e36935b..7808704 100644 --- a/ttcn3-stp-test/Dockerfile +++ b/ttcn3-stp-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f Gerrit-Change-Number: 26582 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:11:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:11:01 +0000 Subject: Change in docker-playground[master]: Switch ttcn3-* master tests from Debian stretch to bullseys References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26583 ) Change subject: Switch ttcn3-* master tests from Debian stretch to bullseys ...................................................................... Switch ttcn3-* master tests from Debian stretch to bullseys So far we were using ancient Debian 9 (stretch) for our IUT containers. Let's upgrade that to Debian 11 (bullseye). Related: OS#4969 Change-Id: Ic6bece9cb695e6eccfcb1e83fdbf1048724a3cf9 --- M jenkins-common.sh M make/Makefile 2 files changed, 13 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/83/26583/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index 9fcf02f..1fc9e20 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -20,7 +20,7 @@ osmo-*-centos7) echo "centos7-build" ;; osmo-*-centos8) echo "centos8-build" ;; osmo-*-latest) echo "debian-stretch-obs-latest" ;; - osmo-*) echo "debian-stretch-build" ;; + osmo-*) echo "debian-bullseye-build" ;; ttcn3-*) echo "debian-bullseye-titan" ;; esac } @@ -31,7 +31,8 @@ osmo-*-centos8) echo "centos8" ;; centos7-*) echo "centos7" ;; centos8-*) echo "centos8" ;; - *) echo "debian-stretch" ;; + debian-buster-*) echo "debian-buster" ;; + *) echo "debian-bullseye" ;; esac } @@ -42,7 +43,10 @@ centos7-*) echo "centos:centos7" ;; centos8-*) echo "centos:centos8" ;; debian10-*) echo "debian:buster" ;; - *) echo "debian:stretch" ;; + debian11-*) echo "debian:bullseye" ;; + debian-stretch-*) echo "debian:stetch" ;; + debian-buster-*) echo "debian:buster" ;; + *) echo "debian:bullseye" ;; esac } @@ -109,7 +113,7 @@ } # Make sure required images are available and build them if necessary. -# $*: image names (e.g. "debian-stretch-build", "osmo-mgw-master", "osmo-mgw-master-centos8") +# $*: image names (e.g. "debian-bullseye-build", "osmo-mgw-master", "osmo-mgw-master-centos8") # The images are automatically built from the Dockerfile of the subdir of # the same name. If there is a distribution name at the end of the image # name (e.g. osmo-mgw-master-centos8), it gets removed from the subdir @@ -232,8 +236,8 @@ } fix_perms() { - if ! docker_image_exists "debian-stretch-build"; then - docker_images_require "debian-stretch-build" + if ! docker_image_exists "debian-bullseye-build"; then + docker_images_require "debian-bullseye-build" fi echo Fixing permissions @@ -241,7 +245,7 @@ -v $VOL_BASE_DIR:/data \ -v $CACHE_DIR:/cache \ --name ${BUILD_TAG}-cleaner \ - $REPO_USER/debian-stretch-build \ + $REPO_USER/debian-bullseye-build \ chmod -R a+rX /data/ /cache/ } diff --git a/make/Makefile b/make/Makefile index 416fc18..8bd360d 100644 --- a/make/Makefile +++ b/make/Makefile @@ -36,8 +36,8 @@ OSMO_SIP_BRANCH?=master OSMO_STP_BRANCH?=master PULL?= -UPSTREAM_DISTRO?=debian:stretch -DISTRO?=debian-stretch +UPSTREAM_DISTRO?=debian:bullseye +DISTRO?=debian-bullseye # Full OBS repository mirror consists of: # ${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/${OSMOCOM_REPO_VERSION} -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26583 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic6bece9cb695e6eccfcb1e83fdbf1048724a3cf9 Gerrit-Change-Number: 26583 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:48:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:48:20 +0000 Subject: Change in docker-playground[master]: titan: move from debian-stetch-titan to debian-bullseye-titan In-Reply-To: References: Message-ID: Hello osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/26582 to look at the new patch set (#2). Change subject: titan: move from debian-stetch-titan to debian-bullseye-titan ...................................................................... titan: move from debian-stetch-titan to debian-bullseye-titan So far we were executing all our TTCN-3 tests from a container image with Debian stretch (9) plus a custom more recent eclipse-titan package from the osmocom feed. Let's update the container base OS from stretch (9) to bullseye (11) while using the same packaged eclipse-titan version (8.0.0) for running the tests. So this should be a low-risk change, as titan runtime remains identical. I've executed all test suites locally and couldn't see any regressions. Related: OS#4969 Change-Id: Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f --- R debian-bullseye-titan/.release R debian-bullseye-titan/Dockerfile R debian-bullseye-titan/Makefile R debian-bullseye-titan/pipework R debian-bullseye-titan/ttcn3-docker-prepare.sh R debian-bullseye-titan/ttcn3-docker-run.sh M jenkins-common.sh M nplab-m3ua-test/jenkins.sh M ttcn3-bsc-test-vamos/Dockerfile M ttcn3-bsc-test/Dockerfile M ttcn3-bscnat-test/Dockerfile M ttcn3-bts-test/Dockerfile M ttcn3-cbc-test/Dockerfile M ttcn3-fr-test/Dockerfile M ttcn3-gbproxy-test/Dockerfile M ttcn3-ggsn-test/Dockerfile M ttcn3-hlr-test/Dockerfile M ttcn3-hnodeb-test/Dockerfile M ttcn3-mgw-test/Dockerfile M ttcn3-msc-test/Dockerfile M ttcn3-nitb-sysinfo/Dockerfile M ttcn3-ns-test/Dockerfile M ttcn3-pcap-client-test/Dockerfile M ttcn3-pcu-test/Dockerfile M ttcn3-remsim-test/Dockerfile M ttcn3-sccp-test/Dockerfile M ttcn3-sgsn-test/Dockerfile M ttcn3-sip-test/Dockerfile M ttcn3-smlc-test/Dockerfile M ttcn3-stp-test/Dockerfile 30 files changed, 27 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/82/26582/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f Gerrit-Change-Number: 26582 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:48:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:48:20 +0000 Subject: Change in docker-playground[master]: Switch ttcn3-* master tests from Debian stretch to bullseys In-Reply-To: References: Message-ID: Hello osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/26583 to look at the new patch set (#2). Change subject: Switch ttcn3-* master tests from Debian stretch to bullseys ...................................................................... Switch ttcn3-* master tests from Debian stretch to bullseys So far we were using ancient Debian 9 (stretch) for our IUT containers. Let's upgrade that to Debian 11 (bullseye). Related: OS#4969 Change-Id: Ic6bece9cb695e6eccfcb1e83fdbf1048724a3cf9 --- M jenkins-common.sh M make/Makefile 2 files changed, 13 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/83/26583/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26583 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic6bece9cb695e6eccfcb1e83fdbf1048724a3cf9 Gerrit-Change-Number: 26583 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:48:22 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 18:48:22 +0000 Subject: Change in docker-playground[master]: nplab-*test: Fix printing of junit on stdout References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26584 ) Change subject: nplab-*test: Fix printing of junit on stdout ...................................................................... nplab-*test: Fix printing of junit on stdout Before this patch the printing of the junit.xml to stdout fails: + collect_logs + cat '/tmp/tmp.CzafJpQyw8/*/junit-*.log' cat: '/tmp/tmp.CzafJpQyw8/*/junit-*.log': No such file or directory + true Change-Id: I600d3bdb3de23ef6f381cd5b81e2b851856b2b9b --- M nplab-m3ua-test/jenkins.sh M nplab-sua-test/jenkins.sh 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/84/26584/1 diff --git a/nplab-m3ua-test/jenkins.sh b/nplab-m3ua-test/jenkins.sh index 94753a2..c4250b0 100755 --- a/nplab-m3ua-test/jenkins.sh +++ b/nplab-m3ua-test/jenkins.sh @@ -36,4 +36,4 @@ --ulimit core=-1 \ -v $VOL_BASE_DIR/m3ua-tester:/data \ --name ${BUILD_TAG}-m3ua-test \ - $REPO_USER/nplab-m3ua-test > $VOL_BASE_DIR/junit-xml-m3ua.log + $REPO_USER/nplab-m3ua-test > $VOL_BASE_DIR/m3ua-tester/junit-xml-m3ua.log diff --git a/nplab-sua-test/jenkins.sh b/nplab-sua-test/jenkins.sh index eeb0f06..0e59cd4 100755 --- a/nplab-sua-test/jenkins.sh +++ b/nplab-sua-test/jenkins.sh @@ -36,4 +36,4 @@ --ulimit core=-1 \ -v $VOL_BASE_DIR/sua-tester:/data \ --name ${BUILD_TAG}-sua-test \ - $REPO_USER/nplab-sua-test > $VOL_BASE_DIR/junit-xml-sua.log + $REPO_USER/nplab-sua-test > $VOL_BASE_DIR/sua-tester/junit-xml-sua.log -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26584 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I600d3bdb3de23ef6f381cd5b81e2b851856b2b9b Gerrit-Change-Number: 26584 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:57:28 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 18:57:28 +0000 Subject: Change in docker-playground[master]: Switch ttcn3-* master tests from Debian stretch to bullseys In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26583 ) Change subject: Switch ttcn3-* master tests from Debian stretch to bullseys ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26583 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic6bece9cb695e6eccfcb1e83fdbf1048724a3cf9 Gerrit-Change-Number: 26583 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 18:57:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:58:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 18:58:26 +0000 Subject: Change in docker-playground[master]: titan: move from debian-stetch-titan to debian-bullseye-titan In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26582 ) Change subject: titan: move from debian-stetch-titan to debian-bullseye-titan ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f Gerrit-Change-Number: 26582 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 18:58:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 18:58:59 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 18:58:59 +0000 Subject: Change in docker-playground[master]: nplab-*test: Fix printing of junit on stdout In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26584 ) Change subject: nplab-*test: Fix printing of junit on stdout ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26584 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I600d3bdb3de23ef6f381cd5b81e2b851856b2b9b Gerrit-Change-Number: 26584 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 18:58:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 19:35:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 19:35:37 +0000 Subject: Change in docker-playground[master]: nplab: Switch from stretch to buster References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26585 ) Change subject: nplab: Switch from stretch to buster ...................................................................... nplab: Switch from stretch to buster The test suites require guile-2.0 so we have to stay with buster and cannot upgrade to bullseye (guile-3.0 only). Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be --- M nplab-m3ua-test/Dockerfile M nplab-m3ua-test/jenkins.sh M nplab-sua-test/jenkins.sh M sigtran-tests/Dockerfile 4 files changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/85/26585/1 diff --git a/nplab-m3ua-test/Dockerfile b/nplab-m3ua-test/Dockerfile index ba5d17d..a7891e1 100644 --- a/nplab-m3ua-test/Dockerfile +++ b/nplab-m3ua-test/Dockerfile @@ -6,7 +6,8 @@ RUN cd /tmp && git clone git://git.osmocom.org/nplab/m3ua-testtool ADD http://git.osmocom.org/nplab/m3ua-testtool/patch /tmp/commit RUN cd /tmp/m3ua-testtool && \ - git pull && \ + git fetch && \ + git checkout -f laforge/python3 && \ cp runtest-junitxml.py /usr/local/bin/ COPY dotguile /root/.guile diff --git a/nplab-m3ua-test/jenkins.sh b/nplab-m3ua-test/jenkins.sh index c4250b0..87035f3 100755 --- a/nplab-m3ua-test/jenkins.sh +++ b/nplab-m3ua-test/jenkins.sh @@ -3,7 +3,7 @@ . ../jenkins-common.sh IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" docker_images_require \ - "debian-stretch-build" \ + "debian-buster-build" \ "sigtran-tests" \ "osmo-stp-$IMAGE_SUFFIX" \ "debian-bullseye-titan" \ diff --git a/nplab-sua-test/jenkins.sh b/nplab-sua-test/jenkins.sh index 0e59cd4..4be00c8 100755 --- a/nplab-sua-test/jenkins.sh +++ b/nplab-sua-test/jenkins.sh @@ -3,9 +3,9 @@ . ../jenkins-common.sh IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" docker_images_require \ - "debian-stretch-build" \ + "debian-buster-build" \ "osmo-stp-$IMAGE_SUFFIX" \ - "debian-stretch-titan" \ + "debian-bullseye-titan" \ "sigtran-tests" \ "nplab-sua-test" diff --git a/sigtran-tests/Dockerfile b/sigtran-tests/Dockerfile index ebfb027..d7f7206 100644 --- a/sigtran-tests/Dockerfile +++ b/sigtran-tests/Dockerfile @@ -1,13 +1,13 @@ ARG USER -FROM $USER/debian-stretch-build +FROM $USER/debian-buster-build MAINTAINER Harald Welte RUN apt-get update && apt-get -y install \ guile-2.0 guile-2.0-dev gnulib tcsh \ - python python-pip + python3 python3-pip -RUN pip install junit-xml +RUN pip3 install junit-xml RUN cd /tmp && git clone https://github.com/nplab/guile-sctp && \ cd guile-sctp && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be Gerrit-Change-Number: 26585 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 19:35:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 19:35:57 +0000 Subject: Change in docker-playground[master]: nplab: Switch from stretch to buster In-Reply-To: References: Message-ID: Hello osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/26585 to look at the new patch set (#2). Change subject: nplab: Switch from stretch to buster ...................................................................... nplab: Switch from stretch to buster The test suites require guile-2.0 so we have to stay with buster and cannot upgrade to bullseye (guile-3.0 only). Related: OS#4969 Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be --- M nplab-m3ua-test/Dockerfile M nplab-m3ua-test/jenkins.sh M nplab-sua-test/jenkins.sh M sigtran-tests/Dockerfile 4 files changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/85/26585/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be Gerrit-Change-Number: 26585 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 19:46:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 15 Dec 2021 19:46:07 +0000 Subject: Change in docker-playground[master]: nplab: Switch from stretch to buster In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26585 ) Change subject: nplab: Switch from stretch to buster ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be Gerrit-Change-Number: 26585 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 19:46:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 20:08:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 20:08:04 +0000 Subject: Change in docker-playground[master]: nplab-*test: Fix printing of junit on stdout In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26584 ) Change subject: nplab-*test: Fix printing of junit on stdout ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26584 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I600d3bdb3de23ef6f381cd5b81e2b851856b2b9b Gerrit-Change-Number: 26584 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 20:08:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 20:08:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 20:08:17 +0000 Subject: Change in docker-playground[master]: nplab-*test: Fix printing of junit on stdout In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26584 ) Change subject: nplab-*test: Fix printing of junit on stdout ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26584 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I600d3bdb3de23ef6f381cd5b81e2b851856b2b9b Gerrit-Change-Number: 26584 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 15 Dec 2021 20:08:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 20:08:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 20:08:19 +0000 Subject: Change in docker-playground[master]: nplab-*test: Fix printing of junit on stdout In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26584 ) Change subject: nplab-*test: Fix printing of junit on stdout ...................................................................... nplab-*test: Fix printing of junit on stdout Before this patch the printing of the junit.xml to stdout fails: + collect_logs + cat '/tmp/tmp.CzafJpQyw8/*/junit-*.log' cat: '/tmp/tmp.CzafJpQyw8/*/junit-*.log': No such file or directory + true Change-Id: I600d3bdb3de23ef6f381cd5b81e2b851856b2b9b --- M nplab-m3ua-test/jenkins.sh M nplab-sua-test/jenkins.sh 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve diff --git a/nplab-m3ua-test/jenkins.sh b/nplab-m3ua-test/jenkins.sh index 1e9a248..3be308a 100755 --- a/nplab-m3ua-test/jenkins.sh +++ b/nplab-m3ua-test/jenkins.sh @@ -36,4 +36,4 @@ --ulimit core=-1 \ -v $VOL_BASE_DIR/m3ua-tester:/data \ --name ${BUILD_TAG}-m3ua-test \ - $REPO_USER/nplab-m3ua-test > $VOL_BASE_DIR/junit-xml-m3ua.log + $REPO_USER/nplab-m3ua-test > $VOL_BASE_DIR/m3ua-tester/junit-xml-m3ua.log diff --git a/nplab-sua-test/jenkins.sh b/nplab-sua-test/jenkins.sh index eeb0f06..0e59cd4 100755 --- a/nplab-sua-test/jenkins.sh +++ b/nplab-sua-test/jenkins.sh @@ -36,4 +36,4 @@ --ulimit core=-1 \ -v $VOL_BASE_DIR/sua-tester:/data \ --name ${BUILD_TAG}-sua-test \ - $REPO_USER/nplab-sua-test > $VOL_BASE_DIR/junit-xml-sua.log + $REPO_USER/nplab-sua-test > $VOL_BASE_DIR/sua-tester/junit-xml-sua.log -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26584 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I600d3bdb3de23ef6f381cd5b81e2b851856b2b9b Gerrit-Change-Number: 26584 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 20:09:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 20:09:06 +0000 Subject: Change in docker-playground[master]: nplab: Switch from stretch to buster In-Reply-To: References: Message-ID: Hello osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/26585 to look at the new patch set (#3). Change subject: nplab: Switch from stretch to buster ...................................................................... nplab: Switch from stretch to buster The test suites require guile-2.0 so we have to stay with buster and cannot upgrade to bullseye (guile-3.0 only). Related: OS#4969 Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be --- M nplab-m3ua-test/Dockerfile M nplab-m3ua-test/jenkins.sh M nplab-sua-test/Dockerfile M nplab-sua-test/jenkins.sh M sigtran-tests/Dockerfile 5 files changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/85/26585/3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be Gerrit-Change-Number: 26585 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 20:09:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 20:09:07 +0000 Subject: Change in docker-playground[master]: sctp-test: Upgrade to bullseye References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26586 ) Change subject: sctp-test: Upgrade to bullseye ...................................................................... sctp-test: Upgrade to bullseye Change-Id: I681802fd779530878c2d2358ebf90b8e2adb4870 --- M sctp-test/Dockerfile 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/86/26586/1 diff --git a/sctp-test/Dockerfile b/sctp-test/Dockerfile index 79df64d..398087e 100644 --- a/sctp-test/Dockerfile +++ b/sctp-test/Dockerfile @@ -1,5 +1,5 @@ ARG USER -FROM $USER/debian-stretch-build +FROM $USER/debian-bullseye-build MAINTAINER Harald Welte @@ -20,7 +20,7 @@ # Commit from 2018-08-28 RUN git clone https://github.com/nplab/packetdrill && \ cd packetdrill && \ - git checkout 89bb4f35393187d0d34a84170de529d688421be7 && \ + git checkout c6810864095558f5df77e9f06941191cbd41d7e2 && \ git am /tmp/*.patch && \ cd gtests/net/packetdrill && \ ./configure && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I681802fd779530878c2d2358ebf90b8e2adb4870 Gerrit-Change-Number: 26586 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 20:20:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 20:20:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Use alive-type components for "infrastructure" components In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26486 ) Change subject: Use alive-type components for "infrastructure" components ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I61d791d6d1bfe9226aabbe223baafc5f8f6d4f04 Gerrit-Change-Number: 26486 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 15 Dec 2021 20:20:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 20:20:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 20:20:28 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Use alive-type components for "infrastructure" components In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26486 ) Change subject: Use alive-type components for "infrastructure" components ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I61d791d6d1bfe9226aabbe223baafc5f8f6d4f04 Gerrit-Change-Number: 26486 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 15 Dec 2021 20:20:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 15 20:20:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 15 Dec 2021 20:20:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Use alive-type components for "infrastructure" components In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26486 ) Change subject: Use alive-type components for "infrastructure" components ...................................................................... Use alive-type components for "infrastructure" components According to feedback received from TITAN developers in https://www.eclipse.org/forums/index.php?t=msg&th=1106652&goto=1848616&#msg_1848616 the use of alive-type components has the following advantage: > Also the DTE during the shutdown can be avoided to use alive type > components. The test ports of the alive components are not > disconnected/unmapped when the component finished only when killed or > the MTC terminated. So the idea of this patch is to use alive-type components for all the underlying infrastructure, such as the *_Emulation_CT starting from M3UA to SCCP and further up the stack. This way, only the MTC and the highest level of components (such as ConnHdlr) remain as normal components. The hope is that using more alive-type components in the lower protocol layer emulations will reduce the probability of DTE during shutdown if some message is received during the component shutdown after the MTC has completed. Change-Id: I61d791d6d1bfe9226aabbe223baafc5f8f6d4f04 --- M bsc/BSC_Tests.ttcn M gbproxy/GBProxy_Tests.ttcn M library/BSSAP_LE_Adapter.ttcn 3 files changed, 11 insertions(+), 11 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index c2ea258..0c71581 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -916,12 +916,12 @@ timer T := 10.0; clnt.id := "IPA" & int2str(i) & "-RSL"; - clnt.vc_IPA := IPA_Emulation_CT.create(clnt.id & "-IPA"); + clnt.vc_IPA := IPA_Emulation_CT.create(clnt.id & "-IPA") alive; clnt.ccm_pars := c_IPA_default_ccm_pars; clnt.ccm_pars.name := "Osmocom TTCN-3 BTS Simulator"; clnt.ccm_pars.unit_id := int2str(1234+i) & "/0/0"; if (handler_mode) { - clnt.vc_RSL := RSL_Emulation_CT.create(clnt.id & "-RSL"); + clnt.vc_RSL := RSL_Emulation_CT.create(clnt.id & "-RSL") alive; connect(clnt.vc_RSL:CCHAN_PT, self:RSL_CCHAN[i]); } @@ -1024,7 +1024,7 @@ multi_conn_mode := (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_SCCPlite_SERVER) }; - vc_MGCP := MGCP_Emulation_CT.create(id); + vc_MGCP := MGCP_Emulation_CT.create(id) alive; vc_MGCP.start(MGCP_Emulation.main(ops, mgcp_pars, id)); } @@ -3569,7 +3569,7 @@ timer T := 10.0; bts[0].rsl.id := "IPA-0-RSL"; - bts[0].rsl.vc_IPA := IPA_Emulation_CT.create(bts[0].rsl.id & "-IPA"); + bts[0].rsl.vc_IPA := IPA_Emulation_CT.create(bts[0].rsl.id & "-IPA") alive; bts[0].rsl.ccm_pars := c_IPA_default_ccm_pars; bts[0].rsl.ccm_pars.name := "Osmocom TTCN-3 BTS Simulator"; bts[0].rsl.ccm_pars.unit_id := "99/0/0"; /* value which is unknown at BTS */ diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn index ddf98a9..3f822c2 100644 --- a/gbproxy/GBProxy_Tests.ttcn +++ b/gbproxy/GBProxy_Tests.ttcn @@ -447,8 +447,8 @@ private function f_init_gb_pcu(inout GbInstance gb, charstring id, integer offset) runs on test_CT { var charstring ns_id := id & "-NS(PCU[" & int2str(offset) & "])"; var charstring bssgp_id := id & "-BSSGP(PCU[" & int2str(offset) & "])"; - gb.vc_NS := NS_CT.create(ns_id); - gb.vc_BSSGP := BSSGP_CT.create(bssgp_id); + gb.vc_NS := NS_CT.create(ns_id) alive; + gb.vc_BSSGP := BSSGP_CT.create(bssgp_id) alive; /* connect lower end of BSSGP emulation with NS upper port */ connect(gb.vc_BSSGP:BSCP, gb.vc_NS:NS_SP); @@ -470,8 +470,8 @@ private function f_init_gb_sgsn(inout GbInstance gb, charstring id, integer offset) runs on test_CT { var charstring ns_id := id & "-NS(SGSN[" & int2str(offset) & "])"; var charstring bssgp_id := id & "-BSSGP(SGSN[" & int2str(offset) & "])"; - gb.vc_NS := NS_CT.create(ns_id); - gb.vc_BSSGP := BSSGP_CT.create(bssgp_id); + gb.vc_NS := NS_CT.create(ns_id) alive; + gb.vc_BSSGP := BSSGP_CT.create(bssgp_id) alive; /* connect lower end of BSSGP emulation with NS upper port */ connect(gb.vc_BSSGP:BSCP, gb.vc_NS:NS_SP); diff --git a/library/BSSAP_LE_Adapter.ttcn b/library/BSSAP_LE_Adapter.ttcn index dba8841..256d8fa 100644 --- a/library/BSSAP_LE_Adapter.ttcn +++ b/library/BSSAP_LE_Adapter.ttcn @@ -85,13 +85,13 @@ ops.sccp_addr_peer := ba.sccp_addr_peer; /* create components */ - ba.vc_SCCP := SCCP_CT.create(id & "-SCCP"); + ba.vc_SCCP := SCCP_CT.create(id & "-SCCP") alive; if (isvalue(ops)) { - ba.vc_BSSAP_LE := BSSAP_LE_Emulation_CT.create(id & "-BSSAP_LE"); + ba.vc_BSSAP_LE := BSSAP_LE_Emulation_CT.create(id & "-BSSAP_LE") alive; } else { ba.vc_BSSAP_LE := null; } - ba.vc_M3UA := M3UA_CT.create(id & "-M3UA"); + ba.vc_M3UA := M3UA_CT.create(id & "-M3UA") alive; map(ba.vc_M3UA:SCTP_PORT, system:sctp); /* connect MTP3 service provider (M3UA) to lower side of SCCP */ connect(ba.vc_M3UA:MTP3_SP_PORT, ba.vc_SCCP:MTP3_SCCP_PORT); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I61d791d6d1bfe9226aabbe223baafc5f8f6d4f04 Gerrit-Change-Number: 26486 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Dec 16 00:39:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 00:39:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61ba8ade6e3a0_66e22ae3e4d9a6002916d6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 32s] checking for libasn1c >= 0.9.30... yes [ 32s] checking for libosmocore >= 1.6.0... yes [ 32s] checking for libosmovty >= 1.6.0... yes [ 32s] checking for libosmoctrl >= 1.6.0... yes [ 32s] checking for libosmogsm >= 1.6.0... yes [ 32s] checking for libosmoabis >= 1.2.0... yes [ 32s] checking for libosmotrau >= 1.2.0... no [ 32s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 32s] [ 32s] No package 'libosmotrau' found [ 32s] [ 32s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 32s] installed software in a non-standard prefix. [ 32s] [ 32s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 32s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 32s] See the pkg-config man page for more details. [ 32s] error: Bad exit status from /var/tmp/rpm-tmp.K8rhyW (%build) [ 32s] [ 32s] [ 32s] RPM build errors: [ 32s] Bad exit status from /var/tmp/rpm-tmp.K8rhyW (%build) [ 32s] ### VM INTERACTION START ### [ 36s] [ 30.129118] sysrq: Power Off [ 36s] [ 30.131482] reboot: Power down [ 36s] ### VM INTERACTION END ### [ 36s] [ 36s] goat19 failed "build osmo-hnodeb.spec" at Thu Dec 16 00:39:47 UTC 2021. [ 36s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 16 00:42:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 00:42:07 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61ba8b738137f_66e22ae3e4d9a60029208@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 60s] checking for libasn1c >= 0.9.30... yes [ 60s] checking for libosmocore >= 1.6.0... yes [ 60s] checking for libosmovty >= 1.6.0... yes [ 60s] checking for libosmoctrl >= 1.6.0... yes [ 60s] checking for libosmogsm >= 1.6.0... yes [ 60s] checking for libosmoabis >= 1.2.0... yes [ 60s] checking for libosmotrau >= 1.2.0... no [ 60s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 60s] [ 60s] No package 'libosmotrau' found [ 60s] [ 60s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 60s] installed software in a non-standard prefix. [ 60s] [ 60s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 60s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 60s] See the pkg-config man page for more details. [ 61s] error: Bad exit status from /var/tmp/rpm-tmp.suExZj (%build) [ 61s] [ 61s] [ 61s] RPM build errors: [ 61s] Bad exit status from /var/tmp/rpm-tmp.suExZj (%build) [ 61s] ### VM INTERACTION START ### [ 64s] [ 50.167684] sysrq: SysRq : Power Off [ 64s] [ 50.170773] reboot: Power down [ 64s] ### VM INTERACTION END ### [ 64s] [ 64s] cloud130 failed "build osmo-hnodeb.spec" at Thu Dec 16 00:42:03 UTC 2021. [ 64s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 16 00:42:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 00:42:59 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <61ba8bad7d12_66e22ae3e4d9a6002921fa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 31s] checking for LIBASN1C... yes [ 31s] checking for LIBOSMOCORE... yes [ 31s] checking for LIBOSMOVTY... yes [ 31s] checking for LIBOSMOCTRL... yes [ 31s] checking for LIBOSMOGSM... yes [ 31s] checking for LIBOSMOABIS... yes [ 31s] checking for LIBOSMOTRAU... no [ 31s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 31s] [ 31s] Package 'libosmotrau', required by 'virtual:world', not found [ 31s] [ 31s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 31s] installed software in a non-standard prefix. [ 31s] [ 31s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 31s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 31s] See the pkg-config man page for more details. [ 31s] error: Bad exit status from /var/tmp/rpm-tmp.WTWRDD (%build) [ 31s] [ 31s] [ 31s] RPM build errors: [ 31s] Bad exit status from /var/tmp/rpm-tmp.WTWRDD (%build) [ 31s] ### VM INTERACTION START ### [ 34s] [ 28.356662][ T412] sysrq: Power Off [ 34s] [ 28.361102][ T7] reboot: Power down [ 34s] ### VM INTERACTION END ### [ 34s] [ 34s] sheep85 failed "build osmo-hnodeb.spec" at Thu Dec 16 00:42:54 UTC 2021. [ 34s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 16 00:43:16 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 00:43:16 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <61ba8bad6bb6f_66e22ae3e4d9a60029224c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 35s] checking for LIBASN1C... yes [ 35s] checking for LIBOSMOCORE... yes [ 35s] checking for LIBOSMOVTY... yes [ 35s] checking for LIBOSMOCTRL... yes [ 35s] checking for LIBOSMOGSM... yes [ 35s] checking for LIBOSMOABIS... yes [ 35s] checking for LIBOSMOTRAU... no [ 35s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 35s] [ 35s] Package 'libosmotrau', required by 'virtual:world', not found [ 35s] [ 35s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 35s] installed software in a non-standard prefix. [ 35s] [ 35s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 35s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 35s] See the pkg-config man page for more details. [ 35s] error: Bad exit status from /var/tmp/rpm-tmp.T0z9Mg (%build) [ 35s] [ 35s] [ 35s] RPM build errors: [ 35s] Bad exit status from /var/tmp/rpm-tmp.T0z9Mg (%build) [ 35s] ### VM INTERACTION START ### [ 38s] [ 32.964287][ T517] sysrq: Power Off [ 38s] [ 32.973599][ T7] reboot: Power down [ 39s] ### VM INTERACTION END ### [ 39s] [ 39s] sheep81 failed "build osmo-hnodeb.spec" at Thu Dec 16 00:43:02 UTC 2021. [ 39s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 16 00:48:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 00:48:07 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61ba8cdb71764_66e22ae3e4d9a6002925e8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 120s] checking for LIBASN1C... yes [ 120s] checking for LIBOSMOCORE... yes [ 120s] checking for LIBOSMOVTY... yes [ 120s] checking for LIBOSMOCTRL... yes [ 120s] checking for LIBOSMOGSM... yes [ 120s] checking for LIBOSMOABIS... yes [ 120s] checking for LIBOSMOTRAU... no [ 120s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 120s] [ 120s] Package 'libosmotrau', required by 'virtual:world', not found [ 120s] [ 120s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 120s] installed software in a non-standard prefix. [ 120s] [ 120s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 120s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 120s] See the pkg-config man page for more details. [ 120s] error: Bad exit status from /var/tmp/rpm-tmp.KwDBQF (%build) [ 120s] [ 120s] [ 120s] RPM build errors: [ 120s] Bad exit status from /var/tmp/rpm-tmp.KwDBQF (%build) [ 120s] ### VM INTERACTION START ### [ 121s] Powering off. [ 121s] [ 89.123421] reboot: Power down [ 121s] ### VM INTERACTION END ### [ 121s] [ 121s] cloud118 failed "build osmo-hnodeb.spec" at Thu Dec 16 00:47:58 UTC 2021. [ 121s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 16 01:00:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 01:00:43 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61ba8ff71cce6_66e22ae3e4d9a60029503e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 114s] checking for LIBASN1C... yes [ 114s] checking for LIBOSMOCORE... yes [ 114s] checking for LIBOSMOVTY... yes [ 114s] checking for LIBOSMOCTRL... yes [ 114s] checking for LIBOSMOGSM... yes [ 114s] checking for LIBOSMOABIS... yes [ 114s] checking for LIBOSMOTRAU... no [ 114s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 114s] [ 114s] Package 'libosmotrau', required by 'virtual:world', not found [ 114s] [ 114s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 114s] installed software in a non-standard prefix. [ 114s] [ 114s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 114s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 114s] See the pkg-config man page for more details. [ 114s] error: Bad exit status from /var/tmp/rpm-tmp.u3C5Qp (%build) [ 114s] [ 114s] [ 114s] RPM build errors: [ 114s] Bad exit status from /var/tmp/rpm-tmp.u3C5Qp (%build) [ 115s] ### VM INTERACTION START ### [ 118s] [ 94.324612][ T379] sysrq: Power Off [ 118s] [ 94.405413][ T15] reboot: Power down [ 118s] ### VM INTERACTION END ### [ 118s] [ 118s] armbuild24 failed "build osmo-hnodeb.spec" at Thu Dec 16 01:00:40 UTC 2021. [ 118s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 16 03:56:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 03:56:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61bab90838b1b_66e22ae3e4d9a6003253dc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 39s] checking for libasn1c >= 0.9.30... yes [ 39s] checking for libosmocore >= 1.6.0... yes [ 39s] checking for libosmovty >= 1.6.0... yes [ 39s] checking for libosmoctrl >= 1.6.0... yes [ 39s] checking for libosmogsm >= 1.6.0... yes [ 39s] checking for libosmoabis >= 1.2.0... yes [ 39s] checking for libosmotrau >= 1.2.0... no [ 39s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 39s] [ 39s] No package 'libosmotrau' found [ 39s] [ 39s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 39s] installed software in a non-standard prefix. [ 39s] [ 39s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 39s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 39s] See the pkg-config man page for more details. [ 39s] error: Bad exit status from /var/tmp/rpm-tmp.CGm2Fn (%build) [ 39s] [ 39s] [ 39s] RPM build errors: [ 39s] Bad exit status from /var/tmp/rpm-tmp.CGm2Fn (%build) [ 39s] ### VM INTERACTION START ### [ 43s] [ 34.722915] sysrq: SysRq : Power Off [ 43s] [ 34.723999] reboot: Power down [ 43s] ### VM INTERACTION END ### [ 43s] [ 43s] obs-arm-10 failed "build osmo-hnodeb.spec" at Thu Dec 16 03:56:13 UTC 2021. [ 43s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 16 04:24:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 04:24:59 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61babfb583d31_66e22ae3e4d9a6003299c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 99s] checking for libasn1c >= 0.9.30... yes [ 99s] checking for libosmocore >= 1.6.0... yes [ 99s] checking for libosmovty >= 1.6.0... yes [ 99s] checking for libosmoctrl >= 1.6.0... yes [ 99s] checking for libosmogsm >= 1.6.0... yes [ 99s] checking for libosmoabis >= 1.2.0... yes [ 99s] checking for libosmotrau >= 1.2.0... no [ 99s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 99s] [ 99s] No package 'libosmotrau' found [ 99s] [ 99s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 99s] installed software in a non-standard prefix. [ 99s] [ 99s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 99s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 99s] See the pkg-config man page for more details. [ 99s] error: Bad exit status from /var/tmp/rpm-tmp.myo28O (%build) [ 99s] [ 99s] [ 99s] RPM build errors: [ 99s] Bad exit status from /var/tmp/rpm-tmp.myo28O (%build) [ 99s] ### VM INTERACTION START ### [ 102s] [ 87.491958] sysrq: SysRq : Power Off [ 102s] [ 87.544633] reboot: Power down [ 102s] ### VM INTERACTION END ### [ 102s] [ 102s] armbuild22 failed "build osmo-hnodeb.spec" at Thu Dec 16 04:24:44 UTC 2021. [ 102s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 16 04:26:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 04:26:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61babff3a1212_66e22ae3e4d9a6003301fa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 188s] checking for LIBASN1C... yes [ 188s] checking for LIBOSMOCORE... yes [ 188s] checking for LIBOSMOVTY... yes [ 188s] checking for LIBOSMOCTRL... yes [ 188s] checking for LIBOSMOGSM... yes [ 188s] checking for LIBOSMOABIS... yes [ 188s] checking for LIBOSMOTRAU... no [ 188s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 188s] [ 188s] Package 'libosmotrau', required by 'virtual:world', not found [ 188s] [ 188s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 188s] installed software in a non-standard prefix. [ 188s] [ 188s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 188s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 188s] See the pkg-config man page for more details. [ 188s] error: Bad exit status from /var/tmp/rpm-tmp.HO7u2D (%build) [ 188s] [ 188s] [ 188s] RPM build errors: [ 188s] Bad exit status from /var/tmp/rpm-tmp.HO7u2D (%build) [ 188s] ### VM INTERACTION START ### [ 189s] Powering off. [ 189s] [ 145.378261] reboot: Power down [ 189s] ### VM INTERACTION END ### [ 189s] [ 189s] obs-arm-9 failed "build osmo-hnodeb.spec" at Thu Dec 16 04:26:18 UTC 2021. [ 189s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 16 07:55:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 07:55:21 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61baf0fb2fd66_4b3e2b08e039260014237@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 162s] checking for LIBASN1C... yes [ 162s] checking for LIBOSMOCORE... yes [ 162s] checking for LIBOSMOVTY... yes [ 162s] checking for LIBOSMOCTRL... yes [ 162s] checking for LIBOSMOGSM... yes [ 162s] checking for LIBOSMOABIS... yes [ 162s] checking for LIBOSMOTRAU... no [ 162s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 162s] [ 162s] Package 'libosmotrau', required by 'virtual:world', not found [ 162s] [ 162s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 162s] installed software in a non-standard prefix. [ 162s] [ 162s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 162s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 162s] See the pkg-config man page for more details. [ 162s] error: Bad exit status from /var/tmp/rpm-tmp.q7UX76 (%build) [ 162s] [ 162s] [ 162s] RPM build errors: [ 162s] Bad exit status from /var/tmp/rpm-tmp.q7UX76 (%build) [ 162s] ### VM INTERACTION START ### [ 166s] [ 103.133807][ T383] sysrq: Power Off [ 166s] [ 103.134499][ T15] reboot: Power down [ 166s] ### VM INTERACTION END ### [ 166s] [ 166s] obs-arm-10 failed "build osmo-hnodeb.spec" at Thu Dec 16 07:55:16 UTC 2021. [ 166s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Dec 16 09:31:51 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 16 Dec 2021 09:31:51 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 8: ok, will change accordingly. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 8 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 16 Dec 2021 09:31:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 09:56:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 09:56:59 +0000 Subject: Change in osmo-ci[master]: jobs/registry-update-base-images: one image per line References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26587 ) Change subject: jobs/registry-update-base-images: one image per line ...................................................................... jobs/registry-update-base-images: one image per line Make the list of images more git friendly, and sort the debian releases by date. Related: OS#4969 Change-Id: Ic724aa4b2c71aa398ad7f7049e8f3406a3883eaa --- M jobs/registry-update-base-images.yml 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/87/26587/1 diff --git a/jobs/registry-update-base-images.yml b/jobs/registry-update-base-images.yml index 2dd6e69..6be2ec6 100644 --- a/jobs/registry-update-base-images.yml +++ b/jobs/registry-update-base-images.yml @@ -16,7 +16,17 @@ builders: - shell: | REGISTRY="registry.osmocom.org" - IMAGES="debian:stretch debian:buster debian:jessie debian:sid ubuntu:zesty centos:centos7 centos:centos8" + IMAGES=" + debian:jessie + debian:stretch + debian:buster + debian:sid + + ubuntu:zesty + + centos:centos7 + centos:centos8 + " for i in $IMAGES; do src=$i dst=${REGISTRY}/$i -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic724aa4b2c71aa398ad7f7049e8f3406a3883eaa Gerrit-Change-Number: 26587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 09:57:00 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 09:57:00 +0000 Subject: Change in osmo-ci[master]: jobs/registry-update-base-images: add d:bullseye References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26588 ) Change subject: jobs/registry-update-base-images: add d:bullseye ...................................................................... jobs/registry-update-base-images: add d:bullseye Related: OS#4969 Change-Id: I2f30c9ff3558e3fad60117d951c85c3548eddf1b --- M jobs/registry-update-base-images.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/88/26588/1 diff --git a/jobs/registry-update-base-images.yml b/jobs/registry-update-base-images.yml index 6be2ec6..1e5e423 100644 --- a/jobs/registry-update-base-images.yml +++ b/jobs/registry-update-base-images.yml @@ -20,6 +20,7 @@ debian:jessie debian:stretch debian:buster + debian:bullseye debian:sid ubuntu:zesty -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2f30c9ff3558e3fad60117d951c85c3548eddf1b Gerrit-Change-Number: 26588 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 09:57:01 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 09:57:01 +0000 Subject: Change in osmo-ci[master]: registry-rebuild-upload-titan: s/stretch/bullseye/ References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26589 ) Change subject: registry-rebuild-upload-titan: s/stretch/bullseye/ ...................................................................... registry-rebuild-upload-titan: s/stretch/bullseye/ Depends: docker-playground Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f Related: OS#4969 Change-Id: Ic117725f765a83cf3d2955e19441795fe6415dd2 --- M jobs/registry-rebuild-upload-titan.yml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/89/26589/1 diff --git a/jobs/registry-rebuild-upload-titan.yml b/jobs/registry-rebuild-upload-titan.yml index 7e50aed..21cf29f 100644 --- a/jobs/registry-rebuild-upload-titan.yml +++ b/jobs/registry-rebuild-upload-titan.yml @@ -26,8 +26,8 @@ builders: - shell: | REGISTRY="registry.osmocom.org" - make -C debian-stretch-titan REGISTRY_HOST=$REGISTRY - docker push "$REGISTRY/$USER/debian-stretch-titan" + make -C debian-bullseye-titan REGISTRY_HOST=$REGISTRY + docker push "$REGISTRY/$USER/debian-bullseye-titan" publishers: - email: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic117725f765a83cf3d2955e19441795fe6415dd2 Gerrit-Change-Number: 26589 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 09:58:07 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 09:58:07 +0000 Subject: Change in docker-playground[master]: titan: move from debian-stetch-titan to debian-bullseye-titan In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26582 ) Change subject: titan: move from debian-stetch-titan to debian-bullseye-titan ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Thanks for making this! We need to be careful with roll out (I can do it if you like), otherwise looking good. https://gerrit.osmocom.org/c/docker-playground/+/26582/3/jenkins-common.sh File jenkins-common.sh: https://gerrit.osmocom.org/c/docker-playground/+/26582/3/jenkins-common.sh at 138 PS3, Line 138: debian-bullseye-titan) This is currently not in the registry, but if we merge it together with https://gerrit.osmocom.org/c/osmo-ci/+/26589 and make sure it runs directly afterwards, it should be fine. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f Gerrit-Change-Number: 26582 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 09:58:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 09:58:31 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 09:58:31 +0000 Subject: Change in docker-playground[master]: Switch ttcn3-* master tests from Debian stretch to bullseys In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26583 ) Change subject: Switch ttcn3-* master tests from Debian stretch to bullseys ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26583 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic6bece9cb695e6eccfcb1e83fdbf1048724a3cf9 Gerrit-Change-Number: 26583 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 09:58:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 09:59:01 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 09:59:01 +0000 Subject: Change in docker-playground[master]: nplab: Switch from stretch to buster In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26585 ) Change subject: nplab: Switch from stretch to buster ...................................................................... Patch Set 3: (2 comments) Caching logic needs the branch in the link, otherwise LGTM https://gerrit.osmocom.org/c/docker-playground/+/26585/3/nplab-m3ua-test/Dockerfile File nplab-m3ua-test/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/26585/3/nplab-m3ua-test/Dockerfile at 7 PS3, Line 7: http://git.osmocom.org/nplab/m3ua-testtool/patch https://git.osmocom.org/nplab/m3ua-testtool/patch/?h=laforge/python3 https://gerrit.osmocom.org/c/docker-playground/+/26585/3/nplab-sua-test/Dockerfile File nplab-sua-test/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/26585/3/nplab-sua-test/Dockerfile at 7 PS3, Line 7: http://git.osmocom.org/nplab/sua-testtool/patch https://git.osmocom.org/nplab/sua-testtool/patch/?h=laforge/python3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be Gerrit-Change-Number: 26585 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 09:59:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 09:59:32 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 09:59:32 +0000 Subject: Change in docker-playground[master]: sctp-test: Upgrade to bullseye In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26586 ) Change subject: sctp-test: Upgrade to bullseye ...................................................................... Patch Set 1: (1 comment) besides the date comment: LGTM https://gerrit.osmocom.org/c/docker-playground/+/26586/1/sctp-test/Dockerfile File sctp-test/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/26586/1/sctp-test/Dockerfile at 20 PS1, Line 20: 2018-08-28 2021-08-24 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I681802fd779530878c2d2358ebf90b8e2adb4870 Gerrit-Change-Number: 26586 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 16 Dec 2021 09:59:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:01:39 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:01:39 +0000 Subject: Change in osmo-ci[master]: registry-rebuild-upload-titan: s/stretch/bullseye/ In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/26589 to look at the new patch set (#2). Change subject: registry-rebuild-upload-titan: s/stretch/bullseye/ ...................................................................... registry-rebuild-upload-titan: s/stretch/bullseye/ Depends: docker-playground Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f Related: OS#4969 Change-Id: Ic117725f765a83cf3d2955e19441795fe6415dd2 --- M jobs/registry-rebuild-upload-titan.yml 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/89/26589/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic117725f765a83cf3d2955e19441795fe6415dd2 Gerrit-Change-Number: 26589 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:31:48 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 16 Dec 2021 10:31:48 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26454 to look at the new patch set (#9). Change subject: select: gather statistics for TCP connections ...................................................................... select: gather statistics for TCP connections osmocom applications are deployed in a variety of different situations. Dependung on the medium that interconnects the network components unexpected behaviour may occur. To debug problems with the interconnection between network components it might help to monitor the health of the related TCP connections. Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Related: SYS#5701 --- M configure.ac M include/Makefile.am A include/osmocom/core/stats_tcp.h M src/Makefile.am M src/select.c A src/stats_tcp.c A src/stats_tcp_internal.h M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 9 files changed, 323 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/26454/9 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:31:48 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 16 Dec 2021 10:31:48 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 9: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26454/8/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/8/src/select.c at 169 PS8, Line 169: stats_tcp_osmo_fd_register(fd); > I'm sorry but this is is crazy, I see no point in registering automatically all the fds we register [?] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 16 Dec 2021 10:31:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:32:36 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 16 Dec 2021 10:32:36 +0000 Subject: Change in libosmo-abis[master]: ipaccess.c: assign names to the related osmo_fds In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26455 ) Change subject: ipaccess.c: assign names to the related osmo_fds ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 10:32:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:32:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:32:59 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: non-jenkins: unique build tag References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26590 ) Change subject: jenkins-common.sh: non-jenkins: unique build tag ...................................................................... jenkins-common.sh: non-jenkins: unique build tag Support running multiple TTCN-3 testsuites in parallel when the jenkins.sh scripts get called from outside of jenkins too. Closes: OS#5358 Change-Id: Iaaf5719f758553687f2ab57975be275e7ac07e36 --- M jenkins-common.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/90/26590/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index 9373076..2e91c14 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -438,9 +438,9 @@ exit 1 fi -# non-jenkins execution: put logs in /tmp +# non-jenkins execution: set a unique BUILD_TAG to avoid collisions (OS#5358) if [ "x$BUILD_TAG" = "x" ]; then - BUILD_TAG=nonjenkins + BUILD_TAG="nonjenkins-$(date +%N)" fi SUITE_NAME=`basename $PWD` -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iaaf5719f758553687f2ab57975be275e7ac07e36 Gerrit-Change-Number: 26590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:34:08 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:34:08 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: non-jenkins: unique build tag In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26590 ) Change subject: jenkins-common.sh: non-jenkins: unique build tag ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/docker-playground/+/26590/1/jenkins-common.sh File jenkins-common.sh: https://gerrit.osmocom.org/c/docker-playground/+/26590/1/jenkins-common.sh at a441 PS1, Line 441: put logs in /tmp this comment was copy-pasted from above for some reason. it makes sense above, but not here. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iaaf5719f758553687f2ab57975be275e7ac07e36 Gerrit-Change-Number: 26590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 16 Dec 2021 10:34:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:34:39 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 10:34:39 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: non-jenkins: unique build tag In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26590 ) Change subject: jenkins-common.sh: non-jenkins: unique build tag ...................................................................... Patch Set 1: Code-Review+2 nice idea! -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iaaf5719f758553687f2ab57975be275e7ac07e36 Gerrit-Change-Number: 26590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 16 Dec 2021 10:34:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:35:58 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:35:58 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: non-jenkins: unique build tag In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26590 ) Change subject: jenkins-common.sh: non-jenkins: unique build tag ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iaaf5719f758553687f2ab57975be275e7ac07e36 Gerrit-Change-Number: 26590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 16 Dec 2021 10:35:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:36:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 10:36:01 +0000 Subject: Change in docker-playground[master]: titan: move from debian-stetch-titan to debian-bullseye-titan In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26582 ) Change subject: titan: move from debian-stetch-titan to debian-bullseye-titan ...................................................................... Patch Set 3: >We need to be careful with roll out (I can do it if you like), otherwise looking good. ok, then please do the roll-out. You're more familiar with the dependencies. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f Gerrit-Change-Number: 26582 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 10:36:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:36:04 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:36:04 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: non-jenkins: unique build tag In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26590 ) Change subject: jenkins-common.sh: non-jenkins: unique build tag ...................................................................... jenkins-common.sh: non-jenkins: unique build tag Support running multiple TTCN-3 testsuites in parallel when the jenkins.sh scripts get called from outside of jenkins too. Closes: OS#5358 Change-Id: Iaaf5719f758553687f2ab57975be275e7ac07e36 --- M jenkins-common.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Verified diff --git a/jenkins-common.sh b/jenkins-common.sh index 9373076..2e91c14 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -438,9 +438,9 @@ exit 1 fi -# non-jenkins execution: put logs in /tmp +# non-jenkins execution: set a unique BUILD_TAG to avoid collisions (OS#5358) if [ "x$BUILD_TAG" = "x" ]; then - BUILD_TAG=nonjenkins + BUILD_TAG="nonjenkins-$(date +%N)" fi SUITE_NAME=`basename $PWD` -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iaaf5719f758553687f2ab57975be275e7ac07e36 Gerrit-Change-Number: 26590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:36:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 10:36:28 +0000 Subject: Change in osmo-ci[master]: registry-rebuild-upload-titan: s/stretch/bullseye/ In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26589 ) Change subject: registry-rebuild-upload-titan: s/stretch/bullseye/ ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic117725f765a83cf3d2955e19441795fe6415dd2 Gerrit-Change-Number: 26589 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Assignee: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 16 Dec 2021 10:36:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:36:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 10:36:41 +0000 Subject: Change in osmo-ci[master]: jobs/registry-update-base-images: one image per line In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26587 ) Change subject: jobs/registry-update-base-images: one image per line ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic724aa4b2c71aa398ad7f7049e8f3406a3883eaa Gerrit-Change-Number: 26587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 16 Dec 2021 10:36:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:36:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 10:36:50 +0000 Subject: Change in osmo-ci[master]: jobs/registry-update-base-images: add d:bullseye In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26588 ) Change subject: jobs/registry-update-base-images: add d:bullseye ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2f30c9ff3558e3fad60117d951c85c3548eddf1b Gerrit-Change-Number: 26588 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 16 Dec 2021 10:36:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:40:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 10:40:27 +0000 Subject: Change in docker-playground[master]: nplab: Switch from stretch to buster In-Reply-To: References: Message-ID: Hello osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/26585 to look at the new patch set (#4). Change subject: nplab: Switch from stretch to buster ...................................................................... nplab: Switch from stretch to buster The test suites require guile-2.0 so we have to stay with buster and cannot upgrade to bullseye (guile-3.0 only). Related: OS#4969 Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be --- M nplab-m3ua-test/Dockerfile M nplab-m3ua-test/jenkins.sh M nplab-sua-test/Dockerfile M nplab-sua-test/jenkins.sh M sigtran-tests/Dockerfile 5 files changed, 12 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/85/26585/4 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be Gerrit-Change-Number: 26585 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:41:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 10:41:00 +0000 Subject: Change in docker-playground[master]: nplab: Switch from stretch to buster In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26585 ) Change subject: nplab: Switch from stretch to buster ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/docker-playground/+/26585/3/nplab-m3ua-test/Dockerfile File nplab-m3ua-test/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/26585/3/nplab-m3ua-test/Dockerfile at 7 PS3, Line 7: http://git.osmocom.org/nplab/m3ua-testtool/patch > https://git.osmocom. [?] Done https://gerrit.osmocom.org/c/docker-playground/+/26585/3/nplab-sua-test/Dockerfile File nplab-sua-test/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/26585/3/nplab-sua-test/Dockerfile at 7 PS3, Line 7: http://git.osmocom.org/nplab/sua-testtool/patch > https://git.osmocom. [?] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be Gerrit-Change-Number: 26585 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 10:41:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:46:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 10:46:01 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 9: > Patch Set 8: Code-Review-2 > > (1 comment) > > I'm really not happy with the proposals done so far here. I am quite happy with the second proposal, except for what I wrote in my last feedback. > Please come up with a system which only applies to specific sockets for which we really want this feature. The entire point of this patch - and I agree with this from day one of the discussion - is to have it automatically work for all TCP sockets. You are trying to change the complete premise of the patchset now retroactively. Maybe the timer can be disabled by default, so that no runtime overhead in terms of getsockopt is incurred. But there should be _one_ switch, provided by libosmocore, which will make all TCP sockets serving remote connections provide those statistics. In the end, we don't have that many TCP sockets in our typical programs anyway. Most is SCTP, unix domain or UDP. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 16 Dec 2021 10:46:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:49:51 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:49:51 +0000 Subject: Change in docker-playground[master]: nplab: Switch from stretch to buster In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26585 ) Change subject: nplab: Switch from stretch to buster ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be Gerrit-Change-Number: 26585 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 10:49:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:51:49 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:51:49 +0000 Subject: Change in docker-playground[master]: sctp-test: Upgrade to bullseye In-Reply-To: References: Message-ID: osmith has uploaded a new patch set (#3) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/docker-playground/+/26586 ) Change subject: sctp-test: Upgrade to bullseye ...................................................................... sctp-test: Upgrade to bullseye Change-Id: I681802fd779530878c2d2358ebf90b8e2adb4870 --- M sctp-test/Dockerfile 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/86/26586/3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I681802fd779530878c2d2358ebf90b8e2adb4870 Gerrit-Change-Number: 26586 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:52:15 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:52:15 +0000 Subject: Change in docker-playground[master]: sctp-test: Upgrade to bullseye In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26586 ) Change subject: sctp-test: Upgrade to bullseye ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I681802fd779530878c2d2358ebf90b8e2adb4870 Gerrit-Change-Number: 26586 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 16 Dec 2021 10:52:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:52:25 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:52:25 +0000 Subject: Change in docker-playground[master]: titan: move from debian-stetch-titan to debian-bullseye-titan In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26582 ) Change subject: titan: move from debian-stetch-titan to debian-bullseye-titan ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f Gerrit-Change-Number: 26582 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 10:52:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:52:30 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:52:30 +0000 Subject: Change in docker-playground[master]: Switch ttcn3-* master tests from Debian stretch to bullseys In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26583 ) Change subject: Switch ttcn3-* master tests from Debian stretch to bullseys ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26583 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic6bece9cb695e6eccfcb1e83fdbf1048724a3cf9 Gerrit-Change-Number: 26583 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 10:52:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:52:34 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:52:34 +0000 Subject: Change in docker-playground[master]: nplab: Switch from stretch to buster In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26585 ) Change subject: nplab: Switch from stretch to buster ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be Gerrit-Change-Number: 26585 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 10:52:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:52:38 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:52:38 +0000 Subject: Change in docker-playground[master]: sctp-test: Upgrade to bullseye In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26586 ) Change subject: sctp-test: Upgrade to bullseye ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I681802fd779530878c2d2358ebf90b8e2adb4870 Gerrit-Change-Number: 26586 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 16 Dec 2021 10:52:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:54:05 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:54:05 +0000 Subject: Change in docker-playground[master]: titan: move from debian-stetch-titan to debian-bullseye-titan In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26582 ) Change subject: titan: move from debian-stetch-titan to debian-bullseye-titan ...................................................................... titan: move from debian-stetch-titan to debian-bullseye-titan So far we were executing all our TTCN-3 tests from a container image with Debian stretch (9) plus a custom more recent eclipse-titan package from the osmocom feed. Let's update the container base OS from stretch (9) to bullseye (11) while using the same packaged eclipse-titan version (8.0.0) for running the tests. So this should be a low-risk change, as titan runtime remains identical. I've executed all test suites locally and couldn't see any regressions. Related: OS#4969 Change-Id: Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f --- R debian-bullseye-titan/.release R debian-bullseye-titan/Dockerfile R debian-bullseye-titan/Makefile R debian-bullseye-titan/pipework R debian-bullseye-titan/ttcn3-docker-prepare.sh R debian-bullseye-titan/ttcn3-docker-run.sh M jenkins-common.sh M nplab-m3ua-test/jenkins.sh M ttcn3-bsc-test-vamos/Dockerfile M ttcn3-bsc-test/Dockerfile M ttcn3-bscnat-test/Dockerfile M ttcn3-bts-test/Dockerfile M ttcn3-cbc-test/Dockerfile M ttcn3-fr-test/Dockerfile M ttcn3-gbproxy-test/Dockerfile M ttcn3-ggsn-test/Dockerfile M ttcn3-hlr-test/Dockerfile M ttcn3-hnodeb-test/Dockerfile M ttcn3-mgw-test/Dockerfile M ttcn3-msc-test/Dockerfile M ttcn3-nitb-sysinfo/Dockerfile M ttcn3-ns-test/Dockerfile M ttcn3-pcap-client-test/Dockerfile M ttcn3-pcu-test/Dockerfile M ttcn3-remsim-test/Dockerfile M ttcn3-sccp-test/Dockerfile M ttcn3-sgsn-test/Dockerfile M ttcn3-sip-test/Dockerfile M ttcn3-smlc-test/Dockerfile M ttcn3-stp-test/Dockerfile 30 files changed, 27 insertions(+), 27 deletions(-) Approvals: osmith: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve diff --git a/debian-stretch-titan/.release b/debian-bullseye-titan/.release similarity index 100% rename from debian-stretch-titan/.release rename to debian-bullseye-titan/.release diff --git a/debian-stretch-titan/Dockerfile b/debian-bullseye-titan/Dockerfile similarity index 96% rename from debian-stretch-titan/Dockerfile rename to debian-bullseye-titan/Dockerfile index d348914..bf99534 100644 --- a/debian-stretch-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -1,12 +1,12 @@ ARG REGISTRY=docker.io -ARG UPSTREAM_DISTRO=debian:stretch +ARG UPSTREAM_DISTRO=debian:bullseye FROM ${REGISTRY}/${UPSTREAM_DISTRO} # Arguments used after FROM must be specified again ARG OSMOCOM_REPO_TESTSUITE_MIRROR="http://download.opensuse.org" MAINTAINER Harald Welte -ARG OSMOCOM_REPO="$OSMOCOM_REPO_TESTSUITE_MIRROR/repositories/network:/osmocom:/latest/Debian_9.0/" +ARG OSMOCOM_REPO="$OSMOCOM_REPO_TESTSUITE_MIRROR/repositories/network:/osmocom:/latest/Debian_11/" RUN apt-get update && apt-get install -y \ gnupg diff --git a/debian-stretch-titan/Makefile b/debian-bullseye-titan/Makefile similarity index 100% rename from debian-stretch-titan/Makefile rename to debian-bullseye-titan/Makefile diff --git a/debian-stretch-titan/pipework b/debian-bullseye-titan/pipework similarity index 100% rename from debian-stretch-titan/pipework rename to debian-bullseye-titan/pipework diff --git a/debian-stretch-titan/ttcn3-docker-prepare.sh b/debian-bullseye-titan/ttcn3-docker-prepare.sh similarity index 100% rename from debian-stretch-titan/ttcn3-docker-prepare.sh rename to debian-bullseye-titan/ttcn3-docker-prepare.sh diff --git a/debian-stretch-titan/ttcn3-docker-run.sh b/debian-bullseye-titan/ttcn3-docker-run.sh similarity index 100% rename from debian-stretch-titan/ttcn3-docker-run.sh rename to debian-bullseye-titan/ttcn3-docker-run.sh diff --git a/jenkins-common.sh b/jenkins-common.sh index 2e91c14..9610676 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -21,7 +21,7 @@ osmo-*-centos8) echo "centos8-build" ;; osmo-*-latest) echo "debian-stretch-obs-latest" ;; osmo-*) echo "debian-stretch-build" ;; - ttcn3-*) echo "debian-stretch-titan" ;; + ttcn3-*) echo "debian-bullseye-titan" ;; esac } @@ -135,7 +135,7 @@ # they are up-to-date. if [ "$REGISTRY_HOST" = "registry.osmocom.org" ]; then case "$i" in - debian-stretch-titan) + debian-bullseye-titan) docker pull "$REGISTRY_HOST/$USER/$i" continue ;; diff --git a/nplab-m3ua-test/jenkins.sh b/nplab-m3ua-test/jenkins.sh index 3be308a..c4250b0 100755 --- a/nplab-m3ua-test/jenkins.sh +++ b/nplab-m3ua-test/jenkins.sh @@ -6,7 +6,7 @@ "debian-stretch-build" \ "sigtran-tests" \ "osmo-stp-$IMAGE_SUFFIX" \ - "debian-stretch-titan" \ + "debian-bullseye-titan" \ "nplab-m3ua-test" set_clean_up_trap diff --git a/ttcn3-bsc-test-vamos/Dockerfile b/ttcn3-bsc-test-vamos/Dockerfile index 1923c38..a29e000 100644 --- a/ttcn3-bsc-test-vamos/Dockerfile +++ b/ttcn3-bsc-test-vamos/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-bsc-test/Dockerfile b/ttcn3-bsc-test/Dockerfile index 1923c38..a29e000 100644 --- a/ttcn3-bsc-test/Dockerfile +++ b/ttcn3-bsc-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-bscnat-test/Dockerfile b/ttcn3-bscnat-test/Dockerfile index 50ca926..15e7727 100644 --- a/ttcn3-bscnat-test/Dockerfile +++ b/ttcn3-bscnat-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-bts-test/Dockerfile b/ttcn3-bts-test/Dockerfile index 8ac7cb8..d676bf0 100644 --- a/ttcn3-bts-test/Dockerfile +++ b/ttcn3-bts-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-cbc-test/Dockerfile b/ttcn3-cbc-test/Dockerfile index 8eba25f..7c1e6c5 100644 --- a/ttcn3-cbc-test/Dockerfile +++ b/ttcn3-cbc-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-fr-test/Dockerfile b/ttcn3-fr-test/Dockerfile index 4a70c12..11589f6 100644 --- a/ttcn3-fr-test/Dockerfile +++ b/ttcn3-fr-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-gbproxy-test/Dockerfile b/ttcn3-gbproxy-test/Dockerfile index 71494d9..a2216b2 100644 --- a/ttcn3-gbproxy-test/Dockerfile +++ b/ttcn3-gbproxy-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-ggsn-test/Dockerfile b/ttcn3-ggsn-test/Dockerfile index d42ac3e..252e893 100644 --- a/ttcn3-ggsn-test/Dockerfile +++ b/ttcn3-ggsn-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-hlr-test/Dockerfile b/ttcn3-hlr-test/Dockerfile index 8480288..ac5ca4f 100644 --- a/ttcn3-hlr-test/Dockerfile +++ b/ttcn3-hlr-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-hnodeb-test/Dockerfile b/ttcn3-hnodeb-test/Dockerfile index 9659dd1..2071cab 100644 --- a/ttcn3-hnodeb-test/Dockerfile +++ b/ttcn3-hnodeb-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-mgw-test/Dockerfile b/ttcn3-mgw-test/Dockerfile index 087dc09..c8eeb2b 100644 --- a/ttcn3-mgw-test/Dockerfile +++ b/ttcn3-mgw-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-msc-test/Dockerfile b/ttcn3-msc-test/Dockerfile index 05610a4..8c67bbf 100644 --- a/ttcn3-msc-test/Dockerfile +++ b/ttcn3-msc-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-nitb-sysinfo/Dockerfile b/ttcn3-nitb-sysinfo/Dockerfile index 45bf69e..3155271 100644 --- a/ttcn3-nitb-sysinfo/Dockerfile +++ b/ttcn3-nitb-sysinfo/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-ns-test/Dockerfile b/ttcn3-ns-test/Dockerfile index 850046d..b94de1b 100644 --- a/ttcn3-ns-test/Dockerfile +++ b/ttcn3-ns-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-pcap-client-test/Dockerfile b/ttcn3-pcap-client-test/Dockerfile index 2a3799f..9e66326 100644 --- a/ttcn3-pcap-client-test/Dockerfile +++ b/ttcn3-pcap-client-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-pcu-test/Dockerfile b/ttcn3-pcu-test/Dockerfile index e42bca1..b7cb21a 100644 --- a/ttcn3-pcu-test/Dockerfile +++ b/ttcn3-pcu-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-remsim-test/Dockerfile b/ttcn3-remsim-test/Dockerfile index caa6da1..e94c55c 100644 --- a/ttcn3-remsim-test/Dockerfile +++ b/ttcn3-remsim-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-sccp-test/Dockerfile b/ttcn3-sccp-test/Dockerfile index 708a72f..f43a5dd 100644 --- a/ttcn3-sccp-test/Dockerfile +++ b/ttcn3-sccp-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-sgsn-test/Dockerfile b/ttcn3-sgsn-test/Dockerfile index 333b5ed..b581b43 100644 --- a/ttcn3-sgsn-test/Dockerfile +++ b/ttcn3-sgsn-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-sip-test/Dockerfile b/ttcn3-sip-test/Dockerfile index 1324ac0..7dd4756 100644 --- a/ttcn3-sip-test/Dockerfile +++ b/ttcn3-sip-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-smlc-test/Dockerfile b/ttcn3-smlc-test/Dockerfile index 5d27ceb..0d5b0da 100644 --- a/ttcn3-smlc-test/Dockerfile +++ b/ttcn3-smlc-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit diff --git a/ttcn3-stp-test/Dockerfile b/ttcn3-stp-test/Dockerfile index e36935b..7808704 100644 --- a/ttcn3-stp-test/Dockerfile +++ b/ttcn3-stp-test/Dockerfile @@ -1,6 +1,6 @@ ARG REGISTRY ARG USER -FROM $REGISTRY/$USER/debian-stretch-titan +FROM $REGISTRY/$USER/debian-bullseye-titan ARG OSMO_TTCN3_BRANCH="master" ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f Gerrit-Change-Number: 26582 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:54:06 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:54:06 +0000 Subject: Change in docker-playground[master]: Switch ttcn3-* master tests from Debian stretch to bullseys In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26583 ) Change subject: Switch ttcn3-* master tests from Debian stretch to bullseys ...................................................................... Switch ttcn3-* master tests from Debian stretch to bullseys So far we were using ancient Debian 9 (stretch) for our IUT containers. Let's upgrade that to Debian 11 (bullseye). Related: OS#4969 Change-Id: Ic6bece9cb695e6eccfcb1e83fdbf1048724a3cf9 --- M jenkins-common.sh M make/Makefile 2 files changed, 13 insertions(+), 9 deletions(-) Approvals: osmith: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve diff --git a/jenkins-common.sh b/jenkins-common.sh index 9610676..5af91fb 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -20,7 +20,7 @@ osmo-*-centos7) echo "centos7-build" ;; osmo-*-centos8) echo "centos8-build" ;; osmo-*-latest) echo "debian-stretch-obs-latest" ;; - osmo-*) echo "debian-stretch-build" ;; + osmo-*) echo "debian-bullseye-build" ;; ttcn3-*) echo "debian-bullseye-titan" ;; esac } @@ -31,7 +31,8 @@ osmo-*-centos8) echo "centos8" ;; centos7-*) echo "centos7" ;; centos8-*) echo "centos8" ;; - *) echo "debian-stretch" ;; + debian-buster-*) echo "debian-buster" ;; + *) echo "debian-bullseye" ;; esac } @@ -42,7 +43,10 @@ centos7-*) echo "centos:centos7" ;; centos8-*) echo "centos:centos8" ;; debian10-*) echo "debian:buster" ;; - *) echo "debian:stretch" ;; + debian11-*) echo "debian:bullseye" ;; + debian-stretch-*) echo "debian:stretch" ;; + debian-buster-*) echo "debian:buster" ;; + *) echo "debian:bullseye" ;; esac } @@ -109,7 +113,7 @@ } # Make sure required images are available and build them if necessary. -# $*: image names (e.g. "debian-stretch-build", "osmo-mgw-master", "osmo-mgw-master-centos8") +# $*: image names (e.g. "debian-bullseye-build", "osmo-mgw-master", "osmo-mgw-master-centos8") # The images are automatically built from the Dockerfile of the subdir of # the same name. If there is a distribution name at the end of the image # name (e.g. osmo-mgw-master-centos8), it gets removed from the subdir @@ -232,8 +236,8 @@ } fix_perms() { - if ! docker_image_exists "debian-stretch-build"; then - docker_images_require "debian-stretch-build" + if ! docker_image_exists "debian-bullseye-build"; then + docker_images_require "debian-bullseye-build" fi echo Fixing permissions @@ -241,7 +245,7 @@ -v $VOL_BASE_DIR:/data \ -v $CACHE_DIR:/cache \ --name ${BUILD_TAG}-cleaner \ - $REPO_USER/debian-stretch-build \ + $REPO_USER/debian-bullseye-build \ chmod -R a+rX /data/ /cache/ } diff --git a/make/Makefile b/make/Makefile index 416fc18..8bd360d 100644 --- a/make/Makefile +++ b/make/Makefile @@ -36,8 +36,8 @@ OSMO_SIP_BRANCH?=master OSMO_STP_BRANCH?=master PULL?= -UPSTREAM_DISTRO?=debian:stretch -DISTRO?=debian-stretch +UPSTREAM_DISTRO?=debian:bullseye +DISTRO?=debian-bullseye # Full OBS repository mirror consists of: # ${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/${OSMOCOM_REPO_VERSION} -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26583 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic6bece9cb695e6eccfcb1e83fdbf1048724a3cf9 Gerrit-Change-Number: 26583 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:54:07 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:54:07 +0000 Subject: Change in docker-playground[master]: nplab: Switch from stretch to buster In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26585 ) Change subject: nplab: Switch from stretch to buster ...................................................................... nplab: Switch from stretch to buster The test suites require guile-2.0 so we have to stay with buster and cannot upgrade to bullseye (guile-3.0 only). Related: OS#4969 Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be --- M nplab-m3ua-test/Dockerfile M nplab-m3ua-test/jenkins.sh M nplab-sua-test/Dockerfile M nplab-sua-test/jenkins.sh M sigtran-tests/Dockerfile 5 files changed, 12 insertions(+), 10 deletions(-) Approvals: osmith: Looks good to me, approved; Verified diff --git a/nplab-m3ua-test/Dockerfile b/nplab-m3ua-test/Dockerfile index ba5d17d..db993bd 100644 --- a/nplab-m3ua-test/Dockerfile +++ b/nplab-m3ua-test/Dockerfile @@ -4,9 +4,10 @@ MAINTAINER Harald Welte RUN cd /tmp && git clone git://git.osmocom.org/nplab/m3ua-testtool -ADD http://git.osmocom.org/nplab/m3ua-testtool/patch /tmp/commit +ADD http://git.osmocom.org/nplab/m3ua-testtool/patch/?h=laforge/python3 /tmp/commit RUN cd /tmp/m3ua-testtool && \ - git pull && \ + git fetch && \ + git checkout -f laforge/python3 && \ cp runtest-junitxml.py /usr/local/bin/ COPY dotguile /root/.guile diff --git a/nplab-m3ua-test/jenkins.sh b/nplab-m3ua-test/jenkins.sh index c4250b0..87035f3 100755 --- a/nplab-m3ua-test/jenkins.sh +++ b/nplab-m3ua-test/jenkins.sh @@ -3,7 +3,7 @@ . ../jenkins-common.sh IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" docker_images_require \ - "debian-stretch-build" \ + "debian-buster-build" \ "sigtran-tests" \ "osmo-stp-$IMAGE_SUFFIX" \ "debian-bullseye-titan" \ diff --git a/nplab-sua-test/Dockerfile b/nplab-sua-test/Dockerfile index f7f071a..d62f665 100644 --- a/nplab-sua-test/Dockerfile +++ b/nplab-sua-test/Dockerfile @@ -4,9 +4,10 @@ MAINTAINER Harald Welte RUN cd /tmp && git clone git://git.osmocom.org/nplab/sua-testtool -ADD http://git.osmocom.org/nplab/sua-testtool/patch /tmp/commit +ADD http://git.osmocom.org/nplab/sua-testtool/patch/?h=laforge/python3 /tmp/commit RUN cd /tmp/sua-testtool && \ - git pull && \ + git fetch && \ + git checkout -f laforge/python3 && \ cp runtest-junitxml.py /usr/local/bin/ COPY dotguile /root/.guile diff --git a/nplab-sua-test/jenkins.sh b/nplab-sua-test/jenkins.sh index 0e59cd4..4be00c8 100755 --- a/nplab-sua-test/jenkins.sh +++ b/nplab-sua-test/jenkins.sh @@ -3,9 +3,9 @@ . ../jenkins-common.sh IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" docker_images_require \ - "debian-stretch-build" \ + "debian-buster-build" \ "osmo-stp-$IMAGE_SUFFIX" \ - "debian-stretch-titan" \ + "debian-bullseye-titan" \ "sigtran-tests" \ "nplab-sua-test" diff --git a/sigtran-tests/Dockerfile b/sigtran-tests/Dockerfile index ebfb027..d7f7206 100644 --- a/sigtran-tests/Dockerfile +++ b/sigtran-tests/Dockerfile @@ -1,13 +1,13 @@ ARG USER -FROM $USER/debian-stretch-build +FROM $USER/debian-buster-build MAINTAINER Harald Welte RUN apt-get update && apt-get -y install \ guile-2.0 guile-2.0-dev gnulib tcsh \ - python python-pip + python3 python3-pip -RUN pip install junit-xml +RUN pip3 install junit-xml RUN cd /tmp && git clone https://github.com/nplab/guile-sctp && \ cd guile-sctp && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I30c05efbc6c7a21cad71b207e723ef958f1ac9be Gerrit-Change-Number: 26585 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:54:07 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:54:07 +0000 Subject: Change in docker-playground[master]: sctp-test: Upgrade to bullseye In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26586 ) Change subject: sctp-test: Upgrade to bullseye ...................................................................... sctp-test: Upgrade to bullseye Change-Id: I681802fd779530878c2d2358ebf90b8e2adb4870 --- M sctp-test/Dockerfile 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: osmith: Looks good to me, approved; Verified diff --git a/sctp-test/Dockerfile b/sctp-test/Dockerfile index 79df64d..7ba92bf 100644 --- a/sctp-test/Dockerfile +++ b/sctp-test/Dockerfile @@ -1,5 +1,5 @@ ARG USER -FROM $USER/debian-stretch-build +FROM $USER/debian-bullseye-build MAINTAINER Harald Welte @@ -17,10 +17,10 @@ WORKDIR /tmp -# Commit from 2018-08-28 +# Commit from 2021-08-24 RUN git clone https://github.com/nplab/packetdrill && \ cd packetdrill && \ - git checkout 89bb4f35393187d0d34a84170de529d688421be7 && \ + git checkout c6810864095558f5df77e9f06941191cbd41d7e2 && \ git am /tmp/*.patch && \ cd gtests/net/packetdrill && \ ./configure && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I681802fd779530878c2d2358ebf90b8e2adb4870 Gerrit-Change-Number: 26586 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:54:08 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:54:08 +0000 Subject: Change in osmo-ci[master]: jobs/registry-update-base-images: one image per line In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26587 ) Change subject: jobs/registry-update-base-images: one image per line ...................................................................... jobs/registry-update-base-images: one image per line Make the list of images more git friendly, and sort the debian releases by date. Related: OS#4969 Change-Id: Ic724aa4b2c71aa398ad7f7049e8f3406a3883eaa --- M jobs/registry-update-base-images.yml 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/jobs/registry-update-base-images.yml b/jobs/registry-update-base-images.yml index 2dd6e69..6be2ec6 100644 --- a/jobs/registry-update-base-images.yml +++ b/jobs/registry-update-base-images.yml @@ -16,7 +16,17 @@ builders: - shell: | REGISTRY="registry.osmocom.org" - IMAGES="debian:stretch debian:buster debian:jessie debian:sid ubuntu:zesty centos:centos7 centos:centos8" + IMAGES=" + debian:jessie + debian:stretch + debian:buster + debian:sid + + ubuntu:zesty + + centos:centos7 + centos:centos8 + " for i in $IMAGES; do src=$i dst=${REGISTRY}/$i -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic724aa4b2c71aa398ad7f7049e8f3406a3883eaa Gerrit-Change-Number: 26587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:54:08 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:54:08 +0000 Subject: Change in osmo-ci[master]: jobs/registry-update-base-images: add d:bullseye In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26588 ) Change subject: jobs/registry-update-base-images: add d:bullseye ...................................................................... jobs/registry-update-base-images: add d:bullseye Related: OS#4969 Change-Id: I2f30c9ff3558e3fad60117d951c85c3548eddf1b --- M jobs/registry-update-base-images.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/jobs/registry-update-base-images.yml b/jobs/registry-update-base-images.yml index 6be2ec6..1e5e423 100644 --- a/jobs/registry-update-base-images.yml +++ b/jobs/registry-update-base-images.yml @@ -20,6 +20,7 @@ debian:jessie debian:stretch debian:buster + debian:bullseye debian:sid ubuntu:zesty -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2f30c9ff3558e3fad60117d951c85c3548eddf1b Gerrit-Change-Number: 26588 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 10:54:09 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 10:54:09 +0000 Subject: Change in osmo-ci[master]: registry-rebuild-upload-titan: s/stretch/bullseye/ In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26589 ) Change subject: registry-rebuild-upload-titan: s/stretch/bullseye/ ...................................................................... registry-rebuild-upload-titan: s/stretch/bullseye/ Depends: docker-playground Ib3bdfa3bec8f8ef42c55ca61cdee8fbca923874f Related: OS#4969 Change-Id: Ic117725f765a83cf3d2955e19441795fe6415dd2 --- M jobs/registry-rebuild-upload-titan.yml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/jobs/registry-rebuild-upload-titan.yml b/jobs/registry-rebuild-upload-titan.yml index 7e50aed..0c63fca 100644 --- a/jobs/registry-rebuild-upload-titan.yml +++ b/jobs/registry-rebuild-upload-titan.yml @@ -8,7 +8,7 @@ - job: name: registry-rebuild-upload-titan description: | - Rebuild + push ttcn3 base images (debian-stretch-titan) in our private + Rebuild + push ttcn3 base images (debian-bullseye-titan) in our private registry.osmocom.org

Related:
@@ -26,8 +26,8 @@ builders: - shell: | REGISTRY="registry.osmocom.org" - make -C debian-stretch-titan REGISTRY_HOST=$REGISTRY - docker push "$REGISTRY/$USER/debian-stretch-titan" + make -C debian-bullseye-titan REGISTRY_HOST=$REGISTRY + docker push "$REGISTRY/$USER/debian-bullseye-titan" publishers: - email: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic117725f765a83cf3d2955e19441795fe6415dd2 Gerrit-Change-Number: 26589 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Assignee: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Dec 16 10:55:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 10:55:02 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61bb1b0a6ef5d_4b3e2b08e0392600447a1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 78s] checking for LIBASN1C... yes [ 78s] checking for LIBOSMOCORE... yes [ 78s] checking for LIBOSMOVTY... yes [ 78s] checking for LIBOSMOCTRL... yes [ 78s] checking for LIBOSMOGSM... yes [ 78s] checking for LIBOSMOABIS... yes [ 78s] checking for LIBOSMOTRAU... no [ 78s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 78s] [ 78s] Package 'libosmotrau', required by 'virtual:world', not found [ 78s] [ 78s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 78s] installed software in a non-standard prefix. [ 78s] [ 78s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 78s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 78s] See the pkg-config man page for more details. [ 78s] error: Bad exit status from /var/tmp/rpm-tmp.xMwJxv (%build) [ 78s] [ 78s] [ 78s] RPM build errors: [ 78s] Bad exit status from /var/tmp/rpm-tmp.xMwJxv (%build) [ 78s] ### VM INTERACTION START ### [ 81s] [ 50.697067][ T384] sysrq: Power Off [ 81s] [ 50.697709][ T211] reboot: Power down [ 81s] ### VM INTERACTION END ### [ 81s] [ 81s] obs-arm-11 failed "build osmo-hnodeb.spec" at Thu Dec 16 10:54:50 UTC 2021. [ 81s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Dec 16 11:05:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 11:05:15 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 9: > Maybe the timer can be disabled by default, so that no runtime overhead in terms of getsockopt is incurred. But there should be _one_ switch, provided by libosmocore, which will make all TCP sockets serving remote connections provide those statistics. To be more precise: There should be one switch, exposed to the user via the VTY, where he can enable or disable TCP statistics for all remote sockets serving signaling traffic (so we're excluding CTRL + VTY here as those are OAM and not part of the normal signaling) V8 of this patch does not introduce any overhead to osmo_select_main, all the getsockopt calls are in a timer. So from my point of view, I don't understand where your strong reaction is coming from * there is a separate list of TCP sockets. only applies to those. Adds one small dynamic allocation on socket creation time. No runtime overhead during processing of traffic of those sockets * the actual statistics polling via getsockopt happens in a timer So IMHO, there are only two topics open: 1) ensuring that the timer doesn't tage ages in case we have many TCP sockets by not polling the full list on every expiration, spreading the load over multiple timer iterations 2) thinking about setting the default timer to "off", requiring explicit user interaction to activate this feature via VTY/config -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 16 Dec 2021 11:05:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 11:29:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 11:29:43 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 9: Code-Review-1 (3 comments) Maybe the thing here is that I don't really see the point in having that done for all TCP sockets. Specially not by default. IMHO the app should specifically allocate and register specific sats_tcp-entry to the API and then they would become available. If then you still want to have somehow a possibility to get all the sockets registered automatically (which I don't see the point), then one may register those as done here but have it disabled by default. But in this case there's going to be no hood "name" or "description" to show for those, well maybe yes, by printing rem_addr:rem_port<->local_addr:local_port or alike on its stats name. Those are my ideas. If you still find the current solution acceptable then feel free to merge it. https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/select.c at 188 PS9, Line 188: osmo_stats_tcp_osmo_fd_unregister(fd); so we are now converting a O(k) operation into an O(n) one. Also if user is responsible of registering it, I'd argue it should also be responsible from unregistering it here. https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/stats_tcp.c File src/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/stats_tcp.c at 194 PS9, Line 194: return; return error? https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/stats_tcp.c at 210 PS9, Line 210: void osmo_stats_tcp_osmo_fd_unregister(const struct osmo_fd *fd) By exposing struct stats_tcp_entry and using it as a param, you convert these functions from O(n) to O(k) because you can directly use llist_add, llist_del, etc. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 16 Dec 2021 11:29:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 11:34:58 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 11:34:58 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 9: BTW, one of the important point here: I don't really see the direct relation between registering/unregistering an FD and willing to track its stats. The kernel will continue to track stats and operate on the socket regardless of it being registered in the mainloop of the process. So I'd really think about decoupling the fact of registering/unregistering the fd with the system exposing the stats for the socket of that fd. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 16 Dec 2021 11:34:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 11:48:00 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 11:48:00 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-start.sh: don't hardcode tcpdump path References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 ) Change subject: ttcn3-tcpdump-start.sh: don't hardcode tcpdump path ...................................................................... ttcn3-tcpdump-start.sh: don't hardcode tcpdump path After replacing debian-stretch-titan with debian-bullseye-titan, tcpdump does not run anymore, the binary is in /usr/bin and not in /usr/sbin. Related: OS#4969 Change-Id: I18c88c45c7522c1120ca42cd48d67fe8f155cd39 --- M ttcn3-tcpdump-start.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/26591/1 diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh index e905d8a..853ac1c 100755 --- a/ttcn3-tcpdump-start.sh +++ b/ttcn3-tcpdump-start.sh @@ -1,7 +1,7 @@ #!/bin/sh PIDFILE_PCAP=/tmp/pcap.pid -TCPDUMP=/usr/sbin/tcpdump +TCPDUMP=$(command -v tcpdump) DUMPCAP=/usr/bin/dumpcap PIDFILE_NETCAT=/tmp/netcat.pid -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c88c45c7522c1120ca42cd48d67fe8f155cd39 Gerrit-Change-Number: 26591 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 11:48:11 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 11:48:11 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: sort pkgs alphabetically References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26592 ) Change subject: debian-bullseye-titan: sort pkgs alphabetically ...................................................................... debian-bullseye-titan: sort pkgs alphabetically Change-Id: Id5e1d6a3a1705234f25e7c346e2fcf1d3741570d --- M debian-bullseye-titan/Dockerfile 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/92/26592/1 diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile index bf99534..1d5c1cd 100644 --- a/debian-bullseye-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -27,13 +27,13 @@ DEBIAN_FRONTEND='noninteractive' apt-get install -y --no-install-recommends --no-install-suggests \ build-essential \ git \ - procps \ - tcpdump \ - wireshark-common \ - vim \ netcat-openbsd \ - python3-setuptools \ + procps \ python3-pip \ + python3-setuptools \ + tcpdump \ + vim \ + wireshark-common \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id5e1d6a3a1705234f25e7c346e2fcf1d3741570d Gerrit-Change-Number: 26592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 11:48:12 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 11:48:12 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: install ping References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26593 ) Change subject: debian-bullseye-titan: install ping ...................................................................... debian-bullseye-titan: install ping Add ping, so ttcn3-tcpdump-start.sh from osmo-ttcn3-hacks.git works as expected. It is supposed to wait until tcpdump is properly capturing packets, by generating dummy packets with ping and waiting until the pcap file gains size. However since ping is currently not installed, it will just wait 10 seconds before executing tests. Fix for: Waiting for packet dumper to start... 0 Waiting for packet dumper to start... 1 Waiting for packet dumper to start... 2 Waiting for packet dumper to start... 3 Waiting for packet dumper to start... 4 Waiting for packet dumper to start... 5 Waiting for packet dumper to start... 6 Waiting for packet dumper to start... 7 Waiting for packet dumper to start... 8 Waiting for packet dumper to start... 9 Related: OS#4969 Change-Id: I46cf22e7eab7dcd4b3835a8c7aa48654aef6c65a --- M debian-bullseye-titan/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/93/26593/1 diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile index 1d5c1cd..0b1fbda 100644 --- a/debian-bullseye-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -27,6 +27,7 @@ DEBIAN_FRONTEND='noninteractive' apt-get install -y --no-install-recommends --no-install-suggests \ build-essential \ git \ + inetutils-ping \ netcat-openbsd \ procps \ python3-pip \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I46cf22e7eab7dcd4b3835a8c7aa48654aef6c65a Gerrit-Change-Number: 26593 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 11:56:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 11:56:35 +0000 Subject: Change in libosmo-netif[master]: prim: return last error code References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26594 ) Change subject: prim: return last error code ...................................................................... prim: return last error code Closes: Coverity CID#242768 Change-Id: Ic0f8b313ab9a8de597d8bb6db76e9883bc6009a0 --- M src/prim.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/94/26594/1 diff --git a/src/prim.c b/src/prim.c index 5189c4c..d26954c 100644 --- a/src/prim.c +++ b/src/prim.c @@ -166,7 +166,7 @@ prim_resp = _sap_ctl_makeprim_hello_cnf(hello_ind->sapi, (uint16_t)rc); LOGSRV(prim_srv, LOGL_INFO, "Tx CTL-HELLO.cnf SAPI=%u API_VERSION=%u\n", hello_ind->sapi, prim_resp->u.hello_cnf.api_version); - osmo_prim_srv_send(prim_srv, prim_resp->hdr.msg); + rc = osmo_prim_srv_send(prim_srv, prim_resp->hdr.msg); return rc; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic0f8b313ab9a8de597d8bb6db76e9883bc6009a0 Gerrit-Change-Number: 26594 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:01:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 12:01:26 +0000 Subject: Change in osmo-hnodeb[master]: Update AUDIO and GTP SAPs to support multiple conns per UE In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 to look at the new patch set (#2). Change subject: Update AUDIO and GTP SAPs to support multiple conns per UE ...................................................................... Update AUDIO and GTP SAPs to support multiple conns per UE This is needed for instance: * AUDIO: video calls * GTP: secondary pdp contexts For better abstraction, now both AUDIO and GTP conns use unique ID namespaces, and one ID is used to identify each one. Each conn relate in turn to a UE since a context_id is passed during connection establishment. Related: SYS#5516 Change-Id: Ib3f60d5ba21defe5259c25e2034fc2217c4d93df --- M doc/hnodeb.msc M include/osmocom/hnodeb/gtp.h M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/rtp.h M src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk_audio.c M src/osmo-hnodeb/llsk_gtp.c M src/osmo-hnodeb/rtp.c 11 files changed, 265 insertions(+), 177 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/70/26570/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ib3f60d5ba21defe5259c25e2034fc2217c4d93df Gerrit-Change-Number: 26570 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:01:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 12:01:27 +0000 Subject: Change in osmo-hnodeb[master]: Fix several Coverity found issues References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 ) Change subject: Fix several Coverity found issues ...................................................................... Fix several Coverity found issues Closes: CID#242770 Closes: CID#242769 Closes: CID#242767 Change-Id: I6d73a970919889953539fbacc601d679d7ec4113 --- M src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/rua.c 2 files changed, 11 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/95/26595/1 diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c index 4695ea9..b8bfebc 100644 --- a/src/osmo-hnodeb/gtp.c +++ b/src/osmo-hnodeb/gtp.c @@ -45,14 +45,15 @@ { struct hnb_gtp_prim *gtp_prim; struct hnb_ue *ue = lib->priv; - struct hnb *hnb = ue->hnb; + struct hnb *hnb; int rc; if (!ue || !ue->conn_ps.active) { - LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", + LOGP(DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", packet, len); return -EINVAL; } + hnb = ue->hnb; LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len); gtp_prim = hnb_gtp_makeprim_conn_data_ind(ue->conn_id, ue->conn_ps.local_tei, packet, len); @@ -180,18 +181,19 @@ int hnb_ue_gtp_tx(struct hnb_ue *ue, void *gtpu_payload, unsigned gtpu_payload_len) { int rc; - struct hnb *hnb = ue->hnb; - - if (!hnb->gtp.gsn) { - LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n"); - return -EINVAL; - } + struct hnb *hnb; if (!ue || !ue->conn_ps.pdp_lib) { LOGUE(ue, DGTP, LOGL_ERROR, "Tx: UE PDP Ctx not available\n"); return -EINVAL; } + hnb = ue->hnb; + if (!hnb->gtp.gsn) { + LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n"); + return -EINVAL; + } + rc = gtp_data_req(hnb->gtp.gsn, ue->conn_ps.pdp_lib, gtpu_payload, gtpu_payload_len); return rc; } diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c index 3a73f0c..5b225de 100644 --- a/src/osmo-hnodeb/rua.c +++ b/src/osmo-hnodeb/rua.c @@ -140,6 +140,7 @@ case RUA_ProcedureCode_id_DirectTransfer: LOGP(DRUA, LOGL_INFO, "RUA rx Initiating DirectTransfer\n"); hnb_rua_dt_handle(hnb, &init->value); + break; default: LOGP(DRUA, LOGL_INFO, "RUA rx unknown Initiating message\n"); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6d73a970919889953539fbacc601d679d7ec4113 Gerrit-Change-Number: 26595 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:01:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 12:01:27 +0000 Subject: Change in osmo-hnodeb[master]: rtp: Use dynamic Payload Type 96 References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26596 ) Change subject: rtp: Use dynamic Payload Type 96 ...................................................................... rtp: Use dynamic Payload Type 96 Change-Id: I6ca83c274200d8fc0fb3d8914e970b05df91f6ea --- M src/osmo-hnodeb/rtp.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/96/26596/1 diff --git a/src/osmo-hnodeb/rtp.c b/src/osmo-hnodeb/rtp.c index 2f40d99..41fb668 100644 --- a/src/osmo-hnodeb/rtp.c +++ b/src/osmo-hnodeb/rtp.c @@ -193,6 +193,14 @@ LOGUE(ue, DRTP, LOGL_ERROR, "Failed to set RTP socket parameters: %s\n", strerror(-rc)); goto free_ret; } + /* TS 25.414 Section 5.1.3.3.1.6: A dynamic Payload Type (IETF RFC 1890 + * [23]) shall be used. Values in the Range between 96 and 127 shall be + * used. The value shall be ignored in the receiving entity. */ + rc = osmo_rtp_socket_set_pt(rs, 96); + if (rc < 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Failed to set RTP socket Payload-Type 96\n"); + /* Continue, the other side is anyway ignoring it... */ + } rs->priv = conn; rs->rx_cb = &rtp_rx_cb; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6ca83c274200d8fc0fb3d8914e970b05df91f6ea Gerrit-Change-Number: 26596 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:02:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 12:02:04 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-start.sh: don't hardcode tcpdump path In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 ) Change subject: ttcn3-tcpdump-start.sh: don't hardcode tcpdump path ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c88c45c7522c1120ca42cd48d67fe8f155cd39 Gerrit-Change-Number: 26591 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 12:02:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:02:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 12:02:26 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-start.sh: don't hardcode tcpdump path In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 ) Change subject: ttcn3-tcpdump-start.sh: don't hardcode tcpdump path ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591/1/ttcn3-tcpdump-start.sh File ttcn3-tcpdump-start.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591/1/ttcn3-tcpdump-start.sh at 5 PS1, Line 5: DUMPCAP=/usr/bin/dumpcap You can problably do the same here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591/1/ttcn3-tcpdump-start.sh at 8 PS1, Line 8: NETCAT=/bin/nc and here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c88c45c7522c1120ca42cd48d67fe8f155cd39 Gerrit-Change-Number: 26591 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 12:02:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:02:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 12:02:40 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: sort pkgs alphabetically In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26592 ) Change subject: debian-bullseye-titan: sort pkgs alphabetically ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id5e1d6a3a1705234f25e7c346e2fcf1d3741570d Gerrit-Change-Number: 26592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 12:02:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:02:58 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 12:02:58 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: install ping In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26593 ) Change subject: debian-bullseye-titan: install ping ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I46cf22e7eab7dcd4b3835a8c7aa48654aef6c65a Gerrit-Change-Number: 26593 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 12:02:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:07:37 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 12:07:37 +0000 Subject: Change in docker-playground[master]: debian-bullseye-obs-latest: new image References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26597 ) Change subject: debian-bullseye-obs-latest: new image ...................................................................... debian-bullseye-obs-latest: new image Add missing container for -latest tests. Currently this causes the -latest tests to fail. Related: OS#4969 Change-Id: I1230e87784bc21b5a6424db0bd8734181ead9bfd --- A debian-bullseye-obs-latest/Dockerfile A debian-bullseye-obs-latest/Makefile M jenkins-common.sh 3 files changed, 30 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/97/26597/1 diff --git a/debian-bullseye-obs-latest/Dockerfile b/debian-bullseye-obs-latest/Dockerfile new file mode 100644 index 0000000..fb8cd93 --- /dev/null +++ b/debian-bullseye-obs-latest/Dockerfile @@ -0,0 +1,26 @@ +ARG REGISTRY=docker.io +ARG UPSTREAM_DISTRO=debian:bullseye +FROM ${REGISTRY}/${UPSTREAM_DISTRO} +# Arguments used after FROM must be specified again +ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" +ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO="${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/latest/Debian_11/" + +RUN apt-get update && \ + apt-get upgrade -y && \ + apt-get install -y --no-install-recommends \ + telnet \ + gnupg \ + && \ + apt-get clean + +COPY .common/Release.key /tmp/Release.key +RUN apt-key add /tmp/Release.key && \ + rm /tmp/Release.key && \ + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-latest.list + +# Make respawn.sh part of this image, so it can be used by other images based on it +COPY .common/respawn.sh /usr/local/bin/respawn.sh + +# Invalidate cache once the repository is updated +ADD $OSMOCOM_REPO/Release /tmp/Release diff --git a/debian-bullseye-obs-latest/Makefile b/debian-bullseye-obs-latest/Makefile new file mode 100644 index 0000000..736769d --- /dev/null +++ b/debian-bullseye-obs-latest/Makefile @@ -0,0 +1,3 @@ +UPSTREAM_DISTRO=debian:bullseye +DISTRO=debian-bullseye +include ../make/Makefile diff --git a/jenkins-common.sh b/jenkins-common.sh index 5af91fb..b74b952 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -19,7 +19,7 @@ osmo-*-latest-centos8) echo "centos8-obs-latest" ;; osmo-*-centos7) echo "centos7-build" ;; osmo-*-centos8) echo "centos8-build" ;; - osmo-*-latest) echo "debian-stretch-obs-latest" ;; + osmo-*-latest) echo "debian-bullseye-obs-latest" ;; osmo-*) echo "debian-bullseye-build" ;; ttcn3-*) echo "debian-bullseye-titan" ;; esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1230e87784bc21b5a6424db0bd8734181ead9bfd Gerrit-Change-Number: 26597 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:09:06 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 12:09:06 +0000 Subject: Change in docker-playground[master]: debian-bullseye-obs-latest: new image In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26597 ) Change subject: debian-bullseye-obs-latest: new image ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1230e87784bc21b5a6424db0bd8734181ead9bfd Gerrit-Change-Number: 26597 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 12:09:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:09:31 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 12:09:31 +0000 Subject: Change in docker-playground[master]: debian-bullseye-obs-latest: new image In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26597 ) Change subject: debian-bullseye-obs-latest: new image ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1230e87784bc21b5a6424db0bd8734181ead9bfd Gerrit-Change-Number: 26597 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 12:09:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:09:34 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 12:09:34 +0000 Subject: Change in docker-playground[master]: debian-bullseye-obs-latest: new image In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26597 ) Change subject: debian-bullseye-obs-latest: new image ...................................................................... debian-bullseye-obs-latest: new image Add missing container for -latest tests. Currently this causes the -latest tests to fail. Related: OS#4969 Change-Id: I1230e87784bc21b5a6424db0bd8734181ead9bfd --- A debian-bullseye-obs-latest/Dockerfile A debian-bullseye-obs-latest/Makefile M jenkins-common.sh 3 files changed, 30 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved osmith: Verified diff --git a/debian-bullseye-obs-latest/Dockerfile b/debian-bullseye-obs-latest/Dockerfile new file mode 100644 index 0000000..fb8cd93 --- /dev/null +++ b/debian-bullseye-obs-latest/Dockerfile @@ -0,0 +1,26 @@ +ARG REGISTRY=docker.io +ARG UPSTREAM_DISTRO=debian:bullseye +FROM ${REGISTRY}/${UPSTREAM_DISTRO} +# Arguments used after FROM must be specified again +ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" +ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" +ARG OSMOCOM_REPO="${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/latest/Debian_11/" + +RUN apt-get update && \ + apt-get upgrade -y && \ + apt-get install -y --no-install-recommends \ + telnet \ + gnupg \ + && \ + apt-get clean + +COPY .common/Release.key /tmp/Release.key +RUN apt-key add /tmp/Release.key && \ + rm /tmp/Release.key && \ + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-latest.list + +# Make respawn.sh part of this image, so it can be used by other images based on it +COPY .common/respawn.sh /usr/local/bin/respawn.sh + +# Invalidate cache once the repository is updated +ADD $OSMOCOM_REPO/Release /tmp/Release diff --git a/debian-bullseye-obs-latest/Makefile b/debian-bullseye-obs-latest/Makefile new file mode 100644 index 0000000..736769d --- /dev/null +++ b/debian-bullseye-obs-latest/Makefile @@ -0,0 +1,3 @@ +UPSTREAM_DISTRO=debian:bullseye +DISTRO=debian-bullseye +include ../make/Makefile diff --git a/jenkins-common.sh b/jenkins-common.sh index 5af91fb..b74b952 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -19,7 +19,7 @@ osmo-*-latest-centos8) echo "centos8-obs-latest" ;; osmo-*-centos7) echo "centos7-build" ;; osmo-*-centos8) echo "centos8-build" ;; - osmo-*-latest) echo "debian-stretch-obs-latest" ;; + osmo-*-latest) echo "debian-bullseye-obs-latest" ;; osmo-*) echo "debian-bullseye-build" ;; ttcn3-*) echo "debian-bullseye-titan" ;; esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1230e87784bc21b5a6424db0bd8734181ead9bfd Gerrit-Change-Number: 26597 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:14:19 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 12:14:19 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-start.sh: don't hardcode binary paths In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 to look at the new patch set (#2). Change subject: ttcn3-tcpdump-start.sh: don't hardcode binary paths ...................................................................... ttcn3-tcpdump-start.sh: don't hardcode binary paths After replacing debian-stretch-titan with debian-bullseye-titan, tcpdump does not run anymore, the binary is in /usr/bin and not in /usr/sbin. Related: OS#4969 Change-Id: I18c88c45c7522c1120ca42cd48d67fe8f155cd39 --- M ttcn3-tcpdump-start.sh 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/26591/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c88c45c7522c1120ca42cd48d67fe8f155cd39 Gerrit-Change-Number: 26591 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:14:27 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 12:14:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-start.sh: don't hardcode binary paths In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 ) Change subject: ttcn3-tcpdump-start.sh: don't hardcode binary paths ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591/1/ttcn3-tcpdump-start.sh File ttcn3-tcpdump-start.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591/1/ttcn3-tcpdump-start.sh at 5 PS1, Line 5: DUMPCAP=/usr/bin/dumpcap > You can problably do the same here. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591/1/ttcn3-tcpdump-start.sh at 8 PS1, Line 8: NETCAT=/bin/nc > and here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c88c45c7522c1120ca42cd48d67fe8f155cd39 Gerrit-Change-Number: 26591 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 12:14:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:16:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 12:16:48 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-start.sh: don't hardcode binary paths In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 ) Change subject: ttcn3-tcpdump-start.sh: don't hardcode binary paths ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c88c45c7522c1120ca42cd48d67fe8f155cd39 Gerrit-Change-Number: 26591 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 12:16:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:17:45 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 12:17:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-start.sh: don't hardcode binary paths In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 ) Change subject: ttcn3-tcpdump-start.sh: don't hardcode binary paths ...................................................................... ttcn3-tcpdump-start.sh: don't hardcode binary paths After replacing debian-stretch-titan with debian-bullseye-titan, tcpdump does not run anymore, the binary is in /usr/bin and not in /usr/sbin. Related: OS#4969 Change-Id: I18c88c45c7522c1120ca42cd48d67fe8f155cd39 --- M ttcn3-tcpdump-start.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh index e905d8a..9b7a8b5 100755 --- a/ttcn3-tcpdump-start.sh +++ b/ttcn3-tcpdump-start.sh @@ -1,11 +1,11 @@ #!/bin/sh PIDFILE_PCAP=/tmp/pcap.pid -TCPDUMP=/usr/sbin/tcpdump -DUMPCAP=/usr/bin/dumpcap +TCPDUMP=$(command -v tcpdump) +DUMPCAP=$(command -v dumpcap) PIDFILE_NETCAT=/tmp/netcat.pid -NETCAT=/bin/nc +NETCAT=$(command -v nc) GSMTAP_PORT=4729 TESTCASE=$1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c88c45c7522c1120ca42cd48d67fe8f155cd39 Gerrit-Change-Number: 26591 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:23:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 12:23:41 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: install ping In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26593 ) Change subject: debian-bullseye-titan: install ping ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I46cf22e7eab7dcd4b3835a8c7aa48654aef6c65a Gerrit-Change-Number: 26593 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 12:23:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:24:21 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 12:24:21 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-start.sh: don't hardcode binary paths In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 ) Change subject: ttcn3-tcpdump-start.sh: don't hardcode binary paths ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c88c45c7522c1120ca42cd48d67fe8f155cd39 Gerrit-Change-Number: 26591 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 12:24:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 12:26:21 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 12:26:21 +0000 Subject: Change in osmo-hnodeb[master]: rtp: Use dynamic Payload Type 96 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26596 ) Change subject: rtp: Use dynamic Payload Type 96 ...................................................................... Patch Set 1: Code-Review+2 Looks good, as 96 has no overlap with other RTP PT allocated by 3GPP such as those listed in 48.103 for AoIP (110..121). -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6ca83c274200d8fc0fb3d8914e970b05df91f6ea Gerrit-Change-Number: 26596 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 16 Dec 2021 12:26:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 13:37:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 16 Dec 2021 13:37:59 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: sort pkgs alphabetically In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26592 ) Change subject: debian-bullseye-titan: sort pkgs alphabetically ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id5e1d6a3a1705234f25e7c346e2fcf1d3741570d Gerrit-Change-Number: 26592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 13:37:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 13:38:59 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 16 Dec 2021 13:38:59 +0000 Subject: Change in docker-playground[master]: Add Dockerfile for OpenBTS-UMTS In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26574 ) Change subject: Add Dockerfile for OpenBTS-UMTS ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibbab5973b84047ee7654a5fb2a8e4b36e1d43847 Gerrit-Change-Number: 26574 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 16 Dec 2021 13:38:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 13:39:02 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 16 Dec 2021 13:39:02 +0000 Subject: Change in docker-playground[master]: Add Dockerfile for OpenBTS-UMTS In-Reply-To: References: Message-ID: fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26574 ) Change subject: Add Dockerfile for OpenBTS-UMTS ...................................................................... Add Dockerfile for OpenBTS-UMTS Change-Id: Ibbab5973b84047ee7654a5fb2a8e4b36e1d43847 --- A openbts-umts/Dockerfile A openbts-umts/Makefile 2 files changed, 69 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Verified diff --git a/openbts-umts/Dockerfile b/openbts-umts/Dockerfile new file mode 100644 index 0000000..b3fd386 --- /dev/null +++ b/openbts-umts/Dockerfile @@ -0,0 +1,64 @@ +# See https://fairwaves.co/blog/openbts-umts-3g-umtrx/ + +# Ancient software requires ancient distro +FROM debian:jessie + +MAINTAINER Vadim Yanitskiy + +RUN apt-get update && \ + apt-get install -y --no-install-recommends \ + --no-install-suggests \ + ca-certificates \ + build-essential \ + pkg-config \ + debhelper \ + automake \ + autoconf \ + libtool-bin \ + libtool \ + unzip \ + wget \ + git \ + libboost-dev \ + libreadline6-dev \ + libusb-1.0-0-dev \ + libsqlite3-dev \ + libosip2-dev \ + libortp-dev \ + libzmq3-dev \ + python-zmq \ + libuhd-dev + +WORKDIR /home/root + +# Download and install UHD firmware +ARG UHD_RELEASE="003.007.003" +RUN wget http://files.ettus.com/binaries/maint_images/archive/uhd-images_$UHD_RELEASE-release.zip && \ + unzip uhd-images_$UHD_RELEASE-release.zip && \ + cp -r uhd-images_$UHD_RELEASE-release/share/uhd/ /usr/share/ + +# Install asn1c +ARG ASN1C_COMMIT="80b3752c8093251a1ef924097e9894404af2d304" +RUN git clone https://github.com/vlm/asn1c.git +RUN cd asn1c && \ + git checkout $ASN1C_COMMIT && \ + ./configure && \ + make install + +# Install libcoredumper +RUN git clone https://github.com/RangeNetworks/libcoredumper.git +RUN cd libcoredumper && \ + ./build.sh && \ + dpkg -i libcoredumper*.deb + +# Finally, install OpenBTS-UMTS +RUN git clone https://github.com/RangeNetworks/OpenBTS-UMTS.git +RUN cd OpenBTS-UMTS && \ + git submodule init && \ + git submodule update && \ + ./autogen.sh && \ + ./configure && \ + make install && \ + make clean + +CMD cd /OpenBTS/ && ./OpenBTS-UMTS diff --git a/openbts-umts/Makefile b/openbts-umts/Makefile new file mode 100644 index 0000000..b030a43 --- /dev/null +++ b/openbts-umts/Makefile @@ -0,0 +1,5 @@ +RUN_ARGS?= \ + --privileged \ + -v /dev/bus/usb:/dev/bus/usb + +include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibbab5973b84047ee7654a5fb2a8e4b36e1d43847 Gerrit-Change-Number: 26574 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 13:39:18 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 16 Dec 2021 13:39:18 +0000 Subject: Change in libosmo-netif[master]: prim: return last error code In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26594 ) Change subject: prim: return last error code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic0f8b313ab9a8de597d8bb6db76e9883bc6009a0 Gerrit-Change-Number: 26594 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 16 Dec 2021 13:39:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 13:41:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 16 Dec 2021 13:41:05 +0000 Subject: Change in osmo-hnodeb[master]: Fix several Coverity found issues In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 ) Change subject: Fix several Coverity found issues ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595/1/src/osmo-hnodeb/gtp.c File src/osmo-hnodeb/gtp.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595/1/src/osmo-hnodeb/gtp.c at 193 PS1, Line 193: LOGUE(ue Is LOGUE NULL-safe? I guess you want to use LOGP here, like above. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6d73a970919889953539fbacc601d679d7ec4113 Gerrit-Change-Number: 26595 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 16 Dec 2021 13:41:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 14:26:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 14:26:51 +0000 Subject: Change in libosmo-netif[master]: prim: return last error code In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/26594 ) Change subject: prim: return last error code ...................................................................... prim: return last error code Closes: Coverity CID#242768 Change-Id: Ic0f8b313ab9a8de597d8bb6db76e9883bc6009a0 --- M src/prim.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/prim.c b/src/prim.c index 5189c4c..d26954c 100644 --- a/src/prim.c +++ b/src/prim.c @@ -166,7 +166,7 @@ prim_resp = _sap_ctl_makeprim_hello_cnf(hello_ind->sapi, (uint16_t)rc); LOGSRV(prim_srv, LOGL_INFO, "Tx CTL-HELLO.cnf SAPI=%u API_VERSION=%u\n", hello_ind->sapi, prim_resp->u.hello_cnf.api_version); - osmo_prim_srv_send(prim_srv, prim_resp->hdr.msg); + rc = osmo_prim_srv_send(prim_srv, prim_resp->hdr.msg); return rc; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/26594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic0f8b313ab9a8de597d8bb6db76e9883bc6009a0 Gerrit-Change-Number: 26594 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 14:27:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 14:27:19 +0000 Subject: Change in osmo-hnodeb[master]: Fix several Coverity found issues In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 ) Change subject: Fix several Coverity found issues ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595/1/src/osmo-hnodeb/gtp.c File src/osmo-hnodeb/gtp.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595/1/src/osmo-hnodeb/gtp.c at 193 PS1, Line 193: LOGUE(ue > Is LOGUE NULL-safe? I guess you want to use LOGP here, like above. LOGUE is safely non-null here. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6d73a970919889953539fbacc601d679d7ec4113 Gerrit-Change-Number: 26595 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 16 Dec 2021 14:27:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 15:11:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 15:11:46 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Set proper CRC Header for ACK Initialization References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26598 ) Change subject: mgcp_network.c: Set proper CRC Header for ACK Initialization ...................................................................... mgcp_network.c: Set proper CRC Header for ACK Initialization Discovered while debugging wireshark CRC calculation and implementing new IuUP code in libosmocore. Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/98/26598/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 2d275ec..264e263 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1225,6 +1225,7 @@ if (data[0] == 0xe0) { data[0] = 0xe4; data[1] = 0x00; + data[2] = 0x09; /* Patch CRC Header to adapt to new header above */ rtp_state->patched_first_rtp_payload = true; LOGPENDP(endp, DRTP, LOGL_DEBUG, "Patching over first two bytes" -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f Gerrit-Change-Number: 26598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 15:24:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 15:24:18 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Set proper CRC Header for ACK Initialization In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26598 ) Change subject: mgcp_network.c: Set proper CRC Header for ACK Initialization ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f Gerrit-Change-Number: 26598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 16 Dec 2021 15:24:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 15:24:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 15:24:37 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: sort pkgs alphabetically In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26592 ) Change subject: debian-bullseye-titan: sort pkgs alphabetically ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id5e1d6a3a1705234f25e7c346e2fcf1d3741570d Gerrit-Change-Number: 26592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 15:24:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 15:25:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 15:25:13 +0000 Subject: Change in osmo-hnodeb[master]: Fix several Coverity found issues In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 ) Change subject: Fix several Coverity found issues ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6d73a970919889953539fbacc601d679d7ec4113 Gerrit-Change-Number: 26595 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 16 Dec 2021 15:25:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 15:25:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 15:25:32 +0000 Subject: Change in osmo-hnodeb[master]: Update AUDIO and GTP SAPs to support multiple conns per UE In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 ) Change subject: Update AUDIO and GTP SAPs to support multiple conns per UE ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ib3f60d5ba21defe5259c25e2034fc2217c4d93df Gerrit-Change-Number: 26570 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 16 Dec 2021 15:25:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 15:32:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 15:32:51 +0000 Subject: Change in osmo-hnodeb[master]: Fix several Coverity found issues In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 ) Change subject: Fix several Coverity found issues ...................................................................... Fix several Coverity found issues Closes: CID#242770 Closes: CID#242769 Closes: CID#242767 Change-Id: I6d73a970919889953539fbacc601d679d7ec4113 --- M src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/rua.c 2 files changed, 11 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c index 4695ea9..b8bfebc 100644 --- a/src/osmo-hnodeb/gtp.c +++ b/src/osmo-hnodeb/gtp.c @@ -45,14 +45,15 @@ { struct hnb_gtp_prim *gtp_prim; struct hnb_ue *ue = lib->priv; - struct hnb *hnb = ue->hnb; + struct hnb *hnb; int rc; if (!ue || !ue->conn_ps.active) { - LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", + LOGP(DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", packet, len); return -EINVAL; } + hnb = ue->hnb; LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len); gtp_prim = hnb_gtp_makeprim_conn_data_ind(ue->conn_id, ue->conn_ps.local_tei, packet, len); @@ -180,18 +181,19 @@ int hnb_ue_gtp_tx(struct hnb_ue *ue, void *gtpu_payload, unsigned gtpu_payload_len) { int rc; - struct hnb *hnb = ue->hnb; - - if (!hnb->gtp.gsn) { - LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n"); - return -EINVAL; - } + struct hnb *hnb; if (!ue || !ue->conn_ps.pdp_lib) { LOGUE(ue, DGTP, LOGL_ERROR, "Tx: UE PDP Ctx not available\n"); return -EINVAL; } + hnb = ue->hnb; + if (!hnb->gtp.gsn) { + LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n"); + return -EINVAL; + } + rc = gtp_data_req(hnb->gtp.gsn, ue->conn_ps.pdp_lib, gtpu_payload, gtpu_payload_len); return rc; } diff --git a/src/osmo-hnodeb/rua.c b/src/osmo-hnodeb/rua.c index 3a73f0c..5b225de 100644 --- a/src/osmo-hnodeb/rua.c +++ b/src/osmo-hnodeb/rua.c @@ -140,6 +140,7 @@ case RUA_ProcedureCode_id_DirectTransfer: LOGP(DRUA, LOGL_INFO, "RUA rx Initiating DirectTransfer\n"); hnb_rua_dt_handle(hnb, &init->value); + break; default: LOGP(DRUA, LOGL_INFO, "RUA rx unknown Initiating message\n"); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6d73a970919889953539fbacc601d679d7ec4113 Gerrit-Change-Number: 26595 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 15:59:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 16 Dec 2021 15:59:51 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 9: (2 comments) > Patch Set 9: Code-Review-1 > > (3 comments) > > Maybe the thing here is that I don't really see the point in having that done for all TCP sockets. Specially not by default. IMHO the app should specifically allocate and register specific sats_tcp-entry to the API and then they would become available. > If then you still want to have somehow a possibility to get all the sockets registered automatically (which I don't see the point), then one may register those as done here but have it disabled by default. This is what I suggested. Simply have the timer be '0' by default, thereby disabling the entire mechanism. But in this case there's going to be no hood "name" or "description" to show for those, well maybe yes, by printing rem_addr:rem_port<->local_addr:local_port or alike on its stats name exactly. So I think we move ahead as described above: register/unregister happens automatically, but the TCP_INFO is not called as the timer is inactive unless the user explicitly requests it via VTY.. The multithread question of course also still needs to be resolved. https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/stats_tcp.c File src/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/stats_tcp.c at 194 PS9, Line 194: return; > return error? agreed https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/stats_tcp.c at 210 PS9, Line 210: void osmo_stats_tcp_osmo_fd_unregister(const struct osmo_fd *fd) > By exposing struct stats_tcp_entry and using it as a param, you convert these functions from O(n) to [?] yes, but I don't think it matters all that much. Registering/unregistering sockets is something we don't do that frequently compared to processing packets on any of those sockets. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 16 Dec 2021 15:59:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:02:15 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 16:02:15 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: install ping In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26593 ) Change subject: debian-bullseye-titan: install ping ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I46cf22e7eab7dcd4b3835a8c7aa48654aef6c65a Gerrit-Change-Number: 26593 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 16:02:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:02:20 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 16:02:20 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: sort pkgs alphabetically In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26592 ) Change subject: debian-bullseye-titan: sort pkgs alphabetically ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id5e1d6a3a1705234f25e7c346e2fcf1d3741570d Gerrit-Change-Number: 26592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 16:02:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:02:24 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 16:02:24 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: sort pkgs alphabetically In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26592 ) Change subject: debian-bullseye-titan: sort pkgs alphabetically ...................................................................... debian-bullseye-titan: sort pkgs alphabetically Change-Id: Id5e1d6a3a1705234f25e7c346e2fcf1d3741570d --- M debian-bullseye-titan/Dockerfile 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Verified diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile index bf99534..1d5c1cd 100644 --- a/debian-bullseye-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -27,13 +27,13 @@ DEBIAN_FRONTEND='noninteractive' apt-get install -y --no-install-recommends --no-install-suggests \ build-essential \ git \ - procps \ - tcpdump \ - wireshark-common \ - vim \ netcat-openbsd \ - python3-setuptools \ + procps \ python3-pip \ + python3-setuptools \ + tcpdump \ + vim \ + wireshark-common \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id5e1d6a3a1705234f25e7c346e2fcf1d3741570d Gerrit-Change-Number: 26592 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:02:25 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 16:02:25 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: install ping In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26593 ) Change subject: debian-bullseye-titan: install ping ...................................................................... debian-bullseye-titan: install ping Add ping, so ttcn3-tcpdump-start.sh from osmo-ttcn3-hacks.git works as expected. It is supposed to wait until tcpdump is properly capturing packets, by generating dummy packets with ping and waiting until the pcap file gains size. However since ping is currently not installed, it will just wait 10 seconds before executing tests. Fix for: Waiting for packet dumper to start... 0 Waiting for packet dumper to start... 1 Waiting for packet dumper to start... 2 Waiting for packet dumper to start... 3 Waiting for packet dumper to start... 4 Waiting for packet dumper to start... 5 Waiting for packet dumper to start... 6 Waiting for packet dumper to start... 7 Waiting for packet dumper to start... 8 Waiting for packet dumper to start... 9 Related: OS#4969 Change-Id: I46cf22e7eab7dcd4b3835a8c7aa48654aef6c65a --- M debian-bullseye-titan/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Verified diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile index 1d5c1cd..0b1fbda 100644 --- a/debian-bullseye-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -27,6 +27,7 @@ DEBIAN_FRONTEND='noninteractive' apt-get install -y --no-install-recommends --no-install-suggests \ build-essential \ git \ + inetutils-ping \ netcat-openbsd \ procps \ python3-pip \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I46cf22e7eab7dcd4b3835a8c7aa48654aef6c65a Gerrit-Change-Number: 26593 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:05:45 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 16:05:45 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Adapt HNBLIF to latest changes In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26571 ) Change subject: hnodeb: Adapt HNBLIF to latest changes ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50a1b9be579ace9f0f85c6c68b5648d504f5f51c Gerrit-Change-Number: 26571 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 16 Dec 2021 16:05:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Dec 16 16:09:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 16:09:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <61bb64c1c8820_4b3e2b08e03926001137f4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 46s] checking for LIBASN1C... yes [ 46s] checking for LIBOSMOCORE... yes [ 46s] checking for LIBOSMOVTY... yes [ 46s] checking for LIBOSMOCTRL... yes [ 46s] checking for LIBOSMOGSM... yes [ 46s] checking for LIBOSMOABIS... yes [ 46s] checking for LIBOSMOTRAU... no [ 46s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 46s] [ 46s] Package 'libosmotrau', required by 'virtual:world', not found [ 46s] [ 46s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 46s] installed software in a non-standard prefix. [ 46s] [ 46s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 46s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 46s] See the pkg-config man page for more details. [ 46s] error: Bad exit status from /var/tmp/rpm-tmp.GvVlzP (%build) [ 46s] [ 46s] [ 46s] RPM build errors: [ 46s] Bad exit status from /var/tmp/rpm-tmp.GvVlzP (%build) [ 46s] ### VM INTERACTION START ### [ 49s] [ 41.083020][ T437] sysrq: Power Off [ 49s] [ 41.127401][ T16] reboot: Power down [ 49s] ### VM INTERACTION END ### [ 49s] [ 49s] lamb05 failed "build osmo-hnodeb.spec" at Thu Dec 16 16:09:01 UTC 2021. [ 49s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:10:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 16:10:41 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 9: See my last comment. I would totally decouple registering stats for sockets from the fd register/unregister mainloop mechanism. If you still like it the other way, let's do it as you suggest. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 9 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 16 Dec 2021 16:10:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:31:36 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 16 Dec 2021 16:31:36 +0000 Subject: Change in osmo-hnodeb[master]: Update AUDIO and GTP SAPs to support multiple conns per UE In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 ) Change subject: Update AUDIO and GTP SAPs to support multiple conns per UE ...................................................................... Patch Set 2: Code-Review+1 (1 comment) not sure if the unresolved TODO is intentional, rest looks good. https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570/2/src/osmo-hnodeb/gtp.c File src/osmo-hnodeb/gtp.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570/2/src/osmo-hnodeb/gtp.c at 185 PS2, Line 185: conn->id = next_gtp_conn_id++; /* TODO: validate next one is not already taken due to wrap-around */ unresolved TODO, do you want to leave it? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ib3f60d5ba21defe5259c25e2034fc2217c4d93df Gerrit-Change-Number: 26570 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 16 Dec 2021 16:31:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:39:25 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 16:39:25 +0000 Subject: Change in osmo-hnodeb[master]: Update AUDIO and GTP SAPs to support multiple conns per UE In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 ) Change subject: Update AUDIO and GTP SAPs to support multiple conns per UE ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570/2/src/osmo-hnodeb/gtp.c File src/osmo-hnodeb/gtp.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570/2/src/osmo-hnodeb/gtp.c at 185 PS2, Line 185: conn->id = next_gtp_conn_id++; /* TODO: validate next one is not already taken due to wrap-around */ > unresolved TODO, do you want to leave it? Yes it's intentional. The libgtp stuff will go away anyway and this code will be re-done in the near future. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ib3f60d5ba21defe5259c25e2034fc2217c4d93df Gerrit-Change-Number: 26570 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 16:39:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:39:28 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 16:39:28 +0000 Subject: Change in osmo-hnodeb[master]: Update AUDIO and GTP SAPs to support multiple conns per UE In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 ) Change subject: Update AUDIO and GTP SAPs to support multiple conns per UE ...................................................................... Update AUDIO and GTP SAPs to support multiple conns per UE This is needed for instance: * AUDIO: video calls * GTP: secondary pdp contexts For better abstraction, now both AUDIO and GTP conns use unique ID namespaces, and one ID is used to identify each one. Each conn relate in turn to a UE since a context_id is passed during connection establishment. Related: SYS#5516 Change-Id: Ib3f60d5ba21defe5259c25e2034fc2217c4d93df --- M doc/hnodeb.msc M include/osmocom/hnodeb/gtp.h M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/hnodeb.h M include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/rtp.h M src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk_audio.c M src/osmo-hnodeb/llsk_gtp.c M src/osmo-hnodeb/rtp.c 11 files changed, 265 insertions(+), 177 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/doc/hnodeb.msc b/doc/hnodeb.msc index 6ad6e7c..10de180 100644 --- a/doc/hnodeb.msc +++ b/doc/hnodeb.msc @@ -43,19 +43,19 @@ --- [ label = "Subscriber set up PS data:" ]; hnodeb <= hnbgw [label="RANAP RAB-Assignment Request(TEI, ADDR)"]; trx <= hnodeb [label="IUH-CONN_DATA.ind[RANAP RAB-Assignment Request(remote_ip, remote_port, remote_tei)]"]; - trx => hnodeb [label="GTP-CONN_ESTABLISH.req(remote_ip,remote_port,remote_tei)"]; + trx => hnodeb [label="GTP-CONN_ESTABLISH.req(context_id,remote_ip,remote_port,remote_tei)"]; ... [ label = "HnodeB sets up GTP-U connection" ]; - trx <= hnodeb [label="GTP-CONN_ESTABLISH.cnf(local_ip,local_port,local_tei,remote_tei)"]; + trx <= hnodeb [label="GTP-CONN_ESTABLISH.cnf(context_id,gtp_conn_id,local_ip,local_port,local_tei)"]; |||; ...; |||; |||; --- [ label = "PS data transmission over GTP-U:" ]; ue => trx [label="..."]; - trx => hnodeb [label="GTP-CONN_DATA.req[remote_tei,payload]"]; + trx => hnodeb [label="GTP-CONN_DATA.req[gtp_conn_id,payload]"]; hnodeb => ggsn [label="GTP-U(remote_tei, local_addr, remote_addr, payload)"]; hnodeb <= ggsn [label="GTP-U(local_tei, remote_addr, local_addr, payload)"]; - trx <= hnodeb [label="GTP-CONN_DATA.ind[local_tei,payload]"]; + trx <= hnodeb [label="GTP-CONN_DATA.ind[gtp_conn_id,payload]"]; ue <= trx [label="..."]; |||; ...; @@ -67,7 +67,7 @@ hnodeb <= hnbgw [label="RANAP IU Release Command"]; trx <= hnodeb [label="IUH-CONN_DATA.ind[RANAP IU Release Command]"]; ...; - trx => hnodeb [label="GTP-CONN_RELEASE.req(remote_tei)"]; + trx => hnodeb [label="GTP-CONN_RELEASE.req(gtp_conn_id)"]; trx => hnodeb [label="IUH-CONN_RELEASE.req[RANAP IU Release Complete]"]; hnodeb => hnbgw [label="RUA-Disconnect(RANAP IU Release Complete)"]; diff --git a/include/osmocom/hnodeb/gtp.h b/include/osmocom/hnodeb/gtp.h index af9e007..477e82b 100644 --- a/include/osmocom/hnodeb/gtp.h +++ b/include/osmocom/hnodeb/gtp.h @@ -18,7 +18,11 @@ */ #pragma once +#include +#include + #include +#include struct hnb; struct hnb_ue; @@ -26,7 +30,19 @@ int hnb_gtp_bind(struct hnb *hnb); void hnb_gtp_unbind(struct hnb *hnb); -int hnb_ue_gtp_bind(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei, - struct osmo_sockaddr *loc_addr, uint32_t *loc_tei); -int hnb_ue_gtp_unbind(struct hnb_ue *ue); -int hnb_ue_gtp_tx(struct hnb_ue *ue, void *gtpu_payload, unsigned gtpu_payload_len); +struct gtp_conn { + struct llist_head list; /* Item in struct hnb->ue_list */ + struct hnb_ue *ue; /* backpointer */ + uint32_t id; + struct osmo_sockaddr loc_addr; + struct osmo_sockaddr rem_addr; + uint32_t loc_tei; + uint32_t rem_tei; + struct pdp_t *pdp_lib; +}; + +struct gtp_conn *gtp_conn_alloc(struct hnb_ue *ue); +void gtp_conn_free(struct gtp_conn *conn); + +int gtp_conn_setup(struct gtp_conn *conn, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei); +int gtp_conn_tx(struct gtp_conn *conn, void *gtpu_payload, unsigned gtpu_payload_len); diff --git a/include/osmocom/hnodeb/hnb_prim.h b/include/osmocom/hnodeb/hnb_prim.h index f0e3a96..0b0a545 100644 --- a/include/osmocom/hnodeb/hnb_prim.h +++ b/include/osmocom/hnodeb/hnb_prim.h @@ -197,6 +197,7 @@ /* HNB_AUDIO_PRIM_CONN_ESTABLISH, DL */ struct hnb_audio_conn_establish_cnf_param { uint32_t context_id; + uint32_t audio_conn_id; uint16_t local_rtp_port; uint8_t error_code; /* 0 = success, !0 = failure */ uint8_t local_rtp_address_type; /* enum u_addr_type */ @@ -205,19 +206,19 @@ /* HNB_AUDIO_PRIM_CONN_RELEASE, UL */ struct hnb_audio_conn_release_req_param { - uint32_t context_id; + uint32_t audio_conn_id; } __attribute__ ((packed)); /* HNB_AUDIO_PRIM_CONN_DATA, UL */ struct hnb_audio_conn_data_req_param { - uint32_t context_id; + uint32_t audio_conn_id; uint32_t data_len; /* RTP payload length in bytes */ uint8_t data[0]; /* RTP payload (aka IP packet) */ } __attribute__ ((packed)); /* HNB_AUDIO_PRIM_CONN_DATA, DL */ struct hnb_audio_conn_data_ind_param { - uint32_t context_id; + uint32_t audio_conn_id; uint32_t data_len; /* RTP payload length in bytes */ uint8_t data[0]; /* RTP payload (aka IP packet) */ } __attribute__ ((packed)); @@ -256,6 +257,7 @@ /* HNB_GTP_PRIM_CONN_ESTABLISH, DL */ struct hnb_gtp_conn_establish_cnf_param { uint32_t context_id; + uint32_t gtp_conn_id; uint32_t local_tei; uint8_t error_code; /* 0 = success, !0 = failure */ uint8_t local_gtpu_address_type; /* enum u_addr_type */ @@ -264,28 +266,19 @@ /* HNB_GTP_PRIM_CONN_RELEASE, UL */ struct hnb_gtp_conn_release_req_param { - uint32_t context_id; - uint32_t remote_tei; -} __attribute__ ((packed)); - -/* HNB_GTP_PRIM_CONN_RELEASE, DL */ -struct hnb_gtp_conn_release_ind_param { - uint32_t context_id; - uint32_t local_tei; + uint32_t gtp_conn_id; } __attribute__ ((packed)); /* HNB_GTP_PRIM_CONN_DATA, DL */ struct hnb_gtp_conn_data_ind_param { - uint32_t context_id; - uint32_t local_tei; + uint32_t gtp_conn_id; uint32_t data_len; /* GTP-U payload length in bytes */ uint8_t data[0]; /* GTP-U payload (aka IP packet) */ } __attribute__ ((packed)); /* HNB_GTP_PRIM_CONN_DATA, UL */ struct hnb_gtp_conn_data_req_param { - uint32_t context_id; - uint32_t remote_tei; + uint32_t gtp_conn_id; uint32_t data_len; /* GTP-U payload length in bytes */ uint8_t data[0]; /* GTP-U payload (aka IP packet) */ } __attribute__ ((packed)); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 52d1bec..82b43c3 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -35,9 +35,6 @@ #include #include -#include -#include - #include enum { @@ -62,16 +59,12 @@ struct hnb_ue_cs_ctx { bool active; /* Is this chan in use? */ bool conn_est_cnf_pending; /* Did we send CONN_ESTABLISH_CNF to lower layers? */ - struct { - struct osmo_rtp_socket *socket; - } rtp; + struct llist_head conn_list; /* list of struct rtp_conn */ } conn_cs; struct hnb_ue_ps_ctx { bool active; /* Is this chan in use? */ bool conn_est_cnf_pending; /* Did we send CONN_ESTABLISH_CNF to lower layers? */ - uint32_t local_tei; - uint32_t remote_tei; - struct pdp_t *pdp_lib; + struct llist_head conn_list; /* list of struct gtp_conn */ } conn_ps; }; struct hnb_ue *hnb_ue_alloc(struct hnb *hnb, uint32_t conn_id); @@ -132,9 +125,11 @@ struct hnb *hnb_alloc(void *tall_ctx); void hnb_free(struct hnb *hnb); struct hnb_ue *hnb_find_ue_by_id(const struct hnb *hnb, uint32_t conn_id); -struct hnb_ue *hnb_find_ue_by_tei(const struct hnb *hnb, uint32_t tei, bool is_remote); struct hnb_ue *hnb_find_ue_by_imsi(const struct hnb *hnb, char *imsi); +struct rtp_conn *hnb_find_rtp_conn_by_id(const struct hnb *hnb, uint32_t audio_conn_id); +struct gtp_conn *hnb_find_gtp_conn_by_id(const struct hnb *hnb, uint32_t gtp_conn_id); + extern void *tall_hnb_ctx; extern struct hnb *g_hnb; diff --git a/include/osmocom/hnodeb/llsk.h b/include/osmocom/hnodeb/llsk.h index 6d98cd0..fe1dce1 100644 --- a/include/osmocom/hnodeb/llsk.h +++ b/include/osmocom/hnodeb/llsk.h @@ -27,7 +27,7 @@ #include struct hnb; -struct hnb_ue; +struct rtp_conn; int hnb_llsk_alloc(struct hnb *hnb); bool hnb_llsk_connected(const struct hnb *hnb); @@ -53,9 +53,8 @@ extern const struct value_string hnb_audio_prim_type_names[]; int llsk_rx_audio(struct hnb *hnb, struct osmo_prim_hdr *oph); -int llsk_audio_tx_conn_data_ind(struct hnb_ue *ue, const uint8_t *payload, uint32_t len); +int llsk_audio_tx_conn_data_ind(struct rtp_conn *conn, const uint8_t *payload, uint32_t len); extern const struct value_string hnb_gtp_prim_type_names[]; int llsk_rx_gtp(struct hnb *hnb, struct osmo_prim_hdr *oph); -struct hnb_gtp_prim *hnb_gtp_makeprim_conn_data_ind(uint32_t context_id, uint32_t local_tei, - const uint8_t *data, uint32_t data_len); +struct hnb_gtp_prim *hnb_gtp_makeprim_conn_data_ind(uint32_t gtp_conn_id, const uint8_t *data, uint32_t data_len); diff --git a/include/osmocom/hnodeb/rtp.h b/include/osmocom/hnodeb/rtp.h index 01ec1c4..8035175 100644 --- a/include/osmocom/hnodeb/rtp.h +++ b/include/osmocom/hnodeb/rtp.h @@ -19,9 +19,21 @@ #pragma once #include +#include struct hnb; struct hnb_ue; -int hnb_ue_voicecall_setup(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, struct osmo_sockaddr *loc_addr); -int hnb_ue_voicecall_release(struct hnb_ue *ue); +struct rtp_conn { + struct llist_head list; /* Item in struct hnb->ue_list */ + struct hnb_ue *ue; /* backpointer */ + uint32_t id; + struct osmo_rtp_socket *socket; + struct osmo_sockaddr loc_addr; + struct osmo_sockaddr rem_addr; +}; + +struct rtp_conn *rtp_conn_alloc(struct hnb_ue *ue); +void rtp_conn_free(struct rtp_conn *conn); + +int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr); diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c index b8bfebc..22d4074 100644 --- a/src/osmo-hnodeb/gtp.c +++ b/src/osmo-hnodeb/gtp.c @@ -27,8 +27,38 @@ #include #include +static uint32_t next_gtp_conn_id = 0; + +struct gtp_conn *gtp_conn_alloc(struct hnb_ue *ue) +{ + struct gtp_conn *conn; + + conn = talloc_zero(ue, struct gtp_conn); + if (!conn) + return NULL; + + conn->ue = ue; + + llist_add(&conn->list, &ue->conn_ps.conn_list); + + return conn; +} + +void gtp_conn_free(struct gtp_conn *conn) +{ + if (!conn) + return; + + if (conn->pdp_lib) { + pdp_freepdp(conn->pdp_lib); + conn->pdp_lib = NULL; + } + llist_del(&conn->list); + talloc_free(conn); +} + /* Get osa of locally bound GTP-U socket */ -int sk_get_bound_addr(int fd, struct osmo_sockaddr *osa) +static int sk_get_bound_addr(int fd, struct osmo_sockaddr *osa) { int rc; socklen_t alen = sizeof(*osa); @@ -44,19 +74,21 @@ static int hnb_gtp_cb_data_ind(struct pdp_t *lib, void *packet, unsigned int len) { struct hnb_gtp_prim *gtp_prim; - struct hnb_ue *ue = lib->priv; + struct gtp_conn *conn = lib->priv; + struct hnb_ue *ue; struct hnb *hnb; int rc; - if (!ue || !ue->conn_ps.active) { - LOGP(DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", + if (!conn || !conn->ue->conn_ps.active) { + LOGUE(conn->ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", packet, len); return -EINVAL; } + ue = conn->ue; hnb = ue->hnb; LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len); - gtp_prim = hnb_gtp_makeprim_conn_data_ind(ue->conn_id, ue->conn_ps.local_tei, packet, len); + gtp_prim = hnb_gtp_makeprim_conn_data_ind(conn->id, packet, len); if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { LOGUE(ue, DGTP, LOGL_ERROR, "Failed Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len); @@ -130,10 +162,10 @@ hnb->gtp.fd1u.fd = -1; } -int hnb_ue_gtp_bind(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei, - struct osmo_sockaddr *loc_addr, uint32_t *loc_tei) +int gtp_conn_setup(struct gtp_conn *conn, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei) { int rc; + struct hnb_ue *ue = conn->ue; struct hnb *hnb = ue->hnb; struct pdp_t *pdp; struct in_addr rem_in; @@ -147,15 +179,18 @@ return -ENOTSUP; } + conn->rem_addr = *rem_addr; + conn->rem_tei = rem_tei; rem_in = rem_addr->u.sin.sin_addr; + conn->id = next_gtp_conn_id++; /* TODO: validate next one is not already taken due to wrap-around */ - rc = gtp_pdp_newpdp(hnb->gtp.gsn, &pdp, ue->conn_id, 0 /* TODO: NSAPI? */, NULL); + rc = gtp_pdp_newpdp(hnb->gtp.gsn, &pdp, conn->id, 0 /* TODO: NSAPI? */, NULL); if (rc < 0) { LOGUE(ue, DGTP, LOGL_ERROR, "Failed creating PDP context: %s\n", strerror(-rc)); return rc; } - pdp->priv = ue; - ue->conn_ps.pdp_lib = pdp; + pdp->priv = conn; + conn->pdp_lib = pdp; pdp->teid_gn = rem_tei; pdp->version = 1; @@ -170,40 +205,32 @@ memcpy(pdp->gsnlu.v, &hnb->gtp.local_addr.u.sin.sin_addr, sizeof(hnb->gtp.local_addr.u.sin.sin_addr)); - *loc_addr = hnb->gtp.local_addr; + conn->loc_addr = hnb->gtp.local_addr; //loc_addr->u.sin.sin_family = AF_INET; //loc_addr->u.sin.sin_addr = hnb->gtp.gsn->gsnu; //loc_addr->u.sin.sin_port = GTP1U_PORT; - *loc_tei = pdp->teid_own; + conn->loc_tei = pdp->teid_own; return 0; } -int hnb_ue_gtp_tx(struct hnb_ue *ue, void *gtpu_payload, unsigned gtpu_payload_len) +int gtp_conn_tx(struct gtp_conn *conn, void *gtpu_payload, unsigned gtpu_payload_len) { int rc; + struct hnb_ue *ue; struct hnb *hnb; - if (!ue || !ue->conn_ps.pdp_lib) { - LOGUE(ue, DGTP, LOGL_ERROR, "Tx: UE PDP Ctx not available\n"); + if (!conn || !conn->pdp_lib) { + LOGP(DGTP, LOGL_ERROR, "Tx: PDP Ctx not available\n"); return -EINVAL; } + ue = conn->ue; hnb = ue->hnb; if (!hnb->gtp.gsn) { LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n"); return -EINVAL; } - rc = gtp_data_req(hnb->gtp.gsn, ue->conn_ps.pdp_lib, gtpu_payload, gtpu_payload_len); + rc = gtp_data_req(hnb->gtp.gsn, conn->pdp_lib, gtpu_payload, gtpu_payload_len); return rc; } - -int hnb_ue_gtp_unbind(struct hnb_ue *ue) -{ - if (!ue->conn_ps.pdp_lib) - return -EINVAL; - - pdp_freepdp(ue->conn_ps.pdp_lib); - ue->conn_ps.pdp_lib = NULL; - return 0; -} diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index b733d15..fe2f4f5 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -109,6 +109,9 @@ ue->hnb = hnb; ue->conn_id = conn_id; + INIT_LLIST_HEAD(&ue->conn_cs.conn_list); + INIT_LLIST_HEAD(&ue->conn_ps.conn_list); + llist_add(&ue->list, &hnb->ue_list); return ue; @@ -125,11 +128,17 @@ void hnb_ue_reset_chan(struct hnb_ue *ue, bool is_ps) { if (is_ps) { - hnb_ue_gtp_unbind(ue); + struct gtp_conn *conn, *conn_tmp; + llist_for_each_entry_safe(conn, conn_tmp, &ue->conn_ps.conn_list, list) + gtp_conn_free(conn); ue->conn_ps = (struct hnb_ue_ps_ctx){0}; + INIT_LLIST_HEAD(&ue->conn_ps.conn_list); } else { - hnb_ue_voicecall_release(ue); + struct rtp_conn *conn, *conn_tmp; + llist_for_each_entry_safe(conn, conn_tmp, &ue->conn_cs.conn_list, list) + rtp_conn_free(conn); ue->conn_cs = (struct hnb_ue_cs_ctx){0}; + INIT_LLIST_HEAD(&ue->conn_cs.conn_list); } } @@ -145,21 +154,6 @@ return NULL; } -struct hnb_ue *hnb_find_ue_by_tei(const struct hnb *hnb, uint32_t tei, bool is_remote) -{ - struct hnb_ue *ue; - - llist_for_each_entry(ue, &hnb->ue_list, list) { - if (!ue->conn_ps.active) - continue; - uint32_t ue_tei = is_remote ? ue->conn_ps.remote_tei : ue->conn_ps.local_tei; - if (tei != ue_tei) - continue; - return ue; - } - return NULL; -} - struct hnb_ue *hnb_find_ue_by_imsi(const struct hnb *hnb, char *imsi) { struct hnb_ue *ue; @@ -176,3 +170,35 @@ } return NULL; } + +struct rtp_conn *hnb_find_rtp_conn_by_id(const struct hnb *hnb, uint32_t audio_conn_id) +{ + struct hnb_ue *ue; + + llist_for_each_entry(ue, &hnb->ue_list, list) { + struct rtp_conn *conn; + if (!ue->conn_cs.active) + continue; + llist_for_each_entry(conn, &ue->conn_cs.conn_list, list) { + if (conn->id == audio_conn_id) + return conn; + } + } + return NULL; +} + +struct gtp_conn *hnb_find_gtp_conn_by_id(const struct hnb *hnb, uint32_t gtp_conn_id) +{ + struct hnb_ue *ue; + + llist_for_each_entry(ue, &hnb->ue_list, list) { + struct gtp_conn *conn; + if (!ue->conn_ps.active) + continue; + llist_for_each_entry(conn, &ue->conn_ps.conn_list, list) { + if (conn->id == gtp_conn_id) + return conn; + } + } + return NULL; +} diff --git a/src/osmo-hnodeb/llsk_audio.c b/src/osmo-hnodeb/llsk_audio.c index 4fa8079..7ce5c09 100644 --- a/src/osmo-hnodeb/llsk_audio.c +++ b/src/osmo-hnodeb/llsk_audio.c @@ -81,14 +81,16 @@ return (struct hnb_audio_prim *)oph; } -static struct hnb_audio_prim *hnb_audio_makeprim_conn_establish_cnf(uint32_t context_id, uint8_t error_code, - uint16_t local_rtp_port, uint8_t local_rtp_address_type, - const union u_addr *local_rtp_addr) +static struct hnb_audio_prim *hnb_audio_makeprim_conn_establish_cnf(uint32_t context_id, uint32_t audio_conn_id, + uint8_t error_code, uint16_t local_rtp_port, + uint8_t local_rtp_address_type, + const union u_addr *local_rtp_addr) { struct hnb_audio_prim *audio_prim; audio_prim = hnb_audio_prim_alloc(HNB_AUDIO_PRIM_CONN_ESTABLISH, PRIM_OP_CONFIRM, 0); audio_prim->u.conn_establish_cnf.context_id = context_id; + audio_prim->u.conn_establish_cnf.audio_conn_id = audio_conn_id; audio_prim->u.conn_establish_cnf.local_rtp_port = local_rtp_port; audio_prim->u.conn_establish_cnf.error_code = error_code; audio_prim->u.conn_establish_cnf.local_rtp_address_type = local_rtp_address_type; @@ -98,15 +100,14 @@ return audio_prim; } -static struct hnb_audio_prim *hnb_audio_makeprim_conn_data_ind(uint32_t context_id, - uint8_t domain, +static struct hnb_audio_prim *hnb_audio_makeprim_conn_data_ind(uint32_t audio_conn_id, const uint8_t *data, uint32_t data_len) { struct hnb_audio_prim *audio_prim; audio_prim = hnb_audio_prim_alloc(HNB_AUDIO_PRIM_CONN_DATA, PRIM_OP_INDICATION, data_len); - audio_prim->u.conn_data_ind.context_id = context_id; + audio_prim->u.conn_data_ind.audio_conn_id = audio_conn_id; audio_prim->u.conn_data_ind.data_len = data_len; if (data_len) { msgb_put(audio_prim->hdr.msg, data_len); @@ -116,15 +117,15 @@ return audio_prim; } -int llsk_audio_tx_conn_data_ind(struct hnb_ue *ue, const uint8_t *payload, uint32_t len) +int llsk_audio_tx_conn_data_ind(struct rtp_conn *conn, const uint8_t *payload, uint32_t len) { struct hnb_audio_prim *audio_prim; int rc; - LOGUE(ue, DLLSK, LOGL_INFO, "Tx AUDIO-CONN_DATA.ind\n"); - audio_prim = hnb_audio_makeprim_conn_data_ind(ue->conn_id, 0 /* CS */, payload, len); - if ((rc = osmo_prim_srv_send(ue->hnb->llsk, audio_prim->hdr.msg)) < 0) - LOGUE(ue, DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_DATA.ind\n"); + LOGUE(conn->ue, DLLSK, LOGL_INFO, "Tx AUDIO-CONN_DATA.ind\n"); + audio_prim = hnb_audio_makeprim_conn_data_ind(conn->id, payload, len); + if ((rc = osmo_prim_srv_send(conn->ue->hnb->llsk, audio_prim->hdr.msg)) < 0) + LOGUE(conn->ue, DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_DATA.ind\n"); return rc; } @@ -134,7 +135,7 @@ int rc; LOGP(DLLSK, LOGL_ERROR, "Tx AUDIO-CONN_ESTABLISH.cnf: ctx=%u error_code=%u\n", context_id, error_code); - audio_prim = hnb_audio_makeprim_conn_establish_cnf(context_id, error_code, 0, HNB_PRIM_ADDR_TYPE_UNSPEC, NULL); + audio_prim = hnb_audio_makeprim_conn_establish_cnf(context_id, 0, error_code, 0, HNB_PRIM_ADDR_TYPE_UNSPEC, NULL); if ((rc = osmo_prim_srv_send(hnb->llsk, audio_prim->hdr.msg)) < 0) { LOGP(DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_ESTABLISH.cnf context_id=%u error_code=%u\n", context_id, error_code); @@ -150,9 +151,9 @@ int af; char rem_addrstr[INET6_ADDRSTRLEN+32]; struct osmo_sockaddr rem_osa = {0}; - struct osmo_sockaddr loc_osa = {0}; union u_addr loc_uaddr = {0}; uint16_t loc_port; + struct rtp_conn *conn = NULL; rc = ll_addr2osa(ce_req->remote_rtp_address_type, &ce_req->remote_rtp_addr, ce_req->remote_rtp_port, &rem_osa); if (rc < 0) { @@ -184,14 +185,15 @@ } /* Create the socket: */ - if ((rc = hnb_ue_voicecall_setup(ue, &rem_osa, &loc_osa)) < 0) { + conn = rtp_conn_alloc(ue); + if ((rc = rtp_conn_setup(conn, &rem_osa)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: Failed to set up audio socket rem_addr=%s\n", rem_addrstr); return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); } /* Convert resulting local address back to LLSK format: */ - if (osa2_ll_addr(&loc_osa, &loc_uaddr, &loc_port) != ce_req->remote_rtp_address_type) { + if (osa2_ll_addr(&conn->loc_addr, &loc_uaddr, &loc_port) != ce_req->remote_rtp_address_type) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: Failed to provide proper local address rem_addr=%s\n", rem_addrstr); rc = _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); @@ -200,8 +202,8 @@ /* Submit successful confirmation */ LOGUE(ue, DLLSK, LOGL_INFO, "Tx AUDIO-CONN_ESTABLISH.cnf: error_code=0 rem_addr=%s loc_addr=%s\n", - rem_addrstr, osmo_sockaddr_to_str(&loc_osa)); - audio_prim = hnb_audio_makeprim_conn_establish_cnf(ce_req->context_id, 0, loc_port, + rem_addrstr, osmo_sockaddr_to_str(&conn->loc_addr)); + audio_prim = hnb_audio_makeprim_conn_establish_cnf(ce_req->context_id, conn->id, 0, loc_port, ce_req->remote_rtp_address_type, &loc_uaddr); if ((rc = osmo_prim_srv_send(hnb->llsk, audio_prim->hdr.msg)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_ESTABLISH.cnf error_code=0\n"); @@ -210,47 +212,49 @@ return rc; release_sock: - hnb_ue_voicecall_release(ue); + rtp_conn_free(conn); return rc; } static int llsk_rx_audio_conn_release_req(struct hnb *hnb, struct hnb_audio_conn_release_req_param *rel_req) { - struct hnb_ue *ue; + struct rtp_conn *conn; - LOGP(DLLSK, LOGL_DEBUG, "Rx AUDIO-CONN_RELEASE.req ctx=%u\n", rel_req->context_id); + LOGP(DLLSK, LOGL_DEBUG, "Rx AUDIO-CONN_RELEASE.req id=%u\n", rel_req->audio_conn_id); - ue = hnb_find_ue_by_id(hnb, rel_req->context_id); - if (!ue) { - LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_RELEASE.req: UE not found! ctx=%u\n", - rel_req->context_id); + conn = hnb_find_rtp_conn_by_id(hnb, rel_req->audio_conn_id); + if (!conn) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_RELEASE.req: RTP conn not found! id=%u\n", + rel_req->audio_conn_id); return -EINVAL; } /* Release RTP socket: */ - return hnb_ue_voicecall_release(ue); + rtp_conn_free(conn); + return 0; } static int llsk_rx_audio_conn_data_req(struct hnb *hnb, struct hnb_audio_conn_data_req_param *data_req) { - struct hnb_ue *ue; + struct rtp_conn *conn; int rc = 0; - LOGP(DLLSK, LOGL_DEBUG, "Rx AUDIO-CONN_DATA.req ctx=%u data_len=%u\n", - data_req->context_id, data_req->data_len); + LOGP(DLLSK, LOGL_DEBUG, "Rx AUDIO-CONN_DATA.req id=%u data_len=%u\n", + data_req->audio_conn_id, data_req->data_len); - ue = hnb_find_ue_by_id(hnb, data_req->context_id); - if (!ue) { - LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_DATA.req: UE not found! ctx=%u data_len=%u\n", - data_req->context_id, data_req->data_len); + conn = hnb_find_rtp_conn_by_id(hnb, data_req->audio_conn_id); + if (!conn) { + LOGP(DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_DATA.req: RTP conn not found! id=%u data_len=%u\n", + data_req->audio_conn_id, data_req->data_len); return -EINVAL; } /* TODO: transmit data_req->data through RTP/Iu-UP socket */ - rc = osmo_rtp_send_frame_ext(ue->conn_cs.rtp.socket, data_req->data, + rc = osmo_rtp_send_frame_ext(conn->socket, data_req->data, data_req->data_len, GSM_RTP_DURATION, false); if (rc < 0) { - LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_DATA.req: UE not found! ctx=%u data_len=%u\n", - data_req->context_id, data_req->data_len); + LOGUE(conn->ue, DLLSK, LOGL_ERROR, + "Rx AUDIO-CONN_DATA.req: Failed sending RTP frame! id=%u data_len=%u\n", + data_req->audio_conn_id, data_req->data_len); } return rc; } diff --git a/src/osmo-hnodeb/llsk_gtp.c b/src/osmo-hnodeb/llsk_gtp.c index e75c497..30451a0 100644 --- a/src/osmo-hnodeb/llsk_gtp.c +++ b/src/osmo-hnodeb/llsk_gtp.c @@ -79,14 +79,16 @@ return (struct hnb_gtp_prim *)oph; } -static struct hnb_gtp_prim *hnb_gtp_makeprim_conn_establish_cnf(uint32_t context_id, uint8_t error_code, - uint32_t local_tei, uint8_t local_gtpu_address_type, +static struct hnb_gtp_prim *hnb_gtp_makeprim_conn_establish_cnf(uint32_t context_id, uint32_t gtp_conn_id, + uint8_t error_code, uint32_t local_tei, + uint8_t local_gtpu_address_type, const union u_addr *local_gtpu_addr) { struct hnb_gtp_prim *gtp_prim; gtp_prim = hnb_gtp_prim_alloc(HNB_GTP_PRIM_CONN_ESTABLISH, PRIM_OP_CONFIRM, 0); gtp_prim->u.conn_establish_cnf.context_id = context_id; + gtp_prim->u.conn_establish_cnf.gtp_conn_id = gtp_conn_id; gtp_prim->u.conn_establish_cnf.local_tei = local_tei; gtp_prim->u.conn_establish_cnf.error_code = error_code; gtp_prim->u.conn_establish_cnf.local_gtpu_address_type = local_gtpu_address_type; @@ -96,14 +98,12 @@ return gtp_prim; } -struct hnb_gtp_prim *hnb_gtp_makeprim_conn_data_ind(uint32_t context_id, uint32_t local_tei, - const uint8_t *data, uint32_t data_len) +struct hnb_gtp_prim *hnb_gtp_makeprim_conn_data_ind(uint32_t gtp_conn_id, const uint8_t *data, uint32_t data_len) { struct hnb_gtp_prim *gtp_prim; gtp_prim = hnb_gtp_prim_alloc(HNB_GTP_PRIM_CONN_DATA, PRIM_OP_INDICATION, data_len); - gtp_prim->u.conn_data_ind.context_id = context_id; - gtp_prim->u.conn_data_ind.local_tei = local_tei; + gtp_prim->u.conn_data_ind.gtp_conn_id = gtp_conn_id; gtp_prim->u.conn_data_ind.data_len = data_len; if (data_len) { msgb_put(gtp_prim->hdr.msg, data_len); @@ -119,7 +119,7 @@ int rc; LOGP(DLLSK, LOGL_ERROR, "Tx GTP-CONN_ESTABLISH.cnf: ctx=%u error_code=%u\n", context_id, error_code); - gtp_prim = hnb_gtp_makeprim_conn_establish_cnf(context_id, error_code, 0, HNB_PRIM_ADDR_TYPE_UNSPEC, NULL); + gtp_prim = hnb_gtp_makeprim_conn_establish_cnf(context_id, 0, error_code, 0, HNB_PRIM_ADDR_TYPE_UNSPEC, NULL); if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { LOGP(DLLSK, LOGL_ERROR, "Failed sending GTP-CONN_ESTABLISH.cnf context_id=%u error_code=%u\n", context_id, error_code); @@ -135,9 +135,8 @@ int af; char rem_addrstr[INET6_ADDRSTRLEN+32]; struct osmo_sockaddr rem_osa = {0}; - struct osmo_sockaddr loc_osa = {0}; union u_addr loc_uaddr = {0}; - uint32_t loc_tei; + struct gtp_conn *conn = NULL; rc = ll_addr2osa(ce_req->remote_gtpu_address_type, &ce_req->remote_gtpu_addr, GTP1U_PORT, &rem_osa); if (rc < 0) { @@ -169,14 +168,15 @@ } /* Create the socket: */ - if ((rc = hnb_ue_gtp_bind(ue, &rem_osa, ce_req->remote_tei, &loc_osa, &loc_tei)) < 0) { + conn = gtp_conn_alloc(ue); + if ((rc = gtp_conn_setup(conn, &rem_osa, ce_req->remote_tei)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: Failed to set up gtp socket rem_tei=%u rem_addr=%s\n", ce_req->remote_tei, rem_addrstr); return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); } /* Convert resulting local address back to LLSK format: */ - if (osa2_ll_addr(&loc_osa, &loc_uaddr, NULL) != ce_req->remote_gtpu_address_type) { + if (osa2_ll_addr(&conn->loc_addr, &loc_uaddr, NULL) != ce_req->remote_gtpu_address_type) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: Failed to provide proper local address rem_addr=%s\n", rem_addrstr); rc = _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); @@ -185,56 +185,53 @@ /* Submit successful confirmation */ LOGUE(ue, DLLSK, LOGL_INFO, "Tx GTP-CONN_ESTABLISH.cnf: error_code=0 rem_addr=%s rem_tei=%u loc_addr=%s local_tei=%u\n", - rem_addrstr, ce_req->remote_tei, osmo_sockaddr_to_str(&loc_osa), loc_tei); - gtp_prim = hnb_gtp_makeprim_conn_establish_cnf(ce_req->context_id, 0, loc_tei, ce_req->remote_gtpu_address_type, &loc_uaddr); + rem_addrstr, ce_req->remote_tei, osmo_sockaddr_to_str(&conn->loc_addr), conn->loc_tei); + gtp_prim = hnb_gtp_makeprim_conn_establish_cnf(ce_req->context_id, conn->id, 0, conn->loc_tei, + ce_req->remote_gtpu_address_type, &loc_uaddr); if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Failed sending GTP-CONN_ESTABLISH.cnf error_code=0\n"); goto release_sock; } - - ue->conn_ps.local_tei = loc_tei; - ue->conn_ps.remote_tei = ce_req->remote_tei; - return rc; release_sock: - hnb_ue_gtp_unbind(ue); + gtp_conn_free(conn); return rc; } static int llsk_rx_gtp_conn_release_req(struct hnb *hnb, struct hnb_gtp_conn_release_req_param *rel_req) { - struct hnb_ue *ue; + struct gtp_conn *conn; int rc = 0; - LOGP(DLLSK, LOGL_DEBUG, "Rx GTP-CONN_RELEASE.req ctx=%u\n", rel_req->context_id); + LOGP(DLLSK, LOGL_DEBUG, "Rx GTP-CONN_RELEASE.req id=%u\n", rel_req->gtp_conn_id); - ue = hnb_find_ue_by_id(hnb, rel_req->context_id); - if (!ue) { - LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_RELEASE.req: UE not found! ctx=%u\n", - rel_req->context_id); + conn = hnb_find_gtp_conn_by_id(hnb, rel_req->gtp_conn_id); + if (!conn) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_RELEASE.req: GTP conn not found! id=%u\n", + rel_req->gtp_conn_id); return -EINVAL; } /* release GTP pdp ctx: */ - hnb_ue_gtp_unbind(ue); + gtp_conn_free(conn); return rc; } static int llsk_rx_gtp_conn_data_req(struct hnb *hnb, struct hnb_gtp_conn_data_req_param *data_req) { - struct hnb_ue *ue; + struct gtp_conn *conn; int rc = 0; - LOGP(DLLSK, LOGL_DEBUG, "Rx GTP-CONN_DATA.req ctx=%u rem_tei=%u data_len=%u\n", - data_req->context_id, data_req->remote_tei, data_req->data_len); + LOGP(DLLSK, LOGL_DEBUG, "Rx GTP-CONN_DATA.req id=%u data_len=%u\n", + data_req->gtp_conn_id, data_req->data_len); - ue = hnb_find_ue_by_id(hnb, data_req->context_id); - if (!ue) { - LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_DATA.req: UE not found! ctx=%u data_len=%u\n", - data_req->context_id, data_req->data_len); + conn = hnb_find_gtp_conn_by_id(hnb, data_req->gtp_conn_id); + if (!conn) { + LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_DATA.req: GTP conn not found! id=%u data_len=%u\n", + data_req->gtp_conn_id, data_req->data_len); return -EINVAL; } - rc = hnb_ue_gtp_tx(ue, data_req->data, data_req->data_len); + rc = gtp_conn_tx(conn, data_req->data, data_req->data_len); return rc; } diff --git a/src/osmo-hnodeb/rtp.c b/src/osmo-hnodeb/rtp.c index cc03c6c..2f40d99 100644 --- a/src/osmo-hnodeb/rtp.c +++ b/src/osmo-hnodeb/rtp.c @@ -27,6 +27,33 @@ #include #include +struct rtp_conn *rtp_conn_alloc(struct hnb_ue *ue) +{ + struct rtp_conn *conn; + + conn = talloc_zero(ue, struct rtp_conn); + if (!conn) + return NULL; + + conn->ue = ue; + + llist_add(&conn->list, &ue->conn_cs.conn_list); + + return conn; +} + +void rtp_conn_free(struct rtp_conn *conn) +{ + if (!conn) + return; + + if (conn->socket) { + osmo_rtp_socket_free(conn->socket); + conn->socket = NULL; + } + llist_del(&conn->list); + talloc_free(conn); +} /* Mixture between osmo_rtp_get_bound_addr and osmo_rtp_get_bound_ip_port using osmo_sockaddr */ /*static int rtp_get_bound_addr(struct osmo_rtp_socket *rs, struct osmo_sockaddr *osa) @@ -97,11 +124,13 @@ tries = (hnb->rtp.port_range_end - hnb->rtp.port_range_start) / 2; for (i = 0; i < tries; i++) { + uint16_t port; if (hnb->rtp.port_range_next >= hnb->rtp.port_range_end) hnb->rtp.port_range_next = hnb->rtp.port_range_start; - rc = osmo_rtp_socket_bind(rs, ip, hnb->rtp.port_range_next); + port = hnb->rtp.port_range_next; + rc = osmo_rtp_socket_bind(rs, ip, port); hnb->rtp.port_range_next += 2; @@ -118,7 +147,7 @@ LOGP(DRTP, LOGL_ERROR, "failed to set socket priority %d: %s\n", hnb->rtp.priority, strerror(errno)); } - return 0; + return port; } return -1; @@ -128,14 +157,14 @@ unsigned int rtp_pl_len, uint16_t seq_number, uint32_t timestamp, bool marker) { - struct hnb_ue *ue = (struct hnb_ue *)rs->priv; + struct rtp_conn *conn = (struct rtp_conn *)rs->priv; - LOGUE(ue, DRTP, LOGL_DEBUG, "Rx RTP seq=%u ts=%u M=%u pl=%p len=%u\n", + LOGUE(conn->ue, DRTP, LOGL_DEBUG, "Rx RTP seq=%u ts=%u M=%u pl=%p len=%u\n", seq_number, timestamp, marker, rtp_pl, rtp_pl_len); - llsk_audio_tx_conn_data_ind(ue, rtp_pl, rtp_pl_len); + llsk_audio_tx_conn_data_ind(conn, rtp_pl, rtp_pl_len); } -int hnb_ue_voicecall_setup(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, struct osmo_sockaddr *loc_addr) +int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr) { int rc; char cname[256+4]; @@ -144,6 +173,7 @@ const char *local_wildcard_ipstr = "0.0.0.0"; char remote_ipstr[INET6_ADDRSTRLEN]; uint16_t remote_port; + struct hnb_ue *ue = conn->ue; struct hnb *hnb = ue->hnb; if (osmo_sockaddr_to_str_and_uint(remote_ipstr, sizeof(remote_ipstr), &remote_port, &rem_addr->u.sa) == 0) { @@ -151,12 +181,9 @@ return -EINVAL; } - if (ue->conn_cs.rtp.socket) { - LOGUE(ue, DRTP, LOGL_ERROR, "Setting up rtp socket but it already exists!\n"); - return -EINVAL; - } + conn->rem_addr = *rem_addr; - rs = ue->conn_cs.rtp.socket = osmo_rtp_socket_create(ue, 0); + rs = conn->socket = osmo_rtp_socket_create(ue, 0); rc = osmo_rtp_socket_set_param(rs, hnb->rtp.jitter_adaptive ? OSMO_RTP_P_JIT_ADAP : @@ -166,7 +193,7 @@ LOGUE(ue, DRTP, LOGL_ERROR, "Failed to set RTP socket parameters: %s\n", strerror(-rc)); goto free_ret; } - rs->priv = ue; + rs->priv = conn; rs->rx_cb = &rtp_rx_cb; rc = rtp_bind(hnb, rs, local_wildcard_ipstr); @@ -174,10 +201,11 @@ LOGUE(ue, DRTP, LOGL_ERROR, "Failed to bind RTP/RTCP sockets\n"); goto free_ret; } + conn->id = rc; /* We use local port as rtp conn ID */ /* Ensure RTCP SDES contains some useful information */ snprintf(cname, sizeof(cname), "hnb@%s", local_wildcard_ipstr); - snprintf(name, sizeof(name), "ue@%u", ue->conn_id); + snprintf(name, sizeof(name), "ue@%u-%u", conn->ue->conn_id, conn->id); osmo_rtp_set_source_desc(rs, cname, name, NULL, NULL, NULL, "OsmoHNodeB-" PACKAGE_VERSION, NULL); @@ -188,8 +216,8 @@ } /* osmo_rtp_socket_connect() is broken, OS#5356 */ - //rc = rtp_get_bound_addr(rs, loc_addr); - rc = rtp_get_bound_addr(rs, rem_addr, loc_addr); + //rc = rtp_get_bound_addr(rs, &conn->loc_addr); + rc = rtp_get_bound_addr(rs, rem_addr, &conn->loc_addr); if (rc < 0) { LOGUE(ue, DRTP, LOGL_ERROR, "Cannot obtain locally bound IP/port: %d\n", rc); goto free_ret; @@ -197,16 +225,7 @@ return rc; free_ret: - osmo_rtp_socket_free(ue->conn_cs.rtp.socket); - ue->conn_cs.rtp.socket = NULL; + osmo_rtp_socket_free(conn->socket); + conn->socket = NULL; return rc; } - -int hnb_ue_voicecall_release(struct hnb_ue *ue) -{ - if (!ue->conn_cs.rtp.socket) - return -EINVAL; - osmo_rtp_socket_free(ue->conn_cs.rtp.socket); - ue->conn_cs.rtp.socket = NULL; - return 0; -} -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ib3f60d5ba21defe5259c25e2034fc2217c4d93df Gerrit-Change-Number: 26570 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:39:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 16:39:29 +0000 Subject: Change in osmo-hnodeb[master]: rtp: Use dynamic Payload Type 96 In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26596 ) Change subject: rtp: Use dynamic Payload Type 96 ...................................................................... rtp: Use dynamic Payload Type 96 Change-Id: I6ca83c274200d8fc0fb3d8914e970b05df91f6ea --- M src/osmo-hnodeb/rtp.c 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnodeb/rtp.c b/src/osmo-hnodeb/rtp.c index 2f40d99..41fb668 100644 --- a/src/osmo-hnodeb/rtp.c +++ b/src/osmo-hnodeb/rtp.c @@ -193,6 +193,14 @@ LOGUE(ue, DRTP, LOGL_ERROR, "Failed to set RTP socket parameters: %s\n", strerror(-rc)); goto free_ret; } + /* TS 25.414 Section 5.1.3.3.1.6: A dynamic Payload Type (IETF RFC 1890 + * [23]) shall be used. Values in the Range between 96 and 127 shall be + * used. The value shall be ignored in the receiving entity. */ + rc = osmo_rtp_socket_set_pt(rs, 96); + if (rc < 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Failed to set RTP socket Payload-Type 96\n"); + /* Continue, the other side is anyway ignoring it... */ + } rs->priv = conn; rs->rx_cb = &rtp_rx_cb; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6ca83c274200d8fc0fb3d8914e970b05df91f6ea Gerrit-Change-Number: 26596 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:39:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 16:39:33 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Adapt HNBLIF to latest changes In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26571 ) Change subject: hnodeb: Adapt HNBLIF to latest changes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50a1b9be579ace9f0f85c6c68b5648d504f5f51c Gerrit-Change-Number: 26571 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 16 Dec 2021 16:39:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:39:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 16:39:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Adapt HNBLIF to latest changes In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26571 ) Change subject: hnodeb: Adapt HNBLIF to latest changes ...................................................................... hnodeb: Adapt HNBLIF to latest changes Change-Id: I50a1b9be579ace9f0f85c6c68b5648d504f5f51c --- M hnodeb/HNB_Tests.ttcn M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 3 files changed, 36 insertions(+), 35 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index ca42e5c..c801ee6 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -296,6 +296,7 @@ var HostName hnodeb_rtp_addr; var PortNumber hnodeb_rtp_port; timer Tu; + var uint32_t audio_conn_id; f_handle_hnbap_hnb_register_req(); @@ -317,8 +318,9 @@ /* Now LLSK provides the remote TransportLayerAddress from RabAssReq and asks SUT to provide a local address: */ LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_ESTABLISH_REQ(context_id, g_pars.hnbgw_rtp_port, HNBLL_IF_ADDR_TYPE_IPV4, f_HNBLLIF_Addr(HNBLL_IF_ADDR_TYPE_IPV4, g_pars.hnbgw_addr)))); - LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_ESTABLISH_CNF(context_id, 0, ?, HNBLL_IF_ADDR_TYPE_IPV4, ?))) -> value sd; + LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_ESTABLISH_CNF(context_id, ?, 0, ?, HNBLL_IF_ADDR_TYPE_IPV4, ?))) -> value sd; + audio_conn_id := sd.data.u.audio.u.conn_establish.u.cnf.audio_conn_id; hnodeb_rtp_addr := f_inet_ntoa(sd.data.u.audio.u.conn_establish.u.cnf.local_addr); if (not match(g_pars.hnodeb_addr, hnodeb_rtp_addr)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "hnodeb RTP local address doesn't match expectations"); @@ -328,7 +330,7 @@ f_HNBGW_rtpem_activate(rtp_payload, hnodeb_rtp_addr, hnodeb_rtp_port); /* Make sure that Uplink frames are received at the HNBGW */ RTPEM_DATA.clear; - LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_DATA_REQ(context_id, rtp_payload))); + LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_DATA_REQ(audio_conn_id, rtp_payload))); Tu.start(2.0); alt { [] RTPEM_DATA.receive(PDU_RTP:?) -> value rtp_pdu { @@ -344,11 +346,11 @@ } Tu.stop; /* We should also have received some RTP from the HNBGW: */ - LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_DATA_IND(context_id, rtp_payload))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_DATA_IND(audio_conn_id, rtp_payload))); f_rtpem_mode(RTPEM_CTRL, RTPEM_MODE_NONE); - LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_RELEASE_REQ(context_id))); + LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_RELEASE_REQ(audio_conn_id))); /* UE sends Iu Release Complete to release the conn */ LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_RELEASE_REQ(context_id, 0, 0, 0, hex2oct(iu_release_compl)))); @@ -371,6 +373,7 @@ var uint32_t local_tei; var octetstring gtp_payload := f_rnd_octstring(40); var HNBLLIF_send_data sd; + var uint32_t gtp_conn_id; f_gtp_register_teid(int2oct(remote_tei, 4)); @@ -394,18 +397,19 @@ /* Now LLSK provides the remote TransportLayerAddress from RabAssReq and asks SUT to provide a local address: */ LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_ESTABLISH_REQ(context_id, remote_tei, HNBLL_IF_ADDR_TYPE_IPV4, f_HNBLLIF_Addr(HNBLL_IF_ADDR_TYPE_IPV4, g_pars.hnbgw_addr)))); - LLSK.receive(f_llsk_rx(tr_HNBLLIF_GTP_CONN_ESTABLISH_CNF(context_id, ?, 0, + LLSK.receive(f_llsk_rx(tr_HNBLLIF_GTP_CONN_ESTABLISH_CNF(context_id, ?, ?, 0, HNBLL_IF_ADDR_TYPE_IPV4, ?))) -> value sd; + gtp_conn_id := sd.data.u.gtp.u.conn_establish.u.cnf.gtp_conn_id; local_tei := sd.data.u.gtp.u.conn_establish.u.cnf.local_tei; /* Forward GTP data in both directions */ - LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_DATA_REQ(context_id, remote_tei, gtp_payload))); + LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_DATA_REQ(gtp_conn_id, gtp_payload))); GTP.receive(tr_GTPU_GPDU(ts_GtpPeerU(g_pars.hnodeb_addr), int2oct(remote_tei, 4), gtp_payload)); f_gtpu_send(local_tei, gtp_payload); - LLSK.receive(f_llsk_rx(tr_HNBLLIF_GTP_CONN_DATA_IND(context_id, local_tei, gtp_payload))); + LLSK.receive(f_llsk_rx(tr_HNBLLIF_GTP_CONN_DATA_IND(gtp_conn_id, gtp_payload))); /* Done, release GTP conn */ - LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_RELEASE_REQ(context_id, remote_tei))); + LLSK.send(f_llsk_tx(ts_HNBLLIF_GTP_CONN_RELEASE_REQ(gtp_conn_id))); /* UE sends Iu Release Complete to release the conn */ LLSK.send(f_llsk_tx(ts_HNBLLIF_IUH_CONN_RELEASE_REQ(context_id, 1, 0, 0, hex2oct(iu_release_compl)))); diff --git a/library/HNBLLIF_Templates.ttcn b/library/HNBLLIF_Templates.ttcn index 78cf89a..fc82a72 100644 --- a/library/HNBLLIF_Templates.ttcn +++ b/library/HNBLLIF_Templates.ttcn @@ -279,6 +279,7 @@ } template (present) HNBLLIF_Message tr_HNBLLIF_AUDIO_CONN_ESTABLISH_CNF(template (present) uint32_t context_id := ?, + template (present) uint32_t audio_conn_id := ?, template (present) uint8_t error_code := ?, template (present) uint16_t local_rtp_port:= ?, template (present) HNBLLIF_AddrType local_rtp_address_type := ?, @@ -293,6 +294,7 @@ u := { cnf := { context_id := context_id, + audio_conn_id := audio_conn_id, local_rtp_port := local_rtp_port, error_code := error_code, local_rtp_address_type := local_rtp_address_type, @@ -305,7 +307,7 @@ } } -template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_RELEASE_REQ(template (value) uint32_t context_id) := { +template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_RELEASE_REQ(template (value) uint32_t audio_conn_id) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { audio := { @@ -315,7 +317,7 @@ op := HNBLL_IF_OP_REQUEST, u := { req := { - context_id := context_id + audio_conn_id := audio_conn_id } } } @@ -324,7 +326,7 @@ } } -template (present) HNBLLIF_Message tr_HNBLLIF_AUDIO_CONN_DATA_IND(template (present) uint32_t context_id := ?, +template (present) HNBLLIF_Message tr_HNBLLIF_AUDIO_CONN_DATA_IND(template (present) uint32_t audio_conn_id := ?, template (present) octetstring data := ?) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { @@ -335,7 +337,7 @@ op := HNBLL_IF_OP_INDICATION, u := { ind := { - context_id := context_id, + audio_conn_id := audio_conn_id, data_len := ?, data := data } @@ -346,7 +348,7 @@ } } -template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_DATA_REQ(template (value) uint32_t context_id, +template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_DATA_REQ(template (value) uint32_t audio_conn_id, template (value) octetstring data) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { @@ -357,7 +359,7 @@ op := HNBLL_IF_OP_REQUEST, u := { req := { - context_id := context_id, + audio_conn_id := audio_conn_id, data_len := lengthof(data), data := data } @@ -399,6 +401,7 @@ } template (present) HNBLLIF_Message tr_HNBLLIF_GTP_CONN_ESTABLISH_CNF(template (present) uint32_t context_id := ?, + template (present) uint32_t gtp_conn_id := ?, template (present) uint32_t local_tei := ?, template (present) uint8_t error_code := ?, template (present) HNBLLIF_AddrType local_gtpu_address_type := ?, @@ -413,6 +416,7 @@ u := { cnf := { context_id := context_id, + gtp_conn_id := gtp_conn_id, local_tei := local_tei, error_code := error_code, local_gtpu_address_type := local_gtpu_address_type, @@ -425,8 +429,7 @@ } } -template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_RELEASE_REQ(template (value) uint32_t context_id, - template (value) uint32_t remote_tei) := { +template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_RELEASE_REQ(template (value) uint32_t gtp_conn_id) := { sapi := HNBLL_IF_SAPI_GTP, u := { gtp := { @@ -436,8 +439,7 @@ op := HNBLL_IF_OP_REQUEST, u := { req := { - context_id := context_id, - remote_tei := remote_tei + gtp_conn_id := gtp_conn_id } } } @@ -446,8 +448,7 @@ } } -template (present) HNBLLIF_Message tr_HNBLLIF_GTP_CONN_DATA_IND(template (present) uint32_t context_id := ?, - template (present) uint32_t local_tei := ?, +template (present) HNBLLIF_Message tr_HNBLLIF_GTP_CONN_DATA_IND(template (present) uint32_t gtp_conn_id, template (present) octetstring data := ?) := { sapi := HNBLL_IF_SAPI_GTP, u := { @@ -458,8 +459,7 @@ op := HNBLL_IF_OP_INDICATION, u := { ind := { - context_id := context_id, - local_tei := local_tei, + gtp_conn_id := gtp_conn_id, data_len := ?, data := data } @@ -470,8 +470,7 @@ } } -template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_DATA_REQ(template (value) uint32_t context_id, - template (value) uint32_t remote_tei, +template (value) HNBLLIF_Message ts_HNBLLIF_GTP_CONN_DATA_REQ(template (value) uint32_t gtp_conn_id, template (value) octetstring data) := { sapi := HNBLL_IF_SAPI_GTP, u := { @@ -482,8 +481,7 @@ op := HNBLL_IF_OP_REQUEST, u := { req := { - context_id := context_id, - remote_tei := remote_tei, + gtp_conn_id := gtp_conn_id, data_len := lengthof(data), data := data } diff --git a/library/HNBLLIF_Types.ttcn b/library/HNBLLIF_Types.ttcn index 95f91fc..a3a6c4c 100644 --- a/library/HNBLLIF_Types.ttcn +++ b/library/HNBLLIF_Types.ttcn @@ -252,6 +252,7 @@ type record HNBLLIF_AUDIO_conn_establish_cnf { uint32_t context_id, + uint32_t audio_conn_id, uint16_t local_rtp_port, uint8_t error_code, HNBLLIF_AddrType local_rtp_address_type, @@ -273,7 +274,7 @@ /* CONN_RELEASE */ type record HNBLLIF_AUDIO_conn_release_req { - uint32_t context_id + uint32_t audio_conn_id } with { variant "" }; @@ -290,13 +291,13 @@ /* CONN_DATA */ type record HNBLLIF_AUDIO_conn_data_ind { - uint32_t context_id, + uint32_t audio_conn_id, uint32_t data_len, octetstring data /* RANAP message */ } with { variant (data_len) "LENGTHTO (data)" }; type record HNBLLIF_AUDIO_conn_data_req { - uint32_t context_id, + uint32_t audio_conn_id, uint32_t data_len, octetstring data /* RANAP message */ } with { variant (data_len) "LENGTHTO (data)" }; @@ -350,6 +351,7 @@ type record HNBLLIF_GTP_conn_establish_cnf { uint32_t context_id, + uint32_t gtp_conn_id, uint32_t local_tei, uint8_t error_code, HNBLLIF_AddrType local_gtpu_address_type, @@ -371,8 +373,7 @@ /* CONN_RELEASE */ type record HNBLLIF_GTP_conn_release_req { - uint32_t context_id, - uint32_t remote_tei + uint32_t gtp_conn_id } with { variant "" }; type union HNBLLIF_GTP_PrimOpUnion_conn_release { @@ -388,15 +389,13 @@ /* CONN_DATA */ type record HNBLLIF_GTP_conn_data_req { - uint32_t context_id, - uint32_t remote_tei, + uint32_t gtp_conn_id, uint32_t data_len, octetstring data /* RANAP message */ } with { variant (data_len) "LENGTHTO (data)" }; type record HNBLLIF_GTP_conn_data_ind { - uint32_t context_id, - uint32_t local_tei, + uint32_t gtp_conn_id, uint32_t data_len, octetstring data /* RANAP message */ } with { variant (data_len) "LENGTHTO (data)" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50a1b9be579ace9f0f85c6c68b5648d504f5f51c Gerrit-Change-Number: 26571 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 16 16:40:39 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 16 Dec 2021 16:40:39 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Set proper CRC Header for ACK Initialization In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26598 ) Change subject: mgcp_network.c: Set proper CRC Header for ACK Initialization ...................................................................... Patch Set 1: See https://gitlab.com/wireshark/wireshark/-/merge_requests/5461 output snippted to see where the 0x09 came from. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f Gerrit-Change-Number: 26598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 16 Dec 2021 16:40:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Dec 16 16:59:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 16:59:52 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <61bb709688c6b_4b3e2b08e0392600127682@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 51s] checking for LIBASN1C... yes [ 51s] checking for LIBOSMOCORE... yes [ 51s] checking for LIBOSMOVTY... yes [ 51s] checking for LIBOSMOCTRL... yes [ 51s] checking for LIBOSMOGSM... yes [ 51s] checking for LIBOSMOABIS... yes [ 51s] checking for LIBOSMOTRAU... no [ 51s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 51s] [ 51s] Package 'libosmotrau', required by 'virtual:world', not found [ 51s] [ 51s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 51s] installed software in a non-standard prefix. [ 51s] [ 51s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 51s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 51s] See the pkg-config man page for more details. [ 51s] error: Bad exit status from /var/tmp/rpm-tmp.ij4JpE (%build) [ 51s] [ 51s] [ 51s] RPM build errors: [ 51s] Bad exit status from /var/tmp/rpm-tmp.ij4JpE (%build) [ 51s] ### VM INTERACTION START ### [ 54s] [ 39.682642][ T392] sysrq: Power Off [ 54s] [ 39.701167][ T16] reboot: Power down [ 54s] ### VM INTERACTION END ### [ 54s] [ 54s] cloud118 failed "build osmo-hnodeb.spec" at Thu Dec 16 16:59:41 UTC 2021. [ 54s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 16 22:05:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 16 Dec 2021 22:05:00 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61bbb8148f6f9_4b3e2b08e03926002321bc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 60s] checking for LIBASN1C... yes [ 60s] checking for LIBOSMOCORE... yes [ 61s] checking for LIBOSMOVTY... yes [ 61s] checking for LIBOSMOCTRL... yes [ 61s] checking for LIBOSMOGSM... yes [ 61s] checking for LIBOSMOABIS... yes [ 61s] checking for LIBOSMOTRAU... no [ 61s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 61s] [ 61s] Package 'libosmotrau', required by 'virtual:world', not found [ 61s] [ 61s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 61s] installed software in a non-standard prefix. [ 61s] [ 61s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 61s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 61s] See the pkg-config man page for more details. [ 61s] error: Bad exit status from /var/tmp/rpm-tmp.lFTyhr (%build) [ 61s] [ 61s] [ 61s] RPM build errors: [ 61s] Bad exit status from /var/tmp/rpm-tmp.lFTyhr (%build) [ 61s] ### VM INTERACTION START ### [ 64s] [ 45.246607][ T384] sysrq: Power Off [ 64s] [ 45.247317][ T15] reboot: Power down [ 64s] ### VM INTERACTION END ### [ 64s] [ 64s] obs-arm-11 failed "build osmo-hnodeb.spec" at Thu Dec 16 22:04:57 UTC 2021. [ 64s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 00:10:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 00:10:31 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61bbd57dbcaf4_4b3e2b08e03926002673ca@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 57s] checking for LIBASN1C... yes [ 57s] checking for LIBOSMOCORE... yes [ 57s] checking for LIBOSMOVTY... yes [ 57s] checking for LIBOSMOCTRL... yes [ 57s] checking for LIBOSMOGSM... yes [ 57s] checking for LIBOSMOABIS... yes [ 57s] checking for LIBOSMOTRAU... no [ 57s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 57s] [ 57s] Package 'libosmotrau', required by 'virtual:world', not found [ 57s] [ 57s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 57s] installed software in a non-standard prefix. [ 57s] [ 57s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 57s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 57s] See the pkg-config man page for more details. [ 57s] error: Bad exit status from /var/tmp/rpm-tmp.brnsTG (%build) [ 57s] [ 57s] [ 57s] RPM build errors: [ 57s] Bad exit status from /var/tmp/rpm-tmp.brnsTG (%build) [ 57s] ### VM INTERACTION START ### [ 60s] [ 30.869043][ T383] sysrq: Power Off [ 60s] [ 30.869709][ T15] reboot: Power down [ 60s] ### VM INTERACTION END ### [ 60s] [ 60s] obs-arm-11 failed "build osmo-hnodeb.spec" at Fri Dec 17 00:10:16 UTC 2021. [ 60s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 00:48:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 00:48:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <61bbde8565ab0_4b3e2b08e0392600274641@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 69s] checking for LIBASN1C... yes [ 69s] checking for LIBOSMOCORE... yes [ 69s] checking for LIBOSMOVTY... yes [ 69s] checking for LIBOSMOCTRL... yes [ 69s] checking for LIBOSMOGSM... yes [ 69s] checking for LIBOSMOABIS... yes [ 69s] checking for LIBOSMOTRAU... no [ 69s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 69s] [ 69s] Package 'libosmotrau', required by 'virtual:world', not found [ 69s] [ 69s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 69s] installed software in a non-standard prefix. [ 69s] [ 69s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 69s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 69s] See the pkg-config man page for more details. [ 70s] error: Bad exit status from /var/tmp/rpm-tmp.HqpFea (%build) [ 70s] [ 70s] [ 70s] RPM build errors: [ 70s] Bad exit status from /var/tmp/rpm-tmp.HqpFea (%build) [ 70s] ### VM INTERACTION START ### [ 73s] [ 53.032018][ T435] sysrq: Power Off [ 73s] [ 53.045011][ T7] reboot: Power down [ 73s] ### VM INTERACTION END ### [ 73s] [ 73s] hci-cnode2-m0 failed "build osmo-hnodeb.spec" at Fri Dec 17 00:48:41 UTC 2021. [ 73s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 01:22:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 01:22:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <61bbe65d11fab_4b3e2b08e03926002826d9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 122s] checking for LIBASN1C... yes [ 122s] checking for LIBOSMOCORE... yes [ 122s] checking for LIBOSMOVTY... yes [ 122s] checking for LIBOSMOCTRL... yes [ 122s] checking for LIBOSMOGSM... yes [ 122s] checking for LIBOSMOABIS... yes [ 122s] checking for LIBOSMOTRAU... no [ 122s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 122s] [ 122s] Package 'libosmotrau', required by 'virtual:world', not found [ 122s] [ 122s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 122s] installed software in a non-standard prefix. [ 122s] [ 122s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 122s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 122s] See the pkg-config man page for more details. [ 122s] error: Bad exit status from /var/tmp/rpm-tmp.fxflNU (%build) [ 122s] [ 122s] [ 122s] RPM build errors: [ 122s] Bad exit status from /var/tmp/rpm-tmp.fxflNU (%build) [ 122s] ### VM INTERACTION START ### [ 125s] [ 74.130438][ T438] sysrq: Power Off [ 126s] [ 74.182633][ T16] reboot: Power down [ 126s] ### VM INTERACTION END ### [ 126s] [ 126s] lamb61 failed "build osmo-hnodeb.spec" at Fri Dec 17 01:22:12 UTC 2021. [ 126s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 01:22:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 01:22:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61bbe67c2f0e1_4b3e2b08e039260028285@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 65s] checking for libasn1c >= 0.9.30... yes [ 65s] checking for libosmocore >= 1.6.0... yes [ 65s] checking for libosmovty >= 1.6.0... yes [ 65s] checking for libosmoctrl >= 1.6.0... yes [ 65s] checking for libosmogsm >= 1.6.0... yes [ 65s] checking for libosmoabis >= 1.2.0... yes [ 65s] checking for libosmotrau >= 1.2.0... no [ 65s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 65s] [ 65s] No package 'libosmotrau' found [ 65s] [ 65s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 65s] installed software in a non-standard prefix. [ 65s] [ 65s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 65s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 65s] See the pkg-config man page for more details. [ 66s] error: Bad exit status from /var/tmp/rpm-tmp.vGHd5C (%build) [ 66s] [ 66s] [ 66s] RPM build errors: [ 66s] Bad exit status from /var/tmp/rpm-tmp.vGHd5C (%build) [ 66s] ### VM INTERACTION START ### [ 69s] [ 52.557475] sysrq: Power Off [ 69s] [ 52.578829] reboot: Power down [ 69s] ### VM INTERACTION END ### [ 69s] [ 69s] cloud116 failed "build osmo-hnodeb.spec" at Fri Dec 17 01:22:48 UTC 2021. [ 69s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 01:23:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 01:23:27 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61bbe69c94b2a_4b3e2b08e0392600283135@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 93s] checking for libasn1c >= 0.9.30... yes [ 93s] checking for libosmocore >= 1.6.0... yes [ 93s] checking for libosmovty >= 1.6.0... yes [ 93s] checking for libosmoctrl >= 1.6.0... yes [ 93s] checking for libosmogsm >= 1.6.0... yes [ 93s] checking for libosmoabis >= 1.2.0... yes [ 93s] checking for libosmotrau >= 1.2.0... no [ 93s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 93s] [ 93s] No package 'libosmotrau' found [ 93s] [ 93s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 93s] installed software in a non-standard prefix. [ 93s] [ 93s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 93s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 93s] See the pkg-config man page for more details. [ 93s] error: Bad exit status from /var/tmp/rpm-tmp.tlzHMq (%build) [ 93s] [ 93s] [ 93s] RPM build errors: [ 93s] Bad exit status from /var/tmp/rpm-tmp.tlzHMq (%build) [ 93s] ### VM INTERACTION START ### [ 97s] [ 53.849151] sysrq: SysRq : Power Off [ 97s] [ 53.866954] reboot: Power down [ 97s] ### VM INTERACTION END ### [ 97s] [ 97s] cloud106 failed "build osmo-hnodeb.spec" at Fri Dec 17 01:23:15 UTC 2021. [ 97s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 01:28:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 01:28:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/x86_64 In-Reply-To: References: Message-ID: <61bbe7e3f2488_4b3e2b08e0392600284890@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 60s] checking for LIBASN1C... yes [ 60s] checking for LIBOSMOCORE... yes [ 60s] checking for LIBOSMOVTY... yes [ 60s] checking for LIBOSMOCTRL... yes [ 60s] checking for LIBOSMOGSM... yes [ 60s] checking for LIBOSMOABIS... yes [ 60s] checking for LIBOSMOTRAU... no [ 60s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 60s] [ 60s] Package 'libosmotrau', required by 'virtual:world', not found [ 60s] [ 60s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 60s] installed software in a non-standard prefix. [ 60s] [ 60s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 60s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 60s] See the pkg-config man page for more details. [ 60s] error: Bad exit status from /var/tmp/rpm-tmp.iYGvoh (%build) [ 60s] [ 60s] [ 60s] RPM build errors: [ 60s] Bad exit status from /var/tmp/rpm-tmp.iYGvoh (%build) [ 60s] ### VM INTERACTION START ### [ 61s] Powering off. [ 61s] [ 44.191498] reboot: Power down [ 61s] ### VM INTERACTION END ### [ 61s] [ 61s] goat13 failed "build osmo-hnodeb.spec" at Fri Dec 17 01:28:44 UTC 2021. [ 61s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 02:05:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 02:05:10 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/armv7l In-Reply-To: References: Message-ID: <61bbf072d9011_4b3e2b08e03926002929d5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 95s] checking for LIBASN1C... yes [ 95s] checking for LIBOSMOCORE... yes [ 95s] checking for LIBOSMOVTY... yes [ 95s] checking for LIBOSMOCTRL... yes [ 95s] checking for LIBOSMOGSM... yes [ 95s] checking for LIBOSMOABIS... yes [ 95s] checking for LIBOSMOTRAU... no [ 95s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 95s] [ 95s] Package 'libosmotrau', required by 'virtual:world', not found [ 95s] [ 95s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 95s] installed software in a non-standard prefix. [ 95s] [ 95s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 95s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 95s] See the pkg-config man page for more details. [ 95s] error: Bad exit status from /var/tmp/rpm-tmp.hC3fjo (%build) [ 95s] [ 95s] [ 95s] RPM build errors: [ 95s] Bad exit status from /var/tmp/rpm-tmp.hC3fjo (%build) [ 95s] ### VM INTERACTION START ### [ 98s] [ 54.568336][ T383] sysrq: Power Off [ 98s] [ 54.568975][ T15] reboot: Power down [ 98s] ### VM INTERACTION END ### [ 98s] [ 98s] obs-arm-11 failed "build osmo-hnodeb.spec" at Fri Dec 17 02:05:04 UTC 2021. [ 98s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 02:30:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 02:30:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61bbf66b1a552_4b3e2b08e0392600298275@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 54s] checking for libasn1c >= 0.9.30... yes [ 54s] checking for libosmocore >= 1.6.0... yes [ 54s] checking for libosmovty >= 1.6.0... yes [ 54s] checking for libosmoctrl >= 1.6.0... yes [ 54s] checking for libosmogsm >= 1.6.0... yes [ 54s] checking for libosmoabis >= 1.2.0... yes [ 54s] checking for libosmotrau >= 1.2.0... no [ 54s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 54s] [ 54s] No package 'libosmotrau' found [ 54s] [ 54s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 54s] installed software in a non-standard prefix. [ 54s] [ 54s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 54s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 54s] See the pkg-config man page for more details. [ 54s] error: Bad exit status from /var/tmp/rpm-tmp.8fLtQ1 (%build) [ 54s] [ 54s] [ 54s] RPM build errors: [ 54s] Bad exit status from /var/tmp/rpm-tmp.8fLtQ1 (%build) [ 54s] ### VM INTERACTION START ### [ 115s] [ 90.455441] sysrq: SysRq : Power Off [ 115s] [ 90.456090] reboot: Power down [ 115s] ### VM INTERACTION END ### [ 115s] [ 115s] obs-arm-11 failed "build osmo-hnodeb.spec" at Fri Dec 17 02:30:44 UTC 2021. [ 115s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 02:42:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 02:42:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_21.04/x86_64 In-Reply-To: References: Message-ID: <61bbf91f27adb_4b3e2b08e0392600301540@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_21.04/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_21.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 465s] | ^ [ 465s] llsk.c: In function 'llsk_rx_cb': [ 465s] gtp.c:168:17: warning: potential null pointer dereference [-Wnull-dereference] [ 465s] 168 | struct hnb_ue *ue = conn->ue; [ 465s] | ^ [ 466s] lto1: some warnings being treated as errors [ 466s] make[5]: *** [/tmp/ccIKl9oz.mk:2: /tmp/osmo-hnodeb.vnT8ga.ltrans0.ltrans.o] Error 1 [ 466s] lto-wrapper: fatal error: make returned 2 exit status [ 466s] compilation terminated. [ 466s] /usr/bin/ld: error: lto-wrapper failed [ 466s] collect2: error: ld returned 1 exit status [ 466s] make[4]: *** [Makefile:501: osmo-hnodeb] Error 1 [ 466s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-hnodeb' [ 466s] make[3]: *** [Makefile:392: all-recursive] Error 1 [ 466s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 466s] make[2]: *** [Makefile:463: all-recursive] Error 1 [ 466s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 466s] make[1]: *** [Makefile:395: all] Error 2 [ 466s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 466s] dh_auto_build: error: make -j1 returned exit code 2 [ 466s] make: *** [debian/rules:45: build] Error 25 [ 466s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 466s] ### VM INTERACTION START ### [ 467s] Powering off. [ 467s] [ 440.234987] reboot: Power down [ 467s] ### VM INTERACTION END ### [ 467s] [ 467s] lamb09 failed "build osmo-hnodeb_0.0.1.13.381c4.202112170026.dsc" at Fri Dec 17 02:42:17 UTC 2021. [ 467s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 02:42:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 02:42:36 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in xUbuntu_21.10/x86_64 In-Reply-To: References: Message-ID: <61bbf9209e352_4b3e2b08e03926003018f4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/xUbuntu_21.10/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in xUbuntu_21.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 196s] | ^ [ 196s] llsk.c: In function 'llsk_rx_cb': [ 196s] gtp.c:168:24: warning: potential null pointer dereference [-Wnull-dereference] [ 196s] 168 | struct hnb_ue *ue = conn->ue; [ 196s] | ^ [ 197s] lto1: some warnings being treated as errors [ 197s] make[5]: *** [/tmp/ccaRgens.mk:2: /tmp/ccVxMCCv.ltrans0.ltrans.o] Error 1 [ 197s] lto-wrapper: fatal error: make returned 2 exit status [ 197s] compilation terminated. [ 197s] /usr/bin/ld: error: lto-wrapper failed [ 197s] collect2: error: ld returned 1 exit status [ 197s] make[4]: *** [Makefile:502: osmo-hnodeb] Error 1 [ 197s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-hnodeb' [ 197s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 197s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 197s] make[2]: *** [Makefile:463: all-recursive] Error 1 [ 197s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 197s] make[1]: *** [Makefile:395: all] Error 2 [ 197s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 197s] dh_auto_build: error: make -j1 returned exit code 2 [ 197s] make: *** [debian/rules:45: build] Error 25 [ 197s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 197s] ### VM INTERACTION START ### [ 198s] Powering off. [ 198s] [ 190.591252] reboot: Power down [ 198s] ### VM INTERACTION END ### [ 198s] [ 198s] goat13 failed "build osmo-hnodeb_0.0.1.13.381c4.202112170026.dsc" at Fri Dec 17 02:42:20 UTC 2021. [ 198s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 02:44:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 02:44:36 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61bbf998edda9_4b3e2b08e0392600302126@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 105s] checking for libasn1c >= 0.9.30... yes [ 105s] checking for libosmocore >= 1.6.0... yes [ 105s] checking for libosmovty >= 1.6.0... yes [ 105s] checking for libosmoctrl >= 1.6.0... yes [ 105s] checking for libosmogsm >= 1.6.0... yes [ 105s] checking for libosmoabis >= 1.2.0... yes [ 105s] checking for libosmotrau >= 1.2.0... no [ 105s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 105s] [ 105s] No package 'libosmotrau' found [ 105s] [ 105s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 105s] installed software in a non-standard prefix. [ 105s] [ 105s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 105s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 105s] See the pkg-config man page for more details. [ 105s] error: Bad exit status from /var/tmp/rpm-tmp.074hlf (%build) [ 105s] [ 105s] [ 105s] RPM build errors: [ 105s] Bad exit status from /var/tmp/rpm-tmp.074hlf (%build) [ 105s] ### VM INTERACTION START ### [ 108s] [ 86.633225] sysrq: SysRq : Power Off [ 108s] [ 86.662527] reboot: Power down [ 109s] ### VM INTERACTION END ### [ 109s] [ 109s] obs-arm-6 failed "build osmo-hnodeb.spec" at Fri Dec 17 02:44:24 UTC 2021. [ 109s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 02:46:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 02:46:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/aarch64 In-Reply-To: References: Message-ID: <61bbfa0f6f330_4b3e2b08e0392600302674@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 175s] checking for LIBASN1C... yes [ 175s] checking for LIBOSMOCORE... yes [ 175s] checking for LIBOSMOVTY... yes [ 175s] checking for LIBOSMOCTRL... yes [ 175s] checking for LIBOSMOGSM... yes [ 175s] checking for LIBOSMOABIS... yes [ 175s] checking for LIBOSMOTRAU... no [ 175s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 175s] [ 175s] Package 'libosmotrau', required by 'virtual:world', not found [ 175s] [ 175s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 175s] installed software in a non-standard prefix. [ 175s] [ 175s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 175s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 175s] See the pkg-config man page for more details. [ 175s] error: Bad exit status from /var/tmp/rpm-tmp.OEb64G (%build) [ 175s] [ 175s] [ 175s] RPM build errors: [ 175s] Bad exit status from /var/tmp/rpm-tmp.OEb64G (%build) [ 176s] ### VM INTERACTION START ### [ 177s] Powering off. [ 177s] [ 132.808202] reboot: Power down [ 177s] ### VM INTERACTION END ### [ 177s] [ 177s] obs-arm-9 failed "build osmo-hnodeb.spec" at Fri Dec 17 02:46:08 UTC 2021. [ 177s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 17 03:06:01 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 03:06:01 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Factory_ARM/aarch64 In-Reply-To: References: Message-ID: <61bbfea2456ae_4b3e2b08e039260030597d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 61s] checking for LIBASN1C... yes [ 62s] checking for LIBOSMOCORE... yes [ 62s] checking for LIBOSMOVTY... yes [ 62s] checking for LIBOSMOCTRL... yes [ 62s] checking for LIBOSMOGSM... yes [ 62s] checking for LIBOSMOABIS... yes [ 62s] checking for LIBOSMOTRAU... no [ 62s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 62s] [ 62s] Package 'libosmotrau', required by 'virtual:world', not found [ 62s] [ 62s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 62s] installed software in a non-standard prefix. [ 62s] [ 62s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 62s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 62s] See the pkg-config man page for more details. [ 62s] error: Bad exit status from /var/tmp/rpm-tmp.ZxGmOO (%build) [ 62s] [ 62s] [ 62s] RPM build errors: [ 62s] Bad exit status from /var/tmp/rpm-tmp.ZxGmOO (%build) [ 62s] ### VM INTERACTION START ### [ 65s] [ 52.945477][ T419] sysrq: Power Off [ 65s] [ 53.013437][ T15] reboot: Power down [ 66s] ### VM INTERACTION END ### [ 66s] [ 66s] obs-arm-8 failed "build osmo-hnodeb.spec" at Fri Dec 17 03:05:51 UTC 2021. [ 66s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Dec 17 11:30:20 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 11:30:20 +0000 Subject: Change in docker-playground[master]: scripts/kernel-test/run-qemu.sh: update qemu args References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26599 ) Change subject: scripts/kernel-test/run-qemu.sh: update qemu args ...................................................................... scripts/kernel-test/run-qemu.sh: update qemu args Get rid of -nodefconfig, it has been removed in qemu 3.1. We are supposed to use -no-user-config instead, which we already do. Fix for this error we see since migrating to debian-bullseye: qemu-system-x86_64: -nodefconfig: invalid option Related: OS#4969 Related: https://qemu.readthedocs.io/en/stable/about/removed-features.html#nodefconfig-removed-in-3-1 Change-Id: I4a00f90980bf6d141ef8d86786e08d405db6db0b --- M scripts/kernel-test/run-qemu.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/99/26599/1 diff --git a/scripts/kernel-test/run-qemu.sh b/scripts/kernel-test/run-qemu.sh index 1873af4..9951e94 100755 --- a/scripts/kernel-test/run-qemu.sh +++ b/scripts/kernel-test/run-qemu.sh @@ -23,7 +23,7 @@ $MACHINE_ARG \ -smp 1 \ -m 512M \ - -nodefconfig -no-user-config -nodefaults -display none \ + -no-user-config -nodefaults -display none \ -gdb unix:/cache/kernel-test/gdb.pipe,server,nowait \ -no-reboot \ -kernel /cache/kernel-test/linux \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4a00f90980bf6d141ef8d86786e08d405db6db0b Gerrit-Change-Number: 26599 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 11:30:20 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 11:30:20 +0000 Subject: Change in docker-playground[master]: osmo-ggsn-*: install iproute2 for kernel tests References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26600 ) Change subject: osmo-ggsn-*: install iproute2 for kernel tests ...................................................................... osmo-ggsn-*: install iproute2 for kernel tests Add the package providing "ip", as debian bullseye doesn't have it installed by default anymore. Fix for: /kernel-test/qemu-ifup.sh: 9: ip: not found Related: OS#4969 Change-Id: I95560868a899169bf0cb05a02d5034d9a77b6af7 --- M osmo-ggsn-latest/Dockerfile M osmo-ggsn-master/Dockerfile 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/00/26600/1 diff --git a/osmo-ggsn-latest/Dockerfile b/osmo-ggsn-latest/Dockerfile index e5408e3..87b0a9e 100644 --- a/osmo-ggsn-latest/Dockerfile +++ b/osmo-ggsn-latest/Dockerfile @@ -20,6 +20,7 @@ flex \ gcc \ git \ + iproute2 \ libc6-dev \ libelf-dev \ libssl-dev \ diff --git a/osmo-ggsn-master/Dockerfile b/osmo-ggsn-master/Dockerfile index c3afb68..1a4504b 100644 --- a/osmo-ggsn-master/Dockerfile +++ b/osmo-ggsn-master/Dockerfile @@ -14,6 +14,7 @@ bridge-utils \ busybox-static \ ca-certificates \ + iproute2 \ libelf-dev \ libgtpnl-dev \ libosmocore-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26600 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I95560868a899169bf0cb05a02d5034d9a77b6af7 Gerrit-Change-Number: 26600 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 11:30:31 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 11:30:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop: add timeout for talloc report References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26601 ) Change subject: ttcn3-tcpdump-stop: add timeout for talloc report ...................................................................... ttcn3-tcpdump-stop: add timeout for talloc report Prevent the script from idling for several minutes without any output if obtaining the talloc report does not work. It seems to get killed eventually, but trying for 5s should be enough. Change-Id: I1bc5baeb94ecd25e1cdab98b060b99747c19d1f9 --- M ttcn3-tcpdump-stop.sh 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/26601/1 diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index 4fbc53f..faf5b2b 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -35,10 +35,15 @@ # Order the SUT to print a talloc report if [ "z$OSMO_SUT_HOST" != "z" ] && [ "z$OSMO_SUT_PORT" != "z" ]; then if [ -x "$(command -v osmo_interact_vty.py)" ]; then - osmo_interact_vty.py \ + echo "Saving talloc report from $OSMO_SUT_HOST:$OSMO_SUT_PORT to $TESTCASE.talloc" + if ! timeout 5 osmo_interact_vty.py \ -H $OSMO_SUT_HOST -p $OSMO_SUT_PORT \ -c "en; show talloc-context application full" \ - > "$TTCN3_PCAP_PATH/$TESTCASE.talloc" + > "$TTCN3_PCAP_PATH/$TESTCASE.talloc"; then + echo + echo "ERROR: failed to get talloc report via vty" + echo + fi else echo "Missing osmo_interact_vty.py from osmo-python-tests!" echo " -> Unable to obtain talloc report from the SUT" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1bc5baeb94ecd25e1cdab98b060b99747c19d1f9 Gerrit-Change-Number: 26601 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Dec 17 11:50:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 11:50:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Tumbleweed/i586 In-Reply-To: References: Message-ID: <61bc799825c1d_74d2b05e19645f853813@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 71s] checking for LIBASN1C... yes [ 71s] checking for LIBOSMOCORE... yes [ 71s] checking for LIBOSMOVTY... yes [ 71s] checking for LIBOSMOCTRL... yes [ 71s] checking for LIBOSMOGSM... yes [ 71s] checking for LIBOSMOABIS... yes [ 71s] checking for LIBOSMOTRAU... no [ 71s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 71s] [ 71s] Package 'libosmotrau', required by 'virtual:world', not found [ 71s] [ 71s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 71s] installed software in a non-standard prefix. [ 71s] [ 71s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 71s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 71s] See the pkg-config man page for more details. [ 71s] error: Bad exit status from /var/tmp/rpm-tmp.SvCETZ (%build) [ 71s] [ 71s] [ 71s] RPM build errors: [ 71s] Bad exit status from /var/tmp/rpm-tmp.SvCETZ (%build) [ 71s] ### VM INTERACTION START ### [ 74s] [ 56.700388][ T432] sysrq: Power Off [ 74s] [ 56.724224][ T16] reboot: Power down [ 75s] ### VM INTERACTION END ### [ 75s] [ 75s] lamb28 failed "build osmo-hnodeb.spec" at Fri Dec 17 11:50:11 UTC 2021. [ 75s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Dec 17 12:22:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 17 Dec 2021 12:22:26 +0000 Subject: Change in docker-playground[master]: scripts/kernel-test/run-qemu.sh: update qemu args In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26599 ) Change subject: scripts/kernel-test/run-qemu.sh: update qemu args ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4a00f90980bf6d141ef8d86786e08d405db6db0b Gerrit-Change-Number: 26599 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 12:22:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 12:22:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 17 Dec 2021 12:22:46 +0000 Subject: Change in docker-playground[master]: osmo-ggsn-*: install iproute2 for kernel tests In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26600 ) Change subject: osmo-ggsn-*: install iproute2 for kernel tests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26600 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I95560868a899169bf0cb05a02d5034d9a77b6af7 Gerrit-Change-Number: 26600 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 12:22:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 12:23:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 17 Dec 2021 12:23:29 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop: add timeout for talloc report In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26601 ) Change subject: ttcn3-tcpdump-stop: add timeout for talloc report ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1bc5baeb94ecd25e1cdab98b060b99747c19d1f9 Gerrit-Change-Number: 26601 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 12:23:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Dec 17 12:38:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 17 Dec 2021 12:38:35 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in openSUSE_Tumbleweed/x86_64 In-Reply-To: References: Message-ID: <61bc84d660e10_74d2b05e19645f867186@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 67s] checking for LIBASN1C... yes [ 67s] checking for LIBOSMOCORE... yes [ 67s] checking for LIBOSMOVTY... yes [ 67s] checking for LIBOSMOCTRL... yes [ 67s] checking for LIBOSMOGSM... yes [ 67s] checking for LIBOSMOABIS... yes [ 67s] checking for LIBOSMOTRAU... no [ 67s] configure: error: Package requirements (libosmotrau >= 1.2.0) were not met: [ 67s] [ 67s] Package 'libosmotrau', required by 'virtual:world', not found [ 67s] [ 67s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 67s] installed software in a non-standard prefix. [ 67s] [ 67s] Alternatively, you may set the environment variables LIBOSMOTRAU_CFLAGS [ 67s] and LIBOSMOTRAU_LIBS to avoid the need to call pkg-config. [ 67s] See the pkg-config man page for more details. [ 67s] error: Bad exit status from /var/tmp/rpm-tmp.0KDzUk (%build) [ 67s] [ 67s] [ 67s] RPM build errors: [ 67s] Bad exit status from /var/tmp/rpm-tmp.0KDzUk (%build) [ 67s] ### VM INTERACTION START ### [ 70s] [ 53.580796][ T436] sysrq: Power Off [ 70s] [ 53.616129][ T16] reboot: Power down [ 70s] ### VM INTERACTION END ### [ 70s] [ 70s] lamb04 failed "build osmo-hnodeb.spec" at Fri Dec 17 12:38:20 UTC 2021. [ 70s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Dec 17 12:40:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 17 Dec 2021 12:40:47 +0000 Subject: Change in osmo-hnodeb[master]: llsk_gtp: Early return if conn alloc fails References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26602 ) Change subject: llsk_gtp: Early return if conn alloc fails ...................................................................... llsk_gtp: Early return if conn alloc fails Change-Id: Iaf597b76ceb9cce3f27c42625f963f740c8f213e --- M src/osmo-hnodeb/llsk_gtp.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/02/26602/1 diff --git a/src/osmo-hnodeb/llsk_gtp.c b/src/osmo-hnodeb/llsk_gtp.c index 30451a0..a224d56 100644 --- a/src/osmo-hnodeb/llsk_gtp.c +++ b/src/osmo-hnodeb/llsk_gtp.c @@ -169,6 +169,9 @@ /* Create the socket: */ conn = gtp_conn_alloc(ue); + if (!conn) + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); + if ((rc = gtp_conn_setup(conn, &rem_osa, ce_req->remote_tei)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: Failed to set up gtp socket rem_tei=%u rem_addr=%s\n", ce_req->remote_tei, rem_addrstr); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Iaf597b76ceb9cce3f27c42625f963f740c8f213e Gerrit-Change-Number: 26602 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 12:40:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 17 Dec 2021 12:40:47 +0000 Subject: Change in osmo-hnodeb[master]: llsk_audio: Fix false positive about uninitialized var access References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26603 ) Change subject: llsk_audio: Fix false positive about uninitialized var access ...................................................................... llsk_audio: Fix false positive about uninitialized var access Let's make gcc in Ubuntu 21.10 happy. Change-Id: If085b0ca0e1d3e7237696eb67cf6301ea84793e0 --- M src/osmo-hnodeb/llsk_audio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/03/26603/1 diff --git a/src/osmo-hnodeb/llsk_audio.c b/src/osmo-hnodeb/llsk_audio.c index 7ce5c09..a600c3c 100644 --- a/src/osmo-hnodeb/llsk_audio.c +++ b/src/osmo-hnodeb/llsk_audio.c @@ -152,7 +152,7 @@ char rem_addrstr[INET6_ADDRSTRLEN+32]; struct osmo_sockaddr rem_osa = {0}; union u_addr loc_uaddr = {0}; - uint16_t loc_port; + uint16_t loc_port = 0; struct rtp_conn *conn = NULL; rc = ll_addr2osa(ce_req->remote_rtp_address_type, &ce_req->remote_rtp_addr, ce_req->remote_rtp_port, &rem_osa); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If085b0ca0e1d3e7237696eb67cf6301ea84793e0 Gerrit-Change-Number: 26603 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 12:40:47 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 17 Dec 2021 12:40:47 +0000 Subject: Change in osmo-hnodeb[master]: contrib/osmo-hnodeb.spec.in: Fix missing dep libosmotrau References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26604 ) Change subject: contrib/osmo-hnodeb.spec.in: Fix missing dep libosmotrau ...................................................................... contrib/osmo-hnodeb.spec.in: Fix missing dep libosmotrau Change-Id: Ia40b6a28caecdd94ce3c53172fe531b12a0a221f --- M contrib/osmo-hnodeb.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/04/26604/1 diff --git a/contrib/osmo-hnodeb.spec.in b/contrib/osmo-hnodeb.spec.in index fef34af..afa1816 100644 --- a/contrib/osmo-hnodeb.spec.in +++ b/contrib/osmo-hnodeb.spec.in @@ -36,6 +36,7 @@ BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmotrau) >= 1.2.0 BuildRequires: pkgconfig(libosmocore) >= 1.6.0 BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 BuildRequires: pkgconfig(libosmogb) >= 1.6.0 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ia40b6a28caecdd94ce3c53172fe531b12a0a221f Gerrit-Change-Number: 26604 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 12:45:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 17 Dec 2021 12:45:51 +0000 Subject: Change in osmo-hnodeb[master]: gtp: Fix possible null pointer dereference References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26605 ) Change subject: gtp: Fix possible null pointer dereference ...................................................................... gtp: Fix possible null pointer dereference Closes: Coverity CID#242771 Change-Id: I412082cc5fa93818d321210c34a2d22c038cb985 --- M src/osmo-hnodeb/gtp.c 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/05/26605/1 diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c index 22d4074..f7d9a14 100644 --- a/src/osmo-hnodeb/gtp.c +++ b/src/osmo-hnodeb/gtp.c @@ -79,12 +79,18 @@ struct hnb *hnb; int rc; - if (!conn || !conn->ue->conn_ps.active) { - LOGUE(conn->ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", - packet, len); + if (!conn) { + LOGP(DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u with no conn!\n", + packet, len); return -EINVAL; } ue = conn->ue; + + if (!ue->conn_ps.active) { + LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", + packet, len); + return -EINVAL; + } hnb = ue->hnb; LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I412082cc5fa93818d321210c34a2d22c038cb985 Gerrit-Change-Number: 26605 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:03:12 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 17 Dec 2021 13:03:12 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26454 to look at the new patch set (#10). Change subject: select: gather statistics for TCP connections ...................................................................... select: gather statistics for TCP connections osmocom applications are deployed in a variety of different situations. Dependung on the medium that interconnects the network components unexpected behaviour may occur. To debug problems with the interconnection between network components it might help to monitor the health of the related TCP connections. Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Related: SYS#5701 --- M configure.ac M include/Makefile.am A include/osmocom/core/stats_tcp.h M src/Makefile.am M src/select.c A src/stats_tcp.c A src/stats_tcp_internal.h M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 9 files changed, 364 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/26454/10 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 10 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:03:12 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 17 Dec 2021 13:03:12 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 10: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/select.c at 188 PS9, Line 188: osmo_stats_tcp_osmo_fd_unregister(fd); > so we are now converting a O(k) operation into an O(n) one. [?] Lets not make this over-complicated. https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/stats_tcp.c File src/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/stats_tcp.c at 194 PS9, Line 194: return; > agreed Done https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/stats_tcp.c at 210 PS9, Line 210: void osmo_stats_tcp_osmo_fd_unregister(const struct osmo_fd *fd) > yes, but I don't think it matters all that much. [?] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 10 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 17 Dec 2021 13:03:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:08:58 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 17 Dec 2021 13:08:58 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26454 to look at the new patch set (#11). Change subject: select: gather statistics for TCP connections ...................................................................... select: gather statistics for TCP connections osmocom applications are deployed in a variety of different situations. Dependung on the medium that interconnects the network components unexpected behaviour may occur. To debug problems with the interconnection between network components it might help to monitor the health of the related TCP connections. Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Related: SYS#5701 --- M configure.ac M include/Makefile.am A include/osmocom/core/stats_tcp.h M src/Makefile.am M src/select.c A src/stats_tcp.c A src/stats_tcp_internal.h M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 9 files changed, 364 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/26454/11 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 11 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:26:53 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 13:26:53 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop: add timeout for talloc report In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26601 ) Change subject: ttcn3-tcpdump-stop: add timeout for talloc report ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1bc5baeb94ecd25e1cdab98b060b99747c19d1f9 Gerrit-Change-Number: 26601 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 13:26:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:27:15 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 13:27:15 +0000 Subject: Change in docker-playground[master]: osmo-ggsn-*: install iproute2 for kernel tests In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26600 ) Change subject: osmo-ggsn-*: install iproute2 for kernel tests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26600 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I95560868a899169bf0cb05a02d5034d9a77b6af7 Gerrit-Change-Number: 26600 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 13:27:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:27:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 13:27:32 +0000 Subject: Change in docker-playground[master]: scripts/kernel-test/run-qemu.sh: update qemu args In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26599 ) Change subject: scripts/kernel-test/run-qemu.sh: update qemu args ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4a00f90980bf6d141ef8d86786e08d405db6db0b Gerrit-Change-Number: 26599 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 13:27:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:32:01 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:32:01 +0000 Subject: Change in libosmocore[master]: PFCP: add DLPFCP and osmo-upf port numbers References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26606 ) Change subject: PFCP: add DLPFCP and osmo-upf port numbers ...................................................................... PFCP: add DLPFCP and osmo-upf port numbers Change-Id: I0a46b147ec6a76d909df28136cfd2b764b2c75ea --- M include/osmocom/core/logging.h M include/osmocom/ctrl/ports.h M include/osmocom/vty/ports.h M src/logging.c 4 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/26606/1 diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index 18ad3ff..6a2b9d0 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -136,7 +136,8 @@ #define DLBSSGP -21 /*!< Osmocom BSSGP layer */ #define DLNSDATA -22 /*!< Osmocom NS layer data pdus */ #define DLNSSIGNAL -23 /*!< Osmocom NS layer signal pdus */ -#define OSMO_NUM_DLIB 23 /*!< Number of logging sub-systems in libraries */ +#define DLPFCP -24 /*!< Osmocom Packet Forwarding Control Protocol */ +#define OSMO_NUM_DLIB 24 /*!< Number of logging sub-systems in libraries */ /* Colors that can be used in log_info_cat.color */ #define OSMO_LOGCOLOR_NORMAL NULL diff --git a/include/osmocom/ctrl/ports.h b/include/osmocom/ctrl/ports.h index 56d663a..d287940 100644 --- a/include/osmocom/ctrl/ports.h +++ b/include/osmocom/ctrl/ports.h @@ -30,4 +30,6 @@ #define OSMO_CTRL_PORT_SMLC 4272 /* 4273 used by VTY interface */ #define OSMO_CTRL_PORT_HNODEB 4274 +/* 4275: OSMO_VTY_PORT_UPF */ +#define OSMO_CTRL_PORT_UPF 4276 /* When adding/changing port numbers, keep docs and wiki in sync. See above. */ diff --git a/include/osmocom/vty/ports.h b/include/osmocom/vty/ports.h index cfefaa8..75ff86f 100644 --- a/include/osmocom/vty/ports.h +++ b/include/osmocom/vty/ports.h @@ -42,4 +42,6 @@ /* 4272 used by control interface */ #define OSMO_VTY_PORT_HNODEB 4273 /* 4274 used by control interface */ +#define OSMO_VTY_PORT_UPF 4275 +/* 4276: OSMO_CTRL_PORT_UPF */ /* When adding/changing port numbers, keep docs and wiki in sync. See above. */ diff --git a/src/logging.c b/src/logging.c index 9497f28..6a97833 100644 --- a/src/logging.c +++ b/src/logging.c @@ -294,6 +294,12 @@ .enabled = 1, .loglevel = LOGL_NOTICE, .color = "\033[38;5;63m", }, + [INT2IDX(DLPFCP)] = { + .name = "DLPFCP", + .description = "libosmo-pfcp Packet Forwarding Control Protocol", + .enabled = 1, .loglevel = LOGL_NOTICE, + .color = "\033[38;5;51m", + }, }; void assert_loginfo(const char *src) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0a46b147ec6a76d909df28136cfd2b764b2c75ea Gerrit-Change-Number: 26606 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:32:01 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:32:01 +0000 Subject: Change in libosmocore[master]: ports.h: add osmo-pfcp-tool References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26607 ) Change subject: ports.h: add osmo-pfcp-tool ...................................................................... ports.h: add osmo-pfcp-tool Change-Id: I8a5f437d934b9bda11ea593b50bd18c7d5d71ce9 --- M include/osmocom/ctrl/ports.h M include/osmocom/vty/ports.h 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/26607/1 diff --git a/include/osmocom/ctrl/ports.h b/include/osmocom/ctrl/ports.h index d287940..b4bceef 100644 --- a/include/osmocom/ctrl/ports.h +++ b/include/osmocom/ctrl/ports.h @@ -32,4 +32,6 @@ #define OSMO_CTRL_PORT_HNODEB 4274 /* 4275: OSMO_VTY_PORT_UPF */ #define OSMO_CTRL_PORT_UPF 4276 +/* 4277: OSMO_VTY_PORT_PFCP_TOOL */ +#define OSMO_CTRL_PORT_PFCP_TOOL 4278 /* When adding/changing port numbers, keep docs and wiki in sync. See above. */ diff --git a/include/osmocom/vty/ports.h b/include/osmocom/vty/ports.h index 75ff86f..d3b1d7a 100644 --- a/include/osmocom/vty/ports.h +++ b/include/osmocom/vty/ports.h @@ -44,4 +44,6 @@ /* 4274 used by control interface */ #define OSMO_VTY_PORT_UPF 4275 /* 4276: OSMO_CTRL_PORT_UPF */ +#define OSMO_VTY_PORT_PFCP_TOOL 4277 +/* 4278: OSMO_CTRL_PORT_UPF */ /* When adding/changing port numbers, keep docs and wiki in sync. See above. */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8a5f437d934b9bda11ea593b50bd18c7d5d71ce9 Gerrit-Change-Number: 26607 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:32:01 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:32:01 +0000 Subject: Change in libosmocore[master]: add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2() References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26608 ) Change subject: add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2() ...................................................................... add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2() To easily log and print a sockaddr using OTC_SELECT, add osmo_sockaddr_to_str_c(). Implement osmo_sockaddr_to_str_buf2() using osmo_strbuf, so that we can return the chars_needed which osmo_sockaddr_to_str_c() uses. From previous osmo_sockaddr_to_str_buf(), call osmo_sockaddr_to_str_buf2() and return NULL if the buf_len was insufficient, to mimick previous behavior. This makes it more consistently returning NULL for insufficient buf_len, as shown in the tweak that is needed in socket_test.c. Before osmo_sockaddr_to_str_buf() would return a truncated port number, now it's all or NULL. I will use osmo_sockaddr_to_str_c() in the new osmo-upf implementation. Related: SYS#5599 Change-Id: I12771bf8a021e6785217b1faad03c09ec1cfef0e --- M include/osmocom/core/socket.h M src/socket.c M tests/socket/socket_test.c 3 files changed, 59 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/08/26608/1 diff --git a/include/osmocom/core/socket.h b/include/osmocom/core/socket.h index a053391..6d11e6f 100644 --- a/include/osmocom/core/socket.h +++ b/include/osmocom/core/socket.h @@ -130,6 +130,8 @@ const char *osmo_sockaddr_to_str(const struct osmo_sockaddr *sockaddr); char *osmo_sockaddr_to_str_buf(char *buf, size_t buf_len, const struct osmo_sockaddr *sockaddr); +int osmo_sockaddr_to_str_buf2(char *buf, size_t buf_len, const struct osmo_sockaddr *sockaddr); +char *osmo_sockaddr_to_str_c(void *ctx, const struct osmo_sockaddr *sockaddr); int osmo_sock_set_dscp(int fd, uint8_t dscp); int osmo_sock_set_priority(int fd, int prio); diff --git a/src/socket.c b/src/socket.c index 1251061..3757539 100644 --- a/src/socket.c +++ b/src/socket.c @@ -1775,7 +1775,57 @@ return osmo_sockaddr_to_str_buf(buf, sizeof(buf), sockaddr); } -/*! string-format a given osmo_sockaddr address into a user-supplied buffer +/*! string-format a given osmo_sockaddr address into a user-supplied buffer. + * Same as osmo_sockaddr_to_str_buf() but returns a would-be length in snprintf() style. + * \param[in] buf user-supplied output buffer + * \param[in] buf_len size of the user-supplied output buffer in bytes + * \param[in] sockaddr the osmo_sockaddr to print + * \return number of characters that would be written if the buffer is large enough, like snprintf(). + */ +int osmo_sockaddr_to_str_buf2(char *buf, size_t buf_len, const struct osmo_sockaddr *sockaddr) +{ + struct osmo_strbuf sb = { .buf = buf, .len = buf_len }; + uint16_t port = 0; + + if (!sockaddr) { + OSMO_STRBUF_PRINTF(sb, "NULL"); + return sb.chars_needed; + } + + switch (sockaddr->u.sa.sa_family) { + case AF_INET: + OSMO_STRBUF_APPEND(sb, osmo_sockaddr_to_str_and_uint, &port, &sockaddr->u.sa); + if (port) + OSMO_STRBUF_PRINTF(sb, ":%u", port); + break; + case AF_INET6: + OSMO_STRBUF_PRINTF(sb, "["); + OSMO_STRBUF_APPEND(sb, osmo_sockaddr_to_str_and_uint, &port, &sockaddr->u.sa); + OSMO_STRBUF_PRINTF(sb, "]"); + if (port) + OSMO_STRBUF_PRINTF(sb, ":%u", port); + break; + default: + OSMO_STRBUF_PRINTF(sb, "unsupported family %d", sockaddr->u.sa.sa_family); + break; + } + + return sb.chars_needed; +} + +/*! string-format a given osmo_sockaddr address into a talloc allocated buffer. + * Like osmo_sockaddr_to_str_buf2() but returns a talloc allocated string. + * \param[in] ctx talloc context to allocate from, e.g. OTC_SELECT. + * \param[in] sockaddr the osmo_sockaddr to print. + * \return human readable string. + */ +char *osmo_sockaddr_to_str_c(void *ctx, const struct osmo_sockaddr *sockaddr) +{ + OSMO_NAME_C_IMPL(ctx, 64, "ERROR", osmo_sockaddr_to_str_buf2, sockaddr) +} + +/*! string-format a given osmo_sockaddr address into a user-supplied buffer. + * Like osmo_sockaddr_to_str_buf2() but returns buf, or NULL if too short. * \param[in] buf user-supplied output buffer * \param[in] buf_len size of the user-supplied output buffer in bytes * \param[in] sockaddr the osmo_sockaddr to print @@ -1784,43 +1834,9 @@ char *osmo_sockaddr_to_str_buf(char *buf, size_t buf_len, const struct osmo_sockaddr *sockaddr) { - uint16_t port = 0; - size_t written; - if (buf_len < 5) + int chars_needed = osmo_sockaddr_to_str_buf2(buf, buf_len, sockaddr); + if (chars_needed >= buf_len) return NULL; - - if (!sockaddr) - return NULL; - - switch (sockaddr->u.sa.sa_family) { - case AF_INET: - written = osmo_sockaddr_to_str_and_uint(buf, buf_len, &port, &sockaddr->u.sa); - if (written + 1 >= buf_len && port) - return NULL; - if (port) - snprintf(buf + written, buf_len - written, ":%u", port); - break; - case AF_INET6: - buf[0] = '['; - written = osmo_sockaddr_to_str_and_uint(buf + 1, buf_len - 1, &port, &sockaddr->u.sa); - if (written + 2 >= buf_len) - return NULL; - - if (written + 3 >= buf_len && port) - return NULL; - - if (port) - snprintf(buf + 1 + written, buf_len - written - 1, "]:%u", port); - else { - buf[written + 1] = ']'; - buf[written + 2] = 0; - } - break; - default: - snprintf(buf, buf_len, "unsupported family %d", sockaddr->u.sa.sa_family); - return buf; - } - return buf; } diff --git a/tests/socket/socket_test.c b/tests/socket/socket_test.c index eda716a..fe77b92 100644 --- a/tests/socket/socket_test.c +++ b/tests/socket/socket_test.c @@ -345,9 +345,11 @@ OSMO_ASSERT(!strncmp("[::1]:42", result, sizeof(buf))); memset(&buf[0], 0, sizeof(buf)); - result = osmo_sockaddr_to_str_buf(buf, 8, &localhost6); printf("Checking osmo_sockaddr_to_str_buf too short IPv6\n"); - OSMO_ASSERT(!strncmp("[::1]:4", result, sizeof(buf))); + result = osmo_sockaddr_to_str_buf(buf, 8, &localhost6); + OSMO_ASSERT(result == NULL); + osmo_sockaddr_to_str_buf2(buf, 8, &localhost6); + OSMO_ASSERT(!strncmp("[::1]:4", buf, sizeof(buf))); memset(&buf[0], 0, sizeof(buf)); result = osmo_sockaddr_to_str_buf(buf, 5, &localhost6); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I12771bf8a021e6785217b1faad03c09ec1cfef0e Gerrit-Change-Number: 26608 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:38:31 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 13:38:31 +0000 Subject: Change in osmo-hnodeb[master]: Fix several Coverity found issues In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 ) Change subject: Fix several Coverity found issues ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595/1/src/osmo-hnodeb/gtp.c File src/osmo-hnodeb/gtp.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595/1/src/osmo-hnodeb/gtp.c at 187 PS1, Line 187: LOGUE(ue I guess you want to use LOGP here, like above. https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595/1/src/osmo-hnodeb/gtp.c at 193 PS1, Line 193: LOGUE(ue > LOGUE is safely non-null here. Sorry, wrong comment location. See above. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6d73a970919889953539fbacc601d679d7ec4113 Gerrit-Change-Number: 26595 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 13:38:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:14 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:14 +0000 Subject: Change in osmo-bsc[master]: log: always include timeouts in FSM transition logging References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26609 ) Change subject: log: always include timeouts in FSM transition logging ...................................................................... log: always include timeouts in FSM transition logging Before: state_chg to ACTIVE state_chg to WAIT_RLL_RTP_RELEASED state_chg to WAIT_SCCP_RLSD After: State change to ACTIVE (no timeout) State change to WAIT_RLL_RTP_RELEASED (T3109, 5s) State change to WAIT_SCCP_RLSD (X4, 60s) Change-Id: I94b7dc4d9e5e45dc731bcb3a843ede9fb6cc0839 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/09/26609/1 diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index b7e2616..167b0a3 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -891,6 +891,7 @@ rate_ctr_init(tall_bsc_ctx); osmo_fsm_set_dealloc_ctx(OTC_SELECT); + osmo_fsm_log_timeouts(true); /* Allocate global gsm_network struct */ rc = bsc_network_alloc(); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I94b7dc4d9e5e45dc731bcb3a843ede9fb6cc0839 Gerrit-Change-Number: 26609 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:15 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:15 +0000 Subject: Change in osmo-bsc[master]: lchan/gscon: always clear both cross ref pointers References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26610 ) Change subject: lchan/gscon: always clear both cross ref pointers ...................................................................... lchan/gscon: always clear both cross ref pointers During specific release scenarios, it became clear that an lchan still pointed at a conn even after it had been deallocated. That was due to setting conn->lchan = NULL but not lchan->conn = NULL. Fix that. Do lchan_forget_conn() first, because during gscon_forget_lchan() we may enter the gscon clearing dance, which in case of no SCCP conn being present will soon / should immediately deallocate the conn. Related: OS#5337 Related: I8c8537acf6b47b121903197608636c43ae601a57 (osmo-bsc) Change-Id: Idbfe4672233ba8105eff5ba77ee07fd871358255 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/10/26610/1 diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 5ae6df6..84f8dc5 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -478,8 +478,11 @@ { LOG_LCHAN(lchan, LOGL_DEBUG, "Clearing lchan state\n"); - if (lchan->conn) - gscon_forget_lchan(lchan->conn, lchan); + if (lchan->conn) { + struct gsm_subscriber_connection *conn = lchan->conn; + lchan_forget_conn(lchan); + gscon_forget_lchan(conn, lchan); + } if (lchan->rqd_ref) { talloc_free(lchan->rqd_ref); @@ -1392,8 +1395,9 @@ * lchan_reset(), we make sure it does. But in case of releases from error handling, the * conn might as well notice now already that its lchan is becoming unusable. */ if (lchan->conn) { - gscon_forget_lchan(lchan->conn, lchan); + struct gsm_subscriber_connection *conn = lchan->conn; lchan_forget_conn(lchan); + gscon_forget_lchan(conn, lchan); } rc = rsl_tx_rf_chan_release(lchan); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idbfe4672233ba8105eff5ba77ee07fd871358255 Gerrit-Change-Number: 26610 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:15 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:15 +0000 Subject: Change in osmo-bsc[master]: lcs: fix bsc_subscr use_count leak References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26611 ) Change subject: lcs: fix bsc_subscr use_count leak ...................................................................... lcs: fix bsc_subscr use_count leak In lcs_ta_req_wait_ta_onenter(), fix use count leak of 'start-paging': get() the use count only after the early exits. osmo-ttcn3-hacks patch I69d4c5c6f8d499bb7f0b96a48af045361433c57b introduces testing against this leak in various LCS tests (e.g. BSC_Tests.TC_lcs_loc_req_for_active_ms_ta_req). Related: OS#5355 Change-Id: Ibbfbfe766eafe42c78048ec5b3b503a11ef5535d --- M src/osmo-bsc/lcs_ta_req.c 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/26611/1 diff --git a/src/osmo-bsc/lcs_ta_req.c b/src/osmo-bsc/lcs_ta_req.c index 6252d46..f0bb02e 100644 --- a/src/osmo-bsc/lcs_ta_req.c +++ b/src/osmo-bsc/lcs_ta_req.c @@ -122,17 +122,6 @@ return; } - paging = (struct bsc_paging_params){ - .reason = BSC_PAGING_FOR_LCS, - .msc = loc_req->conn->sccp.msc, - .bsub = loc_req->conn->bsub, - .tmsi = GSM_RESERVED_TMSI, - .imsi = loc_req->req.imsi, - .chan_needed = RSL_CHANNEED_ANY, - }; - if (paging.bsub) - bsc_subscr_get(paging.bsub, BSUB_USE_PAGING_START); - /* Do we already have an active lchan with knowledge of TA? */ lchan = loc_req->conn->lchan; if (lchan) { @@ -147,6 +136,17 @@ return; } + paging = (struct bsc_paging_params){ + .reason = BSC_PAGING_FOR_LCS, + .msc = loc_req->conn->sccp.msc, + .bsub = loc_req->conn->bsub, + .tmsi = GSM_RESERVED_TMSI, + .imsi = loc_req->req.imsi, + .chan_needed = RSL_CHANNEED_ANY, + }; + if (paging.bsub) + bsc_subscr_get(paging.bsub, BSUB_USE_PAGING_START); + if (!loc_req->req.cell_id_present) { LOG_LCS_TA_REQ(lcs_ta_req, LOGL_DEBUG, "No Cell Identity in BSSMAP Location Request, paging entire BSS\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibbfbfe766eafe42c78048ec5b3b503a11ef5535d Gerrit-Change-Number: 26611 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:15 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:15 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 1/n: store clear cause in gscon References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26612 ) Change subject: fix gscon clear 1/n: store clear cause in gscon ...................................................................... fix gscon clear 1/n: store clear cause in gscon Allow returning a context sensitive cause instead of a hardcoded one in gscon pre_term(). Also, the conn->cause is needed to move message dispatch to an "onenter" function in patch I234b2a754d0c98031056981823cdbc187e977741. I Split this part off as a separate patch for better readability. Related: OS#5337 Change-Id: Ib6432746040899129d1d73ae8dc59add2d88a915 --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_subscr_conn_fsm.c 2 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/12/26612/1 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 238b2f7..4e26ec1 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -404,6 +404,8 @@ bool last_eutran_plmn_valid; /* Is information stored in field below available? */ struct osmo_plmn_id last_eutran_plmn; } fast_return; + + enum gsm0808_cause clear_cause; }; diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index 2140c9b..ff742a2 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -144,6 +144,7 @@ struct msgb *resp; int rc; + conn->clear_cause = cause; if (conn->rx_clear_command) { LOGPFSML(conn->fi, LOGL_DEBUG, "Not sending BSSMAP CLEAR REQUEST, already got CLEAR COMMAND from MSC\n"); @@ -976,9 +977,7 @@ } LOGPFSML(fi, LOGL_DEBUG, "Releasing all lchans (if any) because this conn is terminating\n"); - /* when things go smoothly, the lchan should have been released before FSM instance termination. So if this is - * necessary it's probably "abnormal". */ - gscon_release_lchans(conn, true, GSM48_RR_CAUSE_ABNORMAL_UNSPEC); + gscon_release_lchans(conn, true, bsc_gsm48_rr_cause_from_gsm0808_cause(conn->clear_cause)); /* drop pending messages */ gscon_dtap_queue_flush(conn, 0); @@ -1057,6 +1056,9 @@ INIT_LLIST_HEAD(&conn->hodec2.penalty_timers); conn->sccp.conn_id = -1; + /* Default clear cause (on RR translates to GSM48_RR_CAUSE_ABNORMAL_UNSPEC) */ + conn->clear_cause = GSM0808_CAUSE_EQUIPMENT_FAILURE; + /* don't allocate from 'conn' context, as gscon_cleanup() will call talloc_free(conn) before * libosmocore will call talloc_free(conn->fi), i.e. avoid use-after-free during cleanup */ conn->fi = osmo_fsm_inst_alloc(&gscon_fsm, net, conn, LOGL_DEBUG, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib6432746040899129d1d73ae8dc59add2d88a915 Gerrit-Change-Number: 26612 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:16 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:16 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 2/n: proper state transition to ST_CLEARING References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26613 ) Change subject: fix gscon clear 2/n: proper state transition to ST_CLEARING ...................................................................... fix gscon clear 2/n: proper state transition to ST_CLEARING The way the ST_CLEARING is entered before this patch has various symptoms of how I / we used osmo_fsm when we were still FSM amateurs in Osmocom. Patch that up: - Do state transitioning into gscon_bssmap_clear(), move the Clear Request messaging to ST_CLEARING's onenter function. - In gscon_bssmap_clear(), ask for a state transition to ST_CLEARING first. Go ahead only if it is allowed. - Fix the timeout behavior: by using conn_fsm_state_chg(), use the actual proper X4 timer value from VTY configuration instead of hardcoded magic numbers in various places. Related: OS#5337 Change-Id: I234b2a754d0c98031056981823cdbc187e977741 --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 20 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/13/26613/1 diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index ff742a2..e33fe43 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -141,10 +141,24 @@ static void gscon_bssmap_clear(struct gsm_subscriber_connection *conn, enum gsm0808_cause cause) { + /* already clearing? */ + switch (conn->fi->state) { + case ST_CLEARING: + return; + default: + break; + } + conn->clear_cause = cause; + conn_fsm_state_chg(ST_CLEARING); +} + +static void gscon_fsm_clearing_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ struct msgb *resp; int rc; - conn->clear_cause = cause; + struct gsm_subscriber_connection *conn = fi->priv; + enum gsm0808_cause cause = conn->clear_cause; if (conn->rx_clear_command) { LOGPFSML(conn->fi, LOGL_DEBUG, "Not sending BSSMAP CLEAR REQUEST, already got CLEAR COMMAND from MSC\n"); @@ -152,14 +166,14 @@ } if (!conn->sccp.msc) { - LOGPFSML(conn->fi, LOGL_ERROR, "Unable to deliver BSSMAP Clear Request message, no MSC for this conn\n"); + LOGPFSML(fi, LOGL_ERROR, "Unable to deliver BSSMAP Clear Request message, no MSC for this conn\n"); return; } - LOGPFSML(conn->fi, LOGL_DEBUG, "Tx BSSMAP CLEAR REQUEST(%s) to MSC\n", gsm0808_cause_name(cause)); + LOGPFSML(fi, LOGL_DEBUG, "Tx BSSMAP CLEAR REQUEST(%s) to MSC\n", gsm0808_cause_name(cause)); resp = gsm0808_create_clear_rqst(cause); if (!resp) { - LOGPFSML(conn->fi, LOGL_ERROR, "Unable to compose BSSMAP Clear Request message\n"); + LOGPFSML(fi, LOGL_ERROR, "Unable to compose BSSMAP Clear Request message\n"); return; } @@ -355,8 +369,6 @@ osmo_fsm_inst_state_name(conn->fi)); } gscon_bssmap_clear(conn, GSM0808_CAUSE_EQUIPMENT_FAILURE); - if (conn->fi->state != ST_CLEARING) - osmo_fsm_inst_state_chg(fi, ST_CLEARING, 60, -4); return; default: OSMO_ASSERT(false); @@ -376,7 +388,6 @@ confirmed connection, then instead simply drop the connection */ LOGPFSML(fi, LOGL_INFO, "Connection confirmed but lchan was dropped previously, clearing conn\n"); - osmo_fsm_inst_state_chg(conn->fi, ST_CLEARING, 60, -4); gscon_bssmap_clear(conn, GSM0808_CAUSE_EQUIPMENT_FAILURE); break; } @@ -705,6 +716,7 @@ }, [ST_CLEARING] = { .name = "CLEARING", + .onenter = gscon_fsm_clearing_onenter, /* dead end state */ }, }; @@ -763,11 +775,6 @@ yet so we cannot release it. First wait for the CC, and release in gscon_fsm_wait_cc(). */ break; default: - /* Ensure that the FSM is in ST_CLEARING. */ - osmo_fsm_inst_state_chg(conn->fi, ST_CLEARING, 60, -4); - /* fall thru, omit an error log if already in ST_CLEARING */ - case ST_CLEARING: - /* Request a Clear Command from the MSC. */ gscon_bssmap_clear(conn, GSM0808_CAUSE_EQUIPMENT_FAILURE); break; } @@ -806,8 +813,7 @@ osmo_fsm_inst_name(conn->fi), detach_label); } - if ((conn->fi && conn->fi->state != ST_CLEARING) - && !conn->lchan + if (!conn->lchan && !conn->ho.new_lchan && !conn->assignment.new_lchan && !conn->lcs.loc_req) @@ -1205,7 +1211,6 @@ failed_to_send: LOGPFSML(conn->fi, LOGL_ERROR, "Tx BSSMAP CLEAR REQUEST to MSC\n"); gscon_bssmap_clear(conn, GSM0808_CAUSE_EQUIPMENT_FAILURE); - osmo_fsm_inst_state_chg(conn->fi, ST_ACTIVE, 0, 0); } void gscon_submit_rsl_dtap(struct gsm_subscriber_connection *conn, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I234b2a754d0c98031056981823cdbc187e977741 Gerrit-Change-Number: 26613 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: ipse Gerrit-Reviewer: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:16 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:16 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 3/n: separate state for SCCP RLSD References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26614 ) Change subject: fix gscon clear 3/n: separate state for SCCP RLSD ...................................................................... fix gscon clear 3/n: separate state for SCCP RLSD Properly implement the separate conn release stages in separate FSM states: x) sent Clear Request, wait for a Clear Command from the MSC. Timeout after a configurable 60s. y) after a Clear Command and sending a Clear Complete, wait for the SCCP RLSD. Timeout after a configurable 60s. z) terminate after the RLSD is received / after timeout. handover_test.c needs a little tweak to make the MGCP release work with its fake MGCP client, because cleanup now ensures to invoke gscon_forget_mgw_endpoint() in all cases. Related: I680ec4ed866aa5f0b1ff29e7e98322615cfb288d (osmo-ttcn3-hacks) Related: OS#5337 Change-Id: Ie975117d37f38ba853589dc7f8d3e94f8f9586b2 --- M src/osmo-bsc/bsc_subscr_conn_fsm.c M tests/handover/handover_test.c 2 files changed, 75 insertions(+), 54 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/14/26614/1 diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index e33fe43..121b154 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -67,7 +67,8 @@ ST_ASSIGNMENT, ST_HANDOVER, /* BSSMAP CLEAR has been received */ - ST_CLEARING, + ST_WAIT_CLEAR_CMD, + ST_WAIT_SCCP_RLSD, }; static const struct value_string gscon_fsm_event_names[] = { @@ -95,7 +96,8 @@ struct osmo_tdef_state_timeout conn_fsm_timeouts[32] = { [ST_WAIT_CC] = { .T = -3210 }, - [ST_CLEARING] = { .T = -4 }, + [ST_WAIT_CLEAR_CMD] = { .T = -4 }, + [ST_WAIT_SCCP_RLSD] = { .T = -4 }, }; /* Transition to a state, using the T timer defined in conn_fsm_timeouts. @@ -143,44 +145,71 @@ { /* already clearing? */ switch (conn->fi->state) { - case ST_CLEARING: + case ST_WAIT_CLEAR_CMD: + case ST_WAIT_SCCP_RLSD: return; default: break; } conn->clear_cause = cause; - conn_fsm_state_chg(ST_CLEARING); + conn_fsm_state_chg(ST_WAIT_CLEAR_CMD); } -static void gscon_fsm_clearing_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) +static void gscon_fsm_wait_clear_cmd_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) { struct msgb *resp; int rc; struct gsm_subscriber_connection *conn = fi->priv; enum gsm0808_cause cause = conn->clear_cause; - if (conn->rx_clear_command) { - LOGPFSML(conn->fi, LOGL_DEBUG, "Not sending BSSMAP CLEAR REQUEST, already got CLEAR COMMAND from MSC\n"); - return; - } - if (!conn->sccp.msc) { LOGPFSML(fi, LOGL_ERROR, "Unable to deliver BSSMAP Clear Request message, no MSC for this conn\n"); - return; + goto nothing_sent; } LOGPFSML(fi, LOGL_DEBUG, "Tx BSSMAP CLEAR REQUEST(%s) to MSC\n", gsm0808_cause_name(cause)); resp = gsm0808_create_clear_rqst(cause); if (!resp) { LOGPFSML(fi, LOGL_ERROR, "Unable to compose BSSMAP Clear Request message\n"); - return; + goto nothing_sent; } rate_ctr_inc(rate_ctr_group_get_ctr(conn->sccp.msc->msc_ctrs, MSC_CTR_BSSMAP_TX_DT1_CLEAR_RQST)); rc = osmo_bsc_sigtran_send(conn, resp); - if (rc < 0) + if (rc < 0) { LOGPFSML(conn->fi, LOGL_ERROR, "Unable to deliver BSSMAP Clear Request message\n"); + goto nothing_sent; + } + return; + +nothing_sent: + /* Normally, we request a CLEAR from the MSC and terminate as soon as the CLEAR COMMAND has been issued by the + * MSC. But if we are trying to clear without being able to send anything to the MSC, we might as well shut down + * the conn right away now. */ + conn_fsm_state_chg(ST_WAIT_SCCP_RLSD); +} + +void gscon_fsm_wait_sccp_rlsd_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct gsm_subscriber_connection *conn = fi->priv; + + /* According to 3GPP 48.008 3.1.9.1. "The BSS need not wait for the radio channel + * release to be completed or for the guard timer to expire before returning the + * CLEAR COMPLETE message" */ + if (!gscon_sigtran_send(conn, gsm0808_create_clear_complete())) + rate_ctr_inc(rate_ctr_group_get_ctr(conn->sccp.msc->msc_ctrs, MSC_CTR_BSSMAP_TX_DT1_CLEAR_COMPLETE)); + + /* Give the handover_fsm a chance to book this as handover success before tearing down everything, + * making it look like a sudden death failure. */ + if (conn->ho.fi) + osmo_fsm_inst_dispatch(conn->ho.fi, HO_EV_CONN_RELEASING, NULL); + + if (conn->lcs.loc_req) + osmo_fsm_inst_dispatch(conn->lcs.loc_req->fi, LCS_LOC_REQ_EV_CONN_CLEAR, NULL); + + gscon_release_lchans(conn, true, bsc_gsm48_rr_cause_from_gsm0808_cause(conn->clear_cause)); + osmo_mgcpc_ep_clear(conn->user_plane.mgw_endpoint); } /* forward MO DTAP from RSL side to BSSAP side */ @@ -682,13 +711,13 @@ .name = "INIT", .in_event_mask = S(GSCON_EV_MO_COMPL_L3) | S(GSCON_EV_A_CONN_IND) | S(GSCON_EV_HANDOVER_END), - .out_state_mask = S(ST_WAIT_CC) | S(ST_ACTIVE) | S(ST_CLEARING), + .out_state_mask = S(ST_WAIT_CC) | S(ST_ACTIVE) | S(ST_WAIT_CLEAR_CMD) | S(ST_WAIT_SCCP_RLSD), .action = gscon_fsm_init, }, [ST_WAIT_CC] = { .name = "WAIT_CC", .in_event_mask = S(GSCON_EV_A_CONN_CFM), - .out_state_mask = S(ST_ACTIVE) | S(ST_CLEARING), + .out_state_mask = S(ST_ACTIVE) | S(ST_WAIT_CLEAR_CMD) | S(ST_WAIT_SCCP_RLSD), .action = gscon_fsm_wait_cc, }, [ST_ACTIVE] = { @@ -698,27 +727,32 @@ | S(GSCON_EV_LCS_LOC_REQ_END) | S(GSCON_EV_MO_COMPL_L3) , - .out_state_mask = S(ST_CLEARING) | S(ST_ASSIGNMENT) | + .out_state_mask = S(ST_WAIT_CLEAR_CMD) | S(ST_WAIT_SCCP_RLSD) | S(ST_ASSIGNMENT) | S(ST_HANDOVER), .action = gscon_fsm_active, }, [ST_ASSIGNMENT] = { .name = "ASSIGNMENT", .in_event_mask = EV_TRANSPARENT_SCCP | S(GSCON_EV_ASSIGNMENT_END), - .out_state_mask = S(ST_ACTIVE) | S(ST_CLEARING), + .out_state_mask = S(ST_ACTIVE) | S(ST_WAIT_CLEAR_CMD) | S(ST_WAIT_SCCP_RLSD), .action = gscon_fsm_assignment, }, [ST_HANDOVER] = { .name = "HANDOVER", .in_event_mask = EV_TRANSPARENT_SCCP | S(GSCON_EV_HANDOVER_END), - .out_state_mask = S(ST_ACTIVE) | S(ST_CLEARING), + .out_state_mask = S(ST_ACTIVE) | S(ST_WAIT_CLEAR_CMD) | S(ST_WAIT_SCCP_RLSD), .action = gscon_fsm_handover, }, - [ST_CLEARING] = { - .name = "CLEARING", - .onenter = gscon_fsm_clearing_onenter, - /* dead end state */ - }, + [ST_WAIT_CLEAR_CMD] = { + .name = "WAIT_CLEAR_CMD", + .onenter = gscon_fsm_wait_clear_cmd_onenter, + .out_state_mask = S(ST_WAIT_SCCP_RLSD), + }, + [ST_WAIT_SCCP_RLSD] = { + .name = "WAIT_SCCP_RLSD", + .onenter = gscon_fsm_wait_sccp_rlsd_onenter, + .in_event_mask = S(GSCON_EV_HANDOVER_END), + }, }; void gscon_change_primary_lchan(struct gsm_subscriber_connection *conn, struct gsm_lchan *new_lchan) @@ -848,44 +882,19 @@ static void gscon_fsm_allstate(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct gsm_subscriber_connection *conn = fi->priv; - const enum gsm0808_cause *cause_0808; const struct tlv_parsed *tp; struct osmo_mobile_identity mi_imsi; /* Regular allstate event processing */ switch (event) { case GSCON_EV_A_CLEAR_CMD: - conn->rx_clear_command = true; - - /* Give the handover_fsm a chance to book this as handover success before tearing down everything, - * making it look like a sudden death failure. */ - if (conn->ho.fi) - osmo_fsm_inst_dispatch(conn->ho.fi, HO_EV_CONN_RELEASING, NULL); - - if (conn->lcs.loc_req) - osmo_fsm_inst_dispatch(conn->lcs.loc_req->fi, LCS_LOC_REQ_EV_CONN_CLEAR, NULL); - OSMO_ASSERT(data); - cause_0808 = data; - /* MSC tells us to cleanly shut down */ - if (conn->fi->state != ST_CLEARING) - osmo_fsm_inst_state_chg(fi, ST_CLEARING, 60, -4); - LOGPFSML(fi, LOGL_DEBUG, "Releasing all lchans (if any) after BSSMAP Clear Command\n"); - gscon_release_lchans(conn, true, bsc_gsm48_rr_cause_from_gsm0808_cause(*cause_0808)); - /* FIXME: Release all terestrial resources in ST_CLEARING */ - /* According to 3GPP 48.008 3.1.9.1. "The BSS need not wait for the radio channel - * release to be completed or for the guard timer to expire before returning the - * CLEAR COMPLETE message" */ - - /* Close MGCP connections */ - osmo_mgcpc_ep_clear(conn->user_plane.mgw_endpoint); - - rate_ctr_inc(rate_ctr_group_get_ctr(conn->sccp.msc->msc_ctrs, MSC_CTR_BSSMAP_TX_DT1_CLEAR_COMPLETE)); - gscon_sigtran_send(conn, gsm0808_create_clear_complete()); + conn->clear_cause = *(const enum gsm0808_cause*)data; + conn_fsm_state_chg(ST_WAIT_SCCP_RLSD); break; case GSCON_EV_A_DISC_IND: - /* MSC or SIGTRAN network has hard-released SCCP connection, - * terminate the FSM now. */ + /* MSC or SIGTRAN network has hard-released SCCP connection, terminate the FSM now. + * Cleanup is done in gscon_pre_term() and gscon_cleanup(). */ osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, data); break; case GSCON_EV_FORGET_MGW_ENDPOINT: @@ -975,6 +984,13 @@ osmo_mgcpc_ep_clear(conn->user_plane.mgw_endpoint); conn->user_plane.mgw_endpoint = NULL; + conn->user_plane.mgw_endpoint = NULL; + + if (conn->ho.fi) + osmo_fsm_inst_dispatch(conn->ho.fi, HO_EV_CONN_RELEASING, NULL); + + if (conn->lcs.loc_req) + osmo_fsm_inst_dispatch(conn->lcs.loc_req->fi, LCS_LOC_REQ_EV_CONN_CLEAR, NULL); if (conn->lcls.fi) { /* request termination of LCLS FSM */ @@ -1013,8 +1029,9 @@ case -4: /* The MSC has sent a BSSMAP Clear Command, we acknowledged that, but the conn was never * disconnected. */ - LOGPFSML(fi, LOGL_ERROR, "Long after a BSSMAP Clear Command, the conn is still not" - " released. For sanity, discarding this conn now.\n"); + LOGPFSML(fi, LOGL_ERROR, "Long after expecting %s, the conn is still not" + " released. For sanity, discarding this conn now.\n", + fi->state == ST_WAIT_CLEAR_CMD ? "BSSMAP Clear Command" : "SCCP RLSD"); a_reset_conn_fail(conn->sccp.msc); osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); break; diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index 17bc048..dd2f16a 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -1710,3 +1710,7 @@ }; return &ret; } +struct mgcp_client *osmo_mgcpc_ep_client(const struct osmo_mgcpc_ep *ep) +{ + return NULL; +} -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26614 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie975117d37f38ba853589dc7f8d3e94f8f9586b2 Gerrit-Change-Number: 26614 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:16 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:16 +0000 Subject: Change in osmo-bsc[master]: gscon clear: without SCCP conn, no need to wait for RLSD timeout References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26615 ) Change subject: gscon clear: without SCCP conn, no need to wait for RLSD timeout ...................................................................... gscon clear: without SCCP conn, no need to wait for RLSD timeout Skip the BSSMAP Clear and SCCP RLSD parts and immediately deallocate the gscon when there is no SCCP connection present. Before this patch, such conn would stick around for a minute before a timeout deallocates it. Related: OS#5337 Change-Id: I8c8537acf6b47b121903197608636c43ae601a57 --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/15/26615/1 diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index 121b154..b3e7c57 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -210,6 +210,10 @@ gscon_release_lchans(conn, true, bsc_gsm48_rr_cause_from_gsm0808_cause(conn->clear_cause)); osmo_mgcpc_ep_clear(conn->user_plane.mgw_endpoint); + + /* If there is no SCCP connection at all, then no need to wait for an SCCP RLSD. */ + if (!conn->sccp.msc || conn->sccp.state != SUBSCR_SCCP_ST_CONNECTED) + osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, NULL); } /* forward MO DTAP from RSL side to BSSAP side */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8c8537acf6b47b121903197608636c43ae601a57 Gerrit-Change-Number: 26615 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:50 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:50 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: fix ho-out test failures: cleanup neighbor cfg cruft References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26616 ) Change subject: bsc: fix ho-out test failures: cleanup neighbor cfg cruft ...................................................................... bsc: fix ho-out test failures: cleanup neighbor cfg cruft In the out-of-this-BSC handover tests, a neighbor config of LAC 99 left behind from a previous test obstructed the test from working: % BTS 0 already had neighbor LAC:99 ARFCN-BSIC:123-45 % ERROR: duplicate Cell ID in neighbor config, with differing ARFCN+BSIC: LAC:99 ARFCN-BSIC:123-any Add a 'no neighbor lac 99' before configuring the neighbor via VTY. Also add the missing neighbor config to f_tc_srvcc_eutran_to_geran_ho_out_main(). Affects tests: BSC_Tests.TC_ho_out_of_this_bsc BSC_Tests.TC_srvcc_eutran_to_geran_ho_out BSC_Tests.TC_srvcc_eutran_to_geran_ho_out_forbid_fast_return Change-Id: I7a7c97a47a06abb59c0d89638c6b503ab66eb359 --- M bsc/BSC_Tests.ttcn 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/26616/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 0c71581..97aff9e 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -5616,6 +5616,7 @@ "handover 1", "handover algorithm 2", "handover2 window rxlev averaging 1", + "no neighbors", "neighbor lac 99 arfcn 123 bsic any"}); f_vty_transceive(BSCVTY, "drop bts connection 0 oml"); @@ -5687,7 +5688,7 @@ var template PDU_BSSAP exp_compl := f_gen_exp_compl(); f_establish_fully(ass_req, exp_compl); - f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"}); + f_bts_0_cfg(BSCVTY, {"no neighbor lac 99", "neighbor lac 99 arfcn 123 bsic any"}); f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any"); BSSAP.receive(tr_BSSMAP_HandoverRequired); @@ -5731,7 +5732,7 @@ var template PDU_BSSAP exp_compl := f_gen_exp_compl(); f_establish_fully(ass_req, exp_compl); - f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"}); + f_bts_0_cfg(BSCVTY, {"no neighbor lac 99", "neighbor lac 99 arfcn 123 bsic any"}); f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any"); BSSAP.receive(tr_BSSMAP_HandoverRequired); @@ -5813,7 +5814,7 @@ var template PDU_BSSAP exp_compl := f_gen_exp_compl(); f_establish_fully(ass_req, exp_compl); - f_bts_0_cfg(BSCVTY, {"neighbor lac 99 arfcn 123 bsic any"}); + f_bts_0_cfg(BSCVTY, {"no neighbor lac 99", "neighbor lac 99 arfcn 123 bsic any"}); f_vty_transceive(BSCVTY, "handover any to arfcn 123 bsic any"); BSSAP.receive(tr_BSSMAP_HandoverRequired); @@ -6099,6 +6100,16 @@ var MSC_ConnHdlr vc_conn; var TestHdlrParams pars := f_gen_test_hdlr_pars(); + f_init_vty(); + f_bts_0_cfg(BSCVTY, + {"neighbor-list mode automatic", + "handover 1", + "handover algorithm 2", + "handover2 window rxlev averaging 1", + "no neighbors", + "neighbor lac 99 arfcn 123 bsic any"}); + f_vty_transceive(BSCVTY, "drop bts connection 0 oml"); + f_init(1, true); if (disable_fast_return) { f_vty_allow_srvcc_fast_return(true, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26616 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a7c97a47a06abb59c0d89638c6b503ab66eb359 Gerrit-Change-Number: 26616 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:50 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:50 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: make perform_clear() work when VTY is not initialized References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617 ) Change subject: bsc: make perform_clear() work when VTY is not initialized ...................................................................... bsc: make perform_clear() work when VTY is not initialized To be able to invoke perform_clear() also in tests where the VTY isn't used, only invoke the f_logp() when the VTY is ready. Otherwise this causes an error and a failed test, for no good reason. Related: OS#5337 Change-Id: I8116075f32937bd06ba14b426010bf6fec2ef402 --- M bsc/BSC_Tests.ttcn 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/26617/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 97aff9e..b1deaf5 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1064,6 +1064,13 @@ f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg); } +private function f_logp_if_vty_inited(charstring msg) runs on MSC_ConnHdlr +{ + if (g_vty_initialized) { + f_logp(BSCVTY, msg); + } +} + private function f_sysinfo_seen(integer rsl_idx, RSL_Message rsl) runs on test_CT { if (rsl_idx >= lengthof(g_system_information)) { @@ -7771,22 +7778,22 @@ friend function f_perform_clear(RSL_DCHAN_PT rsl_pt := RSL, RSLEM_PROC_PT rsl_proc_pt := RSL_PROC, template PDU_ML3_NW_MS exp_rr_rel_tmpl := tr_RRM_RR_RELEASE) runs on MSC_ConnHdlr { - f_logp(BSCVTY, "MSC instructs BSC to clear channel"); + f_logp_if_vty_inited("MSC instructs BSC to clear channel"); BSSAP.send(ts_BSSMAP_ClearCommand(0)); interleave { [] rsl_pt.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, decmatch exp_rr_rel_tmpl)) { - f_logp(BSCVTY, "Got RSL RR Release"); + f_logp_if_vty_inited("Got RSL RR Release"); } [] rsl_pt.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) { - f_logp(BSCVTY, "Got RSL Deact SACCH"); + f_logp_if_vty_inited("Got RSL Deact SACCH"); } [] BSSAP.receive(tr_BSSMAP_ClearComplete) { - f_logp(BSCVTY, "Got BSSMAP Clear Complete"); + f_logp_if_vty_inited("Got BSSMAP Clear Complete"); /* Also drop the SCCP connection */ BSSAP.send(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ); } [] rsl_pt.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)) { - f_logp(BSCVTY, "Got RSL RF Chan Rel, sending Rel Ack"); + f_logp_if_vty_inited("Got RSL RF Chan Rel, sending Rel Ack"); rsl_pt.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr)); f_rslem_unregister(0, g_chan_nr, PT := rsl_proc_pt); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8116075f32937bd06ba14b426010bf6fec2ef402 Gerrit-Change-Number: 26617 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:51 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:51 +0000 Subject: Change in osmo-ttcn3-hacks[master]: vty: add f_verify_talloc_count() References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618 ) Change subject: vty: add f_verify_talloc_count() ...................................................................... vty: add f_verify_talloc_count() Counts talloc objects via VTY and waits for a specific object count. Useful to test against leaks. The intended use is to check against leakage of bsc_subscr and gsm_subscriber_connection after each BSC_Tests.*, see patch in 'Related' below. Related: OS#5337 Related: I69d4c5c6f8d499bb7f0b96a48af045361433c57b (osmo-ttcn3-hacks) Change-Id: Iafe720a4931270e868f40c4f623d10bb9c14dc80 --- M library/Osmocom_VTY_Functions.ttcn 1 file changed, 63 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/26618/1 diff --git a/library/Osmocom_VTY_Functions.ttcn b/library/Osmocom_VTY_Functions.ttcn index 49f587d..083c70c 100644 --- a/library/Osmocom_VTY_Functions.ttcn +++ b/library/Osmocom_VTY_Functions.ttcn @@ -14,6 +14,7 @@ import from Misc_Helpers all; import from TELNETasp_PortType all; import from Osmocom_Types all; + import from TCCConversion_Functions all; modulepar { charstring mp_prompt_prefix := "OpenBSC"; @@ -226,4 +227,66 @@ return ""; } +function f_strstr_count(in charstring str, in charstring sub_str) return integer +{ + var integer count := 0; + var integer pos := 0; + + while (true) { + var integer at := f_strstr(str, sub_str, pos); + if (at < 0) { + break; + } + count := count + 1; + pos := at + 1; + } + return count; +} + +type record of charstring StrList; + +/* Perform a 'show talloc-context' to get a count of the given object_strs that are still allocated. + * Retry 'attempts' times until the actual talloc object count matches 'expect_count'. + * Useful to ensure that no mem leaks remain after running a test. */ +function f_verify_talloc_count(TELNETasp_PT pt, StrList object_strs, integer expect_count := 0, + integer attempts := 5, float wait_time := 3.0) +{ + var charstring show_cmd := "show talloc-context application full filter " + for (var integer i := 0; i < lengthof(object_strs); i := i + 1) { + var charstring obj_str := object_strs[i]; + /* spaces confuse the VTY command */ + obj_str := f_replaceEveryOccurenceOfSubstring(obj_str, " ", "."); + /* In the regexp, expect word start and word end to bound the obj name */ + obj_str := "\\<" & obj_str & "\\>"; + if (i > 0) { + show_cmd := show_cmd & "\\|"; + } + show_cmd := show_cmd & obj_str; + } + + while (attempts > 0) { + attempts := attempts - 1; + var charstring ret := f_vty_transceive_ret(pt, show_cmd); + + var boolean ok := true; + for (var integer i := 0; i < lengthof(object_strs); i := i + 1) { + var charstring object_str := object_strs[i]; + var integer count := f_strstr_count(ret, object_str); + log("talloc reports ", object_str, " x ", count, ", expecting ", expect_count); + if (count != expect_count) { + ok := false; + } + } + if (ok) { + return; + } + if (attempts == 0) { + break; + } + log("count mismatch, retrying in ", wait_time); + f_sleep(wait_time); + } + setverdict(fail, "talloc count mismatch"); +} + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iafe720a4931270e868f40c4f623d10bb9c14dc80 Gerrit-Change-Number: 26618 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:51 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:51 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: detect subscr and conn leaks during f_shutdown_helper() References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26619 ) Change subject: bsc: detect subscr and conn leaks during f_shutdown_helper() ...................................................................... bsc: detect subscr and conn leaks during f_shutdown_helper() Invoke f_verify_talloc_count() for bsc_subscr and gsm_subscriber_connection, expecting none to remain after each test. This makes numerous tests fail, where the test does not properly release the RSL and BSSAP connections. An upcoming patch fixes all of those cases: I9396efcabc085d2850244c6468b83c5f3a3ff3a2 Related: OS#5337 Change-Id: I69d4c5c6f8d499bb7f0b96a48af045361433c57b --- M bsc/BSC_Tests.ttcn 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/26619/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index b1deaf5..b1e9875 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -855,6 +855,11 @@ friend function f_shutdown_helper() runs on test_CT { + /* Run the subscr and conn leak test only when the VTY is initialized */ + if (BSCVTY.checkstate("Mapped")) { + f_verify_talloc_count(BSCVTY, {"struct bsc_subscr", "struct gsm_subscriber_connection"}); + } + all component.stop; setverdict(pass); mtc.stop; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I69d4c5c6f8d499bb7f0b96a48af045361433c57b Gerrit-Change-Number: 26619 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:52 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:52 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: f_perform_clear: ack all DLCX and RSL REL REQ References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26620 ) Change subject: bsc: f_perform_clear: ack all DLCX and RSL REL REQ ...................................................................... bsc: f_perform_clear: ack all DLCX and RSL REL REQ ACK any MGCP DLCX or RLL REL REQ during f_perform_clear(), which makes it more universally applicable to invoke at the end of a test. Related: OS#5337 Change-Id: Ie5b77c266a5d8f47edd187c474df281a799a81de --- M bsc/BSC_Tests.ttcn 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/26620/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index b1e9875..c9c9103 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -7780,9 +7780,27 @@ } } +private altstep as_mgcp_ack_all_dlcx() runs on MSC_ConnHdlr { + var MgcpCommand mgcp_cmd; + [] MGCP.receive(tr_DLCX(?)) -> value mgcp_cmd { + MGCP.send(ts_DLCX_ACK2(mgcp_cmd.line.trans_id)); + repeat; + } +} + +private altstep as_rsl_ack_all_rel_req() runs on MSC_ConnHdlr { + var RslLinkId main_dcch := valueof(ts_RslLinkID_DCCH(0)); + [] RSL.receive(tr_RSL_REL_REQ(g_chan_nr, ?)) { + RSL.send(ts_RSL_REL_CONF(g_chan_nr, main_dcch)); + repeat; + } +} + friend function f_perform_clear(RSL_DCHAN_PT rsl_pt := RSL, RSLEM_PROC_PT rsl_proc_pt := RSL_PROC, template PDU_ML3_NW_MS exp_rr_rel_tmpl := tr_RRM_RR_RELEASE) runs on MSC_ConnHdlr { + var default ack_dlcx := activate(as_mgcp_ack_all_dlcx()); + var default ack_rel_req := activate(as_rsl_ack_all_rel_req()); f_logp_if_vty_inited("MSC instructs BSC to clear channel"); BSSAP.send(ts_BSSMAP_ClearCommand(0)); interleave { @@ -7803,6 +7821,8 @@ f_rslem_unregister(0, g_chan_nr, PT := rsl_proc_pt); } } + deactivate(ack_dlcx); + deactivate(ack_rel_req); } private function f_perform_compl_l3(RSL_DCHAN_PT rsl_pt, RSLEM_PROC_PT rsl_proc_pt, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie5b77c266a5d8f47edd187c474df281a799a81de Gerrit-Change-Number: 26620 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 13:55:52 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 13:55:52 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: properly clean up conn after each test References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26621 ) Change subject: bsc: properly clean up conn after each test ...................................................................... bsc: properly clean up conn after each test Make all tests clean up BSSAP conn and RSL link. Now all f_verify_talloc_count() in f_shutdown_helper() should pass, verifying no conn or bsc_subscr leaks. Related: OS#5337 Change-Id: I9396efcabc085d2850244c6468b83c5f3a3ff3a2 --- M bsc/BSC_Tests.ttcn 1 file changed, 163 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/26621/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index c9c9103..604c65e 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1622,6 +1622,7 @@ } [] BSSAP.receive { repeat; } } + f_perform_clear_test_ct(dt); f_shutdown_helper(); } @@ -1700,7 +1701,7 @@ /* Run everything required up to sending a caller-specified assignment command and expect response */ function f_assignment_exp(PDU_BSSAP ass_cmd, template PDU_BSSAP exp, charstring fail_text) -runs on test_CT { +runs on test_CT return DchanTuple { var BSSAP_N_CONNECT_ind rx_c_ind; var RSL_Message rx_rsl; var DchanTuple dt; @@ -1727,13 +1728,15 @@ } [] BSSAP.receive { repeat; } } + return dt; } testcase TC_assignment_csd() runs on test_CT { var template PDU_BSSAP exp_fail := tr_BSSMAP_AssignmentFail; var PDU_BSSAP ass_cmd := f_gen_ass_req(); ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelTypeCSD); //exp_fail.pdu.bssmap.assignmentFailure.cause.causeValue := int2bit(enum2int(GSM0808_CAUSE_REQ_CODEC_TYPE_OR_CONFIG_UNAVAIL), 7); - f_assignment_exp(ass_cmd, exp_fail, "BSC accepted Assignment for CSD"); + var DchanTuple dt := f_assignment_exp(ass_cmd, exp_fail, "BSC accepted Assignment for CSD"); + f_perform_clear_test_ct(dt); f_shutdown_helper(); } @@ -1742,7 +1745,8 @@ var PDU_BSSAP ass_cmd := f_gen_ass_req(); ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelTypeCTM); //exp_fail.pdu.bssmap.assignmentFailure.cause.causeValue := int2bit(enum2int(GSM0808_CAUSE_REQ_CODEC_TYPE_OR_CONFIG_UNAVAIL), 7); - f_assignment_exp(ass_cmd, exp_fail, "BSC accepted Assignment for Speech+CTM"); + var DchanTuple dt := f_assignment_exp(ass_cmd, exp_fail, "BSC accepted Assignment for Speech+CTM"); + f_perform_clear_test_ct(dt); f_shutdown_helper(); } @@ -1972,6 +1976,8 @@ {name := "TTCN3.bts.0.chan.rf_fail_sdcch", mtype := "c", min := 1, max := 1} }; f_statsd_expect(expect); + BSSAP.receive(tr_BSSMAP_ClearRequest); + f_perform_clear(); } testcase TC_stats_conn_fail() runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); @@ -2434,6 +2440,7 @@ /* Send MT message: BSSAP -> RSL */ f_mt_l3_transceive(RSL, link_id, dlci, l3); } + f_perform_clear(); } testcase TC_tch_dlci_link_id_sapi() runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); @@ -3545,8 +3552,10 @@ /* Expevct a CR with a matching Paging response on the A-Interface */ T.start; alt { - [] BSSAP.receive(tr_BSSAP_CONNECT_ind(?, ?, tr_BSSMAP_ComplL3(rr_pag_resp))) { + [] BSSAP.receive(tr_BSSAP_CONNECT_ind(?, ?, tr_BSSMAP_ComplL3(rr_pag_resp))) -> value rx_c_ind { setverdict(pass); + dt.sccp_conn_id := rx_c_ind.connectionId; + BSSAP.send(ts_BSSAP_CONNECT_res(dt.sccp_conn_id)); } [] BSSAP.receive { setverdict(fail, "Received unexpected message on A-Interface!"); @@ -3556,6 +3565,7 @@ } } + f_perform_clear_test_ct(dt); f_shutdown_helper(); } @@ -3727,6 +3737,7 @@ exp_compl.pdu.bssmap.assignmentComplete.aoIPTransportLayer := omit; f_establish_fully(ass_cmd, exp_compl); + f_perform_clear(); } testcase TC_ciph_mode_a5_0() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -3815,6 +3826,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); f_establish_fully(ass_cmd, exp_compl); + f_perform_clear(); } testcase TC_assignment_aoip_tla_v6() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -3837,6 +3849,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); f_establish_fully(ass_cmd, exp_compl); + f_perform_clear(); } testcase TC_assignment_fr_a5_0() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -3910,6 +3923,7 @@ /* Omit: ass_cmd.pdu.bssmap.assignmentRequest.codecList */ f_establish_fully(ass_cmd, exp_fail); + f_perform_clear(); } testcase TC_assignment_fr_a5_1_codec_missing() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -3941,6 +3955,7 @@ /* Start ciphering, expect Cipher Mode Reject */ f_cipher_mode(g_pars.encr, exp_fail := true); + f_perform_clear(); } testcase TC_assignment_fr_a5_not_sup() runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); @@ -3972,6 +3987,7 @@ { name := "TTCN3.bsc.0.assignment.completed", mtype := "c", min := 1, max := 1} }; f_statsd_expect(expect); + f_perform_clear(); } testcase TC_assignment_sign() runs on test_CT { @@ -4114,6 +4130,10 @@ type record of CodecListTest CodecListTests private function f_TC_assignment_codec(charstring id) runs on MSC_ConnHdlr { + f_assignment_codec(id); +} + +private function f_assignment_codec(charstring id, boolean do_perform_clear := true) runs on MSC_ConnHdlr { var PDU_BSSAP ass_cmd := f_gen_ass_req(g_pars.use_osmux); var template PDU_BSSAP exp_compl := f_gen_exp_compl(g_pars.use_osmux); @@ -4168,6 +4188,10 @@ } } } + + if (do_perform_clear) { + f_perform_clear(); + } } private function f_TC_assignment_codec_fail(charstring id) runs on MSC_ConnHdlr { @@ -4184,6 +4208,7 @@ log("expecting ASS FAIL like this: ", exp_fail); f_establish_fully(ass_cmd, exp_fail); + f_perform_clear(); } const CounterNameVals counternames_bsc_bts_assignment := { @@ -4697,6 +4722,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.channelType.speechId_DataIndicator := '05'O; ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR})); f_establish_fully(ass_cmd, exp_compl); + f_perform_clear(); } /* Allow FR only */ @@ -4709,6 +4735,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.channelType.speechId_DataIndicator := '01'O; ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); f_establish_fully(ass_cmd, exp_compl); + f_perform_clear(); } /* Allow HR only (expect assignment failure) */ @@ -4721,6 +4748,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.channelType.speechId_DataIndicator := '05'O; ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR})); f_establish_fully(ass_cmd, exp_fail); + f_perform_clear(); } /* Allow FR only (expect assignment failure) */ @@ -4733,6 +4761,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.channelType.speechId_DataIndicator := '01'O; ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); f_establish_fully(ass_cmd, exp_fail); + f_perform_clear(); } /* Allow FR and HR, but prefer FR */ @@ -4746,6 +4775,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR, ts_CodecHR})); exp_compl.pdu.bssmap.assignmentComplete.speechVersion.speechVersionIdentifier := '0000101'B; /* Expect HR */ f_establish_fully(ass_cmd, exp_compl); + f_perform_clear(); } /* Allow FR and HR, but prefer HR */ @@ -4759,6 +4789,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR, ts_CodecFR})); exp_compl.pdu.bssmap.assignmentComplete.speechVersion.speechVersionIdentifier := '0000101'B; /* Expect HR */ f_establish_fully(ass_cmd, exp_compl); + f_perform_clear(); } /* Allow FR and HR, but prefer FR */ @@ -4772,6 +4803,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR, ts_CodecHR})); exp_compl.pdu.bssmap.assignmentComplete.speechVersion.speechVersionIdentifier := '0000001'B; /* Expect FR */ f_establish_fully(ass_cmd, exp_compl); + f_perform_clear(); } /* Allow FR and HR, but prefer HR */ @@ -4785,6 +4817,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR, ts_CodecFR})); exp_compl.pdu.bssmap.assignmentComplete.speechVersion.speechVersionIdentifier := '0000001'B; /* Expect FR */ f_establish_fully(ass_cmd, exp_compl); + f_perform_clear(); } /* Request a HR channel while all FR channels are exhausted, this is expected @@ -4910,6 +4943,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR, ts_CodecFR})); exp_compl.pdu.bssmap.assignmentComplete.speechVersion.speechVersionIdentifier := '0000101'B; /* Expect HR */ f_establish_fully(ass_cmd, exp_compl); + f_perform_clear(); } /* Allow FR and HR, but prefer FR */ @@ -4923,6 +4957,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR, ts_CodecHR})); exp_compl.pdu.bssmap.assignmentComplete.speechVersion.speechVersionIdentifier := '0000001'B; /* Expect FR */ f_establish_fully(ass_cmd, exp_compl); + f_perform_clear(); } /* Request a HR (prefered) or alternatively a FR channel, it is expected that @@ -4973,6 +5008,8 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for COMPLETE LAYER 3 INFORMATION"); } } + + f_perform_clear(); } testcase TC_assignment_sdcch_exhausted_req_signalling() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -5035,6 +5072,7 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for COMPLETE LAYER 3 INFORMATION"); } } + f_perform_clear(); } testcase TC_assignment_sdcch_exhausted_req_voice_tch_forbidden() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -5095,6 +5133,8 @@ f_rsl_send_l3(ts_RRM_CM_CHG(valueof(ts_CM2))); BSSAP.receive(tr_BSSMAP_ClassmarkUpd(?, omit)); setverdict(pass); + + f_perform_clear(); } testcase TC_classmark() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -5122,6 +5162,8 @@ f_vty_transceive_match_regexp_retry(BSCVTY, "show conns", regex, 0, 4, 1.0); setverdict(pass); + + f_perform_clear(); } testcase TC_common_id() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -5160,6 +5202,7 @@ private function f_tc_unsol_ass_fail(charstring id) runs on MSC_ConnHdlr { f_est_single_l3(ts_RRM_AssignmentFailure('00'O)); f_bssap_expect_nothing(); + f_perform_clear(); } testcase TC_unsol_ass_fail() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -5175,6 +5218,7 @@ private function f_tc_unsol_ass_compl(charstring id) runs on MSC_ConnHdlr { f_est_single_l3(ts_RRM_AssignmentComplete('00'O)); f_bssap_expect_nothing(); + f_perform_clear(); } testcase TC_unsol_ass_compl() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -5190,6 +5234,7 @@ private function f_tc_unsol_ho_fail(charstring id) runs on MSC_ConnHdlr { f_est_single_l3(ts_RRM_HandoverFailure('00'O)); f_bssap_expect_nothing(); + f_perform_clear(); } testcase TC_unsol_ho_fail() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -5210,6 +5255,7 @@ /* send short message */ RSL.send(ts_RSL_DATA_IND(g_chan_nr, valueof(ts_RslLinkID_DCCH(0)), ''O)); f_bssap_expect_nothing(); + f_perform_clear(); } testcase TC_err_82_short_msg() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -5232,6 +5278,7 @@ [] BSSAP.receive { setverdict(fail, "unexpected BSSAP"); } [] T.timeout { setverdict(fail, "Timeout waiting for RR STATUS"); } } + f_perform_clear(); } testcase TC_err_84_unknown_msg() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -5338,6 +5385,8 @@ f_chan_act_verify_tsc(chan_act, BTS_TSC[1]); + f_perform_clear(RSL1, RSL1_PROC); + f_sleep(0.5); } @@ -5488,7 +5537,9 @@ RSL1.send(ts_RSL_RF_CHAN_REL_ACK(new_chan_nr)); f_rslem_unregister(0, g_chan_nr, PT := RSL1_PROC); } - [] BSSAP.receive(tr_BSSMAP_ClearComplete) {} + [] BSSAP.receive(tr_BSSMAP_ClearComplete) { + BSSAP.send(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ); + } } f_sleep(0.5); @@ -5604,7 +5655,9 @@ [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, decmatch tr_RRM_RR_RELEASE)); [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)); [] RSL.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)); - [] BSSAP.receive(tr_BSSMAP_ClearComplete); + [] BSSAP.receive(tr_BSSMAP_ClearComplete) { + BSSAP.send(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ); + } } setverdict(pass); } @@ -5711,6 +5764,7 @@ f_mo_l3_transceive(); f_sleep(1.0); + f_perform_clear(); } testcase TC_ho_out_fail_no_msc_response() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -5792,6 +5846,7 @@ setverdict(pass); f_sleep(1.0); + f_perform_clear(); } testcase TC_ho_out_fail_rr_ho_failure() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -5889,6 +5944,7 @@ f_expect_dlcx_conns(); BSSAP.receive(tr_BSSMAP_ClearComplete); + BSSAP.send(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ); setverdict(pass); f_sleep(1.0); @@ -6222,6 +6278,7 @@ f_expect_dlcx_conns(); BSSAP.receive(tr_BSSMAP_ClearComplete); + BSSAP.send(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ); setverdict(pass); f_sleep(1.0); @@ -6315,6 +6372,7 @@ f_expect_dlcx_conns(); BSSAP.receive(tr_BSSMAP_ClearComplete); + BSSAP.send(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ); f_sleep(1.0); } @@ -6404,6 +6462,7 @@ f_expect_dlcx_conns(); BSSAP.receive(tr_BSSMAP_ClearComplete); + BSSAP.send(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ); f_sleep(1.0); } @@ -6485,6 +6544,7 @@ }; f_expect_dlcx_conns(); BSSAP.receive(tr_BSSMAP_ClearComplete); + BSSAP.send(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_REQ); f_sleep(1.0); } @@ -6700,6 +6760,8 @@ f_probe_for_handover("1.d", "HO to 871-11 still works (verify that this test properly cleans up)", "handover any to arfcn 871 bsic 11", true, expect_target_tsc := BTS_TSC[1]); + + f_perform_clear(); } testcase TC_ho_neighbor_config_1() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -6764,6 +6826,7 @@ f_probe_for_handover("2.b", "HO to bts 2 doesn't work, not listed as neighbor", "handover any to arfcn 871 bsic 12", false); + f_perform_clear(); } testcase TC_ho_neighbor_config_2() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -6815,6 +6878,7 @@ f_probe_for_handover("3.b", "HO to bts 2 works, explicitly listed as neighbor; no ambiguity because bts 3 is not listed as neighbor", "handover any to arfcn 871 bsic 12", true, expect_target_tsc := BTS_TSC[2]); + f_perform_clear(); } testcase TC_ho_neighbor_config_3() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -6869,6 +6933,7 @@ f_probe_for_handover("4.c", "HO to 123-45 triggers inter-BSC HO", "handover any to arfcn 123 bsic 45", true, true); + f_perform_clear(); } testcase TC_ho_neighbor_config_4() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -6919,6 +6984,7 @@ f_probe_for_handover("5.a", "HO to 871-12 triggers inter-BSC HO (ignoring local cells with same ARFCN+BSIC)", "handover any to arfcn 871 bsic 12", true, true); + f_perform_clear(); } testcase TC_ho_neighbor_config_5() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -6962,6 +7028,7 @@ f_probe_for_handover("6.a", "HO to 871-12 is ambiguous = error", "handover any to arfcn 871 bsic 12", false); + f_perform_clear(); } testcase TC_ho_neighbor_config_6() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -7006,6 +7073,7 @@ f_probe_for_handover("7.b", "HO to 123-45 triggers inter-BSC HO", "handover any to arfcn 123 bsic 45", true, true); + f_perform_clear(); } testcase TC_ho_neighbor_config_7() runs on test_CT { var MSC_ConnHdlr vc_conn; @@ -7467,9 +7535,11 @@ /* Fill TS0 SDCCH channels (NOTE: only 3 SDCCH/4 channels are available * on CCCH+SDCCH4+CBCH) */ + var DchanTuples sdcch_cleanup := {}; var integer i; for (i := 0; i < NUM_SDCCH_PER_BTS; i := i + 1) { dt := f_est_dchan('23'O, i, '00010203040506'O); + sdcch_cleanup := sdcch_cleanup & { dt }; } /* Now the dyn ts is selected. First PDCH is released, then sdcch chan is activated */ @@ -7501,6 +7571,11 @@ f_sleep(1.0); f_ts_dyn_mode_assert(0, 0, pdch_chan_nr.tn, PDCH_MODE); + /* Clean up SDCCH lchans */ + for (i := 0; i < lengthof(sdcch_cleanup); i := i + 1) { + f_perform_clear_test_ct(sdcch_cleanup[i]); + } + /* clean up config */ f_ts_set_chcomb(0, 0, 6, "PDCH"); @@ -7523,7 +7598,7 @@ } f_vty_transceive(BSCVTY, "drop bts connection 0 oml"); - f_init(1); + f_init(1, guard_timeout := 60.0); /* The dyn TS want to activate PDCH mode, ACK that. */ var RslChannelNr chan_nr; @@ -7537,15 +7612,21 @@ /* GSM 44.018 Table 9.1.8.2: * RA = '13'O -> Establishment cause = 0001xxxx (MS dual rate capable and asks for "SDCCH"). */ + var DchanTuples chan_cleanup := {}; for (i := 0; i < NUM_SDCCH_PER_BTS; i := i+1) { - f_est_dchan('13'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O); + chan_cleanup := chan_cleanup & { f_est_dchan('13'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O) }; } /* Only the dyn TS is still available. Its first lchan gets converted to SDCCH8 */ - f_est_dchan_dyn('33'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O); + chan_cleanup := chan_cleanup & { f_est_dchan_dyn('33'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O) }; /* Also occupy the seven other SDCCH of the dyn TS */ for (i := 0; i < 7; i := i+1) { - f_est_dchan('33'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O); + chan_cleanup := chan_cleanup & { f_est_dchan('33'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O) }; + } + + /* Clean up SDCCH lchans */ + for (i := 0; i < lengthof(chan_cleanup); i := i + 1) { + f_perform_clear_test_ct(chan_cleanup[i]); } /* clean up config */ @@ -7591,9 +7672,11 @@ /* Fill TS0 SDCCH channels (NOTE: only 3 SDCCH/4 channels are available * on CCCH+SDCCH4+CBCH) */ + var DchanTuples chan_cleanup := {}; var OCT1 ra := '43'O; /* RA containing reason=originating speech call*/ for (i := 0; i < NUM_SDCCH_PER_BTS; i := i + 1) { dt := f_est_dchan(ra, i, '00010203040506'O); + chan_cleanup := chan_cleanup & { dt }; } /* Now the dyn ts is selected. First PDCH is released, then TCH chan is activated */ @@ -7625,6 +7708,11 @@ f_sleep(1.0); f_ts_dyn_mode_assert(0, 0, pdch_chan_nr.tn, PDCH_MODE); + /* Clean up SDCCH lchans */ + for (i := 0; i < lengthof(chan_cleanup); i := i + 1) { + f_perform_clear_test_ct(chan_cleanup[i]); + } + /* clean up config */ f_ts_reset_chcomb(0); /* TODO: clean up other channels? */ @@ -7661,9 +7749,11 @@ /* Fill TS0 SDCCH channels (NOTE: only 3 SDCCH/4 channels are available * on CCCH+SDCCH4+CBCH) */ + var DchanTuples chan_cleanup := {}; var integer i; for (i := 0; i < NUM_SDCCH_PER_BTS; i := i + 1) { dt := f_est_dchan('23'O, i, '00010203040506'O); + chan_cleanup := chan_cleanup & { dt }; } /* Now the dyn ts is selected. First PDCH is released, then sdcch chan is activated */ @@ -7691,6 +7781,11 @@ * f_ts_dyn_mode_assert(0, 0, pdch_chan_nr.tn, PDCH_MODE) */ + /* Clean up SDCCH lchans */ + for (i := 0; i < lengthof(chan_cleanup); i := i + 1) { + f_perform_clear_test_ct(chan_cleanup[i]); + } + /* clean up config */ f_ts_set_chcomb(0, 0, 6, "PDCH"); @@ -7825,6 +7920,15 @@ deactivate(ack_rel_req); } +private function f_perform_clear_test_ct(DchanTuple dt) + runs on test_CT +{ + /* Instruct BSC to clear channel */ + var BssmapCause cause := 0; + BSSAP.send(ts_BSSAP_DATA_req(dt.sccp_conn_id, ts_BSSMAP_ClearCommand(cause))); + f_exp_chan_rel_and_clear(dt, 0); +} + private function f_perform_compl_l3(RSL_DCHAN_PT rsl_pt, RSLEM_PROC_PT rsl_proc_pt, template PDU_ML3_MS_NW l3_info, boolean do_clear := true, boolean expect_bssmap_l3 := true) runs on MSC_ConnHdlr { @@ -8567,6 +8671,7 @@ } setverdict(pass); + f_perform_clear(); } /* Test if the EMERGENCY SETUP gets blocked by the BSC if EMERGENCY CALLS are @@ -8589,6 +8694,8 @@ setverdict(fail, "timout waiting for RR CHANNEL RELEASE!"); } } + BSSAP.receive(tr_BSSMAP_ClearRequest); + f_perform_clear(); } /* EMERGENCY CALL situation #1, allowed globally and by BTS */ @@ -9076,6 +9183,8 @@ setverdict(fail, "FH disabled, but Mobile Allocation IE is present"); continue; } + + f_perform_clear_test_ct(dt); } /* Give the IUT some time to release all channels */ @@ -9147,6 +9256,8 @@ setverdict(fail, "FH enabled, but Mobile Allocation IE is absent"); return; } + + f_perform_clear_test_ct(dt); } testcase TC_fh_params_handover_cmd() runs on test_CT { var FHParamsTrx fhp := f_TC_fh_params_gen(); @@ -9888,6 +9999,8 @@ } } T.stop; + + f_perform_clear(); } /* The BSC does *not* indicate BTS_FEAT_VAMOS; make sure that a channel Mode Modify to VAMOS mode is refused by @@ -9937,7 +10050,7 @@ private function f_TC_reassignment_codec(charstring id) runs on MSC_ConnHdlr { /* First fully set up a speech lchan */ - f_TC_assignment_codec(id); + f_assignment_codec(id, do_perform_clear := false); /* Trigger re-assignment to another lchan */ var AssignmentState assignment_st := valueof(ts_AssignmentStateInit); @@ -10235,6 +10348,8 @@ /* First send the Chan Act ACK */ var RslChannelNr chan_nr := chan_act.ies[0].body.chan_nr; + var DchanTuple dt; + dt.rsl_chan_nr := chan_nr; var RSL_IE_Body chan_ident_ie; if (not f_rsl_find_ie(chan_act, RSL_IE_CHAN_IDENT, chan_ident_ie)) { setverdict(fail, "RSL Channel Identification IE is absent"); @@ -10255,9 +10370,11 @@ var BSSAP_N_CONNECT_ind rx_c_ind; BSSAP.receive(tr_BSSAP_CONNECT_ind(?, ?, tr_BSSMAP_ComplL3(l3))) -> value rx_c_ind; + dt.sccp_conn_id := rx_c_ind.connectionId; BSSAP.send(ts_BSSAP_CONNECT_res(rx_c_ind.connectionId)); f_sleep(1.0); + f_perform_clear_test_ct(dt); f_shutdown_helper(); } @@ -10280,6 +10397,8 @@ chan_act := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_CHAN_ACTIV)); var RslChannelNr chan_nr := chan_act.ies[0].body.chan_nr; + var DchanTuple dt; + dt.rsl_chan_nr := chan_nr; var RSL_IE_Body chan_ident_ie; if (not f_rsl_find_ie(chan_act, RSL_IE_CHAN_IDENT, chan_ident_ie)) { setverdict(fail, "RSL Channel Identification IE is absent"); @@ -10300,9 +10419,11 @@ var BSSAP_N_CONNECT_ind rx_c_ind; BSSAP.receive(tr_BSSAP_CONNECT_ind(?, ?, tr_BSSMAP_ComplL3(l3))) -> value rx_c_ind; + dt.sccp_conn_id := rx_c_ind.connectionId; BSSAP.send(ts_BSSAP_CONNECT_res(rx_c_ind.connectionId)); f_sleep(1.0); + f_perform_clear_test_ct(dt); f_shutdown_helper(); } @@ -10325,6 +10446,8 @@ chan_act := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_CHAN_ACTIV)); var RslChannelNr chan_nr := chan_act.ies[0].body.chan_nr; + var DchanTuple dt; + dt.rsl_chan_nr := chan_nr; var RSL_IE_Body chan_ident_ie; if (not f_rsl_find_ie(chan_act, RSL_IE_CHAN_IDENT, chan_ident_ie)) { setverdict(fail, "RSL Channel Identification IE is absent"); @@ -10345,9 +10468,11 @@ var BSSAP_N_CONNECT_ind rx_c_ind; BSSAP.receive(tr_BSSAP_CONNECT_ind(?, ?, tr_BSSMAP_ComplL3(l3))) -> value rx_c_ind; + dt.sccp_conn_id := rx_c_ind.connectionId; BSSAP.send(ts_BSSAP_CONNECT_res(rx_c_ind.connectionId)); f_sleep(1.0); + f_perform_clear_test_ct(dt); f_shutdown_helper(); } @@ -10395,6 +10520,8 @@ /* Now activation as SDCCH8 */ chan_nr := valueof(t_RslChanNr_SDCCH8(tn := 6, sub_slot := 0)); + var DchanTuple dt; + dt.rsl_chan_nr := chan_nr; chan_act := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_CHAN_ACTIV)); var RSL_IE_Body chan_ident_ie; @@ -10417,9 +10544,11 @@ var BSSAP_N_CONNECT_ind rx_c_ind; BSSAP.receive(tr_BSSAP_CONNECT_ind(?, ?, tr_BSSMAP_ComplL3(l3))) -> value rx_c_ind; + dt.sccp_conn_id := rx_c_ind.connectionId; BSSAP.send(ts_BSSAP_CONNECT_res(rx_c_ind.connectionId)); f_sleep(1.0); + f_perform_clear_test_ct(dt); f_shutdown_helper(); } @@ -10472,6 +10601,8 @@ /* Now activation as SDCCH8 */ chan_nr := valueof(t_RslChanNr_SDCCH8(tn := 6, sub_slot := 0)); + var DchanTuple dt; + dt.rsl_chan_nr := chan_nr; chan_act := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_CHAN_ACTIV)); var RSL_IE_Body chan_ident_ie; @@ -10490,9 +10621,11 @@ var BSSAP_N_CONNECT_ind rx_c_ind; BSSAP.receive(tr_BSSAP_CONNECT_ind(?, ?, tr_BSSMAP_ComplL3(l3))) -> value rx_c_ind; + dt.sccp_conn_id := rx_c_ind.connectionId; BSSAP.send(ts_BSSAP_CONNECT_res(rx_c_ind.connectionId)); f_sleep(1.0); + f_perform_clear_test_ct(dt); f_shutdown_helper(); } @@ -10596,6 +10729,8 @@ f_create_chan_and_exp(); /* we should now have a COMPL_L3 at the MSC */ BSSAP.send(ts_PDU_DTAP_MT(ts_CM_SERV_REJ('02'O), '00'O)); + RSL.receive(tr_RSL_DATA_REQ(g_chan_nr, ?, decmatch tr_CM_SERV_REJ)); + f_perform_clear(); f_sleep(1.0); } testcase TC_cm_serv_rej() runs on test_CT { @@ -10722,15 +10857,16 @@ var integer i; var integer chreq_total, chreq_nochan; - f_init(1); + f_init(1, guard_timeout := 60.0); f_sleep(1.0); /* Exhaust all dedicated SDCCH lchans. /* GSM 44.018 Table 9.1.8.2: * RA = '13'O -> Establishment cause = 0001xxxx (MS dual rate capable and asks for "SDCCH"). */ + var DchanTuples chan_cleanup := {}; for (i := 0; i < NUM_SDCCH_PER_BTS; i := i+1) { - f_est_dchan('13'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O); + chan_cleanup := chan_cleanup & { f_est_dchan('13'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O) }; } /* Since only bts 0 is connected, expecting all_allocated to become true for both bts 0 and the "global" bsc @@ -10740,13 +10876,18 @@ /* Also fill up all remaining (TCH) channels */ for (i := 0; i < NUM_TCHF_PER_BTS + NUM_TCHH_PER_BTS; i := i+1) { - f_est_dchan('33'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O); + chan_cleanup := chan_cleanup & { f_est_dchan('33'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O) }; } /* All TCH are now also occupied */ f_all_allocated_expect_counter_change({"all_allocated:sdcch", "all_allocated:static_sdcch", "all_allocated:tch", "all_allocated:static_tch"}); + /* Clean up SDCCH lchans */ + for (i := 0; i < lengthof(chan_cleanup); i := i + 1) { + f_perform_clear_test_ct(chan_cleanup[i]); + } + f_shutdown_helper(); } @@ -10773,8 +10914,9 @@ /* GSM 44.018 Table 9.1.8.2: * RA = '13'O -> Establishment cause = 0001xxxx (MS dual rate capable and asks for "SDCCH"). */ + var DchanTuples chan_cleanup := {}; for (i := 0; i < NUM_SDCCH_PER_BTS; i := i+1) { - f_est_dchan('13'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O); + chan_cleanup := chan_cleanup & { f_est_dchan('13'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O) }; } /* The static SDCCH should now be occupied, while still 3x8 dynamic SDCCH potentially remain. So only @@ -10796,7 +10938,7 @@ /* occupy the remaining TCH, three TCH/F and two TCH/H lchans */ for (i := 0; i < 5; i := i+1) { - f_est_dchan('33'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O); + chan_cleanup := chan_cleanup & { f_est_dchan('33'O, NUM_SDCCH_PER_BTS + i, '00010203040506'O) }; } /* All TCH lchans are now also occupied, both static and dynamic */ @@ -10830,6 +10972,11 @@ /* Now all channels are occupied except the dyn TS, so expecting only the static counters to increment */ f_all_allocated_expect_counter_change({"all_allocated:static_sdcch", "all_allocated:static_tch"}); + /* Clean up SDCCH lchans */ + for (i := 0; i < lengthof(chan_cleanup); i := i + 1) { + f_perform_clear_test_ct(chan_cleanup[i]); + } + /* clean up config */ f_ts_reset_chcomb(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26621 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9396efcabc085d2850244c6468b83c5f3a3ff3a2 Gerrit-Change-Number: 26621 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 14:42:33 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 17 Dec 2021 14:42:33 +0000 Subject: Change in osmo-hnodeb[master]: Fix several Coverity found issues In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 ) Change subject: Fix several Coverity found issues ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595/1/src/osmo-hnodeb/gtp.c File src/osmo-hnodeb/gtp.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595/1/src/osmo-hnodeb/gtp.c at 193 PS1, Line 193: LOGUE(ue > Sorry, wrong comment location. See above. Fixed in a follow up commit, detected by coverity too. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I6d73a970919889953539fbacc601d679d7ec4113 Gerrit-Change-Number: 26595 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 14:42:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 15:21:59 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 15:21:59 +0000 Subject: Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop: add timeout for talloc report In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26601 ) Change subject: ttcn3-tcpdump-stop: add timeout for talloc report ...................................................................... ttcn3-tcpdump-stop: add timeout for talloc report Prevent the script from idling for several minutes without any output if obtaining the talloc report does not work. It seems to get killed eventually, but trying for 5s should be enough. Change-Id: I1bc5baeb94ecd25e1cdab98b060b99747c19d1f9 --- M ttcn3-tcpdump-stop.sh 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index 4fbc53f..faf5b2b 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -35,10 +35,15 @@ # Order the SUT to print a talloc report if [ "z$OSMO_SUT_HOST" != "z" ] && [ "z$OSMO_SUT_PORT" != "z" ]; then if [ -x "$(command -v osmo_interact_vty.py)" ]; then - osmo_interact_vty.py \ + echo "Saving talloc report from $OSMO_SUT_HOST:$OSMO_SUT_PORT to $TESTCASE.talloc" + if ! timeout 5 osmo_interact_vty.py \ -H $OSMO_SUT_HOST -p $OSMO_SUT_PORT \ -c "en; show talloc-context application full" \ - > "$TTCN3_PCAP_PATH/$TESTCASE.talloc" + > "$TTCN3_PCAP_PATH/$TESTCASE.talloc"; then + echo + echo "ERROR: failed to get talloc report via vty" + echo + fi else echo "Missing osmo_interact_vty.py from osmo-python-tests!" echo " -> Unable to obtain talloc report from the SUT" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26601 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1bc5baeb94ecd25e1cdab98b060b99747c19d1f9 Gerrit-Change-Number: 26601 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 15:22:11 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 15:22:11 +0000 Subject: Change in docker-playground[master]: scripts/kernel-test/run-qemu.sh: update qemu args In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26599 ) Change subject: scripts/kernel-test/run-qemu.sh: update qemu args ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4a00f90980bf6d141ef8d86786e08d405db6db0b Gerrit-Change-Number: 26599 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 15:22:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 15:22:16 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 15:22:16 +0000 Subject: Change in docker-playground[master]: osmo-ggsn-*: install iproute2 for kernel tests In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26600 ) Change subject: osmo-ggsn-*: install iproute2 for kernel tests ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26600 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I95560868a899169bf0cb05a02d5034d9a77b6af7 Gerrit-Change-Number: 26600 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 15:22:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 15:22:20 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 15:22:20 +0000 Subject: Change in docker-playground[master]: scripts/kernel-test/run-qemu.sh: update qemu args In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26599 ) Change subject: scripts/kernel-test/run-qemu.sh: update qemu args ...................................................................... scripts/kernel-test/run-qemu.sh: update qemu args Get rid of -nodefconfig, it has been removed in qemu 3.1. We are supposed to use -no-user-config instead, which we already do. Fix for this error we see since migrating to debian-bullseye: qemu-system-x86_64: -nodefconfig: invalid option Related: OS#4969 Related: https://qemu.readthedocs.io/en/stable/about/removed-features.html#nodefconfig-removed-in-3-1 Change-Id: I4a00f90980bf6d141ef8d86786e08d405db6db0b --- M scripts/kernel-test/run-qemu.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/scripts/kernel-test/run-qemu.sh b/scripts/kernel-test/run-qemu.sh index 1873af4..9951e94 100755 --- a/scripts/kernel-test/run-qemu.sh +++ b/scripts/kernel-test/run-qemu.sh @@ -23,7 +23,7 @@ $MACHINE_ARG \ -smp 1 \ -m 512M \ - -nodefconfig -no-user-config -nodefaults -display none \ + -no-user-config -nodefaults -display none \ -gdb unix:/cache/kernel-test/gdb.pipe,server,nowait \ -no-reboot \ -kernel /cache/kernel-test/linux \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4a00f90980bf6d141ef8d86786e08d405db6db0b Gerrit-Change-Number: 26599 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 15:22:20 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 15:22:20 +0000 Subject: Change in docker-playground[master]: osmo-ggsn-*: install iproute2 for kernel tests In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26600 ) Change subject: osmo-ggsn-*: install iproute2 for kernel tests ...................................................................... osmo-ggsn-*: install iproute2 for kernel tests Add the package providing "ip", as debian bullseye doesn't have it installed by default anymore. Fix for: /kernel-test/qemu-ifup.sh: 9: ip: not found Related: OS#4969 Change-Id: I95560868a899169bf0cb05a02d5034d9a77b6af7 --- M osmo-ggsn-latest/Dockerfile M osmo-ggsn-master/Dockerfile 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/osmo-ggsn-latest/Dockerfile b/osmo-ggsn-latest/Dockerfile index e5408e3..87b0a9e 100644 --- a/osmo-ggsn-latest/Dockerfile +++ b/osmo-ggsn-latest/Dockerfile @@ -20,6 +20,7 @@ flex \ gcc \ git \ + iproute2 \ libc6-dev \ libelf-dev \ libssl-dev \ diff --git a/osmo-ggsn-master/Dockerfile b/osmo-ggsn-master/Dockerfile index c3afb68..1a4504b 100644 --- a/osmo-ggsn-master/Dockerfile +++ b/osmo-ggsn-master/Dockerfile @@ -14,6 +14,7 @@ bridge-utils \ busybox-static \ ca-certificates \ + iproute2 \ libelf-dev \ libgtpnl-dev \ libosmocore-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26600 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I95560868a899169bf0cb05a02d5034d9a77b6af7 Gerrit-Change-Number: 26600 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 16:06:53 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 16:06:53 +0000 Subject: Change in osmo-hnodeb[master]: llsk_gtp: Early return if conn alloc fails In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26602 ) Change subject: llsk_gtp: Early return if conn alloc fails ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26602/1/src/osmo-hnodeb/llsk_gtp.c File src/osmo-hnodeb/llsk_gtp.c: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26602/1/src/osmo-hnodeb/llsk_gtp.c at 173 PS1, Line 173: return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); For consistency with the other returns, maybe also log a message? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Iaf597b76ceb9cce3f27c42625f963f740c8f213e Gerrit-Change-Number: 26602 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 17 Dec 2021 16:06:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 16:07:23 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 16:07:23 +0000 Subject: Change in osmo-hnodeb[master]: llsk_audio: Fix false positive about uninitialized var access In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26603 ) Change subject: llsk_audio: Fix false positive about uninitialized var access ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If085b0ca0e1d3e7237696eb67cf6301ea84793e0 Gerrit-Change-Number: 26603 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 17 Dec 2021 16:07:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 16:09:02 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 16:09:02 +0000 Subject: Change in osmo-hnodeb[master]: gtp: Fix possible null pointer dereference In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26605 ) Change subject: gtp: Fix possible null pointer dereference ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I412082cc5fa93818d321210c34a2d22c038cb985 Gerrit-Change-Number: 26605 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 17 Dec 2021 16:09:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 16:09:34 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 16:09:34 +0000 Subject: Change in osmo-hnodeb[master]: contrib/osmo-hnodeb.spec.in: Fix missing dep libosmotrau In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26604 ) Change subject: contrib/osmo-hnodeb.spec.in: Fix missing dep libosmotrau ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ia40b6a28caecdd94ce3c53172fe531b12a0a221f Gerrit-Change-Number: 26604 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 17 Dec 2021 16:09:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:08:40 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:08:40 +0000 Subject: Change in osmo-hnodeb[master]: llsk_gtp: Early return if conn alloc fails In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26602 ) Change subject: llsk_gtp: Early return if conn alloc fails ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Iaf597b76ceb9cce3f27c42625f963f740c8f213e Gerrit-Change-Number: 26602 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 17 Dec 2021 17:08:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:08:50 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:08:50 +0000 Subject: Change in osmo-hnodeb[master]: llsk_audio: Fix false positive about uninitialized var access In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26603 ) Change subject: llsk_audio: Fix false positive about uninitialized var access ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If085b0ca0e1d3e7237696eb67cf6301ea84793e0 Gerrit-Change-Number: 26603 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 17 Dec 2021 17:08:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:09:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:09:04 +0000 Subject: Change in osmo-hnodeb[master]: gtp: Fix possible null pointer dereference In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26605 ) Change subject: gtp: Fix possible null pointer dereference ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I412082cc5fa93818d321210c34a2d22c038cb985 Gerrit-Change-Number: 26605 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 17 Dec 2021 17:09:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:09:06 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:09:06 +0000 Subject: Change in osmo-hnodeb[master]: llsk_gtp: Early return if conn alloc fails In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26602 ) Change subject: llsk_gtp: Early return if conn alloc fails ...................................................................... llsk_gtp: Early return if conn alloc fails Change-Id: Iaf597b76ceb9cce3f27c42625f963f740c8f213e --- M src/osmo-hnodeb/llsk_gtp.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-hnodeb/llsk_gtp.c b/src/osmo-hnodeb/llsk_gtp.c index 30451a0..a224d56 100644 --- a/src/osmo-hnodeb/llsk_gtp.c +++ b/src/osmo-hnodeb/llsk_gtp.c @@ -169,6 +169,9 @@ /* Create the socket: */ conn = gtp_conn_alloc(ue); + if (!conn) + return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); + if ((rc = gtp_conn_setup(conn, &rem_osa, ce_req->remote_tei)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: Failed to set up gtp socket rem_tei=%u rem_addr=%s\n", ce_req->remote_tei, rem_addrstr); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Iaf597b76ceb9cce3f27c42625f963f740c8f213e Gerrit-Change-Number: 26602 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:09:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:09:07 +0000 Subject: Change in osmo-hnodeb[master]: llsk_audio: Fix false positive about uninitialized var access In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26603 ) Change subject: llsk_audio: Fix false positive about uninitialized var access ...................................................................... llsk_audio: Fix false positive about uninitialized var access Let's make gcc in Ubuntu 21.10 happy. Change-Id: If085b0ca0e1d3e7237696eb67cf6301ea84793e0 --- M src/osmo-hnodeb/llsk_audio.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/osmo-hnodeb/llsk_audio.c b/src/osmo-hnodeb/llsk_audio.c index 7ce5c09..a600c3c 100644 --- a/src/osmo-hnodeb/llsk_audio.c +++ b/src/osmo-hnodeb/llsk_audio.c @@ -152,7 +152,7 @@ char rem_addrstr[INET6_ADDRSTRLEN+32]; struct osmo_sockaddr rem_osa = {0}; union u_addr loc_uaddr = {0}; - uint16_t loc_port; + uint16_t loc_port = 0; struct rtp_conn *conn = NULL; rc = ll_addr2osa(ce_req->remote_rtp_address_type, &ce_req->remote_rtp_addr, ce_req->remote_rtp_port, &rem_osa); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: If085b0ca0e1d3e7237696eb67cf6301ea84793e0 Gerrit-Change-Number: 26603 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:09:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:09:07 +0000 Subject: Change in osmo-hnodeb[master]: contrib/osmo-hnodeb.spec.in: Fix missing dep libosmotrau In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26604 ) Change subject: contrib/osmo-hnodeb.spec.in: Fix missing dep libosmotrau ...................................................................... contrib/osmo-hnodeb.spec.in: Fix missing dep libosmotrau Change-Id: Ia40b6a28caecdd94ce3c53172fe531b12a0a221f --- M contrib/osmo-hnodeb.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/contrib/osmo-hnodeb.spec.in b/contrib/osmo-hnodeb.spec.in index fef34af..afa1816 100644 --- a/contrib/osmo-hnodeb.spec.in +++ b/contrib/osmo-hnodeb.spec.in @@ -36,6 +36,7 @@ BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmotrau) >= 1.2.0 BuildRequires: pkgconfig(libosmocore) >= 1.6.0 BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 BuildRequires: pkgconfig(libosmogb) >= 1.6.0 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ia40b6a28caecdd94ce3c53172fe531b12a0a221f Gerrit-Change-Number: 26604 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:09:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:09:07 +0000 Subject: Change in osmo-hnodeb[master]: gtp: Fix possible null pointer dereference In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26605 ) Change subject: gtp: Fix possible null pointer dereference ...................................................................... gtp: Fix possible null pointer dereference Closes: Coverity CID#242771 Change-Id: I412082cc5fa93818d321210c34a2d22c038cb985 --- M src/osmo-hnodeb/gtp.c 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c index 22d4074..f7d9a14 100644 --- a/src/osmo-hnodeb/gtp.c +++ b/src/osmo-hnodeb/gtp.c @@ -79,12 +79,18 @@ struct hnb *hnb; int rc; - if (!conn || !conn->ue->conn_ps.active) { - LOGUE(conn->ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", - packet, len); + if (!conn) { + LOGP(DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u with no conn!\n", + packet, len); return -EINVAL; } ue = conn->ue; + + if (!ue->conn_ps.active) { + LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", + packet, len); + return -EINVAL; + } hnb = ue->hnb; LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I412082cc5fa93818d321210c34a2d22c038cb985 Gerrit-Change-Number: 26605 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:10:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:10:17 +0000 Subject: Change in libosmocore[master]: PFCP: add DLPFCP and osmo-upf port numbers In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26606 ) Change subject: PFCP: add DLPFCP and osmo-upf port numbers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0a46b147ec6a76d909df28136cfd2b764b2c75ea Gerrit-Change-Number: 26606 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 17 Dec 2021 17:10:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:10:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:10:28 +0000 Subject: Change in libosmocore[master]: ports.h: add osmo-pfcp-tool In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26607 ) Change subject: ports.h: add osmo-pfcp-tool ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8a5f437d934b9bda11ea593b50bd18c7d5d71ce9 Gerrit-Change-Number: 26607 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 17:10:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:10:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:10:58 +0000 Subject: Change in libosmocore[master]: add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26608 ) Change subject: add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I12771bf8a021e6785217b1faad03c09ec1cfef0e Gerrit-Change-Number: 26608 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Fri, 17 Dec 2021 17:10:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:11:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:11:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: fix ho-out test failures: cleanup neighbor cfg cruft In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26616 ) Change subject: bsc: fix ho-out test failures: cleanup neighbor cfg cruft ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26616 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a7c97a47a06abb59c0d89638c6b503ab66eb359 Gerrit-Change-Number: 26616 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 17:11:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:11:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:11:51 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: make perform_clear() work when VTY is not initialized In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617 ) Change subject: bsc: make perform_clear() work when VTY is not initialized ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8116075f32937bd06ba14b426010bf6fec2ef402 Gerrit-Change-Number: 26617 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 17:11:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:12:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:12:19 +0000 Subject: Change in osmo-ttcn3-hacks[master]: vty: add f_verify_talloc_count() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618 ) Change subject: vty: add f_verify_talloc_count() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iafe720a4931270e868f40c4f623d10bb9c14dc80 Gerrit-Change-Number: 26618 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 17:12:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:12:48 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:12:48 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: detect subscr and conn leaks during f_shutdown_helper() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26619 ) Change subject: bsc: detect subscr and conn leaks during f_shutdown_helper() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I69d4c5c6f8d499bb7f0b96a48af045361433c57b Gerrit-Change-Number: 26619 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 17:12:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:13:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:13:04 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: f_perform_clear: ack all DLCX and RSL REL REQ In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26620 ) Change subject: bsc: f_perform_clear: ack all DLCX and RSL REL REQ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie5b77c266a5d8f47edd187c474df281a799a81de Gerrit-Change-Number: 26620 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 17:13:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:13:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:13:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: properly clean up conn after each test In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26621 ) Change subject: bsc: properly clean up conn after each test ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26621 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9396efcabc085d2850244c6468b83c5f3a3ff3a2 Gerrit-Change-Number: 26621 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Fri, 17 Dec 2021 17:13:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:13:47 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:13:47 +0000 Subject: Change in osmo-bsc[master]: log: always include timeouts in FSM transition logging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26609 ) Change subject: log: always include timeouts in FSM transition logging ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I94b7dc4d9e5e45dc731bcb3a843ede9fb6cc0839 Gerrit-Change-Number: 26609 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 17:13:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:14:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:14:00 +0000 Subject: Change in osmo-bsc[master]: lchan/gscon: always clear both cross ref pointers In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26610 ) Change subject: lchan/gscon: always clear both cross ref pointers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idbfe4672233ba8105eff5ba77ee07fd871358255 Gerrit-Change-Number: 26610 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 17:14:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:14:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:14:15 +0000 Subject: Change in osmo-bsc[master]: lcs: fix bsc_subscr use_count leak In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26611 ) Change subject: lcs: fix bsc_subscr use_count leak ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibbfbfe766eafe42c78048ec5b3b503a11ef5535d Gerrit-Change-Number: 26611 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 17:14:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:14:37 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:14:37 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 1/n: store clear cause in gscon In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26612 ) Change subject: fix gscon clear 1/n: store clear cause in gscon ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib6432746040899129d1d73ae8dc59add2d88a915 Gerrit-Change-Number: 26612 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 17:14:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:16:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:16:44 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 11 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 17 Dec 2021 17:16:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 17:17:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 17 Dec 2021 17:17:36 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 11: Code-Review-1 we still have the multithread topic to resolve -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 11 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 17 Dec 2021 17:17:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 18:50:53 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 18:50:53 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: import References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26622 ) Change subject: contrib/obs-mirror: import ...................................................................... contrib/obs-mirror: import Import scripts from OS#4862 to have them properly versioned. We use this to replicate Osmocom related packages from OBS to: https://download.osmocom.org/obs-mirror Put it in contrib/, because it doesn't need to get installed to the jenkins nodes (as it would happen with everything in scripts/). Related: OS#4862 Change-Id: I3f47cddbcee6c9b85fde77a039dcd5b54dd89f2d --- A contrib/obs-mirror/README A contrib/obs-mirror/obs-mirror-include.txt A contrib/obs-mirror/obs-mirror.sh A contrib/obs-mirror/rm-old-nightly-archives.sh A contrib/obs-mirror/test-include-list.sh 5 files changed, 99 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/22/26622/1 diff --git a/contrib/obs-mirror/README b/contrib/obs-mirror/README new file mode 100644 index 0000000..4cab14b --- /dev/null +++ b/contrib/obs-mirror/README @@ -0,0 +1,7 @@ +The scripts in this directory are used to create an archive of Osmocom related +packages from OBS, at: https://downloads.osmocom.org/obs-mirror/ + +There is no mechanism in place to deploy updated scripts after updating them +here in osmo-ci.git, so this must be done manually. + +See OS#4862 for more information. diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt new file mode 100644 index 0000000..037ce3f --- /dev/null +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -0,0 +1,9 @@ +latest/CentOS_8 +latest/Debian_10 +latest/Raspbian_10 +latest/xUbuntu_21.04 + +nightly/CentOS_8 +nightly/Debian_10 +nightly/Raspbian_10 +nightly/xUbuntu_21.04 diff --git a/contrib/obs-mirror/obs-mirror.sh b/contrib/obs-mirror/obs-mirror.sh new file mode 100755 index 0000000..76317c4 --- /dev/null +++ b/contrib/obs-mirror/obs-mirror.sh @@ -0,0 +1,40 @@ +#!/bin/bash + +# Mirror script to create a local archive of the OBS packages in the network:osmocom +# repositories / projects +# +# We are using hard-links to perform de-duplication on the local side; only +# those files that changed compoared to the previous run will be rsync'ed over +# from the remote side +# +# See also: OS#4862 + +set -e -x + +# base directory on the local side +BASE_DIR="/downloads/obs-mirror/" +# sync remote where to find the osmocom packages +REMOTE="rsync.opensuse.org::opensuse-full-really-everything-including-repositories/opensuse/repositories/network:/osmocom:" + +cd "$BASE_DIR" + +RSYNC_ARGS="-av --delete" +RSYNC_ARGS="$RSYNC_ARGS --files-from /home/pkgmirror/obs-mirror-include.txt --recursive" +DATE=`date +%Y%m%d-%H%M%S` + +# create output directory +DIR="$BASE_DIR/$DATE" +mkdir -p "$DIR" + +PREVIOUS="$BASE_DIR/.previous" +if [ -d "$PREVIOUS" ]; then + RSYNC_ARGS+=" --link-dest=$PREVIOUS" +fi + +# finally, perform rsync +# || true: don't stop here if one of the dirs from the include list does not exist +rsync $RSYNC_ARGS "$REMOTE"/ "$DIR"/ || true + +# update '.previous' for the next run +rm -f "$PREVIOUS" +ln -sf "$DATE" "$PREVIOUS" diff --git a/contrib/obs-mirror/rm-old-nightly-archives.sh b/contrib/obs-mirror/rm-old-nightly-archives.sh new file mode 100755 index 0000000..3a5f276 --- /dev/null +++ b/contrib/obs-mirror/rm-old-nightly-archives.sh @@ -0,0 +1,31 @@ +#!/bin/sh -e +# Remove nightly archives older than one month (OS#4862) +DRY=0 + +# Get removal date in seconds since epoch and display it +DATE_RM_SEC=$(expr $(date +%s) - 3600 \* 24 \* 32) +DATE_RM_STR=$(date -d "@$DATE_RM_SEC" +"%Y-%m-%d") +echo "Removing nightly archives from $DATE_RM_STR and older" + +cd /downloads/obs-mirror + +for i in */nightly; do + # "Last modified" isn't set to the date of the dir name for some + # archives, so parse the date from the dir name instead + DATE_DIR="$(basename "$(dirname "$i")")" # e.g. "20210604-002301" + DATE_DIR_SEC="$(date -d "$(echo "$DATE_DIR" | cut -d "-" -f 1)" +%s)" + if [ -z "$DATE_DIR_SEC" ]; then + echo "ERROR: $i: failed to parse date from dir name" + continue + fi + + if [ "$DATE_DIR_SEC" -lt "$DATE_RM_SEC" ]; then + DATE_DIR_STR="$(date -d "@$DATE_DIR_SEC" +"%Y-%m-%d")" + echo "Removing $i ($DATE_DIR_STR)..." + if [ "$DRY" = 0 ]; then + rm -r "$i" + fi + fi +done + +echo "Done" diff --git a/contrib/obs-mirror/test-include-list.sh b/contrib/obs-mirror/test-include-list.sh new file mode 100755 index 0000000..6766403 --- /dev/null +++ b/contrib/obs-mirror/test-include-list.sh @@ -0,0 +1,12 @@ +#!/bin/sh -ex +BASE_DIR="/downloads/obs-mirror/" + +cd "$BASE_DIR" + +rsync \ + -a \ + --list-only \ + --files-from /home/pkgmirror/obs-mirror-include.txt \ + --recursive \ + "$(realpath .previous)"/ \ + new-backup-dir/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3f47cddbcee6c9b85fde77a039dcd5b54dd89f2d Gerrit-Change-Number: 26622 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 18:50:53 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 18:50:53 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: adjust includelist path References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26623 ) Change subject: contrib/obs-mirror: adjust includelist path ...................................................................... contrib/obs-mirror: adjust includelist path Point at obs-mirror-include.txt from this git repository. Related: OS#4862 Change-Id: I4c6a6e424fd727de4e8058c916aa7eb43e7eb4b2 --- M contrib/obs-mirror/obs-mirror.sh M contrib/obs-mirror/test-include-list.sh 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/23/26623/1 diff --git a/contrib/obs-mirror/obs-mirror.sh b/contrib/obs-mirror/obs-mirror.sh index 76317c4..8d25c2d 100755 --- a/contrib/obs-mirror/obs-mirror.sh +++ b/contrib/obs-mirror/obs-mirror.sh @@ -10,6 +10,7 @@ # See also: OS#4862 set -e -x +SCRIPT_DIR="$(realpath "$(dirname "$(realpath "$0")")")" # base directory on the local side BASE_DIR="/downloads/obs-mirror/" @@ -19,7 +20,7 @@ cd "$BASE_DIR" RSYNC_ARGS="-av --delete" -RSYNC_ARGS="$RSYNC_ARGS --files-from /home/pkgmirror/obs-mirror-include.txt --recursive" +RSYNC_ARGS="$RSYNC_ARGS --files-from $SCRIPT_DIR/obs-mirror-include.txt --recursive" DATE=`date +%Y%m%d-%H%M%S` # create output directory diff --git a/contrib/obs-mirror/test-include-list.sh b/contrib/obs-mirror/test-include-list.sh index 6766403..829e8f7 100755 --- a/contrib/obs-mirror/test-include-list.sh +++ b/contrib/obs-mirror/test-include-list.sh @@ -1,4 +1,5 @@ #!/bin/sh -ex +SCRIPT_DIR="$(realpath "$(dirname "$(realpath "$0")")")" BASE_DIR="/downloads/obs-mirror/" cd "$BASE_DIR" @@ -6,7 +7,7 @@ rsync \ -a \ --list-only \ - --files-from /home/pkgmirror/obs-mirror-include.txt \ + --files-from "$SCRIPT_DIR"/obs-mirror-include.txt \ --recursive \ "$(realpath .previous)"/ \ new-backup-dir/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4c6a6e424fd727de4e8058c916aa7eb43e7eb4b2 Gerrit-Change-Number: 26623 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 18:50:54 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 18:50:54 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: stop script on rsync error References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26624 ) Change subject: contrib/obs-mirror: stop script on rsync error ...................................................................... contrib/obs-mirror: stop script on rsync error Sync files into a temporary directory first, and only rename the temp dir to the final dir name if rsync succeeds. Otherwise, exit with error. Related: SYS#5764 Change-Id: Icfefd8e4bae1fd6c73445c7427aaa842c0391b2d --- M contrib/obs-mirror/obs-mirror.sh 1 file changed, 12 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/24/26624/1 diff --git a/contrib/obs-mirror/obs-mirror.sh b/contrib/obs-mirror/obs-mirror.sh index 8d25c2d..6ac3484 100755 --- a/contrib/obs-mirror/obs-mirror.sh +++ b/contrib/obs-mirror/obs-mirror.sh @@ -22,10 +22,11 @@ RSYNC_ARGS="-av --delete" RSYNC_ARGS="$RSYNC_ARGS --files-from $SCRIPT_DIR/obs-mirror-include.txt --recursive" DATE=`date +%Y%m%d-%H%M%S` - -# create output directory DIR="$BASE_DIR/$DATE" -mkdir -p "$DIR" +TEMP_DIR="$BASE_DIR/.temp" + +rm -rf "$TEMP_DIR" +mkdir "$TEMP_DIR" PREVIOUS="$BASE_DIR/.previous" if [ -d "$PREVIOUS" ]; then @@ -33,9 +34,12 @@ fi # finally, perform rsync -# || true: don't stop here if one of the dirs from the include list does not exist -rsync $RSYNC_ARGS "$REMOTE"/ "$DIR"/ || true +if rsync $RSYNC_ARGS "$REMOTE"/ "$TEMP_DIR"/; then + mv "$TEMP_DIR" "$DIR" -# update '.previous' for the next run -rm -f "$PREVIOUS" -ln -sf "$DATE" "$PREVIOUS" + # update '.previous' for the next run + rm -f "$PREVIOUS" + ln -sf "$DATE" "$PREVIOUS" +else + exit 1 +fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icfefd8e4bae1fd6c73445c7427aaa842c0391b2d Gerrit-Change-Number: 26624 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 18:50:55 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 18:50:55 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: redirect all output to a log file References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26625 ) Change subject: contrib/obs-mirror: redirect all output to a log file ...................................................................... contrib/obs-mirror: redirect all output to a log file Related: SYS#5764 Change-Id: Ie56c901877a3b0a1ad566cb243ab698f292407d5 --- M contrib/obs-mirror/obs-mirror.sh M contrib/obs-mirror/rm-old-nightly-archives.sh 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/25/26625/1 diff --git a/contrib/obs-mirror/obs-mirror.sh b/contrib/obs-mirror/obs-mirror.sh index 6ac3484..529aea1 100755 --- a/contrib/obs-mirror/obs-mirror.sh +++ b/contrib/obs-mirror/obs-mirror.sh @@ -9,6 +9,9 @@ # # See also: OS#4862 +echo "Redirecting all output to: /home/pkgmirror/obs-mirror.log" +exec >"/home/pkgmirror/obs-mirror.log" 2>&1 + set -e -x SCRIPT_DIR="$(realpath "$(dirname "$(realpath "$0")")")" diff --git a/contrib/obs-mirror/rm-old-nightly-archives.sh b/contrib/obs-mirror/rm-old-nightly-archives.sh index 3a5f276..e28bce1 100755 --- a/contrib/obs-mirror/rm-old-nightly-archives.sh +++ b/contrib/obs-mirror/rm-old-nightly-archives.sh @@ -1,5 +1,8 @@ #!/bin/sh -e # Remove nightly archives older than one month (OS#4862) +echo "Redirecting all output to: /home/pkgmirror/rm-old-nightly-archives.log" +exec >"/home/pkgmirror/rm-old-nightly-archives.log" 2>&1 + DRY=0 # Get removal date in seconds since epoch and display it -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie56c901877a3b0a1ad566cb243ab698f292407d5 Gerrit-Change-Number: 26625 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 18:50:55 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 17 Dec 2021 18:50:55 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: log DRY var in rm script References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26626 ) Change subject: contrib/obs-mirror: log DRY var in rm script ...................................................................... contrib/obs-mirror: log DRY var in rm script Related: SYS#5764 Change-Id: I705e52030d538e6d86c72f2bccb0eb97e6dab1de --- M contrib/obs-mirror/rm-old-nightly-archives.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/26/26626/1 diff --git a/contrib/obs-mirror/rm-old-nightly-archives.sh b/contrib/obs-mirror/rm-old-nightly-archives.sh index e28bce1..485bf01 100755 --- a/contrib/obs-mirror/rm-old-nightly-archives.sh +++ b/contrib/obs-mirror/rm-old-nightly-archives.sh @@ -8,7 +8,7 @@ # Get removal date in seconds since epoch and display it DATE_RM_SEC=$(expr $(date +%s) - 3600 \* 24 \* 32) DATE_RM_STR=$(date -d "@$DATE_RM_SEC" +"%Y-%m-%d") -echo "Removing nightly archives from $DATE_RM_STR and older" +echo "Removing nightly archives from $DATE_RM_STR and older (DRY=$DRY)" cd /downloads/obs-mirror -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I705e52030d538e6d86c72f2bccb0eb97e6dab1de Gerrit-Change-Number: 26626 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 19:22:39 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 19:22:39 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 2/n: proper state transition to ST_CLEARING In-Reply-To: References: Message-ID: Hello Jenkins Builder, ipse, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26613 to look at the new patch set (#2). Change subject: fix gscon clear 2/n: proper state transition to ST_CLEARING ...................................................................... fix gscon clear 2/n: proper state transition to ST_CLEARING The way the ST_CLEARING is entered before this patch has various symptoms of how I / we used osmo_fsm when we were still FSM amateurs in Osmocom. Patch that up: - In gscon_bssmap_clear(), ask for a state transition to ST_CLEARING first. Go ahead only if it is allowed. - move the Clear Request messaging to ST_CLEARING's onenter function. - Fix the timeout behavior: by using conn_fsm_state_chg(), use the actual proper X4 timer value for ST_CLEARING from VTY configuration instead of hardcoded magic numbers. Related: OS#5337 Change-Id: I234b2a754d0c98031056981823cdbc187e977741 --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 20 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/13/26613/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I234b2a754d0c98031056981823cdbc187e977741 Gerrit-Change-Number: 26613 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 19:22:39 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 19:22:39 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 3/n: separate state for SCCP RLSD In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26614 to look at the new patch set (#2). Change subject: fix gscon clear 3/n: separate state for SCCP RLSD ...................................................................... fix gscon clear 3/n: separate state for SCCP RLSD Properly implement the separate conn release stages in separate FSM states: x) sent Clear Request, wait for a Clear Command from the MSC. Timeout after a configurable 60s. y) after a Clear Command and sending a Clear Complete, wait for the SCCP RLSD. Timeout after a configurable 60s. z) terminate after the RLSD is received / after timeout. handover_test.c needs a little tweak to make the MGCP release work with its fake MGCP client, because cleanup now ensures to invoke gscon_forget_mgw_endpoint() in all cases. Related: I680ec4ed866aa5f0b1ff29e7e98322615cfb288d (osmo-ttcn3-hacks) Related: OS#5337 Change-Id: Ie975117d37f38ba853589dc7f8d3e94f8f9586b2 --- M src/osmo-bsc/bsc_subscr_conn_fsm.c M tests/handover/handover_test.c 2 files changed, 75 insertions(+), 54 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/14/26614/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26614 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie975117d37f38ba853589dc7f8d3e94f8f9586b2 Gerrit-Change-Number: 26614 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 19:22:39 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Fri, 17 Dec 2021 19:22:39 +0000 Subject: Change in osmo-bsc[master]: gscon clear: without SCCP conn, no need to wait for RLSD timeout In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/26615 to look at the new patch set (#2). Change subject: gscon clear: without SCCP conn, no need to wait for RLSD timeout ...................................................................... gscon clear: without SCCP conn, no need to wait for RLSD timeout Skip the BSSMAP Clear and SCCP RLSD parts and immediately deallocate the gscon when there is no SCCP connection present. Before this patch, such conn would stick around for a minute before a timeout deallocates it. Related: OS#5337 Change-Id: I8c8537acf6b47b121903197608636c43ae601a57 --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/15/26615/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8c8537acf6b47b121903197608636c43ae601a57 Gerrit-Change-Number: 26615 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 21:35:57 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 21:35:57 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Set proper CRC Header for ACK Initialization In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26598 ) Change subject: mgcp_network.c: Set proper CRC Header for ACK Initialization ...................................................................... Patch Set 1: The commit message does not explain what's wrong and why the 3-rd octet must be 0x09... -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f Gerrit-Change-Number: 26598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Fri, 17 Dec 2021 21:35:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 21:36:27 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 21:36:27 +0000 Subject: Change in osmo-bsc[master]: log: always include timeouts in FSM transition logging In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26609 ) Change subject: log: always include timeouts in FSM transition logging ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I94b7dc4d9e5e45dc731bcb3a843ede9fb6cc0839 Gerrit-Change-Number: 26609 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 21:36:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 21:36:35 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 21:36:35 +0000 Subject: Change in osmo-bsc[master]: lchan/gscon: always clear both cross ref pointers In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26610 ) Change subject: lchan/gscon: always clear both cross ref pointers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idbfe4672233ba8105eff5ba77ee07fd871358255 Gerrit-Change-Number: 26610 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 21:36:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 21:37:05 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 21:37:05 +0000 Subject: Change in osmo-bsc[master]: lcs: fix bsc_subscr use_count leak In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26611 ) Change subject: lcs: fix bsc_subscr use_count leak ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibbfbfe766eafe42c78048ec5b3b503a11ef5535d Gerrit-Change-Number: 26611 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 21:37:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 21:41:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 21:41:47 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 1/n: store clear cause in gscon In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26612 ) Change subject: fix gscon clear 1/n: store clear cause in gscon ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib6432746040899129d1d73ae8dc59add2d88a915 Gerrit-Change-Number: 26612 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 21:41:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 22:08:07 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 22:08:07 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 2/n: proper state transition to ST_CLEARING In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26613 ) Change subject: fix gscon clear 2/n: proper state transition to ST_CLEARING ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26613/2/src/osmo-bsc/bsc_subscr_conn_fsm.c File src/osmo-bsc/bsc_subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26613/2/src/osmo-bsc/bsc_subscr_conn_fsm.c at 145 PS2, Line 145: switch (conn->fi->state) { Using an 'if' statement here would make it more readable, given that you have only one 'case'. Perhaps you're planning to add more 'case's here? Not critical though. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I234b2a754d0c98031056981823cdbc187e977741 Gerrit-Change-Number: 26613 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 22:08:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 22:11:33 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 22:11:33 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 2/n: proper state transition to ST_CLEARING In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26613 ) Change subject: fix gscon clear 2/n: proper state transition to ST_CLEARING ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26613/2/src/osmo-bsc/bsc_subscr_conn_fsm.c File src/osmo-bsc/bsc_subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26613/2/src/osmo-bsc/bsc_subscr_conn_fsm.c at 145 PS2, Line 145: switch (conn->fi->state) { > Using an 'if' statement here would make it more readable, given that you have only one 'case'. [?] Indeed, I see you're adding more cases in the next patch. Nevermind. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I234b2a754d0c98031056981823cdbc187e977741 Gerrit-Change-Number: 26613 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 22:11:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 22:14:41 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 22:14:41 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 3/n: separate state for SCCP RLSD In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26614 ) Change subject: fix gscon clear 3/n: separate state for SCCP RLSD ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26614 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie975117d37f38ba853589dc7f8d3e94f8f9586b2 Gerrit-Change-Number: 26614 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 17 Dec 2021 22:14:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 22:15:01 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 22:15:01 +0000 Subject: Change in osmo-bsc[master]: gscon clear: without SCCP conn, no need to wait for RLSD timeout In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26615 ) Change subject: gscon clear: without SCCP conn, no need to wait for RLSD timeout ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8c8537acf6b47b121903197608636c43ae601a57 Gerrit-Change-Number: 26615 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 17 Dec 2021 22:15:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 22:18:51 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 22:18:51 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: fix ho-out test failures: cleanup neighbor cfg cruft In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26616 ) Change subject: bsc: fix ho-out test failures: cleanup neighbor cfg cruft ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26616 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a7c97a47a06abb59c0d89638c6b503ab66eb359 Gerrit-Change-Number: 26616 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 17 Dec 2021 22:18:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 17 22:21:03 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 17 Dec 2021 22:21:03 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: make perform_clear() work when VTY is not initialized In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617 ) Change subject: bsc: make perform_clear() work when VTY is not initialized ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617/1/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617/1/bsc/BSC_Tests.ttcn at 1069 PS1, Line 1069: if (g_vty_initialized) { Can we simply have this check in f_logp()? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8116075f32937bd06ba14b426010bf6fec2ef402 Gerrit-Change-Number: 26617 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 17 Dec 2021 22:21:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 18 00:10:06 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 18 Dec 2021 00:10:06 +0000 Subject: Change in osmo-ttcn3-hacks[master]: vty: add f_verify_talloc_count() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618 ) Change subject: vty: add f_verify_talloc_count() ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618/1/library/Osmocom_VTY_Functions.ttcn File library/Osmocom_VTY_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618/1/library/Osmocom_VTY_Functions.ttcn at 246 PS1, Line 246: type record of charstring StrList; I would make it 'private'. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618/1/library/Osmocom_VTY_Functions.ttcn at 252 PS1, Line 252: integer attempts := 5, float wait_time := 3.0) This line needs to be aligned. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618/1/library/Osmocom_VTY_Functions.ttcn at 254 PS1, Line 254: " No semicolon? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iafe720a4931270e868f40c4f623d10bb9c14dc80 Gerrit-Change-Number: 26618 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Sat, 18 Dec 2021 00:10:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 18 00:12:58 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 18 Dec 2021 00:12:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: detect subscr and conn leaks during f_shutdown_helper() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26619 ) Change subject: bsc: detect subscr and conn leaks during f_shutdown_helper() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I69d4c5c6f8d499bb7f0b96a48af045361433c57b Gerrit-Change-Number: 26619 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 18 Dec 2021 00:12:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 18 00:15:20 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 18 Dec 2021 00:15:20 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: f_perform_clear: ack all DLCX and RSL REL REQ In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26620 ) Change subject: bsc: f_perform_clear: ack all DLCX and RSL REL REQ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie5b77c266a5d8f47edd187c474df281a799a81de Gerrit-Change-Number: 26620 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 18 Dec 2021 00:15:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 18 13:00:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 18 Dec 2021 13:00:47 +0000 Subject: Change in osmo-dev[master]: Add tmux scripts for ttcn3-{msc, bsc, bts}-test In-Reply-To: References: Message-ID: Hello osmith, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 to look at the new patch set (#4). Change subject: Add tmux scripts for ttcn3-{msc,bsc,bts}-test ...................................................................... Add tmux scripts for ttcn3-{msc,bsc,bts}-test Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 --- M README A ttcn3/tmux/ttcn3-bsc-test.sh A ttcn3/tmux/ttcn3-bts-test.sh A ttcn3/tmux/ttcn3-msc-test.sh 4 files changed, 132 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/85/26485/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 Gerrit-Change-Number: 26485 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 18 13:04:43 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 18 Dec 2021 13:04:43 +0000 Subject: Change in osmo-dev[master]: Add tmux scripts for ttcn3-{msc, bsc, bts}-test In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26485 ) Change subject: Add tmux scripts for ttcn3-{msc,bsc,bts}-test ...................................................................... Patch Set 3: > Patch Set 3: > > Looks nice, but shouldn't you start the testsuite as the last step? Personally I prefer to run the actual testsuite myself, so I have time to change some parameters or more often execute only a specific test case. -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I201b77c013cbeef9d1a07b9422b27f375811ed69 Gerrit-Change-Number: 26485 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Comment-Date: Sat, 18 Dec 2021 13:04:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 18 15:07:34 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 18 Dec 2021 15:07:34 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: fix CHAN ACT templates for dynamic timeslots In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26194 to look at the new patch set (#3). Change subject: library/RSL_Types: fix CHAN ACT templates for dynamic timeslots ...................................................................... library/RSL_Types: fix CHAN ACT templates for dynamic timeslots * t_RSL_IE_ActType_PDCH is actually a constant, not a template. * tr_RSL_CHAN_ACT_PDCH makes no use of parameter 'mode'. * Accomplish tr_RSL_CHAN_ACT_PDCH with a send template. * Use 'present' qualifier for receive template parameters. Change-Id: Ie62a92daaacf4de5f05dd1f3f5b4a2a5e4ee6dd6 --- M bsc/BSC_Tests.ttcn M library/RSL_Types.ttcn 2 files changed, 31 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/26194/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie62a92daaacf4de5f05dd1f3f5b4a2a5e4ee6dd6 Gerrit-Change-Number: 26194 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Dec 18 18:03:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sat, 18 Dec 2021 18:03:32 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Set proper CRC Header for ACK Initialization In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26598 ) Change subject: mgcp_network.c: Set proper CRC Header for ACK Initialization ...................................................................... Patch Set 1: I think it's clear that prior to this pach the CRC of the modified message was not updated, and now with the patch it is, as the the one line being changed in this patch explains in the commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f Gerrit-Change-Number: 26598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Sat, 18 Dec 2021 18:03:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Sun Dec 19 11:32:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:32:48 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61bf18665dd26_74d2b05e19645f866693c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/xUbuntu_18.04/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 250s] #define VERSION "0.2.3" [ 250s] #define STDC_HEADERS 1 [ 250s] #define HAVE_SYS_TYPES_H 1 [ 250s] #define HAVE_SYS_STAT_H 1 [ 250s] #define HAVE_STDLIB_H 1 [ 250s] #define HAVE_STRING_H 1 [ 250s] #define HAVE_MEMORY_H 1 [ 250s] #define HAVE_STRINGS_H 1 [ 250s] #define HAVE_INTTYPES_H 1 [ 250s] #define HAVE_STDINT_H 1 [ 250s] #define HAVE_UNISTD_H 1 [ 250s] #define HAVE_DLFCN_H 1 [ 250s] #define LT_OBJDIR ".libs/" [ 250s] [ 250s] configure: exit 1 [ 250s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 250s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 250s] make[1]: *** [override_dh_auto_configure] Error 2 [ 250s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 250s] debian/rules:45: recipe for target 'build' failed [ 250s] make: *** [build] Error 2 [ 250s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 250s] ### VM INTERACTION START ### [ 253s] [ 239.842714] sysrq: Power Off [ 253s] [ 239.846518] reboot: Power down [ 253s] ### VM INTERACTION END ### [ 253s] [ 253s] cloud133 failed "build osmo-cbc_0.2.3.dsc" at Sun Dec 19 11:32:40 UTC 2021. [ 253s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:33:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:33:22 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in xUbuntu_19.04/i586 In-Reply-To: References: Message-ID: <61bf188577e69_74d2b05e19645f866725a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/xUbuntu_19.04/i586 Package network:osmocom:latest/osmo-remsim failed to build in xUbuntu_19.04/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:33:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:33:05 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61bf1884bc61c_74d2b05e19645f86670e8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/xUbuntu_18.04/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 0s] Doing kvm build in /var/cache/obs/worker/root_6/root [ 0s] [ 0s] [ 0s] lamb22 started "build osmo-remsim_1.0.0.dsc" at Sun Dec 19 11:33:17 UTC 2021. [ 0s] [ 0s] Building osmo-remsim for project 'network:osmocom:latest' repository 'xUbuntu_18.04' arch 'x86_64' srcmd5 'aa9f1fe44b2d6613d9844d17394ccff2' [ 0s] [ 0s] processing recipe /var/cache/obs/worker/root_6/.build-srcdir/osmo-remsim_1.0.0.dsc ... [ 0s] running changelog2spec --target debian --file /var/cache/obs/worker/root_6/.build-srcdir/osmo-remsim_1.0.0.dsc [ 1s] init_buildsystem --configdir /var/run/obs/worker/6/build/configs --cachedir /var/cache/build --prepare --clean --rpmlist /var/cache/obs/worker/root_6/.build.rpmlist /var/cache/obs/worker/root_6/.build-srcdir/osmo-remsim_1.0.0.dsc build ... [ 3s] cycle: libc6 -> libgcc1 [ 3s] breaking dependency libgcc1 -> libc6 [ 3s] [1/49] preinstalling libgcc1... [ 3s] [2/49] preinstalling libc6... [ 3s] [3/49] preinstalling debianutils... [ 4s] [4/49] preinstalling diffutils... [ 4s] [5/49] preinstalling libattr1... [ 4s] [6/49] preinstalling libbz2-1.0... [ 4s] [7/49] preinstalling libc-bin... [ 4s] [8/49] preinstalling libdbus-1-3... [ 4s] [9/49] preinstalling libdebconfclient0... [ 5s] [10/49] preinstalling libgmp10... [ 5s] [11/49] preinstalling liblzma5... [ 5s] [12/49] preinstalling libnih1... [ 5s] [13/49] preinstalling libpcre3... [ 6s] [14/49] preinstalling libsepol1... [ 6s] [15/49] preinstalling libsigsegv2... [ 6s] [16/49] preinstalling libtinfo5... [ 7s] [17/49] preinstalling libzstd1... -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:33:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:33:39 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in xUbuntu_18.04/i586 In-Reply-To: References: Message-ID: <61bf18a414de1_74d2b05e19645f86673a0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/xUbuntu_18.04/i586 Package network:osmocom:latest/osmo-cbc failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:33:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:33:56 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in xUbuntu_18.04/i586 In-Reply-To: References: Message-ID: <61bf18be36371_74d2b05e19645f8667585@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/xUbuntu_18.04/i586 Package network:osmocom:latest/osmo-remsim failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 3s] [29/49] preinstalling passwd... [ 3s] [30/49] preinstalling sed... [ 4s] [31/49] preinstalling tar... [ 4s] [32/49] preinstalling coreutils... [ 4s] [33/49] preinstalling util-linux... [ 4s] [34/49] preinstalling dpkg... [ 4s] [35/49] preinstalling readline-common... [ 4s] [36/49] preinstalling gzip... [ 4s] [37/49] preinstalling perl-base... [ 5s] [38/49] preinstalling dash... [ 5s] [39/49] preinstalling grep... [ 5s] [40/49] preinstalling debconf... [ 5s] [41/49] preinstalling init-system-helpers... [ 5s] [42/49] preinstalling perl-modules-5.26... [ 5s] [43/49] preinstalling libreadline7... [ 5s] [44/49] preinstalling tzdata... [ 5s] [45/49] preinstalling libperl5.26... [ 6s] [46/49] preinstalling gawk... [ 6s] [47/49] preinstalling base-files... [ 6s] [48/49] preinstalling perl... [ 6s] [49/49] preinstalling bash... [ 6s] [ 6s] [1/6] preinstalling binutils... [ 6s] [2/6] preinstalling libsmartcols1... [ 6s] [3/6] preinstalling libuuid1... [ 6s] [4/6] preinstalling libblkid1... [ 7s] [5/6] preinstalling libmount1... [ 7s] [6/6] preinstalling mount... [ 7s] copying packages... -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:33:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:33:56 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in xUbuntu_19.04/i586 In-Reply-To: References: Message-ID: <61bf18bdec2b6_74d2b05e19645f8667433@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/xUbuntu_19.04/i586 Package network:osmocom:latest/osmo-cbc failed to build in xUbuntu_19.04/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 0s] Using BUILD_ROOT=/var/cache/obs/worker/root_6/.mount [ 0s] Using BUILD_ARCH=i586:i486:i386 [ 0s] Doing kvm build in /var/cache/obs/worker/root_6/root [ 0s] [ 1s] [ 1s] lamb01 started "build osmo-cbc_0.2.3.dsc" at Sun Dec 19 11:34:20 UTC 2021. [ 1s] [ 1s] Building osmo-cbc for project 'network:osmocom:latest' repository 'xUbuntu_19.04' arch 'i586' srcmd5 '29bfe51b0698921bfd22e3f23d2cc1f1' [ 1s] [ 1s] processing recipe /var/cache/obs/worker/root_6/.build-srcdir/osmo-cbc_0.2.3.dsc ... [ 1s] running changelog2spec --target debian --file /var/cache/obs/worker/root_6/.build-srcdir/osmo-cbc_0.2.3.dsc [ 1s] init_buildsystem --configdir /var/run/obs/worker/6/build/configs --cachedir /var/cache/build --prepare --clean --rpmlist /var/cache/obs/worker/root_6/.build.rpmlist /var/cache/obs/worker/root_6/.build-srcdir/osmo-cbc_0.2.3.dsc build ... -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:34:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:34:30 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_10/x86_64 In-Reply-To: References: Message-ID: <61bf18dd3f8a1_74d2b05e19645f8667811@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_10/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 137s] #define PACKAGE_URL "" [ 137s] #define STDC_HEADERS 1 [ 137s] #define HAVE_SYS_TYPES_H 1 [ 137s] #define HAVE_SYS_STAT_H 1 [ 137s] #define HAVE_STDLIB_H 1 [ 137s] #define HAVE_STRING_H 1 [ 137s] #define HAVE_MEMORY_H 1 [ 137s] #define HAVE_STRINGS_H 1 [ 137s] #define HAVE_INTTYPES_H 1 [ 137s] #define HAVE_STDINT_H 1 [ 137s] #define HAVE_UNISTD_H 1 [ 137s] #define HAVE_DLFCN_H 1 [ 137s] #define LT_OBJDIR ".libs/" [ 137s] #define PACKAGE "osmo-remsim" [ 137s] #define VERSION "1.0.0" [ 137s] [ 137s] configure: exit 1 [ 137s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 137s] make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 2 [ 137s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 137s] make: *** [debian/rules:14: build] Error 2 [ 137s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 137s] ### VM INTERACTION START ### [ 140s] [ 132.394230] sysrq: Power Off [ 140s] [ 132.397334] reboot: Power down [ 141s] ### VM INTERACTION END ### [ 141s] [ 141s] goat05 failed "build osmo-remsim_1.0.0.dsc" at Sun Dec 19 11:34:17 UTC 2021. [ 141s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:35:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:35:04 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_10/i586 In-Reply-To: References: Message-ID: <61bf18fc31843_74d2b05e19645f8667982@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_10/i586 Package network:osmocom:latest/osmo-cbc failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 181s] #define PACKAGE_URL "" [ 181s] #define PACKAGE "osmo-cbc" [ 181s] #define VERSION "0.2.3" [ 181s] #define STDC_HEADERS 1 [ 181s] #define HAVE_SYS_TYPES_H 1 [ 181s] #define HAVE_SYS_STAT_H 1 [ 181s] #define HAVE_STDLIB_H 1 [ 181s] #define HAVE_STRING_H 1 [ 181s] #define HAVE_MEMORY_H 1 [ 181s] #define HAVE_STRINGS_H 1 [ 181s] #define HAVE_INTTYPES_H 1 [ 181s] #define HAVE_STDINT_H 1 [ 181s] #define HAVE_UNISTD_H 1 [ 181s] #define HAVE_DLFCN_H 1 [ 181s] #define LT_OBJDIR ".libs/" [ 181s] [ 181s] configure: exit 1 [ 181s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 181s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 181s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 181s] make: *** [debian/rules:45: build] Error 2 [ 181s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 181s] ### VM INTERACTION START ### [ 184s] [ 173.962748] sysrq: Power Off [ 184s] [ 173.972164] reboot: Power down [ 184s] ### VM INTERACTION END ### [ 184s] [ 184s] goat17 failed "build osmo-cbc_0.2.3.dsc" at Sun Dec 19 11:34:54 UTC 2021. [ 184s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:36:12 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:36:12 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_10/x86_64 In-Reply-To: References: Message-ID: <61bf193a915f1_74d2b05e19645f86681bd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_10/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 324s] #define PACKAGE_URL "" [ 324s] #define PACKAGE "osmo-cbc" [ 324s] #define VERSION "0.2.3" [ 324s] #define STDC_HEADERS 1 [ 324s] #define HAVE_SYS_TYPES_H 1 [ 324s] #define HAVE_SYS_STAT_H 1 [ 324s] #define HAVE_STDLIB_H 1 [ 324s] #define HAVE_STRING_H 1 [ 324s] #define HAVE_MEMORY_H 1 [ 324s] #define HAVE_STRINGS_H 1 [ 324s] #define HAVE_INTTYPES_H 1 [ 324s] #define HAVE_STDINT_H 1 [ 324s] #define HAVE_UNISTD_H 1 [ 324s] #define HAVE_DLFCN_H 1 [ 324s] #define LT_OBJDIR ".libs/" [ 324s] [ 324s] configure: exit 1 [ 324s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 324s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 324s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 324s] make: *** [debian/rules:45: build] Error 2 [ 324s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 324s] ### VM INTERACTION START ### [ 327s] [ 306.909076] sysrq: Power Off [ 327s] [ 306.913285] reboot: Power down [ 327s] ### VM INTERACTION END ### [ 327s] [ 327s] old-atreju4 failed "build osmo-cbc_0.2.3.dsc" at Sun Dec 19 11:35:58 UTC 2021. [ 327s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:38:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:38:28 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_10/x86_64 In-Reply-To: References: Message-ID: <61bf19cff0d00_74d2b05e19645f86682e3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_10/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 21s] [19/491] installing libjs-jquery-3.3.1~dfsg-3+deb10u1 [ 21s] [20/491] installing libldap-common-2.4.47+dfsg-3+deb10u6 [ 21s] [21/491] installing libmagic-mgc-1:5.35-4+deb10u2 [ 22s] [22/491] installing libpython2.7-minimal-2.7.16-2+deb10u1 [ 22s] [23/491] installing libsemanage-common-2.8-2 [ 22s] [24/491] installing libthai-data-0.1.28-2 [ 22s] [25/491] installing libx11-data-2:1.6.7-1+deb10u2 [ 22s] [26/491] installing linux-libc-dev-4.19.194-1 [ 22s] [27/491] installing lsb-base-10.2019051400 [ 22s] [28/491] installing lynx-common-2.8.9rel.1-3 [ 22s] [29/491] installing mime-support-3.62 [ 22s] [30/491] installing ncurses-base-6.1+20181013-2+deb10u2 [ 22s] [31/491] installing osmocom-nightly-1.0.0.202112190026 [ 22s] [32/491] installing python-apt-common-1.8.4.3 [ 22s] [33/491] installing sensible-utils-0.0.12 [ 22s] Processing triggers for mime-support (3.62) ... [ 22s] [34/491] installing vim-runtime-2:8.1.0875-5 [ 23s] Adding 'diversion of /usr/share/vim/vim81/doc/help.txt to /usr/share/vim/vim81/doc/help.txt.vim-tiny by vim-runtime' [ 23s] Adding 'diversion of /usr/share/vim/vim81/doc/tags to /usr/share/vim/vim81/doc/tags.vim-tiny by vim-runtime' [ 23s] [35/491] installing xdg-utils-1.1.3-1+deb10u1 [ 23s] [36/491] installing x11-common-1:7.7+19 [ 23s] update-rc.d: warning: start and stop actions are no longer supported; falling back to defaults [ 23s] invoke-rc.d: could not determine current runlevel [ 23s] invoke-rc.d: policy-rc.d denied execution of start. [ 23s] [37/491] installing libgcc1-1:8.3.0-6 [ 23s] dpkg: libgcc1:amd64: dependency problems, but configuring anyway as you requested: [ 23s] libgcc1:amd64 depends on libc6 (>= 2.14); however: [ 23s] Package libc6 is not installed. [ 23s] [38/491] installing libc6-2.28-10 -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:38:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:38:28 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_10/i586 In-Reply-To: References: Message-ID: <61bf19d037a2a_74d2b05e19645f86683e8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_10/i586 Package network:osmocom:latest/osmo-remsim failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 353s] #define PACKAGE_URL "" [ 353s] #define STDC_HEADERS 1 [ 353s] #define HAVE_SYS_TYPES_H 1 [ 353s] #define HAVE_SYS_STAT_H 1 [ 353s] #define HAVE_STDLIB_H 1 [ 353s] #define HAVE_STRING_H 1 [ 353s] #define HAVE_MEMORY_H 1 [ 353s] #define HAVE_STRINGS_H 1 [ 353s] #define HAVE_INTTYPES_H 1 [ 353s] #define HAVE_STDINT_H 1 [ 353s] #define HAVE_UNISTD_H 1 [ 353s] #define HAVE_DLFCN_H 1 [ 353s] #define LT_OBJDIR ".libs/" [ 353s] #define PACKAGE "osmo-remsim" [ 353s] #define VERSION "1.0.0" [ 353s] [ 353s] configure: exit 1 [ 353s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 353s] make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 2 [ 353s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 353s] make: *** [debian/rules:14: build] Error 2 [ 353s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 353s] ### VM INTERACTION START ### [ 356s] [ 296.995486] sysrq: Power Off [ 356s] [ 297.020052] reboot: Power down [ 356s] ### VM INTERACTION END ### [ 356s] [ 356s] cloud105 failed "build osmo-remsim_1.0.0.dsc" at Sun Dec 19 11:38:11 UTC 2021. [ 356s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:39:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:39:02 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61bf19ea8fd08_74d2b05e19645f866841e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/xUbuntu_18.04/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 333s] #define VERSION "0.2.3" [ 333s] #define STDC_HEADERS 1 [ 333s] #define HAVE_SYS_TYPES_H 1 [ 333s] #define HAVE_SYS_STAT_H 1 [ 333s] #define HAVE_STDLIB_H 1 [ 333s] #define HAVE_STRING_H 1 [ 333s] #define HAVE_MEMORY_H 1 [ 333s] #define HAVE_STRINGS_H 1 [ 333s] #define HAVE_INTTYPES_H 1 [ 333s] #define HAVE_STDINT_H 1 [ 333s] #define HAVE_UNISTD_H 1 [ 333s] #define HAVE_DLFCN_H 1 [ 333s] #define LT_OBJDIR ".libs/" [ 333s] [ 333s] configure: exit 1 [ 333s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 333s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 333s] make[1]: *** [override_dh_auto_configure] Error 2 [ 333s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 333s] debian/rules:45: recipe for target 'build' failed [ 333s] make: *** [build] Error 2 [ 333s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 333s] ### VM INTERACTION START ### [ 336s] [ 291.955272] sysrq: Power Off [ 336s] [ 291.991052] reboot: Power down [ 336s] ### VM INTERACTION END ### [ 336s] [ 336s] lamb23 failed "build osmo-cbc_0.2.3.dsc" at Sun Dec 19 11:38:55 UTC 2021. [ 336s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:39:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:39:19 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in xUbuntu_18.04/i586 In-Reply-To: References: Message-ID: <61bf19eba0a6e_74d2b05e19645f866856c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/xUbuntu_18.04/i586 Package network:osmocom:latest/osmo-cbc failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 310s] #define VERSION "0.2.3" [ 310s] #define STDC_HEADERS 1 [ 310s] #define HAVE_SYS_TYPES_H 1 [ 310s] #define HAVE_SYS_STAT_H 1 [ 310s] #define HAVE_STDLIB_H 1 [ 310s] #define HAVE_STRING_H 1 [ 310s] #define HAVE_MEMORY_H 1 [ 310s] #define HAVE_STRINGS_H 1 [ 310s] #define HAVE_INTTYPES_H 1 [ 310s] #define HAVE_STDINT_H 1 [ 310s] #define HAVE_UNISTD_H 1 [ 310s] #define HAVE_DLFCN_H 1 [ 310s] #define LT_OBJDIR ".libs/" [ 310s] [ 310s] configure: exit 1 [ 310s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 310s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 310s] make[1]: *** [override_dh_auto_configure] Error 2 [ 310s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 310s] debian/rules:45: recipe for target 'build' failed [ 310s] make: *** [build] Error 2 [ 310s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 310s] ### VM INTERACTION START ### [ 313s] [ 283.924451] sysrq: Power Off [ 313s] [ 283.927924] reboot: Power down [ 313s] ### VM INTERACTION END ### [ 313s] [ 313s] cloud103 failed "build osmo-cbc_0.2.3.dsc" at Sun Dec 19 11:39:10 UTC 2021. [ 313s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:39:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:39:36 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_10/x86_64 In-Reply-To: References: Message-ID: <61bf1a0aeb3fd_74d2b05e19645f86687c2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_10/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 2s] [6/72] preinstalling sensible-utils... [ 2s] [7/72] preinstalling libgcc1... [ 2s] [8/72] preinstalling libc6... [ 3s] [9/72] preinstalling bsdutils... [ 3s] [10/72] preinstalling debianutils... [ 3s] [11/72] preinstalling diffutils... [ 3s] [12/72] preinstalling hostname... [ 3s] [13/72] preinstalling insserv... [ 3s] [14/72] preinstalling libattr1... [ 3s] [15/72] preinstalling libbz2-1.0... [ 3s] [16/72] preinstalling libc-bin... [ 3s] [17/72] preinstalling libcom-err2... [ 3s] [18/72] preinstalling libdb5.3... [ 3s] [19/72] preinstalling libdebconfclient0... [ 3s] [20/72] preinstalling liblzma5... [ 3s] [21/72] preinstalling libncurses5... [ 4s] [22/72] preinstalling libpcre3... [ 4s] [23/72] preinstalling libsepol1... [ 4s] [24/72] preinstalling libsigsegv2... [ 4s] [25/72] preinstalling libslang2... [ 4s] [26/72] preinstalling libsmartcols1... [ 4s] [27/72] preinstalling libtinfo6... [ 4s] [28/72] preinstalling libustr-1.0-1... [ 4s] [29/72] preinstalling libuuid1... [ 4s] [30/72] preinstalling multiarch-support... [ 4s] [31/72] preinstalling zlib1g... [ 4s] [32/72] preinstalling base-passwd... [ 4s] [33/72] preinstalling libacl1... [ 4s] [34/72] preinstalling libblkid1... -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:39:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:39:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61bf1a0c4aac9_74d2b05e19645f8668813@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/xUbuntu_18.04/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 388s] #define HAVE_SYS_TYPES_H 1 [ 388s] #define HAVE_SYS_STAT_H 1 [ 388s] #define HAVE_STDLIB_H 1 [ 388s] #define HAVE_STRING_H 1 [ 388s] #define HAVE_MEMORY_H 1 [ 388s] #define HAVE_STRINGS_H 1 [ 388s] #define HAVE_INTTYPES_H 1 [ 388s] #define HAVE_STDINT_H 1 [ 388s] #define HAVE_UNISTD_H 1 [ 388s] #define HAVE_DLFCN_H 1 [ 388s] #define LT_OBJDIR ".libs/" [ 388s] #define PACKAGE "osmo-remsim" [ 388s] #define VERSION "1.0.0" [ 388s] [ 388s] configure: exit 1 [ 388s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 388s] debian/rules:17: recipe for target 'override_dh_auto_configure' failed [ 388s] make[1]: *** [override_dh_auto_configure] Error 2 [ 388s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 388s] debian/rules:14: recipe for target 'build' failed [ 388s] make: *** [build] Error 2 [ 388s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 388s] ### VM INTERACTION START ### [ 391s] [ 345.675302] sysrq: Power Off [ 391s] [ 345.724498] reboot: Power down [ 391s] ### VM INTERACTION END ### [ 391s] [ 391s] lamb22 failed "build osmo-remsim_1.0.0.dsc" at Sun Dec 19 11:39:48 UTC 2021. [ 391s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:40:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:40:10 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61bf1a263baca_74d2b05e19645f866892e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 187s] #define VERSION "0.2.3" [ 187s] #define STDC_HEADERS 1 [ 187s] #define HAVE_SYS_TYPES_H 1 [ 187s] #define HAVE_SYS_STAT_H 1 [ 187s] #define HAVE_STDLIB_H 1 [ 187s] #define HAVE_STRING_H 1 [ 187s] #define HAVE_MEMORY_H 1 [ 187s] #define HAVE_STRINGS_H 1 [ 187s] #define HAVE_INTTYPES_H 1 [ 187s] #define HAVE_STDINT_H 1 [ 187s] #define HAVE_UNISTD_H 1 [ 187s] #define HAVE_DLFCN_H 1 [ 187s] #define LT_OBJDIR ".libs/" [ 187s] [ 187s] configure: exit 1 [ 187s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 187s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 187s] make[1]: *** [override_dh_auto_configure] Error 2 [ 187s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 187s] debian/rules:45: recipe for target 'build' failed [ 187s] make: *** [build] Error 2 [ 187s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 187s] ### VM INTERACTION START ### [ 190s] [ 179.942235] sysrq: Power Off [ 190s] [ 179.944582] reboot: Power down [ 190s] ### VM INTERACTION END ### [ 190s] [ 190s] wildcard2 failed "build osmo-cbc_0.2.3.202112190026.dsc" at Sun Dec 19 11:39:59 UTC 2021. [ 190s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:40:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:40:27 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in xUbuntu_18.04/i586 In-Reply-To: References: Message-ID: <61bf1a4540a27_74d2b05e19645f86690d3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/xUbuntu_18.04/i586 Package network:osmocom:latest/osmo-remsim failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 367s] #define HAVE_SYS_TYPES_H 1 [ 367s] #define HAVE_SYS_STAT_H 1 [ 367s] #define HAVE_STDLIB_H 1 [ 367s] #define HAVE_STRING_H 1 [ 367s] #define HAVE_MEMORY_H 1 [ 367s] #define HAVE_STRINGS_H 1 [ 367s] #define HAVE_INTTYPES_H 1 [ 367s] #define HAVE_STDINT_H 1 [ 367s] #define HAVE_UNISTD_H 1 [ 367s] #define HAVE_DLFCN_H 1 [ 367s] #define LT_OBJDIR ".libs/" [ 368s] #define PACKAGE "osmo-remsim" [ 368s] #define VERSION "1.0.0" [ 368s] [ 368s] configure: exit 1 [ 368s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 368s] debian/rules:17: recipe for target 'override_dh_auto_configure' failed [ 368s] make[1]: *** [override_dh_auto_configure] Error 2 [ 368s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 368s] debian/rules:14: recipe for target 'build' failed [ 368s] make: *** [build] Error 2 [ 368s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 368s] ### VM INTERACTION START ### [ 371s] [ 357.765538] sysrq: Power Off [ 371s] [ 357.796880] reboot: Power down [ 371s] ### VM INTERACTION END ### [ 371s] [ 371s] lamb10 failed "build osmo-remsim_1.0.0.dsc" at Sun Dec 19 11:40:24 UTC 2021. [ 371s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:41:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:41:52 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_10/x86_64 In-Reply-To: References: Message-ID: <61bf1a9eb9c91_74d2b05e19645f8669393@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_10/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 192s] #define PACKAGE_URL "" [ 192s] #define PACKAGE "osmo-cbc" [ 192s] #define VERSION "0.2.3" [ 192s] #define STDC_HEADERS 1 [ 192s] #define HAVE_SYS_TYPES_H 1 [ 192s] #define HAVE_SYS_STAT_H 1 [ 192s] #define HAVE_STDLIB_H 1 [ 192s] #define HAVE_STRING_H 1 [ 192s] #define HAVE_MEMORY_H 1 [ 192s] #define HAVE_STRINGS_H 1 [ 192s] #define HAVE_INTTYPES_H 1 [ 192s] #define HAVE_STDINT_H 1 [ 192s] #define HAVE_UNISTD_H 1 [ 192s] #define HAVE_DLFCN_H 1 [ 192s] #define LT_OBJDIR ".libs/" [ 192s] [ 192s] configure: exit 1 [ 192s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 192s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 192s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 192s] make: *** [debian/rules:45: build] Error 2 [ 192s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 192s] ### VM INTERACTION START ### [ 195s] [ 183.143048] sysrq: Power Off [ 195s] [ 183.144910] reboot: Power down [ 195s] ### VM INTERACTION END ### [ 195s] [ 195s] build81 failed "build osmo-cbc_0.2.3.202112190026.dsc" at Sun Dec 19 11:41:47 UTC 2021. [ 195s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:42:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:42:09 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61bf1a9f8d877_74d2b05e19645f8669473@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 301s] #define HAVE_SYS_TYPES_H 1 [ 301s] #define HAVE_SYS_STAT_H 1 [ 301s] #define HAVE_STDLIB_H 1 [ 301s] #define HAVE_STRING_H 1 [ 301s] #define HAVE_MEMORY_H 1 [ 301s] #define HAVE_STRINGS_H 1 [ 301s] #define HAVE_INTTYPES_H 1 [ 301s] #define HAVE_STDINT_H 1 [ 301s] #define HAVE_UNISTD_H 1 [ 301s] #define HAVE_DLFCN_H 1 [ 301s] #define LT_OBJDIR ".libs/" [ 301s] #define PACKAGE "osmo-remsim" [ 301s] #define VERSION "1.0.0.4-0c832" [ 301s] [ 301s] configure: exit 1 [ 301s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 301s] debian/rules:17: recipe for target 'override_dh_auto_configure' failed [ 301s] make[1]: *** [override_dh_auto_configure] Error 2 [ 301s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 301s] debian/rules:14: recipe for target 'build' failed [ 301s] make: *** [build] Error 2 [ 301s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 301s] ### VM INTERACTION START ### [ 304s] [ 286.610392] sysrq: Power Off [ 304s] [ 286.618733] reboot: Power down [ 304s] ### VM INTERACTION END ### [ 304s] [ 304s] old-atreju2 failed "build osmo-remsim_1.0.0.4.0c832.202112190026.dsc" at Sun Dec 19 11:42:00 UTC 2021. [ 304s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:43:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:43:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_10/aarch64 In-Reply-To: References: Message-ID: <61bf1af897d87_74d2b05e19645f8669678@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_10/aarch64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 223s] #define PACKAGE_URL "" [ 223s] #define STDC_HEADERS 1 [ 223s] #define HAVE_SYS_TYPES_H 1 [ 223s] #define HAVE_SYS_STAT_H 1 [ 223s] #define HAVE_STDLIB_H 1 [ 223s] #define HAVE_STRING_H 1 [ 223s] #define HAVE_MEMORY_H 1 [ 223s] #define HAVE_STRINGS_H 1 [ 223s] #define HAVE_INTTYPES_H 1 [ 223s] #define HAVE_STDINT_H 1 [ 223s] #define HAVE_UNISTD_H 1 [ 223s] #define HAVE_DLFCN_H 1 [ 223s] #define LT_OBJDIR ".libs/" [ 223s] #define PACKAGE "osmo-remsim" [ 223s] #define VERSION "1.0.0" [ 223s] [ 223s] configure: exit 1 [ 223s] dh_auto_configure: ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/aarch64-linux-gnu --libexecdir=\${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 223s] make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 2 [ 223s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 223s] make: *** [debian/rules:14: build] Error 2 [ 223s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 223s] ### VM INTERACTION START ### [ 230s] [ 171.661329] sysrq: Power Off [ 230s] [ 171.661952] reboot: Power down [ 230s] ### VM INTERACTION END ### [ 230s] [ 230s] obs-arm-11 failed "build osmo-remsim_1.0.0.dsc" at Sun Dec 19 11:43:45 UTC 2021. [ 230s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:44:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:44:42 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_10/i586 In-Reply-To: References: Message-ID: <61bf1b36751e0_74d2b05e19645f86697d3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_10/i586 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 295s] #define PACKAGE_URL "" [ 295s] #define PACKAGE "osmo-cbc" [ 295s] #define VERSION "0.2.3" [ 295s] #define STDC_HEADERS 1 [ 295s] #define HAVE_SYS_TYPES_H 1 [ 295s] #define HAVE_SYS_STAT_H 1 [ 295s] #define HAVE_STDLIB_H 1 [ 295s] #define HAVE_STRING_H 1 [ 295s] #define HAVE_MEMORY_H 1 [ 295s] #define HAVE_STRINGS_H 1 [ 295s] #define HAVE_INTTYPES_H 1 [ 295s] #define HAVE_STDINT_H 1 [ 295s] #define HAVE_UNISTD_H 1 [ 295s] #define HAVE_DLFCN_H 1 [ 295s] #define LT_OBJDIR ".libs/" [ 295s] [ 295s] configure: exit 1 [ 295s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 295s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 295s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 295s] make: *** [debian/rules:45: build] Error 2 [ 295s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 295s] ### VM INTERACTION START ### [ 298s] [ 282.211631] sysrq: Power Off [ 298s] [ 282.224268] reboot: Power down [ 298s] ### VM INTERACTION END ### [ 298s] [ 298s] lamb66 failed "build osmo-cbc_0.2.3.202112190026.dsc" at Sun Dec 19 11:44:26 UTC 2021. [ 298s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:46:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:46:07 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_10/i586 In-Reply-To: References: Message-ID: <61bf1b8e3926a_74d2b05e19645f86699c9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_10/i586 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 277s] #define PACKAGE_URL "" [ 277s] #define STDC_HEADERS 1 [ 277s] #define HAVE_SYS_TYPES_H 1 [ 277s] #define HAVE_SYS_STAT_H 1 [ 277s] #define HAVE_STDLIB_H 1 [ 277s] #define HAVE_STRING_H 1 [ 277s] #define HAVE_MEMORY_H 1 [ 277s] #define HAVE_STRINGS_H 1 [ 277s] #define HAVE_INTTYPES_H 1 [ 277s] #define HAVE_STDINT_H 1 [ 277s] #define HAVE_UNISTD_H 1 [ 277s] #define HAVE_DLFCN_H 1 [ 277s] #define LT_OBJDIR ".libs/" [ 277s] #define PACKAGE "osmo-remsim" [ 277s] #define VERSION "1.0.0.4-0c832" [ 277s] [ 277s] configure: exit 1 [ 277s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 277s] make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 2 [ 277s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 277s] make: *** [debian/rules:14: build] Error 2 [ 277s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 277s] ### VM INTERACTION START ### [ 280s] [ 264.819624] sysrq: Power Off [ 280s] [ 264.827655] reboot: Power down [ 280s] ### VM INTERACTION END ### [ 280s] [ 280s] lamb18 failed "build osmo-remsim_1.0.0.4.0c832.202112190026.dsc" at Sun Dec 19 11:46:06 UTC 2021. [ 280s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 11:46:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 11:46:24 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_10/x86_64 In-Reply-To: References: Message-ID: <61bf1bad4352a_74d2b05e19645f86700a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_10/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 377s] #define PACKAGE_URL "" [ 377s] #define STDC_HEADERS 1 [ 377s] #define HAVE_SYS_TYPES_H 1 [ 377s] #define HAVE_SYS_STAT_H 1 [ 377s] #define HAVE_STDLIB_H 1 [ 377s] #define HAVE_STRING_H 1 [ 377s] #define HAVE_MEMORY_H 1 [ 377s] #define HAVE_STRINGS_H 1 [ 377s] #define HAVE_INTTYPES_H 1 [ 377s] #define HAVE_STDINT_H 1 [ 377s] #define HAVE_UNISTD_H 1 [ 377s] #define HAVE_DLFCN_H 1 [ 377s] #define LT_OBJDIR ".libs/" [ 377s] #define PACKAGE "osmo-remsim" [ 377s] #define VERSION "1.0.0.4-0c832" [ 377s] [ 377s] configure: exit 1 [ 377s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 377s] make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 2 [ 377s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 377s] make: *** [debian/rules:14: build] Error 2 [ 377s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 377s] ### VM INTERACTION START ### [ 380s] [ 350.151355] sysrq: Power Off [ 380s] [ 350.163308] reboot: Power down [ 380s] ### VM INTERACTION END ### [ 380s] [ 380s] cloud120 failed "build osmo-remsim_1.0.0.4.0c832.202112190026.dsc" at Sun Dec 19 11:46:10 UTC 2021. [ 380s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 12:04:16 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 12:04:16 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_10/aarch64 In-Reply-To: References: Message-ID: <61bf1fc7e5d31_74d2b05e19645f8671427@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_10/aarch64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 389s] #define PACKAGE_URL "" [ 389s] #define PACKAGE "osmo-cbc" [ 389s] #define VERSION "0.2.3" [ 389s] #define STDC_HEADERS 1 [ 389s] #define HAVE_SYS_TYPES_H 1 [ 389s] #define HAVE_SYS_STAT_H 1 [ 389s] #define HAVE_STDLIB_H 1 [ 389s] #define HAVE_STRING_H 1 [ 389s] #define HAVE_MEMORY_H 1 [ 389s] #define HAVE_STRINGS_H 1 [ 389s] #define HAVE_INTTYPES_H 1 [ 389s] #define HAVE_STDINT_H 1 [ 389s] #define HAVE_UNISTD_H 1 [ 389s] #define HAVE_DLFCN_H 1 [ 389s] #define LT_OBJDIR ".libs/" [ 389s] [ 389s] configure: exit 1 [ 389s] dh_auto_configure: ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/aarch64-linux-gnu --libexecdir=\${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 389s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 389s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 389s] make: *** [debian/rules:45: build] Error 2 [ 389s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 389s] ### VM INTERACTION START ### [ 392s] [ 334.036033] sysrq: Power Off [ 392s] [ 334.069254] reboot: Power down [ 393s] ### VM INTERACTION END ### [ 393s] [ 393s] obs-arm-9 failed "build osmo-cbc_0.2.3.dsc" at Sun Dec 19 12:04:14 UTC 2021. [ 393s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 12:19:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 12:19:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_10/aarch64 In-Reply-To: References: Message-ID: <61bf234b94e33_74d2b05e19645f8672842@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_10/aarch64 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 415s] #define PACKAGE_URL "" [ 415s] #define PACKAGE "osmo-cbc" [ 415s] #define VERSION "0.2.3" [ 415s] #define STDC_HEADERS 1 [ 415s] #define HAVE_SYS_TYPES_H 1 [ 415s] #define HAVE_SYS_STAT_H 1 [ 415s] #define HAVE_STDLIB_H 1 [ 415s] #define HAVE_STRING_H 1 [ 415s] #define HAVE_MEMORY_H 1 [ 415s] #define HAVE_STRINGS_H 1 [ 415s] #define HAVE_INTTYPES_H 1 [ 415s] #define HAVE_STDINT_H 1 [ 415s] #define HAVE_UNISTD_H 1 [ 415s] #define HAVE_DLFCN_H 1 [ 415s] #define LT_OBJDIR ".libs/" [ 415s] [ 415s] configure: exit 1 [ 415s] dh_auto_configure: ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/aarch64-linux-gnu --libexecdir=\${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 415s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 415s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 415s] make: *** [debian/rules:45: build] Error 2 [ 415s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 415s] ### VM INTERACTION START ### [ 418s] [ 394.162564] sysrq: Power Off [ 418s] [ 394.164589] reboot: Power down [ 418s] ### VM INTERACTION END ### [ 418s] [ 418s] obs-arm-7 failed "build osmo-cbc_0.2.3.202112190026.dsc" at Sun Dec 19 12:19:09 UTC 2021. [ 418s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 12:24:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 12:24:57 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_10/armv7l In-Reply-To: References: Message-ID: <61bf24b3bca50_74d2b05e19645f8673890@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_10/armv7l Package network:osmocom:latest/osmo-remsim failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 638s] #define PACKAGE_URL "" [ 638s] #define STDC_HEADERS 1 [ 638s] #define HAVE_SYS_TYPES_H 1 [ 638s] #define HAVE_SYS_STAT_H 1 [ 638s] #define HAVE_STDLIB_H 1 [ 638s] #define HAVE_STRING_H 1 [ 638s] #define HAVE_MEMORY_H 1 [ 638s] #define HAVE_STRINGS_H 1 [ 638s] #define HAVE_INTTYPES_H 1 [ 638s] #define HAVE_STDINT_H 1 [ 638s] #define HAVE_UNISTD_H 1 [ 638s] #define HAVE_DLFCN_H 1 [ 638s] #define LT_OBJDIR ".libs/" [ 638s] #define PACKAGE "osmo-remsim" [ 638s] #define VERSION "1.0.0" [ 638s] [ 638s] configure: exit 1 [ 638s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/arm-linux-gnueabihf --libexecdir=\${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 638s] make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 2 [ 638s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 638s] make: *** [debian/rules:14: build] Error 2 [ 638s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 638s] ### VM INTERACTION START ### [ 641s] [ 578.022426] sysrq: SysRq : Power Off [ 641s] [ 578.024669] reboot: Power down [ 641s] ### VM INTERACTION END ### [ 641s] [ 641s] armbuild01 failed "build osmo-remsim_1.0.0.dsc" at Sun Dec 19 12:24:53 UTC 2021. [ 641s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 12:34:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 12:34:52 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_10/aarch64 In-Reply-To: References: Message-ID: <61bf26ef93a79_74d2b05e19645f8675557@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_10/aarch64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 1428s] configure:7264: result: .libs [ 1428s] configure:7528: checking if gcc supports -fno-rtti -fno-exceptions [ 1428s] configure:7546: gcc -c -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fno-rtti -fno-exceptions conftest.c >&5 [ 1428s] cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but not for C [ 1428s] configure:7550: $? = 0 [ 1428s] configure:7563: result: no [ 1428s] configure:7921: checking for gcc option to produce PIC [ 1428s] configure:7928: result: -fPIC -DPIC [ 1428s] configure:7936: checking if gcc PIC flag -fPIC -DPIC works [ 1428s] configure:7954: gcc -c -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPIC -DPIC conftest.c >&5 [ 1428s] configure:7958: $? = 0 [ 1428s] configure:7971: result: yes [ 1428s] configure:8000: checking if gcc static flag -static works [ 1428s] configure:8028: result: yes [ 1428s] configure:8043: checking if gcc supports -c -o file.o [ 1428s] configure:8064: gcc -c -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -o out/conftest2.o conftest.c >&5 [ 1428s] configure:8068: $? = 0 [ 1428s] configure:8090: result: yes [ 1428s] configure:8098: checking if gcc supports -c -o file.o [ 1428s] configure:8145: result: yes [ 1428s] configure:8178: checking whether the gcc linker (/usr/bin/ld) supports shared libraries [ 1428s] configure:9441: result: yes [ 1428s] configure:9478: checking whether -lc should be explicitly linked in [ 1430s] configure:9486: gcc -c -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_S[ 1335.032600][ T410] sysrq: Power Off [ 1430s] [ 1335.064020][ T7] reboot: Power down [ 1430s] ### VM INTERACTION END ### [ 1430s] [ 1430s] obs-arm-1 failed "build osmo-remsim_1.0.0.4.0c832.202112190026.dsc" at Sun Dec 19 12:34:51 UTC 2021. [ 1430s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 12:38:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 12:38:17 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_10/armv7l In-Reply-To: References: Message-ID: <61bf27c0ebf13_74d2b05e19645f86757db@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_10/armv7l Package network:osmocom:latest/osmo-cbc failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 738s] #define PACKAGE_URL "" [ 738s] #define PACKAGE "osmo-cbc" [ 738s] #define VERSION "0.2.3" [ 738s] #define STDC_HEADERS 1 [ 738s] #define HAVE_SYS_TYPES_H 1 [ 738s] #define HAVE_SYS_STAT_H 1 [ 738s] #define HAVE_STDLIB_H 1 [ 738s] #define HAVE_STRING_H 1 [ 738s] #define HAVE_MEMORY_H 1 [ 738s] #define HAVE_STRINGS_H 1 [ 738s] #define HAVE_INTTYPES_H 1 [ 738s] #define HAVE_STDINT_H 1 [ 738s] #define HAVE_UNISTD_H 1 [ 738s] #define HAVE_DLFCN_H 1 [ 738s] #define LT_OBJDIR ".libs/" [ 738s] [ 738s] configure: exit 1 [ 738s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/arm-linux-gnueabihf --libexecdir=\${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 738s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 738s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 738s] make: *** [debian/rules:45: build] Error 2 [ 738s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 738s] ### VM INTERACTION START ### [ 740s] [ 682.203254] sysrq: SysRq : Power Off [ 740s] [ 682.207423] reboot: Power down [ 740s] ### VM INTERACTION END ### [ 740s] [ 740s] armbuild02 failed "build osmo-cbc_0.2.3.dsc" at Sun Dec 19 12:38:13 UTC 2021. [ 740s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 12:40:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 12:40:33 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <61bf28554dc07_74d2b05e19645f86758a3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Raspbian_10/armv7l Package network:osmocom:latest/osmo-cbc failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 1064s] #define PACKAGE_URL "" [ 1064s] #define PACKAGE "osmo-cbc" [ 1064s] #define VERSION "0.2.3" [ 1064s] #define STDC_HEADERS 1 [ 1064s] #define HAVE_SYS_TYPES_H 1 [ 1064s] #define HAVE_SYS_STAT_H 1 [ 1064s] #define HAVE_STDLIB_H 1 [ 1064s] #define HAVE_STRING_H 1 [ 1064s] #define HAVE_MEMORY_H 1 [ 1064s] #define HAVE_STRINGS_H 1 [ 1064s] #define HAVE_INTTYPES_H 1 [ 1064s] #define HAVE_STDINT_H 1 [ 1064s] #define HAVE_UNISTD_H 1 [ 1064s] #define HAVE_DLFCN_H 1 [ 1064s] #define LT_OBJDIR ".libs/" [ 1064s] [ 1064s] configure: exit 1 [ 1065s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/arm-linux-gnueabihf --libexecdir=\${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 1065s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 1065s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1065s] make: *** [debian/rules:45: build] Error 2 [ 1065s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1065s] ### VM INTERACTION START ### [ 1067s] [ 948.462236] sysrq: SysRq : Power Off [ 1067s] [ 948.502541] reboot: Power down [ 1070s] ### VM INTERACTION END ### [ 1071s] [ 1071s] obs-arm-6 failed "build osmo-cbc_0.2.3.dsc" at Sun Dec 19 12:40:23 UTC 2021. [ 1071s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 12:43:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 12:43:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <61bf28e9d2941_74d2b05e19645f86761d3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-cbc failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 750s] #define PACKAGE_URL "" [ 750s] #define PACKAGE "osmo-cbc" [ 750s] #define VERSION "0.2.3" [ 750s] #define STDC_HEADERS 1 [ 750s] #define HAVE_SYS_TYPES_H 1 [ 750s] #define HAVE_SYS_STAT_H 1 [ 750s] #define HAVE_STDLIB_H 1 [ 750s] #define HAVE_STRING_H 1 [ 750s] #define HAVE_MEMORY_H 1 [ 750s] #define HAVE_STRINGS_H 1 [ 750s] #define HAVE_INTTYPES_H 1 [ 750s] #define HAVE_STDINT_H 1 [ 750s] #define HAVE_UNISTD_H 1 [ 750s] #define HAVE_DLFCN_H 1 [ 750s] #define LT_OBJDIR ".libs/" [ 750s] [ 750s] configure: exit 1 [ 750s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/arm-linux-gnueabihf --libexecdir=\${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 750s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 750s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 750s] make: *** [debian/rules:45: build] Error 2 [ 750s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 750s] ### VM INTERACTION START ### [ 753s] [ 635.330661] sysrq: SysRq : Power Off [ 753s] [ 635.353255] reboot: Power down [ 753s] ### VM INTERACTION END ### [ 753s] [ 753s] obs-arm-6 failed "build osmo-cbc_0.2.3.202112190026.dsc" at Sun Dec 19 12:43:03 UTC 2021. [ 753s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 12:51:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 12:51:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <61bf2b0713702_74d2b05e19645f86774fd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Raspbian_10/armv7l Package network:osmocom:latest/osmo-remsim failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 572s] CYGPATH_W='echo' [ 572s] DEFS='' [ 572s] DEPDIR='.deps' [ 572s] DLLTOOL='false' [ 572s] DSYMUTIL='' [ 572s] DUMPBIN='' [ 572s] ECHO_C='' [ 572s] ECHO_N='-n' [ 572s] ECHO_T='' [ 572s] EGREP='/bin/grep -E' [ 572s] EXEEXT='' [ 572s] FGREP='/bin/grep -F' [ 572s] GREP='/bin/grep' [ 572s] HAVE_SYSTEMD_FALSE='' [ 572s] HAVE_SYSTEMD_TRUE='' [ 572s] INSTALL_DATA='${INSTALL} -m 644' [ 572s] INSTALL_PROGRAM='${INSTALL}' [ 572s] INSTALL_SCRIPT='${INSTALL}' [ 572s] INSTALL_STRIP_PROGRAM='$(install_sh) -c -s' [ 572s] JANSSON_CFLAGS='' [ 572s] JANSSON_LIBS='' [ 572s] LD='/usr/bin/ld' [ 572s] LDFLAGS='-Wl,-z,relro -Wl,-z,now' [ 574s] LIBOBJS='[ 535.194737] sysrq: SysRq : Power Off [ 574s] [ 535.206703] reboot: Power down [ 574s] ### VM INTERACTION END ### [ 574s] [ 574s] armbuild02 failed "build osmo-remsim_1.0.0.dsc" at Sun Dec 19 12:51:40 UTC 2021. [ 574s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 12:55:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 12:55:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <61bf2bda759a7_74d2b05e19645f86775c1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-remsim failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 565s] #define PACKAGE_URL "" [ 565s] #define STDC_HEADERS 1 [ 565s] #define HAVE_SYS_TYPES_H 1 [ 565s] #define HAVE_SYS_STAT_H 1 [ 565s] #define HAVE_STDLIB_H 1 [ 565s] #define HAVE_STRING_H 1 [ 565s] #define HAVE_MEMORY_H 1 [ 565s] #define HAVE_STRINGS_H 1 [ 565s] #define HAVE_INTTYPES_H 1 [ 565s] #define HAVE_STDINT_H 1 [ 565s] #define HAVE_UNISTD_H 1 [ 565s] #define HAVE_DLFCN_H 1 [ 565s] #define LT_OBJDIR ".libs/" [ 565s] #define PACKAGE "osmo-remsim" [ 565s] #define VERSION "1.0.0.4-0c832" [ 565s] [ 565s] configure: exit 1 [ 565s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/arm-linux-gnueabihf --libexecdir=\${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 565s] make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 2 [ 565s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 565s] make: *** [debian/rules:14: build] Error 2 [ 565s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 565s] ### VM INTERACTION START ### [ 567s] [ 540.337405] sysrq: SysRq : Power Off [ 567s] [ 540.341428] reboot: Power down [ 567s] ### VM INTERACTION END ### [ 567s] [ 567s] armbuild02 failed "build osmo-remsim_1.0.0.4.0c832.202112190026.dsc" at Sun Dec 19 12:55:31 UTC 2021. [ 567s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Sun Dec 19 12:57:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Sun, 19 Dec 2021 12:57:33 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Raspbian_11/armv7l In-Reply-To: References: Message-ID: <61bf2c528b99b_74d2b05e19645f867765f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Raspbian_11/armv7l Package network:osmocom:nightly/ulfius failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: getbinaries: missing packages: liborcania1.2 (worker was armbuild01:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 00:59:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 00:59:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_10/i586 In-Reply-To: References: Message-ID: <61bfd598e5056_74d2b05e19645f8853459@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_10/i586 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 466s] #define PACKAGE_URL "" [ 466s] #define PACKAGE "osmo-cbc" [ 466s] #define VERSION "0.2.3" [ 466s] #define STDC_HEADERS 1 [ 466s] #define HAVE_SYS_TYPES_H 1 [ 466s] #define HAVE_SYS_STAT_H 1 [ 466s] #define HAVE_STDLIB_H 1 [ 466s] #define HAVE_STRING_H 1 [ 466s] #define HAVE_MEMORY_H 1 [ 466s] #define HAVE_STRINGS_H 1 [ 466s] #define HAVE_INTTYPES_H 1 [ 466s] #define HAVE_STDINT_H 1 [ 466s] #define HAVE_UNISTD_H 1 [ 466s] #define HAVE_DLFCN_H 1 [ 466s] #define LT_OBJDIR ".libs/" [ 466s] [ 466s] configure: exit 1 [ 466s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 466s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 466s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 466s] make: *** [debian/rules:45: build] Error 2 [ 466s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 466s] ### VM INTERACTION START ### [ 469s] [ 449.394252][ T402] sysrq: Power Off [ 469s] [ 449.418882][ T16] reboot: Power down [ 469s] ### VM INTERACTION END ### [ 469s] [ 469s] lamb02 failed "build osmo-cbc_0.2.3.202112200026.dsc" at Mon Dec 20 00:59:52 UTC 2021. [ 469s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 01:08:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 01:08:10 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_10/i586 In-Reply-To: References: Message-ID: <61bfd79633d99_74d2b05e19645f885619f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_10/i586 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 573s] #define PACKAGE_URL "" [ 573s] #define STDC_HEADERS 1 [ 573s] #define HAVE_SYS_TYPES_H 1 [ 573s] #define HAVE_SYS_STAT_H 1 [ 573s] #define HAVE_STDLIB_H 1 [ 573s] #define HAVE_STRING_H 1 [ 573s] #define HAVE_MEMORY_H 1 [ 573s] #define HAVE_STRINGS_H 1 [ 573s] #define HAVE_INTTYPES_H 1 [ 573s] #define HAVE_STDINT_H 1 [ 573s] #define HAVE_UNISTD_H 1 [ 573s] #define HAVE_DLFCN_H 1 [ 573s] #define LT_OBJDIR ".libs/" [ 573s] #define PACKAGE "osmo-remsim" [ 573s] #define VERSION "1.0.0.4-0c832" [ 573s] [ 573s] configure: exit 1 [ 573s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 573s] make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 2 [ 573s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 573s] make: *** [debian/rules:14: build] Error 2 [ 573s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 573s] ### VM INTERACTION START ### [ 576s] [ 535.690193] sysrq: Power Off [ 576s] [ 535.764861] reboot: Power down [ 577s] ### VM INTERACTION END ### [ 577s] [ 577s] lamb12 failed "build osmo-remsim_1.0.0.4.0c832.202112200026.dsc" at Mon Dec 20 01:07:53 UTC 2021. [ 577s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 01:10:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 01:10:10 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_10/aarch64 In-Reply-To: References: Message-ID: <61bfd80fba0dc_74d2b05e19645f88566b2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_10/aarch64 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 168s] #define PACKAGE_URL "" [ 168s] #define PACKAGE "osmo-cbc" [ 168s] #define VERSION "0.2.3" [ 168s] #define STDC_HEADERS 1 [ 168s] #define HAVE_SYS_TYPES_H 1 [ 168s] #define HAVE_SYS_STAT_H 1 [ 168s] #define HAVE_STDLIB_H 1 [ 168s] #define HAVE_STRING_H 1 [ 168s] #define HAVE_MEMORY_H 1 [ 168s] #define HAVE_STRINGS_H 1 [ 168s] #define HAVE_INTTYPES_H 1 [ 168s] #define HAVE_STDINT_H 1 [ 168s] #define HAVE_UNISTD_H 1 [ 168s] #define HAVE_DLFCN_H 1 [ 168s] #define LT_OBJDIR ".libs/" [ 168s] [ 168s] configure: exit 1 [ 168s] dh_auto_configure: ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/aarch64-linux-gnu --libexecdir=\${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 168s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 168s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 168s] make: *** [debian/rules:45: build] Error 2 [ 168s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 168s] ### VM INTERACTION START ### [ 171s] [ 159.233372] sysrq: Power Off [ 171s] [ 159.234760] reboot: Power down [ 171s] ### VM INTERACTION END ### [ 171s] [ 171s] obs-arm-10 failed "build osmo-cbc_0.2.3.202112200026.dsc" at Mon Dec 20 01:10:00 UTC 2021. [ 171s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 01:15:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 01:15:36 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_10/aarch64 In-Reply-To: References: Message-ID: <61bfd95696867_74d2b05e19645f8858030@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_10/aarch64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 182s] #define PACKAGE_URL "" [ 182s] #define STDC_HEADERS 1 [ 182s] #define HAVE_SYS_TYPES_H 1 [ 182s] #define HAVE_SYS_STAT_H 1 [ 182s] #define HAVE_STDLIB_H 1 [ 182s] #define HAVE_STRING_H 1 [ 182s] #define HAVE_MEMORY_H 1 [ 182s] #define HAVE_STRINGS_H 1 [ 182s] #define HAVE_INTTYPES_H 1 [ 182s] #define HAVE_STDINT_H 1 [ 182s] #define HAVE_UNISTD_H 1 [ 182s] #define HAVE_DLFCN_H 1 [ 182s] #define LT_OBJDIR ".libs/" [ 182s] #define PACKAGE "osmo-remsim" [ 182s] #define VERSION "1.0.0.4-0c832" [ 182s] [ 182s] configure: exit 1 [ 182s] dh_auto_configure: ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/aarch64-linux-gnu --libexecdir=\${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 182s] make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 2 [ 182s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 182s] make: *** [debian/rules:14: build] Error 2 [ 182s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 182s] ### VM INTERACTION START ### [ 186s] [ 171.093402] sysrq: Power Off [ 186s] [ 171.113884] reboot: Power down [ 186s] ### VM INTERACTION END ### [ 186s] [ 186s] obs-arm-10 failed "build osmo-remsim_1.0.0.4.0c832.202112200026.dsc" at Mon Dec 20 01:15:28 UTC 2021. [ 186s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 01:25:01 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 01:25:01 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61bfdb7297c55_74d2b05e19645f885993b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 495s] #define VERSION "0.2.3" [ 495s] #define STDC_HEADERS 1 [ 495s] #define HAVE_SYS_TYPES_H 1 [ 495s] #define HAVE_SYS_STAT_H 1 [ 495s] #define HAVE_STDLIB_H 1 [ 495s] #define HAVE_STRING_H 1 [ 495s] #define HAVE_MEMORY_H 1 [ 495s] #define HAVE_STRINGS_H 1 [ 495s] #define HAVE_INTTYPES_H 1 [ 495s] #define HAVE_STDINT_H 1 [ 495s] #define HAVE_UNISTD_H 1 [ 495s] #define HAVE_DLFCN_H 1 [ 495s] #define LT_OBJDIR ".libs/" [ 495s] [ 495s] configure: exit 1 [ 495s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 495s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 495s] make[1]: *** [override_dh_auto_configure] Error 2 [ 495s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 495s] debian/rules:45: recipe for target 'build' failed [ 495s] make: *** [build] Error 2 [ 495s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 495s] ### VM INTERACTION START ### [ 498s] [ 480.223515] sysrq: Power Off [ 498s] [ 480.242480] reboot: Power down [ 498s] ### VM INTERACTION END ### [ 498s] [ 498s] lamb58 failed "build osmo-cbc_0.2.3.202112200026.dsc" at Mon Dec 20 01:24:47 UTC 2021. [ 498s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 01:36:10 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 01:36:10 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <61bfde2561106_74d2b05e19645f8862387@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-cbc failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 666s] ac_cv_path_PKG_CONFIG_INSTALLED=/usr/bin/pkg-config [ 666s] ac_cv_path_SED=/bin/sed [ 666s] ac_cv_path_ac_pt_PKG_CONFIG=/usr/bin/pkg-config [ 666s] ac_cv_path_install='/usr/bin/install -c' [ 666s] ac_cv_path_lt_DD=/bin/dd [ 666s] ac_cv_path_mkdir=/bin/mkdir [ 666s] ac_cv_prog_AWK=gawk [ 666s] ac_cv_prog_CPP='gcc -E' [ 666s] ac_cv_prog_ac_ct_AR=ar [ 666s] ac_cv_prog_ac_ct_CC=gcc [ 666s] ac_cv_prog_ac_ct_MANIFEST_TOOL=mt [ 666s] ac_cv_prog_ac_ct_OBJDUMP=objdump [ 666s] ac_cv_prog_ac_ct_RANLIB=ranlib [ 666s] ac_cv_prog_ac_ct_STRIP=strip [ 666s] ac_cv_prog_cc_c89= [ 666s] ac_cv_prog_cc_g=yes [ 666s] ac_cv_prog_make_make_set=yes [ 666s] am_cv_CC_dependencies_compiler_type=none [ 666s] am_cv_make_support_nested_variables=yes [ 666s] am_cv_prog_cc_c_o=yes [ 666s] lt_cv_ar_at_file=@ [ 666s] lt_cv_archive_cmds_need_lc=no [ 666s] lt_cv_deplibs_check_method=pass_all [ 668s] lt_cv_file[ 614.320364] sysrq: SysRq : Power Off [ 668s] [ 614.321684] reboot: Power down [ 669s] ### VM INTERACTION END ### [ 669s] [ 669s] armbuild02 failed "build osmo-cbc_0.2.3.202112200026.dsc" at Mon Dec 20 01:36:01 UTC 2021. [ 669s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 01:47:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 01:47:13 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_10/x86_64 In-Reply-To: References: Message-ID: <61bfe0ba51e3f_74d2b05e19645f88653c1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_10/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 373s] #define PACKAGE_URL "" [ 373s] #define PACKAGE "osmo-cbc" [ 373s] #define VERSION "0.2.3" [ 373s] #define STDC_HEADERS 1 [ 373s] #define HAVE_SYS_TYPES_H 1 [ 373s] #define HAVE_SYS_STAT_H 1 [ 373s] #define HAVE_STDLIB_H 1 [ 373s] #define HAVE_STRING_H 1 [ 373s] #define HAVE_MEMORY_H 1 [ 373s] #define HAVE_STRINGS_H 1 [ 373s] #define HAVE_INTTYPES_H 1 [ 373s] #define HAVE_STDINT_H 1 [ 373s] #define HAVE_UNISTD_H 1 [ 373s] #define HAVE_DLFCN_H 1 [ 373s] #define LT_OBJDIR ".libs/" [ 373s] [ 373s] configure: exit 1 [ 373s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 373s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 373s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 373s] make: *** [debian/rules:45: build] Error 2 [ 373s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 373s] ### VM INTERACTION START ### [ 376s] [ 356.349477] sysrq: Power Off [ 376s] [ 356.354429] reboot: Power down [ 376s] ### VM INTERACTION END ### [ 376s] [ 376s] lamb51 failed "build osmo-cbc_0.2.3.202112200026.dsc" at Mon Dec 20 01:47:04 UTC 2021. [ 376s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 02:01:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 02:01:23 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61bfe402eb96c_74d2b05e19645f886779a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 264s] #define HAVE_SYS_TYPES_H 1 [ 264s] #define HAVE_SYS_STAT_H 1 [ 264s] #define HAVE_STDLIB_H 1 [ 264s] #define HAVE_STRING_H 1 [ 264s] #define HAVE_MEMORY_H 1 [ 264s] #define HAVE_STRINGS_H 1 [ 264s] #define HAVE_INTTYPES_H 1 [ 264s] #define HAVE_STDINT_H 1 [ 264s] #define HAVE_UNISTD_H 1 [ 264s] #define HAVE_DLFCN_H 1 [ 264s] #define LT_OBJDIR ".libs/" [ 264s] #define PACKAGE "osmo-remsim" [ 264s] #define VERSION "1.0.0.4-0c832" [ 264s] [ 264s] configure: exit 1 [ 264s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 264s] debian/rules:17: recipe for target 'override_dh_auto_configure' failed [ 264s] make[1]: *** [override_dh_auto_configure] Error 2 [ 264s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 264s] debian/rules:14: recipe for target 'build' failed [ 264s] make: *** [build] Error 2 [ 264s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 264s] ### VM INTERACTION START ### [ 267s] [ 249.650730] sysrq: Power Off [ 267s] [ 249.658372] reboot: Power down [ 268s] ### VM INTERACTION END ### [ 268s] [ 268s] lamb05 failed "build osmo-remsim_1.0.0.4.0c832.202112200026.dsc" at Mon Dec 20 02:01:17 UTC 2021. [ 268s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 02:03:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 02:03:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_10/x86_64 In-Reply-To: References: Message-ID: <61bfe4981a7a0_74d2b05e19645f88689b7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_10/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 176s] #define PACKAGE_URL "" [ 176s] #define STDC_HEADERS 1 [ 176s] #define HAVE_SYS_TYPES_H 1 [ 176s] #define HAVE_SYS_STAT_H 1 [ 176s] #define HAVE_STDLIB_H 1 [ 176s] #define HAVE_STRING_H 1 [ 176s] #define HAVE_MEMORY_H 1 [ 176s] #define HAVE_STRINGS_H 1 [ 176s] #define HAVE_INTTYPES_H 1 [ 176s] #define HAVE_STDINT_H 1 [ 176s] #define HAVE_UNISTD_H 1 [ 176s] #define HAVE_DLFCN_H 1 [ 176s] #define LT_OBJDIR ".libs/" [ 176s] #define PACKAGE "osmo-remsim" [ 176s] #define VERSION "1.0.0.4-0c832" [ 176s] [ 176s] configure: exit 1 [ 176s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 176s] make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 2 [ 176s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 176s] make: *** [debian/rules:14: build] Error 2 [ 176s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 176s] ### VM INTERACTION START ### [ 180s] [ 170.583409] sysrq: Power Off [ 180s] [ 170.585727] reboot: Power down [ 180s] ### VM INTERACTION END ### [ 180s] [ 180s] goat11 failed "build osmo-remsim_1.0.0.4.0c832.202112200026.dsc" at Mon Dec 20 02:03:43 UTC 2021. [ 180s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 02:21:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 02:21:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <61bfe8d167f57_74d2b05e19645f88740ab@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-remsim failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 1261s] #define PACKAGE_URL "" [ 1261s] #define STDC_HEADERS 1 [ 1261s] #define HAVE_SYS_TYPES_H 1 [ 1261s] #define HAVE_SYS_STAT_H 1 [ 1261s] #define HAVE_STDLIB_H 1 [ 1261s] #define HAVE_STRING_H 1 [ 1261s] #define HAVE_MEMORY_H 1 [ 1261s] #define HAVE_STRINGS_H 1 [ 1261s] #define HAVE_INTTYPES_H 1 [ 1261s] #define HAVE_STDINT_H 1 [ 1261s] #define HAVE_UNISTD_H 1 [ 1261s] #define HAVE_DLFCN_H 1 [ 1261s] #define LT_OBJDIR ".libs/" [ 1261s] #define PACKAGE "osmo-remsim" [ 1261s] #define VERSION "1.0.0.4-0c832" [ 1261s] [ 1261s] configure: exit 1 [ 1261s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/arm-linux-gnueabihf --libexecdir=\${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 1261s] make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 2 [ 1261s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1261s] make: *** [debian/rules:14: build] Error 2 [ 1261s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1261s] ### VM INTERACTION START ### [ 1264s] [ 1236.663502] sysrq: SysRq : Power Off [ 1264s] [ 1236.703584] reboot: Power down [ 1265s] ### VM INTERACTION END ### [ 1265s] [ 1265s] armbuild24 failed "build osmo-remsim_1.0.0.4.0c832.202112200026.dsc" at Mon Dec 20 02:21:39 UTC 2021. [ 1265s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 02:55:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 02:55:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff0abcc18d_74d2b05e19645f88847e0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 478s] self.__getattribute__('to_'+self.format)() [ 478s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 478s] self.exec_dblatex() [ 478s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 478s] self.to_docbook() [ 478s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 478s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 478s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 478s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 478s] IndexError: tuple index out of range [ 478s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 478s] a2x: resource files: [] [ 478s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 478s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 478s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 478s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 478s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 478s] make[1]: *** [Makefile:363: all] Error 2 [ 478s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 478s] dh_auto_build: error: make -j1 returned exit code 2 [ 478s] make: *** [debian/rules:5: binary] Error 25 [ 478s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 478s] ### VM INTERACTION START ### [ 479s] Powering off. [ 479s] [ 456.725628] reboot: Power down [ 479s] ### VM INTERACTION END ### [ 479s] [ 479s] lamb56 failed "build osmo-gsm-manuals-dev_1.2.0.202112200026.dsc" at Mon Dec 20 02:55:12 UTC 2021. [ 479s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:02:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:02:05 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff231dee57_74d2b05e19645f88865ea@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 378s] self.exec_dblatex() [ 378s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 378s] self.to_docbook() [ 378s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 378s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 378s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 378s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 378s] IndexError: tuple index out of range [ 378s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 378s] a2x: resource files: [] [ 378s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 378s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 378s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 378s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 378s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 378s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 378s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 378s] make[1]: *** [Makefile:410: all] Error 2 [ 378s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 378s] dh_auto_build: error: make -j1 returned exit code 2 [ 378s] make: *** [debian/rules:7: build] Error 25 [ 378s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 378s] ### VM INTERACTION START ### [ 379s] Powering off. [ 379s] [ 357.592860] reboot: Power down [ 379s] ### VM INTERACTION END ### [ 379s] [ 379s] old-cirrus3 failed "build osmo-hlr_1.4.0.1.37a5.202112200026.dsc" at Mon Dec 20 03:01:52 UTC 2021. [ 379s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:02:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:02:39 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff2527eeae_74d2b05e19645f888666e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 418s] self.__getattribute__('to_'+self.format)() [ 418s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 418s] self.exec_dblatex() [ 418s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 418s] self.to_docbook() [ 418s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 418s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 418s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 418s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 418s] IndexError: tuple index out of range [ 418s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 418s] a2x: resource files: [] [ 418s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 418s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 418s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 418s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 418s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 418s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 418s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 418s] dh_auto_build: error: make -j1 returned exit code 2 [ 418s] make: *** [debian/rules:12: build] Error 25 [ 418s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 418s] ### VM INTERACTION START ### [ 419s] Powering off. [ 419s] [ 399.436252] reboot: Power down [ 419s] ### VM INTERACTION END ### [ 419s] [ 419s] old-cirrus4 failed "build osmo-pcu_1.0.0.1.8d03.202112200026.dsc" at Mon Dec 20 03:02:27 UTC 2021. [ 419s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:02:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:02:56 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff26c649bc_74d2b05e19645f888675a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gbproxy Last lines of build log: [ 432s] self.exec_dblatex() [ 432s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 432s] self.to_docbook() [ 432s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 432s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 432s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 432s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 432s] IndexError: tuple index out of range [ 432s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 432s] a2x: resource files: [] [ 432s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 432s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 432s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 432s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 432s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 432s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 432s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 432s] make[1]: *** [Makefile:377: all] Error 2 [ 432s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 432s] dh_auto_build: error: make -j1 returned exit code 2 [ 432s] make: *** [debian/rules:45: build] Error 25 [ 432s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 432s] ### VM INTERACTION START ### [ 433s] Powering off. [ 433s] [ 412.558768] reboot: Power down [ 433s] ### VM INTERACTION END ### [ 433s] [ 433s] lamb08 failed "build osmo-gbproxy_0.2.0.4.28ec0.202112200026.dsc" at Mon Dec 20 03:02:48 UTC 2021. [ 433s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:03:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:03:13 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff28bbf0ef_74d2b05e19645f888701b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 440s] self.exec_dblatex() [ 440s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 440s] self.to_docbook() [ 440s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 440s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 440s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 440s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 440s] IndexError: tuple index out of range [ 440s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 440s] a2x: resource files: [] [ 440s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 440s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 440s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 440s] make[3]: *** [Makefile:386: all-recursive] Error 1 [ 440s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 440s] make[2]: *** [Makefile:484: all-recursive] Error 1 [ 440s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 440s] make[1]: *** [Makefile:408: all] Error 2 [ 440s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 440s] dh_auto_build: error: make -j1 returned exit code 2 [ 440s] make: *** [debian/rules:14: build] Error 25 [ 440s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 440s] ### VM INTERACTION START ### [ 441s] Powering off. [ 441s] [ 419.633496] reboot: Power down [ 441s] ### VM INTERACTION END ### [ 441s] [ 441s] lamb06 failed "build osmo-remsim_1.0.0.4.0c832.202112200026.dsc" at Mon Dec 20 03:02:57 UTC 2021. [ 441s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:04:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:04:04 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff2a82a4bd_74d2b05e19645f888727b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 502s] self.exec_dblatex() [ 502s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 503s] self.to_docbook() [ 503s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 503s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 503s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 503s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 503s] IndexError: tuple index out of range [ 503s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 503s] a2x: resource files: [] [ 503s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 503s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 503s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 503s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 503s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 503s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 503s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 503s] make[1]: *** [Makefile:452: all] Error 2 [ 503s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 503s] dh_auto_build: error: make -j1 returned exit code 2 [ 503s] make: *** [debian/rules:6: build] Error 25 [ 503s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 503s] ### VM INTERACTION START ### [ 504s] Powering off. [ 504s] [ 480.627109] reboot: Power down [ 504s] ### VM INTERACTION END ### [ 504s] [ 504s] old-cirrus3 failed "build osmo-trx_1.4.0.1.424c.202112200026.dsc" at Mon Dec 20 03:04:00 UTC 2021. [ 504s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:04:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:04:04 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff2a8b74b8_74d2b05e19645f8887495@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 489s] self.exec_dblatex() [ 489s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 489s] self.to_docbook() [ 489s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 489s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 489s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 489s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 489s] IndexError: tuple index out of range [ 489s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 489s] a2x: resource files: [] [ 489s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 489s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 489s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 489s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 489s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 489s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 489s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 489s] make[1]: *** [Makefile:368: all] Error 2 [ 489s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 489s] dh_auto_build: error: make -j1 returned exit code 2 [ 489s] make: *** [debian/rules:45: build] Error 25 [ 489s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 489s] ### VM INTERACTION START ### [ 491s] Powering off. [ 491s] [ 465.401369] reboot: Power down [ 491s] ### VM INTERACTION END ### [ 491s] [ 491s] lamb28 failed "build osmo-cbc_0.2.3.202112200026.dsc" at Mon Dec 20 03:03:52 UTC 2021. [ 491s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:08:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:08:02 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff398df88e_74d2b05e19645f8889015@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 667s] self.exec_dblatex() [ 667s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 667s] self.to_docbook() [ 667s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 667s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 667s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 667s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 667s] IndexError: tuple index out of range [ 667s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 667s] a2x: resource files: [] [ 667s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 667s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 667s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 667s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 667s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 667s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 667s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 667s] make[1]: *** [Makefile:403: all] Error 2 [ 667s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 667s] dh_auto_build: error: make -j1 returned exit code 2 [ 667s] make: *** [debian/rules:12: build] Error 25 [ 667s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 667s] ### VM INTERACTION START ### [ 668s] Powering off. [ 668s] [ 590.831059] reboot: Power down [ 668s] ### VM INTERACTION END ### [ 668s] [ 668s] cloud125 failed "build libosmo-sccp_1.5.0.2.0432.202112200026.dsc" at Mon Dec 20 03:07:50 UTC 2021. [ 668s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:08:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:08:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff3d3b1e2f_74d2b05e19645f888977d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 212s] self.exec_dblatex() [ 212s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 212s] self.to_docbook() [ 212s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 212s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 212s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 212s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 212s] IndexError: tuple index out of range [ 212s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 212s] a2x: resource files: [] [ 212s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 212s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 212s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 212s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 212s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 212s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 212s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 212s] make[1]: *** [Makefile:327: all] Error 2 [ 212s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 212s] dh_auto_build: error: make -j1 returned exit code 2 [ 212s] make: *** [debian/rules:12: build] Error 25 [ 212s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 212s] ### VM INTERACTION START ### [ 213s] Powering off. [ 213s] [ 201.551628] reboot: Power down [ 213s] ### VM INTERACTION END ### [ 213s] [ 213s] goat17 failed "build osmo-sip-connector_1.6.0.202112200026.dsc" at Mon Dec 20 03:08:43 UTC 2021. [ 213s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:09:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:09:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff41372fe2_74d2b05e19645f88899da@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 824s] self.exec_dblatex() [ 824s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 824s] self.to_docbook() [ 824s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 824s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 824s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 824s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 824s] IndexError: tuple index out of range [ 824s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 824s] a2x: resource files: [] [ 824s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 824s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 824s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 824s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 824s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 824s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 824s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 824s] make[1]: *** [Makefile:392: all] Error 2 [ 824s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 824s] dh_auto_build: error: make -j1 returned exit code 2 [ 824s] make: *** [debian/rules:15: build] Error 25 [ 824s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 824s] ### VM INTERACTION START ### [ 825s] Powering off. [ 825s] [ 700.719298] reboot: Power down [ 825s] ### VM INTERACTION END ### [ 825s] [ 825s] cloud103 failed "build osmo-ggsn_1.8.0.202112200026.dsc" at Mon Dec 20 03:09:28 UTC 2021. [ 825s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:09:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:09:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff41959ac0_74d2b05e19645f889023e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 824s] self.exec_dblatex() [ 824s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 824s] self.to_docbook() [ 824s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 824s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 824s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 824s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 824s] IndexError: tuple index out of range [ 824s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 824s] a2x: resource files: [] [ 824s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 824s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 824s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 824s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 824s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 824s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 824s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 824s] make[1]: *** [Makefile:423: all] Error 2 [ 824s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 824s] dh_auto_build: error: make -j1 returned exit code 2 [ 824s] make: *** [debian/rules:17: build] Error 25 [ 824s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 824s] ### VM INTERACTION START ### [ 825s] Powering off. [ 825s] [ 699.741906] reboot: Power down [ 826s] ### VM INTERACTION END ### [ 826s] [ 826s] cloud120 failed "build osmo-mgw_1.9.0.7.bc3f.202112200026.dsc" at Mon Dec 20 03:09:27 UTC 2021. [ 826s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:15:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:15:59 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff5775835d_74d2b05e19645f8893555@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 279s] self.exec_dblatex() [ 279s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 279s] self.to_docbook() [ 279s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 279s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 279s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 279s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 279s] IndexError: tuple index out of range [ 279s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 279s] a2x: resource files: [] [ 279s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 279s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 279s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 279s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 279s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 279s] make[2]: *** [Makefile:454: all-recursive] Error 1 [ 279s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 279s] make[1]: *** [Makefile:386: all] Error 2 [ 279s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 279s] dh_auto_build: error: make -j1 returned exit code 2 [ 280s] make: *** [debian/rules:45: build] Error 25 [ 280s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 280s] ### VM INTERACTION START ### [ 281s] Powering off. [ 281s] [ 268.900389] reboot: Power down [ 281s] ### VM INTERACTION END ### [ 281s] [ 281s] goat11 failed "build osmo-bsc_1.8.0.16.260eb.202112200026.dsc" at Mon Dec 20 03:15:57 UTC 2021. [ 281s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:16:16 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:16:16 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff5966ec0b_74d2b05e19645f88936c9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 423s] self.exec_dblatex() [ 423s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 423s] self.to_docbook() [ 423s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 423s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 423s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 423s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 423s] IndexError: tuple index out of range [ 423s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 423s] a2x: resource files: [] [ 423s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 423s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 423s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 423s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 423s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 423s] make[2]: *** [Makefile:475: all-recursive] Error 1 [ 423s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 423s] make[1]: *** [Makefile:393: all] Error 2 [ 423s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 423s] dh_auto_build: error: make -j1 returned exit code 2 [ 423s] make: *** [debian/rules:9: build] Error 25 [ 423s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 423s] ### VM INTERACTION START ### [ 424s] Powering off. [ 424s] [ 412.630734] reboot: Power down [ 424s] ### VM INTERACTION END ### [ 424s] [ 424s] goat13 failed "build osmo-iuh_1.1.0.1.9b4d.202112200026.dsc" at Mon Dec 20 03:16:13 UTC 2021. [ 424s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:17:58 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:17:58 +0000 Subject: Build failure of network:osmocom:nightly/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff5f22357c_74d2b05e19645f88949a4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-smlc Last lines of build log: [ 505s] self.exec_dblatex() [ 505s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 505s] self.to_docbook() [ 505s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 505s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 505s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 505s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 505s] IndexError: tuple index out of range [ 505s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 505s] a2x: resource files: [] [ 505s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 505s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 505s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 505s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 505s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 505s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 505s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 505s] make[1]: *** [Makefile:377: all] Error 2 [ 505s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 505s] dh_auto_build: error: make -j1 returned exit code 2 [ 505s] make: *** [debian/rules:45: build] Error 25 [ 505s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 505s] ### VM INTERACTION START ### [ 507s] Powering off. [ 507s] [ 480.523269] reboot: Power down [ 507s] ### VM INTERACTION END ### [ 507s] [ 507s] lamb23 failed "build osmo-smlc_0.2.1.1.5b7f.202112200026.dsc" at Mon Dec 20 03:17:49 UTC 2021. [ 507s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:21:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:21:05 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff6a32f8b2_74d2b05e19645f88959a9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 243s] self.exec_dblatex() [ 243s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 243s] self.to_docbook() [ 243s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 243s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 243s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 243s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 243s] IndexError: tuple index out of range [ 243s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 243s] a2x: resource files: [] [ 243s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 243s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 243s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 243s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 243s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 243s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 243s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 243s] make[1]: *** [Makefile:394: all] Error 2 [ 243s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 243s] dh_auto_build: error: make -j1 returned exit code 2 [ 243s] make: *** [debian/rules:45: build] Error 25 [ 243s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 243s] ### VM INTERACTION START ### [ 244s] Powering off. [ 244s] [ 233.213496] reboot: Power down [ 244s] ### VM INTERACTION END ### [ 244s] [ 244s] goat13 failed "build osmo-sgsn_1.8.0.2.57425.202112200026.dsc" at Mon Dec 20 03:20:59 UTC 2021. [ 244s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:21:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:21:22 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff6c31fd6a_74d2b05e19645f889621b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 261s] self.exec_dblatex() [ 261s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 261s] self.to_docbook() [ 261s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 261s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 261s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 261s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 261s] IndexError: tuple index out of range [ 261s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 261s] a2x: resource files: [] [ 261s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 261s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 261s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 261s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 261s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 261s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 261s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 261s] make[1]: *** [Makefile:402: all] Error 2 [ 261s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 261s] dh_auto_build: error: make -j1 returned exit code 2 [ 261s] make: *** [debian/rules:45: build] Error 25 [ 261s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 261s] ### VM INTERACTION START ### [ 262s] Powering off. [ 262s] [ 250.668323] reboot: Power down [ 262s] ### VM INTERACTION END ### [ 262s] [ 262s] goat17 failed "build osmo-msc_1.8.0.12.2ee27.202112200026.dsc" at Mon Dec 20 03:21:16 UTC 2021. [ 262s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:31:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:31:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bff91a4f3b5_74d2b05e19645f8899213@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 833s] self.exec_dblatex() [ 833s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 833s] self.to_docbook() [ 833s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 833s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 833s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 833s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 833s] IndexError: tuple index out of range [ 833s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnodeb-usermanual.adoc'] [ 833s] a2x: resource files: [] [ 833s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 833s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnodeb-usermanual.pdf] Error 1 [ 833s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 833s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 833s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 833s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 833s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 833s] make[1]: *** [Makefile:394: all] Error 2 [ 833s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 833s] dh_auto_build: error: make -j1 returned exit code 2 [ 833s] make: *** [debian/rules:45: build] Error 25 [ 833s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 833s] ### VM INTERACTION START ### [ 834s] Powering off. [ 834s] [ 734.134825] reboot: Power down [ 834s] ### VM INTERACTION END ### [ 834s] [ 834s] lamb59 failed "build osmo-hnodeb_0.0.1.17.272f.202112200026.dsc" at Mon Dec 20 03:31:22 UTC 2021. [ 834s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:44:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:44:36 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bffc2971b85_74d2b05e19645f89009dd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 454s] self.__getattribute__('to_'+self.format)() [ 454s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 454s] self.exec_dblatex() [ 454s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 454s] self.to_docbook() [ 454s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 454s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 454s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 454s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 454s] IndexError: tuple index out of range [ 454s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 454s] a2x: resource files: [] [ 454s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 454s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 454s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 454s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 454s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 454s] make[1]: *** [Makefile:363: all] Error 2 [ 454s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 454s] dh_auto_build: error: make -j1 returned exit code 2 [ 454s] make: *** [debian/rules:5: binary] Error 25 [ 454s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 454s] ### VM INTERACTION START ### [ 455s] Powering off. [ 455s] [ 432.555874] reboot: Power down [ 455s] ### VM INTERACTION END ### [ 455s] [ 455s] lamb07 failed "build osmo-gsm-manuals-dev_1.2.0.dsc" at Mon Dec 20 03:44:30 UTC 2021. [ 455s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:48:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:48:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bffd3360bca_74d2b05e19645f89018b4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 230s] self.exec_dblatex() [ 230s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 230s] self.to_docbook() [ 230s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 230s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 230s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 230s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 230s] IndexError: tuple index out of range [ 230s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 230s] a2x: resource files: [] [ 230s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 230s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 230s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 230s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 230s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 230s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 230s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 230s] make[1]: *** [Makefile:392: all] Error 2 [ 230s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 230s] dh_auto_build: error: make -j1 returned exit code 2 [ 230s] make: *** [debian/rules:15: build] Error 25 [ 230s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 230s] ### VM INTERACTION START ### [ 231s] Powering off. [ 231s] [ 219.476284] reboot: Power down [ 231s] ### VM INTERACTION END ### [ 231s] [ 231s] goat11 failed "build osmo-ggsn_1.8.0.dsc" at Mon Dec 20 03:48:45 UTC 2021. [ 231s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:48:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:48:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bffd3383a77_74d2b05e19645f8901999@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 221s] self.exec_dblatex() [ 221s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 221s] self.to_docbook() [ 221s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 221s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 221s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 221s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 221s] IndexError: tuple index out of range [ 221s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 221s] a2x: resource files: [] [ 221s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 221s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 221s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 221s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 221s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 221s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 221s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 221s] make[1]: *** [Makefile:377: all] Error 2 [ 221s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 221s] dh_auto_build: error: make -j1 returned exit code 2 [ 221s] make: *** [debian/rules:45: build] Error 25 [ 221s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 221s] ### VM INTERACTION START ### [ 222s] Powering off. [ 222s] [ 210.230642] reboot: Power down [ 222s] ### VM INTERACTION END ### [ 222s] [ 222s] goat11 failed "build osmo-gbproxy_0.2.0.dsc" at Mon Dec 20 03:48:45 UTC 2021. [ 222s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:49:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:49:25 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bffd5519c09_74d2b05e19645f89023b8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 257s] self.exec_dblatex() [ 257s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 257s] self.to_docbook() [ 257s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 257s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 257s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 257s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 257s] IndexError: tuple index out of range [ 257s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 257s] a2x: resource files: [] [ 257s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 257s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 257s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 257s] make[3]: *** [Makefile:386: all-recursive] Error 1 [ 257s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 257s] make[2]: *** [Makefile:484: all-recursive] Error 1 [ 257s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 257s] make[1]: *** [Makefile:408: all] Error 2 [ 257s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 257s] dh_auto_build: error: make -j1 returned exit code 2 [ 257s] make: *** [debian/rules:14: build] Error 25 [ 257s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 257s] ### VM INTERACTION START ### [ 258s] Powering off. [ 258s] [ 246.969377] reboot: Power down [ 258s] ### VM INTERACTION END ### [ 258s] [ 258s] goat19 failed "build osmo-remsim_1.0.0.dsc" at Mon Dec 20 03:49:24 UTC 2021. [ 258s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:49:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:49:59 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bffd7056414_74d2b05e19645f8902465@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 283s] self.exec_dblatex() [ 283s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 283s] self.to_docbook() [ 283s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 283s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 283s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 283s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 283s] IndexError: tuple index out of range [ 283s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 283s] a2x: resource files: [] [ 283s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 283s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 283s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 283s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 283s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 283s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 283s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 283s] make[1]: *** [Makefile:423: all] Error 2 [ 283s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 283s] dh_auto_build: error: make -j1 returned exit code 2 [ 283s] make: *** [debian/rules:17: build] Error 25 [ 283s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 283s] ### VM INTERACTION START ### [ 285s] Powering off. [ 285s] [ 272.393666] reboot: Power down [ 285s] ### VM INTERACTION END ### [ 285s] [ 285s] sheep83 failed "build osmo-mgw_1.9.0.dsc" at Mon Dec 20 03:49:43 UTC 2021. [ 285s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:50:16 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:50:16 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bffd905d828_74d2b05e19645f8902710@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 295s] self.exec_dblatex() [ 295s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 295s] self.to_docbook() [ 295s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 295s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 295s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 295s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 295s] IndexError: tuple index out of range [ 295s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 295s] a2x: resource files: [] [ 295s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 295s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 295s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 295s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 295s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 295s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 295s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 295s] make[1]: *** [Makefile:452: all] Error 2 [ 295s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 295s] dh_auto_build: error: make -j1 returned exit code 2 [ 295s] make: *** [debian/rules:6: build] Error 25 [ 295s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 295s] ### VM INTERACTION START ### [ 296s] Powering off. [ 296s] [ 284.229577] reboot: Power down [ 296s] ### VM INTERACTION END ### [ 296s] [ 296s] goat11 failed "build osmo-trx_1.4.0.dsc" at Mon Dec 20 03:50:14 UTC 2021. [ 296s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:55:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:55:56 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bffed67fac4_74d2b05e19645f890345d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 631s] self.exec_dblatex() [ 631s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 631s] self.to_docbook() [ 631s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 631s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 631s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 631s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 631s] IndexError: tuple index out of range [ 631s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 631s] a2x: resource files: [] [ 631s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 632s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 632s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 632s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 632s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 632s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 632s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 632s] make[1]: *** [Makefile:410: all] Error 2 [ 632s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 632s] dh_auto_build: error: make -j1 returned exit code 2 [ 632s] make: *** [debian/rules:7: build] Error 25 [ 632s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 632s] ### VM INTERACTION START ### [ 633s] Powering off. [ 633s] [ 609.305332] reboot: Power down [ 633s] ### VM INTERACTION END ### [ 633s] [ 633s] lamb58 failed "build osmo-hlr_1.4.0.dsc" at Mon Dec 20 03:55:43 UTC 2021. [ 633s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:56:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:56:30 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bffef6743e3_74d2b05e19645f89035fc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 687s] self.exec_dblatex() [ 687s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 687s] self.to_docbook() [ 687s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 687s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 687s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 687s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 687s] IndexError: tuple index out of range [ 687s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 687s] a2x: resource files: [] [ 687s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 687s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 687s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 687s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 687s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 687s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 687s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 687s] make[1]: *** [Makefile:368: all] Error 2 [ 687s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 687s] dh_auto_build: error: make -j1 returned exit code 2 [ 687s] make: *** [debian/rules:45: build] Error 25 [ 687s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 687s] ### VM INTERACTION START ### [ 688s] Powering off. [ 688s] [ 619.999128] reboot: Power down [ 689s] ### VM INTERACTION END ### [ 689s] [ 689s] cloud126 failed "build osmo-cbc_0.2.3.dsc" at Mon Dec 20 03:56:20 UTC 2021. [ 689s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:57:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:57:21 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bfff318b460_74d2b05e19645f8903710@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 738s] self.exec_dblatex() [ 738s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 738s] self.to_docbook() [ 738s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 738s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 738s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 738s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 738s] IndexError: tuple index out of range [ 738s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 738s] a2x: resource files: [] [ 738s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 738s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 738s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 738s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 738s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 738s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 738s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 738s] make[1]: *** [Makefile:403: all] Error 2 [ 738s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 738s] dh_auto_build: error: make -j1 returned exit code 2 [ 738s] make: *** [debian/rules:12: build] Error 25 [ 738s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 738s] ### VM INTERACTION START ### [ 739s] Powering off. [ 739s] [ 697.563224] reboot: Power down [ 739s] ### VM INTERACTION END ### [ 739s] [ 739s] cloud121 failed "build libosmo-sccp_1.5.0.dsc" at Mon Dec 20 03:57:19 UTC 2021. [ 739s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 03:57:55 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 03:57:55 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bfff514a266_74d2b05e19645f89038fa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 721s] self.exec_dblatex() [ 721s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 721s] self.to_docbook() [ 721s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 721s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 721s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 721s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 721s] IndexError: tuple index out of range [ 721s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 721s] a2x: resource files: [] [ 721s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 721s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 721s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 721s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 721s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 721s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 721s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 721s] make[1]: *** [Makefile:327: all] Error 2 [ 721s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 721s] dh_auto_build: error: make -j1 returned exit code 2 [ 721s] make: *** [debian/rules:12: build] Error 25 [ 721s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 721s] ### VM INTERACTION START ### [ 722s] Powering off. [ 722s] [ 649.828282][ T341] reboot: Power down [ 722s] ### VM INTERACTION END ### [ 722s] [ 722s] lamb01 failed "build osmo-sip-connector_1.6.0.dsc" at Mon Dec 20 03:57:51 UTC 2021. [ 722s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 04:00:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 04:00:28 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61bfffe7788c9_74d2b05e19645f8904377@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 895s] self.__getattribute__('to_'+self.format)() [ 895s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 895s] self.exec_dblatex() [ 895s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 895s] self.to_docbook() [ 895s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 895s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 895s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 895s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 895s] IndexError: tuple index out of range [ 895s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 895s] a2x: resource files: [] [ 895s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 895s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 895s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 895s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 895s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 895s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 895s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 895s] dh_auto_build: error: make -j1 returned exit code 2 [ 895s] make: *** [debian/rules:12: build] Error 25 [ 895s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 895s] ### VM INTERACTION START ### [ 896s] Powering off. [ 896s] [ 799.138936] reboot: Power down [ 896s] ### VM INTERACTION END ### [ 896s] [ 896s] lamb57 failed "build osmo-pcu_1.0.0.dsc" at Mon Dec 20 04:00:14 UTC 2021. [ 896s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 04:01:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 04:01:02 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0000270275_74d2b05e19645f890449@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 199s] self.exec_dblatex() [ 199s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 199s] self.to_docbook() [ 199s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 199s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 199s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 199s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 199s] IndexError: tuple index out of range [ 199s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 199s] a2x: resource files: [] [ 199s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 199s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 199s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 199s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 199s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 199s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 199s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 199s] make[1]: *** [Makefile:377: all] Error 2 [ 199s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 199s] dh_auto_build: error: make -j1 returned exit code 2 [ 199s] make: *** [debian/rules:45: build] Error 25 [ 199s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 199s] ### VM INTERACTION START ### [ 200s] Powering off. [ 200s] [ 189.974438] reboot: Power down [ 201s] ### VM INTERACTION END ### [ 201s] [ 201s] goat07 failed "build osmo-smlc_0.2.1.dsc" at Mon Dec 20 04:00:57 UTC 2021. [ 201s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 04:04:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 04:04:26 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c000d75f14e_74d2b05e19645f8905119@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 404s] self.exec_dblatex() [ 404s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 404s] self.to_docbook() [ 404s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 404s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 404s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 404s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 404s] IndexError: tuple index out of range [ 404s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 404s] a2x: resource files: [] [ 404s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 404s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 404s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 404s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 404s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 404s] make[2]: *** [Makefile:475: all-recursive] Error 1 [ 404s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 404s] make[1]: *** [Makefile:393: all] Error 2 [ 404s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 404s] dh_auto_build: error: make -j1 returned exit code 2 [ 404s] make: *** [debian/rules:9: build] Error 25 [ 404s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 404s] ### VM INTERACTION START ### [ 405s] Powering off. [ 405s] [ 393.508312] reboot: Power down [ 405s] ### VM INTERACTION END ### [ 405s] [ 405s] goat17 failed "build osmo-iuh_1.1.0.dsc" at Mon Dec 20 04:04:16 UTC 2021. [ 405s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 04:08:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 04:08:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c001c623b8d_74d2b05e19645f8906368@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 227s] self.exec_dblatex() [ 227s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 227s] self.to_docbook() [ 227s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 227s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 227s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 227s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 227s] IndexError: tuple index out of range [ 227s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 227s] a2x: resource files: [] [ 227s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 227s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 227s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 227s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 227s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 227s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 227s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 227s] make[1]: *** [Makefile:394: all] Error 2 [ 227s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 227s] dh_auto_build: error: make -j1 returned exit code 2 [ 227s] make: *** [debian/rules:45: build] Error 25 [ 227s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 227s] ### VM INTERACTION START ### [ 228s] Powering off. [ 228s] [ 216.766119] reboot: Power down [ 228s] ### VM INTERACTION END ### [ 228s] [ 228s] goat19 failed "build osmo-sgsn_1.8.0.dsc" at Mon Dec 20 04:08:13 UTC 2021. [ 228s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 04:09:32 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 04:09:32 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0020327608_74d2b05e19645f8906957@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 699s] self.exec_dblatex() [ 699s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 699s] self.to_docbook() [ 699s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 699s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 699s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 699s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 699s] IndexError: tuple index out of range [ 699s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 699s] a2x: resource files: [] [ 699s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 699s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 699s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 699s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 699s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 699s] make[2]: *** [Makefile:454: all-recursive] Error 1 [ 699s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 699s] make[1]: *** [Makefile:386: all] Error 2 [ 699s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 699s] dh_auto_build: error: make -j1 returned exit code 2 [ 699s] make: *** [debian/rules:45: build] Error 25 [ 699s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 699s] ### VM INTERACTION START ### [ 700s] Powering off. [ 700s] [ 663.083845] reboot: Power down [ 700s] ### VM INTERACTION END ### [ 700s] [ 700s] build83 failed "build osmo-bsc_1.8.0.dsc" at Mon Dec 20 04:09:21 UTC 2021. [ 700s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 04:13:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 04:13:47 +0000 Subject: Build failure of network:osmocom:latest/osmo-hnodeb in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c00312b0b62_74d2b05e19645f8908550@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hnodeb/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hnodeb failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hnodeb Last lines of build log: [ 550s] self.exec_dblatex() [ 550s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 550s] self.to_docbook() [ 550s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 550s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 550s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 550s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 550s] IndexError: tuple index out of range [ 550s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnodeb-usermanual.adoc'] [ 550s] a2x: resource files: [] [ 550s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 550s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnodeb-usermanual.pdf] Error 1 [ 550s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 550s] make[3]: *** [Makefile:389: all-recursive] Error 1 [ 550s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 550s] make[2]: *** [Makefile:458: all-recursive] Error 1 [ 550s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 550s] make[1]: *** [Makefile:390: all] Error 2 [ 550s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 550s] dh_auto_build: error: make -j1 returned exit code 2 [ 550s] make: *** [debian/rules:45: build] Error 25 [ 550s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 550s] ### VM INTERACTION START ### [ 551s] Powering off. [ 551s] [ 511.661451] reboot: Power down [ 551s] ### VM INTERACTION END ### [ 551s] [ 551s] build79 failed "build osmo-hnodeb_0.0.1.dsc" at Mon Dec 20 04:13:44 UTC 2021. [ 551s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 04:18:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 04:18:36 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c004202f088_74d2b05e19645f8910645@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 819s] self.exec_dblatex() [ 819s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 819s] self.to_docbook() [ 819s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 819s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 819s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 819s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 819s] IndexError: tuple index out of range [ 819s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 819s] a2x: resource files: [] [ 819s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 819s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 819s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 819s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 819s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 820s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 820s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 820s] make[1]: *** [Makefile:402: all] Error 2 [ 820s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 820s] dh_auto_build: error: make -j1 returned exit code 2 [ 820s] make: *** [debian/rules:45: build] Error 25 [ 820s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 820s] ### VM INTERACTION START ### [ 821s] Powering off. [ 821s] [ 720.556402] reboot: Power down [ 821s] ### VM INTERACTION END ### [ 821s] [ 821s] cloud124 failed "build osmo-msc_1.8.0.dsc" at Mon Dec 20 04:18:22 UTC 2021. [ 821s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 08:57:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 08:57:43 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61c0459e82dce_74d2b05e19645f8954999@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/xUbuntu_18.04/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 125s] #define VERSION "0.2.3" [ 125s] #define STDC_HEADERS 1 [ 125s] #define HAVE_SYS_TYPES_H 1 [ 125s] #define HAVE_SYS_STAT_H 1 [ 125s] #define HAVE_STDLIB_H 1 [ 125s] #define HAVE_STRING_H 1 [ 125s] #define HAVE_MEMORY_H 1 [ 125s] #define HAVE_STRINGS_H 1 [ 125s] #define HAVE_INTTYPES_H 1 [ 125s] #define HAVE_STDINT_H 1 [ 125s] #define HAVE_UNISTD_H 1 [ 125s] #define HAVE_DLFCN_H 1 [ 125s] #define LT_OBJDIR ".libs/" [ 125s] [ 125s] configure: exit 1 [ 125s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 125s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 125s] make[1]: *** [override_dh_auto_configure] Error 2 [ 125s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 125s] debian/rules:45: recipe for target 'build' failed [ 125s] make: *** [build] Error 2 [ 125s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 125s] ### VM INTERACTION START ### [ 128s] [ 121.098301] sysrq: Power Off [ 128s] [ 121.100539] reboot: Power down [ 128s] ### VM INTERACTION END ### [ 128s] [ 128s] goat17 failed "build osmo-cbc_0.2.3.dsc" at Mon Dec 20 08:57:34 UTC 2021. [ 128s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 08:59:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 08:59:42 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in xUbuntu_18.04/i586 In-Reply-To: References: Message-ID: <61c04618a7d2c_74d2b05e19645f89552dd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/xUbuntu_18.04/i586 Package network:osmocom:latest/osmo-cbc failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 254s] #define VERSION "0.2.3" [ 254s] #define STDC_HEADERS 1 [ 254s] #define HAVE_SYS_TYPES_H 1 [ 254s] #define HAVE_SYS_STAT_H 1 [ 254s] #define HAVE_STDLIB_H 1 [ 254s] #define HAVE_STRING_H 1 [ 254s] #define HAVE_MEMORY_H 1 [ 254s] #define HAVE_STRINGS_H 1 [ 254s] #define HAVE_INTTYPES_H 1 [ 254s] #define HAVE_STDINT_H 1 [ 254s] #define HAVE_UNISTD_H 1 [ 254s] #define HAVE_DLFCN_H 1 [ 254s] #define LT_OBJDIR ".libs/" [ 254s] [ 254s] configure: exit 1 [ 254s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 254s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 254s] make[1]: *** [override_dh_auto_configure] Error 2 [ 254s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 254s] debian/rules:45: recipe for target 'build' failed [ 254s] make: *** [build] Error 2 [ 254s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 254s] ### VM INTERACTION START ### [ 257s] [ 244.888303] sysrq: Power Off [ 257s] [ 244.892752] reboot: Power down [ 257s] ### VM INTERACTION END ### [ 257s] [ 257s] lamb06 failed "build osmo-cbc_0.2.3.dsc" at Mon Dec 20 08:59:27 UTC 2021. [ 257s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 08:59:59 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 08:59:59 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61c04618ed8bf_74d2b05e19645f89553fa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/xUbuntu_18.04/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 260s] #define HAVE_SYS_TYPES_H 1 [ 260s] #define HAVE_SYS_STAT_H 1 [ 260s] #define HAVE_STDLIB_H 1 [ 260s] #define HAVE_STRING_H 1 [ 260s] #define HAVE_MEMORY_H 1 [ 260s] #define HAVE_STRINGS_H 1 [ 260s] #define HAVE_INTTYPES_H 1 [ 260s] #define HAVE_STDINT_H 1 [ 260s] #define HAVE_UNISTD_H 1 [ 260s] #define HAVE_DLFCN_H 1 [ 260s] #define LT_OBJDIR ".libs/" [ 260s] #define PACKAGE "osmo-remsim" [ 260s] #define VERSION "1.0.0" [ 260s] [ 260s] configure: exit 1 [ 260s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 260s] debian/rules:17: recipe for target 'override_dh_auto_configure' failed [ 260s] make[1]: *** [override_dh_auto_configure] Error 2 [ 260s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 260s] debian/rules:14: recipe for target 'build' failed [ 260s] make: *** [build] Error 2 [ 260s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 260s] ### VM INTERACTION START ### [ 263s] [ 249.204501] sysrq: Power Off [ 263s] [ 249.211501] reboot: Power down [ 263s] ### VM INTERACTION END ### [ 263s] [ 263s] lamb22 failed "build osmo-remsim_1.0.0.dsc" at Mon Dec 20 08:59:48 UTC 2021. [ 263s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 08:59:42 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 08:59:42 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in xUbuntu_18.04/i586 In-Reply-To: References: Message-ID: <61c0461865c41_74d2b05e19645f895511b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/xUbuntu_18.04/i586 Package network:osmocom:latest/osmo-remsim failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 261s] #define HAVE_SYS_TYPES_H 1 [ 261s] #define HAVE_SYS_STAT_H 1 [ 261s] #define HAVE_STDLIB_H 1 [ 261s] #define HAVE_STRING_H 1 [ 261s] #define HAVE_MEMORY_H 1 [ 261s] #define HAVE_STRINGS_H 1 [ 261s] #define HAVE_INTTYPES_H 1 [ 261s] #define HAVE_STDINT_H 1 [ 261s] #define HAVE_UNISTD_H 1 [ 261s] #define HAVE_DLFCN_H 1 [ 261s] #define LT_OBJDIR ".libs/" [ 261s] #define PACKAGE "osmo-remsim" [ 261s] #define VERSION "1.0.0" [ 261s] [ 261s] configure: exit 1 [ 261s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 261s] debian/rules:17: recipe for target 'override_dh_auto_configure' failed [ 261s] make[1]: *** [override_dh_auto_configure] Error 2 [ 261s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 261s] debian/rules:14: recipe for target 'build' failed [ 261s] make: *** [build] Error 2 [ 261s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 261s] ### VM INTERACTION START ### [ 264s] [ 252.066394] sysrq: Power Off [ 264s] [ 252.071018] reboot: Power down [ 265s] ### VM INTERACTION END ### [ 265s] [ 265s] lamb06 failed "build osmo-remsim_1.0.0.dsc" at Mon Dec 20 08:59:35 UTC 2021. [ 265s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 09:03:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 09:03:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61c046cb58253_74d2b05e19645f8955532@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/xUbuntu_18.04/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 127s] #define VERSION "0.2.3" [ 127s] #define STDC_HEADERS 1 [ 127s] #define HAVE_SYS_TYPES_H 1 [ 127s] #define HAVE_SYS_STAT_H 1 [ 127s] #define HAVE_STDLIB_H 1 [ 127s] #define HAVE_STRING_H 1 [ 127s] #define HAVE_MEMORY_H 1 [ 127s] #define HAVE_STRINGS_H 1 [ 127s] #define HAVE_INTTYPES_H 1 [ 127s] #define HAVE_STDINT_H 1 [ 127s] #define HAVE_UNISTD_H 1 [ 127s] #define HAVE_DLFCN_H 1 [ 127s] #define LT_OBJDIR ".libs/" [ 127s] [ 127s] configure: exit 1 [ 127s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 127s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 127s] make[1]: *** [override_dh_auto_configure] Error 2 [ 127s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 127s] debian/rules:45: recipe for target 'build' failed [ 127s] make: *** [build] Error 2 [ 127s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 127s] ### VM INTERACTION START ### [ 130s] [ 122.939335] sysrq: Power Off [ 130s] [ 122.941558] reboot: Power down [ 130s] ### VM INTERACTION END ### [ 130s] [ 130s] goat17 failed "build osmo-cbc_0.2.3.dsc" at Mon Dec 20 09:02:54 UTC 2021. [ 130s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 09:07:38 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 09:07:38 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in xUbuntu_18.04/i586 In-Reply-To: References: Message-ID: <61c047db66f3_74d2b05e19645f895628e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/xUbuntu_18.04/i586 Package network:osmocom:latest/osmo-cbc failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 249s] #define VERSION "0.2.3" [ 249s] #define STDC_HEADERS 1 [ 249s] #define HAVE_SYS_TYPES_H 1 [ 249s] #define HAVE_SYS_STAT_H 1 [ 249s] #define HAVE_STDLIB_H 1 [ 249s] #define HAVE_STRING_H 1 [ 249s] #define HAVE_MEMORY_H 1 [ 249s] #define HAVE_STRINGS_H 1 [ 249s] #define HAVE_INTTYPES_H 1 [ 249s] #define HAVE_STDINT_H 1 [ 249s] #define HAVE_UNISTD_H 1 [ 249s] #define HAVE_DLFCN_H 1 [ 249s] #define LT_OBJDIR ".libs/" [ 249s] [ 249s] configure: exit 1 [ 249s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 249s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 249s] make[1]: *** [override_dh_auto_configure] Error 2 [ 249s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 249s] debian/rules:45: recipe for target 'build' failed [ 249s] make: *** [build] Error 2 [ 249s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 249s] ### VM INTERACTION START ### [ 252s] [ 238.126460] sysrq: Power Off [ 252s] [ 238.137525] reboot: Power down [ 252s] ### VM INTERACTION END ### [ 252s] [ 252s] old-cirrus2 failed "build osmo-cbc_0.2.3.dsc" at Mon Dec 20 09:07:26 UTC 2021. [ 252s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 09:10:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 09:10:11 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61c0488e43c9f_74d2b05e19645f895752b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 149s] #define HAVE_SYS_TYPES_H 1 [ 149s] #define HAVE_SYS_STAT_H 1 [ 149s] #define HAVE_STDLIB_H 1 [ 149s] #define HAVE_STRING_H 1 [ 149s] #define HAVE_MEMORY_H 1 [ 149s] #define HAVE_STRINGS_H 1 [ 149s] #define HAVE_INTTYPES_H 1 [ 149s] #define HAVE_STDINT_H 1 [ 149s] #define HAVE_UNISTD_H 1 [ 149s] #define HAVE_DLFCN_H 1 [ 149s] #define LT_OBJDIR ".libs/" [ 149s] #define PACKAGE "osmo-remsim" [ 149s] #define VERSION "1.0.0.4-0c832" [ 149s] [ 149s] configure: exit 1 [ 149s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 149s] debian/rules:17: recipe for target 'override_dh_auto_configure' failed [ 149s] make[1]: *** [override_dh_auto_configure] Error 2 [ 149s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 149s] debian/rules:14: recipe for target 'build' failed [ 149s] make: *** [build] Error 2 [ 149s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 149s] ### VM INTERACTION START ### [ 152s] [ 144.599208] sysrq: Power Off [ 152s] [ 144.600351] reboot: Power down [ 152s] ### VM INTERACTION END ### [ 152s] [ 152s] build70 failed "build osmo-remsim_1.0.0.4.0c832.202112200026.dsc" at Mon Dec 20 09:09:56 UTC 2021. [ 152s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 09:13:01 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 09:13:01 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61c0492291c3d_74d2b05e19645f8961573@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 313s] #define VERSION "0.2.3" [ 313s] #define STDC_HEADERS 1 [ 313s] #define HAVE_SYS_TYPES_H 1 [ 313s] #define HAVE_SYS_STAT_H 1 [ 313s] #define HAVE_STDLIB_H 1 [ 313s] #define HAVE_STRING_H 1 [ 313s] #define HAVE_MEMORY_H 1 [ 313s] #define HAVE_STRINGS_H 1 [ 313s] #define HAVE_INTTYPES_H 1 [ 313s] #define HAVE_STDINT_H 1 [ 313s] #define HAVE_UNISTD_H 1 [ 313s] #define HAVE_DLFCN_H 1 [ 313s] #define LT_OBJDIR ".libs/" [ 313s] [ 313s] configure: exit 1 [ 313s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 313s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 313s] make[1]: *** [override_dh_auto_configure] Error 2 [ 313s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 313s] debian/rules:45: recipe for target 'build' failed [ 313s] make: *** [build] Error 2 [ 313s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 313s] ### VM INTERACTION START ### [ 316s] [ 301.241382][ T402] sysrq: Power Off [ 316s] [ 301.244550][ T16] reboot: Power down [ 316s] ### VM INTERACTION END ### [ 316s] [ 316s] lamb01 failed "build osmo-cbc_0.2.3.202112200026.dsc" at Mon Dec 20 09:12:45 UTC 2021. [ 316s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:35:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:35:51 +0000 Subject: Change in osmo-bsc[master]: log: always include timeouts in FSM transition logging In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26609 ) Change subject: log: always include timeouts in FSM transition logging ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I94b7dc4d9e5e45dc731bcb3a843ede9fb6cc0839 Gerrit-Change-Number: 26609 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:35:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:36:50 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:36:50 +0000 Subject: Change in osmo-bsc[master]: lchan/gscon: always clear both cross ref pointers In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26610 ) Change subject: lchan/gscon: always clear both cross ref pointers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idbfe4672233ba8105eff5ba77ee07fd871358255 Gerrit-Change-Number: 26610 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:36:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:37:22 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:37:22 +0000 Subject: Change in osmo-bsc[master]: lcs: fix bsc_subscr use_count leak In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26611 ) Change subject: lcs: fix bsc_subscr use_count leak ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibbfbfe766eafe42c78048ec5b3b503a11ef5535d Gerrit-Change-Number: 26611 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:37:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:38:06 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:38:06 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 1/n: store clear cause in gscon In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26612 ) Change subject: fix gscon clear 1/n: store clear cause in gscon ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib6432746040899129d1d73ae8dc59add2d88a915 Gerrit-Change-Number: 26612 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:38:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:38:12 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:38:12 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 2/n: proper state transition to ST_CLEARING In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26613 ) Change subject: fix gscon clear 2/n: proper state transition to ST_CLEARING ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I234b2a754d0c98031056981823cdbc187e977741 Gerrit-Change-Number: 26613 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:38:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:43:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:43:15 +0000 Subject: Change in osmo-bsc[master]: fix gscon clear 3/n: separate state for SCCP RLSD In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26614 ) Change subject: fix gscon clear 3/n: separate state for SCCP RLSD ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Fix linter https://gerrit.osmocom.org/c/osmo-bsc/+/26614/2/src/osmo-bsc/bsc_subscr_conn_fsm.c File src/osmo-bsc/bsc_subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26614/2/src/osmo-bsc/bsc_subscr_conn_fsm.c at 190 PS2, Line 190: conn_fsm_state_chg(ST_WAIT_SCCP_RLSD); will you actually ever receive an SCCP RLSD in that case? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26614 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie975117d37f38ba853589dc7f8d3e94f8f9586b2 Gerrit-Change-Number: 26614 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:43:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:44:07 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:44:07 +0000 Subject: Change in osmo-bsc[master]: gscon clear: without SCCP conn, no need to wait for RLSD timeout In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26615 ) Change subject: gscon clear: without SCCP conn, no need to wait for RLSD timeout ...................................................................... Patch Set 2: Code-Review+1 I think this patch answers my question in previous patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8c8537acf6b47b121903197608636c43ae601a57 Gerrit-Change-Number: 26615 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:44:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:45:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:45:02 +0000 Subject: Change in libosmocore[master]: PFCP: add DLPFCP and osmo-upf port numbers In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26606 ) Change subject: PFCP: add DLPFCP and osmo-upf port numbers ...................................................................... Patch Set 1: Code-Review+1 Fix jenkins -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0a46b147ec6a76d909df28136cfd2b764b2c75ea Gerrit-Change-Number: 26606 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:45:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:45:23 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:45:23 +0000 Subject: Change in libosmocore[master]: ports.h: add osmo-pfcp-tool In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26607 ) Change subject: ports.h: add osmo-pfcp-tool ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8a5f437d934b9bda11ea593b50bd18c7d5d71ce9 Gerrit-Change-Number: 26607 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:45:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:49:09 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:49:09 +0000 Subject: Change in libosmocore[master]: add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26608 ) Change subject: add osmo_sockaddr_to_str_c(), osmo_sockaddr_to_str_buf2() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26608/1/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/26608/1/src/socket.c at 1827 PS1, Line 1827: /*! string-format a given osmo_sockaddr address into a user-supplied buffer. I think you are changing how this function used to worked here, and imho it's unexpected. I'd rather return a string filling the buffer as much as possible rather than returning NULL, similar to strlcpy, etc. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I12771bf8a021e6785217b1faad03c09ec1cfef0e Gerrit-Change-Number: 26608 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:49:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:50:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:50:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: properly clean up conn after each test In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26621 ) Change subject: bsc: properly clean up conn after each test ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26621 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9396efcabc085d2850244c6468b83c5f3a3ff3a2 Gerrit-Change-Number: 26621 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:50:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:50:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:50:46 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: import In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26622 ) Change subject: contrib/obs-mirror: import ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3f47cddbcee6c9b85fde77a039dcd5b54dd89f2d Gerrit-Change-Number: 26622 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:50:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:51:10 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:51:10 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: adjust includelist path In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26623 ) Change subject: contrib/obs-mirror: adjust includelist path ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4c6a6e424fd727de4e8058c916aa7eb43e7eb4b2 Gerrit-Change-Number: 26623 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:51:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:52:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:52:03 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: stop script on rsync error In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26624 ) Change subject: contrib/obs-mirror: stop script on rsync error ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icfefd8e4bae1fd6c73445c7427aaa842c0391b2d Gerrit-Change-Number: 26624 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:52:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:52:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:52:37 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: redirect all output to a log file In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26625 ) Change subject: contrib/obs-mirror: redirect all output to a log file ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie56c901877a3b0a1ad566cb243ab698f292407d5 Gerrit-Change-Number: 26625 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:52:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:52:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:52:48 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: log DRY var in rm script In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26626 ) Change subject: contrib/obs-mirror: log DRY var in rm script ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I705e52030d538e6d86c72f2bccb0eb97e6dab1de Gerrit-Change-Number: 26626 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:52:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:54:06 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:54:06 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: fix ho-out test failures: cleanup neighbor cfg cruft In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26616 ) Change subject: bsc: fix ho-out test failures: cleanup neighbor cfg cruft ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26616 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a7c97a47a06abb59c0d89638c6b503ab66eb359 Gerrit-Change-Number: 26616 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:54:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:54:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:54:40 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: make perform_clear() work when VTY is not initialized In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617 ) Change subject: bsc: make perform_clear() work when VTY is not initialized ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8116075f32937bd06ba14b426010bf6fec2ef402 Gerrit-Change-Number: 26617 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 20 Dec 2021 09:54:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:56:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:56:16 +0000 Subject: Change in osmo-ttcn3-hacks[master]: vty: add f_verify_talloc_count() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618 ) Change subject: vty: add f_verify_talloc_count() ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618/1/library/Osmocom_VTY_Functions.ttcn File library/Osmocom_VTY_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618/1/library/Osmocom_VTY_Functions.ttcn at 230 PS1, Line 230: function f_strstr_count(in charstring str, in charstring sub_str) return integer Please a small description. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618/1/library/Osmocom_VTY_Functions.ttcn at 246 PS1, Line 246: type record of charstring StrList; > I would make it 'private'. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iafe720a4931270e868f40c4f623d10bb9c14dc80 Gerrit-Change-Number: 26618 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:56:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:57:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:57:02 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: detect subscr and conn leaks during f_shutdown_helper() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26619 ) Change subject: bsc: detect subscr and conn leaks during f_shutdown_helper() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I69d4c5c6f8d499bb7f0b96a48af045361433c57b Gerrit-Change-Number: 26619 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:57:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:57:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:57:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: f_perform_clear: ack all DLCX and RSL REL REQ In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26620 ) Change subject: bsc: f_perform_clear: ack all DLCX and RSL REL REQ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie5b77c266a5d8f47edd187c474df281a799a81de Gerrit-Change-Number: 26620 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:57:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 09:57:30 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 09:57:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: bsc: f_perform_clear: ack all DLCX and RSL REL REQ In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26620 ) Change subject: bsc: f_perform_clear: ack all DLCX and RSL REL REQ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie5b77c266a5d8f47edd187c474df281a799a81de Gerrit-Change-Number: 26620 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 09:57:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 10:39:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 10:39:01 +0000 Subject: Change in osmo-ci[master]: WIP References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26642 ) Change subject: WIP ...................................................................... WIP Change-Id: I4e004958e96f90589a97396b71ac69cdf2a1d900 --- M ansible/roles/osmocom-jenkins-slave/tasks/generic-slave.yml 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/42/26642/1 diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/generic-slave.yml b/ansible/roles/osmocom-jenkins-slave/tasks/generic-slave.yml index 6c50754..157871b 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/generic-slave.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/generic-slave.yml @@ -13,3 +13,20 @@ dest: "/home/{{ jenkins_user }}/bin" state: link force: yes + +- name: add local user directoy PATH to incoming ssh connections + copy: + content: "PATH=$PATH:/home/{{ jenkins_user }}/bin\n" + dest: /home/{{ jenkins_user }}/.ssh/environment + +- name: enable PermitUserEnvironment in sshd_config + replace: + path: /etc/ssh/sshd_config + regexp: '^#PermitUserEnvironment no$' + replace: 'PermitUserEnvironment yes' + validate: 'sshd -t -f %s' + +- name: reload sshd + service: + name: sshd + state: reloaded -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4e004958e96f90589a97396b71ac69cdf2a1d900 Gerrit-Change-Number: 26642 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 10:39:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 10:39:03 +0000 Subject: Change in osmo-ci[master]: jobs: Automatically push ttcn3-bts-tests to osmocom registry References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26643 ) Change subject: jobs: Automatically push ttcn3-bts-tests to osmocom registry ...................................................................... jobs: Automatically push ttcn3-bts-tests to osmocom registry This image used to be pushed to the sysmocom registry, before the osmocom one existed. Let's make it available in the osmocom one now that we have it instead. The new job triggers upon conclusion of the registry-rebuild-upload-titan job, since anyway the ttcn3-bts-tests is based on that image and hence requires it to be built prior to it. Related: SYS#5765 Change-Id: I65e4e5a9e539de5bfd881e08d7c5842f2266ecee --- M jobs/registry-rebuild-upload-titan.yml 1 file changed, 39 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/43/26643/1 diff --git a/jobs/registry-rebuild-upload-titan.yml b/jobs/registry-rebuild-upload-titan.yml index 0c63fca..2042cdf 100644 --- a/jobs/registry-rebuild-upload-titan.yml +++ b/jobs/registry-rebuild-upload-titan.yml @@ -1,9 +1,18 @@ - ---- - project: name: registry-rebuild-upload-titan jobs: - registry-rebuild-upload-titan + - registry-rebuild-upload-ttcn3-bts-tests + +- scm: + name: osmocom-docker-playground + scm: + - git: + url: git://git.osmocom.org/docker-playground + skip-tag: true + branches: + - 'origin/master' + - job: name: registry-rebuild-upload-titan @@ -17,18 +26,40 @@ node: osmocom-master-debian9 scm: - - git: - url: git://git.osmocom.org/docker-playground - skip-tag: true - branches: - - 'origin/master' - + - 'osmocom-docker-playground' builders: - shell: | REGISTRY="registry.osmocom.org" make -C debian-bullseye-titan REGISTRY_HOST=$REGISTRY docker push "$REGISTRY/$USER/debian-bullseye-titan" + publishers: + - email: + notify-every-unstable-build: true + recipients: 'jenkins-notifications at lists.osmocom.org' +- job: + name: registry-rebuild-upload-ttcn3-bts-tests + description: | + Rebuild + push ttcn3-bts-test image in our private registry.osmocom.org. + This docker container is used by osmo-gsm-tester main unit to run TTCN3 + BTS_Tests testsuite against real hardware. +

+ Related:
+
    +
  • SYS#5765 +
+ node: osmocom-master-debian9 + triggers: + - reverse: + jobs: + - registry-rebuild-upload-titan + scm: + - 'osmocom-docker-playground' + builders: + - shell: | + REGISTRY="registry.osmocom.org" + make -C ttcn3-bts-test REGISTRY_HOST=$REGISTRY + docker push "$REGISTRY/$USER/ttcn3-bts-test" publishers: - email: notify-every-unstable-build: true -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I65e4e5a9e539de5bfd881e08d7c5842f2266ecee Gerrit-Change-Number: 26643 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 10:39:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 10:39:40 +0000 Subject: Change in osmo-ci[master]: WIP In-Reply-To: References: Message-ID: pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26642 ) Change subject: WIP ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4e004958e96f90589a97396b71ac69cdf2a1d900 Gerrit-Change-Number: 26642 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 10:43:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 10:43:19 +0000 Subject: Change in osmo-gsm-tester[master]: ttcn3: Use osmocom registry to pull ttcn3-bts-test References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/26644 ) Change subject: ttcn3: Use osmocom registry to pull ttcn3-bts-test ...................................................................... ttcn3: Use osmocom registry to pull ttcn3-bts-test Since recently, the ttcn3-bts-test image is available in the osmocom registry. Let's use that one instead of the sysmocom one. The imaqge is built and pushed to the registry regularly by osmocom jenkins job registry-rebuild-upload-ttcn3-bts-tests (see osmo-ci.git/jobs/registry-rebuild-upload-titan.yml). Related: SYS#5765 Change-Id: I6de9719830290aa7f3ca80a6080ed37f107bdc16 --- M sysmocom/ttcn3/jenkins-run.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/44/26644/1 diff --git a/sysmocom/ttcn3/jenkins-run.sh b/sysmocom/ttcn3/jenkins-run.sh index 1688b88..faa9aad 100755 --- a/sysmocom/ttcn3/jenkins-run.sh +++ b/sysmocom/ttcn3/jenkins-run.sh @@ -25,7 +25,7 @@ PWD=$OLDPWD } -docker pull registry.sysmocom.de/ttcn3-bts-test +docker pull registry.osmocom.org/ttcn3-bts-test # remove older trial dirs and *-run.tgz, if any trial_dir_prefix="trial-" -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/26644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6de9719830290aa7f3ca80a6080ed37f107bdc16 Gerrit-Change-Number: 26644 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 10:58:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 10:58:15 +0000 Subject: Change in osmo-hnodeb[master]: Add example default config file References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26645 ) Change subject: Add example default config file ...................................................................... Add example default config file This config file is also installed and used by the systemd service by default. Local ip address of 127.0.0.3 is used by default to avoid collisions with default configs of osmo-sgsn and osmo-ggsn. Related: OS#5360 Change-Id: I02d628f48ca5adbc46e75a015c39a6fb5614a2d6 --- M doc/examples/osmo-hnodeb/osmo-hnodeb.cfg 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/45/26645/1 diff --git a/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg b/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg index e69de29..89b4799 100644 --- a/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg +++ b/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg @@ -0,0 +1,22 @@ +log stderr + logging filter all 1 + logging color 1 + logging print category 1 + logging print category-hex 0 + logging timestamp 1 +! +line vty + no login +! +hnodeb + cell_identity 1 + location_area_code 2 + routing_area_code 3 + service_area_code 4 + iuh + local-ip 127.0.0.1 + remote-ip 127.0.0.1 + ll-socket + path /tmp/hnb_prim_sock + gtp + local-ip 127.0.0.3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I02d628f48ca5adbc46e75a015c39a6fb5614a2d6 Gerrit-Change-Number: 26645 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 11:04:12 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 20 Dec 2021 11:04:12 +0000 Subject: Change in osmo-ci[master]: jobs: Automatically push ttcn3-bts-tests to osmocom registry In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26643 ) Change subject: jobs: Automatically push ttcn3-bts-tests to osmocom registry ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I65e4e5a9e539de5bfd881e08d7c5842f2266ecee Gerrit-Change-Number: 26643 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 20 Dec 2021 11:04:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Mon Dec 20 11:04:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 11:04:22 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <61c06343d5b20_74d2b05e19645f8978980@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-remsim failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 612s] #define PACKAGE_URL "" [ 612s] #define STDC_HEADERS 1 [ 612s] #define HAVE_SYS_TYPES_H 1 [ 612s] #define HAVE_SYS_STAT_H 1 [ 612s] #define HAVE_STDLIB_H 1 [ 612s] #define HAVE_STRING_H 1 [ 612s] #define HAVE_MEMORY_H 1 [ 612s] #define HAVE_STRINGS_H 1 [ 612s] #define HAVE_INTTYPES_H 1 [ 612s] #define HAVE_STDINT_H 1 [ 612s] #define HAVE_UNISTD_H 1 [ 612s] #define HAVE_DLFCN_H 1 [ 612s] #define LT_OBJDIR ".libs/" [ 612s] #define PACKAGE "osmo-remsim" [ 612s] #define VERSION "1.0.0.4-0c832" [ 612s] [ 612s] configure: exit 1 [ 612s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/arm-linux-gnueabihf --libexecdir=\${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 612s] make[1]: *** [debian/rules:17: override_dh_auto_configure] Error 2 [ 612s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 612s] make: *** [debian/rules:14: build] Error 2 [ 612s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 612s] ### VM INTERACTION START ### [ 615s] [ 552.224293] sysrq: SysRq : Power Off [ 615s] [ 552.230567] reboot: Power down [ 616s] ### VM INTERACTION END ### [ 616s] [ 616s] obs-arm-5 failed "build osmo-remsim_1.0.0.4.0c832.202112200026.dsc" at Mon Dec 20 11:04:09 UTC 2021. [ 616s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Dec 20 11:05:10 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 20 Dec 2021 11:05:10 +0000 Subject: Change in osmo-gsm-tester[master]: ttcn3: Use osmocom registry to pull ttcn3-bts-test In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/26644 ) Change subject: ttcn3: Use osmocom registry to pull ttcn3-bts-test ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/26644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6de9719830290aa7f3ca80a6080ed37f107bdc16 Gerrit-Change-Number: 26644 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 20 Dec 2021 11:05:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 11:08:36 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 20 Dec 2021 11:08:36 +0000 Subject: Change in osmo-hnodeb[master]: Add example default config file In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26645 ) Change subject: Add example default config file ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I02d628f48ca5adbc46e75a015c39a6fb5614a2d6 Gerrit-Change-Number: 26645 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 20 Dec 2021 11:08:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Mon Dec 20 11:12:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 11:12:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <61c06526a247a_74d2b05e19645f8981913@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-cbc failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 471s] #define PACKAGE_URL "" [ 471s] #define PACKAGE "osmo-cbc" [ 471s] #define VERSION "0.2.3" [ 471s] #define STDC_HEADERS 1 [ 471s] #define HAVE_SYS_TYPES_H 1 [ 471s] #define HAVE_SYS_STAT_H 1 [ 471s] #define HAVE_STDLIB_H 1 [ 471s] #define HAVE_STRING_H 1 [ 471s] #define HAVE_MEMORY_H 1 [ 471s] #define HAVE_STRINGS_H 1 [ 471s] #define HAVE_INTTYPES_H 1 [ 471s] #define HAVE_STDINT_H 1 [ 471s] #define HAVE_UNISTD_H 1 [ 471s] #define HAVE_DLFCN_H 1 [ 471s] #define LT_OBJDIR ".libs/" [ 471s] [ 471s] configure: exit 1 [ 471s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/arm-linux-gnueabihf --libexecdir=\${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 471s] make[1]: *** [debian/rules:50: override_dh_auto_configure] Error 2 [ 471s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 471s] make: *** [debian/rules:45: build] Error 2 [ 471s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 471s] ### VM INTERACTION START ### [ 473s] [ 449.607954] sysrq: SysRq : Power Off [ 473s] [ 449.609690] reboot: Power down [ 474s] ### VM INTERACTION END ### [ 474s] [ 474s] armbuild21 failed "build osmo-cbc_0.2.3.202112200026.dsc" at Mon Dec 20 11:12:09 UTC 2021. [ 474s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Dec 20 11:49:05 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 11:49:05 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Use alive-type components for infrastructure components References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26646 ) Change subject: hnodeb: Use alive-type components for infrastructure components ...................................................................... hnodeb: Use alive-type components for infrastructure components See 7138913d664c33b2404e3d293ab820fb3516ff73 for more information. Change-Id: I342b172aec58542be8c24228f488a635f84bda5a --- M hnodeb/HNBGW_ConnectionHandler.ttcn 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/26646/1 diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn index b069a11..a3ff32f 100644 --- a/hnodeb/HNBGW_ConnectionHandler.ttcn +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -71,7 +71,7 @@ private function f_HNBGW_ConnHdlr_init_iuh(charstring id) runs on HNBGW_ConnHdlr { var Iuh_Emulation_CT vc_Iuh; - vc_Iuh := Iuh_Emulation_CT.create(id & "-HNBGW"); + vc_Iuh := Iuh_Emulation_CT.create(id & "-HNBGW") alive; connect(self:HNBAP, vc_Iuh:HNBAP); connect(self:RUA, vc_Iuh:RUA); @@ -94,7 +94,7 @@ sgsn_role := false }; - vc_GTP := GTP_Emulation_CT.create(id); + vc_GTP := GTP_Emulation_CT.create(id) alive; connect(self:GTP, vc_GTP:CLIENT); connect(self:GTP_PROC, vc_GTP:CLIENT_PROC); vc_GTP.start(GTP_Emulation.main(gtp_cfg)); @@ -255,7 +255,7 @@ RtpemMode mode := RTPEM_MODE_BIDIR) runs on HNBGW_ConnHdlr { /* Step 0: initialize, connect and start the emulation component */ - vc_RTPEM := RTP_Emulation_CT.create(testcasename() & "-RTPEM"); + vc_RTPEM := RTP_Emulation_CT.create(testcasename() & "-RTPEM") alive; map(vc_RTPEM:RTP, system:RTP); map(vc_RTPEM:RTCP, system:RTCP); connect(vc_RTPEM:CTRL, self:RTPEM_CTRL); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I342b172aec58542be8c24228f488a635f84bda5a Gerrit-Change-Number: 26646 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:33:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:33:09 +0000 Subject: Change in osmo-ci[master]: jobs: Automatically push ttcn3-bts-tests to osmocom registry In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26643 ) Change subject: jobs: Automatically push ttcn3-bts-tests to osmocom registry ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I65e4e5a9e539de5bfd881e08d7c5842f2266ecee Gerrit-Change-Number: 26643 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 20 Dec 2021 13:33:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:33:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:33:14 +0000 Subject: Change in osmo-ci[master]: jobs: Automatically push ttcn3-bts-tests to osmocom registry In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26643 ) Change subject: jobs: Automatically push ttcn3-bts-tests to osmocom registry ...................................................................... jobs: Automatically push ttcn3-bts-tests to osmocom registry This image used to be pushed to the sysmocom registry, before the osmocom one existed. Let's make it available in the osmocom one now that we have it instead. The new job triggers upon conclusion of the registry-rebuild-upload-titan job, since anyway the ttcn3-bts-tests is based on that image and hence requires it to be built prior to it. Related: SYS#5765 Change-Id: I65e4e5a9e539de5bfd881e08d7c5842f2266ecee --- M jobs/registry-rebuild-upload-titan.yml 1 file changed, 39 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/registry-rebuild-upload-titan.yml b/jobs/registry-rebuild-upload-titan.yml index 0c63fca..2042cdf 100644 --- a/jobs/registry-rebuild-upload-titan.yml +++ b/jobs/registry-rebuild-upload-titan.yml @@ -1,9 +1,18 @@ - ---- - project: name: registry-rebuild-upload-titan jobs: - registry-rebuild-upload-titan + - registry-rebuild-upload-ttcn3-bts-tests + +- scm: + name: osmocom-docker-playground + scm: + - git: + url: git://git.osmocom.org/docker-playground + skip-tag: true + branches: + - 'origin/master' + - job: name: registry-rebuild-upload-titan @@ -17,18 +26,40 @@ node: osmocom-master-debian9 scm: - - git: - url: git://git.osmocom.org/docker-playground - skip-tag: true - branches: - - 'origin/master' - + - 'osmocom-docker-playground' builders: - shell: | REGISTRY="registry.osmocom.org" make -C debian-bullseye-titan REGISTRY_HOST=$REGISTRY docker push "$REGISTRY/$USER/debian-bullseye-titan" + publishers: + - email: + notify-every-unstable-build: true + recipients: 'jenkins-notifications at lists.osmocom.org' +- job: + name: registry-rebuild-upload-ttcn3-bts-tests + description: | + Rebuild + push ttcn3-bts-test image in our private registry.osmocom.org. + This docker container is used by osmo-gsm-tester main unit to run TTCN3 + BTS_Tests testsuite against real hardware. +

+ Related:
+
    +
  • SYS#5765 +
+ node: osmocom-master-debian9 + triggers: + - reverse: + jobs: + - registry-rebuild-upload-titan + scm: + - 'osmocom-docker-playground' + builders: + - shell: | + REGISTRY="registry.osmocom.org" + make -C ttcn3-bts-test REGISTRY_HOST=$REGISTRY + docker push "$REGISTRY/$USER/ttcn3-bts-test" publishers: - email: notify-every-unstable-build: true -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I65e4e5a9e539de5bfd881e08d7c5842f2266ecee Gerrit-Change-Number: 26643 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:33:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:33:24 +0000 Subject: Change in osmo-gsm-tester[master]: ttcn3: Use osmocom registry to pull ttcn3-bts-test In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/26644 ) Change subject: ttcn3: Use osmocom registry to pull ttcn3-bts-test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/26644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6de9719830290aa7f3ca80a6080ed37f107bdc16 Gerrit-Change-Number: 26644 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 20 Dec 2021 13:33:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:33:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:33:26 +0000 Subject: Change in osmo-gsm-tester[master]: ttcn3: Use osmocom registry to pull ttcn3-bts-test In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/26644 ) Change subject: ttcn3: Use osmocom registry to pull ttcn3-bts-test ...................................................................... ttcn3: Use osmocom registry to pull ttcn3-bts-test Since recently, the ttcn3-bts-test image is available in the osmocom registry. Let's use that one instead of the sysmocom one. The imaqge is built and pushed to the registry regularly by osmocom jenkins job registry-rebuild-upload-ttcn3-bts-tests (see osmo-ci.git/jobs/registry-rebuild-upload-titan.yml). Related: SYS#5765 Change-Id: I6de9719830290aa7f3ca80a6080ed37f107bdc16 --- M sysmocom/ttcn3/jenkins-run.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/sysmocom/ttcn3/jenkins-run.sh b/sysmocom/ttcn3/jenkins-run.sh index 1688b88..faa9aad 100755 --- a/sysmocom/ttcn3/jenkins-run.sh +++ b/sysmocom/ttcn3/jenkins-run.sh @@ -25,7 +25,7 @@ PWD=$OLDPWD } -docker pull registry.sysmocom.de/ttcn3-bts-test +docker pull registry.osmocom.org/ttcn3-bts-test # remove older trial dirs and *-run.tgz, if any trial_dir_prefix="trial-" -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/26644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6de9719830290aa7f3ca80a6080ed37f107bdc16 Gerrit-Change-Number: 26644 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:33:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:33:42 +0000 Subject: Change in osmo-hnodeb[master]: Add example default config file In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26645 ) Change subject: Add example default config file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I02d628f48ca5adbc46e75a015c39a6fb5614a2d6 Gerrit-Change-Number: 26645 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 20 Dec 2021 13:33:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:33:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:33:45 +0000 Subject: Change in osmo-hnodeb[master]: Add example default config file In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26645 ) Change subject: Add example default config file ...................................................................... Add example default config file This config file is also installed and used by the systemd service by default. Local ip address of 127.0.0.3 is used by default to avoid collisions with default configs of osmo-sgsn and osmo-ggsn. Related: OS#5360 Change-Id: I02d628f48ca5adbc46e75a015c39a6fb5614a2d6 --- M doc/examples/osmo-hnodeb/osmo-hnodeb.cfg 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg b/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg index e69de29..89b4799 100644 --- a/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg +++ b/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg @@ -0,0 +1,22 @@ +log stderr + logging filter all 1 + logging color 1 + logging print category 1 + logging print category-hex 0 + logging timestamp 1 +! +line vty + no login +! +hnodeb + cell_identity 1 + location_area_code 2 + routing_area_code 3 + service_area_code 4 + iuh + local-ip 127.0.0.1 + remote-ip 127.0.0.1 + ll-socket + path /tmp/hnb_prim_sock + gtp + local-ip 127.0.0.3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I02d628f48ca5adbc46e75a015c39a6fb5614a2d6 Gerrit-Change-Number: 26645 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:33:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:33:59 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Use alive-type components for infrastructure components In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26646 ) Change subject: hnodeb: Use alive-type components for infrastructure components ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I342b172aec58542be8c24228f488a635f84bda5a Gerrit-Change-Number: 26646 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 20 Dec 2021 13:33:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:34:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:34:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Use alive-type components for infrastructure components In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26646 ) Change subject: hnodeb: Use alive-type components for infrastructure components ...................................................................... hnodeb: Use alive-type components for infrastructure components See 7138913d664c33b2404e3d293ab820fb3516ff73 for more information. Change-Id: I342b172aec58542be8c24228f488a635f84bda5a --- M hnodeb/HNBGW_ConnectionHandler.ttcn 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn index b069a11..a3ff32f 100644 --- a/hnodeb/HNBGW_ConnectionHandler.ttcn +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -71,7 +71,7 @@ private function f_HNBGW_ConnHdlr_init_iuh(charstring id) runs on HNBGW_ConnHdlr { var Iuh_Emulation_CT vc_Iuh; - vc_Iuh := Iuh_Emulation_CT.create(id & "-HNBGW"); + vc_Iuh := Iuh_Emulation_CT.create(id & "-HNBGW") alive; connect(self:HNBAP, vc_Iuh:HNBAP); connect(self:RUA, vc_Iuh:RUA); @@ -94,7 +94,7 @@ sgsn_role := false }; - vc_GTP := GTP_Emulation_CT.create(id); + vc_GTP := GTP_Emulation_CT.create(id) alive; connect(self:GTP, vc_GTP:CLIENT); connect(self:GTP_PROC, vc_GTP:CLIENT_PROC); vc_GTP.start(GTP_Emulation.main(gtp_cfg)); @@ -255,7 +255,7 @@ RtpemMode mode := RTPEM_MODE_BIDIR) runs on HNBGW_ConnHdlr { /* Step 0: initialize, connect and start the emulation component */ - vc_RTPEM := RTP_Emulation_CT.create(testcasename() & "-RTPEM"); + vc_RTPEM := RTP_Emulation_CT.create(testcasename() & "-RTPEM") alive; map(vc_RTPEM:RTP, system:RTP); map(vc_RTPEM:RTCP, system:RTCP); connect(vc_RTPEM:CTRL, self:RTPEM_CTRL); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I342b172aec58542be8c24228f488a635f84bda5a Gerrit-Change-Number: 26646 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:34:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:34:27 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: import In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26622 ) Change subject: contrib/obs-mirror: import ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3f47cddbcee6c9b85fde77a039dcd5b54dd89f2d Gerrit-Change-Number: 26622 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 13:34:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:34:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:34:43 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: adjust includelist path In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26623 ) Change subject: contrib/obs-mirror: adjust includelist path ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4c6a6e424fd727de4e8058c916aa7eb43e7eb4b2 Gerrit-Change-Number: 26623 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 13:34:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:35:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:35:02 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: stop script on rsync error In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26624 ) Change subject: contrib/obs-mirror: stop script on rsync error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icfefd8e4bae1fd6c73445c7427aaa842c0391b2d Gerrit-Change-Number: 26624 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 13:35:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:35:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:35:11 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: redirect all output to a log file In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26625 ) Change subject: contrib/obs-mirror: redirect all output to a log file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie56c901877a3b0a1ad566cb243ab698f292407d5 Gerrit-Change-Number: 26625 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 13:35:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:35:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:35:17 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: log DRY var in rm script In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26626 ) Change subject: contrib/obs-mirror: log DRY var in rm script ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I705e52030d538e6d86c72f2bccb0eb97e6dab1de Gerrit-Change-Number: 26626 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 13:35:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:35:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:35:19 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: import In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26622 ) Change subject: contrib/obs-mirror: import ...................................................................... contrib/obs-mirror: import Import scripts from OS#4862 to have them properly versioned. We use this to replicate Osmocom related packages from OBS to: https://download.osmocom.org/obs-mirror Put it in contrib/, because it doesn't need to get installed to the jenkins nodes (as it would happen with everything in scripts/). Related: OS#4862 Change-Id: I3f47cddbcee6c9b85fde77a039dcd5b54dd89f2d --- A contrib/obs-mirror/README A contrib/obs-mirror/obs-mirror-include.txt A contrib/obs-mirror/obs-mirror.sh A contrib/obs-mirror/rm-old-nightly-archives.sh A contrib/obs-mirror/test-include-list.sh 5 files changed, 99 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/obs-mirror/README b/contrib/obs-mirror/README new file mode 100644 index 0000000..4cab14b --- /dev/null +++ b/contrib/obs-mirror/README @@ -0,0 +1,7 @@ +The scripts in this directory are used to create an archive of Osmocom related +packages from OBS, at: https://downloads.osmocom.org/obs-mirror/ + +There is no mechanism in place to deploy updated scripts after updating them +here in osmo-ci.git, so this must be done manually. + +See OS#4862 for more information. diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt new file mode 100644 index 0000000..037ce3f --- /dev/null +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -0,0 +1,9 @@ +latest/CentOS_8 +latest/Debian_10 +latest/Raspbian_10 +latest/xUbuntu_21.04 + +nightly/CentOS_8 +nightly/Debian_10 +nightly/Raspbian_10 +nightly/xUbuntu_21.04 diff --git a/contrib/obs-mirror/obs-mirror.sh b/contrib/obs-mirror/obs-mirror.sh new file mode 100755 index 0000000..76317c4 --- /dev/null +++ b/contrib/obs-mirror/obs-mirror.sh @@ -0,0 +1,40 @@ +#!/bin/bash + +# Mirror script to create a local archive of the OBS packages in the network:osmocom +# repositories / projects +# +# We are using hard-links to perform de-duplication on the local side; only +# those files that changed compoared to the previous run will be rsync'ed over +# from the remote side +# +# See also: OS#4862 + +set -e -x + +# base directory on the local side +BASE_DIR="/downloads/obs-mirror/" +# sync remote where to find the osmocom packages +REMOTE="rsync.opensuse.org::opensuse-full-really-everything-including-repositories/opensuse/repositories/network:/osmocom:" + +cd "$BASE_DIR" + +RSYNC_ARGS="-av --delete" +RSYNC_ARGS="$RSYNC_ARGS --files-from /home/pkgmirror/obs-mirror-include.txt --recursive" +DATE=`date +%Y%m%d-%H%M%S` + +# create output directory +DIR="$BASE_DIR/$DATE" +mkdir -p "$DIR" + +PREVIOUS="$BASE_DIR/.previous" +if [ -d "$PREVIOUS" ]; then + RSYNC_ARGS+=" --link-dest=$PREVIOUS" +fi + +# finally, perform rsync +# || true: don't stop here if one of the dirs from the include list does not exist +rsync $RSYNC_ARGS "$REMOTE"/ "$DIR"/ || true + +# update '.previous' for the next run +rm -f "$PREVIOUS" +ln -sf "$DATE" "$PREVIOUS" diff --git a/contrib/obs-mirror/rm-old-nightly-archives.sh b/contrib/obs-mirror/rm-old-nightly-archives.sh new file mode 100755 index 0000000..3a5f276 --- /dev/null +++ b/contrib/obs-mirror/rm-old-nightly-archives.sh @@ -0,0 +1,31 @@ +#!/bin/sh -e +# Remove nightly archives older than one month (OS#4862) +DRY=0 + +# Get removal date in seconds since epoch and display it +DATE_RM_SEC=$(expr $(date +%s) - 3600 \* 24 \* 32) +DATE_RM_STR=$(date -d "@$DATE_RM_SEC" +"%Y-%m-%d") +echo "Removing nightly archives from $DATE_RM_STR and older" + +cd /downloads/obs-mirror + +for i in */nightly; do + # "Last modified" isn't set to the date of the dir name for some + # archives, so parse the date from the dir name instead + DATE_DIR="$(basename "$(dirname "$i")")" # e.g. "20210604-002301" + DATE_DIR_SEC="$(date -d "$(echo "$DATE_DIR" | cut -d "-" -f 1)" +%s)" + if [ -z "$DATE_DIR_SEC" ]; then + echo "ERROR: $i: failed to parse date from dir name" + continue + fi + + if [ "$DATE_DIR_SEC" -lt "$DATE_RM_SEC" ]; then + DATE_DIR_STR="$(date -d "@$DATE_DIR_SEC" +"%Y-%m-%d")" + echo "Removing $i ($DATE_DIR_STR)..." + if [ "$DRY" = 0 ]; then + rm -r "$i" + fi + fi +done + +echo "Done" diff --git a/contrib/obs-mirror/test-include-list.sh b/contrib/obs-mirror/test-include-list.sh new file mode 100755 index 0000000..6766403 --- /dev/null +++ b/contrib/obs-mirror/test-include-list.sh @@ -0,0 +1,12 @@ +#!/bin/sh -ex +BASE_DIR="/downloads/obs-mirror/" + +cd "$BASE_DIR" + +rsync \ + -a \ + --list-only \ + --files-from /home/pkgmirror/obs-mirror-include.txt \ + --recursive \ + "$(realpath .previous)"/ \ + new-backup-dir/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3f47cddbcee6c9b85fde77a039dcd5b54dd89f2d Gerrit-Change-Number: 26622 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:35:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:35:20 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: adjust includelist path In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26623 ) Change subject: contrib/obs-mirror: adjust includelist path ...................................................................... contrib/obs-mirror: adjust includelist path Point at obs-mirror-include.txt from this git repository. Related: OS#4862 Change-Id: I4c6a6e424fd727de4e8058c916aa7eb43e7eb4b2 --- M contrib/obs-mirror/obs-mirror.sh M contrib/obs-mirror/test-include-list.sh 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/obs-mirror/obs-mirror.sh b/contrib/obs-mirror/obs-mirror.sh index 76317c4..8d25c2d 100755 --- a/contrib/obs-mirror/obs-mirror.sh +++ b/contrib/obs-mirror/obs-mirror.sh @@ -10,6 +10,7 @@ # See also: OS#4862 set -e -x +SCRIPT_DIR="$(realpath "$(dirname "$(realpath "$0")")")" # base directory on the local side BASE_DIR="/downloads/obs-mirror/" @@ -19,7 +20,7 @@ cd "$BASE_DIR" RSYNC_ARGS="-av --delete" -RSYNC_ARGS="$RSYNC_ARGS --files-from /home/pkgmirror/obs-mirror-include.txt --recursive" +RSYNC_ARGS="$RSYNC_ARGS --files-from $SCRIPT_DIR/obs-mirror-include.txt --recursive" DATE=`date +%Y%m%d-%H%M%S` # create output directory diff --git a/contrib/obs-mirror/test-include-list.sh b/contrib/obs-mirror/test-include-list.sh index 6766403..829e8f7 100755 --- a/contrib/obs-mirror/test-include-list.sh +++ b/contrib/obs-mirror/test-include-list.sh @@ -1,4 +1,5 @@ #!/bin/sh -ex +SCRIPT_DIR="$(realpath "$(dirname "$(realpath "$0")")")" BASE_DIR="/downloads/obs-mirror/" cd "$BASE_DIR" @@ -6,7 +7,7 @@ rsync \ -a \ --list-only \ - --files-from /home/pkgmirror/obs-mirror-include.txt \ + --files-from "$SCRIPT_DIR"/obs-mirror-include.txt \ --recursive \ "$(realpath .previous)"/ \ new-backup-dir/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4c6a6e424fd727de4e8058c916aa7eb43e7eb4b2 Gerrit-Change-Number: 26623 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:35:21 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:35:21 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: stop script on rsync error In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26624 ) Change subject: contrib/obs-mirror: stop script on rsync error ...................................................................... contrib/obs-mirror: stop script on rsync error Sync files into a temporary directory first, and only rename the temp dir to the final dir name if rsync succeeds. Otherwise, exit with error. Related: SYS#5764 Change-Id: Icfefd8e4bae1fd6c73445c7427aaa842c0391b2d --- M contrib/obs-mirror/obs-mirror.sh 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/obs-mirror/obs-mirror.sh b/contrib/obs-mirror/obs-mirror.sh index 8d25c2d..6ac3484 100755 --- a/contrib/obs-mirror/obs-mirror.sh +++ b/contrib/obs-mirror/obs-mirror.sh @@ -22,10 +22,11 @@ RSYNC_ARGS="-av --delete" RSYNC_ARGS="$RSYNC_ARGS --files-from $SCRIPT_DIR/obs-mirror-include.txt --recursive" DATE=`date +%Y%m%d-%H%M%S` - -# create output directory DIR="$BASE_DIR/$DATE" -mkdir -p "$DIR" +TEMP_DIR="$BASE_DIR/.temp" + +rm -rf "$TEMP_DIR" +mkdir "$TEMP_DIR" PREVIOUS="$BASE_DIR/.previous" if [ -d "$PREVIOUS" ]; then @@ -33,9 +34,12 @@ fi # finally, perform rsync -# || true: don't stop here if one of the dirs from the include list does not exist -rsync $RSYNC_ARGS "$REMOTE"/ "$DIR"/ || true +if rsync $RSYNC_ARGS "$REMOTE"/ "$TEMP_DIR"/; then + mv "$TEMP_DIR" "$DIR" -# update '.previous' for the next run -rm -f "$PREVIOUS" -ln -sf "$DATE" "$PREVIOUS" + # update '.previous' for the next run + rm -f "$PREVIOUS" + ln -sf "$DATE" "$PREVIOUS" +else + exit 1 +fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icfefd8e4bae1fd6c73445c7427aaa842c0391b2d Gerrit-Change-Number: 26624 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:35:22 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:35:22 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: redirect all output to a log file In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26625 ) Change subject: contrib/obs-mirror: redirect all output to a log file ...................................................................... contrib/obs-mirror: redirect all output to a log file Related: SYS#5764 Change-Id: Ie56c901877a3b0a1ad566cb243ab698f292407d5 --- M contrib/obs-mirror/obs-mirror.sh M contrib/obs-mirror/rm-old-nightly-archives.sh 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/obs-mirror/obs-mirror.sh b/contrib/obs-mirror/obs-mirror.sh index 6ac3484..529aea1 100755 --- a/contrib/obs-mirror/obs-mirror.sh +++ b/contrib/obs-mirror/obs-mirror.sh @@ -9,6 +9,9 @@ # # See also: OS#4862 +echo "Redirecting all output to: /home/pkgmirror/obs-mirror.log" +exec >"/home/pkgmirror/obs-mirror.log" 2>&1 + set -e -x SCRIPT_DIR="$(realpath "$(dirname "$(realpath "$0")")")" diff --git a/contrib/obs-mirror/rm-old-nightly-archives.sh b/contrib/obs-mirror/rm-old-nightly-archives.sh index 3a5f276..e28bce1 100755 --- a/contrib/obs-mirror/rm-old-nightly-archives.sh +++ b/contrib/obs-mirror/rm-old-nightly-archives.sh @@ -1,5 +1,8 @@ #!/bin/sh -e # Remove nightly archives older than one month (OS#4862) +echo "Redirecting all output to: /home/pkgmirror/rm-old-nightly-archives.log" +exec >"/home/pkgmirror/rm-old-nightly-archives.log" 2>&1 + DRY=0 # Get removal date in seconds since epoch and display it -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie56c901877a3b0a1ad566cb243ab698f292407d5 Gerrit-Change-Number: 26625 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:35:22 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:35:22 +0000 Subject: Change in osmo-ci[master]: contrib/obs-mirror: log DRY var in rm script In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26626 ) Change subject: contrib/obs-mirror: log DRY var in rm script ...................................................................... contrib/obs-mirror: log DRY var in rm script Related: SYS#5764 Change-Id: I705e52030d538e6d86c72f2bccb0eb97e6dab1de --- M contrib/obs-mirror/rm-old-nightly-archives.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/obs-mirror/rm-old-nightly-archives.sh b/contrib/obs-mirror/rm-old-nightly-archives.sh index e28bce1..485bf01 100755 --- a/contrib/obs-mirror/rm-old-nightly-archives.sh +++ b/contrib/obs-mirror/rm-old-nightly-archives.sh @@ -8,7 +8,7 @@ # Get removal date in seconds since epoch and display it DATE_RM_SEC=$(expr $(date +%s) - 3600 \* 24 \* 32) DATE_RM_STR=$(date -d "@$DATE_RM_SEC" +"%Y-%m-%d") -echo "Removing nightly archives from $DATE_RM_STR and older" +echo "Removing nightly archives from $DATE_RM_STR and older (DRY=$DRY)" cd /downloads/obs-mirror -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I705e52030d538e6d86c72f2bccb0eb97e6dab1de Gerrit-Change-Number: 26626 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 13:37:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 13:37:35 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: fix CHAN ACT templates for dynamic timeslots In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26194 ) Change subject: library/RSL_Types: fix CHAN ACT templates for dynamic timeslots ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie62a92daaacf4de5f05dd1f3f5b4a2a5e4ee6dd6 Gerrit-Change-Number: 26194 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 13:37:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 14:30:11 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 20 Dec 2021 14:30:11 +0000 Subject: Change in osmo-bsc[master]: bts: add missing return -EINVAL statements References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26647 ) Change subject: bts: add missing return -EINVAL statements ...................................................................... bts: add missing return -EINVAL statements The checks that make sure that an ARFCN falls in the correct range do not return with -EINVAL as they should, instead nothing happens. (Only the check for GSM1800 is corrct) Change-Id: Iddadafe3fbc47e2f980d8e4ab4f320998cb454ff Related: SYS#5369 --- M src/osmo-bsc/bts.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/26647/1 diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index c4ae518..2ce0344 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -441,6 +441,7 @@ if (bts->c0->arfcn < 512 || bts->c0->arfcn > 810) { LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1900 channel (%u) must be between 512-810.\n", bts->nr, bts->c0->arfcn); + return -EINVAL; } break; case GSM_BAND_900: @@ -448,16 +449,19 @@ bts->c0->arfcn > 1023) { LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n", bts->nr, bts->c0->arfcn); + return -EINVAL; } break; case GSM_BAND_850: if (bts->c0->arfcn < 128 || bts->c0->arfcn > 251) { LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM850 channel (%u) must be between 128-251.\n", bts->nr, bts->c0->arfcn); + return -EINVAL; } break; default: LOGP(DNM, LOGL_ERROR, "(bts=%u) Unsupported frequency band.\n", bts->nr); + return -EINVAL; } /* Verify the physical channel mapping */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iddadafe3fbc47e2f980d8e4ab4f320998cb454ff Gerrit-Change-Number: 26647 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 14:30:12 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 20 Dec 2021 14:30:12 +0000 Subject: Change in osmo-bsc[master]: bts: fix sourcecode formatting (excess whitespace) References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26648 ) Change subject: bts: fix sourcecode formatting (excess whitespace) ...................................................................... bts: fix sourcecode formatting (excess whitespace) Change-Id: Ie4fad0426d1d089156481806a05982a24375b766 --- M src/osmo-bsc/bts.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/48/26648/1 diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 2ce0344..1461585 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -446,7 +446,7 @@ break; case GSM_BAND_900: if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || - bts->c0->arfcn > 1023) { + bts->c0->arfcn > 1023) { LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n", bts->nr, bts->c0->arfcn); return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie4fad0426d1d089156481806a05982a24375b766 Gerrit-Change-Number: 26648 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 14:52:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 20 Dec 2021 14:52:32 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: fix CHAN ACT templates for dynamic timeslots In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26194 ) Change subject: library/RSL_Types: fix CHAN ACT templates for dynamic timeslots ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie62a92daaacf4de5f05dd1f3f5b4a2a5e4ee6dd6 Gerrit-Change-Number: 26194 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 14:52:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 14:54:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 14:54:27 +0000 Subject: Change in osmo-bsc[master]: bts: add missing return -EINVAL statements In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26647 ) Change subject: bts: add missing return -EINVAL statements ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iddadafe3fbc47e2f980d8e4ab4f320998cb454ff Gerrit-Change-Number: 26647 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 20 Dec 2021 14:54:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 14:54:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 14:54:36 +0000 Subject: Change in osmo-bsc[master]: bts: fix sourcecode formatting (excess whitespace) In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26648 ) Change subject: bts: fix sourcecode formatting (excess whitespace) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie4fad0426d1d089156481806a05982a24375b766 Gerrit-Change-Number: 26648 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 20 Dec 2021 14:54:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 14:54:38 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 14:54:38 +0000 Subject: Change in osmo-bsc[master]: bts: add missing return -EINVAL statements In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26647 ) Change subject: bts: add missing return -EINVAL statements ...................................................................... bts: add missing return -EINVAL statements The checks that make sure that an ARFCN falls in the correct range do not return with -EINVAL as they should, instead nothing happens. (Only the check for GSM1800 is corrct) Change-Id: Iddadafe3fbc47e2f980d8e4ab4f320998cb454ff Related: SYS#5369 --- M src/osmo-bsc/bts.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index c4ae518..2ce0344 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -441,6 +441,7 @@ if (bts->c0->arfcn < 512 || bts->c0->arfcn > 810) { LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM1900 channel (%u) must be between 512-810.\n", bts->nr, bts->c0->arfcn); + return -EINVAL; } break; case GSM_BAND_900: @@ -448,16 +449,19 @@ bts->c0->arfcn > 1023) { LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n", bts->nr, bts->c0->arfcn); + return -EINVAL; } break; case GSM_BAND_850: if (bts->c0->arfcn < 128 || bts->c0->arfcn > 251) { LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM850 channel (%u) must be between 128-251.\n", bts->nr, bts->c0->arfcn); + return -EINVAL; } break; default: LOGP(DNM, LOGL_ERROR, "(bts=%u) Unsupported frequency band.\n", bts->nr); + return -EINVAL; } /* Verify the physical channel mapping */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iddadafe3fbc47e2f980d8e4ab4f320998cb454ff Gerrit-Change-Number: 26647 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 14:54:38 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 14:54:38 +0000 Subject: Change in osmo-bsc[master]: bts: fix sourcecode formatting (excess whitespace) In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26648 ) Change subject: bts: fix sourcecode formatting (excess whitespace) ...................................................................... bts: fix sourcecode formatting (excess whitespace) Change-Id: Ie4fad0426d1d089156481806a05982a24375b766 --- M src/osmo-bsc/bts.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 2ce0344..1461585 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -446,7 +446,7 @@ break; case GSM_BAND_900: if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || - bts->c0->arfcn > 1023) { + bts->c0->arfcn > 1023) { LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n", bts->nr, bts->c0->arfcn); return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie4fad0426d1d089156481806a05982a24375b766 Gerrit-Change-Number: 26648 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 14:54:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 14:54:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: fix CHAN ACT templates for dynamic timeslots In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26194 ) Change subject: library/RSL_Types: fix CHAN ACT templates for dynamic timeslots ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie62a92daaacf4de5f05dd1f3f5b4a2a5e4ee6dd6 Gerrit-Change-Number: 26194 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 20 Dec 2021 14:54:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 20 14:55:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 20 Dec 2021 14:55:00 +0000 Subject: Change in osmo-ttcn3-hacks[master]: library/RSL_Types: fix CHAN ACT templates for dynamic timeslots In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26194 ) Change subject: library/RSL_Types: fix CHAN ACT templates for dynamic timeslots ...................................................................... library/RSL_Types: fix CHAN ACT templates for dynamic timeslots * t_RSL_IE_ActType_PDCH is actually a constant, not a template. * tr_RSL_CHAN_ACT_PDCH makes no use of parameter 'mode'. * Accomplish tr_RSL_CHAN_ACT_PDCH with a send template. * Use 'present' qualifier for receive template parameters. Change-Id: Ie62a92daaacf4de5f05dd1f3f5b4a2a5e4ee6dd6 --- M bsc/BSC_Tests.ttcn M library/RSL_Types.ttcn 2 files changed, 31 insertions(+), 19 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 0c71581..5276ed9 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -7374,7 +7374,7 @@ log("TCH/F_TCH/H_PDCH pchan starts out in disabled mode:"); f_ts_dyn_mode_assert(0, 0, chan_nr.tn, NONE_MODE); /* The BSC will activate the dynamic PDCH by default, so confirm that */ - rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?)); + rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr)); f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2342)); f_sleep(1.0); @@ -7403,7 +7403,7 @@ f_ts_dyn_mode_assert(0, 0, chan_nr.tn, NONE_MODE); /* The BSC will activate the dynamic PDCH by default, so confirm that */ - rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?)); + rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr)); /* NACK this activation and expect the "show timeslot" mode still to be NONE */ f_ipa_tx(0, ts_RSL_CHAN_ACT_NACK(chan_nr, RSL_ERR_EQUIPMENT_FAIL)); @@ -7435,7 +7435,7 @@ log("TCH/F_TCH/H_SDCCH8_PDCH pchan starts out in disabled mode:"); f_ts_dyn_mode_assert(0, 0, pdch_chan_nr.tn, NONE_MODE); /* The BSC will activate the dynamic PDCH by default, so confirm that */ - rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(pdch_chan_nr, ?)); + rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(pdch_chan_nr)); f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(pdch_chan_nr, 2342)); f_sleep(1.0); @@ -7473,7 +7473,7 @@ f_exp_chan_rel_and_clear(dt, 0); /* The BSC will switch the TS back to PDCH once the only lchan using it is released: */ - rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(pdch_chan_nr, ?)); + rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(pdch_chan_nr)); f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(pdch_chan_nr, 2342)); f_sleep(1.0); f_ts_dyn_mode_assert(0, 0, pdch_chan_nr.tn, PDCH_MODE); @@ -7505,7 +7505,7 @@ /* The dyn TS want to activate PDCH mode, ACK that. */ var RslChannelNr chan_nr; chan_nr := valueof(t_RslChanNr_PDCH(2)); - f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?)); + f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr)); f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2342)); f_sleep(1.0); @@ -7559,7 +7559,7 @@ log("TCH/F_TCH/H_SDCCH8_PDCH pchan starts out in disabled mode:"); f_ts_dyn_mode_assert(0, 0, pdch_chan_nr.tn, NONE_MODE); /* The BSC will activate the dynamic PDCH by default, so confirm that */ - rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(pdch_chan_nr, ?)); + rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(pdch_chan_nr)); f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(pdch_chan_nr, 2342)); f_sleep(1.0); @@ -7597,7 +7597,7 @@ f_exp_chan_rel_and_clear(dt, 0); /* The BSC will switch the TS back to PDCH once the only lchan using it is released: */ - rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(pdch_chan_nr, ?)); + rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(pdch_chan_nr)); f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(pdch_chan_nr, 2342)); f_sleep(1.0); f_ts_dyn_mode_assert(0, 0, pdch_chan_nr.tn, PDCH_MODE); @@ -7629,7 +7629,7 @@ log("TCH/F_TCH/H_SDCCH8_PDCH pchan starts out in disabled mode:"); f_ts_dyn_mode_assert(0, 0, pdch_chan_nr.tn, NONE_MODE); /* The BSC will activate the dynamic PDCH by default, so confirm that */ - rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(pdch_chan_nr, ?)); + rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(pdch_chan_nr)); f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(pdch_chan_nr, 2342)); f_sleep(1.0); @@ -7662,7 +7662,7 @@ /* FIXME? Currently the TS stays in state BORKEN: */ /* The BSC will switch the TS back to PDCH once the only lchan using it is released: */ - /* rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(pdch_chan_nr, ?)); + /* rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(pdch_chan_nr)); * f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(pdch_chan_nr, 2342)); * f_sleep(1.0); * f_ts_dyn_mode_assert(0, 0, pdch_chan_nr.tn, PDCH_MODE) @@ -10319,7 +10319,7 @@ var RslChannelNr chan_nr := valueof(t_RslChanNr_PDCH(6)); /* The BSC will activate the dynamic PDCH by default, so confirm that */ - f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?)); + f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr)); f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2323)); /* clean up timeslot 6 config, will only take effect when the OML drops the next time */ @@ -10391,7 +10391,7 @@ var RslChannelNr chan_nr := valueof(t_RslChanNr_PDCH(6)); /* The BSC will activate the dynamic PDCH by default, so confirm that */ - f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?)); + f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr)); f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2323)); /* clean up timeslot 6 config, will only take effect when the OML drops the next time */ @@ -10723,7 +10723,7 @@ /* The dyn TS wants to activate PDCH mode, ACK that. */ var RslChannelNr chan_nr; chan_nr := valueof(t_RslChanNr_PDCH(2)); - f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?)); + f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr)); f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2342)); /* Exhaust all dedicated SDCCH lchans. @@ -10781,7 +10781,7 @@ /* All SDCCH on the dyn TS are released, the dyn TS wants to activate PDCH again */ chan_nr := valueof(t_RslChanNr_PDCH(2)); - f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?)); + f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr)); f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2342)); /* Now all channels are occupied except the dyn TS, so expecting only the static counters to increment */ diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 70fb398..ccd43e6 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -318,7 +318,7 @@ } /* osmocom-style dynamic PDCH */ - const RSL_IE_ActivationType t_RSL_IE_ActType_PDCH := { + const RSL_IE_ActivationType c_RSL_IE_ActType_PDCH := { reactivation := false, reserved := 1, a_bits := ACT_REL_TO_OSMO_PDCH @@ -1400,13 +1400,23 @@ * } } - template RSL_Message tr_RSL_CHAN_ACT_PDCH(template RslChannelNr chan_nr, - template RSL_IE_ChannelMode mode) := { + + template (value) RSL_Message + ts_RSL_CHAN_ACT_PDCH(template (value) RslChannelNr chan_nr) := { + msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false), + msg_type := RSL_MT_CHAN_ACTIV, + ies :={ + t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := chan_nr}), + t_RSL_IE(RSL_IE_ACT_TYPE, RSL_IE_Body:{act_type := c_RSL_IE_ActType_PDCH}) + } + } + template RSL_Message + tr_RSL_CHAN_ACT_PDCH(template (present) RslChannelNr chan_nr) := { msg_disc := tr_RSL_MsgDisc(RSL_MDISC_DCHAN, false), msg_type := RSL_MT_CHAN_ACTIV, ies :={ tr_RSL_IE(RSL_IE_Body:{chan_nr := chan_nr}), - tr_RSL_IE(RSL_IE_Body:{act_type := t_RSL_IE_ActType_PDCH}), + tr_RSL_IE(RSL_IE_Body:{act_type := c_RSL_IE_ActType_PDCH}), /* lots of optional IEs */ * } @@ -2320,14 +2330,16 @@ } - template (value) RSL_Message ts_RSL_IPA_PDCH_ACT(RslChannelNr chan_nr) := { + template (value) RSL_Message + ts_RSL_IPA_PDCH_ACT(template (value) RslChannelNr chan_nr) := { msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false), msg_type := RSL_MT_IPAC_PDCH_ACT, ies := { t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := chan_nr}) } } - template RSL_Message tr_RSL_IPA_PDCH_ACT(template RslChannelNr chan_nr) := { + template RSL_Message + tr_RSL_IPA_PDCH_ACT(template (present) RslChannelNr chan_nr) := { msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false), msg_type := RSL_MT_IPAC_PDCH_ACT, ies := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie62a92daaacf4de5f05dd1f3f5b4a2a5e4ee6dd6 Gerrit-Change-Number: 26194 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Mon Dec 20 15:04:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:04:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09ba521ee1_74d2b05e19645f81023845@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 420s] self.__getattribute__('to_'+self.format)() [ 420s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 420s] self.exec_dblatex() [ 420s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 420s] self.to_docbook() [ 420s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 420s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 420s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 420s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 420s] IndexError: tuple index out of range [ 420s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 420s] a2x: resource files: [] [ 420s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 420s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 420s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 420s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 420s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 420s] make[1]: *** [Makefile:363: all] Error 2 [ 420s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 420s] dh_auto_build: error: make -j1 returned exit code 2 [ 420s] make: *** [debian/rules:5: binary] Error 25 [ 420s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 420s] ### VM INTERACTION START ### [ 421s] Powering off. [ 421s] [ 404.216149] reboot: Power down [ 421s] ### VM INTERACTION END ### [ 421s] [ 421s] lamb57 failed "build osmo-gsm-manuals-dev_1.2.0.202112200026.dsc" at Mon Dec 20 15:04:43 UTC 2021. [ 421s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:05:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:05:31 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09bc437f10_74d2b05e19645f810240a6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 466s] self.__getattribute__('to_'+self.format)() [ 466s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 466s] self.exec_dblatex() [ 466s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 466s] self.to_docbook() [ 466s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 466s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 466s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 466s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 466s] IndexError: tuple index out of range [ 466s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 466s] a2x: resource files: [] [ 466s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 466s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 466s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 466s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 466s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 466s] make[1]: *** [Makefile:363: all] Error 2 [ 466s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 466s] dh_auto_build: error: make -j1 returned exit code 2 [ 466s] make: *** [debian/rules:5: binary] Error 25 [ 466s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 467s] ### VM INTERACTION START ### [ 468s] Powering off. [ 468s] [ 441.665619][T31727] reboot: Power down [ 468s] ### VM INTERACTION END ### [ 468s] [ 468s] lamb03 failed "build osmo-gsm-manuals-dev_1.2.0.dsc" at Mon Dec 20 15:05:18 UTC 2021. [ 468s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:10:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:10:03 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09cd17508d_74d2b05e19645f81024876@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 247s] self.exec_dblatex() [ 247s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 247s] self.to_docbook() [ 247s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 247s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 247s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 247s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 247s] IndexError: tuple index out of range [ 247s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 247s] a2x: resource files: [] [ 247s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 247s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 247s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 247s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 247s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 247s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 247s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 247s] make[1]: *** [Makefile:392: all] Error 2 [ 247s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 247s] dh_auto_build: error: make -j1 returned exit code 2 [ 247s] make: *** [debian/rules:15: build] Error 25 [ 247s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 247s] ### VM INTERACTION START ### [ 248s] Powering off. [ 248s] [ 236.543549] reboot: Power down [ 248s] ### VM INTERACTION END ### [ 248s] [ 248s] build74 failed "build osmo-ggsn_1.8.0.dsc" at Mon Dec 20 15:09:56 UTC 2021. [ 248s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:10:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:10:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09cf1aa347_74d2b05e19645f810250d8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 271s] self.exec_dblatex() [ 271s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 271s] self.to_docbook() [ 271s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 271s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 271s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 271s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 271s] IndexError: tuple index out of range [ 271s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 271s] a2x: resource files: [] [ 271s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 271s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 271s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 271s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 271s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 271s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 271s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 271s] make[1]: *** [Makefile:327: all] Error 2 [ 271s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 271s] dh_auto_build: error: make -j1 returned exit code 2 [ 271s] make: *** [debian/rules:12: build] Error 25 [ 271s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 271s] ### VM INTERACTION START ### [ 272s] Powering off. [ 272s] [ 258.703421] reboot: Power down [ 273s] ### VM INTERACTION END ### [ 273s] [ 273s] sheep86 failed "build osmo-sip-connector_1.6.0.202112200026.dsc" at Mon Dec 20 15:10:23 UTC 2021. [ 273s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:10:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:10:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09cf1e0d68_74d2b05e19645f810251a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 279s] self.exec_dblatex() [ 279s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 279s] self.to_docbook() [ 279s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 279s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 279s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 279s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 279s] IndexError: tuple index out of range [ 279s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 279s] a2x: resource files: [] [ 279s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 279s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 279s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 279s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 279s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 279s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 279s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 279s] make[1]: *** [Makefile:392: all] Error 2 [ 279s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 279s] dh_auto_build: error: make -j1 returned exit code 2 [ 279s] make: *** [debian/rules:15: build] Error 25 [ 279s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 279s] ### VM INTERACTION START ### [ 280s] Powering off. [ 280s] [ 266.237843] reboot: Power down [ 280s] ### VM INTERACTION END ### [ 280s] [ 280s] sheep86 failed "build osmo-ggsn_1.8.0.202112200026.dsc" at Mon Dec 20 15:10:28 UTC 2021. [ 280s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:11:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:11:11 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09d297efd8_74d2b05e19645f81025328@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 309s] self.__getattribute__('to_'+self.format)() [ 309s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 309s] self.exec_dblatex() [ 309s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 309s] self.to_docbook() [ 309s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 309s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 309s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 309s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 309s] IndexError: tuple index out of range [ 309s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 309s] a2x: resource files: [] [ 309s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 309s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 309s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 309s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 309s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 309s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 309s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 309s] dh_auto_build: error: make -j1 returned exit code 2 [ 309s] make: *** [debian/rules:12: build] Error 25 [ 309s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 309s] ### VM INTERACTION START ### [ 310s] Powering off. [ 310s] [ 296.009373] reboot: Power down [ 310s] ### VM INTERACTION END ### [ 310s] [ 310s] sheep88 failed "build osmo-pcu_1.0.0.1.8d03.202112200026.dsc" at Mon Dec 20 15:10:54 UTC 2021. [ 310s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:11:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:11:45 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09d48d41fd_74d2b05e19645f81025662@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 347s] self.exec_dblatex() [ 347s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 347s] self.to_docbook() [ 347s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 347s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 347s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 347s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 347s] IndexError: tuple index out of range [ 347s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 347s] a2x: resource files: [] [ 347s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 347s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 347s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 347s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 347s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 347s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 347s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 347s] make[1]: *** [Makefile:377: all] Error 2 [ 347s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 347s] dh_auto_build: error: make -j1 returned exit code 2 [ 347s] make: *** [debian/rules:45: build] Error 25 [ 347s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 347s] ### VM INTERACTION START ### [ 349s] Powering off. [ 349s] [ 331.474037] reboot: Power down [ 349s] ### VM INTERACTION END ### [ 349s] [ 349s] lamb13 failed "build osmo-gbproxy_0.2.0.dsc" at Mon Dec 20 15:11:40 UTC 2021. [ 349s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:12:02 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:12:02 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09d496a983_74d2b05e19645f810257d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 358s] self.exec_dblatex() [ 358s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 358s] self.to_docbook() [ 358s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 358s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 358s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 358s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 358s] IndexError: tuple index out of range [ 358s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 358s] a2x: resource files: [] [ 358s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 358s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 358s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 358s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 358s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 358s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 358s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 358s] make[1]: *** [Makefile:327: all] Error 2 [ 358s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 358s] dh_auto_build: error: make -j1 returned exit code 2 [ 358s] make: *** [debian/rules:12: build] Error 25 [ 358s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 358s] ### VM INTERACTION START ### [ 359s] Powering off. [ 359s] [ 340.484911] reboot: Power down [ 359s] ### VM INTERACTION END ### [ 359s] [ 359s] lamb52 failed "build osmo-sip-connector_1.6.0.dsc" at Mon Dec 20 15:11:56 UTC 2021. [ 359s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:12:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:12:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09d823cb0e_74d2b05e19645f8102586a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 411s] self.__getattribute__('to_'+self.format)() [ 411s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 411s] self.exec_dblatex() [ 411s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 411s] self.to_docbook() [ 411s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 411s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 411s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 411s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 411s] IndexError: tuple index out of range [ 411s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 411s] a2x: resource files: [] [ 411s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 411s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 411s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 411s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 411s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 411s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 411s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 411s] dh_auto_build: error: make -j1 returned exit code 2 [ 411s] make: *** [debian/rules:12: build] Error 25 [ 411s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 411s] ### VM INTERACTION START ### [ 412s] Powering off. [ 412s] [ 392.947949] reboot: Power down [ 412s] ### VM INTERACTION END ### [ 412s] [ 412s] lamb62 failed "build osmo-pcu_1.0.0.dsc" at Mon Dec 20 15:12:48 UTC 2021. [ 412s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:12:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:12:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09d826c0f0_74d2b05e19645f810259a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gbproxy Last lines of build log: [ 428s] self.exec_dblatex() [ 428s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 428s] self.to_docbook() [ 428s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 428s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 428s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 428s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 428s] IndexError: tuple index out of range [ 428s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 428s] a2x: resource files: [] [ 428s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 428s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 428s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 428s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 428s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 428s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 428s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 428s] make[1]: *** [Makefile:377: all] Error 2 [ 428s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 428s] dh_auto_build: error: make -j1 returned exit code 2 [ 428s] make: *** [debian/rules:45: build] Error 25 [ 428s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 428s] ### VM INTERACTION START ### [ 429s] Powering off. [ 429s] [ 409.565386][T32149] reboot: Power down [ 429s] ### VM INTERACTION END ### [ 429s] [ 429s] lamb03 failed "build osmo-gbproxy_0.2.0.4.28ec0.202112200026.dsc" at Mon Dec 20 15:12:51 UTC 2021. [ 429s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:14:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:14:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09ddf3f031_74d2b05e19645f81026072@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 337s] self.exec_dblatex() [ 337s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 337s] self.to_docbook() [ 337s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 337s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 337s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 337s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 337s] IndexError: tuple index out of range [ 337s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 337s] a2x: resource files: [] [ 337s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 337s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 337s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 337s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 337s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 337s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 337s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 337s] make[1]: *** [Makefile:410: all] Error 2 [ 337s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 337s] dh_auto_build: error: make -j1 returned exit code 2 [ 337s] make: *** [debian/rules:7: build] Error 25 [ 337s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 337s] ### VM INTERACTION START ### [ 338s] Powering off. [ 338s] [ 323.055375] reboot: Power down [ 338s] ### VM INTERACTION END ### [ 338s] [ 338s] old-atreju4 failed "build osmo-hlr_1.4.0.1.37a5.202112200026.dsc" at Mon Dec 20 15:14:05 UTC 2021. [ 338s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:14:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:14:18 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09de09f4c_74d2b05e19645f810262f6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 349s] self.exec_dblatex() [ 349s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 349s] self.to_docbook() [ 349s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 349s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 349s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 349s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 349s] IndexError: tuple index out of range [ 350s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 350s] a2x: resource files: [] [ 350s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 350s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 350s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 350s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 350s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 350s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 350s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 350s] make[1]: *** [Makefile:368: all] Error 2 [ 350s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 350s] dh_auto_build: error: make -j1 returned exit code 2 [ 350s] make: *** [debian/rules:45: build] Error 25 [ 350s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 350s] ### VM INTERACTION START ### [ 351s] Powering off. [ 351s] [ 334.311582] reboot: Power down [ 351s] ### VM INTERACTION END ### [ 351s] [ 351s] old-atreju3 failed "build osmo-cbc_0.2.3.dsc" at Mon Dec 20 15:14:15 UTC 2021. [ 351s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:14:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:14:35 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09de040abb_74d2b05e19645f8102636a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 364s] self.exec_dblatex() [ 364s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 364s] self.to_docbook() [ 364s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 364s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 364s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 364s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 364s] IndexError: tuple index out of range [ 364s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 364s] a2x: resource files: [] [ 364s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 364s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 364s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 364s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 364s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 364s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 364s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 364s] make[1]: *** [Makefile:410: all] Error 2 [ 364s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 364s] dh_auto_build: error: make -j1 returned exit code 2 [ 364s] make: *** [debian/rules:7: build] Error 25 [ 364s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 365s] ### VM INTERACTION START ### [ 366s] Powering off. [ 366s] [ 349.363520] reboot: Power down [ 366s] ### VM INTERACTION END ### [ 366s] [ 366s] lamb08 failed "build osmo-hlr_1.4.0.dsc" at Mon Dec 20 15:14:32 UTC 2021. [ 366s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:14:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:14:52 +0000 Subject: Build failure of network:osmocom:nightly/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09df9bbb0f_74d2b05e19645f81026446@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 369s] self.exec_dblatex() [ 369s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 369s] self.to_docbook() [ 369s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 369s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 369s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 369s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 369s] IndexError: tuple index out of range [ 369s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 369s] a2x: resource files: [] [ 369s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 369s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 369s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 369s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 369s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 369s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 369s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 369s] make[1]: *** [Makefile:423: all] Error 2 [ 369s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 369s] dh_auto_build: error: make -j1 returned exit code 2 [ 369s] make: *** [debian/rules:17: build] Error 25 [ 369s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 369s] ### VM INTERACTION START ### [ 370s] Powering off. [ 370s] [ 350.982480] reboot: Power down [ 370s] ### VM INTERACTION END ### [ 370s] [ 370s] lamb28 failed "build osmo-mgw_1.9.0.7.bc3f.202112200026.dsc" at Mon Dec 20 15:14:41 UTC 2021. [ 370s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:15:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:15:09 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09e18d27b8_74d2b05e19645f81026749@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 383s] self.exec_dblatex() [ 383s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 383s] self.to_docbook() [ 383s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 383s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 383s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 383s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 383s] IndexError: tuple index out of range [ 383s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 383s] a2x: resource files: [] [ 383s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 383s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 383s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 383s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 383s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 383s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 383s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 383s] make[1]: *** [Makefile:403: all] Error 2 [ 383s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 383s] dh_auto_build: error: make -j1 returned exit code 2 [ 383s] make: *** [debian/rules:12: build] Error 25 [ 383s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 383s] ### VM INTERACTION START ### [ 384s] Powering off. [ 384s] [ 365.316578] reboot: Power down [ 385s] ### VM INTERACTION END ### [ 385s] [ 385s] lamb24 failed "build libosmo-sccp_1.5.0.2.0432.202112200026.dsc" at Mon Dec 20 15:14:55 UTC 2021. [ 385s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:15:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:15:09 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09e19de12_74d2b05e19645f81026868@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 537s] self.exec_dblatex() [ 537s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 537s] self.to_docbook() [ 537s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 537s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 537s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 537s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 537s] IndexError: tuple index out of range [ 537s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 537s] a2x: resource files: [] [ 537s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 537s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 537s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 537s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 537s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 537s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 537s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 537s] make[1]: *** [Makefile:452: all] Error 2 [ 537s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 537s] dh_auto_build: error: make -j1 returned exit code 2 [ 537s] make: *** [debian/rules:6: build] Error 25 [ 537s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 537s] ### VM INTERACTION START ### [ 539s] Powering off. [ 539s] [ 515.322200] reboot: Power down [ 539s] ### VM INTERACTION END ### [ 539s] [ 539s] lamb57 failed "build osmo-trx_1.4.0.dsc" at Mon Dec 20 15:14:56 UTC 2021. [ 539s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:15:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:15:26 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09e1a9d82d_74d2b05e19645f81026985@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 567s] self.exec_dblatex() [ 567s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 567s] self.to_docbook() [ 567s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 567s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 567s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 567s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 567s] IndexError: tuple index out of range [ 567s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 567s] a2x: resource files: [] [ 567s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 567s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 567s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 567s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 567s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 567s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 567s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 567s] make[1]: *** [Makefile:452: all] Error 2 [ 567s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 567s] dh_auto_build: error: make -j1 returned exit code 2 [ 567s] make: *** [debian/rules:6: build] Error 25 [ 567s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 567s] ### VM INTERACTION START ### [ 568s] Powering off. [ 568s] [ 549.472442] reboot: Power down [ 568s] ### VM INTERACTION END ### [ 568s] [ 568s] lamb20 failed "build osmo-trx_1.4.0.1.424c.202112200026.dsc" at Mon Dec 20 15:15:19 UTC 2021. [ 568s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:15:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:15:26 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09e1ac45ca_74d2b05e19645f810270c1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 413s] self.exec_dblatex() [ 413s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 413s] self.to_docbook() [ 413s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 413s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 413s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 413s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 413s] IndexError: tuple index out of range [ 413s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 413s] a2x: resource files: [] [ 413s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 413s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 413s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 413s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 413s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 413s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 413s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 413s] make[1]: *** [Makefile:423: all] Error 2 [ 413s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 413s] dh_auto_build: error: make -j1 returned exit code 2 [ 413s] make: *** [debian/rules:17: build] Error 25 [ 413s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 413s] ### VM INTERACTION START ### [ 414s] Powering off. [ 414s] [ 387.549620] reboot: Power down [ 414s] ### VM INTERACTION END ### [ 414s] [ 414s] cloud116 failed "build osmo-mgw_1.9.0.dsc" at Mon Dec 20 15:15:20 UTC 2021. [ 414s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:15:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:15:43 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09e3964a92_74d2b05e19645f81027192@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 420s] self.exec_dblatex() [ 420s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 420s] self.to_docbook() [ 420s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 420s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 420s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 420s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 420s] IndexError: tuple index out of range [ 420s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 420s] a2x: resource files: [] [ 420s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 420s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 420s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 420s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 420s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 420s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 420s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 420s] make[1]: *** [Makefile:403: all] Error 2 [ 420s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 420s] dh_auto_build: error: make -j1 returned exit code 2 [ 420s] make: *** [debian/rules:12: build] Error 25 [ 420s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 420s] ### VM INTERACTION START ### [ 421s] Powering off. [ 421s] [ 391.785064] reboot: Power down [ 421s] ### VM INTERACTION END ### [ 421s] [ 421s] cloud124 failed "build libosmo-sccp_1.5.0.dsc" at Mon Dec 20 15:15:27 UTC 2021. [ 421s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:15:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:15:43 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09e39c493a_74d2b05e19645f8102725f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 402s] self.exec_dblatex() [ 402s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 402s] self.to_docbook() [ 402s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 402s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 402s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 402s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 402s] IndexError: tuple index out of range [ 402s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 402s] a2x: resource files: [] [ 402s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 402s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 402s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 402s] make[3]: *** [Makefile:386: all-recursive] Error 1 [ 402s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 402s] make[2]: *** [Makefile:484: all-recursive] Error 1 [ 402s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 402s] make[1]: *** [Makefile:408: all] Error 2 [ 402s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 402s] dh_auto_build: error: make -j1 returned exit code 2 [ 402s] make: *** [debian/rules:14: build] Error 25 [ 402s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 402s] ### VM INTERACTION START ### [ 403s] Powering off. [ 403s] [ 386.323201] reboot: Power down [ 403s] ### VM INTERACTION END ### [ 403s] [ 403s] lamb53 failed "build osmo-remsim_1.0.0.dsc" at Mon Dec 20 15:15:38 UTC 2021. [ 403s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:16:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:16:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09e554a38e_74d2b05e19645f8102738a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 477s] self.exec_dblatex() [ 477s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 477s] self.to_docbook() [ 477s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 477s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 477s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 477s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 477s] IndexError: tuple index out of range [ 477s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 477s] a2x: resource files: [] [ 477s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 477s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 477s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 477s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 477s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 477s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 477s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 477s] make[1]: *** [Makefile:368: all] Error 2 [ 477s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 477s] dh_auto_build: error: make -j1 returned exit code 2 [ 477s] make: *** [debian/rules:45: build] Error 25 [ 477s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 477s] ### VM INTERACTION START ### [ 478s] Powering off. [ 478s] [ 456.772294][ T1156] reboot: Power down [ 478s] ### VM INTERACTION END ### [ 478s] [ 478s] lamb01 failed "build osmo-cbc_0.2.3.202112200026.dsc" at Mon Dec 20 15:16:24 UTC 2021. [ 478s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:19:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:19:24 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09f0ab6f6f_74d2b05e19645f8102789a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 241s] self.exec_dblatex() [ 241s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 241s] self.to_docbook() [ 241s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 241s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 241s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 241s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 241s] IndexError: tuple index out of range [ 241s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 241s] a2x: resource files: [] [ 241s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 241s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 241s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 241s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 241s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 241s] make[2]: *** [Makefile:454: all-recursive] Error 1 [ 241s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 241s] make[1]: *** [Makefile:386: all] Error 2 [ 241s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 241s] dh_auto_build: error: make -j1 returned exit code 2 [ 241s] make: *** [debian/rules:45: build] Error 25 [ 241s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 241s] ### VM INTERACTION START ### [ 242s] Powering off. [ 242s] [ 232.319200] reboot: Power down [ 243s] ### VM INTERACTION END ### [ 243s] [ 243s] goat11 failed "build osmo-bsc_1.8.0.16.260eb.202112200026.dsc" at Mon Dec 20 15:19:20 UTC 2021. [ 243s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:20:32 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:20:32 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09f4366bb8_74d2b05e19645f81027938@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 574s] self.exec_dblatex() [ 574s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 574s] self.to_docbook() [ 574s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 574s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 574s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 574s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 574s] IndexError: tuple index out of range [ 574s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 574s] a2x: resource files: [] [ 574s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 574s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 574s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 574s] make[3]: *** [Makefile:386: all-recursive] Error 1 [ 574s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 574s] make[2]: *** [Makefile:484: all-recursive] Error 1 [ 574s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 574s] make[1]: *** [Makefile:408: all] Error 2 [ 574s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 574s] dh_auto_build: error: make -j1 returned exit code 2 [ 574s] make: *** [debian/rules:14: build] Error 25 [ 574s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 574s] ### VM INTERACTION START ### [ 575s] Powering off. [ 575s] [ 553.209010][T15010] reboot: Power down [ 575s] ### VM INTERACTION END ### [ 575s] [ 575s] lamb02 failed "build osmo-remsim_1.0.0.4.0c832.202112200026.dsc" at Mon Dec 20 15:20:25 UTC 2021. [ 575s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:21:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:21:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09fa199fd8_74d2b05e19645f81028279@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 380s] self.exec_dblatex() [ 380s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 380s] self.to_docbook() [ 380s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 380s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 380s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 380s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 380s] IndexError: tuple index out of range [ 380s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 380s] a2x: resource files: [] [ 380s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 380s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 380s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 380s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 380s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 380s] make[2]: *** [Makefile:475: all-recursive] Error 1 [ 380s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 380s] make[1]: *** [Makefile:393: all] Error 2 [ 380s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 380s] dh_auto_build: error: make -j1 returned exit code 2 [ 380s] make: *** [debian/rules:9: build] Error 25 [ 380s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 380s] ### VM INTERACTION START ### [ 381s] Powering off. [ 381s] [ 371.571202] reboot: Power down [ 382s] ### VM INTERACTION END ### [ 382s] [ 382s] goat19 failed "build osmo-iuh_1.1.0.1.9b4d.202112200026.dsc" at Mon Dec 20 15:21:43 UTC 2021. [ 382s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:21:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:21:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09fa1c2533_74d2b05e19645f8102834c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-smlc Last lines of build log: [ 377s] self.exec_dblatex() [ 377s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 377s] self.to_docbook() [ 377s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 377s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 377s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 377s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 377s] IndexError: tuple index out of range [ 377s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 377s] a2x: resource files: [] [ 377s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 377s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 377s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 377s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 377s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 377s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 377s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 377s] make[1]: *** [Makefile:377: all] Error 2 [ 377s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 377s] dh_auto_build: error: make -j1 returned exit code 2 [ 377s] make: *** [debian/rules:45: build] Error 25 [ 377s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 377s] ### VM INTERACTION START ### [ 378s] Powering off. [ 378s] [ 361.840798] reboot: Power down [ 379s] ### VM INTERACTION END ### [ 379s] [ 379s] lamb10 failed "build osmo-smlc_0.2.1.1.5b7f.202112200026.dsc" at Mon Dec 20 15:21:45 UTC 2021. [ 379s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:23:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:23:22 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c09ffaafcba_74d2b05e19645f81028743@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 418s] self.exec_dblatex() [ 418s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 418s] self.to_docbook() [ 418s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 418s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 418s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 418s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 418s] IndexError: tuple index out of range [ 418s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 418s] a2x: resource files: [] [ 418s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 418s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 418s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 418s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 418s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 418s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 418s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 418s] make[1]: *** [Makefile:377: all] Error 2 [ 418s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 418s] dh_auto_build: error: make -j1 returned exit code 2 [ 418s] make: *** [debian/rules:45: build] Error 25 [ 418s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 418s] ### VM INTERACTION START ### [ 419s] Powering off. [ 419s] [ 398.386233] reboot: Power down [ 419s] ### VM INTERACTION END ### [ 419s] [ 419s] lamb28 failed "build osmo-smlc_0.2.1.dsc" at Mon Dec 20 15:23:16 UTC 2021. [ 419s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:24:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:24:30 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0a0374023a_74d2b05e19645f810292f7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 488s] self.exec_dblatex() [ 488s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 488s] self.to_docbook() [ 488s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 488s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 488s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 488s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 488s] IndexError: tuple index out of range [ 488s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 488s] a2x: resource files: [] [ 488s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 488s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 488s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 488s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 488s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 488s] make[2]: *** [Makefile:454: all-recursive] Error 1 [ 488s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 488s] make[1]: *** [Makefile:386: all] Error 2 [ 488s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 488s] dh_auto_build: error: make -j1 returned exit code 2 [ 488s] make: *** [debian/rules:45: build] Error 25 [ 488s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 488s] ### VM INTERACTION START ### [ 489s] Powering off. [ 489s] [ 470.298218] reboot: Power down [ 489s] ### VM INTERACTION END ### [ 490s] [ 490s] lamb52 failed "build osmo-bsc_1.8.0.dsc" at Mon Dec 20 15:24:29 UTC 2021. [ 490s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:25:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:25:21 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0a06f17bd1_74d2b05e19645f810293fd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 201s] self.exec_dblatex() [ 201s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 201s] self.to_docbook() [ 201s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 201s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 201s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 201s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 201s] IndexError: tuple index out of range [ 201s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 201s] a2x: resource files: [] [ 201s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 201s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 201s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 201s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 201s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 201s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 201s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 201s] make[1]: *** [Makefile:402: all] Error 2 [ 201s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 201s] dh_auto_build: error: make -j1 returned exit code 2 [ 201s] make: *** [debian/rules:45: build] Error 25 [ 201s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 201s] ### VM INTERACTION START ### [ 202s] Powering off. [ 202s] [ 191.303339] reboot: Power down [ 202s] ### VM INTERACTION END ### [ 202s] [ 202s] goat19 failed "build osmo-msc_1.8.0.12.2ee27.202112200026.dsc" at Mon Dec 20 15:25:12 UTC 2021. [ 202s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:27:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:27:54 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0a108f4081_74d2b05e19645f810295b4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 355s] self.exec_dblatex() [ 355s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 355s] self.to_docbook() [ 355s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 355s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 355s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 355s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 355s] IndexError: tuple index out of range [ 355s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnodeb-usermanual.adoc'] [ 355s] a2x: resource files: [] [ 355s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 355s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnodeb-usermanual.pdf] Error 1 [ 355s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 355s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 355s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 355s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 355s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 355s] make[1]: *** [Makefile:394: all] Error 2 [ 355s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 355s] dh_auto_build: error: make -j1 returned exit code 2 [ 355s] make: *** [debian/rules:45: build] Error 25 [ 355s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 355s] ### VM INTERACTION START ### [ 356s] Powering off. [ 356s] [ 338.751949] reboot: Power down [ 356s] ### VM INTERACTION END ### [ 356s] [ 356s] lamb15 failed "build osmo-hnodeb_0.0.1.17.272f.202112200026.dsc" at Mon Dec 20 15:27:52 UTC 2021. [ 356s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:28:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:28:28 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0a127c0fd5_74d2b05e19645f810296d8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 726s] self.exec_dblatex() [ 726s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 726s] self.to_docbook() [ 726s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 726s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 726s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 726s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 726s] IndexError: tuple index out of range [ 726s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 726s] a2x: resource files: [] [ 726s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 726s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 726s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 726s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 726s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 726s] make[2]: *** [Makefile:475: all-recursive] Error 1 [ 726s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 726s] make[1]: *** [Makefile:393: all] Error 2 [ 726s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 726s] dh_auto_build: error: make -j1 returned exit code 2 [ 726s] make: *** [debian/rules:9: build] Error 25 [ 726s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 726s] ### VM INTERACTION START ### [ 727s] Powering off. [ 727s] [ 709.955621] reboot: Power down [ 727s] ### VM INTERACTION END ### [ 727s] [ 727s] lamb57 failed "build osmo-iuh_1.1.0.dsc" at Mon Dec 20 15:28:24 UTC 2021. [ 727s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:29:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:29:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0a15fe6d50_74d2b05e19645f810297a3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 423s] self.exec_dblatex() [ 423s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 423s] self.to_docbook() [ 423s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 423s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 423s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 423s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 423s] IndexError: tuple index out of range [ 423s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 423s] a2x: resource files: [] [ 423s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 423s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 423s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 423s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 423s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 423s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 423s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 423s] make[1]: *** [Makefile:394: all] Error 2 [ 423s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 423s] dh_auto_build: error: make -j1 returned exit code 2 [ 423s] make: *** [debian/rules:45: build] Error 25 [ 423s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 423s] ### VM INTERACTION START ### [ 425s] Powering off. [ 425s] [ 404.108168][ T1981] reboot: Power down [ 425s] ### VM INTERACTION END ### [ 425s] [ 425s] lamb04 failed "build osmo-sgsn_1.8.0.2.57425.202112200026.dsc" at Mon Dec 20 15:29:03 UTC 2021. [ 425s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:33:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:33:34 +0000 Subject: Build failure of network:osmocom:latest/osmo-hnodeb in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0a25114c4_74d2b05e19645f81030085@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hnodeb/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hnodeb failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hnodeb Last lines of build log: [ 192s] self.exec_dblatex() [ 192s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 192s] self.to_docbook() [ 192s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 192s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 192s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 192s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 192s] IndexError: tuple index out of range [ 192s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnodeb-usermanual.adoc'] [ 192s] a2x: resource files: [] [ 192s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 192s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnodeb-usermanual.pdf] Error 1 [ 192s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 192s] make[3]: *** [Makefile:389: all-recursive] Error 1 [ 192s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 192s] make[2]: *** [Makefile:458: all-recursive] Error 1 [ 192s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 192s] make[1]: *** [Makefile:390: all] Error 2 [ 192s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 192s] dh_auto_build: error: make -j1 returned exit code 2 [ 192s] make: *** [debian/rules:45: build] Error 25 [ 192s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 192s] ### VM INTERACTION START ### [ 194s] Powering off. [ 194s] [ 183.301841] reboot: Power down [ 194s] ### VM INTERACTION END ### [ 194s] [ 194s] goat13 failed "build osmo-hnodeb_0.0.1.dsc" at Mon Dec 20 15:33:18 UTC 2021. [ 194s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:33:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:33:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0a2704877_74d2b05e19645f81030140@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 222s] self.exec_dblatex() [ 222s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 222s] self.to_docbook() [ 222s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 222s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 222s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 222s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 222s] IndexError: tuple index out of range [ 222s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 222s] a2x: resource files: [] [ 222s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 222s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 222s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 222s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 222s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 222s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 222s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 222s] make[1]: *** [Makefile:394: all] Error 2 [ 222s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 222s] dh_auto_build: error: make -j1 returned exit code 2 [ 222s] make: *** [debian/rules:45: build] Error 25 [ 222s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 222s] ### VM INTERACTION START ### [ 223s] Powering off. [ 223s] [ 212.394398] reboot: Power down [ 223s] ### VM INTERACTION END ### [ 223s] [ 223s] build73 failed "build osmo-sgsn_1.8.0.dsc" at Mon Dec 20 15:33:49 UTC 2021. [ 223s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 15:36:41 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 15:36:41 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0a32375477_74d2b05e19645f8103026c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 370s] self.exec_dblatex() [ 370s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 370s] self.to_docbook() [ 370s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 370s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 370s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 370s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 370s] IndexError: tuple index out of range [ 370s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 370s] a2x: resource files: [] [ 370s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 370s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 370s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 370s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 370s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 370s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 370s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 370s] make[1]: *** [Makefile:402: all] Error 2 [ 370s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 370s] dh_auto_build: error: make -j1 returned exit code 2 [ 370s] make: *** [debian/rules:45: build] Error 25 [ 370s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 370s] ### VM INTERACTION START ### [ 371s] Powering off. [ 371s] [ 354.283757] reboot: Power down [ 371s] ### VM INTERACTION END ### [ 371s] [ 371s] lamb22 failed "build osmo-msc_1.8.0.dsc" at Mon Dec 20 15:36:24 UTC 2021. [ 371s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:29:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:29:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f5c171134_74d2b05e19645f81085365@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 233s] self.__getattribute__('to_'+self.format)() [ 233s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 233s] self.exec_dblatex() [ 233s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 233s] self.to_docbook() [ 233s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 233s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 233s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 233s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 233s] IndexError: tuple index out of range [ 233s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 233s] a2x: resource files: [] [ 233s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 233s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 233s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 233s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 233s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 233s] make[1]: *** [Makefile:363: all] Error 2 [ 233s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 233s] dh_auto_build: error: make -j1 returned exit code 2 [ 233s] make: *** [debian/rules:5: binary] Error 25 [ 233s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 233s] ### VM INTERACTION START ### [ 234s] Powering off. [ 234s] [ 222.029746] reboot: Power down [ 234s] ### VM INTERACTION END ### [ 234s] [ 234s] build72 failed "build osmo-gsm-manuals-dev_1.2.0.202112200026.dsc" at Mon Dec 20 21:29:14 UTC 2021. [ 234s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:31:17 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:31:17 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f6375b647_74d2b05e19645f810855a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 353s] self.__getattribute__('to_'+self.format)() [ 353s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 353s] self.exec_dblatex() [ 353s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 353s] self.to_docbook() [ 353s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 353s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 353s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 353s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 353s] IndexError: tuple index out of range [ 353s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 353s] a2x: resource files: [] [ 353s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 353s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 353s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 353s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 353s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 353s] make[1]: *** [Makefile:363: all] Error 2 [ 353s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 353s] dh_auto_build: error: make -j1 returned exit code 2 [ 353s] make: *** [debian/rules:5: binary] Error 25 [ 353s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 353s] ### VM INTERACTION START ### [ 354s] Powering off. [ 354s] [ 336.044045] reboot: Power down [ 354s] ### VM INTERACTION END ### [ 354s] [ 354s] lamb53 failed "build osmo-gsm-manuals-dev_1.2.0.dsc" at Mon Dec 20 21:31:06 UTC 2021. [ 354s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:36:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:36:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f764b2aa3_74d2b05e19645f810865b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 196s] self.exec_dblatex() [ 196s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 196s] self.to_docbook() [ 196s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 196s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 196s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 196s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 196s] IndexError: tuple index out of range [ 196s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 196s] a2x: resource files: [] [ 196s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 196s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 196s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 196s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 196s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 196s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 196s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 196s] make[1]: *** [Makefile:423: all] Error 2 [ 196s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 196s] dh_auto_build: error: make -j1 returned exit code 2 [ 196s] make: *** [debian/rules:17: build] Error 25 [ 196s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 196s] ### VM INTERACTION START ### [ 197s] Powering off. [ 197s] [ 186.319513] reboot: Power down [ 197s] ### VM INTERACTION END ### [ 197s] [ 197s] goat13 failed "build osmo-mgw_1.9.0.7.bc3f.202112200026.dsc" at Mon Dec 20 21:35:50 UTC 2021. [ 197s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:36:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:36:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f764d7d6e_74d2b05e19645f8108667@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 284s] self.exec_dblatex() [ 284s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 284s] self.to_docbook() [ 284s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 284s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 284s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 284s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 284s] IndexError: tuple index out of range [ 284s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 284s] a2x: resource files: [] [ 284s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 284s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 284s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 284s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 284s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 284s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 284s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 284s] make[1]: *** [Makefile:392: all] Error 2 [ 284s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 284s] dh_auto_build: error: make -j1 returned exit code 2 [ 284s] make: *** [debian/rules:15: build] Error 25 [ 284s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 284s] ### VM INTERACTION START ### [ 285s] Powering off. [ 285s] [ 270.870240] reboot: Power down [ 285s] ### VM INTERACTION END ### [ 285s] [ 285s] sheep86 failed "build osmo-ggsn_1.8.0.202112200026.dsc" at Mon Dec 20 21:35:50 UTC 2021. [ 285s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:36:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:36:06 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f765244d9_74d2b05e19645f8108671a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 207s] self.exec_dblatex() [ 207s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 207s] self.to_docbook() [ 207s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 207s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 207s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 207s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 207s] IndexError: tuple index out of range [ 207s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 207s] a2x: resource files: [] [ 207s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 207s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 207s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 207s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 207s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 207s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 207s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 207s] make[1]: *** [Makefile:403: all] Error 2 [ 207s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 207s] dh_auto_build: error: make -j1 returned exit code 2 [ 207s] make: *** [debian/rules:12: build] Error 25 [ 207s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 207s] ### VM INTERACTION START ### [ 208s] Powering off. [ 208s] [ 197.658382] reboot: Power down [ 209s] ### VM INTERACTION END ### [ 209s] [ 209s] goat19 failed "build libosmo-sccp_1.5.0.2.0432.202112200026.dsc" at Mon Dec 20 21:36:02 UTC 2021. [ 209s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:36:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:36:23 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f76586e0f_74d2b05e19645f810868f7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 189s] self.exec_dblatex() [ 189s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 189s] self.to_docbook() [ 189s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 189s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 189s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 189s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 189s] IndexError: tuple index out of range [ 189s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 189s] a2x: resource files: [] [ 189s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 189s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 189s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 189s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 189s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 189s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 189s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 189s] make[1]: *** [Makefile:377: all] Error 2 [ 189s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 189s] dh_auto_build: error: make -j1 returned exit code 2 [ 189s] make: *** [debian/rules:45: build] Error 25 [ 189s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 189s] ### VM INTERACTION START ### [ 190s] Powering off. [ 190s] [ 179.786580] reboot: Power down [ 191s] ### VM INTERACTION END ### [ 191s] [ 191s] goat17 failed "build osmo-gbproxy_0.2.0.dsc" at Mon Dec 20 21:36:11 UTC 2021. [ 191s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:37:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:37:31 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f7a2db4f6_74d2b05e19645f81086983@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 367s] self.exec_dblatex() [ 367s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 367s] self.to_docbook() [ 367s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 367s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 367s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 367s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 367s] IndexError: tuple index out of range [ 367s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 367s] a2x: resource files: [] [ 367s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 367s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 367s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 367s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 367s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 367s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 367s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 367s] make[1]: *** [Makefile:327: all] Error 2 [ 367s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 367s] dh_auto_build: error: make -j1 returned exit code 2 [ 367s] make: *** [debian/rules:12: build] Error 25 [ 367s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 367s] ### VM INTERACTION START ### [ 368s] Powering off. [ 368s] [ 348.967523] reboot: Power down [ 368s] ### VM INTERACTION END ### [ 368s] [ 368s] lamb21 failed "build osmo-sip-connector_1.6.0.202112200026.dsc" at Mon Dec 20 21:37:26 UTC 2021. [ 368s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:37:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:37:48 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f7c12b4d0_74d2b05e19645f8108706b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gbproxy Last lines of build log: [ 383s] self.exec_dblatex() [ 383s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 383s] self.to_docbook() [ 383s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 383s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 383s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 383s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 383s] IndexError: tuple index out of range [ 383s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 383s] a2x: resource files: [] [ 383s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 383s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 383s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 383s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 383s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 383s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 383s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 383s] make[1]: *** [Makefile:377: all] Error 2 [ 383s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 383s] dh_auto_build: error: make -j1 returned exit code 2 [ 383s] make: *** [debian/rules:45: build] Error 25 [ 383s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 383s] ### VM INTERACTION START ### [ 384s] Powering off. [ 384s] [ 365.334257] reboot: Power down [ 384s] ### VM INTERACTION END ### [ 384s] [ 384s] lamb55 failed "build osmo-gbproxy_0.2.0.4.28ec0.202112200026.dsc" at Mon Dec 20 21:37:42 UTC 2021. [ 384s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:38:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:38:05 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f7c191d98_74d2b05e19645f81087115@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 404s] self.__getattribute__('to_'+self.format)() [ 404s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 404s] self.exec_dblatex() [ 404s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 404s] self.to_docbook() [ 404s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 404s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 404s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 404s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 404s] IndexError: tuple index out of range [ 404s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 404s] a2x: resource files: [] [ 404s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 404s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 404s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 404s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 404s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 404s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 404s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 404s] dh_auto_build: error: make -j1 returned exit code 2 [ 404s] make: *** [debian/rules:12: build] Error 25 [ 404s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 404s] ### VM INTERACTION START ### [ 405s] Powering off. [ 405s] [ 386.385096] reboot: Power down [ 405s] ### VM INTERACTION END ### [ 405s] [ 405s] old-cirrus2 failed "build osmo-pcu_1.0.0.1.8d03.202112200026.dsc" at Mon Dec 20 21:37:59 UTC 2021. [ 405s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:38:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:38:39 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f7e07ac5c_74d2b05e19645f8108724e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 358s] self.exec_dblatex() [ 358s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 358s] self.to_docbook() [ 358s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 358s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 358s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 358s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 358s] IndexError: tuple index out of range [ 358s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 358s] a2x: resource files: [] [ 358s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 358s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 358s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 358s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 358s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 358s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 358s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 358s] make[1]: *** [Makefile:368: all] Error 2 [ 358s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 358s] dh_auto_build: error: make -j1 returned exit code 2 [ 358s] make: *** [debian/rules:45: build] Error 25 [ 358s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 358s] ### VM INTERACTION START ### [ 359s] Powering off. [ 359s] [ 342.556104] reboot: Power down [ 360s] ### VM INTERACTION END ### [ 360s] [ 360s] lamb20 failed "build osmo-cbc_0.2.3.202112200026.dsc" at Mon Dec 20 21:38:37 UTC 2021. [ 360s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:38:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:38:39 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f7e0d2648_74d2b05e19645f810873e5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 219s] self.exec_dblatex() [ 219s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 219s] self.to_docbook() [ 219s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 219s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 219s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 219s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 219s] IndexError: tuple index out of range [ 219s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 219s] a2x: resource files: [] [ 219s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 219s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 219s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 219s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 219s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 219s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 219s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 219s] make[1]: *** [Makefile:410: all] Error 2 [ 219s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 219s] dh_auto_build: error: make -j1 returned exit code 2 [ 219s] make: *** [debian/rules:7: build] Error 25 [ 219s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 219s] ### VM INTERACTION START ### [ 220s] Powering off. [ 220s] [ 210.893706] reboot: Power down [ 220s] ### VM INTERACTION END ### [ 220s] [ 220s] goat03 failed "build osmo-hlr_1.4.0.dsc" at Mon Dec 20 21:38:26 UTC 2021. [ 220s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:38:56 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:38:56 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f7fa44e99_74d2b05e19645f810874ca@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 369s] self.exec_dblatex() [ 369s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 369s] self.to_docbook() [ 369s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 369s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 369s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 369s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 369s] IndexError: tuple index out of range [ 369s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 369s] a2x: resource files: [] [ 369s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 369s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 369s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 369s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 369s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 369s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 369s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 369s] make[1]: *** [Makefile:410: all] Error 2 [ 369s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 369s] dh_auto_build: error: make -j1 returned exit code 2 [ 369s] make: *** [debian/rules:7: build] Error 25 [ 369s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 369s] ### VM INTERACTION START ### [ 370s] Powering off. [ 370s] [ 352.307522] reboot: Power down [ 370s] ### VM INTERACTION END ### [ 370s] [ 370s] lamb16 failed "build osmo-hlr_1.4.0.1.37a5.202112200026.dsc" at Mon Dec 20 21:38:51 UTC 2021. [ 370s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:39:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:39:13 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f8189314b_74d2b05e19645f8108757c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 366s] self.exec_dblatex() [ 366s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 366s] self.to_docbook() [ 366s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 366s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 366s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 366s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 366s] IndexError: tuple index out of range [ 366s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 366s] a2x: resource files: [] [ 366s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 366s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 366s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 366s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 366s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 366s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 366s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 366s] make[1]: *** [Makefile:392: all] Error 2 [ 366s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 366s] dh_auto_build: error: make -j1 returned exit code 2 [ 366s] make: *** [debian/rules:15: build] Error 25 [ 366s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 366s] ### VM INTERACTION START ### [ 367s] Powering off. [ 367s] [ 349.359238] reboot: Power down [ 367s] ### VM INTERACTION END ### [ 367s] [ 367s] lamb61 failed "build osmo-ggsn_1.8.0.dsc" at Mon Dec 20 21:39:10 UTC 2021. [ 367s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:39:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:39:13 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f8191c6ed_74d2b05e19645f81087779@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 346s] self.exec_dblatex() [ 346s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 346s] self.to_docbook() [ 346s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 346s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 346s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 346s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 346s] IndexError: tuple index out of range [ 346s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 346s] a2x: resource files: [] [ 346s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 346s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 346s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 346s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 346s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 346s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 346s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 346s] make[1]: *** [Makefile:327: all] Error 2 [ 346s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 346s] dh_auto_build: error: make -j1 returned exit code 2 [ 346s] make: *** [debian/rules:12: build] Error 25 [ 346s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 346s] ### VM INTERACTION START ### [ 347s] Powering off. [ 347s] [ 330.057738] reboot: Power down [ 347s] ### VM INTERACTION END ### [ 347s] [ 347s] lamb70 failed "build osmo-sip-connector_1.6.0.dsc" at Mon Dec 20 21:39:02 UTC 2021. [ 347s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:39:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:39:13 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f818ce6c7_74d2b05e19645f810876d5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 255s] self.exec_dblatex() [ 255s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 255s] self.to_docbook() [ 255s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 255s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 255s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 255s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 255s] IndexError: tuple index out of range [ 255s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 255s] a2x: resource files: [] [ 255s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 255s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 255s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 255s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 255s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 255s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 255s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 255s] make[1]: *** [Makefile:403: all] Error 2 [ 255s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 255s] dh_auto_build: error: make -j1 returned exit code 2 [ 255s] make: *** [debian/rules:12: build] Error 25 [ 255s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 255s] ### VM INTERACTION START ### [ 256s] Powering off. [ 256s] [ 244.971150] reboot: Power down [ 256s] ### VM INTERACTION END ### [ 256s] [ 256s] build70 failed "build libosmo-sccp_1.5.0.dsc" at Mon Dec 20 21:38:57 UTC 2021. [ 256s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:39:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:39:30 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f8195d98c_74d2b05e19645f810878d9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 276s] self.exec_dblatex() [ 276s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 276s] self.to_docbook() [ 276s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 276s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 276s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 276s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 276s] IndexError: tuple index out of range [ 276s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 276s] a2x: resource files: [] [ 276s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 276s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 276s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 276s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 276s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 276s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 276s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 276s] make[1]: *** [Makefile:368: all] Error 2 [ 276s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 276s] dh_auto_build: error: make -j1 returned exit code 2 [ 276s] make: *** [debian/rules:45: build] Error 25 [ 276s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 276s] ### VM INTERACTION START ### [ 277s] Powering off. [ 277s] [ 263.069763] reboot: Power down [ 277s] ### VM INTERACTION END ### [ 277s] [ 277s] sheep87 failed "build osmo-cbc_0.2.3.dsc" at Mon Dec 20 21:39:20 UTC 2021. [ 277s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:39:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:39:30 +0000 Subject: Build failure of network:osmocom:nightly/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f8198170f_74d2b05e19645f81087926@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-smlc Last lines of build log: [ 190s] self.exec_dblatex() [ 190s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 190s] self.to_docbook() [ 190s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 190s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 190s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 190s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 190s] IndexError: tuple index out of range [ 190s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 190s] a2x: resource files: [] [ 190s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 190s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 190s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 190s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 190s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 190s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 190s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 190s] make[1]: *** [Makefile:377: all] Error 2 [ 190s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 190s] dh_auto_build: error: make -j1 returned exit code 2 [ 190s] make: *** [debian/rules:45: build] Error 25 [ 190s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 190s] ### VM INTERACTION START ### [ 191s] Powering off. [ 191s] [ 181.035314] reboot: Power down [ 191s] ### VM INTERACTION END ### [ 191s] [ 191s] goat19 failed "build osmo-smlc_0.2.1.1.5b7f.202112200026.dsc" at Mon Dec 20 21:39:20 UTC 2021. [ 191s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:39:47 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:39:47 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f8383ce79_74d2b05e19645f81088094@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 504s] self.exec_dblatex() [ 504s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 504s] self.to_docbook() [ 504s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 504s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 504s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 504s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 504s] IndexError: tuple index out of range [ 504s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 504s] a2x: resource files: [] [ 504s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 504s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 504s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 504s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 504s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 504s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 504s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 504s] make[1]: *** [Makefile:452: all] Error 2 [ 504s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 504s] dh_auto_build: error: make -j1 returned exit code 2 [ 504s] make: *** [debian/rules:6: build] Error 25 [ 504s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 504s] ### VM INTERACTION START ### [ 505s] Powering off. [ 505s] [ 483.856752] reboot: Power down [ 506s] ### VM INTERACTION END ### [ 506s] [ 506s] lamb57 failed "build osmo-trx_1.4.0.1.424c.202112200026.dsc" at Mon Dec 20 21:39:38 UTC 2021. [ 506s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:40:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:40:04 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f838b994f_74d2b05e19645f81088149@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 396s] self.__getattribute__('to_'+self.format)() [ 396s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 396s] self.exec_dblatex() [ 396s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 396s] self.to_docbook() [ 396s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 396s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 396s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 396s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 396s] IndexError: tuple index out of range [ 396s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 396s] a2x: resource files: [] [ 396s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 396s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 396s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 396s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 396s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 396s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 396s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 396s] dh_auto_build: error: make -j1 returned exit code 2 [ 396s] make: *** [debian/rules:12: build] Error 25 [ 396s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 396s] ### VM INTERACTION START ### [ 397s] Powering off. [ 397s] [ 380.193330] reboot: Power down [ 398s] ### VM INTERACTION END ### [ 398s] [ 398s] lamb54 failed "build osmo-pcu_1.0.0.dsc" at Mon Dec 20 21:39:48 UTC 2021. [ 398s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:40:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:40:21 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f8573195e_74d2b05e19645f81088247@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 241s] self.exec_dblatex() [ 241s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 241s] self.to_docbook() [ 241s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 241s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 241s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 241s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 241s] IndexError: tuple index out of range [ 241s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 241s] a2x: resource files: [] [ 241s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 241s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 241s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 241s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 241s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 241s] make[2]: *** [Makefile:454: all-recursive] Error 1 [ 241s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 241s] make[1]: *** [Makefile:386: all] Error 2 [ 241s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 241s] dh_auto_build: error: make -j1 returned exit code 2 [ 241s] make: *** [debian/rules:45: build] Error 25 [ 241s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 241s] ### VM INTERACTION START ### [ 242s] Powering off. [ 242s] [ 231.529541] reboot: Power down [ 242s] ### VM INTERACTION END ### [ 242s] [ 242s] goat11 failed "build osmo-bsc_1.8.0.16.260eb.202112200026.dsc" at Mon Dec 20 21:40:12 UTC 2021. [ 242s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:40:55 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:40:55 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f871482fe_74d2b05e19645f810883fe@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 367s] self.exec_dblatex() [ 367s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 367s] self.to_docbook() [ 367s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 367s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 367s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 367s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 367s] IndexError: tuple index out of range [ 367s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 367s] a2x: resource files: [] [ 367s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 367s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 367s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 367s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 367s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 367s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 367s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 367s] make[1]: *** [Makefile:423: all] Error 2 [ 367s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 367s] dh_auto_build: error: make -j1 returned exit code 2 [ 367s] make: *** [debian/rules:17: build] Error 25 [ 367s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 367s] ### VM INTERACTION START ### [ 368s] Powering off. [ 368s] [ 350.153305] reboot: Power down [ 368s] ### VM INTERACTION END ### [ 368s] [ 368s] old-cirrus2 failed "build osmo-mgw_1.9.0.dsc" at Mon Dec 20 21:40:49 UTC 2021. [ 368s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:42:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:42:03 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f8aea150e_74d2b05e19645f8108865b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 354s] self.exec_dblatex() [ 354s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 354s] self.to_docbook() [ 354s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 354s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 354s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 354s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 354s] IndexError: tuple index out of range [ 354s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 354s] a2x: resource files: [] [ 354s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 354s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 354s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 354s] make[3]: *** [Makefile:386: all-recursive] Error 1 [ 354s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 354s] make[2]: *** [Makefile:484: all-recursive] Error 1 [ 354s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 354s] make[1]: *** [Makefile:408: all] Error 2 [ 354s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 354s] dh_auto_build: error: make -j1 returned exit code 2 [ 354s] make: *** [debian/rules:14: build] Error 25 [ 354s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 354s] ### VM INTERACTION START ### [ 355s] Powering off. [ 355s] [ 339.305460] reboot: Power down [ 355s] ### VM INTERACTION END ### [ 355s] [ 355s] old-atreju5 failed "build osmo-remsim_1.0.0.4.0c832.202112200026.dsc" at Mon Dec 20 21:41:51 UTC 2021. [ 355s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:42:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:42:03 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f8aedff91_74d2b05e19645f8108879d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 409s] self.exec_dblatex() [ 409s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 409s] self.to_docbook() [ 409s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 409s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 409s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 409s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 409s] IndexError: tuple index out of range [ 409s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 409s] a2x: resource files: [] [ 409s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 409s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 409s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 409s] make[3]: *** [Makefile:386: all-recursive] Error 1 [ 409s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 409s] make[2]: *** [Makefile:484: all-recursive] Error 1 [ 409s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 409s] make[1]: *** [Makefile:408: all] Error 2 [ 409s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 409s] dh_auto_build: error: make -j1 returned exit code 2 [ 409s] make: *** [debian/rules:14: build] Error 25 [ 409s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 409s] ### VM INTERACTION START ### [ 410s] Powering off. [ 410s] [ 391.515525] reboot: Power down [ 411s] ### VM INTERACTION END ### [ 411s] [ 411s] lamb27 failed "build osmo-remsim_1.0.0.dsc" at Mon Dec 20 21:41:59 UTC 2021. [ 411s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:42:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:42:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f8ecda49_74d2b05e19645f810888f4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 376s] self.exec_dblatex() [ 376s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 376s] self.to_docbook() [ 376s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 376s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 376s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 376s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 376s] IndexError: tuple index out of range [ 376s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 376s] a2x: resource files: [] [ 376s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 376s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 376s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 376s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 376s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 376s] make[2]: *** [Makefile:475: all-recursive] Error 1 [ 376s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 376s] make[1]: *** [Makefile:393: all] Error 2 [ 376s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 376s] dh_auto_build: error: make -j1 returned exit code 2 [ 376s] make: *** [debian/rules:9: build] Error 25 [ 376s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 376s] ### VM INTERACTION START ### [ 377s] Powering off. [ 377s] [ 366.537926] reboot: Power down [ 377s] ### VM INTERACTION END ### [ 377s] [ 377s] goat17 failed "build osmo-iuh_1.1.0.1.9b4d.202112200026.dsc" at Mon Dec 20 21:42:26 UTC 2021. [ 377s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:42:54 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:42:54 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f8ec6c1c6_74d2b05e19645f81088968@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 570s] self.exec_dblatex() [ 570s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 570s] self.to_docbook() [ 570s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 570s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 570s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 570s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 570s] IndexError: tuple index out of range [ 570s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 570s] a2x: resource files: [] [ 570s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 570s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 570s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 570s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 570s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 570s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 570s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 570s] make[1]: *** [Makefile:452: all] Error 2 [ 570s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 570s] dh_auto_build: error: make -j1 returned exit code 2 [ 570s] make: *** [debian/rules:6: build] Error 25 [ 570s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 570s] ### VM INTERACTION START ### [ 571s] Powering off. [ 571s] [ 538.253681] reboot: Power down [ 571s] ### VM INTERACTION END ### [ 571s] [ 571s] cloud132 failed "build osmo-trx_1.4.0.dsc" at Mon Dec 20 21:42:40 UTC 2021. [ 571s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:45:27 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:45:27 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f980e1a15_74d2b05e19645f810893c0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 362s] self.exec_dblatex() [ 362s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 362s] self.to_docbook() [ 362s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 362s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 362s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 362s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 362s] IndexError: tuple index out of range [ 362s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 362s] a2x: resource files: [] [ 362s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 362s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 362s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 362s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 362s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 362s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 362s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 362s] make[1]: *** [Makefile:377: all] Error 2 [ 362s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 362s] dh_auto_build: error: make -j1 returned exit code 2 [ 362s] make: *** [debian/rules:45: build] Error 25 [ 362s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 362s] ### VM INTERACTION START ### [ 363s] Powering off. [ 363s] [ 345.486185] reboot: Power down [ 363s] ### VM INTERACTION END ### [ 363s] [ 363s] lamb19 failed "build osmo-smlc_0.2.1.dsc" at Mon Dec 20 21:45:12 UTC 2021. [ 363s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:47:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:47:09 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hnodeb in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0f9f8b3cf9_74d2b05e19645f810896e8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: [ 264s] self.exec_dblatex() [ 264s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 264s] self.to_docbook() [ 264s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 264s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 264s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 264s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 264s] IndexError: tuple index out of range [ 264s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnodeb-usermanual.adoc'] [ 264s] a2x: resource files: [] [ 264s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 264s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnodeb-usermanual.pdf] Error 1 [ 264s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 264s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 264s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 264s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 264s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 264s] make[1]: *** [Makefile:394: all] Error 2 [ 264s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 264s] dh_auto_build: error: make -j1 returned exit code 2 [ 264s] make: *** [debian/rules:45: build] Error 25 [ 264s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 264s] ### VM INTERACTION START ### [ 266s] Powering off. [ 266s] [ 251.974278] reboot: Power down [ 266s] ### VM INTERACTION END ### [ 266s] [ 266s] sheep86 failed "build osmo-hnodeb_0.0.1.17.272f.202112200026.dsc" at Mon Dec 20 21:47:06 UTC 2021. [ 266s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:48:34 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:48:34 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0fa36dbb1e_74d2b05e19645f81089757@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 447s] self.exec_dblatex() [ 447s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 447s] self.to_docbook() [ 447s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 447s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 447s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 447s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 447s] IndexError: tuple index out of range [ 447s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 447s] a2x: resource files: [] [ 447s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 447s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 447s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 447s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 447s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 447s] make[2]: *** [Makefile:454: all-recursive] Error 1 [ 447s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 447s] make[1]: *** [Makefile:386: all] Error 2 [ 447s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 447s] dh_auto_build: error: make -j1 returned exit code 2 [ 447s] make: *** [debian/rules:45: build] Error 25 [ 447s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 447s] ### VM INTERACTION START ### [ 448s] Powering off. [ 448s] [ 431.020173] reboot: Power down [ 448s] ### VM INTERACTION END ### [ 448s] [ 448s] lamb09 failed "build osmo-bsc_1.8.0.dsc" at Mon Dec 20 21:48:31 UTC 2021. [ 448s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:48:51 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:48:51 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0fa55c316f_74d2b05e19645f810899c2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 368s] self.exec_dblatex() [ 368s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 368s] self.to_docbook() [ 368s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 368s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 368s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 368s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 368s] IndexError: tuple index out of range [ 368s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 368s] a2x: resource files: [] [ 368s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 368s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 368s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 368s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 368s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 368s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 368s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 368s] make[1]: *** [Makefile:402: all] Error 2 [ 368s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 368s] dh_auto_build: error: make -j1 returned exit code 2 [ 368s] make: *** [debian/rules:45: build] Error 25 [ 368s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 368s] ### VM INTERACTION START ### [ 369s] Powering off. [ 369s] [ 352.150051] reboot: Power down [ 369s] ### VM INTERACTION END ### [ 369s] [ 369s] lamb07 failed "build osmo-msc_1.8.0.12.2ee27.202112200026.dsc" at Mon Dec 20 21:48:47 UTC 2021. [ 369s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:49:25 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:49:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0fa6fc0a58_74d2b05e19645f8109015f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 394s] self.exec_dblatex() [ 394s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 394s] self.to_docbook() [ 394s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 394s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 394s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 394s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 394s] IndexError: tuple index out of range [ 394s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 394s] a2x: resource files: [] [ 394s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 394s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 394s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 394s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 394s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 394s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 394s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 394s] make[1]: *** [Makefile:394: all] Error 2 [ 394s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 394s] dh_auto_build: error: make -j1 returned exit code 2 [ 394s] make: *** [debian/rules:45: build] Error 25 [ 394s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 394s] ### VM INTERACTION START ### [ 395s] Powering off. [ 395s] [ 377.331810] reboot: Power down [ 395s] ### VM INTERACTION END ### [ 395s] [ 395s] lamb60 failed "build osmo-sgsn_1.8.0.2.57425.202112200026.dsc" at Mon Dec 20 21:49:20 UTC 2021. [ 395s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:51:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:51:24 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0faeb16e98_74d2b05e19645f8109063d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 720s] self.exec_dblatex() [ 720s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 720s] self.to_docbook() [ 720s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 720s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 720s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 720s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 720s] IndexError: tuple index out of range [ 720s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 720s] a2x: resource files: [] [ 720s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 720s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 720s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 720s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 720s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 720s] make[2]: *** [Makefile:475: all-recursive] Error 1 [ 720s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 720s] make[1]: *** [Makefile:393: all] Error 2 [ 720s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 720s] dh_auto_build: error: make -j1 returned exit code 2 [ 720s] make: *** [debian/rules:9: build] Error 25 [ 720s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 720s] ### VM INTERACTION START ### [ 722s] Powering off. [ 722s] [ 705.466950] reboot: Power down [ 722s] ### VM INTERACTION END ### [ 722s] [ 722s] lamb21 failed "build osmo-iuh_1.1.0.dsc" at Mon Dec 20 21:51:13 UTC 2021. [ 722s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:55:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:55:22 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0fbd83733d_74d2b05e19645f8109133e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 225s] self.exec_dblatex() [ 225s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 225s] self.to_docbook() [ 225s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 225s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 225s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 225s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 225s] IndexError: tuple index out of range [ 225s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 225s] a2x: resource files: [] [ 225s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 225s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 225s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 225s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 225s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 225s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 225s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 225s] make[1]: *** [Makefile:394: all] Error 2 [ 225s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 225s] dh_auto_build: error: make -j1 returned exit code 2 [ 225s] make: *** [debian/rules:45: build] Error 25 [ 225s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 225s] ### VM INTERACTION START ### [ 226s] Powering off. [ 226s] [ 215.774089] reboot: Power down [ 226s] ### VM INTERACTION END ### [ 226s] [ 226s] build74 failed "build osmo-sgsn_1.8.0.dsc" at Mon Dec 20 21:55:08 UTC 2021. [ 226s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:55:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:55:22 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0fbd8908d1_74d2b05e19645f810914a1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 235s] self.exec_dblatex() [ 235s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 235s] self.to_docbook() [ 235s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 235s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 235s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 235s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 235s] IndexError: tuple index out of range [ 235s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 235s] a2x: resource files: [] [ 235s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 235s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 235s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 235s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 235s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 235s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 235s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 235s] make[1]: *** [Makefile:402: all] Error 2 [ 235s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 235s] dh_auto_build: error: make -j1 returned exit code 2 [ 235s] make: *** [debian/rules:45: build] Error 25 [ 235s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 235s] ### VM INTERACTION START ### [ 236s] Powering off. [ 236s] [ 224.808771] reboot: Power down [ 236s] ### VM INTERACTION END ### [ 236s] [ 236s] build77 failed "build osmo-msc_1.8.0.dsc" at Mon Dec 20 21:55:21 UTC 2021. [ 236s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Mon Dec 20 21:57:38 2021 From: noreply at opensuse.org (OBS Notification) Date: Mon, 20 Dec 2021 21:57:38 +0000 Subject: Build failure of network:osmocom:latest/osmo-hnodeb in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c0fc53ccdf6_74d2b05e19645f8109201e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hnodeb/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hnodeb failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hnodeb Last lines of build log: [ 358s] self.exec_dblatex() [ 358s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 358s] self.to_docbook() [ 358s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 358s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 358s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 358s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 358s] IndexError: tuple index out of range [ 358s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnodeb-usermanual.adoc'] [ 358s] a2x: resource files: [] [ 358s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 358s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnodeb-usermanual.pdf] Error 1 [ 358s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 358s] make[3]: *** [Makefile:389: all-recursive] Error 1 [ 358s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 358s] make[2]: *** [Makefile:458: all-recursive] Error 1 [ 358s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 358s] make[1]: *** [Makefile:390: all] Error 2 [ 358s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 358s] dh_auto_build: error: make -j1 returned exit code 2 [ 358s] make: *** [debian/rules:45: build] Error 25 [ 358s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 358s] ### VM INTERACTION START ### [ 359s] Powering off. [ 359s] [ 341.486061] reboot: Power down [ 360s] ### VM INTERACTION END ### [ 360s] [ 360s] lamb21 failed "build osmo-hnodeb_0.0.1.dsc" at Mon Dec 20 21:57:29 UTC 2021. [ 360s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 00:29:13 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 00:29:13 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c11ff3b8972_74d2b05e19645f811255cb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 49s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 49s] exit ... [ 49s] ### VM INTERACTION START ### [ 52s] [ 12.959350] sysrq: SysRq : Power Off [ 52s] [ 12.963886] reboot: Power down [ 53s] ### VM INTERACTION END ### [ 53s] [ 53s] obs-arm-6 failed "build libosmocore.spec" at Tue Dec 21 00:28:57 UTC 2021. [ 53s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 00:30:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 00:30:04 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c1200e2b448_74d2b05e19645f811256fa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 45s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 45s] exit ... [ 45s] ### VM INTERACTION START ### [ 49s] [ 9.344244] sysrq: SysRq : Power Off [ 49s] [ 9.345044] reboot: Power down [ 49s] ### VM INTERACTION END ### [ 49s] [ 49s] obs-arm-11 failed "build libosmocore.spec" at Tue Dec 21 00:29:48 UTC 2021. [ 49s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 00:30:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 00:30:21 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c1202cb5792_74d2b05e19645f811257f9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 13s] file /usr/lib/system[ 3.887702] serial8250: too much work for irq4 [ 13s] d/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 13s] exit ... [ 13s] ### VM INTERACTION START ### [ 17s] [ 7.197687] sysrq: SysRq : Power Off [ 17s] [ 7.201522] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] old-cirrus4 failed "build libosmocore.spec" at Tue Dec 21 00:30:18 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 00:30:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 00:30:21 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c1202ce3591_74d2b05e19645f81125882@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 15s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 15s] exit ... [ 15s] ### VM INTERACTION START ### [ 18s] [ 8.601814] sysrq: Power Off [ 18s] [ 8.606342] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] lamb59 failed "build libosmocore.spec" at Tue Dec 21 00:30:18 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 00:36:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 00:36:35 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c1219715756_74d2b05e19645f81126343@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 353s] self.__getattribute__('to_'+self.format)() [ 353s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 353s] self.exec_dblatex() [ 353s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 353s] self.to_docbook() [ 353s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 353s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 353s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 353s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 353s] IndexError: tuple index out of range [ 353s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 353s] a2x: resource files: [] [ 353s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 353s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 353s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 353s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 353s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 353s] make[1]: *** [Makefile:363: all] Error 2 [ 353s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 353s] dh_auto_build: error: make -j1 returned exit code 2 [ 353s] make: *** [debian/rules:5: binary] Error 25 [ 353s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 353s] ### VM INTERACTION START ### [ 354s] Powering off. [ 354s] [ 336.271113] reboot: Power down [ 354s] ### VM INTERACTION END ### [ 354s] [ 354s] old-cirrus2 failed "build osmo-gsm-manuals-dev_1.2.0.202112210026.dsc" at Tue Dec 21 00:36:26 UTC 2021. [ 354s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 00:40:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 00:40:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61c122a17dfe0_74d2b05e19645f8112689a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 239s] #define VERSION "0.2.3" [ 239s] #define STDC_HEADERS 1 [ 239s] #define HAVE_SYS_TYPES_H 1 [ 239s] #define HAVE_SYS_STAT_H 1 [ 239s] #define HAVE_STDLIB_H 1 [ 239s] #define HAVE_STRING_H 1 [ 239s] #define HAVE_MEMORY_H 1 [ 239s] #define HAVE_STRINGS_H 1 [ 239s] #define HAVE_INTTYPES_H 1 [ 239s] #define HAVE_STDINT_H 1 [ 239s] #define HAVE_UNISTD_H 1 [ 239s] #define HAVE_DLFCN_H 1 [ 239s] #define LT_OBJDIR ".libs/" [ 239s] [ 239s] configure: exit 1 [ 239s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 239s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 239s] make[1]: *** [override_dh_auto_configure] Error 2 [ 239s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 239s] debian/rules:45: recipe for target 'build' failed [ 239s] make: *** [build] Error 2 [ 239s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 239s] ### VM INTERACTION START ### [ 242s] [ 228.778642] sysrq: Power Off [ 242s] [ 228.783240] reboot: Power down [ 242s] ### VM INTERACTION END ### [ 242s] [ 242s] old-cirrus2 failed "build osmo-cbc_0.2.3.202112210026.dsc" at Tue Dec 21 00:40:45 UTC 2021. [ 242s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 00:41:24 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 00:41:24 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61c122c046d2b_74d2b05e19645f8112694b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 276s] #define HAVE_SYS_TYPES_H 1 [ 276s] #define HAVE_SYS_STAT_H 1 [ 276s] #define HAVE_STDLIB_H 1 [ 276s] #define HAVE_STRING_H 1 [ 276s] #define HAVE_MEMORY_H 1 [ 276s] #define HAVE_STRINGS_H 1 [ 276s] #define HAVE_INTTYPES_H 1 [ 276s] #define HAVE_STDINT_H 1 [ 276s] #define HAVE_UNISTD_H 1 [ 276s] #define HAVE_DLFCN_H 1 [ 276s] #define LT_OBJDIR ".libs/" [ 276s] #define PACKAGE "osmo-remsim" [ 276s] #define VERSION "1.0.0.4-0c832" [ 276s] [ 276s] configure: exit 1 [ 276s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 276s] debian/rules:17: recipe for target 'override_dh_auto_configure' failed [ 276s] make[1]: *** [override_dh_auto_configure] Error 2 [ 276s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 276s] debian/rules:14: recipe for target 'build' failed [ 276s] make: *** [build] Error 2 [ 276s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 276s] ### VM INTERACTION START ### [ 279s] [ 263.148455][ T404] sysrq: Power Off [ 279s] [ 263.152925][ T16] reboot: Power down [ 279s] ### VM INTERACTION END ### [ 279s] [ 279s] lamb01 failed "build osmo-remsim_1.0.0.4.0c832.202112210026.dsc" at Tue Dec 21 00:41:07 UTC 2021. [ 279s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:00:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:00:48 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c14374a7f60_74d2b05e19645f81141959@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 186s] self.__getattribute__('to_'+self.format)() [ 186s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 186s] self.exec_dblatex() [ 186s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 186s] self.to_docbook() [ 186s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 186s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 186s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 186s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 186s] IndexError: tuple index out of range [ 186s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 186s] a2x: resource files: [] [ 186s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 186s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 186s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 186s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 186s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 186s] make[1]: *** [Makefile:363: all] Error 2 [ 186s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 186s] dh_auto_build: error: make -j1 returned exit code 2 [ 186s] make: *** [debian/rules:5: binary] Error 25 [ 186s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 186s] ### VM INTERACTION START ### [ 187s] Powering off. [ 187s] [ 176.396671] reboot: Power down [ 187s] ### VM INTERACTION END ### [ 187s] [ 187s] goat17 failed "build osmo-gsm-manuals-dev_1.2.0.202112210026.dsc" at Tue Dec 21 03:00:44 UTC 2021. [ 187s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:03:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:03:21 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c1440823f1f_74d2b05e19645f81142110@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 338s] self.__getattribute__('to_'+self.format)() [ 338s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 338s] self.exec_dblatex() [ 338s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 338s] self.to_docbook() [ 338s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 338s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 338s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 338s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 338s] IndexError: tuple index out of range [ 338s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'test-usermanual.adoc'] [ 338s] a2x: resource files: [] [ 338s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 338s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf] Error 1 [ 338s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 338s] make[2]: *** [Makefile:439: all-recursive] Error 1 [ 338s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 338s] make[1]: *** [Makefile:363: all] Error 2 [ 338s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 338s] dh_auto_build: error: make -j1 returned exit code 2 [ 338s] make: *** [debian/rules:5: binary] Error 25 [ 338s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 338s] ### VM INTERACTION START ### [ 339s] Powering off. [ 339s] [ 321.268301] reboot: Power down [ 339s] ### VM INTERACTION END ### [ 339s] [ 339s] lamb06 failed "build osmo-gsm-manuals-dev_1.2.0.dsc" at Tue Dec 21 03:03:13 UTC 2021. [ 339s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:06:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:06:45 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c144d920d3f_74d2b05e19645f811425df@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 195s] self.exec_dblatex() [ 195s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 195s] self.to_docbook() [ 195s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 195s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 195s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 195s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 195s] IndexError: tuple index out of range [ 195s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomgw-usermanual.adoc'] [ 195s] a2x: resource files: [] [ 195s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 195s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomgw-usermanual.pdf] Error 1 [ 195s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 195s] make[3]: *** [Makefile:387: all-recursive] Error 1 [ 195s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 195s] make[2]: *** [Makefile:514: all-recursive] Error 1 [ 195s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 195s] make[1]: *** [Makefile:423: all] Error 2 [ 195s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 195s] dh_auto_build: error: make -j1 returned exit code 2 [ 195s] make: *** [debian/rules:17: build] Error 25 [ 195s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 195s] ### VM INTERACTION START ### [ 196s] Powering off. [ 196s] [ 185.647074] reboot: Power down [ 196s] ### VM INTERACTION END ### [ 196s] [ 196s] goat17 failed "build osmo-mgw_1.9.0.dsc" at Tue Dec 21 03:06:38 UTC 2021. [ 196s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:07:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:07:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c145167cdd2_74d2b05e19645f81142668@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 258s] self.exec_dblatex() [ 258s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 258s] self.to_docbook() [ 258s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 258s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 258s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 258s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 258s] IndexError: tuple index out of range [ 258s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 258s] a2x: resource files: [] [ 258s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 258s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 258s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 258s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 258s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 258s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 258s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 258s] make[1]: *** [Makefile:452: all] Error 2 [ 258s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 258s] dh_auto_build: error: make -j1 returned exit code 2 [ 258s] make: *** [debian/rules:6: build] Error 25 [ 258s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 258s] ### VM INTERACTION START ### [ 259s] Powering off. [ 259s] [ 248.555425] reboot: Power down [ 259s] ### VM INTERACTION END ### [ 259s] [ 259s] goat17 failed "build osmo-trx_1.4.0.dsc" at Tue Dec 21 03:07:42 UTC 2021. [ 259s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:07:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:07:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c14516b79e3_74d2b05e19645f8114273f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 261s] self.exec_dblatex() [ 261s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 261s] self.to_docbook() [ 261s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 261s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 261s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 261s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 261s] IndexError: tuple index out of range [ 261s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmogbproxy-usermanual.adoc'] [ 261s] a2x: resource files: [] [ 261s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 261s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmogbproxy-usermanual.pdf] Error 1 [ 261s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 261s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 261s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 261s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 261s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 261s] make[1]: *** [Makefile:377: all] Error 2 [ 261s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 261s] dh_auto_build: error: make -j1 returned exit code 2 [ 261s] make: *** [debian/rules:45: build] Error 25 [ 261s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 261s] ### VM INTERACTION START ### [ 262s] Powering off. [ 262s] [ 249.207596] reboot: Power down [ 263s] ### VM INTERACTION END ### [ 263s] [ 263s] sheep88 failed "build osmo-gbproxy_0.2.0.dsc" at Tue Dec 21 03:07:47 UTC 2021. [ 263s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:08:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:08:44 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c14554dbd0d_74d2b05e19645f811430b8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 303s] self.__getattribute__('to_'+self.format)() [ 303s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 714, in to_pdf [ 303s] self.exec_dblatex() [ 303s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 303s] self.to_docbook() [ 303s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 303s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 303s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 303s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 303s] IndexError: tuple index out of range [ 303s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmopcu-usermanual.adoc'] [ 303s] a2x: resource files: [] [ 303s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 303s] make[3]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmopcu-usermanual.pdf] Error 1 [ 303s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 303s] make[2]: *** [Makefile:384: all-recursive] Error 1 [ 303s] make[2]: Leaving directory '/usr/src/packages/BUILD/doc' [ 303s] make[1]: *** [Makefile:420: all-recursive] Error 1 [ 303s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 303s] dh_auto_build: error: make -j1 returned exit code 2 [ 303s] make: *** [debian/rules:12: build] Error 25 [ 303s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 303s] ### VM INTERACTION START ### [ 304s] Powering off. [ 304s] [ 291.930498] reboot: Power down [ 304s] ### VM INTERACTION END ### [ 304s] [ 304s] sheep86 failed "build osmo-pcu_1.0.0.dsc" at Tue Dec 21 03:08:28 UTC 2021. [ 304s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:09:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:09:36 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c1457187afc_74d2b05e19645f811434e9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 357s] self.exec_dblatex() [ 357s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 357s] self.to_docbook() [ 357s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 357s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 357s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 357s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 357s] IndexError: tuple index out of range [ 357s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosipconnector-usermanual.adoc'] [ 357s] a2x: resource files: [] [ 357s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 357s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosipconnector-usermanual.pdf] Error 1 [ 357s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 357s] make[3]: *** [Makefile:335: all-recursive] Error 1 [ 357s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 357s] make[2]: *** [Makefile:371: all-recursive] Error 1 [ 357s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 357s] make[1]: *** [Makefile:327: all] Error 2 [ 357s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 357s] dh_auto_build: error: make -j1 returned exit code 2 [ 357s] make: *** [debian/rules:12: build] Error 25 [ 357s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 357s] ### VM INTERACTION START ### [ 358s] Powering off. [ 358s] [ 341.628718] reboot: Power down [ 359s] ### VM INTERACTION END ### [ 359s] [ 359s] lamb55 failed "build osmo-sip-connector_1.6.0.dsc" at Tue Dec 21 03:09:28 UTC 2021. [ 359s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:09:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:09:36 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c14571a8877_74d2b05e19645f8114359c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 360s] self.exec_dblatex() [ 360s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 360s] self.to_docbook() [ 360s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 360s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 360s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 360s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 360s] IndexError: tuple index out of range [ 360s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohlr-usermanual.adoc'] [ 360s] a2x: resource files: [] [ 360s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 360s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohlr-usermanual.pdf] Error 1 [ 360s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 360s] make[3]: *** [Makefile:382: all-recursive] Error 1 [ 360s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 360s] make[2]: *** [Makefile:488: all-recursive] Error 1 [ 360s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 360s] make[1]: *** [Makefile:410: all] Error 2 [ 360s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 360s] dh_auto_build: error: make -j1 returned exit code 2 [ 360s] make: *** [debian/rules:7: build] Error 25 [ 360s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 360s] ### VM INTERACTION START ### [ 362s] Powering off. [ 362s] [ 344.562398] reboot: Power down [ 362s] ### VM INTERACTION END ### [ 362s] [ 362s] lamb06 failed "build osmo-hlr_1.4.0.dsc" at Tue Dec 21 03:09:28 UTC 2021. [ 362s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:09:36 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:09:36 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c14571ceeb8_74d2b05e19645f8114362f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 358s] self.exec_dblatex() [ 358s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 358s] self.to_docbook() [ 358s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 358s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 358s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 358s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 358s] IndexError: tuple index out of range [ 358s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmocbc-usermanual.adoc'] [ 358s] a2x: resource files: [] [ 358s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 358s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmocbc-usermanual.pdf] Error 1 [ 358s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 358s] make[3]: *** [Makefile:381: all-recursive] Error 1 [ 358s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 358s] make[2]: *** [Makefile:421: all-recursive] Error 1 [ 358s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 358s] make[1]: *** [Makefile:368: all] Error 2 [ 358s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 358s] dh_auto_build: error: make -j1 returned exit code 2 [ 358s] make: *** [debian/rules:45: build] Error 25 [ 358s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 358s] ### VM INTERACTION START ### [ 359s] Powering off. [ 359s] [ 341.502133] reboot: Power down [ 359s] ### VM INTERACTION END ### [ 359s] [ 359s] lamb18 failed "build osmo-cbc_0.2.3.dsc" at Tue Dec 21 03:09:29 UTC 2021. [ 359s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:09:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:09:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c145909cd62_74d2b05e19645f811438a2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 366s] self.exec_dblatex() [ 366s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 366s] self.to_docbook() [ 366s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 366s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 366s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 366s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 366s] IndexError: tuple index out of range [ 366s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmoggsn-usermanual.adoc'] [ 366s] a2x: resource files: [] [ 366s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 366s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmoggsn-usermanual.pdf] Error 1 [ 366s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 366s] make[3]: *** [Makefile:447: all-recursive] Error 1 [ 366s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 366s] make[2]: *** [Makefile:487: all-recursive] Error 1 [ 366s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 366s] make[1]: *** [Makefile:392: all] Error 2 [ 366s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 366s] dh_auto_build: error: make -j1 returned exit code 2 [ 366s] make: *** [debian/rules:15: build] Error 25 [ 366s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 366s] ### VM INTERACTION START ### [ 367s] Powering off. [ 367s] [ 350.148736] reboot: Power down [ 367s] ### VM INTERACTION END ### [ 367s] [ 367s] lamb05 failed "build osmo-ggsn_1.8.0.dsc" at Tue Dec 21 03:09:36 UTC 2021. [ 367s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:09:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:09:53 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c1459126288_74d2b05e19645f8114392e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 381s] self.exec_dblatex() [ 381s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 381s] self.to_docbook() [ 381s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 381s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 381s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 381s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 381s] IndexError: tuple index out of range [ 381s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmostp-usermanual.adoc'] [ 381s] a2x: resource files: [] [ 381s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 381s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmostp-usermanual.pdf] Error 1 [ 381s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 381s] make[3]: *** [Makefile:377: all-recursive] Error 1 [ 381s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 381s] make[2]: *** [Makefile:508: all-recursive] Error 1 [ 381s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 381s] make[1]: *** [Makefile:403: all] Error 2 [ 381s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 381s] dh_auto_build: error: make -j1 returned exit code 2 [ 381s] make: *** [debian/rules:12: build] Error 25 [ 381s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 381s] ### VM INTERACTION START ### [ 382s] Powering off. [ 382s] [ 365.169263] reboot: Power down [ 383s] ### VM INTERACTION END ### [ 383s] [ 383s] lamb57 failed "build libosmo-sccp_1.5.0.dsc" at Tue Dec 21 03:09:52 UTC 2021. [ 383s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:11:01 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:11:01 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c145cbb4d9f_74d2b05e19645f81144496@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 454s] self.exec_dblatex() [ 454s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 454s] self.to_docbook() [ 454s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 454s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 454s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 454s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 454s] IndexError: tuple index out of range [ 454s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmo-remsim-usermanual.adoc'] [ 454s] a2x: resource files: [] [ 454s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 454s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmo-remsim-usermanual.pdf] Error 1 [ 454s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 454s] make[3]: *** [Makefile:386: all-recursive] Error 1 [ 454s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 454s] make[2]: *** [Makefile:484: all-recursive] Error 1 [ 454s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 454s] make[1]: *** [Makefile:408: all] Error 2 [ 454s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 454s] dh_auto_build: error: make -j1 returned exit code 2 [ 454s] make: *** [debian/rules:14: build] Error 25 [ 454s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 454s] ### VM INTERACTION START ### [ 455s] Powering off. [ 455s] [ 434.427231][T14676] reboot: Power down [ 455s] ### VM INTERACTION END ### [ 455s] [ 455s] lamb01 failed "build osmo-remsim_1.0.0.dsc" at Tue Dec 21 03:11:00 UTC 2021. [ 455s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:14:08 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:14:08 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c1469ce6146_74d2b05e19645f81144843@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 239s] self.exec_dblatex() [ 239s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 239s] self.to_docbook() [ 239s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 239s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 239s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 239s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 239s] IndexError: tuple index out of range [ 239s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmobsc-usermanual.adoc'] [ 239s] a2x: resource files: [] [ 239s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 239s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmobsc-usermanual.pdf] Error 1 [ 239s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 239s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 239s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 239s] make[2]: *** [Makefile:454: all-recursive] Error 1 [ 239s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 239s] make[1]: *** [Makefile:386: all] Error 2 [ 239s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 239s] dh_auto_build: error: make -j1 returned exit code 2 [ 239s] make: *** [debian/rules:45: build] Error 25 [ 239s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 239s] ### VM INTERACTION START ### [ 240s] Powering off. [ 240s] [ 230.312766] reboot: Power down [ 240s] ### VM INTERACTION END ### [ 240s] [ 240s] goat11 failed "build osmo-bsc_1.8.0.dsc" at Tue Dec 21 03:14:01 UTC 2021. [ 240s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:16:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:16:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c146f95ebad_74d2b05e19645f81145063@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 350s] self.exec_dblatex() [ 350s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 350s] self.to_docbook() [ 350s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 350s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 350s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 350s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 350s] IndexError: tuple index out of range [ 350s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosmlc-usermanual.adoc'] [ 350s] a2x: resource files: [] [ 350s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 350s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosmlc-usermanual.pdf] Error 1 [ 350s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 350s] make[3]: *** [Makefile:376: all-recursive] Error 1 [ 350s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 350s] make[2]: *** [Makefile:445: all-recursive] Error 1 [ 350s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 350s] make[1]: *** [Makefile:377: all] Error 2 [ 350s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 350s] dh_auto_build: error: make -j1 returned exit code 2 [ 350s] make: *** [debian/rules:45: build] Error 25 [ 350s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 350s] ### VM INTERACTION START ### [ 352s] Powering off. [ 352s] [ 334.084514] reboot: Power down [ 352s] ### VM INTERACTION END ### [ 352s] [ 352s] lamb57 failed "build osmo-smlc_0.2.1.dsc" at Tue Dec 21 03:16:00 UTC 2021. [ 352s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:22:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:22:21 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c1487ce6bd0_74d2b05e19645f81146825@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 725s] self.exec_dblatex() [ 725s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 725s] self.to_docbook() [ 725s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 725s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 725s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 725s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 725s] IndexError: tuple index out of range [ 725s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnbgw-usermanual.adoc'] [ 725s] a2x: resource files: [] [ 725s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 725s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnbgw-usermanual.pdf] Error 1 [ 725s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 725s] make[3]: *** [Makefile:383: all-recursive] Error 1 [ 725s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 725s] make[2]: *** [Makefile:475: all-recursive] Error 1 [ 725s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 725s] make[1]: *** [Makefile:393: all] Error 2 [ 725s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 725s] dh_auto_build: error: make -j1 returned exit code 2 [ 725s] make: *** [debian/rules:9: build] Error 25 [ 725s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 725s] ### VM INTERACTION START ### [ 726s] Powering off. [ 726s] [ 708.530100] reboot: Power down [ 726s] ### VM INTERACTION END ### [ 726s] [ 726s] lamb09 failed "build osmo-iuh_1.1.0.dsc" at Tue Dec 21 03:22:11 UTC 2021. [ 726s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:28:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:28:52 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c14a028a4a7_74d2b05e19645f811473dd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 368s] self.exec_dblatex() [ 368s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 368s] self.to_docbook() [ 368s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 368s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 368s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 368s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 368s] IndexError: tuple index out of range [ 368s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmosgsn-usermanual.adoc'] [ 368s] a2x: resource files: [] [ 368s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 368s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmosgsn-usermanual.pdf] Error 1 [ 368s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 368s] make[3]: *** [Makefile:393: all-recursive] Error 1 [ 368s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 368s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 368s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 368s] make[1]: *** [Makefile:394: all] Error 2 [ 368s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 368s] dh_auto_build: error: make -j1 returned exit code 2 [ 368s] make: *** [debian/rules:45: build] Error 25 [ 368s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 368s] ### VM INTERACTION START ### [ 369s] Powering off. [ 369s] [ 349.854811] reboot: Power down [ 369s] ### VM INTERACTION END ### [ 369s] [ 369s] lamb13 failed "build osmo-sgsn_1.8.0.dsc" at Tue Dec 21 03:28:36 UTC 2021. [ 369s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:29:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:29:26 +0000 Subject: Build failure of network:osmocom:latest/osmo-hnodeb in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c14a2149cbb_74d2b05e19645f8114755a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hnodeb/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hnodeb failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hnodeb Last lines of build log: [ 414s] self.exec_dblatex() [ 414s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 414s] self.to_docbook() [ 414s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 414s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 414s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 414s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 414s] IndexError: tuple index out of range [ 414s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmohnodeb-usermanual.adoc'] [ 414s] a2x: resource files: [] [ 414s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 414s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmohnodeb-usermanual.pdf] Error 1 [ 414s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 414s] make[3]: *** [Makefile:389: all-recursive] Error 1 [ 414s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 414s] make[2]: *** [Makefile:458: all-recursive] Error 1 [ 414s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 414s] make[1]: *** [Makefile:390: all] Error 2 [ 414s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 414s] dh_auto_build: error: make -j1 returned exit code 2 [ 414s] make: *** [debian/rules:45: build] Error 25 [ 414s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 414s] ### VM INTERACTION START ### [ 415s] Powering off. [ 415s] [ 365.946755] reboot: Power down [ 415s] ### VM INTERACTION END ### [ 415s] [ 415s] cloud116 failed "build osmo-hnodeb_0.0.1.dsc" at Tue Dec 21 03:29:23 UTC 2021. [ 415s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 03:29:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 03:29:09 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c14a20e209a_74d2b05e19645f8114744c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 383s] self.exec_dblatex() [ 383s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 383s] self.to_docbook() [ 383s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 383s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 383s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 383s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 383s] IndexError: tuple index out of range [ 383s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmomsc-usermanual.adoc'] [ 383s] a2x: resource files: [] [ 383s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 383s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmomsc-usermanual.pdf] Error 1 [ 383s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 383s] make[3]: *** [Makefile:402: all-recursive] Error 1 [ 383s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 383s] make[2]: *** [Makefile:470: all-recursive] Error 1 [ 383s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 383s] make[1]: *** [Makefile:402: all] Error 2 [ 383s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 383s] dh_auto_build: error: make -j1 returned exit code 2 [ 383s] make: *** [debian/rules:45: build] Error 25 [ 383s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 383s] ### VM INTERACTION START ### [ 385s] Powering off. [ 385s] [ 364.866740] reboot: Power down [ 385s] ### VM INTERACTION END ### [ 385s] [ 385s] lamb09 failed "build osmo-msc_1.8.0.dsc" at Tue Dec 21 03:28:52 UTC 2021. [ 385s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Tue Dec 21 09:05:19 2021 From: noreply at opensuse.org (OBS Notification) Date: Tue, 21 Dec 2021 09:05:19 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61c198e750a58_686e2ad7512c85f055294@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 258s] self.exec_dblatex() [ 258s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 729, in exec_dblatex [ 258s] self.to_docbook() [ 258s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in to_docbook [ 258s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 258s] File "/usr/lib/python3/dist-packages/asciidoc/a2x.py", line 684, in [ 258s] ' '.join(map(lambda x: "{}{}".format(x[0], " " + x[1] if x[1] else ""), options)), [ 258s] IndexError: tuple index out of range [ 258s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f /usr/share/osmo-gsm-manuals/build/mscgen-filter.conf -f /usr/share/osmo-gsm-manuals/build/diag-filter.conf -f /usr/share/osmo-gsm-manuals/build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/doc/manuals' -a commondir='/usr/share/osmo-gsm-manuals/common'", '--dblatex-opts=-s /usr/share/osmo-gsm-manuals/build/custom-dblatex.sty -P draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT ', '-a', 'revdate=unknown', 'osmotrx-usermanual.adoc'] [ 258s] a2x: resource files: [] [ 258s] a2x: resource directories: ['/etc/asciidoc/stylesheets'] [ 258s] make[4]: *** [/usr/share/osmo-gsm-manuals/build/Makefile.asciidoc.inc:70: osmotrx-usermanual.pdf] Error 1 [ 258s] make[4]: Leaving directory '/usr/src/packages/BUILD/doc/manuals' [ 258s] make[3]: *** [Makefile:398: all-recursive] Error 1 [ 258s] make[3]: Leaving directory '/usr/src/packages/BUILD/doc' [ 258s] make[2]: *** [Makefile:521: all-recursive] Error 1 [ 258s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 258s] make[1]: *** [Makefile:452: all] Error 2 [ 258s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 258s] dh_auto_build: error: make -j1 returned exit code 2 [ 258s] make: *** [debian/rules:6: build] Error 25 [ 258s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 258s] ### VM INTERACTION START ### [ 259s] Powering off. [ 259s] [ 248.138594] reboot: Power down [ 259s] ### VM INTERACTION END ### [ 259s] [ 259s] goat09 failed "build osmo-trx_1.4.0.dsc" at Tue Dec 21 09:05:10 UTC 2021. [ 259s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Dec 21 09:59:43 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 21 Dec 2021 09:59:43 +0000 Subject: Change in osmo-ci[master]: repo-install-test: Validate osmo-hnodeb --version References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26649 ) Change subject: repo-install-test: Validate osmo-hnodeb --version ...................................................................... repo-install-test: Validate osmo-hnodeb --version Change-Id: I87c9c375fa810223daadd5768d6a54e9935c34eb --- M scripts/repo-install-test/run-inside-docker.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/49/26649/1 diff --git a/scripts/repo-install-test/run-inside-docker.sh b/scripts/repo-install-test/run-inside-docker.sh index 1ba94d9..e44c609 100755 --- a/scripts/repo-install-test/run-inside-docker.sh +++ b/scripts/repo-install-test/run-inside-docker.sh @@ -347,6 +347,7 @@ osmo-hlr \ osmo-hlr-db-tool \ osmo-hnbgw \ + osmo-hnodeb \ osmo-mgw \ osmo-msc \ osmo-pcu \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I87c9c375fa810223daadd5768d6a54e9935c34eb Gerrit-Change-Number: 26649 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 10:36:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 21 Dec 2021 10:36:15 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Set proper CRC Header for ACK Initialization In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26598 ) Change subject: mgcp_network.c: Set proper CRC Header for ACK Initialization ...................................................................... Patch Set 1: ping -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f Gerrit-Change-Number: 26598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Tue, 21 Dec 2021 10:36:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 10:40:18 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 10:40:18 +0000 Subject: Change in osmo-ci[master]: repo-install-test: Validate osmo-hnodeb --version In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26649 ) Change subject: repo-install-test: Validate osmo-hnodeb --version ...................................................................... Patch Set 1: Code-Review+1 Assuming you want this to run for both latest and nightly: LGTM! Otherwise you'd need: if [ "$FEED" = "nightly" ]; then ... fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I87c9c375fa810223daadd5768d6a54e9935c34eb Gerrit-Change-Number: 26649 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 21 Dec 2021 10:40:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 10:41:46 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 21 Dec 2021 10:41:46 +0000 Subject: Change in osmo-ci[master]: repo-install-test: Validate osmo-hnodeb --version In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26649 ) Change subject: repo-install-test: Validate osmo-hnodeb --version ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > Assuming you want this to run for both latest and nightly: LGTM! > > Otherwise you'd need: > > if [ "$FEED" = "nightly" ]; then > ... > fi It runs fine in both, see https://jenkins.osmocom.org/jenkins/job/Osmocom-repo-install-debian10/337/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I87c9c375fa810223daadd5768d6a54e9935c34eb Gerrit-Change-Number: 26649 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 21 Dec 2021 10:41:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 10:43:06 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 10:43:06 +0000 Subject: Change in osmo-ci[master]: repo-install-test: Validate osmo-hnodeb --version In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26649 ) Change subject: repo-install-test: Validate osmo-hnodeb --version ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I87c9c375fa810223daadd5768d6a54e9935c34eb Gerrit-Change-Number: 26649 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 21 Dec 2021 10:43:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 10:59:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 21 Dec 2021 10:59:32 +0000 Subject: Change in osmo-ci[master]: repo-install-test: Validate osmo-hnodeb --version In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26649 ) Change subject: repo-install-test: Validate osmo-hnodeb --version ...................................................................... repo-install-test: Validate osmo-hnodeb --version Change-Id: I87c9c375fa810223daadd5768d6a54e9935c34eb --- M scripts/repo-install-test/run-inside-docker.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/scripts/repo-install-test/run-inside-docker.sh b/scripts/repo-install-test/run-inside-docker.sh index 1ba94d9..e44c609 100755 --- a/scripts/repo-install-test/run-inside-docker.sh +++ b/scripts/repo-install-test/run-inside-docker.sh @@ -347,6 +347,7 @@ osmo-hlr \ osmo-hlr-db-tool \ osmo-hnbgw \ + osmo-hnodeb \ osmo-mgw \ osmo-msc \ osmo-pcu \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I87c9c375fa810223daadd5768d6a54e9935c34eb Gerrit-Change-Number: 26649 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 12:16:47 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 21 Dec 2021 12:16:47 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Add dotty graphs of the component hierarchy for Gb and RAN References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26650 ) Change subject: Add dotty graphs of the component hierarchy for Gb and RAN ...................................................................... Add dotty graphs of the component hierarchy for Gb and RAN These graphs show the component hierarchy and which ports of which component are connected where. Change-Id: I79badbcdbbf03d69de3a1a18241c7a9537c161bf --- A doc/gb_stack_fr.dot A doc/gb_stack_ip.dot A doc/ran_emulation_aoip.dot A doc/ran_emulation_sccplite.dot 4 files changed, 169 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/26650/1 diff --git a/doc/gb_stack_fr.dot b/doc/gb_stack_fr.dot new file mode 100644 index 0000000..f69a264 --- /dev/null +++ b/doc/gb_stack_fr.dot @@ -0,0 +1,48 @@ +digraph G { + rankdir = LR; + label = "Gb protocol stack with NS over FR"; + + "BSSGP_BVC_CT" [ + shape = "record" + label = " BSSGP_BVC_CT | BSSGP_SP | BSSGP_SP_SIG | BSSGP_PROC | GLOBAL | MGMT | BVC" + ] + + "BSSGP_CT" [ + shape = "record" + label = " BSSGP_CT | PROC | GLOBAL | RIM | MGMT | BVC | BSCP" + ] + + "NS_CT" [ + shape = "record" + label = " NS_CT | NS_SP | NSVC | NS_CTRL | NSIP_PROC" + ] + + "NSVC_CT" [ + shape = "record" + label = " NSVC_CT | NS_SP | NSCP" + ] + + "NS_Provider_FR_CT" [ + shape = "record" + label = " NS_PRovider_FR_CT | NSE | FR | FR_PROC" + ] + + "FR_Emulation_CT" [ + shape = "record" + label = " FR_Emulation_CT | CLIENT | PROC | FR" + ] + + "system" [ + shape = "record" + label = " system | FR" + ] + + "BSSGP_BVC_CT":BVC -> "BSSGP_CT":BVC + "BSSGP_CT":BSCP -> "NS_CT":NS_SP + + "NS_CT":NSVC -> "NSVC_CT":NS_SP + "NSVC_CT":NSCP -> "NS_Provider_FR_CT":NSE + "NS_Provider_FR_CT":FR -> "FR_Emulation_CT":CLIENT + "NS_Provider_FR_CT":FR_PROC -> "FR_Emulation_CT":PROC + "FR_Emulation_CT":FR -> "system":FR +} diff --git a/doc/gb_stack_ip.dot b/doc/gb_stack_ip.dot new file mode 100644 index 0000000..0c54c78 --- /dev/null +++ b/doc/gb_stack_ip.dot @@ -0,0 +1,43 @@ +digraph G { + rankdir = LR; + label = "Gb protocol stack with NS over IP"; + + "BSSGP_BVC_CT" [ + shape = "record" + label = " BSSGP_BVC_CT | BSSGP_SP | BSSGP_SP_SIG | BSSGP_PROC | GLOBAL | MGMT | BVC" + ] + + "BSSGP_CT" [ + shape = "record" + label = " BSSGP_CT | PROC | GLOBAL | RIM | MGMT | BVC | BSCP" + ] + + "NS_CT" [ + shape = "record" + label = " NS_CT | NS_SP | NSVC | NS_CTRL | NSIP_PROC" + ] + + "NSVC_CT" [ + shape = "record" + label = " NSVC_CT | NS_SP | NSCP" + ] + + "NS_Provider_IPL4_CT" [ + shape = "record" + label = " NS_Provider_IPL4_CT | NSE | NSVC | IPL4 | PROC" + ] + + "system" [ + shape = "record" + label = " system | IPL4" + ] + + "BSSGP_BVC_CT":BVC -> "BSSGP_CT":BVC + "BSSGP_CT":BSCP -> "NS_CT":NS_SP + + "NS_CT":NSVC -> "NSVC_CT":NS_SP + "NS_CT":NSIP_PROC -> "NS_Provider_IPL4_CT":PROC + "NSVC_CT":NSCP -> "NS_Provider_IPL4_CT":NSVC + "NS_Provider_IPL4_CT":IPL4 -> "system":IPL4 + +} diff --git a/doc/ran_emulation_aoip.dot b/doc/ran_emulation_aoip.dot new file mode 100644 index 0000000..59f6d3d --- /dev/null +++ b/doc/ran_emulation_aoip.dot @@ -0,0 +1,39 @@ +digraph G { + rankdir = LR; + label = "RAN_Emulation when used with AoIP as in MSC_Tests"; + + "RAN_ConnHdlr" [ + shape = "record" + label = " RAN_ConnHdlr | BSSAP | BSSAP_PROC" + ]; + + "RAN_Emulation_CT" [ + shape = "record" + label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + ]; + + "SCCP_CT" [ + shape = "record" + label = " SCCP_CT | MTP3_SCCP_PORT | SCCP_SP_PORT" + ]; + + "M3UA_CT" [ + + shape = "record" + label = " M3UA_CT | SCTP_PORT | MTP3_SP_PORT" + ]; + + "system" [ + shape = "record" + label = " system | SCTP" + ]; + + "RAN_ConnHdlr":BSSAP -> "RAN_Emulation_CT":CLIENT + "RAN_ConnHdlr":BSSAP_PROC -> "RAN_Emulation_CT":PROC + + "RAN_Emulation_CT":BSSAP -> "SCCP_CT":SCCP_SP_PORT + "RAN_Emulation_CT":RANAP -> "SCCP_CT":SCCP_SP_PORT + + "SCCP_CT":MTP3_SCCP_PORT -> "M3UA_CT":MTP3_SP_PORT + "M3UA_CT":SCTP_PORT -> "system":SCTP +} diff --git a/doc/ran_emulation_sccplite.dot b/doc/ran_emulation_sccplite.dot new file mode 100644 index 0000000..cce29b1 --- /dev/null +++ b/doc/ran_emulation_sccplite.dot @@ -0,0 +1,39 @@ +digraph G { + rankdir = LR; + label = "RAN_Emulation when used with SCCPLite"; + + "RAN_ConnHdlr" [ + shape = "record" + label = " RAN_ConnHdlr | BSSAP | BSSAP_PROC" + ]; + + "RAN_Emulation_CT" [ + shape = "record" + label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + ]; + + "SCCP_CT" [ + shape = "record" + label = " SCCP_CT | MTP3_SCCP_PORT | SCCP_SP_PORT" + ]; + + "IPA_Emulation_CT" [ + shape = "record" + label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" + ]; + + "system" [ + shape = "record" + label = " system | IPA_CODEC_PORT" + ]; + + "RAN_ConnHdlr":BSSAP -> "RAN_Emulation_CT":CLIENT + "RAN_ConnHdlr":BSSAP_PROC -> "RAN_Emulation_CT":PROC + + "RAN_Emulation_CT":BSSAP -> "SCCP_CT":SCCP_SP_PORT + "RAN_Emulation_CT":MGCP -> "IPA_Emulation_CT":IPA_MGCP_PORT + "RAN_Emulation_CT":CTRL -> "IPA_Emulation_CT":IPA_CTRL_PORT + + "SCCP_CT":MTP3_SCCP_PORT -> "IPA_Emulation_CT":MTP3_SP_PORT + "IPA_Emulation_CT":IPA_PORT -> "system":IPA_CODEC_PORT +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79badbcdbbf03d69de3a1a18241c7a9537c161bf Gerrit-Change-Number: 26650 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 12:45:49 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 21 Dec 2021 12:45:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Add dotty graphs of the component hierarchy for Gb and RAN In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26650 ) Change subject: Add dotty graphs of the component hierarchy for Gb and RAN ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79badbcdbbf03d69de3a1a18241c7a9537c161bf Gerrit-Change-Number: 26650 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Tue, 21 Dec 2021 12:45:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 13:46:51 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 21 Dec 2021 13:46:51 +0000 Subject: Change in osmo-mgw[master]: mgcp_client: add new codec "IUUP" References: Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26651 ) Change subject: mgcp_client: add new codec "IUUP" ...................................................................... mgcp_client: add new codec "IUUP" 3GPP TS 25.414 5.1.3.3.1.6 specifies that IuUP can use RTP as transport. The payload type is specified from 97-127, which shall be ignored on the receiving end anyway. It does not specify a name to be use din SDP. In order to generate reasonable SDP messages, lets specify that we can use "IUUP" as codec name if we want to create an RTP stream with IuUP. The payload type number we use shall be 97 by default. Change-Id: Ifd1210a897743396899f34457c96e6fd2109c6b3 Related: SYS#5152 --- M include/osmocom/mgcp_client/mgcp_client.h M src/libosmo-mgcp-client/mgcp_client.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/51/26651/1 diff --git a/include/osmocom/mgcp_client/mgcp_client.h b/include/osmocom/mgcp_client/mgcp_client.h index 0405175..70cc904 100644 --- a/include/osmocom/mgcp_client/mgcp_client.h +++ b/include/osmocom/mgcp_client/mgcp_client.h @@ -49,6 +49,7 @@ CODEC_GSMHR_8000_1 = 111, CODEC_AMR_8000_1 = 112, CODEC_AMRWB_16000_1 = 113, + CODEC_IUUP = 96, }; /* Note: when new codec types are added, the corresponding value strings * in mgcp_client.c (codec_table) must be updated as well. Enumerations diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 8c2c118..0f4bcee 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -59,6 +59,7 @@ { CODEC_GSMHR_8000_1, "GSM-HR-08/8000/1" }, { CODEC_AMR_8000_1, "AMR/8000/1" }, { CODEC_AMRWB_16000_1, "AMR-WB/16000/1" }, + { CODEC_IUUP, "IUUP" }, { 0, NULL }, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd1210a897743396899f34457c96e6fd2109c6b3 Gerrit-Change-Number: 26651 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 13:54:45 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 21 Dec 2021 13:54:45 +0000 Subject: Change in osmo-mgw[master]: mgcp_client: add new codec "IUUP" In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26651 ) Change subject: mgcp_client: add new codec "IUUP" ...................................................................... Patch Set 1: There is a bit of a cosmetic problem when using IuUP on osmo-mgw. We need to specify a name for a codec. Usually this is something like "AMR/8000/1". As far as I understand IuUP is more an encapsulation format that comes with a header attached to the actual payload, so it is never pure AMR or anything else. Its just IuUP. I have now defined a new codec that is called "IUUP". I couldn't find any reference in the spec which name to choose here. It seems to be unspecified. I have named the constant "CODEC_IUUP". What I am not happy with is that this is not a codec after all, so this needs to be discussed. Maybe we chose a different name for the constant like "CODEC_ANY_IUUP" or name it "PAYLOAD_IUUP". Or maybe we even add another API that allows the API user to register new codec names and then we can register "IUUP" from the application. (I think renaming all the structs from "codec_..." to "payload_..." is not an option) Feedback is welcome. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd1210a897743396899f34457c96e6fd2109c6b3 Gerrit-Change-Number: 26651 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 21 Dec 2021 13:54:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 14:10:43 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 21 Dec 2021 14:10:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Add dotty graphs of BSC + MSC test component hierarchy References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26652 ) Change subject: doc: Add dotty graphs of BSC + MSC test component hierarchy ...................................................................... doc: Add dotty graphs of BSC + MSC test component hierarchy Change-Id: I5b83a7f733eee4e4ab710985ee8dc21315ebebca --- A doc/bsc_tests_aoip.dot A doc/msc_tests_aoip.dot 2 files changed, 170 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/26652/1 diff --git a/doc/bsc_tests_aoip.dot b/doc/bsc_tests_aoip.dot new file mode 100644 index 0000000..59725ff --- /dev/null +++ b/doc/bsc_tests_aoip.dot @@ -0,0 +1,81 @@ +digraph G { + rankdir = LR; + label = "MSC_Tests component hierarcy"; + + "MSC_ConnHdlr" [ + shape = "record" + label = " RAN_ConnHdlr | BSSAP | BSSAP_PROC | RSL | RSL_PROC | MGCP | MGCP_PROC | MGCP_MULTI | BSSAP_LE | BSSAP_LE_PROC | STATSD_PROC | RAN | BSCVTY | COORD | MGCP_MSC_CLIENT" + ]; + + "RAN_Emulation_CT" [ + shape = "record" + label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + ]; + "RAN_Emulation_CT":BSSAP -> "SCCP_CT":SCCP_SP_PORT + "MSC_ConnHdlr":BSSAP -> "RAN_Emulation_CT":CLIENT + "MSC_ConnHdlr":BSSAP_PROC -> "RAN_Emulation_CT":PROC + "MSC_ConnHdlr":IPA_CTRL -> "IPA_Emulation_CT":IPA_CTRL_PORT + + "RSL_Emulation_CT" [ + shape = "record" + label = " RSL_Emulation_CT | CLIENT_PT | RSL_PROC | CCHAN_PT | IPA_PT" + ] + "RSL_Emulation_CT":IPA_PT -> "IPA_Emulation_CT":IPA_RSL_PORT + "MSC_ConnHdlr":RSL -> "RSL_Emulation_CT":CLIENT_PT + "MSC_ConnHdlr":RSL_PROC -> "RSL_Emulation_CT":RSL_PROC + + "BSSAP_LE_Emulation_CT" [ + shape = "record" + label = " BSSAP_LE_Emulation_CT | CLIENT | PROC | BSSAP_LE" + ] + "BSSAP_LE_Emulation_CT":BSSAP_LE -> "SCCP_CT":SCCP_SP_PORT + "MSC_ConnHdlr":BSSAP_LE -> "BSSAP_LE_Emulation_CT":CLIENT + "MSC_ConnHdlr":BSSAP_LE_PROC -> "BSSAP_LE_Emulation_CT":PROC + + "SCCP_CT" [ + shape = "record" + label = " SCCP_CT | MTP3_SCCP_PORT | SCCP_SP_PORT" + ]; + "SCCP_CT":MTP3_SCCP_PORT -> "M3UA_CT":MTP3_SP_PORT + + "M3UA_CT" [ + + shape = "record" + label = " M3UA_CT | SCTP_PORT | MTP3_SP_PORT" + ]; + "M3UA_CT":SCTP_PORT -> "system":SCTP + + + "StatsD_Checker_CT" [ + shape = "record" + label = " StatsD_Checker_CT | STATSD_PROC | STATS | STATSVTY" + ] + "StatsD_Checker_CT":STATS -> "system":IPL4 + "StatsD_Checker_CT":STATSVTY -> "system":TELNET + "MSC_ConnHdlr":STATSD_PROC -> "StatsD_Checker_CT":STATSD_PROC + + + "MGCP_Emulation_CT" [ + shape = "record" + label = " MGCP_Emulation_CT | MGCP_CLIENT | MGCP_PROC | MGCP_CLIENT_MULTI | MGCP" + ] + "MGCP_Emulation_CT":MGCP -> "system":IPL4 + "MGCP_Emulation_CT":MGCP -> "IPA_Emulation_CT":IPA_MGCP_PORT + "MSC_ConnHdlr":MGCP -> "MGCP_Emulation_CT":MGCP_CLIENT + "MSC_ConnHdlr":MGCP_PROC -> "MGCP_Emulation_CT":MGCP_PROC + "MSC_ConnHdlr":MGCP_MULTI -> "MGCP_Emulation_CT":MGCP_CLIENT_MULTI + "MSC_ConnHdlr":BSCVTY -> "system":TELNET + + + "IPA_Emulation_CT" [ + shape = "record" + label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" + ]; + "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 + + + "system" [ + shape = "record" + label = " system | SCTP | IPL4 | UD | TELNET" + ]; +} diff --git a/doc/msc_tests_aoip.dot b/doc/msc_tests_aoip.dot new file mode 100644 index 0000000..e80c332 --- /dev/null +++ b/doc/msc_tests_aoip.dot @@ -0,0 +1,89 @@ +digraph G { + rankdir = LR; + label = "MSC_Tests component hierarcy"; + + "BSC_ConnHdlr" [ + shape = "record" + label = " RAN_ConnHdlr | BSSAP | BSSAP_PROC | MNCC | MNCC_PROC | GSUP | GSUP_PROC | MGCP | MGCP_PROC | MGCP_MULTI | SMPP | SMPP_PROC | IPA_CTRL | SGsAP | SGsAP_PROC" + ]; + + "RAN_Emulation_CT" [ + shape = "record" + label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + ]; + "RAN_Emulation_CT":BSSAP -> "SCCP_CT":SCCP_SP_PORT + "BSC_ConnHdlr":BSSAP -> "RAN_Emulation_CT":CLIENT + "BSC_ConnHdlr":BSSAP_PROC -> "RAN_Emulation_CT":PROC + "BSC_ConnHdlr":IPA_CTRL -> "IPA_Emulation_CT":IPA_CTRL_PORT + + + "SCCP_CT" [ + shape = "record" + label = " SCCP_CT | MTP3_SCCP_PORT | SCCP_SP_PORT" + ]; + "SCCP_CT":MTP3_SCCP_PORT -> "M3UA_CT":MTP3_SP_PORT + + "M3UA_CT" [ + + shape = "record" + label = " M3UA_CT | SCTP_PORT | MTP3_SP_PORT" + ]; + "M3UA_CT":SCTP_PORT -> "system":SCTP + + + "MNCC_Emulation_CT" [ + shape = "record" + label = " MNCC_Emulation_CT | MNCC_CLIENT | MNCC_PROC | MNCC" + ] + "MNCC_Emulation_CT":MNCC -> "system":UD + "BSC_ConnHdlr":MNCC -> "MNCC_Emulation_CT":MNCC_CLIENT + "BSC_ConnHdlr":MNCC_PROC -> "MNCC_Emulation_CT":MNCC_PROC + + + "GSUP_Emulation_CT" [ + shape = "record" + label = " GSUP_Emulation_CT | GSUP_CLIENT | GSUP_PROC | GSUP" + ] + "GSUP_Emulation_CT":GSUP -> "IPA_Emulation_CT":IPA_GSUP_PORT + "BSC_ConnHdlr":GSUP -> "GSUP_Emulation_CT":GSUP_CLIENT + "BSC_ConnHdlr":GSUP_PROC -> "GSUP_Emulation_CT":GSUP_PROC + + + "MGCP_Emulation_CT" [ + shape = "record" + label = " MGCP_Emulation_CT | MGCP_CLIENT | MGCP_PROC | MGCP_CLIENT_MULTI | MGCP" + ] + "MGCP_Emulation_CT":MGCP -> "system":IPL4 + "MGCP_Emulation_CT":MGCP -> "IPA_Emulation_CT":IPA_MGCP_PORT + "BSC_ConnHdlr":MGCP -> "MGCP_Emulation_CT":MGCP_CLIENT + "BSC_ConnHdlr":MGCP_PROC -> "MGCP_Emulation_CT":MGCP_PROC + "BSC_ConnHdlr":MGCP_MULTI -> "MGCP_Emulation_CT":MGCP_CLIENT_MULTI + + "SMPP_Emulation_CT" [ + shape = "record" + label = " SMPP_Emulation_CT | SMPP_CLIENT | SMPP_PROC | SMPP_PORT" + ] + "SMPP_Emulation_CT":SMPP_PORT -> "system":IPL4 + "BSC_ConnHdlr":SMPP -> "SMPP_Emulation_CT":SMPP_CLIENT + "BSC_ConnHdlr":SMPP_PROC -> "SMPP_Emulation_CT":SMPP_PROC + + "SGsAP_Emulation_CT" [ + shape = "record" + label = " SGsAP_Emulation_CT | SGsAP_CLIENT | SGsAP_PROC | SGsAP_UNIT | SGsAP" + ] + "SGsAP_Emulation_CT":SGsAP -> "system":IPL4 + "BSC_ConnHdlr":SGsAP -> "SGsAP_Emulation_CT":SGsAP_CLIENT + "BSC_ConnHdlr":SGsAP_PROC -> "SGsAP_Emulation_CT":SGsAP_PROC + + "IPA_Emulation_CT" [ + shape = "record" + label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" + ]; + "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 + + + "system" [ + shape = "record" + label = " system | SCTP | IPL4 | UD" + ]; +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b83a7f733eee4e4ab710985ee8dc21315ebebca Gerrit-Change-Number: 26652 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 14:27:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 21 Dec 2021 14:27:18 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Add dotty graphs of BSC + MSC test component hierarchy In-Reply-To: References: Message-ID: Hello Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26652 to look at the new patch set (#2). Change subject: doc: Add dotty graphs of BSC + MSC test component hierarchy ...................................................................... doc: Add dotty graphs of BSC + MSC test component hierarchy Change-Id: I5b83a7f733eee4e4ab710985ee8dc21315ebebca --- A doc/bsc_tests_aoip.dot A doc/msc_tests_aoip.dot 2 files changed, 170 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/26652/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b83a7f733eee4e4ab710985ee8dc21315ebebca Gerrit-Change-Number: 26652 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 14:27:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 21 Dec 2021 14:27:18 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Add dotty graph of BTS_Tests component hierarchy References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26653 ) Change subject: doc: Add dotty graph of BTS_Tests component hierarchy ...................................................................... doc: Add dotty graph of BTS_Tests component hierarchy Change-Id: I42d5d67cae290f4b8b330b7800cb5337a9745ce3 --- A doc/bts_tests.dot 1 file changed, 49 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/26653/1 diff --git a/doc/bts_tests.dot b/doc/bts_tests.dot new file mode 100644 index 0000000..8cbb5b1 --- /dev/null +++ b/doc/bts_tests.dot @@ -0,0 +1,49 @@ +digraph G { + rankdir = LR; + label = "BTS_Tests component hierarchy"; + + "ConnHdlr" [ + shape = "record" + label = " ConnHdlr | RSL | RSL_PROC | LAPDM | L1CTL | BTS_TRXC | BSCVTY | PCU | RTPEM_DATA | RTPEM_CTRL" + ]; + "ConnHdlr":L1CTL -> "system":UD [label="L1CTL_PT:UD_PT"] + "ConnHdlr":BTS_TRXC -> "system":IPL4 [label="TRXC_CODEC_PT"] + "ConnHdlr":BSCVTY -> "system":TELNET + "ConnHdlr":PCU -> "system":UD [label="PCUIF_CODEC_PT"] + + "RSL_Emulation_CT" [ + shape = "record" + label = " RSL_Emulation_CT | CLIENT_PT | RSL_PROC | CCHAN_PT | IPA_PT" + ] + "RSL_Emulation_CT":IPA_PT -> "IPA_Emulation_CT":IPA_RSL_PORT + "ConnHdlr":RSL -> "RSL_Emulation_CT":CLIENT_PT + "ConnHdlr":RSL_PROC -> "RSL_Emulation_CT":RSL_PROC + + "LAPDm_CT" [ + shape = "record" + label = " LAPDM_CT | LAPDM_SP | L1CTL" + ] + "LAPDm_CT":L1CTL -> "system":UD [label="L1CTL_PT:UD_PT"] + "ConnHdlr":LAPDM -> "LAPDm_CT":LAPDM_SP + + "RTP_Emulation_CT" [ + shape = "record" + label = " RTP_Emulation_CT | DATA | CTRL | RTP | RTCP" + ] + "RTP_Emulation_CT":RTP -> "system":IPL4 [label="RTP_CODEC_PT"] + "RTP_Emulation_CT":RTCP -> "system":IPL4 [label="RTP_CODEC_PT"] + "ConnHdlr":RTPEM_DATA -> "RTP_Emulation_CT":DATA + "ConnHdlr":RTPEM_CTRL -> "RTP_Emulation_CT":CTRL + + "IPA_Emulation_CT" [ + shape = "record" + label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" + ]; + "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 + + + "system" [ + shape = "record" + label = " system | IPL4 | UD | TELNET" + ]; +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I42d5d67cae290f4b8b330b7800cb5337a9745ce3 Gerrit-Change-Number: 26653 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 14:33:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 21 Dec 2021 14:33:13 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Re-order ports in RAN_Emulation_CT References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26654 ) Change subject: doc: Re-order ports in RAN_Emulation_CT ...................................................................... doc: Re-order ports in RAN_Emulation_CT Bring it in-line with all other test components: user-facing ports at the top, IUT-facing ports at the bottom. Change-Id: I1001601f5bb7c9beb40fd0ddd404c55e3d211608 --- M doc/bsc_tests_aoip.dot M doc/msc_tests_aoip.dot M doc/ran_emulation_aoip.dot M doc/ran_emulation_sccplite.dot 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/26654/1 diff --git a/doc/bsc_tests_aoip.dot b/doc/bsc_tests_aoip.dot index 4128d5c..161142a 100644 --- a/doc/bsc_tests_aoip.dot +++ b/doc/bsc_tests_aoip.dot @@ -9,7 +9,7 @@ "RAN_Emulation_CT" [ shape = "record" - label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + label = " RAN_Emulation_CT | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC | BSSAP | RANAP" ]; "RAN_Emulation_CT":BSSAP -> "SCCP_CT":SCCP_SP_PORT "MSC_ConnHdlr":BSSAP -> "RAN_Emulation_CT":CLIENT diff --git a/doc/msc_tests_aoip.dot b/doc/msc_tests_aoip.dot index c443cbc..06359f7 100644 --- a/doc/msc_tests_aoip.dot +++ b/doc/msc_tests_aoip.dot @@ -9,7 +9,7 @@ "RAN_Emulation_CT" [ shape = "record" - label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + label = " RAN_Emulation_CT | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC | BSSAP | RANAP" ]; "RAN_Emulation_CT":BSSAP -> "SCCP_CT":SCCP_SP_PORT "BSC_ConnHdlr":BSSAP -> "RAN_Emulation_CT":CLIENT diff --git a/doc/ran_emulation_aoip.dot b/doc/ran_emulation_aoip.dot index 59f6d3d..8374555 100644 --- a/doc/ran_emulation_aoip.dot +++ b/doc/ran_emulation_aoip.dot @@ -9,7 +9,7 @@ "RAN_Emulation_CT" [ shape = "record" - label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + label = " RAN_Emulation_CT | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC | BSSAP | RANAP" ]; "SCCP_CT" [ diff --git a/doc/ran_emulation_sccplite.dot b/doc/ran_emulation_sccplite.dot index cce29b1..7ab7feb 100644 --- a/doc/ran_emulation_sccplite.dot +++ b/doc/ran_emulation_sccplite.dot @@ -9,7 +9,7 @@ "RAN_Emulation_CT" [ shape = "record" - label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + label = " RAN_Emulation_CT | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC | BSSAP | RANAP" ]; "SCCP_CT" [ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1001601f5bb7c9beb40fd0ddd404c55e3d211608 Gerrit-Change-Number: 26654 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 14:41:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 21 Dec 2021 14:41:44 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Always nnotate codec port types in case of IPL4/UD ports References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26655 ) Change subject: doc: Always nnotate codec port types in case of IPL4/UD ports ...................................................................... doc: Always nnotate codec port types in case of IPL4/UD ports Change-Id: Icee6eeb4a526ff5cbeb8b01df8149c488875455e --- M doc/bsc_tests_aoip.dot M doc/bts_tests.dot M doc/msc_tests_aoip.dot 3 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/26655/1 diff --git a/doc/bsc_tests_aoip.dot b/doc/bsc_tests_aoip.dot index 161142a..1457bdf 100644 --- a/doc/bsc_tests_aoip.dot +++ b/doc/bsc_tests_aoip.dot @@ -50,7 +50,7 @@ shape = "record" label = " StatsD_Checker_CT | STATSD_PROC | STATS | STATSVTY" ] - "StatsD_Checker_CT":STATS -> "system":IPL4 + "StatsD_Checker_CT":STATS -> "system":IPL4 [label="STATSD_CODEC_PT"] "StatsD_Checker_CT":STATSVTY -> "system":TELNET "MSC_ConnHdlr":STATSD_PROC -> "StatsD_Checker_CT":STATSD_PROC @@ -59,7 +59,7 @@ shape = "record" label = " MGCP_Emulation_CT | MGCP_CLIENT | MGCP_PROC | MGCP_CLIENT_MULTI | MGCP" ] - "MGCP_Emulation_CT":MGCP -> "system":IPL4 + "MGCP_Emulation_CT":MGCP -> "system":IPL4 [label="MGCP_CODEC_PT"] "MGCP_Emulation_CT":MGCP -> "IPA_Emulation_CT":IPA_MGCP_PORT "MSC_ConnHdlr":MGCP -> "MGCP_Emulation_CT":MGCP_CLIENT "MSC_ConnHdlr":MGCP_PROC -> "MGCP_Emulation_CT":MGCP_PROC @@ -71,7 +71,7 @@ shape = "record" label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" ]; - "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 + "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 [label="IPA_CODEC_PT"] "system" [ diff --git a/doc/bts_tests.dot b/doc/bts_tests.dot index 8cbb5b1..3fd9471 100644 --- a/doc/bts_tests.dot +++ b/doc/bts_tests.dot @@ -39,7 +39,7 @@ shape = "record" label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" ]; - "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 + "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 [label="IPA_CODEC_PT"] "system" [ diff --git a/doc/msc_tests_aoip.dot b/doc/msc_tests_aoip.dot index 06359f7..c799844 100644 --- a/doc/msc_tests_aoip.dot +++ b/doc/msc_tests_aoip.dot @@ -35,7 +35,7 @@ shape = "record" label = " MNCC_Emulation_CT | MNCC_CLIENT | MNCC_PROC | MNCC" ] - "MNCC_Emulation_CT":MNCC -> "system":UD + "MNCC_Emulation_CT":MNCC -> "system":UD [label="MNCC_CODEC_PT"] "BSC_ConnHdlr":MNCC -> "MNCC_Emulation_CT":MNCC_CLIENT "BSC_ConnHdlr":MNCC_PROC -> "MNCC_Emulation_CT":MNCC_PROC @@ -53,7 +53,7 @@ shape = "record" label = " MGCP_Emulation_CT | MGCP_CLIENT | MGCP_PROC | MGCP_CLIENT_MULTI | MGCP" ] - "MGCP_Emulation_CT":MGCP -> "system":IPL4 + "MGCP_Emulation_CT":MGCP -> "system":IPL4 [label="MGCP_CODEC_PT"] "MGCP_Emulation_CT":MGCP -> "IPA_Emulation_CT":IPA_MGCP_PORT "BSC_ConnHdlr":MGCP -> "MGCP_Emulation_CT":MGCP_CLIENT "BSC_ConnHdlr":MGCP_PROC -> "MGCP_Emulation_CT":MGCP_PROC @@ -63,7 +63,7 @@ shape = "record" label = " SMPP_Emulation_CT | SMPP_CLIENT | SMPP_PROC | SMPP_PORT" ] - "SMPP_Emulation_CT":SMPP_PORT -> "system":IPL4 + "SMPP_Emulation_CT":SMPP_PORT -> "system":IPL4 [label="SMPP_CODEC_PT"] "BSC_ConnHdlr":SMPP -> "SMPP_Emulation_CT":SMPP_CLIENT "BSC_ConnHdlr":SMPP_PROC -> "SMPP_Emulation_CT":SMPP_PROC @@ -71,7 +71,7 @@ shape = "record" label = " SGsAP_Emulation_CT | SGsAP_CLIENT | SGsAP_PROC | SGsAP_UNIT | SGsAP" ] - "SGsAP_Emulation_CT":SGsAP -> "system":IPL4 + "SGsAP_Emulation_CT":SGsAP -> "system":IPL4 [label="SGsAP_CODEC_PT"] "BSC_ConnHdlr":SGsAP -> "SGsAP_Emulation_CT":SGsAP_CLIENT "BSC_ConnHdlr":SGsAP_PROC -> "SGsAP_Emulation_CT":SGsAP_PROC @@ -79,7 +79,7 @@ shape = "record" label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" ]; - "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 + "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 [label="IPA_CODEC_PT"] "system" [ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icee6eeb4a526ff5cbeb8b01df8149c488875455e Gerrit-Change-Number: 26655 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 14:43:25 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 21 Dec 2021 14:43:25 +0000 Subject: Change in osmo-mgw[master]: mgcp_client: add new codec "IUUP" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26651 ) Change subject: mgcp_client: add new codec "IUUP" ...................................................................... Patch Set 1: did you check if there are any specs that specify the SDP payload name for IuUP? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd1210a897743396899f34457c96e6fd2109c6b3 Gerrit-Change-Number: 26651 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 21 Dec 2021 14:43:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 14:59:57 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 21 Dec 2021 14:59:57 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26454 to look at the new patch set (#12). Change subject: select: gather statistics for TCP connections ...................................................................... select: gather statistics for TCP connections osmocom applications are deployed in a variety of different situations. Dependung on the medium that interconnects the network components unexpected behaviour may occur. To debug problems with the interconnection between network components it might help to monitor the health of the related TCP connections. Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Related: SYS#5701 --- M configure.ac M include/Makefile.am A include/osmocom/core/stats_tcp.h M src/Makefile.am M src/select.c A src/stats_tcp.c M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 8 files changed, 368 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/26454/12 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 12 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 14:59:57 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 21 Dec 2021 14:59:57 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 12: (12 comments) https://gerrit.osmocom.org/c/libosmocore/+/26454/3/src/ctrl/control_if.c File src/ctrl/control_if.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/3/src/ctrl/control_if.c at 65 PS3, Line 65: # > not sure if this works for builddir != srcdir builds Done https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/select.c at 173 PS1, Line 173: /* Ensure that priv_stats is set to NULL. */ > I find this comment useless. Done https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/select.c at 388 PS1, Line 388: stats_tcp_poll(&osmo_fds); > I really don't think you want to poll those statistics every time you enter any osmo_select_main. [?] Done https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/9/src/select.c at 188 PS9, Line 188: osmo_stats_tcp_osmo_fd_unregister(fd); > Lets not make this over-complicated. Done https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.h File src/stats_tcp.h: https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.h at 5 PS1, Line 5: void stats_tcp_poll(struct llist_head *osmo_fds); > A header file just for one function? Are you planning to add more stuff here? If not, let's rather d [?] Done https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.c File src/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.c at 64 PS1, Line 64: const struct osmo_stat_item_desc stats_tcp_item_desc[] = { > static? Done https://gerrit.osmocom.org/c/libosmocore/+/26454/1/src/stats_tcp.c at 74 PS1, Line 74: const struct osmo_stat_item_group_desc stats_tcp_desc = { > static? Done https://gerrit.osmocom.org/c/libosmocore/+/26454/3/src/stats_tcp.c File src/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/26454/3/src/stats_tcp.c at 54 PS3, Line 54: static LLIST_HEAD(stats_tcp); > I wonder if this should also be __thread, as the osmo_fd list is per-thread. [?] I feel more comfortable with keeping the stats_tcp list global and using mutexes to protect the critical path. I am also not sure how well the whole stats stuff integrates with threads. Also I have no experience with handling the different threads, starting the timers, vty etc... https://gerrit.osmocom.org/c/libosmocore/+/26454/3/src/stats_tcp.c at 170 PS3, Line 170: return; > comment does not agree with function. [?] I am a bit surprised. There seem to be no way to find out via getsockopt if a socket is a TCP socket. https://gerrit.osmocom.org/c/libosmocore/+/26454/3/src/stats_tcp.c at 227 PS3, Line 227: llist_for_each_entry(stats_tcp_entry, &stats_tcp, entry) { : fill_stats(stats_tcp_entry); : } > doing all sockets at once has the danger of creating high latency. [?] I agree that this might be a problem. This is addressed in the current patch set. https://gerrit.osmocom.org/c/libosmocore/+/26454/3/src/stats_tcp.c at 247 PS3, Line 247: osmo_timer_setup(&stats_tcp_poll_timer, stats_tcp_poll_timer_cb, NULL); > are we sure we can call osmo_timer_schedule from this constructor? As constructor call ordering is [?] Probably that is unsafe. We have decided that we want to set the default interval to 0. This means that the timer can never be scheduled from the constructor anyway. So we can remove this line and only do the osmo_timer_setup from here. https://gerrit.osmocom.org/c/libosmocore/+/26454/3/src/stats_tcp_internal.h File src/stats_tcp_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/26454/3/src/stats_tcp_internal.h at 11 PS3, Line 11: void stats_tcp_osmo_fd_register(struct osmo_fd *fd); : void stats_tcp_osmo_fd_unregister(struct osmo_fd *fd); : int stats_tcp_set_interval(int interval); > those symbols [?] In the current patchset I have elimnated the need for stats_tcp_internal.h. Its now more uniform to stats.h, which is better I think. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 12 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 21 Dec 2021 14:59:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Comment-In-Reply-To: dexter Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 15:33:05 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 21 Dec 2021 15:33:05 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26454 to look at the new patch set (#13). Change subject: select: gather statistics for TCP connections ...................................................................... select: gather statistics for TCP connections osmocom applications are deployed in a variety of different situations. Dependung on the medium that interconnects the network components unexpected behaviour may occur. To debug problems with the interconnection between network components it might help to monitor the health of the related TCP connections. Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Related: SYS#5701 --- M configure.ac M include/Makefile.am A include/osmocom/core/stats_tcp.h M src/Makefile.am M src/select.c A src/stats_tcp.c M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 8 files changed, 368 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/26454/13 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 13 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 15:41:44 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 21 Dec 2021 15:41:44 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26454 to look at the new patch set (#14). Change subject: select: gather statistics for TCP connections ...................................................................... select: gather statistics for TCP connections osmocom applications are deployed in a variety of different situations. Dependung on the medium that interconnects the network components unexpected behaviour may occur. To debug problems with the interconnection between network components it might help to monitor the health of the related TCP connections. Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Related: SYS#5701 --- M configure.ac M include/Makefile.am A include/osmocom/core/stats_tcp.h M src/Makefile.am M src/select.c A src/stats_tcp.c M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 8 files changed, 367 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/26454/14 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 14 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 15:54:31 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 21 Dec 2021 15:54:31 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26454 to look at the new patch set (#15). Change subject: select: gather statistics for TCP connections ...................................................................... select: gather statistics for TCP connections osmocom applications are deployed in a variety of different situations. Dependung on the medium that interconnects the network components unexpected behaviour may occur. To debug problems with the interconnection between network components it might help to monitor the health of the related TCP connections. Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Related: SYS#5701 --- M configure.ac M include/Makefile.am A include/osmocom/core/stats_tcp.h M src/Makefile.am M src/select.c A src/stats_tcp.c M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 8 files changed, 386 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/26454/15 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 15 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 16:30:16 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Tue, 21 Dec 2021 16:30:16 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26454 to look at the new patch set (#16). Change subject: select: gather statistics for TCP connections ...................................................................... select: gather statistics for TCP connections osmocom applications are deployed in a variety of different situations. Dependung on the medium that interconnects the network components unexpected behaviour may occur. To debug problems with the interconnection between network components it might help to monitor the health of the related TCP connections. Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Related: SYS#5701 --- M configure.ac M include/Makefile.am A include/osmocom/core/stats_tcp.h M src/Makefile.am M src/select.c A src/stats_tcp.c M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 8 files changed, 367 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/26454/16 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 16 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 17:30:31 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 21 Dec 2021 17:30:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: IuUP_Emulation: Fix frame number wrap-around References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26656 ) Change subject: IuUP_Emulation: Fix frame number wrap-around ...................................................................... IuUP_Emulation: Fix frame number wrap-around As seen when running a test: IuUP_Emulation.ttcn:150 Dynamic test case error: While RAW-encoding type '@IuUP_Types.IuUP_PDU': There are insufficient bits to encode '@IuUP_Types.IuUP_PDU_Type_0.frame_nr' Change-Id: Ic9e69115c49545a7b9797d8f85568d5e91dfb329 --- M library/IuUP_Emulation.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/26656/1 diff --git a/library/IuUP_Emulation.ttcn b/library/IuUP_Emulation.ttcn index 56384ee..b35602c 100644 --- a/library/IuUP_Emulation.ttcn +++ b/library/IuUP_Emulation.ttcn @@ -143,7 +143,7 @@ } else { pdu := valueof(ts_IuUP_Type1(st.tx_next_frame_nr, 0, payload)); } - st.tx_next_frame_nr := st.tx_next_frame_nr + 1; + st.tx_next_frame_nr := (st.tx_next_frame_nr + 1) mod 16; } } if (isvalue(pdu)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9e69115c49545a7b9797d8f85568d5e91dfb329 Gerrit-Change-Number: 26656 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 18:46:30 2021 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Tue, 21 Dec 2021 18:46:30 +0000 Subject: Change in libosmocore[master]: conv: Fix the traceback for tail biting codes References: Message-ID: tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26657 ) Change subject: conv: Fix the traceback for tail biting codes ...................................................................... conv: Fix the traceback for tail biting codes When picking the end state, looking only at the path metric is highly suboptimal because in a tail biting code, we _know_ that whatever treillis path is correct, it must start and end at the same state. So we only consider path meeting that condition. We know any path that doesn't isn't the right one. We only fallback to only path metric if no path met that condition. Fixes #4508 Signed-off-by: Sylvain Munaut Change-Id: I87e51d3880c0fe7bf3d6cd08fd46517a424a230c --- M include/osmocom/core/conv.h M src/conv.c M src/conv_acc.c 3 files changed, 93 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/57/26657/1 diff --git a/include/osmocom/core/conv.h b/include/osmocom/core/conv.h index 1c14c3b..84ef0f8 100644 --- a/include/osmocom/core/conv.h +++ b/include/osmocom/core/conv.h @@ -124,6 +124,7 @@ const sbit_t *input, int n); int osmo_conv_decode_flush(struct osmo_conv_decoder *decoder, const sbit_t *input); +int osmo_conv_decode_get_best_end_state(struct osmo_conv_decoder *decoder); int osmo_conv_decode_get_output(struct osmo_conv_decoder *decoder, ubit_t *output, int has_flush, int end_state); diff --git a/src/conv.c b/src/conv.c index 0e07e1f..453e942 100644 --- a/src/conv.c +++ b/src/conv.c @@ -526,6 +526,68 @@ } int +osmo_conv_decode_get_best_end_state(struct osmo_conv_decoder *decoder) +{ + const struct osmo_conv_code *code = decoder->code; + + int min_ae, min_state; + int s; + + /* If flushed, we _know_ the end state */ + if (code->term == CONV_TERM_FLUSH) + return 0; + + /* Search init */ + min_state = -1; + min_ae = MAX_AE; + + /* If tail biting, we search for the minimum path metric that + * gives a circular traceback (i.e. start_state == end_state */ + if (code->term == CONV_TERM_TAIL_BITING) + { + int t, n, i; + uint8_t *sh_ptr; + + for (s=0; sn_states; s++) + { + /* Check if that state traces back to itself */ + n = decoder->o_idx; + sh_ptr = &decoder->state_history[decoder->n_states * (n-1)]; + t = s; + + for (i=n-1; i>=0; i--) { + t = sh_ptr[t]; + sh_ptr -= decoder->n_states; + } + + if (s != t) + continue; + + /* If it does, consider it */ + if (decoder->ae[s] < min_ae) { + min_ae = decoder->ae[s]; + min_state = s; + } + } + + if (min_ae < MAX_AE) + return min_state; + } + + /* Finally, just the lowest path metric */ + for (s=0; sn_states; s++) + { + /* Is it smaller ? */ + if (decoder->ae[s] < min_ae) { + min_ae = decoder->ae[s]; + min_state = s; + } + } + + return min_state; +} + +int osmo_conv_decode_get_output(struct osmo_conv_decoder *decoder, ubit_t *output, int has_flush, int end_state) { @@ -533,30 +595,19 @@ int min_ae; uint8_t min_state, cur_state; - int i, s, n; + int i, n; uint8_t *sh_ptr; /* End state ? */ - if (end_state < 0) { - /* Find state with least error */ - min_ae = MAX_AE; - min_state = 0xff; + if (end_state < 0) + end_state = osmo_conv_decode_get_best_end_state(decoder); - for (s=0; sn_states; s++) - { - if (decoder->ae[s] < min_ae) { - min_ae = decoder->ae[s]; - min_state = s; - } - } + if (end_state < 0) + return -1; - if (min_state == 0xff) - return -1; - } else { - min_state = (uint8_t) end_state; - min_ae = decoder->ae[end_state]; - } + min_state = (uint8_t) end_state; + min_ae = decoder->ae[end_state]; /* Traceback */ cur_state = min_state; @@ -598,8 +649,8 @@ * * This is an all-in-one function, taking care of * \ref osmo_conv_decode_init, \ref osmo_conv_decode_scan, - * \ref osmo_conv_decode_flush, \ref osmo_conv_decode_get_output and - * \ref osmo_conv_decode_deinit. + * \ref osmo_conv_decode_flush, \ref osmo_conv_decode_get_best_end_state, + * \ref osmo_conv_decode_get_output and \ref osmo_conv_decode_deinit. */ int osmo_conv_decode(const struct osmo_conv_code *code, @@ -626,7 +677,7 @@ rv = osmo_conv_decode_get_output(&decoder, output, code->term == CONV_TERM_FLUSH, /* has_flush */ - code->term == CONV_TERM_FLUSH ? 0 : -1 /* end_state */ + -1 /* end_state */ ); osmo_conv_decode_deinit(&decoder); diff --git a/src/conv_acc.c b/src/conv_acc.c index a26ed3b..4bd3b07 100644 --- a/src/conv_acc.c +++ b/src/conv_acc.c @@ -483,10 +483,27 @@ */ static int traceback(struct vdecoder *dec, uint8_t *out, int term, int len) { - int i, sum, max = -1; - unsigned path, state = 0; + int i, j, sum, max = -1; + unsigned path, state = 0, state_scan; - if (term != CONV_TERM_FLUSH) { + if (term == CONV_TERM_TAIL_BITING) { + for (i = 0; i < dec->trellis.num_states; i++) { + state_scan = i; + for (j = len - 1; j >= 0; j--) { + path = dec->paths[j][state_scan] + 1; + state_scan = vstate_lshift(state_scan, dec->k, path); + } + if (state_scan != i) + continue; + sum = dec->trellis.sums[i]; + if (sum > max) { + max = sum; + state = i; + } + } + } + + if ((max < 0) && (term != CONV_TERM_FLUSH)) { for (i = 0; i < dec->trellis.num_states; i++) { sum = dec->trellis.sums[i]; if (sum > max) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I87e51d3880c0fe7bf3d6cd08fd46517a424a230c Gerrit-Change-Number: 26657 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 19:46:15 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 19:46:15 +0000 Subject: Change in osmo-bsc-nat[master]: Add project skeleton References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 ) Change subject: Add project skeleton ...................................................................... Add project skeleton It was decided to write OsmoBSCNAT with 3GPP AoIP support from scratch, in a separate repository from OsmoBSC. The previous codebase was too heavily tied into legacy SCCPlite code and had been removed from osmo-bsc.git in Ia05dc76336a64a7f08962843b9a7cc19f2c83387. Related: OS#2545 Change-Id: Iae5d37483dcb9db00578d5c9cd1736f08754a65e --- A .gitignore A .gitreview A AUTHORS A COPYING A Makefile.am A README.md A configure.ac A contrib/Makefile.am A contrib/jenkins.sh A contrib/osmo-bsc-nat.spec.in A contrib/systemd/Makefile.am A contrib/systemd/osmo-bsc-nat.service A debian/changelog A debian/compat A debian/control A debian/copyright A debian/osmo-bsc-nat.install A debian/rules A debian/source/format A doc/Makefile.am A doc/examples/Makefile.am A doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg A doc/manuals/Makefile.am A doc/manuals/chapters/overview.adoc A doc/manuals/osmobscnat-usermanual-docinfo.xml A doc/manuals/osmobscnat-usermanual.adoc A doc/manuals/osmobscnat-vty-reference.xml A doc/manuals/regen_doc.sh A doc/manuals/vty/bsc_nat_vty_additions.xml A git-version-gen A include/Makefile.am A include/osmocom/Makefile.am A include/osmocom/bsc_nat/Makefile.am A include/osmocom/bsc_nat/bsc_nat.h A osmoappdesc.py A src/Makefile.am A src/osmo-bsc-nat/Makefile.am A src/osmo-bsc-nat/main.c A tests/Makefile.am A tests/atlocal.in A tests/ctrl_test_runner.py A tests/osmo-bsc-nat.vty A tests/testsuite.at 43 files changed, 2,146 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/58/26658/1 diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..314cf0b --- /dev/null +++ b/.gitignore @@ -0,0 +1,73 @@ +debian/*.log +*.o +*.lo +*.a +.deps +Makefile +Makefile.in +config.h +config.h.in +*.pc +*~ + +*.*~ +*.sw? +.libs +*.pyc +*.gcda +*.gcno + +**/TAGS + +#configure +aclocal.m4 +autom4te.cache/ +config.log +config.status +config.guess +config.sub +configure +compile +depcomp +install-sh +missing +stamp-h1 +libtool +ltmain.sh +m4/*.m4 + +# git-version-gen magic +.tarball-version +.version +osmo-bsc-nat-*.tar.bz2 +osmo-bsc-nat-*.tar.gz + +tags +/deps + +src/osmo-bsc-nat/osmo-bsc-nat + +#tests +tests/testsuite.dir +tests/*/*_test + +tests/atconfig +tests/atlocal +tests/package.m4 +tests/testsuite +tests/testsuite.log + +writtenconfig/ + +# manuals +doc/manuals/*.html +doc/manuals/*.svg +doc/manuals/*.pdf +doc/manuals/*__*.png +doc/manuals/*.check +doc/manuals/generated/ +doc/manuals/osmobscnat-usermanual.xml +doc/manuals/common +doc/manuals/build + +contrib/osmo-bsc-nat.spec diff --git a/.gitreview b/.gitreview new file mode 100644 index 0000000..8ef54fd --- /dev/null +++ b/.gitreview @@ -0,0 +1,3 @@ +[gerrit] +host=gerrit.osmocom.org +project=osmo-bsc-nat diff --git a/AUTHORS b/AUTHORS new file mode 100644 index 0000000..79a9f72 --- /dev/null +++ b/AUTHORS @@ -0,0 +1 @@ +Oliver Smith diff --git a/COPYING b/COPYING new file mode 100644 index 0000000..dba13ed --- /dev/null +++ b/COPYING @@ -0,0 +1,661 @@ + GNU AFFERO GENERAL PUBLIC LICENSE + Version 3, 19 November 2007 + + Copyright (C) 2007 Free Software Foundation, Inc. + Everyone is permitted to copy and distribute verbatim copies + of this license document, but changing it is not allowed. + + Preamble + + The GNU Affero General Public License is a free, copyleft license for +software and other kinds of works, specifically designed to ensure +cooperation with the community in the case of network server software. + + The licenses for most software and other practical works are designed +to take away your freedom to share and change the works. By contrast, +our General Public Licenses are intended to guarantee your freedom to +share and change all versions of a program--to make sure it remains free +software for all its users. + + When we speak of free software, we are referring to freedom, not +price. Our General Public Licenses are designed to make sure that you +have the freedom to distribute copies of free software (and charge for +them if you wish), that you receive source code or can get it if you +want it, that you can change the software or use pieces of it in new +free programs, and that you know you can do these things. + + Developers that use our General Public Licenses protect your rights +with two steps: (1) assert copyright on the software, and (2) offer +you this License which gives you legal permission to copy, distribute +and/or modify the software. + + A secondary benefit of defending all users' freedom is that +improvements made in alternate versions of the program, if they +receive widespread use, become available for other developers to +incorporate. Many developers of free software are heartened and +encouraged by the resulting cooperation. However, in the case of +software used on network servers, this result may fail to come about. +The GNU General Public License permits making a modified version and +letting the public access it on a server without ever releasing its +source code to the public. + + The GNU Affero General Public License is designed specifically to +ensure that, in such cases, the modified source code becomes available +to the community. It requires the operator of a network server to +provide the source code of the modified version running there to the +users of that server. Therefore, public use of a modified version, on +a publicly accessible server, gives the public access to the source +code of the modified version. + + An older license, called the Affero General Public License and +published by Affero, was designed to accomplish similar goals. This is +a different license, not a version of the Affero GPL, but Affero has +released a new version of the Affero GPL which permits relicensing under +this license. + + The precise terms and conditions for copying, distribution and +modification follow. + + TERMS AND CONDITIONS + + 0. Definitions. + + "This License" refers to version 3 of the GNU Affero General Public License. + + "Copyright" also means copyright-like laws that apply to other kinds of +works, such as semiconductor masks. + + "The Program" refers to any copyrightable work licensed under this +License. Each licensee is addressed as "you". "Licensees" and +"recipients" may be individuals or organizations. + + To "modify" a work means to copy from or adapt all or part of the work +in a fashion requiring copyright permission, other than the making of an +exact copy. The resulting work is called a "modified version" of the +earlier work or a work "based on" the earlier work. + + A "covered work" means either the unmodified Program or a work based +on the Program. + + To "propagate" a work means to do anything with it that, without +permission, would make you directly or secondarily liable for +infringement under applicable copyright law, except executing it on a +computer or modifying a private copy. Propagation includes copying, +distribution (with or without modification), making available to the +public, and in some countries other activities as well. + + To "convey" a work means any kind of propagation that enables other +parties to make or receive copies. Mere interaction with a user through +a computer network, with no transfer of a copy, is not conveying. + + An interactive user interface displays "Appropriate Legal Notices" +to the extent that it includes a convenient and prominently visible +feature that (1) displays an appropriate copyright notice, and (2) +tells the user that there is no warranty for the work (except to the +extent that warranties are provided), that licensees may convey the +work under this License, and how to view a copy of this License. If +the interface presents a list of user commands or options, such as a +menu, a prominent item in the list meets this criterion. + + 1. Source Code. + + The "source code" for a work means the preferred form of the work +for making modifications to it. "Object code" means any non-source +form of a work. + + A "Standard Interface" means an interface that either is an official +standard defined by a recognized standards body, or, in the case of +interfaces specified for a particular programming language, one that +is widely used among developers working in that language. + + The "System Libraries" of an executable work include anything, other +than the work as a whole, that (a) is included in the normal form of +packaging a Major Component, but which is not part of that Major +Component, and (b) serves only to enable use of the work with that +Major Component, or to implement a Standard Interface for which an +implementation is available to the public in source code form. A +"Major Component", in this context, means a major essential component +(kernel, window system, and so on) of the specific operating system +(if any) on which the executable work runs, or a compiler used to +produce the work, or an object code interpreter used to run it. + + The "Corresponding Source" for a work in object code form means all +the source code needed to generate, install, and (for an executable +work) run the object code and to modify the work, including scripts to +control those activities. However, it does not include the work's +System Libraries, or general-purpose tools or generally available free +programs which are used unmodified in performing those activities but +which are not part of the work. For example, Corresponding Source +includes interface definition files associated with source files for +the work, and the source code for shared libraries and dynamically +linked subprograms that the work is specifically designed to require, +such as by intimate data communication or control flow between those +subprograms and other parts of the work. + + The Corresponding Source need not include anything that users +can regenerate automatically from other parts of the Corresponding +Source. + + The Corresponding Source for a work in source code form is that +same work. + + 2. Basic Permissions. + + All rights granted under this License are granted for the term of +copyright on the Program, and are irrevocable provided the stated +conditions are met. This License explicitly affirms your unlimited +permission to run the unmodified Program. The output from running a +covered work is covered by this License only if the output, given its +content, constitutes a covered work. This License acknowledges your +rights of fair use or other equivalent, as provided by copyright law. + + You may make, run and propagate covered works that you do not +convey, without conditions so long as your license otherwise remains +in force. You may convey covered works to others for the sole purpose +of having them make modifications exclusively for you, or provide you +with facilities for running those works, provided that you comply with +the terms of this License in conveying all material for which you do +not control copyright. Those thus making or running the covered works +for you must do so exclusively on your behalf, under your direction +and control, on terms that prohibit them from making any copies of +your copyrighted material outside their relationship with you. + + Conveying under any other circumstances is permitted solely under +the conditions stated below. Sublicensing is not allowed; section 10 +makes it unnecessary. + + 3. Protecting Users' Legal Rights From Anti-Circumvention Law. + + No covered work shall be deemed part of an effective technological +measure under any applicable law fulfilling obligations under article +11 of the WIPO copyright treaty adopted on 20 December 1996, or +similar laws prohibiting or restricting circumvention of such +measures. + + When you convey a covered work, you waive any legal power to forbid +circumvention of technological measures to the extent such circumvention +is effected by exercising rights under this License with respect to +the covered work, and you disclaim any intention to limit operation or +modification of the work as a means of enforcing, against the work's +users, your or third parties' legal rights to forbid circumvention of +technological measures. + + 4. Conveying Verbatim Copies. + + You may convey verbatim copies of the Program's source code as you +receive it, in any medium, provided that you conspicuously and +appropriately publish on each copy an appropriate copyright notice; +keep intact all notices stating that this License and any +non-permissive terms added in accord with section 7 apply to the code; +keep intact all notices of the absence of any warranty; and give all +recipients a copy of this License along with the Program. + + You may charge any price or no price for each copy that you convey, +and you may offer support or warranty protection for a fee. + + 5. Conveying Modified Source Versions. + + You may convey a work based on the Program, or the modifications to +produce it from the Program, in the form of source code under the +terms of section 4, provided that you also meet all of these conditions: + + a) The work must carry prominent notices stating that you modified + it, and giving a relevant date. + + b) The work must carry prominent notices stating that it is + released under this License and any conditions added under section + 7. This requirement modifies the requirement in section 4 to + "keep intact all notices". + + c) You must license the entire work, as a whole, under this + License to anyone who comes into possession of a copy. This + License will therefore apply, along with any applicable section 7 + additional terms, to the whole of the work, and all its parts, + regardless of how they are packaged. This License gives no + permission to license the work in any other way, but it does not + invalidate such permission if you have separately received it. + + d) If the work has interactive user interfaces, each must display + Appropriate Legal Notices; however, if the Program has interactive + interfaces that do not display Appropriate Legal Notices, your + work need not make them do so. + + A compilation of a covered work with other separate and independent +works, which are not by their nature extensions of the covered work, +and which are not combined with it such as to form a larger program, +in or on a volume of a storage or distribution medium, is called an +"aggregate" if the compilation and its resulting copyright are not +used to limit the access or legal rights of the compilation's users +beyond what the individual works permit. Inclusion of a covered work +in an aggregate does not cause this License to apply to the other +parts of the aggregate. + + 6. Conveying Non-Source Forms. + + You may convey a covered work in object code form under the terms +of sections 4 and 5, provided that you also convey the +machine-readable Corresponding Source under the terms of this License, +in one of these ways: + + a) Convey the object code in, or embodied in, a physical product + (including a physical distribution medium), accompanied by the + Corresponding Source fixed on a durable physical medium + customarily used for software interchange. + + b) Convey the object code in, or embodied in, a physical product + (including a physical distribution medium), accompanied by a + written offer, valid for at least three years and valid for as + long as you offer spare parts or customer support for that product + model, to give anyone who possesses the object code either (1) a + copy of the Corresponding Source for all the software in the + product that is covered by this License, on a durable physical + medium customarily used for software interchange, for a price no + more than your reasonable cost of physically performing this + conveying of source, or (2) access to copy the + Corresponding Source from a network server at no charge. + + c) Convey individual copies of the object code with a copy of the + written offer to provide the Corresponding Source. This + alternative is allowed only occasionally and noncommercially, and + only if you received the object code with such an offer, in accord + with subsection 6b. + + d) Convey the object code by offering access from a designated + place (gratis or for a charge), and offer equivalent access to the + Corresponding Source in the same way through the same place at no + further charge. You need not require recipients to copy the + Corresponding Source along with the object code. If the place to + copy the object code is a network server, the Corresponding Source + may be on a different server (operated by you or a third party) + that supports equivalent copying facilities, provided you maintain + clear directions next to the object code saying where to find the + Corresponding Source. Regardless of what server hosts the + Corresponding Source, you remain obligated to ensure that it is + available for as long as needed to satisfy these requirements. + + e) Convey the object code using peer-to-peer transmission, provided + you inform other peers where the object code and Corresponding + Source of the work are being offered to the general public at no + charge under subsection 6d. + + A separable portion of the object code, whose source code is excluded +from the Corresponding Source as a System Library, need not be +included in conveying the object code work. + + A "User Product" is either (1) a "consumer product", which means any +tangible personal property which is normally used for personal, family, +or household purposes, or (2) anything designed or sold for incorporation +into a dwelling. In determining whether a product is a consumer product, +doubtful cases shall be resolved in favor of coverage. For a particular +product received by a particular user, "normally used" refers to a +typical or common use of that class of product, regardless of the status +of the particular user or of the way in which the particular user +actually uses, or expects or is expected to use, the product. A product +is a consumer product regardless of whether the product has substantial +commercial, industrial or non-consumer uses, unless such uses represent +the only significant mode of use of the product. + + "Installation Information" for a User Product means any methods, +procedures, authorization keys, or other information required to install +and execute modified versions of a covered work in that User Product from +a modified version of its Corresponding Source. The information must +suffice to ensure that the continued functioning of the modified object +code is in no case prevented or interfered with solely because +modification has been made. + + If you convey an object code work under this section in, or with, or +specifically for use in, a User Product, and the conveying occurs as +part of a transaction in which the right of possession and use of the +User Product is transferred to the recipient in perpetuity or for a +fixed term (regardless of how the transaction is characterized), the +Corresponding Source conveyed under this section must be accompanied +by the Installation Information. But this requirement does not apply +if neither you nor any third party retains the ability to install +modified object code on the User Product (for example, the work has +been installed in ROM). + + The requirement to provide Installation Information does not include a +requirement to continue to provide support service, warranty, or updates +for a work that has been modified or installed by the recipient, or for +the User Product in which it has been modified or installed. Access to a +network may be denied when the modification itself materially and +adversely affects the operation of the network or violates the rules and +protocols for communication across the network. + + Corresponding Source conveyed, and Installation Information provided, +in accord with this section must be in a format that is publicly +documented (and with an implementation available to the public in +source code form), and must require no special password or key for +unpacking, reading or copying. + + 7. Additional Terms. + + "Additional permissions" are terms that supplement the terms of this +License by making exceptions from one or more of its conditions. +Additional permissions that are applicable to the entire Program shall +be treated as though they were included in this License, to the extent +that they are valid under applicable law. If additional permissions +apply only to part of the Program, that part may be used separately +under those permissions, but the entire Program remains governed by +this License without regard to the additional permissions. + + When you convey a copy of a covered work, you may at your option +remove any additional permissions from that copy, or from any part of +it. (Additional permissions may be written to require their own +removal in certain cases when you modify the work.) You may place +additional permissions on material, added by you to a covered work, +for which you have or can give appropriate copyright permission. + + Notwithstanding any other provision of this License, for material you +add to a covered work, you may (if authorized by the copyright holders of +that material) supplement the terms of this License with terms: + + a) Disclaiming warranty or limiting liability differently from the + terms of sections 15 and 16 of this License; or + + b) Requiring preservation of specified reasonable legal notices or + author attributions in that material or in the Appropriate Legal + Notices displayed by works containing it; or + + c) Prohibiting misrepresentation of the origin of that material, or + requiring that modified versions of such material be marked in + reasonable ways as different from the original version; or + + d) Limiting the use for publicity purposes of names of licensors or + authors of the material; or + + e) Declining to grant rights under trademark law for use of some + trade names, trademarks, or service marks; or + + f) Requiring indemnification of licensors and authors of that + material by anyone who conveys the material (or modified versions of + it) with contractual assumptions of liability to the recipient, for + any liability that these contractual assumptions directly impose on + those licensors and authors. + + All other non-permissive additional terms are considered "further +restrictions" within the meaning of section 10. If the Program as you +received it, or any part of it, contains a notice stating that it is +governed by this License along with a term that is a further +restriction, you may remove that term. If a license document contains +a further restriction but permits relicensing or conveying under this +License, you may add to a covered work material governed by the terms +of that license document, provided that the further restriction does +not survive such relicensing or conveying. + + If you add terms to a covered work in accord with this section, you +must place, in the relevant source files, a statement of the +additional terms that apply to those files, or a notice indicating +where to find the applicable terms. + + Additional terms, permissive or non-permissive, may be stated in the +form of a separately written license, or stated as exceptions; +the above requirements apply either way. + + 8. Termination. + + You may not propagate or modify a covered work except as expressly +provided under this License. Any attempt otherwise to propagate or +modify it is void, and will automatically terminate your rights under +this License (including any patent licenses granted under the third +paragraph of section 11). + + However, if you cease all violation of this License, then your +license from a particular copyright holder is reinstated (a) +provisionally, unless and until the copyright holder explicitly and +finally terminates your license, and (b) permanently, if the copyright +holder fails to notify you of the violation by some reasonable means +prior to 60 days after the cessation. + + Moreover, your license from a particular copyright holder is +reinstated permanently if the copyright holder notifies you of the +violation by some reasonable means, this is the first time you have +received notice of violation of this License (for any work) from that +copyright holder, and you cure the violation prior to 30 days after +your receipt of the notice. + + Termination of your rights under this section does not terminate the +licenses of parties who have received copies or rights from you under +this License. If your rights have been terminated and not permanently +reinstated, you do not qualify to receive new licenses for the same +material under section 10. + + 9. Acceptance Not Required for Having Copies. + + You are not required to accept this License in order to receive or +run a copy of the Program. Ancillary propagation of a covered work +occurring solely as a consequence of using peer-to-peer transmission +to receive a copy likewise does not require acceptance. However, +nothing other than this License grants you permission to propagate or +modify any covered work. These actions infringe copyright if you do +not accept this License. Therefore, by modifying or propagating a +covered work, you indicate your acceptance of this License to do so. + + 10. Automatic Licensing of Downstream Recipients. + + Each time you convey a covered work, the recipient automatically +receives a license from the original licensors, to run, modify and +propagate that work, subject to this License. You are not responsible +for enforcing compliance by third parties with this License. + + An "entity transaction" is a transaction transferring control of an +organization, or substantially all assets of one, or subdividing an +organization, or merging organizations. If propagation of a covered +work results from an entity transaction, each party to that +transaction who receives a copy of the work also receives whatever +licenses to the work the party's predecessor in interest had or could +give under the previous paragraph, plus a right to possession of the +Corresponding Source of the work from the predecessor in interest, if +the predecessor has it or can get it with reasonable efforts. + + You may not impose any further restrictions on the exercise of the +rights granted or affirmed under this License. For example, you may +not impose a license fee, royalty, or other charge for exercise of +rights granted under this License, and you may not initiate litigation +(including a cross-claim or counterclaim in a lawsuit) alleging that +any patent claim is infringed by making, using, selling, offering for +sale, or importing the Program or any portion of it. + + 11. Patents. + + A "contributor" is a copyright holder who authorizes use under this +License of the Program or a work on which the Program is based. The +work thus licensed is called the contributor's "contributor version". + + A contributor's "essential patent claims" are all patent claims +owned or controlled by the contributor, whether already acquired or +hereafter acquired, that would be infringed by some manner, permitted +by this License, of making, using, or selling its contributor version, +but do not include claims that would be infringed only as a +consequence of further modification of the contributor version. For +purposes of this definition, "control" includes the right to grant +patent sublicenses in a manner consistent with the requirements of +this License. + + Each contributor grants you a non-exclusive, worldwide, royalty-free +patent license under the contributor's essential patent claims, to +make, use, sell, offer for sale, import and otherwise run, modify and +propagate the contents of its contributor version. + + In the following three paragraphs, a "patent license" is any express +agreement or commitment, however denominated, not to enforce a patent +(such as an express permission to practice a patent or covenant not to +sue for patent infringement). To "grant" such a patent license to a +party means to make such an agreement or commitment not to enforce a +patent against the party. + + If you convey a covered work, knowingly relying on a patent license, +and the Corresponding Source of the work is not available for anyone +to copy, free of charge and under the terms of this License, through a +publicly available network server or other readily accessible means, +then you must either (1) cause the Corresponding Source to be so +available, or (2) arrange to deprive yourself of the benefit of the +patent license for this particular work, or (3) arrange, in a manner +consistent with the requirements of this License, to extend the patent +license to downstream recipients. "Knowingly relying" means you have +actual knowledge that, but for the patent license, your conveying the +covered work in a country, or your recipient's use of the covered work +in a country, would infringe one or more identifiable patents in that +country that you have reason to believe are valid. + + If, pursuant to or in connection with a single transaction or +arrangement, you convey, or propagate by procuring conveyance of, a +covered work, and grant a patent license to some of the parties +receiving the covered work authorizing them to use, propagate, modify +or convey a specific copy of the covered work, then the patent license +you grant is automatically extended to all recipients of the covered +work and works based on it. + + A patent license is "discriminatory" if it does not include within +the scope of its coverage, prohibits the exercise of, or is +conditioned on the non-exercise of one or more of the rights that are +specifically granted under this License. You may not convey a covered +work if you are a party to an arrangement with a third party that is +in the business of distributing software, under which you make payment +to the third party based on the extent of your activity of conveying +the work, and under which the third party grants, to any of the +parties who would receive the covered work from you, a discriminatory +patent license (a) in connection with copies of the covered work +conveyed by you (or copies made from those copies), or (b) primarily +for and in connection with specific products or compilations that +contain the covered work, unless you entered into that arrangement, +or that patent license was granted, prior to 28 March 2007. + + Nothing in this License shall be construed as excluding or limiting +any implied license or other defenses to infringement that may +otherwise be available to you under applicable patent law. + + 12. No Surrender of Others' Freedom. + + If conditions are imposed on you (whether by court order, agreement or +otherwise) that contradict the conditions of this License, they do not +excuse you from the conditions of this License. If you cannot convey a +covered work so as to satisfy simultaneously your obligations under this +License and any other pertinent obligations, then as a consequence you may +not convey it at all. For example, if you agree to terms that obligate you +to collect a royalty for further conveying from those to whom you convey +the Program, the only way you could satisfy both those terms and this +License would be to refrain entirely from conveying the Program. + + 13. Remote Network Interaction; Use with the GNU General Public License. + + Notwithstanding any other provision of this License, if you modify the +Program, your modified version must prominently offer all users +interacting with it remotely through a computer network (if your version +supports such interaction) an opportunity to receive the Corresponding +Source of your version by providing access to the Corresponding Source +from a network server at no charge, through some standard or customary +means of facilitating copying of software. This Corresponding Source +shall include the Corresponding Source for any work covered by version 3 +of the GNU General Public License that is incorporated pursuant to the +following paragraph. + + Notwithstanding any other provision of this License, you have +permission to link or combine any covered work with a work licensed +under version 3 of the GNU General Public License into a single +combined work, and to convey the resulting work. The terms of this +License will continue to apply to the part which is the covered work, +but the work with which it is combined will remain governed by version +3 of the GNU General Public License. + + 14. Revised Versions of this License. + + The Free Software Foundation may publish revised and/or new versions of +the GNU Affero General Public License from time to time. Such new versions +will be similar in spirit to the present version, but may differ in detail to +address new problems or concerns. + + Each version is given a distinguishing version number. If the +Program specifies that a certain numbered version of the GNU Affero General +Public License "or any later version" applies to it, you have the +option of following the terms and conditions either of that numbered +version or of any later version published by the Free Software +Foundation. If the Program does not specify a version number of the +GNU Affero General Public License, you may choose any version ever published +by the Free Software Foundation. + + If the Program specifies that a proxy can decide which future +versions of the GNU Affero General Public License can be used, that proxy's +public statement of acceptance of a version permanently authorizes you +to choose that version for the Program. + + Later license versions may give you additional or different +permissions. However, no additional obligations are imposed on any +author or copyright holder as a result of your choosing to follow a +later version. + + 15. Disclaimer of Warranty. + + THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY +APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT +HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY +OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, +THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR +PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM +IS WITH YOU. SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF +ALL NECESSARY SERVICING, REPAIR OR CORRECTION. + + 16. Limitation of Liability. + + IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING +WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS +THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY +GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE +USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF +DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD +PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS), +EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF +SUCH DAMAGES. + + 17. Interpretation of Sections 15 and 16. + + If the disclaimer of warranty and limitation of liability provided +above cannot be given local legal effect according to their terms, +reviewing courts shall apply local law that most closely approximates +an absolute waiver of all civil liability in connection with the +Program, unless a warranty or assumption of liability accompanies a +copy of the Program in return for a fee. + + END OF TERMS AND CONDITIONS + + How to Apply These Terms to Your New Programs + + If you develop a new program, and you want it to be of the greatest +possible use to the public, the best way to achieve this is to make it +free software which everyone can redistribute and change under these terms. + + To do so, attach the following notices to the program. It is safest +to attach them to the start of each source file to most effectively +state the exclusion of warranty; and each file should have at least +the "copyright" line and a pointer to where the full notice is found. + + + Copyright (C) + + This program is free software: you can redistribute it and/or modify + it under the terms of the GNU Affero General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU Affero General Public License for more details. + + You should have received a copy of the GNU Affero General Public License + along with this program. If not, see . + +Also add information on how to contact you by electronic and paper mail. + + If your software can interact with users remotely through a computer +network, you should also make sure that it provides a way for users to +get its source. For example, if your program is a web application, its +interface could display a "Source" link that leads users to an archive +of the code. There are many ways you could offer source, and different +solutions will be better for different programs; see section 13 for the +specific requirements. + + You should also get your employer (if you work as a programmer) or school, +if any, to sign a "copyright disclaimer" for the program, if necessary. +For more information on this, and how to apply and follow the GNU AGPL, see +. diff --git a/Makefile.am b/Makefile.am new file mode 100644 index 0000000..9648f0e --- /dev/null +++ b/Makefile.am @@ -0,0 +1,36 @@ +AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6 + +## FIXME: automake >= 1.13 or autoconf >= 2.70 provide better suited AC_CONFIG_MACRO_DIRS for configure.ac +## remove line below when OE toolchain is updated to version which include those +ACLOCAL_AMFLAGS = -I m4 +AM_CPPFLAGS = \ + $(all_includes) \ + -I$(top_srcdir)/include \ + $(NULL) + +SUBDIRS = \ + include \ + src \ + tests \ + doc \ + contrib \ + $(NULL) + +BUILT_SOURCES = $(top_srcdir)/.version +EXTRA_DIST = \ + .version \ + contrib/osmo-bsc-nat.spec.in \ + debian \ + git-version-gen \ + osmoappdesc.py \ + $(NULL) + +AM_DISTCHECK_CONFIGURE_FLAGS = \ + --with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir) + + at RELMAKE@ + +$(top_srcdir)/.version: + echo $(VERSION) > $@-t && mv $@-t $@ +dist-hook: + echo $(VERSION) > $(distdir)/.tarball-version diff --git a/README.md b/README.md new file mode 100644 index 0000000..8ed9954 --- /dev/null +++ b/README.md @@ -0,0 +1,57 @@ +osmo-bsc-nat +=========================================== + +OsmoBSCNAT masquerades multiple BSCs behind one. It is part of the +[Osmocom](https://osmocom.org/) Open Source Mobile Communications project. + +Homepage +-------- + +The official homepage of the project is +https://osmocom.org/projects/osmo-bscnat/wiki + +GIT Repository +-------------- + +You can clone from the official osmo-bsc-nat.git repository using + + git clone git://git.osmocom.org/osmo-bsc-nat.git + +There is a cgit interface at https://git.osmocom.org/osmo-bsc-nat/ + +Documentation +------------- + +User Manuals and VTY reference manuals are optionally built in PDF form +as part of the build process. + +Pre-rendered PDF version of the current "master" can be found at +[User Manual](https://ftp.osmocom.org/docs/latest/osmobscnat-usermanual.pdf) +as well as the [VTY Reference Manual](https://ftp.osmocom.org/docs/latest/osmobscnat-vty-reference.pdf) + + +Mailing List +------------ + +Discussions related to osmo-bsc-nat are happening on the +openbsc at lists.osmocom.org mailing list, please see +https://lists.osmocom.org/mailman/listinfo/openbsc for subscription +options and the list archive. + +Please observe the +[Osmocom Mailing List Rules](https://osmocom.org/projects/cellular-infrastructure/wiki/Mailing_List_Rules) +when posting. + +Contributing +------------ + +Our coding standards are described at +https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards + +We us a gerrit based patch submission/review process for managing +contributions. Please see +https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for +more details + +The current patch queue for osmo-bsc-nat can be seen at +https://gerrit.osmocom.org/#/q/project:osmo-bsc-nat+status:open diff --git a/configure.ac b/configure.ac new file mode 100644 index 0000000..116c3a2 --- /dev/null +++ b/configure.ac @@ -0,0 +1,227 @@ +dnl Process this file with autoconf to produce a configure script +AC_INIT([osmo-bsc-nat], + m4_esyscmd([./git-version-gen .tarball-version]), + [openbsc at lists.osmocom.org]) + +dnl *This* is the root dir, even if an install-sh exists in ../ or ../../ +AC_CONFIG_AUX_DIR([.]) + +AM_INIT_AUTOMAKE([dist-bzip2]) +AC_CONFIG_TESTDIR(tests) + +CFLAGS="$CFLAGS -std=gnu11" + +dnl kernel style compile messages +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) + +dnl include release helper +RELMAKE='-include osmo-release.mk' +AC_SUBST([RELMAKE]) + +dnl checks for programs +AC_PROG_MAKE_SET +AC_PROG_CC +AC_PROG_INSTALL +LT_INIT + +dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang +AS_CASE(["$LD"],[*clang*], + [AS_CASE(["${host_os}"], + [*linux*],[archive_cmds='$CC -shared $pic_flag $libobjs $deplibs $compiler_flags $wl-soname $wl$soname -o $lib'])]) + +dnl check for pkg-config (explained in detail in libosmocore/configure.ac) +AC_PATH_PROG(PKG_CONFIG_INSTALLED, pkg-config, no) +if test "x$PKG_CONFIG_INSTALLED" = "xno"; then + AC_MSG_WARN([You need to install pkg-config]) +fi +PKG_PROG_PKG_CONFIG([0.20]) + +dnl checks for libraries +AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) +AC_SUBST(LIBRARY_DL) +old_LIBS=$LIBS +AC_SEARCH_LIBS([sctp_recvmsg], [sctp], [ + AC_DEFINE(HAVE_LIBSCTP, 1, [Define 1 to enable SCTP support]) + AC_SUBST(HAVE_LIBSCTP, [1]) + if test -n "$ac_lib"; then + AC_SUBST(LIBSCTP_LIBS, [-l$ac_lib]) + fi + ], [ + AC_MSG_ERROR([sctp_recvmsg not found in searched libs])]) +LIBS=$old_LIBS + +PKG_CHECK_MODULES(LIBASN1C, libasn1c >= 0.9.30) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.6.0) +PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 1.2.0) +PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.1.0) +PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.5.0) + +dnl checks for header files +AC_HEADER_STDC + +dnl Checks for typedefs, structures and compiler characteristics + +AC_ARG_ENABLE(sanitize, + [AS_HELP_STRING( + [--enable-sanitize], + [Compile with address sanitizer enabled], + )], + [sanitize=$enableval], [sanitize="no"]) +if test x"$sanitize" = x"yes" +then + CFLAGS="$CFLAGS -fsanitize=address -fsanitize=undefined" + CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" +fi + +AC_ARG_ENABLE(werror, + [AS_HELP_STRING( + [--enable-werror], + [Turn all compiler warnings into errors, with exceptions: + a) deprecation (allow upstream to mark deprecation without breaking builds); + b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) + ] + )], + [werror=$enableval], [werror="no"]) +if test x"$werror" = x"yes" +then + WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" + WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" + CFLAGS="$CFLAGS $WERROR_FLAGS" + CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" +fi + +# The following test is taken from WebKit's webkit.m4 +saved_CFLAGS="$CFLAGS" +CFLAGS="$CFLAGS -fvisibility=hidden " +AC_MSG_CHECKING([if ${CC} supports -fvisibility=hidden]) +AC_COMPILE_IFELSE([AC_LANG_SOURCE([char foo;])], + [ AC_MSG_RESULT([yes]) + SYMBOL_VISIBILITY="-fvisibility=hidden"], + AC_MSG_RESULT([no])) +CFLAGS="$saved_CFLAGS" +AC_SUBST(SYMBOL_VISIBILITY) + +# Coverage build taken from WebKit's configure.in +AC_MSG_CHECKING([whether to enable code coverage support]) +AC_ARG_ENABLE(coverage, + AC_HELP_STRING([--enable-coverage], + [enable code coverage support [default=no]]), + [],[enable_coverage="no"]) +AC_MSG_RESULT([$enable_coverage]) +if test "$enable_coverage" = "yes"; then + COVERAGE_CFLAGS="-ftest-coverage -fprofile-arcs" + COVERAGE_LDFLAGS="-ftest-coverage -fprofile-arcs" + AC_SUBST([COVERAGE_CFLAGS]) + AC_SUBST([COVERAGE_LDFLAGS]) +fi + +AC_ARG_ENABLE(profile, + [AS_HELP_STRING([--enable-profile], [Compile with profiling support enabled], )], + [profile=$enableval], [profile="no"]) +if test x"$profile" = x"yes" +then + CFLAGS="$CFLAGS -pg" + CPPFLAGS="$CPPFLAGS -pg" +fi + +AC_ARG_ENABLE([external_tests], + AC_HELP_STRING([--enable-external-tests], + [Include the VTY/CTRL tests in make check [default=no]]), + [enable_ext_tests="$enableval"],[enable_ext_tests="no"]) +if test "x$enable_ext_tests" = "xyes" ; then + AC_CHECK_PROG(PYTHON3_AVAIL,python3,yes) + if test "x$PYTHON3_AVAIL" != "xyes" ; then + AC_MSG_ERROR([Please install python3 to run the VTY/CTRL tests.]) + fi + AC_CHECK_PROG(OSMOTESTEXT_CHECK,osmotestvty.py,yes) + if test "x$OSMOTESTEXT_CHECK" != "xyes" ; then + AC_MSG_ERROR([Please install git://osmocom.org/python/osmo-python-tests to run the VTY/CTRL tests.]) + fi +fi +AC_MSG_CHECKING([whether to enable VTY/CTRL tests]) +AC_MSG_RESULT([$enable_ext_tests]) +AM_CONDITIONAL(ENABLE_EXT_TESTS, test "x$enable_ext_tests" = "xyes") + +# Generate manuals +AC_ARG_ENABLE(manuals, + [AS_HELP_STRING( + [--enable-manuals], + [Generate manual PDFs [default=no]], + )], + [osmo_ac_build_manuals=$enableval], [osmo_ac_build_manuals="no"]) +AM_CONDITIONAL([BUILD_MANUALS], [test x"$osmo_ac_build_manuals" = x"yes"]) +AC_ARG_VAR(OSMO_GSM_MANUALS_DIR, [path to common osmo-gsm-manuals files, overriding pkg-config and "../osmo-gsm-manuals" + fallback]) +if test x"$osmo_ac_build_manuals" = x"yes" +then + # Find OSMO_GSM_MANUALS_DIR (env, pkg-conf, fallback) + if test -n "$OSMO_GSM_MANUALS_DIR"; then + echo "checking for OSMO_GSM_MANUALS_DIR... $OSMO_GSM_MANUALS_DIR (from env)" + else + OSMO_GSM_MANUALS_DIR="$($PKG_CONFIG osmo-gsm-manuals --variable=osmogsmmanualsdir 2>/dev/null)" + if test -n "$OSMO_GSM_MANUALS_DIR"; then + echo "checking for OSMO_GSM_MANUALS_DIR... $OSMO_GSM_MANUALS_DIR (from pkg-conf)" + else + OSMO_GSM_MANUALS_DIR="../osmo-gsm-manuals" + echo "checking for OSMO_GSM_MANUALS_DIR... $OSMO_GSM_MANUALS_DIR (fallback)" + fi + fi + if ! test -d "$OSMO_GSM_MANUALS_DIR"; then + AC_MSG_ERROR("OSMO_GSM_MANUALS_DIR does not exist! Install osmo-gsm-manuals or set OSMO_GSM_MANUALS_DIR.") + fi + + # Find and run check-depends + CHECK_DEPENDS="$OSMO_GSM_MANUALS_DIR/check-depends.sh" + if ! test -x "$CHECK_DEPENDS"; then + CHECK_DEPENDS="osmo-gsm-manuals-check-depends" + fi + if ! $CHECK_DEPENDS; then + AC_MSG_ERROR("missing dependencies for --enable-manuals") + fi + + # Put in Makefile with absolute path + OSMO_GSM_MANUALS_DIR="$(realpath "$OSMO_GSM_MANUALS_DIR")" + AC_SUBST([OSMO_GSM_MANUALS_DIR]) +fi + +# https://www.freedesktop.org/software/systemd/man/daemon.html +AC_ARG_WITH([systemdsystemunitdir], + [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd service files])],, + [with_systemdsystemunitdir=auto]) +AS_IF([test "x$with_systemdsystemunitdir" = "xyes" -o "x$with_systemdsystemunitdir" = "xauto"], [ + def_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir systemd) + + AS_IF([test "x$def_systemdsystemunitdir" = "x"], + [AS_IF([test "x$with_systemdsystemunitdir" = "xyes"], + [AC_MSG_ERROR([systemd support requested but pkg-config unable to query systemd package])]) + with_systemdsystemunitdir=no], + [with_systemdsystemunitdir="$def_systemdsystemunitdir"])]) +AS_IF([test "x$with_systemdsystemunitdir" != "xno"], + [AC_SUBST([systemdsystemunitdir], [$with_systemdsystemunitdir])]) +AM_CONDITIONAL([HAVE_SYSTEMD], [test "x$with_systemdsystemunitdir" != "xno"]) + +AC_MSG_RESULT([CFLAGS="$CFLAGS"]) +AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"]) + +dnl Generate the output +AM_CONFIG_HEADER(config.h) + +AC_OUTPUT( + include/Makefile + include/osmocom/Makefile + include/osmocom/bsc_nat/Makefile + src/Makefile + src/osmo-bsc-nat/Makefile + tests/Makefile + tests/atlocal + doc/Makefile + doc/examples/Makefile + doc/manuals/Makefile + contrib/Makefile + contrib/systemd/Makefile + contrib/osmo-bsc-nat.spec + Makefile) diff --git a/contrib/Makefile.am b/contrib/Makefile.am new file mode 100644 index 0000000..3439c97 --- /dev/null +++ b/contrib/Makefile.am @@ -0,0 +1 @@ +SUBDIRS = systemd diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..8441344 --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,67 @@ +#!/usr/bin/env bash +# jenkins build helper script for osmo-bsc-nat. This is how we build on jenkins.osmocom.org +# +# environment variables: +# * WITH_MANUALS: build manual PDFs if set to "1" +# * PUBLISH: upload manuals after building if set to "1" (ignored without WITH_MANUALS = "1") +# + +if ! [ -x "$(command -v osmo-build-dep.sh)" ]; then + echo "Error: We need to have scripts/osmo-deps.sh from http://git.osmocom.org/osmo-ci/ in PATH !" + exit 2 +fi + + +set -ex + +base="$PWD" +deps="$base/deps" +inst="$deps/install" +export deps inst + +osmo-clean-workspace.sh + +mkdir "$deps" || true + +verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]") + +export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" +export LD_LIBRARY_PATH="$inst/lib" +export PATH="$inst/bin:$PATH" + +osmo-build-dep.sh libosmocore "" --disable-doxygen +osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-netif +osmo-build-dep.sh libosmo-sccp + +# Additional configure options and depends +CONFIG="" +if [ "$WITH_MANUALS" = "1" ]; then + CONFIG="--enable-manuals" +fi + +set +x +echo +echo +echo +echo " =============================== osmo-bsc-nat ===============================" +echo +set -x + +cd "$base" +autoreconf --install --force +./configure --enable-sanitize --enable-external-tests $CONFIG +$MAKE $PARALLEL_MAKE +LD_LIBRARY_PATH="$inst/lib" $MAKE check \ + || cat-testlogs.sh +LD_LIBRARY_PATH="$inst/lib" \ + DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests $CONFIG" \ + $MAKE $PARALLEL_MAKE distcheck \ + || cat-testlogs.sh + +if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then + make -C "$base/doc/manuals" publish +fi + +$MAKE $PARALLEL_MAKE maintainer-clean +osmo-clean-workspace.sh diff --git a/contrib/osmo-bsc-nat.spec.in b/contrib/osmo-bsc-nat.spec.in new file mode 100644 index 0000000..ae41bdc --- /dev/null +++ b/contrib/osmo-bsc-nat.spec.in @@ -0,0 +1,92 @@ +# +# spec file for package osmo-bsc-nat +# +# Copyright (c) 2017, Martin Hauke +# Copyright (c) 2021, sysmocom - s.f.m.c. GmbH +# Author: Oliver Smith +# +# All modifications and additions to the file contributed by third parties +# remain the property of their copyright owners, unless otherwise agreed +# upon. The license for this file, and modifications and additions to the +# file, is the same license as for the pristine package itself (unless the +# license for the pristine package is not an Open Source License, in which +# case the license is the MIT License). An "Open Source License" is a +# license that conforms to the Open Source Definition (Version 1.9) +# published by the Open Source Initiative. + +## Disable LTO for now since it breaks compilation of the tests +## https://osmocom.org/issues/4113 +%define _lto_cflags %{nil} + +Name: osmo-bsc-nat +Version: @VERSION@ +Release: 0 +Summary: OsmoBSCNAT masquerades multiple BSCs behind one +License: AGPL-3.0-or-later AND GPL-2.0-or-later +Group: Hardware/Mobile +URL: https://osmocom.org/projects/osmo-bscnat +Source: %{name}-%{version}.tar.xz +BuildRequires: automake >= 1.9 +BuildRequires: libtool >= 2 +BuildRequires: pkgconfig >= 0.20 +%if 0%{?suse_version} +BuildRequires: systemd-rpm-macros +%endif +BuildRequires: pkgconfig(libcrypto) >= 0.9.5 +BuildRequires: pkgconfig(libosmo-netif) >= 1.1.0 +BuildRequires: pkgconfig(libosmo-sigtran) >= 1.5.0 +BuildRequires: pkgconfig(libosmoabis) >= 1.2.0 +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmogb) >= 1.6.0 +BuildRequires: pkgconfig(libosmogsm) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 +BuildRequires: pkgconfig(talloc) +%{?systemd_requires} + +%description +OsmoBSCNAT masquerades multiple BSCs behind one. + +%prep +%setup -q + +%build +echo "%{version}" >.tarball-version +autoreconf -fi +%configure \ + --docdir=%{_docdir}/%{name} \ + --with-systemdsystemunitdir=%{_unitdir} +make %{?_smp_mflags} + +%install +%make_install + +%if 0%{?suse_version} +%preun +%service_del_preun %{name}.service + +%postun +%service_del_postun %{name}.service + +%pre +%service_add_pre %{name}.service + +%post +%service_add_post %{name}.service +%endif + +%check +make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) + +%files +%license COPYING +%doc AUTHORS README.md +%{_bindir}/osmo-bsc-nat +%dir %{_docdir}/%{name}/examples +%dir %{_docdir}/%{name}/examples/osmo-bsc-nat +%{_docdir}/%{name}/examples/osmo-bsc-nat/osmo-bsc-nat.cfg +%dir %{_sysconfdir}/osmocom +%config(noreplace) %{_sysconfdir}/osmocom/osmo-bsc-nat.cfg +%{_unitdir}/%{name}.service + +%changelog diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am new file mode 100644 index 0000000..bcaaa40 --- /dev/null +++ b/contrib/systemd/Makefile.am @@ -0,0 +1,6 @@ +EXTRA_DIST = osmo-bsc-nat.service + +if HAVE_SYSTEMD +systemdsystemunit_DATA = \ + osmo-bsc-nat.service +endif diff --git a/contrib/systemd/osmo-bsc-nat.service b/contrib/systemd/osmo-bsc-nat.service new file mode 100644 index 0000000..366ae46 --- /dev/null +++ b/contrib/systemd/osmo-bsc-nat.service @@ -0,0 +1,11 @@ +[Unit] +Description=Osmocom BSC NAT + +[Service] +Type=simple +Restart=always +ExecStart=/usr/bin/osmo-bsc-nat -c /etc/osmocom/osmo-bsc-nat.cfg +RestartSec=2 + +[Install] +WantedBy=multi-user.target diff --git a/debian/changelog b/debian/changelog new file mode 100644 index 0000000..3e0cef0 --- /dev/null +++ b/debian/changelog @@ -0,0 +1,8 @@ +osmo-bsc-nat (0.1.0) unstable; urgency=medium + + [ Oliver Smith ] + * Add project skeleton + * Initial empty repository + + -- Oliver Smith Wed, 01 Dec 2021 10:48:03 +0100 + diff --git a/debian/compat b/debian/compat new file mode 100644 index 0000000..ec63514 --- /dev/null +++ b/debian/compat @@ -0,0 +1 @@ +9 diff --git a/debian/control b/debian/control new file mode 100644 index 0000000..c542881 --- /dev/null +++ b/debian/control @@ -0,0 +1,44 @@ +Source: osmo-bsc-nat +Section: net +Priority: extra +Maintainer: Osmocom team +Build-Depends: debhelper (>=9), + dh-autoreconf, + autotools-dev, + autoconf, + automake, + libtool, + pkg-config, + python3-minimal, + libtalloc-dev, + libosmocore-dev (>= 1.6.0), + libosmo-sigtran-dev (>= 1.5.0), + libosmo-abis-dev (>= 1.2.0), + libosmo-netif-dev (>= 1.1.0), + osmo-gsm-manuals-dev (>= 1.2.0) +Standards-Version: 3.9.8 +Vcs-Git: git://git.osmocom.org/osmo-bsc-nat.git +Vcs-Browser: https://git.osmocom.org/osmo-bsc-nat/ +Homepage: https://projects.osmocom.org/projects/osmo-bsc-nat + +Package: osmo-bsc-nat +Architecture: any +Multi-Arch: foreign +Depends: ${misc:Depends}, ${shlibs:Depends} +Description: OsmoBSCNAT masquerades multiple BSCs behind one + +Package: osmo-bsc-nat-dbg +Section: debug +Architecture: any +Multi-Arch: same +Depends: osmo-bsc-nat (= ${binary:Version}), ${misc:Depends} +Description: OsmoBSCNAT masquerades multiple BSCs behind one + +Package: osmo-bsc-nat-doc +Architecture: all +Section: doc +Priority: optional +Depends: ${misc:Depends} +Description: ${misc:Package} PDF documentation + Various manuals: user manual, VTY reference manual and/or + protocol/interface manuals. diff --git a/debian/copyright b/debian/copyright new file mode 100644 index 0000000..c8d37a5 --- /dev/null +++ b/debian/copyright @@ -0,0 +1,19 @@ +Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ +Upstream-Name: osmo-bsc-nat +Source: git://git.osmocom.org/osmo-bsc-nat + +Files: * +Copyright: 2021 sysmocom - s.f.m.c. GmbH +License: AGPL-3.0+ + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU Affero General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + . + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU Affero General Public License for more details. + . + You should have received a copy of the GNU Affero General Public License + along with this program. If not, see . diff --git a/debian/osmo-bsc-nat.install b/debian/osmo-bsc-nat.install new file mode 100644 index 0000000..f64bd38 --- /dev/null +++ b/debian/osmo-bsc-nat.install @@ -0,0 +1,4 @@ +etc/osmocom/osmo-bsc-nat.cfg +lib/systemd/system/osmo-bsc-nat.service +usr/bin/osmo-bsc-nat +usr/share/doc/osmo-bsc-nat/examples/osmo-bsc-nat/osmo-bsc-nat.cfg usr/share/doc/osmo-bsc-nat/examples diff --git a/debian/rules b/debian/rules new file mode 100755 index 0000000..aa780e0 --- /dev/null +++ b/debian/rules @@ -0,0 +1,66 @@ +#!/usr/bin/make -f +# You must remove unused comment lines for the released package. +# See debhelper(7) (uncomment to enable) +# This is an autogenerated template for debian/rules. +# +# Output every command that modifies files on the build system. +#export DH_VERBOSE = 1 +# +# Copy some variable definitions from pkg-info.mk and vendor.mk +# under /usr/share/dpkg/ to here if they are useful. +# +# See FEATURE AREAS/ENVIRONMENT in dpkg-buildflags(1) +# Apply all hardening options +#export DEB_BUILD_MAINT_OPTIONS = hardening=+all +# Package maintainers to append CFLAGS +#export DEB_CFLAGS_MAINT_APPEND = -Wall -pedantic +# Package maintainers to append LDFLAGS +#export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed +# +# With debhelper version 9 or newer, the dh command exports +# all buildflags. So there is no need to include the +# /usr/share/dpkg/buildflags.mk file here if compat is 9 or newer. +# +# These are rarely used code. (START) +# +# The following include for *.mk magically sets miscellaneous +# variables while honoring existing values of pertinent +# environment variables: +# +# Architecture-related variables such as DEB_TARGET_MULTIARCH: +#include /usr/share/dpkg/architecture.mk +# Vendor-related variables such as DEB_VENDOR: +#include /usr/share/dpkg/vendor.mk +# Package-related variables such as DEB_DISTRIBUTION +#include /usr/share/dpkg/pkg-info.mk +# +# You may alternatively set them susing a simple script such as: +# DEB_VENDOR ?= $(shell dpkg-vendor --query Vendor) +# +# These are rarely used code. (END) +# + +# main packaging script based on dh7 syntax +%: + dh $@ --with autoreconf + +# debmake generated override targets +CONFIGURE_FLAGS += --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals +override_dh_auto_configure: + dh_auto_configure -- $(CONFIGURE_FLAGS) +# +# Do not install libtool archive, python .pyc .pyo +#override_dh_install: +# dh_install --list-missing -X.la -X.pyc -X.pyo + +# See https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-dbg +override_dh_strip: + dh_strip -posmo-bsc-nat --dbg-package=osmo-bsc-nat-dbg + +# Print test results in case of a failure +override_dh_auto_test: + dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false) + +# Don't create .pdf.gz files (barely saves space and they can't be opened directly by most pdf readers) +override_dh_compress: + dh_compress -X.pdf diff --git a/debian/source/format b/debian/source/format new file mode 100644 index 0000000..89ae9db --- /dev/null +++ b/debian/source/format @@ -0,0 +1 @@ +3.0 (native) diff --git a/doc/Makefile.am b/doc/Makefile.am new file mode 100644 index 0000000..15f36b7 --- /dev/null +++ b/doc/Makefile.am @@ -0,0 +1,4 @@ +SUBDIRS = \ + examples \ + manuals \ + $(NULL) diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am new file mode 100644 index 0000000..1849b98 --- /dev/null +++ b/doc/examples/Makefile.am @@ -0,0 +1,30 @@ +OSMOCONF_FILES = \ + osmo-bsc-nat/osmo-bsc-nat.cfg + +osmoconfdir = $(sysconfdir)/osmocom +osmoconf_DATA = $(OSMOCONF_FILES) + +EXTRA_DIST = $(OSMOCONF_FILES) + +CFG_FILES = find $(srcdir) -name '*.cfg*' | sed -e 's,^$(srcdir),,' + +dist-hook: + for f in $$($(CFG_FILES)); do \ + j="$(distdir)/$$f" && \ + mkdir -p "$$(dirname $$j)" && \ + $(INSTALL_DATA) $(srcdir)/$$f $$j; \ + done + +install-data-hook: + for f in $$($(CFG_FILES)); do \ + j="$(DESTDIR)$(docdir)/examples/$$f" && \ + mkdir -p "$$(dirname $$j)" && \ + $(INSTALL_DATA) $(srcdir)/$$f $$j; \ + done + +uninstall-hook: + @$(PRE_UNINSTALL) + for f in $$($(CFG_FILES)); do \ + j="$(DESTDIR)$(docdir)/examples/$$f" && \ + $(RM) $$j; \ + done diff --git a/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg b/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg diff --git a/doc/manuals/Makefile.am b/doc/manuals/Makefile.am new file mode 100644 index 0000000..f29abe7 --- /dev/null +++ b/doc/manuals/Makefile.am @@ -0,0 +1,26 @@ +EXTRA_DIST = \ + osmobscnat-usermanual.adoc \ + osmobscnat-usermanual-docinfo.xml \ + osmobscnat-vty-reference.xml \ + chapters \ + regen_doc.sh \ + vty + +if BUILD_MANUALS + ASCIIDOC = osmobscnat-usermanual.adoc + include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.asciidoc.inc + osmobscnat-usermanual.pdf: $(srcdir)/chapters/*.adoc + +# TODO: enable once we have VTY available in osmo-bsc-nat +# VTY_REFERENCE = osmobscnat-vty-reference.xml + +# BUILT_REFERENCE_XML = $(builddir)/vty/bsc_nat_vty_reference.xml +# $(builddir)/vty/bsc_nat_vty_reference.xml: $(top_builddir)/src/osmo-bsc-nat/osmo-bsc-nat +# mkdir -p $(builddir)/vty +# $(top_builddir)/src/osmo-bsc-nat/osmo-bsc-nat --vty-ref-xml > $@ + +# include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.vty-reference.inc + + OSMO_REPOSITORY = osmo-bsc-nat + include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.common.inc +endif diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc new file mode 100644 index 0000000..88171c7 --- /dev/null +++ b/doc/manuals/chapters/overview.adoc @@ -0,0 +1,10 @@ +OsmoBSCNAT[[overview]] +== Overview + +This manual should help you getting started with OsmoBSCNAT. It will cover +aspects of configuring and running the OsmoBSCNAT. + +[[intro_overview]] +=== About OsmoBSCNAT + +OsmoBSCNAT masquerades multiple BSCs behind one. diff --git a/doc/manuals/osmobscnat-usermanual-docinfo.xml b/doc/manuals/osmobscnat-usermanual-docinfo.xml new file mode 100644 index 0000000..a88cac6 --- /dev/null +++ b/doc/manuals/osmobscnat-usermanual-docinfo.xml @@ -0,0 +1,47 @@ + + + 1 + December 2021 + OS + + Initial OsmoBSCNAT manual + + + + + + + Oliver + Smith + osmith at sysmocom.de + OS + + sysmocom + sysmocom - s.f.m.c. GmbH + Software Developer + + + + + + 2021 + sysmocom - s.f.m.c. GmbH + + + + + Permission is granted to copy, distribute and/or modify this + document under the terms of the GNU Free Documentation License, + Version 1.3 or any later version published by the Free Software + Foundation; with the Invariant Sections being just 'Foreword', + 'Acknowledgements' and 'Preface', with no Front-Cover Texts, + and no Back-Cover Texts. A copy of the license is included in + the section entitled "GNU Free Documentation License". + + + The Asciidoc source code of this manual can be found at + + http://git.osmocom.org/osmo-gsm-manuals/ + + + diff --git a/doc/manuals/osmobscnat-usermanual.adoc b/doc/manuals/osmobscnat-usermanual.adoc new file mode 100644 index 0000000..86dc31d --- /dev/null +++ b/doc/manuals/osmobscnat-usermanual.adoc @@ -0,0 +1,31 @@ +:gfdl-enabled: +:program-name: OsmoBSCNAT + +OsmoBSCNAT User Manual +====================== +Oliver Smith + + +include::./common/chapters/preface.adoc[] + +include::{srcdir}/chapters/overview.adoc[] + +include::./common/chapters/vty.adoc[] + +include::./common/chapters/logging.adoc[] + +include::./common/chapters/cs7-config.adoc[] + +include::./common/chapters/counters-overview.adoc[] + +include::./common/chapters/control_if.adoc[] + +include::./common/chapters/vty_cpu_sched.adoc[] + +include::./common/chapters/port_numbers.adoc[] + +include::./common/chapters/bibliography.adoc[] + +include::./common/chapters/glossary.adoc[] + +include::./common/chapters/gfdl.adoc[] diff --git a/doc/manuals/osmobscnat-vty-reference.xml b/doc/manuals/osmobscnat-vty-reference.xml new file mode 100644 index 0000000..6b3ea5d --- /dev/null +++ b/doc/manuals/osmobscnat-vty-reference.xml @@ -0,0 +1,33 @@ + + + +]> + + + + + + v1 + 1st December 2021 + OS + Initial + + + + OsmoBSCNAT VTY Reference + + + 2021 + + + + This work is copyright by sysmocom - s.f.m.c. GmbH. All rights reserved. + + + + + + &chapter-vty; + diff --git a/doc/manuals/regen_doc.sh b/doc/manuals/regen_doc.sh new file mode 100755 index 0000000..1a849fe --- /dev/null +++ b/doc/manuals/regen_doc.sh @@ -0,0 +1,17 @@ +#!/bin/sh -x + +if [ -z "$DOCKER_PLAYGROUND" ]; then + echo "You need to set DOCKER_PLAYGROUND" + exit 1 +fi + +SCRIPT=$(realpath "$0") +MANUAL_DIR=$(dirname "$SCRIPT") + +COMMIT=${COMMIT:-$(git log -1 --format=format:%H)} + +cd "$DOCKER_PLAYGROUND/scripts" || exit 1 + +OSMO_BSC_NAT_BRANCH=$COMMIT ./regen_doc.sh osmo-bsc-nat 4273 \ + "$MANUAL_DIR/chapters/counters_generated.adoc" \ + "$MANUAL_DIR/vty/bsc_nat_vty_reference.xml" diff --git a/doc/manuals/vty/bsc_nat_vty_additions.xml b/doc/manuals/vty/bsc_nat_vty_additions.xml new file mode 100644 index 0000000..a4c675e --- /dev/null +++ b/doc/manuals/vty/bsc_nat_vty_additions.xml @@ -0,0 +1,2 @@ + + diff --git a/git-version-gen b/git-version-gen new file mode 100755 index 0000000..42cf3d2 --- /dev/null +++ b/git-version-gen @@ -0,0 +1,151 @@ +#!/bin/sh +# Print a version string. +scriptversion=2010-01-28.01 + +# Copyright (C) 2007-2010 Free Software Foundation, Inc. +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# This script is derived from GIT-VERSION-GEN from GIT: http://git.or.cz/. +# It may be run two ways: +# - from a git repository in which the "git describe" command below +# produces useful output (thus requiring at least one signed tag) +# - from a non-git-repo directory containing a .tarball-version file, which +# presumes this script is invoked like "./git-version-gen .tarball-version". + +# In order to use intra-version strings in your project, you will need two +# separate generated version string files: +# +# .tarball-version - present only in a distribution tarball, and not in +# a checked-out repository. Created with contents that were learned at +# the last time autoconf was run, and used by git-version-gen. Must not +# be present in either $(srcdir) or $(builddir) for git-version-gen to +# give accurate answers during normal development with a checked out tree, +# but must be present in a tarball when there is no version control system. +# Therefore, it cannot be used in any dependencies. GNUmakefile has +# hooks to force a reconfigure at distribution time to get the value +# correct, without penalizing normal development with extra reconfigures. +# +# .version - present in a checked-out repository and in a distribution +# tarball. Usable in dependencies, particularly for files that don't +# want to depend on config.h but do want to track version changes. +# Delete this file prior to any autoconf run where you want to rebuild +# files to pick up a version string change; and leave it stale to +# minimize rebuild time after unrelated changes to configure sources. +# +# It is probably wise to add these two files to .gitignore, so that you +# don't accidentally commit either generated file. +# +# Use the following line in your configure.ac, so that $(VERSION) will +# automatically be up-to-date each time configure is run (and note that +# since configure.ac no longer includes a version string, Makefile rules +# should not depend on configure.ac for version updates). +# +# AC_INIT([GNU project], +# m4_esyscmd([build-aux/git-version-gen .tarball-version]), +# [bug-project at example]) +# +# Then use the following lines in your Makefile.am, so that .version +# will be present for dependencies, and so that .tarball-version will +# exist in distribution tarballs. +# +# BUILT_SOURCES = $(top_srcdir)/.version +# $(top_srcdir)/.version: +# echo $(VERSION) > $@-t && mv $@-t $@ +# dist-hook: +# echo $(VERSION) > $(distdir)/.tarball-version + +case $# in + 1) ;; + *) echo 1>&2 "Usage: $0 \$srcdir/.tarball-version"; exit 1;; +esac + +tarball_version_file=$1 +nl=' +' + +# First see if there is a tarball-only version file. +# then try "git describe", then default. +if test -f $tarball_version_file +then + v=`cat $tarball_version_file` || exit 1 + case $v in + *$nl*) v= ;; # reject multi-line output + [0-9]*) ;; + *) v= ;; + esac + test -z "$v" \ + && echo "$0: WARNING: $tarball_version_file seems to be damaged" 1>&2 +fi + +if test -n "$v" +then + : # use $v +elif + v=`git describe --abbrev=4 --match='v*' HEAD 2>/dev/null \ + || git describe --abbrev=4 HEAD 2>/dev/null` \ + && case $v in + [0-9]*) ;; + v[0-9]*) ;; + *) (exit 1) ;; + esac +then + # Is this a new git that lists number of commits since the last + # tag or the previous older version that did not? + # Newer: v6.10-77-g0f8faeb + # Older: v6.10-g0f8faeb + case $v in + *-*-*) : git describe is okay three part flavor ;; + *-*) + : git describe is older two part flavor + # Recreate the number of commits and rewrite such that the + # result is the same as if we were using the newer version + # of git describe. + vtag=`echo "$v" | sed 's/-.*//'` + numcommits=`git rev-list "$vtag"..HEAD | wc -l` + v=`echo "$v" | sed "s/\(.*\)-\(.*\)/\1-$numcommits-\2/"`; + ;; + esac + + # Change the first '-' to a '.', so version-comparing tools work properly. + # Remove the "g" in git describe's output string, to save a byte. + v=`echo "$v" | sed 's/-/./;s/\(.*\)-g/\1-/'`; +else + v=UNKNOWN +fi + +v=`echo "$v" |sed 's/^v//'` + +# Don't declare a version "dirty" merely because a time stamp has changed. +git status > /dev/null 2>&1 + +dirty=`sh -c 'git diff-index --name-only HEAD' 2>/dev/null` || dirty= +case "$dirty" in + '') ;; + *) # Append the suffix only if there isn't one already. + case $v in + *-dirty) ;; + *) v="$v-dirty" ;; + esac ;; +esac + +# Omit the trailing newline, so that m4_esyscmd can use the result directly. +echo "$v" | tr -d '\012' + +# Local variables: +# eval: (add-hook 'write-file-hooks 'time-stamp) +# time-stamp-start: "scriptversion=" +# time-stamp-format: "%:y-%02m-%02d.%02H" +# time-stamp-end: "$" +# End: diff --git a/include/Makefile.am b/include/Makefile.am new file mode 100644 index 0000000..9d963a0 --- /dev/null +++ b/include/Makefile.am @@ -0,0 +1,3 @@ +SUBDIRS = \ + osmocom \ + $(NULL) diff --git a/include/osmocom/Makefile.am b/include/osmocom/Makefile.am new file mode 100644 index 0000000..7c36c11 --- /dev/null +++ b/include/osmocom/Makefile.am @@ -0,0 +1,3 @@ +SUBDIRS = \ + bsc_nat \ + $(NULL) diff --git a/include/osmocom/bsc_nat/Makefile.am b/include/osmocom/bsc_nat/Makefile.am new file mode 100644 index 0000000..158ca4b --- /dev/null +++ b/include/osmocom/bsc_nat/Makefile.am @@ -0,0 +1,3 @@ +noinst_HEADERS = \ + bsc_nat.h \ + $(NULL) diff --git a/include/osmocom/bsc_nat/bsc_nat.h b/include/osmocom/bsc_nat/bsc_nat.h new file mode 100644 index 0000000..bbdf826 --- /dev/null +++ b/include/osmocom/bsc_nat/bsc_nat.h @@ -0,0 +1,19 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Oliver Smith + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once diff --git a/osmoappdesc.py b/osmoappdesc.py new file mode 100644 index 0000000..8b6231f --- /dev/null +++ b/osmoappdesc.py @@ -0,0 +1,27 @@ +#!/usr/bin/env python3 + +# (C) 2021 by sysmocom - s.m.f.c. GmbH +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see + +app_configs = { + "osmo-bsc-nat": ["doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg"] +} + +apps = [(4244, "src/osmo-bsc-nat/osmo-bsc-nat", "OsmoBSCNAT", "osmo-bsc-nat") + ] + +vty_command = ["./src/osmo-bsc-nat/osmo-bsc-nat", "-c", + "doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg"] + +vty_app = apps[0] diff --git a/src/Makefile.am b/src/Makefile.am new file mode 100644 index 0000000..4cfcfa4 --- /dev/null +++ b/src/Makefile.am @@ -0,0 +1,3 @@ +SUBDIRS = \ + osmo-bsc-nat \ + $(NULL) diff --git a/src/osmo-bsc-nat/Makefile.am b/src/osmo-bsc-nat/Makefile.am new file mode 100644 index 0000000..9d0bf3e --- /dev/null +++ b/src/osmo-bsc-nat/Makefile.am @@ -0,0 +1,40 @@ +AM_CPPFLAGS = \ + $(all_includes) \ + -I$(top_srcdir)/include \ + -I$(top_builddir) \ + $(NULL) + +AM_CFLAGS = \ + -Wall \ + $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOGSM_CFLAGS) \ + $(LIBOSMOVTY_CFLAGS) \ + $(LIBOSMOCTRL_CFLAGS) \ + $(LIBOSMONETIF_CFLAGS) \ + $(COVERAGE_CFLAGS) \ + $(LIBOSMOABIS_CFLAGS) \ + $(LIBOSMOSIGTRAN_CFLAGS) \ + $(NULL) + +AM_LDFLAGS = \ + $(COVERAGE_LDFLAGS) \ + $(NULL) + +bin_PROGRAMS = \ + osmo-bsc-nat \ + $(NULL) + +osmo_bsc_nat_SOURCES = \ + main.c \ + $(NULL) + +osmo_bsc_nat_LDADD = \ + $(LIBOSMOCORE_LIBS) \ + $(LIBOSMOGSM_LIBS) \ + $(LIBOSMOVTY_LIBS) \ + $(LIBOSMOCTRL_LIBS) \ + $(LIBOSMONETIF_LIBS) \ + $(COVERAGE_LDFLAGS) \ + $(LIBOSMOABIS_LIBS) \ + $(LIBOSMOSIGTRAN_LIBS) \ + $(NULL) diff --git a/src/osmo-bsc-nat/main.c b/src/osmo-bsc-nat/main.c new file mode 100644 index 0000000..8775af1 --- /dev/null +++ b/src/osmo-bsc-nat/main.c @@ -0,0 +1,25 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Oliver Smith + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include "config.h" + +int main(int argc, char **argv) +{ + return 0; +} diff --git a/tests/Makefile.am b/tests/Makefile.am new file mode 100644 index 0000000..5784e5d --- /dev/null +++ b/tests/Makefile.am @@ -0,0 +1,77 @@ +SUBDIRS = \ + $(NULL) + +# The `:;' works around a Bash 3.2 bug when the output is not writeable. +$(srcdir)/package.m4: $(top_srcdir)/configure.ac + :;{ \ + echo '# Signature of the current package.' && \ + echo 'm4_define([AT_PACKAGE_NAME],' && \ + echo ' [$(PACKAGE_NAME)])' && \ + echo 'm4_define([AT_PACKAGE_TARNAME],' && \ + echo ' [$(PACKAGE_TARNAME)])' && \ + echo 'm4_define([AT_PACKAGE_VERSION],' && \ + echo ' [$(PACKAGE_VERSION)])' && \ + echo 'm4_define([AT_PACKAGE_STRING],' && \ + echo ' [$(PACKAGE_STRING)])' && \ + echo 'm4_define([AT_PACKAGE_BUGREPORT],' && \ + echo ' [$(PACKAGE_BUGREPORT)])'; \ + echo 'm4_define([AT_PACKAGE_URL],' && \ + echo ' [$(PACKAGE_URL)])'; \ + } >'$(srcdir)/package.m4' + +EXTRA_DIST = \ + testsuite.at \ + $(srcdir)/package.m4 \ + $(TESTSUITE) \ + ctrl_test_runner.py \ + osmo-bsc-nat.vty \ + $(NULL) + +TESTSUITE = $(srcdir)/testsuite + +DISTCLEANFILES = \ + atconfig \ + $(NULL) + +if ENABLE_EXT_TESTS +python-tests: $(BUILT_SOURCES) + echo "" +# TODO: Enable once we have a VTY/CTRL interface: +# $(MAKE) vty-test +# osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v +# osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v +# $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v +else +python-tests: $(BUILT_SOURCES) + echo "Not running python-based tests (determined at configure-time)" +endif + +# Run a specific test with: 'make vty-test VTY_TEST=osmo-bsc-nat.vty' +VTY_TEST ?= *.vty + +# To update the VTY script from current application behavior, +# pass -u to vty_script_runner.py by doing: +# make vty-test U=-u +vty-test: + osmo_verify_transcript_vty.py -v \ + -n OsmoBSCNAT -p 4244 \ + -r "$(top_builddir)/src/osmo-bsc-nat/osmo-bsc-nat -c $(top_srcdir)/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg" \ + $(U) $(srcdir)/$(VTY_TEST) + +check-local: atconfig $(TESTSUITE) + $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) + $(MAKE) $(AM_MAKEFLAGS) python-tests + +installcheck-local: atconfig $(TESTSUITE) + $(SHELL) '$(TESTSUITE)' AUTOTEST_PATH='$(bindir)' \ + $(TESTSUITEFLAGS) + +clean-local: + test ! -f '$(TESTSUITE)' || \ + $(SHELL) '$(TESTSUITE)' --clean + +AUTOM4TE = $(SHELL) $(top_srcdir)/missing --run autom4te +AUTOTEST = $(AUTOM4TE) --language=autotest +$(TESTSUITE): $(srcdir)/testsuite.at $(srcdir)/package.m4 + $(AUTOTEST) -I '$(srcdir)' -o $@.tmp $@.at + mv $@.tmp $@ diff --git a/tests/atlocal.in b/tests/atlocal.in new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/tests/atlocal.in diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py new file mode 100755 index 0000000..819c516 --- /dev/null +++ b/tests/ctrl_test_runner.py @@ -0,0 +1,207 @@ +#!/usr/bin/env python3 + +# (C) 2013 by Jacob Erlbeck +# (C) 2014 by Holger Hans Peter Freyther +# based on vty_test_runner.py: +# (C) 2013 by Katerina Barone-Adesi +# (C) 2013 by Holger Hans Peter Freyther +# based on bsc_control.py. + +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +import os +import time +import unittest +import socket +import sys +import struct + +import osmopy.obscvty as obscvty +import osmopy.osmoutil as osmoutil +from osmopy.osmo_ipa import Ctrl, IPA + +# to be able to find $top_srcdir/doc/... +confpath = os.path.join(sys.path[0], '..') +verbose = False + +class TestCtrlBase(unittest.TestCase): + + def ctrl_command(self): + raise Exception("Needs to be implemented by a subclass") + + def ctrl_app(self): + raise Exception("Needs to be implemented by a subclass") + + def setUp(self): + osmo_ctrl_cmd = self.ctrl_command()[:] + config_index = osmo_ctrl_cmd.index('-c') + if config_index: + cfi = config_index + 1 + osmo_ctrl_cmd[cfi] = os.path.join(confpath, osmo_ctrl_cmd[cfi]) + + try: + self.proc = osmoutil.popen_devnull(osmo_ctrl_cmd) + except OSError: + print("Current directory: %s" % os.getcwd(), file=sys.stderr) + print("Consider setting -b", file=sys.stderr) + + appstring = self.ctrl_app()[2] + appport = self.ctrl_app()[0] + self.connect("127.0.0.1", appport) + self.next_id = 1000 + + def tearDown(self): + self.disconnect() + osmoutil.end_proc(self.proc) + + def disconnect(self): + if not (self.sock is None): + self.sock.close() + + def connect(self, host, port): + if verbose: + print("Connecting to host %s:%i" % (host, port)) + + retries = 30 + while True: + try: + sck = socket.socket(socket.AF_INET, socket.SOCK_STREAM) + sck.setblocking(1) + sck.connect((host, port)) + except IOError: + retries -= 1 + if retries <= 0: + raise + time.sleep(.1) + continue + break + self.sock = sck + return sck + + def send(self, data): + if verbose: + print("Sending \"%s\"" %(data)) + data = Ctrl().add_header(data) + return self.sock.send(data) == len(data) + + def send_set(self, var, value, id): + setmsg = "SET %s %s %s" %(id, var, value) + return self.send(setmsg) + + def send_get(self, var, id): + getmsg = "GET %s %s" %(id, var) + return self.send(getmsg) + + def do_set(self, var, value): + id = self.next_id + self.next_id += 1 + self.send_set(var, value, id) + return self.recv_msgs()[id] + + def do_get(self, var): + id = self.next_id + self.next_id += 1 + self.send_get(var, id) + return self.recv_msgs()[id] + + def recv_msgs(self): + responses = {} + data = self.sock.recv(4096) + while (len(data)>0): + (head, data) = IPA().split_combined(data) + answer = Ctrl().rem_header(head).decode() + if verbose: + print("Got message:", answer) + (mtype, id, msg) = answer.split(None, 2) + id = int(id) + rsp = {'mtype': mtype, 'id': id} + if mtype == "ERROR": + rsp['error'] = msg + else: + split = msg.split(None, 1) + rsp['var'] = split[0] + if len(split) > 1: + rsp['value'] = split[1] + else: + rsp['value'] = None + responses[id] = rsp + + if verbose: + print("Decoded replies: ", responses) + + return responses + + +class TestCtrlBSCNAT(TestCtrlBase): + + def tearDown(self): + TestCtrlBase.tearDown(self) + os.unlink("tmp_dummy_sock") + + def ctrl_command(self): + return ["./src/osmo-bsc-nat/osmo-bsc-nat", "-r", "tmp_dummy_sock", "-c", + "doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg"] + + def ctrl_app(self): + return (4249, "./src/osmo-bsc-nat/osmo-bsc-nat", "OsmoBSCNAT", "bsc_nat") + + def testCtrlErrs(self): + r = self.do_get('invalid') + self.assertEqual(r['mtype'], 'ERROR') + self.assertEqual(r['error'], 'Command not found') + + r = self.do_get('bsc_nat.999') + self.assertEqual(r['mtype'], 'ERROR') + self.assertEqual(r['error'], 'Error while resolving object') + +def add_bsc_nat_test(suite, workdir, klass): + if not os.path.isfile(os.path.join(workdir, "src/osmo-bsc-nat/osmo-bsc-nat")): + print("Skipping the osmo-bsc-nat test") + return + test = unittest.TestLoader().loadTestsFromTestCase(klass) + suite.addTest(test) + +if __name__ == '__main__': + import argparse + import sys + + workdir = '.' + + parser = argparse.ArgumentParser() + parser.add_argument("-v", "--verbose", dest="verbose", + action="store_true", help="verbose mode") + parser.add_argument("-p", "--pythonconfpath", dest="p", + help="searchpath for config") + parser.add_argument("-w", "--workdir", dest="w", + help="Working directory") + args = parser.parse_args() + + verbose_level = 1 + if args.verbose: + verbose_level = 2 + verbose = True + + if args.w: + workdir = args.w + + if args.p: + confpath = args.p + + print("confpath %s, workdir %s" % (confpath, workdir)) + os.chdir(workdir) + print("Running tests for specific control commands") + suite = unittest.TestSuite() + add_bsc_nat_test(suite, workdir, TestCtrlBSCNAT) + res = unittest.TextTestRunner(verbosity=verbose_level).run(suite) + sys.exit(len(res.errors) + len(res.failures)) diff --git a/tests/osmo-bsc-nat.vty b/tests/osmo-bsc-nat.vty new file mode 100644 index 0000000..f060511 --- /dev/null +++ b/tests/osmo-bsc-nat.vty @@ -0,0 +1,2 @@ +OsmoBSCNAT> enable + diff --git a/tests/testsuite.at b/tests/testsuite.at new file mode 100644 index 0000000..65d1ca0 --- /dev/null +++ b/tests/testsuite.at @@ -0,0 +1,8 @@ +AT_INIT +AT_BANNER([Regression tests.]) + +#AT_SETUP([foobar]) +#AT_KEYWORDS([foobar]) +#cat $abs_srcdir/foobar/foobar_test.ok > expout +#AT_CHECK([$abs_top_builddir/tests/foobar/foobar_test], [], [expout], [ignore]) +#AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Iae5d37483dcb9db00578d5c9cd1736f08754a65e Gerrit-Change-Number: 26658 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 19:46:15 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 19:46:15 +0000 Subject: Change in osmo-bsc-nat[master]: Add vty interface References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659 ) Change subject: Add vty interface ...................................................................... Add vty interface Related: OS#2545 Change-Id: I6f2d8d1d62b97be471ebcf1bb14aac0b895833d1 --- M include/osmocom/bsc_nat/Makefile.am M include/osmocom/bsc_nat/bsc_nat.h A include/osmocom/bsc_nat/logging.h A include/osmocom/bsc_nat/vty.h M src/osmo-bsc-nat/Makefile.am A src/osmo-bsc-nat/bsc_nat.c A src/osmo-bsc-nat/logging.c M src/osmo-bsc-nat/main.c A src/osmo-bsc-nat/vty.c 9 files changed, 297 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/59/26659/1 diff --git a/include/osmocom/bsc_nat/Makefile.am b/include/osmocom/bsc_nat/Makefile.am index 158ca4b..f573dd9 100644 --- a/include/osmocom/bsc_nat/Makefile.am +++ b/include/osmocom/bsc_nat/Makefile.am @@ -1,3 +1,5 @@ noinst_HEADERS = \ bsc_nat.h \ + logging.h \ + vty.h \ $(NULL) diff --git a/include/osmocom/bsc_nat/bsc_nat.h b/include/osmocom/bsc_nat/bsc_nat.h index bbdf826..511d5a4 100644 --- a/include/osmocom/bsc_nat/bsc_nat.h +++ b/include/osmocom/bsc_nat/bsc_nat.h @@ -17,3 +17,12 @@ * */ #pragma once + +struct bsc_nat { +}; + +struct bsc_nat *bsc_nat_alloc(void *tall_ctx); +void bsc_nat_free(struct bsc_nat *bsc_nat); + +extern void *tall_bsc_nat_ctx; +extern struct bsc_nat *g_bsc_nat; diff --git a/include/osmocom/bsc_nat/logging.h b/include/osmocom/bsc_nat/logging.h new file mode 100644 index 0000000..88f67b0 --- /dev/null +++ b/include/osmocom/bsc_nat/logging.h @@ -0,0 +1,27 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Oliver Smith + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +#include + +enum { + DMAIN, +}; + +extern const struct log_info bsc_nat_log_info; diff --git a/include/osmocom/bsc_nat/vty.h b/include/osmocom/bsc_nat/vty.h new file mode 100644 index 0000000..f882c23 --- /dev/null +++ b/include/osmocom/bsc_nat/vty.h @@ -0,0 +1,31 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Oliver Smith + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#pragma once + +#include +#include +#include + +enum bsc_nat_vty_nodes { + BSC_NAT_NODE = _LAST_OSMOVTY_NODE, +}; + +void bsc_nat_vty_init(void); +int bsc_nat_vty_go_parent(struct vty *vty); diff --git a/src/osmo-bsc-nat/Makefile.am b/src/osmo-bsc-nat/Makefile.am index 9d0bf3e..9aa9524 100644 --- a/src/osmo-bsc-nat/Makefile.am +++ b/src/osmo-bsc-nat/Makefile.am @@ -25,7 +25,10 @@ $(NULL) osmo_bsc_nat_SOURCES = \ + bsc_nat.c \ + logging.c \ main.c \ + vty.c \ $(NULL) osmo_bsc_nat_LDADD = \ diff --git a/src/osmo-bsc-nat/bsc_nat.c b/src/osmo-bsc-nat/bsc_nat.c new file mode 100644 index 0000000..149e7cb --- /dev/null +++ b/src/osmo-bsc-nat/bsc_nat.c @@ -0,0 +1,38 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Oliver Smith + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include "config.h" + +#include +#include + +struct bsc_nat *bsc_nat_alloc(void *tall_ctx) +{ + struct bsc_nat *bsc_nat; + + bsc_nat = talloc_zero(tall_ctx, struct bsc_nat); + OSMO_ASSERT(bsc_nat); + + return bsc_nat; +} + +void bsc_nat_free(struct bsc_nat *bsc_nat) +{ + talloc_free(bsc_nat); +} diff --git a/src/osmo-bsc-nat/logging.c b/src/osmo-bsc-nat/logging.c new file mode 100644 index 0000000..5ada8c2 --- /dev/null +++ b/src/osmo-bsc-nat/logging.c @@ -0,0 +1,37 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Oliver Smith + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#include +#include + +#include + +static const struct log_info_cat log_cat[] = { + [DMAIN] = { + .name = "DMAIN", + .loglevel = LOGL_NOTICE, + .enabled = 1, + .color = "", + .description = "Main program", + }, +}; + +const struct log_info bsc_nat_log_info = { + .cat = log_cat, + .num_cat = ARRAY_SIZE(log_cat), +}; diff --git a/src/osmo-bsc-nat/main.c b/src/osmo-bsc-nat/main.c index 8775af1..813909b 100644 --- a/src/osmo-bsc-nat/main.c +++ b/src/osmo-bsc-nat/main.c @@ -19,7 +19,78 @@ #include "config.h" +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +static const char *const copyright = + "OsmoBSCNAT - Osmocom BSC NAT\r\n" + "Copyright (C) 2021 by sysmocom s.f.m.c. GmbH \r\n" + "Author: Oliver Smith\r\n" + "License AGPLv3+: GNU AGPL version 3 or later \r\n" + "This is free software: you are free to change and redistribute it.\r\n" + "There is NO WARRANTY, to the extent permitted by law.\r\n"; + +void *tall_bsc_nat_ctx; +struct bsc_nat *g_bsc_nat; + +static struct vty_app_info vty_info = { + .name = "OsmoBSCNAT", + .version = PACKAGE_VERSION, + .go_parent_cb = bsc_nat_vty_go_parent, +}; + +static void main_vty_init() +{ + int rc; + + vty_info.copyright = copyright; + vty_info.tall_ctx = tall_bsc_nat_ctx; + vty_init(&vty_info); + + bsc_nat_vty_init(); + + logging_vty_add_cmds(); + osmo_talloc_vty_add_cmds(); + osmo_cpu_sched_vty_init(tall_bsc_nat_ctx); + + rc = telnet_init_dynif(tall_bsc_nat_ctx, g_bsc_nat, vty_get_bind_addr(), OSMO_VTY_PORT_BSC_NAT); + if (rc < 0) { + perror("Error binding VTY port"); + exit(1); + } +} + int main(int argc, char **argv) { + int rc; + + talloc_enable_null_tracking(); + tall_bsc_nat_ctx = talloc_named_const(NULL, 0, "bsc_nat"); + + rc = osmo_init_logging2(tall_bsc_nat_ctx, &bsc_nat_log_info); + if (rc < 0) + exit(1); + + g_bsc_nat = bsc_nat_alloc(tall_bsc_nat_ctx); + + main_vty_init(); + + while (!osmo_select_shutdown_done()) + osmo_select_main_ctx(0); + + talloc_report_full(tall_bsc_nat_ctx, stderr); + talloc_free(tall_bsc_nat_ctx); + talloc_free(tall_vty_ctx); + talloc_report_full(NULL, stderr); + talloc_disable_null_tracking(); + return 0; } diff --git a/src/osmo-bsc-nat/vty.c b/src/osmo-bsc-nat/vty.c new file mode 100644 index 0000000..089d27b --- /dev/null +++ b/src/osmo-bsc-nat/vty.c @@ -0,0 +1,79 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Oliver Smith + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include "config.h" + +#include + +#include +#include +#include + +#include +#include + +int bsc_nat_vty_go_parent(struct vty *vty) +{ + switch (vty->node) { + case BSC_NAT_NODE: + vty->node = CONFIG_NODE; + vty->index = g_bsc_nat; + break; + case CONFIG_NODE: + vty->node = ENABLE_NODE; + vty->index = NULL; + break; + default: + vty->node = CONFIG_NODE; + vty->index = NULL; + break; + } + + return vty->node; +} + +static struct cmd_node bsc_nat_node = { + BSC_NAT_NODE, + "%s(config-bsc-nat)# ", + 1, +}; + +DEFUN(cfg_bsc_nat, + cfg_bsc_nat_cmd, + "bsc-nat", "Configure the BSC NAT\n") +{ + OSMO_ASSERT(g_bsc_nat); + vty->index = g_bsc_nat; + vty->node = BSC_NAT_NODE; + + return CMD_SUCCESS; +} + +static int config_write_bsc_nat(struct vty *vty) +{ + vty_out(vty, "bsc-nat%s", VTY_NEWLINE); + return CMD_SUCCESS; +} + + +void bsc_nat_vty_init(void) +{ + install_element(CONFIG_NODE, &cfg_bsc_nat_cmd); + install_node(&bsc_nat_node, config_write_bsc_nat); +} -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I6f2d8d1d62b97be471ebcf1bb14aac0b895833d1 Gerrit-Change-Number: 26659 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 19:46:15 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 19:46:15 +0000 Subject: Change in osmo-bsc-nat[master]: Add command-line options References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26660 ) Change subject: Add command-line options ...................................................................... Add command-line options Related: OS#2545 Change-Id: I41bca9e1b88bb130870d078ed3f499e39e0bf5d3 --- M src/osmo-bsc-nat/main.c 1 file changed, 65 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/60/26660/1 diff --git a/src/osmo-bsc-nat/main.c b/src/osmo-bsc-nat/main.c index 813909b..1edc134 100644 --- a/src/osmo-bsc-nat/main.c +++ b/src/osmo-bsc-nat/main.c @@ -19,6 +19,8 @@ #include "config.h" +#include + #include #include #include @@ -47,7 +49,59 @@ .go_parent_cb = bsc_nat_vty_go_parent, }; -static void main_vty_init() +static struct { + const char *config_file; +} bsc_nat_cmdline_config = { + .config_file = "osmo-bsc-nat.cfg", +}; + +static void print_help() +{ + printf("usage: osmo-bsc-nat \n"); + printf("\n"); + printf("optional arguments:\n"); + printf(" -h, --help show this help message and exit\n"); + printf(" -c, --config-file the config file to use\n"); + printf(" -V, --version show version number and exit\n"); +} + +static void handle_options(int argc, char **argv) +{ + while (1) { + int idx = 0, c; + static const struct option long_options[] = { + {"help", 0, 0, 'h'}, + {"config-file", 1, 0, 'c'}, + {"version", 0, 0, 'V' }, + { 0, 0, 0, 0 }, + }; + + c = getopt_long(argc, argv, "hc:V", long_options, &idx); + + if (c == -1) + break; + + switch (c) { + case 'h': + print_help(); + exit(0); + break; + case 'c': + bsc_nat_cmdline_config.config_file = optarg; + break; + case 'V': + print_version(1); + exit(0); + break; + default: + fprintf(stderr, "Error in command line options. Exiting.\n"); + exit(-1); + break; + } + } +} + +static void main_vty_init(int argc, char **argv) { int rc; @@ -61,6 +115,15 @@ osmo_talloc_vty_add_cmds(); osmo_cpu_sched_vty_init(tall_bsc_nat_ctx); + handle_options(argc, argv); + + rc = vty_read_config_file(bsc_nat_cmdline_config.config_file, NULL); + if (rc < 0) { + fprintf(stderr, "Failed to parse the config file: '%s'\n", + bsc_nat_cmdline_config.config_file); + exit(1); + } + rc = telnet_init_dynif(tall_bsc_nat_ctx, g_bsc_nat, vty_get_bind_addr(), OSMO_VTY_PORT_BSC_NAT); if (rc < 0) { perror("Error binding VTY port"); @@ -81,7 +144,7 @@ g_bsc_nat = bsc_nat_alloc(tall_bsc_nat_ctx); - main_vty_init(); + main_vty_init(argc, argv); while (!osmo_select_shutdown_done()) osmo_select_main_ctx(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I41bca9e1b88bb130870d078ed3f499e39e0bf5d3 Gerrit-Change-Number: 26660 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 19:46:16 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 19:46:16 +0000 Subject: Change in osmo-bsc-nat[master]: Add signal handler References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26661 ) Change subject: Add signal handler ...................................................................... Add signal handler Related: OS#2545 Change-Id: I303e9275a2f1f6f2da742089d079ba604ee5a36b --- M src/osmo-bsc-nat/main.c 1 file changed, 44 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/61/26661/1 diff --git a/src/osmo-bsc-nat/main.c b/src/osmo-bsc-nat/main.c index 1edc134..a37d3cb 100644 --- a/src/osmo-bsc-nat/main.c +++ b/src/osmo-bsc-nat/main.c @@ -131,6 +131,49 @@ } } +static void signal_handler(int signum) +{ + fprintf(stdout, "signal %u received\n", signum); + + switch (signum) { + case SIGINT: + case SIGTERM: + /* If SIGTERM was already sent before, just terminate immediately. */ + if (osmo_select_shutdown_requested()) + exit(-1); + osmo_select_shutdown_request(); + break; + case SIGABRT: + /* in case of abort, we want to obtain a talloc report and + * then run default SIGABRT handler, who will generate coredump + * and abort the process. abort() should do this for us after we + * return, but program wouldn't exit if an external SIGABRT is + * received. + */ + talloc_report(tall_vty_ctx, stderr); + talloc_report_full(tall_bsc_nat_ctx, stderr); + signal(SIGABRT, SIG_DFL); + raise(SIGABRT); + break; + case SIGUSR1: + talloc_report(tall_vty_ctx, stderr); + talloc_report_full(tall_bsc_nat_ctx, stderr); + break; + default: + break; + } +} + +static void signal_handler_init(void) +{ + signal(SIGINT, &signal_handler); + signal(SIGTERM, &signal_handler); + signal(SIGABRT, &signal_handler); + signal(SIGUSR1, &signal_handler); + signal(SIGUSR2, &signal_handler); + osmo_init_ignore_signals(); +} + int main(int argc, char **argv) { int rc; @@ -145,6 +188,7 @@ g_bsc_nat = bsc_nat_alloc(tall_bsc_nat_ctx); main_vty_init(argc, argv); + signal_handler_init(); while (!osmo_select_shutdown_done()) osmo_select_main_ctx(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I303e9275a2f1f6f2da742089d079ba604ee5a36b Gerrit-Change-Number: 26661 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 19:46:16 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 19:46:16 +0000 Subject: Change in osmo-bsc-nat[master]: Add bsc_nat fsm References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 ) Change subject: Add bsc_nat fsm ...................................................................... Add bsc_nat fsm Create the initial FSM that starts and stops two SS7 instances (one for CN, one for RAN), and binds an sccp user to each. Related: OS#2545 Depends: libosmocore 0066f1bdcb328e7ffc846b4746e3e1d02afe4be8 Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 --- M doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg M include/osmocom/bsc_nat/Makefile.am M include/osmocom/bsc_nat/bsc_nat.h A include/osmocom/bsc_nat/bsc_nat_fsm.h M src/osmo-bsc-nat/Makefile.am M src/osmo-bsc-nat/bsc_nat.c A src/osmo-bsc-nat/bsc_nat_fsm.c M src/osmo-bsc-nat/main.c M src/osmo-bsc-nat/vty.c 9 files changed, 339 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/62/26662/1 diff --git a/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg b/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg index e69de29..65ce821 100644 --- a/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg +++ b/doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg @@ -0,0 +1,16 @@ +cs7 instance 0 + point-code 0.23.3 + asp asp-clnt-OsmoBSCNAT-CN 2905 0 m3ua + remote-ip 127.0.0.1 + local-ip 127.0.0.3 + +cs7 instance 1 + point-code 0.23.1 + asp asp-clnt-OsmoBSCNAT-RAN 2905 0 m3ua + remote-ip 127.0.0.2 + local-ip 127.0.0.4 + +bsc-nat + cs7-instance-cn 0 + cs7-instance-ran 1 + diff --git a/include/osmocom/bsc_nat/Makefile.am b/include/osmocom/bsc_nat/Makefile.am index f573dd9..90f44a7 100644 --- a/include/osmocom/bsc_nat/Makefile.am +++ b/include/osmocom/bsc_nat/Makefile.am @@ -1,5 +1,6 @@ noinst_HEADERS = \ bsc_nat.h \ + bsc_nat_fsm.h \ logging.h \ vty.h \ $(NULL) diff --git a/include/osmocom/bsc_nat/bsc_nat.h b/include/osmocom/bsc_nat/bsc_nat.h index 511d5a4..d1a046e 100644 --- a/include/osmocom/bsc_nat/bsc_nat.h +++ b/include/osmocom/bsc_nat/bsc_nat.h @@ -18,7 +18,22 @@ */ #pragma once +#include +#include + + +struct bsc_nat_ss7_inst { + uint32_t ss7_id; + struct osmo_sccp_addr local_sccp_addr; + struct osmo_sccp_user *scu; +}; + struct bsc_nat { + bool shutdown; + struct osmo_fsm_inst *fi; + + struct bsc_nat_ss7_inst *cn; + struct bsc_nat_ss7_inst *ran; }; struct bsc_nat *bsc_nat_alloc(void *tall_ctx); diff --git a/include/osmocom/bsc_nat/bsc_nat_fsm.h b/include/osmocom/bsc_nat/bsc_nat_fsm.h new file mode 100644 index 0000000..252fd67 --- /dev/null +++ b/include/osmocom/bsc_nat/bsc_nat_fsm.h @@ -0,0 +1,36 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Oliver Smith + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ +#pragma once + +enum bsc_nat_fsm_states { + BSC_NAT_FSM_ST_STOPPED, + BSC_NAT_FSM_ST_STARTING, + BSC_NAT_FSM_ST_STARTED, + BSC_NAT_FSM_ST_STOPPING, +}; + +enum bsc_nat_fsm_events { + BSC_NAT_FSM_EV_START, + BSC_NAT_FSM_EV_STOP, +}; + +extern struct osmo_fsm bsc_nat_fsm; + +void bsc_nat_start(struct bsc_nat *bsc_nat); +void bsc_nat_stop(struct bsc_nat *bsc_nat, bool exit_proc); diff --git a/src/osmo-bsc-nat/Makefile.am b/src/osmo-bsc-nat/Makefile.am index 9aa9524..6a759cb 100644 --- a/src/osmo-bsc-nat/Makefile.am +++ b/src/osmo-bsc-nat/Makefile.am @@ -26,6 +26,7 @@ osmo_bsc_nat_SOURCES = \ bsc_nat.c \ + bsc_nat_fsm.c \ logging.c \ main.c \ vty.c \ diff --git a/src/osmo-bsc-nat/bsc_nat.c b/src/osmo-bsc-nat/bsc_nat.c index 149e7cb..e911c0f 100644 --- a/src/osmo-bsc-nat/bsc_nat.c +++ b/src/osmo-bsc-nat/bsc_nat.c @@ -21,6 +21,7 @@ #include #include +#include struct bsc_nat *bsc_nat_alloc(void *tall_ctx) { @@ -29,10 +30,25 @@ bsc_nat = talloc_zero(tall_ctx, struct bsc_nat); OSMO_ASSERT(bsc_nat); + bsc_nat->cn = talloc_zero(bsc_nat, struct bsc_nat_ss7_inst); + OSMO_ASSERT(bsc_nat->cn); + talloc_set_name_const(bsc_nat->cn, "struct bsc_nat_ss7_inst (CN)"); + + bsc_nat->ran = talloc_zero(bsc_nat, struct bsc_nat_ss7_inst); + OSMO_ASSERT(bsc_nat->ran); + talloc_set_name_const(bsc_nat->ran, "struct bsc_nat_ss7_inst (RAN)"); + + bsc_nat->fi = osmo_fsm_inst_alloc(&bsc_nat_fsm, bsc_nat, bsc_nat, LOGL_INFO, NULL); + return bsc_nat; } void bsc_nat_free(struct bsc_nat *bsc_nat) { + if (bsc_nat->fi) { + osmo_fsm_inst_free(bsc_nat->fi); + bsc_nat->fi = NULL; + } + talloc_free(bsc_nat); } diff --git a/src/osmo-bsc-nat/bsc_nat_fsm.c b/src/osmo-bsc-nat/bsc_nat_fsm.c new file mode 100644 index 0000000..bfaa7f7 --- /dev/null +++ b/src/osmo-bsc-nat/bsc_nat_fsm.c @@ -0,0 +1,213 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Oliver Smith + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include "config.h" + +#include +#include + +#include +#include + +#include + +#include +#include +#include + +#define X(s) (1 << (s)) + +#define DEFAULT_PC_RAN "0.23.1" /* same as default for OsmoMSC */ +#define DEFAULT_PC_CN "0.23.3" /* same as default for OsmoBSC */ + +static void st_stopped(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + switch (event) { + case BSC_NAT_FSM_EV_START: + osmo_fsm_inst_state_chg(fi, BSC_NAT_FSM_ST_STARTING, 0, 0); + break; + } +} + +static void st_stopped_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct bsc_nat *bsc_nat = (struct bsc_nat *)fi->priv; + + if (bsc_nat->shutdown) { + LOGPFSML(fi, LOGL_NOTICE, "Shutting down\n"); + osmo_select_shutdown_request(); + } +} + +static int sccp_sap_up(struct osmo_prim_hdr *oph, void *priv) +{ + LOGP(DMAIN, LOGL_NOTICE, "STUB: sccp_sap_up() called\n"); + + return 0; +} + +static int ss7_inst_init(struct bsc_nat_ss7_inst *inst, const char *name, const char *default_pc_str, + enum osmo_sccp_ssn ssn) +{ + int default_pc; + struct osmo_sccp_instance *sccp; + + default_pc = osmo_ss7_pointcode_parse(NULL, default_pc_str); + OSMO_ASSERT(default_pc >= 0); + + sccp = osmo_sccp_simple_client_on_ss7_id(inst, inst->ss7_id, name, default_pc, OSMO_SS7_ASP_PROT_M3UA, 0, NULL, + 0, NULL); + if (!sccp) { + LOGP(DMAIN, LOGL_ERROR, "%s: failed to request sccp client instance for sccp user\n", name); + return -1; + } + + osmo_sccp_local_addr_by_instance(&inst->local_sccp_addr, sccp, ssn); + + inst->scu = osmo_sccp_user_bind(sccp, name, sccp_sap_up, ssn); + if (!inst->scu) { + LOGP(DMAIN, LOGL_ERROR, "%s: failed to bind sccp user\n", name); + return -2; + } + + osmo_sccp_user_set_priv(inst->scu, inst); + return 0; +} + +static void ss7_inst_free(struct bsc_nat_ss7_inst *inst) +{ + if (inst->scu) { + osmo_sccp_user_unbind(inst->scu); + inst->scu = NULL; + } + + struct osmo_ss7_instance *ss7 = osmo_ss7_instance_find(inst->ss7_id); + if (ss7) + osmo_ss7_instance_destroy(ss7); +} + +static void st_starting_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct bsc_nat *bsc_nat = (struct bsc_nat *)fi->priv; + + if (ss7_inst_init(bsc_nat->cn, "OsmoBSCNAT-CN", DEFAULT_PC_CN, OSMO_SCCP_SSN_RANAP) < 0) { + osmo_fsm_inst_state_chg(fi, BSC_NAT_FSM_ST_STOPPING, 0, 0); + return; + } + + if (ss7_inst_init(bsc_nat->ran, "OsmoBSCNAT-RAN", DEFAULT_PC_RAN, OSMO_SCCP_SSN_MSC) < 0) { + osmo_fsm_inst_state_chg(fi, BSC_NAT_FSM_ST_STOPPING, 0, 0); + return; + } + + osmo_fsm_inst_state_chg(fi, BSC_NAT_FSM_ST_STARTED, 0, 0); +} + +static void st_started(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + switch (event) { + case BSC_NAT_FSM_EV_STOP: + osmo_fsm_inst_state_chg(fi, BSC_NAT_FSM_ST_STOPPING, 0, 0); + break; + } +} + +static void st_stopping_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct bsc_nat *bsc_nat = (struct bsc_nat *)fi->priv; + + ss7_inst_free(bsc_nat->cn); + ss7_inst_free(bsc_nat->ran); + + osmo_fsm_inst_state_chg(fi, BSC_NAT_FSM_ST_STOPPED, 0, 0); +} + +static struct osmo_fsm_state bsc_nat_fsm_states[] = { + [BSC_NAT_FSM_ST_STOPPED] = { + .name = "STOPPED", + .in_event_mask = + X(BSC_NAT_FSM_EV_START), + .out_state_mask = + X(BSC_NAT_FSM_ST_STARTING), + .action = st_stopped, + .onenter = st_stopped_on_enter, + }, + [BSC_NAT_FSM_ST_STARTING] = { + .name = "STARTING", + .out_state_mask = + X(BSC_NAT_FSM_ST_STARTED) | + X(BSC_NAT_FSM_ST_STOPPING), + .onenter = st_starting_on_enter, + }, + [BSC_NAT_FSM_ST_STARTED] = { + .name = "STARTED", + .in_event_mask = + X(BSC_NAT_FSM_EV_STOP), + .out_state_mask = + X(BSC_NAT_FSM_ST_STOPPING), + .action = st_started, + }, + [BSC_NAT_FSM_ST_STOPPING] = { + .name = "STOPPING", + .out_state_mask = + X(BSC_NAT_FSM_ST_STOPPED), + .onenter = st_stopping_on_enter, + }, +}; + +const struct value_string bsc_nat_fsm_event_names[] = { + OSMO_VALUE_STRING(BSC_NAT_FSM_EV_START), + OSMO_VALUE_STRING(BSC_NAT_FSM_EV_STOP), + { 0, NULL } +}; + +int bsc_nat_fsm_timer_cb(struct osmo_fsm_inst *fi) +{ + switch (fi->state) { + default: + OSMO_ASSERT(false); + } + return 0; +} + +struct osmo_fsm bsc_nat_fsm = { + .name = "BSC_NAT", + .states = bsc_nat_fsm_states, + .num_states = ARRAY_SIZE(bsc_nat_fsm_states), + .timer_cb = bsc_nat_fsm_timer_cb, + .log_subsys = DMAIN, + .event_names = bsc_nat_fsm_event_names, +}; + +static __attribute__((constructor)) void bsc_nat_fsm_init(void) +{ + OSMO_ASSERT(osmo_fsm_register(&bsc_nat_fsm) == 0); +} + +void bsc_nat_start(struct bsc_nat *bsc_nat) +{ + osmo_fsm_inst_dispatch(bsc_nat->fi, BSC_NAT_FSM_EV_START, NULL); +} + +void bsc_nat_stop(struct bsc_nat *bsc_nat, bool exit_proc) +{ + if (exit_proc) + bsc_nat->shutdown = true; + osmo_fsm_inst_dispatch(bsc_nat->fi, BSC_NAT_FSM_EV_STOP, NULL); +} diff --git a/src/osmo-bsc-nat/main.c b/src/osmo-bsc-nat/main.c index a37d3cb..d1e32a9 100644 --- a/src/osmo-bsc-nat/main.c +++ b/src/osmo-bsc-nat/main.c @@ -22,6 +22,8 @@ #include #include +#include +#include #include #include #include @@ -29,6 +31,7 @@ #include #include +#include #include #include @@ -113,7 +116,10 @@ logging_vty_add_cmds(); osmo_talloc_vty_add_cmds(); + osmo_fsm_vty_add_cmds(); osmo_cpu_sched_vty_init(tall_bsc_nat_ctx); + osmo_ss7_vty_init_asp(NULL); + osmo_sccp_vty_init(); handle_options(argc, argv); @@ -139,9 +145,9 @@ case SIGINT: case SIGTERM: /* If SIGTERM was already sent before, just terminate immediately. */ - if (osmo_select_shutdown_requested()) + if (g_bsc_nat->shutdown) exit(-1); - osmo_select_shutdown_request(); + bsc_nat_stop(g_bsc_nat, true); break; case SIGABRT: /* in case of abort, we want to obtain a talloc report and @@ -185,14 +191,23 @@ if (rc < 0) exit(1); + rc = osmo_ss7_init(); + if (rc < 0) + exit(1); + g_bsc_nat = bsc_nat_alloc(tall_bsc_nat_ctx); main_vty_init(argc, argv); signal_handler_init(); + bsc_nat_start(g_bsc_nat); + while (!osmo_select_shutdown_done()) osmo_select_main_ctx(0); + talloc_report_full(g_bsc_nat, stderr); + bsc_nat_free(g_bsc_nat); + log_fini(); talloc_report_full(tall_bsc_nat_ctx, stderr); talloc_free(tall_bsc_nat_ctx); talloc_free(tall_vty_ctx); diff --git a/src/osmo-bsc-nat/vty.c b/src/osmo-bsc-nat/vty.c index 089d27b..128940e 100644 --- a/src/osmo-bsc-nat/vty.c +++ b/src/osmo-bsc-nat/vty.c @@ -68,12 +68,36 @@ static int config_write_bsc_nat(struct vty *vty) { vty_out(vty, "bsc-nat%s", VTY_NEWLINE); + vty_out(vty, " cs7-instance-cn %u%s", g_bsc_nat->cn->ss7_id, VTY_NEWLINE); + vty_out(vty, " cs7-instance-ran %u%s", g_bsc_nat->ran->ss7_id, VTY_NEWLINE); + return CMD_SUCCESS; } +#define SS7_REF_STR "SS7 instance reference number\n" + +DEFUN(cfg_cs7_instance_cn, + cfg_cs7_instance_cn_cmd, + "cs7-instance-cn <0-15>", + "Set SS7 to be used to connect to CN-side\n" SS7_REF_STR) +{ + g_bsc_nat->cn->ss7_id = atoi(argv[0]); + return CMD_SUCCESS; +} + +DEFUN(cfg_cs7_instance_ran, + cfg_cs7_instance_ran_cmd, + "cs7-instance-ran <0-15>", + "Set SS7 to be used to connect to RAN-side\n" SS7_REF_STR) +{ + g_bsc_nat->ran->ss7_id = atoi(argv[0]); + return CMD_SUCCESS; +} void bsc_nat_vty_init(void) { install_element(CONFIG_NODE, &cfg_bsc_nat_cmd); install_node(&bsc_nat_node, config_write_bsc_nat); + install_element(BSC_NAT_NODE, &cfg_cs7_instance_cn_cmd); + install_element(BSC_NAT_NODE, &cfg_cs7_instance_ran_cmd); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 19:46:22 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 19:46:22 +0000 Subject: Change in libosmocore[master]: select_main: don't poll forever during shutdown References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26663 ) Change subject: select_main: don't poll forever during shutdown ...................................................................... select_main: don't poll forever during shutdown Do not poll without timeout during shutdown if no timers are pending. Change-Id: I81c64a7ae440304522c2179c212023a566ddced8 --- M src/select.c 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/63/26663/1 diff --git a/src/select.c b/src/select.c index 590c3db..fbb617f 100644 --- a/src/select.c +++ b/src/select.c @@ -367,14 +367,20 @@ { unsigned int n_poll; int rc; + int timeout = 0; /* prepare read and write fdsets */ n_poll = poll_fill_fds(); - if (!polling) + if (!polling) { osmo_timers_prepare(); + timeout = osmo_timers_nearest_ms(); - rc = poll(g_poll.poll, n_poll, polling ? 0 : osmo_timers_nearest_ms()); + if (_osmo_select_shutdown_requested && timeout == -1) + timeout = 0; + } + + rc = poll(g_poll.poll, n_poll, timeout); if (rc < 0) return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81c64a7ae440304522c2179c212023a566ddced8 Gerrit-Change-Number: 26663 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 19:46:35 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 19:46:35 +0000 Subject: Change in libosmo-sccp[master]: src/sccp_scmg: fix typo References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26664 ) Change subject: src/sccp_scmg: fix typo ...................................................................... src/sccp_scmg: fix typo Change-Id: Ifd6264da2da2e7cc62485dcde9b6c462d4858626 --- M src/sccp_scmg.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/64/26664/1 diff --git a/src/sccp_scmg.c b/src/sccp_scmg.c index aba2416..ef3a0b3 100644 --- a/src/sccp_scmg.c +++ b/src/sccp_scmg.c @@ -308,7 +308,7 @@ int sccp_scmg_init(struct osmo_sccp_instance *inst) { struct osmo_sccp_user *scu; - scu = osmo_sccp_user_bind(inst, "SCCP Maangement", scmg_prim_cb, SCCP_SSN_MANAGEMENT); + scu = osmo_sccp_user_bind(inst, "SCCP Management", scmg_prim_cb, SCCP_SSN_MANAGEMENT); if (!scu) return -1; return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ifd6264da2da2e7cc62485dcde9b6c462d4858626 Gerrit-Change-Number: 26664 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 19:46:35 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 19:46:35 +0000 Subject: Change in libosmo-sccp[master]: osmo_ss7_instance_destroy: use for_each_entry_safe References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26665 ) Change subject: osmo_ss7_instance_destroy: use for_each_entry_safe ...................................................................... osmo_ss7_instance_destroy: use for_each_entry_safe Fix segfault in each loop. Change-Id: Ieaec3584375b0e6b943638fe1e50b4d74a627216 --- M src/osmo_ss7.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/65/26665/1 diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 649e3f7..99536d3 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -410,20 +410,20 @@ * \param[in] inst SS7 Instance to be destroyed */ void osmo_ss7_instance_destroy(struct osmo_ss7_instance *inst) { - struct osmo_ss7_linkset *lset; - struct osmo_ss7_as *as; - struct osmo_ss7_asp *asp; + struct osmo_ss7_linkset *lset, *lset2; + struct osmo_ss7_as *as, *as2; + struct osmo_ss7_asp *asp, *asp2; OSMO_ASSERT(ss7_initialized); LOGSS7(inst, LOGL_INFO, "Destroying SS7 Instance\n"); - llist_for_each_entry(asp, &inst->asp_list, list) + llist_for_each_entry_safe(asp, asp2, &inst->asp_list, list) osmo_ss7_asp_destroy(asp); - llist_for_each_entry(as, &inst->as_list, list) + llist_for_each_entry_safe(as, as2, &inst->as_list, list) osmo_ss7_as_destroy(as); - llist_for_each_entry(lset, &inst->linksets, list) + llist_for_each_entry_safe(lset, lset2, &inst->linksets, list) osmo_ss7_linkset_destroy(lset); llist_del(&inst->list); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ieaec3584375b0e6b943638fe1e50b4d74a627216 Gerrit-Change-Number: 26665 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 19:49:00 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 19:49:00 +0000 Subject: Change in osmo-bsc-nat[master]: Add bsc_nat fsm In-Reply-To: References: Message-ID: osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 ) Change subject: Add bsc_nat fsm ...................................................................... Add bsc_nat fsm Create the initial FSM that starts and stops two SS7 instances (one for CN, one for RAN), and binds an sccp user to each. Related: OS#2545 Depends: libosmocore 0066f1bdcb328e7ffc846b4746e3e1d02afe4be8 Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 --- M doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg M include/osmocom/bsc_nat/Makefile.am M include/osmocom/bsc_nat/bsc_nat.h A include/osmocom/bsc_nat/bsc_nat_fsm.h M src/osmo-bsc-nat/Makefile.am M src/osmo-bsc-nat/bsc_nat.c A src/osmo-bsc-nat/bsc_nat_fsm.c M src/osmo-bsc-nat/main.c M src/osmo-bsc-nat/vty.c 9 files changed, 338 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/62/26662/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 19:57:44 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 19:57:44 +0000 Subject: Change in osmo-dev[master]: all.deps, werror.opts: add osmo-bsc-nat References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/26666 ) Change subject: all.deps, werror.opts: add osmo-bsc-nat ...................................................................... all.deps, werror.opts: add osmo-bsc-nat Change-Id: Ica90826c8bfbf4f295c49702d36e7c88e43f80cd --- M all.deps M werror.opts 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/66/26666/1 diff --git a/all.deps b/all.deps index 65bdf27..54209eb 100644 --- a/all.deps +++ b/all.deps @@ -23,6 +23,7 @@ asn1c libasn1c osmo-gbproxy libosmocore osmo-pcap libosmocore +osmo-bsc-nat libosmo-sccp # can only clone these docker-playground diff --git a/werror.opts b/werror.opts index 2121fca..21c876a 100644 --- a/werror.opts +++ b/werror.opts @@ -12,3 +12,4 @@ osmo-msc --enable-werror osmo-sgsn --enable-werror osmo-bts --enable-werror +osmo-bsc-nat --enable-werror -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ica90826c8bfbf4f295c49702d36e7c88e43f80cd Gerrit-Change-Number: 26666 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 19:57:46 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 19:57:46 +0000 Subject: Change in osmo-dev[master]: net/templates/run.sh: refactor kill logic References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/26667 ) Change subject: net/templates/run.sh: refactor kill logic ...................................................................... net/templates/run.sh: refactor kill logic Put the terminal PIDs into a variable instead of running kill %1 %2 etc. This makes it easier to conditionally spawn some of the programs. Change-Id: Iaf6c175de2edf720009af13eace2b0ef83b0735b --- M net/templates/run.sh 1 file changed, 34 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/67/26667/1 diff --git a/net/templates/run.sh b/net/templates/run.sh index 8571a42..cd0fc72 100755 --- a/net/templates/run.sh +++ b/net/templates/run.sh @@ -118,33 +118,62 @@ sudo tcpdump -i $dev -n -w current_log/$dev.single.pcap -U not port 22 & sudo tcpdump -i lo -n -w current_log/lo.single.pcap -U not port 22 & +PIDS="" + term "$ggsn" GGSN & +PIDS="$PIDS $!" + sleep .2 term "$stp" STP & +PIDS="$PIDS $!" + sleep .2 term "$hlr" HLR & +PIDS="$PIDS $!" + sleep .2 term "$sgsn" SGSN & +PIDS="$PIDS $!" + sleep .2 term "$gbproxy" GBPROXY & +PIDS="$PIDS $!" + sleep .2 term "$mgw4msc" MGW4MSC & +PIDS="$PIDS $!" + sleep .2 term "$mgw4bsc" MGW4BSC & +PIDS="$PIDS $!" + sleep .2 term "$msc" MSC & +PIDS="$PIDS $!" + sleep 2 term "$hnbgw" HNBGW & +PIDS="$PIDS $!" + sleep .2 term "$bsc" BSC & +PIDS="$PIDS $!" if [ "x${MSC_MNCC}" != "xinternal" ]; then sleep .2 term "$sipcon" SIPCON & + PIDS="$PIDS $!" + sleep .2 case "${PBX_SERVER}" in - "kamailio") term "$kamailio" KAMAILIO &;; - "freeswitch") term "./freeswitch/freeswitch.sh" FREESWITCH &;; + "kamailio") + term "$kamailio" KAMAILIO & + PIDS="$PIDS $!" + ;; + "freeswitch") + term "./freeswitch/freeswitch.sh" FREESWITCH & + PIDS="$PIDS $!" + ;; esac fi @@ -157,7 +186,9 @@ #ssh bts neels/stop_remote.sh -kill %1 %2 %3 %4 %5 %6 %7 %8 %9 %10 %11 %12 %13 %14 +for i in $PIDS; do + kill "$i" +done killall osmo-msc killall osmo-bsc killall osmo-gbproxy -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26667 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iaf6c175de2edf720009af13eace2b0ef83b0735b Gerrit-Change-Number: 26667 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 21 19:57:47 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 21 Dec 2021 19:57:47 +0000 Subject: Change in osmo-dev[master]: net: add osmo-bsc-nat References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/26668 ) Change subject: net: add osmo-bsc-nat ...................................................................... net: add osmo-bsc-nat Make STP_CN_IP and STP_RAN_IP configurable. If they are not set to the same IP, run a second OsmoSTP and OsmoBSCNAT to connect both OsmoSTP. Related: OS#2545 Change-Id: I8bfbd00bfeeebc6e1b87a8cd6333212db4380653 --- M net/config_2g3g A net/templates/osmo-bsc-nat.cfg M net/templates/osmo-bsc.cfg M net/templates/osmo-msc.cfg A net/templates/osmo-stp-cn.cfg R net/templates/osmo-stp-ran.cfg M net/templates/run.sh 7 files changed, 92 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/68/26668/1 diff --git a/net/config_2g3g b/net/config_2g3g index 263629f..c1498be 100644 --- a/net/config_2g3g +++ b/net/config_2g3g @@ -109,6 +109,18 @@ SIPCON_SIP="${TO_SIP_IP}" SIPCON_SIP_PORT="5060" +STP_CN_IP="127.0.0.1" +STP_RAN_IP="127.0.0.1" +# Set STP_CN_IP different from STP_RAN_IP, to run a second OsmoSTP and +# OsmoBSCNAT to connect both +# STP_RAN_IP="127.0.0.2" + +# Enabled only when STP_CN_IP != STP_RAN_IP +BSCNAT_CN_PC="${BSC_PC}" +BSCNAT_CN_IP="127.0.0.3" +BSCNAT_RAN_PC="${MSC_PC}" +BSCNAT_RAN_IP="127.0.0.4" + # PBX_SERVER: # "kamailio" -- launch kamailio # "freeswitch" -- launch freeswitch diff --git a/net/templates/osmo-bsc-nat.cfg b/net/templates/osmo-bsc-nat.cfg new file mode 100644 index 0000000..c9a71da --- /dev/null +++ b/net/templates/osmo-bsc-nat.cfg @@ -0,0 +1,21 @@ +${include(common_template_warning)} +cs7 instance 0 + point-code ${BSCNAT_CN_PC} + asp asp-clnt-OsmoBSCNAT-CN 2905 0 m3ua + remote-ip ${STP_CN_IP} + local-ip ${BSCNAT_CN_IP} + +cs7 instance 1 + point-code ${BSCNAT_RAN_PC} + asp asp-clnt-OsmoBSCNAT-RAN 2905 0 m3ua + remote-ip ${STP_RAN_IP} + local-ip ${BSCNAT_RAN_IP} + +bsc-nat + cs7-instance-cn 0 + cs7-instance-ran 1 + +${foreach(LOG_OUTPUT)} +log ${LOG_OUTPUTn_TYPE} +${include(common_logging)} +${foreach_end} diff --git a/net/templates/osmo-bsc.cfg b/net/templates/osmo-bsc.cfg index ab10a81..98f4e0c 100644 --- a/net/templates/osmo-bsc.cfg +++ b/net/templates/osmo-bsc.cfg @@ -19,7 +19,8 @@ ipa bind ${BSC_IP} cs7 instance 0 point-code ${BSC_PC} - asp asp-clnt-msc-0 2905 0 m3ua + asp asp-clnt-bsc-0 2905 0 m3ua + remote-ip ${STP_RAN_IP} network network country code ${MCC} mobile network code ${MNC} diff --git a/net/templates/osmo-msc.cfg b/net/templates/osmo-msc.cfg index 00bf182..c018c78 100644 --- a/net/templates/osmo-msc.cfg +++ b/net/templates/osmo-msc.cfg @@ -1,4 +1,8 @@ ${include(common_template_warning)} +cs7 instance 0 + point-code ${MSC_PC} + asp asp-clnt-msc-0 2905 0 m3ua + remote-ip ${STP_CN_IP} network network country code ${MCC} mobile network code ${MNC} diff --git a/net/templates/osmo-stp-cn.cfg b/net/templates/osmo-stp-cn.cfg new file mode 100644 index 0000000..c84168c --- /dev/null +++ b/net/templates/osmo-stp-cn.cfg @@ -0,0 +1,24 @@ +${include(common_template_warning)} + +# By default, osmo-dev starts one osmo-stp with this config. If STP_CN_IP and +# STP_RAN_IP are changed to be different, osmo-dev starts two osmo-stp, one +# with this config and another one with osmo-stp-ran.cfg. + +line vty + bind ${STP_CN_IP} + +cs7 instance 0 + xua rkm routing-key-allocation dynamic-permitted + listen m3ua 2905 + accept-asp-connections dynamic-permitted + local-ip ${STP_CN_IP} + +${foreach(LOG_OUTPUT)} +log ${LOG_OUTPUTn_TYPE} +${include(common_logging)} + logging level linp notice + logging level lss7 notice + logging level lsccp notice + logging level lsua notice + logging level lm3ua notice +${foreach_end} diff --git a/net/templates/osmo-stp.cfg b/net/templates/osmo-stp-ran.cfg similarity index 70% rename from net/templates/osmo-stp.cfg rename to net/templates/osmo-stp-ran.cfg index d7d1515..c753108 100644 --- a/net/templates/osmo-stp.cfg +++ b/net/templates/osmo-stp-ran.cfg @@ -1,8 +1,16 @@ ${include(common_template_warning)} + +# This file does not get used by default, only if STP_CN_IP and STP_RAN_IP are +# changed to be different! + +line vty + bind ${STP_RAN_IP} + cs7 instance 0 xua rkm routing-key-allocation dynamic-permitted listen m3ua 2905 accept-asp-connections dynamic-permitted + local-ip ${STP_RAN_IP} ${foreach(LOG_OUTPUT)} log ${LOG_OUTPUTn_TYPE} diff --git a/net/templates/run.sh b/net/templates/run.sh index cd0fc72..311cdd9 100755 --- a/net/templates/run.sh +++ b/net/templates/run.sh @@ -81,8 +81,10 @@ #mgw4bsc="strace osmo-mgw -c osmo-mgw-for-bsc.cfg" mgw4bsc="osmo-mgw -c osmo-mgw-for-bsc.cfg" hlr="LD_LIBRARY_PATH=/usr/local/lib gdb -ex run --args osmo-hlr --db-upgrade" -stp="osmo-stp" +stp4cn="osmo-stp -c osmo-stp-cn.cfg" +stp4ran="osmo-stp -c osmo-stp-ran.cfg" bsc="LD_LIBRARY_PATH=/usr/local/lib gdb -ex run --args osmo-bsc -c osmo-bsc.cfg" +bscnat="osmo-bsc-nat" if [ "x${MSC_MNCC}" != "xinternal" ]; then sipcon="osmo-sip-connector -c osmo-sip-connector.cfg" @@ -123,9 +125,23 @@ term "$ggsn" GGSN & PIDS="$PIDS $!" -sleep .2 -term "$stp" STP & -PIDS="$PIDS $!" +if [ "${STP_CN_IP}" = "${STP_RAN_IP}" ]; then + sleep .2 + term "$stp4cn" STP & + PIDS="$PIDS $!" +else + sleep .2 + term "$stp4cn" STP4CN & + PIDS="$PIDS $!" + + sleep .2 + term "$stp4ran" STP4RAN & + PIDS="$PIDS $!" + + sleep .2 + term "$bscnat" BSCNAT & + PIDS="$PIDS $!" +fi sleep .2 term "$hlr" HLR & @@ -199,6 +215,7 @@ killall -9 osmo-stp sudo killall tcpdump killall osmo-ggsn +killall osmo-bsc-nat if [ "x${MSC_MNCC}" != "xinternal" ]; then # 'killall' seems to work only with the shortened name -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I8bfbd00bfeeebc6e1b87a8cd6333212db4380653 Gerrit-Change-Number: 26668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Wed Dec 22 00:29:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 22 Dec 2021 00:29:31 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c27173582e0_2a772b197dcce5f423447f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 28s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 28s] exit ... [ 28s] ### VM INTERACTION START ### [ 31s] [ 12.485122] sysrq: SysRq : Power Off [ 31s] [ 12.488773] reboot: Power down [ 31s] ### VM INTERACTION END ### [ 31s] [ 31s] obs-arm-9 failed "build libosmocore.spec" at Wed Dec 22 00:29:18 UTC 2021. [ 31s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 22 00:31:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 22 Dec 2021 00:31:30 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c271ec78f01_2a772b197dcce5f42347b9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 24s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 24s] exit ... [ 24s] ### VM INTERACTION START ### [ 27s] [ 12.380952] sysrq: SysRq : Power Off [ 27s] [ 12.390767] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] armbuild24 failed "build libosmocore.spec" at Wed Dec 22 00:31:18 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 22 00:32:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 22 Dec 2021 00:32:04 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c27206539f2_2a772b197dcce5f4234890@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 9s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 9s] exit ... [ 9s] ### VM INTERACTION START ### [ 12s] [ 7.415927] sysrq: Power Off [ 12s] [ 7.418309] reboot: Power down [ 12s] ### VM INTERACTION END ### [ 12s] [ 12s] goat15 failed "build libosmocore.spec" at Wed Dec 22 00:32:00 UTC 2021. [ 12s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 22 00:32:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 22 Dec 2021 00:32:04 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c272069fadb_2a772b197dcce5f4234930@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 12s] file /usr/lib/system[ 4.059828] serial8250: too much work for irq4 [ 12s] d/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 12s] exit ... [ 12s] ### VM INTERACTION START ### [ 16s] [ 7.324514] sysrq: SysRq : Power Off [ 16s] [ 7.330428] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] sheep86 failed "build libosmocore.spec" at Wed Dec 22 00:32:02 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 22 00:47:22 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 22 Dec 2021 00:47:22 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61c275abcaa29_2a772b197dcce5f423731@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 311s] #define VERSION "0.2.3" [ 311s] #define STDC_HEADERS 1 [ 311s] #define HAVE_SYS_TYPES_H 1 [ 311s] #define HAVE_SYS_STAT_H 1 [ 311s] #define HAVE_STDLIB_H 1 [ 311s] #define HAVE_STRING_H 1 [ 311s] #define HAVE_MEMORY_H 1 [ 311s] #define HAVE_STRINGS_H 1 [ 311s] #define HAVE_INTTYPES_H 1 [ 311s] #define HAVE_STDINT_H 1 [ 311s] #define HAVE_UNISTD_H 1 [ 311s] #define HAVE_DLFCN_H 1 [ 311s] #define LT_OBJDIR ".libs/" [ 311s] [ 311s] configure: exit 1 [ 311s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 311s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 311s] make[1]: *** [override_dh_auto_configure] Error 2 [ 311s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 311s] debian/rules:45: recipe for target 'build' failed [ 311s] make: *** [build] Error 2 [ 311s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 311s] ### VM INTERACTION START ### [ 314s] [ 288.810860] sysrq: Power Off [ 314s] [ 288.839026] reboot: Power down [ 314s] ### VM INTERACTION END ### [ 314s] [ 314s] cloud122 failed "build osmo-cbc_0.2.3.202112220026.dsc" at Wed Dec 22 00:47:20 UTC 2021. [ 314s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 22 00:48:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 22 Dec 2021 00:48:30 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61c275e53592a_2a772b197dcce5f423741a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 349s] #define HAVE_SYS_TYPES_H 1 [ 349s] #define HAVE_SYS_STAT_H 1 [ 349s] #define HAVE_STDLIB_H 1 [ 349s] #define HAVE_STRING_H 1 [ 349s] #define HAVE_MEMORY_H 1 [ 349s] #define HAVE_STRINGS_H 1 [ 349s] #define HAVE_INTTYPES_H 1 [ 349s] #define HAVE_STDINT_H 1 [ 349s] #define HAVE_UNISTD_H 1 [ 349s] #define HAVE_DLFCN_H 1 [ 349s] #define LT_OBJDIR ".libs/" [ 349s] #define PACKAGE "osmo-remsim" [ 349s] #define VERSION "1.0.0.4-0c832" [ 349s] [ 349s] configure: exit 1 [ 349s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 349s] debian/rules:17: recipe for target 'override_dh_auto_configure' failed [ 349s] make[1]: *** [override_dh_auto_configure] Error 2 [ 349s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 349s] debian/rules:14: recipe for target 'build' failed [ 349s] make: *** [build] Error 2 [ 349s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 349s] ### VM INTERACTION START ### [ 352s] [ 326.630969] sysrq: Power Off [ 352s] [ 326.638703] reboot: Power down [ 352s] ### VM INTERACTION END ### [ 352s] [ 352s] hci-cnode2-m0 failed "build osmo-remsim_1.0.0.4.0c832.202112220026.dsc" at Wed Dec 22 00:48:23 UTC 2021. [ 352s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Dec 22 04:02:34 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 22 Dec 2021 04:02:34 +0000 Subject: Change in osmo-ttcn3-hacks[master]: IuUP_Emulation: Fix frame number wrap-around In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26656 ) Change subject: IuUP_Emulation: Fix frame number wrap-around ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9e69115c49545a7b9797d8f85568d5e91dfb329 Gerrit-Change-Number: 26656 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 22 Dec 2021 04:02:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 09:39:08 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 09:39:08 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Add dotty graphs of BSC + MSC test component hierarchy In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26652 ) Change subject: doc: Add dotty graphs of BSC + MSC test component hierarchy ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b83a7f733eee4e4ab710985ee8dc21315ebebca Gerrit-Change-Number: 26652 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 09:39:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 09:39:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 09:39:20 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Add dotty graph of BTS_Tests component hierarchy In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26653 ) Change subject: doc: Add dotty graph of BTS_Tests component hierarchy ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I42d5d67cae290f4b8b330b7800cb5337a9745ce3 Gerrit-Change-Number: 26653 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 09:39:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 09:39:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 09:39:29 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Re-order ports in RAN_Emulation_CT In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26654 ) Change subject: doc: Re-order ports in RAN_Emulation_CT ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1001601f5bb7c9beb40fd0ddd404c55e3d211608 Gerrit-Change-Number: 26654 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 09:39:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 09:40:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 09:40:15 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Always nnotate codec port types in case of IPL4/UD ports In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26655 ) Change subject: doc: Always nnotate codec port types in case of IPL4/UD ports ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26655/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26655/1//COMMIT_MSG at 7 PS1, Line 7: doc: Always nnotate codec port types in case of IPL4/UD ports annotate -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icee6eeb4a526ff5cbeb8b01df8149c488875455e Gerrit-Change-Number: 26655 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 09:40:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 09:50:41 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 09:50:41 +0000 Subject: Change in libosmocore[master]: conv: Fix the traceback for tail biting codes In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26657 ) Change subject: conv: Fix the traceback for tail biting codes ...................................................................... Patch Set 1: (5 comments) Letting Hoernchen and laforge review this one. I'd be great perhaps having some unit test showing the difference in behavior after the fix. Remember to fix stuff pointed out by the linter if applying. https://gerrit.osmocom.org/c/libosmocore/+/26657/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/26657/1//COMMIT_MSG at 16 PS1, Line 16: Fixes #4508 OS#4508 https://gerrit.osmocom.org/c/libosmocore/+/26657/1/src/conv.c File src/conv.c: https://gerrit.osmocom.org/c/libosmocore/+/26657/1/src/conv.c at 551 PS1, Line 551: for (s=0; sn_states; s++) spaces between s=0 and others. https://gerrit.osmocom.org/c/libosmocore/+/26657/1/src/conv.c at 552 PS1, Line 552: { { in the same line of for. https://gerrit.osmocom.org/c/libosmocore/+/26657/1/src/conv.c at 558 PS1, Line 558: for (i=n-1; i>=0; i--) { spaces between s=0 and others. https://gerrit.osmocom.org/c/libosmocore/+/26657/1/src/conv.c at 579 PS1, Line 579: { { in the same line of for. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I87e51d3880c0fe7bf3d6cd08fd46517a424a230c Gerrit-Change-Number: 26657 Gerrit-PatchSet: 1 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 09:50:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 09:51:40 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 09:51:40 +0000 Subject: Change in osmo-bsc-nat[master]: Add project skeleton In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 ) Change subject: Add project skeleton ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Iae5d37483dcb9db00578d5c9cd1736f08754a65e Gerrit-Change-Number: 26658 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 09:51:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 09:53:28 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 09:53:28 +0000 Subject: Change in osmo-bsc-nat[master]: Add vty interface In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659 ) Change subject: Add vty interface ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I6f2d8d1d62b97be471ebcf1bb14aac0b895833d1 Gerrit-Change-Number: 26659 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 09:53:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 09:54:28 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 09:54:28 +0000 Subject: Change in osmo-bsc-nat[master]: Add command-line options In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26660 ) Change subject: Add command-line options ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I41bca9e1b88bb130870d078ed3f499e39e0bf5d3 Gerrit-Change-Number: 26660 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 09:54:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 09:54:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 09:54:54 +0000 Subject: Change in osmo-bsc-nat[master]: Add signal handler In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26661 ) Change subject: Add signal handler ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I303e9275a2f1f6f2da742089d079ba604ee5a36b Gerrit-Change-Number: 26661 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 09:54:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 09:59:49 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 09:59:49 +0000 Subject: Change in osmo-bsc-nat[master]: Add bsc_nat fsm In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 ) Change subject: Add bsc_nat fsm ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/2/src/osmo-bsc-nat/bsc_nat_fsm.c File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/2/src/osmo-bsc-nat/bsc_nat_fsm.c at 44 PS2, Line 44: break; I usually add "default: OSMO_ASSERT(0);" to all FSMs, specially now during development, in order to catch quickly scenarios which were missed or not envisioned. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 09:59:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 10:02:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 10:02:27 +0000 Subject: Change in libosmocore[master]: select_main: don't poll forever during shutdown In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26663 ) Change subject: select_main: don't poll forever during shutdown ...................................................................... Patch Set 1: Code-Review+1 Letting neels give feedback as he wrote the last stuff about shutting down there. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81c64a7ae440304522c2179c212023a566ddced8 Gerrit-Change-Number: 26663 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 10:02:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 10:04:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 10:04:32 +0000 Subject: Change in libosmo-sccp[master]: src/sccp_scmg: fix typo In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26664 ) Change subject: src/sccp_scmg: fix typo ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ifd6264da2da2e7cc62485dcde9b6c462d4858626 Gerrit-Change-Number: 26664 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 10:04:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 10:05:20 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 10:05:20 +0000 Subject: Change in libosmo-sccp[master]: osmo_ss7_instance_destroy: use for_each_entry_safe In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26665 ) Change subject: osmo_ss7_instance_destroy: use for_each_entry_safe ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ieaec3584375b0e6b943638fe1e50b4d74a627216 Gerrit-Change-Number: 26665 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 10:05:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 10:05:56 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 10:05:56 +0000 Subject: Change in osmo-dev[master]: all.deps, werror.opts: add osmo-bsc-nat In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26666 ) Change subject: all.deps, werror.opts: add osmo-bsc-nat ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ica90826c8bfbf4f295c49702d36e7c88e43f80cd Gerrit-Change-Number: 26666 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 10:05:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 10:06:19 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 10:06:19 +0000 Subject: Change in osmo-dev[master]: net/templates/run.sh: refactor kill logic In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26667 ) Change subject: net/templates/run.sh: refactor kill logic ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26667 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iaf6c175de2edf720009af13eace2b0ef83b0735b Gerrit-Change-Number: 26667 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 10:06:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 10:07:28 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 10:07:28 +0000 Subject: Change in osmo-dev[master]: net: add osmo-bsc-nat In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26668 ) Change subject: net: add osmo-bsc-nat ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I8bfbd00bfeeebc6e1b87a8cd6333212db4380653 Gerrit-Change-Number: 26668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 10:07:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 10:26:08 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 22 Dec 2021 10:26:08 +0000 Subject: Change in osmo-ci[master]: OBS, ttcn3-testsuites: add 2021q4 References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26669 ) Change subject: OBS, ttcn3-testsuites: add 2021q4 ...................................................................... OBS, ttcn3-testsuites: add 2021q4 Related: SYS#5726 Change-Id: I4913218b192cf0cb1fb74b239ced9a0501c2eb48 --- M jobs/ttcn3-testsuites.yml M scripts/common-obs.sh M scripts/osmocom-nightly-packages.sh 3 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/69/26669/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index bcbbab5..113f4cd 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -348,6 +348,29 @@ blocking: "^(ttcn3|TTCN3-.*)-gbproxy-test.*" timer: 30 12 * * * + # centos8 2021q4 (SYS#5726) + - TTCN3-centos-pcu-test-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-pcu-test.*" + timer: 00 13 * * * + - TTCN3-centos-pcu-test-sns-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-pcu-test.*" + timer: 15 13 * * * + - TTCN3-centos-bsc-test-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-bsc-test.*" + timer: 30 13 * * * + - TTCN3-centos-mgw-test-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-mgw-test.*" + timer: 45 13 * * * + - TTCN3-centos-bts-test-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-bts-test.*" + timer: 00 14 * * * + - TTCN3-centos-smlc-test-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-smlc-test.*" + timer: 15 14 * * * + - TTCN3-centos-gbproxy-test-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-gbproxy-test.*" + timer: 30 14 * * * + - job-template: name: '{job-name}' project-type: freestyle diff --git a/scripts/common-obs.sh b/scripts/common-obs.sh index 1a10eb6..e53a7aa 100644 --- a/scripts/common-obs.sh +++ b/scripts/common-obs.sh @@ -4,6 +4,7 @@ FEEDS_ALL=" 2021q1 + 2021q4 latest next nightly diff --git a/scripts/osmocom-nightly-packages.sh b/scripts/osmocom-nightly-packages.sh index 4d21cd7..2a70c31 100755 --- a/scripts/osmocom-nightly-packages.sh +++ b/scripts/osmocom-nightly-packages.sh @@ -16,6 +16,7 @@ # Values for FEED env var. Adjust FEEDS_ALL in common-obs when changing. FEEDS=" 2021q1 + 2021q4 next nightly " -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4913218b192cf0cb1fb74b239ced9a0501c2eb48 Gerrit-Change-Number: 26669 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 10:56:51 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 22 Dec 2021 10:56:51 +0000 Subject: Change in osmo-bsc-nat[master]: Add bsc_nat fsm In-Reply-To: References: Message-ID: Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 to look at the new patch set (#3). Change subject: Add bsc_nat fsm ...................................................................... Add bsc_nat fsm Create the initial FSM that starts and stops two SS7 instances (one for CN, one for RAN), and binds an sccp user to each. Related: OS#2545 Depends: libosmocore 0066f1bdcb328e7ffc846b4746e3e1d02afe4be8 Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 --- M doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg M include/osmocom/bsc_nat/Makefile.am M include/osmocom/bsc_nat/bsc_nat.h A include/osmocom/bsc_nat/bsc_nat_fsm.h M src/osmo-bsc-nat/Makefile.am M src/osmo-bsc-nat/bsc_nat.c A src/osmo-bsc-nat/bsc_nat_fsm.c M src/osmo-bsc-nat/main.c M src/osmo-bsc-nat/vty.c 9 files changed, 342 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/62/26662/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 10:57:32 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 22 Dec 2021 10:57:32 +0000 Subject: Change in osmo-bsc-nat[master]: Add bsc_nat fsm In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 ) Change subject: Add bsc_nat fsm ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/2/src/osmo-bsc-nat/bsc_nat_fsm.c File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/2/src/osmo-bsc-nat/bsc_nat_fsm.c at 44 PS2, Line 44: break; > I usually add "default: OSMO_ASSERT(0);" to all FSMs, specially now during development, in order to [?] Thanks. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 10:57:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 11:46:25 2021 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Wed, 22 Dec 2021 11:46:25 +0000 Subject: Change in libosmocore[master]: conv: Fix the traceback for tail biting codes In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26657 to look at the new patch set (#2). Change subject: conv: Fix the traceback for tail biting codes ...................................................................... conv: Fix the traceback for tail biting codes When picking the end state, looking only at the path metric is highly suboptimal because in a tail biting code, we _know_ that whatever treillis path is correct, it must start and end at the same state. So we only consider path meeting that condition. We know any path that doesn't isn't the right one. We only fallback to only path metric if no path met that condition. Fixes OS#4508 Signed-off-by: Sylvain Munaut Change-Id: I87e51d3880c0fe7bf3d6cd08fd46517a424a230c --- M include/osmocom/core/conv.h M src/conv.c M src/conv_acc.c 3 files changed, 93 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/57/26657/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I87e51d3880c0fe7bf3d6cd08fd46517a424a230c Gerrit-Change-Number: 26657 Gerrit-PatchSet: 2 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 13:19:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 13:19:15 +0000 Subject: Change in libosmocore[master]: include/: Adapt some headers to match contrib/struct_endianess.py format References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26670 ) Change subject: include/: Adapt some headers to match contrib/struct_endianess.py format ...................................................................... include/: Adapt some headers to match contrib/struct_endianess.py format This way the related files are not changed when running the script to generate struct fields for big endian systems. Change-Id: I830e0961331a73f8dceb1a5a1c879798541752fd --- M include/osmocom/gprs/protocol/gsm_08_18.h M include/osmocom/gsm/protocol/gsm_08_58.h M include/osmocom/gsm/protocol/gsm_44_004.h 3 files changed, 27 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/26670/1 diff --git a/include/osmocom/gprs/protocol/gsm_08_18.h b/include/osmocom/gprs/protocol/gsm_08_18.h index 0d002b5..d6f0fe6 100644 --- a/include/osmocom/gprs/protocol/gsm_08_18.h +++ b/include/osmocom/gprs/protocol/gsm_08_18.h @@ -362,13 +362,12 @@ /* RIM PDU Indications * 3GPP TS 48.018, section 11.3.65.0 */ struct bssgp_rim_pdu_ind { -#if OSMO_IS_BIG_ENDIAN - uint8_t reserved:4, - pdu_type_ext:3, - ack_requested:1; -#elif OSMO_IS_LITTLE_ENDIAN +#if OSMO_IS_LITTLE_ENDIAN uint8_t ack_requested:1, pdu_type_ext:3, reserved:4; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t reserved:4, pdu_type_ext:3, ack_requested:1; #endif } __attribute__ ((packed)); diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h index 4937f08..7a527ff 100644 --- a/include/osmocom/gsm/protocol/gsm_08_58.h +++ b/include/osmocom/gsm/protocol/gsm_08_58.h @@ -118,35 +118,29 @@ /* Osmocom specific IE to negotiate repeated ACCH capabilities */ struct abis_rsl_osmo_rep_acch_cap { -#if OSMO_IS_BIG_ENDIAN - uint8_t reserved:1, - rxqual:3, - ul_sacch:1, - dl_sacch:1, - dl_facch_all:1, - dl_facch_cmd:1; -#elif OSMO_IS_LITTLE_ENDIAN +#if OSMO_IS_LITTLE_ENDIAN uint8_t dl_facch_cmd:1, dl_facch_all:1, dl_sacch:1, ul_sacch:1, rxqual:3, reserved:1; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t reserved:1, rxqual:3, ul_sacch:1, dl_sacch:1, dl_facch_all:1, dl_facch_cmd:1; #endif } __attribute__ ((packed)); /* Osmocom specific IE to negotiate temporary overpower of ACCH channels */ struct abis_rsl_osmo_temp_ovp_acch_cap { -#if OSMO_IS_BIG_ENDIAN - uint8_t sacch_enable:1, - facch_enable:1, - rxqual:3, - overpower_db:3; -#elif OSMO_IS_LITTLE_ENDIAN +#if OSMO_IS_LITTLE_ENDIAN uint8_t overpower_db:3, rxqual:3, facch_enable:1, sacch_enable:1; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t sacch_enable:1, facch_enable:1, rxqual:3, overpower_db:3; #endif } __attribute__ ((packed)); @@ -862,10 +856,10 @@ uint8_t u_rxqual:3, reserved_u_rxqual:1, l_rxqual:3, reserved_l_rxqual:1; #elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ uint8_t reserved_l_rxlev:2, l_rxlev:6; uint8_t reserved_u_rxlev:2, u_rxlev:6; - uint8_t reserved_l_rxqual:1, l_rxqual:3, - reserved_u_rxqual:1, u_rxqual:3; + uint8_t reserved_l_rxqual:1, l_rxqual:3, reserved_u_rxqual:1, u_rxqual:3; #endif }__attribute__ ((packed)); @@ -922,6 +916,7 @@ uint8_t pc_interval:5, reserved_pc:3; uint8_t red_step_size:4, inc_step_size:4; #elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ uint8_t reserved_p1:3, p1:5; uint8_t reserved_n1:3, n1:5; uint8_t reserved_p2:3, p2:5; @@ -943,11 +938,12 @@ uint8_t upper_p:5, reserved_upper_p:3; uint8_t upper_n:5, reserved_upper_n:3; #elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ uint8_t reserved_lower_p:3, lower_p:5; uint8_t reserved_lower_n:3, lower_n:5; uint8_t reserved_upper_p:3, upper_p:5; uint8_t reserved_upper_n:3, upper_n:5; - #endif +#endif }__attribute__ ((packed)); struct osmo_preproc_pc_comp { /* Used for Carrier-to-Interference (C/I), in dB: */ @@ -1051,18 +1047,16 @@ }; struct rsl_l1_info { -#if OSMO_IS_BIG_ENDIAN - uint8_t ms_pwr:5, - fpc_epc:1, - srr_sro:1, - reserved:1; - uint8_t ta; -#elif OSMO_IS_LITTLE_ENDIAN +#if OSMO_IS_LITTLE_ENDIAN uint8_t reserved:1, srr_sro:1, fpc_epc:1, ms_pwr:5; uint8_t ta; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t ms_pwr:5, fpc_epc:1, srr_sro:1, reserved:1; + uint8_t ta; #endif } __attribute__ ((packed)); diff --git a/include/osmocom/gsm/protocol/gsm_44_004.h b/include/osmocom/gsm/protocol/gsm_44_004.h index 32ef24e..616e436 100644 --- a/include/osmocom/gsm/protocol/gsm_44_004.h +++ b/include/osmocom/gsm/protocol/gsm_44_004.h @@ -5,17 +5,15 @@ /* TS 44.004 Section 7.1 */ struct gsm_sacch_l1_hdr { -#if OSMO_IS_BIG_ENDIAN - uint8_t reserved:1, - srr_sro:1, - fpc_epc:1, - ms_pwr:5; - uint8_t ta; -#elif OSMO_IS_LITTLE_ENDIAN +#if OSMO_IS_LITTLE_ENDIAN uint8_t ms_pwr:5, fpc_epc:1, srr_sro:1, reserved:1; uint8_t ta; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t reserved:1, srr_sro:1, fpc_epc:1, ms_pwr:5; + uint8_t ta; #endif } __attribute__ ((packed)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I830e0961331a73f8dceb1a5a1c879798541752fd Gerrit-Change-Number: 26670 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 13:19:37 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 13:19:37 +0000 Subject: Change in libosmocore[master]: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/6357 ) Change subject: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data ...................................................................... Patch Set 5: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/6357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 Gerrit-Change-Number: 6357 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 13:19:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 13:34:48 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 13:34:48 +0000 Subject: Change in osmo-hnodeb[master]: Add initial support for IuUP RTP based Transport Layer References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 ) Change subject: Add initial support for IuUP RTP based Transport Layer ...................................................................... Add initial support for IuUP RTP based Transport Layer Use the recently introduced IuUP support in libosmocore to send and receive proper IuUP over RTP instead of regular RTP. The LLSK AUDIO primitives are updated to provide required information back and forth. Depends: libosmocore.git Change-Id Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 Related: SYS#5516 Change-Id: Ie137809e1f91dfd702853c52be97ca79e8604eab --- M TODO-RELEASE M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/rtp.h M src/osmo-hnodeb/llsk_audio.c M src/osmo-hnodeb/rtp.c 6 files changed, 158 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/71/26671/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 9e75c9a..d847efe 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmo-netif >1.1.0 use of netif/sctp.h +libosmocore > 1.6.0 use of core/iuup.h diff --git a/include/osmocom/hnodeb/hnb_prim.h b/include/osmocom/hnodeb/hnb_prim.h index 0b0a545..ba3223d 100644 --- a/include/osmocom/hnodeb/hnb_prim.h +++ b/include/osmocom/hnodeb/hnb_prim.h @@ -186,12 +186,23 @@ }; /* HNB_AUDIO_PRIM_CONN_ESTABLISH, UL */ +#define HNB_MAX_RFCIS 64 +#define HNB_MAX_SUBFLOWS 7 struct hnb_audio_conn_establish_req_param { uint32_t context_id; uint16_t remote_rtp_port; uint8_t spare1; uint8_t remote_rtp_address_type; /* enum u_addr_type */ union u_addr remote_rtp_addr; + /* IuUP related: */ + uint8_t transparent; /* 1=transparent; 0=SMpSDU */ + uint8_t data_pdu_type; + uint16_t supported_versions_mask; /* host byte order */ + uint8_t num_rfci; + uint8_t num_subflows; + uint16_t subflow_sizes[HNB_MAX_RFCIS][HNB_MAX_SUBFLOWS]; + uint8_t IPTIs_present; /* 1=present; 0=not present */ + uint8_t IPTIs[HNB_MAX_RFCIS]; /* values range 0-15, 4 bits */ } __attribute__ ((packed)); /* HNB_AUDIO_PRIM_CONN_ESTABLISH, DL */ @@ -212,6 +223,10 @@ /* HNB_AUDIO_PRIM_CONN_DATA, UL */ struct hnb_audio_conn_data_req_param { uint32_t audio_conn_id; + uint8_t frame_nr; + uint8_t fqc; + uint8_t rfci; + uint8_t spare; uint32_t data_len; /* RTP payload length in bytes */ uint8_t data[0]; /* RTP payload (aka IP packet) */ } __attribute__ ((packed)); @@ -219,6 +234,10 @@ /* HNB_AUDIO_PRIM_CONN_DATA, DL */ struct hnb_audio_conn_data_ind_param { uint32_t audio_conn_id; + uint8_t frame_nr; + uint8_t fqc; + uint8_t rfci; + uint8_t spare; uint32_t data_len; /* RTP payload length in bytes */ uint8_t data[0]; /* RTP payload (aka IP packet) */ } __attribute__ ((packed)); diff --git a/include/osmocom/hnodeb/llsk.h b/include/osmocom/hnodeb/llsk.h index fe1dce1..78eb065 100644 --- a/include/osmocom/hnodeb/llsk.h +++ b/include/osmocom/hnodeb/llsk.h @@ -53,7 +53,8 @@ extern const struct value_string hnb_audio_prim_type_names[]; int llsk_rx_audio(struct hnb *hnb, struct osmo_prim_hdr *oph); -int llsk_audio_tx_conn_data_ind(struct rtp_conn *conn, const uint8_t *payload, uint32_t len); +int llsk_audio_tx_conn_data_ind(struct rtp_conn *conn, uint8_t frame_nr, uint8_t fqc, uint8_t rfci, + const uint8_t *payload, uint32_t len); extern const struct value_string hnb_gtp_prim_type_names[]; int llsk_rx_gtp(struct hnb *hnb, struct osmo_prim_hdr *oph); diff --git a/include/osmocom/hnodeb/rtp.h b/include/osmocom/hnodeb/rtp.h index 8035175..5eaec7b 100644 --- a/include/osmocom/hnodeb/rtp.h +++ b/include/osmocom/hnodeb/rtp.h @@ -18,8 +18,11 @@ */ #pragma once +#include + #include #include +#include struct hnb; struct hnb_ue; @@ -31,9 +34,11 @@ struct osmo_rtp_socket *socket; struct osmo_sockaddr loc_addr; struct osmo_sockaddr rem_addr; + struct osmo_iuup_instance *iui; }; struct rtp_conn *rtp_conn_alloc(struct hnb_ue *ue); void rtp_conn_free(struct rtp_conn *conn); -int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr); +int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr, const struct hnb_audio_conn_establish_req_param *ce_req); +int rtp_conn_tx_data(struct rtp_conn *conn, uint8_t frame_nr, uint8_t fqc, uint8_t rfci, const uint8_t *data, unsigned int data_len); diff --git a/src/osmo-hnodeb/llsk_audio.c b/src/osmo-hnodeb/llsk_audio.c index a600c3c..da54d28 100644 --- a/src/osmo-hnodeb/llsk_audio.c +++ b/src/osmo-hnodeb/llsk_audio.c @@ -101,13 +101,16 @@ } static struct hnb_audio_prim *hnb_audio_makeprim_conn_data_ind(uint32_t audio_conn_id, - const uint8_t *data, - uint32_t data_len) + uint8_t frame_nr, uint8_t fqc, uint8_t rfci, + const uint8_t *data, uint32_t data_len) { struct hnb_audio_prim *audio_prim; audio_prim = hnb_audio_prim_alloc(HNB_AUDIO_PRIM_CONN_DATA, PRIM_OP_INDICATION, data_len); audio_prim->u.conn_data_ind.audio_conn_id = audio_conn_id; + audio_prim->u.conn_data_ind.frame_nr = frame_nr; + audio_prim->u.conn_data_ind.fqc = fqc; + audio_prim->u.conn_data_ind.rfci = rfci; audio_prim->u.conn_data_ind.data_len = data_len; if (data_len) { msgb_put(audio_prim->hdr.msg, data_len); @@ -117,13 +120,15 @@ return audio_prim; } -int llsk_audio_tx_conn_data_ind(struct rtp_conn *conn, const uint8_t *payload, uint32_t len) +int llsk_audio_tx_conn_data_ind(struct rtp_conn *conn, uint8_t frame_nr, uint8_t fqc, uint8_t rfci, + const uint8_t *payload, uint32_t len) { struct hnb_audio_prim *audio_prim; int rc; - LOGUE(conn->ue, DLLSK, LOGL_INFO, "Tx AUDIO-CONN_DATA.ind\n"); - audio_prim = hnb_audio_makeprim_conn_data_ind(conn->id, payload, len); + LOGUE(conn->ue, DLLSK, LOGL_DEBUG, "Tx AUDIO-CONN_DATA.ind conn_id=%u fn=%u fqc=%u rfci=%u data_len=%u\n", + conn->id, frame_nr, fqc, rfci, len); + audio_prim = hnb_audio_makeprim_conn_data_ind(conn->id, frame_nr, fqc, rfci, payload, len); if ((rc = osmo_prim_srv_send(conn->ue->hnb->llsk, audio_prim->hdr.msg)) < 0) LOGUE(conn->ue, DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_DATA.ind\n"); return rc; @@ -186,7 +191,7 @@ /* Create the socket: */ conn = rtp_conn_alloc(ue); - if ((rc = rtp_conn_setup(conn, &rem_osa)) < 0) { + if ((rc = rtp_conn_setup(conn, &rem_osa, ce_req)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: Failed to set up audio socket rem_addr=%s\n", rem_addrstr); return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); @@ -248,14 +253,8 @@ return -EINVAL; } - /* TODO: transmit data_req->data through RTP/Iu-UP socket */ - rc = osmo_rtp_send_frame_ext(conn->socket, data_req->data, - data_req->data_len, GSM_RTP_DURATION, false); - if (rc < 0) { - LOGUE(conn->ue, DLLSK, LOGL_ERROR, - "Rx AUDIO-CONN_DATA.req: Failed sending RTP frame! id=%u data_len=%u\n", - data_req->audio_conn_id, data_req->data_len); - } + /* Transmit data_req->data through RTP/Iu-UP socket */ + rc = rtp_conn_tx_data(conn, data_req->frame_nr, data_req->fqc, data_req->rfci, data_req->data, data_req->data_len); return rc; } diff --git a/src/osmo-hnodeb/rtp.c b/src/osmo-hnodeb/rtp.c index 41fb668..837a555 100644 --- a/src/osmo-hnodeb/rtp.c +++ b/src/osmo-hnodeb/rtp.c @@ -22,14 +22,88 @@ #include #include +#include +#include #include #include #include +#define HNB_IUUP_MSGB_SIZE 4096 + +static struct osmo_iuup_rnl_prim *llsk_audio_ce_to_iuup_rnl_cfg(void *ctx, const struct hnb_audio_conn_establish_req_param *ce_req) +{ + struct osmo_iuup_rnl_prim *irp; + struct osmo_iuup_rnl_config *cfg; + unsigned int i; + + irp = osmo_iuup_rnl_prim_alloc(ctx, OSMO_IUUP_RNL_CONFIG, PRIM_OP_REQUEST, HNB_IUUP_MSGB_SIZE); + cfg = &irp->u.config; + cfg->transparent = !!ce_req->transparent; + cfg->active = true; + cfg->data_pdu_type = ce_req->data_pdu_type; + cfg->supported_versions_mask = ce_req->supported_versions_mask; + cfg->num_rfci = ce_req->num_rfci; + cfg->num_subflows = ce_req->num_subflows; + OSMO_ASSERT(cfg->num_rfci <= ARRAY_SIZE(cfg->subflow_sizes)); + OSMO_ASSERT(cfg->num_subflows <= ARRAY_SIZE(cfg->subflow_sizes[0])); + for (i = 0; i< cfg->num_rfci; i++) + memcpy(&cfg->subflow_sizes[i][0], &ce_req->subflow_sizes[i][0], cfg->num_subflows*sizeof(uint16_t)); + cfg->IPTIs_present = ce_req->IPTIs_present; + if (cfg->IPTIs_present) + memcpy(cfg->IPTIs, ce_req->IPTIs, cfg->num_rfci); + + cfg->t_init = (struct osmo_iuup_rnl_config_timer){ .t_ms = IUUP_TIMER_INIT_T_DEFAULT, .n_max = IUUP_TIMER_INIT_N_DEFAULT }; + cfg->t_ta = (struct osmo_iuup_rnl_config_timer){ .t_ms = IUUP_TIMER_TA_T_DEFAULT, .n_max = IUUP_TIMER_TA_N_DEFAULT }; + cfg->t_rc = (struct osmo_iuup_rnl_config_timer){ .t_ms = IUUP_TIMER_RC_T_DEFAULT, .n_max = IUUP_TIMER_RC_N_DEFAULT }; + + return irp; +} + +static int _iuup_user_prim_cb(struct osmo_prim_hdr *oph, void *ctx) +{ + struct rtp_conn *conn = (struct rtp_conn *)ctx; + struct osmo_iuup_rnl_prim *irp = (struct osmo_iuup_rnl_prim *)oph; + struct msgb *msg = oph->msg; + int rc; + + switch (OSMO_PRIM_HDR(&irp->oph)) { + case OSMO_PRIM(OSMO_IUUP_RNL_DATA, PRIM_OP_INDICATION): + rc = llsk_audio_tx_conn_data_ind(conn, irp->u.data.frame_nr, irp->u.data.fqc, + irp->u.data.rfci, msgb_l3(msg), msgb_l3len(msg)); + break; + default: + LOGUE(conn->ue, DRTP, LOGL_NOTICE, "Rx Unknown prim=%u op=%u from IuUP layer", + irp->oph.primitive, irp->oph.operation); + rc = -1; + } + + msgb_free(msg); + return rc; +} + +static int _iuup_transport_prim_cb(struct osmo_prim_hdr *oph, void *ctx) +{ + struct rtp_conn *conn = (struct rtp_conn *)ctx; + struct msgb *msg = oph->msg; + int rc; + + rc = osmo_rtp_send_frame_ext(conn->socket, msgb_l2(msg), msgb_l2len(msg), + GSM_RTP_DURATION, false); + if (rc < 0) { + LOGUE(conn->ue, DLLSK, LOGL_ERROR, + "Rx IuUP Transport UNITDATA.req: Failed sending RTP frame! id=%u data_len=%u\n", + conn->id, msgb_l2len(msg)); + } + + msgb_free(msg); + return rc; +} + struct rtp_conn *rtp_conn_alloc(struct hnb_ue *ue) { struct rtp_conn *conn; + char iuup_id[64]; conn = talloc_zero(ue, struct rtp_conn); if (!conn) @@ -37,6 +111,11 @@ conn->ue = ue; + snprintf(iuup_id, sizeof(iuup_id), "ue-%u", conn->ue->conn_id); + conn->iui = osmo_iuup_instance_alloc(conn, iuup_id); + osmo_iuup_instance_set_user_prim_cb(conn->iui, _iuup_user_prim_cb, conn); + osmo_iuup_instance_set_transport_prim_cb(conn->iui, _iuup_transport_prim_cb, conn); + llist_add(&conn->list, &ue->conn_cs.conn_list); return conn; @@ -51,6 +130,10 @@ osmo_rtp_socket_free(conn->socket); conn->socket = NULL; } + if (conn->iui) { + osmo_iuup_instance_free(conn->iui); + conn->iui = NULL; + } llist_del(&conn->list); talloc_free(conn); } @@ -158,13 +241,23 @@ uint32_t timestamp, bool marker) { struct rtp_conn *conn = (struct rtp_conn *)rs->priv; + struct osmo_iuup_tnl_prim *itp; + int rc; LOGUE(conn->ue, DRTP, LOGL_DEBUG, "Rx RTP seq=%u ts=%u M=%u pl=%p len=%u\n", seq_number, timestamp, marker, rtp_pl, rtp_pl_len); - llsk_audio_tx_conn_data_ind(conn, rtp_pl, rtp_pl_len); + + itp = osmo_iuup_tnl_prim_alloc(conn, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_INDICATION, HNB_IUUP_MSGB_SIZE); + itp->oph.msg->l2h = msgb_put(itp->oph.msg, rtp_pl_len); + memcpy(itp->oph.msg->l2h, rtp_pl, rtp_pl_len); + rc = osmo_iuup_tnl_prim_up(conn->iui, itp); + if (rc < 0) + LOGUE(conn->ue, DRTP, LOGL_NOTICE, + "Failed passing rx rtp up to IuUP layer: %d\n", rc); } -int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr) +int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr, + const struct hnb_audio_conn_establish_req_param *ce_req) { int rc; char cname[256+4]; @@ -173,6 +266,7 @@ const char *local_wildcard_ipstr = "0.0.0.0"; char remote_ipstr[INET6_ADDRSTRLEN]; uint16_t remote_port; + struct osmo_iuup_rnl_prim *irp; struct hnb_ue *ue = conn->ue; struct hnb *hnb = ue->hnb; @@ -231,9 +325,30 @@ goto free_ret; } + /* Now configure the IuUP layer: */ + irp = llsk_audio_ce_to_iuup_rnl_cfg(conn, ce_req); + rc = osmo_iuup_rnl_prim_down(conn->iui, irp); + if (rc < 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Failed setting up IuUP layer: %d\n", rc); + goto free_ret; + } + return rc; free_ret: osmo_rtp_socket_free(conn->socket); conn->socket = NULL; return rc; } + +int rtp_conn_tx_data(struct rtp_conn *conn, uint8_t frame_nr, uint8_t fqc, uint8_t rfci, const uint8_t *data, unsigned int data_len) +{ + struct osmo_iuup_rnl_prim *irp; + + irp = osmo_iuup_rnl_prim_alloc(conn, OSMO_IUUP_RNL_DATA, PRIM_OP_REQUEST, HNB_IUUP_MSGB_SIZE); + irp->u.data.rfci = rfci; + irp->u.data.frame_nr = frame_nr; + irp->u.data.fqc = fqc; + irp->oph.msg->l3h = msgb_put(irp->oph.msg, data_len); + memcpy(irp->oph.msg->l3h, data, data_len); + return osmo_iuup_rnl_prim_down(conn->iui, irp); +} -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ie137809e1f91dfd702853c52be97ca79e8604eab Gerrit-Change-Number: 26671 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 13:38:57 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 13:38:57 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Updates in HNBLLIF and HNBGW_COnnectioNHandler to support and... References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26672 ) Change subject: hnodeb: Updates in HNBLLIF and HNBGW_COnnectioNHandler to support and test IuUP ...................................................................... hnodeb: Updates in HNBLLIF and HNBGW_COnnectioNHandler to support and test IuUP Depends: osmo-hnodeb.git Change-Id Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 Related: SYS#5516 Change-Id: I19612fce8190dfe14f98d346adb5db4e1c2a08d9 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 4 files changed, 116 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/26672/1 diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn index a3ff32f..ac280b0 100644 --- a/hnodeb/HNBGW_ConnectionHandler.ttcn +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -248,13 +248,14 @@ } /* Initialize and start the RTP emulation component for a ConnHdlr */ -function f_HNBGW_rtpem_activate(inout octetstring payload, - HostName remote_host, - PortNumber remote_port, - RtpemConfig cfg := c_RtpemDefaultCfg, - RtpemMode mode := RTPEM_MODE_BIDIR) +function f_HNBGW_rtpem_activate(inout octetstring payload) runs on HNBGW_ConnHdlr { - /* Step 0: initialize, connect and start the emulation component */ + /* Initialize, connect and start the emulation component */ + var RtpemConfig cfg := c_RtpemDefaultCfg; + cfg.iuup_mode := true; + cfg.iuup_tx_init := false; + cfg.tx_payload_type := 96; + vc_RTPEM := RTP_Emulation_CT.create(testcasename() & "-RTPEM") alive; map(vc_RTPEM:RTP, system:RTP); map(vc_RTPEM:RTCP, system:RTCP); @@ -274,11 +275,15 @@ /* Bind the RTP emulation to the configured address */ f_rtpem_bind(RTPEM_CTRL, g_pars.hnbgw_addr, g_pars.hnbgw_rtp_port); - /* Connect to the IUT's address/port parsed from CRCX ACK */ - f_rtpem_connect(RTPEM_CTRL, remote_host, remote_port); - /* Set the given RTP emulation mode */ - f_rtpem_mode(RTPEM_CTRL, mode); + f_rtpem_mode(RTPEM_CTRL, RTPEM_MODE_RXONLY); +} + +function f_HNBGW_rtpem_connect(HostName remote_host, PortNumber remote_port) +runs on HNBGW_ConnHdlr { + f_rtpem_connect(RTPEM_CTRL, remote_host, remote_port); + /* Set the given RTP emulation mode */ + f_rtpem_mode(RTPEM_CTRL, RTPEM_MODE_BIDIR); } } diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index c801ee6..a58e203 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -56,6 +56,8 @@ import from GTP_Templates all; import from GTP_Emulation all; +import from IuUP_Types all; + modulepar { /* IP address at which the HNodeB can be reached */ charstring mp_hnodeb_ip := "127.0.0.1"; @@ -297,6 +299,10 @@ var PortNumber hnodeb_rtp_port; timer Tu; var uint32_t audio_conn_id; + var IuUP_FQC fqc := IuUP_FQC_GOOD; + + rtp_payload := f_rnd_octstring(6); + f_HNBGW_rtpem_activate(rtp_payload); f_handle_hnbap_hnb_register_req(); @@ -326,11 +332,22 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "hnodeb RTP local address doesn't match expectations"); } hnodeb_rtp_port := sd.data.u.audio.u.conn_establish.u.cnf.local_rtp_port; - rtp_payload := f_rnd_octstring(6); - f_HNBGW_rtpem_activate(rtp_payload, hnodeb_rtp_addr, hnodeb_rtp_port); + f_HNBGW_rtpem_connect(hnodeb_rtp_addr, hnodeb_rtp_port); + + /* We should eventually receive some RTP/IUUP from the HNBGW once Init phase goes on: */ + Tu.start(2.0); + alt { + [] LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_DATA_IND(audio_conn_id, ?, enum2int(fqc), ?, rtp_payload))); + [] Tu.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for Downlink speech frames"); + } + } + Tu.stop; + f_rtpem_mode(RTPEM_CTRL, RTPEM_MODE_RXONLY); + /* Make sure that Uplink frames are received at the HNBGW */ RTPEM_DATA.clear; - LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_DATA_REQ(audio_conn_id, rtp_payload))); + LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_DATA_REQ(audio_conn_id, 1, enum2int(fqc), 0, rtp_payload))); Tu.start(2.0); alt { [] RTPEM_DATA.receive(PDU_RTP:?) -> value rtp_pdu { @@ -345,10 +362,9 @@ } } Tu.stop; - /* We should also have received some RTP from the HNBGW: */ - LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_DATA_IND(audio_conn_id, rtp_payload))); f_rtpem_mode(RTPEM_CTRL, RTPEM_MODE_NONE); + f_sleep(0.5); /* give some time to RTP_Emu to stop sending RTP packets... */ LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_RELEASE_REQ(audio_conn_id))); diff --git a/library/HNBLLIF_Templates.ttcn b/library/HNBLLIF_Templates.ttcn index fc82a72..6aee659 100644 --- a/library/HNBLLIF_Templates.ttcn +++ b/library/HNBLLIF_Templates.ttcn @@ -251,11 +251,42 @@ /********************** * AUDIO SAPI **********************/ +const HNBLLIF_AUDIO_IPTIs IPTIs_default := { + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 +}; + +private function f_subflow_sizes_default() return HNBLLIF_AUDIO_SubflowSizes +{ + var HNBLLIF_AUDIO_SubflowSizes ss; + + for (var integer i := 0; i < HNBLLIF_MAX_RFCIS; i := i + 1) { + for (var integer j := 0; j < HNBLLIF_MAX_SUBFLOWS; j := j + 1) { + ss[i][j] := 0; + } + } + + ss[0][0] := 81; ss[0][1] := 103; ss[0][2] := 60; + ss[1][0] := 39; ss[1][1] := 0; ss[1][2] := 0; + ss[2][0] := 0; ss[2][1] := 0; ss[2][2] := 0; + + return ss; +} template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_ESTABLISH_REQ(template (value) uint32_t context_id, template (value) uint16_t remote_rtp_port, template (value) HNBLLIF_AddrType remote_rtp_address_type, - template (value) HNBLLIF_Addr remote_addr) := { + template (value) HNBLLIF_Addr remote_addr, + template (value) uint8_t transparent := 0, + template (value) uint8_t data_pdu_type := 0, + template (value) uint16_t supported_versions_mask := 3, + template (value) uint8_t num_rfci := 3, + template (value) uint8_t num_subflows := 3, + template (value) HNBLLIF_AUDIO_SubflowSizes subflow_sizes := f_subflow_sizes_default(), + template (value) uint8_t IPTIs_present := 0, + template (value) HNBLLIF_AUDIO_IPTIs IPTIs := IPTIs_default) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { audio := { @@ -269,7 +300,15 @@ remote_rtp_port := remote_rtp_port, reserved := 0, remote_rtp_address_type := remote_rtp_address_type, - remote_addr := remote_addr + remote_addr := remote_addr, + transparent := transparent, + data_pdu_type := data_pdu_type, + supported_versions_mask := supported_versions_mask, + num_rfci := num_rfci, + num_subflows := num_subflows, + subflow_sizes := subflow_sizes, + IPTIs_present := IPTIs_present, + IPTIs := IPTIs } } } @@ -327,7 +366,10 @@ } template (present) HNBLLIF_Message tr_HNBLLIF_AUDIO_CONN_DATA_IND(template (present) uint32_t audio_conn_id := ?, - template (present) octetstring data := ?) := { + template (present) uint8_t frame_nr := ?, + template (present) uint8_t fqc := ?, + template (present) uint8_t rfci := ?, + template (present) octetstring data := ?) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { audio := { @@ -338,6 +380,10 @@ u := { ind := { audio_conn_id := audio_conn_id, + frame_nr := frame_nr, + fqc := fqc, + rfci := rfci, + spare := 0, data_len := ?, data := data } @@ -349,6 +395,9 @@ } template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_DATA_REQ(template (value) uint32_t audio_conn_id, + template (value) uint8_t frame_nr, + template (value) uint8_t fqc, + template (value) uint8_t rfci, template (value) octetstring data) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { @@ -360,6 +409,10 @@ u := { req := { audio_conn_id := audio_conn_id, + frame_nr := frame_nr, + fqc := fqc, + rfci := rfci, + spare := 0, data_len := lengthof(data), data := data } diff --git a/library/HNBLLIF_Types.ttcn b/library/HNBLLIF_Types.ttcn index a3a6c4c..fa44f11 100644 --- a/library/HNBLLIF_Types.ttcn +++ b/library/HNBLLIF_Types.ttcn @@ -241,14 +241,28 @@ HNBLL_IF_AUDIO_MSG_CONN_DATA ('0002'O) } with { variant "FIELDLENGTH(16)" }; +const integer HNBLLIF_MAX_RFCIS := 64; +const integer HNBLLIF_MAX_SUBFLOWS := 7; +type record length(HNBLLIF_MAX_RFCIS) of uint8_t HNBLLIF_AUDIO_IPTIs; +type record length(HNBLLIF_MAX_SUBFLOWS) of uint16_t HNBLLIF_AUDIO_RFCI_SubflowSizes; +type record length(HNBLLIF_MAX_RFCIS) of HNBLLIF_AUDIO_RFCI_SubflowSizes HNBLLIF_AUDIO_SubflowSizes; + /* CONN_ESTABLISH */ type record HNBLLIF_AUDIO_conn_establish_req { uint32_t context_id, uint16_t remote_rtp_port, uint8_t reserved, HNBLLIF_AddrType remote_rtp_address_type, - HNBLLIF_Addr remote_addr -} with { variant "" }; + HNBLLIF_Addr remote_addr, + uint8_t transparent, /* 1=transparent; 0=SMpSDU */ + uint8_t data_pdu_type, + uint16_t supported_versions_mask, /* host byte order */ + uint8_t num_rfci, + uint8_t num_subflows, + HNBLLIF_AUDIO_SubflowSizes subflow_sizes, + uint8_t IPTIs_present, /* 1=present; 0=not present */ + HNBLLIF_AUDIO_IPTIs IPTIs /* values range 0-15, 4 bits */ +} with { variant "" }; type record HNBLLIF_AUDIO_conn_establish_cnf { uint32_t context_id, @@ -292,12 +306,20 @@ /* CONN_DATA */ type record HNBLLIF_AUDIO_conn_data_ind { uint32_t audio_conn_id, + uint8_t frame_nr, + uint8_t fqc, /* enumerated IuUP_FQC */ + uint8_t rfci, + uint8_t spare, uint32_t data_len, octetstring data /* RANAP message */ } with { variant (data_len) "LENGTHTO (data)" }; type record HNBLLIF_AUDIO_conn_data_req { uint32_t audio_conn_id, + uint8_t frame_nr, + uint8_t fqc, /* enumerated IuUP_FQC */ + uint8_t rfci, + uint8_t spare, uint32_t data_len, octetstring data /* RANAP message */ } with { variant (data_len) "LENGTHTO (data)" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I19612fce8190dfe14f98d346adb5db4e1c2a08d9 Gerrit-Change-Number: 26672 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 13:55:21 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 13:55:21 +0000 Subject: Change in libosmocore[master]: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#6) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/6357 ) Change subject: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data ...................................................................... Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data Only support for SMpSDU mode is introduced in this commit. Not supported explicit list: - Transparent mode - ATM/AAL2 based Transport layer - GTP-U based Transport Layer - Iu Rate Control procedure - Time Alignment procedure APIs are provided to allocate the primitives properly inside the related msgb. This way primitives can be placed in the headroom, leaving the data part of the msgb for the IuUP payload, hence allowing re-use of the msgb and 0 copy of IuUP payload when forwarding data over RNL<->TNL. Since RNL and TNL primitives relu struct osmo_prim_header, which is not packed, they cannot be set to packed, and hence proper memory alignment in the msgb must be done to avoid misaligned accesses (Asan errors about it otherwise). Related: SYS#5516 Change-Id: Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 --- M include/Makefile.am M include/osmocom/core/logging.h A include/osmocom/gsm/iuup.h M include/osmocom/gsm/prim.h A include/osmocom/gsm/protocol/gsm_25_415.h M src/gsm/Makefile.am A src/gsm/iuup.c M src/gsm/libosmogsm.map M src/logging.c M tests/Makefile.am A tests/iuup/iuup_test.c A tests/iuup/iuup_test.ok M tests/logging/logging_vty_test.vty M tests/testsuite.at 14 files changed, 1,978 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/57/6357/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/6357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 Gerrit-Change-Number: 6357 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:01:04 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 14:01:04 +0000 Subject: Change in libosmocore[master]: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#7) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/6357 ) Change subject: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data ...................................................................... Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data Only support for SMpSDU mode is introduced in this commit. Not supported explicit list: - Transparent mode - ATM/AAL2 based Transport layer - GTP-U based Transport Layer - Iu Rate Control procedure - Time Alignment procedure APIs are provided to allocate the primitives properly inside the related msgb. This way primitives can be placed in the headroom, leaving the data part of the msgb for the IuUP payload, hence allowing re-use of the msgb and 0 copy of IuUP payload when forwarding data over RNL<->TNL. Since RNL and TNL primitives relu struct osmo_prim_header, which is not packed, they cannot be set to packed, and hence proper memory alignment in the msgb must be done to avoid misaligned accesses (Asan errors about it otherwise). Related: SYS#5516 Change-Id: Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 --- M include/Makefile.am M include/osmocom/core/logging.h A include/osmocom/gsm/iuup.h M include/osmocom/gsm/prim.h A include/osmocom/gsm/protocol/gsm_25_415.h M src/gsm/Makefile.am A src/gsm/iuup.c M src/gsm/libosmogsm.map M src/logging.c M tests/Makefile.am A tests/iuup/iuup_test.c A tests/iuup/iuup_test.ok M tests/logging/logging_vty_test.vty M tests/testsuite.at 14 files changed, 1,980 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/57/6357/7 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/6357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 Gerrit-Change-Number: 6357 Gerrit-PatchSet: 7 Gerrit-Owner: laforge Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:12:49 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 22 Dec 2021 14:12:49 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore TRACING_LOGGING References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26673 ) Change subject: lint: checkpatch_osmo: ignore TRACING_LOGGING ...................................................................... lint: checkpatch_osmo: ignore TRACING_LOGGING Don't recommend to use ftrace instead of using __func__ inside printf. This only applies to the linux kernel, not to the Osmocom code base. Related: OS#5087 Related: https://gerrit.osmocom.org/c/libosmocore/+/6357 Change-Id: Ied23be32d3371a8b9ac9938a336474f71e7a3ccd --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/73/26673/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index d1ce63a..8514f9c 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -70,6 +70,7 @@ # * SPDX_LICENSE_TAG: we don't place it on line 1 # * SPLIT_STRING: we do split long messages over multiple lines # * STRING_FRAGMENTS: sometimes used intentionally to improve readability +# * TRACING_LOGGING: recommends to use kernel's internal ftrace instead of printf("%s()\n", __func__) # * TRAILING_STATEMENTS: not followed, e.g. 'while (osmo_select_main_ctx(1) > 0);' is put in one line # * UNNECESSARY_BREAK: not followed (see https://gerrit.osmocom.org/c/libosmo-netif/+/26429) # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) @@ -108,6 +109,7 @@ --ignore SPDX_LICENSE_TAG \ --ignore SPLIT_STRING \ --ignore STRING_FRAGMENTS \ + --ignore TRACING_LOGGING \ --ignore TRAILING_STATEMENTS \ --ignore UNNECESSARY_BREAK \ --ignore UNNECESSARY_INT \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ied23be32d3371a8b9ac9938a336474f71e7a3ccd Gerrit-Change-Number: 26673 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:13:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:13:56 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore TRACING_LOGGING In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26673 ) Change subject: lint: checkpatch_osmo: ignore TRACING_LOGGING ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ied23be32d3371a8b9ac9938a336474f71e7a3ccd Gerrit-Change-Number: 26673 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 22 Dec 2021 14:13:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:13:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:13:57 +0000 Subject: Change in osmo-ci[master]: lint: checkpatch_osmo: ignore TRACING_LOGGING In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26673 ) Change subject: lint: checkpatch_osmo: ignore TRACING_LOGGING ...................................................................... lint: checkpatch_osmo: ignore TRACING_LOGGING Don't recommend to use ftrace instead of using __func__ inside printf. This only applies to the linux kernel, not to the Osmocom code base. Related: OS#5087 Related: https://gerrit.osmocom.org/c/libosmocore/+/6357 Change-Id: Ied23be32d3371a8b9ac9938a336474f71e7a3ccd --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index d1ce63a..8514f9c 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -70,6 +70,7 @@ # * SPDX_LICENSE_TAG: we don't place it on line 1 # * SPLIT_STRING: we do split long messages over multiple lines # * STRING_FRAGMENTS: sometimes used intentionally to improve readability +# * TRACING_LOGGING: recommends to use kernel's internal ftrace instead of printf("%s()\n", __func__) # * TRAILING_STATEMENTS: not followed, e.g. 'while (osmo_select_main_ctx(1) > 0);' is put in one line # * UNNECESSARY_BREAK: not followed (see https://gerrit.osmocom.org/c/libosmo-netif/+/26429) # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) @@ -108,6 +109,7 @@ --ignore SPDX_LICENSE_TAG \ --ignore SPLIT_STRING \ --ignore STRING_FRAGMENTS \ + --ignore TRACING_LOGGING \ --ignore TRAILING_STATEMENTS \ --ignore UNNECESSARY_BREAK \ --ignore UNNECESSARY_INT \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ied23be32d3371a8b9ac9938a336474f71e7a3ccd Gerrit-Change-Number: 26673 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:14:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:14:35 +0000 Subject: Change in libosmocore[master]: include/: Adapt some headers to match contrib/struct_endianess.py format In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26670 ) Change subject: include/: Adapt some headers to match contrib/struct_endianess.py format ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I830e0961331a73f8dceb1a5a1c879798541752fd Gerrit-Change-Number: 26670 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 22 Dec 2021 14:14:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:16:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:16:35 +0000 Subject: Change in libosmocore[master]: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/6357 ) Change subject: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/6357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 Gerrit-Change-Number: 6357 Gerrit-PatchSet: 7 Gerrit-Owner: laforge Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:16:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:20:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:20:29 +0000 Subject: Change in libosmocore[master]: conv: Fix the traceback for tail biting codes In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26657 ) Change subject: conv: Fix the traceback for tail biting codes ...................................................................... Patch Set 2: Code-Review+1 Excellent work! I'm wondering if it would it make sense to add some unit tests to avoid future regressions? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I87e51d3880c0fe7bf3d6cd08fd46517a424a230c Gerrit-Change-Number: 26657 Gerrit-PatchSet: 2 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:20:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:23:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:23:52 +0000 Subject: Change in osmo-hnodeb[master]: Add initial support for IuUP RTP based Transport Layer In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 ) Change subject: Add initial support for IuUP RTP based Transport Layer ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671/1/include/osmocom/hnodeb/hnb_prim.h File include/osmocom/hnodeb/hnb_prim.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671/1/include/osmocom/hnodeb/hnb_prim.h at 200 PS1, Line 200: supported_versions_mask should we really pass this low-level detail/decision to the SAP/lower-layer? Should we even bother to support anything but V2? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ie137809e1f91dfd702853c52be97ca79e8604eab Gerrit-Change-Number: 26671 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 22 Dec 2021 14:23:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:24:27 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:24:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Add dotty graphs of BSC + MSC test component hierarchy In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26652 ) Change subject: doc: Add dotty graphs of BSC + MSC test component hierarchy ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b83a7f733eee4e4ab710985ee8dc21315ebebca Gerrit-Change-Number: 26652 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:24:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:24:31 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:24:31 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Add dotty graph of BTS_Tests component hierarchy In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26653 ) Change subject: doc: Add dotty graph of BTS_Tests component hierarchy ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I42d5d67cae290f4b8b330b7800cb5337a9745ce3 Gerrit-Change-Number: 26653 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:24:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:24:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:24:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Re-order ports in RAN_Emulation_CT In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26654 ) Change subject: doc: Re-order ports in RAN_Emulation_CT ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1001601f5bb7c9beb40fd0ddd404c55e3d211608 Gerrit-Change-Number: 26654 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:24:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:24:55 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:24:55 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Always annotate codec port types in case of IPL4/UD ports In-Reply-To: References: Message-ID: Hello Jenkins Builder, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26655 to look at the new patch set (#2). Change subject: doc: Always annotate codec port types in case of IPL4/UD ports ...................................................................... doc: Always annotate codec port types in case of IPL4/UD ports Change-Id: Icee6eeb4a526ff5cbeb8b01df8149c488875455e --- M doc/bsc_tests_aoip.dot M doc/bts_tests.dot M doc/msc_tests_aoip.dot 3 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/26655/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icee6eeb4a526ff5cbeb8b01df8149c488875455e Gerrit-Change-Number: 26655 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:24:58 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:24:58 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Always annotate codec port types in case of IPL4/UD ports In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26655 ) Change subject: doc: Always annotate codec port types in case of IPL4/UD ports ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icee6eeb4a526ff5cbeb8b01df8149c488875455e Gerrit-Change-Number: 26655 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:24:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:25:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:25:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Add dotty graphs of the component hierarchy for Gb and RAN In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26650 ) Change subject: Add dotty graphs of the component hierarchy for Gb and RAN ...................................................................... Add dotty graphs of the component hierarchy for Gb and RAN These graphs show the component hierarchy and which ports of which component are connected where. Change-Id: I79badbcdbbf03d69de3a1a18241c7a9537c161bf --- A doc/gb_stack_fr.dot A doc/gb_stack_ip.dot A doc/ran_emulation_aoip.dot A doc/ran_emulation_sccplite.dot 4 files changed, 169 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/doc/gb_stack_fr.dot b/doc/gb_stack_fr.dot new file mode 100644 index 0000000..f69a264 --- /dev/null +++ b/doc/gb_stack_fr.dot @@ -0,0 +1,48 @@ +digraph G { + rankdir = LR; + label = "Gb protocol stack with NS over FR"; + + "BSSGP_BVC_CT" [ + shape = "record" + label = " BSSGP_BVC_CT | BSSGP_SP | BSSGP_SP_SIG | BSSGP_PROC | GLOBAL | MGMT | BVC" + ] + + "BSSGP_CT" [ + shape = "record" + label = " BSSGP_CT | PROC | GLOBAL | RIM | MGMT | BVC | BSCP" + ] + + "NS_CT" [ + shape = "record" + label = " NS_CT | NS_SP | NSVC | NS_CTRL | NSIP_PROC" + ] + + "NSVC_CT" [ + shape = "record" + label = " NSVC_CT | NS_SP | NSCP" + ] + + "NS_Provider_FR_CT" [ + shape = "record" + label = " NS_PRovider_FR_CT | NSE | FR | FR_PROC" + ] + + "FR_Emulation_CT" [ + shape = "record" + label = " FR_Emulation_CT | CLIENT | PROC | FR" + ] + + "system" [ + shape = "record" + label = " system | FR" + ] + + "BSSGP_BVC_CT":BVC -> "BSSGP_CT":BVC + "BSSGP_CT":BSCP -> "NS_CT":NS_SP + + "NS_CT":NSVC -> "NSVC_CT":NS_SP + "NSVC_CT":NSCP -> "NS_Provider_FR_CT":NSE + "NS_Provider_FR_CT":FR -> "FR_Emulation_CT":CLIENT + "NS_Provider_FR_CT":FR_PROC -> "FR_Emulation_CT":PROC + "FR_Emulation_CT":FR -> "system":FR +} diff --git a/doc/gb_stack_ip.dot b/doc/gb_stack_ip.dot new file mode 100644 index 0000000..0c54c78 --- /dev/null +++ b/doc/gb_stack_ip.dot @@ -0,0 +1,43 @@ +digraph G { + rankdir = LR; + label = "Gb protocol stack with NS over IP"; + + "BSSGP_BVC_CT" [ + shape = "record" + label = " BSSGP_BVC_CT | BSSGP_SP | BSSGP_SP_SIG | BSSGP_PROC | GLOBAL | MGMT | BVC" + ] + + "BSSGP_CT" [ + shape = "record" + label = " BSSGP_CT | PROC | GLOBAL | RIM | MGMT | BVC | BSCP" + ] + + "NS_CT" [ + shape = "record" + label = " NS_CT | NS_SP | NSVC | NS_CTRL | NSIP_PROC" + ] + + "NSVC_CT" [ + shape = "record" + label = " NSVC_CT | NS_SP | NSCP" + ] + + "NS_Provider_IPL4_CT" [ + shape = "record" + label = " NS_Provider_IPL4_CT | NSE | NSVC | IPL4 | PROC" + ] + + "system" [ + shape = "record" + label = " system | IPL4" + ] + + "BSSGP_BVC_CT":BVC -> "BSSGP_CT":BVC + "BSSGP_CT":BSCP -> "NS_CT":NS_SP + + "NS_CT":NSVC -> "NSVC_CT":NS_SP + "NS_CT":NSIP_PROC -> "NS_Provider_IPL4_CT":PROC + "NSVC_CT":NSCP -> "NS_Provider_IPL4_CT":NSVC + "NS_Provider_IPL4_CT":IPL4 -> "system":IPL4 + +} diff --git a/doc/ran_emulation_aoip.dot b/doc/ran_emulation_aoip.dot new file mode 100644 index 0000000..59f6d3d --- /dev/null +++ b/doc/ran_emulation_aoip.dot @@ -0,0 +1,39 @@ +digraph G { + rankdir = LR; + label = "RAN_Emulation when used with AoIP as in MSC_Tests"; + + "RAN_ConnHdlr" [ + shape = "record" + label = " RAN_ConnHdlr | BSSAP | BSSAP_PROC" + ]; + + "RAN_Emulation_CT" [ + shape = "record" + label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + ]; + + "SCCP_CT" [ + shape = "record" + label = " SCCP_CT | MTP3_SCCP_PORT | SCCP_SP_PORT" + ]; + + "M3UA_CT" [ + + shape = "record" + label = " M3UA_CT | SCTP_PORT | MTP3_SP_PORT" + ]; + + "system" [ + shape = "record" + label = " system | SCTP" + ]; + + "RAN_ConnHdlr":BSSAP -> "RAN_Emulation_CT":CLIENT + "RAN_ConnHdlr":BSSAP_PROC -> "RAN_Emulation_CT":PROC + + "RAN_Emulation_CT":BSSAP -> "SCCP_CT":SCCP_SP_PORT + "RAN_Emulation_CT":RANAP -> "SCCP_CT":SCCP_SP_PORT + + "SCCP_CT":MTP3_SCCP_PORT -> "M3UA_CT":MTP3_SP_PORT + "M3UA_CT":SCTP_PORT -> "system":SCTP +} diff --git a/doc/ran_emulation_sccplite.dot b/doc/ran_emulation_sccplite.dot new file mode 100644 index 0000000..cce29b1 --- /dev/null +++ b/doc/ran_emulation_sccplite.dot @@ -0,0 +1,39 @@ +digraph G { + rankdir = LR; + label = "RAN_Emulation when used with SCCPLite"; + + "RAN_ConnHdlr" [ + shape = "record" + label = " RAN_ConnHdlr | BSSAP | BSSAP_PROC" + ]; + + "RAN_Emulation_CT" [ + shape = "record" + label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + ]; + + "SCCP_CT" [ + shape = "record" + label = " SCCP_CT | MTP3_SCCP_PORT | SCCP_SP_PORT" + ]; + + "IPA_Emulation_CT" [ + shape = "record" + label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" + ]; + + "system" [ + shape = "record" + label = " system | IPA_CODEC_PORT" + ]; + + "RAN_ConnHdlr":BSSAP -> "RAN_Emulation_CT":CLIENT + "RAN_ConnHdlr":BSSAP_PROC -> "RAN_Emulation_CT":PROC + + "RAN_Emulation_CT":BSSAP -> "SCCP_CT":SCCP_SP_PORT + "RAN_Emulation_CT":MGCP -> "IPA_Emulation_CT":IPA_MGCP_PORT + "RAN_Emulation_CT":CTRL -> "IPA_Emulation_CT":IPA_CTRL_PORT + + "SCCP_CT":MTP3_SCCP_PORT -> "IPA_Emulation_CT":MTP3_SP_PORT + "IPA_Emulation_CT":IPA_PORT -> "system":IPA_CODEC_PORT +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79badbcdbbf03d69de3a1a18241c7a9537c161bf Gerrit-Change-Number: 26650 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:25:01 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:25:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Add dotty graphs of BSC + MSC test component hierarchy In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26652 ) Change subject: doc: Add dotty graphs of BSC + MSC test component hierarchy ...................................................................... doc: Add dotty graphs of BSC + MSC test component hierarchy Change-Id: I5b83a7f733eee4e4ab710985ee8dc21315ebebca --- A doc/bsc_tests_aoip.dot A doc/msc_tests_aoip.dot 2 files changed, 170 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/bsc_tests_aoip.dot b/doc/bsc_tests_aoip.dot new file mode 100644 index 0000000..4128d5c --- /dev/null +++ b/doc/bsc_tests_aoip.dot @@ -0,0 +1,81 @@ +digraph G { + rankdir = LR; + label = "MSC_Tests component hierarchy"; + + "MSC_ConnHdlr" [ + shape = "record" + label = " MSC_ConnHdlr | BSSAP | BSSAP_PROC | RSL | RSL_PROC | MGCP | MGCP_PROC | MGCP_MULTI | BSSAP_LE | BSSAP_LE_PROC | STATSD_PROC | RAN | BSCVTY | COORD | MGCP_MSC_CLIENT" + ]; + + "RAN_Emulation_CT" [ + shape = "record" + label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + ]; + "RAN_Emulation_CT":BSSAP -> "SCCP_CT":SCCP_SP_PORT + "MSC_ConnHdlr":BSSAP -> "RAN_Emulation_CT":CLIENT + "MSC_ConnHdlr":BSSAP_PROC -> "RAN_Emulation_CT":PROC + "MSC_ConnHdlr":IPA_CTRL -> "IPA_Emulation_CT":IPA_CTRL_PORT + + "RSL_Emulation_CT" [ + shape = "record" + label = " RSL_Emulation_CT | CLIENT_PT | RSL_PROC | CCHAN_PT | IPA_PT" + ] + "RSL_Emulation_CT":IPA_PT -> "IPA_Emulation_CT":IPA_RSL_PORT + "MSC_ConnHdlr":RSL -> "RSL_Emulation_CT":CLIENT_PT + "MSC_ConnHdlr":RSL_PROC -> "RSL_Emulation_CT":RSL_PROC + + "BSSAP_LE_Emulation_CT" [ + shape = "record" + label = " BSSAP_LE_Emulation_CT | CLIENT | PROC | BSSAP_LE" + ] + "BSSAP_LE_Emulation_CT":BSSAP_LE -> "SCCP_CT":SCCP_SP_PORT + "MSC_ConnHdlr":BSSAP_LE -> "BSSAP_LE_Emulation_CT":CLIENT + "MSC_ConnHdlr":BSSAP_LE_PROC -> "BSSAP_LE_Emulation_CT":PROC + + "SCCP_CT" [ + shape = "record" + label = " SCCP_CT | MTP3_SCCP_PORT | SCCP_SP_PORT" + ]; + "SCCP_CT":MTP3_SCCP_PORT -> "M3UA_CT":MTP3_SP_PORT + + "M3UA_CT" [ + + shape = "record" + label = " M3UA_CT | SCTP_PORT | MTP3_SP_PORT" + ]; + "M3UA_CT":SCTP_PORT -> "system":SCTP + + + "StatsD_Checker_CT" [ + shape = "record" + label = " StatsD_Checker_CT | STATSD_PROC | STATS | STATSVTY" + ] + "StatsD_Checker_CT":STATS -> "system":IPL4 + "StatsD_Checker_CT":STATSVTY -> "system":TELNET + "MSC_ConnHdlr":STATSD_PROC -> "StatsD_Checker_CT":STATSD_PROC + + + "MGCP_Emulation_CT" [ + shape = "record" + label = " MGCP_Emulation_CT | MGCP_CLIENT | MGCP_PROC | MGCP_CLIENT_MULTI | MGCP" + ] + "MGCP_Emulation_CT":MGCP -> "system":IPL4 + "MGCP_Emulation_CT":MGCP -> "IPA_Emulation_CT":IPA_MGCP_PORT + "MSC_ConnHdlr":MGCP -> "MGCP_Emulation_CT":MGCP_CLIENT + "MSC_ConnHdlr":MGCP_PROC -> "MGCP_Emulation_CT":MGCP_PROC + "MSC_ConnHdlr":MGCP_MULTI -> "MGCP_Emulation_CT":MGCP_CLIENT_MULTI + "MSC_ConnHdlr":BSCVTY -> "system":TELNET + + + "IPA_Emulation_CT" [ + shape = "record" + label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" + ]; + "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 + + + "system" [ + shape = "record" + label = " system | SCTP | IPL4 | UD | TELNET" + ]; +} diff --git a/doc/msc_tests_aoip.dot b/doc/msc_tests_aoip.dot new file mode 100644 index 0000000..c443cbc --- /dev/null +++ b/doc/msc_tests_aoip.dot @@ -0,0 +1,89 @@ +digraph G { + rankdir = LR; + label = "MSC_Tests component hierarchy"; + + "BSC_ConnHdlr" [ + shape = "record" + label = " BSC_ConnHdlr | BSSAP | BSSAP_PROC | MNCC | MNCC_PROC | GSUP | GSUP_PROC | MGCP | MGCP_PROC | MGCP_MULTI | SMPP | SMPP_PROC | IPA_CTRL | SGsAP | SGsAP_PROC" + ]; + + "RAN_Emulation_CT" [ + shape = "record" + label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + ]; + "RAN_Emulation_CT":BSSAP -> "SCCP_CT":SCCP_SP_PORT + "BSC_ConnHdlr":BSSAP -> "RAN_Emulation_CT":CLIENT + "BSC_ConnHdlr":BSSAP_PROC -> "RAN_Emulation_CT":PROC + "BSC_ConnHdlr":IPA_CTRL -> "IPA_Emulation_CT":IPA_CTRL_PORT + + + "SCCP_CT" [ + shape = "record" + label = " SCCP_CT | MTP3_SCCP_PORT | SCCP_SP_PORT" + ]; + "SCCP_CT":MTP3_SCCP_PORT -> "M3UA_CT":MTP3_SP_PORT + + "M3UA_CT" [ + + shape = "record" + label = " M3UA_CT | SCTP_PORT | MTP3_SP_PORT" + ]; + "M3UA_CT":SCTP_PORT -> "system":SCTP + + + "MNCC_Emulation_CT" [ + shape = "record" + label = " MNCC_Emulation_CT | MNCC_CLIENT | MNCC_PROC | MNCC" + ] + "MNCC_Emulation_CT":MNCC -> "system":UD + "BSC_ConnHdlr":MNCC -> "MNCC_Emulation_CT":MNCC_CLIENT + "BSC_ConnHdlr":MNCC_PROC -> "MNCC_Emulation_CT":MNCC_PROC + + + "GSUP_Emulation_CT" [ + shape = "record" + label = " GSUP_Emulation_CT | GSUP_CLIENT | GSUP_PROC | GSUP" + ] + "GSUP_Emulation_CT":GSUP -> "IPA_Emulation_CT":IPA_GSUP_PORT + "BSC_ConnHdlr":GSUP -> "GSUP_Emulation_CT":GSUP_CLIENT + "BSC_ConnHdlr":GSUP_PROC -> "GSUP_Emulation_CT":GSUP_PROC + + + "MGCP_Emulation_CT" [ + shape = "record" + label = " MGCP_Emulation_CT | MGCP_CLIENT | MGCP_PROC | MGCP_CLIENT_MULTI | MGCP" + ] + "MGCP_Emulation_CT":MGCP -> "system":IPL4 + "MGCP_Emulation_CT":MGCP -> "IPA_Emulation_CT":IPA_MGCP_PORT + "BSC_ConnHdlr":MGCP -> "MGCP_Emulation_CT":MGCP_CLIENT + "BSC_ConnHdlr":MGCP_PROC -> "MGCP_Emulation_CT":MGCP_PROC + "BSC_ConnHdlr":MGCP_MULTI -> "MGCP_Emulation_CT":MGCP_CLIENT_MULTI + + "SMPP_Emulation_CT" [ + shape = "record" + label = " SMPP_Emulation_CT | SMPP_CLIENT | SMPP_PROC | SMPP_PORT" + ] + "SMPP_Emulation_CT":SMPP_PORT -> "system":IPL4 + "BSC_ConnHdlr":SMPP -> "SMPP_Emulation_CT":SMPP_CLIENT + "BSC_ConnHdlr":SMPP_PROC -> "SMPP_Emulation_CT":SMPP_PROC + + "SGsAP_Emulation_CT" [ + shape = "record" + label = " SGsAP_Emulation_CT | SGsAP_CLIENT | SGsAP_PROC | SGsAP_UNIT | SGsAP" + ] + "SGsAP_Emulation_CT":SGsAP -> "system":IPL4 + "BSC_ConnHdlr":SGsAP -> "SGsAP_Emulation_CT":SGsAP_CLIENT + "BSC_ConnHdlr":SGsAP_PROC -> "SGsAP_Emulation_CT":SGsAP_PROC + + "IPA_Emulation_CT" [ + shape = "record" + label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" + ]; + "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 + + + "system" [ + shape = "record" + label = " system | SCTP | IPL4 | UD" + ]; +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b83a7f733eee4e4ab710985ee8dc21315ebebca Gerrit-Change-Number: 26652 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:25:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:25:02 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Add dotty graph of BTS_Tests component hierarchy In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26653 ) Change subject: doc: Add dotty graph of BTS_Tests component hierarchy ...................................................................... doc: Add dotty graph of BTS_Tests component hierarchy Change-Id: I42d5d67cae290f4b8b330b7800cb5337a9745ce3 --- A doc/bts_tests.dot 1 file changed, 49 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/bts_tests.dot b/doc/bts_tests.dot new file mode 100644 index 0000000..8cbb5b1 --- /dev/null +++ b/doc/bts_tests.dot @@ -0,0 +1,49 @@ +digraph G { + rankdir = LR; + label = "BTS_Tests component hierarchy"; + + "ConnHdlr" [ + shape = "record" + label = " ConnHdlr | RSL | RSL_PROC | LAPDM | L1CTL | BTS_TRXC | BSCVTY | PCU | RTPEM_DATA | RTPEM_CTRL" + ]; + "ConnHdlr":L1CTL -> "system":UD [label="L1CTL_PT:UD_PT"] + "ConnHdlr":BTS_TRXC -> "system":IPL4 [label="TRXC_CODEC_PT"] + "ConnHdlr":BSCVTY -> "system":TELNET + "ConnHdlr":PCU -> "system":UD [label="PCUIF_CODEC_PT"] + + "RSL_Emulation_CT" [ + shape = "record" + label = " RSL_Emulation_CT | CLIENT_PT | RSL_PROC | CCHAN_PT | IPA_PT" + ] + "RSL_Emulation_CT":IPA_PT -> "IPA_Emulation_CT":IPA_RSL_PORT + "ConnHdlr":RSL -> "RSL_Emulation_CT":CLIENT_PT + "ConnHdlr":RSL_PROC -> "RSL_Emulation_CT":RSL_PROC + + "LAPDm_CT" [ + shape = "record" + label = " LAPDM_CT | LAPDM_SP | L1CTL" + ] + "LAPDm_CT":L1CTL -> "system":UD [label="L1CTL_PT:UD_PT"] + "ConnHdlr":LAPDM -> "LAPDm_CT":LAPDM_SP + + "RTP_Emulation_CT" [ + shape = "record" + label = " RTP_Emulation_CT | DATA | CTRL | RTP | RTCP" + ] + "RTP_Emulation_CT":RTP -> "system":IPL4 [label="RTP_CODEC_PT"] + "RTP_Emulation_CT":RTCP -> "system":IPL4 [label="RTP_CODEC_PT"] + "ConnHdlr":RTPEM_DATA -> "RTP_Emulation_CT":DATA + "ConnHdlr":RTPEM_CTRL -> "RTP_Emulation_CT":CTRL + + "IPA_Emulation_CT" [ + shape = "record" + label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" + ]; + "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 + + + "system" [ + shape = "record" + label = " system | IPL4 | UD | TELNET" + ]; +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I42d5d67cae290f4b8b330b7800cb5337a9745ce3 Gerrit-Change-Number: 26653 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:25:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:25:03 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Re-order ports in RAN_Emulation_CT In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26654 ) Change subject: doc: Re-order ports in RAN_Emulation_CT ...................................................................... doc: Re-order ports in RAN_Emulation_CT Bring it in-line with all other test components: user-facing ports at the top, IUT-facing ports at the bottom. Change-Id: I1001601f5bb7c9beb40fd0ddd404c55e3d211608 --- M doc/bsc_tests_aoip.dot M doc/msc_tests_aoip.dot M doc/ran_emulation_aoip.dot M doc/ran_emulation_sccplite.dot 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/bsc_tests_aoip.dot b/doc/bsc_tests_aoip.dot index 4128d5c..161142a 100644 --- a/doc/bsc_tests_aoip.dot +++ b/doc/bsc_tests_aoip.dot @@ -9,7 +9,7 @@ "RAN_Emulation_CT" [ shape = "record" - label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + label = " RAN_Emulation_CT | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC | BSSAP | RANAP" ]; "RAN_Emulation_CT":BSSAP -> "SCCP_CT":SCCP_SP_PORT "MSC_ConnHdlr":BSSAP -> "RAN_Emulation_CT":CLIENT diff --git a/doc/msc_tests_aoip.dot b/doc/msc_tests_aoip.dot index c443cbc..06359f7 100644 --- a/doc/msc_tests_aoip.dot +++ b/doc/msc_tests_aoip.dot @@ -9,7 +9,7 @@ "RAN_Emulation_CT" [ shape = "record" - label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + label = " RAN_Emulation_CT | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC | BSSAP | RANAP" ]; "RAN_Emulation_CT":BSSAP -> "SCCP_CT":SCCP_SP_PORT "BSC_ConnHdlr":BSSAP -> "RAN_Emulation_CT":CLIENT diff --git a/doc/ran_emulation_aoip.dot b/doc/ran_emulation_aoip.dot index 59f6d3d..8374555 100644 --- a/doc/ran_emulation_aoip.dot +++ b/doc/ran_emulation_aoip.dot @@ -9,7 +9,7 @@ "RAN_Emulation_CT" [ shape = "record" - label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + label = " RAN_Emulation_CT | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC | BSSAP | RANAP" ]; "SCCP_CT" [ diff --git a/doc/ran_emulation_sccplite.dot b/doc/ran_emulation_sccplite.dot index cce29b1..7ab7feb 100644 --- a/doc/ran_emulation_sccplite.dot +++ b/doc/ran_emulation_sccplite.dot @@ -9,7 +9,7 @@ "RAN_Emulation_CT" [ shape = "record" - label = " RAN_Emulation_CT | BSSAP | RANAP | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC" + label = " RAN_Emulation_CT | MGCP | CTRL | CTRL_CLIENT | CLIENT | PROC | BSSAP | RANAP" ]; "SCCP_CT" [ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1001601f5bb7c9beb40fd0ddd404c55e3d211608 Gerrit-Change-Number: 26654 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:25:05 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:25:05 +0000 Subject: Change in osmo-ttcn3-hacks[master]: doc: Always annotate codec port types in case of IPL4/UD ports In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26655 ) Change subject: doc: Always annotate codec port types in case of IPL4/UD ports ...................................................................... doc: Always annotate codec port types in case of IPL4/UD ports Change-Id: Icee6eeb4a526ff5cbeb8b01df8149c488875455e --- M doc/bsc_tests_aoip.dot M doc/bts_tests.dot M doc/msc_tests_aoip.dot 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/bsc_tests_aoip.dot b/doc/bsc_tests_aoip.dot index 161142a..1457bdf 100644 --- a/doc/bsc_tests_aoip.dot +++ b/doc/bsc_tests_aoip.dot @@ -50,7 +50,7 @@ shape = "record" label = " StatsD_Checker_CT | STATSD_PROC | STATS | STATSVTY" ] - "StatsD_Checker_CT":STATS -> "system":IPL4 + "StatsD_Checker_CT":STATS -> "system":IPL4 [label="STATSD_CODEC_PT"] "StatsD_Checker_CT":STATSVTY -> "system":TELNET "MSC_ConnHdlr":STATSD_PROC -> "StatsD_Checker_CT":STATSD_PROC @@ -59,7 +59,7 @@ shape = "record" label = " MGCP_Emulation_CT | MGCP_CLIENT | MGCP_PROC | MGCP_CLIENT_MULTI | MGCP" ] - "MGCP_Emulation_CT":MGCP -> "system":IPL4 + "MGCP_Emulation_CT":MGCP -> "system":IPL4 [label="MGCP_CODEC_PT"] "MGCP_Emulation_CT":MGCP -> "IPA_Emulation_CT":IPA_MGCP_PORT "MSC_ConnHdlr":MGCP -> "MGCP_Emulation_CT":MGCP_CLIENT "MSC_ConnHdlr":MGCP_PROC -> "MGCP_Emulation_CT":MGCP_PROC @@ -71,7 +71,7 @@ shape = "record" label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" ]; - "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 + "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 [label="IPA_CODEC_PT"] "system" [ diff --git a/doc/bts_tests.dot b/doc/bts_tests.dot index 8cbb5b1..3fd9471 100644 --- a/doc/bts_tests.dot +++ b/doc/bts_tests.dot @@ -39,7 +39,7 @@ shape = "record" label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" ]; - "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 + "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 [label="IPA_CODEC_PT"] "system" [ diff --git a/doc/msc_tests_aoip.dot b/doc/msc_tests_aoip.dot index 06359f7..c799844 100644 --- a/doc/msc_tests_aoip.dot +++ b/doc/msc_tests_aoip.dot @@ -35,7 +35,7 @@ shape = "record" label = " MNCC_Emulation_CT | MNCC_CLIENT | MNCC_PROC | MNCC" ] - "MNCC_Emulation_CT":MNCC -> "system":UD + "MNCC_Emulation_CT":MNCC -> "system":UD [label="MNCC_CODEC_PT"] "BSC_ConnHdlr":MNCC -> "MNCC_Emulation_CT":MNCC_CLIENT "BSC_ConnHdlr":MNCC_PROC -> "MNCC_Emulation_CT":MNCC_PROC @@ -53,7 +53,7 @@ shape = "record" label = " MGCP_Emulation_CT | MGCP_CLIENT | MGCP_PROC | MGCP_CLIENT_MULTI | MGCP" ] - "MGCP_Emulation_CT":MGCP -> "system":IPL4 + "MGCP_Emulation_CT":MGCP -> "system":IPL4 [label="MGCP_CODEC_PT"] "MGCP_Emulation_CT":MGCP -> "IPA_Emulation_CT":IPA_MGCP_PORT "BSC_ConnHdlr":MGCP -> "MGCP_Emulation_CT":MGCP_CLIENT "BSC_ConnHdlr":MGCP_PROC -> "MGCP_Emulation_CT":MGCP_PROC @@ -63,7 +63,7 @@ shape = "record" label = " SMPP_Emulation_CT | SMPP_CLIENT | SMPP_PROC | SMPP_PORT" ] - "SMPP_Emulation_CT":SMPP_PORT -> "system":IPL4 + "SMPP_Emulation_CT":SMPP_PORT -> "system":IPL4 [label="SMPP_CODEC_PT"] "BSC_ConnHdlr":SMPP -> "SMPP_Emulation_CT":SMPP_CLIENT "BSC_ConnHdlr":SMPP_PROC -> "SMPP_Emulation_CT":SMPP_PROC @@ -71,7 +71,7 @@ shape = "record" label = " SGsAP_Emulation_CT | SGsAP_CLIENT | SGsAP_PROC | SGsAP_UNIT | SGsAP" ] - "SGsAP_Emulation_CT":SGsAP -> "system":IPL4 + "SGsAP_Emulation_CT":SGsAP -> "system":IPL4 [label="SGsAP_CODEC_PT"] "BSC_ConnHdlr":SGsAP -> "SGsAP_Emulation_CT":SGsAP_CLIENT "BSC_ConnHdlr":SGsAP_PROC -> "SGsAP_Emulation_CT":SGsAP_PROC @@ -79,7 +79,7 @@ shape = "record" label = " IPA_Emulation_CT | MTP3_SP_PORT | IPA_MGCP_PORT | IPA_RSL_PORT | IPA_OML_PORT | IPA_CTRL_PORT | IPA_GSUP_PORT | IPA_RSPRO_PORT | IPA_OSMO_PCU_PORT | IPA_SP_PORT | IPA_PORT" ]; - "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 + "IPA_Emulation_CT":IPA_PORT -> "system":IPL4 [label="IPA_CODEC_PT"] "system" [ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icee6eeb4a526ff5cbeb8b01df8149c488875455e Gerrit-Change-Number: 26655 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:25:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:25:45 +0000 Subject: Change in libosmocore[master]: select_main: don't poll forever during shutdown In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26663 ) Change subject: select_main: don't poll forever during shutdown ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81c64a7ae440304522c2179c212023a566ddced8 Gerrit-Change-Number: 26663 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:25:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:25:54 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:25:54 +0000 Subject: Change in libosmo-sccp[master]: src/sccp_scmg: fix typo In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26664 ) Change subject: src/sccp_scmg: fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ifd6264da2da2e7cc62485dcde9b6c462d4858626 Gerrit-Change-Number: 26664 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:25:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:26:00 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:26:00 +0000 Subject: Change in libosmo-sccp[master]: src/sccp_scmg: fix typo In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26664 ) Change subject: src/sccp_scmg: fix typo ...................................................................... src/sccp_scmg: fix typo Change-Id: Ifd6264da2da2e7cc62485dcde9b6c462d4858626 --- M src/sccp_scmg.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/sccp_scmg.c b/src/sccp_scmg.c index aba2416..ef3a0b3 100644 --- a/src/sccp_scmg.c +++ b/src/sccp_scmg.c @@ -308,7 +308,7 @@ int sccp_scmg_init(struct osmo_sccp_instance *inst) { struct osmo_sccp_user *scu; - scu = osmo_sccp_user_bind(inst, "SCCP Maangement", scmg_prim_cb, SCCP_SSN_MANAGEMENT); + scu = osmo_sccp_user_bind(inst, "SCCP Management", scmg_prim_cb, SCCP_SSN_MANAGEMENT); if (!scu) return -1; return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ifd6264da2da2e7cc62485dcde9b6c462d4858626 Gerrit-Change-Number: 26664 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:26:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:26:15 +0000 Subject: Change in libosmo-sccp[master]: osmo_ss7_instance_destroy: use for_each_entry_safe In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26665 ) Change subject: osmo_ss7_instance_destroy: use for_each_entry_safe ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ieaec3584375b0e6b943638fe1e50b4d74a627216 Gerrit-Change-Number: 26665 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:26:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:26:17 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:26:17 +0000 Subject: Change in libosmo-sccp[master]: osmo_ss7_instance_destroy: use for_each_entry_safe In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26665 ) Change subject: osmo_ss7_instance_destroy: use for_each_entry_safe ...................................................................... osmo_ss7_instance_destroy: use for_each_entry_safe Fix segfault in each loop. Change-Id: Ieaec3584375b0e6b943638fe1e50b4d74a627216 --- M src/osmo_ss7.c 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 649e3f7..99536d3 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -410,20 +410,20 @@ * \param[in] inst SS7 Instance to be destroyed */ void osmo_ss7_instance_destroy(struct osmo_ss7_instance *inst) { - struct osmo_ss7_linkset *lset; - struct osmo_ss7_as *as; - struct osmo_ss7_asp *asp; + struct osmo_ss7_linkset *lset, *lset2; + struct osmo_ss7_as *as, *as2; + struct osmo_ss7_asp *asp, *asp2; OSMO_ASSERT(ss7_initialized); LOGSS7(inst, LOGL_INFO, "Destroying SS7 Instance\n"); - llist_for_each_entry(asp, &inst->asp_list, list) + llist_for_each_entry_safe(asp, asp2, &inst->asp_list, list) osmo_ss7_asp_destroy(asp); - llist_for_each_entry(as, &inst->as_list, list) + llist_for_each_entry_safe(as, as2, &inst->as_list, list) osmo_ss7_as_destroy(as); - llist_for_each_entry(lset, &inst->linksets, list) + llist_for_each_entry_safe(lset, lset2, &inst->linksets, list) osmo_ss7_linkset_destroy(lset); llist_del(&inst->list); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ieaec3584375b0e6b943638fe1e50b4d74a627216 Gerrit-Change-Number: 26665 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:26:34 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:26:34 +0000 Subject: Change in osmo-ci[master]: OBS, ttcn3-testsuites: add 2021q4 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26669 ) Change subject: OBS, ttcn3-testsuites: add 2021q4 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4913218b192cf0cb1fb74b239ced9a0501c2eb48 Gerrit-Change-Number: 26669 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 22 Dec 2021 14:26:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:29:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:29:28 +0000 Subject: Change in osmo-bsc-nat[master]: Add project skeleton In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 ) Change subject: Add project skeleton ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/configure.ac File configure.ac: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/configure.ac at 53 PS1, Line 53: P will we need ASN.1 decoding/encoding in the bsc-nat? I'm currently a bit surprised and cannot think of any part that would require it. https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/jenkins.sh File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/jenkins.sh at 32 PS1, Line 32: osm does not include libasn1c which configure.ac is requiring (probably wrongly so). https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/osmo-bsc-nat.spec.in File contrib/osmo-bsc-nat.spec.in: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/osmo-bsc-nat.spec.in at 41 PS1, Line 41: Bui why would we need libosmogb here? configure.ac doesn't list it, and I cannot think of a reason. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Iae5d37483dcb9db00578d5c9cd1736f08754a65e Gerrit-Change-Number: 26658 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 22 Dec 2021 14:29:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:30:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:30:02 +0000 Subject: Change in osmo-bsc-nat[master]: Add vty interface In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659 ) Change subject: Add vty interface ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I6f2d8d1d62b97be471ebcf1bb14aac0b895833d1 Gerrit-Change-Number: 26659 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:30:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:30:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:30:20 +0000 Subject: Change in osmo-bsc-nat[master]: Add command-line options In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26660 ) Change subject: Add command-line options ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I41bca9e1b88bb130870d078ed3f499e39e0bf5d3 Gerrit-Change-Number: 26660 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:30:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:30:30 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:30:30 +0000 Subject: Change in osmo-bsc-nat[master]: Add signal handler In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26661 ) Change subject: Add signal handler ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I303e9275a2f1f6f2da742089d079ba604ee5a36b Gerrit-Change-Number: 26661 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:30:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:31:44 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:31:44 +0000 Subject: Change in osmo-bsc-nat[master]: Add bsc_nat fsm In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 ) Change subject: Add bsc_nat fsm ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:31:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:32:19 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:32:19 +0000 Subject: Change in osmo-ttcn3-hacks[master]: IuUP_Emulation: Fix frame number wrap-around In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26656 ) Change subject: IuUP_Emulation: Fix frame number wrap-around ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9e69115c49545a7b9797d8f85568d5e91dfb329 Gerrit-Change-Number: 26656 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 22 Dec 2021 14:32:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:32:36 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:32:36 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Updates in HNBLLIF and HNBGW_COnnectioNHandler to support and... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26672 ) Change subject: hnodeb: Updates in HNBLLIF and HNBGW_COnnectioNHandler to support and test IuUP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I19612fce8190dfe14f98d346adb5db4e1c2a08d9 Gerrit-Change-Number: 26672 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 22 Dec 2021 14:32:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:37:57 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 14:37:57 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 16: Code-Review+1 ok, looks good. There's basically two questions open from my point of view: 1) should we really not register every TCP socket by default [except VTY/CTRL]. Pau thinks we shouldn't, I'm more inclined to say we should. Any other comments? 2) polling only one socket every interval. Previsouly we had all at each timer (which might block the process for too long time). But doing only one per interval might be on the other extreme. If there's 200 sockets (100 single-TRX BTSs registered to one osmo-bsc), it would take 100 timer expirations to have scanned all sockets. Furthermore, we probably need something in osmo-gsm-manuals -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 16 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 22 Dec 2021 14:37:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:49:54 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 14:49:54 +0000 Subject: Change in libosmocore[master]: include/: Adapt some headers to match contrib/struct_endianess.py format In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26670 ) Change subject: include/: Adapt some headers to match contrib/struct_endianess.py format ...................................................................... include/: Adapt some headers to match contrib/struct_endianess.py format This way the related files are not changed when running the script to generate struct fields for big endian systems. Change-Id: I830e0961331a73f8dceb1a5a1c879798541752fd --- M include/osmocom/gprs/protocol/gsm_08_18.h M include/osmocom/gsm/protocol/gsm_08_58.h M include/osmocom/gsm/protocol/gsm_44_004.h 3 files changed, 27 insertions(+), 36 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/gprs/protocol/gsm_08_18.h b/include/osmocom/gprs/protocol/gsm_08_18.h index 0d002b5..d6f0fe6 100644 --- a/include/osmocom/gprs/protocol/gsm_08_18.h +++ b/include/osmocom/gprs/protocol/gsm_08_18.h @@ -362,13 +362,12 @@ /* RIM PDU Indications * 3GPP TS 48.018, section 11.3.65.0 */ struct bssgp_rim_pdu_ind { -#if OSMO_IS_BIG_ENDIAN - uint8_t reserved:4, - pdu_type_ext:3, - ack_requested:1; -#elif OSMO_IS_LITTLE_ENDIAN +#if OSMO_IS_LITTLE_ENDIAN uint8_t ack_requested:1, pdu_type_ext:3, reserved:4; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t reserved:4, pdu_type_ext:3, ack_requested:1; #endif } __attribute__ ((packed)); diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h index 4937f08..7a527ff 100644 --- a/include/osmocom/gsm/protocol/gsm_08_58.h +++ b/include/osmocom/gsm/protocol/gsm_08_58.h @@ -118,35 +118,29 @@ /* Osmocom specific IE to negotiate repeated ACCH capabilities */ struct abis_rsl_osmo_rep_acch_cap { -#if OSMO_IS_BIG_ENDIAN - uint8_t reserved:1, - rxqual:3, - ul_sacch:1, - dl_sacch:1, - dl_facch_all:1, - dl_facch_cmd:1; -#elif OSMO_IS_LITTLE_ENDIAN +#if OSMO_IS_LITTLE_ENDIAN uint8_t dl_facch_cmd:1, dl_facch_all:1, dl_sacch:1, ul_sacch:1, rxqual:3, reserved:1; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t reserved:1, rxqual:3, ul_sacch:1, dl_sacch:1, dl_facch_all:1, dl_facch_cmd:1; #endif } __attribute__ ((packed)); /* Osmocom specific IE to negotiate temporary overpower of ACCH channels */ struct abis_rsl_osmo_temp_ovp_acch_cap { -#if OSMO_IS_BIG_ENDIAN - uint8_t sacch_enable:1, - facch_enable:1, - rxqual:3, - overpower_db:3; -#elif OSMO_IS_LITTLE_ENDIAN +#if OSMO_IS_LITTLE_ENDIAN uint8_t overpower_db:3, rxqual:3, facch_enable:1, sacch_enable:1; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t sacch_enable:1, facch_enable:1, rxqual:3, overpower_db:3; #endif } __attribute__ ((packed)); @@ -862,10 +856,10 @@ uint8_t u_rxqual:3, reserved_u_rxqual:1, l_rxqual:3, reserved_l_rxqual:1; #elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ uint8_t reserved_l_rxlev:2, l_rxlev:6; uint8_t reserved_u_rxlev:2, u_rxlev:6; - uint8_t reserved_l_rxqual:1, l_rxqual:3, - reserved_u_rxqual:1, u_rxqual:3; + uint8_t reserved_l_rxqual:1, l_rxqual:3, reserved_u_rxqual:1, u_rxqual:3; #endif }__attribute__ ((packed)); @@ -922,6 +916,7 @@ uint8_t pc_interval:5, reserved_pc:3; uint8_t red_step_size:4, inc_step_size:4; #elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ uint8_t reserved_p1:3, p1:5; uint8_t reserved_n1:3, n1:5; uint8_t reserved_p2:3, p2:5; @@ -943,11 +938,12 @@ uint8_t upper_p:5, reserved_upper_p:3; uint8_t upper_n:5, reserved_upper_n:3; #elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ uint8_t reserved_lower_p:3, lower_p:5; uint8_t reserved_lower_n:3, lower_n:5; uint8_t reserved_upper_p:3, upper_p:5; uint8_t reserved_upper_n:3, upper_n:5; - #endif +#endif }__attribute__ ((packed)); struct osmo_preproc_pc_comp { /* Used for Carrier-to-Interference (C/I), in dB: */ @@ -1051,18 +1047,16 @@ }; struct rsl_l1_info { -#if OSMO_IS_BIG_ENDIAN - uint8_t ms_pwr:5, - fpc_epc:1, - srr_sro:1, - reserved:1; - uint8_t ta; -#elif OSMO_IS_LITTLE_ENDIAN +#if OSMO_IS_LITTLE_ENDIAN uint8_t reserved:1, srr_sro:1, fpc_epc:1, ms_pwr:5; uint8_t ta; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t ms_pwr:5, fpc_epc:1, srr_sro:1, reserved:1; + uint8_t ta; #endif } __attribute__ ((packed)); diff --git a/include/osmocom/gsm/protocol/gsm_44_004.h b/include/osmocom/gsm/protocol/gsm_44_004.h index 32ef24e..616e436 100644 --- a/include/osmocom/gsm/protocol/gsm_44_004.h +++ b/include/osmocom/gsm/protocol/gsm_44_004.h @@ -5,17 +5,15 @@ /* TS 44.004 Section 7.1 */ struct gsm_sacch_l1_hdr { -#if OSMO_IS_BIG_ENDIAN - uint8_t reserved:1, - srr_sro:1, - fpc_epc:1, - ms_pwr:5; - uint8_t ta; -#elif OSMO_IS_LITTLE_ENDIAN +#if OSMO_IS_LITTLE_ENDIAN uint8_t ms_pwr:5, fpc_epc:1, srr_sro:1, reserved:1; uint8_t ta; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t reserved:1, srr_sro:1, fpc_epc:1, ms_pwr:5; + uint8_t ta; #endif } __attribute__ ((packed)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I830e0961331a73f8dceb1a5a1c879798541752fd Gerrit-Change-Number: 26670 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:55:03 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 14:55:03 +0000 Subject: Change in osmo-hnodeb[master]: Add initial support for IuUP RTP based Transport Layer In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 ) Change subject: Add initial support for IuUP RTP based Transport Layer ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671/1/include/osmocom/hnodeb/hnb_prim.h File include/osmocom/hnodeb/hnb_prim.h: https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671/1/include/osmocom/hnodeb/hnb_prim.h at 200 PS1, Line 200: supported_versions_mask > should we really pass this low-level detail/decision to the SAP/lower-layer? Should we even bother t [?] Yes, this information is provided in the RAB-Assignment-Request to the HNB, so the requested supported versions need to be a subset of that AFAIU: """ userPlaneInformation userPlaneMode: support-mode-for-predefined-SDU-sizes (1) uP-ModeVersions: 0001 [bit length 16, 0000 0000 0000 0001 decimal value 1] """ -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ie137809e1f91dfd702853c52be97ca79e8604eab Gerrit-Change-Number: 26671 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 22 Dec 2021 14:55:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 14:56:55 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 14:56:55 +0000 Subject: Change in osmo-ci[master]: OBS, ttcn3-testsuites: add 2021q4 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26669 ) Change subject: OBS, ttcn3-testsuites: add 2021q4 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4913218b192cf0cb1fb74b239ced9a0501c2eb48 Gerrit-Change-Number: 26669 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 14:56:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 15:02:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 15:02:18 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 16: > Patch Set 16: Code-Review+1 > > ok, looks good. There's basically two questions open from my point of view: > > 1) should we really not register every TCP socket by default [except VTY/CTRL]. Pau thinks we shouldn't, I'm more inclined to say we should. Any other comments? For the record: "I think" we should not couple osmo_fd registration with this TCP stats API in any way, it should be totally decoupled and done manually by the user/app/library on specific sockets (fds). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 16 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 22 Dec 2021 15:02:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 15:03:12 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 22 Dec 2021 15:03:12 +0000 Subject: Change in osmo-ttcn3-hacks[master]: deps: Update SCTPasp to fix SCTP kernal ABI breakage References: Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 ) Change subject: deps: Update SCTPasp to fix SCTP kernal ABI breakage ...................................................................... deps: Update SCTPasp to fix SCTP kernal ABI breakage Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Related: OS#5366 --- M deps/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/26674/1 diff --git a/deps/Makefile b/deps/Makefile index 9296f1b..5c69ee9 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -120,7 +120,7 @@ titan.TestPorts.MTP3asp_commit= 1cecdad6f3641a5f19b3833703bff6e5005eff11 titan.TestPorts.PCAPasp_commit= R.8.A-3-g9ad320f titan.TestPorts.PIPEasp_commit= R.7.D-3-g8b01154 -titan.TestPorts.SCTPasp_commit= R.11.A-7-ga21b94f +titan.TestPorts.SCTPasp_commit= R.11.A-8-g2e911c3 titan.TestPorts.SIPmsg_commit= R.15.A-1-ge4f9dd0 titan.TestPorts.TCPasp_commit= R.9.A-5-g2c91bc6 titan.TestPorts.TELNETasp_commit= 873fe539642542cd9a901c208f1ec11c6d2f5387 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Gerrit-Change-Number: 26674 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 15:03:17 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 15:03:17 +0000 Subject: Change in osmo-ttcn3-hacks[master]: IuUP_Emulation: Fix frame number wrap-around In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26656 ) Change subject: IuUP_Emulation: Fix frame number wrap-around ...................................................................... IuUP_Emulation: Fix frame number wrap-around As seen when running a test: IuUP_Emulation.ttcn:150 Dynamic test case error: While RAW-encoding type '@IuUP_Types.IuUP_PDU': There are insufficient bits to encode '@IuUP_Types.IuUP_PDU_Type_0.frame_nr' Change-Id: Ic9e69115c49545a7b9797d8f85568d5e91dfb329 --- M library/IuUP_Emulation.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/IuUP_Emulation.ttcn b/library/IuUP_Emulation.ttcn index 56384ee..b35602c 100644 --- a/library/IuUP_Emulation.ttcn +++ b/library/IuUP_Emulation.ttcn @@ -143,7 +143,7 @@ } else { pdu := valueof(ts_IuUP_Type1(st.tx_next_frame_nr, 0, payload)); } - st.tx_next_frame_nr := st.tx_next_frame_nr + 1; + st.tx_next_frame_nr := (st.tx_next_frame_nr + 1) mod 16; } } if (isvalue(pdu)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9e69115c49545a7b9797d8f85568d5e91dfb329 Gerrit-Change-Number: 26656 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 15:04:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 15:04:18 +0000 Subject: Change in osmo-ttcn3-hacks[master]: deps: Update SCTPasp to fix SCTP kernal ABI breakage In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 ) Change subject: deps: Update SCTPasp to fix SCTP kernal ABI breakage ...................................................................... Patch Set 1: (1 comment) So was this fixed upstream already then? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674/1//COMMIT_MSG at 7 PS1, Line 7: deps: Update SCTPasp to fix SCTP kernal ABI breakage kernel -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Gerrit-Change-Number: 26674 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 15:04:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 15:24:38 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 22 Dec 2021 15:24:38 +0000 Subject: Change in osmo-ttcn3-hacks[master]: deps: Update SCTPasp to fix SCTP kernal ABI breakage In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 ) Change subject: deps: Update SCTPasp to fix SCTP kernal ABI breakage ...................................................................... Patch Set 1: > Patch Set 1: > > (1 comment) > > So was this fixed upstream already then? No, for now it's a commit in our local fork, see https://github.com/osmocom/titan.TestPorts.SCTPasp/commit/2e911c3f2cec63694ccae75a28909c9cefa03f3d -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Gerrit-Change-Number: 26674 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 15:24:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 15:25:01 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 15:25:01 +0000 Subject: Change in osmo-ttcn3-hacks[master]: deps: Update SCTPasp to fix SCTP kernal ABI breakage In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 ) Change subject: deps: Update SCTPasp to fix SCTP kernal ABI breakage ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Gerrit-Change-Number: 26674 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 15:25:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 15:29:25 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 22 Dec 2021 15:29:25 +0000 Subject: Change in osmo-ttcn3-hacks[master]: deps: Update SCTPasp In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 to look at the new patch set (#2). Change subject: deps: Update SCTPasp ...................................................................... deps: Update SCTPasp Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Related: OS#5366 --- M deps/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/26674/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Gerrit-Change-Number: 26674 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 15:31:10 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 22 Dec 2021 15:31:10 +0000 Subject: Change in osmo-ttcn3-hacks[master]: deps: Update SCTPasp to fix SCTP kernel ABI breakage In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 to look at the new patch set (#3). Change subject: deps: Update SCTPasp to fix SCTP kernel ABI breakage ...................................................................... deps: Update SCTPasp to fix SCTP kernel ABI breakage Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Related: OS#5366 --- M deps/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/26674/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Gerrit-Change-Number: 26674 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 15:31:27 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 22 Dec 2021 15:31:27 +0000 Subject: Change in osmo-ttcn3-hacks[master]: deps: Update SCTPasp to fix SCTP kernel ABI breakage In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 ) Change subject: deps: Update SCTPasp to fix SCTP kernel ABI breakage ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674/1//COMMIT_MSG at 7 PS1, Line 7: deps: Update SCTPasp to fix SCTP kernal ABI breakage > kernel Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Gerrit-Change-Number: 26674 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 15:31:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 16:16:12 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 16:16:12 +0000 Subject: Change in osmo-mgw[master]: mgcp_client: add new codec "IUUP" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26651 ) Change subject: mgcp_client: add new codec "IUUP" ...................................................................... Patch Set 1: Code-Review-1 I actually think the correct mime tyoe / name to use is vnd.3gpp.iufp as defined in https://www.iana.org/assignments/media-types/audio/vnd.3gpp.iufp 3GPP TS 29.415 "elevates" the IuUP protocol on the IuCS/Iuh interface to the IuFP protocol on the Nb interface between MGWs in the CN. See also https://osmocom.org/issues/1937#note-9 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd1210a897743396899f34457c96e6fd2109c6b3 Gerrit-Change-Number: 26651 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 22 Dec 2021 16:16:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 16:16:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 16:16:49 +0000 Subject: Change in osmo-ttcn3-hacks[master]: deps: Update SCTPasp to fix SCTP kernel ABI breakage In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 ) Change subject: deps: Update SCTPasp to fix SCTP kernel ABI breakage ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Gerrit-Change-Number: 26674 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 22 Dec 2021 16:16:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 16:16:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 22 Dec 2021 16:16:51 +0000 Subject: Change in osmo-ttcn3-hacks[master]: deps: Update SCTPasp to fix SCTP kernel ABI breakage In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 ) Change subject: deps: Update SCTPasp to fix SCTP kernel ABI breakage ...................................................................... deps: Update SCTPasp to fix SCTP kernel ABI breakage Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Related: OS#5366 --- M deps/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/deps/Makefile b/deps/Makefile index 9296f1b..5c69ee9 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -120,7 +120,7 @@ titan.TestPorts.MTP3asp_commit= 1cecdad6f3641a5f19b3833703bff6e5005eff11 titan.TestPorts.PCAPasp_commit= R.8.A-3-g9ad320f titan.TestPorts.PIPEasp_commit= R.7.D-3-g8b01154 -titan.TestPorts.SCTPasp_commit= R.11.A-7-ga21b94f +titan.TestPorts.SCTPasp_commit= R.11.A-8-g2e911c3 titan.TestPorts.SIPmsg_commit= R.15.A-1-ge4f9dd0 titan.TestPorts.TCPasp_commit= R.9.A-5-g2c91bc6 titan.TestPorts.TELNETasp_commit= 873fe539642542cd9a901c208f1ec11c6d2f5387 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I257ab571eef1a7ef18998ad0976b1992482e74c4 Gerrit-Change-Number: 26674 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 18:58:18 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 18:58:18 +0000 Subject: Change in osmo-hnodeb[master]: Get rid of libgtp for GTP-U References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26675 ) Change subject: Get rid of libgtp for GTP-U ...................................................................... Get rid of libgtp for GTP-U It doesn't make much sense to pull whole libgtp to implement only the user plan side of GTP. Let's drop it and add a minimal GTP-U implementation here. Related: SYS#5516 Change-Id: I53ad4915aaed3bc7574036e963be10514e370fe2 --- M configure.ac M contrib/jenkins.sh M contrib/osmo-hnodeb.spec.in M debian/control M include/osmocom/hnodeb/gtp.h M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk_gtp.c 10 files changed, 264 insertions(+), 172 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/75/26675/1 diff --git a/configure.ac b/configure.ac index 8a34b82..e96a6a1 100644 --- a/configure.ac +++ b/configure.ac @@ -67,7 +67,6 @@ PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 0.8.0) PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.8.0) PKG_CHECK_MODULES(LIBOSMOHNBAP, libosmo-hnbap >= 0.8.0) -PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.8.0) dnl checks for header files diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 3225de2..7001013 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -34,7 +34,6 @@ osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sccp osmo-build-dep.sh libasn1c -osmo-build-dep.sh osmo-ggsn osmo-build-dep.sh osmo-iuh # Additional configure options and depends diff --git a/contrib/osmo-hnodeb.spec.in b/contrib/osmo-hnodeb.spec.in index afa1816..aa33057 100644 --- a/contrib/osmo-hnodeb.spec.in +++ b/contrib/osmo-hnodeb.spec.in @@ -47,7 +47,6 @@ BuildRequires: pkgconfig(libosmo-rua) >= 0.8.0 BuildRequires: pkgconfig(talloc) BuildRequires: pkgconfig(libasn1c) >= 0.9.30 -BuildRequires: pkgconfig(libgtp) >= 1.8.0 %{?systemd_requires} %description diff --git a/debian/control b/debian/control index 503b202..a306e10 100644 --- a/debian/control +++ b/debian/control @@ -13,7 +13,6 @@ python3-minimal, libtalloc-dev, libasn1c-dev (>= 0.9.30), - libgtp-dev (>= 1.8.0), libsctp-dev, libosmocore-dev (>= 1.6.0), libosmo-sigtran-dev (>= 1.5.0), diff --git a/include/osmocom/hnodeb/gtp.h b/include/osmocom/hnodeb/gtp.h index 477e82b..5fa47c3 100644 --- a/include/osmocom/hnodeb/gtp.h +++ b/include/osmocom/hnodeb/gtp.h @@ -18,9 +18,6 @@ */ #pragma once -#include -#include - #include #include @@ -38,11 +35,11 @@ struct osmo_sockaddr rem_addr; uint32_t loc_tei; uint32_t rem_tei; - struct pdp_t *pdp_lib; + uint16_t seq_nr; }; struct gtp_conn *gtp_conn_alloc(struct hnb_ue *ue); void gtp_conn_free(struct gtp_conn *conn); int gtp_conn_setup(struct gtp_conn *conn, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei); -int gtp_conn_tx(struct gtp_conn *conn, void *gtpu_payload, unsigned gtpu_payload_len); +int gtp_conn_tx(struct gtp_conn *conn, const uint8_t *gtpu_payload, unsigned gtpu_payload_len); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 82b43c3..924e1ac 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -107,8 +107,7 @@ struct gtp { char *cfg_local_addr; struct osmo_sockaddr local_addr; - struct gsn_t *gsn; - struct osmo_fd fd1u; + struct osmo_wqueue wq1u; } gtp; uint16_t rnc_id; diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 6edbf88..27987a1 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -19,7 +19,6 @@ $(LIBOSMORUA_CFLAGS) \ $(LIBOSMORANAP_CFLAGS) \ $(LIBOSMOHNBAP_CFLAGS) \ - $(LIBGTP_CFLAGS) \ $(NULL) AM_LDFLAGS = \ @@ -63,5 +62,4 @@ $(LIBOSMORANAP_LIBS) \ $(LIBOSMOHNBAP_LIBS) \ $(LIBSCTP_LIBS) \ - $(LIBGTP_LIBS) \ $(NULL) diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c index f7d9a14..c22de65 100644 --- a/src/osmo-hnodeb/gtp.c +++ b/src/osmo-hnodeb/gtp.c @@ -23,11 +23,27 @@ #include #include #include +#include -#include -#include +/* 3GPP TS 29.281 */ +struct gtp1u_hdr { /* 3GPP TS 29.281 */ +#if OSMO_IS_LITTLE_ENDIAN + uint8_t pn:1, /* N-PDU Number flag */ + s:1, /* Sequence number flag */ + e:1, /* Extension header flag */ + spare:1, + pt:1, /* Protocol Type: GTP=1, GTP'=0 */ + version:3; /* Version: 1 */ +#elif OSMO_IS_BIG_ENDIAN + uint8_t version:3, pt:1, spare:1, e:1, s:1, pn:1; +#endif + uint8_t msg_type; + uint16_t length; + uint32_t tei; /* 05 - 08 Tunnel Endpoint ID */ + uint8_t data[0]; +} __attribute__((packed)); -static uint32_t next_gtp_conn_id = 0; +static uint32_t next_gtp_conn_id = 1; struct gtp_conn *gtp_conn_alloc(struct hnb_ue *ue) { @@ -49,14 +65,231 @@ if (!conn) return; - if (conn->pdp_lib) { - pdp_freepdp(conn->pdp_lib); - conn->pdp_lib = NULL; - } llist_del(&conn->list); talloc_free(conn); } +int gtp_conn_setup(struct gtp_conn *conn, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei) +{ + struct hnb_ue *ue = conn->ue; + struct hnb *hnb = ue->hnb; + + LOGUE(ue, DGTP, LOGL_INFO, "Creating PDP context\n"); + + + if (rem_addr->u.sa.sa_family != AF_INET) { + LOGUE(ue, DGTP, LOGL_ERROR, "Failed creating PDP context: unsupported proto family %u\n", + rem_addr->u.sa.sa_family); + return -ENOTSUP; + } + + conn->id = next_gtp_conn_id++; /* TODO: validate next one is not already taken due to wrap-around */ + + conn->loc_addr = hnb->gtp.local_addr; + conn->rem_addr = *rem_addr; + conn->rem_tei = rem_tei; + conn->loc_tei = conn->id; /* We use conn ID as local TEI */ + return 0; +} + +int gtp_conn_tx(struct gtp_conn *conn, const uint8_t *gtpu_payload, unsigned gtpu_payload_len) +{ + int rc; + struct hnb_ue *ue; + struct hnb *hnb; + struct msgb *msg; + struct gtp1u_hdr *hdr; + struct osmo_sockaddr *sa; + const uint8_t opt_hdr_len = 4; + unsigned msg_len = sizeof(*hdr) + opt_hdr_len + gtpu_payload_len; + + if (!conn) { + LOGP(DGTP, LOGL_ERROR, "Tx: GTP-U conn not available\n"); + return -EINVAL; + } + + ue = conn->ue; + hnb = ue->hnb; + + if (hnb->gtp.wq1u.bfd.fd == -1) { + LOGP(DGTP, LOGL_ERROR, "Tx: GTP-U socket not available\n"); + return -EINVAL; + } + + if (gtpu_payload_len == 0) { + LOGP(DGTP, LOGL_ERROR, "Tx: GTP-U len=0\n"); + return -EINVAL; + } + + msg = msgb_alloc_c(hnb, sizeof(*sa) + msg_len, "gtp-ul"); + + sa = (struct osmo_sockaddr *)msgb_put(msg, sizeof(*sa)); + *sa = conn->rem_addr; + + hdr = (struct gtp1u_hdr *)msgb_put(msg, msg_len); + hdr->pn = 0; + hdr->s = 1; + hdr->e = 0; + hdr->spare = 0; + hdr->pt = 1; + hdr->version = 1; + hdr->msg_type = 0xff; + osmo_store16be(gtpu_payload_len + opt_hdr_len, &hdr->length); + osmo_store32be(conn->rem_tei, &hdr->tei); + osmo_store16be(conn->seq_nr, &hdr->data[0]); + conn->seq_nr++; + /* byes 2 and 3 are set to 0 */ + memcpy(&hdr->data[opt_hdr_len], gtpu_payload, gtpu_payload_len); + + rc = osmo_wqueue_enqueue(&hnb->gtp.wq1u, msg); + if (rc < 0) + msgb_free(msg); + + return rc; +} + +/* Called whenever we receive a DATA packet */ +static int hnb_gtp_rx_gtp(struct hnb *hnb, struct msgb *msg, const struct osmo_sockaddr *from) +{ + struct gtp_conn *conn; + struct hnb_ue *ue; + struct gtp1u_hdr *hdr; + uint32_t tei; + struct hnb_gtp_prim *gtp_prim; + int rc; + + hdr = (struct gtp1u_hdr *)msgb_data(msg); + tei = osmo_load32be(&hdr->tei); + + /* The local TEI is the GTP conn_id: */ + conn = hnb_find_gtp_conn_by_id(hnb, tei); + if (!conn) { + LOGP(DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind len=%u with no conn!\n", + msgb_l3len(msg)); + rc = -EINVAL; + goto free_ret; + } + ue = conn->ue; + + if (osmo_sockaddr_cmp(from, &conn->rem_addr)) { + LOGUE(ue, DGTP, LOGL_NOTICE, "Rx DL GTP-U loc_tei=0x%08x from unexpected addr=%s!\n", + tei, osmo_sockaddr_to_str(from)); + rc = -EINVAL; + goto free_ret; + } + ue = conn->ue; + + if (!ue->conn_ps.active) { + LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind len=%u but UE conn_ps is not active!\n", + msgb_l3len(msg)); + rc = -EINVAL; + goto free_ret; + } + hnb = ue->hnb; + + LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind len=%u\n", msgb_l3len(msg)); + gtp_prim = hnb_gtp_makeprim_conn_data_ind(conn->id, msgb_l3(msg), msgb_l3len(msg)); + if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { + LOGUE(ue, DGTP, LOGL_ERROR, "Failed Tx GTP-CONN_DATA.ind len=%u\n", + msgb_l3len(msg)); + } +free_ret: + msgb_free(msg); + return rc; +} + +static int hnb_gtp_wq_read_cb(struct osmo_fd *fd) +{ + struct hnb *hnb = (struct hnb *)fd->data; + struct msgb *msg; + struct gtp1u_hdr *hdr; + int rc; + struct osmo_sockaddr peer; + socklen_t peerlen = sizeof(peer.u.sas); + unsigned int opt_hdr_len; + uint16_t pl_len; + + msg = msgb_alloc_c(hnb, 4096, "gtp-dl"); + + rc = recvfrom(hnb->gtp.wq1u.bfd.fd, msgb_data(msg), msg->data_len, 0, + &peer.u.sa, &peerlen); + if (rc <= 0) { + LOGP(DGTP, LOGL_ERROR, "recvfrom() failed: rc = %d error = %s\n", + rc, rc ? strerror(errno) : "No error"); + goto free_ret; + } + msgb_put(msg, rc); + + /* Do some sanity checks: */ + if (msgb_length(msg) < sizeof(*hdr)) { + LOGP(DGTP, LOGL_ERROR, "Rx GTP-U packet with size %u < %zu (header)\n", + msgb_length(msg), sizeof(*hdr)); + rc = -EINVAL; + goto free_ret; + } + + hdr = (struct gtp1u_hdr *)msgb_data(msg); + pl_len = osmo_load16be(&hdr->length); + + /* Do some sanity checks: */ + if (hdr->version != 1) { + LOGP(DGTP, LOGL_ERROR, "Rx GTP-U version %u != 1\n", hdr->version); + rc = -ENOTSUP; + goto free_ret; + } + + if (hdr->e == 1) { + LOGP(DGTP, LOGL_ERROR, "Rx GTP-U with Extension Header not supported\n"); + rc = -ENOTSUP; + goto free_ret; + } + + if (hdr->s || hdr->pn || hdr->e) + opt_hdr_len = 4; + if (hdr->pn) + opt_hdr_len = 0; + + if (msgb_length(msg) < sizeof(*hdr) + opt_hdr_len) { + LOGP(DGTP, LOGL_ERROR, "Rx GTP-U packet with size %u < %zu (header + opt)\n", + msgb_length(msg), sizeof(*hdr) + opt_hdr_len); + rc = -EINVAL; + goto free_ret; + } + + msg->l3h = msgb_data(msg) + sizeof(*hdr) + opt_hdr_len; + + if (pl_len < opt_hdr_len || msgb_l3len(msg) != (pl_len - opt_hdr_len)) { + LOGP(DGTP, LOGL_ERROR, "Rx GTP-U packet with payload size %u != %u (header)\n", + msgb_length(msg), pl_len - opt_hdr_len); + rc = -EINVAL; + goto free_ret; + } + + return hnb_gtp_rx_gtp(hnb, msg, &peer); +free_ret: + msgb_free(msg); + return rc; +} + +static int hnb_gtp_wq_write_cb(struct osmo_fd *fd, struct msgb *msg) +{ + struct hnb *hnb = (struct hnb *)fd->data; + struct osmo_sockaddr *rem_addr; + int rc; + + rem_addr = (struct osmo_sockaddr *)msgb_data(msg); + msgb_pull(msg, sizeof(*rem_addr)); + + rc = sendto(hnb->gtp.wq1u.bfd.fd, msgb_data(msg), msgb_length(msg), 0, + &rem_addr->u.sa, sizeof(*rem_addr)); + if (rc < 0) { + int err = errno; + LOGP(DGTP, LOGL_ERROR, "GTP1-U sendto(len=%d, to=%s) failed: Error = %s\n", + msgb_length(msg), osmo_sockaddr_to_str(rem_addr), strerror(err)); + } + return rc; +} + /* Get osa of locally bound GTP-U socket */ static int sk_get_bound_addr(int fd, struct osmo_sockaddr *osa) { @@ -70,173 +303,43 @@ return 0; } -/* Called whenever we receive a DATA packet */ -static int hnb_gtp_cb_data_ind(struct pdp_t *lib, void *packet, unsigned int len) -{ - struct hnb_gtp_prim *gtp_prim; - struct gtp_conn *conn = lib->priv; - struct hnb_ue *ue; - struct hnb *hnb; - int rc; - - if (!conn) { - LOGP(DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u with no conn!\n", - packet, len); - return -EINVAL; - } - ue = conn->ue; - - if (!ue->conn_ps.active) { - LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", - packet, len); - return -EINVAL; - } - hnb = ue->hnb; - - LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len); - gtp_prim = hnb_gtp_makeprim_conn_data_ind(conn->id, packet, len); - if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { - LOGUE(ue, DGTP, LOGL_ERROR, "Failed Tx GTP-CONN_DATA.ind data=%p len=%u\n", - packet, len); - } - return rc; -} - -/* libgtp select loop integration */ -static int hnb_gtp_fd_cb(struct osmo_fd *fd, unsigned int what) -{ - struct hnb *hnb = fd->data; - int rc; - - if (!(what & OSMO_FD_READ)) - return 0; - - switch (fd->priv_nr) { - case 0: - rc = gtp_decaps1u(hnb->gtp.gsn); - break; - default: - rc = -EINVAL; - break; - } - return rc; -} - int hnb_gtp_bind(struct hnb *hnb) { int rc; - struct gsn_t *gsn; - struct in_addr inaddr; - rc = inet_pton(AF_INET, hnb->gtp.cfg_local_addr, &inaddr); - if (rc <= 0) - return -EINVAL; + OSMO_ASSERT(hnb->gtp.wq1u.bfd.fd == -1); - /* TODO: add new mode GTP_MODE_GTPU_ONLY to set up gtpu side only (and ignore statedir) */ - rc = gtp_new(&gsn, "/tmp", &inaddr, GTP_MODE_SGSN); + hnb->gtp.wq1u.read_cb = hnb_gtp_wq_read_cb; + hnb->gtp.wq1u.write_cb = hnb_gtp_wq_write_cb; + + rc = osmo_sock_init2_ofd(&hnb->gtp.wq1u.bfd, AF_UNSPEC, SOCK_DGRAM, IPPROTO_UDP, + hnb->gtp.cfg_local_addr, 2152, NULL, 0, OSMO_SOCK_F_BIND); if (rc < 0) { LOGP(DGTP, LOGL_ERROR, "Failed to set up GTP socket: %s\n", strerror(-rc)); return rc; } - rc = sk_get_bound_addr(gsn->fd1u, &hnb->gtp.local_addr); + rc = sk_get_bound_addr(hnb->gtp.wq1u.bfd.fd, &hnb->gtp.local_addr); if (rc < 0) { LOGP(DGTP, LOGL_ERROR, "Failed to get GTP-U socket bound address: %s\n", strerror(-rc)); goto free_ret; } - - osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0); - if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0) - goto free_ret; - - gtp_set_cb_data_ind(gsn, hnb_gtp_cb_data_ind); - - hnb->gtp.gsn = gsn; return 0; free_ret: - gtp_free(gsn); - hnb->gtp.fd1u.fd = -1; + if (hnb->gtp.wq1u.bfd.fd != -1) { + close(hnb->gtp.wq1u.bfd.fd); + hnb->gtp.wq1u.bfd.fd = -1; + } return rc; } void hnb_gtp_unbind(struct hnb *hnb) { - osmo_fd_unregister(&hnb->gtp.fd1u); - gtp_free(hnb->gtp.gsn); - hnb->gtp.gsn = NULL; - hnb->gtp.fd1u.fd = -1; -} - -int gtp_conn_setup(struct gtp_conn *conn, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei) -{ - int rc; - struct hnb_ue *ue = conn->ue; - struct hnb *hnb = ue->hnb; - struct pdp_t *pdp; - struct in_addr rem_in; - - LOGUE(ue, DGTP, LOGL_INFO, "Creating PDP context\n"); - - - if (rem_addr->u.sa.sa_family != AF_INET) { - LOGUE(ue, DGTP, LOGL_ERROR, "Failed creating PDP context: unsupported proto family %u\n", - rem_addr->u.sa.sa_family); - return -ENOTSUP; + if (hnb->gtp.wq1u.bfd.fd != -1) { + osmo_wqueue_clear(&hnb->gtp.wq1u); + osmo_fd_unregister(&hnb->gtp.wq1u.bfd); + close(hnb->gtp.wq1u.bfd.fd); + hnb->gtp.wq1u.bfd.fd = -1; } - - conn->rem_addr = *rem_addr; - conn->rem_tei = rem_tei; - rem_in = rem_addr->u.sin.sin_addr; - conn->id = next_gtp_conn_id++; /* TODO: validate next one is not already taken due to wrap-around */ - - rc = gtp_pdp_newpdp(hnb->gtp.gsn, &pdp, conn->id, 0 /* TODO: NSAPI? */, NULL); - if (rc < 0) { - LOGUE(ue, DGTP, LOGL_ERROR, "Failed creating PDP context: %s\n", strerror(-rc)); - return rc; - } - pdp->priv = conn; - conn->pdp_lib = pdp; - - pdp->teid_gn = rem_tei; - pdp->version = 1; - pdp->hisaddr0 = rem_in; - pdp->hisaddr1 = rem_in; - - pdp->gsnru.l = sizeof(rem_in); - memcpy(pdp->gsnru.v, &rem_in, sizeof(rem_in)); - - - pdp->gsnlu.l = sizeof(hnb->gtp.local_addr.u.sin.sin_addr); - memcpy(pdp->gsnlu.v, &hnb->gtp.local_addr.u.sin.sin_addr, - sizeof(hnb->gtp.local_addr.u.sin.sin_addr)); - - conn->loc_addr = hnb->gtp.local_addr; - //loc_addr->u.sin.sin_family = AF_INET; - //loc_addr->u.sin.sin_addr = hnb->gtp.gsn->gsnu; - //loc_addr->u.sin.sin_port = GTP1U_PORT; - conn->loc_tei = pdp->teid_own; - return 0; -} - -int gtp_conn_tx(struct gtp_conn *conn, void *gtpu_payload, unsigned gtpu_payload_len) -{ - int rc; - struct hnb_ue *ue; - struct hnb *hnb; - - if (!conn || !conn->pdp_lib) { - LOGP(DGTP, LOGL_ERROR, "Tx: PDP Ctx not available\n"); - return -EINVAL; - } - - ue = conn->ue; - hnb = ue->hnb; - if (!hnb->gtp.gsn) { - LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n"); - return -EINVAL; - } - - rc = gtp_data_req(hnb->gtp.gsn, conn->pdp_lib, gtpu_payload, gtpu_payload_len); - return rc; } diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index fe2f4f5..18f39b4 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -61,7 +61,9 @@ hnb->rtp.priority = -1; hnb->gtp.cfg_local_addr = talloc_strdup(hnb, "0.0.0.0"); - hnb->gtp.fd1u.fd = -1; + osmo_wqueue_init(&hnb->gtp.wq1u, 1024); + hnb->gtp.wq1u.bfd.data = hnb; + hnb->gtp.wq1u.bfd.fd = -1; hnb->shutdown_fi = osmo_fsm_inst_alloc(&hnb_shutdown_fsm, hnb, hnb, LOGL_INFO, NULL); @@ -90,10 +92,7 @@ osmo_prim_srv_link_free(hnb->llsk_link); hnb->llsk_link = NULL; - if (hnb->gtp.gsn) { - gtp_free(hnb->gtp.gsn); - hnb->gtp.gsn = NULL; - } + hnb_gtp_unbind(hnb); talloc_free(hnb); } diff --git a/src/osmo-hnodeb/llsk_gtp.c b/src/osmo-hnodeb/llsk_gtp.c index a224d56..775df50 100644 --- a/src/osmo-hnodeb/llsk_gtp.c +++ b/src/osmo-hnodeb/llsk_gtp.c @@ -138,7 +138,7 @@ union u_addr loc_uaddr = {0}; struct gtp_conn *conn = NULL; - rc = ll_addr2osa(ce_req->remote_gtpu_address_type, &ce_req->remote_gtpu_addr, GTP1U_PORT, &rem_osa); + rc = ll_addr2osa(ce_req->remote_gtpu_address_type, &ce_req->remote_gtpu_addr, 2152, &rem_osa); if (rc < 0) { LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: ctx=%u with unexpected address type %u\n", ce_req->context_id, ce_req->remote_gtpu_address_type); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I53ad4915aaed3bc7574036e963be10514e370fe2 Gerrit-Change-Number: 26675 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 22 19:01:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 22 Dec 2021 19:01:02 +0000 Subject: Change in docker-playground[master]: osmo-hnodeb-master: no longer depend on libgtp References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26676 ) Change subject: osmo-hnodeb-master: no longer depend on libgtp ...................................................................... osmo-hnodeb-master: no longer depend on libgtp Newer osmo-hnodeb no longer depend on libgtp, get rid od the dependency. Depends: osmo-hnodeb.git Change-Id I53ad4915aaed3bc7574036e963be10514e370fe2 Related: SYS#5516 Change-Id: I4e223823d08c7e9e17d87f54d9554429d31c8091 --- M osmo-hnodeb-master/Dockerfile 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/76/26676/1 diff --git a/osmo-hnodeb-master/Dockerfile b/osmo-hnodeb-master/Dockerfile index a7ff068..1a3ded9 100644 --- a/osmo-hnodeb-master/Dockerfile +++ b/osmo-hnodeb-master/Dockerfile @@ -10,7 +10,6 @@ libosmo-abis-dev \ libosmo-netif-dev \ libosmo-sigtran-dev \ - libgtp-dev \ libasn1c-dev && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26676 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4e223823d08c7e9e17d87f54d9554429d31c8091 Gerrit-Change-Number: 26676 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Dec 23 00:32:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 23 Dec 2021 00:32:52 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c3c3ba7798d_26fb2ae6b519c5f027417e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 16s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 16s] exit ... [ 16s] ### VM INTERACTION START ### [ 19s] [ 9.187506] sysrq: Power Off [ 19s] [ 9.190544] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] lamb13 failed "build libosmocore.spec" at Thu Dec 23 00:32:43 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 23 00:33:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 23 Dec 2021 00:33:09 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c3c3d9292_26fb2ae6b519c5f0274320@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 40s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 40s] exit ... [ 40s] ### VM INTERACTION START ### [ 44s] [ 9.180749] sysrq: SysRq : Power Off [ 44s] [ 9.181270] reboot: Power down [ 44s] ### VM INTERACTION END ### [ 44s] [ 44s] obs-arm-11 failed "build libosmocore.spec" at Thu Dec 23 00:32:53 UTC 2021. [ 44s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 23 00:38:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 23 Dec 2021 00:38:35 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c3c52540e27_26fb2ae6b519c5f02761f4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 41s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 41s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 42s] exit ... [ 42s] ### VM INTERACTION START ### [ 45s] [ 16.206800] sysrq: SysRq : Power Off [ 45s] [ 16.209409] reboot: Power down [ 45s] ### VM INTERACTION END ### [ 45s] [ 45s] obs-arm-6 failed "build libosmocore.spec" at Thu Dec 23 00:38:28 UTC 2021. [ 45s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 23 00:41:09 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 23 Dec 2021 00:41:09 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c3c5b79e603_26fb2ae6b519c5f02766c2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 55s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 55s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 55s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 56s] exit ... [ 56s] ### VM INTERACTION START ### [ 58s] [ 11.897540] sysrq: SysRq : Power Off [ 58s] [ 12.009315] reboot: Power down [ 58s] ### VM INTERACTION END ### [ 58s] [ 58s] lamb62 failed "build libosmocore.spec" at Thu Dec 23 00:41:02 UTC 2021. [ 58s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 23 01:40:35 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 23 Dec 2021 01:40:35 +0000 Subject: Build failure of network:osmocom:nightly/osmo-cbc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61c3d3a98a862_26fb2ae6b519c5f0287655@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-cbc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: [ 235s] #define VERSION "0.2.3" [ 235s] #define STDC_HEADERS 1 [ 235s] #define HAVE_SYS_TYPES_H 1 [ 235s] #define HAVE_SYS_STAT_H 1 [ 235s] #define HAVE_STDLIB_H 1 [ 235s] #define HAVE_STRING_H 1 [ 235s] #define HAVE_MEMORY_H 1 [ 235s] #define HAVE_STRINGS_H 1 [ 235s] #define HAVE_INTTYPES_H 1 [ 235s] #define HAVE_STDINT_H 1 [ 235s] #define HAVE_UNISTD_H 1 [ 235s] #define HAVE_DLFCN_H 1 [ 235s] #define LT_OBJDIR ".libs/" [ 235s] [ 235s] configure: exit 1 [ 235s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 235s] debian/rules:50: recipe for target 'override_dh_auto_configure' failed [ 235s] make[1]: *** [override_dh_auto_configure] Error 2 [ 235s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 235s] debian/rules:45: recipe for target 'build' failed [ 235s] make: *** [build] Error 2 [ 235s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 235s] ### VM INTERACTION START ### [ 238s] [ 224.673457] sysrq: Power Off [ 238s] [ 224.676552] reboot: Power down [ 238s] ### VM INTERACTION END ### [ 238s] [ 238s] old-cirrus4 failed "build osmo-cbc_0.2.3.202112230026.dsc" at Thu Dec 23 01:40:29 UTC 2021. [ 238s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Thu Dec 23 02:40:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 23 Dec 2021 02:40:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <61c3e1a8bcb2e_26fb2ae6b519c5f02966af@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 151s] #define HAVE_SYS_TYPES_H 1 [ 151s] #define HAVE_SYS_STAT_H 1 [ 151s] #define HAVE_STDLIB_H 1 [ 151s] #define HAVE_STRING_H 1 [ 151s] #define HAVE_MEMORY_H 1 [ 151s] #define HAVE_STRINGS_H 1 [ 151s] #define HAVE_INTTYPES_H 1 [ 151s] #define HAVE_STDINT_H 1 [ 151s] #define HAVE_UNISTD_H 1 [ 151s] #define HAVE_DLFCN_H 1 [ 151s] #define LT_OBJDIR ".libs/" [ 151s] #define PACKAGE "osmo-remsim" [ 151s] #define VERSION "1.0.0.4-0c832" [ 151s] [ 151s] configure: exit 1 [ 151s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals returned exit code 1 [ 151s] debian/rules:17: recipe for target 'override_dh_auto_configure' failed [ 151s] make[1]: *** [override_dh_auto_configure] Error 2 [ 151s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 151s] debian/rules:14: recipe for target 'build' failed [ 151s] make: *** [build] Error 2 [ 151s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 151s] ### VM INTERACTION START ### [ 154s] [ 145.594929] sysrq: Power Off [ 154s] [ 145.596535] reboot: Power down [ 154s] ### VM INTERACTION END ### [ 154s] [ 154s] goat15 failed "build osmo-remsim_1.0.0.4.0c832.202112230026.dsc" at Thu Dec 23 02:40:07 UTC 2021. [ 154s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Dec 23 09:15:48 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 09:15:48 +0000 Subject: Change in osmo-ci[master]: OBS, ttcn3-testsuites: add 2021q4 In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26669 ) Change subject: OBS, ttcn3-testsuites: add 2021q4 ...................................................................... OBS, ttcn3-testsuites: add 2021q4 Related: SYS#5726 Change-Id: I4913218b192cf0cb1fb74b239ced9a0501c2eb48 --- M jobs/ttcn3-testsuites.yml M scripts/common-obs.sh M scripts/osmocom-nightly-packages.sh 3 files changed, 25 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index bcbbab5..113f4cd 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -348,6 +348,29 @@ blocking: "^(ttcn3|TTCN3-.*)-gbproxy-test.*" timer: 30 12 * * * + # centos8 2021q4 (SYS#5726) + - TTCN3-centos-pcu-test-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-pcu-test.*" + timer: 00 13 * * * + - TTCN3-centos-pcu-test-sns-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-pcu-test.*" + timer: 15 13 * * * + - TTCN3-centos-bsc-test-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-bsc-test.*" + timer: 30 13 * * * + - TTCN3-centos-mgw-test-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-mgw-test.*" + timer: 45 13 * * * + - TTCN3-centos-bts-test-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-bts-test.*" + timer: 00 14 * * * + - TTCN3-centos-smlc-test-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-smlc-test.*" + timer: 15 14 * * * + - TTCN3-centos-gbproxy-test-2021q4: + blocking: "^(ttcn3|TTCN3-.*)-gbproxy-test.*" + timer: 30 14 * * * + - job-template: name: '{job-name}' project-type: freestyle diff --git a/scripts/common-obs.sh b/scripts/common-obs.sh index 1a10eb6..e53a7aa 100644 --- a/scripts/common-obs.sh +++ b/scripts/common-obs.sh @@ -4,6 +4,7 @@ FEEDS_ALL=" 2021q1 + 2021q4 latest next nightly diff --git a/scripts/osmocom-nightly-packages.sh b/scripts/osmocom-nightly-packages.sh index 4d21cd7..2a70c31 100755 --- a/scripts/osmocom-nightly-packages.sh +++ b/scripts/osmocom-nightly-packages.sh @@ -16,6 +16,7 @@ # Values for FEED env var. Adjust FEEDS_ALL in common-obs when changing. FEEDS=" 2021q1 + 2021q4 next nightly " -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4913218b192cf0cb1fb74b239ced9a0501c2eb48 Gerrit-Change-Number: 26669 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 09:28:38 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 09:28:38 +0000 Subject: Change in libosmocore[master]: select_main: don't poll forever during shutdown In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26663 ) Change subject: select_main: don't poll forever during shutdown ...................................................................... Patch Set 1: (Not merging yet so Neels has a chance to review) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81c64a7ae440304522c2179c212023a566ddced8 Gerrit-Change-Number: 26663 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 23 Dec 2021 09:28:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 09:47:37 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 09:47:37 +0000 Subject: Change in osmo-bsc-nat[master]: Add project skeleton In-Reply-To: References: Message-ID: Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 to look at the new patch set (#2). Change subject: Add project skeleton ...................................................................... Add project skeleton It was decided to write OsmoBSCNAT with 3GPP AoIP support from scratch, in a separate repository from OsmoBSC. The previous codebase was too heavily tied into legacy SCCPlite code and had been removed from osmo-bsc.git in Ia05dc76336a64a7f08962843b9a7cc19f2c83387. Related: OS#2545 Change-Id: Iae5d37483dcb9db00578d5c9cd1736f08754a65e --- A .gitignore A .gitreview A AUTHORS A COPYING A Makefile.am A README.md A configure.ac A contrib/Makefile.am A contrib/jenkins.sh A contrib/osmo-bsc-nat.spec.in A contrib/systemd/Makefile.am A contrib/systemd/osmo-bsc-nat.service A debian/changelog A debian/compat A debian/control A debian/copyright A debian/osmo-bsc-nat.install A debian/rules A debian/source/format A doc/Makefile.am A doc/examples/Makefile.am A doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg A doc/manuals/Makefile.am A doc/manuals/chapters/overview.adoc A doc/manuals/osmobscnat-usermanual-docinfo.xml A doc/manuals/osmobscnat-usermanual.adoc A doc/manuals/osmobscnat-vty-reference.xml A doc/manuals/regen_doc.sh A doc/manuals/vty/bsc_nat_vty_additions.xml A git-version-gen A include/Makefile.am A include/osmocom/Makefile.am A include/osmocom/bsc_nat/Makefile.am A include/osmocom/bsc_nat/bsc_nat.h A osmoappdesc.py A src/Makefile.am A src/osmo-bsc-nat/Makefile.am A src/osmo-bsc-nat/main.c A tests/Makefile.am A tests/atlocal.in A tests/ctrl_test_runner.py A tests/osmo-bsc-nat.vty A tests/testsuite.at 43 files changed, 2,144 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/58/26658/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Iae5d37483dcb9db00578d5c9cd1736f08754a65e Gerrit-Change-Number: 26658 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 09:48:29 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 09:48:29 +0000 Subject: Change in osmo-bsc-nat[master]: Add project skeleton In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 ) Change subject: Add project skeleton ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/configure.ac File configure.ac: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/configure.ac at 53 PS1, Line 53: P > will we need ASN. [?] Done https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/jenkins.sh File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/jenkins.sh at 32 PS1, Line 32: osm > does not include libasn1c which configure.ac is requiring (probably wrongly so). Ack https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/osmo-bsc-nat.spec.in File contrib/osmo-bsc-nat.spec.in: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/1/contrib/osmo-bsc-nat.spec.in at 41 PS1, Line 41: Bui > why would we need libosmogb here? configure.ac doesn't list it, and I cannot think of a reason. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Iae5d37483dcb9db00578d5c9cd1736f08754a65e Gerrit-Change-Number: 26658 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 23 Dec 2021 09:48:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 11:07:28 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 23 Dec 2021 11:07:28 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26454 to look at the new patch set (#17). Change subject: select: gather statistics for TCP connections ...................................................................... select: gather statistics for TCP connections osmocom applications are deployed in a variety of different situations. Dependung on the medium that interconnects the network components unexpected behaviour may occur. To debug problems with the interconnection between network components it might help to monitor the health of the related TCP connections. Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Related: SYS#5701 --- M configure.ac M include/Makefile.am A include/osmocom/core/stats_tcp.h M src/Makefile.am M src/select.c M src/stats.c A src/stats_tcp.c M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 9 files changed, 406 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/26454/17 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 17 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 11:14:20 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 23 Dec 2021 11:14:20 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26454 to look at the new patch set (#18). Change subject: select: gather statistics for TCP connections ...................................................................... select: gather statistics for TCP connections osmocom applications are deployed in a variety of different situations. Dependung on the medium that interconnects the network components unexpected behaviour may occur. To debug problems with the interconnection between network components it might help to monitor the health of the related TCP connections. Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Related: SYS#5701 --- M configure.ac M include/Makefile.am A include/osmocom/core/stats_tcp.h M src/Makefile.am M src/select.c M src/stats.c A src/stats_tcp.c M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 9 files changed, 406 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/26454/18 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 18 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 12:27:22 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 23 Dec 2021 12:27:22 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 18: I have added a config option to configure the batch size per interval. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 18 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 23 Dec 2021 12:27:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 13:41:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 23 Dec 2021 13:41:15 +0000 Subject: Change in osmo-bsc-nat[master]: Add project skeleton In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 ) Change subject: Add project skeleton ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Iae5d37483dcb9db00578d5c9cd1736f08754a65e Gerrit-Change-Number: 26658 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 23 Dec 2021 13:41:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:12:51 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 23 Dec 2021 14:12:51 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Iuh_Emulation: Avoid sending events to HNBAP if socket is not connected References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26677 ) Change subject: Iuh_Emulation: Avoid sending events to HNBAP if socket is not connected ...................................................................... Iuh_Emulation: Avoid sending events to HNBAP if socket is not connected This should hopefully fix HNB_Tests errors showing up in jenkins after the test finishes: Iuh_Emulation.ttcn:203 Dynamic test case error: Port HNBAP has neither connections nor mappings. Message cannot be sent on it. Change-Id: Ide201425e81dcfe2fd395d820bdcbd74f5415ef5 --- M library/Iuh_Emulation.ttcn 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/26677/1 diff --git a/library/Iuh_Emulation.ttcn b/library/Iuh_Emulation.ttcn index 75a95ba..bc8e7c3 100644 --- a/library/Iuh_Emulation.ttcn +++ b/library/Iuh_Emulation.ttcn @@ -128,6 +128,12 @@ return conn_id; } +private function f_send_IUHEM_Event(template (value) IUHEM_Event evt) runs on Iuh_Emulation_CT { + if (HNBAP.checkstate("Connected")) { + HNBAP.send(evt); + } +} + function main(Iuh_conn_parameters p, charstring id) runs on Iuh_Emulation_CT { var Result res; g_pars := p; @@ -147,7 +153,7 @@ /* notify user about SCTP establishment */ if (p.remote_sctp_port != -1) { - HNBAP.send(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); + f_send_IUHEM_Event(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); } while (true) { @@ -194,13 +200,13 @@ g_last_conn_id := asp_evt.connOpened.connId; log("Established a new Iuh connection (conn_id=", g_last_conn_id, ")"); - HNBAP.send(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); /* TODO: send g_last_conn_id */ + f_send_IUHEM_Event(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); /* TODO: send g_last_conn_id */ } [] Iuh.receive(ASP_Event:{connClosed:=?}) -> value asp_evt { log("Iuh: Closed"); g_self_conn_id := -1; - HNBAP.send(IUHEM_Event:{up_down:=IUHEM_EVENT_DOWN}); /* TODO: send asp_evt.connClosed.connId */ + f_send_IUHEM_Event(IUHEM_Event:{up_down:=IUHEM_EVENT_DOWN}); /* TODO: send asp_evt.connClosed.connId */ if (not emu_is_server()) { self.stop; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26677 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide201425e81dcfe2fd395d820bdcbd74f5415ef5 Gerrit-Change-Number: 26677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:23:39 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 14:23:39 +0000 Subject: Change in libosmocore[master]: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/6357 ) Change subject: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data ...................................................................... Patch Set 7: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/6357/7/include/osmocom/gsm/protocol/gsm_25_415.h File include/osmocom/gsm/protocol/gsm_25_415.h: https://gerrit.osmocom.org/c/libosmocore/+/6357/7/include/osmocom/gsm/protocol/gsm_25_415.h at 3 PS7, Line 3: 2017 2021, same in other files -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/6357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 Gerrit-Change-Number: 6357 Gerrit-PatchSet: 7 Gerrit-Owner: laforge Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 23 Dec 2021 14:23:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:26:30 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 14:26:30 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Iuh_Emulation: Avoid sending events to HNBAP if socket is not connected In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26677 ) Change subject: Iuh_Emulation: Avoid sending events to HNBAP if socket is not connected ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26677 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide201425e81dcfe2fd395d820bdcbd74f5415ef5 Gerrit-Change-Number: 26677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 23 Dec 2021 14:26:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:29:43 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 14:29:43 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Updates in HNBLLIF and HNBGW_COnnectioNHandler to support and... In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26672 ) Change subject: hnodeb: Updates in HNBLLIF and HNBGW_COnnectioNHandler to support and test IuUP ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I19612fce8190dfe14f98d346adb5db4e1c2a08d9 Gerrit-Change-Number: 26672 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 23 Dec 2021 14:29:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:48:52 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 23 Dec 2021 14:48:52 +0000 Subject: Change in osmo-bsc-nat[master]: Add project skeleton In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 ) Change subject: Add project skeleton ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Iae5d37483dcb9db00578d5c9cd1736f08754a65e Gerrit-Change-Number: 26658 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 23 Dec 2021 14:48:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:49:11 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 23 Dec 2021 14:49:11 +0000 Subject: Change in osmo-bsc-nat[master]: Add vty interface In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659 ) Change subject: Add vty interface ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I6f2d8d1d62b97be471ebcf1bb14aac0b895833d1 Gerrit-Change-Number: 26659 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 23 Dec 2021 14:49:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:50:16 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 23 Dec 2021 14:50:16 +0000 Subject: Change in libosmocore[master]: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/6357 ) Change subject: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data ...................................................................... Patch Set 7: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/6357/7/include/osmocom/gsm/protocol/gsm_25_415.h File include/osmocom/gsm/protocol/gsm_25_415.h: https://gerrit.osmocom.org/c/libosmocore/+/6357/7/include/osmocom/gsm/protocol/gsm_25_415.h at 3 PS7, Line 3: 2017 > 2021, same in other files no, the original code was written back then and is sitting in laforge/iu_up branch ever since. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/6357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 Gerrit-Change-Number: 6357 Gerrit-PatchSet: 7 Gerrit-Owner: laforge Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 23 Dec 2021 14:50:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:50:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 23 Dec 2021 14:50:20 +0000 Subject: Change in libosmocore[master]: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/6357 ) Change subject: Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data ...................................................................... Introduce CRC and FSM for IuUP (user plane) as used in 3G RTP data Only support for SMpSDU mode is introduced in this commit. Not supported explicit list: - Transparent mode - ATM/AAL2 based Transport layer - GTP-U based Transport Layer - Iu Rate Control procedure - Time Alignment procedure APIs are provided to allocate the primitives properly inside the related msgb. This way primitives can be placed in the headroom, leaving the data part of the msgb for the IuUP payload, hence allowing re-use of the msgb and 0 copy of IuUP payload when forwarding data over RNL<->TNL. Since RNL and TNL primitives relu struct osmo_prim_header, which is not packed, they cannot be set to packed, and hence proper memory alignment in the msgb must be done to avoid misaligned accesses (Asan errors about it otherwise). Related: SYS#5516 Change-Id: Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 --- M include/Makefile.am M include/osmocom/core/logging.h A include/osmocom/gsm/iuup.h M include/osmocom/gsm/prim.h A include/osmocom/gsm/protocol/gsm_25_415.h M src/gsm/Makefile.am A src/gsm/iuup.c M src/gsm/libosmogsm.map M src/logging.c M tests/Makefile.am A tests/iuup/iuup_test.c A tests/iuup/iuup_test.ok M tests/logging/logging_vty_test.vty M tests/testsuite.at 14 files changed, 1,980 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/Makefile.am b/include/Makefile.am index e3246cf..eab0489 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -125,6 +125,7 @@ osmocom/gsm/gsup_sms.h \ osmocom/gsm/i460_mux.h \ osmocom/gsm/ipa.h \ + osmocom/gsm/iuup.h \ osmocom/gsm/lapd_core.h \ osmocom/gsm/lapdm.h \ osmocom/gsm/meas_rep.h \ @@ -148,6 +149,7 @@ osmocom/gsm/protocol/gsm_12_21.h \ osmocom/gsm/protocol/gsm_23_003.h \ osmocom/gsm/protocol/gsm_23_041.h \ + osmocom/gsm/protocol/gsm_25_415.h \ osmocom/gsm/protocol/gsm_29_118.h \ osmocom/gsm/protocol/gsm_44_004.h \ osmocom/gsm/protocol/gsm_44_318.h \ diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index 18ad3ff..7907734 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -136,7 +136,8 @@ #define DLBSSGP -21 /*!< Osmocom BSSGP layer */ #define DLNSDATA -22 /*!< Osmocom NS layer data pdus */ #define DLNSSIGNAL -23 /*!< Osmocom NS layer signal pdus */ -#define OSMO_NUM_DLIB 23 /*!< Number of logging sub-systems in libraries */ +#define DLIUUP -24 /*!< Osmocom IuUP layer */ +#define OSMO_NUM_DLIB 24 /*!< Number of logging sub-systems in libraries */ /* Colors that can be used in log_info_cat.color */ #define OSMO_LOGCOLOR_NORMAL NULL diff --git a/include/osmocom/gsm/iuup.h b/include/osmocom/gsm/iuup.h new file mode 100644 index 0000000..b1651c5 --- /dev/null +++ b/include/osmocom/gsm/iuup.h @@ -0,0 +1,122 @@ +#pragma once + +#include + +#include +#include + +/*********************************************************************** + * Primitives towards the lower layers (typically RTP transport) + ***********************************************************************/ +enum osmo_iuup_tnl_prim_type { + OSMO_IUUP_TNL_UNITDATA, +}; + +struct osmo_iuup_tnl_prim { + struct osmo_prim_hdr oph; +}; + +/*********************************************************************** + * Primitives towards the upper layers at the RNL SAP + ***********************************************************************/ + +/* 3GPP TS 25.415 Section 7.2.1 */ +enum osmo_iuup_rnl_prim_type { + OSMO_IUUP_RNL_CONFIG, + OSMO_IUUP_RNL_DATA, + OSMO_IUUP_RNL_STATUS, + OSMO_IUUP_RNL_UNIT_DATA, +}; + +/* TS 25.413 9.2.1.3*/ +#define IUUP_MAX_SUBFLOWS 7 +#define IUUP_MAX_RFCIS 64 + +#define IUUP_TIMER_INIT_T_DEFAULT 1000 +#define IUUP_TIMER_TA_T_DEFAULT 500 +#define IUUP_TIMER_RC_T_DEFAULT 500 +#define IUUP_TIMER_INIT_N_DEFAULT 3 +#define IUUP_TIMER_TA_N_DEFAULT 1 +#define IUUP_TIMER_RC_N_DEFAULT 1 +struct osmo_iuup_rnl_config_timer { + uint32_t t_ms; /* time in ms */ + uint32_t n_max; /* max number of repetitions */ +}; +struct osmo_iuup_rnl_config { + /* transparent (true) or SMpSDU (false): */ + bool transparent; + + /* should we actively transmit INIT in SmpSDU mode? */ + bool active; + + /* Currently Version 0 or 1: */ + uint8_t data_pdu_type; + + /* Supported mode versions */ + uint16_t supported_versions_mask; + uint8_t num_rfci; + uint8_t num_subflows; + uint16_t subflow_sizes[IUUP_MAX_RFCIS][IUUP_MAX_SUBFLOWS]; + bool IPTIs_present; + uint8_t IPTIs[IUUP_MAX_RFCIS]; /* values range 0-15, 4 bits */ + + /* TODO: Indication of delivery of erroneous SDUs*/ + struct osmo_iuup_rnl_config_timer t_init; + struct osmo_iuup_rnl_config_timer t_ta; + struct osmo_iuup_rnl_config_timer t_rc; +}; + +struct osmo_iuup_rnl_data { + uint8_t rfci; + uint8_t frame_nr; + uint8_t fqc; +}; + +struct osmo_iuup_rnl_status { + enum iuup_procedure procedure; + union { + struct { + enum iuup_error_cause cause; + enum iuup_error_distance distance; + } error_event; + struct { + uint16_t supported_versions_mask; + uint8_t num_subflows; + uint8_t num_rfci; + uint16_t subflow_sizes[IUUP_MAX_RFCIS][IUUP_MAX_SUBFLOWS]; + bool IPTIs_present; + uint8_t IPTIs[IUUP_MAX_RFCIS]; /* values range 0-15, 4 bits */ + } initialization; + struct { + } rate_control; + struct { + } time_alignment; + } u; +}; + +/* SAP on the upper side of IuUP, towards the user */ +struct osmo_iuup_rnl_prim { + struct osmo_prim_hdr oph; + union { + struct osmo_iuup_rnl_config config; + struct osmo_iuup_rnl_data data; + struct osmo_iuup_rnl_status status; + //struct osmo_iuup_rnl_unitdata unitdata; + } u; +}; + +struct osmo_iuup_instance; +struct osmo_iuup_instance *osmo_iuup_instance_alloc(void *ctx, const char *id); +void osmo_iuup_instance_free(struct osmo_iuup_instance *iui); + +void osmo_iuup_instance_set_user_prim_cb(struct osmo_iuup_instance *iui, osmo_prim_cb func, void *priv); +void osmo_iuup_instance_set_transport_prim_cb(struct osmo_iuup_instance *iui, osmo_prim_cb func, void *priv); +int osmo_iuup_tnl_prim_up(struct osmo_iuup_instance *iui, struct osmo_iuup_tnl_prim *itp); +int osmo_iuup_rnl_prim_down(struct osmo_iuup_instance *inst, struct osmo_iuup_rnl_prim *irp); + + +int osmo_iuup_compute_header_crc(const uint8_t *iuup_pdu, unsigned int pdu_len); +int osmo_iuup_compute_payload_crc(const uint8_t *iuup_pdu, unsigned int pdu_len); + +struct osmo_iuup_rnl_prim *osmo_iuup_rnl_prim_alloc(void *ctx, unsigned int primitive, unsigned int operation, unsigned int size); +struct osmo_iuup_tnl_prim *osmo_iuup_tnl_prim_alloc(void *ctx, unsigned int primitive, unsigned int operation, unsigned int size); diff --git a/include/osmocom/gsm/prim.h b/include/osmocom/gsm/prim.h index 045e353..73cd7f7 100644 --- a/include/osmocom/gsm/prim.h +++ b/include/osmocom/gsm/prim.h @@ -18,4 +18,7 @@ SAP_NS, SAP_BSSGP_RIM, + + SAP_IUUP_TNL, + SAP_IUUP_RNL, }; diff --git a/include/osmocom/gsm/protocol/gsm_25_415.h b/include/osmocom/gsm/protocol/gsm_25_415.h new file mode 100644 index 0000000..5d90fd3 --- /dev/null +++ b/include/osmocom/gsm/protocol/gsm_25_415.h @@ -0,0 +1,222 @@ +#pragma once +/* Iu User Plane (IuUP) Definitions as per 3GPP TS 25.415 */ +/* (C) 2017 by Harald Welte + * All Rights Reserved. + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +#include +#include + +/* 3GPP TS 25.415 Section 6.6.2.1 */ +struct iuup_pdutype0_hdr { +#if OSMO_IS_LITTLE_ENDIAN + /* control part */ + uint8_t frame_nr:4, + pdu_type:4; + uint8_t rfci:6, + fqc:2; + /* checksum part */ + uint8_t payload_crc_hi:2, header_crc:6; + uint8_t payload_crc_lo; + + /* payload part */ + uint8_t payload[0]; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t pdu_type:4, frame_nr:4; + uint8_t fqc:2, rfci:6; + uint8_t header_crc:6, payload_crc_hi:2; + uint8_t payload_crc_lo; + uint8_t payload[0]; +#endif +} __attribute__((packed)); + +/* 3GPP TS 25.415 Section 6.6.2.2 */ +struct iuup_pdutype1_hdr { +#if OSMO_IS_LITTLE_ENDIAN + /* control part */ + uint8_t frame_nr:4, + pdu_type:4; + uint8_t rfci:6, + fqc:2; + /* checksum part */ + uint8_t spare:2, + header_crc:6; + /* payload part */ + uint8_t payload[0]; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t pdu_type:4, frame_nr:4; + uint8_t fqc:2, rfci:6; + uint8_t header_crc:6, spare:2; + uint8_t payload[0]; +#endif +} __attribute__((packed)); + +/* 3GPP TS 25.415 Section 6.6.2.3 */ +struct iuup_pdutype14_hdr { +#if OSMO_IS_LITTLE_ENDIAN + /* control part */ + uint8_t frame_nr:2, + ack_nack:2, + pdu_type:4; + uint8_t proc_ind:4, + mode_version:4; + /* checksum part */ + uint8_t payload_crc_hi:2, header_crc:6; + uint8_t payload_crc_lo; + /* payload part */ + uint8_t payload[0]; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t pdu_type:4, ack_nack:2, frame_nr:2; + uint8_t mode_version:4, proc_ind:4; + uint8_t header_crc:6, payload_crc_hi:2; + uint8_t payload_crc_lo; + uint8_t payload[0]; +#endif +} __attribute__((packed)); + +/* 3GPP TS 25.415 Section 6.6.2.3.4.1 */ +struct iuup_ctrl_init_rfci_hdr { +#if OSMO_IS_LITTLE_ENDIAN + uint8_t rfci:6, + li:1, + lri:1; + uint8_t subflow_length[0]; /* 1 or 2 bytes depending on li */ +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t lri:1, li:1, rfci:6; + uint8_t subflow_length[0]; +#endif +} __attribute__((packed)); +struct iuup_ctrl_init_hdr { +#if OSMO_IS_LITTLE_ENDIAN + uint8_t chain_ind:1, + num_subflows_per_rfci:3, + ti:1, + spare:3; + uint8_t rfci_data[0]; /* struct iuup_ctrl_init_rfci_hdr* */ +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint8_t spare:3, ti:1, num_subflows_per_rfci:3, chain_ind:1; + uint8_t rfci_data[0]; /* struct iuup_ctrl_init_rfci_hdr* */ +; +#endif +} __attribute__((packed)); +struct iuup_ctrl_init_tail { +#if OSMO_IS_LITTLE_ENDIAN + uint16_t versions_supported; + uint8_t spare:4, + data_pdu_type:4; + uint8_t spare_extension[0]; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + uint16_t versions_supported; + uint8_t data_pdu_type:4, spare:4; + uint8_t spare_extension[0]; +#endif +} __attribute__((packed)); + +/* 3GPP TS 25.415 Section 6.6.2.3.4.4 */ +struct iuup_ctrl_error_event { +#if OSMO_IS_LITTLE_ENDIAN + struct iuup_pdutype14_hdr hdr; + uint8_t error_cause:6, + error_distance:2; + uint8_t spare_extension[0]; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + struct iuup_pdutype14_hdr hdr; + uint8_t error_distance:2, error_cause:6; + uint8_t spare_extension[0]; +#endif +} __attribute__((packed)); + +/* 3GPP TS 25.415 Section 6.6.2.3.2 */ +struct iuup_ctrl_ack { + struct iuup_pdutype14_hdr hdr; + uint8_t spare_extension[0]; +} __attribute__((packed)); + +/* 3GPP TS 25.415 Section 6.6.2.3.3 */ +struct iuup_ctrl_nack { +#if OSMO_IS_LITTLE_ENDIAN + struct iuup_pdutype14_hdr hdr; + uint8_t spare:2, + error_cause:6; + uint8_t spare_extension[0]; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ + struct iuup_pdutype14_hdr hdr; + uint8_t error_cause:6, spare:2; + uint8_t spare_extension[0]; +#endif +} __attribute__((packed)); + +/* 3GPP TS 25.415 Section 6.6.2 + 6.6.3.1 */ +enum iuup_pdu_type { + IUUP_PDU_T_DATA_CRC = 0, + IUUP_PDU_T_DATA_NOCRC = 1, + IUUP_PDU_T_CONTROL = 14, +}; + +/* 3GPP TS 25.415 Section 6.6.3.2 */ +enum iuup_ack_nack { + IUUP_AN_PROCEDURE = 0, + IUUP_AN_ACK = 1, + IUUP_AN_NACK = 2, +}; + +/* 3GPP TS 25.415 Section 6.6.3.5 */ +enum iuup_fqc { + IUUP_FQC_FRAME_GOOD = 0, + IUUP_FQC_FRAME_BAD = 1, + IUUP_FQC_FRAME_BAD_RADIO = 2, +}; + +/* 3GPP TS 25.415 Section 6.6.3.7 */ +enum iuup_procedure { + IUUP_PROC_INIT = 0, + IUUP_PROC_RATE_CTRL = 1, + IUUP_PROC_TIME_ALIGN = 2, + IUUP_PROC_ERR_EVENT = 3, +}; + + +/* 3GPP TS 25.415 Section 6.6.3.15 */ +enum iuup_error_distance { + IUUP_ERR_DIST_LOCAL = 0, + IUUP_ERR_DIST_FIRST_FWD = 1, + IUUP_ERR_DIST_SECOND_FWD = 2, + IUUP_ERR_DIST_RESERVED = 3, +}; + + +/* 3GPP TS 25.415 Section 6.6.3.16 */ +enum iuup_error_cause { + IUUP_ERR_CAUSE_CRC_ERR_HDR = 0, + IUUP_ERR_CAUSE_CRC_ERR_DATA = 1, + IUUP_ERR_CAUSE_UNEXPECTED_FN = 2, + IUUP_ERR_CAUSE_FRAME_LOSS = 3, + IUUP_ERR_CAUSE_UNKNOWN_PDUTYPE = 4, + IUUP_ERR_CAUSE_UNKNOWN_PROC = 5, + IUUP_ERR_CAUSE_UNKNNOWN_RES_VAL = 6, + IUUP_ERR_CAUSE_UNKNNOWN_FIELD = 7, + IUUP_ERR_CAUSE_FRAME_TOO_SHORT = 8, + IUUP_ERR_CAUSE_MISSING_FIELDS = 9, + IUUP_ERR_CAUSE_UNEXPECTED_PDU_T = 16, + IUUP_ERR_CAUSE_UNEXPECTED_PROC = 18, + IUUP_ERR_CAUSE_UNEXPECTED_RFCI = 19, + IUUP_ERR_CAUSE_UNEXPECTED_VALUE = 20, + IUUP_ERR_CAUSE_INIT_FAILURE = 42, + IUUP_ERR_CAUSE_INIT_FAILURE_NET_TMR = 43, + IUUP_ERR_CAUSE_INIT_FAILURE_REP_NACK = 44, + IUUP_ERR_CAUSE_RATE_CTRL_FAILURE = 45, + IUUP_ERR_CAUSE_ERR_EVENT_FAIL = 46, + IUUP_ERR_CAUSE_TIME_ALIGN_NOTSUPP = 47, + IUUP_ERR_CAUSE_REQ_TIME_ALIGN_NOTPOSS = 48, + IUUP_ERR_CAUSE_MODE_VERSION_NOT_SUPPORTED = 49, +}; diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am index 580e397..326efd2 100644 --- a/src/gsm/Makefile.am +++ b/src/gsm/Makefile.am @@ -33,7 +33,7 @@ gsup.c gsup_sms.c gprs_gea.c gsm0503_conv.c oap.c gsm0808_utils.c \ gsm23003.c gsm23236.c mncc.c bts_features.c oap_client.c \ gsm29118.c gsm48_rest_octets.c cbsp.c gsm48049.c i460_mux.c \ - gad.c bsslap.c bssmap_le.c kdf.c + gad.c bsslap.c bssmap_le.c kdf.c iuup.c libgsmint_la_LDFLAGS = -no-undefined libgsmint_la_LIBADD = $(top_builddir)/src/libosmocore.la diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c new file mode 100644 index 0000000..159e533 --- /dev/null +++ b/src/gsm/iuup.c @@ -0,0 +1,1007 @@ +/*! \file iu_up.c + * IuUP (Iu User Plane) according to 3GPP TS 25.415 */ +/* + * (C) 2017 by Harald Welte + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include +#include + +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +/*********************************************************************** + * CRC Calculation + ***********************************************************************/ + +/* Section 6.6.3.8 Header CRC */ +const struct osmo_crc8gen_code iuup_hdr_crc_code = { + .bits = 6, + .poly = 47, + .init = 0, + .remainder = 0, +}; + +/* Section 6.6.3.9 Payload CRC */ +const struct osmo_crc16gen_code iuup_data_crc_code = { + .bits = 10, + .poly = 563, + .init = 0, + .remainder = 0, +}; + +static int iuup_get_payload_offset(const uint8_t *iuup_pdu) +{ + uint8_t pdu_type = iuup_pdu[0] >> 4; + switch (pdu_type) { + case 0: + case 14: + return 4; + case 1: + return 3; + default: + return -1; + } +} + +int osmo_iuup_compute_payload_crc(const uint8_t *iuup_pdu, unsigned int pdu_len) +{ + ubit_t buf[1024*8]; + uint8_t pdu_type; + int offset, payload_len_bytes; + + if (pdu_len < 1) + return -1; + + pdu_type = iuup_pdu[0] >> 4; + + /* Type 1 has no CRC */ + if (pdu_type == 1) + return 0; + + offset = iuup_get_payload_offset(iuup_pdu); + if (offset < 0) + return offset; + + if (pdu_len < offset) + return -1; + + payload_len_bytes = pdu_len - offset; + osmo_pbit2ubit(buf, iuup_pdu+offset, payload_len_bytes*8); + return osmo_crc16gen_compute_bits(&iuup_data_crc_code, buf, payload_len_bytes*8); +} + +int osmo_iuup_compute_header_crc(const uint8_t *iuup_pdu, unsigned int pdu_len) +{ + ubit_t buf[2*8]; + + if (pdu_len < 2) + return -1; + + osmo_pbit2ubit(buf, iuup_pdu, 2*8); + return osmo_crc8gen_compute_bits(&iuup_hdr_crc_code, buf, 2*8); +} + +/*********************************************************************** + * Internal State / FSM (Annex B) + ***********************************************************************/ + +#define S(x) (1 << (x)) + +#define IUUP_TIMER_INIT 1 +#define IUUP_TIMER_TA 2 +#define IUUP_TIMER_RC 3 + +struct osmo_timer_nt { + uint32_t n; /* number of repetitions */ + struct osmo_iuup_tnl_prim *retrans_itp; + struct osmo_timer_list timer; +}; + +struct osmo_iuup_instance { + struct osmo_iuup_rnl_config config; + struct osmo_fsm_inst *fi; + + uint8_t mode_version; + + struct { + struct osmo_timer_nt init; + struct osmo_timer_nt ta; + struct osmo_timer_nt rc; + } timer; + /* call-back function to pass primitives up to the user */ + osmo_prim_cb user_prim_cb; + void *user_prim_priv; + osmo_prim_cb transport_prim_cb; + void *transport_prim_priv; + uint8_t type14_fn; /* 2 bits */ +}; + +enum iuup_fsm_state { + IUUP_FSM_ST_NULL, + IUUP_FSM_ST_INIT, + IUUP_FSM_ST_TrM_DATA_XFER_READY, + IUUP_FSM_ST_SMpSDU_DATA_XFER_READY, +}; + +enum iuup_fsm_event { + IUUP_FSM_EVT_IUUP_CONFIG_REQ, + IUUP_FSM_EVT_IUUP_DATA_REQ, + IUUP_FSM_EVT_IUUP_DATA_IND, + IUUP_FSM_EVT_IUUP_STATUS_REQ, + IUUP_FSM_EVT_IUUP_STATUS_IND, + IUUP_FSM_EVT_SSASAR_UNITDATA_REQ, + IUUP_FSM_EVT_SSASAR_UNITDATA_IND, + IUUP_FSM_EVT_IUUP_UNITDATA_REQ, + IUUP_FSM_EVT_IUUP_UNITDATA_IND, + IUUP_FSM_EVT_INIT, + IUUP_FSM_EVT_LAST_INIT_ACK, + IUUP_FSM_EVT_INIT_NACK, +}; + +static const struct value_string iuup_fsm_event_names[] = { + { IUUP_FSM_EVT_IUUP_CONFIG_REQ, "IuUP-CONFIG.req" }, + { IUUP_FSM_EVT_IUUP_DATA_REQ, "IuUP-DATA.req" }, + { IUUP_FSM_EVT_IUUP_DATA_IND, "IuUP-DATA.ind" }, + { IUUP_FSM_EVT_IUUP_STATUS_REQ, "IuUP-STATUS.req" }, + { IUUP_FSM_EVT_IUUP_STATUS_IND, "IuUP-STATUS.ind" }, + { IUUP_FSM_EVT_SSASAR_UNITDATA_REQ, "SSSAR-UNITDATA.req" }, + { IUUP_FSM_EVT_SSASAR_UNITDATA_IND, "SSSAR-UNITDATA.ind" }, + { IUUP_FSM_EVT_IUUP_UNITDATA_REQ, "IuUP-UNITDATA.req" }, + { IUUP_FSM_EVT_IUUP_UNITDATA_IND, "IuUP-UNITDATA.ind" }, + { IUUP_FSM_EVT_INIT, "INIT" }, + { IUUP_FSM_EVT_LAST_INIT_ACK, "LAST_INIT_ACK" }, + { IUUP_FSM_EVT_INIT_NACK, "INIT_NACK" }, + { 0, NULL } +}; + +static inline uint8_t iuup_get_pdu_type(const uint8_t *data) +{ + return data[0] >> 4; +} + +static inline uint8_t iuup_get_hdr_crc(const uint8_t *data) +{ + return data[2] >> 2; +} + +/* Helper functions to store non-packed structs in msgb so that pointers are properly aligned: */ +#define IUUP_MSGB_SIZE 4096 +#define PTR_ALIGNMENT_BYTES 8 +#define IUUP_MSGB_HEADROOM_MIN_REQUIRED (OSMO_MAX(sizeof(struct osmo_iuup_tnl_prim), sizeof(struct osmo_iuup_rnl_prim)) + (PTR_ALIGNMENT_BYTES - 1)) +static inline struct msgb *osmo_iuup_msgb_alloc_c(void *ctx, size_t size) +{ + osmo_static_assert(size > IUUP_MSGB_HEADROOM_MIN_REQUIRED, iuup_msgb_alloc_headroom_bigger); + return msgb_alloc_headroom_c(ctx, size, IUUP_MSGB_HEADROOM_MIN_REQUIRED, "iuup-msgb"); +} + +/* push data so that the resulting pointer to write to is aligned to 8 byte */ +static inline __attribute__((assume_aligned(PTR_ALIGNMENT_BYTES))) +unsigned char *aligned_msgb_push(struct msgb *msg, unsigned int len) +{ + uint8_t *ptr = (msgb_data(msg) - len); + size_t extra_size = ((uintptr_t)ptr & (PTR_ALIGNMENT_BYTES - 1)); + + return msgb_push(msg, len + extra_size); +} + +struct osmo_iuup_rnl_prim *osmo_iuup_rnl_prim_alloc(void *ctx, unsigned int primitive, unsigned int operation, unsigned int size) +{ + struct msgb *msg; + struct osmo_iuup_rnl_prim *irp; + + msg = osmo_iuup_msgb_alloc_c(ctx, size); + irp = (struct osmo_iuup_rnl_prim *)aligned_msgb_push(msg, sizeof(*irp)); + osmo_prim_init(&irp->oph, SAP_IUUP_RNL, primitive, operation, msg); + return irp; +} + +struct osmo_iuup_tnl_prim *osmo_iuup_tnl_prim_alloc(void *ctx, unsigned int primitive, unsigned int operation, unsigned int size) +{ + struct msgb *msg; + struct osmo_iuup_tnl_prim *itp; + + msg = osmo_iuup_msgb_alloc_c(ctx, size); + itp = (struct osmo_iuup_tnl_prim *) aligned_msgb_push(msg, sizeof(*itp)); + osmo_prim_init(&itp->oph, SAP_IUUP_TNL, primitive, operation, msg); + return itp; +} + +/* 6.6.2.3.2 */ +static struct osmo_iuup_tnl_prim *itp_ctrl_ack_alloc(struct osmo_iuup_instance *iui, enum iuup_procedure proc_ind, uint8_t fn) +{ + struct osmo_iuup_tnl_prim *itp; + struct iuup_ctrl_ack *ack; + itp = osmo_iuup_tnl_prim_alloc(iui, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_REQUEST, IUUP_MSGB_SIZE); + itp->oph.msg->l2h = msgb_put(itp->oph.msg, sizeof(struct iuup_ctrl_ack)); + ack = (struct iuup_ctrl_ack *) msgb_l2(itp->oph.msg); + *ack = (struct iuup_ctrl_ack){ + .hdr = { + .frame_nr = fn, + .ack_nack = IUUP_AN_ACK, + .pdu_type = IUUP_PDU_T_CONTROL, + .proc_ind = proc_ind, + .mode_version = iui->mode_version, + .payload_crc_hi = 0, + .header_crc = 0, + .payload_crc_lo = 0, + }, + }; + ack->hdr.header_crc = osmo_iuup_compute_header_crc(msgb_l2(itp->oph.msg), msgb_l2len(itp->oph.msg)); + return itp; +} + +/* 6.6.2.3.3 */ +static struct osmo_iuup_tnl_prim *tnp_ctrl_nack_alloc(struct osmo_iuup_instance *iui, enum iuup_procedure proc_ind, enum iuup_error_cause error_cause, uint8_t fn) +{ + struct osmo_iuup_tnl_prim *itp; + struct iuup_ctrl_nack *nack; + itp = osmo_iuup_tnl_prim_alloc(iui, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_REQUEST, IUUP_MSGB_SIZE); + itp->oph.msg->l2h = msgb_put(itp->oph.msg, sizeof(struct iuup_ctrl_nack)); + nack = (struct iuup_ctrl_nack *) msgb_l2(itp->oph.msg); + *nack = (struct iuup_ctrl_nack){ + .hdr = { + .frame_nr = fn, + .ack_nack = IUUP_AN_NACK, + .pdu_type = IUUP_PDU_T_CONTROL, + .proc_ind = proc_ind, + .mode_version = iui->mode_version, + .payload_crc_hi = 0, + .header_crc = 0, + .payload_crc_lo = 0, + }, + .spare = 0, + .error_cause = error_cause, + }; + nack->hdr.header_crc = osmo_iuup_compute_header_crc(msgb_l2(itp->oph.msg), msgb_l2len(itp->oph.msg)); + return itp; +} + +/* 6.6.2.3.4.1 */ +static struct osmo_iuup_tnl_prim *tnp_ctrl_init_alloc(struct osmo_iuup_instance *iui) +{ + struct osmo_iuup_tnl_prim *itp; + struct iuup_pdutype14_hdr *hdr; + struct iuup_ctrl_init_hdr *ihdr; + struct iuup_ctrl_init_rfci_hdr *ihdr_rfci; + struct iuup_ctrl_init_tail *itail; + unsigned int i, j; + uint8_t num_subflows, num_rfci; + uint16_t payload_crc; + struct msgb *msg; + + num_subflows = iui->config.num_subflows; + num_rfci = iui->config.num_rfci; + + itp = osmo_iuup_tnl_prim_alloc(iui, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_REQUEST, IUUP_MSGB_SIZE); + msg = itp->oph.msg; + + msg->l2h = msgb_put(msg, sizeof(*hdr)); + hdr = (struct iuup_pdutype14_hdr *)msgb_l2(msg); + hdr->frame_nr = iui->type14_fn++; + hdr->ack_nack = IUUP_AN_PROCEDURE; + hdr->pdu_type = IUUP_PDU_T_CONTROL; + hdr->proc_ind = IUUP_PROC_INIT; + hdr->mode_version = 0; /* Use here the minimum version required to negotiate */ + hdr->header_crc = osmo_iuup_compute_header_crc(msgb_l2(msg), msgb_l2len(msg)); + + ihdr = (struct iuup_ctrl_init_hdr *)msgb_put(msg, sizeof(*ihdr)); + ihdr->chain_ind = 0; /* this frame is the last frame for the procedure. TODO: support several */ + ihdr->num_subflows_per_rfci = num_subflows; + ihdr->ti = iui->config.IPTIs_present ? 1 : 0; + ihdr->spare = 0; + + /* RFCI + subflow size part: */ + for (i = 0; i < num_rfci; i++) { + bool last = (i+1 == num_rfci); + uint8_t len_size = 1; + for (j = 0; j < num_subflows; j++) { + if (iui->config.subflow_sizes[i][j] > UINT8_MAX) + len_size = 2; + } + ihdr_rfci = (struct iuup_ctrl_init_rfci_hdr *)msgb_put(msg, sizeof(*ihdr_rfci) + len_size * num_subflows); + ihdr_rfci->rfci = i; + ihdr_rfci->li = len_size - 1; + ihdr_rfci->lri = last; + if (len_size == 2) { + uint16_t *buf = (uint16_t *)&ihdr_rfci->subflow_length[0]; + for (j = 0; j < num_subflows; j++) + osmo_store16be(iui->config.subflow_sizes[i][j], buf++); + } else { + for (j = 0; j < num_subflows; j++) + ihdr_rfci->subflow_length[j] = iui->config.subflow_sizes[i][j]; + } + } + + if (iui->config.IPTIs_present) { + uint8_t num_bytes = (num_rfci + 1) / 2; + uint8_t *buf = msgb_put(msg, num_bytes); + for (i = 0; i < num_bytes - 1; i++) + buf[i] = iui->config.IPTIs[i*2] << 4 | + (iui->config.IPTIs[i*2 + 1] & 0x0f); + buf[i] = iui->config.IPTIs[i*2] << 4; + if (!(num_rfci & 0x01)) /* is even: */ + buf[i] |= (iui->config.IPTIs[i*2 + 1] & 0x0f); + + } + + itail = (struct iuup_ctrl_init_tail *)msgb_put(msg, sizeof(*itail)); + osmo_store16be(iui->config.supported_versions_mask, &itail->versions_supported); + itail->spare = 0; + itail->data_pdu_type = iui->config.data_pdu_type; + + payload_crc = osmo_iuup_compute_payload_crc(msgb_l2(msg), msgb_l2len(msg)); + hdr->payload_crc_hi = (payload_crc >> 8) & 0x03; + hdr->payload_crc_lo = payload_crc & 0xff; + + + return itp; +} + +/* transform a RNL data primitive into a TNL data primitive (down the stack) */ +static struct osmo_iuup_tnl_prim *rnl_to_tnl_data(struct osmo_iuup_instance *iui, + struct osmo_iuup_rnl_prim *irp) +{ + struct osmo_iuup_tnl_prim *itp; + struct osmo_iuup_rnl_data dt; + struct msgb *msg; + uint16_t payload_crc; + struct iuup_pdutype0_hdr *h0; + struct iuup_pdutype1_hdr *h1; + + OSMO_ASSERT(OSMO_PRIM_HDR(&irp->oph) == OSMO_PRIM(OSMO_IUUP_RNL_DATA, PRIM_OP_REQUEST)); + + msg = irp->oph.msg; + dt = irp->u.data; + + /* pull up to the IuUP payload and push a new primitive header in front */ + msgb_pull_to_l3(msg); + + /* push the PDU TYPE 0 / 1 header in front of the payload */ + switch (iui->config.data_pdu_type) { + case 0: + msg->l2h = msgb_push(msg, sizeof(*h0)); + h0 = (struct iuup_pdutype0_hdr *)msg->l2h; + h0->frame_nr = dt.frame_nr; + h0->pdu_type = IUUP_PDU_T_DATA_CRC; + h0->rfci = dt.rfci; + h0->fqc = dt.fqc; + h0->header_crc = osmo_iuup_compute_header_crc(msgb_l2(msg), msgb_l2len(msg)); + payload_crc = osmo_iuup_compute_payload_crc(msgb_l2(msg), msgb_l2len(msg)); + h0->payload_crc_hi = (payload_crc >> 8) & 0x03; + h0->payload_crc_lo = payload_crc & 0xff; + break; + case 1: + msg->l2h = msgb_push(msg, sizeof(*h1)); + h1 = (struct iuup_pdutype1_hdr *)msg->l2h; + h1->frame_nr = dt.frame_nr; + h1->pdu_type = IUUP_PDU_T_DATA_NOCRC; + h1->rfci = dt.rfci; + h1->fqc = dt.fqc; + h1->header_crc = osmo_iuup_compute_header_crc(msgb_l2(msg), msgb_l2len(msg)); + h1->spare = 0; + break; + default: + OSMO_ASSERT(0); + } + + /* Avoid allocating irp out of 8byte-aligned address, Asan is not happy with it */ + itp = (struct osmo_iuup_tnl_prim *) aligned_msgb_push(msg, sizeof(*itp)); + osmo_prim_init(&itp->oph, SAP_IUUP_TNL, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_REQUEST, msg); + + return itp; +} + +/* transform a TNL primitive into a RNL primitive (up the stack) */ +static struct osmo_iuup_rnl_prim *tnl_to_rnl_data(struct osmo_iuup_tnl_prim *itp) +{ + struct msgb *msg; + struct iuup_pdutype0_hdr *h0; + struct iuup_pdutype1_hdr *h1; + struct osmo_iuup_rnl_data dt; + struct osmo_iuup_rnl_prim *irp; + + msg = itp->oph.msg; + + OSMO_ASSERT(OSMO_PRIM_HDR(&itp->oph) == OSMO_PRIM(OSMO_IUUP_TNL_UNITDATA, PRIM_OP_INDICATION)); + + switch (iuup_get_pdu_type(msgb_l2(msg))) { + case IUUP_PDU_T_DATA_CRC: + h0 = (struct iuup_pdutype0_hdr *) msgb_l2(msg); + dt.rfci = h0->rfci; + dt.frame_nr = h0->frame_nr; + dt.fqc = h0->fqc; + break; + case IUUP_PDU_T_DATA_NOCRC: + h1 = (struct iuup_pdutype1_hdr *) msgb_l2(msg); + dt.rfci = h1->rfci; + dt.frame_nr = h1->frame_nr; + dt.fqc = h1->fqc; + break; + } + + /* pull up to the IuUP payload and push a new primitive header in front */ + msgb_pull_to_l3(msg); + + /* Avoid allocating irp out of 8byte-aligned address, Asan is not happy with it */ + irp = (struct osmo_iuup_rnl_prim *) aligned_msgb_push(msg, sizeof(*irp)); + osmo_prim_init(&irp->oph, SAP_IUUP_RNL, OSMO_IUUP_RNL_DATA, PRIM_OP_INDICATION, msg); + irp->u.data = dt; + + return irp; +} + +static struct osmo_iuup_rnl_prim *irp_error_event_alloc_c(void *ctx, enum iuup_error_cause cause, enum iuup_error_distance distance) +{ + struct osmo_iuup_rnl_prim *irp; + struct msgb *msg; + msg = msgb_alloc_c(ctx, sizeof(*irp), "iuup-tx"); + irp = (struct osmo_iuup_rnl_prim *) msgb_put(msg, sizeof(*irp)); + osmo_prim_init(&irp->oph, SAP_IUUP_RNL, OSMO_IUUP_RNL_STATUS, PRIM_OP_INDICATION, msg); + irp->u.status.procedure = IUUP_PROC_ERR_EVENT; + irp->u.status.u.error_event.cause = cause; + irp->u.status.u.error_event.distance = distance; + return irp; +} + +static struct osmo_iuup_tnl_prim *itp_copy_c(void *ctx, const struct osmo_iuup_tnl_prim *src_itp) +{ + struct msgb *msg; + struct osmo_iuup_tnl_prim *dst_itp; + + msg = msgb_copy_c(ctx, src_itp->oph.msg, "iuup-tx-retrans"); + dst_itp = (struct osmo_iuup_tnl_prim *)msgb_data(msg); + dst_itp->oph.msg = msg; + return dst_itp; +} + +static void retransmit_initialization(struct osmo_iuup_instance *iui) +{ + struct osmo_iuup_tnl_prim *itp; + iui->fi->T = IUUP_TIMER_INIT; + osmo_timer_schedule(&iui->fi->timer, iui->config.t_init.t_ms / 1000, (iui->config.t_init.t_ms % 1000) * 1000); + itp = itp_copy_c(iui, iui->timer.init.retrans_itp); + iui->transport_prim_cb(&itp->oph, iui->transport_prim_priv); +} + +/* return: whether the last Init was Acked correctly and hence can transition to next state */ +static bool iuup_rx_initialization(struct osmo_iuup_instance *iui, struct osmo_iuup_tnl_prim *itp) +{ + struct iuup_pdutype14_hdr *hdr; + struct iuup_ctrl_init_hdr *ihdr; + struct iuup_ctrl_init_rfci_hdr *ihdr_rfci; + struct iuup_ctrl_init_tail *itail; + enum iuup_error_cause err_cause; + uint8_t num_rfci = 0; + unsigned int i; + bool is_last; + uint16_t remote_mask, match_mask; + struct osmo_iuup_tnl_prim *resp; + + /* TODO: whenever we check message boundaries, length, etc. and we fail, send NACK */ + + hdr = (struct iuup_pdutype14_hdr *)msgb_l2(itp->oph.msg); + ihdr = (struct iuup_ctrl_init_hdr *)hdr->payload; + if (ihdr->num_subflows_per_rfci == 0) { + LOGPFSML(iui->fi, LOGL_NOTICE, "Initialization: Unexpected num_subflows=0 received\n"); + err_cause = IUUP_ERR_CAUSE_UNEXPECTED_VALUE; + goto send_nack; + } + ihdr_rfci = (struct iuup_ctrl_init_rfci_hdr *)ihdr->rfci_data; + + do { + uint8_t l_size_bytes = ihdr_rfci->li + 1; + is_last = ihdr_rfci->lri; + if (ihdr_rfci->rfci != num_rfci) { + LOGPFSML(iui->fi, LOGL_NOTICE, "Initialization: Unexpected RFCI %u at position %u received\n", + ihdr_rfci->rfci, num_rfci); + err_cause = IUUP_ERR_CAUSE_UNEXPECTED_RFCI; + goto send_nack; + } + if (l_size_bytes == 2) { + uint16_t *subflow_size = (uint16_t *)ihdr_rfci->subflow_length; + for (i = 0; i < ihdr->num_subflows_per_rfci; i++) { + iui->config.subflow_sizes[ihdr_rfci->rfci][i] = osmo_load16be(subflow_size); + subflow_size++; + } + } else { + uint8_t *subflow_size = ihdr_rfci->subflow_length; + for (i = 0; i < ihdr->num_subflows_per_rfci; i++) { + iui->config.subflow_sizes[ihdr_rfci->rfci][i] = osmo_load16be(subflow_size); + subflow_size++; + } + } + num_rfci++; + ihdr_rfci++; + ihdr_rfci = (struct iuup_ctrl_init_rfci_hdr *)(((uint8_t *)ihdr_rfci) + ihdr->num_subflows_per_rfci * l_size_bytes); + } while (!is_last); + + if (ihdr->ti) { /* Timing information present */ + uint8_t *buf = (uint8_t *)ihdr_rfci; + uint8_t num_bytes = (num_rfci + 1) / 2; + iui->config.IPTIs_present = true; + for (i = 0; i < num_bytes - 1; i++) { + iui->config.IPTIs[i*2] = *buf >> 4; + iui->config.IPTIs[i*2 + 1] = *buf & 0x0f; + buf++; + } + iui->config.IPTIs[i*2] = *buf >> 4; + if (!(num_rfci & 0x01)) /* is even: */ + iui->config.IPTIs[i*2 + 1] = *buf & 0x0f; + buf++; + itail = (struct iuup_ctrl_init_tail *)buf; + } else { + itail = (struct iuup_ctrl_init_tail *)ihdr_rfci; + } + + if (itail->data_pdu_type > 1) { + LOGPFSML(iui->fi, LOGL_NOTICE, "Initialization: Unexpected Data PDU Type %u received\n", itail->data_pdu_type); + err_cause = IUUP_ERR_CAUSE_UNEXPECTED_VALUE; + goto send_nack; + } + + remote_mask = osmo_load16be(&itail->versions_supported); + match_mask = (remote_mask & iui->config.supported_versions_mask); + if (match_mask == 0x0000) { + LOGPFSML(iui->fi, LOGL_NOTICE, + "Initialization: No match in supported versions local=0x%04x vs remote=0x%04x\n", + iui->config.supported_versions_mask, remote_mask); + err_cause = IUUP_ERR_CAUSE_UNEXPECTED_VALUE; + goto send_nack; + } + for (i = 15; i >= 0; i--) { + if (match_mask & (1<mode_version = i; + break; + } + } + + iui->config.num_rfci = num_rfci; + iui->config.num_subflows = ihdr->num_subflows_per_rfci; + iui->config.data_pdu_type = itail->data_pdu_type; + + LOGPFSML(iui->fi, LOGL_DEBUG, "Tx Initialization ACK\n"); + resp = itp_ctrl_ack_alloc(iui, IUUP_PROC_INIT, hdr->frame_nr); + iui->transport_prim_cb(&resp->oph, iui->transport_prim_priv); + return ihdr->chain_ind == 0; +send_nack: + LOGPFSML(iui->fi, LOGL_NOTICE, "Tx Initialization NACK cause=%u orig_message=%s\n", + err_cause, osmo_hexdump((const unsigned char *) msgb_l2(itp->oph.msg), msgb_l2len(itp->oph.msg))); + resp = tnp_ctrl_nack_alloc(iui, IUUP_PROC_INIT, err_cause, hdr->frame_nr); + iui->transport_prim_cb(&resp->oph, iui->transport_prim_priv); + return false; +} + +/********************** + * FSM STATE FUNCTIONS + **********************/ +static void iuup_fsm_null(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + struct osmo_iuup_instance *iui = fi->priv; + struct osmo_iuup_rnl_prim *user_prim = NULL; + + switch (event) { + case IUUP_FSM_EVT_IUUP_CONFIG_REQ: + user_prim = data; + iui->config = user_prim->u.config; + iui->config.supported_versions_mask &= 0x0003; /* We only support versions 1 and 2 ourselves */ + //TODO: if supported_versions_mask == 0x0000,no supported versions, send error to upper layers + + if (iui->config.transparent) + osmo_fsm_inst_state_chg(fi, IUUP_FSM_ST_TrM_DATA_XFER_READY, 0, 0); + else { + osmo_fsm_inst_state_chg(fi, IUUP_FSM_ST_INIT, 0, 0); + } + break; + } +} + +/* transparent mode data transfer */ +static void iuup_fsm_trm_data(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + //struct osmo_iuup_instance *iui = fi->priv; + + switch (event) { + case IUUP_FSM_EVT_IUUP_CONFIG_REQ: + osmo_fsm_inst_state_chg(fi, IUUP_FSM_ST_NULL, 0, 0); + break; + case IUUP_FSM_EVT_IUUP_DATA_REQ: + /* Data coming down from RNL (user) towards TNL (transport) */ + break; + case IUUP_FSM_EVT_IUUP_DATA_IND: + /* Data coming up from TNL (transport) towards RNL (user) */ + break; + case IUUP_FSM_EVT_IUUP_UNITDATA_REQ: + case IUUP_FSM_EVT_IUUP_UNITDATA_IND: + case IUUP_FSM_EVT_SSASAR_UNITDATA_REQ: + case IUUP_FSM_EVT_SSASAR_UNITDATA_IND: + /* no state change */ + break; + } +} + +static void iuup_fsm_init_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct osmo_iuup_instance *iui = fi->priv; + + iui->type14_fn = 0; + if (iui->config.active) { + iui->timer.init.n = 0; + iui->timer.init.retrans_itp = tnp_ctrl_init_alloc(iui); + retransmit_initialization(iui); + } +} + +static void iuup_fsm_init(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + struct osmo_iuup_instance *iui = fi->priv; + struct osmo_iuup_rnl_prim *irp; + struct osmo_iuup_tnl_prim *itp; + + switch (event) { + case IUUP_FSM_EVT_IUUP_CONFIG_REQ: + /* the only permitted 'config req' type is the request to release the instance */ + osmo_fsm_inst_state_chg(fi, IUUP_FSM_ST_NULL, 0, 0); + break; + case IUUP_FSM_EVT_INIT: + itp = data; + if (iuup_rx_initialization(iui, itp)) + osmo_fsm_inst_state_chg(fi, IUUP_FSM_ST_SMpSDU_DATA_XFER_READY, 0, 0); + break; + case IUUP_FSM_EVT_LAST_INIT_ACK: + /* last INIT ACK was received, transition to DATA_XFER_READY state */ + osmo_fsm_inst_state_chg(fi, IUUP_FSM_ST_SMpSDU_DATA_XFER_READY, 0, 0); + break; + case IUUP_FSM_EVT_INIT_NACK: + LOGPFSML(fi, LOGL_NOTICE, "Rx Initialization NACK N=%" PRIu32 "/%" PRIu32 "\n", + iui->timer.init.n, iui->config.t_init.n_max); + osmo_timer_del(&fi->timer); + if (iui->timer.init.n == iui->config.t_init.n_max) { + irp = irp_error_event_alloc_c(iui, IUUP_ERR_CAUSE_INIT_FAILURE_REP_NACK, IUUP_ERR_DIST_SECOND_FWD); + iui->user_prim_cb(&irp->oph, iui->user_prim_priv); + return; + } + iui->timer.init.n++; + retransmit_initialization(iui); + break; + default: + OSMO_ASSERT(false); + } +} + +static void iuup_fsm_smpsdu_data(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + struct osmo_iuup_instance *iui = fi->priv; + struct osmo_iuup_rnl_prim *irp = NULL; + struct osmo_iuup_tnl_prim *itp = NULL; + + switch (event) { + case IUUP_FSM_EVT_IUUP_CONFIG_REQ: + irp = data; + osmo_fsm_inst_state_chg(fi, IUUP_FSM_ST_NULL, 0, 0); + break; + case IUUP_FSM_EVT_IUUP_DATA_REQ: + /* Data coming down from RNL (user) towards TNL (transport) */ + irp = data; + itp = rnl_to_tnl_data(iui, irp); + iui->transport_prim_cb(&itp->oph, iui->transport_prim_priv); + break; + case IUUP_FSM_EVT_IUUP_DATA_IND: + /* Data coming up from TNL (transport) towards RNL (user) */ + itp = data; + irp = tnl_to_rnl_data(itp); + iui->user_prim_cb(&irp->oph, iui->user_prim_priv); + break; + case IUUP_FSM_EVT_IUUP_UNITDATA_REQ: + case IUUP_FSM_EVT_IUUP_UNITDATA_IND: + case IUUP_FSM_EVT_SSASAR_UNITDATA_REQ: + case IUUP_FSM_EVT_SSASAR_UNITDATA_IND: + /* no state change */ + break; + } +} + +static int iuup_fsm_timer_cb(struct osmo_fsm_inst *fi) +{ + struct osmo_iuup_instance *iui = fi->priv; + struct osmo_iuup_rnl_prim *irp; + + switch (fi->T) { + case IUUP_TIMER_INIT: + OSMO_ASSERT(fi->state == IUUP_FSM_ST_INIT); + if (iui->timer.init.n == iui->config.t_init.n_max) { + irp = irp_error_event_alloc_c(iui, IUUP_ERR_CAUSE_INIT_FAILURE_NET_TMR, IUUP_ERR_DIST_LOCAL); + iui->user_prim_cb(&irp->oph, iui->user_prim_priv); + return 0; + } + iui->timer.init.n++; + retransmit_initialization(iui); + break; + case IUUP_TIMER_TA: + break; + case IUUP_TIMER_RC: + break; + default: + OSMO_ASSERT(0); + } + return 0; +} + + +static const struct osmo_fsm_state iuup_fsm_states[] = { + [IUUP_FSM_ST_NULL] = { + .in_event_mask = S(IUUP_FSM_EVT_IUUP_CONFIG_REQ), + .out_state_mask = S(IUUP_FSM_ST_INIT) | + S(IUUP_FSM_ST_TrM_DATA_XFER_READY), + .name = "NULL", + .action = iuup_fsm_null, + }, + [IUUP_FSM_ST_TrM_DATA_XFER_READY] = { + .in_event_mask = S(IUUP_FSM_EVT_IUUP_CONFIG_REQ) | + S(IUUP_FSM_EVT_IUUP_STATUS_REQ) | + S(IUUP_FSM_EVT_IUUP_DATA_REQ) | + S(IUUP_FSM_EVT_IUUP_DATA_IND) | + S(IUUP_FSM_EVT_IUUP_UNITDATA_REQ) | + S(IUUP_FSM_EVT_IUUP_UNITDATA_IND) | + S(IUUP_FSM_EVT_SSASAR_UNITDATA_REQ) | + S(IUUP_FSM_EVT_SSASAR_UNITDATA_IND), + .out_state_mask = S(IUUP_FSM_ST_NULL), + .name = "TrM Data Transfer Ready", + .action = iuup_fsm_trm_data, + }, + [IUUP_FSM_ST_INIT] = { + .in_event_mask = S(IUUP_FSM_EVT_IUUP_CONFIG_REQ) | + S(IUUP_FSM_EVT_INIT) | + S(IUUP_FSM_EVT_LAST_INIT_ACK) | + S(IUUP_FSM_EVT_INIT_NACK), + .out_state_mask = S(IUUP_FSM_ST_NULL) | + S(IUUP_FSM_ST_SMpSDU_DATA_XFER_READY), + .name = "Initialisation", + .onenter = iuup_fsm_init_on_enter, + .action = iuup_fsm_init, + }, + [IUUP_FSM_ST_SMpSDU_DATA_XFER_READY] = { + .in_event_mask = S(IUUP_FSM_EVT_IUUP_DATA_REQ) | + S(IUUP_FSM_EVT_IUUP_DATA_IND), + .out_state_mask = S(IUUP_FSM_ST_NULL) | + S(IUUP_FSM_ST_INIT), + .name = "SMpSDU Data Transfer Ready", + .action = iuup_fsm_smpsdu_data, + }, +}; + +static struct osmo_fsm iuup_fsm = { + .name = "IuUP", + .states = iuup_fsm_states, + .num_states = ARRAY_SIZE(iuup_fsm_states), + .timer_cb = iuup_fsm_timer_cb, + .log_subsys = DLIUUP, + .event_names = iuup_fsm_event_names, +}; + +static int iuup_verify_pdu(const uint8_t *data, unsigned int len) +{ + int header_crc_computed, payload_crc_computed; + uint16_t payload_crc; + uint8_t pdu_type = iuup_get_pdu_type(data); + struct iuup_pdutype0_hdr *t0h; + struct iuup_pdutype14_hdr *t14h; + + if (len < 3) + return -EINVAL; + + header_crc_computed = osmo_iuup_compute_header_crc(data, len); + if (iuup_get_hdr_crc(data) != header_crc_computed) { + LOGP(DLIUUP, LOGL_NOTICE, "Checksum error: rx 0x%02x vs exp 0x%02x\n", + iuup_get_hdr_crc(data), header_crc_computed); + return -EIO; + } + switch (pdu_type) { + case IUUP_PDU_T_DATA_NOCRC: + if (len < 4) + return -EINVAL; + break; + case IUUP_PDU_T_DATA_CRC: + t0h = (struct iuup_pdutype0_hdr *) data; + payload_crc = ((uint16_t)t0h->payload_crc_hi << 8) | t0h->payload_crc_lo; + payload_crc_computed = osmo_iuup_compute_payload_crc(data, len); + if (payload_crc != payload_crc_computed) + return -EIO; + break; + case IUUP_PDU_T_CONTROL: + t14h = (struct iuup_pdutype14_hdr *) data; + if (t14h->ack_nack == IUUP_AN_PROCEDURE) { + payload_crc = ((uint16_t)t14h->payload_crc_hi << 8) | t14h->payload_crc_lo; + payload_crc_computed = osmo_iuup_compute_payload_crc(data, len); + if (payload_crc != payload_crc_computed) + return -EIO; + } + break; + default: + return -EINVAL; + } + return 0; +} + +/* A IuUP TNL SAP primitive from transport (lower layer) */ +int osmo_iuup_tnl_prim_up(struct osmo_iuup_instance *inst, struct osmo_iuup_tnl_prim *itp) +{ + struct osmo_prim_hdr *oph = &itp->oph; + struct iuup_pdutype14_hdr *t14h; + int rc = 0; + + OSMO_ASSERT(oph->sap == SAP_IUUP_TNL); + + switch (OSMO_PRIM_HDR(oph)) { + case OSMO_PRIM(OSMO_IUUP_TNL_UNITDATA, PRIM_OP_INDICATION): + if (iuup_verify_pdu(msgb_l2(oph->msg), msgb_l2len(oph->msg)) < 0) { + LOGPFSML(inst->fi, LOGL_NOTICE, "Discarding invalid IuUP PDU: %s\n", + osmo_hexdump((const unsigned char *) msgb_l2(oph->msg), msgb_l2len(oph->msg))); + /* don't return error as the caller is not responsible for the PDU which + * was transmitted from some remote peer */ + return 0; + } + switch (iuup_get_pdu_type(msgb_l2(oph->msg))) { + case IUUP_PDU_T_DATA_CRC: + oph->msg->l3h = msgb_l2(oph->msg) + sizeof(struct iuup_pdutype0_hdr); + rc = osmo_fsm_inst_dispatch(inst->fi, IUUP_FSM_EVT_IUUP_DATA_IND, itp); + break; + case IUUP_PDU_T_DATA_NOCRC: + oph->msg->l3h = msgb_l2(oph->msg) + sizeof(struct iuup_pdutype1_hdr); + rc = osmo_fsm_inst_dispatch(inst->fi, IUUP_FSM_EVT_IUUP_DATA_IND, itp); + break; + case IUUP_PDU_T_CONTROL: + t14h = (struct iuup_pdutype14_hdr *) msgb_l2(oph->msg); + switch (t14h->ack_nack) { + case IUUP_AN_PROCEDURE: + switch (t14h->proc_ind) { + case IUUP_PROC_INIT: + rc = osmo_fsm_inst_dispatch(inst->fi, IUUP_FSM_EVT_INIT, itp); + break; + case IUUP_PROC_RATE_CTRL: + case IUUP_PROC_TIME_ALIGN: + case IUUP_PROC_ERR_EVENT: + LOGPFSML(inst->fi, LOGL_NOTICE, "Received Request for " + "unsupported IuUP procedure %u\n", t14h->proc_ind); + break; + default: + LOGPFSML(inst->fi, LOGL_NOTICE, "Received Request for " + "unknown IuUP procedure %u\n", t14h->proc_ind); + break; + } + break; + case IUUP_AN_ACK: + switch (t14h->proc_ind) { + case IUUP_PROC_INIT: + rc = osmo_fsm_inst_dispatch(inst->fi, + IUUP_FSM_EVT_LAST_INIT_ACK, itp); + break; + default: + LOGPFSML(inst->fi, LOGL_ERROR, "Received ACK for " + "unknown IuUP procedure %u\n", t14h->proc_ind); + break; + } + break; + case IUUP_AN_NACK: + switch (t14h->proc_ind) { + case IUUP_PROC_INIT: + rc = osmo_fsm_inst_dispatch(inst->fi, + IUUP_FSM_EVT_INIT_NACK, itp); + break; + default: + LOGPFSML(inst->fi, LOGL_ERROR, "Received NACK for " + "unknown IuUP procedure %u\n", t14h->proc_ind); + break; + } + break; + default: + LOGPFSML(inst->fi, LOGL_ERROR, "Received unknown IuUP ACK/NACK\n"); + break; + } + break; + default: + LOGPFSML(inst->fi, LOGL_NOTICE, "Received unknown IuUP PDU type %u\n", + iuup_get_pdu_type(msgb_l2(oph->msg))); + break; + } + break; + default: + /* exception: return an error code due to a wrong primitive */ + return -EINVAL; + } + + return rc; +} + +/* A IuUP RNL SAP primitive from user (higher layer) */ +int osmo_iuup_rnl_prim_down(struct osmo_iuup_instance *inst, struct osmo_iuup_rnl_prim *irp) +{ + struct osmo_prim_hdr *oph = &irp->oph; + int rc; + + OSMO_ASSERT(oph->sap == SAP_IUUP_RNL); + + switch (OSMO_PRIM_HDR(oph)) { + case OSMO_PRIM(OSMO_IUUP_RNL_CONFIG, PRIM_OP_REQUEST): + rc = osmo_fsm_inst_dispatch(inst->fi, IUUP_FSM_EVT_IUUP_CONFIG_REQ, irp); + msgb_free(irp->oph.msg); + break; + case OSMO_PRIM(OSMO_IUUP_RNL_DATA, PRIM_OP_REQUEST): + rc = osmo_fsm_inst_dispatch(inst->fi, IUUP_FSM_EVT_IUUP_DATA_REQ, irp); + if (rc != 0) + msgb_free(irp->oph.msg); + break; + case OSMO_PRIM(OSMO_IUUP_RNL_STATUS, PRIM_OP_REQUEST): + rc = osmo_fsm_inst_dispatch(inst->fi, IUUP_FSM_EVT_IUUP_STATUS_REQ, irp); + msgb_free(irp->oph.msg); + break; + default: + rc = -EINVAL; + msgb_free(irp->oph.msg); + } + return rc; +} + +struct osmo_iuup_instance *osmo_iuup_instance_alloc(void *ctx, const char *id) +{ + struct osmo_iuup_instance *iui; + iui = talloc_zero(ctx, struct osmo_iuup_instance); + if (!iui) + return NULL; + + iui->fi = osmo_fsm_inst_alloc(&iuup_fsm, NULL, iui, LOGL_DEBUG, id); + if (!iui->fi) + goto free_ret; + + return iui; +free_ret: + talloc_free(iui); + return NULL; +} + +void osmo_iuup_instance_free(struct osmo_iuup_instance *iui) +{ + if (!iui) + return; + + if (iui->fi) + osmo_fsm_inst_free(iui->fi); + iui->fi = NULL; + talloc_free(iui); +} + +void osmo_iuup_instance_set_user_prim_cb(struct osmo_iuup_instance *iui, osmo_prim_cb func, void *priv) +{ + iui->user_prim_cb = func; + iui->user_prim_priv = priv; +} +void osmo_iuup_instance_set_transport_prim_cb(struct osmo_iuup_instance *iui, osmo_prim_cb func, void *priv) +{ + iui->transport_prim_cb = func; + iui->transport_prim_priv = priv; +} + +static __attribute__((constructor)) void on_dso_load_iuup_fsm(void) +{ + OSMO_ASSERT(osmo_fsm_register(&iuup_fsm) == 0); +} diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map index 475ec02..b971ca0 100644 --- a/src/gsm/libosmogsm.map +++ b/src/gsm/libosmogsm.map @@ -771,5 +771,16 @@ osmo_gad_raw_write; osmo_gad_type_names; +osmo_iuup_compute_header_crc; +osmo_iuup_compute_payload_crc; +osmo_iuup_instance_alloc; +osmo_iuup_instance_free; +osmo_iuup_instance_set_user_prim_cb; +osmo_iuup_instance_set_transport_prim_cb; +osmo_iuup_tnl_prim_up; +osmo_iuup_rnl_prim_down; +osmo_iuup_rnl_prim_alloc; +osmo_iuup_tnl_prim_alloc; + local: *; }; diff --git a/src/logging.c b/src/logging.c index 9497f28..e5c66f2 100644 --- a/src/logging.c +++ b/src/logging.c @@ -294,6 +294,12 @@ .enabled = 1, .loglevel = LOGL_NOTICE, .color = "\033[38;5;63m", }, + [INT2IDX(DLIUUP)] = { + .name = "DLIUUP", + .description = "Iu UP layer", + .enabled = 1, .loglevel = LOGL_NOTICE, + .color = "\033[38;5;65m", + }, }; void assert_loginfo(const char *src) diff --git a/tests/Makefile.am b/tests/Makefile.am index a6f6017..f54ce18 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -45,6 +45,7 @@ time_cc/time_cc_test \ gsm48/rest_octets_test \ base64/base64_test \ + iuup/iuup_test \ $(NULL) if ENABLE_MSGFILE @@ -328,6 +329,9 @@ time_cc_time_cc_test_SOURCES = time_cc/time_cc_test.c time_cc_time_cc_test_LDADD = $(LDADD) +iuup_iuup_test_SOURCES = iuup/iuup_test.c +iuup_iuup_test_LDADD = $(LDADD) $(top_builddir)/src/gsm/libosmogsm.la + # The `:;' works around a Bash 3.2 bug when the output is not writeable. $(srcdir)/package.m4: $(top_srcdir)/configure.ac :;{ \ @@ -420,6 +424,7 @@ time_cc/time_cc_test.ok \ gsm48/rest_octets_test.ok \ base64/base64_test.ok \ + iuup/iuup_test.ok \ $(NULL) if ENABLE_LIBSCTP @@ -616,6 +621,8 @@ >$(srcdir)/it_q/it_q_test.ok time_cc/time_cc_test \ >$(srcdir)/time_cc/time_cc_test.ok + iuup/iuup_test \ + >$(srcdir)/iuup/iuup_test.ok check-local: atconfig $(TESTSUITE) [ -e /proc/cpuinfo ] && cat /proc/cpuinfo diff --git a/tests/iuup/iuup_test.c b/tests/iuup/iuup_test.c new file mode 100644 index 0000000..0c7dbff --- /dev/null +++ b/tests/iuup/iuup_test.c @@ -0,0 +1,543 @@ +#include +#include + +#include +#include +#include +#include +#include +#include + +#include +#include + +static void *iuup_test_ctx; + +static struct osmo_iuup_rnl_config def_configure_req = { + .transparent = false, + .active = true, + .supported_versions_mask = 0x0001, + .num_rfci = 3, + .num_subflows = 3, + .subflow_sizes = { + {81, 103, 60}, + {39, 0, 0}, + {0, 0, 0}, + }, + /* .delivery_err_sdu = All set to 0 (YES) by default, */ + .IPTIs_present = true, + .IPTIs = {1, 7, 1}, + .t_init = { .t_ms = IUUP_TIMER_INIT_T_DEFAULT, .n_max = IUUP_TIMER_INIT_N_DEFAULT }, + .t_ta = { .t_ms = IUUP_TIMER_TA_T_DEFAULT, .n_max = IUUP_TIMER_TA_N_DEFAULT }, + .t_rc = { .t_ms = IUUP_TIMER_RC_T_DEFAULT, .n_max = IUUP_TIMER_RC_N_DEFAULT }, +}; + +/* Frame 33, "Initialization", OS#4744 3g_call_23112021.pcapng +IuUP + 1110 .... = PDU Type: Control Procedure (14) + .... 00.. = Ack/Nack: Procedure (0) + .... ..00 = Frame Number: 0 + 0000 .... = Mode Version: 0x0 + .... 0000 = Procedure: Initialization (0) + 1101 11.. = Header CRC: 0x37 [correct] + .... ..11 1001 1001 = Payload CRC: 0x399 + 000. .... = Spare: 0x0 + ...1 .... = TI: IPTIs present in frame (1) + .... 011. = Subflows: 3 + .... ...0 = Chain Indicator: this frame is the last frame for the procedure (0) + RFCI 0 Initialization + 0... .... = RFCI 0 LRI: Not last RFCI (0x0) + .0.. .... = RFCI 0 LI: one octet used (0x0) + ..00 0000 = RFCI 0: 0 + RFCI 0 Flow 0 Len: 81 + RFCI 0 Flow 1 Len: 103 + RFCI 0 Flow 2 Len: 60 + RFCI 1 Initialization + 0... .... = RFCI 1 LRI: Not last RFCI (0x0) + .0.. .... = RFCI 1 LI: one octet used (0x0) + ..00 0001 = RFCI 1: 1 + RFCI 1 Flow 0 Len: 39 + RFCI 1 Flow 1 Len: 0 + RFCI 1 Flow 2 Len: 0 + RFCI 2 Initialization + 1... .... = RFCI 2 LRI: Last RFCI in current frame (0x1) + .0.. .... = RFCI 2 LI: one octet used (0x0) + ..00 0010 = RFCI 2: 2 + RFCI 2 Flow 0 Len: 0 + RFCI 2 Flow 1 Len: 0 + RFCI 2 Flow 2 Len: 0 + IPTIs + 0001 .... = RFCI 0 IPTI: 0x1 + .... 0111 = RFCI 1 IPTI: 0x7 + 0001 .... = RFCI 2 IPTI: 0x1 + Iu UP Mode Versions Supported: 0x0001 + 0... .... .... .... = Version 16: not supported (0x0) + .0.. .... .... .... = Version 15: not supported (0x0) + ..0. .... .... .... = Version 14: not supported (0x0) + ...0 .... .... .... = Version 13: not supported (0x0) + .... 0... .... .... = Version 12: not supported (0x0) + .... .0.. .... .... = Version 11: not supported (0x0) + .... ..0. .... .... = Version 10: not supported (0x0) + .... ...0 .... .... = Version 9: not supported (0x0) + .... .... 0... .... = Version 8: not supported (0x0) + .... .... .0.. .... = Version 7: not supported (0x0) + .... .... ..0. .... = Version 6: not supported (0x0) + .... .... ...0 .... = Version 5: not supported (0x0) + .... .... .... 0... = Version 4: not supported (0x0) + .... .... .... .0.. = Version 3: not supported (0x0) + .... .... .... ..0. = Version 2: not supported (0x0) + .... .... .... ...1 = Version 1: supported (0x1) + 0000 .... = RFCI Data Pdu Type: PDU type 0 (0x0) +*/ +static const uint8_t iuup_initialization[] = { + 0xe0, 0x00, 0xdf, 0x99, 0x16, 0x00, 0x51, 0x67, 0x3c, 0x01, 0x27, 0x00, + 0x00, 0x82, 0x00, 0x00, 0x00, 0x17, 0x10, 0x00, 0x01, 0x00 +}; + +/* Frame 87, "Data RFCI=0 FN = 1", OS#4744 3g_call_23112021.pcapng +IuUP + 0000 .... = PDU Type: Data with CRC (0) + .... 0001 = Frame Number: 1 + 00.. .... = FQC: Frame Good (0) + ..00 0000 = RFCI: 0x00 + 1110 00.. = Header CRC: 0x38 [correct] + .... ..11 1111 1111 = Payload CRC: 0x3ff + Payload Data: 08556d944c71a1a081e7ead204244480000ecd82b81118000097c4794e7740 +*/ +static const uint8_t iuup_data[] = { + 0x01, 0x00, 0xe3, 0xff, /*payload starts here: */ 0x08, 0x55, 0x6d, 0x94, 0x4c, 0x71, 0xa1, 0xa0, + 0x81, 0xe7, 0xea, 0xd2, 0x04, 0x24, 0x44, 0x80, 0x00, 0x0e, 0xcd, 0x82, + 0xb8, 0x11, 0x18, 0x00, 0x00, 0x97, 0xc4, 0x79, 0x4e, 0x77, 0x40 +}; + +#define IUUP_MSGB_SIZE 4096 + +static struct osmo_iuup_tnl_prim *itp_ctrl_nack_alloc(enum iuup_procedure proc_ind, enum iuup_error_cause error_cause, uint8_t fn) +{ + struct osmo_iuup_tnl_prim *tnp; + struct iuup_ctrl_nack *nack; + tnp = osmo_iuup_tnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_INDICATION, IUUP_MSGB_SIZE); + tnp->oph.msg->l2h = msgb_put(tnp->oph.msg, sizeof(struct iuup_ctrl_nack)); + nack = (struct iuup_ctrl_nack *) msgb_l2(tnp->oph.msg); + *nack = (struct iuup_ctrl_nack){ + .hdr = { + .frame_nr = fn, + .ack_nack = IUUP_AN_NACK, + .pdu_type = IUUP_PDU_T_CONTROL, + .proc_ind = proc_ind, + .mode_version = 0, + .payload_crc_hi = 0, + .header_crc = 0, + .payload_crc_lo = 0, + }, + .spare = 0, + .error_cause = error_cause, + }; + nack->hdr.header_crc = osmo_iuup_compute_header_crc(msgb_l2(tnp->oph.msg), msgb_l2len(tnp->oph.msg)); + return tnp; +} + +static struct osmo_iuup_tnl_prim *itp_ctrl_ack_alloc(enum iuup_procedure proc_ind, uint8_t fn) +{ + struct osmo_iuup_tnl_prim *tnp; + struct iuup_ctrl_ack *ack; + tnp = osmo_iuup_tnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_INDICATION, IUUP_MSGB_SIZE); + tnp->oph.msg->l2h = msgb_put(tnp->oph.msg, sizeof(struct iuup_ctrl_ack)); + ack = (struct iuup_ctrl_ack *) msgb_l2(tnp->oph.msg); + *ack = (struct iuup_ctrl_ack){ + .hdr = { + .frame_nr = fn, + .ack_nack = IUUP_AN_ACK, + .pdu_type = IUUP_PDU_T_CONTROL, + .proc_ind = proc_ind, + .mode_version = 0, + .payload_crc_hi = 0, + .header_crc = 0, + .payload_crc_lo = 0, + }, + }; + ack->hdr.header_crc = osmo_iuup_compute_header_crc(msgb_l2(tnp->oph.msg), msgb_l2len(tnp->oph.msg)); + return tnp; +} + +static void clock_override_set(long sec, long usec) +{ + osmo_gettimeofday_override_time.tv_sec = sec + usec / (1000*1000); + osmo_gettimeofday_override_time.tv_usec = usec % (1000*1000); + printf("sys={%lu.%06lu}, %s\n", osmo_gettimeofday_override_time.tv_sec, + osmo_gettimeofday_override_time.tv_usec, __func__); +} + +void test_crc(void) +{ + int rc; + + /* Frame 34, "Initialization ACK", OS#4744 3g_call_23112021.pcapng */ + static const uint8_t iuup_initialization_ack[] = { + 0xe4, 0x00, 0xdf, 0x99, 0x16, 0x00, 0x51, 0x67, 0x3c, 0x01, 0x27, 0x00, + 0x00, 0x82, 0x00, 0x00, 0x00, 0x17, 0x10, 0x00, 0x01, 0x00 + }; + + printf("=== start: %s ===\n", __func__); + + rc = osmo_iuup_compute_header_crc(iuup_initialization, sizeof(iuup_initialization)); + printf("iuup_initialization: Header CRC = 0x%02x\n", rc); + rc = osmo_iuup_compute_payload_crc(iuup_initialization, sizeof(iuup_initialization)); + printf("iuup_initialization: Payload CRC = 0x%03x\n", rc); + + rc = osmo_iuup_compute_header_crc(iuup_initialization_ack, sizeof(iuup_initialization_ack)); + printf("iuup_initialization_ack: Header CRC = 0x%02x\n", rc); + rc = osmo_iuup_compute_payload_crc(iuup_initialization_ack, sizeof(iuup_initialization_ack)); + printf("iuup_initialization_ack: Payload CRC = 0x%03x\n", rc); + + printf("=== end: %s ===\n", __func__); +} + + +/**************************** + * test_tinit_timeout_retrans + ****************************/ +static unsigned int _tinit_timeout_retrans_user_rx_prim = 0; +static int _tinit_timeout_retrans_user_prim_cb(struct osmo_prim_hdr *oph, void *ctx) +{ + struct osmo_iuup_rnl_prim *irp = (struct osmo_iuup_rnl_prim *)oph; + printf("%s()\n", __func__); + + OSMO_ASSERT(OSMO_PRIM_HDR(&irp->oph) == OSMO_PRIM(OSMO_IUUP_RNL_STATUS, PRIM_OP_INDICATION)); + + OSMO_ASSERT(irp->u.status.procedure == IUUP_PROC_ERR_EVENT); + OSMO_ASSERT(irp->u.status.u.error_event.cause == IUUP_ERR_CAUSE_INIT_FAILURE_NET_TMR); + OSMO_ASSERT(irp->u.status.u.error_event.distance == IUUP_ERR_DIST_LOCAL); + _tinit_timeout_retrans_user_rx_prim++; + msgb_free(oph->msg); + return 0; +} +static unsigned int _tinit_timeout_retrans_transport_rx_prim = 0; +static int _tinit_timeout_retrans_transport_prim_cb(struct osmo_prim_hdr *oph, void *ctx) +{ + struct osmo_iuup_tnl_prim *itp = (struct osmo_iuup_tnl_prim *)oph; + struct msgb *msg = oph->msg; + + printf("%s()\n", __func__); + OSMO_ASSERT(OSMO_PRIM_HDR(&itp->oph) == OSMO_PRIM(OSMO_IUUP_TNL_UNITDATA, PRIM_OP_REQUEST)); + printf("Transport: DL len=%u: %s\n", msgb_l2len(msg), + osmo_hexdump((const unsigned char *) msgb_l2(msg), msgb_l2len(msg))); + _tinit_timeout_retrans_transport_rx_prim++; + + msgb_free(msg); + return 0; +} +void test_tinit_timeout_retrans(void) +{ + struct osmo_iuup_instance *iui; + struct osmo_iuup_rnl_prim *rnp; + int rc, i; + + iui = osmo_iuup_instance_alloc(iuup_test_ctx, __func__); + OSMO_ASSERT(iui); + osmo_iuup_instance_set_user_prim_cb(iui, _tinit_timeout_retrans_user_prim_cb, NULL); + osmo_iuup_instance_set_transport_prim_cb(iui, _tinit_timeout_retrans_transport_prim_cb, NULL); + + clock_override_set(0, 0); + + /* Tx CONFIG.req */ + rnp = osmo_iuup_rnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_RNL_CONFIG, PRIM_OP_REQUEST, IUUP_MSGB_SIZE); + rnp->u.config = def_configure_req; + OSMO_ASSERT((rc = osmo_iuup_rnl_prim_down(iui, rnp)) == 0); + /* STATUS-INIT.req is transmitted automatically: */ + OSMO_ASSERT(_tinit_timeout_retrans_transport_rx_prim == 1); + + /* After one sec, INITIALIZATION msg is retransmitted */ + for (i = 1; i < IUUP_TIMER_INIT_N_DEFAULT + 1; i++) { + clock_override_set(0, IUUP_TIMER_INIT_T_DEFAULT*1000 * i); + osmo_select_main(0); + OSMO_ASSERT(_tinit_timeout_retrans_transport_rx_prim == i + 1); + } + /* Last one should send an error event: */ + OSMO_ASSERT(_tinit_timeout_retrans_user_rx_prim == 0); + clock_override_set(0, IUUP_TIMER_INIT_T_DEFAULT*1000 * i); + osmo_select_main(0); + OSMO_ASSERT(_tinit_timeout_retrans_transport_rx_prim == i); + OSMO_ASSERT(_tinit_timeout_retrans_user_rx_prim == 1); + + /* Nothing else is received afterwards. osmo_select_main() will block forever. */ + /*clock_override_set(i + 1, 0); + osmo_select_main(0); + OSMO_ASSERT(_tinit_timeout_retrans_transport_rx_prim == i); + OSMO_ASSERT(_tinit_timeout_retrans_user_rx_prim == 1);*/ + + osmo_iuup_instance_free(iui); +} + +/**************************** + * test_tinit_nack + ****************************/ +static unsigned int _init_nack_retrans_user_rx_prim = 0; +static int _init_nack_retrans_user_prim_cb(struct osmo_prim_hdr *oph, void *ctx) +{ + struct osmo_iuup_rnl_prim *irp = (struct osmo_iuup_rnl_prim *)oph; + + printf("%s()\n", __func__); + + OSMO_ASSERT(OSMO_PRIM_HDR(&irp->oph) == OSMO_PRIM(OSMO_IUUP_RNL_STATUS, PRIM_OP_INDICATION)); + + OSMO_ASSERT(irp->u.status.procedure == IUUP_PROC_ERR_EVENT); + OSMO_ASSERT(irp->u.status.u.error_event.cause == IUUP_ERR_CAUSE_INIT_FAILURE_REP_NACK); + OSMO_ASSERT(irp->u.status.u.error_event.distance == IUUP_ERR_DIST_SECOND_FWD); + _init_nack_retrans_user_rx_prim++; + msgb_free(oph->msg); + return 0; +} +static int _init_nack_retrans_transport_rx_prim = 0; +static int _init_nack_retrans_transport_prim_cb(struct osmo_prim_hdr *oph, void *ctx) +{ + struct osmo_iuup_tnl_prim *itp = (struct osmo_iuup_tnl_prim *)oph; + struct msgb *msg = oph->msg; + + printf("%s()\n", __func__); + OSMO_ASSERT(OSMO_PRIM_HDR(&itp->oph) == OSMO_PRIM(OSMO_IUUP_TNL_UNITDATA, PRIM_OP_REQUEST)); + printf("Transport: DL len=%u: %s\n", msgb_l2len(msg), + osmo_hexdump((const unsigned char *) msgb_l2(msg), msgb_l2len(msg))); + _init_nack_retrans_transport_rx_prim++; + + msgb_free(msg); + return 0; +} +void test_init_nack_retrans(void) +{ + struct osmo_iuup_instance *iui; + struct osmo_iuup_rnl_prim *rnp; + struct osmo_iuup_tnl_prim *tnp; + int rc, i; + + iui = osmo_iuup_instance_alloc(iuup_test_ctx, __func__); + OSMO_ASSERT(iui); + osmo_iuup_instance_set_user_prim_cb(iui, _init_nack_retrans_user_prim_cb, NULL); + osmo_iuup_instance_set_transport_prim_cb(iui, _init_nack_retrans_transport_prim_cb, NULL); + + clock_override_set(0, 0); + + /* Tx CONFIG.req */ + rnp = osmo_iuup_rnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_RNL_CONFIG, PRIM_OP_REQUEST, IUUP_MSGB_SIZE); + rnp->u.config = def_configure_req; + OSMO_ASSERT((rc = osmo_iuup_rnl_prim_down(iui, rnp)) == 0); + /* STATUS-INIT.req is transmitted automatically: */ + OSMO_ASSERT(_init_nack_retrans_transport_rx_prim == 1); + + /* After one sec, INITIALIZATION msg is retransmitted */ + for (i = 1; i < IUUP_TIMER_INIT_N_DEFAULT + 1; i++) { + /* Send NACK: */ + tnp = itp_ctrl_nack_alloc(IUUP_PROC_INIT, IUUP_ERR_CAUSE_MODE_VERSION_NOT_SUPPORTED, 0); + OSMO_ASSERT((rc = osmo_iuup_tnl_prim_up(iui, tnp)) == 0); + /* A new INIT is retransmitted: */ + OSMO_ASSERT(_init_nack_retrans_transport_rx_prim == i + 1); + } + /* Last one should send an error event: */ + OSMO_ASSERT(_init_nack_retrans_user_rx_prim == 0); + tnp = itp_ctrl_nack_alloc(IUUP_PROC_INIT, IUUP_ERR_CAUSE_MODE_VERSION_NOT_SUPPORTED, 0); + OSMO_ASSERT((rc = osmo_iuup_tnl_prim_up(iui, tnp)) == 0); + OSMO_ASSERT(_init_nack_retrans_transport_rx_prim == i); + OSMO_ASSERT(_init_nack_retrans_user_rx_prim == 1); + + /* Nothing else is received afterwards. osmo_select_main() will block forever. */ + + osmo_iuup_instance_free(iui); +} + + +/**************************** + * test_init_ack + ****************************/ +static unsigned int _init_ack_user_rx_prim = 0; +static int _init_ack_user_prim_cb(struct osmo_prim_hdr *oph, void *ctx) +{ + struct osmo_iuup_rnl_prim *irp = (struct osmo_iuup_rnl_prim *)oph; + struct msgb *msg = oph->msg; + + printf("%s()\n", __func__); + + OSMO_ASSERT(OSMO_PRIM_HDR(&irp->oph) == OSMO_PRIM(OSMO_IUUP_RNL_DATA, PRIM_OP_INDICATION)); + printf("User: UL len=%u: %s\n", msgb_l3len(msg), + osmo_hexdump((const unsigned char *) msgb_l3(msg), msgb_l3len(msg))); + + _init_ack_user_rx_prim++; + msgb_free(oph->msg); + return 0; +} +static int _init_ack_transport_rx_prim = 0; +static int _init_ack_transport_prim_cb(struct osmo_prim_hdr *oph, void *ctx) +{ + struct osmo_iuup_tnl_prim *itp = (struct osmo_iuup_tnl_prim *)oph; + struct msgb *msg = oph->msg; + + printf("%s()\n", __func__); + OSMO_ASSERT(OSMO_PRIM_HDR(&itp->oph) == OSMO_PRIM(OSMO_IUUP_TNL_UNITDATA, PRIM_OP_REQUEST)); + printf("Transport: DL len=%u: %s\n", msgb_l2len(msg), + osmo_hexdump((const unsigned char *) msgb_l2(msg), msgb_l2len(msg))); + _init_ack_transport_rx_prim++; + + msgb_free(msg); + return 0; +} +void test_init_ack(void) +{ + struct osmo_iuup_instance *iui; + struct osmo_iuup_rnl_prim *rnp; + struct osmo_iuup_tnl_prim *tnp; + struct iuup_pdutype0_hdr *hdr0; + int rc; + + iui = osmo_iuup_instance_alloc(iuup_test_ctx, __func__); + OSMO_ASSERT(iui); + osmo_iuup_instance_set_user_prim_cb(iui, _init_ack_user_prim_cb, NULL); + osmo_iuup_instance_set_transport_prim_cb(iui, _init_ack_transport_prim_cb, NULL); + + clock_override_set(0, 0); + + /* Tx CONFIG.req */ + rnp = osmo_iuup_rnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_RNL_CONFIG, PRIM_OP_REQUEST, IUUP_MSGB_SIZE); + rnp->u.config = def_configure_req; + OSMO_ASSERT((rc = osmo_iuup_rnl_prim_down(iui, rnp)) == 0); + /* STATUS-INIT.req is transmitted automatically: */ + OSMO_ASSERT(_init_ack_transport_rx_prim == 1); + + /* Send ACK: */ + tnp = itp_ctrl_ack_alloc(IUUP_PROC_INIT, 0); + OSMO_ASSERT((rc = osmo_iuup_tnl_prim_up(iui, tnp)) == 0); + OSMO_ASSERT(_init_ack_transport_rx_prim == 1); /* Make sure there's no retrans */ + OSMO_ASSERT(_init_ack_user_rx_prim == 0); /* Make sure there's no error event */ + + /* Send IuUP incoming data to the implementation: */ + tnp = osmo_iuup_tnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_INDICATION, IUUP_MSGB_SIZE); + tnp->oph.msg->l2h = msgb_put(tnp->oph.msg, sizeof(iuup_data)); + hdr0 = (struct iuup_pdutype0_hdr *)msgb_l2(tnp->oph.msg); + memcpy(hdr0, iuup_data, sizeof(iuup_data)); + OSMO_ASSERT((rc = osmo_iuup_tnl_prim_up(iui, tnp)) == 0); + /* We receive it in RNL: */ + OSMO_ASSERT(_init_ack_user_rx_prim == 1); + + /* Now in opposite direction, RNL->[IuuP]->TNL: */ + rnp = osmo_iuup_rnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_RNL_DATA, PRIM_OP_REQUEST, IUUP_MSGB_SIZE); + rnp->u.data.rfci = 0; + rnp->u.data.frame_nr = 1; + rnp->u.data.fqc = IUUP_FQC_FRAME_GOOD; + rnp->oph.msg->l3h = msgb_put(rnp->oph.msg, sizeof(iuup_data) - 4); + memcpy(rnp->oph.msg->l3h, iuup_data + 4, sizeof(iuup_data) - 4); + OSMO_ASSERT((rc = osmo_iuup_rnl_prim_down(iui, rnp)) == 0); + OSMO_ASSERT(_init_ack_transport_rx_prim == 2); /* We receive data in TNL */ + + osmo_iuup_instance_free(iui); +} + +/**************************** + * test_passive_init + ****************************/ +static unsigned int _passive_init_user_rx_prim = 0; +static int _passive_init_user_prim_cb(struct osmo_prim_hdr *oph, void *ctx) +{ + struct osmo_iuup_rnl_prim *irp = (struct osmo_iuup_rnl_prim *)oph; + struct msgb *msg = oph->msg; + + printf("%s()\n", __func__); + + OSMO_ASSERT(OSMO_PRIM_HDR(&irp->oph) == OSMO_PRIM(OSMO_IUUP_RNL_DATA, PRIM_OP_INDICATION)); + printf("User: UL len=%u: %s\n", msgb_l3len(msg), + osmo_hexdump((const unsigned char *) msgb_l3(msg), msgb_l3len(msg))); + + _passive_init_user_rx_prim++; + msgb_free(oph->msg); + return 0; +} +static int _passive_init_transport_rx_prim = 0; +static int _passive_init_transport_prim_cb(struct osmo_prim_hdr *oph, void *ctx) +{ + struct osmo_iuup_tnl_prim *itp = (struct osmo_iuup_tnl_prim *)oph; + struct msgb *msg; + + printf("%s()\n", __func__); + msg = oph->msg; + OSMO_ASSERT(OSMO_PRIM_HDR(&itp->oph) == OSMO_PRIM(OSMO_IUUP_TNL_UNITDATA, PRIM_OP_REQUEST)); + printf("Transport: DL len=%u: %s\n", msgb_l2len(msg), + osmo_hexdump((const unsigned char *) msgb_l2(msg), msgb_l2len(msg))); + _passive_init_transport_rx_prim++; + + msgb_free(msg); + return 0; +} +void test_passive_init(void) +{ + /* Here we check the passive INIT code path, aka receiving INIT and returning INIT_ACK/NACK */ + struct osmo_iuup_instance *iui; + struct osmo_iuup_rnl_prim *rnp; + struct osmo_iuup_tnl_prim *tnp; + struct iuup_pdutype14_hdr *hdr14; + struct iuup_pdutype0_hdr *hdr0; + int rc; + + iui = osmo_iuup_instance_alloc(iuup_test_ctx, __func__); + OSMO_ASSERT(iui); + osmo_iuup_instance_set_user_prim_cb(iui, _passive_init_user_prim_cb, NULL); + osmo_iuup_instance_set_transport_prim_cb(iui, _passive_init_transport_prim_cb, NULL); + + clock_override_set(0, 0); + + /* Tx CONFIG.req */ + rnp = osmo_iuup_rnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_RNL_CONFIG, PRIM_OP_REQUEST, IUUP_MSGB_SIZE); + rnp->u.config = def_configure_req; + rnp->u.config.active = false; + OSMO_ASSERT((rc = osmo_iuup_rnl_prim_down(iui, rnp)) == 0); + /* STATUS-INIT.req is NOT transmitted automatically: */ + OSMO_ASSERT(_passive_init_transport_rx_prim == 0); + + /* Send Init: */ + tnp = osmo_iuup_tnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_INDICATION, IUUP_MSGB_SIZE); + tnp->oph.msg->l2h = msgb_put(tnp->oph.msg, sizeof(iuup_initialization)); + hdr14 = (struct iuup_pdutype14_hdr *)msgb_l2(tnp->oph.msg); + memcpy(hdr14, iuup_initialization, sizeof(iuup_initialization)); + OSMO_ASSERT((rc = osmo_iuup_tnl_prim_up(iui, tnp)) == 0); + OSMO_ASSERT(_passive_init_transport_rx_prim == 1); /* We receive an Init ACK */ + OSMO_ASSERT(_passive_init_user_rx_prim == 0); + + /* Send IuUP incoming data to the implementation: */ + tnp = osmo_iuup_tnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_INDICATION, IUUP_MSGB_SIZE); + tnp->oph.msg->l2h = msgb_put(tnp->oph.msg, sizeof(iuup_data)); + hdr0 = (struct iuup_pdutype0_hdr *)msgb_l2(tnp->oph.msg); + memcpy(hdr0, iuup_data, sizeof(iuup_data)); + OSMO_ASSERT((rc = osmo_iuup_tnl_prim_up(iui, tnp)) == 0); + /* We receive it in RNL: */ + OSMO_ASSERT(_passive_init_user_rx_prim == 1); + + /* Now in opposite direction, RNL->[IuuP]->TNL: */ + rnp = osmo_iuup_rnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_RNL_DATA, PRIM_OP_REQUEST, IUUP_MSGB_SIZE); + rnp->u.data.rfci = 0; + rnp->u.data.frame_nr = 1; + rnp->u.data.fqc = IUUP_FQC_FRAME_GOOD; + rnp->oph.msg->l3h = msgb_put(rnp->oph.msg, sizeof(iuup_data) - 4); + memcpy(rnp->oph.msg->l3h, iuup_data + 4, sizeof(iuup_data) - 4); + OSMO_ASSERT((rc = osmo_iuup_rnl_prim_down(iui, rnp)) == 0); + OSMO_ASSERT(_passive_init_transport_rx_prim == 2); /* We receive data in TNL */ + + osmo_iuup_instance_free(iui); +} + +int main(int argc, char **argv) +{ + iuup_test_ctx = talloc_named_const(NULL, 0, "iuup_test"); + osmo_init_logging2(iuup_test_ctx, NULL); + log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_category_hex(osmo_stderr_target, 0); + log_set_use_color(osmo_stderr_target, 0); + log_set_category_filter(osmo_stderr_target, DLIUUP, 1, LOGL_DEBUG); + osmo_fsm_log_addr(false); + + osmo_gettimeofday_override = true; + + test_crc(); + test_tinit_timeout_retrans(); + test_init_nack_retrans(); + test_init_ack(); + test_passive_init(); + + printf("OK.\n"); +} diff --git a/tests/iuup/iuup_test.ok b/tests/iuup/iuup_test.ok new file mode 100644 index 0000000..5423096 --- /dev/null +++ b/tests/iuup/iuup_test.ok @@ -0,0 +1,45 @@ +=== start: test_crc === +iuup_initialization: Header CRC = 0x37 +iuup_initialization: Payload CRC = 0x399 +iuup_initialization_ack: Header CRC = 0x09 +iuup_initialization_ack: Payload CRC = 0x399 +=== end: test_crc === +sys={0.000000}, clock_override_set +_tinit_timeout_retrans_transport_prim_cb() +Transport: DL len=22: e0 00 df 99 16 00 51 67 3c 01 27 00 00 82 00 00 00 17 10 00 01 00 +sys={1.000000}, clock_override_set +_tinit_timeout_retrans_transport_prim_cb() +Transport: DL len=22: e0 00 df 99 16 00 51 67 3c 01 27 00 00 82 00 00 00 17 10 00 01 00 +sys={2.000000}, clock_override_set +_tinit_timeout_retrans_transport_prim_cb() +Transport: DL len=22: e0 00 df 99 16 00 51 67 3c 01 27 00 00 82 00 00 00 17 10 00 01 00 +sys={3.000000}, clock_override_set +_tinit_timeout_retrans_transport_prim_cb() +Transport: DL len=22: e0 00 df 99 16 00 51 67 3c 01 27 00 00 82 00 00 00 17 10 00 01 00 +sys={4.000000}, clock_override_set +_tinit_timeout_retrans_user_prim_cb() +sys={0.000000}, clock_override_set +_init_nack_retrans_transport_prim_cb() +Transport: DL len=22: e0 00 df 99 16 00 51 67 3c 01 27 00 00 82 00 00 00 17 10 00 01 00 +_init_nack_retrans_transport_prim_cb() +Transport: DL len=22: e0 00 df 99 16 00 51 67 3c 01 27 00 00 82 00 00 00 17 10 00 01 00 +_init_nack_retrans_transport_prim_cb() +Transport: DL len=22: e0 00 df 99 16 00 51 67 3c 01 27 00 00 82 00 00 00 17 10 00 01 00 +_init_nack_retrans_transport_prim_cb() +Transport: DL len=22: e0 00 df 99 16 00 51 67 3c 01 27 00 00 82 00 00 00 17 10 00 01 00 +_init_nack_retrans_user_prim_cb() +sys={0.000000}, clock_override_set +_init_ack_transport_prim_cb() +Transport: DL len=22: e0 00 df 99 16 00 51 67 3c 01 27 00 00 82 00 00 00 17 10 00 01 00 +_init_ack_user_prim_cb() +User: UL len=31: 08 55 6d 94 4c 71 a1 a0 81 e7 ea d2 04 24 44 80 00 0e cd 82 b8 11 18 00 00 97 c4 79 4e 77 40 +_init_ack_transport_prim_cb() +Transport: DL len=35: 01 00 e3 ff 08 55 6d 94 4c 71 a1 a0 81 e7 ea d2 04 24 44 80 00 0e cd 82 b8 11 18 00 00 97 c4 79 4e 77 40 +sys={0.000000}, clock_override_set +_passive_init_transport_prim_cb() +Transport: DL len=4: e4 00 24 00 +_passive_init_user_prim_cb() +User: UL len=31: 08 55 6d 94 4c 71 a1 a0 81 e7 ea d2 04 24 44 80 00 0e cd 82 b8 11 18 00 00 97 c4 79 4e 77 40 +_passive_init_transport_prim_cb() +Transport: DL len=35: 01 00 e3 ff 08 55 6d 94 4c 71 a1 a0 81 e7 ea d2 04 24 44 80 00 0e cd 82 b8 11 18 00 00 97 c4 79 4e 77 40 +OK. diff --git a/tests/logging/logging_vty_test.vty b/tests/logging/logging_vty_test.vty index 99e8781..c74accd 100644 --- a/tests/logging/logging_vty_test.vty +++ b/tests/logging/logging_vty_test.vty @@ -54,7 +54,7 @@ logging print level (0|1) logging print file (0|1|basename) [last] logging set-log-mask MASK - logging level (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal) (debug|info|notice|error|fatal) + logging level (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup) (debug|info|notice|error|fatal) logging level set-all (debug|info|notice|error|fatal) logging level force-all (debug|info|notice|error|fatal) no logging level force-all @@ -472,7 +472,7 @@ logging_vty_test# list ... - logp (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal) (debug|info|notice|error|fatal) .LOGMESSAGE + logp (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro|lns|lbssgp|lnsdata|lnssignal|liuup) (debug|info|notice|error|fatal) .LOGMESSAGE ... logging_vty_test# logp? @@ -507,6 +507,7 @@ lbssgp GPRS BSSGP layer lnsdata GPRS NS layer data PDU lnssignal GPRS NS layer signal PDU + liuup Iu UP layer logging_vty_test# logp lglobal ? debug Log debug messages and higher levels diff --git a/tests/testsuite.at b/tests/testsuite.at index 92c4e39..882203e 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -458,3 +458,9 @@ cat $abs_srcdir/time_cc/time_cc_test.ok > expout AT_CHECK([$abs_top_builddir/tests/time_cc/time_cc_test], [0], [expout], [ignore]) AT_CLEANUP + +AT_SETUP([iuup]) +AT_KEYWORDS([iuup]) +cat $abs_srcdir/iuup/iuup_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/iuup/iuup_test], [0], [expout], [ignore]) +AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/6357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 Gerrit-Change-Number: 6357 Gerrit-PatchSet: 7 Gerrit-Owner: laforge Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:51:09 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 23 Dec 2021 14:51:09 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Updates in HNBLLIF and HNBGW_COnnectioNHandler to support and... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26672 ) Change subject: hnodeb: Updates in HNBLLIF and HNBGW_COnnectioNHandler to support and test IuUP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I19612fce8190dfe14f98d346adb5db4e1c2a08d9 Gerrit-Change-Number: 26672 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 23 Dec 2021 14:51:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:51:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 23 Dec 2021 14:51:23 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Iuh_Emulation: Avoid sending events to HNBAP if socket is not connected In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26677 ) Change subject: Iuh_Emulation: Avoid sending events to HNBAP if socket is not connected ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26677 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide201425e81dcfe2fd395d820bdcbd74f5415ef5 Gerrit-Change-Number: 26677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 23 Dec 2021 14:51:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:51:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 23 Dec 2021 14:51:29 +0000 Subject: Change in osmo-ttcn3-hacks[master]: Iuh_Emulation: Avoid sending events to HNBAP if socket is not connected In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26677 ) Change subject: Iuh_Emulation: Avoid sending events to HNBAP if socket is not connected ...................................................................... Iuh_Emulation: Avoid sending events to HNBAP if socket is not connected This should hopefully fix HNB_Tests errors showing up in jenkins after the test finishes: Iuh_Emulation.ttcn:203 Dynamic test case error: Port HNBAP has neither connections nor mappings. Message cannot be sent on it. Change-Id: Ide201425e81dcfe2fd395d820bdcbd74f5415ef5 --- M library/Iuh_Emulation.ttcn 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/Iuh_Emulation.ttcn b/library/Iuh_Emulation.ttcn index 75a95ba..bc8e7c3 100644 --- a/library/Iuh_Emulation.ttcn +++ b/library/Iuh_Emulation.ttcn @@ -128,6 +128,12 @@ return conn_id; } +private function f_send_IUHEM_Event(template (value) IUHEM_Event evt) runs on Iuh_Emulation_CT { + if (HNBAP.checkstate("Connected")) { + HNBAP.send(evt); + } +} + function main(Iuh_conn_parameters p, charstring id) runs on Iuh_Emulation_CT { var Result res; g_pars := p; @@ -147,7 +153,7 @@ /* notify user about SCTP establishment */ if (p.remote_sctp_port != -1) { - HNBAP.send(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); + f_send_IUHEM_Event(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); } while (true) { @@ -194,13 +200,13 @@ g_last_conn_id := asp_evt.connOpened.connId; log("Established a new Iuh connection (conn_id=", g_last_conn_id, ")"); - HNBAP.send(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); /* TODO: send g_last_conn_id */ + f_send_IUHEM_Event(IUHEM_Event:{up_down:=IUHEM_EVENT_UP}); /* TODO: send g_last_conn_id */ } [] Iuh.receive(ASP_Event:{connClosed:=?}) -> value asp_evt { log("Iuh: Closed"); g_self_conn_id := -1; - HNBAP.send(IUHEM_Event:{up_down:=IUHEM_EVENT_DOWN}); /* TODO: send asp_evt.connClosed.connId */ + f_send_IUHEM_Event(IUHEM_Event:{up_down:=IUHEM_EVENT_DOWN}); /* TODO: send asp_evt.connClosed.connId */ if (not emu_is_server()) { self.stop; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26677 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide201425e81dcfe2fd395d820bdcbd74f5415ef5 Gerrit-Change-Number: 26677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:51:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 23 Dec 2021 14:51:29 +0000 Subject: Change in osmo-ttcn3-hacks[master]: hnodeb: Updates in HNBLLIF and HNBGW_COnnectioNHandler to support and... In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26672 ) Change subject: hnodeb: Updates in HNBLLIF and HNBGW_COnnectioNHandler to support and test IuUP ...................................................................... hnodeb: Updates in HNBLLIF and HNBGW_COnnectioNHandler to support and test IuUP Depends: osmo-hnodeb.git Change-Id Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 Related: SYS#5516 Change-Id: I19612fce8190dfe14f98d346adb5db4e1c2a08d9 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn M library/HNBLLIF_Templates.ttcn M library/HNBLLIF_Types.ttcn 4 files changed, 116 insertions(+), 20 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn index a3ff32f..ac280b0 100644 --- a/hnodeb/HNBGW_ConnectionHandler.ttcn +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -248,13 +248,14 @@ } /* Initialize and start the RTP emulation component for a ConnHdlr */ -function f_HNBGW_rtpem_activate(inout octetstring payload, - HostName remote_host, - PortNumber remote_port, - RtpemConfig cfg := c_RtpemDefaultCfg, - RtpemMode mode := RTPEM_MODE_BIDIR) +function f_HNBGW_rtpem_activate(inout octetstring payload) runs on HNBGW_ConnHdlr { - /* Step 0: initialize, connect and start the emulation component */ + /* Initialize, connect and start the emulation component */ + var RtpemConfig cfg := c_RtpemDefaultCfg; + cfg.iuup_mode := true; + cfg.iuup_tx_init := false; + cfg.tx_payload_type := 96; + vc_RTPEM := RTP_Emulation_CT.create(testcasename() & "-RTPEM") alive; map(vc_RTPEM:RTP, system:RTP); map(vc_RTPEM:RTCP, system:RTCP); @@ -274,11 +275,15 @@ /* Bind the RTP emulation to the configured address */ f_rtpem_bind(RTPEM_CTRL, g_pars.hnbgw_addr, g_pars.hnbgw_rtp_port); - /* Connect to the IUT's address/port parsed from CRCX ACK */ - f_rtpem_connect(RTPEM_CTRL, remote_host, remote_port); - /* Set the given RTP emulation mode */ - f_rtpem_mode(RTPEM_CTRL, mode); + f_rtpem_mode(RTPEM_CTRL, RTPEM_MODE_RXONLY); +} + +function f_HNBGW_rtpem_connect(HostName remote_host, PortNumber remote_port) +runs on HNBGW_ConnHdlr { + f_rtpem_connect(RTPEM_CTRL, remote_host, remote_port); + /* Set the given RTP emulation mode */ + f_rtpem_mode(RTPEM_CTRL, RTPEM_MODE_BIDIR); } } diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index c801ee6..a58e203 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -56,6 +56,8 @@ import from GTP_Templates all; import from GTP_Emulation all; +import from IuUP_Types all; + modulepar { /* IP address at which the HNodeB can be reached */ charstring mp_hnodeb_ip := "127.0.0.1"; @@ -297,6 +299,10 @@ var PortNumber hnodeb_rtp_port; timer Tu; var uint32_t audio_conn_id; + var IuUP_FQC fqc := IuUP_FQC_GOOD; + + rtp_payload := f_rnd_octstring(6); + f_HNBGW_rtpem_activate(rtp_payload); f_handle_hnbap_hnb_register_req(); @@ -326,11 +332,22 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "hnodeb RTP local address doesn't match expectations"); } hnodeb_rtp_port := sd.data.u.audio.u.conn_establish.u.cnf.local_rtp_port; - rtp_payload := f_rnd_octstring(6); - f_HNBGW_rtpem_activate(rtp_payload, hnodeb_rtp_addr, hnodeb_rtp_port); + f_HNBGW_rtpem_connect(hnodeb_rtp_addr, hnodeb_rtp_port); + + /* We should eventually receive some RTP/IUUP from the HNBGW once Init phase goes on: */ + Tu.start(2.0); + alt { + [] LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_DATA_IND(audio_conn_id, ?, enum2int(fqc), ?, rtp_payload))); + [] Tu.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for Downlink speech frames"); + } + } + Tu.stop; + f_rtpem_mode(RTPEM_CTRL, RTPEM_MODE_RXONLY); + /* Make sure that Uplink frames are received at the HNBGW */ RTPEM_DATA.clear; - LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_DATA_REQ(audio_conn_id, rtp_payload))); + LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_DATA_REQ(audio_conn_id, 1, enum2int(fqc), 0, rtp_payload))); Tu.start(2.0); alt { [] RTPEM_DATA.receive(PDU_RTP:?) -> value rtp_pdu { @@ -345,10 +362,9 @@ } } Tu.stop; - /* We should also have received some RTP from the HNBGW: */ - LLSK.receive(f_llsk_rx(tr_HNBLLIF_AUDIO_CONN_DATA_IND(audio_conn_id, rtp_payload))); f_rtpem_mode(RTPEM_CTRL, RTPEM_MODE_NONE); + f_sleep(0.5); /* give some time to RTP_Emu to stop sending RTP packets... */ LLSK.send(f_llsk_tx(ts_HNBLLIF_AUDIO_CONN_RELEASE_REQ(audio_conn_id))); diff --git a/library/HNBLLIF_Templates.ttcn b/library/HNBLLIF_Templates.ttcn index fc82a72..6aee659 100644 --- a/library/HNBLLIF_Templates.ttcn +++ b/library/HNBLLIF_Templates.ttcn @@ -251,11 +251,42 @@ /********************** * AUDIO SAPI **********************/ +const HNBLLIF_AUDIO_IPTIs IPTIs_default := { + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 +}; + +private function f_subflow_sizes_default() return HNBLLIF_AUDIO_SubflowSizes +{ + var HNBLLIF_AUDIO_SubflowSizes ss; + + for (var integer i := 0; i < HNBLLIF_MAX_RFCIS; i := i + 1) { + for (var integer j := 0; j < HNBLLIF_MAX_SUBFLOWS; j := j + 1) { + ss[i][j] := 0; + } + } + + ss[0][0] := 81; ss[0][1] := 103; ss[0][2] := 60; + ss[1][0] := 39; ss[1][1] := 0; ss[1][2] := 0; + ss[2][0] := 0; ss[2][1] := 0; ss[2][2] := 0; + + return ss; +} template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_ESTABLISH_REQ(template (value) uint32_t context_id, template (value) uint16_t remote_rtp_port, template (value) HNBLLIF_AddrType remote_rtp_address_type, - template (value) HNBLLIF_Addr remote_addr) := { + template (value) HNBLLIF_Addr remote_addr, + template (value) uint8_t transparent := 0, + template (value) uint8_t data_pdu_type := 0, + template (value) uint16_t supported_versions_mask := 3, + template (value) uint8_t num_rfci := 3, + template (value) uint8_t num_subflows := 3, + template (value) HNBLLIF_AUDIO_SubflowSizes subflow_sizes := f_subflow_sizes_default(), + template (value) uint8_t IPTIs_present := 0, + template (value) HNBLLIF_AUDIO_IPTIs IPTIs := IPTIs_default) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { audio := { @@ -269,7 +300,15 @@ remote_rtp_port := remote_rtp_port, reserved := 0, remote_rtp_address_type := remote_rtp_address_type, - remote_addr := remote_addr + remote_addr := remote_addr, + transparent := transparent, + data_pdu_type := data_pdu_type, + supported_versions_mask := supported_versions_mask, + num_rfci := num_rfci, + num_subflows := num_subflows, + subflow_sizes := subflow_sizes, + IPTIs_present := IPTIs_present, + IPTIs := IPTIs } } } @@ -327,7 +366,10 @@ } template (present) HNBLLIF_Message tr_HNBLLIF_AUDIO_CONN_DATA_IND(template (present) uint32_t audio_conn_id := ?, - template (present) octetstring data := ?) := { + template (present) uint8_t frame_nr := ?, + template (present) uint8_t fqc := ?, + template (present) uint8_t rfci := ?, + template (present) octetstring data := ?) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { audio := { @@ -338,6 +380,10 @@ u := { ind := { audio_conn_id := audio_conn_id, + frame_nr := frame_nr, + fqc := fqc, + rfci := rfci, + spare := 0, data_len := ?, data := data } @@ -349,6 +395,9 @@ } template (value) HNBLLIF_Message ts_HNBLLIF_AUDIO_CONN_DATA_REQ(template (value) uint32_t audio_conn_id, + template (value) uint8_t frame_nr, + template (value) uint8_t fqc, + template (value) uint8_t rfci, template (value) octetstring data) := { sapi := HNBLL_IF_SAPI_AUDIO, u := { @@ -360,6 +409,10 @@ u := { req := { audio_conn_id := audio_conn_id, + frame_nr := frame_nr, + fqc := fqc, + rfci := rfci, + spare := 0, data_len := lengthof(data), data := data } diff --git a/library/HNBLLIF_Types.ttcn b/library/HNBLLIF_Types.ttcn index a3a6c4c..fa44f11 100644 --- a/library/HNBLLIF_Types.ttcn +++ b/library/HNBLLIF_Types.ttcn @@ -241,14 +241,28 @@ HNBLL_IF_AUDIO_MSG_CONN_DATA ('0002'O) } with { variant "FIELDLENGTH(16)" }; +const integer HNBLLIF_MAX_RFCIS := 64; +const integer HNBLLIF_MAX_SUBFLOWS := 7; +type record length(HNBLLIF_MAX_RFCIS) of uint8_t HNBLLIF_AUDIO_IPTIs; +type record length(HNBLLIF_MAX_SUBFLOWS) of uint16_t HNBLLIF_AUDIO_RFCI_SubflowSizes; +type record length(HNBLLIF_MAX_RFCIS) of HNBLLIF_AUDIO_RFCI_SubflowSizes HNBLLIF_AUDIO_SubflowSizes; + /* CONN_ESTABLISH */ type record HNBLLIF_AUDIO_conn_establish_req { uint32_t context_id, uint16_t remote_rtp_port, uint8_t reserved, HNBLLIF_AddrType remote_rtp_address_type, - HNBLLIF_Addr remote_addr -} with { variant "" }; + HNBLLIF_Addr remote_addr, + uint8_t transparent, /* 1=transparent; 0=SMpSDU */ + uint8_t data_pdu_type, + uint16_t supported_versions_mask, /* host byte order */ + uint8_t num_rfci, + uint8_t num_subflows, + HNBLLIF_AUDIO_SubflowSizes subflow_sizes, + uint8_t IPTIs_present, /* 1=present; 0=not present */ + HNBLLIF_AUDIO_IPTIs IPTIs /* values range 0-15, 4 bits */ +} with { variant "" }; type record HNBLLIF_AUDIO_conn_establish_cnf { uint32_t context_id, @@ -292,12 +306,20 @@ /* CONN_DATA */ type record HNBLLIF_AUDIO_conn_data_ind { uint32_t audio_conn_id, + uint8_t frame_nr, + uint8_t fqc, /* enumerated IuUP_FQC */ + uint8_t rfci, + uint8_t spare, uint32_t data_len, octetstring data /* RANAP message */ } with { variant (data_len) "LENGTHTO (data)" }; type record HNBLLIF_AUDIO_conn_data_req { uint32_t audio_conn_id, + uint8_t frame_nr, + uint8_t fqc, /* enumerated IuUP_FQC */ + uint8_t rfci, + uint8_t spare, uint32_t data_len, octetstring data /* RANAP message */ } with { variant (data_len) "LENGTHTO (data)" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I19612fce8190dfe14f98d346adb5db4e1c2a08d9 Gerrit-Change-Number: 26672 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:52:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 23 Dec 2021 14:52:13 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... Patch Set 18: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 18 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 23 Dec 2021 14:52:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:52:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 23 Dec 2021 14:52:15 +0000 Subject: Change in libosmocore[master]: select: gather statistics for TCP connections In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26454 ) Change subject: select: gather statistics for TCP connections ...................................................................... select: gather statistics for TCP connections osmocom applications are deployed in a variety of different situations. Dependung on the medium that interconnects the network components unexpected behaviour may occur. To debug problems with the interconnection between network components it might help to monitor the health of the related TCP connections. Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Related: SYS#5701 --- M configure.ac M include/Makefile.am A include/osmocom/core/stats_tcp.h M src/Makefile.am M src/select.c M src/stats.c A src/stats_tcp.c M src/vty/stats_vty.c M tests/stats/stats_vty_test.vty 9 files changed, 406 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index a69f793..8fb299b 100644 --- a/configure.ac +++ b/configure.ac @@ -516,6 +516,28 @@ CHECK_BUILTIN_SUPPORT([__builtin_cpu_supports], [Runtime SIMD detection will be disabled]) +dnl There are some members in struct tcp_info that might not exist on all linux versions +AC_CHECK_MEMBER([struct tcp_info.tcpi_rwnd_limited], + AC_DEFINE([HAVE_TCP_INFO_TCPI_RWND_LIMITED], + [1], + [Define to 1 if your header file have the tcpi_rwnd_limited member in struct tcp_info]), + [], + [#include ]) + +AC_CHECK_MEMBER([struct tcp_info.tcpi_sndbuf_limited], + AC_DEFINE([HAVE_TCP_INFO_TCPI_SNDBUF_LIMITED], + [1], + [Define to 1 if your header file have the tcpi_sndbuf_limited member in struct tcp_info]), + [], + [#include ]) + +AC_CHECK_MEMBER([struct tcp_info.tcpi_reord_seen], + AC_DEFINE([HAVE_TCP_INFO_TCPI_REORD_SEEN], + [1], + [Define to 1 if your header file have the tcpi_reord_seen member in struct tcp_info]), + [], + [#include ]) + AC_MSG_RESULT([CFLAGS="$CFLAGS"]) AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"]) diff --git a/include/Makefile.am b/include/Makefile.am index eab0489..a234014 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -46,6 +46,7 @@ osmocom/core/process.h \ osmocom/core/rate_ctr.h \ osmocom/core/stat_item.h \ + osmocom/core/stats_tcp.h \ osmocom/core/select.h \ osmocom/core/sercomm.h \ osmocom/core/signal.h \ diff --git a/include/osmocom/core/stats_tcp.h b/include/osmocom/core/stats_tcp.h new file mode 100644 index 0000000..6b9657a --- /dev/null +++ b/include/osmocom/core/stats_tcp.h @@ -0,0 +1,16 @@ +#pragma once + +#define TCP_STATS_DEFAULT_INTERVAL 0 /* secs */ +#define TCP_STATS_DEFAULT_BATCH_SIZE 1 /* sockets per interval */ + +struct osmo_tcp_stats_config { + /* poll interval in seconds, use osmo_stats_tcp_set_interval() to manipulate this value */ + int interval; + /* specify how many sockets are processed when the interval timer expires */ + int batch_size; +}; +extern struct osmo_tcp_stats_config *osmo_tcp_stats_config; + +int osmo_stats_tcp_osmo_fd_register(const struct osmo_fd *fd, const char *name); +int osmo_stats_tcp_osmo_fd_unregister(const struct osmo_fd *fd); +int osmo_stats_tcp_set_interval(int interval); diff --git a/src/Makefile.am b/src/Makefile.am index 4bda456..5777c31 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -22,6 +22,7 @@ conv.c application.c rbtree.c strrb.c \ loggingrb.c crc8gen.c crc16gen.c crc32gen.c crc64gen.c \ macaddr.c stat_item.c stats.c stats_statsd.c prim.c \ + stats_tcp.c \ conv_acc.c conv_acc_generic.c sercomm.c prbs.c \ isdnhdlc.c \ tdef.c \ diff --git a/src/select.c b/src/select.c index 590c3db..b48d13e 100644 --- a/src/select.c +++ b/src/select.c @@ -33,6 +33,8 @@ #include #include #include +#include +#include #include "../config.h" @@ -181,6 +183,9 @@ #ifndef FORCE_IO_SELECT g_poll.num_registered--; #endif /* FORCE_IO_SELECT */ + + /* If existent, free any statistical data */ + osmo_stats_tcp_osmo_fd_unregister(fd); } /*! Close a file descriptor, mark it as closed + unregister from select loop abstraction diff --git a/src/stats.c b/src/stats.c index f8c91fd..4267284 100644 --- a/src/stats.c +++ b/src/stats.c @@ -85,6 +85,7 @@ #include #include #include +#include #ifdef HAVE_SYSTEMTAP /* include the generated probes header and put markers in code */ @@ -240,6 +241,10 @@ osmo_stats_ctx = ctx; is_initialised = 1; start_timer(); + + /* Make sure that the tcp-stats interval timer also runs at its + * preconfigured rate. The vty might change this setting later. */ + osmo_stats_tcp_set_interval(osmo_tcp_stats_config->interval); } /*! Find a stats_reporter of given \a type and \a name. diff --git a/src/stats_tcp.c b/src/stats_tcp.c new file mode 100644 index 0000000..fffb10a --- /dev/null +++ b/src/stats_tcp.c @@ -0,0 +1,322 @@ +/* + * (C) 2021 by sysmocom - s.f.m.c. GmbH + * Author: Philipp Maier + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + */ + +/*! \addtogroup stats + * @{ + * \file stats_tcp.c */ + +#include "config.h" +#if !defined(EMBEDDED) + +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +static struct osmo_tcp_stats_config s_tcp_stats_config = { + .interval = TCP_STATS_DEFAULT_INTERVAL, +}; + +struct osmo_tcp_stats_config *osmo_tcp_stats_config = &s_tcp_stats_config; + +static struct osmo_timer_list stats_tcp_poll_timer; + +static LLIST_HEAD(stats_tcp); +static struct stats_tcp_entry *stats_tcp_entry_cur; +pthread_mutex_t stats_tcp_lock; + +struct stats_tcp_entry { + struct llist_head entry; + const struct osmo_fd *fd; + struct osmo_stat_item_group *stats_tcp; + const char *name; +}; + +enum { + STATS_TCP_UNACKED, + STATS_TCP_LOST, + STATS_TCP_RETRANS, + STATS_TCP_RTT, + STATS_TCP_RCV_RTT, + STATS_TCP_NOTSENT_BYTES, + STATS_TCP_RWND_LIMITED, + STATS_TCP_SNDBUF_LIMITED, + STATS_TCP_REORD_SEEN, +}; + +static struct osmo_stat_item_desc stats_tcp_item_desc[] = { + [STATS_TCP_UNACKED] = { "tcp:unacked", "unacknowledged packets", "", 60, 0 }, + [STATS_TCP_LOST] = { "tcp:lost", "lost packets", "", 60, 0 }, + [STATS_TCP_RETRANS] = { "tcp:retrans", "retransmitted packets", "", 60, 0 }, + [STATS_TCP_RTT] = { "tcp:rtt", "roundtrip-time", "", 60, 0 }, + [STATS_TCP_RCV_RTT] = { "tcp:rcv_rtt", "roundtrip-time (receive)", "", 60, 0 }, + [STATS_TCP_NOTSENT_BYTES] = { "tcp:notsent_bytes", "bytes not yet sent", "", 60, 0 }, + [STATS_TCP_RWND_LIMITED] = { "tcp:rwnd_limited", "time (usec) limited by receive window", "", 60, 0 }, + [STATS_TCP_SNDBUF_LIMITED] = { "tcp:sndbuf_limited", "Time (usec) limited by send buffer", "", 60, 0 }, + [STATS_TCP_REORD_SEEN] = { "tcp:sndbuf_limited", "reordering events seen", "", 60, 0 }, +}; + +static struct osmo_stat_item_group_desc stats_tcp_desc = { + .group_name_prefix = "tcp", + .group_description = "stats tcp", + .class_id = OSMO_STATS_CLASS_GLOBAL, + .num_items = ARRAY_SIZE(stats_tcp_item_desc), + .item_desc = stats_tcp_item_desc, +}; + +static void fill_stats(struct stats_tcp_entry *stats_tcp_entry) +{ + int rc; + struct tcp_info tcp_info; + socklen_t tcp_info_len = sizeof(tcp_info); + char stat_name[256]; + + /* Do not fill in anything before the socket is connected to a remote end */ + if (osmo_sock_get_ip_and_port(stats_tcp_entry->fd->fd, NULL, 0, NULL, 0, false) != 0) + return; + + /* Gather TCP statistics and update the stats items */ + rc = getsockopt(stats_tcp_entry->fd->fd, IPPROTO_TCP, TCP_INFO, &tcp_info, &tcp_info_len); + if (rc < 0) + return; + + /* Create stats items if they do not exist yet */ + if (!stats_tcp_entry->stats_tcp) { + stats_tcp_entry->stats_tcp = + osmo_stat_item_group_alloc(stats_tcp_entry, &stats_tcp_desc, stats_tcp_entry->fd->fd); + OSMO_ASSERT(stats_tcp_entry->stats_tcp); + } + + /* Update statistics */ + if (stats_tcp_entry->name) + snprintf(stat_name, sizeof(stat_name), "%s,%s", stats_tcp_entry->name, + osmo_sock_get_name2(stats_tcp_entry->fd->fd)); + else + snprintf(stat_name, sizeof(stat_name), "%s", osmo_sock_get_name2(stats_tcp_entry->fd->fd)); + osmo_stat_item_group_set_name(stats_tcp_entry->stats_tcp, stat_name); + + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_UNACKED), + tcp_info.tcpi_unacked); + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_LOST), + tcp_info.tcpi_lost); + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_RETRANS), + tcp_info.tcpi_retrans); + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_RTT), tcp_info.tcpi_rtt); + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_RCV_RTT), + tcp_info.tcpi_rcv_rtt); + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_NOTSENT_BYTES), + tcp_info.tcpi_notsent_bytes); + +#if HAVE_TCP_INFO_TCPI_RWND_LIMITED == 1 + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_RWND_LIMITED), + tcp_info.tcpi_rwnd_limited); +#else + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_RWND_LIMITED), -1); +#endif + +#if STATS_TCP_SNDBUF_LIMITED == 1 + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_REORD_SEEN), + tcp_info.tcpi_sndbuf_limited); +#else + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_REORD_SEEN), -1); +#endif + +#if HAVE_TCP_INFO_TCPI_REORD_SEEN == 1 + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_REORD_SEEN), + tcp_info.tcpi_reord_seen); +#else + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_REORD_SEEN), -1); +#endif + +} + +static bool is_tcp(const struct osmo_fd *fd) +{ + int rc; + struct stat fd_stat; + int so_protocol = 0; + socklen_t so_protocol_len = sizeof(so_protocol); + + /* Is this a socket? */ + rc = fstat(fd->fd, &fd_stat); + if (rc < 0) + return false; + if (!S_ISSOCK(fd_stat.st_mode)) + return false; + + /* Is it a TCP socket? */ + rc = getsockopt(fd->fd, SOL_SOCKET, SO_PROTOCOL, &so_protocol, &so_protocol_len); + if (rc < 0) + return false; + if (so_protocol == IPPROTO_TCP) + return true; + + return false; +} + +/*! Register an osmo_fd for TCP stats monitoring. + * \param[in] fd osmocom file descriptor to be registered. + * \param[in] human readbla name that is used as prefix for the related stats item. + * \returns 0 on success; negative in case of error. */ +int osmo_stats_tcp_osmo_fd_register(const struct osmo_fd *fd, const char *name) +{ + struct stats_tcp_entry *stats_tcp_entry; + + /* Only TCP sockets can be registered for monitoring, anything else will fall through. */ + if (!is_tcp(fd)) + return -EINVAL; + + /* When the osmo_fd is registered and unregistered properly there shouldn't be any leftovers from already closed + * osmo_fds in the stats_tcp list. But lets proactively make sure that any leftovers are cleaned up. */ + osmo_stats_tcp_osmo_fd_unregister(fd); + + /* Make a new list object, attach the osmo_fd... */ + stats_tcp_entry = talloc_zero(OTC_GLOBAL, struct stats_tcp_entry); + OSMO_ASSERT(stats_tcp_entry); + stats_tcp_entry->fd = fd; + stats_tcp_entry->name = talloc_strdup(stats_tcp_entry, name); + + pthread_mutex_lock(&stats_tcp_lock); + llist_add_tail(&stats_tcp_entry->entry, &stats_tcp); + pthread_mutex_unlock(&stats_tcp_lock); + + return 0; +} + +static void next_stats_tcp_entry(void) +{ + struct stats_tcp_entry *last; + + if (llist_empty(&stats_tcp)) { + stats_tcp_entry_cur = NULL; + return; + } + + last = (struct stats_tcp_entry *)llist_last_entry(&stats_tcp, struct stats_tcp_entry, entry); + + if (!stats_tcp_entry_cur || stats_tcp_entry_cur == last) + stats_tcp_entry_cur = + (struct stats_tcp_entry *)llist_first_entry(&stats_tcp, struct stats_tcp_entry, entry); + else + stats_tcp_entry_cur = + (struct stats_tcp_entry *)llist_entry(stats_tcp_entry_cur->entry.next, struct stats_tcp_entry, + entry); +} + +/*! Register an osmo_fd for TCP stats monitoring. + * \param[in] fd osmocom file descriptor to be unregistered. + * \returns 0 on success; negative in case of error. */ +int osmo_stats_tcp_osmo_fd_unregister(const struct osmo_fd *fd) +{ + struct stats_tcp_entry *stats_tcp_entry; + int rc = -EINVAL; + + pthread_mutex_lock(&stats_tcp_lock); + llist_for_each_entry(stats_tcp_entry, &stats_tcp, entry) { + if (fd->fd == stats_tcp_entry->fd->fd) { + /* In case we want to remove exactly that item which is also selected as the current itemy, we + * must designate either a different item or invalidate the current item. */ + if (stats_tcp_entry == stats_tcp_entry_cur) { + if (llist_count(&stats_tcp) > 2) + next_stats_tcp_entry(); + else + stats_tcp_entry_cur = NULL; + } + + /* Date item from list */ + llist_del(&stats_tcp_entry->entry); + osmo_stat_item_group_free(stats_tcp_entry->stats_tcp); + talloc_free(stats_tcp_entry); + rc = 0; + break; + } + } + pthread_mutex_unlock(&stats_tcp_lock); + + return rc; +} + +static void stats_tcp_poll_timer_cb(void *data) +{ + int i; + int batch_size; + int llist_size; + + pthread_mutex_lock(&stats_tcp_lock); + + /* Make sure we do not run over the same sockets multiple times if the + * configured llist_size is larger then the actual list */ + batch_size = osmo_tcp_stats_config->batch_size; + llist_size = llist_count(&stats_tcp); + if (llist_size < batch_size) + batch_size = llist_size; + + /* Process a batch of sockets */ + for (i = 0; i < batch_size; i++) { + next_stats_tcp_entry(); + if (stats_tcp_entry_cur) + fill_stats(stats_tcp_entry_cur); + } + + pthread_mutex_unlock(&stats_tcp_lock); + + if (osmo_tcp_stats_config->interval > 0) + osmo_timer_schedule(&stats_tcp_poll_timer, osmo_tcp_stats_config->interval, 0); +} + +/*! Set the polling interval (common for all sockets) + * \param[in] interval Poll interval in seconds + * \returns 0 on success; negative on error */ +int osmo_stats_tcp_set_interval(int interval) +{ + osmo_tcp_stats_config->interval = interval; + if (osmo_tcp_stats_config->interval > 0) + osmo_timer_schedule(&stats_tcp_poll_timer, osmo_tcp_stats_config->interval, 0); + return 0; +} + +static __attribute__((constructor)) +void on_dso_load_stats_tcp(void) +{ + stats_tcp_entry_cur = NULL; + pthread_mutex_init(&stats_tcp_lock, NULL); + + osmo_tcp_stats_config->interval = TCP_STATS_DEFAULT_INTERVAL; + osmo_tcp_stats_config->batch_size = TCP_STATS_DEFAULT_BATCH_SIZE; + + osmo_timer_setup(&stats_tcp_poll_timer, stats_tcp_poll_timer_cb, NULL); +} + +#endif /* !EMBEDDED */ + +/* @} */ diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index e2247a3..a73fafb 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -33,6 +33,7 @@ #include #include #include +#include #define CFG_STATS_STR "Configure stats sub-system\n" #define CFG_REPORTER_STR "Configure a stats reporter\n" @@ -389,6 +390,32 @@ return CMD_SUCCESS; } +DEFUN(cfg_tcp_stats_interval, cfg_tcp_stats_interval_cmd, + "stats-tcp interval <0-65535>", + CFG_STATS_STR "Set the tcp socket stats polling interval\n" + "Interval in seconds (0 disables the polling interval)\n") +{ + int rc; + int interval = atoi(argv[0]); + rc = osmo_stats_tcp_set_interval(interval); + if (rc < 0) { + vty_out(vty, "%% Unable to set interval: %s%s", + strerror(-rc), VTY_NEWLINE); + return CMD_WARNING; + } + + return CMD_SUCCESS; +} + +DEFUN(cfg_tcp_stats_batch_size, cfg_tcp_stats_batch_size_cmd, + "stats-tcp batch-size <1-65535>", + CFG_STATS_STR "Set the number of tcp sockets that are processed per stats polling interval\n" + "Number of sockets per interval\n") +{ + osmo_tcp_stats_config->batch_size = atoi(argv[0]); + return CMD_SUCCESS; +} + DEFUN(show_stats, show_stats_cmd, "show stats", @@ -677,6 +704,10 @@ struct osmo_stats_reporter *srep; vty_out(vty, "stats interval %d%s", osmo_stats_config->interval, VTY_NEWLINE); + if (osmo_tcp_stats_config->interval != TCP_STATS_DEFAULT_INTERVAL) + vty_out(vty, "stats-tcp interval %d%s", osmo_tcp_stats_config->interval, VTY_NEWLINE); + if (osmo_tcp_stats_config->batch_size != TCP_STATS_DEFAULT_BATCH_SIZE) + vty_out(vty, "stats-tcp batch-size %d%s", osmo_tcp_stats_config->batch_size, VTY_NEWLINE); /* Loop through all reporters */ llist_for_each_entry(srep, &osmo_stats_reporter_list, list) @@ -699,6 +730,8 @@ install_lib_element(CONFIG_NODE, &cfg_stats_reporter_log_cmd); install_lib_element(CONFIG_NODE, &cfg_no_stats_reporter_log_cmd); install_lib_element(CONFIG_NODE, &cfg_stats_interval_cmd); + install_lib_element(CONFIG_NODE, &cfg_tcp_stats_interval_cmd); + install_lib_element(CONFIG_NODE, &cfg_tcp_stats_batch_size_cmd); install_node(&cfg_stats_node, config_write_stats); diff --git a/tests/stats/stats_vty_test.vty b/tests/stats/stats_vty_test.vty index 94cc7e8..8732d50 100644 --- a/tests/stats/stats_vty_test.vty +++ b/tests/stats/stats_vty_test.vty @@ -7,6 +7,7 @@ stats reporter log [NAME] no stats reporter log [NAME] stats interval <0-65535> + stats-tcp interval <0-65535> ... stats_vty_test(config)# ### No reporters shall be configured by default -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1416f95aff2adcf13689646b7574845de169fa3d Gerrit-Change-Number: 26454 Gerrit-PatchSet: 19 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:52:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 23 Dec 2021 14:52:28 +0000 Subject: Change in docker-playground[master]: osmo-hnodeb-master: no longer depend on libgtp In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26676 ) Change subject: osmo-hnodeb-master: no longer depend on libgtp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26676 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4e223823d08c7e9e17d87f54d9554429d31c8091 Gerrit-Change-Number: 26676 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 23 Dec 2021 14:52:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:53:47 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 23 Dec 2021 14:53:47 +0000 Subject: Change in osmo-hnodeb[master]: Get rid of libgtp for GTP-U In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26675 ) Change subject: Get rid of libgtp for GTP-U ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I53ad4915aaed3bc7574036e963be10514e370fe2 Gerrit-Change-Number: 26675 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 23 Dec 2021 14:53:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:54:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 23 Dec 2021 14:54:02 +0000 Subject: Change in osmo-hnodeb[master]: Get rid of libgtp for GTP-U In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26675 to look at the new patch set (#2). Change subject: Get rid of libgtp for GTP-U ...................................................................... Get rid of libgtp for GTP-U It doesn't make much sense to pull whole libgtp to implement only the user plan side of GTP. Let's drop it and add a minimal GTP-U implementation here. Related: SYS#5516 Change-Id: I53ad4915aaed3bc7574036e963be10514e370fe2 --- M configure.ac M contrib/jenkins.sh M contrib/osmo-hnodeb.spec.in M debian/control M include/osmocom/hnodeb/gtp.h M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk_gtp.c M src/osmo-hnodeb/rtp.c 11 files changed, 265 insertions(+), 173 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/75/26675/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I53ad4915aaed3bc7574036e963be10514e370fe2 Gerrit-Change-Number: 26675 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 14:55:26 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 23 Dec 2021 14:55:26 +0000 Subject: Change in osmo-hnodeb[master]: Add initial support for IuUP RTP based Transport Layer In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 to look at the new patch set (#2). Change subject: Add initial support for IuUP RTP based Transport Layer ...................................................................... Add initial support for IuUP RTP based Transport Layer Use the recently introduced IuUP support in libosmocore to send and receive proper IuUP over RTP instead of regular RTP. The LLSK AUDIO primitives are updated to provide required information back and forth. Depends: libosmocore.git Change-Id Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 Related: SYS#5516 Change-Id: Ie137809e1f91dfd702853c52be97ca79e8604eab --- M TODO-RELEASE M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/rtp.h M src/osmo-hnodeb/llsk_audio.c M src/osmo-hnodeb/rtp.c 6 files changed, 158 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/71/26671/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ie137809e1f91dfd702853c52be97ca79e8604eab Gerrit-Change-Number: 26671 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 15:23:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 23 Dec 2021 15:23:15 +0000 Subject: Change in osmo-mgw[master]: cosmetic: Rename variable payload=>payload_type References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26678 ) Change subject: cosmetic: Rename variable payload=>payload_type ...................................................................... cosmetic: Rename variable payload=>payload_type Using "payload" there is misleading, the proper naming is payload type, a well known term for RTP. Change-Id: Ifcad63b0ba5068acd555960c71c3ad1489a2b870 --- M src/libosmo-mgcp/mgcp_sdp.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/78/26678/1 diff --git a/src/libosmo-mgcp/mgcp_sdp.c b/src/libosmo-mgcp/mgcp_sdp.c index a36c6d2..98b3099 100644 --- a/src/libosmo-mgcp/mgcp_sdp.c +++ b/src/libosmo-mgcp/mgcp_sdp.c @@ -98,7 +98,7 @@ /* Helper function to update codec map information with additional data from * SDP, called from: mgcp_parse_sdp_data() */ static void codecs_update(void *ctx, struct sdp_rtp_map *codecs, int used, - int payload, const char *audio_name) + int payload_type, const char *audio_name) { int i; @@ -110,7 +110,7 @@ /* Note: We can only update payload codecs that already exist * in our codec list. If we get an unexpected payload type, * we just drop it */ - if (codecs[i].payload_type != payload) + if (codecs[i].payload_type != payload_type) continue; if (sscanf(audio_name, "%63[^/]/%d/%d", @@ -127,7 +127,7 @@ return; } - LOGP(DLMGCP, LOGL_ERROR, "Unconfigured PT(%d) with %s\n", payload, + LOGP(DLMGCP, LOGL_ERROR, "Unconfigured PT(%d) with %s\n", payload_type, audio_name); } @@ -334,7 +334,7 @@ void *tmp_ctx = talloc_new(NULL); struct mgcp_rtp_end *rtp; - int payload; + int payload_type; int ptime, ptime2 = 0; char audio_name[64]; int port, rc; @@ -355,8 +355,8 @@ /* skip these SDP attributes */ break; case 'a': - if (sscanf(line, "a=rtpmap:%d %63s", &payload, audio_name) == 2) { - codecs_update(tmp_ctx, codecs, codecs_used, payload, audio_name); + if (sscanf(line, "a=rtpmap:%d %63s", &payload_type, audio_name) == 2) { + codecs_update(tmp_ctx, codecs, codecs_used, payload_type, audio_name); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifcad63b0ba5068acd555960c71c3ad1489a2b870 Gerrit-Change-Number: 26678 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 15:52:39 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 15:52:39 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: add d9 to upstream_distro func References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26679 ) Change subject: jenkins-common.sh: add d9 to upstream_distro func ...................................................................... jenkins-common.sh: add d9 to upstream_distro func After the default UPSTREAM_DISTRO was changed from debian:stretch to debian:bullseye, the "debian9-repo-install-test" container has gotten built with bullseye instead of stretch. This is the reason for failures of the jenkins job Osmocom-repo-install-debian9 we have seen over the past days. With this patch applied, it runs through again: https://jenkins.osmocom.org/jenkins/job/Osmocom-repo-install-debian9/339/ Change-Id: I98a19184ba936114c03cd5cc4f54a3173cbd9cfe --- M jenkins-common.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/79/26679/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index b74b952..1e9435a 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -42,6 +42,7 @@ osmo-*-centos8) echo "centos:centos8"; ;; centos7-*) echo "centos:centos7" ;; centos8-*) echo "centos:centos8" ;; + debian9-*) echo "debian:stretch" ;; debian10-*) echo "debian:buster" ;; debian11-*) echo "debian:bullseye" ;; debian-stretch-*) echo "debian:stretch" ;; -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I98a19184ba936114c03cd5cc4f54a3173cbd9cfe Gerrit-Change-Number: 26679 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Thu Dec 23 16:40:39 2021 From: noreply at opensuse.org (OBS Notification) Date: Thu, 23 Dec 2021 16:40:39 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c4a6a2ea2da_196b2ab243444600144198@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 11s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 11s] exit ... [ 11s] ### VM INTERACTION START ### [ 14s] [ 6.477419] sysrq: SysRq : Power Off [ 14s] [ 6.479172] reboot: Power down [ 14s] ### VM INTERACTION END ### [ 14s] [ 14s] wildcard2 failed "build libosmocore.spec" at Thu Dec 23 16:40:25 UTC 2021. [ 14s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Dec 23 16:45:49 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 16:45:49 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Set proper CRC Header for ACK Initialization In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26598 ) Change subject: mgcp_network.c: Set proper CRC Header for ACK Initialization ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f Gerrit-Change-Number: 26598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 23 Dec 2021 16:45:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 16:46:10 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 16:46:10 +0000 Subject: Change in osmo-mgw[master]: cosmetic: Rename variable payload=>payload_type In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26678 ) Change subject: cosmetic: Rename variable payload=>payload_type ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifcad63b0ba5068acd555960c71c3ad1489a2b870 Gerrit-Change-Number: 26678 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 23 Dec 2021 16:46:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 17:16:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 23 Dec 2021 17:16:27 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Set proper CRC Header for ACK Initialization In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26598 ) Change subject: mgcp_network.c: Set proper CRC Header for ACK Initialization ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f Gerrit-Change-Number: 26598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 23 Dec 2021 17:16:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 17:16:32 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 23 Dec 2021 17:16:32 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Set proper CRC Header for ACK Initialization In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26598 ) Change subject: mgcp_network.c: Set proper CRC Header for ACK Initialization ...................................................................... mgcp_network.c: Set proper CRC Header for ACK Initialization Discovered while debugging wireshark CRC calculation and implementing new IuUP code in libosmocore. Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 2d275ec..264e263 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1225,6 +1225,7 @@ if (data[0] == 0xe0) { data[0] = 0xe4; data[1] = 0x00; + data[2] = 0x09; /* Patch CRC Header to adapt to new header above */ rtp_state->patched_first_rtp_payload = true; LOGPENDP(endp, DRTP, LOGL_DEBUG, "Patching over first two bytes" -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f Gerrit-Change-Number: 26598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 17:17:02 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 23 Dec 2021 17:17:02 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: add d9 to upstream_distro func In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26679 ) Change subject: jenkins-common.sh: add d9 to upstream_distro func ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I98a19184ba936114c03cd5cc4f54a3173cbd9cfe Gerrit-Change-Number: 26679 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 23 Dec 2021 17:17:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 17:17:35 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 17:17:35 +0000 Subject: Change in docker-playground[master]: osmo-remsim-test-latest: install client-shell References: Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26680 ) Change subject: osmo-remsim-test-latest: install client-shell ...................................................................... osmo-remsim-test-latest: install client-shell Fix for failing ttcn3-remsim-test-latest, in osmo-remsim-client.log: /bin/sh: 1: osmo-remsim-client-shell: not found Change-Id: Ia3041ea6f19ebe53e05117806acf88d3f86d4479 --- M osmo-remsim-latest/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/80/26680/1 diff --git a/osmo-remsim-latest/Dockerfile b/osmo-remsim-latest/Dockerfile index c684cb8..80b8296 100644 --- a/osmo-remsim-latest/Dockerfile +++ b/osmo-remsim-latest/Dockerfile @@ -10,6 +10,7 @@ apt-get update && \ apt-get install -y --no-install-recommends \ osmo-remsim-server \ + osmo-remsim-client-shell \ osmo-remsim-client-st2 \ osmo-remsim-bankd && \ apt-get clean \ @@ -17,6 +18,7 @@ centos*) \ dnf install -y \ osmo-remsim-server \ + osmo-remsim-client-shell \ osmo-remsim-client-st2 \ osmo-remsim-bankd \ ;; \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia3041ea6f19ebe53e05117806acf88d3f86d4479 Gerrit-Change-Number: 26680 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 17:17:55 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 17:17:55 +0000 Subject: Change in docker-playground[master]: osmo-remsim-test-latest: install client-shell In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26680 ) Change subject: osmo-remsim-test-latest: install client-shell ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia3041ea6f19ebe53e05117806acf88d3f86d4479 Gerrit-Change-Number: 26680 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 23 Dec 2021 17:17:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 17:18:05 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 17:18:05 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: add d9 to upstream_distro func In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26679 ) Change subject: jenkins-common.sh: add d9 to upstream_distro func ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I98a19184ba936114c03cd5cc4f54a3173cbd9cfe Gerrit-Change-Number: 26679 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 23 Dec 2021 17:18:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 17:18:10 2021 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 23 Dec 2021 17:18:10 +0000 Subject: Change in docker-playground[master]: jenkins-common.sh: add d9 to upstream_distro func In-Reply-To: References: Message-ID: osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26679 ) Change subject: jenkins-common.sh: add d9 to upstream_distro func ...................................................................... jenkins-common.sh: add d9 to upstream_distro func After the default UPSTREAM_DISTRO was changed from debian:stretch to debian:bullseye, the "debian9-repo-install-test" container has gotten built with bullseye instead of stretch. This is the reason for failures of the jenkins job Osmocom-repo-install-debian9 we have seen over the past days. With this patch applied, it runs through again: https://jenkins.osmocom.org/jenkins/job/Osmocom-repo-install-debian9/339/ Change-Id: I98a19184ba936114c03cd5cc4f54a3173cbd9cfe --- M jenkins-common.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Verified diff --git a/jenkins-common.sh b/jenkins-common.sh index b74b952..1e9435a 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -42,6 +42,7 @@ osmo-*-centos8) echo "centos:centos8"; ;; centos7-*) echo "centos:centos7" ;; centos8-*) echo "centos:centos8" ;; + debian9-*) echo "debian:stretch" ;; debian10-*) echo "debian:buster" ;; debian11-*) echo "debian:bullseye" ;; debian-stretch-*) echo "debian:stretch" ;; -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I98a19184ba936114c03cd5cc4f54a3173cbd9cfe Gerrit-Change-Number: 26679 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 23 17:27:03 2021 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Thu, 23 Dec 2021 17:27:03 +0000 Subject: Change in libosmo-abis[master]: ipaccess.c: register RSL/OML related osmo_fds for monitoring In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 to look at the new patch set (#3). Change subject: ipaccess.c: register RSL/OML related osmo_fds for monitoring ...................................................................... ipaccess.c: register RSL/OML related osmo_fds for monitoring The osmo_fds used for ipaccess based E1 traffic should be registered for monitoring to get tcp_stats for all RSL/OML links. Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e depends: libosmocore I64b288174ae3dd22d50a701ce7cbf9e623246479 Related: SYS#5701 --- M src/input/ipaccess.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/55/26455/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Dec 24 00:32:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 00:32:53 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in CentOS_7/x86_64 In-Reply-To: References: Message-ID: <61c5154282dc2_196b2ab243444600239576@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/CentOS_7/x86_64 Package network:osmocom:nightly/libosmocore failed to build in CentOS_7/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 74s] /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../include -DBUILDING_LIBOSMOCORE -Wall -Wall -pthread -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -std=gnu11 -DBUILDING_LIBOSMOCORE -Wall -c -o sercomm.lo sercomm.c [ 74s] /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../include -DBUILDING_LIBOSMOCORE -Wall -Wall -pthread -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -std=gnu11 -DBUILDING_LIBOSMOCORE -Wall -c -o prbs.lo prbs.c [ 74s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../include -DBUILDING_LIBOSMOCORE -Wall -Wall -pthread -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -std=gnu11 -DBUILDING_LIBOSMOCORE -Wall -c conv_acc_generic.c -fPIC -DPIC -o .libs/conv_acc_generic.o [ 74s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../include -DBUILDING_LIBOSMOCORE -Wall -Wall -pthread -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -std=gnu11 -DBUILDING_LIBOSMOCORE -Wall -c sercomm.c -fPIC -DPIC -o .libs/sercomm.o [ 74s] stats_tcp.c: In function 'fill_stats': [ 74s] stats_tcp.c:138:15: error: 'struct tcp_info' has no member named 'tcpi_notsent_bytes' [ 74s] tcp_info.tcpi_notsent_bytes); [ 74s] ^ [ 74s] libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../include -DBUILDING_LIBOSMOCORE -Wall -Wall -pthread -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -std=gnu11 -DBUILDING_LIBOSMOCORE -Wall -c prbs.c -fPIC -DPIC -o .libs/prbs.o [ 74s] make[3]: *** [stats_tcp.lo] Error 1 [ 74s] make[3]: *** Waiting for unfinished jobs.... [ 74s] make[3]: Leaving directory `/home/abuild/rpmbuild/BUILD/libosmocore-1.6.0.23.b1ef.202112240026/src' [ 74s] make[2]: *** [all] Error 2 [ 74s] make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/libosmocore-1.6.0.23.b1ef.202112240026/src' [ 74s] make[1]: *** [all-recursive] Error 1 [ 74s] make[1]: Leaving directory `/home/abuild/rpmbuild/BUILD/libosmocore-1.6.0.23.b1ef.202112240026' [ 74s] make: *** [all] Error 2 [ 74s] error: Bad exit status from /var/tmp/rpm-tmp.UXN2xj (%build) [ 74s] [ 74s] [ 74s] RPM build errors: [ 74s] Bad exit status from /var/tmp/rpm-tmp.UXN2xj (%build) [ 75s] ### VM INTERACTION START ### [ 76s] Powering off. [ 76s] [ 65.140184] reboot: Power down [ 76s] ### VM INTERACTION END ### [ 76s] [ 76s] sheep87 failed "build libosmocore.spec" at Fri Dec 24 00:32:41 UTC 2021. [ 76s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:04:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:04:06 +0000 Subject: Build failure of network:osmocom:latest/libosmo-abis in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c51c89240bb_196b2ab2434446002466d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-abis/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/libosmo-abis failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-abis Last lines of build log: [ 23s] [166/183] cumulate hostname-3.16-lp151.2.3 [ 23s] [167/183] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 23s] [168/183] cumulate pam-1.3.0-lp151.7.2 [ 23s] [169/183] cumulate python3-base-3.6.5-lp151.4.2 [ 23s] [170/183] cumulate gcc-PIE-7-lp151.3.2 [ 23s] [171/183] cumulate shadow-4.6-lp151.1.2 [ 23s] [172/183] cumulate cmake-3.10.2-lp151.4.2 [ 23s] [173/183] cumulate sysuser-shadow-2.0-lp151.3.3 [ 23s] [174/183] cumulate bctoolbox-devel-0.6.0-lp151.2.3 [ 23s] [175/183] cumulate system-group-hardware-20170617-lp151.4.3 [ 23s] [176/183] cumulate ortp-devel-1.0.2-lp151.2.3 [ 23s] [177/183] cumulate libutempter0-1.1.6-lp151.4.3 [ 23s] [178/183] cumulate util-linux-2.33.1-lp151.2.2 [ 23s] [179/183] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 23s] [180/183] cumulate systemd-234-lp151.25.2 [ 23s] [181/183] cumulate rpm-build-4.14.1-lp151.13.2 [ 23s] [182/183] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 23s] [183/183] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 23s] now installing cumulated packages [ 23s] Preparing... ######################################## [ 23s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 23s] exit ... [ 23s] ### VM INTERACTION START ### [ 27s] [ 8.648667] sysrq: SysRq : Power Off [ 27s] [ 8.649378] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] obs-arm-11 failed "build libosmo-abis.spec" at Fri Dec 24 01:03:49 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:06:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:06:05 +0000 Subject: Build failure of network:osmocom:latest/libosmo-abis in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c51d024d390_196b2ab2434446002472c8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-abis/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/libosmo-abis failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-abis Last lines of build log: [ 21s] [170/186] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 21s] [171/186] cumulate pam-1.3.0-lp151.7.38 [ 21s] [172/186] cumulate python3-base-3.6.5-lp151.5.2 [ 21s] [173/186] cumulate gcc-PIE-7-lp151.3.5 [ 21s] [174/186] cumulate shadow-4.6-lp151.1.27 [ 21s] [175/186] cumulate cmake-3.10.2-lp151.4.1 [ 21s] [176/186] cumulate sysuser-shadow-2.0-lp151.3.70 [ 21s] [177/186] cumulate bctoolbox-devel-0.6.0-lp151.2.3 [ 21s] [178/186] cumulate system-group-hardware-20170617-lp151.4.70 [ 21s] [179/186] cumulate ortp-devel-1.0.2-lp151.2.3 [ 21s] [180/186] cumulate libutempter0-1.1.6-lp151.4.70 [ 21s] [181/186] cumulate util-linux-2.33.1-lp151.2.23 [ 21s] [182/186] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 21s] [183/186] cumulate systemd-234-lp151.25.7 [ 21s] [18[ 7.086562] serial8250: too much work for irq4 [ 21s] 4/186] cumulate rpm-build-4.14.1-lp151.13.10 [ 21s] [185/186] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 21s] [186/186] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 21s] now installing cumulated packages [ 21s] Preparing... ######################################## [ 21s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 22s] exit ... [ 22s] ### VM INTERACTION START ### [ 25s] [ 10.571425] sysrq: SysRq : Power Off [ 25s] [ 10.603077] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb61 failed "build libosmo-abis.spec" at Fri Dec 24 01:05:58 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:06:05 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:06:05 +0000 Subject: Build failure of network:osmocom:latest/libosmo-netif in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c51d02dfa1b_196b2ab2434446002473bb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-netif/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/libosmo-netif failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-netif Last lines of build log: [ 19s] [141/158] cumulate libtool-2.4.6-lp151.2.3 [ 19s] [142/158] cumulate build-compare-20171204T112209.f06fbac-lp151.2.3 [ 19s] [143/158] cumulate gcc7-7.4.0+r266845-lp151.1.3 [ 19s] [144/158] cumulate gcc-7-lp151.3.2 [ 19s] [145/158] cumulate hostname-3.16-lp151.2.3 [ 19s] [146/158] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 19s] [147/158] cumulate pam-1.3.0-lp151.7.2 [ 19s] [148/158] cumulate gcc-PIE-7-lp151.3.2 [ 19s] [149/158] cumulate shadow-4.6-lp151.1.2 [ 19s] [150/158] cumulate sysuser-shadow-2.0-lp151.3.3 [ 19s] [151/158] cumulate system-group-hardware-20170617-lp151.4.3 [ 19s] [152/158] cumulate libutempter0-1.1.6-lp151.4.3 [ 19s] [153/158] cumulate util-linux-2.33.1-lp151.2.2 [ 19s] [154/158] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 19s] [155/158] cumulate systemd-234-lp151.25.2 [ 19s] [156/158] cumulate rpm-build-4.14.1-lp151.13.2 [ 19s] [157/158] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 19s] [158/158] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 19s] now installing cumulated packages [ 19s] Preparing... ######################################## [ 19s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 19s] exit ... [ 19s] ### VM INTERACTION START ### [ 22s] [ 8.821231] sysrq: SysRq : Power Off [ 22s] [ 8.821828] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] obs-arm-11 failed "build libosmo-netif.spec" at Fri Dec 24 01:06:04 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:05:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:05:48 +0000 Subject: Build failure of network:osmocom:latest/libosmo-abis in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c51d01d8181_196b2ab24344460024712a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-abis/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/libosmo-abis failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-abis Last lines of build log: [ 16s] [168/185] cumulate libosmogsm-devel-1.6.0-lp152.1.1 [ 16s] [169/185] cumulate pam-1.3.0-lp152.10.25 [ 16s] [170/185] cumulate python3-base-3.6.10-lp152.3.7 [ 16s] [171/185] cumulate gcc-PIE-7-lp152.4.114 [ 16s] [172/185] cumulate shadow-4.6-lp152.3.80 [ 16s] [173/185] cumulate cmake-mini-3.17.0-lp152.1.2 [ 16s] [174/185] cumulate cmake-3.17.0-lp152.1.1 [ 16s] [175/185] cumulate sysuser-shadow-2.0-lp152.4.114 [ 16s] [176/185] cumulate system-group-hardware-20170617-lp152.5.114 [ 16s] [177/185] cumulate bctoolbox-devel-0.6.0-lp152.3.8 [ 16s] [178/185] cumulate libutempter0-1.1.6-lp152.5.114 [ 16s] [179/185] cumulate ortp-devel-1.0.2-lp152.3.8 [ 16s] [180/185] cumulate util-linux-2.33.1-lp152.4.78 [ 16s] [181/185] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 16s] [182/185] cumulate systemd-234-lp152.30.1 [ 16s] [183/185] cumulate rpm-build-4.14.1-lp152.17.5 [ 16s] [184/185] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 16s] [185/185] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 16s] now installing cumulated packages [ 16s] Preparing... ######################################## [ 16s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 16s] exit ... [ 16s] ### VM INTERACTION START ### [ 19s] [ 8.854193] sysrq: Power Off [ 19s] [ 8.858209] reboot: Power down [ 19s] ### VM INTERACTION END ### [ 19s] [ 19s] old-cirrus1 failed "build libosmo-abis.spec" at Fri Dec 24 01:05:45 UTC 2021. [ 19s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:07:30 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:07:30 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c51d5ba1834_196b2ab243444600247581@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/libosmo-sccp failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 29s] [145/162] cumulate gcc7-7.4.0+r266845-lp151.1.3 [ 29s] [146/162] cumulate gcc-7-lp151.3.2 [ 29s] [147/162] cumulate hostname-3.16-lp151.2.3 [ 29s] [148/162] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 29s] [149/162] cumulate libosmonetif8-1.1.0-lp151.2.2 [ 29s] [150/162] cumulate pam-1.3.0-lp151.7.2 [ 29s] [151/162] cumulate gcc-PIE-7-lp151.3.2 [ 29s] [152/162] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 29s] [153/162] cumulate shadow-4.6-lp151.1.2 [ 29s] [154/162] cumulate sysuser-shadow-2.0-lp151.3.3 [ 29s] [155/162] cumulate system-group-hardware-20170617-lp151.4.3 [ 29s] [156/162] cumulate libutempter0-1.1.6-lp151.4.3 [ 29s] [157/162] cumulate util-linux-2.33.1-lp151.2.2 [ 29s] [158/162] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 29s] [159/162] cumulate systemd-234-lp151.25.2 [ 29s] [160/162] cumulate rpm-build-4.14.1-lp151.13.2 [ 29s] [161/162] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 29s] [162/162] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 29s] now installing cumulated packages [ 29s] Preparing... ######################################## [ 29s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 29s] exit ... [ 29s] ### VM INTERACTION START ### [ 32s] [ 11.204398] sysrq: SysRq : Power Off [ 32s] [ 11.206211] reboot: Power down [ 32s] ### VM INTERACTION END ### [ 32s] [ 32s] armbuild02 failed "build libosmo-sccp.spec" at Fri Dec 24 01:07:28 UTC 2021. [ 32s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:08:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:08:04 +0000 Subject: Build failure of network:osmocom:latest/libosmo-netif in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c51d76dea57_196b2ab2434446002477c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-netif/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/libosmo-netif failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-netif Last lines of build log: [ 16s] [144/161] cumulate libtool-2.4.6-lp151.2.68 [ 16s] [145/161] cumulate build-compare-20171204T112209.f06fbac-lp151.2.38 [ 16s] [146/161] cumulate gcc7-7.4.0+r266845-lp151.1.35 [ 16s] [147/161] cumulate gcc-7-lp151.3.5 [ 16s] [148/161] cumulate hostname-3.16-lp151.2.3 [ 16s] [149/161] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 16s] [150/161] cumulate pam-1.3.0-lp151.7.38 [ 16s] [151/161] cumulate gcc-PIE-7-lp151.3.5 [ 16s] [152/161] cumulate shadow-4.6-lp151.1.27 [ 16s] [153/161] cumulate sysuser-shadow-2.0-lp151.3.70 [ 16s] [154/161] cumulate system-group-hardware-20170617-lp151.4.70 [ 16s] [155/161] cumulate libutempter0-1.1.6-lp151.4.70 [ 16s] [156/161] cumulate util-linux-2.33.1-lp151.2.23 [ 16s] [157/161] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 16s] [158/161] cumulate systemd-234-lp151.25.7 [ 16s] [159/161] cumulate rpm-build-4.14.1-lp151.13.10 [ 16s] [160/161] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 16s] [161/161] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 16s] now installing cumulated packages [ 16s] Preparing... ######################################## [ 16s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 17s] exit ... [ 17s] ### VM INTERACTION START ### [ 20s] [ 8.151761] sysrq: SysRq : Power Off [ 20s] [ 8.174389] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] lamb24 failed "build libosmo-netif.spec" at Fri Dec 24 01:07:54 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:08:04 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:08:04 +0000 Subject: Build failure of network:osmocom:latest/libosmo-netif in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c51d7789e0c_196b2ab24344460024787e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-netif/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/libosmo-netif failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-netif Last lines of build log: [ 25s] [145/162] cumulate libtool-2.4.6-lp152.3.101 [ 25s] [146/162] cumulate build-compare-20200529T185052.7a95d20-lp152.1.4 [ 25s] [147/162] cumulate gcc7-7.5.0+r278197-lp152.2.46 [ 25s] [148/162] cumulate gcc-7-lp152.4.114 [ 25s] [149/162] cumulate hostname-3.16-lp152.3.5 [ 25s] [150/162] cumulate libosmogsm-devel-1.6.0-lp152.1.1 [ 25s] [151/162] cumulate pam-1.3.0-lp152.10.25 [ 25s] [152/162] cumulate gcc-PIE-7-lp152.4.114 [ 25s] [153/162] cumulate shadow-4.6-lp152.3.80 [ 25s] [154/162] cumulate sysuser-shadow-2.0-lp152.4.114 [ 25s] [155/162] cumulate system-group-hardware-20170617-lp152.5.114 [ 25s] [156/162] cumulate libutempter0-1.1.6-lp152.5.114 [ 25s] [157/162] cumulate util-linux-2.33.1-lp152.4.78 [ 25s] [158/162] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 25s] [159/162] cumulate systemd-234-lp152.30.1 [ 25s] [160/162] cumulate rpm-build-4.14.1-lp152.17.5 [ 25s] [161/162] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 25s] [162/162] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 25s] now installing cumulated packages [ 25s] Preparing... ######################################## [ 26s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 26s] exit ... [ 26s] ### VM INTERACTION START ### [ 29s] [ 12.479387] sysrq: Power Off [ 29s] [ 12.499324] reboot: Power down [ 29s] ### VM INTERACTION END ### [ 29s] [ 29s] cloud107 failed "build libosmo-netif.spec" at Fri Dec 24 01:07:59 UTC 2021. [ 29s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:08:21 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:08:21 +0000 Subject: Build failure of network:osmocom:latest/libosmo-abis in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c51d973483c_196b2ab2434446002481e0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-abis/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/libosmo-abis failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest libosmo-abis Last lines of build log: [ 24s] [164/181] cumulate hostname-3.16-lp151.2.3 [ 24s] [165/181] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 24s] [166/181] cumulate pam-1.3.0-lp151.7.2 [ 24s] [167/181] cumulate python3-base-3.6.5-lp151.5.1 [ 24s] [168/181] cumulate gcc-PIE-7-lp151.3.2 [ 24s] [169/181] cumulate shadow-4.6-lp151.1.2 [ 24s] [170/181] cumulate cmake-3.10.2-lp151.4.2 [ 24s] [171/181] cumulate sysuser-shadow-2.0-lp151.3.3 [ 24s] [172/181] cumulate bctoolbox-devel-0.6.0-lp151.2.3 [ 24s] [173/181] cumulate system-group-hardware-20170617-lp151.4.3 [ 24s] [174/181] cumulate ortp-devel-1.0.2-lp151.2.3 [ 24s] [175/181] cumulate libutempter0-1.1.6-lp151.4.3 [ 24s] [176/181] cumulate util-linux-2.33.1-lp151.2.2 [ 24s] [177/181] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 24s] [178/181] cumulate systemd-234-lp151.25.2 [ 24s] [179/181] cumulate rpm-build-4.14.1-lp151.13.2 [ 24s] [180/181] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 24s] [181/181] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 24s] now installing cumulated packages [ 24s] Preparing... ######################################## [ 24s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 24s] exit ... [ 24s] ### VM INTERACTION START ### [ 27s] [ 10.510929] sysrq: SysRq : Power Off [ 27s] [ 10.512232] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] armbuild02 failed "build libosmo-abis.spec" at Fri Dec 24 01:08:09 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:09:29 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:09:29 +0000 Subject: Build failure of network:osmocom:latest/libasn1c in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c51dd239789_196b2ab2434446002483e0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/libasn1c failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libasn1c Last lines of build log: [ 16s] [133/150] cumulate zlib-devel-1.2.11-lp152.7.8 [ 16s] [134/150] cumulate libtool-2.4.6-lp152.3.101 [ 16s] [135/150] cumulate build-compare-20200529T185052.7a95d20-lp152.1.4 [ 16s] [136/150] cumulate gcc7-7.5.0+r278197-lp152.2.46 [ 16s] [137/150] cumulate gcc-7-lp152.4.114 [ 16s] [138/150] cumulate hostname-3.16-lp152.3.5 [ 16s] [139/150] cumulate pam-1.3.0-lp152.10.25 [ 16s] [140/150] cumulate gcc-PIE-7-lp152.4.114 [ 16s] [141/150] cumulate shadow-4.6-lp152.3.80 [ 16s] [142/150] cumulate sysuser-shadow-2.0-lp152.4.114 [ 16s] [143/150] cumulate system-group-hardware-20170617-lp152.5.114 [ 16s] [144/150] cumulate libutempter0-1.1.6-lp152.5.114 [ 16s] [145/150] cumulate util-linux-2.33.1-lp152.4.78 [ 16s] [146/150] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 16s] [147/150] cumulate systemd-234-lp152.30.1 [ 16s] [148/150] cumulate rpm-build-4.14.1-lp152.17.5 [ 16s] [149/150] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 16s] [150/150] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 16s] now installing cumulated packages [ 16s] Preparing... ######################################## [ 17s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 17s] exit ... [ 17s] ### VM INTERACTION START ### [ 20s] [ 9.556858] sysrq: Power Off [ 20s] [ 9.591512] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] lamb25 failed "build libasn1c.spec" at Fri Dec 24 01:09:22 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:10:37 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:10:37 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c51e1152713_196b2ab2434446002487e9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 64s] [148/165] cumulate gcc7-7.4.0+r266845-lp151.1.35 [ 64s] [149/165] cumulate gcc-7-lp151.3.5 [ 64s] [150/165] cumulate hostname-3.16-lp151.2.3 [ 64s] [151/165] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 64s] [152/165] cumulate libosmonetif8-1.1.0-lp151.2.2 [ 64s] [153/165] cumulate pam-1.3.0-lp151.7.38 [ 64s] [154/165] cumulate gcc-PIE-7-lp151.3.5 [ 64s] [155/165] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 64s] [156/165] cumulate shadow-4.6-lp151.1.27 [ 64s] [157/165] cumulate sysuser-shadow-2.0-lp151.3.70 [ 64s] [158/165] cumulate system-group-hardware-20170617-lp151.4.70 [ 64s] [159/165] cumulate libutempter0-1.1.6-lp151.4.70 [ 64s] [160/165] cumulate util-linux-2.33.1-lp151.2.23 [ 64s] [161/165] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 64s] [162/165] cumulate systemd-234-lp151.25.7 [ 64s] [163/165] cumulate rpm-build-4.14.1-lp151.13.10 [ 64s] [164/165] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 64s] [165/165] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 64s] now installing cumulated packages [ 64s] Preparing... ######################################## [ 64s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 65s] exit ... [ 65s] ### VM INTERACTION START ### [ 68s] [ 14.024675] sysrq: SysRq : Power Off [ 68s] [ 14.078364] reboot: Power down [ 68s] ### VM INTERACTION END ### [ 68s] [ 68s] lamb27 failed "build libosmo-sccp.spec" at Fri Dec 24 01:10:21 UTC 2021. [ 68s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:11:11 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:11:11 +0000 Subject: Build failure of network:osmocom:latest/libasn1c in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c51e4b7900e_196b2ab243444600249143@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/libasn1c failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libasn1c Last lines of build log: [ 37s] [129/146] cumulate zlib-devel-1.2.11-lp151.4.1 [ 37s] [130/146] cumulate libtool-2.4.6-lp151.2.3 [ 37s] [131/146] cumulate build-compare-20171204T112209.f06fbac-lp151.2.3 [ 37s] [132/146] cumulate gcc7-7.4.0+r266845-lp151.1.3 [ 37s] [133/146] cumulate gcc-7-lp151.3.2 [ 37s] [134/146] cumulate hostname-3.16-lp151.2.3 [ 37s] [135/146] cumulate pam-1.3.0-lp151.7.2 [ 37s] [136/146] cumulate gcc-PIE-7-lp151.3.2 [ 37s] [137/146] cumulate shadow-4.6-lp151.1.2 [ 37s] [138/146] cumulate sysuser-shadow-2.0-lp151.3.3 [ 37s] [139/146] cumulate system-group-hardware-20170617-lp151.4.3 [ 37s] [140/146] cumulate libutempter0-1.1.6-lp151.4.3 [ 37s] [141/146] cumulate util-linux-2.33.1-lp151.2.2 [ 37s] [142/146] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 37s] [143/146] cumulate systemd-234-lp151.25.2 [ 37s] [144/146] cumulate rpm-build-4.14.1-lp151.13.2 [ 37s] [145/146] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 37s] [146/146] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 37s] now installing cumulated packages [ 37s] Preparing... ######################################## [ 37s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 37s] exit ... [ 37s] ### VM INTERACTION START ### [ 40s] [ 8.773807] sysrq: SysRq : Power Off [ 40s] [ 8.774754] reboot: Power down [ 41s] ### VM INTERACTION END ### [ 41s] [ 41s] obs-arm-11 failed "build libasn1c.spec" at Fri Dec 24 01:11:00 UTC 2021. [ 41s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:11:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:11:28 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c51e4c94381_196b2ab2434446002492c2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 16s] [149/166] cumulate gcc7-7.5.0+r278197-lp152.2.46 [ 16s] [150/166] cumulate gcc-7-lp152.4.114 [ 16s] [151/166] cumulate hostname-3.16-lp152.3.5 [ 16s] [152/166] cumulate libosmogsm-devel-1.6.0-lp152.1.1 [ 16s] [153/166] cumulate libosmonetif8-1.1.0-lp152.2.2 [ 16s] [154/166] cumulate pam-1.3.0-lp152.10.25 [ 16s] [155/166] cumulate gcc-PIE-7-lp152.4.114 [ 16s] [156/166] cumulate libosmonetif-devel-1.1.0-lp152.2.2 [ 16s] [157/166] cumulate shadow-4.6-lp152.3.80 [ 16s] [158/166] cumulate sysuser-shadow-2.0-lp152.4.114 [ 16s] [159/166] cumulate system-group-hardware-20170617-lp152.5.114 [ 16s] [160/166] cumulate libutempter0-1.1.6-lp152.5.114 [ 16s] [161/166] cumulate util-linux-2.33.1-lp152.4.78 [ 16s] [162/166] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 16s] [163/166] cumulate systemd-234-lp152.30.1 [ 16s] [164/166] cumulate rpm-build-4.14.1-lp152.17.5 [ 16s] [165/166] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 16s] [166/166] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 16s] now installing cumulated packages [ 16s] Preparing... ######################################## [ 16s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 16s] exit ... [ 16s] ### VM INTERACTION START ### [ 19s] [ 9.025842] sysrq: Power Off [ 19s] [ 9.029465] reboot: Power down [ 19s] ### VM INTERACTION END ### [ 19s] [ 19s] lamb12 failed "build libosmo-sccp.spec" at Fri Dec 24 01:11:23 UTC 2021. [ 19s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:11:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:11:28 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c51e4d3ccbd_196b2ab24344460024935f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 16s] [157/174] cumulate libosmoabis10-1.2.0-lp152.1.1 [ 16s] [158/174] cumulate libosmoctrl0-1.6.0-lp152.1.1 [ 16s] [159/174] cumulate pam-1.3.0-lp152.10.25 [ 16s] [160/174] cumulate python3-base-3.6.10-lp152.3.7 [ 16s] [161/174] cumulate gcc-PIE-7-lp152.4.114 [ 16s] [162/174] cumulate libosmoabis-devel-1.2.0-lp152.1.1 [ 16s] [163/174] cumulate libosmoctrl-devel-1.6.0-lp152.1.1 [ 16s] [164/174] cumulate python3-3.6.10-lp152.3.44 [ 16s] [165/174] cumulate shadow-4.6-lp152.3.80 [ 16s] [166/174] cumulate sysuser-shadow-2.0-lp152.4.114 [ 16s] [167/174] cumulate system-group-hardware-20170617-lp152.5.114 [ 16s] [168/174] cumulate libutempter0-1.1.6-lp152.5.114 [ 16s] [169/174] cumulate util-linux-2.33.1-lp152.4.78 [ 16s] [170/174] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 16s] [171/174] cumulate systemd-234-lp152.30.1 [ 16s] [172/174] cumulate rpm-build-4.14.1-lp152.17.5 [ 16s] [173/174] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 16s] [174/174] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 16s] now installing cumulated packages [ 16s] Preparing... ######################################## [ 16s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 16s] exit ... [ 16s] ### VM INTERACTION START ### [ 19s] [ 9.554757] sysrq: Power Off [ 19s] [ 9.558421] reboot: Power down [ 19s] ### VM INTERACTION END ### [ 19s] [ 19s] lamb18 failed "build osmo-hlr.spec" at Fri Dec 24 01:11:26 UTC 2021. [ 19s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:11:28 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:11:28 +0000 Subject: Build failure of network:osmocom:latest/libasn1c in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c51e4d9c74d_196b2ab2434446002494e1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/libasn1c failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libasn1c Last lines of build log: [ 14s] [132/149] cumulate zlib-devel-1.2.11-lp151.4.1 [ 14s] [133/149] cumulate libtool-2.4.6-lp151.2.68 [ 14s] [134/149] cumulate build-compare-20171204T112209.f06fbac-lp151.2.38 [ 14s] [135/149] cumulate gcc7-7.4.0+r266845-lp151.1.35 [ 14s] [136/149] cumulate gcc-7-lp151.3.5 [ 14s] [137/149] cumulate hostname-3.16-lp151.2.3 [ 14s] [138/149] cumulate pam-1.3.0-lp151.7.38 [ 14s] [139/149] cumulate gcc-PIE-7-lp151.3.5 [ 14s] [140/149] cumulate shadow-4.6-lp151.1.27 [ 14s] [141/149] cumulate sysuser-shadow-2.0-lp151.3.70 [ 14s] [142/149] cumulate system-group-hardware-20170617-lp151.4.70 [ 14s] [143/149] cumulate libutempter0-1.1.6-lp151.4.70 [ 14s] [144/149] cumulate util-linux-2.33.1-lp151.2.23 [ 14s] [145/149] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 14s] [146/149] cumulate systemd-234-lp151.25.7 [ 14s] [147/149] cumulate rpm-build-4.14.1-lp151.13.10 [ 14s] [148/149] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 14s] [149/149] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 14s] now installing cumulated packages [ 14s] Preparing... ######################################## [ 14s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 14s] exit ... [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.343989] sysrq: SysRq : Power Off [ 17s] [ 7.349809] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] cloud114 failed "build libasn1c.spec" at Fri Dec 24 01:11:19 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:11:45 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:11:45 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c51e674ff73_196b2ab243444600249563@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 26s] [157/173] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 26s] [158/173] cumulate pam-1.3.0-lp151.7.38 [ 26s] [159/173] cumulate python3-base-3.6.5-lp151.5.2 [ 26s] [160/173] cumulate gcc-PIE-7-lp151.3.5 [ 26s] [161/173] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 26s] [162/173] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 26s] [163/173] cumulate python3-3.6.5-lp151.5.1 [ 26s] [164/173] cumulate shadow-4.6-lp151.1.27 [ 26s] [165/173] cumulate sysuser-shadow-2.0-lp151.3.70 [ 26s] [166/173] cumulate system-group-hardware-20170617-lp151.4.70 [ 26s] [167/173] cumulate libutempter0-1.1.6-lp151.4.70 [ 26s] [168/173] cumulate util-linux-2.33.1-lp151.2.23 [ 26s] [169/173] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 26s] [170/173] cumulate systemd-234-lp151.25.7 [ 26s] [171/173] cumulate rpm-build-4.14.1-lp151.13.10 [ 26s] [172/173] cumulate[ 6.069950] serial8250: too much work for irq4 [ 26s] aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 26s] [173/173] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 26s] now installing cumulated packages [ 27s] Preparing... ######################################## [ 27s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 27s] exit ... [ 27s] ### VM INTERACTION START ### [ 30s] [ 9.925634] sysrq: SysRq : Power Off [ 30s] [ 9.945111] reboot: Power down [ 30s] ### VM INTERACTION END ### [ 30s] [ 30s] lamb01 failed "build osmo-hlr.spec" at Fri Dec 24 01:11:39 UTC 2021. [ 30s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:13:44 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:13:44 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c51edf4dd1c_196b2ab243444600249938@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 13s] [163/179] cumulate gcc-PIE-7-lp151.3.5 [ 13s] [164/179] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 13s] [165/179] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 13s] [166/179] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 13s] [167/179] cumulate python3-3.6.5-lp151.5.1 [ 13s] [168/179] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 13s] [169/179] cumulate shadow-4.6-lp151.1.27 [ 13s] [170/179] cumulate sysuser-shadow-2.0-lp151.3.70 [ 13s] [171/179] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 13s] [172/179] cumulate system-group-hardware-20170617-lp151.4[ 3.920445] serial8250: too much work for irq4 [ 13s] .70 [ 13s] [173/179] cumulate libutempter0-1.1.6-lp151.4.70 [ 13s] [174/179] cumulate util-linux-2.33.1-lp151.2.23 [ 13s] [175/179] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 13s] [176/179] cumulate systemd-234-lp151.25.7 [ 13s] [177/179] cumulate rpm-build-4.14.1-lp151.13.10 [ 13s] [178/179] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 13s] [179/179] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 13s] now installing cumulated packages [ 13s] Preparing... ######################################## [ 13s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 13s] exit ... [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.381949] sysrq: SysRq : Power Off [ 16s] [ 7.384326] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] build74 failed "build osmo-iuh.spec" at Fri Dec 24 01:13:36 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:14:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:14:18 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c51eff6fae3_196b2ab243444600250118@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-iuh failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 18s] [159/176] cumulate python3-base-3.6.5-lp151.4.2 [ 18s] [160/176] cumulate gcc-PIE-7-lp151.3.2 [ 18s] [161/176] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 18s] [162/176] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 18s] [163/176] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 18s] [164/176] cumulate python3-3.6.5-lp151.5.1 [ 18s] [165/176] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 18s] [166/176] cumulate shadow-4.6-lp151.1.2 [ 18s] [167/176] cumulate sysuser-shadow-2.0-lp151.3.3 [ 18s] [168/176] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 18s] [169/176] cumulate system-group-hardware-20170617-lp151.4.3 [ 18s] [170/176] cumulate libutempter0-1.1.6-lp151.4.3 [ 18s] [171/176] cumulate util-linux-2.33.1-lp151.2.2 [ 18s] [172/176] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 18s] [173/176] cumulate systemd-234-lp151.25.2 [ 18s] [174/176] cumulate rpm-build-4.14.1-lp151.13.2 [ 18s] [175/176] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 18s] [176/176] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 18s] now installing cumulated packages [ 18s] Preparing... ######################################## [ 18s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 18s] exit ... [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.886090] sysrq: SysRq : Power Off [ 21s] [ 8.889416] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] obs-arm-10 failed "build osmo-iuh.spec" at Fri Dec 24 01:14:10 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:14:53 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:14:53 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c51f1ad01cc_196b2ab2434446002502fd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 72s] [163/180] cumulate python3-base-3.6.10-lp152.3.7 [ 72s] [164/180] cumulate gcc-PIE-7-lp152.4.114 [ 72s] [165/180] cumulate libosmonetif-devel-1.1.0-lp152.2.2 [ 72s] [166/180] cumulate libosmoctrl-devel-1.6.0-lp152.1.1 [ 72s] [167/180] cumulate libosmogb-devel-1.6.0-lp152.1.1 [ 72s] [168/180] cumulate python3-3.6.10-lp152.3.44 [ 72s] [169/180] cumulate libosmo-sigtran7-1.5.0-lp152.1.1 [ 72s] [170/180] cumulate shadow-4.6-lp152.3.80 [ 72s] [171/180] cumulate sysuser-shadow-2.0-lp152.4.114 [ 72s] [172/180] cumulate libosmo-sigtran-devel-1.5.0-lp152.1.1 [ 72s] [173/180] cumulate system-group-hardware-20170617-lp152.5.114 [ 72s] [174/180] cumulate libutempter0-1.1.6-lp152.5.114 [ 72s] [175/180] cumulate util-linux-2.33.1-lp152.4.78 [ 72s] [176/180] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 72s] [177/180] cumulate systemd-234-lp152.30.1 [ 72s] [178/180] cumulate rpm-build-4.14.1-lp152.17.5 [ 72s] [179/180] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 72s] [180/180] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 72s] now installing cumulated packages [ 72s] Preparing... ######################################## [ 72s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 73s] exit ... [ 73s] ### VM INTERACTION START ### [ 76s] [ 15.320494] sysrq: Power Off [ 76s] [ 15.341482] reboot: Power down [ 76s] ### VM INTERACTION END ### [ 76s] [ 76s] cloud108 failed "build osmo-iuh.spec" at Fri Dec 24 01:14:41 UTC 2021. [ 76s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:16:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:16:18 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c51f784d3a6_196b2ab243444600250461@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 53s] [162/179] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 53s] [163/179] cumulate libosmonetif8-1.1.0-lp151.2.2 [ 53s] [164/179] cumulate pam-1.3.0-lp151.7.38 [ 53s] [165/179] cumulate gcc-PIE-7-lp151.3.5 [ 53s] [166/179] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 53s] [167/179] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 53s] [168/179] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 53s] [169/179] cumulate libosmocoding-devel-1.6.0-lp151.1.1 [ 53s] [170/179] cumulate shadow-4.6-lp151.1.27 [ 53s] [171/179] cumulate sysuser-shadow-2.0-lp151.3.70 [ 53s] [172/179] cumulate system-group-hardware-20170617-lp151.4.70 [ 53s] [173/179] cumulate libutempter0-1.1.6-lp151.4.70 [ 53s] [174/179] cumulate util-linux-2.33.1-lp151.2.23 [ 53s] [175/179] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 53s] [176/179] cumulate systemd-234-lp151.25.7 [ 53s] [177/179] cumulate rpm-build-4.14.1-lp151.13.10 [ 53s] [178/179] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 53s] [179/179] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 53s] now installing cumulated packages [ 53s] Preparing... ######################################## [ 53s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 53s] exit ... [ 53s] ### VM INTERACTION START ### [ 56s] [ 15.393256] sysrq: SysRq : Power Off [ 56s] [ 15.409872] reboot: Power down [ 57s] ### VM INTERACTION END ### [ 57s] [ 57s] old-atreju5 failed "build osmo-mgw.spec" at Fri Dec 24 01:16:04 UTC 2021. [ 57s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:16:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:16:18 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c51f7892860_196b2ab243444600250539@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-hlr failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 67s] [153/170] cumulate libosmoabis10-1.2.0-lp151.1.1 [ 67s] [154/170] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 67s] [155/170] cumulate pam-1.3.0-lp151.7.2 [ 67s] [156/170] cumulate python3-base-3.6.5-lp151.4.2 [ 67s] [157/170] cumulate gcc-PIE-7-lp151.3.2 [ 67s] [158/170] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 67s] [159/170] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 67s] [160/170] cumulate python3-3.6.5-lp151.5.1 [ 67s] [161/170] cumulate shadow-4.6-lp151.1.2 [ 67s] [162/170] cumulate sysuser-shadow-2.0-lp151.3.3 [ 67s] [163/170] cumulate system-group-hardware-20170617-lp151.4.3 [ 67s] [164/170] cumulate libutempter0-1.1.6-lp151.4.3 [ 67s] [165/170] cumulate util-linux-2.33.1-lp151.2.2 [ 67s] [166/170] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 67s] [167/170] cumulate systemd-234-lp151.25.2 [ 67s] [168/170] cumulate rpm-build-4.14.1-lp151.13.2 [ 67s] [169/170] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 67s] [170/170] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 67s] now installing cumulated packages [ 67s] Preparing... ######################################## [ 67s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 68s] exit ... [ 68s] ### VM INTERACTION START ### [ 71s] [ 22.021060] sysrq: SysRq : Power Off [ 71s] [ 22.034225] reboot: Power down [ 72s] ### VM INTERACTION END ### [ 72s] [ 72s] obs-arm-3 failed "build osmo-hlr.spec" at Fri Dec 24 01:16:08 UTC 2021. [ 72s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:18:18 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:18:18 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c51fefdc52b_196b2ab2434446002506b1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 17s] [163/180] cumulate libosmoctrl0-1.6.0-lp152.1.1 [ 17s] [164/180] cumulate libosmonetif8-1.1.0-lp152.2.2 [ 17s] [165/180] cumulate pam-1.3.0-lp152.10.25 [ 17s] [166/180] cumulate gcc-PIE-7-lp152.4.114 [ 17s] [167/180] cumulate libosmonetif-devel-1.1.0-lp152.2.2 [ 17s] [168/180] cumulate libosmoabis-devel-1.2.0-lp152.1.1 [ 17s] [169/180] cumulate libosmoctrl-devel-1.6.0-lp152.1.1 [ 17s] [170/180] cumulate libosmocoding-devel-1.6.0-lp152.1.1 [ 17s] [171/180] cumulate shadow-4.6-lp152.3.80 [ 17s] [172/180] cumulate sysuser-shadow-2.0-lp152.4.114 [ 17s] [173/180] cumulate system-group-hardware-20170617-lp152.5.114 [ 17s] [174/180] cumulate libutempter0-1.1.6-lp152.5.114 [ 17s] [175/180] cumulate util-linux-2.33.1-lp152.4.78 [ 17s] [176/180] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 17s] [177/180] cumulate systemd-234-lp152.30.1 [ 17s] [178/180] cumulate rpm-build-4.14.1-lp152.17.5 [ 17s] [179/180] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 17s] [180/180] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 17s] now installing cumulated packages [ 17s] Preparing... ######################################## [ 17s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 17s] exit ... [ 17s] ### VM INTERACTION START ### [ 20s] [ 9.345427] sysrq: Power Off [ 20s] [ 9.350466] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] lamb28 failed "build osmo-mgw.spec" at Fri Dec 24 01:18:11 UTC 2021. [ 20s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:18:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:18:52 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c5200abb93c_196b2ab2434446002508d0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 41s] [149/166] cumulate gcc7-7.4.0+r266845-lp151.1.35 [ 41s] [150/166] cumulate gcc-7-lp151.3.5 [ 41s] [151/166] cumulate hostname-3.16-lp151.2.3 [ 41s] [152/166] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 41s] [153/166] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 41s] [154/166] cumulate pam-1.3.0-lp151.7.38 [ 41s] [155/166] cumulate gcc-PIE-7-lp151.3.5 [ 41s] [156/166] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 41s] [157/166] cumulate shadow-4.6-lp151.1.27 [ 41s] [158/166] cumulate sysuser-shadow-2.0-lp151.3.70 [ 41s] [159/166] cumulate system-group-hardware-20170617-lp151.4.70 [ 41s] [160/166] cumulate libutempter0-1.1.6-lp151.4.70 [ 41s] [161/166] cumulate util-linux-2.33.1-lp151.2.23 [ 41s] [162/166] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 41s] [163/166] cumulate systemd-234-lp151.25.7 [ 41s] [164/166] cumulate rpm-build-4.14.1-lp151.13.10 [ 41s] [165/166] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 41s] [166/166] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 41s] now installing cumulated packages [ 41s] Preparing... ######################################## [ 41s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 41s] exit ... [ 41s] ### VM INTERACTION START ### [ 45s] [ 10.964651] sysrq: SysRq : Power Off [ 45s] [ 10.988436] reboot: Power down [ 45s] ### VM INTERACTION END ### [ 45s] [ 45s] lamb22 failed "build osmo-ggsn.spec" at Fri Dec 24 01:18:41 UTC 2021. [ 45s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:18:52 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:18:52 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c5200b4f42a_196b2ab243444600250996@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-mgw failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 25s] [159/176] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 25s] [160/176] cumulate libosmonetif8-1.1.0-lp151.2.2 [ 25s] [161/176] cumulate pam-1.3.0-lp151.7.2 [ 25s] [162/176] cumulate gcc-PIE-7-lp151.3.2 [ 25s] [163/176] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 25s] [164/176] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 25s] [165/176] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 25s] [166/176] cumulate libosmocoding-devel-1.6.0-lp151.1.1 [ 25s] [167/176] cumulate shadow-4.6-lp151.1.2 [ 25s] [168/176] cumulate sysuser-shadow-2.0-lp151.3.3 [ 25s] [169/176] cumulate system-group-hardware-20170617-lp151.4.3 [ 25s] [170/176] cumulate libutempter0-1.1.6-lp151.4.3 [ 25s] [171/176] cumulate util-linux-2.33.1-lp151.2.2 [ 25s] [172/176] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 25s] [173/176] cumulate systemd-234-lp151.25.2 [ 25s] [174/176] cumulate rpm-build-4.14.1-lp151.13.2 [ 25s] [175/176] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 25s] [176/176] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 25s] now installing cumulated packages [ 25s] Preparing... ######################################## [ 25s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 25s] exit ... [ 25s] ### VM INTERACTION START ### [ 28s] [ 8.805211] sysrq: SysRq : Power Off [ 28s] [ 8.805824] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] obs-arm-11 failed "build osmo-mgw.spec" at Fri Dec 24 01:18:37 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:19:26 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:19:26 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c5202b45a57_196b2ab243444600251131@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 13s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 13s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 13s] exit ... [ 13s] ### VM INTERACTION START ### [ 16s] [ 8.264064] sysrq: Power Off [ 16s] [ 8.267554] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] sheep85 failed "build simtrace2.spec" at Fri Dec 24 01:19:20 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:20:00 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:20:00 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c5204a5db5b_196b2ab2434446002512cc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 25s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 25s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 25s] exit ... [ 25s] ### VM INTERACTION START ### [ 29s] [ 10.256336] sysrq: SysRq : Power Off [ 29s] [ 10.256985] reboot: Power down [ 29s] ### VM INTERACTION END ### [ 29s] [ 29s] obs-arm-10 failed "build simtrace2.spec" at Fri Dec 24 01:19:57 UTC 2021. [ 29s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:22:33 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:22:33 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c520deb435b_196b2ab2434446002521bc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 14s] [150/167] cumulate gcc7-7.5.0+r278197-lp152.2.46 [ 14s] [151/167] cumulate gcc-7-lp152.4.114 [ 14s] [152/167] cumulate hostname-3.16-lp152.3.5 [ 14s] [153/167] cumulate libosmogsm-devel-1.6.0-lp152.1.1 [ 14s] [154/167] cumulate libosmoctrl0-1.6.0-lp152.1.1 [ 14s] [155/167] cumulate pam-1.3.0-lp152.10.25 [ 14s] [156/167] cumulate gcc-PIE-7-lp152.4.114 [ 14s] [157/167] cumulate libosmoctrl-devel-1.6.0-lp152.1.1 [ 14s] [158/167] cumulate shadow-4.6-lp152.3.80 [ 14s] [159/167] cumulate sysuser-shadow-2.0-lp152.4.114 [ 14s] [160/167] cumulate system-group-hardware-20170617-lp152.5.114 [ 14s] [161/167] cumulate libutempter0-1.1.6-lp152.5.114 [ 14s] [162/167] cumulate util-linux-2.33.1-lp152.4.78 [ 14s] [163/167] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 14s] [164/167] cumulate systemd-234-lp152.30.1 [ 14s] [165/167] cumulate rpm-build-4.14.1-lp152.17.5 [ 14s] [166/167] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 14s] [167/167] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 14s] now installing cumulated packages [ 14s] Preparing... ######################################## [ 14s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 14s] exit ... [ 14s] ### VM INTERACTION START ### [ 17s] [ 8.655832] sysrq: Power Off [ 17s] [ 8.662173] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] lamb66 failed "build osmo-ggsn.spec" at Fri Dec 24 01:22:20 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:22:50 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:22:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c520fdb90a7_196b2ab243444600252248@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-ggsn failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 31s] [146/163] cumulate gcc7-7.4.0+r266845-lp151.1.3 [ 31s] [147/163] cumulate gcc-7-lp151.3.2 [ 31s] [148/163] cumulate hostname-3.16-lp151.2.3 [ 31s] [149/163] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 31s] [150/163] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 31s] [151/163] cumulate pam-1.3.0-lp151.7.2 [ 31s] [152/163] cumulate gcc-PIE-7-lp151.3.2 [ 31s] [153/163] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 31s] [154/163] cumulate shadow-4.6-lp151.1.2 [ 31s] [155/163] cumulate sysuser-shadow-2.0-lp151.3.3 [ 31s] [156/163] cumulate system-group-hardware-20170617-lp151.4.3 [ 31s] [157/163] cumulate libutempter0-1.1.6-lp151.4.3 [ 31s] [158/163] cumulate util-linux-2.33.1-lp151.2.2 [ 31s] [159/163] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 31s] [160/163] cumulate systemd-234-lp151.25.2 [ 31s] [161/163] cumulate rpm-build-4.14.1-lp151.13.2 [ 31s] [162/163] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 31s] [163/163] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 31s] now installing cumulated packages [ 31s] Preparing... ######################################## [ 31s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 31s] exit ... [ 31s] ### VM INTERACTION START ### [ 34s] [ 8.809292] sysrq: SysRq : Power Off [ 34s] [ 8.809896] reboot: Power down [ 34s] ### VM INTERACTION END ### [ 34s] [ 34s] obs-arm-11 failed "build osmo-ggsn.spec" at Fri Dec 24 01:22:47 UTC 2021. [ 34s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:23:07 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:23:07 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c520fe7a7d4_196b2ab243444600252351@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 63s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-[ 7.765970] serial8250: too much work for irq4 [ 63s] lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 63s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 63s] exit ... [ 63s] ### VM INTERACTION START ### [ 66s] [ 10.982526] sysrq: SysRq : Power Off [ 66s] [ 11.033554] reboot: Power down [ 66s] ### VM INTERACTION END ### [ 66s] [ 66s] cloud127 failed "build simtrace2.spec" at Fri Dec 24 01:23:00 UTC 2021. [ 66s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:25:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:25:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c521afb612a_196b2ab243444600252970@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 13s] [154/171] cumulate libopenssl-1_1-devel-1.1.0i-lp151.7.7 [ 13s] [155/171] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 13s] [156/171] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 13s] [157/171] cumulate libosmogb12-1.6.0-lp151.1.1 [ 13s] [158/171] cumulate pam-1.3.0-lp151.7.38 [ 13s] [159/171] cumulate gcc-PIE-7-lp151.3.5 [ 13s] [160/171] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 13s] [161/171] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 13s] [162/171] cumulate shadow-4.6-lp151.1.27 [ 13s] [163/171] cumulate sysuser-shadow-2.0-lp151.3.70 [ 13s] [164/171] cumulate system-group-hardware-20170617-lp151.4.70 [ 13s] [165/171] cumulate libutempter0-1.1.6-lp151.4.70 [ 13s] [166/171] cumulate util-linux-2.33.1-lp151.2.23 [ 13s] [167/171] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 13s] [168/171] cumulate systemd-234-lp151.25.7 [ 13s] [169/171] cumulate rpm-build-4.14.1-lp151.13.10 [ 13s] [170/171] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 13s] [171/171] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 13s] now installing cumulated packages [ 13s] Preparing... ######################################## [ 13s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 13s] exit ... [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.222411] sysrq: SysRq : Power Off [ 16s] [ 7.229365] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] lamb12 failed "build osmo-gbproxy.spec" at Fri Dec 24 01:25:32 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:25:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:25:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c521b012ab7_196b2ab243444600253064@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 17s] [179/196] cumulate libosmogsm-devel-1.6.0-lp152.1.1 [ 17s] [180/196] cumulate pam-1.3.0-lp152.10.25 [ 17s] [181/196] cumulate python3-base-3.6.10-lp152.3.7 [ 17s] [182/196] cumulate gcc-PIE-7-lp152.4.114 [ 17s] [183/196] cumulate pcre-devel-8.41-lp152.6.104 [ 17s] [184/196] cumulate shadow-4.6-lp152.3.80 [ 17s] [185/196] cumulate sysuser-shadow-2.0-lp152.4.114 [ 17s] [186/196] cumulate libselinux-devel-3.0-lp152.1.47 [ 17s] [187/196] cumulate system-group-hardware-20170617-lp152.5.114 [ 17s] [188/196] cumulate glib2-devel-2.62.5-lp152.1.14 [ 17s] [189/196] cumulate libutempter0-1.1.6-lp152.5.114 [ 17s] [190/196] cumulate sofia-sip-devel-1.12.11-lp152.3.7 [ 17s] [191/196] cumulate util-linux-2.33.1-lp152.4.78 [ 17s] [192/196] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 17s] [193/196] cumulate systemd-234-lp152.30.1 [ 17s] [194/196] cumulate rpm-build-4.14.1-lp152.17.5 [ 17s] [195/196] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 17s] [196/196] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 17s] now installing cumulated packages [ 17s] Preparing... ######################################## [ 17s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 17s] exit ... [ 17s] ### VM INTERACTION START ### [ 20s] [ 9.720226] sysrq: Power Off [ 20s] [ 9.723690] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb07 failed "build osmo-sip-connector.spec" at Fri Dec 24 01:25:38 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:25:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:25:57 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c521b07f804_196b2ab2434446002531bd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-sip-connector failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 25s] [169/186] cumulate libopenssl-1_1-devel-1.1.0i-lp151.7.2 [ 25s] [170/186] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 25s] [171/186] cumulate pam-1.3.0-lp151.7.2 [ 25s] [172/186] cumulate python3-base-3.6.5-lp151.4.2 [ 25s] [173/186] cumulate gcc-PIE-7-lp151.3.2 [ 25s] [174/186] cumulate pcre-devel-8.41-lp151.5.3 [ 25s] [175/186] cumulate shadow-4.6-lp151.1.2 [ 25s] [176/186] cumulate sysuser-shadow-2.0-lp151.3.3 [ 25s] [177/186] cumulate glib2-devel-2.54.3-lp151.6.2 [ 25s] [178/186] cumulate system-group-hardware-20170617-lp151.4.3 [ 25s] [179/186] cumulate sofia-sip-devel-1.12.11-lp151.2.3 [ 25s] [180/186] cumulate libutempter0-1.1.6-lp151.4.3 [ 25s] [181/186] cumulate util-linux-2.33.1-lp151.2.2 [ 25s] [182/186] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 25s] [183/186] cumulate systemd-234-lp151.25.2 [ 25s] [184/186] cumulate rpm-build-4.14.1-lp151.13.2 [ 25s] [185/186] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 25s] [186/186] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 25s] now installing cumulated packages [ 25s] Preparing... ######################################## [ 25s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 25s] exit ... [ 25s] ### VM INTERACTION START ### [ 29s] [ 13.773613] sysrq: SysRq : Power Off [ 29s] [ 13.905791] reboot: Power down [ 29s] ### VM INTERACTION END ### [ 29s] [ 29s] obs-arm-9 failed "build osmo-sip-connector.spec" at Fri Dec 24 01:25:42 UTC 2021. [ 29s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:26:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:26:48 +0000 Subject: Build failure of network:osmocom:latest/libosmo-netif in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c521ea733c2_196b2ab243444600253687@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-netif/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/libosmo-netif failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest libosmo-netif Last lines of build log: [ 23s] [139/156] cumulate libtool-2.4.6-lp151.2.3 [ 23s] [140/156] cumulate build-compare-20171204T112209.f06fbac-lp151.2.3 [ 23s] [141/156] cumulate gcc7-7.4.0+r266845-lp151.1.3 [ 23s] [142/156] cumulate gcc-7-lp151.3.2 [ 23s] [143/156] cumulate hostname-3.16-lp151.2.3 [ 23s] [144/156] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 23s] [145/156] cumulate pam-1.3.0-lp151.7.2 [ 23s] [146/156] cumulate gcc-PIE-7-lp151.3.2 [ 23s] [147/156] cumulate shadow-4.6-lp151.1.2 [ 23s] [148/156] cumulate sysuser-shadow-2.0-lp151.3.3 [ 23s] [149/156] cumulate system-group-hardware-20170617-lp151.4.3 [ 23s] [150/156] cumulate libutempter0-1.1.6-lp151.4.3 [ 23s] [151/156] cumulate util-linux-2.33.1-lp151.2.2 [ 23s] [152/156] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 23s] [153/156] cumulate systemd-234-lp151.25.2 [ 23s] [154/156] cumulate rpm-build-4.14.1-lp151.13.2 [ 23s] [155/156] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 23s] [156/156] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 23s] now installing cumulated packages [ 23s] Preparing... ######################################## [ 23s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 23s] exit ... [ 23s] ### VM INTERACTION START ### [ 26s] [ 11.601623] sysrq: SysRq : Power Off [ 26s] [ 11.603034] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] armbuild01 failed "build libosmo-netif.spec" at Fri Dec 24 01:26:43 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:28:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:28:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c52247c5a81_196b2ab243444600253969@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-gbproxy failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 23s] [151/168] cumulate libopenssl-1_1-devel-1.1.0i-lp151.7.2 [ 23s] [152/168] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 23s] [153/168] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 23s] [154/168] cumulate libosmogb12-1.6.0-lp151.1.1 [ 23s] [155/168] cumulate pam-1.3.0-lp151.7.2 [ 23s] [156/168] cumulate gcc-PIE-7-lp151.3.2 [ 23s] [157/168] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 23s] [158/168] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 23s] [159/168] cumulate shadow-4.6-lp151.1.2 [ 23s] [160/168] cumulate sysuser-shadow-2.0-lp151.3.3 [ 23s] [161/168] cumulate system-group-hardware-20170617-lp151.4.3 [ 23s] [162/168] cumulate libutempter0-1.1.6-lp151.4.3 [ 23s] [163/168] cumulate util-linux-2.33.1-lp151.2.2 [ 23s] [164/168] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 23s] [165/168] cumulate systemd-234-lp151.25.2 [ 23s] [166/168] cumulate rpm-build-4.14.1-lp151.13.2 [ 23s] [167/168] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 23s] [168/168] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 23s] now installing cumulated packages [ 23s] Preparing... ######################################## [ 23s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 23s] exit ... [ 23s] ### VM INTERACTION START ### [ 26s] [ 12.014429] sysrq: SysRq : Power Off [ 26s] [ 12.080576] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] obs-arm-9 failed "build osmo-gbproxy.spec" at Fri Dec 24 01:28:02 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:28:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:28:31 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c522499ccd9_196b2ab2434446002543af@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-gbproxy failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 19s] [155/172] cumulate libopenssl-1_1-devel-1.1.1d-lp152.6.22 [ 19s] [156/172] cumulate libosmogsm-devel-1.6.0-lp152.1.1 [ 19s] [157/172] cumulate libosmoctrl0-1.6.0-lp152.1.1 [ 19s] [158/172] cumulate libosmogb12-1.6.0-lp152.1.1 [ 19s] [159/172] cumulate pam-1.3.0-lp152.10.25 [ 19s] [160/172] cumulate gcc-PIE-7-lp152.4.114 [ 19s] [161/172] cumulate libosmoctrl-devel-1.6.0-lp152.1.1 [ 19s] [162/172] cumulate libosmogb-devel-1.6.0-lp152.1.1 [ 19s] [163/172] cumulate shadow-4.6-lp152.3.80 [ 19s] [164/172] cumulate sysuser-shadow-2.0-lp152.4.114 [ 19s] [165/172] cumulate system-group-hardware-20170617-lp152.5.114 [ 19s] [166/172] cumulate libutempter0-1.1.6-lp152.5.114 [ 19s] [167/172] cumulate util-linux-2.33.1-lp152.4.78 [ 19s] [168/172] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 19s] [169/172] cumulate systemd-234-lp152.30.1 [ 19s] [170/172] cumulate rpm-build-4.14.1-lp152.17.5 [ 19s] [171/172] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 19s] [172/172] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 19s] now installing cumulated packages [ 19s] Preparing... ######################################## [ 19s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 19s] exit ... [ 19s] ### VM INTERACTION START ### [ 22s] [ 10.885001] sysrq: Power Off [ 22s] [ 10.908118] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb28 failed "build osmo-gbproxy.spec" at Fri Dec 24 01:28:16 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:28:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:28:48 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c5226353b66_196b2ab2434446002544b7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 31s] [152/169] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 31s] [153/169] cumulate libosmogb12-1.6.0-lp151.1.1 [ 31s] [154/169] cumulate gcc7-c++-7.4.0+r266845-lp151.1.35 [ 31s] [155/169] cumulate pam-1.3.0-lp151.7.38 [ 31s] [156/169] cumulate gcc-PIE-7-lp151.3.5 [ 31s] [157/169] cumulate gcc-c++-7-lp151.3.5 [ 31s] [158/169] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 31s] [159/169] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 31s] [160/169] cumulate shadow-4.6-lp151.1.27 [ 31s] [161/169] cumulate sysuser-shadow-2.0-lp151.3.70 [ 31s] [162/169] cumulate system-group-hardware-20170617-lp151.4.70 [ 31s] [163/169] cumulate libutempter0-1.1.6-lp151.4.70 [ 31s] [164/169] cumulate util-linux-2.33.1-lp151.2.23 [ 31s] [165/169] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 31s] [166/169] cumulate systemd-234-lp151.25.7 [ 31s] [167/169] cumulate rpm-build-4.14.1-lp151.13.10 [ 31s] [168/169] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 31s] [169/169] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 31s] now installing cumulated packages [ 31s] Preparing... ######################################## [ 31s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 31s] exit ... [ 31s] ### VM INTERACTION START ### [ 34s] [ 10.172508] sysrq: SysRq : Power Off [ 34s] [ 10.190394] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] lamb55 failed "build osmo-pcu.spec" at Fri Dec 24 01:28:32 UTC 2021. [ 35s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:29:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:29:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcap in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c522a1e6371_196b2ab2434446002545d0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcap/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-pcap failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcap Last lines of build log: [ 13s] [164/180] cumulate hostname-3.16-lp151.2.3 [ 13s] [165/180] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 13s] [166/180] cumulate libosmogb12-1.6.0-lp151.1.1 [ 13s] [167/180] cumulate libgnutls-devel-3.6.7-lp151.1.1 [ 13s] [168/180] cumulate pam-1.3.0-lp151.7.38 [ 13s] [169/180] cumulate gcc-PIE-7-lp151.3.5 [ 13s] [170/180] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 13s] [171/180] cumulate shadow-4.6-lp151.1.27 [ 13s] [172/180] cumulate sysuser-shadow-2.0-lp151.3.70 [ 13s] [173/180] cumulate [ 3.921345] serial8250: too much work for irq4 [ 13s] system-group-hardware-20170617-lp151.4.70 [ 13s] [174/180] cumulate libutempter0-1.1.6-lp151.4.70 [ 13s] [175/180] cumulate util-linux-2.33.1-lp151.2.23 [ 13s] [176/180] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 13s] [177/180] cumulate systemd-234-lp151.25.7 [ 13s] [178/180] cumulate rpm-build-4.14.1-lp151.13.10 [ 13s] [179/180] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 13s] [180/180] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 13s] now installing cumulated packages [ 13s] Preparing... ######################################## [ 13s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 13s] exit ... [ 13s] ### VM INTERACTION START ### [ 16s] [ 7.291200] sysrq: SysRq : Power Off [ 16s] [ 7.296590] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 17s] [ 17s] lamb13 failed "build osmo-pcap.spec" at Fri Dec 24 01:29:37 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:29:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:29:40 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c522a22d26a_196b2ab2434446002546fd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/libosmo-sccp failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 18s] [143/160] cumulate gcc7-7.4.0+r266845-lp151.1.3 [ 18s] [144/160] cumulate gcc-7-lp151.3.2 [ 18s] [145/160] cumulate hostname-3.16-lp151.2.3 [ 18s] [146/160] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 18s] [147/160] cumulate libosmonetif8-1.1.0-lp151.2.2 [ 18s] [148/160] cumulate pam-1.3.0-lp151.7.2 [ 18s] [149/160] cumulate gcc-PIE-7-lp151.3.2 [ 18s] [150/160] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 18s] [151/160] cumulate shadow-4.6-lp151.1.2 [ 18s] [152/160] cumulate sysuser-shadow-2.0-lp151.3.3 [ 18s] [153/160] cumulate system-group-hardware-20170617-lp151.4.3 [ 18s] [154/160] cumulate libutempter0-1.1.6-lp151.4.3 [ 18s] [155/160] cumulate util-linux-2.33.1-lp151.2.2 [ 18s] [156/160] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 18s] [157/160] cumulate systemd-234-lp151.25.2 [ 18s] [158/160] cumulate rpm-build-4.14.1-lp151.13.2 [ 18s] [159/160] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 18s] [160/160] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 18s] now installing cumulated packages [ 18s] Preparing... ######################################## [ 18s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 19s] exit ... [ 19s] ### VM INTERACTION START ### [ 22s] [ 9.655445] sysrq: SysRq : Power Off [ 22s] [ 9.657168] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] armbuild25 failed "build libosmo-sccp.spec" at Fri Dec 24 01:29:37 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:30:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:30:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcap in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c522bcaf3fb_196b2ab24344460025497c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcap/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-pcap failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcap Last lines of build log: [ 13s] [159/176] cumulate gcc-7-lp151.3.2 [ 13s] [160/176] cumulate hostname-3.16-lp151.2.3 [ 13s] [161/176] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 13s] [162/176] cumulate libosmogb12-1.6.0-lp151.1.1 [ 13s] [163/176] cumulate libgnutls-devel-3.6.7-lp151.1.1 [ 13s] [164/176] cumulate pam-1.3.0-lp151.7.2 [ 13s] [165/176] cumulate gcc-PIE-7-lp151.3.2 [ 13s] [166/176] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 13s] [167/176] cumulate shadow-4.6-lp151.1.2 [ 13s] [168/176] cumulate sysuser-shadow-2.0-lp151.3.3 [ 13s] [169/176] cumulate system-group-hardware-20170617-lp151.4.3 [ 13s] [170/176] cumulate libutempter0-1.1.6-lp151.4.3 [ 13s] [171/176] cumulate util-linux-2.33.1-lp151.2.2 [ 13s] [172/176] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 13s] [173/176] cumulate systemd-234-lp151.25.2 [ 13s] [174/176] cumulate rpm-build-4.14.1-lp151.13.2 [ 13s] [175/176] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 13s] [176/176] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 13s] now installing cumulated packages [ 13s] Preparing... ######################################## [ 13s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 13s] exit ... [ 13s] ### VM INTERACTION START ### [ 16s] [ 8.628490] sysrq: SysRq : Power Off [ 16s] [ 8.629193] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] obs-arm-11 failed "build osmo-pcap.spec" at Fri Dec 24 01:30:12 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:30:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:30:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c522bcdb846_196b2ab24344460025502f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-trx failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 39s] [193/210] cumulate libboost_regex1_66_0-devel-1.66.0-lp152.6.2 [ 39s] [194/210] cumulate libboost_serialization1_66_0-devel-1.66.0-lp152.6.2 [ 39s] [195/210] cumulate libboost_system1_66_0-devel-1.66.0-lp152.6.2 [ 39s] [196/210] cumulate libboost_test1_66_0-devel-1.66.0-lp152.6.2 [ 39s] [197/210] cumulate sysuser-shadow-2.0-lp152.4.114 [ 39s] [198/210] cumulate libboost_date_time1_66_0-devel-1.66.0-lp152.6.2 [ 39s] [199/210] cumulate libuhd003-3.9.7-lp152.7.32 [ 39s] [200/210] cumulate system-group-hardware-20170617-lp152.5.114 [ 39s] [201/210] cumulate libboost_filesystem1_66_0-devel-1.66.0-lp152.6.2 [ 39s] [202/210] cumulate libboost_thread1_66_0-devel-1.66.0-lp152.6.2 [ 39s] [203/210] cumulate libutempter0-1.1.6-lp152.5.114 [ 39s] [204/210] cumulate uhd-devel-3.9.7-lp152.7.32 [ 39s] [205/210] cumulate util-linux-2.33.1-lp152.4.78 [ 39s] [206/210] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 39s] [207/210] cumulate systemd-234-lp152.30.1 [ 39s] [208/210] cumulate rpm-build-4.14.1-lp152.17.5 [ 39s] [209/210] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 39s] [210/210] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 39s] now installing cumulated packages [ 39s] Preparing... ######################################## [ 39s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 39s] exit ... [ 39s] ### VM INTERACTION START ### [ 42s] [ 14.288601] sysrq: Power Off [ 42s] [ 14.342451] reboot: Power down [ 43s] ### VM INTERACTION END ### [ 43s] [ 43s] lamb55 failed "build osmo-trx.spec" at Fri Dec 24 01:30:13 UTC 2021. [ 43s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:31:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:31:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcap in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c5231733746_196b2ab2434446002557a7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcap/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-pcap failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcap Last lines of build log: [ 10s] [164/181] cumulate gcc-7-lp152.4.114 [ 10s] [165/181] cumulate hostname-3.16-lp152.3.5 [ 10s] [166/181] cumulate libosmogsm-devel-1.6.0-lp152.1.1 [ 10s] [167/181] cumulate libosmogb12-1.6.0-lp152.1.1 [ 10s] [168/181] cumulate libgnutls-devel-3.6.7-lp152.8.1 [ 10s] [169/181] cumulate pam-1.3.0-lp152.10.25 [ 10s] [170/181] cumulate gcc-PIE-7-lp152.4.114 [ 10s] [171/181] cumulate libosmogb-devel-1.6.0-lp152.1.1 [ 10s] [172/181] cumulate shadow-4.6-lp152.3.80 [ 10s] [173/181] cumulate sysuser-shadow-2.0-lp152.4.114 [ 10s] [174/181] cumulate system-group-hardware-20170617-lp152.5.114 [ 10s] [175/181] cumulate libutempter0-1.1.6-lp152.5.114 [ 10s] [176/181] cumulate util-linux-2.33.1-lp152.4.78 [ 10s] [177/181] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 10s] [178/181] cumulate systemd-234-lp152.30.1 [ 10s] [179/181] cumulate rpm-build-4.14.1-lp152.17.5 [ 10s] [180/181] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 10s] [181/181] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 10s] now installing cumulated packages [ 10s] Preparing... ######################################## [ 10s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 10s] exit ... [ 10s] ### VM INTERACTION START ### [ 13s] [ 7.757794] sysrq: Power Off [ 13s] [ 7.759354] reboot: Power down [ 13s] ### VM INTERACTION END ### [ 13s] [ 13s] goat11 failed "build osmo-pcap.spec" at Fri Dec 24 01:31:28 UTC 2021. [ 13s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:31:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:31:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c52317994e9_196b2ab2434446002559de@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 12s] [172/189] cumulate libopenssl-1_1-devel-1.1.0i-lp151.7.7 [ 12s] [173/189] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 12s] [174/189] cumulate pam-1.3.0-lp151.7.38 [ 12s] [175/189] cumulate python3-base-3.6.5-lp151.5.2 [ 12s] [176/189] cumulate gcc-PIE-7-lp151.3.5 [ 12s] [177/189] cumulate pcre-devel-8.41-lp151.5.67 [ 12s] [178/189] cumulate shadow-4.6-lp151.1.27 [ 12s] [179/189] cumulate sysuser-shadow-2.0-lp151.3.70 [ 12s] [180/189] cumulate glib2-devel-2.54.3-lp151.6.2 [ 12s] [181/189] cumulate system-group-hardware-20170617-lp151.4.70 [ 12s] [182/189] cumulate sofia-sip-devel-1.12.11-lp151.2.4 [ 12s] [183/189] cumulate libutempter0-1.1.6-lp151.4.70 [ 12s] [184/189] cumulate util-linux-2.33.1-lp151.2.23 [ 12s] [185/189] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 12s] [186/189] cumulate systemd-234-lp151.25.7 [ 12s] [187/189] cumulate rpm-build-4.14.1-lp151.13.10 [ 12s] [188/189] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 12s] [189/189] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 12s] now installing cumulated packages [ 12s] Preparing... ######################################## [ 12s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 12s] exit ... [ 12s] ### VM INTERACTION START ### [ 15s] [ 7.194642] sysrq: SysRq : Power Off [ 15s] [ 7.198967] reboot: Power down [ 15s] ### VM INTERACTION END ### [ 15s] [ 15s] sheep87 failed "build osmo-sip-connector.spec" at Fri Dec 24 01:31:31 UTC 2021. [ 15s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:33:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:33:23 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c523725aa09_196b2ab243444600257182@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-pcu failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 24s] [149/166] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 24s] [150/166] cumulate libosmogb12-1.6.0-lp151.1.1 [ 24s] [151/166] cumulate gcc7-c++-7.4.0+r266845-lp151.1.3 [ 24s] [152/166] cumulate pam-1.3.0-lp151.7.2 [ 24s] [153/166] cumulate gcc-PIE-7-lp151.3.2 [ 24s] [154/166] cumulate gcc-c++-7-lp151.3.2 [ 24s] [155/166] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 24s] [156/166] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 24s] [157/166] cumulate shadow-4.6-lp151.1.2 [ 24s] [158/166] cumulate sysuser-shadow-2.0-lp151.3.3 [ 24s] [159/166] cumulate system-group-hardware-20170617-lp151.4.3 [ 24s] [160/166] cumulate libutempter0-1.1.6-lp151.4.3 [ 24s] [161/166] cumulate util-linux-2.33.1-lp151.2.2 [ 24s] [162/166] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 24s] [163/166] cumulate systemd-234-lp151.25.2 [ 24s] [164/166] cumulate rpm-build-4.14.1-lp151.13.2 [ 24s] [165/166] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 24s] [166/166] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 24s] now installing cumulated packages [ 24s] Preparing... ######################################## [ 24s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 25s] exit ... [ 25s] ### VM INTERACTION START ### [ 28s] [ 12.582264] sysrq: SysRq : Power Off [ 28s] [ 12.620964] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] obs-arm-9 failed "build osmo-pcu.spec" at Fri Dec 24 01:33:13 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:33:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:33:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c52394cebc6_196b2ab24344460025747c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-trx failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 14s] [195/212] cumulate libboost_regex1_66_0-devel-1.66.0-lp151.4.5 [ 14s] [196/212] cumulate libboost_serialization1_66_0-devel-1.66.0-lp151.4.5 [ 14s] [197/212] cumulate libboost_system1_66_0-devel-1.66.0-lp151.4.5 [ 14s] [198/212] cumulate libboost_test1_66_0-devel-1.66.0-lp151.4.5 [ 14s] [199/212] cumulate sysuser-shadow-2.0-lp151.3.70 [ 14s] [200/212] cumulate libboost_date_time1_66_0-devel-1.66.0-lp151.4.5 [ 14s] [201/212] cumulate libuhd003-3.9.7-lp151.4.51 [ 14s] [202/212] cumulate system-group-hardware-20170617-lp151.4.70 [ 14s] [203/212] cumulate libboost_filesystem1_66_0-devel-1.66.0-lp151.4.5 [ 14s] [204/212] cumulate libboost_thread1_66_0-devel-1.66.0-lp151.4.5 [ 14s] [205/212] cumulate libutempter0-1.1.6-lp151.4.70 [ 14s] [206/212] cumulate uhd-devel-3.9.7-lp151.4.51 [ 14s] [207/212] cumulate util-linux-2.33.1-lp151.2.23 [ 14s] [208/212] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 14s] [209/212] cumulate systemd-234-lp151.25.7 [ 14s] [210/212] cumulate rpm-build-4.14.1-lp151.13.10 [ 14s] [211/212] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 14s] [212/212] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 14s] now installing cumulated packages [ 14s] Preparing... ######################################## [ 14s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 14s] exit ... [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.418770] sysrq: SysRq : Power Off [ 17s] [ 7.423287] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] lamb07 failed "build osmo-trx.spec" at Fri Dec 24 01:33:26 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:33:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:33:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c52394801e9_196b2ab2434446002573fd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 14s] [153/170] cumulate libosmoctrl0-1.6.0-lp152.1.1 [ 14s] [154/170] cumulate libosmogb12-1.6.0-lp152.1.1 [ 14s] [155/170] cumulate gcc7-c++-7.5.0+r278197-lp152.2.46 [ 14s] [156/170] cumulate pam-1.3.0-lp152.10.25 [ 14s] [157/170] cumulate gcc-PIE-7-lp152.4.114 [ 14s] [158/170] cumulate gcc-c++-7-lp152.4.114 [ 14s] [159/170] cumulate libosmoctrl-devel-1.6.0-lp152.1.1 [ 14s] [160/170] cumulate libosmogb-devel-1.6.0-lp152.1.1 [ 14s] [161/170] cumulate shadow-4.6-lp152.3.80 [ 14s] [162/170] cumulate sysuser-shadow-2.0-lp152.4.114 [ 14s] [163/170] cumulate system-group-hardware-20170617-lp152.5.114 [ 14s] [164/170] cumulate libutempter0-1.1.6-lp152.5.114 [ 14s] [165/170] cumulate util-linux-2.33.1-lp152.4.78 [ 14s] [166/170] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 14s] [167/170] cumulate systemd-234-lp152.30.1 [ 14s] [168/170] cumulate rpm-build-4.14.1-lp152.17.5 [ 14s] [169/170] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 14s] [170/170] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 14s] now installing cumulated packages [ 14s] Preparing... ######################################## [ 14s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 15s] exit ... [ 15s] ### VM INTERACTION START ### [ 18s] [ 8.896814] sysrq: Power Off [ 18s] [ 8.907401] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] lamb12 failed "build osmo-pcu.spec" at Fri Dec 24 01:33:25 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Dec 24 01:34:47 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 24 Dec 2021 01:34:47 +0000 Subject: Change in libosmo-abis[master]: ipaccess.c: register RSL/OML related osmo_fds for monitoring In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/26455 ) Change subject: ipaccess.c: register RSL/OML related osmo_fds for monitoring ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/libosmo-abis/+/26455/3/src/input/ipaccess.c File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/26455/3/src/input/ipaccess.c at 676 PS3, Line 676: rsl oml -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/26455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I42ca4e9257eee2857784dd4f5b17a83220e2be9e Gerrit-Change-Number: 26455 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 24 Dec 2021 01:34:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Dec 24 01:35:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:35:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c52408aee37_196b2ab2434446002582cb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-bts failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 18s] [163/180] cumulate libosmoctrl0-1.6.0-lp152.1.1 [ 18s] [164/180] cumulate libosmogb12-1.6.0-lp152.1.1 [ 18s] [165/180] cumulate pam-1.3.0-lp152.10.25 [ 18s] [166/180] cumulate gcc-PIE-7-lp152.4.114 [ 18s] [167/180] cumulate libosmoabis-devel-1.2.0-lp152.1.1 [ 18s] [168/180] cumulate libosmoctrl-devel-1.6.0-lp152.1.1 [ 18s] [169/180] cumulate libosmogb-devel-1.6.0-lp152.1.1 [ 18s] [170/180] cumulate libosmocoding-devel-1.6.0-lp152.1.1 [ 18s] [171/180] cumulate shadow-4.6-lp152.3.80 [ 18s] [172/180] cumulate sysuser-shadow-2.0-lp152.4.114 [ 18s] [173/180] cumulate system-group-hardware-20170617-lp152.5.114 [ 18s] [174/180] cumulate libutempter0-1.1.6-lp152.5.114 [ 18s] [175/180] cumulate util-linux-2.33.1-lp152.4.78 [ 18s] [176/180] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 18s] [177/180] cumulate systemd-234-lp152.30.1 [ 18s] [178/180] cumulate rpm-build-4.14.1-lp152.17.5 [ 18s] [179/180] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 18s] [180/180] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 18s] now installing cumulated packages [ 18s] Preparing... ######################################## [ 18s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 19s] exit ... [ 19s] ### VM INTERACTION START ### [ 22s] [ 9.977105] sysrq: Power Off [ 22s] [ 9.993027] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb20 failed "build osmo-bts.spec" at Fri Dec 24 01:35:35 UTC 2021. [ 22s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:35:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:35:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c524094e488_196b2ab243444600258395@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 15s] mulate libosmonetif8-1.1.0-lp151.2.2 [ 15s] [174/190] cumulate libulfius2_5-2.5.4-lp151.1.1 [ 15s] [175/190] cumulate libgnutls-devel-3.6.7-lp151.1.1 [ 15s] [176/190] cumulate pam-1.3.0-lp151.7.38 [ 15s] [177/190] cumulate gcc-PIE-7-lp151.3.5 [ 15s] [178/190] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 15s] [179/190] cumulate libmicrohttpd-devel-0.9.57-lp151.2.3 [ 15s] [180/190] cumulate shadow-4.6-lp151.1.27 [ 15s] [181/190] cumulate sysuser-shadow-2.0-lp151.3.70 [ 15s] [182/190] cumulate ulfius-devel-2.5.4-lp151.1.1 [ 15s] [183/190] cumulate system-group-hardware-20170617-lp151.4.70 [ 15s] [184/190] cumulate libutempter0-1.1.6-lp151.4.70 [ 15s] [185/190] cumulate util-linux-2.33.1-lp151.2.23 [ 15s] [186/190] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 15s] [187/190] cumulate systemd-234-lp151.25.7 [ 15s] [188/190] cumulate rpm-build-4.14.1-lp151.13.10 [ 15s] [189/190] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 15s] [190/190] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 15s] now installing cumulated packages [ 15s] Preparing... ######################################## [ 15s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 15s] exit ... [ 15s] ### VM INTERACTION START ### [ 18s] [ 7.674362] sysrq: SysRq : Power Off [ 18s] [ 7.682379] reboot: Power down [ 19s] ### VM INTERACTION END ### [ 19s] [ 19s] lamb07 failed "build osmo-cbc.spec" at Fri Dec 24 01:35:31 UTC 2021. [ 19s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:35:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:35:57 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c5240a27bc6_196b2ab24344460025854f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-trx failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 26s] [192/209] cumulate libboost_regex1_66_0-devel-1.66.0-lp151.4.3 [ 26s] [193/209] cumulate libboost_serialization1_66_0-devel-1.66.0-lp151.4.3 [ 26s] [194/209] cumulate libboost_system1_66_0-devel-1.66.0-lp151.4.3 [ 26s] [195/209] cumulate libboost_test1_66_0-devel-1.66.0-lp151.4.3 [ 26s] [196/209] cumulate sysuser-shadow-2.0-lp151.3.3 [ 26s] [197/209] cumulate libboost_date_time1_66_0-devel-1.66.0-lp151.4.3 [ 26s] [198/209] cumulate libuhd003-3.9.7-lp151.4.3 [ 26s] [199/209] cumulate system-group-hardware-20170617-lp151.4.3 [ 26s] [200/209] cumulate libboost_filesystem1_66_0-devel-1.66.0-lp151.4.3 [ 26s] [201/209] cumulate libboost_thread1_66_0-devel-1.66.0-lp151.4.3 [ 26s] [202/209] cumulate libutempter0-1.1.6-lp151.4.3 [ 26s] [203/209] cumulate uhd-devel-3.9.7-lp151.4.3 [ 26s] [204/209] cumulate util-linux-2.33.1-lp151.2.2 [ 26s] [205/209] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 26s] [206/209] cumulate systemd-234-lp151.25.2 [ 26s] [207/209] cumulate rpm-build-4.14.1-lp151.13.2 [ 26s] [208/209] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 26s] [209/209] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 26s] now installing cumulated packages [ 26s] Preparing... ######################################## [ 27s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 27s] exit ... [ 27s] ### VM INTERACTION START ### [ 30s] [ 13.535624] sysrq: SysRq : Power Off [ 30s] [ 13.537797] reboot: Power down [ 30s] ### VM INTERACTION END ### [ 30s] [ 30s] obs-arm-9 failed "build osmo-trx.spec" at Fri Dec 24 01:35:55 UTC 2021. [ 30s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:37:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:37:23 +0000 Subject: Build failure of network:osmocom:latest/libasn1c in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c52464311e3_196b2ab243444600259285@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/libasn1c failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest libasn1c Last lines of build log: [ 23s] [127/144] cumulate zlib-devel-1.2.11-lp151.4.1 [ 23s] [128/144] cumulate libtool-2.4.6-lp151.2.3 [ 23s] [129/144] cumulate build-compare-20171204T112209.f06fbac-lp151.2.3 [ 23s] [130/144] cumulate gcc7-7.4.0+r266845-lp151.1.3 [ 23s] [131/144] cumulate gcc-7-lp151.3.2 [ 23s] [132/144] cumulate hostname-3.16-lp151.2.3 [ 23s] [133/144] cumulate pam-1.3.0-lp151.7.2 [ 23s] [134/144] cumulate gcc-PIE-7-lp151.3.2 [ 23s] [135/144] cumulate shadow-4.6-lp151.1.2 [ 23s] [136/144] cumulate sysuser-shadow-2.0-lp151.3.3 [ 23s] [137/144] cumulate system-group-hardware-20170617-lp151.4.3 [ 23s] [138/144] cumulate libutempter0-1.1.6-lp151.4.3 [ 23s] [139/144] cumulate util-linux-2.33.1-lp151.2.2 [ 23s] [140/144] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 23s] [141/144] cumulate systemd-234-lp151.25.2 [ 23s] [142/144] cumulate rpm-build-4.14.1-lp151.13.2 [ 23s] [143/144] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 23s] [144/144] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 23s] now installing cumulated packages [ 24s] Preparing... ######################################## [ 24s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 24s] exit ... [ 24s] ### VM INTERACTION START ### [ 27s] [ 12.737411] sysrq: SysRq : Power Off [ 27s] [ 12.740001] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] armbuild24 failed "build libasn1c.spec" at Fri Dec 24 01:37:15 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:37:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:37:57 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c5247f48d62_196b2ab2434446002596da@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-bts failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 27s] [159/176] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 27s] [160/176] cumulate libosmogb12-1.6.0-lp151.1.1 [ 27s] [161/176] cumulate pam-1.3.0-lp151.7.2 [ 27s] [162/176] cumulate gcc-PIE-7-lp151.3.2 [ 27s] [163/176] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 27s] [164/176] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 27s] [165/176] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 27s] [166/176] cumulate libosmocoding-devel-1.6.0-lp151.1.1 [ 27s] [167/176] cumulate shadow-4.6-lp151.1.2 [ 27s] [168/176] cumulate sysuser-shadow-2.0-lp151.3.3 [ 27s] [169/176] cumulate system-group-hardware-20170617-lp151.4.3 [ 27s] [170/176] cumulate libutempter0-1.1.6-lp151.4.3 [ 27s] [171/176] cumulate util-linux-2.33.1-lp151.2.2 [ 27s] [172/176] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 27s] [173/176] cumulate systemd-234-lp151.25.2 [ 27s] [174/176] cumulate rpm-build-4.14.1-lp151.13.2 [ 27s] [175/176] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 27s] [176/176] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 27s] now installing cumulated packages [ 28s] Preparing... ######################################## [ 28s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 28s] exit ... [ 28s] ### VM INTERACTION START ### [ 31s] [ 14.346744] sysrq: SysRq : Power Off [ 31s] [ 14.348591] reboot: Power down [ 32s] ### VM INTERACTION END ### [ 32s] [ 32s] obs-arm-9 failed "build osmo-bts.spec" at Fri Dec 24 01:37:47 UTC 2021. [ 32s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Dec 24 01:38:38 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 24 Dec 2021 01:38:38 +0000 Subject: Change in docker-playground[master]: osmo-remsim-test-latest: install client-shell In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26680 ) Change subject: osmo-remsim-test-latest: install client-shell ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia3041ea6f19ebe53e05117806acf88d3f86d4479 Gerrit-Change-Number: 26680 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 24 Dec 2021 01:38:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Fri Dec 24 01:38:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:38:31 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c5249ef1aca_196b2ab24344460026006a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-cbc failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 14s] [175/192] cumulate libosmonetif8-1.1.0-lp152.2.2 [ 14s] [176/192] cumulate libulfius2_6-2.6.6-lp152.1.2 [ 14s] [177/192] cumulate libgnutls-devel-3.6.7-lp152.8.1 [ 14s] [178/192] cumulate pam-1.3.0-lp152.10.25 [ 14s] [179/192] cumulate gcc-PIE-7-lp152.4.114 [ 14s] [180/192] cumulate libosmonetif-devel-1.1.0-lp152.2.2 [ 14s] [181/192] cumulate libmicrohttpd-devel-0.9.57-lp152.3.4 [ 14s] [182/192] cumulate shadow-4.6-lp152.3.80 [ 14s] [183/192] cumulate sysuser-shadow-2.0-lp152.4.114 [ 14s] [184/192] cumulate ulfius-devel-2.6.6-lp152.1.2 [ 14s] [185/192] cumulate system-group-hardware-20170617-lp152.5.114 [ 14s] [186/192] cumulate libutempter0-1.1.6-lp152.5.114 [ 14s] [187/192] cumulate util-linux-2.33.1-lp152.4.78 [ 14s] [188/192] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 14s] [189/192] cumulate systemd-234-lp152.30.1 [ 14s] [190/192] cumulate rpm-build-4.14.1-lp152.17.5 [ 14s] [191/192] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 14s] [192/192] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 14s] now installing cumulated packages [ 14s] Preparing... ######################################## [ 14s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 14s] exit ... [ 14s] ### VM INTERACTION START ### [ 17s] [ 8.423751] sysrq: Power Off [ 17s] [ 8.427018] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] sheep88 failed "build osmo-cbc.spec" at Fri Dec 24 01:38:27 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:38:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:38:31 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c5249f25b7d_196b2ab24344460026017@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-bts failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 13s] [162/179] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 13s] [163/179] cumulate libosmogb12-1.6.0-lp151.1.1 [ 13s] [164/179] cumulate pam-1.3.0-lp151.7.38 [ 13s] [165/179] cumulate gcc-PIE-7-lp151.3.5 [ 13s] [166/179] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 13s] [167/179] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 13s] [168/179] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 13s] [169/179] cumulate libosmocoding-devel-1.6.0-lp151.1.1 [ 13s] [170/179] cumulate shadow-4.6-lp151.1.27 [ 13s] [171/179] cumulate sysuser-shadow-2.0-lp151.3.70 [ 13s] [172/179] cumulate system-group-hardware-20170617-lp151.4.70 [ 13s] [173/179] cumulate libutempter0-1.1.6-lp151.4.70 [ 13s] [174/179] cumulate util-linux-2.33.1-lp151.2.23 [ 14s] [175/179] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 14s] [176/179] cumulate systemd-234-lp151.25.7 [ 14s] [177/179] cumulate rpm-build-4.14.1-lp151.13.10 [ 14s] [178/179] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 14s] [179/179] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 14s] now installing cumulated packages [ 14s] Preparing... ######################################## [ 14s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 14s] exit ... [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.764683] sysrq: SysRq : Power Off [ 17s] [ 7.773765] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] sheep87 failed "build osmo-bts.spec" at Fri Dec 24 01:38:28 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:39:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:39:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c524f718779_196b2ab2434446002605fd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 7s] [153/170] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 7s] [154/170] cumulate libosmonetif8-1.1.0-lp151.2.2 [ 7s] [155/170] cumulate pam-1.3.0-lp151.7.38 [ 7s] [156/170] cumulate gcc-PIE-7-lp151.3.5 [ 7s] [157/170] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 7s] [158/170] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 7s] [159/170] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 7s] [160/170] cumulate shadow-4.6-lp151.1.27 [ 7s] [161/170] cumulate sysuser-shadow-2.0-lp151.3.70 [ 7s] [162/170] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 7s] [163/170] cumulate system-group-hardware-20170617-lp151.4.70 [ 7s] [164/170] cumulate libutempter0-1.1.6-lp151.4.70 [ 7s] [165/170] cumulate util-linux-2.33.1-lp151.2.23 [ 7s] [166/170] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 7s] [167/170] cumulate systemd-234-lp151.25.7 [ 7s] [168/170] cumulate rpm-build-4.14.1-lp151.13.10 [ 7s] [169/170] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 7s] [170/170] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 7s] now installing cumulated packages [ 8s] Preparing... ######################################## [ 8s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 8s] exit ... [ 8s] ### VM INTERACTION START ### [ 11s] [ 6.367514] sysrq: SysRq : Power Off [ 11s] [ 6.371753] reboot: Power down [ 11s] ### VM INTERACTION END ### [ 11s] [ 11s] goat19 failed "build osmo-smlc.spec" at Fri Dec 24 01:39:28 UTC 2021. [ 11s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:39:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:39:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c524f74eb96_196b2ab2434446002606e3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-smlc failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 9s] [154/171] cumulate libosmoctrl0-1.6.0-lp152.1.1 [ 9s] [155/171] cumulate libosmonetif8-1.1.0-lp152.2.2 [ 9s] [156/171] cumulate pam-1.3.0-lp152.10.25 [ 9s] [157/171] cumulate gcc-PIE-7-lp152.4.114 [ 9s] [158/171] cumulate libosmonetif-devel-1.1.0-lp152.2.2 [ 9s] [159/171] cumulate libosmoctrl-devel-1.6.0-lp152.1.1 [ 9s] [160/171] cumulate libosmo-sigtran7-1.5.0-lp152.1.1 [ 9s] [161/171] cumulate shadow-4.6-lp152.3.80 [ 9s] [162/171] cumulate sysuser-shadow-2.0-lp152.4.114 [ 9s] [163/171] cumulate libosmo-sigtran-devel-1.5.0-lp152.1.1 [ 9s] [164/171] cumulate system-group-hardware-20170617-lp152.5.114 [ 9s] [165/171] cumulate libutempter0-1.1.6-lp152.5.114 [ 9s] [166/171] cumulate util-linux-2.33.1-lp152.4.78 [ 9s] [167/171] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 9s] [168/171] cumulate systemd-234-lp152.30.1 [ 9s] [169/171] cumulate rpm-build-4.14.1-lp152.17.5 [ 9s] [170/171] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 9s] [171/171] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 9s] now installing cumulated packages [ 9s] Preparing... ######################################## [ 9s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 9s] exit ... [ 9s] ### VM INTERACTION START ### [ 12s] [ 7.378797] sysrq: Power Off [ 12s] [ 7.381588] reboot: Power down [ 12s] ### VM INTERACTION END ### [ 12s] [ 12s] goat17 failed "build osmo-smlc.spec" at Fri Dec 24 01:39:29 UTC 2021. [ 12s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:40:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:40:48 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c52536db47e_196b2ab2434446002609c6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-cbc failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 40s] [170/187] cumulate libosmonetif8-1.1.0-lp151.2.2 [ 40s] [171/187] cumulate libulfius2_5-2.5.4-lp151.1.2 [ 40s] [172/187] cumulate libgnutls-devel-3.6.7-lp151.1.1 [ 40s] [173/187] cumulate pam-1.3.0-lp151.7.2 [ 40s] [174/187] cumulate gcc-PIE-7-lp151.3.2 [ 40s] [175/187] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 40s] [176/187] cumulate libmicrohttpd-devel-0.9.57-lp151.2.3 [ 40s] [177/187] cumulate shadow-4.6-lp151.1.2 [ 40s] [178/187] cumulate sysuser-shadow-2.0-lp151.3.3 [ 40s] [179/187] cumulate ulfius-devel-2.5.4-lp151.1.2 [ 40s] [180/187] cumulate system-group-hardware-20170617-lp151.4.3 [ 40s] [181/187] cumulate libutempter0-1.1.6-lp151.4.3 [ 40s] [182/187] cumulate util-linux-2.33.1-lp151.2.2 [ 40s] [183/187] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 40s] [184/187] cumulate systemd-234-lp151.25.2 [ 40s] [185/187] cumulate rpm-build-4.14.1-lp151.13.2 [ 40s] [186/187] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 40s] [187/187] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 40s] now installing cumulated packages [ 40s] Preparing... ######################################## [ 40s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 40s] exit ... [ 40s] ### VM INTERACTION START ### [ 43s] [ 9.007189] sysrq: SysRq : Power Off [ 43s] [ 9.007949] reboot: Power down [ 43s] ### VM INTERACTION END ### [ 43s] [ 43s] obs-arm-10 failed "build osmo-cbc.spec" at Fri Dec 24 01:40:47 UTC 2021. [ 43s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:41:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:41:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c5257018a1e_196b2ab2434446002611f1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 14s] [164/179] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 14s] [165/179] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 14s] [166/179] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 14s] [167/179] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 14s] [168/179] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 14s] [169/179] cumulate shadow-4.6-lp151.1.27 [ 14s] [170/179] cumulate sysuser-shadow-2.0-lp151.3.70 [ 14s] [171/179] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 4.113094] serial8250: too much work for irq4 [ 14s] [ 14s] [172/179] cumulate system-group-hardware-20170617-lp151.4.70 [ 14s] [173/179] cumulate libutempter0-1.1.6-lp151.4.70 [ 14s] [174/179] cumulate util-linux-2.33.1-lp151.2.23 [ 14s] [175/179] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 14s] [176/179] cumulate systemd-234-lp151.25.7 [ 14s] [177/179] cumulate rpm-build-4.14.1-lp151.13.10 [ 14s] [178/179] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 14s] [179/179] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 14s] now installing cumulated packages [ 14s] Preparing... ######################################## [ 14s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 14s] exit ... [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.417452] sysrq: SysRq : Power Off [ 17s] [ 7.420530] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] lamb12 failed "build osmo-bsc.spec" at Fri Dec 24 01:41:33 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:41:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:41:57 +0000 Subject: Build failure of network:osmocom:latest/osmo-hnodeb in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c525719f310_196b2ab2434446002612ec@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hnodeb/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-hnodeb failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hnodeb Last lines of build log: [ 17s] [171/188] cumulate libosmonetif-devel-1.1.0-lp152.2.2 [ 17s] [172/188] cumulate libosmoabis-devel-1.2.0-lp152.1.1 [ 17s] [173/188] cumulate libosmoctrl-devel-1.6.0-lp152.1.1 [ 17s] [174/188] cumulate libosmogb-devel-1.6.0-lp152.1.1 [ 17s] [175/188] cumulate libosmo-sigtran7-1.5.0-lp152.1.1 [ 17s] [176/188] cumulate shadow-4.6-lp152.3.80 [ 17s] [177/188] cumulate sysuser-shadow-2.0-lp152.4.114 [ 17s] [178/188] cumulate libosmo-sigtran-devel-1.5.0-lp152.1.1 [ 17s] [179/188] cumulate libosmo-ranap5-1.1.0-lp152.1.1 [ 17s] [180/188] cumulate libosmo-ranap-devel-1.1.0-lp152.1.1 [ 17s] [181/188] cumulate system-group-hardware-20170617-lp152.5.114 [ 17s] [182/188] cumulate libutempter0-1.1.6-lp152.5.114 [ 17s] [183/188] cumulate util-linux-2.33.1-lp152.4.78 [ 17s] [184/188] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 17s] [185/188] cumulate systemd-234-lp152.30.1 [ 17s] [186/188] cumulate rpm-build-4.14.1-lp152.17.5 [ 17s] [187/188] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 17s] [188/188] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 17s] now installing cumulated packages [ 18s] Preparing... ######################################## [ 18s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 18s] exit ... [ 18s] ### VM INTERACTION START ### [ 21s] [ 9.757395] sysrq: Power Off [ 21s] [ 9.769918] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb56 failed "build osmo-hnodeb.spec" at Fri Dec 24 01:41:41 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:43:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:43:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c525ab8f3d3_196b2ab243444600261662@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-smlc failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 12s] [150/167] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 12s] [151/167] cumulate libosmonetif8-1.1.0-lp151.2.2 [ 12s] [152/167] cumulate pam-1.3.0-lp151.7.2 [ 12s] [153/167] cumulate gcc-PIE-7-lp151.3.2 [ 12s] [154/167] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 12s] [155/167] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 12s] [156/167] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 12s] [157/167] cumulate shadow-4.6-lp151.1.2 [ 12s] [158/167] cumulate sysuser-shadow-2.0-lp151.3.3 [ 12s] [159/167] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 12s] [160/167] cumulate system-group-hardware-20170617-lp151.4.3 [ 12s] [161/167] cumulate libutempter0-1.1.6-lp151.4.3 [ 12s] [162/167] cumulate util-linux-2.33.1-lp151.2.2 [ 12s] [163/167] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 12s] [164/167] cumulate systemd-234-lp151.25.2 [ 12s] [165/167] cumulate rpm-build-4.14.1-lp151.13.2 [ 12s] [166/167] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 12s] [167/167] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 12s] now installing cumulated packages [ 12s] Preparing... ######################################## [ 12s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 13s] exit ... [ 13s] ### VM INTERACTION START ### [ 16s] [ 8.750178] sysrq: SysRq : Power Off [ 16s] [ 8.751142] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] obs-arm-11 failed "build osmo-smlc.spec" at Fri Dec 24 01:42:50 UTC 2021. [ 16s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:43:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:43:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c525aea2310_196b2ab243444600261732@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-iuh failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 35s] [157/174] cumulate python3-base-3.6.5-lp151.5.1 [ 35s] [158/174] cumulate gcc-PIE-7-lp151.3.2 [ 35s] [159/174] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 35s] [160/174] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 35s] [161/174] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 35s] [162/174] cumulate python3-3.6.5-lp151.5.1 [ 35s] [163/174] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 35s] [164/174] cumulate shadow-4.6-lp151.1.2 [ 35s] [165/174] cumulate sysuser-shadow-2.0-lp151.3.3 [ 35s] [166/174] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 35s] [167/174] cumulate system-group-hardware-20170617-lp151.4.3 [ 35s] [168/174] cumulate libutempter0-1.1.6-lp151.4.3 [ 35s] [169/174] cumulate util-linux-2.33.1-lp151.2.2 [ 35s] [170/174] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 35s] [171/174] cumulate systemd-234-lp151.25.2 [ 35s] [172/174] cumulate rpm-build-4.14.1-lp151.13.2 [ 35s] [173/174] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 35s] [174/174] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 35s] now installing cumulated packages [ 35s] Preparing... ######################################## [ 35s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 36s] exit ... [ 36s] ### VM INTERACTION START ### [ 39s] [ 13.987126] sysrq: SysRq : Power Off [ 39s] [ 13.999728] reboot: Power down [ 39s] ### VM INTERACTION END ### [ 39s] [ 39s] armbuild02 failed "build osmo-iuh.spec" at Fri Dec 24 01:42:52 UTC 2021. [ 39s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:43:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:43:57 +0000 Subject: Build failure of network:osmocom:latest/osmo-hnodeb in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c525e82a8e1_196b2ab243444600262049@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hnodeb/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-hnodeb failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hnodeb Last lines of build log: [ 13s] [171/187] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 13s] [172/187] cumulate libosmoct[ 3.818200] serial8250: too much work for irq4 [ 13s] rl-devel-1.6.0-lp151.1.1 [ 13s] [173/187] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 13s] [174/187] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 13s] [175/187] cumulate shadow-4.6-lp151.1.27 [ 13s] [176/187] cumulate sysuser-shadow-2.0-lp151.3.70 [ 13s] [177/187] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 13s] [178/187] cumulate libosmo-ranap5-1.1.0-lp151.1.1 [ 13s] [179/187] cumulate libosmo-ranap-devel-1.1.0-lp151.1.1 [ 13s] [180/187] cumulate system-group-hardware-20170617-lp151.4.70 [ 13s] [181/187] cumulate libutempter0-1.1.6-lp151.4.70 [ 13s] [182/187] cumulate util-linux-2.33.1-lp151.2.23 [ 13s] [183/187] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 13s] [184/187] cumulate systemd-234-lp151.25.7 [ 13s] [185/187] cumulate rpm-build-4.14.1-lp151.13.10 [ 13s] [186/187] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 13s] [187/187] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 13s] now installing cumulated packages [ 13s] Preparing... ######################################## [ 13s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 14s] exit ... [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.164660] sysrq: SysRq : Power Off [ 17s] [ 7.168645] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] lamb56 failed "build osmo-hnodeb.spec" at Fri Dec 24 01:43:45 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:43:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:43:57 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c525e7dbf05_196b2ab2434446002619a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-msc failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 21s] [175/192] cumulate libosmo-gsup-client0-1.4.0-lp152.1.1 [ 21s] [176/192] cumulate libosmoabis-devel-1.2.0-lp152.1.1 [ 21s] [177/192] cumulate libosmoctrl-devel-1.6.0-lp152.1.1 [ 21s] [178/192] cumulate libosmo-sigtran7-1.5.0-lp152.1.1 [ 21s] [179/192] cumulate shadow-4.6-lp152.3.80 [ 21s] [180/192] cumulate sysuser-shadow-2.0-lp152.4.114 [ 21s] [181/192] cumulate libosmo-sigtran-devel-1.5.0-lp152.1.1 [ 21s] [182/192] cumulate libosmo-gsup-client-devel-1.4.0-lp152.1.1 [ 21s] [183/192] cumulate libosmo-ranap5-1.1.0-lp152.1.1 [ 21s] [184/192] cumulate libosmo-ranap-devel-1.1.0-lp152.1.1 [ 21s] [185/192] cumulate system-group-hardware-20170617-lp152.5.114 [ 21s] [186/192] cumulate libutempter0-1.1.6-lp152.5.114 [ 21s] [187/192] cumulate util-linux-2.33.1-lp152.4.78 [ 21s] [188/192] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 21s] [189/192] cumulate systemd-234-lp152.30.1 [ 21s] [190/192] cumulate rpm-build-4.14.1-lp152.17.5 [ 21s] [191/192] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 21s] [192/192] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 21s] now installing cumulated packages [ 21s] Preparing... ######################################## [ 21s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 21s] exit ... [ 21s] ### VM INTERACTION START ### [ 25s] [ 10.081809] sysrq: Power Off [ 25s] [ 10.087332] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] hci-cnode2-m0 failed "build osmo-msc.spec" at Fri Dec 24 01:43:56 UTC 2021. [ 25s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:45:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:45:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-hnodeb in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c52626d8f48_196b2ab243444600262112@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hnodeb/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-hnodeb failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hnodeb Last lines of build log: [ 18s] [167/184] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 18s] [168/184] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 18s] [169/184] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 18s] [170/184] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 18s] [171/184] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 18s] [172/184] cumulate shadow-4.6-lp151.1.2 [ 18s] [173/184] cumulate sysuser-shadow-2.0-lp151.3.3 [ 18s] [174/184] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 18s] [175/184] cumulate libosmo-ranap5-1.1.0-lp151.1.1 [ 18s] [176/184] cumulate libosmo-ranap-devel-1.1.0-lp151.1.1 [ 18s] [177/184] cumulate system-group-hardware-20170617-lp151.4.3 [ 18s] [178/184] cumulate libutempter0-1.1.6-lp151.4.3 [ 18s] [179/184] cumulate util-linux-2.33.1-lp151.2.2 [ 18s] [180/184] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 18s] [181/184] cumulate systemd-234-lp151.25.2 [ 18s] [182/184] cumulate rpm-build-4.14.1-lp151.13.2 [ 18s] [183/184] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 18s] [184/184] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 18s] now installing cumulated packages [ 18s] Preparing... ######################################## [ 18s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 18s] exit ... [ 18s] ### VM INTERACTION START ### [ 21s] [ 8.608846] sysrq: SysRq : Power Off [ 21s] [ 8.609463] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] obs-arm-11 failed "build osmo-hnodeb.spec" at Fri Dec 24 01:44:58 UTC 2021. [ 21s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:45:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:45:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c5265fa4b1a_196b2ab2434446002623bb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 14s] [163/180] cumulate pam-1.3.0-lp152.10.25 [ 14s] [164/180] cumulate gcc-PIE-7-lp152.4.114 [ 14s] [165/180] cumulate libosmonetif-devel-1.1.0-lp152.2.2 [ 14s] [166/180] cumulate libosmoabis-devel-1.2.0-lp152.1.1 [ 14s] [167/180] cumulate libosmoctrl-devel-1.6.0-lp152.1.1 [ 14s] [168/180] cumulate libosmogb-devel-1.6.0-lp152.1.1 [ 14s] [169/180] cumulate libosmo-sigtran7-1.5.0-lp152.1.1 [ 14s] [170/180] cumulate shadow-4.6-lp152.3.80 [ 14s] [171/180] cumulate sysuser-shadow-2.0-lp152.4.114 [ 14s] [172/180] cumulate libosmo-sigtran-devel-1.5.0-lp152.1.1 [ 14s] [173/180] cumulate system-group-hardware-20170617-lp152.5.114 [ 14s] [174/180] cumulate libutempter0-1.1.6-lp152.5.114 [ 14s] [175/180] cumulate util-linux-2.33.1-lp152.4.78 [ 14s] [176/180] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 14s] [177/180] cumulate systemd-234-lp152.30.1 [ 14s] [178/180] cumulate rpm-build-4.14.1-lp152.17.5 [ 14s] [179/180] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 14s] [180/180] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 14s] now installing cumulated packages [ 14s] Preparing... ######################################## [ 14s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 14s] exit ... [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.837077] sysrq: Power Off [ 17s] [ 7.839470] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] goat11 failed "build osmo-bsc.spec" at Fri Dec 24 01:45:31 UTC 2021. [ 17s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:46:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:46:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c526803d65d_196b2ab243444600262557@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-msc failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 37s] [175/191] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 37s] [176/191] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 37s] [177/191] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 37s] [178/191] cumulate shadow-4.6-lp151.1.27 [ 37s] [179/1[ 7.732344] serial8250: too much work for irq4 [ 37s] 91] cumulate sysuser-shadow-2.0-lp151.3.70 [ 37s] [180/191] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 37s] [181/191] cumulate libosmo-gsup-client-devel-1.4.0-lp151.1.1 [ 37s] [182/191] cumulate libosmo-ranap5-1.1.0-lp151.1.1 [ 37s] [183/191] cumulate libosmo-ranap-devel-1.1.0-lp151.1.1 [ 37s] [184/191] cumulate system-group-hardware-20170617-lp151.4.70 [ 38s] [185/191] cumulate libutempter0-1.1.6-lp151.4.70 [ 38s] [186/191] cumulate util-linux-2.33.1-lp151.2.23 [ 38s] [187/191] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 38s] [188/191] cumulate systemd-234-lp151.25.7 [ 38s] [189/191] cumulate rpm-build-4.14.1-lp151.13.10 [ 38s] [190/191] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 38s] [191/191] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 38s] now installing cumulated packages [ 38s] Preparing... ######################################## [ 38s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 38s] exit ... [ 38s] ### VM INTERACTION START ### [ 41s] [ 11.320098] sysrq: SysRq : Power Off [ 41s] [ 11.482165] reboot: Power down [ 41s] ### VM INTERACTION END ### [ 41s] [ 41s] lamb26 failed "build osmo-msc.spec" at Fri Dec 24 01:46:06 UTC 2021. [ 41s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:47:57 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:47:57 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c526d6d8621_196b2ab2434446002633bf@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 20s] [171/187] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 20s] [172/187] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 20s] [173/187] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 20s] [174/187] cumulate shadow-4.6[ 5.516186] serial8250: too much work for irq4 [ 20s] -lp151.1.27 [ 20s] [175/187] cumulate sysuser-shadow-2.0-lp151.3.70 [ 20s] [176/187] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 20s] [177/187] cumulate libosmo-gsup-client-devel-1.4.0-lp151.1.1 [ 20s] [178/187] cumulate libosmo-ranap5-1.1.0-lp151.1.1 [ 20s] [179/187] cumulate libosmo-ranap-devel-1.1.0-lp151.1.1 [ 20s] [180/187] cumulate system-group-hardware-20170617-lp151.4.70 [ 20s] [181/187] cumulate libutempter0-1.1.6-lp151.4.70 [ 20s] [182/187] cumulate util-linux-2.33.1-lp151.2.23 [ 20s] [183/187] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 20s] [184/187] cumulate systemd-234-lp151.25.7 [ 20s] [185/187] cumulate rpm-build-4.14.1-lp151.13.10 [ 20s] [186/187] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 20s] [187/187] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 20s] now installing cumulated packages [ 20s] Preparing... ######################################## [ 20s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.7.x86_64 and libsystemd0-mini-234-lp151.25.1.x86_64 [ 21s] exit ... [ 21s] ### VM INTERACTION START ### [ 24s] [ 9.139526] sysrq: SysRq : Power Off [ 24s] [ 9.158516] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb03 failed "build osmo-sgsn.spec" at Fri Dec 24 01:47:53 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:49:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:49:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c52715e6e00_196b2ab2434446002635cb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 74s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp152.30.1.x86_64 and systemd-234-lp152.30.1.x86_64 [ 74s] exit ... [ 74s] ### VM INTERACTION START ### [ 77s] [ 16.923668] sysrq: Power Off [ 77s] [ 16.973116] reboot: Power down [ 78s] ### VM INTERACTION END ### [ 78s] [ 78s] lamb24 failed "build osmo-remsim.spec" at Fri Dec 24 01:48:55 UTC 2021. [ 78s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:49:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:49:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c52716653ca_196b2ab243444600263637@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-bsc failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 24s] [159/176] cumulate pam-1.3.0-lp151.7.2 [ 24s] [160/176] cumulate gcc-PIE-7-lp151.3.2 [ 24s] [161/176] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 24s] [162/176] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 24s] [163/176] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 24s] [164/176] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 24s] [165/176] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 24s] [166/176] cumulate shadow-4.6-lp151.1.2 [ 24s] [167/176] cumulate sysuser-shadow-2.0-lp151.3.3 [ 24s] [168/176] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 24s] [169/176] cumulate system-group-hardware-20170617-lp151.4.3 [ 24s] [170/176] cumulate libutempter0-1.1.6-lp151.4.3 [ 24s] [171/176] cumulate util-linux-2.33.1-lp151.2.2 [ 24s] [172/176] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 24s] [173/176] cumulate systemd-234-lp151.25.2 [ 24s] [174/176] cumulate rpm-build-4.14.1-lp151.13.2 [ 24s] [175/176] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 24s] [176/176] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 24s] now installing cumulated packages [ 24s] Preparing... ######################################## [ 24s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 24s] exit ... [ 24s] ### VM INTERACTION START ### [ 27s] [ 12.566909] sysrq: SysRq : Power Off [ 27s] [ 12.568702] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] obs-arm-9 failed "build osmo-bsc.spec" at Fri Dec 24 01:48:51 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:49:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:49:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in openSUSE_Leap_15.1/x86_64 In-Reply-To: References: Message-ID: <61c5274ebcd98_196b2ab2434446002638f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/openSUSE_Leap_15.1/x86_64 Package network:osmocom:latest/osmo-remsim failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 14s] file /usr/lib/system[ 4.057790] serial8250: too much work for irq4 [ 14s] d/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.1.x86_64 and systemd-234-lp151.25.7.x86_64 [ 14s] exit ... [ 14s] ### VM INTERACTION START ### [ 17s] [ 7.216591] sysrq: SysRq : Power Off [ 17s] [ 7.220497] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] lamb12 failed "build osmo-remsim.spec" at Fri Dec 24 01:49:37 UTC 2021. [ 18s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:49:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:49:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in openSUSE_Leap_15.2/x86_64 In-Reply-To: References: Message-ID: <61c5274fa4d78_196b2ab2434446002639e5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/openSUSE_Leap_15.2/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 9s] [171/188] cumulate libosmoabis-devel-1.2.0-lp152.1.1 [ 9s] [172/188] cumulate libosmoctrl-devel-1.6.0-lp152.1.1 [ 9s] [173/188] cumulate libosmogb-devel-1.6.0-lp152.1.1 [ 9s] [174/188] cumulate libosmo-sigtran7-1.5.0-lp152.1.1 [ 9s] [175/188] cumulate shadow-4.6-lp152.3.80 [ 9s] [176/188] cumulate sysuser-shadow-2.0-lp152.4.114 [ 9s] [177/188] cumulate libosmo-sigtran-devel-1.5.0-lp152.1.1 [ 9s] [178/188] cumulate libosmo-gsup-client-devel-1.4.0-lp152.1.1 [ 9s] [179/188] cumulate libosmo-ranap5-1.1.0-lp152.1.1 [ 9s] [180/188] cumulate libosmo-ranap-devel-1.1.0-lp152.1.1 [ 9s] [181/188] cumulate system-group-hardware-20170617-lp152.5.114 [ 9s] [182/188] cumulate libutempter0-1.1.6-lp152.5.114 [ 9s] [183/188] cumulate util-linux-2.33.1-lp152.4.78 [ 9s] [184/188] cumulate aaa_base-84.87+git20180409.04c9dae-lp152.13.1 [ 9s] [185/188] cumulate systemd-234-lp152.30.1 [ 9s] [186/188] cumulate rpm-build-4.14.1-lp152.17.5 [ 9s] [187/188] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp152.13.1 [ 9s] [188/188] cumulate post-build-checks-84.87+git20200110.2d02f07-lp152.1.1 [ 9s] now installing cumulated packages [ 9s] Preparing... ######################################## [ 9s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp152.30.1.x86_64 and libsystemd0-mini-234-lp152.30.1.x86_64 [ 10s] exit ... [ 10s] ### VM INTERACTION START ### [ 13s] [ 7.317950] sysrq: Power Off [ 13s] [ 7.319945] reboot: Power down [ 13s] ### VM INTERACTION END ### [ 13s] [ 13s] goat11 failed "build osmo-sgsn.spec" at Fri Dec 24 01:49:26 UTC 2021. [ 13s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:50:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:50:31 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c527709640f_196b2ab2434446002643bf@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-msc failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 25s] [171/188] cumulate libosmo-gsup-client0-1.4.0-lp151.1.1 [ 25s] [172/188] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 25s] [173/188] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 25s] [174/188] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 25s] [175/188] cumulate shadow-4.6-lp151.1.2 [ 25s] [176/188] cumulate sysuser-shadow-2.0-lp151.3.3 [ 25s] [177/188] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 25s] [178/188] cumulate libosmo-gsup-client-devel-1.4.0-lp151.1.1 [ 25s] [179/188] cumulate libosmo-ranap5-1.1.0-lp151.1.1 [ 25s] [180/188] cumulate libosmo-ranap-devel-1.1.0-lp151.1.1 [ 25s] [181/188] cumulate system-group-hardware-20170617-lp151.4.3 [ 25s] [182/188] cumulate libutempter0-1.1.6-lp151.4.3 [ 25s] [183/188] cumulate util-linux-2.33.1-lp151.2.2 [ 25s] [184/188] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 25s] [185/188] cumulate systemd-234-lp151.25.2 [ 25s] [186/188] cumulate rpm-build-4.14.1-lp151.13.2 [ 25s] [187/188] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 25s] [188/188] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 25s] now installing cumulated packages [ 25s] Preparing... ######################################## [ 25s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 25s] exit ... [ 25s] ### VM INTERACTION START ### [ 28s] [ 9.025980] sysrq: SysRq : Power Off [ 28s] [ 9.026791] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] obs-arm-11 failed "build osmo-msc.spec" at Fri Dec 24 01:50:14 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:52:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:52:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c527e522390_196b2ab243444600265151@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-remsim failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 24s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.2.aarch64 and systemd-234-lp151.25.2.aarch64 [ 24s] exit ... [ 24s] ### VM INTERACTION START ### [ 27s] [ 12.853750] sysrq: SysRq : Power Off [ 27s] [ 12.855695] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 28s] obs-arm-9 failed "build osmo-remsim.spec" at Fri Dec 24 01:52:09 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:53:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:53:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in openSUSE_Leap_15.1_ARM/aarch64 In-Reply-To: References: Message-ID: <61c5283f355b5_196b2ab243444600265499@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:latest/osmo-sgsn failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 21s] [167/184] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 21s] [168/184] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 21s] [169/184] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 21s] [170/184] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 21s] [171/184] cumulate shadow-4.6-lp151.1.2 [ 21s] [172/184] cumulate sysuser-shadow-2.0-lp151.3.3 [ 21s] [173/184] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 21s] [174/184] cumulate libosmo-gsup-client-devel-1.4.0-lp151.1.1 [ 21s] [175/184] cumulate libosmo-ranap5-1.1.0-lp151.1.1 [ 21s] [176/184] cumulate libosmo-ranap-devel-1.1.0-lp151.1.1 [ 21s] [177/184] cumulate system-group-hardware-20170617-lp151.4.3 [ 21s] [178/184] cumulate libutempter0-1.1.6-lp151.4.3 [ 21s] [179/184] cumulate util-linux-2.33.1-lp151.2.2 [ 21s] [180/184] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 21s] [181/184] cumulate systemd-234-lp151.25.2 [ 21s] [182/184] cumulate rpm-build-4.14.1-lp151.13.2 [ 21s] [183/184] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 21s] [184/184] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 21s] now installing cumulated packages [ 21s] Preparing... ######################################## [ 21s] file /usr/lib64/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.aarch64 and libsystemd0-mini-234-lp151.25.2.aarch64 [ 21s] exit ... [ 21s] ### VM INTERACTION START ### [ 24s] [ 11.560037] sysrq: SysRq : Power Off [ 24s] [ 11.562869] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] obs-arm-8 failed "build osmo-sgsn.spec" at Fri Dec 24 01:53:37 UTC 2021. [ 24s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 01:58:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 01:58:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c5294bcad23_196b2ab243444600267746@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-hlr failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 29s] [151/168] cumulate libosmoabis10-1.2.0-lp151.1.1 [ 29s] [152/168] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 29s] [153/168] cumulate pam-1.3.0-lp151.7.2 [ 29s] [154/168] cumulate python3-base-3.6.5-lp151.5.1 [ 29s] [155/168] cumulate gcc-PIE-7-lp151.3.2 [ 29s] [156/168] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 29s] [157/168] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 29s] [158/168] cumulate python3-3.6.5-lp151.5.1 [ 29s] [159/168] cumulate shadow-4.6-lp151.1.2 [ 29s] [160/168] cumulate sysuser-shadow-2.0-lp151.3.3 [ 29s] [161/168] cumulate system-group-hardware-20170617-lp151.4.3 [ 29s] [162/168] cumulate libutempter0-1.1.6-lp151.4.3 [ 29s] [163/168] cumulate util-linux-2.33.1-lp151.2.2 [ 29s] [164/168] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 29s] [165/168] cumulate systemd-234-lp151.25.2 [ 29s] [166/168] cumulate rpm-build-4.14.1-lp151.13.2 [ 29s] [167/168] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 29s] [168/168] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 29s] now installing cumulated packages [ 29s] Preparing... ######################################## [ 29s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 30s] exit ... [ 30s] ### VM INTERACTION START ### [ 33s] [ 15.620878] sysrq: SysRq : Power Off [ 33s] [ 15.714118] reboot: Power down [ 33s] ### VM INTERACTION END ### [ 33s] [ 33s] armbuild24 failed "build osmo-hlr.spec" at Fri Dec 24 01:57:59 UTC 2021. [ 33s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:13:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:13:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c52cf23f1d7_196b2ab243444600272740@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-mgw failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 31s] [157/174] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 31s] [158/174] cumulate libosmonetif8-1.1.0-lp151.2.2 [ 31s] [159/174] cumulate pam-1.3.0-lp151.7.2 [ 31s] [160/174] cumulate gcc-PIE-7-lp151.3.2 [ 31s] [161/174] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 31s] [162/174] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 31s] [163/174] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 31s] [164/174] cumulate libosmocoding-devel-1.6.0-lp151.1.1 [ 31s] [165/174] cumulate shadow-4.6-lp151.1.2 [ 31s] [166/174] cumulate sysuser-shadow-2.0-lp151.3.3 [ 31s] [167/174] cumulate system-group-hardware-20170617-lp151.4.3 [ 31s] [168/174] cumulate libutempter0-1.1.6-lp151.4.3 [ 31s] [169/174] cumulate util-linux-2.33.1-lp151.2.2 [ 31s] [170/174] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 31s] [171/174] cumulate systemd-234-lp151.25.2 [ 31s] [172/174] cumulate rpm-build-4.14.1-lp151.13.2 [ 31s] [173/174] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 31s] [174/174] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 31s] now installing cumulated packages [ 32s] Preparing... ######################################## [ 32s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 32s] exit ... [ 32s] ### VM INTERACTION START ### [ 35s] [ 12.783117] sysrq: SysRq : Power Off [ 35s] [ 12.784615] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] armbuild02 failed "build osmo-mgw.spec" at Fri Dec 24 02:13:28 UTC 2021. [ 35s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:17:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:17:40 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c52de12faf2_196b2ab2434446002737ac@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/simtrace2 failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 27s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 27s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 27s] exit ... [ 27s] ### VM INTERACTION START ### [ 31s] [ 12.547380] sysrq: SysRq : Power Off [ 31s] [ 12.548872] reboot: Power down [ 31s] ### VM INTERACTION END ### [ 31s] [ 31s] armbuild01 failed "build simtrace2.spec" at Fri Dec 24 02:17:37 UTC 2021. [ 31s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:23:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:23:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c52f0d3dcb9_196b2ab2434446002760ab@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-ggsn failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 23s] [144/161] cumulate gcc7-7.4.0+r266845-lp151.1.3 [ 23s] [145/161] cumulate gcc-7-lp151.3.2 [ 23s] [146/161] cumulate hostname-3.16-lp151.2.3 [ 23s] [147/161] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 23s] [148/161] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 23s] [149/161] cumulate pam-1.3.0-lp151.7.2 [ 23s] [150/161] cumulate gcc-PIE-7-lp151.3.2 [ 23s] [151/161] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 23s] [152/161] cumulate shadow-4.6-lp151.1.2 [ 23s] [153/161] cumulate sysuser-shadow-2.0-lp151.3.3 [ 23s] [154/161] cumulate system-group-hardware-20170617-lp151.4.3 [ 23s] [155/161] cumulate libutempter0-1.1.6-lp151.4.3 [ 23s] [156/161] cumulate util-linux-2.33.1-lp151.2.2 [ 23s] [157/161] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 23s] [158/161] cumulate systemd-234-lp151.25.2 [ 23s] [159/161] cumulate rpm-build-4.14.1-lp151.13.2 [ 23s] [160/161] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 23s] [161/161] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 23s] now installing cumulated packages [ 23s] Preparing... ######################################## [ 23s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 24s] exit ... [ 24s] ### VM INTERACTION START ### [ 27s] [ 11.123725] sysrq: SysRq : Power Off [ 27s] [ 11.127217] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] armbuild01 failed "build osmo-ggsn.spec" at Fri Dec 24 02:22:59 UTC 2021. [ 27s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:24:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:24:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c52f66529fa_196b2ab2434446002762c8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-trx failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 30s] [190/207] cumulate libboost_regex1_66_0-devel-1.66.0-lp151.4.3 [ 30s] [191/207] cumulate libboost_serialization1_66_0-devel-1.66.0-lp151.4.3 [ 30s] [192/207] cumulate libboost_system1_66_0-devel-1.66.0-lp151.4.3 [ 30s] [193/207] cumulate libboost_test1_66_0-devel-1.66.0-lp151.4.3 [ 30s] [194/207] cumulate sysuser-shadow-2.0-lp151.3.3 [ 30s] [195/207] cumulate libboost_date_time1_66_0-devel-1.66.0-lp151.4.3 [ 30s] [196/207] cumulate libuhd003-3.9.7-lp151.4.3 [ 30s] [197/207] cumulate system-group-hardware-20170617-lp151.4.3 [ 30s] [198/207] cumulate libboost_filesystem1_66_0-devel-1.66.0-lp151.4.3 [ 30s] [199/207] cumulate libboost_thread1_66_0-devel-1.66.0-lp151.4.3 [ 30s] [200/207] cumulate libutempter0-1.1.6-lp151.4.3 [ 30s] [201/207] cumulate uhd-devel-3.9.7-lp151.4.3 [ 30s] [202/207] cumulate util-linux-2.33.1-lp151.2.2 [ 30s] [203/207] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 30s] [204/207] cumulate systemd-234-lp151.25.2 [ 30s] [205/207] cumulate rpm-build-4.14.1-lp151.13.2 [ 30s] [206/207] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 30s] [207/207] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 30s] now installing cumulated packages [ 30s] Preparing... ######################################## [ 30s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 31s] exit ... [ 31s] ### VM INTERACTION START ### [ 34s] [ 17.729463] sysrq: SysRq : Power Off [ 34s] [ 17.751987] reboot: Power down [ 34s] ### VM INTERACTION END ### [ 34s] [ 34s] armbuild21 failed "build osmo-trx.spec" at Fri Dec 24 02:24:08 UTC 2021. [ 34s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:28:15 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:28:15 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c530556ab42_196b2ab24344460027704c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-sip-connector failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 30s] [167/184] cumulate libopenssl-1_1-devel-1.1.0i-lp151.7.2 [ 30s] [168/184] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 30s] [169/184] cumulate pam-1.3.0-lp151.7.2 [ 30s] [170/184] cumulate python3-base-3.6.5-lp151.5.1 [ 30s] [171/184] cumulate gcc-PIE-7-lp151.3.2 [ 30s] [172/184] cumulate pcre-devel-8.41-lp151.5.3 [ 30s] [173/184] cumulate shadow-4.6-lp151.1.2 [ 30s] [174/184] cumulate sysuser-shadow-2.0-lp151.3.3 [ 30s] [175/184] cumulate glib2-devel-2.54.3-lp151.6.2 [ 30s] [176/184] cumulate system-group-hardware-20170617-lp151.4.3 [ 30s] [177/184] cumulate sofia-sip-devel-1.12.11-lp151.2.3 [ 30s] [178/184] cumulate libutempter0-1.1.6-lp151.4.3 [ 30s] [179/184] cumulate util-linux-2.33.1-lp151.2.2 [ 30s] [180/184] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 30s] [181/184] cumulate systemd-234-lp151.25.2 [ 30s] [182/184] cumulate rpm-build-4.14.1-lp151.13.2 [ 30s] [183/184] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 30s] [184/184] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 30s] now installing cumulated packages [ 30s] Preparing... ######################################## [ 30s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 31s] exit ... [ 31s] ### VM INTERACTION START ### [ 34s] [ 14.803664] sysrq: SysRq : Power Off [ 34s] [ 14.816377] reboot: Power down [ 34s] ### VM INTERACTION END ### [ 34s] [ 34s] armbuild01 failed "build osmo-sip-connector.spec" at Fri Dec 24 02:28:12 UTC 2021. [ 34s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:34:14 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:34:14 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcap in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c531bcbc1e4_196b2ab2434446002790b7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcap/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-pcap failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-pcap Last lines of build log: [ 30s] [157/174] cumulate gcc-7-lp151.3.2 [ 30s] [158/174] cumulate hostname-3.16-lp151.2.3 [ 30s] [159/174] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 30s] [160/174] cumulate libgnutls-devel-3.6.7-lp151.1.1 [ 30s] [161/174] cumulate libosmogb12-1.6.0-lp151.1.1 [ 30s] [162/174] cumulate pam-1.3.0-lp151.7.2 [ 30s] [163/174] cumulate gcc-PIE-7-lp151.3.2 [ 30s] [164/174] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 30s] [165/174] cumulate shadow-4.6-lp151.1.2 [ 30s] [166/174] cumulate sysuser-shadow-2.0-lp151.3.3 [ 30s] [167/174] cumulate system-group-hardware-20170617-lp151.4.3 [ 30s] [168/174] cumulate libutempter0-1.1.6-lp151.4.3 [ 30s] [169/174] cumulate util-linux-2.33.1-lp151.2.2 [ 30s] [170/174] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 30s] [171/174] cumulate systemd-234-lp151.25.2 [ 30s] [172/174] cumulate rpm-build-4.14.1-lp151.13.2 [ 30s] [173/174] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 30s] [174/174] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 30s] now installing cumulated packages [ 31s] Preparing... ######################################## [ 31s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 32s] exit ... [ 32s] ### VM INTERACTION START ### [ 35s] [ 17.192871] sysrq: SysRq : Power Off [ 35s] [ 17.265217] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] armbuild24 failed "build osmo-pcap.spec" at Fri Dec 24 02:34:12 UTC 2021. [ 35s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:36:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:36:31 +0000 Subject: Build failure of network:osmocom:latest/osmo-gbproxy in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c53238e2160_196b2ab2434446002802da@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gbproxy/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-gbproxy failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-gbproxy Last lines of build log: [ 22s] [149/166] cumulate libopenssl-1_1-devel-1.1.0i-lp151.7.2 [ 22s] [150/166] cumulate libosmogsm-devel-1.6.0-lp151.1.1 [ 22s] [151/166] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 22s] [152/166] cumulate libosmogb12-1.6.0-lp151.1.1 [ 22s] [153/166] cumulate pam-1.3.0-lp151.7.2 [ 22s] [154/166] cumulate gcc-PIE-7-lp151.3.2 [ 22s] [155/166] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 22s] [156/166] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 22s] [157/166] cumulate shadow-4.6-lp151.1.2 [ 22s] [158/166] cumulate sysuser-shadow-2.0-lp151.3.3 [ 22s] [159/166] cumulate system-group-hardware-20170617-lp151.4.3 [ 22s] [160/166] cumulate libutempter0-1.1.6-lp151.4.3 [ 22s] [161/166] cumulate util-linux-2.33.1-lp151.2.2 [ 22s] [162/166] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 22s] [163/166] cumulate systemd-234-lp151.25.2 [ 22s] [164/166] cumulate rpm-build-4.14.1-lp151.13.2 [ 22s] [165/166] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 22s] [166/166] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 22s] now installing cumulated packages [ 22s] Preparing... ######################################## [ 22s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 23s] exit ... [ 23s] ### VM INTERACTION START ### [ 26s] [ 11.426334] sysrq: SysRq : Power Off [ 26s] [ 11.440139] reboot: Power down [ 26s] ### VM INTERACTION END ### [ 26s] [ 26s] armbuild22 failed "build osmo-gbproxy.spec" at Fri Dec 24 02:36:16 UTC 2021. [ 26s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:39:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:39:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c532cec3687_196b2ab2434446002808d6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-pcu failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 28s] [147/164] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 28s] [148/164] cumulate gcc7-c++-7.4.0+r266845-lp151.1.3 [ 28s] [149/164] cumulate libosmogb12-1.6.0-lp151.1.1 [ 28s] [150/164] cumulate pam-1.3.0-lp151.7.2 [ 28s] [151/164] cumulate gcc-PIE-7-lp151.3.2 [ 28s] [152/164] cumulate gcc-c++-7-lp151.3.2 [ 28s] [153/164] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 28s] [154/164] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 28s] [155/164] cumulate shadow-4.6-lp151.1.2 [ 28s] [156/164] cumulate sysuser-shadow-2.0-lp151.3.3 [ 28s] [157/164] cumulate system-group-hardware-20170617-lp151.4.3 [ 28s] [158/164] cumulate libutempter0-1.1.6-lp151.4.3 [ 28s] [159/164] cumulate util-linux-2.33.1-lp151.2.2 [ 28s] [160/164] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 28s] [161/164] cumulate systemd-234-lp151.25.2 [ 28s] [162/164] cumulate rpm-build-4.14.1-lp151.13.2 [ 28s] [163/164] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 28s] [164/164] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 28s] now installing cumulated packages [ 28s] Preparing... ######################################## [ 29s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 29s] exit ... [ 29s] ### VM INTERACTION START ### [ 32s] [ 13.932466] sysrq: SysRq : Power Off [ 32s] [ 13.952906] reboot: Power down [ 32s] ### VM INTERACTION END ### [ 32s] [ 32s] armbuild01 failed "build osmo-pcu.spec" at Fri Dec 24 02:39:05 UTC 2021. [ 32s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:41:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:41:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c533618bc4d_196b2ab2434446002810f1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-bts failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 38s] [157/174] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 38s] [158/174] cumulate libosmogb12-1.6.0-lp151.1.1 [ 38s] [159/174] cumulate pam-1.3.0-lp151.7.2 [ 38s] [160/174] cumulate gcc-PIE-7-lp151.3.2 [ 38s] [161/174] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 38s] [162/174] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 38s] [163/174] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 38s] [164/174] cumulate libosmocoding-devel-1.6.0-lp151.1.1 [ 38s] [165/174] cumulate shadow-4.6-lp151.1.2 [ 38s] [166/174] cumulate sysuser-shadow-2.0-lp151.3.3 [ 38s] [167/174] cumulate system-group-hardware-20170617-lp151.4.3 [ 38s] [168/174] cumulate libutempter0-1.1.6-lp151.4.3 [ 38s] [169/174] cumulate util-linux-2.33.1-lp151.2.2 [ 38s] [170/174] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 38s] [171/174] cumulate systemd-234-lp151.25.2 [ 38s] [172/174] cumulate rpm-build-4.14.1-lp151.13.2 [ 38s] [173/174] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 38s] [174/174] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 38s] now installing cumulated packages [ 38s] Preparing... ######################################## [ 38s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 39s] exit ... [ 39s] ### VM INTERACTION START ### [ 42s] [ 14.088945] sysrq: SysRq : Power Off [ 42s] [ 14.090670] reboot: Power down [ 42s] ### VM INTERACTION END ### [ 42s] [ 42s] armbuild02 failed "build osmo-bts.spec" at Fri Dec 24 02:40:56 UTC 2021. [ 42s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:42:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:42:31 +0000 Subject: Build failure of network:osmocom:latest/osmo-cbc in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c5339e37b74_196b2ab243444600281582@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-cbc/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-cbc failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-cbc Last lines of build log: [ 23s] [168/185] cumulate libosmonetif8-1.1.0-lp151.2.2 [ 23s] [169/185] cumulate libgnutls-devel-3.6.7-lp151.1.1 [ 23s] [170/185] cumulate libulfius2_5-2.5.4-lp151.1.2 [ 23s] [171/185] cumulate pam-1.3.0-lp151.7.2 [ 23s] [172/185] cumulate gcc-PIE-7-lp151.3.2 [ 23s] [173/185] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 23s] [174/185] cumulate libmicrohttpd-devel-0.9.57-lp151.2.3 [ 23s] [175/185] cumulate shadow-4.6-lp151.1.2 [ 23s] [176/185] cumulate sysuser-shadow-2.0-lp151.3.3 [ 23s] [177/185] cumulate ulfius-devel-2.5.4-lp151.1.2 [ 23s] [178/185] cumulate system-group-hardware-20170617-lp151.4.3 [ 23s] [179/185] cumulate libutempter0-1.1.6-lp151.4.3 [ 23s] [180/185] cumulate util-linux-2.33.1-lp151.2.2 [ 23s] [181/185] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 23s] [182/185] cumulate systemd-234-lp151.25.2 [ 23s] [183/185] cumulate rpm-build-4.14.1-lp151.13.2 [ 23s] [184/185] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 23s] [185/185] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 23s] now installing cumulated packages [ 24s] Preparing... ######################################## [ 24s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 25s] exit ... [ 25s] ### VM INTERACTION START ### [ 28s] [ 13.932256] sysrq: SysRq : Power Off [ 28s] [ 13.939778] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] armbuild22 failed "build osmo-cbc.spec" at Fri Dec 24 02:42:28 UTC 2021. [ 28s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:42:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:42:48 +0000 Subject: Build failure of network:osmocom:latest/osmo-smlc in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c533bda2503_196b2ab243444600281735@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-smlc/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-smlc failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-smlc Last lines of build log: [ 29s] [148/165] cumulate libosmoctrl0-1.6.0-lp151.1.1 [ 29s] [149/165] cumulate libosmonetif8-1.1.0-lp151.2.2 [ 29s] [150/165] cumulate pam-1.3.0-lp151.7.2 [ 29s] [151/165] cumulate gcc-PIE-7-lp151.3.2 [ 29s] [152/165] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 29s] [153/165] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 29s] [154/165] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 29s] [155/165] cumulate shadow-4.6-lp151.1.2 [ 29s] [156/165] cumulate sysuser-shadow-2.0-lp151.3.3 [ 29s] [157/165] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 29s] [158/165] cumulate system-group-hardware-20170617-lp151.4.3 [ 29s] [159/165] cumulate libutempter0-1.1.6-lp151.4.3 [ 29s] [160/165] cumulate util-linux-2.33.1-lp151.2.2 [ 29s] [161/165] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 29s] [162/165] cumulate systemd-234-lp151.25.2 [ 29s] [163/165] cumulate rpm-build-4.14.1-lp151.13.2 [ 29s] [164/165] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 29s] [165/165] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 29s] now installing cumulated packages [ 30s] Preparing... ######################################## [ 30s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 30s] exit ... [ 30s] ### VM INTERACTION START ### [ 33s] [ 13.291257] sysrq: SysRq : Power Off [ 33s] [ 13.309700] reboot: Power down [ 33s] ### VM INTERACTION END ### [ 33s] [ 33s] armbuild02 failed "build osmo-smlc.spec" at Fri Dec 24 02:42:43 UTC 2021. [ 33s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:44:31 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:44:31 +0000 Subject: Build failure of network:osmocom:latest/osmo-hnodeb in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c534196ad28_196b2ab243444600282168@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hnodeb/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-hnodeb failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-hnodeb Last lines of build log: [ 27s] [165/182] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 27s] [166/182] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 27s] [167/182] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 27s] [168/182] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 27s] [169/182] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 27s] [170/182] cumulate shadow-4.6-lp151.1.2 [ 27s] [171/182] cumulate sysuser-shadow-2.0-lp151.3.3 [ 27s] [172/182] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 27s] [173/182] cumulate libosmo-ranap5-1.1.0-lp151.1.1 [ 27s] [174/182] cumulate libosmo-ranap-devel-1.1.0-lp151.1.1 [ 27s] [175/182] cumulate system-group-hardware-20170617-lp151.4.3 [ 27s] [176/182] cumulate libutempter0-1.1.6-lp151.4.3 [ 27s] [177/182] cumulate util-linux-2.33.1-lp151.2.2 [ 27s] [178/182] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 27s] [179/182] cumulate systemd-234-lp151.25.2 [ 27s] [180/182] cumulate rpm-build-4.14.1-lp151.13.2 [ 27s] [181/182] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 27s] [182/182] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 27s] now installing cumulated packages [ 27s] Preparing... ######################################## [ 27s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 28s] exit ... [ 28s] ### VM INTERACTION START ### [ 31s] [ 15.076499] sysrq: SysRq : Power Off [ 31s] [ 15.100525] reboot: Power down [ 31s] ### VM INTERACTION END ### [ 31s] [ 31s] armbuild22 failed "build osmo-hnodeb.spec" at Fri Dec 24 02:44:28 UTC 2021. [ 31s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:47:06 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:47:06 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c534adc476e_196b2ab243444600283289@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-bsc failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 25s] [157/174] cumulate pam-1.3.0-lp151.7.2 [ 25s] [158/174] cumulate gcc-PIE-7-lp151.3.2 [ 25s] [159/174] cumulate libosmonetif-devel-1.1.0-lp151.2.2 [ 25s] [160/174] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 25s] [161/174] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 25s] [162/174] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 25s] [163/174] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 25s] [164/174] cumulate shadow-4.6-lp151.1.2 [ 25s] [165/174] cumulate sysuser-shadow-2.0-lp151.3.3 [ 25s] [166/174] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 25s] [167/174] cumulate system-group-hardware-20170617-lp151.4.3 [ 25s] [168/174] cumulate libutempter0-1.1.6-lp151.4.3 [ 25s] [169/174] cumulate util-linux-2.33.1-lp151.2.2 [ 25s] [170/174] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 25s] [171/174] cumulate systemd-234-lp151.25.2 [ 25s] [172/174] cumulate rpm-build-4.14.1-lp151.13.2 [ 25s] [173/174] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 25s] [174/174] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 25s] now installing cumulated packages [ 25s] Preparing... ######################################## [ 25s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 25s] exit ... [ 25s] ### VM INTERACTION START ### [ 28s] [ 12.620350] sysrq: SysRq : Power Off [ 28s] [ 12.622104] reboot: Power down [ 29s] ### VM INTERACTION END ### [ 29s] [ 29s] armbuild24 failed "build osmo-bsc.spec" at Fri Dec 24 02:46:55 UTC 2021. [ 29s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:47:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:47:23 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c534cc7b7bb_196b2ab243444600283316@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-msc failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 31s] [169/186] cumulate libosmoabis-devel-1.2.0-lp151.1.1 [ 31s] [170/186] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 31s] [171/186] cumulate libosmo-gsup-client0-1.4.0-lp151.1.1 [ 31s] [172/186] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 31s] [173/186] cumulate shadow-4.6-lp151.1.2 [ 31s] [174/186] cumulate sysuser-shadow-2.0-lp151.3.3 [ 31s] [175/186] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 31s] [176/186] cumulate libosmo-gsup-client-devel-1.4.0-lp151.1.1 [ 31s] [177/186] cumulate libosmo-ranap5-1.1.0-lp151.1.1 [ 31s] [178/186] cumulate libosmo-ranap-devel-1.1.0-lp151.1.1 [ 31s] [179/186] cumulate system-group-hardware-20170617-lp151.4.3 [ 31s] [180/186] cumulate libutempter0-1.1.6-lp151.4.3 [ 31s] [181/186] cumulate util-linux-2.33.1-lp151.2.2 [ 31s] [182/186] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 31s] [183/186] cumulate systemd-234-lp151.25.2 [ 31s] [184/186] cumulate rpm-build-4.14.1-lp151.13.2 [ 31s] [185/186] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 31s] [186/186] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 31s] now installing cumulated packages [ 31s] Preparing... ######################################## [ 32s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 32s] exit ... [ 32s] ### VM INTERACTION START ### [ 35s] [ 14.910547] sysrq: SysRq : Power Off [ 35s] [ 14.913580] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 36s] [ 36s] armbuild01 failed "build osmo-msc.spec" at Fri Dec 24 02:47:06 UTC 2021. [ 36s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:48:48 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:48:48 +0000 Subject: Build failure of network:osmocom:latest/osmo-remsim in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c53522208f5_196b2ab24344460028371c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-remsim/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-remsim failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-remsim Last lines of build log: [ 32s] file /usr/lib/systemd/systemd-modules-load conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 32s] file /usr/lib/systemd/systemd-quotacheck conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 32s] file /usr/lib/systemd/systemd-random-seed conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 32s] file /usr/lib/systemd/systemd-remount-fs conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 32s] file /usr/lib/systemd/systemd-reply-password conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 32s] file /usr/lib/systemd/systemd-rfkill conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 32s] file /usr/lib/systemd/systemd-shutdown conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 32s] file /usr/lib/systemd/systemd-sleep conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 32s] file /usr/lib/systemd/systemd-socket-proxyd conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 32s] file /usr/lib/systemd/systemd-sysctl conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 33s] file /usr/lib/systemd/systemd-timedated conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 33s] file /usr/lib/systemd/systemd-timesyncd conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 33s] file /usr/lib/systemd/systemd-update-done conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 33s] file /usr/lib/systemd/systemd-update-utmp conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 33s] file /usr/lib/systemd/systemd-user-sessions conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 33s] file /usr/lib/systemd/systemd-vconsole-setup conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 33s] file /usr/lib/systemd/systemd-volatile-root conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 33s] file /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-generator conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 33s] file /usr/lib/sysusers.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 33s] file /usr/lib/tmpfiles.d/systemd.conf conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 33s] file /usr/share/systemd/kbd-model-map conflicts between attempted installs of systemd-mini-234-lp151.25.2.armv7hl and systemd-234-lp151.25.2.armv7hl [ 33s] exit ... [ 33s] ### VM INTERACTION START ### [ 36s] [ 17.064360] sysrq: SysRq : Power Off [ 36s] [ 17.209690] reboot: Power down [ 37s] ### VM INTERACTION END ### [ 37s] [ 37s] armbuild22 failed "build osmo-remsim.spec" at Fri Dec 24 02:48:36 UTC 2021. [ 37s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Fri Dec 24 02:51:40 2021 From: noreply at opensuse.org (OBS Notification) Date: Fri, 24 Dec 2021 02:51:40 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in openSUSE_Leap_15.1_ARM/armv7l In-Reply-To: References: Message-ID: <61c535d9d871c_196b2ab2434446002841e1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:latest/osmo-sgsn failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 79s] [165/182] cumulate libosmoctrl-devel-1.6.0-lp151.1.1 [ 79s] [166/182] cumulate libosmogb-devel-1.6.0-lp151.1.1 [ 79s] [167/182] cumulate libosmo-gsup-client0-1.4.0-lp151.1.1 [ 79s] [168/182] cumulate libosmo-sigtran7-1.5.0-lp151.1.1 [ 79s] [169/182] cumulate shadow-4.6-lp151.1.2 [ 79s] [170/182] cumulate sysuser-shadow-2.0-lp151.3.3 [ 79s] [171/182] cumulate libosmo-sigtran-devel-1.5.0-lp151.1.1 [ 79s] [172/182] cumulate libosmo-gsup-client-devel-1.4.0-lp151.1.1 [ 79s] [173/182] cumulate libosmo-ranap5-1.1.0-lp151.1.1 [ 79s] [174/182] cumulate libosmo-ranap-devel-1.1.0-lp151.1.1 [ 79s] [175/182] cumulate system-group-hardware-20170617-lp151.4.3 [ 79s] [176/182] cumulate libutempter0-1.1.6-lp151.4.3 [ 79s] [177/182] cumulate util-linux-2.33.1-lp151.2.2 [ 79s] [178/182] cumulate aaa_base-84.87+git20180409.04c9dae-lp151.4.1 [ 79s] [179/182] cumulate systemd-234-lp151.25.2 [ 79s] [180/182] cumulate rpm-build-4.14.1-lp151.13.2 [ 79s] [181/182] cumulate aaa_base-malloccheck-84.87+git20180409.04c9dae-lp151.4.1 [ 79s] [182/182] cumulate post-build-checks-84.88+git20181015.ceb5c96-lp151.1.1 [ 79s] now installing cumulated packages [ 80s] Preparing... ######################################## [ 80s] file /usr/lib/libsystemd.so.0.19.0 conflicts between attempted installs of libsystemd0-234-lp151.25.2.armv7hl and libsystemd0-mini-234-lp151.25.2.armv7hl [ 82s] exit ... [ 82s] ### VM INTERACTION START ### [ 85s] [ 28.209350] sysrq: SysRq : Power Off [ 85s] [ 28.233416] reboot: Power down [ 85s] ### VM INTERACTION END ### [ 85s] [ 85s] obs-arm-5 failed "build osmo-sgsn.spec" at Fri Dec 24 02:51:37 UTC 2021. [ 85s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Dec 24 04:44:49 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 24 Dec 2021 04:44:49 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: use osmo-config-merge to generate config files In-Reply-To: References: Message-ID: fixeria has uploaded a new patch set (#2) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 ) Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files ...................................................................... ttcn3-bts-test: use osmo-config-merge to generate config files This uses the config files from osmo-ttcn3-hacks.git instead of keeping local copies around here, which has shown many times will get out of sync. Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 --- M ttcn3-bts-test/Makefile D ttcn3-bts-test/fh/osmo-bsc.cfg A ttcn3-bts-test/fh/osmo-bsc.confmerge M ttcn3-bts-test/jenkins.sh D ttcn3-bts-test/oml/osmo-bts.cfg A ttcn3-bts-test/oml/osmo-bts.confmerge D ttcn3-bts-test/osmo-bsc.cfg A ttcn3-bts-test/osmo-bsc.confmerge D ttcn3-bts-test/osmo-bts.cfg A ttcn3-bts-test/osmo-bts.confmerge D ttcn3-bts-test/virtphy/osmo-bts.cfg A ttcn3-bts-test/virtphy/osmo-bts.confmerge 12 files changed, 328 insertions(+), 848 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/22/20622/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 Gerrit-Change-Number: 20622 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Assignee: fixeria Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 04:44:52 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 24 Dec 2021 04:44:52 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: move generic config files into a directory References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26681 ) Change subject: ttcn3-bts-test: move generic config files into a directory ...................................................................... ttcn3-bts-test: move generic config files into a directory Change-Id: I1bc5c51306525c6829e9d8e2991555a99c9b49a2 --- M ttcn3-bts-test/Makefile R ttcn3-bts-test/generic/BTS_Tests.cfg R ttcn3-bts-test/generic/osmo-bsc.confmerge R ttcn3-bts-test/generic/osmo-bts.confmerge M ttcn3-bts-test/jenkins.sh 5 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/81/26681/1 diff --git a/ttcn3-bts-test/Makefile b/ttcn3-bts-test/Makefile index 19154b8..2d3335f 100644 --- a/ttcn3-bts-test/Makefile +++ b/ttcn3-bts-test/Makefile @@ -8,8 +8,8 @@ osmo-bsc.src.cfg CFG_GEN_FILES = \ - osmo-bts-generic.cfg \ - osmo-bsc-generic.cfg \ + generic/osmo-bts.cfg \ + generic/osmo-bsc.cfg \ virtphy/osmo-bts.cfg \ oml/osmo-bts.cfg \ fh/osmo-bsc.cfg @@ -22,20 +22,20 @@ %src.cfg: wget $(CFG_SRC_FETCH_URL)/$(@:%.src.cfg=%.cfg) -O $@ -osmo-bts-generic.cfg: osmo-bts.src.cfg osmo-bts.confmerge +generic/osmo-bts.cfg: osmo-bts.src.cfg generic/osmo-bts.confmerge osmo-config-merge $^ > $@ -osmo-bsc-generic.cfg: osmo-bsc.src.cfg osmo-bsc.confmerge +generic/osmo-bsc.cfg: osmo-bsc.src.cfg generic/osmo-bsc.confmerge osmo-config-merge $^ > $@ -virtphy/osmo-bts.cfg: osmo-bts-generic.cfg virtphy/osmo-bts.confmerge +virtphy/osmo-bts.cfg: generic/osmo-bts.cfg virtphy/osmo-bts.confmerge osmo-config-merge $^ > $@ sed -i "/osmotrx/d" $@ -oml/osmo-bts.cfg: osmo-bts-generic.cfg oml/osmo-bts.confmerge +oml/osmo-bts.cfg: generic/osmo-bts.cfg oml/osmo-bts.confmerge osmo-config-merge $^ > $@ -fh/osmo-bsc.cfg: osmo-bsc-generic.cfg fh/osmo-bsc.confmerge +fh/osmo-bsc.cfg: generic/osmo-bsc.cfg fh/osmo-bsc.confmerge osmo-config-merge $^ > $@ clean: diff --git a/ttcn3-bts-test/BTS_Tests.cfg b/ttcn3-bts-test/generic/BTS_Tests.cfg similarity index 100% rename from ttcn3-bts-test/BTS_Tests.cfg rename to ttcn3-bts-test/generic/BTS_Tests.cfg diff --git a/ttcn3-bts-test/osmo-bsc.confmerge b/ttcn3-bts-test/generic/osmo-bsc.confmerge similarity index 100% rename from ttcn3-bts-test/osmo-bsc.confmerge rename to ttcn3-bts-test/generic/osmo-bsc.confmerge diff --git a/ttcn3-bts-test/osmo-bts.confmerge b/ttcn3-bts-test/generic/osmo-bts.confmerge similarity index 100% rename from ttcn3-bts-test/osmo-bts.confmerge rename to ttcn3-bts-test/generic/osmo-bts.confmerge diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 201ce46..35ce0d5 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -120,7 +120,7 @@ network_create $SUBNET mkdir $VOL_BASE_DIR/bts-tester-generic -cp BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-generic/ +cp generic/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-generic/ write_mp_osmo_repo "$VOL_BASE_DIR/bts-tester-generic/BTS_Tests.cfg" mkdir $VOL_BASE_DIR/bts-tester-virtphy cp virtphy/BTS_Tests.cfg $VOL_BASE_DIR/bts-tester-virtphy/ @@ -136,11 +136,11 @@ $VOL_BASE_DIR/bts-tester-hopping/BTS_Tests.cfg.inc mkdir $VOL_BASE_DIR/bsc -cp osmo-bsc-generic.cfg $VOL_BASE_DIR/bsc/ +cp generic/osmo-bsc.cfg $VOL_BASE_DIR/bsc/ mkdir $VOL_BASE_DIR/bts mkdir $VOL_BASE_DIR/bts/unix -cp osmo-bts-generic.cfg $VOL_BASE_DIR/bts/ +cp generic/osmo-bts.cfg $VOL_BASE_DIR/bts/ mkdir $VOL_BASE_DIR/unix @@ -182,7 +182,7 @@ # 4) Frequency hopping tests require different configuration files cp fh/osmo-bsc.cfg $VOL_BASE_DIR/bsc/ -cp osmo-bts-generic.cfg $VOL_BASE_DIR/bts/ +cp generic/osmo-bts.cfg $VOL_BASE_DIR/bts/ # restart the BSC/BTS and run the testsuite again docker container kill ${BUILD_TAG}-bts start_bsc -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1bc5c51306525c6829e9d8e2991555a99c9b49a2 Gerrit-Change-Number: 26681 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 04:54:04 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 24 Dec 2021 04:54:04 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: use osmo-config-merge to generate config files In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 ) Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files ...................................................................... Patch Set 2: Verified-1 Let's keep it WIP for now, I am still testing it. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 Gerrit-Change-Number: 20622 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Assignee: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 24 Dec 2021 04:54:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 06:47:21 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 24 Dec 2021 06:47:21 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: install libosmocore-utils References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/26682 ) Change subject: debian-bullseye-titan: install libosmocore-utils ...................................................................... debian-bullseye-titan: install libosmocore-utils This package contains osmo-config-merge, which is going to be used in subsequent commits for generating the configuration files. Change-Id: Ia4f3b6c0b8fe793171483a495c2f386991ee0f52 --- M debian-bullseye-titan/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/82/26682/1 diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile index 0b1fbda..43da6df 100644 --- a/debian-bullseye-titan/Dockerfile +++ b/debian-bullseye-titan/Dockerfile @@ -35,6 +35,7 @@ tcpdump \ vim \ wireshark-common \ + libosmocore-utils \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia4f3b6c0b8fe793171483a495c2f386991ee0f52 Gerrit-Change-Number: 26682 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 07:24:26 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 24 Dec 2021 07:24:26 +0000 Subject: Change in docker-playground[master]: debian-bullseye-titan: install libosmocore-utils In-Reply-To: References: Message-ID: fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26682 ) Change subject: debian-bullseye-titan: install libosmocore-utils ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia4f3b6c0b8fe793171483a495c2f386991ee0f52 Gerrit-Change-Number: 26682 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:34:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:34:29 +0000 Subject: Change in libosmocore[master]: tcp_stats: fix compilation on CentOS 7 References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26683 ) Change subject: tcp_stats: fix compilation on CentOS 7 ...................................................................... tcp_stats: fix compilation on CentOS 7 This is to fix the following compile error on CentOS 7: [ 74s] stats_tcp.c: In function 'fill_stats': [ 74s] stats_tcp.c:138:15: error: 'struct tcp_info' has no member named 'tcpi_notsent_bytes' [ 74s] tcp_info.tcpi_notsent_bytes); [ 74s] ^ Closes: OS#5374 Change-Id: Icde6651baeb0828477dbf540a02b16a1a5f91797 --- M configure.ac M src/stats_tcp.c 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/83/26683/1 diff --git a/configure.ac b/configure.ac index 8fb299b..89615fd 100644 --- a/configure.ac +++ b/configure.ac @@ -517,6 +517,13 @@ [Runtime SIMD detection will be disabled]) dnl There are some members in struct tcp_info that might not exist on all linux versions +AC_CHECK_MEMBER([struct tcp_info.tcpi_notsent_bytes], + AC_DEFINE([HAVE_TCP_INFO_TCPI_NOTSENT_BYTES], + [1], + [Define to 1 if your header file have the tcpi_notsent_bytes member in struct tcp_info]), + [], + [#include ]) + AC_CHECK_MEMBER([struct tcp_info.tcpi_rwnd_limited], AC_DEFINE([HAVE_TCP_INFO_TCPI_RWND_LIMITED], [1], diff --git a/src/stats_tcp.c b/src/stats_tcp.c index fffb10a..d2be6a9 100644 --- a/src/stats_tcp.c +++ b/src/stats_tcp.c @@ -134,8 +134,12 @@ osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_RTT), tcp_info.tcpi_rtt); osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_RCV_RTT), tcp_info.tcpi_rcv_rtt); +#if HAVE_TCP_INFO_TCPI_NOTSENT_BYTES == 1 osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_NOTSENT_BYTES), tcp_info.tcpi_notsent_bytes); +#else + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_NOTSENT_BYTES), -1); +#endif #if HAVE_TCP_INFO_TCPI_RWND_LIMITED == 1 osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_RWND_LIMITED), -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icde6651baeb0828477dbf540a02b16a1a5f91797 Gerrit-Change-Number: 26683 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:38:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:38:29 +0000 Subject: Change in libosmocore[master]: iuup: Fix signed/unsigned loop counter control flow issue References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26684 ) Change subject: iuup: Fix signed/unsigned loop counter control flow issue ...................................................................... iuup: Fix signed/unsigned loop counter control flow issue The use of an unsinged integer as for loop counter variable doesn't work when counting down and comparing with >= 0. The existing code would be an infinite loop if it wasn't for the (data dependent) break condition: >>> CID 243259: Control flow issues (NO_EFFECT) >>> This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "i >= 0U". 572 for (i = 15; i >= 0; i--) { 573 if (match_mask & (1<mode_version = i; 575 break; 576 } Change-Id: I019d0f0d8f2b167575a2883a13cca692c96961cf Closes: CID#243259 --- M src/gsm/iuup.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/26684/1 diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c index 159e533..b838dc6 100644 --- a/src/gsm/iuup.c +++ b/src/gsm/iuup.c @@ -493,7 +493,7 @@ struct iuup_ctrl_init_tail *itail; enum iuup_error_cause err_cause; uint8_t num_rfci = 0; - unsigned int i; + int i; bool is_last; uint16_t remote_mask, match_mask; struct osmo_iuup_tnl_prim *resp; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I019d0f0d8f2b167575a2883a13cca692c96961cf Gerrit-Change-Number: 26684 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:39:15 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:39:15 +0000 Subject: Change in libosmocore[master]: iuup: Fix signed/unsigned loop counter control flow issue In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26684 ) Change subject: iuup: Fix signed/unsigned loop counter control flow issue ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I019d0f0d8f2b167575a2883a13cca692c96961cf Gerrit-Change-Number: 26684 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 24 Dec 2021 10:39:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:39:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:39:24 +0000 Subject: Change in libosmocore[master]: tcp_stats: fix compilation on CentOS 7 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26683 ) Change subject: tcp_stats: fix compilation on CentOS 7 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icde6651baeb0828477dbf540a02b16a1a5f91797 Gerrit-Change-Number: 26683 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 24 Dec 2021 10:39:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:39:49 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:39:49 +0000 Subject: Change in libosmocore[master]: tcp_stats: fix compilation on CentOS 7 In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26683 ) Change subject: tcp_stats: fix compilation on CentOS 7 ...................................................................... tcp_stats: fix compilation on CentOS 7 This is to fix the following compile error on CentOS 7: [ 74s] stats_tcp.c: In function 'fill_stats': [ 74s] stats_tcp.c:138:15: error: 'struct tcp_info' has no member named 'tcpi_notsent_bytes' [ 74s] tcp_info.tcpi_notsent_bytes); [ 74s] ^ Closes: OS#5374 Change-Id: Icde6651baeb0828477dbf540a02b16a1a5f91797 --- M configure.ac M src/stats_tcp.c 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 8fb299b..89615fd 100644 --- a/configure.ac +++ b/configure.ac @@ -517,6 +517,13 @@ [Runtime SIMD detection will be disabled]) dnl There are some members in struct tcp_info that might not exist on all linux versions +AC_CHECK_MEMBER([struct tcp_info.tcpi_notsent_bytes], + AC_DEFINE([HAVE_TCP_INFO_TCPI_NOTSENT_BYTES], + [1], + [Define to 1 if your header file have the tcpi_notsent_bytes member in struct tcp_info]), + [], + [#include ]) + AC_CHECK_MEMBER([struct tcp_info.tcpi_rwnd_limited], AC_DEFINE([HAVE_TCP_INFO_TCPI_RWND_LIMITED], [1], diff --git a/src/stats_tcp.c b/src/stats_tcp.c index fffb10a..d2be6a9 100644 --- a/src/stats_tcp.c +++ b/src/stats_tcp.c @@ -134,8 +134,12 @@ osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_RTT), tcp_info.tcpi_rtt); osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_RCV_RTT), tcp_info.tcpi_rcv_rtt); +#if HAVE_TCP_INFO_TCPI_NOTSENT_BYTES == 1 osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_NOTSENT_BYTES), tcp_info.tcpi_notsent_bytes); +#else + osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_NOTSENT_BYTES), -1); +#endif #if HAVE_TCP_INFO_TCPI_RWND_LIMITED == 1 osmo_stat_item_set(osmo_stat_item_group_get_item(stats_tcp_entry->stats_tcp, STATS_TCP_RWND_LIMITED), -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icde6651baeb0828477dbf540a02b16a1a5f91797 Gerrit-Change-Number: 26683 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:49:20 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:49:20 +0000 Subject: Change in libosmocore[master]: iuup: Fix signed/unsigned loop counter control flow issue In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26684 ) Change subject: iuup: Fix signed/unsigned loop counter control flow issue ...................................................................... iuup: Fix signed/unsigned loop counter control flow issue The use of an unsinged integer as for loop counter variable doesn't work when counting down and comparing with >= 0. The existing code would be an infinite loop if it wasn't for the (data dependent) break condition: >>> CID 243259: Control flow issues (NO_EFFECT) >>> This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "i >= 0U". 572 for (i = 15; i >= 0; i--) { 573 if (match_mask & (1<mode_version = i; 575 break; 576 } Change-Id: I019d0f0d8f2b167575a2883a13cca692c96961cf Closes: CID#243259 --- M src/gsm/iuup.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c index 159e533..b838dc6 100644 --- a/src/gsm/iuup.c +++ b/src/gsm/iuup.c @@ -493,7 +493,7 @@ struct iuup_ctrl_init_tail *itail; enum iuup_error_cause err_cause; uint8_t num_rfci = 0; - unsigned int i; + int i; bool is_last; uint16_t remote_mask, match_mask; struct osmo_iuup_tnl_prim *resp; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I019d0f0d8f2b167575a2883a13cca692c96961cf Gerrit-Change-Number: 26684 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:51:42 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:51:42 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: use osmo-config-merge to generate config files In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 ) Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files ...................................................................... Patch Set 3: Code-Review+1 please test with a copy of the ttcn3-bts-test job and don't build your private branches in the "production" ttcn3-bts-test job. I've just received build failure notification and tried to understand what's happenign, grep'ing for osmo-config-merge everywhere until I realized that somebody had used that 'production testing' job to build a private branch. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 Gerrit-Change-Number: 20622 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Assignee: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 24 Dec 2021 10:51:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:52:07 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:52:07 +0000 Subject: Change in docker-playground[master]: osmo-remsim-test-latest: install client-shell In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26680 ) Change subject: osmo-remsim-test-latest: install client-shell ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia3041ea6f19ebe53e05117806acf88d3f86d4479 Gerrit-Change-Number: 26680 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 24 Dec 2021 10:52:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:52:12 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:52:12 +0000 Subject: Change in docker-playground[master]: osmo-remsim-test-latest: install client-shell In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26680 ) Change subject: osmo-remsim-test-latest: install client-shell ...................................................................... osmo-remsim-test-latest: install client-shell Fix for failing ttcn3-remsim-test-latest, in osmo-remsim-client.log: /bin/sh: 1: osmo-remsim-client-shell: not found Change-Id: Ia3041ea6f19ebe53e05117806acf88d3f86d4479 --- M osmo-remsim-latest/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve osmith: Verified diff --git a/osmo-remsim-latest/Dockerfile b/osmo-remsim-latest/Dockerfile index c684cb8..80b8296 100644 --- a/osmo-remsim-latest/Dockerfile +++ b/osmo-remsim-latest/Dockerfile @@ -10,6 +10,7 @@ apt-get update && \ apt-get install -y --no-install-recommends \ osmo-remsim-server \ + osmo-remsim-client-shell \ osmo-remsim-client-st2 \ osmo-remsim-bankd && \ apt-get clean \ @@ -17,6 +18,7 @@ centos*) \ dnf install -y \ osmo-remsim-server \ + osmo-remsim-client-shell \ osmo-remsim-client-st2 \ osmo-remsim-bankd \ ;; \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia3041ea6f19ebe53e05117806acf88d3f86d4479 Gerrit-Change-Number: 26680 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:53:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:53:41 +0000 Subject: Change in osmo-mgw[master]: cosmetic: Rename variable payload=>payload_type In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26678 ) Change subject: cosmetic: Rename variable payload=>payload_type ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifcad63b0ba5068acd555960c71c3ad1489a2b870 Gerrit-Change-Number: 26678 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 24 Dec 2021 10:53:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:53:45 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:53:45 +0000 Subject: Change in osmo-mgw[master]: cosmetic: Rename variable payload=>payload_type In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26678 ) Change subject: cosmetic: Rename variable payload=>payload_type ...................................................................... cosmetic: Rename variable payload=>payload_type Using "payload" there is misleading, the proper naming is payload type, a well known term for RTP. Change-Id: Ifcad63b0ba5068acd555960c71c3ad1489a2b870 --- M src/libosmo-mgcp/mgcp_sdp.c 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_sdp.c b/src/libosmo-mgcp/mgcp_sdp.c index a36c6d2..98b3099 100644 --- a/src/libosmo-mgcp/mgcp_sdp.c +++ b/src/libosmo-mgcp/mgcp_sdp.c @@ -98,7 +98,7 @@ /* Helper function to update codec map information with additional data from * SDP, called from: mgcp_parse_sdp_data() */ static void codecs_update(void *ctx, struct sdp_rtp_map *codecs, int used, - int payload, const char *audio_name) + int payload_type, const char *audio_name) { int i; @@ -110,7 +110,7 @@ /* Note: We can only update payload codecs that already exist * in our codec list. If we get an unexpected payload type, * we just drop it */ - if (codecs[i].payload_type != payload) + if (codecs[i].payload_type != payload_type) continue; if (sscanf(audio_name, "%63[^/]/%d/%d", @@ -127,7 +127,7 @@ return; } - LOGP(DLMGCP, LOGL_ERROR, "Unconfigured PT(%d) with %s\n", payload, + LOGP(DLMGCP, LOGL_ERROR, "Unconfigured PT(%d) with %s\n", payload_type, audio_name); } @@ -334,7 +334,7 @@ void *tmp_ctx = talloc_new(NULL); struct mgcp_rtp_end *rtp; - int payload; + int payload_type; int ptime, ptime2 = 0; char audio_name[64]; int port, rc; @@ -355,8 +355,8 @@ /* skip these SDP attributes */ break; case 'a': - if (sscanf(line, "a=rtpmap:%d %63s", &payload, audio_name) == 2) { - codecs_update(tmp_ctx, codecs, codecs_used, payload, audio_name); + if (sscanf(line, "a=rtpmap:%d %63s", &payload_type, audio_name) == 2) { + codecs_update(tmp_ctx, codecs, codecs_used, payload_type, audio_name); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifcad63b0ba5068acd555960c71c3ad1489a2b870 Gerrit-Change-Number: 26678 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:54:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:54:02 +0000 Subject: Change in osmo-hnodeb[master]: Add initial support for IuUP RTP based Transport Layer In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 ) Change subject: Add initial support for IuUP RTP based Transport Layer ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ie137809e1f91dfd702853c52be97ca79e8604eab Gerrit-Change-Number: 26671 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 24 Dec 2021 10:54:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:54:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:54:26 +0000 Subject: Change in osmo-hnodeb[master]: Get rid of libgtp for GTP-U In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26675 ) Change subject: Get rid of libgtp for GTP-U ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I53ad4915aaed3bc7574036e963be10514e370fe2 Gerrit-Change-Number: 26675 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 24 Dec 2021 10:54:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:54:29 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:54:29 +0000 Subject: Change in osmo-hnodeb[master]: Add initial support for IuUP RTP based Transport Layer In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 ) Change subject: Add initial support for IuUP RTP based Transport Layer ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ie137809e1f91dfd702853c52be97ca79e8604eab Gerrit-Change-Number: 26671 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 24 Dec 2021 10:54:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:54:32 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:54:32 +0000 Subject: Change in osmo-hnodeb[master]: Add initial support for IuUP RTP based Transport Layer In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 ) Change subject: Add initial support for IuUP RTP based Transport Layer ...................................................................... Add initial support for IuUP RTP based Transport Layer Use the recently introduced IuUP support in libosmocore to send and receive proper IuUP over RTP instead of regular RTP. The LLSK AUDIO primitives are updated to provide required information back and forth. Depends: libosmocore.git Change-Id Ibe356fa7b1abaca0091e368db8478e79c09c6cb0 Related: SYS#5516 Change-Id: Ie137809e1f91dfd702853c52be97ca79e8604eab --- M TODO-RELEASE M include/osmocom/hnodeb/hnb_prim.h M include/osmocom/hnodeb/llsk.h M include/osmocom/hnodeb/rtp.h M src/osmo-hnodeb/llsk_audio.c M src/osmo-hnodeb/rtp.c 6 files changed, 158 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 9e75c9a..d847efe 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmo-netif >1.1.0 use of netif/sctp.h +libosmocore > 1.6.0 use of core/iuup.h diff --git a/include/osmocom/hnodeb/hnb_prim.h b/include/osmocom/hnodeb/hnb_prim.h index 0b0a545..ba3223d 100644 --- a/include/osmocom/hnodeb/hnb_prim.h +++ b/include/osmocom/hnodeb/hnb_prim.h @@ -186,12 +186,23 @@ }; /* HNB_AUDIO_PRIM_CONN_ESTABLISH, UL */ +#define HNB_MAX_RFCIS 64 +#define HNB_MAX_SUBFLOWS 7 struct hnb_audio_conn_establish_req_param { uint32_t context_id; uint16_t remote_rtp_port; uint8_t spare1; uint8_t remote_rtp_address_type; /* enum u_addr_type */ union u_addr remote_rtp_addr; + /* IuUP related: */ + uint8_t transparent; /* 1=transparent; 0=SMpSDU */ + uint8_t data_pdu_type; + uint16_t supported_versions_mask; /* host byte order */ + uint8_t num_rfci; + uint8_t num_subflows; + uint16_t subflow_sizes[HNB_MAX_RFCIS][HNB_MAX_SUBFLOWS]; + uint8_t IPTIs_present; /* 1=present; 0=not present */ + uint8_t IPTIs[HNB_MAX_RFCIS]; /* values range 0-15, 4 bits */ } __attribute__ ((packed)); /* HNB_AUDIO_PRIM_CONN_ESTABLISH, DL */ @@ -212,6 +223,10 @@ /* HNB_AUDIO_PRIM_CONN_DATA, UL */ struct hnb_audio_conn_data_req_param { uint32_t audio_conn_id; + uint8_t frame_nr; + uint8_t fqc; + uint8_t rfci; + uint8_t spare; uint32_t data_len; /* RTP payload length in bytes */ uint8_t data[0]; /* RTP payload (aka IP packet) */ } __attribute__ ((packed)); @@ -219,6 +234,10 @@ /* HNB_AUDIO_PRIM_CONN_DATA, DL */ struct hnb_audio_conn_data_ind_param { uint32_t audio_conn_id; + uint8_t frame_nr; + uint8_t fqc; + uint8_t rfci; + uint8_t spare; uint32_t data_len; /* RTP payload length in bytes */ uint8_t data[0]; /* RTP payload (aka IP packet) */ } __attribute__ ((packed)); diff --git a/include/osmocom/hnodeb/llsk.h b/include/osmocom/hnodeb/llsk.h index fe1dce1..78eb065 100644 --- a/include/osmocom/hnodeb/llsk.h +++ b/include/osmocom/hnodeb/llsk.h @@ -53,7 +53,8 @@ extern const struct value_string hnb_audio_prim_type_names[]; int llsk_rx_audio(struct hnb *hnb, struct osmo_prim_hdr *oph); -int llsk_audio_tx_conn_data_ind(struct rtp_conn *conn, const uint8_t *payload, uint32_t len); +int llsk_audio_tx_conn_data_ind(struct rtp_conn *conn, uint8_t frame_nr, uint8_t fqc, uint8_t rfci, + const uint8_t *payload, uint32_t len); extern const struct value_string hnb_gtp_prim_type_names[]; int llsk_rx_gtp(struct hnb *hnb, struct osmo_prim_hdr *oph); diff --git a/include/osmocom/hnodeb/rtp.h b/include/osmocom/hnodeb/rtp.h index 8035175..5eaec7b 100644 --- a/include/osmocom/hnodeb/rtp.h +++ b/include/osmocom/hnodeb/rtp.h @@ -18,8 +18,11 @@ */ #pragma once +#include + #include #include +#include struct hnb; struct hnb_ue; @@ -31,9 +34,11 @@ struct osmo_rtp_socket *socket; struct osmo_sockaddr loc_addr; struct osmo_sockaddr rem_addr; + struct osmo_iuup_instance *iui; }; struct rtp_conn *rtp_conn_alloc(struct hnb_ue *ue); void rtp_conn_free(struct rtp_conn *conn); -int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr); +int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr, const struct hnb_audio_conn_establish_req_param *ce_req); +int rtp_conn_tx_data(struct rtp_conn *conn, uint8_t frame_nr, uint8_t fqc, uint8_t rfci, const uint8_t *data, unsigned int data_len); diff --git a/src/osmo-hnodeb/llsk_audio.c b/src/osmo-hnodeb/llsk_audio.c index a600c3c..da54d28 100644 --- a/src/osmo-hnodeb/llsk_audio.c +++ b/src/osmo-hnodeb/llsk_audio.c @@ -101,13 +101,16 @@ } static struct hnb_audio_prim *hnb_audio_makeprim_conn_data_ind(uint32_t audio_conn_id, - const uint8_t *data, - uint32_t data_len) + uint8_t frame_nr, uint8_t fqc, uint8_t rfci, + const uint8_t *data, uint32_t data_len) { struct hnb_audio_prim *audio_prim; audio_prim = hnb_audio_prim_alloc(HNB_AUDIO_PRIM_CONN_DATA, PRIM_OP_INDICATION, data_len); audio_prim->u.conn_data_ind.audio_conn_id = audio_conn_id; + audio_prim->u.conn_data_ind.frame_nr = frame_nr; + audio_prim->u.conn_data_ind.fqc = fqc; + audio_prim->u.conn_data_ind.rfci = rfci; audio_prim->u.conn_data_ind.data_len = data_len; if (data_len) { msgb_put(audio_prim->hdr.msg, data_len); @@ -117,13 +120,15 @@ return audio_prim; } -int llsk_audio_tx_conn_data_ind(struct rtp_conn *conn, const uint8_t *payload, uint32_t len) +int llsk_audio_tx_conn_data_ind(struct rtp_conn *conn, uint8_t frame_nr, uint8_t fqc, uint8_t rfci, + const uint8_t *payload, uint32_t len) { struct hnb_audio_prim *audio_prim; int rc; - LOGUE(conn->ue, DLLSK, LOGL_INFO, "Tx AUDIO-CONN_DATA.ind\n"); - audio_prim = hnb_audio_makeprim_conn_data_ind(conn->id, payload, len); + LOGUE(conn->ue, DLLSK, LOGL_DEBUG, "Tx AUDIO-CONN_DATA.ind conn_id=%u fn=%u fqc=%u rfci=%u data_len=%u\n", + conn->id, frame_nr, fqc, rfci, len); + audio_prim = hnb_audio_makeprim_conn_data_ind(conn->id, frame_nr, fqc, rfci, payload, len); if ((rc = osmo_prim_srv_send(conn->ue->hnb->llsk, audio_prim->hdr.msg)) < 0) LOGUE(conn->ue, DLLSK, LOGL_ERROR, "Failed sending AUDIO-CONN_DATA.ind\n"); return rc; @@ -186,7 +191,7 @@ /* Create the socket: */ conn = rtp_conn_alloc(ue); - if ((rc = rtp_conn_setup(conn, &rem_osa)) < 0) { + if ((rc = rtp_conn_setup(conn, &rem_osa, ce_req)) < 0) { LOGUE(ue, DLLSK, LOGL_ERROR, "Rx AUDIO-CONN_ESTABLISH.req: Failed to set up audio socket rem_addr=%s\n", rem_addrstr); return _send_conn_establish_cnf_failed(hnb, ce_req->context_id, 4); @@ -248,14 +253,8 @@ return -EINVAL; } - /* TODO: transmit data_req->data through RTP/Iu-UP socket */ - rc = osmo_rtp_send_frame_ext(conn->socket, data_req->data, - data_req->data_len, GSM_RTP_DURATION, false); - if (rc < 0) { - LOGUE(conn->ue, DLLSK, LOGL_ERROR, - "Rx AUDIO-CONN_DATA.req: Failed sending RTP frame! id=%u data_len=%u\n", - data_req->audio_conn_id, data_req->data_len); - } + /* Transmit data_req->data through RTP/Iu-UP socket */ + rc = rtp_conn_tx_data(conn, data_req->frame_nr, data_req->fqc, data_req->rfci, data_req->data, data_req->data_len); return rc; } diff --git a/src/osmo-hnodeb/rtp.c b/src/osmo-hnodeb/rtp.c index 41fb668..0435c81 100644 --- a/src/osmo-hnodeb/rtp.c +++ b/src/osmo-hnodeb/rtp.c @@ -22,14 +22,88 @@ #include #include +#include +#include #include #include #include +#define HNB_IUUP_MSGB_SIZE 4096 + +static struct osmo_iuup_rnl_prim *llsk_audio_ce_to_iuup_rnl_cfg(void *ctx, const struct hnb_audio_conn_establish_req_param *ce_req) +{ + struct osmo_iuup_rnl_prim *irp; + struct osmo_iuup_rnl_config *cfg; + unsigned int i; + + irp = osmo_iuup_rnl_prim_alloc(ctx, OSMO_IUUP_RNL_CONFIG, PRIM_OP_REQUEST, HNB_IUUP_MSGB_SIZE); + cfg = &irp->u.config; + cfg->transparent = !!ce_req->transparent; + cfg->active = true; + cfg->data_pdu_type = ce_req->data_pdu_type; + cfg->supported_versions_mask = ce_req->supported_versions_mask; + cfg->num_rfci = ce_req->num_rfci; + cfg->num_subflows = ce_req->num_subflows; + OSMO_ASSERT(cfg->num_rfci <= ARRAY_SIZE(cfg->subflow_sizes)); + OSMO_ASSERT(cfg->num_subflows <= ARRAY_SIZE(cfg->subflow_sizes[0])); + for (i = 0; i < cfg->num_rfci; i++) + memcpy(&cfg->subflow_sizes[i][0], &ce_req->subflow_sizes[i][0], cfg->num_subflows*sizeof(uint16_t)); + cfg->IPTIs_present = ce_req->IPTIs_present; + if (cfg->IPTIs_present) + memcpy(cfg->IPTIs, ce_req->IPTIs, cfg->num_rfci); + + cfg->t_init = (struct osmo_iuup_rnl_config_timer){ .t_ms = IUUP_TIMER_INIT_T_DEFAULT, .n_max = IUUP_TIMER_INIT_N_DEFAULT }; + cfg->t_ta = (struct osmo_iuup_rnl_config_timer){ .t_ms = IUUP_TIMER_TA_T_DEFAULT, .n_max = IUUP_TIMER_TA_N_DEFAULT }; + cfg->t_rc = (struct osmo_iuup_rnl_config_timer){ .t_ms = IUUP_TIMER_RC_T_DEFAULT, .n_max = IUUP_TIMER_RC_N_DEFAULT }; + + return irp; +} + +static int _iuup_user_prim_cb(struct osmo_prim_hdr *oph, void *ctx) +{ + struct rtp_conn *conn = (struct rtp_conn *)ctx; + struct osmo_iuup_rnl_prim *irp = (struct osmo_iuup_rnl_prim *)oph; + struct msgb *msg = oph->msg; + int rc; + + switch (OSMO_PRIM_HDR(&irp->oph)) { + case OSMO_PRIM(OSMO_IUUP_RNL_DATA, PRIM_OP_INDICATION): + rc = llsk_audio_tx_conn_data_ind(conn, irp->u.data.frame_nr, irp->u.data.fqc, + irp->u.data.rfci, msgb_l3(msg), msgb_l3len(msg)); + break; + default: + LOGUE(conn->ue, DRTP, LOGL_NOTICE, "Rx Unknown prim=%u op=%u from IuUP layer", + irp->oph.primitive, irp->oph.operation); + rc = -1; + } + + msgb_free(msg); + return rc; +} + +static int _iuup_transport_prim_cb(struct osmo_prim_hdr *oph, void *ctx) +{ + struct rtp_conn *conn = (struct rtp_conn *)ctx; + struct msgb *msg = oph->msg; + int rc; + + rc = osmo_rtp_send_frame_ext(conn->socket, msgb_l2(msg), msgb_l2len(msg), + GSM_RTP_DURATION, false); + if (rc < 0) { + LOGUE(conn->ue, DLLSK, LOGL_ERROR, + "Rx IuUP Transport UNITDATA.req: Failed sending RTP frame! id=%u data_len=%u\n", + conn->id, msgb_l2len(msg)); + } + + msgb_free(msg); + return rc; +} + struct rtp_conn *rtp_conn_alloc(struct hnb_ue *ue) { struct rtp_conn *conn; + char iuup_id[64]; conn = talloc_zero(ue, struct rtp_conn); if (!conn) @@ -37,6 +111,11 @@ conn->ue = ue; + snprintf(iuup_id, sizeof(iuup_id), "ue-%u", conn->ue->conn_id); + conn->iui = osmo_iuup_instance_alloc(conn, iuup_id); + osmo_iuup_instance_set_user_prim_cb(conn->iui, _iuup_user_prim_cb, conn); + osmo_iuup_instance_set_transport_prim_cb(conn->iui, _iuup_transport_prim_cb, conn); + llist_add(&conn->list, &ue->conn_cs.conn_list); return conn; @@ -51,6 +130,10 @@ osmo_rtp_socket_free(conn->socket); conn->socket = NULL; } + if (conn->iui) { + osmo_iuup_instance_free(conn->iui); + conn->iui = NULL; + } llist_del(&conn->list); talloc_free(conn); } @@ -158,13 +241,23 @@ uint32_t timestamp, bool marker) { struct rtp_conn *conn = (struct rtp_conn *)rs->priv; + struct osmo_iuup_tnl_prim *itp; + int rc; LOGUE(conn->ue, DRTP, LOGL_DEBUG, "Rx RTP seq=%u ts=%u M=%u pl=%p len=%u\n", seq_number, timestamp, marker, rtp_pl, rtp_pl_len); - llsk_audio_tx_conn_data_ind(conn, rtp_pl, rtp_pl_len); + + itp = osmo_iuup_tnl_prim_alloc(conn, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_INDICATION, HNB_IUUP_MSGB_SIZE); + itp->oph.msg->l2h = msgb_put(itp->oph.msg, rtp_pl_len); + memcpy(itp->oph.msg->l2h, rtp_pl, rtp_pl_len); + rc = osmo_iuup_tnl_prim_up(conn->iui, itp); + if (rc < 0) + LOGUE(conn->ue, DRTP, LOGL_NOTICE, + "Failed passing rx rtp up to IuUP layer: %d\n", rc); } -int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr) +int rtp_conn_setup(struct rtp_conn *conn, const struct osmo_sockaddr *rem_addr, + const struct hnb_audio_conn_establish_req_param *ce_req) { int rc; char cname[256+4]; @@ -173,6 +266,7 @@ const char *local_wildcard_ipstr = "0.0.0.0"; char remote_ipstr[INET6_ADDRSTRLEN]; uint16_t remote_port; + struct osmo_iuup_rnl_prim *irp; struct hnb_ue *ue = conn->ue; struct hnb *hnb = ue->hnb; @@ -231,9 +325,30 @@ goto free_ret; } + /* Now configure the IuUP layer: */ + irp = llsk_audio_ce_to_iuup_rnl_cfg(conn, ce_req); + rc = osmo_iuup_rnl_prim_down(conn->iui, irp); + if (rc < 0) { + LOGUE(ue, DRTP, LOGL_ERROR, "Failed setting up IuUP layer: %d\n", rc); + goto free_ret; + } + return rc; free_ret: osmo_rtp_socket_free(conn->socket); conn->socket = NULL; return rc; } + +int rtp_conn_tx_data(struct rtp_conn *conn, uint8_t frame_nr, uint8_t fqc, uint8_t rfci, const uint8_t *data, unsigned int data_len) +{ + struct osmo_iuup_rnl_prim *irp; + + irp = osmo_iuup_rnl_prim_alloc(conn, OSMO_IUUP_RNL_DATA, PRIM_OP_REQUEST, HNB_IUUP_MSGB_SIZE); + irp->u.data.rfci = rfci; + irp->u.data.frame_nr = frame_nr; + irp->u.data.fqc = fqc; + irp->oph.msg->l3h = msgb_put(irp->oph.msg, data_len); + memcpy(irp->oph.msg->l3h, data, data_len); + return osmo_iuup_rnl_prim_down(conn->iui, irp); +} -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ie137809e1f91dfd702853c52be97ca79e8604eab Gerrit-Change-Number: 26671 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 10:54:33 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 24 Dec 2021 10:54:33 +0000 Subject: Change in osmo-hnodeb[master]: Get rid of libgtp for GTP-U In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26675 ) Change subject: Get rid of libgtp for GTP-U ...................................................................... Get rid of libgtp for GTP-U It doesn't make much sense to pull whole libgtp to implement only the user plan side of GTP. Let's drop it and add a minimal GTP-U implementation here. Related: SYS#5516 Change-Id: I53ad4915aaed3bc7574036e963be10514e370fe2 --- M configure.ac M contrib/jenkins.sh M contrib/osmo-hnodeb.spec.in M debian/control M include/osmocom/hnodeb/gtp.h M include/osmocom/hnodeb/hnodeb.h M src/osmo-hnodeb/Makefile.am M src/osmo-hnodeb/gtp.c M src/osmo-hnodeb/hnb.c M src/osmo-hnodeb/llsk_gtp.c 10 files changed, 264 insertions(+), 172 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 8a34b82..e96a6a1 100644 --- a/configure.ac +++ b/configure.ac @@ -67,7 +67,6 @@ PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 0.8.0) PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 0.8.0) PKG_CHECK_MODULES(LIBOSMOHNBAP, libosmo-hnbap >= 0.8.0) -PKG_CHECK_MODULES(LIBGTP, libgtp >= 1.8.0) dnl checks for header files diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 3225de2..7001013 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -34,7 +34,6 @@ osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sccp osmo-build-dep.sh libasn1c -osmo-build-dep.sh osmo-ggsn osmo-build-dep.sh osmo-iuh # Additional configure options and depends diff --git a/contrib/osmo-hnodeb.spec.in b/contrib/osmo-hnodeb.spec.in index afa1816..aa33057 100644 --- a/contrib/osmo-hnodeb.spec.in +++ b/contrib/osmo-hnodeb.spec.in @@ -47,7 +47,6 @@ BuildRequires: pkgconfig(libosmo-rua) >= 0.8.0 BuildRequires: pkgconfig(talloc) BuildRequires: pkgconfig(libasn1c) >= 0.9.30 -BuildRequires: pkgconfig(libgtp) >= 1.8.0 %{?systemd_requires} %description diff --git a/debian/control b/debian/control index 503b202..a306e10 100644 --- a/debian/control +++ b/debian/control @@ -13,7 +13,6 @@ python3-minimal, libtalloc-dev, libasn1c-dev (>= 0.9.30), - libgtp-dev (>= 1.8.0), libsctp-dev, libosmocore-dev (>= 1.6.0), libosmo-sigtran-dev (>= 1.5.0), diff --git a/include/osmocom/hnodeb/gtp.h b/include/osmocom/hnodeb/gtp.h index 477e82b..5fa47c3 100644 --- a/include/osmocom/hnodeb/gtp.h +++ b/include/osmocom/hnodeb/gtp.h @@ -18,9 +18,6 @@ */ #pragma once -#include -#include - #include #include @@ -38,11 +35,11 @@ struct osmo_sockaddr rem_addr; uint32_t loc_tei; uint32_t rem_tei; - struct pdp_t *pdp_lib; + uint16_t seq_nr; }; struct gtp_conn *gtp_conn_alloc(struct hnb_ue *ue); void gtp_conn_free(struct gtp_conn *conn); int gtp_conn_setup(struct gtp_conn *conn, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei); -int gtp_conn_tx(struct gtp_conn *conn, void *gtpu_payload, unsigned gtpu_payload_len); +int gtp_conn_tx(struct gtp_conn *conn, const uint8_t *gtpu_payload, unsigned gtpu_payload_len); diff --git a/include/osmocom/hnodeb/hnodeb.h b/include/osmocom/hnodeb/hnodeb.h index 82b43c3..924e1ac 100644 --- a/include/osmocom/hnodeb/hnodeb.h +++ b/include/osmocom/hnodeb/hnodeb.h @@ -107,8 +107,7 @@ struct gtp { char *cfg_local_addr; struct osmo_sockaddr local_addr; - struct gsn_t *gsn; - struct osmo_fd fd1u; + struct osmo_wqueue wq1u; } gtp; uint16_t rnc_id; diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 6edbf88..27987a1 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -19,7 +19,6 @@ $(LIBOSMORUA_CFLAGS) \ $(LIBOSMORANAP_CFLAGS) \ $(LIBOSMOHNBAP_CFLAGS) \ - $(LIBGTP_CFLAGS) \ $(NULL) AM_LDFLAGS = \ @@ -63,5 +62,4 @@ $(LIBOSMORANAP_LIBS) \ $(LIBOSMOHNBAP_LIBS) \ $(LIBSCTP_LIBS) \ - $(LIBGTP_LIBS) \ $(NULL) diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c index f7d9a14..c22de65 100644 --- a/src/osmo-hnodeb/gtp.c +++ b/src/osmo-hnodeb/gtp.c @@ -23,11 +23,27 @@ #include #include #include +#include -#include -#include +/* 3GPP TS 29.281 */ +struct gtp1u_hdr { /* 3GPP TS 29.281 */ +#if OSMO_IS_LITTLE_ENDIAN + uint8_t pn:1, /* N-PDU Number flag */ + s:1, /* Sequence number flag */ + e:1, /* Extension header flag */ + spare:1, + pt:1, /* Protocol Type: GTP=1, GTP'=0 */ + version:3; /* Version: 1 */ +#elif OSMO_IS_BIG_ENDIAN + uint8_t version:3, pt:1, spare:1, e:1, s:1, pn:1; +#endif + uint8_t msg_type; + uint16_t length; + uint32_t tei; /* 05 - 08 Tunnel Endpoint ID */ + uint8_t data[0]; +} __attribute__((packed)); -static uint32_t next_gtp_conn_id = 0; +static uint32_t next_gtp_conn_id = 1; struct gtp_conn *gtp_conn_alloc(struct hnb_ue *ue) { @@ -49,14 +65,231 @@ if (!conn) return; - if (conn->pdp_lib) { - pdp_freepdp(conn->pdp_lib); - conn->pdp_lib = NULL; - } llist_del(&conn->list); talloc_free(conn); } +int gtp_conn_setup(struct gtp_conn *conn, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei) +{ + struct hnb_ue *ue = conn->ue; + struct hnb *hnb = ue->hnb; + + LOGUE(ue, DGTP, LOGL_INFO, "Creating PDP context\n"); + + + if (rem_addr->u.sa.sa_family != AF_INET) { + LOGUE(ue, DGTP, LOGL_ERROR, "Failed creating PDP context: unsupported proto family %u\n", + rem_addr->u.sa.sa_family); + return -ENOTSUP; + } + + conn->id = next_gtp_conn_id++; /* TODO: validate next one is not already taken due to wrap-around */ + + conn->loc_addr = hnb->gtp.local_addr; + conn->rem_addr = *rem_addr; + conn->rem_tei = rem_tei; + conn->loc_tei = conn->id; /* We use conn ID as local TEI */ + return 0; +} + +int gtp_conn_tx(struct gtp_conn *conn, const uint8_t *gtpu_payload, unsigned gtpu_payload_len) +{ + int rc; + struct hnb_ue *ue; + struct hnb *hnb; + struct msgb *msg; + struct gtp1u_hdr *hdr; + struct osmo_sockaddr *sa; + const uint8_t opt_hdr_len = 4; + unsigned msg_len = sizeof(*hdr) + opt_hdr_len + gtpu_payload_len; + + if (!conn) { + LOGP(DGTP, LOGL_ERROR, "Tx: GTP-U conn not available\n"); + return -EINVAL; + } + + ue = conn->ue; + hnb = ue->hnb; + + if (hnb->gtp.wq1u.bfd.fd == -1) { + LOGP(DGTP, LOGL_ERROR, "Tx: GTP-U socket not available\n"); + return -EINVAL; + } + + if (gtpu_payload_len == 0) { + LOGP(DGTP, LOGL_ERROR, "Tx: GTP-U len=0\n"); + return -EINVAL; + } + + msg = msgb_alloc_c(hnb, sizeof(*sa) + msg_len, "gtp-ul"); + + sa = (struct osmo_sockaddr *)msgb_put(msg, sizeof(*sa)); + *sa = conn->rem_addr; + + hdr = (struct gtp1u_hdr *)msgb_put(msg, msg_len); + hdr->pn = 0; + hdr->s = 1; + hdr->e = 0; + hdr->spare = 0; + hdr->pt = 1; + hdr->version = 1; + hdr->msg_type = 0xff; + osmo_store16be(gtpu_payload_len + opt_hdr_len, &hdr->length); + osmo_store32be(conn->rem_tei, &hdr->tei); + osmo_store16be(conn->seq_nr, &hdr->data[0]); + conn->seq_nr++; + /* byes 2 and 3 are set to 0 */ + memcpy(&hdr->data[opt_hdr_len], gtpu_payload, gtpu_payload_len); + + rc = osmo_wqueue_enqueue(&hnb->gtp.wq1u, msg); + if (rc < 0) + msgb_free(msg); + + return rc; +} + +/* Called whenever we receive a DATA packet */ +static int hnb_gtp_rx_gtp(struct hnb *hnb, struct msgb *msg, const struct osmo_sockaddr *from) +{ + struct gtp_conn *conn; + struct hnb_ue *ue; + struct gtp1u_hdr *hdr; + uint32_t tei; + struct hnb_gtp_prim *gtp_prim; + int rc; + + hdr = (struct gtp1u_hdr *)msgb_data(msg); + tei = osmo_load32be(&hdr->tei); + + /* The local TEI is the GTP conn_id: */ + conn = hnb_find_gtp_conn_by_id(hnb, tei); + if (!conn) { + LOGP(DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind len=%u with no conn!\n", + msgb_l3len(msg)); + rc = -EINVAL; + goto free_ret; + } + ue = conn->ue; + + if (osmo_sockaddr_cmp(from, &conn->rem_addr)) { + LOGUE(ue, DGTP, LOGL_NOTICE, "Rx DL GTP-U loc_tei=0x%08x from unexpected addr=%s!\n", + tei, osmo_sockaddr_to_str(from)); + rc = -EINVAL; + goto free_ret; + } + ue = conn->ue; + + if (!ue->conn_ps.active) { + LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind len=%u but UE conn_ps is not active!\n", + msgb_l3len(msg)); + rc = -EINVAL; + goto free_ret; + } + hnb = ue->hnb; + + LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind len=%u\n", msgb_l3len(msg)); + gtp_prim = hnb_gtp_makeprim_conn_data_ind(conn->id, msgb_l3(msg), msgb_l3len(msg)); + if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { + LOGUE(ue, DGTP, LOGL_ERROR, "Failed Tx GTP-CONN_DATA.ind len=%u\n", + msgb_l3len(msg)); + } +free_ret: + msgb_free(msg); + return rc; +} + +static int hnb_gtp_wq_read_cb(struct osmo_fd *fd) +{ + struct hnb *hnb = (struct hnb *)fd->data; + struct msgb *msg; + struct gtp1u_hdr *hdr; + int rc; + struct osmo_sockaddr peer; + socklen_t peerlen = sizeof(peer.u.sas); + unsigned int opt_hdr_len; + uint16_t pl_len; + + msg = msgb_alloc_c(hnb, 4096, "gtp-dl"); + + rc = recvfrom(hnb->gtp.wq1u.bfd.fd, msgb_data(msg), msg->data_len, 0, + &peer.u.sa, &peerlen); + if (rc <= 0) { + LOGP(DGTP, LOGL_ERROR, "recvfrom() failed: rc = %d error = %s\n", + rc, rc ? strerror(errno) : "No error"); + goto free_ret; + } + msgb_put(msg, rc); + + /* Do some sanity checks: */ + if (msgb_length(msg) < sizeof(*hdr)) { + LOGP(DGTP, LOGL_ERROR, "Rx GTP-U packet with size %u < %zu (header)\n", + msgb_length(msg), sizeof(*hdr)); + rc = -EINVAL; + goto free_ret; + } + + hdr = (struct gtp1u_hdr *)msgb_data(msg); + pl_len = osmo_load16be(&hdr->length); + + /* Do some sanity checks: */ + if (hdr->version != 1) { + LOGP(DGTP, LOGL_ERROR, "Rx GTP-U version %u != 1\n", hdr->version); + rc = -ENOTSUP; + goto free_ret; + } + + if (hdr->e == 1) { + LOGP(DGTP, LOGL_ERROR, "Rx GTP-U with Extension Header not supported\n"); + rc = -ENOTSUP; + goto free_ret; + } + + if (hdr->s || hdr->pn || hdr->e) + opt_hdr_len = 4; + if (hdr->pn) + opt_hdr_len = 0; + + if (msgb_length(msg) < sizeof(*hdr) + opt_hdr_len) { + LOGP(DGTP, LOGL_ERROR, "Rx GTP-U packet with size %u < %zu (header + opt)\n", + msgb_length(msg), sizeof(*hdr) + opt_hdr_len); + rc = -EINVAL; + goto free_ret; + } + + msg->l3h = msgb_data(msg) + sizeof(*hdr) + opt_hdr_len; + + if (pl_len < opt_hdr_len || msgb_l3len(msg) != (pl_len - opt_hdr_len)) { + LOGP(DGTP, LOGL_ERROR, "Rx GTP-U packet with payload size %u != %u (header)\n", + msgb_length(msg), pl_len - opt_hdr_len); + rc = -EINVAL; + goto free_ret; + } + + return hnb_gtp_rx_gtp(hnb, msg, &peer); +free_ret: + msgb_free(msg); + return rc; +} + +static int hnb_gtp_wq_write_cb(struct osmo_fd *fd, struct msgb *msg) +{ + struct hnb *hnb = (struct hnb *)fd->data; + struct osmo_sockaddr *rem_addr; + int rc; + + rem_addr = (struct osmo_sockaddr *)msgb_data(msg); + msgb_pull(msg, sizeof(*rem_addr)); + + rc = sendto(hnb->gtp.wq1u.bfd.fd, msgb_data(msg), msgb_length(msg), 0, + &rem_addr->u.sa, sizeof(*rem_addr)); + if (rc < 0) { + int err = errno; + LOGP(DGTP, LOGL_ERROR, "GTP1-U sendto(len=%d, to=%s) failed: Error = %s\n", + msgb_length(msg), osmo_sockaddr_to_str(rem_addr), strerror(err)); + } + return rc; +} + /* Get osa of locally bound GTP-U socket */ static int sk_get_bound_addr(int fd, struct osmo_sockaddr *osa) { @@ -70,173 +303,43 @@ return 0; } -/* Called whenever we receive a DATA packet */ -static int hnb_gtp_cb_data_ind(struct pdp_t *lib, void *packet, unsigned int len) -{ - struct hnb_gtp_prim *gtp_prim; - struct gtp_conn *conn = lib->priv; - struct hnb_ue *ue; - struct hnb *hnb; - int rc; - - if (!conn) { - LOGP(DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u with no conn!\n", - packet, len); - return -EINVAL; - } - ue = conn->ue; - - if (!ue->conn_ps.active) { - LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n", - packet, len); - return -EINVAL; - } - hnb = ue->hnb; - - LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len); - gtp_prim = hnb_gtp_makeprim_conn_data_ind(conn->id, packet, len); - if ((rc = osmo_prim_srv_send(hnb->llsk, gtp_prim->hdr.msg)) < 0) { - LOGUE(ue, DGTP, LOGL_ERROR, "Failed Tx GTP-CONN_DATA.ind data=%p len=%u\n", - packet, len); - } - return rc; -} - -/* libgtp select loop integration */ -static int hnb_gtp_fd_cb(struct osmo_fd *fd, unsigned int what) -{ - struct hnb *hnb = fd->data; - int rc; - - if (!(what & OSMO_FD_READ)) - return 0; - - switch (fd->priv_nr) { - case 0: - rc = gtp_decaps1u(hnb->gtp.gsn); - break; - default: - rc = -EINVAL; - break; - } - return rc; -} - int hnb_gtp_bind(struct hnb *hnb) { int rc; - struct gsn_t *gsn; - struct in_addr inaddr; - rc = inet_pton(AF_INET, hnb->gtp.cfg_local_addr, &inaddr); - if (rc <= 0) - return -EINVAL; + OSMO_ASSERT(hnb->gtp.wq1u.bfd.fd == -1); - /* TODO: add new mode GTP_MODE_GTPU_ONLY to set up gtpu side only (and ignore statedir) */ - rc = gtp_new(&gsn, "/tmp", &inaddr, GTP_MODE_SGSN); + hnb->gtp.wq1u.read_cb = hnb_gtp_wq_read_cb; + hnb->gtp.wq1u.write_cb = hnb_gtp_wq_write_cb; + + rc = osmo_sock_init2_ofd(&hnb->gtp.wq1u.bfd, AF_UNSPEC, SOCK_DGRAM, IPPROTO_UDP, + hnb->gtp.cfg_local_addr, 2152, NULL, 0, OSMO_SOCK_F_BIND); if (rc < 0) { LOGP(DGTP, LOGL_ERROR, "Failed to set up GTP socket: %s\n", strerror(-rc)); return rc; } - rc = sk_get_bound_addr(gsn->fd1u, &hnb->gtp.local_addr); + rc = sk_get_bound_addr(hnb->gtp.wq1u.bfd.fd, &hnb->gtp.local_addr); if (rc < 0) { LOGP(DGTP, LOGL_ERROR, "Failed to get GTP-U socket bound address: %s\n", strerror(-rc)); goto free_ret; } - - osmo_fd_setup(&hnb->gtp.fd1u, gsn->fd1u, OSMO_FD_READ, hnb_gtp_fd_cb, hnb, 0); - if ((rc = osmo_fd_register(&hnb->gtp.fd1u)) < 0) - goto free_ret; - - gtp_set_cb_data_ind(gsn, hnb_gtp_cb_data_ind); - - hnb->gtp.gsn = gsn; return 0; free_ret: - gtp_free(gsn); - hnb->gtp.fd1u.fd = -1; + if (hnb->gtp.wq1u.bfd.fd != -1) { + close(hnb->gtp.wq1u.bfd.fd); + hnb->gtp.wq1u.bfd.fd = -1; + } return rc; } void hnb_gtp_unbind(struct hnb *hnb) { - osmo_fd_unregister(&hnb->gtp.fd1u); - gtp_free(hnb->gtp.gsn); - hnb->gtp.gsn = NULL; - hnb->gtp.fd1u.fd = -1; -} - -int gtp_conn_setup(struct gtp_conn *conn, const struct osmo_sockaddr *rem_addr, uint32_t rem_tei) -{ - int rc; - struct hnb_ue *ue = conn->ue; - struct hnb *hnb = ue->hnb; - struct pdp_t *pdp; - struct in_addr rem_in; - - LOGUE(ue, DGTP, LOGL_INFO, "Creating PDP context\n"); - - - if (rem_addr->u.sa.sa_family != AF_INET) { - LOGUE(ue, DGTP, LOGL_ERROR, "Failed creating PDP context: unsupported proto family %u\n", - rem_addr->u.sa.sa_family); - return -ENOTSUP; + if (hnb->gtp.wq1u.bfd.fd != -1) { + osmo_wqueue_clear(&hnb->gtp.wq1u); + osmo_fd_unregister(&hnb->gtp.wq1u.bfd); + close(hnb->gtp.wq1u.bfd.fd); + hnb->gtp.wq1u.bfd.fd = -1; } - - conn->rem_addr = *rem_addr; - conn->rem_tei = rem_tei; - rem_in = rem_addr->u.sin.sin_addr; - conn->id = next_gtp_conn_id++; /* TODO: validate next one is not already taken due to wrap-around */ - - rc = gtp_pdp_newpdp(hnb->gtp.gsn, &pdp, conn->id, 0 /* TODO: NSAPI? */, NULL); - if (rc < 0) { - LOGUE(ue, DGTP, LOGL_ERROR, "Failed creating PDP context: %s\n", strerror(-rc)); - return rc; - } - pdp->priv = conn; - conn->pdp_lib = pdp; - - pdp->teid_gn = rem_tei; - pdp->version = 1; - pdp->hisaddr0 = rem_in; - pdp->hisaddr1 = rem_in; - - pdp->gsnru.l = sizeof(rem_in); - memcpy(pdp->gsnru.v, &rem_in, sizeof(rem_in)); - - - pdp->gsnlu.l = sizeof(hnb->gtp.local_addr.u.sin.sin_addr); - memcpy(pdp->gsnlu.v, &hnb->gtp.local_addr.u.sin.sin_addr, - sizeof(hnb->gtp.local_addr.u.sin.sin_addr)); - - conn->loc_addr = hnb->gtp.local_addr; - //loc_addr->u.sin.sin_family = AF_INET; - //loc_addr->u.sin.sin_addr = hnb->gtp.gsn->gsnu; - //loc_addr->u.sin.sin_port = GTP1U_PORT; - conn->loc_tei = pdp->teid_own; - return 0; -} - -int gtp_conn_tx(struct gtp_conn *conn, void *gtpu_payload, unsigned gtpu_payload_len) -{ - int rc; - struct hnb_ue *ue; - struct hnb *hnb; - - if (!conn || !conn->pdp_lib) { - LOGP(DGTP, LOGL_ERROR, "Tx: PDP Ctx not available\n"); - return -EINVAL; - } - - ue = conn->ue; - hnb = ue->hnb; - if (!hnb->gtp.gsn) { - LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n"); - return -EINVAL; - } - - rc = gtp_data_req(hnb->gtp.gsn, conn->pdp_lib, gtpu_payload, gtpu_payload_len); - return rc; } diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c index fe2f4f5..18f39b4 100644 --- a/src/osmo-hnodeb/hnb.c +++ b/src/osmo-hnodeb/hnb.c @@ -61,7 +61,9 @@ hnb->rtp.priority = -1; hnb->gtp.cfg_local_addr = talloc_strdup(hnb, "0.0.0.0"); - hnb->gtp.fd1u.fd = -1; + osmo_wqueue_init(&hnb->gtp.wq1u, 1024); + hnb->gtp.wq1u.bfd.data = hnb; + hnb->gtp.wq1u.bfd.fd = -1; hnb->shutdown_fi = osmo_fsm_inst_alloc(&hnb_shutdown_fsm, hnb, hnb, LOGL_INFO, NULL); @@ -90,10 +92,7 @@ osmo_prim_srv_link_free(hnb->llsk_link); hnb->llsk_link = NULL; - if (hnb->gtp.gsn) { - gtp_free(hnb->gtp.gsn); - hnb->gtp.gsn = NULL; - } + hnb_gtp_unbind(hnb); talloc_free(hnb); } diff --git a/src/osmo-hnodeb/llsk_gtp.c b/src/osmo-hnodeb/llsk_gtp.c index a224d56..775df50 100644 --- a/src/osmo-hnodeb/llsk_gtp.c +++ b/src/osmo-hnodeb/llsk_gtp.c @@ -138,7 +138,7 @@ union u_addr loc_uaddr = {0}; struct gtp_conn *conn = NULL; - rc = ll_addr2osa(ce_req->remote_gtpu_address_type, &ce_req->remote_gtpu_addr, GTP1U_PORT, &rem_osa); + rc = ll_addr2osa(ce_req->remote_gtpu_address_type, &ce_req->remote_gtpu_addr, 2152, &rem_osa); if (rc < 0) { LOGP(DLLSK, LOGL_ERROR, "Rx GTP-CONN_ESTABLISH.req: ctx=%u with unexpected address type %u\n", ce_req->context_id, ce_req->remote_gtpu_address_type); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I53ad4915aaed3bc7574036e963be10514e370fe2 Gerrit-Change-Number: 26675 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 12:17:11 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 24 Dec 2021 12:17:11 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: use osmo-config-merge to generate config files In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 ) Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 Gerrit-Change-Number: 20622 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Assignee: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 24 Dec 2021 12:17:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 12:17:16 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 24 Dec 2021 12:17:16 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: move generic config files into a directory In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26681 ) Change subject: ttcn3-bts-test: move generic config files into a directory ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1bc5c51306525c6829e9d8e2991555a99c9b49a2 Gerrit-Change-Number: 26681 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 24 Dec 2021 12:17:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 12:22:25 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 24 Dec 2021 12:22:25 +0000 Subject: Change in docker-playground[master]: osmo-hnodeb-master: no longer depend on libgtp In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26676 ) Change subject: osmo-hnodeb-master: no longer depend on libgtp ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26676 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4e223823d08c7e9e17d87f54d9554429d31c8091 Gerrit-Change-Number: 26676 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 24 Dec 2021 12:22:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 12:22:27 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 24 Dec 2021 12:22:27 +0000 Subject: Change in docker-playground[master]: osmo-hnodeb-master: no longer depend on libgtp In-Reply-To: References: Message-ID: pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26676 ) Change subject: osmo-hnodeb-master: no longer depend on libgtp ...................................................................... osmo-hnodeb-master: no longer depend on libgtp Newer osmo-hnodeb no longer depend on libgtp, get rid od the dependency. Depends: osmo-hnodeb.git Change-Id I53ad4915aaed3bc7574036e963be10514e370fe2 Related: SYS#5516 Change-Id: I4e223823d08c7e9e17d87f54d9554429d31c8091 --- M osmo-hnodeb-master/Dockerfile 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Verified diff --git a/osmo-hnodeb-master/Dockerfile b/osmo-hnodeb-master/Dockerfile index a7ff068..1a3ded9 100644 --- a/osmo-hnodeb-master/Dockerfile +++ b/osmo-hnodeb-master/Dockerfile @@ -10,7 +10,6 @@ libosmo-abis-dev \ libosmo-netif-dev \ libosmo-sigtran-dev \ - libgtp-dev \ libasn1c-dev && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26676 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4e223823d08c7e9e17d87f54d9554429d31c8091 Gerrit-Change-Number: 26676 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 13:32:15 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 24 Dec 2021 13:32:15 +0000 Subject: Change in osmo-ttcn3-hacks[master]: RTP IuUP Emulation: Avoid spamming with retransmitted Init References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26685 ) Change subject: RTP IuUP Emulation: Avoid spamming with retransmitted Init ...................................................................... RTP IuUP Emulation: Avoid spamming with retransmitted Init Until now, an Init was sent on each RTP transmit period, clogging the pcap files. Moreover, this is break by design, since transmitting another Init so close the the previous one would give no time to the transmitter to receive the Init ACk and move state, which means the other end would potentially be reconfigured each time (for each Init). Change-Id: I8e299a3fe49f9d31cae182f7ed4dc0ea3fc22ba2 --- M library/IuUP_Emulation.ttcn M library/RTP_Emulation.ttcn 2 files changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/26685/1 diff --git a/library/IuUP_Emulation.ttcn b/library/IuUP_Emulation.ttcn index b35602c..a4ca659 100644 --- a/library/IuUP_Emulation.ttcn +++ b/library/IuUP_Emulation.ttcn @@ -124,8 +124,12 @@ select (st.state) { case (ST_INIT) { if (st.cfg.active_init) { - /* send INIT */ - pdu := valueof(ts_IuUP_INIT('160051673C01270000820000001710000100'O)); + if (not isvalue(st.pending_tx_pdu)) { + /* send INIT */ + pdu := valueof(ts_IuUP_INIT('160051673C01270000820000001710000100'O)); + st.pending_tx_pdu := pdu; + } /* else: wait for INIT-ACK return ''O at the end */ + } else { /* wait for INIT */ if (isvalue(st.pending_tx_pdu)) { diff --git a/library/RTP_Emulation.ttcn b/library/RTP_Emulation.ttcn index b2360dc..bdca75d 100644 --- a/library/RTP_Emulation.ttcn +++ b/library/RTP_Emulation.ttcn @@ -345,6 +345,10 @@ private function f_tx_rtp(octetstring payload, BIT1 marker := '0'B) runs on RTP_Emulation_CT { if (g_cfg.iuup_mode) { payload := f_IuUP_Em_tx_encap(g_iuup_ent, payload); + if (lengthof(payload) == 0) { + /* Nothing to transmit, waiting for INIT-ACK */ + return; + } } var PDU_RTP rtp := valueof(ts_RTP(g_cfg.tx_ssrc, g_cfg.tx_payload_type, g_tx_next_seq, g_tx_next_ts, payload, marker)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8e299a3fe49f9d31cae182f7ed4dc0ea3fc22ba2 Gerrit-Change-Number: 26685 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 13:48:35 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 24 Dec 2021 13:48:35 +0000 Subject: Change in osmo-mgw[master]: Define mgcp_rtp_end.output_enabled as bool References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26686 ) Change subject: Define mgcp_rtp_end.output_enabled as bool ...................................................................... Define mgcp_rtp_end.output_enabled as bool Change-Id: I55f7796ef774f86050041f2c5e3a2f8f7d1f56df --- M include/osmocom/mgcp/mgcp_network.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_msg.c M tests/mgcp/mgcp_test.c 4 files changed, 6 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/86/26686/1 diff --git a/include/osmocom/mgcp/mgcp_network.h b/include/osmocom/mgcp/mgcp_network.h index b9cf5e3..e3fa3b1 100644 --- a/include/osmocom/mgcp/mgcp_network.h +++ b/include/osmocom/mgcp/mgcp_network.h @@ -110,8 +110,8 @@ uint32_t packet_duration_ms; int maximum_packet_time; /* -1: not set */ char *fmtp_extra; - /* are we transmitting packets (1) or dropping (0) outbound packets */ - int output_enabled; + /* are we transmitting packets (true) or dropping (false) outbound packets */ + bool output_enabled; /* FIXME: This parameter can be set + printed, but is nowhere used! */ int force_output_ptime; diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c index 5c3c60e..9c2fb0f 100644 --- a/src/libosmo-mgcp/mgcp_conn.c +++ b/src/libosmo-mgcp/mgcp_conn.c @@ -108,7 +108,7 @@ /* Set default values */ end->frames_per_packet = 0; /* unknown */ end->packet_duration_ms = DEFAULT_RTP_AUDIO_PACKET_DURATION_MS; - end->output_enabled = 0; + end->output_enabled = false; end->maximum_packet_time = -1; conn_rtp->rate_ctr_group = rate_ctr_group_alloc(conn, &rate_ctr_group_desc, rate_ctr_index++); diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c index f36fa71..4581b76 100644 --- a/src/libosmo-mgcp/mgcp_msg.c +++ b/src/libosmo-mgcp/mgcp_msg.c @@ -110,8 +110,7 @@ /* Special handling for RTP connections */ if (conn->type == MGCP_CONN_TYPE_RTP) { - conn->u.rtp.end.output_enabled = - conn->mode & MGCP_CONN_SEND_ONLY ? 1 : 0; + conn->u.rtp.end.output_enabled = !!(conn->mode & MGCP_CONN_SEND_ONLY); } LOGPENDP(endp, DLMGCP, LOGL_DEBUG, "conn:%s\n", mgcp_conn_dump(conn)); @@ -121,7 +120,7 @@ /* Special handling f?r RTP connections */ if (conn->type == MGCP_CONN_TYPE_RTP) { - LOGPCONN(conn, DLMGCP, LOGL_DEBUG, "output_enabled %d\n", + LOGPCONN(conn, DLMGCP, LOGL_DEBUG, "output_enabled %u\n", conn->u.rtp.end.output_enabled); } diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index a8aad14..9b4933c 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -868,7 +868,7 @@ printf("Connection mode not set\n"); OSMO_ASSERT(conn->end.output_enabled - == (conn->conn->mode & MGCP_CONN_SEND_ONLY ? 1 : 0)); + == !!(conn->conn->mode & MGCP_CONN_SEND_ONLY)); conn->conn->mode |= CONN_UNMODIFIED; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I55f7796ef774f86050041f2c5e3a2f8f7d1f56df Gerrit-Change-Number: 26686 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 24 18:50:09 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 24 Dec 2021 18:50:09 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: use osmo-config-merge to generate config files In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 ) Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files ...................................................................... Patch Set 3: > Patch Set 3: Code-Review+1 > > please test with a copy of the ttcn3-bts-test job and don't build your private branches in the "production" ttcn3-bts-test job. I've just received build failure notification and tried to understand what's happenign, grep'ing for osmo-config-merge everywhere until I realized that somebody had used that 'production testing' job to build a private branch. I am sorry, this was indeed a bad idea. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 Gerrit-Change-Number: 20622 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Assignee: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 24 Dec 2021 18:50:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Dec 26 02:23:03 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Sun, 26 Dec 2021 02:23:03 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Set proper CRC Header for ACK Initialization In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26598 ) Change subject: mgcp_network.c: Set proper CRC Header for ACK Initialization ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26598/1/src/libosmo-mgcp/mgcp_network.c File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26598/1/src/libosmo-mgcp/mgcp_network.c at 1228 PS1, Line 1228: data[2] = 0x09; /* Patch CRC Header to adapt to new header above */ Shouldn't this be 0x24 (0x09 << 2)? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f Gerrit-Change-Number: 26598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: lynxis lazus Gerrit-Comment-Date: Sun, 26 Dec 2021 02:23:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 27 08:54:22 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 27 Dec 2021 08:54:22 +0000 Subject: Change in libosmocore[master]: contrib/libosmocore.spec.in: mention osmo-config-merge in utils References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26687 ) Change subject: contrib/libosmocore.spec.in: mention osmo-config-merge in utils ...................................................................... contrib/libosmocore.spec.in: mention osmo-config-merge in utils Change-Id: I4d3d06b2f27ded60f9408e326202c5c6bf6d35d1 --- M contrib/libosmocore.spec.in 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/26687/1 diff --git a/contrib/libosmocore.spec.in b/contrib/libosmocore.spec.in index 3018280..c2fe738 100644 --- a/contrib/libosmocore.spec.in +++ b/contrib/libosmocore.spec.in @@ -54,7 +54,8 @@ This package contains a program for frequency calculation for GSM called "osmo-arfcn", and a program called "osmo-auc-gen" that is used -for testing GSM authentication. +for testing GSM authentication, as well as "osmo-config-merge", a tool +for merging Osmocom configuration files. %package -n libosmocodec0 Summary: GSM 06.10, 06.20, 06.60, 06.90 codec library -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4d3d06b2f27ded60f9408e326202c5c6bf6d35d1 Gerrit-Change-Number: 26687 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 27 09:22:21 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 27 Dec 2021 09:22:21 +0000 Subject: Change in osmo-ci[master]: tasks/ttcn3-slave.yml: also install libosmocore-utils References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26688 ) Change subject: tasks/ttcn3-slave.yml: also install libosmocore-utils ...................................................................... tasks/ttcn3-slave.yml: also install libosmocore-utils This package provides osmo-config-merge, which is going to be used by docker-playground for generating configuration files. Change-Id: I87e54440a6b399aa0f0461ebf668991b5cdd0b07 Related: https://gerrit.osmocom.org/c/docker-playground/+/20622 --- M ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/88/26688/1 diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml b/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml index fbfc1ec..5e15254 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml @@ -24,9 +24,11 @@ filename: obs_osmocom update_cache: yes -- name: install titan +- name: install titan and libosmocore-utils apt: - name: eclipse-titan + name: + - eclipse-titan + - libosmocore-utils update_cache: yes cache_valid_time: 3600 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I87e54440a6b399aa0f0461ebf668991b5cdd0b07 Gerrit-Change-Number: 26688 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 27 09:25:03 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 27 Dec 2021 09:25:03 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: move generic config files into a directory In-Reply-To: References: Message-ID: Hello laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/26681 to look at the new patch set (#3). Change subject: ttcn3-bts-test: move generic config files into a directory ...................................................................... ttcn3-bts-test: move generic config files into a directory Change-Id: I1bc5c51306525c6829e9d8e2991555a99c9b49a2 --- M ttcn3-bts-test/Dockerfile M ttcn3-bts-test/Makefile R ttcn3-bts-test/generic/BTS_Tests.cfg R ttcn3-bts-test/generic/osmo-bsc.confmerge R ttcn3-bts-test/generic/osmo-bts.confmerge M ttcn3-bts-test/jenkins.sh 6 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/81/26681/3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1bc5c51306525c6829e9d8e2991555a99c9b49a2 Gerrit-Change-Number: 26681 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 27 14:38:29 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 27 Dec 2021 14:38:29 +0000 Subject: Change in libosmocore[master]: contrib/libosmocore.spec.in: mention osmo-config-merge in utils In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26687 ) Change subject: contrib/libosmocore.spec.in: mention osmo-config-merge in utils ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4d3d06b2f27ded60f9408e326202c5c6bf6d35d1 Gerrit-Change-Number: 26687 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 27 Dec 2021 14:38:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 27 14:39:36 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 27 Dec 2021 14:39:36 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: move generic config files into a directory In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/26681 ) Change subject: ttcn3-bts-test: move generic config files into a directory ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1bc5c51306525c6829e9d8e2991555a99c9b49a2 Gerrit-Change-Number: 26681 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 27 Dec 2021 14:39:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 27 14:52:53 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 27 Dec 2021 14:52:53 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Fix byte alignment of CRC Header for ACK Initialization References: Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26689 ) Change subject: mgcp_network.c: Fix byte alignment of CRC Header for ACK Initialization ...................................................................... mgcp_network.c: Fix byte alignment of CRC Header for ACK Initialization The Header CRC field is 6 bits, not 8, and spans bits 7-2. Fixes: ebb05c1f90e97d0795230e90ea49af7d084dc9fe Change-Id: I9a8179813d451948bfa02443894fdd2313dfc4a0 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/89/26689/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 264e263..f865dfe 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1225,7 +1225,7 @@ if (data[0] == 0xe0) { data[0] = 0xe4; data[1] = 0x00; - data[2] = 0x09; /* Patch CRC Header to adapt to new header above */ + data[2] = (0x09 << 2); /* Patch CRC Header to adapt to new header above */ rtp_state->patched_first_rtp_payload = true; LOGPENDP(endp, DRTP, LOGL_DEBUG, "Patching over first two bytes" -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9a8179813d451948bfa02443894fdd2313dfc4a0 Gerrit-Change-Number: 26689 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 27 14:53:22 2021 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 27 Dec 2021 14:53:22 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Set proper CRC Header for ACK Initialization In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26598 ) Change subject: mgcp_network.c: Set proper CRC Header for ACK Initialization ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/26598/1/src/libosmo-mgcp/mgcp_network.c File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26598/1/src/libosmo-mgcp/mgcp_network.c at 1228 PS1, Line 1228: data[2] = 0x09; /* Patch CRC Header to adapt to new header above */ > Shouldn't this be 0x24 (0x09 << 2)? Correct, thanks. see https://gerrit.osmocom.org/c/osmo-mgw/+/26689 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic8350d1f9a9e5dcefeb787462d267bfac08d778f Gerrit-Change-Number: 26598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: lynxis lazus Gerrit-Comment-Date: Mon, 27 Dec 2021 14:53:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 27 17:41:40 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Mon, 27 Dec 2021 17:41:40 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Fix byte alignment of CRC Header for ACK Initialization In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26689 ) Change subject: mgcp_network.c: Fix byte alignment of CRC Header for ACK Initialization ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9a8179813d451948bfa02443894fdd2313dfc4a0 Gerrit-Change-Number: 26689 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Mon, 27 Dec 2021 17:41:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Dec 27 18:10:01 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Mon, 27 Dec 2021 18:10:01 +0000 Subject: Change in osmo-mgw[master]: doc/overview: fix wrong project page link References: Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26690 ) Change subject: doc/overview: fix wrong project page link ...................................................................... doc/overview: fix wrong project page link Change-Id: Ie221099bf1ac278729817ae88773cfc3a709ffba --- M doc/manuals/chapters/overview.adoc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/26690/1 diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc index 9251a7c..3c93859 100644 --- a/doc/manuals/chapters/overview.adoc +++ b/doc/manuals/chapters/overview.adoc @@ -107,8 +107,8 @@ You can find the OsmoMGW issue tracker and wiki online at -- https://osmocom.org/projects/osmomgw -- https://osmocom.org/projects/osmomgw/wiki +- https://osmocom.org/projects/osmo-mgw +- https://osmocom.org/projects/osmo-mgw/wiki RFC 3435 for MGCP is located at -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie221099bf1ac278729817ae88773cfc3a709ffba Gerrit-Change-Number: 26690 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 07:59:44 2021 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 28 Dec 2021 07:59:44 +0000 Subject: Change in osmo-mgw[master]: doc/overview: fix wrong project page link In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26690 ) Change subject: doc/overview: fix wrong project page link ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie221099bf1ac278729817ae88773cfc3a709ffba Gerrit-Change-Number: 26690 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Tue, 28 Dec 2021 07:59:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 12:13:59 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 28 Dec 2021 12:13:59 +0000 Subject: Change in libosmocore[master]: select_main: don't poll forever during shutdown In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26663 ) Change subject: select_main: don't poll forever during shutdown ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81c64a7ae440304522c2179c212023a566ddced8 Gerrit-Change-Number: 26663 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 28 Dec 2021 12:13:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 12:14:12 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 28 Dec 2021 12:14:12 +0000 Subject: Change in libosmocore[master]: select_main: don't poll forever during shutdown In-Reply-To: References: Message-ID: neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26663 ) Change subject: select_main: don't poll forever during shutdown ...................................................................... select_main: don't poll forever during shutdown Do not poll without timeout during shutdown if no timers are pending. Change-Id: I81c64a7ae440304522c2179c212023a566ddced8 --- M src/select.c 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/select.c b/src/select.c index b48d13e..ddff132 100644 --- a/src/select.c +++ b/src/select.c @@ -372,14 +372,20 @@ { unsigned int n_poll; int rc; + int timeout = 0; /* prepare read and write fdsets */ n_poll = poll_fill_fds(); - if (!polling) + if (!polling) { osmo_timers_prepare(); + timeout = osmo_timers_nearest_ms(); - rc = poll(g_poll.poll, n_poll, polling ? 0 : osmo_timers_nearest_ms()); + if (_osmo_select_shutdown_requested && timeout == -1) + timeout = 0; + } + + rc = poll(g_poll.poll, n_poll, timeout); if (rc < 0) return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81c64a7ae440304522c2179c212023a566ddced8 Gerrit-Change-Number: 26663 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 12:18:49 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 28 Dec 2021 12:18:49 +0000 Subject: Change in osmo-dev[master]: all.deps, werror.opts: add osmo-bsc-nat In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26666 ) Change subject: all.deps, werror.opts: add osmo-bsc-nat ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ica90826c8bfbf4f295c49702d36e7c88e43f80cd Gerrit-Change-Number: 26666 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 28 Dec 2021 12:18:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 12:18:55 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 28 Dec 2021 12:18:55 +0000 Subject: Change in osmo-dev[master]: net/templates/run.sh: refactor kill logic In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26667 ) Change subject: net/templates/run.sh: refactor kill logic ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26667 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iaf6c175de2edf720009af13eace2b0ef83b0735b Gerrit-Change-Number: 26667 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 28 Dec 2021 12:18:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 12:19:03 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 28 Dec 2021 12:19:03 +0000 Subject: Change in osmo-dev[master]: net: add osmo-bsc-nat In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/26668 ) Change subject: net: add osmo-bsc-nat ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/26668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I8bfbd00bfeeebc6e1b87a8cd6333212db4380653 Gerrit-Change-Number: 26668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 28 Dec 2021 12:19:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 12:45:37 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 28 Dec 2021 12:45:37 +0000 Subject: Change in osmo-bsc-nat[master]: Add bsc_nat fsm In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 ) Change subject: Add bsc_nat fsm ...................................................................... Patch Set 4: (8 comments) https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/4/include/osmocom/bsc_nat/bsc_nat_fsm.h File include/osmocom/bsc_nat/bsc_nat_fsm.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/4/include/osmocom/bsc_nat/bsc_nat_fsm.h at 21 PS4, Line 21: enum bsc_nat_fsm_states { (usually the state enum can live in the foo_fsm.c file, outside code only needs the events enum) https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/4/include/osmocom/bsc_nat/bsc_nat_fsm.h at 33 PS4, Line 33: extern struct osmo_fsm bsc_nat_fsm; (no need to declare the fsm in the .h, it can be static in the .c file. We usually do osmo_fsm_register() and osmo_fsm_inst_alloc() in the foo_fsm.c file) https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/4/include/osmocom/bsc_nat/bsc_nat_fsm.h at 35 PS4, Line 35: void bsc_nat_start(struct bsc_nat *bsc_nat); does this do the same as BSC_NAT_FSM_EV_START? Then maybe the events enum can also move to the .c file? The idea is to list here exactly those items that calling code uses to interact with the FSM inst. https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/4/src/osmo-bsc-nat/bsc_nat_fsm.c File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/4/src/osmo-bsc-nat/bsc_nat_fsm.c at 34 PS4, Line 34: #define X(s) (1 << (s)) we usually call this S(). I don't know why, maybe "shift"? all i know is that so far I've only seen it called S(). Also we usually define this just above the states array. Again no reason really. https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/4/src/osmo-bsc-nat/bsc_nat_fsm.c at 142 PS4, Line 142: osmo_fsm_inst_state_chg(fi, BSC_NAT_FSM_ST_STOPPED, 0, 0); seems like ST_STOPPING is not needed: the onenter directly changes state to another state. Just put this code in the st_stopped_onenter() function and transition directly to ST_STOPPED? https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/4/src/osmo-bsc-nat/bsc_nat_fsm.c at 159 PS4, Line 159: X(BSC_NAT_FSM_ST_STOPPING), (let me plug here the scheme i invented and use in my FSM definitions, which allows adding and removing states and events from masks by editing / copypasting a single line only: .out_state_mask = 0 | S(ST_FOO) | S(ST_BAR) , ) https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/4/src/osmo-bsc-nat/bsc_nat_fsm.c at 184 PS4, Line 184: int bsc_nat_fsm_timer_cb(struct osmo_fsm_inst *fi) seems like no timer cb is needed. Otherwise rather 'return 1;' to request FSM termination. https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/4/src/osmo-bsc-nat/main.c File src/osmo-bsc-nat/main.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/4/src/osmo-bsc-nat/main.c at 150 PS4, Line 150: bsc_nat_stop(g_bsc_nat, true); osmo_select_shutdown_request() changes the osmo select loop to only handle pending writes and no longer read incoming packets. bsc_nat_stop() does not do that. Are you sure this is what you want? EDIT: I just realized that osmo_select_shutdown_request() is called in st_stopped_onenter(). Still it seems unnecessary to me to separate the select shutdown request from main(), there doesn't seem to be a reason to "hide" the shutdown request behind two state transitions in a distant .c file? I can imagine rather use plain osmo_select_shutdown_request() as it was, and call bsc_nat_stop() after the main loop in main() exited? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7d52fa649c397582b18a1a7dcc40bb407f3b2c97 Gerrit-Change-Number: 26662 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Tue, 28 Dec 2021 12:45:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 13:03:48 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 28 Dec 2021 13:03:48 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: use osmo-config-merge to generate config files In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 ) Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files ...................................................................... Patch Set 5: Verified-1 We need osmo-config-merge to be installed on the machine executing jenkins.sh and building images. Here is a patch: https://gerrit.osmocom.org/c/osmo-ci/+/26688, however I need somebody to confirm that this is the correct place. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 Gerrit-Change-Number: 20622 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Assignee: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 28 Dec 2021 13:03:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 13:08:03 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 28 Dec 2021 13:08:03 +0000 Subject: Change in osmo-bsc-nat[master]: Add vty interface In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659 ) Change subject: Add vty interface ...................................................................... Patch Set 2: (5 comments) https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659/2/src/osmo-bsc-nat/Makefile.am File src/osmo-bsc-nat/Makefile.am: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659/2/src/osmo-bsc-nat/Makefile.am at 31 PS2, Line 31: vty.c \ I know it's a different source tree, but personally, I prefer if the file name reflects the context: mainly because it is easier to ctags-jump to bsc_nat_vty.c than skip through all the matches for vty.c across all the osmo git source trees... Just mentioning it, it's fine if you prefer this way. https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659/2/src/osmo-bsc-nat/logging.c File src/osmo-bsc-nat/logging.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659/2/src/osmo-bsc-nat/logging.c at 25 PS2, Line 25: [DMAIN] = { "DMAIN" seems odd. Usually main() just does fprintf(stderr) or LOGP(DLGLOBAL). So semantically "main" is not really a subsystem IMO? https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659/2/src/osmo-bsc-nat/logging.c at 38 PS2, Line 38: (i usually just put these things in main.c, don't see a reason for a separate logging.c file, especially since that noises up ctags by shadowing the libosmocore logging.c file ... up to you) https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659/2/src/osmo-bsc-nat/main.c File src/osmo-bsc-nat/main.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659/2/src/osmo-bsc-nat/main.c at 47 PS2, Line 47: .go_parent_cb = bsc_nat_vty_go_parent, (can drop this, see other comment) https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659/2/src/osmo-bsc-nat/vty.c File src/osmo-bsc-nat/vty.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659/2/src/osmo-bsc-nat/vty.c at 31 PS2, Line 31: int bsc_nat_vty_go_parent(struct vty *vty) you no longer need to define a go_parent or is_config_node callback. Those were needed for the legacy VTY node handling. The new/current vty code implicitly figures out what nodes nest in what other nodes, and also which vty->index object to point to when exiting a child node. The only reason to implement a go_parent cb is if you want specific actions to happen when the VTY node is exited; imagine that you want to start up or shut down a component when the user is done configuring a node. Usually that's a bad UI design decision though. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I6f2d8d1d62b97be471ebcf1bb14aac0b895833d1 Gerrit-Change-Number: 26659 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Tue, 28 Dec 2021 13:08:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 13:12:42 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 28 Dec 2021 13:12:42 +0000 Subject: Change in osmo-upf[master]: initial osmocom boilerplate source tree References: Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/26691 ) Change subject: initial osmocom boilerplate source tree ...................................................................... initial osmocom boilerplate source tree Change-Id: I4352dd8738a1a9de6ba2fc250ee8eef69c65ff1e --- A .gitignore A .gitreview A AUTHORS A Makefile.am A README.md A TODO-RELEASE A configure.ac A contrib/Makefile.am A contrib/jenkins.sh A contrib/osmo-upf.spec.in A contrib/systemd/Makefile.am A contrib/systemd/osmo-upf.service A debian/changelog A debian/compat A debian/control A debian/copyright A debian/osmo-upf.install A debian/rules A debian/source/format A doc/Makefile.am A doc/examples/Makefile.am A doc/examples/osmo-upf/osmo-upf.cfg A doc/manuals/Makefile.am A doc/manuals/chapters/overview.adoc A doc/manuals/osmoupf-usermanual-docinfo.xml A doc/manuals/osmoupf-usermanual.adoc A doc/manuals/osmoupf-vty-reference.xml A doc/manuals/regen_doc.sh A doc/manuals/vty/upf_vty_additions.xml A git-version-gen A include/Makefile.am A include/osmocom/Makefile.am A include/osmocom/upf/Makefile.am A include/osmocom/upf/upf.h A osmoappdesc.py A src/Makefile.am A src/osmo-upf/Makefile.am A src/osmo-upf/osmo_upf_main.c A src/osmo-upf/upf.c A tests/Makefile.am A tests/atlocal.in A tests/testsuite.at A tests/upf.vty 43 files changed, 1,571 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/91/26691/1 diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..3027037 --- /dev/null +++ b/.gitignore @@ -0,0 +1,73 @@ +debian/*.log +*.o +*.lo +*.a +.deps +Makefile +Makefile.in +config.h +config.h.in +*.pc +*~ + +*.*~ +*.sw? +.libs +*.pyc +*.gcda +*.gcno + +**/TAGS + +#configure +aclocal.m4 +autom4te.cache/ +config.log +config.status +config.guess +config.sub +configure +compile +depcomp +install-sh +missing +stamp-h1 +libtool +ltmain.sh +m4/*.m4 + +# git-version-gen magic +.tarball-version +.version +osmo-upf-*.tar.bz2 +osmo-upf-*.tar.gz + +tags +/deps + +src/osmo-upf/osmo-upf + +#tests +tests/testsuite.dir +tests/*/*_test + +tests/atconfig +tests/atlocal +tests/package.m4 +tests/testsuite +tests/testsuite.log + +writtenconfig/ + +# manuals +doc/manuals/*.html +doc/manuals/*.svg +doc/manuals/*.pdf +doc/manuals/*__*.png +doc/manuals/*.check +doc/manuals/generated/ +doc/manuals/osmoupf-usermanual.xml +doc/manuals/common +doc/manuals/build + +contrib/osmo-upf.spec diff --git a/.gitreview b/.gitreview new file mode 100644 index 0000000..e982555 --- /dev/null +++ b/.gitreview @@ -0,0 +1,3 @@ +[gerrit] +host=gerrit.osmocom.org +project=osmo-upf diff --git a/AUTHORS b/AUTHORS new file mode 100644 index 0000000..5ce3b38 --- /dev/null +++ b/AUTHORS @@ -0,0 +1 @@ +Neels Hofmeyr diff --git a/Makefile.am b/Makefile.am new file mode 100644 index 0000000..4452f04 --- /dev/null +++ b/Makefile.am @@ -0,0 +1,36 @@ +AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6 + +## FIXME: automake >= 1.13 or autoconf >= 2.70 provide better suited AC_CONFIG_MACRO_DIRS for configure.ac +## remove line below when OE toolchain is updated to version which include those +ACLOCAL_AMFLAGS = -I m4 +AM_CPPFLAGS = \ + $(all_includes) \ + -I$(top_srcdir)/include \ + $(NULL) + +SUBDIRS = \ + include \ + src \ + tests \ + doc \ + contrib \ + $(NULL) + +BUILT_SOURCES = $(top_srcdir)/.version +EXTRA_DIST = \ + .version \ + contrib/osmo-upf.spec.in \ + debian \ + git-version-gen \ + osmoappdesc.py \ + $(NULL) + +AM_DISTCHECK_CONFIGURE_FLAGS = \ + --with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir) + + at RELMAKE@ + +$(top_srcdir)/.version: + echo $(VERSION) > $@-t && mv $@-t $@ +dist-hook: + echo $(VERSION) > $(distdir)/.tarball-version diff --git a/README.md b/README.md new file mode 100644 index 0000000..4c7b9f7 --- /dev/null +++ b/README.md @@ -0,0 +1,54 @@ +osmo-upf - Osmocom User Plane Function Implementation +===================================================== + +Homepage +-------- + +The official homepage of the project is +https://osmocom.org/projects/osmoupf/wiki + +GIT Repository +-------------- + +You can clone from the official osmo-upf.git repository using + + git clone git://git.osmocom.org/osmo-upf.git + +There is a cgit interface at https://git.osmocom.org/osmo-upf/ + +To submit patches, see "Contributing" below. + +Documentation +------------- + +User Manuals and VTY reference manuals are [optionally] built in PDF form +as part of the build process. + +Pre-rendered PDF version of the current "master" can be found at +[User Manual](https://ftp.osmocom.org/docs/latest/osmoupf-usermanual.pdf) +as well as the [VTY Reference Manual](https://ftp.osmocom.org/docs/latest/osmoupf-vty-reference.pdf) + + +Mailing List +------------ + +Discussions related to osmo-bts are happening on the +osmocom-net-gprs at lists.osmocom.org mailing list, please see +https://lists.osmocom.org/mailman/listinfo/osmocom-net-gprs +for subscription options and the list archive. + +Please observe the [Osmocom Mailing List +Rules](https://osmocom.org/projects/cellular-infrastructure/wiki/Mailing_List_Rules) +when posting. + +Contributing +------------ + +Our coding standards are described at +https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards + +Submit patches at https://gerrit.osmocom.org/ +See also https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit + +The current patch queue for OsmoUPF can be seen at +https://gerrit.osmocom.org/#/q/project:osmo-upf+status:open diff --git a/TODO-RELEASE b/TODO-RELEASE new file mode 100644 index 0000000..d0852fc --- /dev/null +++ b/TODO-RELEASE @@ -0,0 +1,9 @@ +# When cleaning up this file: bump API version in corresponding Makefile.am and rename corresponding debian/lib*.install +# according to https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info +# In short: +# LIBVERSION=c:r:a +# If the library source code has changed at all since the last update, then increment revision: c:r + 1:a. +# If any interfaces have been added, removed, or changed since the last update: c + 1:0:0. +# If any interfaces have been added since the last public release: c:r:a + 1. +# If any interfaces have been removed or changed since the last public release: c:r:0. +#library what description / commit summary line diff --git a/configure.ac b/configure.ac new file mode 100644 index 0000000..4995146 --- /dev/null +++ b/configure.ac @@ -0,0 +1,210 @@ +AC_INIT([osmo-upf], + m4_esyscmd([./git-version-gen .tarball-version]), + [osmocom-net-gprs at lists.osmocom.org]) + +dnl *This* is the root dir, even if an install-sh exists in ../ or ../../ +AC_CONFIG_AUX_DIR([.]) + +AM_INIT_AUTOMAKE([dist-bzip2]) +AC_CONFIG_TESTDIR(tests) + +CFLAGS="$CFLAGS -std=gnu11" + +dnl kernel style compile messages +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) + +dnl include release helper +RELMAKE='-include osmo-release.mk' +AC_SUBST([RELMAKE]) + +dnl checks for programs +AC_PROG_MAKE_SET +AC_PROG_CC +AC_PROG_INSTALL +LT_INIT + +dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang +AS_CASE(["$LD"],[*clang*], + [AS_CASE(["${host_os}"], + [*linux*],[archive_cmds='$CC -shared $pic_flag $libobjs $deplibs $compiler_flags $wl-soname $wl$soname -o $lib'])]) + +dnl check for pkg-config (explained in detail in libosmocore/configure.ac) +AC_PATH_PROG(PKG_CONFIG_INSTALLED, pkg-config, no) +if test "x$PKG_CONFIG_INSTALLED" = "xno"; then + AC_MSG_WARN([You need to install pkg-config]) +fi +PKG_PROG_PKG_CONFIG([0.20]) + +dnl checks for libraries +AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) +AC_SUBST(LIBRARY_DL) + +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) + +dnl checks for header files +AC_HEADER_STDC + +dnl Checks for typedefs, structures and compiler characteristics + +AC_ARG_ENABLE(sanitize, + [AS_HELP_STRING( + [--enable-sanitize], + [Compile with address sanitizer enabled], + )], + [sanitize=$enableval], [sanitize="no"]) +if test x"$sanitize" = x"yes" +then + CFLAGS="$CFLAGS -fsanitize=address -fsanitize=undefined" + CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" +fi + +AC_ARG_ENABLE(werror, + [AS_HELP_STRING( + [--enable-werror], + [Turn all compiler warnings into errors, with exceptions: + a) deprecation (allow upstream to mark deprecation without breaking builds); + b) "#warning" pragmas (allow to remind ourselves of errors without breaking builds) + ] + )], + [werror=$enableval], [werror="no"]) +if test x"$werror" = x"yes" +then + WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" + WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" + CFLAGS="$CFLAGS $WERROR_FLAGS" + CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" +fi + +# The following test is taken from WebKit's webkit.m4 +saved_CFLAGS="$CFLAGS" +CFLAGS="$CFLAGS -fvisibility=hidden " +AC_MSG_CHECKING([if ${CC} supports -fvisibility=hidden]) +AC_COMPILE_IFELSE([AC_LANG_SOURCE([char foo;])], + [ AC_MSG_RESULT([yes]) + SYMBOL_VISIBILITY="-fvisibility=hidden"], + AC_MSG_RESULT([no])) +CFLAGS="$saved_CFLAGS" +AC_SUBST(SYMBOL_VISIBILITY) + +# Coverage build taken from WebKit's configure.in +AC_MSG_CHECKING([whether to enable code coverage support]) +AC_ARG_ENABLE(coverage, + AC_HELP_STRING([--enable-coverage], + [enable code coverage support [default=no]]), + [],[enable_coverage="no"]) +AC_MSG_RESULT([$enable_coverage]) +if test "$enable_coverage" = "yes"; then + COVERAGE_CFLAGS="-ftest-coverage -fprofile-arcs" + COVERAGE_LDFLAGS="-ftest-coverage -fprofile-arcs" + AC_SUBST([COVERAGE_CFLAGS]) + AC_SUBST([COVERAGE_LDFLAGS]) +fi + +AC_ARG_ENABLE(profile, + [AS_HELP_STRING([--enable-profile], [Compile with profiling support enabled], )], + [profile=$enableval], [profile="no"]) +if test x"$profile" = x"yes" +then + CFLAGS="$CFLAGS -pg" + CPPFLAGS="$CPPFLAGS -pg" +fi + +AC_ARG_ENABLE([external_tests], + AC_HELP_STRING([--enable-external-tests], + [Include the VTY/CTRL tests in make check [default=no]]), + [enable_ext_tests="$enableval"],[enable_ext_tests="no"]) +if test "x$enable_ext_tests" = "xyes" ; then + AC_CHECK_PROG(PYTHON3_AVAIL,python3,yes) + if test "x$PYTHON3_AVAIL" != "xyes" ; then + AC_MSG_ERROR([Please install python3 to run the VTY/CTRL tests.]) + fi + AC_CHECK_PROG(OSMOTESTEXT_CHECK,osmotestvty.py,yes) + if test "x$OSMOTESTEXT_CHECK" != "xyes" ; then + AC_MSG_ERROR([Please install git://osmocom.org/python/osmo-python-tests to run the VTY/CTRL tests.]) + fi +fi +AC_MSG_CHECKING([whether to enable VTY/CTRL tests]) +AC_MSG_RESULT([$enable_ext_tests]) +AM_CONDITIONAL(ENABLE_EXT_TESTS, test "x$enable_ext_tests" = "xyes") + +# Generate manuals +AC_ARG_ENABLE(manuals, + [AS_HELP_STRING( + [--enable-manuals], + [Generate manual PDFs [default=no]], + )], + [osmo_ac_build_manuals=$enableval], [osmo_ac_build_manuals="no"]) +AM_CONDITIONAL([BUILD_MANUALS], [test x"$osmo_ac_build_manuals" = x"yes"]) +AC_ARG_VAR(OSMO_GSM_MANUALS_DIR, [path to common osmo-gsm-manuals files, overriding pkg-config and "../osmo-gsm-manuals" + fallback]) +if test x"$osmo_ac_build_manuals" = x"yes" +then + # Find OSMO_GSM_MANUALS_DIR (env, pkg-conf, fallback) + if test -n "$OSMO_GSM_MANUALS_DIR"; then + echo "checking for OSMO_GSM_MANUALS_DIR... $OSMO_GSM_MANUALS_DIR (from env)" + else + OSMO_GSM_MANUALS_DIR="$($PKG_CONFIG osmo-gsm-manuals --variable=osmogsmmanualsdir 2>/dev/null)" + if test -n "$OSMO_GSM_MANUALS_DIR"; then + echo "checking for OSMO_GSM_MANUALS_DIR... $OSMO_GSM_MANUALS_DIR (from pkg-conf)" + else + OSMO_GSM_MANUALS_DIR="../osmo-gsm-manuals" + echo "checking for OSMO_GSM_MANUALS_DIR... $OSMO_GSM_MANUALS_DIR (fallback)" + fi + fi + if ! test -d "$OSMO_GSM_MANUALS_DIR"; then + AC_MSG_ERROR("OSMO_GSM_MANUALS_DIR does not exist! Install osmo-gsm-manuals or set OSMO_GSM_MANUALS_DIR.") + fi + + # Find and run check-depends + CHECK_DEPENDS="$OSMO_GSM_MANUALS_DIR/check-depends.sh" + if ! test -x "$CHECK_DEPENDS"; then + CHECK_DEPENDS="osmo-gsm-manuals-check-depends" + fi + if ! $CHECK_DEPENDS; then + AC_MSG_ERROR("missing dependencies for --enable-manuals") + fi + + # Put in Makefile with absolute path + OSMO_GSM_MANUALS_DIR="$(realpath "$OSMO_GSM_MANUALS_DIR")" + AC_SUBST([OSMO_GSM_MANUALS_DIR]) +fi + +# https://www.freedesktop.org/software/systemd/man/daemon.html +AC_ARG_WITH([systemdsystemunitdir], + [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd service files])],, + [with_systemdsystemunitdir=auto]) +AS_IF([test "x$with_systemdsystemunitdir" = "xyes" -o "x$with_systemdsystemunitdir" = "xauto"], [ + def_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir systemd) + + AS_IF([test "x$def_systemdsystemunitdir" = "x"], + [AS_IF([test "x$with_systemdsystemunitdir" = "xyes"], + [AC_MSG_ERROR([systemd support requested but pkg-config unable to query systemd package])]) + with_systemdsystemunitdir=no], + [with_systemdsystemunitdir="$def_systemdsystemunitdir"])]) +AS_IF([test "x$with_systemdsystemunitdir" != "xno"], + [AC_SUBST([systemdsystemunitdir], [$with_systemdsystemunitdir])]) +AM_CONDITIONAL([HAVE_SYSTEMD], [test "x$with_systemdsystemunitdir" != "xno"]) + +AC_MSG_RESULT([CFLAGS="$CFLAGS"]) +AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"]) + +dnl Generate the output +AM_CONFIG_HEADER(config.h) + +AC_OUTPUT( + include/Makefile + include/osmocom/Makefile + include/osmocom/upf/Makefile + src/Makefile + src/osmo-upf/Makefile + tests/Makefile + tests/atlocal + doc/Makefile + doc/examples/Makefile + doc/manuals/Makefile + contrib/Makefile + contrib/systemd/Makefile + Makefile) diff --git a/contrib/Makefile.am b/contrib/Makefile.am new file mode 100644 index 0000000..3439c97 --- /dev/null +++ b/contrib/Makefile.am @@ -0,0 +1 @@ +SUBDIRS = systemd diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..05ff623 --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,64 @@ +#!/usr/bin/env bash +# jenkins build helper script for osmo-upf. This is how we build on jenkins.osmocom.org +# +# environment variables: +# * WITH_MANUALS: build manual PDFs if set to "1" +# * PUBLISH: upload manuals after building if set to "1" (ignored without WITH_MANUALS = "1") +# + +if ! [ -x "$(command -v osmo-build-dep.sh)" ]; then + echo "Error: We need to have scripts/osmo-deps.sh from http://git.osmocom.org/osmo-ci/ in PATH !" + exit 2 +fi + + +set -ex + +base="$PWD" +deps="$base/deps" +inst="$deps/install" +export deps inst + +osmo-clean-workspace.sh + +mkdir "$deps" || true + +verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]") + +export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" +export LD_LIBRARY_PATH="$inst/lib" +export PATH="$inst/bin:$PATH" + +osmo-build-dep.sh libosmocore "" --disable-doxygen + +# Additional configure options and depends +CONFIG="" +if [ "$WITH_MANUALS" = "1" ]; then + CONFIG="--enable-manuals" +fi + +set +x +echo +echo +echo +echo " =============================== osmo-upf ===============================" +echo +set -x + +cd "$base" +autoreconf --install --force +./configure --enable-sanitize --enable-external-tests $CONFIG +$MAKE $PARALLEL_MAKE +LD_LIBRARY_PATH="$inst/lib" $MAKE check \ + || cat-testlogs.sh +LD_LIBRARY_PATH="$inst/lib" \ + DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests $CONFIG" \ + $MAKE $PARALLEL_MAKE distcheck \ + || cat-testlogs.sh + +if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then + make -C "$base/doc/manuals" publish +fi + +$MAKE $PARALLEL_MAKE maintainer-clean +osmo-clean-workspace.sh diff --git a/contrib/osmo-upf.spec.in b/contrib/osmo-upf.spec.in new file mode 100644 index 0000000..3ae6ac4 --- /dev/null +++ b/contrib/osmo-upf.spec.in @@ -0,0 +1,86 @@ +# +# spec file for package osmo-upf +# +# Copyright (c) 2017, Martin Hauke +# +# All modifications and additions to the file contributed by third parties +# remain the property of their copyright owners, unless otherwise agreed +# upon. The license for this file, and modifications and additions to the +# file, is the same license as for the pristine package itself (unless the +# license for the pristine package is not an Open Source License, in which +# case the license is the MIT License). An "Open Source License" is a +# license that conforms to the Open Source Definition (Version 1.9) +# published by the Open Source Initiative. + +## Disable LTO for now since it breaks compilation of the tests +## https://osmocom.org/issues/4113 +%define _lto_cflags %{nil} + +Name: osmo-upf +Version: @VERSION@ +Release: 0 +Summary: OsmoUPF: Osmocom User Plane Function +License: AGPL-3.0-or-later AND GPL-2.0-or-later +Group: Hardware/Mobile +URL: https://osmocom.org/projects/osmoupf +Source: %{name}-%{version}.tar.xz +BuildRequires: autoconf-archive +BuildRequires: automake >= 1.9 +BuildRequires: libtool >= 2 +BuildRequires: lksctp-tools-devel +BuildRequires: pkgconfig >= 0.20 +%if 0%{?suse_version} +BuildRequires: systemd-rpm-macros +%endif +BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmoctrl) >= 1.6.0 +BuildRequires: pkgconfig(libosmovty) >= 1.6.0 +BuildRequires: pkgconfig(talloc) +%{?systemd_requires} + +%description +OsmoUPF: Osmocom User Plane Function + +%prep +%setup -q + +%build +echo "%{version}" >.tarball-version +autoreconf -fi +%configure \ + --docdir=%{_docdir}/%{name} \ + --with-systemdsystemunitdir=%{_unitdir} +make %{?_smp_mflags} + +%install +%make_install + +%if 0%{?suse_version} +%preun +%service_del_preun %{name}.service + +%postun +%service_del_postun %{name}.service + +%pre +%service_add_pre %{name}.service + +%post +%service_add_post %{name}.service +%endif + +%check +make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) + +%files +%license COPYING +%doc AUTHORS README.md +%{_bindir}/osmo-upf +%dir %{_docdir}/%{name}/examples +%dir %{_docdir}/%{name}/examples/osmo-upf +%{_docdir}/%{name}/examples/osmo-upf/osmo-upf.cfg +%dir %{_sysconfdir}/osmocom +%config(noreplace) %{_sysconfdir}/osmocom/osmo-upf.cfg +%{_unitdir}/%{name}.service + +%changelog diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am new file mode 100644 index 0000000..f5e5468 --- /dev/null +++ b/contrib/systemd/Makefile.am @@ -0,0 +1,6 @@ +EXTRA_DIST = osmo-upf.service + +if HAVE_SYSTEMD +systemdsystemunit_DATA = \ + osmo-upf.service +endif diff --git a/contrib/systemd/osmo-upf.service b/contrib/systemd/osmo-upf.service new file mode 100644 index 0000000..c4bc22a --- /dev/null +++ b/contrib/systemd/osmo-upf.service @@ -0,0 +1,11 @@ +[Unit] +Description=Osmocom User Plane Function (UPF) + +[Service] +Type=simple +Restart=always +ExecStart=/usr/bin/osmo-upf -c /etc/osmocom/osmo-upf.cfg +RestartSec=2 + +[Install] +WantedBy=multi-user.target diff --git a/debian/changelog b/debian/changelog new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/debian/changelog diff --git a/debian/compat b/debian/compat new file mode 100644 index 0000000..ec63514 --- /dev/null +++ b/debian/compat @@ -0,0 +1 @@ +9 diff --git a/debian/control b/debian/control new file mode 100644 index 0000000..04b8224 --- /dev/null +++ b/debian/control @@ -0,0 +1,42 @@ +Source: osmo-upf +Section: net +Priority: extra +Maintainer: Osmocom team +Build-Depends: debhelper (>=9), + dh-autoreconf, + autotools-dev, + autoconf, + autoconf-archive, + automake, + libtool, + pkg-config, + python3-minimal, + libtalloc-dev, + libosmocore-dev (>= 1.6.0), + osmo-gsm-manuals-dev (>= 1.2.0) +Standards-Version: 3.9.8 +Vcs-Git: git://git.osmocom.org/osmo-upf.git +Vcs-Browser: https://git.osmocom.org/osmo-upf/ +Homepage: https://projects.osmocom.org/projects/osmo-upf + +Package: osmo-upf +Architecture: any +Multi-Arch: foreign +Depends: ${misc:Depends}, ${shlibs:Depends} +Description: OsmoUPF: Osmocom User Plane Function + +Package: osmo-upf-dbg +Section: debug +Architecture: any +Multi-Arch: same +Depends: osmo-upf (= ${binary:Version}), ${misc:Depends} +Description: OsmoUPF: Osmocom User Plane Function + +Package: osmo-upf-doc +Architecture: all +Section: doc +Priority: optional +Depends: ${misc:Depends} +Description: ${misc:Package} PDF documentation + Various manuals: user manual, VTY reference manual and/or + protocol/interface manuals. diff --git a/debian/copyright b/debian/copyright new file mode 100644 index 0000000..48facd0 --- /dev/null +++ b/debian/copyright @@ -0,0 +1,19 @@ +Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ +Upstream-Name: osmo-upf +Source: git://git.osmocom.org/osmo-upf + +Files: * +Copyright: 2021 sysmocom - s.f.m.c. GmbH +License: AGPL-3.0+ + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU Affero General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + . + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU Affero General Public License for more details. + . + You should have received a copy of the GNU Affero General Public License + along with this program. If not, see . diff --git a/debian/osmo-upf.install b/debian/osmo-upf.install new file mode 100644 index 0000000..7e48c41 --- /dev/null +++ b/debian/osmo-upf.install @@ -0,0 +1,4 @@ +etc/osmocom/osmo-upf.cfg +lib/systemd/system/osmo-upf.service +usr/bin/osmo-upf +usr/share/doc/osmo-upf/examples/osmo-upf/osmo-upf.cfg usr/share/doc/osmo-upf/examples diff --git a/debian/rules b/debian/rules new file mode 100755 index 0000000..bac82b9 --- /dev/null +++ b/debian/rules @@ -0,0 +1,66 @@ +#!/usr/bin/make -f +# You must remove unused comment lines for the released package. +# See debhelper(7) (uncomment to enable) +# This is an autogenerated template for debian/rules. +# +# Output every command that modifies files on the build system. +#export DH_VERBOSE = 1 +# +# Copy some variable definitions from pkg-info.mk and vendor.mk +# under /usr/share/dpkg/ to here if they are useful. +# +# See FEATURE AREAS/ENVIRONMENT in dpkg-buildflags(1) +# Apply all hardening options +#export DEB_BUILD_MAINT_OPTIONS = hardening=+all +# Package maintainers to append CFLAGS +#export DEB_CFLAGS_MAINT_APPEND = -Wall -pedantic +# Package maintainers to append LDFLAGS +#export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed +# +# With debhelper version 9 or newer, the dh command exports +# all buildflags. So there is no need to include the +# /usr/share/dpkg/buildflags.mk file here if compat is 9 or newer. +# +# These are rarely used code. (START) +# +# The following include for *.mk magically sets miscellaneous +# variables while honoring existing values of pertinent +# environment variables: +# +# Architecture-related variables such as DEB_TARGET_MULTIARCH: +#include /usr/share/dpkg/architecture.mk +# Vendor-related variables such as DEB_VENDOR: +#include /usr/share/dpkg/vendor.mk +# Package-related variables such as DEB_DISTRIBUTION +#include /usr/share/dpkg/pkg-info.mk +# +# You may alternatively set them susing a simple script such as: +# DEB_VENDOR ?= $(shell dpkg-vendor --query Vendor) +# +# These are rarely used code. (END) +# + +# main packaging script based on dh7 syntax +%: + dh $@ --with autoreconf + +# debmake generated override targets +CONFIGURE_FLAGS += --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals +override_dh_auto_configure: + dh_auto_configure -- $(CONFIGURE_FLAGS) +# +# Do not install libtool archive, python .pyc .pyo +#override_dh_install: +# dh_install --list-missing -X.la -X.pyc -X.pyo + +# See https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-dbg +override_dh_strip: + dh_strip -posmo-upf --dbg-package=osmo-upf-dbg + +# Print test results in case of a failure +override_dh_auto_test: + dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false) + +# Don't create .pdf.gz files (barely saves space and they can't be opened directly by most pdf readers) +override_dh_compress: + dh_compress -X.pdf diff --git a/debian/source/format b/debian/source/format new file mode 100644 index 0000000..89ae9db --- /dev/null +++ b/debian/source/format @@ -0,0 +1 @@ +3.0 (native) diff --git a/doc/Makefile.am b/doc/Makefile.am new file mode 100644 index 0000000..15f36b7 --- /dev/null +++ b/doc/Makefile.am @@ -0,0 +1,4 @@ +SUBDIRS = \ + examples \ + manuals \ + $(NULL) diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am new file mode 100644 index 0000000..49b19d9 --- /dev/null +++ b/doc/examples/Makefile.am @@ -0,0 +1,30 @@ +OSMOCONF_FILES = \ + osmo-upf/osmo-upf.cfg + +osmoconfdir = $(sysconfdir)/osmocom +osmoconf_DATA = $(OSMOCONF_FILES) + +EXTRA_DIST = $(OSMOCONF_FILES) + +CFG_FILES = find $(srcdir) -name '*.cfg*' | sed -e 's,^$(srcdir),,' + +dist-hook: + for f in $$($(CFG_FILES)); do \ + j="$(distdir)/$$f" && \ + mkdir -p "$$(dirname $$j)" && \ + $(INSTALL_DATA) $(srcdir)/$$f $$j; \ + done + +install-data-hook: + for f in $$($(CFG_FILES)); do \ + j="$(DESTDIR)$(docdir)/examples/$$f" && \ + mkdir -p "$$(dirname $$j)" && \ + $(INSTALL_DATA) $(srcdir)/$$f $$j; \ + done + +uninstall-hook: + @$(PRE_UNINSTALL) + for f in $$($(CFG_FILES)); do \ + j="$(DESTDIR)$(docdir)/examples/$$f" && \ + $(RM) $$j; \ + done diff --git a/doc/examples/osmo-upf/osmo-upf.cfg b/doc/examples/osmo-upf/osmo-upf.cfg new file mode 100644 index 0000000..8a2a407 --- /dev/null +++ b/doc/examples/osmo-upf/osmo-upf.cfg @@ -0,0 +1,9 @@ +log stderr + logging filter all 1 + logging color 1 + logging print level 1 + logging print category 1 + logging print category-hex 0 + logging print file basename last + logging print extended-timestamp 1 + logging level set-all notice diff --git a/doc/manuals/Makefile.am b/doc/manuals/Makefile.am new file mode 100644 index 0000000..d89e1b3 --- /dev/null +++ b/doc/manuals/Makefile.am @@ -0,0 +1,25 @@ +EXTRA_DIST = \ + osmoupf-usermanual.adoc \ + osmoupf-usermanual-docinfo.xml \ + osmoupf-vty-reference.xml \ + chapters \ + regen_doc.sh \ + vty + +if BUILD_MANUALS + ASCIIDOC = osmoupf-usermanual.adoc + include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.asciidoc.inc + osmoupf-usermanual.pdf: $(srcdir)/chapters/*.adoc + + VTY_REFERENCE = osmoupf-vty-reference.xml + + BUILT_REFERENCE_XML = $(builddir)/vty/upf_vty_reference.xml + $(builddir)/vty/upf_vty_reference.xml: $(top_builddir)/src/osmo-upf/osmo-upf + mkdir -p $(builddir)/vty + $(top_builddir)/src/osmo-upf/osmo-upf --vty-ref-xml > $@ + + include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.vty-reference.inc + + OSMO_REPOSITORY = osmo-upf + include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.common.inc +endif diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc new file mode 100644 index 0000000..2b9b547 --- /dev/null +++ b/doc/manuals/chapters/overview.adoc @@ -0,0 +1,24 @@ +OsmoUPF + +[[overview]] +== Overview + +This manual should help you getting started with OsmoUPF. It will cover +aspects of configuring and running OsmoUPF. + +[[intro_overview]] +=== About OsmoUPF + +OsmoUPF is the Osmocom implementation of a User Plane Function for 2G, 3G, 4G +and 5G mobile network packet switched user data management. It implements: + +- A Packet Forwarding Control Protocol (PFCP) entity to manage the GTP user + plane of mobile subscribers. +- GTP forwarding as well as encapsulation/decapsulation of user traffic, using + the Linux mainline kernel GTP module. + +The aim is to provide: + +- 1000 modifications of tunnel state per second (add/remove/modify), +- 4-8 Gbps throughput, +- 100-125k concurrent GTP tunnels. diff --git a/doc/manuals/osmoupf-usermanual-docinfo.xml b/doc/manuals/osmoupf-usermanual-docinfo.xml new file mode 100644 index 0000000..d3ddc8c --- /dev/null +++ b/doc/manuals/osmoupf-usermanual-docinfo.xml @@ -0,0 +1,47 @@ + + + 1 + October 2016 + PEP + + Initial OsmoHnodeB manual + + + + + + + Pau + Espin Pedrol + pespin at sysmocom.de + PE + + sysmocom + sysmocom - s.f.m.c. GmbH + Software Developer + + + + + + 2021 + sysmocom - s.f.m.c. GmbH + + + + + Permission is granted to copy, distribute and/or modify this + document under the terms of the GNU Free Documentation License, + Version 1.3 or any later version published by the Free Software + Foundation; with the Invariant Sections being just 'Foreword', + 'Acknowledgements' and 'Preface', with no Front-Cover Texts, + and no Back-Cover Texts. A copy of the license is included in + the section entitled "GNU Free Documentation License". + + + The Asciidoc source code of this manual can be found at + + http://git.osmocom.org/osmo-gsm-manuals/ + + + diff --git a/doc/manuals/osmoupf-usermanual.adoc b/doc/manuals/osmoupf-usermanual.adoc new file mode 100644 index 0000000..578c0b9 --- /dev/null +++ b/doc/manuals/osmoupf-usermanual.adoc @@ -0,0 +1,31 @@ +:gfdl-enabled: +:program-name: OsmoHNodeB + +OsmoHNodeB User Manual +====================== +Pau Espin Pedrol + + +include::./common/chapters/preface.adoc[] + +include::{srcdir}/chapters/overview.adoc[] + +include::./common/chapters/vty.adoc[] + +include::./common/chapters/logging.adoc[] + +include::./common/chapters/cs7-config.adoc[] + +include::./common/chapters/counters-overview.adoc[] + +include::./common/chapters/control_if.adoc[] + +include::./common/chapters/vty_cpu_sched.adoc[] + +include::./common/chapters/port_numbers.adoc[] + +include::./common/chapters/bibliography.adoc[] + +include::./common/chapters/glossary.adoc[] + +include::./common/chapters/gfdl.adoc[] diff --git a/doc/manuals/osmoupf-vty-reference.xml b/doc/manuals/osmoupf-vty-reference.xml new file mode 100644 index 0000000..8b7b818 --- /dev/null +++ b/doc/manuals/osmoupf-vty-reference.xml @@ -0,0 +1,37 @@ + + + + +]> + + + + + + v1 + 30th November 2021 + NJH + Initial + + + + OsmoUPF VTY Reference + + + 2021 + + + + This work is copyright by sysmocom - s.f.m.c. GmbH. All rights reserved. + + + + + + &chapter-vty; + diff --git a/doc/manuals/regen_doc.sh b/doc/manuals/regen_doc.sh new file mode 100755 index 0000000..1d6999a --- /dev/null +++ b/doc/manuals/regen_doc.sh @@ -0,0 +1,17 @@ +#!/bin/sh -x + +if [ -z "$DOCKER_PLAYGROUND" ]; then + echo "You need to set DOCKER_PLAYGROUND" + exit 1 +fi + +SCRIPT=$(realpath "$0") +MANUAL_DIR=$(dirname "$SCRIPT") + +COMMIT=${COMMIT:-$(git log -1 --format=format:%H)} + +cd "$DOCKER_PLAYGROUND/scripts" || exit 1 + +OSMO_HNODEB_BRANCH=$COMMIT ./regen_doc.sh osmo-upf 4273 \ + "$MANUAL_DIR/chapters/counters_generated.adoc" \ + "$MANUAL_DIR/vty/upf_vty_reference.xml" diff --git a/doc/manuals/vty/upf_vty_additions.xml b/doc/manuals/vty/upf_vty_additions.xml new file mode 100644 index 0000000..a4c675e --- /dev/null +++ b/doc/manuals/vty/upf_vty_additions.xml @@ -0,0 +1,2 @@ + + diff --git a/git-version-gen b/git-version-gen new file mode 100755 index 0000000..42cf3d2 --- /dev/null +++ b/git-version-gen @@ -0,0 +1,151 @@ +#!/bin/sh +# Print a version string. +scriptversion=2010-01-28.01 + +# Copyright (C) 2007-2010 Free Software Foundation, Inc. +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# This script is derived from GIT-VERSION-GEN from GIT: http://git.or.cz/. +# It may be run two ways: +# - from a git repository in which the "git describe" command below +# produces useful output (thus requiring at least one signed tag) +# - from a non-git-repo directory containing a .tarball-version file, which +# presumes this script is invoked like "./git-version-gen .tarball-version". + +# In order to use intra-version strings in your project, you will need two +# separate generated version string files: +# +# .tarball-version - present only in a distribution tarball, and not in +# a checked-out repository. Created with contents that were learned at +# the last time autoconf was run, and used by git-version-gen. Must not +# be present in either $(srcdir) or $(builddir) for git-version-gen to +# give accurate answers during normal development with a checked out tree, +# but must be present in a tarball when there is no version control system. +# Therefore, it cannot be used in any dependencies. GNUmakefile has +# hooks to force a reconfigure at distribution time to get the value +# correct, without penalizing normal development with extra reconfigures. +# +# .version - present in a checked-out repository and in a distribution +# tarball. Usable in dependencies, particularly for files that don't +# want to depend on config.h but do want to track version changes. +# Delete this file prior to any autoconf run where you want to rebuild +# files to pick up a version string change; and leave it stale to +# minimize rebuild time after unrelated changes to configure sources. +# +# It is probably wise to add these two files to .gitignore, so that you +# don't accidentally commit either generated file. +# +# Use the following line in your configure.ac, so that $(VERSION) will +# automatically be up-to-date each time configure is run (and note that +# since configure.ac no longer includes a version string, Makefile rules +# should not depend on configure.ac for version updates). +# +# AC_INIT([GNU project], +# m4_esyscmd([build-aux/git-version-gen .tarball-version]), +# [bug-project at example]) +# +# Then use the following lines in your Makefile.am, so that .version +# will be present for dependencies, and so that .tarball-version will +# exist in distribution tarballs. +# +# BUILT_SOURCES = $(top_srcdir)/.version +# $(top_srcdir)/.version: +# echo $(VERSION) > $@-t && mv $@-t $@ +# dist-hook: +# echo $(VERSION) > $(distdir)/.tarball-version + +case $# in + 1) ;; + *) echo 1>&2 "Usage: $0 \$srcdir/.tarball-version"; exit 1;; +esac + +tarball_version_file=$1 +nl=' +' + +# First see if there is a tarball-only version file. +# then try "git describe", then default. +if test -f $tarball_version_file +then + v=`cat $tarball_version_file` || exit 1 + case $v in + *$nl*) v= ;; # reject multi-line output + [0-9]*) ;; + *) v= ;; + esac + test -z "$v" \ + && echo "$0: WARNING: $tarball_version_file seems to be damaged" 1>&2 +fi + +if test -n "$v" +then + : # use $v +elif + v=`git describe --abbrev=4 --match='v*' HEAD 2>/dev/null \ + || git describe --abbrev=4 HEAD 2>/dev/null` \ + && case $v in + [0-9]*) ;; + v[0-9]*) ;; + *) (exit 1) ;; + esac +then + # Is this a new git that lists number of commits since the last + # tag or the previous older version that did not? + # Newer: v6.10-77-g0f8faeb + # Older: v6.10-g0f8faeb + case $v in + *-*-*) : git describe is okay three part flavor ;; + *-*) + : git describe is older two part flavor + # Recreate the number of commits and rewrite such that the + # result is the same as if we were using the newer version + # of git describe. + vtag=`echo "$v" | sed 's/-.*//'` + numcommits=`git rev-list "$vtag"..HEAD | wc -l` + v=`echo "$v" | sed "s/\(.*\)-\(.*\)/\1-$numcommits-\2/"`; + ;; + esac + + # Change the first '-' to a '.', so version-comparing tools work properly. + # Remove the "g" in git describe's output string, to save a byte. + v=`echo "$v" | sed 's/-/./;s/\(.*\)-g/\1-/'`; +else + v=UNKNOWN +fi + +v=`echo "$v" |sed 's/^v//'` + +# Don't declare a version "dirty" merely because a time stamp has changed. +git status > /dev/null 2>&1 + +dirty=`sh -c 'git diff-index --name-only HEAD' 2>/dev/null` || dirty= +case "$dirty" in + '') ;; + *) # Append the suffix only if there isn't one already. + case $v in + *-dirty) ;; + *) v="$v-dirty" ;; + esac ;; +esac + +# Omit the trailing newline, so that m4_esyscmd can use the result directly. +echo "$v" | tr -d '\012' + +# Local variables: +# eval: (add-hook 'write-file-hooks 'time-stamp) +# time-stamp-start: "scriptversion=" +# time-stamp-format: "%:y-%02m-%02d.%02H" +# time-stamp-end: "$" +# End: diff --git a/include/Makefile.am b/include/Makefile.am new file mode 100644 index 0000000..9d963a0 --- /dev/null +++ b/include/Makefile.am @@ -0,0 +1,3 @@ +SUBDIRS = \ + osmocom \ + $(NULL) diff --git a/include/osmocom/Makefile.am b/include/osmocom/Makefile.am new file mode 100644 index 0000000..3f929f1 --- /dev/null +++ b/include/osmocom/Makefile.am @@ -0,0 +1,3 @@ +SUBDIRS = \ + upf \ + $(NULL) diff --git a/include/osmocom/upf/Makefile.am b/include/osmocom/upf/Makefile.am new file mode 100644 index 0000000..2608e8f --- /dev/null +++ b/include/osmocom/upf/Makefile.am @@ -0,0 +1,3 @@ +noinst_HEADERS = \ + upf.h \ + $(NULL) diff --git a/include/osmocom/upf/upf.h b/include/osmocom/upf/upf.h new file mode 100644 index 0000000..503c5a4 --- /dev/null +++ b/include/osmocom/upf/upf.h @@ -0,0 +1,12 @@ +/* Global definitions for OsmoUPF */ +#pragma once + +struct ctrl_handle; + +struct g_upf { + struct ctrl_handle *ctrl; +}; + +extern struct g_upf *g_upf; + +void g_upf_alloc(void *ctx); diff --git a/osmoappdesc.py b/osmoappdesc.py new file mode 100644 index 0000000..c0729c7 --- /dev/null +++ b/osmoappdesc.py @@ -0,0 +1,27 @@ +#!/usr/bin/env python3 + +# (C) 2021 by sysmocom - s.m.f.c. GmbH +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see + +app_configs = { + "osmo-upf": ["doc/examples/osmo-upf/osmo-upf.cfg"] +} + +apps = [(4275, "src/osmo-upf/osmo-upf", "OsmoUPF", "osmo-upf") + ] + +vty_command = ["./src/osmo-upf/osmo-upf", "-c", + "doc/examples/osmo-upf/osmo-upf.cfg"] + +vty_app = apps[0] diff --git a/src/Makefile.am b/src/Makefile.am new file mode 100644 index 0000000..a8ba763 --- /dev/null +++ b/src/Makefile.am @@ -0,0 +1,3 @@ +SUBDIRS = \ + osmo-upf \ + $(NULL) diff --git a/src/osmo-upf/Makefile.am b/src/osmo-upf/Makefile.am new file mode 100644 index 0000000..ec04fc7 --- /dev/null +++ b/src/osmo-upf/Makefile.am @@ -0,0 +1,33 @@ +AM_CPPFLAGS = \ + $(all_includes) \ + -I$(top_srcdir)/include \ + -I$(top_builddir) \ + $(NULL) + +AM_CFLAGS = \ + -Wall \ + $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOVTY_CFLAGS) \ + $(LIBOSMOCTRL_CFLAGS) \ + $(COVERAGE_CFLAGS) \ + $(NULL) + +AM_LDFLAGS = \ + $(COVERAGE_LDFLAGS) \ + $(NULL) + +bin_PROGRAMS = \ + osmo-upf \ + $(NULL) + +osmo_upf_SOURCES = \ + osmo_upf_main.c \ + upf.c \ + $(NULL) + +osmo_upf_LDADD = \ + $(LIBOSMOCORE_LIBS) \ + $(LIBOSMOVTY_LIBS) \ + $(LIBOSMOCTRL_LIBS) \ + $(COVERAGE_LDFLAGS) \ + $(NULL) diff --git a/src/osmo-upf/osmo_upf_main.c b/src/osmo-upf/osmo_upf_main.c new file mode 100644 index 0000000..f171232 --- /dev/null +++ b/src/osmo-upf/osmo_upf_main.c @@ -0,0 +1,315 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * All Rights Reserved + * + * Author: Neels Hofmeyr + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#define _GNU_SOURCE +#include + +/* build switches from the configure script */ +#include "config.h" + +#include +#include + +extern void *tall_vty_ctx; + +void *tall_upf_ctx = NULL; +static int quit = 0; + +static struct { + const char *config_file; + int daemonize; + enum vty_ref_gen_mode vty_ref_gen_mode; +} upf_cmdline_config = { + .config_file = "osmo-upf.cfg", + .vty_ref_gen_mode = VTY_REF_GEN_MODE_DEFAULT, +}; + +static void print_usage() +{ + printf("Usage: osmo-upf\n"); +} + +static void print_help() +{ + const struct value_string *vty_ref_gen_mode_name; + + printf("Some useful options:\n"); + printf(" -h --help This text.\n"); + printf(" -D --daemonize Fork the process into a background daemon.\n"); + printf(" -c --config-file filename The config file to use.\n"); + printf(" -V --version Print the version of OsmoMSC.\n"); + + printf("\nVTY reference generation:\n"); + printf(" --vty-ref-xml Generate the VTY reference XML output and exit.\n"); + printf(" --vty-ref-mode MODE Mode for --vty-ref-xml:\n"); + /* List all VTY ref gen modes */ + for (vty_ref_gen_mode_name = vty_ref_gen_mode_names; vty_ref_gen_mode_name->str; vty_ref_gen_mode_name++) + printf(" %s: %s\n", + vty_ref_gen_mode_name->str, + get_value_string(vty_ref_gen_mode_desc, vty_ref_gen_mode_name->value)); +} + +static void handle_long_options(const char *prog_name, const int long_option) +{ + switch (long_option) { + case 1: + upf_cmdline_config.vty_ref_gen_mode = get_string_value(vty_ref_gen_mode_names, optarg); + if (upf_cmdline_config.vty_ref_gen_mode < 0) { + fprintf(stderr, "%s: Unknown VTY reference generation mode: '%s'\n", prog_name, optarg); + exit(2); + } + break; + case 2: + fprintf(stderr, "Generating the VTY reference in mode '%s' (%s)\n", + get_value_string(vty_ref_gen_mode_names, upf_cmdline_config.vty_ref_gen_mode), + get_value_string(vty_ref_gen_mode_desc, upf_cmdline_config.vty_ref_gen_mode)); + vty_dump_xml_ref_mode(stdout, upf_cmdline_config.vty_ref_gen_mode); + exit(0); + default: + fprintf(stderr, "%s: error parsing cmdline options\n", prog_name); + exit(2); + } +} + +static void handle_options(int argc, char **argv) +{ + while (1) { + int option_index = 0, c; + static int long_option = 0; + static struct option long_options[] = { + {"help", 0, 0, 'h'}, + {"daemonize", 0, 0, 'D'}, + {"config-file", 1, 0, 'c'}, + {"version", 0, 0, 'V' }, + {"vty-ref-mode", 1, &long_option, 1}, + {"vty-ref-xml", 0, &long_option, 2}, + {0, 0, 0, 0} + }; + + c = getopt_long(argc, argv, "hDc:V", long_options, &option_index); + if (c == -1) + break; + + switch (c) { + case 'h': + print_usage(); + print_help(); + exit(0); + case 0: + handle_long_options(argv[0], long_option); + break; + case 'D': + upf_cmdline_config.daemonize = 1; + break; + case 'c': + upf_cmdline_config.config_file = optarg; + break; + case 'V': + print_version(1); + exit(0); + break; + default: + /* catch unknown options *as well as* missing arguments. */ + fprintf(stderr, "%s: Error in command line options. Exiting.\n", argv[0]); + exit(-1); + } + } + + if (argc > optind) { + fprintf(stderr, "%s: Unsupported positional arguments on command line\n", argv[0]); + exit(2); + } +} + +static void signal_handler(int signum) +{ + fprintf(stdout, "signal %u received\n", signum); + + switch (signum) { + case SIGINT: + case SIGTERM: + LOGP(DLGLOBAL, LOGL_NOTICE, "Terminating due to signal %d\n", signum); + quit++; + break; + case SIGABRT: + osmo_generate_backtrace(); + /* in case of abort, we want to obtain a talloc report and + * then run default SIGABRT handler, who will generate coredump + * and abort the process. abort() should do this for us after we + * return, but program wouldn't exit if an external SIGABRT is + * received. + */ + talloc_report(tall_vty_ctx, stderr); + talloc_report_full(tall_upf_ctx, stderr); + signal(SIGABRT, SIG_DFL); + raise(SIGABRT); + break; + case SIGUSR1: + talloc_report(tall_vty_ctx, stderr); + talloc_report_full(tall_upf_ctx, stderr); + break; + case SIGUSR2: + talloc_report_full(tall_vty_ctx, stderr); + break; + default: + break; + } +} + +static const char * const osmo_upf_copyright = + "OsmoUPF - Osmocom User Plane Function implementation\r\n" + "Copyright (C) 2021 by sysmocom - s.f.m.c. GmbH \r\n" + "License AGPLv3+: GNU AGPL version 3 or later \r\n" + "This is free software: you are free to change and redistribute it.\r\n" + "There is NO WARRANTY, to the extent permitted by law.\r\n"; + +static struct vty_app_info upf_vty_app_info = { + .name = "OsmoUPF", + .version = PACKAGE_VERSION, + .copyright = osmo_upf_copyright, +}; + +static const struct log_info_cat upf_default_categories[] = { +}; + +const struct log_info log_info = { + .cat = upf_default_categories, + .num_cat = ARRAY_SIZE(upf_default_categories), +}; + +int main(int argc, char **argv) +{ + int rc; + + /* Track the use of talloc NULL memory contexts */ + talloc_enable_null_tracking(); + + osmo_fsm_set_dealloc_ctx(OTC_SELECT); + + tall_upf_ctx = talloc_named_const(NULL, 1, "osmo-upf"); + upf_vty_app_info.tall_ctx = tall_upf_ctx; + + msgb_talloc_ctx_init(tall_upf_ctx, 0); + osmo_signal_talloc_ctx_init(tall_upf_ctx); + + osmo_init_logging2(tall_upf_ctx, &log_info); + + osmo_fsm_log_timeouts(true); + osmo_fsm_log_addr(true); + + osmo_stats_init(tall_upf_ctx); + + g_upf_alloc(tall_upf_ctx); + + /* For --version, vty_init() must be called before handling options */ + vty_init(&upf_vty_app_info); + + ctrl_vty_init(tall_upf_ctx); + logging_vty_add_cmds(); + osmo_talloc_vty_add_cmds(); + osmo_cpu_sched_vty_init(tall_upf_ctx); + + /* Parse options */ + handle_options(argc, argv); + + rc = vty_read_config_file(upf_cmdline_config.config_file, NULL); + if (rc < 0) { + LOGP(DLGLOBAL, LOGL_FATAL, "Failed to parse the config file: '%s'\n", + upf_cmdline_config.config_file); + return 1; + } + + /* start telnet, after reading config for vty_get_bind_addr() */ + rc = telnet_init_dynif(tall_upf_ctx, &g_upf, vty_get_bind_addr(), OSMO_VTY_PORT_UPF); + if (rc < 0) + return 2; + + /* start control interface, after reading config for ctrl_vty_get_bind_addr() */ + g_upf->ctrl = ctrl_interface_setup_dynip(g_upf, ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_UPF, NULL); + if (!g_upf->ctrl) { + fprintf(stderr, "Failed to initialize control interface. Exiting.\n"); + return -1; + } + + signal(SIGINT, &signal_handler); + signal(SIGTERM, &signal_handler); + signal(SIGABRT, &signal_handler); + signal(SIGUSR1, &signal_handler); + signal(SIGUSR2, &signal_handler); + osmo_init_ignore_signals(); + + if (upf_cmdline_config.daemonize) { + rc = osmo_daemonize(); + if (rc < 0) { + perror("Error during daemonize"); + return 6; + } + } + + do { + log_reset_context(); + osmo_select_main_ctx(0); + + /* If the user hits Ctrl-C the third time, just terminate immediately. */ + if (quit >= 3) + break; + + /* Has SIGTERM been received (and not yet been handled)? */ + if (quit && !osmo_select_shutdown_requested()) { + osmo_signal_dispatch(SS_L_GLOBAL, S_L_GLOBAL_SHUTDOWN, NULL); + + /* Request write-only mode in osmo_select_main_ctx() */ + osmo_select_shutdown_request(); + /* continue the main select loop until all write queues are serviced. */ + } + } while (!osmo_select_shutdown_done()); + + log_fini(); + + /* Report the heap state of talloc contexts, then free, so both ASAN and Valgrind are happy... */ + talloc_report_full(tall_upf_ctx, stderr); + talloc_free(tall_upf_ctx); + + talloc_report_full(tall_vty_ctx, stderr); + talloc_free(tall_vty_ctx); + + talloc_report_full(NULL, stderr); + talloc_disable_null_tracking(); + return 0; +} diff --git a/src/osmo-upf/upf.c b/src/osmo-upf/upf.c new file mode 100644 index 0000000..6bb5482 --- /dev/null +++ b/src/osmo-upf/upf.c @@ -0,0 +1,30 @@ +/* (C) 2021 by sysmocom - s.f.m.c. GmbH + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include + +#include + +struct g_upf *g_upf = NULL; + +void g_upf_alloc(void *ctx) +{ + OSMO_ASSERT(g_upf == NULL); + g_upf = talloc_zero(ctx, struct g_upf); +} diff --git a/tests/Makefile.am b/tests/Makefile.am new file mode 100644 index 0000000..d04a753 --- /dev/null +++ b/tests/Makefile.am @@ -0,0 +1,72 @@ +SUBDIRS = \ + $(NULL) + +# The `:;' works around a Bash 3.2 bug when the output is not writeable. +$(srcdir)/package.m4: $(top_srcdir)/configure.ac + :;{ \ + echo '# Signature of the current package.' && \ + echo 'm4_define([AT_PACKAGE_NAME],' && \ + echo ' [$(PACKAGE_NAME)])' && \ + echo 'm4_define([AT_PACKAGE_TARNAME],' && \ + echo ' [$(PACKAGE_TARNAME)])' && \ + echo 'm4_define([AT_PACKAGE_VERSION],' && \ + echo ' [$(PACKAGE_VERSION)])' && \ + echo 'm4_define([AT_PACKAGE_STRING],' && \ + echo ' [$(PACKAGE_STRING)])' && \ + echo 'm4_define([AT_PACKAGE_BUGREPORT],' && \ + echo ' [$(PACKAGE_BUGREPORT)])'; \ + echo 'm4_define([AT_PACKAGE_URL],' && \ + echo ' [$(PACKAGE_URL)])'; \ + } >'$(srcdir)/package.m4' + +EXTRA_DIST = \ + testsuite.at \ + $(srcdir)/package.m4 \ + $(TESTSUITE) \ + $(NULL) + +TESTSUITE = $(srcdir)/testsuite + +DISTCLEANFILES = \ + atconfig \ + $(NULL) + +if ENABLE_EXT_TESTS +python-tests: $(BUILT_SOURCES) + $(MAKE) vty-test + osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v + osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v +else +python-tests: $(BUILT_SOURCES) + echo "Not running python-based tests (determined at configure-time)" +endif + +# Run a specific test with: 'make vty-test VTY_TEST=foo.vty' +VTY_TEST ?= *.vty + +# To update the VTY script from current application behavior, +# pass -u to vty_script_runner.py by doing: +# make vty-test U=-u +vty-test: + osmo_verify_transcript_vty.py -v \ + -n OsmoUPF -p 4275 \ + -r "$(top_builddir)/src/osmo-upf/osmo-upf -c $(top_srcdir)/doc/examples/osmo-upf/osmo-upf.cfg" \ + $(U) $(srcdir)/$(VTY_TEST) + +check-local: atconfig $(TESTSUITE) + $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) + $(MAKE) $(AM_MAKEFLAGS) python-tests + +installcheck-local: atconfig $(TESTSUITE) + $(SHELL) '$(TESTSUITE)' AUTOTEST_PATH='$(bindir)' \ + $(TESTSUITEFLAGS) + +clean-local: + test ! -f '$(TESTSUITE)' || \ + $(SHELL) '$(TESTSUITE)' --clean + +AUTOM4TE = $(SHELL) $(top_srcdir)/missing --run autom4te +AUTOTEST = $(AUTOM4TE) --language=autotest +$(TESTSUITE): $(srcdir)/testsuite.at $(srcdir)/package.m4 + $(AUTOTEST) -I '$(srcdir)' -o $@.tmp $@.at + mv $@.tmp $@ diff --git a/tests/atlocal.in b/tests/atlocal.in new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/tests/atlocal.in diff --git a/tests/testsuite.at b/tests/testsuite.at new file mode 100644 index 0000000..09a77c3 --- /dev/null +++ b/tests/testsuite.at @@ -0,0 +1,2 @@ +AT_INIT +AT_BANNER([Regression tests.]) diff --git a/tests/upf.vty b/tests/upf.vty new file mode 100644 index 0000000..02ea1af --- /dev/null +++ b/tests/upf.vty @@ -0,0 +1,4 @@ +OsmoUPF> enable +OsmoUPF# configure terminal +OsmoUPF(config)# show running-config +... -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/26691 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I4352dd8738a1a9de6ba2fc250ee8eef69c65ff1e Gerrit-Change-Number: 26691 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 13:14:05 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 28 Dec 2021 13:14:05 +0000 Subject: Change in osmo-bsc-nat[master]: Add project skeleton In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 ) Change subject: Add project skeleton ...................................................................... Patch Set 2: (1 comment) could be worthwhile to also look at the two project skeletons that Pau and I recently created from scratch. I found a couple of things I hadn't thought of when looking through Pau's source tree. Just pushed mine here now: https://gerrit.osmocom.org/c/osmo-upf/+/26691 and Pau's is in osmo-hnodeb.git https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658/2//COMMIT_MSG at 9 PS2, Line 9: from scratch, yaay! discard legacy crufty source code!! osmo_fsm-ize and OTC_SELECT-ize everything!!! -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Iae5d37483dcb9db00578d5c9cd1736f08754a65e Gerrit-Change-Number: 26658 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Tue, 28 Dec 2021 13:14:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 13:18:43 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 28 Dec 2021 13:18:43 +0000 Subject: Change in osmo-upf[master]: initial osmocom boilerplate source tree In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/26691 ) Change subject: initial osmocom boilerplate source tree ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-upf/+/26691/1/doc/manuals/osmoupf-usermanual-docinfo.xml File doc/manuals/osmoupf-usermanual-docinfo.xml: https://gerrit.osmocom.org/c/osmo-upf/+/26691/1/doc/manuals/osmoupf-usermanual-docinfo.xml at 7 PS1, Line 7: Initial OsmoHnodeB manual x https://gerrit.osmocom.org/c/osmo-upf/+/26691/1/doc/manuals/osmoupf-usermanual-docinfo.xml at 16 PS1, Line 16: pespin at sysmocom.de x https://gerrit.osmocom.org/c/osmo-upf/+/26691/1/doc/manuals/osmoupf-usermanual.adoc File doc/manuals/osmoupf-usermanual.adoc: https://gerrit.osmocom.org/c/osmo-upf/+/26691/1/doc/manuals/osmoupf-usermanual.adoc at 6 PS1, Line 6: Pau Espin Pedrol x -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/26691 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I4352dd8738a1a9de6ba2fc250ee8eef69c65ff1e Gerrit-Change-Number: 26691 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Comment-Date: Tue, 28 Dec 2021 13:18:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 13:23:39 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 28 Dec 2021 13:23:39 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: use osmo-config-merge to generate config files In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 ) Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files ...................................................................... Patch Set 5: Here is another problem: https://osmocom.org/issues/5377 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 Gerrit-Change-Number: 20622 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Assignee: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 28 Dec 2021 13:23:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 13:26:30 2021 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 28 Dec 2021 13:26:30 +0000 Subject: Change in osmo-upf[master]: initial osmocom boilerplate source tree In-Reply-To: References: Message-ID: neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-upf/+/26691 ) Change subject: initial osmocom boilerplate source tree ...................................................................... initial osmocom boilerplate source tree Change-Id: I4352dd8738a1a9de6ba2fc250ee8eef69c65ff1e --- A .gitignore A .gitreview A AUTHORS A Makefile.am A README.md A TODO-RELEASE A configure.ac A contrib/Makefile.am A contrib/jenkins.sh A contrib/osmo-upf.spec.in A contrib/systemd/Makefile.am A contrib/systemd/osmo-upf.service A debian/changelog A debian/compat A debian/control A debian/copyright A debian/osmo-upf.install A debian/rules A debian/source/format A doc/Makefile.am A doc/examples/Makefile.am A doc/examples/osmo-upf/osmo-upf.cfg A doc/manuals/Makefile.am A doc/manuals/chapters/overview.adoc A doc/manuals/osmoupf-usermanual-docinfo.xml A doc/manuals/osmoupf-usermanual.adoc A doc/manuals/osmoupf-vty-reference.xml A doc/manuals/regen_doc.sh A doc/manuals/vty/upf_vty_additions.xml A git-version-gen A include/Makefile.am A include/osmocom/Makefile.am A include/osmocom/upf/Makefile.am A include/osmocom/upf/upf.h A osmoappdesc.py A src/Makefile.am A src/osmo-upf/Makefile.am A src/osmo-upf/osmo_upf_main.c A src/osmo-upf/upf.c A tests/Makefile.am A tests/atlocal.in A tests/testsuite.at A tests/upf.vty 43 files changed, 1,568 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/91/26691/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/26691 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I4352dd8738a1a9de6ba2fc250ee8eef69c65ff1e Gerrit-Change-Number: 26691 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 15:35:32 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 28 Dec 2021 15:35:32 +0000 Subject: Change in osmo-bts[master]: phy_instance_destroy(): fix NULL pointer dereference References: Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26692 ) Change subject: phy_instance_destroy(): fix NULL pointer dereference ...................................................................... phy_instance_destroy(): fix NULL pointer dereference Change-Id: Id028577ef92d1b3ce63ba62b63b8b29edb2ae5a4 Fixes: OS#5377 --- M src/common/phy_link.c 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/26692/1 diff --git a/src/common/phy_link.c b/src/common/phy_link.c index 5ad72ac..352d8f7 100644 --- a/src/common/phy_link.c +++ b/src/common/phy_link.c @@ -129,10 +129,12 @@ /* remove from list of instances in the link */ llist_del(&pinst->list); - /* remove reverse link from TRX */ - OSMO_ASSERT(pinst->trx->pinst == pinst); - pinst->trx->pinst = NULL; - pinst->trx = NULL; + /* remove reverse link from TRX (if associated) */ + if (pinst->trx != NULL) { + OSMO_ASSERT(pinst->trx->pinst == pinst); + pinst->trx->pinst = NULL; + pinst->trx = NULL; + } talloc_free(pinst); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id028577ef92d1b3ce63ba62b63b8b29edb2ae5a4 Gerrit-Change-Number: 26692 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 16:02:22 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 28 Dec 2021 16:02:22 +0000 Subject: Change in osmo-bts[master]: phy_instance_destroy(): fix NULL pointer dereference In-Reply-To: References: Message-ID: Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/26692 to look at the new patch set (#2). Change subject: phy_instance_destroy(): fix NULL pointer dereference ...................................................................... phy_instance_destroy(): fix NULL pointer dereference It's possible that a PHY instance has no associated TRX instance. Change-Id: Id028577ef92d1b3ce63ba62b63b8b29edb2ae5a4 Fixes: OS#5377 --- M src/common/phy_link.c 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/26692/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id028577ef92d1b3ce63ba62b63b8b29edb2ae5a4 Gerrit-Change-Number: 26692 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 21:05:07 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Tue, 28 Dec 2021 21:05:07 +0000 Subject: Change in osmo-mgw[master]: doc/overview: fix wrong project page link In-Reply-To: References: Message-ID: lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26690 ) Change subject: doc/overview: fix wrong project page link ...................................................................... doc/overview: fix wrong project page link Change-Id: Ie221099bf1ac278729817ae88773cfc3a709ffba --- M doc/manuals/chapters/overview.adoc 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc index 9251a7c..3c93859 100644 --- a/doc/manuals/chapters/overview.adoc +++ b/doc/manuals/chapters/overview.adoc @@ -107,8 +107,8 @@ You can find the OsmoMGW issue tracker and wiki online at -- https://osmocom.org/projects/osmomgw -- https://osmocom.org/projects/osmomgw/wiki +- https://osmocom.org/projects/osmo-mgw +- https://osmocom.org/projects/osmo-mgw/wiki RFC 3435 for MGCP is located at -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie221099bf1ac278729817ae88773cfc3a709ffba Gerrit-Change-Number: 26690 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Dec 28 21:05:47 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Tue, 28 Dec 2021 21:05:47 +0000 Subject: Change in osmo-mgw[master]: mgcp_network.c: Fix byte alignment of CRC Header for ACK Initialization In-Reply-To: References: Message-ID: lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26689 ) Change subject: mgcp_network.c: Fix byte alignment of CRC Header for ACK Initialization ...................................................................... mgcp_network.c: Fix byte alignment of CRC Header for ACK Initialization The Header CRC field is 6 bits, not 8, and spans bits 7-2. Fixes: ebb05c1f90e97d0795230e90ea49af7d084dc9fe Change-Id: I9a8179813d451948bfa02443894fdd2313dfc4a0 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 264e263..f865dfe 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1225,7 +1225,7 @@ if (data[0] == 0xe0) { data[0] = 0xe4; data[1] = 0x00; - data[2] = 0x09; /* Patch CRC Header to adapt to new header above */ + data[2] = (0x09 << 2); /* Patch CRC Header to adapt to new header above */ rtp_state->patched_first_rtp_payload = true; LOGPENDP(endp, DRTP, LOGL_DEBUG, "Patching over first two bytes" -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9a8179813d451948bfa02443894fdd2313dfc4a0 Gerrit-Change-Number: 26689 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at opensuse.org Wed Dec 29 08:53:46 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 29 Dec 2021 08:53:46 +0000 Subject: Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61cc22256a9de_64742ab6a65da5fc340379@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 110s] [296/387] installing libboost1.74-dev-1.74.0-13 [ 112s] [297/387] installing python3-lib2to3-3.9.9-3 [ 112s] [298/387] installing libhwloc-dev-2.7.0-1 [ 113s] [299/387] installing user-setup-1.88 [ 113s] [300/387] installing libibverbs1-38.0-1 [ 113s] Processing triggers for libc-bin (2.33-1) ... [ 113s] [301/387] installing libpython3.9-dev-3.9.9-2 [ 114s] Processing triggers for man-db (2.9.4-4) ... [ 114s] [302/387] installing dh-autoreconf-20 [ 114s] Processing triggers for man-db (2.9.4-4) ... [ 114s] [303/387] installing g++-11-11.2.0-13 [ 115s] [304/387] installing openssh-client-1:8.7p1-3 [ 116s] update-alternatives: using /usr/bin/ssh to provide /usr/bin/rsh (rsh) in auto mode [ 116s] update-alternatives: using /usr/bin/slogin to provide /usr/bin/rlogin (rlogin) in auto mode [ 116s] update-alternatives: and can't be the same [ 116s] Use 'update-alternatives --help' for program usage information. [ 116s] dpkg: error processing package openssh-client (--install): [ 116s] installed openssh-client package post-installation script subprocess returned error exit status 2 [ 116s] Processing triggers for man-db (2.9.4-4) ... [ 116s] Errors were encountered while processing: [ 116s] openssh-client [ 116s] exit ... [ 116s] ### VM INTERACTION START ### [ 119s] [ 102.387421] sysrq: Power Off [ 119s] [ 102.397422] reboot: Power down [ 119s] ### VM INTERACTION END ### [ 119s] [ 119s] lamb18 failed "build libusrp_3.4.6.202112290026.dsc" at Wed Dec 29 08:53:37 UTC 2021. [ 119s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 29 08:54:03 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 29 Dec 2021 08:54:03 +0000 Subject: Build failure of network:osmocom:latest/libusrp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61cc2243e853c_64742ab6a65da5fc340486@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/Debian_Unstable/x86_64 Package network:osmocom:latest/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 120s] [296/387] installing libboost1.74-dev-1.74.0-13 [ 123s] [297/387] installing python3-lib2to3-3.9.9-3 [ 123s] [298/387] installing libhwloc-dev-2.7.0-1 [ 123s] [299/387] installing user-setup-1.88 [ 124s] [300/387] installing libibverbs1-38.0-1 [ 124s] Processing triggers for libc-bin (2.33-1) ... [ 124s] [301/387] installing libpython3.9-dev-3.9.9-2 [ 125s] Processing triggers for man-db (2.9.4-4) ... [ 125s] [302/387] installing dh-autoreconf-20 [ 125s] Processing triggers for man-db (2.9.4-4) ... [ 125s] [303/387] installing g++-11-11.2.0-13 [ 127s] [304/387] installing openssh-client-1:8.7p1-3 [ 127s] update-alternatives: using /usr/bin/ssh to provide /usr/bin/rsh (rsh) in auto mode [ 127s] update-alternatives: using /usr/bin/slogin to provide /usr/bin/rlogin (rlogin) in auto mode [ 127s] update-alternatives: and can't be the same [ 127s] Use 'update-alternatives --help' for program usage information. [ 127s] dpkg: error processing package openssh-client (--install): [ 127s] installed openssh-client package post-installation script subprocess returned error exit status 2 [ 127s] Processing triggers for man-db (2.9.4-4) ... [ 127s] Errors were encountered while processing: [ 127s] openssh-client [ 127s] exit ... [ 127s] ### VM INTERACTION START ### [ 130s] [ 112.140167] sysrq: Power Off [ 131s] [ 112.144020] reboot: Power down [ 131s] ### VM INTERACTION END ### [ 131s] [ 131s] lamb26 failed "build libusrp_3.4.6.dsc" at Wed Dec 29 08:53:51 UTC 2021. [ 131s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 29 08:59:43 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 29 Dec 2021 08:59:43 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61cc238c68acf_64742ab6a65da5fc3412b9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 145s] This may take some time... done. [ 145s] Processing triggers for man-db (2.9.4-4) ... [ 146s] [534/649] installing texlive-science-2021.20211217-1 [ 146s] Processing triggers for man-db (2.9.4-4) ... [ 146s] Processing triggers for tex-common (6.17) ... [ 146s] Running mktexlsr. This may take some time... done. [ 147s] Running updmap-sys. This may take some time... done. [ 147s] Running mktexlsr /var/lib/texmf ... done. [ 147s] Building format(s) --all. [ 154s] This may take some time... done. [ 154s] [535/649] installing g++-11-11.2.0-13 [ 155s] [536/649] installing openssh-client-1:8.7p1-3 [ 156s] update-alternatives: using /usr/bin/ssh to provide /usr/bin/rsh (rsh) in auto mode [ 156s] update-alternatives: using /usr/bin/slogin to provide /usr/bin/rlogin (rlogin) in auto mode [ 156s] update-alternatives: and can't be the same [ 156s] Use 'update-alternatives --help' for program usage information. [ 156s] dpkg: error processing package openssh-client (--install): [ 156s] installed openssh-client package post-installation script subprocess returned error exit status 2 [ 156s] Processing triggers for man-db (2.9.4-4) ... [ 156s] Errors were encountered while processing: [ 156s] openssh-client [ 156s] exit ... [ 156s] ### VM INTERACTION START ### [ 159s] [ 147.585872] sysrq: Power Off [ 159s] [ 147.587679] reboot: Power down [ 159s] ### VM INTERACTION END ### [ 159s] [ 159s] goat19 failed "build osmo-trx_1.4.0.dsc" at Wed Dec 29 08:59:29 UTC 2021. [ 159s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From noreply at opensuse.org Wed Dec 29 09:05:23 2021 From: noreply at opensuse.org (OBS Notification) Date: Wed, 29 Dec 2021 09:05:23 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <61cc24d53f317_64742ab6a65da5fc3427cc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 354s] This may take some time... done. [ 354s] Processing triggers for man-db (2.9.4-4) ... [ 356s] [534/649] installing texlive-science-2021.20211217-1 [ 356s] Processing triggers for man-db (2.9.4-4) ... [ 357s] Processing triggers for tex-common (6.17) ... [ 357s] Running mktexlsr. This may take some time... done. [ 358s] Running updmap-sys. This may take some time... done. [ 358s] Running mktexlsr /var/lib/texmf ... done. [ 358s] Building format(s) --all. [ 372s] This may take some time... done. [ 372s] [535/649] installing g++-11-11.2.0-13 [ 373s] [536/649] installing openssh-client-1:8.7p1-3 [ 373s] update-alternatives: using /usr/bin/ssh to provide /usr/bin/rsh (rsh) in auto mode [ 373s] update-alternatives: using /usr/bin/slogin to provide /usr/bin/rlogin (rlogin) in auto mode [ 373s] update-alternatives: and can't be the same [ 373s] Use 'update-alternatives --help' for program usage information. [ 373s] dpkg: error processing package openssh-client (--install): [ 373s] installed openssh-client package post-installation script subprocess returned error exit status 2 [ 373s] Processing triggers for man-db (2.9.4-4) ... [ 374s] Errors were encountered while processing: [ 374s] openssh-client [ 374s] exit ... [ 374s] ### VM INTERACTION START ### [ 377s] [ 352.010154][ T410] sysrq: Power Off [ 377s] [ 352.012594][ T16] reboot: Power down [ 377s] ### VM INTERACTION END ### [ 377s] [ 377s] lamb01 failed "build osmo-trx_1.4.0.1.424c.202112290026.dsc" at Wed Dec 29 09:05:08 UTC 2021. [ 377s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Dec 29 16:07:13 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 29 Dec 2021 16:07:13 +0000 Subject: Change in osmo-ci[master]: jenkins-jobs: add master build for opencm3 projects References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26693 ) Change subject: jenkins-jobs: add master build for opencm3 projects ...................................................................... jenkins-jobs: add master build for opencm3 projects Change-Id: I95f84079478ce57d8d5c0cffd71bc67e1605e68e --- M jobs/master-builds.yml 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/93/26693/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 65b641b..0a885ff 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -342,6 +342,9 @@ - simtrace2: cmd: '{docker_run} {docker_img} /build/contrib/jenkins.sh --publish' email: gerrit-log at lists.osmocom.org laforge at gnumonks.org kredon at sysmocom.de + - osmo-opencm3-projects: + cmd: '{docker_run} {docker_img} /build/contrib/jenkins.sh --publish' + email: gerrit-log at lists.osmocom.org laforge at gnumonks.org kredon at sysmocom.de - osmo-e1d - osmo-cbc -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I95f84079478ce57d8d5c0cffd71bc67e1605e68e Gerrit-Change-Number: 26693 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 29 16:07:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 29 Dec 2021 16:07:14 +0000 Subject: Change in osmo-ci[master]: obs-mirror.sh: Keep log files of rsync job References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26694 ) Change subject: obs-mirror.sh: Keep log files of rsync job ...................................................................... obs-mirror.sh: Keep log files of rsync job Before this commit, the obs-mirror.log was overwritten every night, meaning we have no history of rsync log files. Change-Id: I26392ed8615b9f4a6aa23e92b82ad9aff01eac4b --- M contrib/obs-mirror/obs-mirror.sh 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/94/26694/1 diff --git a/contrib/obs-mirror/obs-mirror.sh b/contrib/obs-mirror/obs-mirror.sh index 529aea1..895afac 100755 --- a/contrib/obs-mirror/obs-mirror.sh +++ b/contrib/obs-mirror/obs-mirror.sh @@ -9,8 +9,10 @@ # # See also: OS#4862 -echo "Redirecting all output to: /home/pkgmirror/obs-mirror.log" -exec >"/home/pkgmirror/obs-mirror.log" 2>&1 +DATE=`date +%Y%m%d-%H%M%S` +LOGFILE="/home/pkgmirror/obs-mirror-$DATE.log" +echo "Redirecting all output to: $LOGFILE" +exec >$LOGFILE 2>&1 set -e -x SCRIPT_DIR="$(realpath "$(dirname "$(realpath "$0")")")" @@ -24,7 +26,6 @@ RSYNC_ARGS="-av --delete" RSYNC_ARGS="$RSYNC_ARGS --files-from $SCRIPT_DIR/obs-mirror-include.txt --recursive" -DATE=`date +%Y%m%d-%H%M%S` DIR="$BASE_DIR/$DATE" TEMP_DIR="$BASE_DIR/.temp" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I26392ed8615b9f4a6aa23e92b82ad9aff01eac4b Gerrit-Change-Number: 26694 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 29 16:22:04 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 29 Dec 2021 16:22:04 +0000 Subject: Change in osmo-bts[master]: phy_instance_destroy(): fix NULL pointer dereference In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26692 ) Change subject: phy_instance_destroy(): fix NULL pointer dereference ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id028577ef92d1b3ce63ba62b63b8b29edb2ae5a4 Gerrit-Change-Number: 26692 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 29 Dec 2021 16:22:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 29 16:47:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 29 Dec 2021 16:47:00 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: use osmo-config-merge to generate config files In-Reply-To: References: Message-ID: fixeria has uploaded a new patch set (#6) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 ) Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files ...................................................................... ttcn3-bts-test: use osmo-config-merge to generate config files This uses the config files from osmo-ttcn3-hacks.git instead of keeping local copies around here, which has shown many times will get out of sync. Download the original files using wget (*.src.cfg) and merge them with the local *.confmerge files using osmo-config-merge (*.gen.cfg). Unfortunately, osmo-config-merge is not capable of removing text blocks or substituting specific parts, so we fall-back to using sed where it's needed. A good example is 'log gsmtap 127.0.0.1', as there is no command for removing a logging target of such type. Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 --- M .gitignore M ttcn3-bts-test/Makefile D ttcn3-bts-test/fh/osmo-bsc.cfg A ttcn3-bts-test/fh/osmo-bsc.confmerge M ttcn3-bts-test/jenkins.sh D ttcn3-bts-test/oml/osmo-bts.cfg A ttcn3-bts-test/oml/osmo-bts.confmerge D ttcn3-bts-test/osmo-bsc.cfg A ttcn3-bts-test/osmo-bsc.confmerge D ttcn3-bts-test/osmo-bts.cfg A ttcn3-bts-test/osmo-bts.confmerge D ttcn3-bts-test/virtphy/osmo-bts.cfg A ttcn3-bts-test/virtphy/osmo-bts.confmerge 13 files changed, 316 insertions(+), 851 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/22/20622/6 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 Gerrit-Change-Number: 20622 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Assignee: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Dec 29 16:47:00 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 29 Dec 2021 16:47:00 +0000 Subject: Change in docker-playground[master]: ttcn3-bts-test: move generic config files into a directory In-Reply-To: References: Message-ID: Hello laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/26681 to look at the new patch set (#5). Change subject: ttcn3-bts-test: move generic config files into a directory ...................................................................... ttcn3-bts-test: move generic config files into a directory Change-Id: I1bc5c51306525c6829e9d8e2991555a99c9b49a2 --- M ttcn3-bts-test/Dockerfile M ttcn3-bts-test/Makefile R ttcn3-bts-test/generic/BTS_Tests.cfg R ttcn3-bts-test/generic/osmo-bsc.confmerge R ttcn3-bts-test/generic/osmo-bts.confmerge M ttcn3-bts-test/jenkins.sh 6 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/81/26681/5 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/26681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1bc5c51306525c6829e9d8e2991555a99c9b49a2 Gerrit-Change-Number: 26681 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 30 11:18:14 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 30 Dec 2021 11:18:14 +0000 Subject: Change in ...osmo_dia2gsup[master]: upgrade to lager 3.9.1 (fix builds with Erlang/OTP 24) References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26695 ) Change subject: upgrade to lager 3.9.1 (fix builds with Erlang/OTP 24) ...................................................................... upgrade to lager 3.9.1 (fix builds with Erlang/OTP 24) Change-Id: I704855533caf00046aa046d2ac9358adeadbca31 --- M rebar.config 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/95/26695/1 diff --git a/rebar.config b/rebar.config index 86444dd..0803ccd 100644 --- a/rebar.config +++ b/rebar.config @@ -2,7 +2,7 @@ {deps, [ {setup, "2.0.2"}, - {lager, "3.6.8"}, + {lager, {git, "https://github.com/erlang-lager/lager", {tag, "3.9.1"}}}, {osmo_ss7, {git, "git://git.osmocom.org/erlang/osmo_ss7", {branch, "laforge/wip"}}}, {osmo_gsup, {git, "git://git.osmocom.org/erlang/osmo_gsup", {branch, "master"}}} ]}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I704855533caf00046aa046d2ac9358adeadbca31 Gerrit-Change-Number: 26695 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 30 13:45:10 2021 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 30 Dec 2021 13:45:10 +0000 Subject: Change in osmo-ci[master]: obs-mirror.sh: Keep log files of rsync job In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26694 ) Change subject: obs-mirror.sh: Keep log files of rsync job ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I26392ed8615b9f4a6aa23e92b82ad9aff01eac4b Gerrit-Change-Number: 26694 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 30 Dec 2021 13:45:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 30 15:29:02 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 30 Dec 2021 15:29:02 +0000 Subject: Change in osmo-ci[master]: obs-mirror-archive: keep raspbian + debian 11 (instead of 10) References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26696 ) Change subject: obs-mirror-archive: keep raspbian + debian 11 (instead of 10) ...................................................................... obs-mirror-archive: keep raspbian + debian 11 (instead of 10) Debian / Raspbian 10 are getting a bit old, and our test suites also all have shifted to 11 by now, so let's rather keep a nightly archive of 11 as opposed to 10 Change-Id: Id08acf82d9c959553684d0d95b31a8c0379115a6 --- M contrib/obs-mirror/obs-mirror-include.txt 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/96/26696/1 diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt index 037ce3f..ffb62d3 100644 --- a/contrib/obs-mirror/obs-mirror-include.txt +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -1,9 +1,9 @@ latest/CentOS_8 -latest/Debian_10 -latest/Raspbian_10 +latest/Debian_11 +latest/Raspbian_11 latest/xUbuntu_21.04 nightly/CentOS_8 -nightly/Debian_10 -nightly/Raspbian_10 +nightly/Debian_11 +nightly/Raspbian_11 nightly/xUbuntu_21.04 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id08acf82d9c959553684d0d95b31a8c0379115a6 Gerrit-Change-Number: 26696 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 30 15:29:03 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 30 Dec 2021 15:29:03 +0000 Subject: Change in osmo-ci[master]: obs-mirror: Keep more 'latest' distributions References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26697 ) Change subject: obs-mirror: Keep more 'latest' distributions ...................................................................... obs-mirror: Keep more 'latest' distributions 'latest' doesn't change very often, so we can keep history for more distros. Change-Id: I3c8ac31bdf394f8b94ed643413ee2a1379eb76a2 --- M contrib/obs-mirror/obs-mirror-include.txt 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/97/26697/1 diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt index ffb62d3..ba1b3f3 100644 --- a/contrib/obs-mirror/obs-mirror-include.txt +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -1,6 +1,13 @@ +latest/CentOS_7 latest/CentOS_8 +latest/Debian_9.0 +latest/Debian_10 latest/Debian_11 +latest/Raspbian_10 latest/Raspbian_11 +latest/xUbuntu_18.04 +latest/xUbuntu_19.04 +latest/xUbuntu_20.04 latest/xUbuntu_21.04 nightly/CentOS_8 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3c8ac31bdf394f8b94ed643413ee2a1379eb76a2 Gerrit-Change-Number: 26697 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 30 15:30:41 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 30 Dec 2021 15:30:41 +0000 Subject: Change in osmo-ci[master]: obs-mirror.sh: Keep log files of rsync job In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26694 ) Change subject: obs-mirror.sh: Keep log files of rsync job ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I26392ed8615b9f4a6aa23e92b82ad9aff01eac4b Gerrit-Change-Number: 26694 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 30 Dec 2021 15:30:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 30 15:30:48 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 30 Dec 2021 15:30:48 +0000 Subject: Change in osmo-ci[master]: obs-mirror.sh: Keep log files of rsync job In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26694 ) Change subject: obs-mirror.sh: Keep log files of rsync job ...................................................................... obs-mirror.sh: Keep log files of rsync job Before this commit, the obs-mirror.log was overwritten every night, meaning we have no history of rsync log files. Change-Id: I26392ed8615b9f4a6aa23e92b82ad9aff01eac4b --- M contrib/obs-mirror/obs-mirror.sh 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/obs-mirror/obs-mirror.sh b/contrib/obs-mirror/obs-mirror.sh index 529aea1..895afac 100755 --- a/contrib/obs-mirror/obs-mirror.sh +++ b/contrib/obs-mirror/obs-mirror.sh @@ -9,8 +9,10 @@ # # See also: OS#4862 -echo "Redirecting all output to: /home/pkgmirror/obs-mirror.log" -exec >"/home/pkgmirror/obs-mirror.log" 2>&1 +DATE=`date +%Y%m%d-%H%M%S` +LOGFILE="/home/pkgmirror/obs-mirror-$DATE.log" +echo "Redirecting all output to: $LOGFILE" +exec >$LOGFILE 2>&1 set -e -x SCRIPT_DIR="$(realpath "$(dirname "$(realpath "$0")")")" @@ -24,7 +26,6 @@ RSYNC_ARGS="-av --delete" RSYNC_ARGS="$RSYNC_ARGS --files-from $SCRIPT_DIR/obs-mirror-include.txt --recursive" -DATE=`date +%Y%m%d-%H%M%S` DIR="$BASE_DIR/$DATE" TEMP_DIR="$BASE_DIR/.temp" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I26392ed8615b9f4a6aa23e92b82ad9aff01eac4b Gerrit-Change-Number: 26694 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 30 15:32:18 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 30 Dec 2021 15:32:18 +0000 Subject: Change in osmo-ci[master]: obs-mirror-archive: keep raspbian + debian 11 (instead of 10) In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26696 ) Change subject: obs-mirror-archive: keep raspbian + debian 11 (instead of 10) ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id08acf82d9c959553684d0d95b31a8c0379115a6 Gerrit-Change-Number: 26696 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 30 Dec 2021 15:32:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 30 15:32:26 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 30 Dec 2021 15:32:26 +0000 Subject: Change in osmo-ci[master]: obs-mirror: Keep more 'latest' distributions In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26697 ) Change subject: obs-mirror: Keep more 'latest' distributions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3c8ac31bdf394f8b94ed643413ee2a1379eb76a2 Gerrit-Change-Number: 26697 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 30 Dec 2021 15:32:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 30 15:32:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 30 Dec 2021 15:32:28 +0000 Subject: Change in osmo-ci[master]: obs-mirror-archive: keep raspbian + debian 11 (instead of 10) In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26696 ) Change subject: obs-mirror-archive: keep raspbian + debian 11 (instead of 10) ...................................................................... obs-mirror-archive: keep raspbian + debian 11 (instead of 10) Debian / Raspbian 10 are getting a bit old, and our test suites also all have shifted to 11 by now, so let's rather keep a nightly archive of 11 as opposed to 10 Change-Id: Id08acf82d9c959553684d0d95b31a8c0379115a6 --- M contrib/obs-mirror/obs-mirror-include.txt 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt index 037ce3f..ffb62d3 100644 --- a/contrib/obs-mirror/obs-mirror-include.txt +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -1,9 +1,9 @@ latest/CentOS_8 -latest/Debian_10 -latest/Raspbian_10 +latest/Debian_11 +latest/Raspbian_11 latest/xUbuntu_21.04 nightly/CentOS_8 -nightly/Debian_10 -nightly/Raspbian_10 +nightly/Debian_11 +nightly/Raspbian_11 nightly/xUbuntu_21.04 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id08acf82d9c959553684d0d95b31a8c0379115a6 Gerrit-Change-Number: 26696 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 30 15:32:28 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 30 Dec 2021 15:32:28 +0000 Subject: Change in osmo-ci[master]: obs-mirror: Keep more 'latest' distributions In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26697 ) Change subject: obs-mirror: Keep more 'latest' distributions ...................................................................... obs-mirror: Keep more 'latest' distributions 'latest' doesn't change very often, so we can keep history for more distros. Change-Id: I3c8ac31bdf394f8b94ed643413ee2a1379eb76a2 --- M contrib/obs-mirror/obs-mirror-include.txt 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt index ffb62d3..ba1b3f3 100644 --- a/contrib/obs-mirror/obs-mirror-include.txt +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -1,6 +1,13 @@ +latest/CentOS_7 latest/CentOS_8 +latest/Debian_9.0 +latest/Debian_10 latest/Debian_11 +latest/Raspbian_10 latest/Raspbian_11 +latest/xUbuntu_18.04 +latest/xUbuntu_19.04 +latest/xUbuntu_20.04 latest/xUbuntu_21.04 nightly/CentOS_8 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3c8ac31bdf394f8b94ed643413ee2a1379eb76a2 Gerrit-Change-Number: 26697 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 30 19:47:10 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 30 Dec 2021 19:47:10 +0000 Subject: Change in ...osmo_dia2gsup[master]: switch back to use the master branch of osmo_ss7 References: Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26698 ) Change subject: switch back to use the master branch of osmo_ss7 ...................................................................... switch back to use the master branch of osmo_ss7 Add the missing ipa_ccm_options record to use the new api Change-Id: I89ff055ed84e394d0f25bc6389d1f4d757f7b92b --- M rebar.config M src/gsup_client.erl 2 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/98/26698/1 diff --git a/rebar.config b/rebar.config index 0803ccd..66db6b5 100644 --- a/rebar.config +++ b/rebar.config @@ -3,7 +3,7 @@ {deps, [ {setup, "2.0.2"}, {lager, {git, "https://github.com/erlang-lager/lager", {tag, "3.9.1"}}}, - {osmo_ss7, {git, "git://git.osmocom.org/erlang/osmo_ss7", {branch, "laforge/wip"}}}, + {osmo_ss7, {git, "git://git.osmocom.org/erlang/osmo_ss7", {branch, "master"}}}, {osmo_gsup, {git, "git://git.osmocom.org/erlang/osmo_gsup", {branch, "master"}}} ]}. diff --git a/src/gsup_client.erl b/src/gsup_client.erl index 361864f..6a583e0 100644 --- a/src/gsup_client.erl +++ b/src/gsup_client.erl @@ -36,6 +36,7 @@ -behaviour(gen_server). -include_lib("osmo_gsup/include/gsup_protocol.hrl"). +-include_lib("osmo_ss7/include/ipa.hrl"). -define(IPAC_PROTO_EXT_GSUP, {osmo, 5}). @@ -65,8 +66,19 @@ % register the GSUP codec with the IPA core; ignore result as we mgiht be doing this multiple times ipa_proto:register_codec(?IPAC_PROTO_EXT_GSUP, fun gsup_protocol:encode/1, fun gsup_protocol:decode/1), lager:info("Connecting to GSUP HLR on IP ~s port ~p~n", [Address, Port]), + CcmOptions = #ipa_ccm_options{ + serial_number="HSS-00-00-00-00-00-00", + unit_id="0/0/0", + mac_address="00:00:00:00:00:00", + location="00:00:00:00:00:00", + unit_type="00:00:00:00:00:00", + equipment_version="00:00:00:00:00:00", + sw_version="00:00:00:00:00:00", + unit_name="HSS-00-00-00-00-00-00" + }, case ipa_proto:connect(Address, Port, Options) of {ok, {Socket, IpaPid}} -> + ipa_proto:set_ccm_options(Socket, CcmOptions), lager:info("connected!~n", []), true = ipa_proto:register_stream(Socket, ?IPAC_PROTO_EXT_GSUP, {process_id, self()}), ipa_proto:unblock(Socket), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I89ff055ed84e394d0f25bc6389d1f4d757f7b92b Gerrit-Change-Number: 26698 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Dec 30 19:47:27 2021 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 30 Dec 2021 19:47:27 +0000 Subject: Change in ...osmo_dia2gsup[master]: add .gitreview configuration References: Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26699 ) Change subject: add .gitreview configuration ...................................................................... add .gitreview configuration Change-Id: I2bf183f46ca1cb62be982ddc32bd249bfdf1ca86 --- A .gitreview 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/99/26699/1 diff --git a/.gitreview b/.gitreview new file mode 100644 index 0000000..787894f --- /dev/null +++ b/.gitreview @@ -0,0 +1,3 @@ +[gerrit] +host=gerrit.osmocom.org +project=erlang/osmo_dia2gsup -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2bf183f46ca1cb62be982ddc32bd249bfdf1ca86 Gerrit-Change-Number: 26699 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 15:47:23 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 31 Dec 2021 15:47:23 +0000 Subject: Change in osmo-e1d[master]: e1d: reliably detect EOF in _e1_ts_{read, write} (RAW mode) References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26700 ) Change subject: e1d: reliably detect EOF in _e1_ts_{read,write} (RAW mode) ...................................................................... e1d: reliably detect EOF in _e1_ts_{read,write} (RAW mode) This allows us to reliably detect client disconnection at least in the case of RAW mode channels. Even with this patch applied, e1d still fails to reliably detect client disconnect on HDLC-FCS channels. Change-Id: Ifb8b91d39b394f9c10c859f3adac85ea47b7653f --- M src/mux_demux.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/00/26700/1 diff --git a/src/mux_demux.c b/src/mux_demux.c index dffc798..bceeecd 100644 --- a/src/mux_demux.c +++ b/src/mux_demux.c @@ -147,7 +147,7 @@ break; } - if (l < 0 && errno != EAGAIN) { + if ((l < 0 && errno != EAGAIN) || l == 0) { LOGPTS(ts, DE1D, LOGL_ERROR, "dead socket during read: %s\n", strerror(errno)); e1_ts_stop(ts); @@ -293,7 +293,7 @@ break; } - if (rv < 0 && errno != EAGAIN) { + if ((rv < 0 && errno != EAGAIN) || rv == 0) { LOGPTS(ts, DE1D, LOGL_ERROR, "dead socket during write: %s\n", strerror(errno)); e1_ts_stop(ts); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ifb8b91d39b394f9c10c859f3adac85ea47b7653f Gerrit-Change-Number: 26700 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 15:47:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 31 Dec 2021 15:47:24 +0000 Subject: Change in osmo-e1d[master]: e1d: reliably detect EOF (HDLC-FCS mode) References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26701 ) Change subject: e1d: reliably detect EOF (HDLC-FCS mode) ...................................................................... e1d: reliably detect EOF (HDLC-FCS mode) This patch makes e1d reliably detect EOF on client sockets while in HDLC-FCS mode. Change-Id: I0260360643f723f7c721ae67c47dce8df7778694 --- M src/mux_demux.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/01/26701/1 diff --git a/src/mux_demux.c b/src/mux_demux.c index bceeecd..341256a 100644 --- a/src/mux_demux.c +++ b/src/mux_demux.c @@ -62,7 +62,7 @@ LOGPTS(ts, DXFR, LOGL_DEBUG, "RX Message: %d [ %s]\n", rv, osmo_hexdump(ts->hdlc.rx_buf, rv)); rv = write(ts->fd, ts->hdlc.rx_buf, bytes_to_write); - if (rv < 0) + if (rv <= 0) return rv; } else if (rv < 0 && ts->id == 4) { LOGPTS(ts, DXFR, LOGL_ERROR, "ERR RX: %d %d %d [ %s]\n", @@ -97,7 +97,7 @@ rv, osmo_hexdump(ts->hdlc.tx_buf, rv)); ts->hdlc.tx_len = rv; ts->hdlc.tx_ofs = 0; - } else if (rv < 0 && errno != EAGAIN) + } else if ((rv < 0 && errno != EAGAIN) || rv == 0) return rv; } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I0260360643f723f7c721ae67c47dce8df7778694 Gerrit-Change-Number: 26701 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 15:47:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 31 Dec 2021 15:47:24 +0000 Subject: Change in osmo-e1d[master]: Introduce a #define for the maximum HDLC buffer size (264) References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26702 ) Change subject: Introduce a #define for the maximum HDLC buffer size (264) ...................................................................... Introduce a #define for the maximum HDLC buffer size (264) The purpose of turning the magic number into a #define is to allow clients to use it. Change-Id: I9281a4cd85d79823d06860ffaaa09b6d67bc0de3 --- M include/osmocom/e1d/proto.h M src/e1d.h 2 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/02/26702/1 diff --git a/include/osmocom/e1d/proto.h b/include/osmocom/e1d/proto.h index 6457f14..3033f11 100644 --- a/include/osmocom/e1d/proto.h +++ b/include/osmocom/e1d/proto.h @@ -92,6 +92,7 @@ #define E1DP_INVALID 0xff #define E1DP_DEFAULT_SOCKET "/tmp/osmo-e1d.ctl" +#define E1DP_MAX_SIZE_HDLC 264 struct osmo_e1dp_msg_hdr { uint16_t magic; diff --git a/src/e1d.h b/src/e1d.h index e824f8f..af6c09e 100644 --- a/src/e1d.h +++ b/src/e1d.h @@ -30,6 +30,8 @@ #include #include +#include + enum e1d_vty_node { E1D_NODE = _LAST_OSMOVTY_NODE + 1, LINE_NODE @@ -66,8 +68,8 @@ struct osmo_isdnhdlc_vars tx; struct osmo_isdnhdlc_vars rx; - uint8_t rx_buf[264]; - uint8_t tx_buf[264]; + uint8_t rx_buf[E1DP_MAX_SIZE_HDLC]; + uint8_t tx_buf[E1DP_MAX_SIZE_HDLC]; int tx_ofs; int tx_len; } hdlc; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I9281a4cd85d79823d06860ffaaa09b6d67bc0de3 Gerrit-Change-Number: 26702 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 15:47:24 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 31 Dec 2021 15:47:24 +0000 Subject: Change in osmo-e1d[master]: e1d-ts-pipe: Don't write more HDLC bytes than e1d supports References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26703 ) Change subject: e1d-ts-pipe: Don't write more HDLC bytes than e1d supports ...................................................................... e1d-ts-pipe: Don't write more HDLC bytes than e1d supports This avoids truncation and the following error message when operating in HDLC-FCS mode: <0001> mux_demux.c:91 (I0:L0:T16) Truncated message: Client tried to send 320 bytes but our buffer is limited to 264 Change-Id: I836d8b98ce5b831b0498c4650263ec3b3d4f2c45 --- M src/e1d-ts-pipe.c 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/03/26703/1 diff --git a/src/e1d-ts-pipe.c b/src/e1d-ts-pipe.c index bae45de..2928e85 100644 --- a/src/e1d-ts-pipe.c +++ b/src/e1d-ts-pipe.c @@ -39,6 +39,7 @@ static void *g_ctx; static struct osmo_e1dp_client *g_client; static struct osmo_fd ts_ofd; +static enum osmo_e1dp_ts_mode g_mode = E1DP_TSMODE_RAW; static int outfd = 1; static int infd = 0; @@ -70,7 +71,11 @@ } if (what & OSMO_FD_WRITE) { - rc = read(infd, buf, sizeof(buf)); + unsigned int read_len = sizeof(buf); + if (g_mode == E1DP_TSMODE_HDLCFCS) + read_len = E1DP_MAX_SIZE_HDLC; + + rc = read(infd, buf, read_len); if (rc < 0 && errno != EAGAIN) exit(4); else if (rc == 0) { /* EOF */ @@ -120,7 +125,6 @@ int main(int argc, char **argv) { int intf_nr = -1, line_nr = -1, ts_nr = -1; - enum osmo_e1dp_ts_mode mode = E1DP_TSMODE_RAW; char *path = E1DP_DEFAULT_SOCKET; int bufsize = 160; int tsfd; @@ -172,7 +176,7 @@ fprintf(stderr, "Unknown mode '%s'\n", optarg); exit(2); } - mode = rc; + g_mode = rc; break; case 'r': rc = open(optarg, 0, O_RDONLY); @@ -199,7 +203,7 @@ exit(1); } - tsfd = ts_open(intf_nr, line_nr, ts_nr, mode, bufsize); + tsfd = ts_open(intf_nr, line_nr, ts_nr, g_mode, bufsize); if (tsfd < 0) exit(2); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I836d8b98ce5b831b0498c4650263ec3b3d4f2c45 Gerrit-Change-Number: 26703 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 16:20:35 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 31 Dec 2021 16:20:35 +0000 Subject: Change in osmo-e1d[master]: e1d: Add watchdog timer to detect dead lines / USB devices References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26704 ) Change subject: e1d: Add watchdog timer to detect dead lines / USB devices ...................................................................... e1d: Add watchdog timer to detect dead lines / USB devices We just found a bug in icE1usb (likely firmware) which was hard to find as there was zero notification from osmo-e1d that it actually never received any data from the icE1usb hardware/firmware anymore. Change-Id: Id22e4110b9067f50b1818eb12295b2d4eb9cdc12 --- M src/e1d.h M src/intf_line.c M src/mux_demux.c 3 files changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/04/26704/1 diff --git a/src/e1d.h b/src/e1d.h index af6c09e..618776d 100644 --- a/src/e1d.h +++ b/src/e1d.h @@ -123,6 +123,12 @@ struct osmo_timer_list timer; } ts0; + /* watchdog timer to catch situations where no more USB data is received */ + struct { + struct osmo_timer_list timer; + uint32_t rx_bytes; + } watchdog; + void *e1gen_priv; }; diff --git a/src/intf_line.c b/src/intf_line.c index 5143e45..5659129 100644 --- a/src/intf_line.c +++ b/src/intf_line.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include "e1d.h" @@ -64,6 +65,20 @@ .ctr_desc = line_ctr_description, }; +/* watchdog timer, called once per second to check if we still receive data on the line */ +static void line_watchdog_cb(void *data) +{ + struct e1_line *line = data; + + if (line->watchdog.rx_bytes < 240000) { + LOGPLI(line, DE1D, LOGL_ERROR, "Received Only %u bytes/s (expected: 262144): Line dead?\n", + line->watchdog.rx_bytes); + } + + line->watchdog.rx_bytes = 0; + osmo_timer_schedule(&line->watchdog.timer, 1, 0); +} + // --------------------------------------------------------------------------- // e1d structures // --------------------------------------------------------------------------- @@ -196,6 +211,10 @@ llist_add_tail(&line->list, &intf->lines); + /* start watchdog timer */ + osmo_timer_setup(&line->watchdog.timer, line_watchdog_cb, line); + osmo_timer_schedule(&line->watchdog.timer, 1, 0); + LOGPLI(line, DE1D, LOGL_NOTICE, "Created\n"); return line; @@ -206,6 +225,8 @@ { LOGPLI(line, DE1D, LOGL_NOTICE, "Destroying\n"); + osmo_timer_del(&line->watchdog.timer); + /* close all [peer] file descriptors */ for (int i=0; i<32; i++) e1_ts_stop(&line->ts[i]); diff --git a/src/mux_demux.c b/src/mux_demux.c index 341256a..b0a9cf2 100644 --- a/src/mux_demux.c +++ b/src/mux_demux.c @@ -391,6 +391,8 @@ return -1; } + line->watchdog.rx_bytes += size; + ftr = size / 32; OSMO_ASSERT(size % 32 == 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Id22e4110b9067f50b1818eb12295b2d4eb9cdc12 Gerrit-Change-Number: 26704 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 16:47:55 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 31 Dec 2021 16:47:55 +0000 Subject: Change in ...osmo_dia2gsup[master]: add .gitreview configuration In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26699 ) Change subject: add .gitreview configuration ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2bf183f46ca1cb62be982ddc32bd249bfdf1ca86 Gerrit-Change-Number: 26699 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 31 Dec 2021 16:47:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 16:47:56 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 31 Dec 2021 16:47:56 +0000 Subject: Change in ...osmo_dia2gsup[master]: add .gitreview configuration In-Reply-To: References: Message-ID: laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26699 ) Change subject: add .gitreview configuration ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2bf183f46ca1cb62be982ddc32bd249bfdf1ca86 Gerrit-Change-Number: 26699 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 16:47:59 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 31 Dec 2021 16:47:59 +0000 Subject: Change in ...osmo_dia2gsup[master]: add .gitreview configuration In-Reply-To: References: Message-ID: laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26699 ) Change subject: add .gitreview configuration ...................................................................... add .gitreview configuration Change-Id: I2bf183f46ca1cb62be982ddc32bd249bfdf1ca86 --- A .gitreview 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/.gitreview b/.gitreview new file mode 100644 index 0000000..787894f --- /dev/null +++ b/.gitreview @@ -0,0 +1,3 @@ +[gerrit] +host=gerrit.osmocom.org +project=erlang/osmo_dia2gsup -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/26699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2bf183f46ca1cb62be982ddc32bd249bfdf1ca86 Gerrit-Change-Number: 26699 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 16:48:34 2021 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Fri, 31 Dec 2021 16:48:34 +0000 Subject: Change in osmo-e1d[master]: e1d: reliably detect EOF (HDLC-FCS mode) In-Reply-To: References: Message-ID: tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26701 ) Change subject: e1d: reliably detect EOF (HDLC-FCS mode) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I0260360643f723f7c721ae67c47dce8df7778694 Gerrit-Change-Number: 26701 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-Comment-Date: Fri, 31 Dec 2021 16:48:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 16:48:48 2021 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Fri, 31 Dec 2021 16:48:48 +0000 Subject: Change in osmo-e1d[master]: e1d: reliably detect EOF in _e1_ts_{read, write} (RAW mode) In-Reply-To: References: Message-ID: tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26700 ) Change subject: e1d: reliably detect EOF in _e1_ts_{read,write} (RAW mode) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ifb8b91d39b394f9c10c859f3adac85ea47b7653f Gerrit-Change-Number: 26700 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-Comment-Date: Fri, 31 Dec 2021 16:48:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 16:49:28 2021 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Fri, 31 Dec 2021 16:49:28 +0000 Subject: Change in osmo-e1d[master]: Introduce a #define for the maximum HDLC buffer size (264) In-Reply-To: References: Message-ID: tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26702 ) Change subject: Introduce a #define for the maximum HDLC buffer size (264) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I9281a4cd85d79823d06860ffaaa09b6d67bc0de3 Gerrit-Change-Number: 26702 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-Comment-Date: Fri, 31 Dec 2021 16:49:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 16:51:11 2021 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Fri, 31 Dec 2021 16:51:11 +0000 Subject: Change in osmo-e1d[master]: e1d-ts-pipe: Don't write more HDLC bytes than e1d supports In-Reply-To: References: Message-ID: tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26703 ) Change subject: e1d-ts-pipe: Don't write more HDLC bytes than e1d supports ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I836d8b98ce5b831b0498c4650263ec3b3d4f2c45 Gerrit-Change-Number: 26703 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-Comment-Date: Fri, 31 Dec 2021 16:51:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 16:56:34 2021 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Fri, 31 Dec 2021 16:56:34 +0000 Subject: Change in osmo-e1d[master]: e1d: Add watchdog timer to detect dead lines / USB devices In-Reply-To: References: Message-ID: tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26704 ) Change subject: e1d: Add watchdog timer to detect dead lines / USB devices ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Id22e4110b9067f50b1818eb12295b2d4eb9cdc12 Gerrit-Change-Number: 26704 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-Comment-Date: Fri, 31 Dec 2021 16:56:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Dec 31 19:35:51 2021 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 31 Dec 2021 19:35:51 +0000 Subject: Change in osmo-e1d[master]: update ice1usb_proto.h to current master References: Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26705 ) Change subject: update ice1usb_proto.h to current master ...................................................................... update ice1usb_proto.h to current master Copy from firmware source code repo at https://git.osmocom.org/osmo-e1-hardware/tree/firmware/ice40-riscv/icE1usb/ice1usb_proto.h as of d376b2e852fbf26a60ac4d6f66e54bb85f0b7204 Change-Id: I8f7b9462482421993e3516aa9d0794bb8076b65b --- M src/ice1usb_proto.h M src/usb.c 2 files changed, 16 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/05/26705/1 diff --git a/src/ice1usb_proto.h b/src/ice1usb_proto.h index 5f5f31c..71f7236 100644 --- a/src/ice1usb_proto.h +++ b/src/ice1usb_proto.h @@ -1,7 +1,14 @@ -#pragma once +/* + * ice1usb_proto.h + * + * Copyright (C) 2020 Harald Welte + * SPDX-License-Identifier: MIT + * + * Header file describing the USB protocol between the icE1usb firmware and the host + * software (currently really only osmo-e1d) + */ -/* Header file describing the USB protocol between the icE1usb firmware and the host - * software (currently really only osmo-e1d) */ +#pragma once /*********************************************************************** * Control Endpoint / Device Requests @@ -75,12 +82,12 @@ ***********************************************************************/ enum ice1usb_irq_type { - ICE1USB_IRQQ_T_ERRCNT = 1, + ICE1USB_IRQ_T_ERRCNT = 1, }; /* Ensue ro keep those in sync with e1.h */ #define ICE1USB_ERR_F_ALIGN_ERR 0x01 -#define ICE1USB_ERR_F_TICK_ERR 0x02 +#define ICE1USB_ERR_F_LOS 0x02 struct ice1usb_irq_err { /* 16-bit little-endian counters */ diff --git a/src/usb.c b/src/usb.c index 3ec793f..0e08a9f 100644 --- a/src/usb.c +++ b/src/usb.c @@ -330,10 +330,10 @@ errcnt->flags & ICE1USB_ERR_F_ALIGN_ERR ? "LOST" : "REGAINED"); } - if ((errcnt->flags & ICE1USB_ERR_F_TICK_ERR) != (last->flags & ICE1USB_ERR_F_TICK_ERR)) { + if ((errcnt->flags & ICE1USB_ERR_F_LOS) != (last->flags & ICE1USB_ERR_F_LOS)) { LOGPLI(line, DE1D, LOGL_ERROR, "Rx Clock %s\n", - errcnt->flags & ICE1USB_ERR_F_TICK_ERR ? "LOST" : "REGAINED"); - if (errcnt->flags & ICE1USB_ERR_F_TICK_ERR) + errcnt->flags & ICE1USB_ERR_F_LOS ? "LOST" : "REGAINED"); + if (errcnt->flags & ICE1USB_ERR_F_LOS) line_ctr_add(line, LINE_CTR_LOS, 1); } @@ -351,7 +351,7 @@ } switch (irq->type) { - case ICE1USB_IRQQ_T_ERRCNT: + case ICE1USB_IRQ_T_ERRCNT: if (xfer->actual_length < sizeof(*irq)) { LOGPLI(line, DE1D, LOGL_ERROR, "Short ERRCNT interrupt: %u<%zu\n", xfer->actual_length, sizeof(*irq)); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I8f7b9462482421993e3516aa9d0794bb8076b65b Gerrit-Change-Number: 26705 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: