Change in osmo-bts[master]: sched_lchan_tch_x: use functions to determine AMR tranmssion phase

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 31 15:15:14 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25296 )

Change subject: sched_lchan_tch_x: use functions to determine AMR tranmssion phase
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

You added an amr test dir but forgot to include the test files?

https://gerrit.osmocom.org/c/osmo-bts/+/25296/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/25296/1//COMMIT_MSG@12 
PS1, Line 12: receiver should use). codec idfentifer. The formulas in the present
1-remove dot
2-"identifier" ?


https://gerrit.osmocom.org/c/osmo-bts/+/25296/1/src/osmo-bts-trx/sched_lchan_tchf.c 
File src/osmo-bts-trx/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25296/1/src/osmo-bts-trx/sched_lchan_tchf.c@470 
PS1, Line 470: 				LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Codec (FT = %d) "
Shouldn't we keep sending with the older type until we can change it? I'd expect the received to account for this scenario...


https://gerrit.osmocom.org/c/osmo-bts/+/25296/1/src/osmo-bts-trx/sched_utils.h 
File src/osmo-bts-trx/sched_utils.h:

https://gerrit.osmocom.org/c/osmo-bts/+/25296/1/src/osmo-bts-trx/sched_utils.h@40 
PS1, Line 40: /*! determine the whether an uplink AMR block is CMI according to 3GPP TS 45.009.
"the whether" is wrong.


https://gerrit.osmocom.org/c/osmo-bts/+/25296/1/src/osmo-bts-trx/sched_utils.h@45 
PS1, Line 45: 	uint32_t fn_26 = fn_begin % 26;
No reason for this variable, put it in the switch directly.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25296
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I94a934a6b3b397b4cd0e9da3577325de58814335
Gerrit-Change-Number: 25296
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 31 Aug 2021 15:15:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210831/1196cb1d/attachment.htm>


More information about the gerrit-log mailing list