Change in osmo-bsc[master]: bty_vty: add VTY settungs for temporary overpower

dexter gerrit-no-reply at lists.osmocom.org
Tue Aug 31 12:17:37 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25283 )

Change subject: bty_vty: add VTY settungs for temporary overpower
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/25283/1/src/osmo-bsc/abis_rsl.c 
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25283/1/src/osmo-bsc/abis_rsl.c@563 
PS1, Line 563: 	cap = (struct abis_rsl_osmo_top_acch_cap *)msg->tail;
> I think this approach is rather weird. […]
Hmm. I agree that having a struct with only one element might introduce over complexity. We might consider to simplify that.

The msgb_tlv_put should be generic. temporary_overpower is of type struct abis_rsl_osmo_top_acch_cap, so it is copying struct to struct. I see this also in other places and I did it the same way in rep_acch_cap_for_bts() as well.

(lindent messed up the formatting too, I have corrected that now.)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25283
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I488a91bb4ed86f630db56564a0cd293f39f0f690
Gerrit-Change-Number: 25283
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 31 Aug 2021 12:17:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210831/d05e5a73/attachment.htm>


More information about the gerrit-log mailing list