Change in osmo-bts[master]: osmo-bts-trx: implement Temporary Overpower for SACCH/FACCH

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 31 09:50:51 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25284 )

Change subject: osmo-bts-trx: implement Temporary Overpower for SACCH/FACCH
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/25284/1/include/osmo-bts/scheduler.h 
File include/osmo-bts/scheduler.h:

https://gerrit.osmocom.org/c/osmo-bts/+/25284/1/include/osmo-bts/scheduler.h@131 
PS1, Line 131: 	uint8_t			dl_facch_bursts;  /* number of remaining DL FACCH bursts */
would be great having "remain" in the name in order to clarify.


https://gerrit.osmocom.org/c/osmo-bts/+/25284/1/src/common/scheduler.c 
File src/common/scheduler.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25284/1/src/common/scheduler.c@1337 
PS1, Line 1337: 		br->att = l1cs->lchan->bs_power_ctrl.current;
I would rather move this to the function and rename the function be something like "apply_lchan_attenuation", which takes all the logic into account.


https://gerrit.osmocom.org/c/osmo-bts/+/25284/1/src/common/scheduler.c@1340 
PS1, Line 1340: 	} else /* Ensure no attenuation in the absence of lchan (e.g. on PDCH) */
} else {}


https://gerrit.osmocom.org/c/osmo-bts/+/25284/1/src/osmo-bts-trx/sched_lchan_tchf.c 
File src/osmo-bts-trx/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25284/1/src/osmo-bts-trx/sched_lchan_tchf.c@580 
PS1, Line 580: 		br->flags |= TRX_BR_F_FACCH;
maybe make the flag more generic? like "TRX_BR_F_OVERPOWER_ALLOWED"?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25284
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie8a626fefccf1eb07271058e5126ec106cb1abcf
Gerrit-Change-Number: 25284
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 31 Aug 2021 09:50:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210831/0b71787a/attachment.htm>


More information about the gerrit-log mailing list