Change in osmo-ttcn3-hacks[master]: pcu: as_rx_fail_dummy: Drop unneeded dependency on ms param

laforge gerrit-no-reply at lists.osmocom.org
Tue Aug 31 06:59:12 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25263 )

Change subject: pcu: as_rx_fail_dummy: Drop unneeded dependency on ms param
......................................................................

pcu: as_rx_fail_dummy: Drop unneeded dependency on ms param

The parameter is not used, so let's drop it and rename it to make it
usable without ms.

Change-Id: I57e9c754c00f930fccc35cf8d853e576fc8054da
---
M pcu/GPRS_Components.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index 2297fb6..4446b63 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -559,7 +559,7 @@
 	}
 }
 
-altstep as_ms_rx_fail_dummy(inout GprsMS ms, template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum)
+altstep as_rx_fail_dummy(template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum)
 runs on MS_BTS_IFACE_CT {
 	var BTS_PDTCH_Block data_msg;
 	[] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,
@@ -961,7 +961,7 @@
 				  block_nr := nr.blk_nr));
 	alt {
 	[exp_container_idx == 0] as_ms_rx_ignore_dummy(ms, nr);
-	[exp_container_idx > 0]	 as_ms_rx_fail_dummy(ms, nr);
+	[exp_container_idx > 0]	 as_rx_fail_dummy(nr);
 	[]	as_ms_rx_pkt_neighbor_cell_data(ms, exp_si, exp_container_idx, si_offset, nr, single_step);
 	[] 	BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr, tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH),
 					   tr_RLCMAC_DL_CTRL(?, ?)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25263
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I57e9c754c00f930fccc35cf8d853e576fc8054da
Gerrit-Change-Number: 25263
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210831/f6eacd33/attachment.htm>


More information about the gerrit-log mailing list