Change in osmo-bts[master]: l1sap/gsmtap: Don't log UI fill frames [zero information field]

laforge gerrit-no-reply at lists.osmocom.org
Tue Aug 31 06:55:56 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25237 )

Change subject: l1sap/gsmtap: Don't log UI fill frames [zero information field]
......................................................................

l1sap/gsmtap: Don't log UI fill frames [zero information field]

When generating GSMTAP, we are already suppressing generation for
fill frames on PCH and AGCH.  Let's expand that also to dedicated
channels SDCCH, TCH/F and TCH/H.  The fill frames just clog up the
logs without providing much benefit.

SACCH is still being logged, as it contains SI or MEAS REP, so every
active channel still sees GSMTAP traffic every 480ms (SACCH interval).

Change-Id: I0dd37d8848eb0379f84d15f5f006142b16823c6a
---
M src/common/l1sap.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  dexter: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  Hoernchen: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index c028a2c..3b225c2 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -474,6 +474,9 @@
 
 	switch (chan_type) {
 	case GSMTAP_CHANNEL_AGCH:
+	case GSMTAP_CHANNEL_SDCCH:
+	case GSMTAP_CHANNEL_TCH_F:
+	case GSMTAP_CHANNEL_TCH_H:
 		if (!memcmp(data, fill_frame, GSM_MACBLOCK_LEN))
 			return true;
 		break;
@@ -481,6 +484,7 @@
 		if (!memcmp(data, paging_fill, GSM_MACBLOCK_LEN))
 			return true;
 		break;
+	/* FIXME: implement the same for GSMTAP_CHANNEL_PDTCH from/to PCU */
 	/* don't use 'default' case here as the above only conditionally return true */
 	}
 	return false;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25237
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0dd37d8848eb0379f84d15f5f006142b16823c6a
Gerrit-Change-Number: 25237
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210831/9d106ef1/attachment.htm>


More information about the gerrit-log mailing list