Change in osmo-bsc[master]: bty_vty: add VTY settungs for temporary overpower

laforge gerrit-no-reply at lists.osmocom.org
Tue Aug 31 06:46:42 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25283 )

Change subject: bty_vty: add VTY settungs for temporary overpower
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/25283/1/src/osmo-bsc/abis_rsl.c 
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25283/1/src/osmo-bsc/abis_rsl.c@563 
PS1, Line 563: 	cap = (struct abis_rsl_osmo_top_acch_cap *)msg->tail;
I think this approach is rather weird.

Either 

a) we know that RSL_IE_OSMO_TOP_ACCH_CAP simply is a uint8_t and we don't use a struct, which means we can simply copy a uint8_t to the IE, or

b) we use an opaque structure, but then we should only copy structure to structure with a memcpy, rather than copying a uint8_t to the tlv, while using sizeof() of the struct.

To me, this looks like the absolute worst of both worlds.

The only advantage of introducing a struct with a single element is future extensibility, but that only makes sense if all of the code is written in a way that it does not contain any assumptions that the struct/IE only constists of a single element.  Then you must write the code in a generic way.

By mixing the two approaches it looks like it is easy to extend the s truct with additional elements, but actually it still will not work if you extend.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25283
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I488a91bb4ed86f630db56564a0cd293f39f0f690
Gerrit-Change-Number: 25283
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 31 Aug 2021 06:46:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210831/96d61e6f/attachment.htm>


More information about the gerrit-log mailing list