This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25285 ) Change subject: rsl: parse temporary overpower value RSL CHAN ACT ...................................................................... Patch Set 1: Code-Review+1 (3 comments) https://gerrit.osmocom.org/c/osmo-bts/+/25285/1/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/25285/1/src/common/rsl.c@1525 PS1, Line 1525: abis_rsl_osmo_top_acch_cap I'm wondering why are you using a struct if it is only a single uint8_t? is this expected to expand in a subsequent patch? https://gerrit.osmocom.org/c/osmo-bts/+/25285/1/src/common/rsl.c@1529 PS1, Line 1529: if (!TLVP_PRESENT(tp, RSL_IE_OSMO_TOP_ACCH_CAP)) you can use TLVP_PRES_LEN and merge those two lines. The surrounding code maybe predated that macro. https://gerrit.osmocom.org/c/osmo-bts/+/25285/1/src/common/rsl.c@1838 PS1, Line 1838: parse_temporary_overpower_acch_capability > We might want to send NACK if BTS_FEAT_ACCH_TOP is not supported by the given BTS model? good point, agreed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I426c2510865c4a986c68f2027cc676aaac0d8a4c Gerrit-Change-Number: 25285 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Tue, 31 Aug 2021 06:34:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210831/1207f136/attachment.htm>