Change in osmo-bsc[master]: vty: Fix wrong TSC sent when activating lchan through VTY

osmith gerrit-no-reply at lists.osmocom.org
Mon Aug 30 09:31:31 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25278 )

Change subject: vty: Fix wrong TSC sent when activating lchan through VTY
......................................................................


Patch Set 2:

(1 comment)

wondering about "info.requires_voice_stream = false;", otherwise LGTM!

https://gerrit.osmocom.org/c/osmo-bsc/+/25278/2/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25278/2/src/osmo-bsc/bsc_vty.c@1611 
PS2, Line 1611: 		info.activ_for = ACTIVATE_FOR_VTY;
why not move "info.requires_voice_stream = false;" here too?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25278
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I26813561ee9e7783a4004f32225f19296bd6319c
Gerrit-Change-Number: 25278
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Aug 2021 09:31:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210830/c8d18d9e/attachment.htm>


More information about the gerrit-log mailing list