Change in osmo-bsc[master]: add stat_items for BTS and TRX connection stati

pespin gerrit-no-reply at lists.osmocom.org
Mon Aug 30 08:54:57 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25274 )

Change subject: add stat_items for BTS and TRX connection stati
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I'm not really liking your approach to re-count all stuff every while. This should be done only when needed.

https://gerrit.osmocom.org/c/osmo-bsc/+/25274/1/src/osmo-bsc/bsc_stats.c 
File src/osmo-bsc/bsc_stats.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25274/1/src/osmo-bsc/bsc_stats.c@156 
PS1, Line 156: 			if (trx_is_usable(trx))
> how about: […]
I don't see the point in your suggestion. The result is going to be the same. You add some reads in favor of potentially dropping some writes, that's it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25274
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2057a798e681a169cc03243a09b3d6449734c010
Gerrit-Change-Number: 25274
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Aug 2021 08:54:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210830/0ac4f4d6/attachment.htm>


More information about the gerrit-log mailing list