This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25226 )
Change subject: add stat items bsc.0.num_msc:connected, .num_msc:total
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
combine votes
https://gerrit.osmocom.org/c/osmo-bsc/+/25226/1/src/osmo-bsc/bsc_init.c
File src/osmo-bsc/bsc_init.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/25226/1/src/osmo-bsc/bsc_init.c@50
PS1, Line 50: [BSC_STAT_NUM_BTS_TOTAL] = { "num_bts:total", "Number of configured BTS for this BSC", "", 16, 0 },
> Please better align the counter name strings so they appear at same position in line.
i see that as unnecessary overhead, also causing non-atomic patches in the future if a longer name shows up
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25226
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If76bbf9b3adb64c68d5c31c6b526fa71a99996ae
Gerrit-Change-Number: 25226
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 27 Aug 2021 07:22:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210827/dd1962d1/attachment.htm>