Change in osmo-bsc[master]: stat_item desc: add explicit indexes for clarity

neels gerrit-no-reply at lists.osmocom.org
Fri Aug 27 07:02:47 UTC 2021


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25213 )

Change subject: stat_item desc: add explicit indexes for clarity
......................................................................

stat_item desc: add explicit indexes for clarity

Add explicit indexes like [BSC_STAT_NUM_BTS_TOTAL] = { ...

BSC_STAT_NUM_BTS_TOTAL == 0 and the first item of bsc_stat_desc of
course has index 0, but when grepping the code, it looks like
BSC_STAT_NUM_BTS_TOTAL is missing a name definition.

Same for MSC_STAT_MSC_LINKS_ACTIVE and MSC_STAT_MSC_LINKS_TOTAL.

Related: SYS#5542
Change-Id: Ie47e0857c41d517a9b37be96f6669d1825d24a6d
---
M src/osmo-bsc/bsc_init.c
M src/osmo-bsc/osmo_bsc_msc.c
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bsc_init.c b/src/osmo-bsc/bsc_init.c
index 24596f4..42acbbc 100644
--- a/src/osmo-bsc/bsc_init.c
+++ b/src/osmo-bsc/bsc_init.c
@@ -47,7 +47,7 @@
 #include <stdbool.h>
 
 static const struct osmo_stat_item_desc bsc_stat_desc[] = {
-	{ "num_bts:total", "Number of configured BTS for this BSC", "", 16, 0 },
+	[BSC_STAT_NUM_BTS_TOTAL] = { "num_bts:total", "Number of configured BTS for this BSC", "", 16, 0 },
 };
 
 static const struct osmo_stat_item_group_desc bsc_statg_desc = {
diff --git a/src/osmo-bsc/osmo_bsc_msc.c b/src/osmo-bsc/osmo_bsc_msc.c
index 772bea5..a80ee64 100644
--- a/src/osmo-bsc/osmo_bsc_msc.c
+++ b/src/osmo-bsc/osmo_bsc_msc.c
@@ -147,8 +147,8 @@
 };
 
 static const struct osmo_stat_item_desc msc_stat_desc[] = {
-	{ "msc_links:active", "Number of active MSC links", "", 16, 0 },
-	{ "msc_links:total", "Number of configured MSC links", "", 16, 0 },
+	[MSC_STAT_MSC_LINKS_ACTIVE] = { "msc_links:active", "Number of active MSC links", "", 16, 0 },
+	[MSC_STAT_MSC_LINKS_TOTAL] = { "msc_links:total", "Number of configured MSC links", "", 16, 0 },
 };
 
 static const struct osmo_stat_item_group_desc msc_statg_desc = {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25213
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie47e0857c41d517a9b37be96f6669d1825d24a6d
Gerrit-Change-Number: 25213
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210827/bb25b86d/attachment.htm>


More information about the gerrit-log mailing list