Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_pdch_energy_saving

osmith gerrit-no-reply at lists.osmocom.org
Thu Aug 26 08:21:47 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25262 )

Change subject: pcu: Introduce test TC_pdch_energy_saving
......................................................................


Patch Set 1:

(1 comment)

LGTM, but I'd split it into two patches.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25262/1/pcu/GPRS_Components.ttcn 
File pcu/GPRS_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25262/1/pcu/GPRS_Components.ttcn@562 
PS1, Line 562: altstep as_rx_fail_dummy(template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum)
separate logical change, I'd put this in its own commit



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25262
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icf5cc467ecabe3fcbf86e0f4caf497669b76fb42
Gerrit-Change-Number: 25262
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Aug 2021 08:21:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210826/9f488101/attachment.htm>


More information about the gerrit-log mailing list