Change in osmo-pcu[master]: sched: energy saving: Avoid Tx dummy blocks on empty PDCH TS

osmith gerrit-no-reply at lists.osmocom.org
Thu Aug 26 08:14:14 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25242 )

Change subject: sched: energy saving: Avoid Tx dummy blocks on empty PDCH TS
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

change makes sense, just some nitpicks regarding the comment block

https://gerrit.osmocom.org/c/osmo-pcu/+/25242/1/src/gprs_rlcmac_sched.cpp 
File src/gprs_rlcmac_sched.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25242/1/src/gprs_rlcmac_sched.cpp@496 
PS1, Line 496: 		 * because temporary tbfs created to send Imm Ass Rej (see
is the reason described here the only reason, or are there more?

if it's the only reason, maybe shorten "in general, for instance because" to "if" to make it easier to read.


https://gerrit.osmocom.org/c/osmo-pcu/+/25242/1/src/gprs_rlcmac_sched.cpp@496 
PS1, Line 496: temporary tbfs
temporary temporary block flows? :) maybe "dummy TBFs" instead? handle_tbf_reject speaks of "temporary dummy TBF"



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25242
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I8d66dd5e838748611e7b77b504fc86295f02c019
Gerrit-Change-Number: 25242
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Aug 2021 08:14:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210826/3ceeeb45/attachment.htm>


More information about the gerrit-log mailing list