Change in osmo-msc[master]: vlr_auth_fsm.c: Simplify function auth_fsm_wait_ai_resync

pespin gerrit-no-reply at lists.osmocom.org
Wed Aug 25 10:14:38 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25231 )

Change subject: vlr_auth_fsm.c: Simplify function auth_fsm_wait_ai_resync
......................................................................

vlr_auth_fsm.c: Simplify function auth_fsm_wait_ai_resync

Change-Id: I2070002dea18b728deef5547b4deb6166cfcab6a
---
M src/libvlr/vlr_auth_fsm.c
1 file changed, 3 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c
index 1cacbce..a6b5cd2 100644
--- a/src/libvlr/vlr_auth_fsm.c
+++ b/src/libvlr/vlr_auth_fsm.c
@@ -438,7 +438,9 @@
 	switch (event) {
 	case VLR_AUTH_E_HLR_SAI_ACK:
 		vlr_subscr_update_tuples(vsub, gsup);
-		goto pass;
+		osmo_fsm_inst_state_chg(fi, VLR_SUB_AS_WAIT_RESP_RESYNC,
+					vlr_timer(vsub->vlr, 3260), 3260);
+		_vlr_subscr_authenticate(fi);
 		break;
 	case VLR_AUTH_E_HLR_SAI_NACK:
 		auth_fsm_term(fi,
@@ -447,12 +449,6 @@
 				      : GSM48_REJECT_NETWORK_FAILURE);
 		break;
 	}
-
-	return;
-pass:
-	osmo_fsm_inst_state_chg(fi, VLR_SUB_AS_WAIT_RESP_RESYNC,
-				vlr_timer(vsub->vlr, 3260), 3260);
-	_vlr_subscr_authenticate(fi);
 }
 
 /* Waiting for AUTH RESP from MS (re-sync case) */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25231
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I2070002dea18b728deef5547b4deb6166cfcab6a
Gerrit-Change-Number: 25231
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210825/bf0295b2/attachment.htm>


More information about the gerrit-log mailing list