Change in osmo-msc[master]: vlr_sgs.h: Set proper logic order of items in enum sgs_ue_fsm_state

pespin gerrit-no-reply at lists.osmocom.org
Wed Aug 25 10:14:37 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/25230 )

Change subject: vlr_sgs.h: Set proper logic order of items in enum sgs_ue_fsm_state
......................................................................

vlr_sgs.h: Set proper logic order of items in enum sgs_ue_fsm_state

Set order of states in the same order as they appear in the specs (see
chapter 4.2.2 mentioned above the enum).
Furthermore, from FSM state transition point of view it also makes sense
to put them in this new order, since one should pass through
SGS_UE_ST_LA_UPD_PRES to get to SGS_UE_ST_ASSOCIATED.

Change-Id: Ia9216965e9f30caedffa3cb53d14da7f7fd37b4e
---
M include/osmocom/msc/vlr_sgs.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/include/osmocom/msc/vlr_sgs.h b/include/osmocom/msc/vlr_sgs.h
index 1a4984d..05e062b 100644
--- a/include/osmocom/msc/vlr_sgs.h
+++ b/include/osmocom/msc/vlr_sgs.h
@@ -32,8 +32,8 @@
 /* See also 3GPP TS 29.118, chapter 4.2.2 States at the VLR */
 enum sgs_ue_fsm_state {
 	SGS_UE_ST_NULL,
-	SGS_UE_ST_ASSOCIATED,
 	SGS_UE_ST_LA_UPD_PRES,
+	SGS_UE_ST_ASSOCIATED,
 };
 
 enum vlr_sgs_state_tmr {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/25230
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ia9216965e9f30caedffa3cb53d14da7f7fd37b4e
Gerrit-Change-Number: 25230
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210825/c777eea0/attachment.htm>


More information about the gerrit-log mailing list