Change in libosmocore[master]: CTRL: expose stat_item groups on CTRL

dexter gerrit-no-reply at lists.osmocom.org
Wed Aug 25 08:23:48 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25224 )

Change subject: CTRL: expose stat_item groups on CTRL
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/25224/1/src/ctrl/control_if.c 
File src/ctrl/control_if.c:

https://gerrit.osmocom.org/c/libosmocore/+/25224/1/src/ctrl/control_if.c@734 
PS1, Line 734:  * stat_item.(last|...).group_name.N.item_name
> stat_item groups can also be identified by a name since recently. […]
The code below does not allow to fetch the stat items by name?


https://gerrit.osmocom.org/c/libosmocore/+/25224/1/src/ctrl/control_if.c@736 
PS1, Line 736: CTRL_CMD_DEFINE(stat_item, "stat_item *");
> IIRC there's a specific macro to define readonly commands, so you don't need to specify dummy get fu […]
That should be CTRL_CMD_DEFINE_RO(), it is also used in osmo-bsc bsc_ctrl_commands.c



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25224
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idace66b37492fe96b2f2e133a69cac7960ca279c
Gerrit-Change-Number: 25224
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Aug 2021 08:23:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210825/22d53eef/attachment.htm>


More information about the gerrit-log mailing list