Change in osmo-pcu[master]: tbf.h: Improve documentation on several flags

pespin gerrit-no-reply at lists.osmocom.org
Mon Aug 23 16:28:31 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25106 )

Change subject: tbf.h: Improve documentation on several flags
......................................................................

tbf.h: Improve documentation on several flags

Change-Id: Ice2c164ced039fb4ab621d8f7c2fb85f8348788a
---
M src/tbf.h
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve



diff --git a/src/tbf.h b/src/tbf.h
index 84c3d39..358a7ad 100644
--- a/src/tbf.h
+++ b/src/tbf.h
@@ -124,9 +124,9 @@
 
 #define GPRS_RLCMAC_FLAG_CCCH		0 /* assignment on CCCH */
 #define GPRS_RLCMAC_FLAG_PACCH		1 /* assignment on PACCH */
-#define GPRS_RLCMAC_FLAG_DL_ACK		2 /* downlink acknowledge received  */
-#define GPRS_RLCMAC_FLAG_TO_UL_ACK	3
-#define GPRS_RLCMAC_FLAG_TO_DL_ACK	4
+#define GPRS_RLCMAC_FLAG_DL_ACK		2 /* DL TBF: At least one DL ACK/NACK was recieved since it was assigned */
+#define GPRS_RLCMAC_FLAG_TO_UL_ACK	3 /* UL TBF: Failed to receive last polled CTRL ACK confirming our UL ACK/NACK */
+#define GPRS_RLCMAC_FLAG_TO_DL_ACK	4 /* DL TBF: Failed to receive last polled DL ACK/NACK */
 #define GPRS_RLCMAC_FLAG_TO_MASK	0xf0 /* timeout bits */
 
 #define T_START(tbf, t, T, r, f) tbf->t_start(t, T, r, f, __FILE__, __LINE__)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25106
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ice2c164ced039fb4ab621d8f7c2fb85f8348788a
Gerrit-Change-Number: 25106
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210823/cd1907d1/attachment.htm>


More information about the gerrit-log mailing list