This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25052 ) Change subject: Remove duplicate call to gprs_rlcmac_lost_rep ...................................................................... Remove duplicate call to gprs_rlcmac_lost_rep Function is already called by gprs_rlcmac_received_lost(), so next call following it will be sum=0 and return EINVAL. Change-Id: I015ba16d18fdd6e2441ec3c256b5ac88771d7a8b --- M src/tbf_dl.cpp 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 2154ed6..e76ea8c 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -1266,7 +1266,6 @@ /* report all outstanding packets as lost */ gprs_rlcmac_received_lost(this, 0, lost); - gprs_rlcmac_lost_rep(this); /* TODO: Reschedule all LLC frames starting with the one that is * (partly) encoded in chunk 1 of block V(A). (optional) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I015ba16d18fdd6e2441ec3c256b5ac88771d7a8b Gerrit-Change-Number: 25052 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210823/0ea8f491/attachment.htm>