Change in osmo-pcu[master]: Drop duplicate log line

pespin gerrit-no-reply at lists.osmocom.org
Mon Aug 23 16:28:06 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25049 )

Change subject: Drop duplicate log line
......................................................................

Drop duplicate log line

Same line (or similar if run_diag) is logged immediately below, showing
up twice in log which is confusing:

"""
20210726171543005 DTBF tbf.cpp:455 TBF(TFI=2 TLLI=0xfe563576 DIR=DL STATE=WAIT_RELEASE EGPRS) T3193 timeout expired, freeing TBF
20210726171543005 DTBF tbf.cpp:462 TBF(TFI=2 TLLI=0xfe563576 DIR=DL STATE=WAIT_RELEASE EGPRS) T3193 timeout expired, freeing TBF
"""

Change-Id: Ie171c458e670f8471ac93f78520a05926114c974
---
M src/tbf.cpp
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve



diff --git a/src/tbf.cpp b/src/tbf.cpp
index 107c867..6ed8e3d 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -452,9 +452,6 @@
 
 static inline void tbf_timeout_free(struct gprs_rlcmac_tbf *tbf, enum tbf_timers t, bool run_diag)
 {
-	LOGPTBF(tbf, LOGL_NOTICE, "%s timeout expired, freeing TBF\n",
-		get_value_string(tbf_timers_names, t));
-
 	if (run_diag) {
 		LOGPTBF(tbf, LOGL_NOTICE, "%s timeout expired, freeing TBF: %s\n",
 			get_value_string(tbf_timers_names, t), tbf->rlcmac_diag().c_str());

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25049
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie171c458e670f8471ac93f78520a05926114c974
Gerrit-Change-Number: 25049
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210823/53dbe9e5/attachment.htm>


More information about the gerrit-log mailing list