Change in osmo-pcu[master]: fix: handle NULL return of as_dl_tbf() and as_ul_tbf()

pespin gerrit-no-reply at lists.osmocom.org
Mon Aug 23 14:53:09 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25182 )

Change subject: fix: handle NULL return of as_dl_tbf() and as_ul_tbf()
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/25182/3/src/bts.cpp 
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25182/3/src/bts.cpp@a1172 
PS3, Line 1172: 		tbf = as_ul_tbf(poll->tbf_poll.poll_tbf);
here it can't return NULL, since poll_tbf will always be non null and since we checked it's direction==GPRS_RLCMAC_UL_TBF, we are sure we always get a correct pointer here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25182
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I8ce21be6836549b47a606c00b793d6f005964c5c
Gerrit-Change-Number: 25182
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Aug 2021 14:53:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210823/c4f6cb3b/attachment.htm>


More information about the gerrit-log mailing list