Change in osmo-bsc[master]: osmo_bsc_main: integrate MGW pooling into osmo-bsc

pespin gerrit-no-reply at lists.osmocom.org
Mon Aug 23 14:24:39 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25123 )

Change subject: osmo_bsc_main: integrate MGW pooling into osmo-bsc
......................................................................


Patch Set 10:

(9 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/10/doc/manuals/chapters/mgwpool.adoc 
File doc/manuals/chapters/mgwpool.adoc:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/10/doc/manuals/chapters/mgwpool.adoc@7 
PS10, Line 7: machnies. Until osmo-mgw includes multithreading support, it may also be used ot
to


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/10/doc/manuals/chapters/mgwpool.adoc@8 
PS10, Line 8: scale-out to multiple cores on a single host."
Remove character: "


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/10/doc/manuals/chapters/mgwpool.adoc@11 
PS10, Line 11: the pool will automatically assign the call to the MGW with the lowest load.
hint/idea: It may make sense to defie some "maximum call load" config or similar to vty, so one can calculate % of load when taking the decision. That's in case you have different hosts (different HW) serving calls running osmo-mgw.


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/10/doc/manuals/chapters/mgwpool.adoc@41 
PS10, Line 41: local host ip-addresses or different ports. When OsmoMGW is installed from
IP addresses


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/10/doc/manuals/chapters/mgwpool.adoc@64 
PS10, Line 64: each MGW must be different. Otherwise it won't be possible to distinguish the
should be


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/10/doc/manuals/chapters/mgwpool.adoc@72 
PS10, Line 72: calls.
do we have a vty command to avoid establishing new calls on a mgw node? (EDIT) Self-answer: yes. it would be nice to put a link to an anchor to the section below explaining it.


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/10/doc/manuals/chapters/mgwpool.adoc@76 
PS10, Line 76: The VTY implenets a 'show mgw-pool' command that lists the currently configured
implements


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/10/include/osmocom/bsc/gsm_data.h 
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/10/include/osmocom/bsc/gsm_data.h@1363 
PS10, Line 1363: 		/* Single MGCP client configuration under msc node (also required for
I would avoid maintaining different structs from previous versions. Let's always use a pool and put there only 1 mgw if needed.


https://gerrit.osmocom.org/c/osmo-bsc/+/25123/10/src/osmo-bsc/osmo_bsc_main.c 
File src/osmo-bsc/osmo_bsc_main.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/25123/10/src/osmo-bsc/osmo_bsc_main.c@890 
PS10, Line 890:         mgcp_client_single = mgcp_client_init(bsc_gsmnet, bsc_gsmnet->mgw.conf);
AS I said, let's rather fill the pool always from the VTY?

Maybe here, if the pool is empty, create one and put it into the pool.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25123
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8f33ab2cea04b545c403a6fe479aa963a0fc0d0d
Gerrit-Change-Number: 25123
Gerrit-PatchSet: 10
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Aug 2021 14:24:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210823/339357a4/attachment.htm>


More information about the gerrit-log mailing list