Change in docker-playground[master]: ttcn3-pcu-test: add mp_osmo_pcu_newer_than_0_9_0

osmith gerrit-no-reply at lists.osmocom.org
Mon Aug 23 13:20:24 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/25156 )

Change subject: ttcn3-pcu-test: add mp_osmo_pcu_newer_than_0_9_0
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > I would avoid this kind of parameters in the future if there's no good reason for it other than making other tests fail/crash.
> > AFAIU, in this case running the new tests on older versions would simply make the newly added test fail, but wouldn't affect others.
> > It's fine letting the testset run for a few more seconds rather than now having to add parameters, later having to remove them, etc.
> 
> I agree that these parameters don't need to be added only to prevent a new test from failing on the latest release (vs nightly).
> 
> Here the reason was different, this was needed or else a whole bunch of existing tests would fail on latest: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25185

Oh, I've confused it with another variable.

Anyway, this variable was added, so existing tests TC_paging_ps_from_sgsn_* could be extended without having them starting to fail on latest. So IMHO it's still worth to add the variable for that, it's about making sure existing tests still pass on latest.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25157


-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/25156
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Iabd0cf658f2b8e2913824b899c5bd012c587c21d
Gerrit-Change-Number: 25156
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Aug 2021 13:20:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210823/22a8b592/attachment.htm>


More information about the gerrit-log mailing list