Change in osmo-bts[master]: early IMM ASS: add configurable delay for RR IMM ASS

pespin gerrit-no-reply at lists.osmocom.org
Mon Aug 23 12:20:00 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25201 )

Change subject: early IMM ASS: add configurable delay for RR IMM ASS
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/25201/6/src/common/lchan.c 
File src/common/lchan.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25201/6/src/common/lchan.c@74 
PS6, Line 74: 			osmo_timer_del(&lchan->early_rr_ia_delay);
what if timer has never been setup before (osmo_timer_setup()). Is it safe to call this?
In general I prefer having osmo_timer_setup being called once during initialization, and not every time schedule() is called.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25201
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia1e63b98944dc840cde212fc732e20277cdc5585
Gerrit-Change-Number: 25201
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: Hoernchen <ewild at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Aug 2021 12:20:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210823/5789deeb/attachment.htm>


More information about the gerrit-log mailing list