Change in osmo-bts[master]: early IA: change default X15 timer to 0 ms

neels gerrit-no-reply at lists.osmocom.org
Sun Aug 22 19:15:59 UTC 2021


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/25215 )


Change subject: early IA: change default X15 timer to 0 ms
......................................................................

early IA: change default X15 timer to 0 ms

Tests have shown that even a delay of 0, i.e. a simple defer until the
next select() loop, makes the difference from failing to working early
IA. So set the default to 0, achieving such defer.

Change-Id: I95365649edd51114bcf6028f0dc3bbe4186f96d2
---
M src/common/bts.c
M tests/osmo-bts.vty
2 files changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/15/25215/1

diff --git a/src/common/bts.c b/src/common/bts.c
index a8a23f1..05584aa 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -144,7 +144,7 @@
 };
 
 struct osmo_tdef abis_T_defs[] = {
-	{ .T=-15, .default_val=50, .unit=OSMO_TDEF_MS, .desc="Time to wait between Channel Activation and dispatching a cached early Immediate Assignment" },
+	{ .T=-15, .default_val=0, .unit=OSMO_TDEF_MS, .desc="Time to wait between Channel Activation and dispatching a cached early Immediate Assignment" },
 	{}
 };
 
diff --git a/tests/osmo-bts.vty b/tests/osmo-bts.vty
index e39d304..4873030 100644
--- a/tests/osmo-bts.vty
+++ b/tests/osmo-bts.vty
@@ -68,7 +68,7 @@
 OsmoBTS> show timer
 bts: X1 = 300 s	Time after which osmo-bts exits if regular ramp down during shut down process does not finish (s) (default: 300 s)
 bts: X2 = 3 s	Time after which osmo-bts exits if requesting transceivers to stop during shut down process does not finish (s) (default: 3 s)
-abis: X15 = 50 ms	Time to wait between Channel Activation and dispatching a cached early Immediate Assignment (default: 50 ms)
+abis: X15 = 0 ms	Time to wait between Channel Activation and dispatching a cached early Immediate Assignment (default: 0 ms)
 OsmoBTS> show timer bts ?
   [TNNNN]  T- or X-timer-number -- 3GPP compliant timer number of the format '1234' or 'T1234' or 't1234'; Osmocom-specific timer number of the format: 'X1234' or 'x1234'.
 OsmoBTS> show timer bts
@@ -81,7 +81,7 @@
 OsmoBTS> show timer abis ?
   [TNNNN]  T- or X-timer-number -- 3GPP compliant timer number of the format '1234' or 'T1234' or 't1234'; Osmocom-specific timer number of the format: 'X1234' or 'x1234'.
 OsmoBTS> show timer abis X15
-abis: X15 = 50 ms	Time to wait between Channel Activation and dispatching a cached early Immediate Assignment (default: 50 ms)
+abis: X15 = 0 ms	Time to wait between Channel Activation and dispatching a cached early Immediate Assignment (default: 0 ms)
 
 OsmoBTS> show e1_driver ?
   <cr>  
@@ -215,13 +215,13 @@
 bts: X1 = 300 s	Time after which osmo-bts exits if regular ramp down during shut down process does not finish (s) (default: 300 s)
 
 OsmoBTS(config)# timer abis X15
-abis: X15 = 50 ms	Time to wait between Channel Activation and dispatching a cached early Immediate Assignment (default: 50 ms)
+abis: X15 = 0 ms	Time to wait between Channel Activation and dispatching a cached early Immediate Assignment (default: 0 ms)
 OsmoBTS(config)# timer abis X15 123
 OsmoBTS(config)# timer abis X15
-abis: X15 = 123 ms	Time to wait between Channel Activation and dispatching a cached early Immediate Assignment (default: 50 ms)
+abis: X15 = 123 ms	Time to wait between Channel Activation and dispatching a cached early Immediate Assignment (default: 0 ms)
 OsmoBTS(config)# timer abis X15 default
 OsmoBTS(config)# timer abis X15
-abis: X15 = 50 ms	Time to wait between Channel Activation and dispatching a cached early Immediate Assignment (default: 50 ms)
+abis: X15 = 0 ms	Time to wait between Channel Activation and dispatching a cached early Immediate Assignment (default: 0 ms)
 
 OsmoBTS(config)# bts 0
 OsmoBTS(bts)# list

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25215
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I95365649edd51114bcf6028f0dc3bbe4186f96d2
Gerrit-Change-Number: 25215
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210822/dc7a4a8b/attachment.htm>


More information about the gerrit-log mailing list