Change in libosmocore[master]: vty 'stats reset': do not reset stat_items

osmith gerrit-no-reply at lists.osmocom.org
Fri Aug 20 15:41:56 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25214 )

Change subject: vty 'stats reset': do not reset stat_items
......................................................................


Patch Set 2:

(2 comments)

I'm not sure whether this will lead to fallout in ttcn3 tests... maybe we do rely on "stats reset" to also reset stat_items in some tests? maybe run a few bigger testsuites with this patch applied?

https://gerrit.osmocom.org/c/libosmocore/+/25214/1/src/vty/stats_vty.c 
File src/vty/stats_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/25214/1/src/vty/stats_vty.c@a589 
PS1, Line 589: static int reset_osmo_stat_item_group_handler(struct osmo_stat_item_group *statg, void *sctx_)
this function can be removed too, as you remove its only caller


https://gerrit.osmocom.org/c/libosmocore/+/25214/1/src/vty/stats_vty.c@a591 
PS1, Line 591:         osmo_stat_item_group_reset(statg);
log an error in the function if it is used? (or in osmo_stat_item_reset?)



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25214
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If2134768b1076e7af189276c45f2a09a4944303e
Gerrit-Change-Number: 25214
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Aug 2021 15:41:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210820/c4e3c844/attachment.htm>


More information about the gerrit-log mailing list