Change in libosmocore[master]: tests/stats: show how last item sent may be wrong

osmith gerrit-no-reply at lists.osmocom.org
Fri Aug 20 14:04:54 UTC 2021


osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25205 )

Change subject: tests/stats: show how last item sent may be wrong
......................................................................

tests/stats: show how last item sent may be wrong

Extend the test to illustrate the bug described in the related issue,
which will be fixed with the next patch.

Related: OS#5215
Change-Id: I1d26867ac1b837bea6a9754a3203e53c147e7a5f
---
M tests/stats/stats_test.c
M tests/stats/stats_test.err
2 files changed, 12 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/stats/stats_test.c b/tests/stats/stats_test.c
index 15f50d2..6505e66 100644
--- a/tests/stats/stats_test.c
+++ b/tests/stats/stats_test.c
@@ -442,6 +442,16 @@
 	osmo_stats_report();
 	OSMO_ASSERT(send_count == 2);
 
+	fprintf(stderr, "report (group 1, item 1 no update, send last item (!= last max), OS#5215):\n");
+	send_count = 0;
+	osmo_stats_report();
+	OSMO_ASSERT(send_count == 0); /* BUG: should be 2! */
+
+	fprintf(stderr, "report (group 1, item 1 no update, nothing to send):\n");
+	send_count = 0;
+	osmo_stats_report();
+	OSMO_ASSERT(send_count == 0);
+
 	fprintf(stderr, "report (remove statg1, ctrg1):\n");
 	/* force single flush */
 	srep1->force_single_flush = 1;
diff --git a/tests/stats/stats_test.err b/tests/stats/stats_test.err
index 69104d9..08c2cbc 100644
--- a/tests/stats/stats_test.err
+++ b/tests/stats/stats_test.err
@@ -115,6 +115,8 @@
 report (group 1, item 1 update twice, check max):
   test2: item p= g=test.one i=1 n=item.a v=20 u=ma
   test1: item p= g=test.one i=1 n=item.a v=20 u=ma
+report (group 1, item 1 no update, send last item (!= last max), OS#5215):
+report (group 1, item 1 no update, nothing to send):
 report (remove statg1, ctrg1):
   test2: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0
   test1: counter p= g=ctr-test:one_dot i=3 n=ctr:a v=0 d=0

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25205
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1d26867ac1b837bea6a9754a3203e53c147e7a5f
Gerrit-Change-Number: 25205
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210820/b44e96f2/attachment.htm>


More information about the gerrit-log mailing list