Change in libosmocore[master]: tests: add 'make update_exp' target

dexter gerrit-no-reply at lists.osmocom.org
Fri Aug 20 08:31:33 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25207 )

Change subject: tests: add 'make update_exp' target
......................................................................


Patch Set 1: Code-Review+2

> Patch Set 1:
> 
> > Patch Set 1: Code-Review+1
> > 
> > looks like something that is easy to forget to update when adding new tests.
> 
> Right, but it's very useful to update test output. I think Neels added something similar in osmo-hlr.
> 
> If it does get forgotten to update, it should not be a big problem since it's just a convenience function and will get noticed once somebody tries to use it to update the test output for the test that was forgotten. So they can just fix it up then.

You are right and its used by developers only anyway.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25207
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7247fffde82ab9195ae03b2ccb30d7aa47543113
Gerrit-Change-Number: 25207
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Aug 2021 08:31:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210820/46b8957e/attachment.htm>


More information about the gerrit-log mailing list