Change in osmo-mgw[master]: mgcp_client_vty: fix docstrings for mgw-pool

laforge gerrit-no-reply at lists.osmocom.org
Thu Aug 19 14:47:35 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25209 )

Change subject: mgcp_client_vty: fix docstrings for mgw-pool
......................................................................

mgcp_client_vty: fix docstrings for mgw-pool

The interactive VTY commands to reconnect, block and unblock MGCP
clients from the pool are not displayed properly because the doctring
lacks the reference number.

Change-Id: I0367c33f5cd02978e3f14b1343dfaafa1ea62370
Related: SYS#5091
---
M src/libosmo-mgcp-client/mgcp_client_vty.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/libosmo-mgcp-client/mgcp_client_vty.c b/src/libosmo-mgcp-client/mgcp_client_vty.c
index 7d41ee1..7779e2c 100644
--- a/src/libosmo-mgcp-client/mgcp_client_vty.c
+++ b/src/libosmo-mgcp-client/mgcp_client_vty.c
@@ -404,7 +404,7 @@
 
 DEFUN_ATTR(mgw_reconnect, mgw_reconnect_cmd,
 	   "mgw <0-255> reconnect",
-	   MGW_STR "reconfigure and reconnect MGCP client\n", CMD_ATTR_IMMEDIATE)
+	   MGW_STR "reference number\n" "reconfigure and reconnect MGCP client\n", CMD_ATTR_IMMEDIATE)
 {
 	int nr = atoi(argv[0]);
 	struct mgcp_client_pool_member *pool_member = NULL;
@@ -454,7 +454,7 @@
 
 DEFUN_ATTR(mgw_block, mgw_block_cmd,
 	   "mgw <0-255> block",
-	   MGW_STR "block MGCP client so that it won't be used for new calls\n", CMD_ATTR_IMMEDIATE)
+	   MGW_STR "reference number\n" "block MGCP client so that it won't be used for new calls\n", CMD_ATTR_IMMEDIATE)
 {
 	int nr = atoi(argv[0]);
 	struct mgcp_client_pool_member *pool_member = NULL;
@@ -471,7 +471,7 @@
 
 DEFUN_ATTR(mgw_unblock, mgw_unblock_cmd,
 	   "mgw <0-255> unblock",
-	   MGW_STR "unblock MGCP client so that it will be available for new calls\n", CMD_ATTR_IMMEDIATE)
+	   MGW_STR "reference number\n" "unblock MGCP client so that it will be available for new calls\n", CMD_ATTR_IMMEDIATE)
 {
 	int nr = atoi(argv[0]);
 	struct mgcp_client_pool_member *pool_member = NULL;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25209
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I0367c33f5cd02978e3f14b1343dfaafa1ea62370
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210819/45b21b43/attachment.htm>


More information about the gerrit-log mailing list