Change in osmo-bts[master]: add VTY transcript testing

dexter gerrit-no-reply at lists.osmocom.org
Thu Aug 19 10:20:27 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25198 )

Change subject: add VTY transcript testing
......................................................................


Patch Set 3: Verified+1 Code-Review+1

(1 comment)

I think this is a good Idea. Maybe also the manual might need an update.

https://gerrit.osmocom.org/c/osmo-bts/+/25198/3/src/common/main.c 
File src/common/main.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25198/3/src/common/main.c@85 
PS3, Line 85: 		"       --vty-test		VTY test mode. Do not connect to BSC, do not exit.\n"
I would make it even more generic like --vty-only. This feature is not only valuable for testing but also for setting up an initial BTS configuration via VTY. Some folks prefer to do it via telnet, rather then via manual editing.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25198
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I730daf548a3a9bb116aa8b6d5772ca9af0ada08f
Gerrit-Change-Number: 25198
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 19 Aug 2021 10:20:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210819/aa8c419e/attachment.htm>


More information about the gerrit-log mailing list